contributing to dnd5e | Foundry VTT | Page 1

deep pivot Nov 20, 2023, 12:59 AM

#

alright @leaden wagon once you've got git --version returning not an error, contributing requires a few setup steps in vscode

run git config user.name yourUserName
run git config user.email youremail

#

Specifically the ones associated with your github account

leaden wagon Nov 20, 2023, 1:00 AM

#

so,
git version 2.42.0.windows.2

and when I run that first line with Zanderaf as username it pops fatal: not in a git directory out

deep pivot Nov 20, 2023, 1:00 AM

#

hmmmm

#

what do you have in this tab

leaden wagon Nov 20, 2023, 1:01 AM

#

no current git repo

#

gotta initalize one

#

ive got a fork of the system if that helps

deep pivot Nov 20, 2023, 1:01 AM

#

How did you clone the repository?

leaden wagon Nov 20, 2023, 1:01 AM

#

from a fork

deep pivot Nov 20, 2023, 1:02 AM

#

By clone I mean instantiate this dnd5e folder

leaden wagon Nov 20, 2023, 1:03 AM

#

Ah, what I did was basically make a fork of FoundryVtt/dnd5e and download it off the fork

deep pivot Nov 20, 2023, 1:03 AM

#

Yeah the fork is good

#

but you specifically need to clone the repository

#

that will make sure you get all the relevant files, including the .git info

leaden wagon Nov 20, 2023, 1:04 AM

#

ah gotcha

#

so put that into git?

deep pivot Nov 20, 2023, 1:04 AM

#

Yeah, you basically need to re-download the dnd5e folder

#

I gtg tho

#

hopefully this gets you closer

leaden wagon Nov 20, 2023, 1:05 AM

#

np ^^ and thanks for the help!

deep pivot Nov 20, 2023, 1:05 AM

#

tl;dr you need to make a branch in your fork and then make changes on that, from there you can file a pull request to get your changes merged into the main repository

runic tusk Nov 20, 2023, 8:27 AM

#

leaden wagon np ^^ and thanks for the help!

What step are you at?

leaden wagon Nov 20, 2023, 11:06 AM

#

runic tusk What step are you at?

Just got home from work, not sure how to exactly clone the repo, think I managed to do it via the Git GUI last night but was too tired to remember

#

should I be doing it this way?

runic tusk Nov 20, 2023, 11:10 AM

#

nah just git bash instead, much easier

#

git clone LinkGoesHere

#

also you want it in your systems folder so you can open it in foundry

leaden wagon Nov 20, 2023, 11:11 AM

#

where does it normally clone to?

runic tusk Nov 20, 2023, 11:11 AM

#

Where you decide

leaden wagon Nov 20, 2023, 11:13 AM

#

got it, clone repo is in my systems folder,

#

so open with vscode and do the things I was doing before with chaos?

runic tusk Nov 20, 2023, 11:14 AM

#

open the repo with vscode, then open a terminal

#

(you can do that in vscode)

leaden wagon Nov 20, 2023, 11:14 AM

#

got it

runic tusk Nov 20, 2023, 11:15 AM

#

double check but I think the command is npm run build:db

leaden wagon Nov 20, 2023, 11:16 AM

#

i dont need to do npm ci on this do i?

#

or should that be a start

runic tusk Nov 20, 2023, 11:17 AM

#

naw

leaden wagon Nov 20, 2023, 11:18 AM

#


> build:db
> node ./utils/packs.mjs package pack --nedb

node:internal/errors:497
    ErrorCaptureStackTrace(err);
    ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'nedb-promises' imported from C:\Users\milic\AppData\Local\FoundryVTT\Data\systems\dnd5e\utils\packs.mjs
    at new NodeError (node:internal/errors:406:5)
    at packageResolve (node:internal/modules/esm/resolve:789:9)
    at moduleResolve (node:internal/modules/esm/resolve:838:20)
    at defaultResolve (node:internal/modules/esm/resolve:1043:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:228:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}

Node.js v20.9.0

runic tusk Nov 20, 2023, 11:18 AM

#

might need to do npm install

leaden wagon Nov 20, 2023, 11:19 AM

#

got it, build:db worked

runic tusk Nov 20, 2023, 11:20 AM

#

cool, now shut down vscode, boot up foundry, do your edits, shut down foundry, run the command to unpack back to json files

#

then create a new branch (on your fork), push the json files to that branch, and if it all seems right, make a PR

leaden wagon Nov 20, 2023, 11:21 AM

#

thank you for the help!

leaden wagon Nov 20, 2023, 11:57 AM

#

so I ran npm run build:json
is it suppose to say that all these other files have been modified or was that just it being built from db files

runic tusk Nov 20, 2023, 11:58 AM

#

That sems normal

#

You don't want to commit the db files though

#

Only any json files that have received changes

leaden wagon Nov 20, 2023, 11:59 AM

#

they still all look to be db files, did I not convert anything in the end with the build:json command?

runic tusk Nov 20, 2023, 11:59 AM

#

Look in that src folder

leaden wagon Nov 20, 2023, 12:00 PM

#

got it, there it is,

#

only touched the classes and subclass items and their advancements, so just the 2 folders?

#

or should I just get the ones I fully changed since I didnt touch monk etc

runic tusk Nov 20, 2023, 12:02 PM

#

I'm wondering why it says you have 2k+ changes files

#

Is it saying every json file has gotten a change?

leaden wagon Nov 20, 2023, 12:03 PM

#

it says I have backgrounds modified but I never touched them?

runic tusk Nov 20, 2023, 12:03 PM

#

Check the diffs 🙂

leaden wagon Nov 20, 2023, 12:03 PM

#

how would I do that again?

runic tusk Nov 20, 2023, 12:04 PM

#

Click the branch icon (where it says '2k+'), then select a changed file, what's it saying?

leaden wagon Nov 20, 2023, 12:04 PM

#

got it

#

all looks to be identical acolyte wise?

runic tusk Nov 20, 2023, 12:05 PM

#

Yeah it would be pretty clear

#

git's just confused lol

#

Submit the jsons of items you actually touched

#

Though I think you can just commit them all, and github will do a proper diff

#

Try that if you dare lol

leaden wagon Nov 20, 2023, 12:08 PM

#

do i just select them and then commit?

runic tusk Nov 20, 2023, 12:10 PM

#

yah, hit that '+'

#

(google tells me the diff for 2k+ files is due to line endings, so nothing to be concerned about)

leaden wagon Nov 20, 2023, 12:11 PM

#

got it, and its been +'ed, so now what?

runic tusk Nov 20, 2023, 12:12 PM

#

Well undo that, you're not on a new branch 🙂

leaden wagon Nov 20, 2023, 12:12 PM

#

wheres the undo button

runic tusk Nov 20, 2023, 12:13 PM

#

did you stage, or did you also commit?

leaden wagon Nov 20, 2023, 12:13 PM

#

just stage

runic tusk Nov 20, 2023, 12:13 PM

#

ok no problem then

#

Click 'master' down in the bottom left, make new branch

#

You should be safe to just revert all changes to files you don't care about for this PR, makes vscode a bit easier to work with

leaden wagon Nov 20, 2023, 12:15 PM

#

ah question, when I clicked stage changes for those selcted files, theyre gone now

#

or atleast

#

i cant find them

runic tusk Nov 20, 2023, 12:16 PM

#

sure theyre not just in a dropdown above 'Changes'?

leaden wagon Nov 20, 2023, 12:16 PM

#

#

just the changes folder visible here

runic tusk Nov 20, 2023, 12:17 PM

#

looks like you committed. 🙂

leaden wagon Nov 20, 2023, 12:17 PM

#

damn

runic tusk Nov 20, 2023, 12:17 PM

#

did you commit on the master or new branch?

leaden wagon Nov 20, 2023, 12:17 PM

#

it was before the new branch, so yea master Id assume

#

this mean a restart?

runic tusk Nov 20, 2023, 12:18 PM

#

easy fix, just go to master and find 'undo last commit'

#

It's in the '...' menu

leaden wagon Nov 20, 2023, 12:19 PM

#

got it, theres 2 folders now, staged changes and changes, staged changes has the files

#

should i just unstage everything?

runic tusk Nov 20, 2023, 12:21 PM

#

Nah, just swap to your proper branch now

leaden wagon Nov 20, 2023, 12:23 PM

#

where would I go to do that?

runic tusk Nov 20, 2023, 12:23 PM

#

Bottom left if you aren't on 'redundantfeatures' already

leaden wagon Nov 20, 2023, 12:23 PM

#

already am

runic tusk Nov 20, 2023, 12:23 PM

#

then you're gucci: commit

leaden wagon Nov 20, 2023, 12:24 PM

#

this button up top?

#

the checkmark*

runic tusk Nov 20, 2023, 12:25 PM

#

Alternatively 'Commit Staged' in the menu

leaden wagon Nov 20, 2023, 12:25 PM

#

didnt configure username and email in git dammit

#

can i do that in the vscode terminal?

runic tusk Nov 20, 2023, 12:25 PM

#

sure!

leaden wagon Nov 20, 2023, 12:29 PM

#

done and commited

#

where exactly did this go then? original clone was a fork

runic tusk Nov 20, 2023, 12:30 PM

#

If it is pushed to your branch on github, then you should now be able to make a PR.

leaden wagon Nov 20, 2023, 12:30 PM

#

i gotta publish branch at the bottom of the screen then?

runic tusk Nov 20, 2023, 12:30 PM

#

Yes

leaden wagon Nov 20, 2023, 12:32 PM

#

does this layout look right?

runic tusk Nov 20, 2023, 12:32 PM

#

Something's definitely not right here

leaden wagon Nov 20, 2023, 12:32 PM

#

oh god, itheres

#

a ton of stuff

#

yea somethings wrong

#

I've got a feeling I should maybe start over on a fresh slate, just figure out what went wrong

runic tusk Nov 20, 2023, 12:34 PM

#

I am not seeing your commit of any json files?

leaden wagon Nov 20, 2023, 12:39 PM

#

ok, think I fixed it?

#

#

only 13 files changed now

runic tusk Nov 20, 2023, 12:43 PM

#

thinkcat

#

Why is it saying 2.3.1

leaden wagon Nov 20, 2023, 12:45 PM

#

where exactly?

runic tusk Nov 20, 2023, 12:46 PM

#

In your json files

leaden wagon Nov 20, 2023, 12:47 PM

#

im... not exactly sure? I forked the repo off the main D&D5e one, it for sure wasnt 2.3.1 when i was editing

#

wouldnt have been able to add slippery mind for rogue otherwise without the update?

runic tusk Nov 20, 2023, 12:49 PM

#

Maybe you should rebase to the 2.4.x branch rather than master

leaden wagon Nov 20, 2023, 12:51 PM

#

got it, got a description typed up of the changes, should I got ahead and post it to 2.4x?

runic tusk Nov 20, 2023, 12:52 PM

#

What could go wrong?

leaden wagon Nov 20, 2023, 12:53 PM

#

welp I did it

#

hopefully it isnt too atrocious

runic tusk Nov 20, 2023, 12:53 PM

#

This is the weird part. It should just be saying '1 commit ahead'

leaden wagon Nov 20, 2023, 12:54 PM

#

it feels like I got a 2.3 version for some reason?

runic tusk Nov 20, 2023, 12:54 PM

#

Somehow?

leaden wagon Nov 20, 2023, 12:54 PM

#

I've got no idea what lines got twisted in the work though

runic tusk Nov 20, 2023, 12:57 PM

#

Well Kim or Arbron will let you know if it's messed up 😄

leaden wagon Nov 20, 2023, 1:02 PM

#

im hoping i wont thrown against the wall for trying 😂

#

but thanks for the help! Sorry It was a bit slow, glad I finally know how all of this works for a start

runic tusk Nov 20, 2023, 1:03 PM

#

Could always try again - you can checkout the remote branch (2.4.x) on the actual repo and use that as a base

leaden wagon Nov 20, 2023, 1:03 PM

#

gotcha, if it does turn out wonky, thats gonna be what I try next

runic tusk Nov 20, 2023, 4:46 PM

#

a'ight @leaden wagon you're up, new issue, new PR

leaden wagon Nov 20, 2023, 4:49 PM

#

gotcha

runic tusk Nov 20, 2023, 4:50 PM

#

And welcome to the 'wontfix' club

leaden wagon Nov 20, 2023, 4:55 PM

#

im still forking over the master branch right?

#

wanted to start from the beginning

runic tusk Nov 20, 2023, 4:55 PM

#

OK, so, when you change branch, you should be able to see the 2.4.x branch

#

Try using that instead of master, still dunno why that gave you 2.3.1 code.

leaden wagon Nov 20, 2023, 4:57 PM

#

so switch branch, and then fork, got it

runic tusk Nov 20, 2023, 4:57 PM

#

Nah, you can do all this within vscode

#

It should show as upstream/2.4.x

#

Swap to that, and just to be sure, check one of the jsons and see if they are labeled as 2.4.0

leaden wagon Nov 20, 2023, 5:00 PM

#

how exactly do I do it through vscode?

runic tusk Nov 20, 2023, 5:01 PM

#

Click the branch name (bottom left), it should be producing a long list at the top

#

When you have swapped to that, make a new branch, this should copy it, and then you're good to make any changes.

leaden wagon Nov 20, 2023, 5:16 PM

#

slowly getting the hang of this

#

what about jack of all trades?

#

Im geussin leave it because it affects initiative?

runic tusk Nov 20, 2023, 5:20 PM

#

Check the effect. Does it target flags.dnd5e?

leaden wagon Nov 20, 2023, 5:20 PM

#

ah yup,
flags.dnd5e.jackOfAllTrades

runic tusk Nov 20, 2023, 5:20 PM

#

Then leave it.

#

Advancements can't affect special traits, so all that target those should just be left.

leaden wagon Nov 20, 2023, 5:21 PM

#

all im really seeing is life domain cleric giving Heavy armor via AE

#

cant seem to find much else

runic tusk Nov 20, 2023, 5:22 PM

#

Druidic, thieves cant?

leaden wagon Nov 20, 2023, 5:22 PM

#

druidic and theives cant dont have ae's by the looks of it

runic tusk Nov 20, 2023, 5:22 PM

#

🤔

leaden wagon Nov 20, 2023, 5:23 PM

#

honestly just life domain 🤔

runic tusk Nov 20, 2023, 5:23 PM

#

huh, druidic did have its AE removed.

#

Was my dev world outdated? 😂

#

Druid even has the language advancement too

#

Lemme do a quick scan for items that have effects

#

[
    "Ki: Empty Body",
    "Invocation: Devil's Sight",
    "Bonus Proficiency (Life Domain)",
    "Ki: Diamond Soul",
    "Fighting Style: Archery",
    "Fiendish Resilience",
    "Dragon Ancestor",
    "Improved Divine Smite",
    "Fast Movement",
    "Draconic Resilience",
    "Feral Instinct",
    "Nature's Ward",
    "Unarmored Defense (Barbarian)",
    "Unarmored Defense (Monk)",
    "Slippery Mind",
    "Rage",
    "Reliable Talent",
    "Purity of Body",
    "Divine Health",
    "Jack of All Trades",
    "Fighting Style: Dueling",
    "Hide in Plain Sight",
    "Unarmored Movement",
    "Fighting Style: Defense"
]

#

So evidently not a lot, Arbron must have nuked some

leaden wagon Nov 20, 2023, 5:27 PM

#

Divine Health, already added through traits, so that ae can go,

runic tusk Nov 20, 2023, 5:28 PM

#

Slippery Mind?

leaden wagon Nov 20, 2023, 5:28 PM

#

right, that one needs a full trait advancement

#

remove the ae / add it in then?

runic tusk Nov 20, 2023, 5:29 PM

#

fo sho

leaden wagon Nov 20, 2023, 5:31 PM

#

just learning that monks become immune to poison damage through this 🤔

#

dragon ancestor is another one, providing a language instead of trait

#

and I think thats everything

Life Domain Cleric:

Removed AE granting heavy armor proficiency
Rogue:
Added Slippery Mind Trait Advancement (Wisdom Save Prof)
Paladin:
Removed AE granting Divine Health effect
Monk:
Removed AE granting Purity of Body effect
Sorcerer:
Removed AE granting Draconic Language effect

#

everything else seems vital to working

#

ok, few minor hiccups but ive built the json files

runic tusk Nov 20, 2023, 5:51 PM

#

2k+ changes

leaden wagon Nov 20, 2023, 5:51 PM

#

so, before I do anything, what exactly does stage changes mean?

runic tusk Nov 20, 2023, 5:51 PM

#

'These are the files I want to commit'

#

You 'put them on the stage'

leaden wagon Nov 20, 2023, 5:51 PM

#

got it, and im making a new branch before I do that

#

probably a stupid question, but if I cloned the repo directly from the main foundry/dnd5e repo, did I mess up

runic tusk Nov 20, 2023, 5:57 PM

#

Well I would have cloned my own fork

#

If this makes you unable to publish a branch, you should still be able to add your fork as a remote, then publish it there.

leaden wagon Nov 20, 2023, 5:59 PM

#

got it

leaden wagon Nov 20, 2023, 6:21 PM

#

man im so damn confused. So i rebuilt the json, make my own branch, and go to select the files to stage, and I stage them by clicking this plus sign

#

but then they dissapear, and when I click commit, it says nothing staged to commit?

runic tusk Nov 20, 2023, 6:23 PM

#

Record it? This sounds super weird

leaden wagon Nov 20, 2023, 6:28 PM

#

unless im doing something terribly wrong

runic tusk Nov 20, 2023, 6:30 PM

#

thinkcat

#

What if you scroll up to the top?

leaden wagon Nov 20, 2023, 6:31 PM

#

theres sometimes a staged changes folder, but i dont remember the last time it was there

#

its always been missing 🤔

runic tusk Nov 20, 2023, 6:32 PM

#

Should appear when you actually stage stuff

leaden wagon Nov 20, 2023, 6:32 PM

#

just staged warlock and sorc, and nothin,

runic tusk Nov 20, 2023, 6:33 PM

#

Reboot vscode

#

Actually, I'm not seeing any changes in those files in your recording?

#

Did you unpack after editing them in foundry?

leaden wagon Nov 20, 2023, 6:34 PM

#

built the db before going into foundry, then built json after I was done in dev world stuff

runic tusk Nov 20, 2023, 6:34 PM

#

Where are the changes then? thinkcat

#

Oh this is Fighter, you didnt touch that

#

Check the files you actually did touch

leaden wagon Nov 20, 2023, 6:36 PM

#

part of the problem, once I stage them I cant find them anywhere

#

theres no staged folder to see em in

#

and unstaging doesnt seem to do much

#

i feel like im working with haunted software

runic tusk Nov 20, 2023, 6:37 PM

#

Show me Life Domain cleric

#

Rather the item from which you removed the effect, I mean

#

It should show a bunch of changed lines.

leaden wagon Nov 20, 2023, 6:40 PM

#

in the source control? Was one of the ones I staged that's currently missing

runic tusk Nov 20, 2023, 6:41 PM

#

OK, stage all that you changed, then revert all changes on all other files. What's it look like, then?

leaden wagon Nov 20, 2023, 6:43 PM

#

ah damn I've gotta go for today, need to pick up family- thanks for the extra help, ill see if I cant get back to it later tonight

runic tusk Nov 21, 2023, 7:10 PM

#

You still need help here?

leaden wagon Nov 21, 2023, 8:02 PM

#

Sorry, been at a relatives house since last night watching their dog, dont have my laptop on me try this thing again until tommorrow afternoon

#

got a decent grasp on what I'm doing, just gotta figure out where the staged stuff dissapear to

runic tusk Nov 21, 2023, 8:08 PM

#

You were editing the items in the compendiums, right? 🙂

leaden wagon Nov 21, 2023, 8:18 PM

#

yea, unlocked em to edit

leaden wagon Dec 1, 2023, 1:15 PM

#

hey zhell- about the CLI thing- what exactly do I have to do different? Spent most of yesterday redo'ing all those installs Chaos worked me through on my laptop to keep it seperate from my PC, and I'm just now getting to trying to figure it out

#

i've cloned the repo through vscode's console via my own fork and done nothing with it-

runic tusk Dec 1, 2023, 1:27 PM

#

Checked the readme on the CLI tool?

leaden wagon Dec 1, 2023, 1:35 PM

#

yea, been doing that- getting an error whenever I checked the version with fvtt --version

#

fvtt : File C:\Users\myname\AppData\Roaming\npm\fvtt.ps1 cannot be loaded because running scripts is disabled on this system. For more information, see about_Execution_Policies at https:/go.microsoft.com/fwlink/?LinkID=135170.
At line:1 char:1

fvtt --version

  + CategoryInfo          : SecurityError: (:) [], PSSecurityException
  + FullyQualifiedErrorId : UnauthorizedAccess

runic tusk Dec 1, 2023, 1:39 PM

#

Ah windows access issue

#

I remember getting this, and the fix being easy.

#

Something like this: https://www.sharepointdiary.com/2014/03/fix-for-powershell-script-cannot-be-loaded-because-running-scripts-is-disabled-on-this-system.html

#

As for actually converting between json, nedb, ldb, and back to json, it should go something like this on v11:

fresh system, no db files, no ldb files, only jsons exist.
use CLI to convert to ldb
edit in foundry
convert ldb to json
convert json to nedb
nedb back to json

Hope @daring swift won't mind a ping to tell me if I've lost the cheese off my crackers, but he knows more than I on this and I remember there being something about the json files having different names when generated from the CLI tool (eg barbarian-<item id>.json vs barbarian.json)

leaden wagon Dec 1, 2023, 2:09 PM

#

ok, managed to fix it- no longer throwing errors, dog got loose and distracted me a bunch, so to turn it from the fresh clone to use cli to unpack, is it

cd foundryvtt-cli
npm install
npm run build
npm link

#

this part of the readme?

#

wait, mmm

runic tusk Dec 1, 2023, 2:10 PM

#

In your local repo you should only have json files currently. 🙂

leaden wagon Dec 1, 2023, 2:11 PM

#

yea, looks like I do

runic tusk Dec 1, 2023, 2:11 PM

#

You want to be on the 2.4.x branch

leaden wagon Dec 1, 2023, 2:13 PM

#

got it, switched over rn

runic tusk Dec 1, 2023, 2:15 PM

#

and then you'll want to build the db files

#

(using the cli)

#

and probably fvtt package workon "dnd5e" --type "System"

leaden wagon Dec 1, 2023, 2:18 PM

#

so ```fvtt package unpack "compendiumName"

#

to just unpack the specific ones I need?

runic tusk Dec 1, 2023, 2:18 PM

#

json files are the "unpacked" state

leaden wagon Dec 1, 2023, 2:19 PM

#

ah, gotcha- how exactly would building the db files go then? kind of blanking on reading the readme file,- packing instead of unpacking then?

runic tusk Dec 1, 2023, 2:20 PM

#

Yeah you want to build the v11 LevelDB files

#

should hopefully be on the cli tool's page somewhere

#

I'm a bit on and off rn due to work

leaden wagon Dec 1, 2023, 2:21 PM

#

its all fine- bit scattered rn too trying to do this while dog-sitting for my nephew

runic tusk Dec 1, 2023, 3:12 PM

#

leaden wagon its all fine- bit scattered rn too trying to do this while dog-sitting for my ne...

ok im back, where we at?

leaden wagon Dec 1, 2023, 3:13 PM

#

Currently trying to wrangle dogs from eating the table

runic tusk Dec 1, 2023, 3:13 PM

#

hm i dont think there's a cli command for that

daring swift Dec 1, 2023, 3:19 PM

#

Just to be clear, if you are making any changes to the compendiums for the system right now you’ll have to do that in Foundry v10, not v11, otherwise you’ll end up with backwards incompatible changes since the system still supports v10

#

In which case you can use our build scripts for extracting/compiling the packs

runic tusk Dec 1, 2023, 3:21 PM

#

Which backwards incompatible changes? 🤔

daring swift Dec 1, 2023, 3:25 PM

#

I know there were some changes to the active effects data structure, not sure if there was anything else

runic tusk Dec 1, 2023, 3:27 PM

#

This should be fine though, there are only effects to delete.

#

Though it would be easier to do on v10.

leaden wagon Dec 1, 2023, 5:44 PM

#

I'm starting to get lost in most of this, along with babysitting dogs 🤔

#

adhd is not doing me any favors trying to learn most of this

runic tusk Dec 1, 2023, 5:47 PM

#

Installing v10 would simplify it greatly.

leaden wagon Dec 1, 2023, 5:47 PM

#

I think I might give up the reins on this for now, and leave it for someone more focused to handle it- and try to get a grasp with it another weekend- got some notes on everything you and chaos taught me zhell, so thanks for all that help- think its slightly overwhelming for me at the moment with everything goin on

#

ill give it one more try rn

#

would I need the CLI stuff?

#

or just do it the way I've been trying

runic tusk Dec 1, 2023, 5:47 PM

#

You already did it correctly - was just my bad cus I forgot it was different on v11. What you did the very first time will work on v10.

#

Clean repo, 2.4.x, pack into db, make edits, unpack
(on v10)

leaden wagon Dec 1, 2023, 5:48 PM

#

got it, I'll get to downloading it on this wifi then

#

ho boi, 25 minutes sweaty

leaden wagon Dec 1, 2023, 6:17 PM

#

should of maybe asked before, but 10.312 right?

#

the last v10 build?

runic tusk Dec 1, 2023, 6:17 PM

#

Yes 🙂

#

I do not think it matters, however - as long as it is not older than 10.303, the absolute minimum

leaden wagon Dec 1, 2023, 6:19 PM

#

few more minutes and should be good to start workin

#

ok, done, opened up, installed npm, build the db's, deleted the AEs from:
Life Cleric Armor Prof
Divine Health from Paladin
Purity of Body from Monk
Slippery Mind from Rogue
Draconic Language from Draconice Sorc

runic tusk Dec 1, 2023, 6:35 PM

#

Double check that they do not also need an advancement

#

I do not belive Rogue has one for Slippery Mind

#

or the sorcerer?

leaden wagon Dec 1, 2023, 6:36 PM

#

should I add in any missing ones as well?

#

advancement wise?

#

or do that in a different PR

runic tusk Dec 1, 2023, 6:36 PM

#

That would be the correct thing to do 🙂

leaden wagon Dec 1, 2023, 6:36 PM

#

got it

#

in the case of slippery mind, should the advancement text just say Wisdom, or should I copy paste in the actual text from the feature? aka

By 15th level, you have acquired greater mental strength. You gain proficiency in Wisdom saving throws.

#

not sure how its regularly done

runic tusk Dec 1, 2023, 6:40 PM

#

I think 'Druidic' is a good example to look at

leaden wagon Dec 1, 2023, 6:41 PM

#

got it, just says druidic

runic tusk Dec 1, 2023, 6:41 PM

#

Straight and to the point.

leaden wagon Dec 1, 2023, 6:43 PM

#

and then theres monk, its always monk

runic tusk Dec 1, 2023, 6:43 PM

#

Heh.

#

Go with the full one then, drop the "By 15th level"

leaden wagon Dec 1, 2023, 6:48 PM

#

Just gonna keep a list here-

Active Effects Removed in place of Advancement

Life Domain Cleric: Bonus Proficiency in Heavy Armor
Monk: Purity of Body Resistance and Condition Immunity
Paladin: Divine Health Immunity to Disease
Rogue: Slippery Mind granting Wisdom Saving Throw Proficiency
Draconic Sorcerer: Dragon Language granted by Dragon Ancestor

Advancement Additions:

Added trait advancement for Rogue at level 15 to grant Wisdom save proficiency.
Added language trait advancement for Draconic Bloodline Sorcerer to grant Draconic as a language

#

umm, something feels wrong?

#

was there anyone that added item choice advancements to the hunter subclass? or did I pull the wrong system folder

runic tusk Dec 1, 2023, 6:55 PM

#

Lemme take a look

#

Yes, the hunter subclass has Item Choice advancements

leaden wagon Dec 1, 2023, 6:56 PM

#

got it, remember doing it the first time like 2 weeks ago when the original thing was labeled wont change

#

geuss it was built in

runic tusk Dec 1, 2023, 6:56 PM

#

Wrong branch at the time I guess 🙂

leaden wagon Dec 1, 2023, 6:56 PM

#

yea, that too

#

I think thats everything? paladin monk and cleric all have their AE stuff already in trait advancements, just dragon sorc and rogue were missing theirs

runic tusk Dec 1, 2023, 7:00 PM

#

and then ya close foundry, and unpack to jsons

#

and hopefully it actually shows changes this time. rainberk

leaden wagon Dec 1, 2023, 7:00 PM

#

npm run build:json right?

runic tusk Dec 1, 2023, 7:01 PM

#

Yes

leaden wagon Dec 1, 2023, 7:03 PM

#

#

progress!

#

the first time I think ive ever seen red mean I've done something (i hope) right

runic tusk Dec 1, 2023, 7:04 PM

#

Remember that you only want to commit the json files you changed. Not the rest, and not the db files

leaden wagon Dec 1, 2023, 7:05 PM

#

i may have done a stupid- new branch was suppose to be opened before I made changes right?

#

or is there a way to salvage it?

runic tusk Dec 1, 2023, 7:06 PM

#

what branch are you on locally?

leaden wagon Dec 1, 2023, 7:06 PM

#

2.4x

runic tusk Dec 1, 2023, 7:06 PM

#

have you commited?

leaden wagon Dec 1, 2023, 7:07 PM

#

havnt commited or staged anything

runic tusk Dec 1, 2023, 7:07 PM

#

Then just make a new branch now 🙂

leaden wagon Dec 1, 2023, 7:08 PM

#

heres hoping the staging stuff doesnt dissapear into the void

daring swift Dec 1, 2023, 7:09 PM

#

runic tusk Remember that you only want to commit the json files you changed. Not the rest, ...

You'll still want to commit the .db files

#

Yeah, you can just do git checkout -b new-branch and all your changes will remain

runic tusk Dec 1, 2023, 7:09 PM

#

We didn't get rid of those?

daring swift Dec 1, 2023, 7:09 PM

#

Not quite yet, when we go v11 only we will be

runic tusk Dec 1, 2023, 7:09 PM

#

Huh, I thought they were gonna be in the release action

leaden wagon Dec 1, 2023, 7:13 PM

#

so, all of this I changed- I gotta stage the db files from them too?

runic tusk Dec 1, 2023, 7:14 PM

#

yeah classfeatures.db and classes.db

leaden wagon Dec 1, 2023, 7:14 PM

#

subclasses too im geussing because of Draconic bloodline

runic tusk Dec 1, 2023, 7:14 PM

#

yes

leaden wagon Dec 1, 2023, 7:21 PM

#

uhhh, so... i may have forgotten to change the title

#

still says the high elf thing

#

runic tusk Dec 1, 2023, 7:21 PM

#

lol we'll deal

leaden wagon Dec 1, 2023, 7:21 PM

#

but it looks alright?

runic tusk Dec 1, 2023, 7:21 PM

#

KIm usually squashes stuff

#

Seems to have a merge conflict. What file is it complaining about?

leaden wagon Dec 1, 2023, 7:23 PM

#

packs/classes.db

#

runic tusk Dec 1, 2023, 7:24 PM

#

Not entirely certain we care too much about merge conflicts in the db files, since we can just do a rebuild before a release.

leaden wagon Dec 1, 2023, 7:25 PM

#

that wasnt as bad as I thought- the whole v11 part of it was a mess and a half trying to figure out what was going on

runic tusk Dec 1, 2023, 7:25 PM

#

lol yes

#contributing to dnd5e