pastel tide
Ready for another one, @proud bobcat? I grabbed Rally from the github.
It has displayPool, displayMod, and function findObject(), which aren't used.
It could use the same check for having a token selected.
It also has changes, which is where the AE stuff was being stored and isn't used here.
mod: [{ name: "SR5.", value: limit }], is incomplete/incorrect.
That out of the way...
let combatants = game.combats.get(combat).combatants._source; doesn't appear to do anything in v10. combatants ends up being length 0.
proud bobcat
Ready for another one, <@204126892951994368>? I grabbed Rally from the github.
...
basically all of the things that came from using IAmTheFirewall as a starting point and not touching what was unused
proud bobcat
`let combatants = game.combats.get(combat).combatants._source;` doesn't appear t...
I love major version differences
pastel tide
basically all of the things that came from using IAmTheFirewall as a starting po...
Yup, I get that. I'm calling it out to be thorough. 🙂
As before, you're welcome to hop in and poke at it directly on my test instance.
proud bobcat
I will be doing that for the v10 specific stuff
pastel tide
(Please... do... it justifies me owning three licenses. 😁 )
proud bobcat
going to make sure it still works on v11 first
going to need to find a new way to figure out which combat is being used since active does not show what I thought it did
pastel tide
Woops... didn't realize you'd logged in.
proud bobcat
all good
pastel tide
I probably just spammed the hell out of the console.
proud bobcat
I can mute or hide what I need to
should I be safe to assume that we only care about combat on the active scene? or is that too much of an assumption... i.e. that doesn't work if players may be on two different scenes
pastel tide
Safe to assume? No, probably not.
Make a requirement/condition? Yes.
proud bobcat
Well I was thinking of gms that put different floors acorss multiple scenes
although with how combat works in foundry that should keep them from doing that
pastel tide
Yeah... Foundry itself doesn't deal well/cleanly with unlinked combat trackers, so I wouldn't cater to people inflicting that particular headache on themselves.
I sure as hell don't do it. In fact, Multilevel Tokens and it's cloning feature is one of the reasons I haven't moved to v11. I don't have the time to fight with Ripper's modules to get multiple levels into one scene, so I use MLT.
proud bobcat
oh I am trying to learn Ripper's stuff
will look for active scene, not worry about if they are currently looking at that scene and reference combat from that one
pastel tide
I don't have the time to do all the image editing prep work involved in making Levels work.
"Rally" Macro
proud bobcat
who should I use for the face on the rally tests
well who is the best choice for it
pastel tide
Garbo, the second with a gold border.
Assuming you left my skill change in place. Otherwise, they're all gonna kinda suck. 🙂
pastel tide
It seems to be working Friendly-on-Friendly, but not Hostile-on-Hostile.
proud bobcat
I might see the issue. still has the disposition error
silver mural
@proud bobcat you should never use variables with _ due to them being foundry internals and they can behave unrelaiable
proud bobcat
are you talking about the id variable?
silver mural
combatants should have an actor which either gives the syntehtik or real actor
_source
I didnt look at the code, just the thread
proud bobcat
oh, yea that is leaving. _source is just the source documents used in the object, I noticed it is predictable that way. Guessing internally it is used for easier back tracking if needed
@pastel tide, check the command now on hostile-on-hostile
pastel tide
Yup, that seems to work. Lemme roll on a neutral... though I'm not sure what Mr. Crate has for stats. 🙂
proud bobcat
may need to fake those stats for him
pastel tide
Oh, wait... it's a vehicle. It would be excluded.
Poor Mr. Crate.
Yup, seems to work for neutral-on-neutral, too.
proud bobcat
combatants should have an actor which either gives the syntehtik or real actor
combatants is an object and has an EmbeddedCollection. forEach handles it correctly, but when I first tried I just did a for loop and it was failing without referencing the source field since it had more than just the embeddedcollection in it
proud bobcat
Yup, seems to work for neutral-on-neutral, too.
I updated calibrate to have all of the changes needed for rally. hopefully that will lower how many it needs
pastel tide
Other than what's used for roll itself (skill, attribute, limit), I think it's identical, yeah?
proud bobcat
basically, although if I understood what all it affects, it should work on vehicles/drones as well so I added that on the check
pastel tide
"Rally" & "Calibration" Macros
Hmm... Calibration (KC, p. 37) specifies "personas". Time for some research. IC are specifically personas (same page reference, actually), people obviously are too... lemme see if I can find something definitive either way for drones.
proud bobcat
does it? well that makes things a little more complicated
may leave it to just characters then
pastel tide
Sprites definitely are, they're described on SR5 p. 254 as "personas without devices".
SR5, p. 235
Vehicles/drones are not listed. They're definitely devices, though. Lemme keep poking.
proud bobcat
When a rigger is jumped in it becomes a persona. So will need to check for type sprite
pastel tide
Sure, but that would be on the combat tracker as the Rigger's token, not the vehicle's token.
The vehicle is the device, but the persona is still the rigger.
proud bobcat
true
pastel tide
A'ight... I looked at all 138 instances of the word "persona" in SR5 core. There's nothing that indicates a vehicle/drone can be one.
So... as far as type goes, Vehicle Actors are out, everything else is in.
proud bobcat
spirit would be out as well since they can't access the matrix
pastel tide
True. Critters should stay in, because some people may build things like Vampires as critters.
Personally, I think the Critter Actor type needs to go away completely (now that Character actors can have Critter powers, something they couldn't originally do), but that's another story.
proud bobcat
critter should stay in as I think (would need to double check) but I think animal critters may have a damage track like drones of 6+ instead of the metahuman 8+
pastel tide
Nope; basic "Dog" has B4/W3 and 10/10 boxes like a person would.
proud bobcat
That may have been an optional rule in one of the books
pastel tide
Not that I recall. Could have been an SR4 thing, maybe.
(I miss SR3's fixed-size bars.)
proud bobcat
I have read so many different SR rules that I have to relook them up so often
pastel tide
I'm in a couple of SR5 LCs... if there were an optional rule, at least one of them would have debated it to death.
proud bobcat
ain't that the truth
pastel tide
In any case... I'm done with work for the day and switching machines now. Lemme know when you have a version of Calibration for me to beat the hell out of. 🙂
proud bobcat
it is good for you to mess with
pastel tide
it is good for you to mess with
Seems all good.
proud bobcat
Seems all good.
approve the pr at your leisure
pastel tide
I pushed the button and think I went through the motions, but nothing happened.