Whatever tickles your fancy without | Foundry VTT | Page 1

rigid cradle Oct 4, 2023, 1:56 PM

#

My plan would be to do the following things in any order:

make importer language independent
allow multiple imports into the same sheet
auto-create vehicles/spirits/sprites etc when importing

hazy panther Oct 4, 2023, 2:00 PM

#

Sounds like good improvements. If you have questions, let me know.

You'll find two main issues:

the character importer is the oldest and most hacky code and is JavaScript still while the rest is TypeScript.
character and item importers aren't much connected. There's been some tries to use the item importers from the character importer, but they stopped

deep pewter Oct 4, 2023, 2:06 PM

#

@rigid cradle I've also been working on importer updates. Primarily I've been focusing on doing automatic icon assignment for items, but I also made some related additions to new data flags for imported items that could help with preventing duplicates and/or language independence.

I don't know if that's useful or helpful for you, but I have a draft PR that you can look through if you want to see how I structured it. If you think something else would work better, I'm also happy to re-work my stuff to fit what works for you.

rigid cradle Oct 4, 2023, 2:42 PM

#

I guess the code is written in a node.js ecosystem?

deep pewter Oct 4, 2023, 2:43 PM

#

I do it using the desktop app and VS Code

#

I set it up using the readme-dev instructions and followed this video to get breakpoints and such enabled in VS Code
https://www.youtube.com/watch?v=CQ5UiDud60o

YouTube

Brandon Cole

Debugging FoundryVTT Modules Using Visual Studio Code (VSCode)

A quick guide on how to set up debugging for client side foundryvtt modules in the VSCode editor.

Tag me @vance on the foundry discord if you have any questions.

Sorry about the barking dogs, hard to keep them quiet long enough to record when squirrels are running around the backyard :)

▶ Play video

rigid cradle Oct 4, 2023, 3:26 PM

#

My VSCode does not know the foundry terms. Can I enable that?

deep pewter Oct 4, 2023, 3:37 PM

#

Yeah you can add the correct folder to the workspace to enable it

#

Lemme check what that should be

#

For me it's C:\Program Files\Foundry Virtual Tabletop\resources\app

hazy panther Oct 4, 2023, 3:38 PM

#

If you've followed the readme-dev.md you should have a full TypeScript node.js setup and the (if very outdated) Foundry types should also provide you some auto-completion.

#

The Foundry types are still v9, since the league of foundry devs didn't update further, due to the schema changes in Foundry. Haven't checked for a while if there's been some updates on that or a fully new typing approach I could follow...
...the v9 types do work still though (mostly)

rigid cradle Oct 4, 2023, 3:46 PM

#

Yeah, my npm install was still running... my bad 🙂

rigid cradle Oct 4, 2023, 4:06 PM

#

The part of linking the dev folder to foundry data is not clear

#

underneath your development shadowrun5e system directory. -> in the src folder?

hazy panther Oct 4, 2023, 4:08 PM

#

You're runnig Windows?

rigid cradle Oct 4, 2023, 4:08 PM

#

Yes

hazy panther Oct 4, 2023, 4:09 PM

#

https://github.com/smilligan93/SR5-FoundryVTT/blob/master/README-DEV.md#linking-the-dev-and-system-folder

You have to have the foundryconfig.json in the top most project folder (next to package.json) and the path within to point to your foundry data path. By default that's within your AppData as shown. Then you have to start a cmd with admin permissions and execute gulp link from within your project dir.

#

Option B is using the mklink command from within your cmd, which also doesn't need admin perms. For this you'd have to link your project folder to shadowrun5e within the foundry data ./systems folder. This option doesn't need the foundryconfig.json at all.
Edit: it's the project folder, not the /dist folder within. 🙂

#

For me the foundryconfig.json is

{
  "dataPath": "..\\..\\FoundryData\\v11",
  "linkTargetDirName": "shadowrun5e"
}

My data path is not default, but two folders up from my project dir.

#

After linking you can build (by gulp build or gulp watch) this will craete the /dist folder in your project, which allows the system to run in Foundry.

rigid cradle Oct 4, 2023, 4:20 PM

#

Ah, that just creates a symlink

#

Win10 with PowerShell should be able to do that nativly but I didnt try that yet

hazy panther Oct 4, 2023, 4:21 PM

#

mklink and PowerShell should both do, the gulp link is mostly to catch all OS'es

rigid cradle Oct 4, 2023, 4:23 PM

#

So I linked it, but foundry does not pick it up as the system

hazy panther Oct 4, 2023, 4:23 PM

#

Try restarting foundry

rigid cradle Oct 4, 2023, 4:23 PM

#

I guess I need to build each time I try to test things?

hazy panther Oct 4, 2023, 4:23 PM

#

gulp watch will auto build on all changes. So a typical dev flow would be:

start foundry (I do it via vscode tasks)
gulp watch
dev away

rigid cradle Oct 4, 2023, 4:24 PM

#

That works 👍

hazy panther Oct 4, 2023, 4:25 PM

#

Enjoy coding. 🙂

#

If you have improvements for the Readme-dev.md either let me know or PR them.

rigid cradle Oct 4, 2023, 4:35 PM

#

rigid cradle underneath your development shadowrun5e system directory. -> in the src folder?

This is an improvment 🙂 I dont know if it is OS specific or just language but I would have written something like "in the root directory on the same level as src"

hazy panther Oct 4, 2023, 4:37 PM

#

Likely language, since I'm not a native english speaker.

rigid cradle Oct 5, 2023, 2:04 PM

#

How can I execute the unit tests? This needs some more description in the readMe

rigid cradle Oct 5, 2023, 2:56 PM

#

@hazy panther I refactored the importer and made it language independent. Should I put this already as a pull request? Or are you okay with larger PRs that might take some time to review

hazy panther Oct 5, 2023, 6:53 PM

#

rigid cradle <@240916673970962432> I refactored the importer and made it language independent...

I'll have to look over a few other PRs anyway, since I intend to work on the system this weekend. So long as the current state is tested and working, I'd be alright for it to be a partial step to your longer plan.

rigid cradle Oct 5, 2023, 6:55 PM

#

I tested it manually and let npm: test run

#

Dont know if thats sufficient

#

I made a PR and use this branch as base for the next feature 🙂

hazy panther Oct 5, 2023, 6:56 PM

#

There isn't really a npm testing suite, since the foundry runtime is needed. There is a foundry module called quench and a small testing suite for that (that doesn't cover the importer at all)

#

Also I don't expect other devs to write tests for their features. 🙂 It's mostly for whenever I refactor or rebuild system parts.

rigid cradle Oct 5, 2023, 8:58 PM

#

I want to create an actor programmatically, but I cannot manage to get the right type. Is there a trick to get the predefined types? Currently I just use the string, but that feels kind of wrong

rigid cradle Oct 6, 2023, 11:33 AM

#

https://github.com/smilligan93/SR5-FoundryVTT/projects/19#card-86877843 can someone with dev rights put the vehicle import into "In progress"? Thanks

GitHub

Chummer Import · smilligan93/SR5-FoundryVTT

Shadowrun 5th Edition system for FoundryVTT. Contribute to smilligan93/SR5-FoundryVTT development by creating an account on GitHub.

rigid cradle Oct 6, 2023, 4:28 PM

#

@hazy panther do you already know when you want to have the next release? Due to the bundling I cannot use my changes in the system without you updating the whole system 🙂

#Whatever tickles your fancy without