david aka claudekennilol

[pearl mango]

Is this what the selection window looks like for you?

[nova sinew]

Super huge

[pearl mango]

Yeah that's not right. Let me take a look at the release real quick

It seems like it should be right. I'll have to dig into it later and see what's going wrong. The style sheet definitely isn't being applied for you.

On the plus side, none of that should effect the bonuses actually being applied

Can you tell me how you're hosting your game?

Hosting service? Self hosted?

[nova sinew]

Self

Using client not browser

[pearl mango]

If you go to your foundry data directory is the styles css in the Roll Bonuses pf1 folder?

[nova sinew]

which is browser but still

[nova sinew]

oh god

lemme check

yes

[pearl mango]

Alright, well, I'll dig into it a bit more and see what I find out and let you know later

[nova sinew]

sure, thank you 😄

[pearl mango]

@slim heron I know you've used this new feature. For you, does it look like Nevela's or my screenshots?

@nova sinew Can you try with only my mod enabled and see what that does? If it works can you try "find the culprit"?

[pearl mango]

@nova sinew Do you have a server prefix defined for your foundry server?

Can you open up the mod's module.json, change this line, then restart your world (mabye even close the electron client and re-open it), and see if this fixes it?

[nova sinew]

No, I don't

I'll do it tomorrow since I'm going to bed now. I'll update you here when I do

[next hollow]

That won't change anything.

I mean, if that was a problem, v11 would fail to load the module at all saying it can't find the file.

[next hollow]

@pearl mango You're using nested CSS which is poorly if at all supported by browsers currently, so that will just be invalid CSS for most.

I don't know of Any browser that does support nested CSS right now even.

Ah, browsers started support it ~july this year. Electron client definitely does not support it.

And Firefox added it with 117, 116 is newest it claims is available for me

[slim heron]

I've only used it for weapon types/groups

But I'll test it later

[pearl mango]

Gotcha. I was wondering if that might be it and was gonna test the Electron client tonight. I just updated it to nested css last update because I was starting to have too many styles to keep it manageable separately and didn't want to manage separate style sheets as my mod is still just straight JavaScript without a build pipeline

[nova sinew]

still using v10 here

[next hollow]

Sure, but no-one is having issues in v11, so the module.json content can't be wrong.

[nova sinew]

Oh okay

[next hollow]

I could consider that possibility if david had separate releases for v10 and v11.

[nova sinew]

Well I'll wait for his answer, I'm guessing our time zones are 9 hours apart or something

[pearl mango]

Mana already posted the answer, I'll just have to downgrade the css. You could also connect to your local foundry server with chrome to resolve it for now (probably a good idea to do regardless). You just launch the normal foundry (electron) client normally, but then use chrome to connect to localhost:30000 instead of continuing within the normal foundry client

[nova sinew]

I still have flashbacks from roll20 being super slow with big or complicated maps. I know that the client is using chrome tho so I'm not sure how exactly foundry is superior in this regard

[pearl mango]

The built in foundry client isn't using chrome, it's using electron which is a chromium-based client, but is not chrome

[next hollow]

Close enough tho

[pearl mango]

(it's also not updated on the same cadence as Chrome and is updated only by updating Foundry which is why you're running into this issue)

[pearl mango]

Not close enough for this conversation, otherwise there wouldn't be an issue 😉

[next hollow]

Eh, it's just older version.

[pearl mango]

Yeah I understand they're very closely related, but they're still not the same ¯_(ツ)_/¯

[nova sinew]

But is it different in terms of performance if I use chrome instead?
Because I have 300+ tabs open on 4 windows on chrome all the time so I'll bet it won't help performance

[pearl mango]

Uh, I'm not qualified to answer that 😅 . Best thing I can offer is to try it out and see what happens ¯_(ツ)_/¯. If you're using chrome's somewhat recent option for "hibernating" inactive tabs (I forget the exact term they use--enabled by default) then you'll probably be fine. But it doesn't hurt to try.

But for the issue you're having with my mod, it's only a visual styling issue, none of the actual functionality is broken at all (or at least if it is it's because of something else that isn't related 🙃). So it doesn't harm anything if you want to stick with the default foundry/electron client.

I hope to have the next version of my mod out tonight which will fix it either way.

[pearl mango]

@nova sinew I just released 2.7.0 which should fix the styling issue for you. Let me know if it still doesn't look like my screenshots (also new features for ammo, but you can see that in the release announement)

[pearl mango]

Oh poop I know what I forgot

[nova sinew]

Tried uninstaling, closing foundry, deleting the module's folder and then install

[pearl mango]

Yeah that was my fault. I forgot to update the build script to account for the updated style fixes

[nova sinew]

Oh good I thought my computer is just trolling me again

[pearl mango]

Nope, totally my fault. I just forgot that I needed to update that part by the time I released it

[pearl mango]

Ok try again with 2.7.1

[nova sinew]

Looks good 😄

[pearl mango]

Whew, that's much better. Specifically for that screenshot, if you select the Weapon that the attack comes from, it will silently include any attacks created from that weapon

Though if you don't want to include the weapon itself, selecting the attack will not include the parent weapon

[nova sinew]

Oh that's good to know, I thought the weapon was the item in the inventory and it wouldn't affect the attacks

[pearl mango]

That's a limitation on how PF1 has created attacks from weapons. In the system, if you modify the weapon, then any attacks created from the weapon aren't updated because they're two separate "items".

But there's enough info for me (me as in the mod) to look and go "yup that attack belongs to that weapon" so I made the mod smart enough to apply any bonuses configured to that weapon to also be configured for attacks created from that weapon

[nova sinew]

Yeah I mean, it's pretty smart with weapon focus for sure, I'm looking forward for more compatibility with this mod around weapon focus

I actually say that it doesn't offer help with critical focus which increases crit confirm roll by 4

[pearl mango]

That's because you can do that with the system's built in changes

I'm looking forward for more compatibility with this mod around weapon focus
What do you mean by this?

[nova sinew]

Like, right now, the reads the details in advanced inside Weapon Focus and uses it for other feats like Weapon Specialization right?
There are other feats which could benefit from it

[pearl mango]

Gotcha. If you've got examples I can add them to my todo list

[nova sinew]

https://www.d20pfsrd.com/feats/combat-feats/cornugon-shield-combat/

For example

I'll have to look at all the feats in depth to find stuff that I think your mod would be able to use since there are a lot of feats that rely on weapon focus but don't give bonuses

[pearl mango]

Hm, that specific example is kinda iffy for me to want to include automated-ly. I would want it to automatically require spikes chain proficiency but that's dependant on the specific translation being used. It also has conditional bonuses for fighting defensively that I can't account for.

So I could basically only give a good experience for English users for 1/3 of the total benefit of the buff

[slim heron]

why wont you just add change to AC with dFlags.combatexpertise.on ? 2 : 1 ?

on spiked chain itself

[nova sinew]

Because I wasn't aware I could do that 😄

[nova sinew]

@pearl mango
Is there a way to add more flags to versatile performance? for each perform skill? Sing, Act and dance for example?

[pearl mango]

I don't remember if you can do it on a single ability. You may have to create a second

[nova sinew]

Yeah that's what I want to avoid

[pearl mango]

Why specifically avoid it?

[nova sinew]

Cuz it's gonna be a cluster of the same ability for different skills

[nova sinew]

Trying to test it but I'm not sure I'm doing it correctly

[pearl mango]

That requires a dictionary flag on another buff

[nova sinew]

Wait so it can't be used on feats?

[slim heron]

you have to make dFlag on the Buff with a value. and refer it as dFlags.tagname.nameoflag == value ? value if true : value if false

[nova sinew]

so .on is the name of the flag I assume?

[slim heron]

yep

[nova sinew]

and if I check feats it's either true or false right?

[slim heron]

you mean if you disable them?

[nova sinew]

yeah

like the == value is either true or false

[slim heron]

it is supposed to work in conjunction with something temporal like buff or equipped state. you can disable feats too but its not straightforward for most players.

[nova sinew]

Can I use it to check if a buff is on?

[slim heron]

That's exactly how it works. You make dflag with a value . If it is supposed to be X: 0 when you can just reffer to .value of it. With buff active it will add said value - else 0. if it is somethong different you make ==value ? true : false statement. which will return true if buff is on and false if its not.

[nova sinew]

@dFlag.haste.isActive ? 1 : 2 doesn't work for me tho

[slim heron]

that's not how you use dFlags

first half should be a statement

[slim heron]

This is more like boolean flag

First one will add +2 if rage is on. Second one will add 5 to range if buff is on.

[nova sinew]

OHHHH

I need to actually make flags 🤦🏻‍♂️

Braindead me

[slim heron]

👀

[nova sinew]

I know I know, it's literally in the name

I thought the dFlag is something internal in pf1e

Can the value on the flag be a formula?

Well, I used math instead 😄

[slim heron]

No

[nova sinew]

@pearl mango if I don't want the mod to work on versatile performance, how can I disable it?

Removing the flag readds it

[pearl mango]

There is no option to not use it

[nova sinew]

Can roll bonuses increase dc to targeted spells?

[slim heron]

it can automate Spell focus and elemental Focus.

[pearl mango]

By school, by element type, or all spells for generic DC. Or spell/elemental focus or spell specialization.

But nothing else to target an individual spell

[nova sinew]

So what does the target_spell help me with?

attack and damage rolls?

[pearl mango]

Correct. Target/bonus is its own little subsystem that I haven't added CL/DC into so right now it's only for attack/damage (for anything that has attack/damage rolls)

[nova sinew]

#pf1e message
Though it's not really automation, one could use it for intensify spell this way (I only now realized that I meant intensify spell 🤦🏻‍♂️) Right?

[pearl mango]

Well that's even something else because that's modifying dice totals and not just DC/CL. Also I don't have any way to modify an existing spell but prepare it as a different level for prepared casters