#Abnormal Crits - Possible SBC

1 messages · Page 1 of 1 (latest)

sage flint
#

@crisp crow I'm trying to diagnose on Foundry v11 PF1 9.3 and I'm not seeing this. I imported a stock goblin warrior and forced a crit on both the bow and sword.

If you can still reproduce this, what are your Foundry, PF1, and SBC versions?

#

Abnormal Crits - Possible SBC

crisp crow
#

thats if you want to know.

image.png
#

some of those tokens ( unlinked) still have this behavior.

#

Though i think i accedently edited base actor so it no longer can reproduce it.

sage flint
#

Does it happen to a new import?

crisp crow
#

let me check

#

yep

#

check Shipmate creature

# 

CR 1/2

XP 200

Human expert 1/warrior 1

N Medium humanoid

Init +1; Senses Perception +4

DEFENSE

AC 15, touch 12, flat-footed 13 (+3 armor, +1 Dex, +1 dodge)

hp 11 (2 HD; 1d8+1d10+2)

Fort +3, Ref +1, Will +2

OFFENSE

Spd 30 ft.

Melee scimitar +2 (1d6+1/18-20) or dagger +2 (1d4+1/19-20)

Ranged composite longbow +2 (1d8+1/x3)

Space 5 ft.; Reach 5 ft.

STATISTICS

Str 13, Dex 13, Con 12, Int 8, Wis 10, Cha 9

Base Atk +1; CMB +2; CMD 14

Feats Dodge, Skill Focus (Profession [sailor])

Skills Acrobatics +5, Climb +5, Craft (ships) +3, Perception +4, Profession (fisherman) +4, Profession (sailor) +8, Survival +4, Swim +5

Languages Common

Combat Gear masterwork studded leather, daggers (2), composite longbow (+1 Str) with 20 arrows, scimitar```
#

hmm i can reproduce it with goblin warrior too

sage flint
#

PF1 9.3, Foundry 10.303, SBC 4.1.1:

From Actor in Actors tab:

image.png
#

From Unlinked Token on Map:

image.png
white thorn
#

Unrelatedly, those action names need to be sporked.

sage flint
#

Sporked? 😄

white thorn
#

I dunno, replaced with something more sane than just repeating the item name. Cut out the cruft.

sage flint
#

Oh, yeah, I knew what you meant there.

#

Just amused that "sporked" was the term used. Reminded me of school lunch utensils.

crisp crow
#

Looks like the culprit is roll bonuses module

#

@zenith raptor can you check x3+ crits with your module active?

zenith raptor
sage flint
#

David, you have my sympathies on the fun. 🫂

zenith raptor
#

Because I haven't been following this - that's the damage that's going crazy?

crisp crow
crisp crow
zenith raptor
#

Uh wait it only does that for SBC imported things?

#

If you create a weapon yourself it doesn't do that?

crisp crow
#

yep

zenith raptor
#

If you export/import that same weapon/attack - does it work correctly then or still broken?

#

And do you have anything from my mod pointing at it to modify the critical threat range?

crisp crow
crisp crow
sage flint
#

Wait

#

Hang on.

crisp crow
#

just made whole bunch of goblins

zenith raptor
# crisp crow anything above standard crits become this

I'm trying to figure out if you export the actor, and import it back, if it still happens -- because if it does, then you can give me the json and then I can import it and I can figure out what's going on (..hopefully)

crisp crow
sage flint
#

Found it.

#

Naturally, Mana was right.

#

SBC is once again handling CritMult as a string.

#

A small-but-should-be-unneeded fix in Roll Bonuses would be to convert to a number, which at worst won't harm anything.

zenith raptor
#

Well dang. It would be nice if actions were documents so this couldn't have happened, but I can add a check for that

sage flint
#

It's on me, though it shouldn't have happened, so it's also annoying here. 🙂

zenith raptor
#

Talking about this value right rollData.action.ability.critRange?

sage flint
#

SBC just got split apart, and doesn't quite work right in the dev environment, but I'll try to get this patched. @crisp crow can you please put a bug report on the gitlab?

sage flint
zenith raptor
#

Well while you're there you wanna double check that one too 😅?

sage flint
#

Already on it. 😄

zenith raptor
#

Oh ok I see the pic

sage flint
#

Great minds. 😉

zenith raptor
#

It looks like it was this return rollData.action.ability.critMult + sum, so it was doing something like "2" + 1 turning it into "21" which the system later turned into 21

sage flint
#

To be fair, that normally works. 😄

zenith raptor
#

return +(rollData.action.ability.critMult || 2) + sum
Well it's a lot safer now

crisp crow
crisp crow
zenith raptor
#

Haha

sage flint
#

🙏 My bad

crisp crow
#

no problem we all get a laugh. thats pretty much was the only case they can hit the mark and when they did it was total overkill 😄

zenith raptor
#

I had a character that I played exclusively with my wife. It was a warpriest with a Scythe and Greater Weapon of the Chosen (so on a single attack I could roll 2d20 and keep the better) And she dual wielded with Kene Kukris and had Butterfly's Sting (which meant she could forego bonus damage on a confirmed crit so the next person that hit it got a free crit). So she'd line 'em up and I'd knock 'em down. I'd hit that much at least once per combat. At level 5 or so it was basically a minimum of ~120 damage. (I mean she didn't have keen at level 5, or at least not on both her weapons yet, but it was pretty awesome)

crisp crow
sage flint
#

See, that scares the hell out of me.

#

I've never had a player use Butterfly's Sting, but I love the feat.

#

But combine that with a Swashbuckler that has "Feinting Deed" that doesn't even need an attack roll...

#

😬

zenith raptor
#

The average of 2d20 and taking the higher is roughly 14, and the chances of rolling a crit fail is 1 in 400 so I basically never missed the free crit chance

sage flint
#

Aye!

zenith raptor
#

I've been updating my integration with Item Hints and added hints on the spells that have abilities configured for them

image.png
#

@crisp crow I've pushed an updated 2.3.3 so you don't have to worry about rebuilding those actors you've already made

crisp crow