#Specific FA icons failing to render in specific browsers

1 messages · Page 1 of 1 (latest)

simple ginkgo
#

Specifically, the issue seems to be with the icon that the warning notification uses

low harness
#

Works in setup and login but not in world

vocal sentinel
#

all 3 of mine break

low harness
#

no all

#

all mine break

#

in world

vocal sentinel
#

oh rly?

#

okay

low harness
#

yes

#

setup and login they work

#

but in world they all break

vocal sentinel
#

so yea it's just the in-game/out-of-game split that's weird, yea

simple ginkgo
#

Yeah, stuff breaking in the world but not in setup is its own weirdness. AFAIK, the FA icon loading stuff for both should be identical between those different pages

vocal sentinel
#

It honestly, doesn't bother me that much, but PH brought it up on the pf2e server, and it pushed me to finally ask about a thing that i'd noticed was broken a long time ago

#

if we don't solve it, not the end of the world

low harness
#

yeah its just always bugged me

vocal sentinel
#

i pinged my group to see if anyone's around for more data gathering, but saturday evening's an ask

low harness
#

so in setup it works

#

it must be a module

simple ginkgo
low harness
simple ginkgo
low harness
#

i just tested that and it works in world

vocal sentinel
#

new data point: chrome works on v11p2 in a nearly-blank 5e world i have around to test with

#

gonna try non-pf2e on v10 now

low harness
#

fresh 5e world worked

vocal sentinel
#

yep

low harness
#

fresh pf2e world works

simple ginkgo
#

The possibility on I've tested in pf2e 4.7.4 and core 10.291 myself and had no issues, just as another datapoint

#

So, a module acting up sounds more likely. Can you Find The Culprit or something and figure out which one it might be?

vocal sentinel
#

yea this is gonna end up being a module issue and we're gonna look real dumb

#

time to Find The Culprit

low harness
#

LOL

#

LibTheamer

#

lib Themer is breaking it i think

vocal sentinel
#

that'd make sense, at least mouse is around and developing again

#

i'm gonna run down my list, if it pops the same module, i'll make the bug report

simple ginkgo
#

Lemme double check and see if I can confirm on this end

#

Hmm, libThemer doesn't intrinsically break it on my end.

Maybe a theme module that's leaning on that?

low harness
#

just only having libthemer enabled on pf2e world it breaks

image.png
simple ginkgo
#

Derp. I should activate the module before calling it ruled out, lol

Yeah, that module does seem to break it

vocal sentinel
#

yep

simple ginkgo
#

@karmic coyote I think libThemer is somehow breaking some of the icons in notifications

karmic coyote
#

Maybe. @low harness what options do you have enabled? or is it just the module enabled?

simple ginkgo
#

I literally just enabled the module, didn't touch anything else after installing it, and it broke the icons in notifications

karmic coyote
#

Alright, let me take a look. I might have done something weird.

low harness
karmic coyote
#

@simple ginkgo I am stupid and don't remember the options for the notifications, any chance you could remind me so I don't spend like 10 minutes trying to find them again?

simple ginkgo
vocal sentinel
karmic coyote
#

Awe... I see whats happening

#

libThemer lets you change the font variable, and its not wrapping it in quotes so instead of --font-awesome: "Font Awesome 6 Pro"; its just --font-awesome: Font Awesome 6 Pro;

I should be able to resolve this. Give me a reason to look at some of the other issues I haven't had the time to look at yet.

#

Its always little things

vocal sentinel
#

ty bud 🙂

low harness
#

amazing! thank you

simple ginkgo
#

My next question is "why does that only break some of the stuff in notifications instead of the whole UI"? lol

karmic coyote
#

Well it depends on how good people are at actually using the variable to set the font family vs a static value...

simple ginkgo
#

Ah, it looks like most stuff is being done via fas fa-icon-name while that's being done at a lower level by setting the font family and character manually

karmic coyote
#

For example, when using something like <i class="fas fa-comments"></i> this would work fine, as it doesn't use the variable to get the font family, it uses

.fa-classic, .fa-light, .fa-regular, .fa-solid, .fa-thin, .fal, .far, .fas, .fat {
    font-family: "Font Awesome 6 Pro";
}

from the css provided by font awesome.

simple ginkgo
#

Yeah, that explains it

karmic coyote
#

Meaning it would work just fine without any issues. But if you were to just try using the variable, I would have broken. haha

simple ginkgo
#

Mystery solved, lol

karmic coyote
#

I will do my best to get this patched tonight or tomorrow, I am going to try and fix a few other things well I am working on it as well. Thanks for letting me know!

low harness
#

thanks heaps!

karmic coyote
#

So apparently I am both stupid and smart all in one. I am wrapping the font in double quotes, however I am only doing this when you are setting it and not when its loaded by default.

So a quick solution to fix the issue is to change the icon font from font awesome to something else and back. I am going to update the default so that it includes the double quotes so this will fix the issue going forward. I have to figure out what the best way to update the issue for anyone else when updating and not installing fresh.

vocal sentinel
karmic coyote
#

Shit, I forgot about this.

#

Let me look into it tonight, tomorrow morning, I've been working all day and might crash after my shower, if not, I'll work on this.

vocal sentinel
karmic coyote
#

Well dont boot up MM+ than, cause nothing new has been added to that either... Though I do think update 2.2.3 was one of my best. haha

vocal sentinel
karmic coyote
#

I am happy it was a small mistake. cause someone else said they made the mistake of doing v26 instead of v2.6... I would have just said... whelp my users are fucked. haha