Item Piles Splittermond Currencies | Foundry VTT | Page 1

surreal widget Nov 23, 2022, 8:13 PM

#

@rare falcon Welcome! 🙂

#

Aye, that's why I tagged you in the thread 🙂

rare falcon Nov 23, 2022, 8:14 PM

#

I see. Man I work in IT, but discord makes me feel old 😄

surreal widget Nov 23, 2022, 8:15 PM

#

Haha 😛

#

In any case, I've been noodling on the problem

#

So in the getItemPrices, I've thought this up:

if (typeof overallCost === "string" && isNaN(Number(overallCost))) {
  const parts = overallCost.matchAll(/((\w*)(?=.)([1-9]+\d*)(?=.)(\w*))+/g);
  overallCost = 0;
  if (parts.length === 1 && !parts[0][1] && !parts[0][3]) {
    overallCost = Number(parts[0][2]);
  } else {
    for (const part of parts) {
      const currency = currencyList.find(curr => {
        const abbr = curr.abbreviation.toLowerCase();
        return abbr.includes(part[1]) || abbr.includes(part[3]);
      });
      if (!currency) continue;
      overallCost += currency.exchangeRate * Number(part[2]);
    }
  }
}

rare falcon Nov 23, 2022, 8:15 PM

#

Yeah, I am really sorry for this 😄 I wish I could help you more

surreal widget Nov 23, 2022, 8:16 PM

#

In essence, I use regex to detect like 10gp 50sp 25cp

#

which then adds up each relative currency value to figure out the total

#

so that the rest of the code can take it from there

rare falcon Nov 23, 2022, 8:20 PM

#

Sorry if I take some time to understand that, I'm really new to JS.

But we are still talking about issue #176 and not the new one (#200) I created, yes? Just to be sure.

surreal widget Nov 23, 2022, 8:20 PM

#

Yeah the old one

#

Okay, so basically, the problem is string parsing

#

We need to take 1L 50T and somehow translate it into raw numbers so that Item Piles can handle it

#

Since L and T are both used in the currency settings, we can split the cost up into individual parts, and figure out what each part means

#

In this case 1L and 50T

#

if we look for numbers and text, we can deduct that 1L is 1 Lunare and 50T is 50 Telare

#

Meaning the cost of this item is 150 Telare total

#

Get my drift? 🙂

rare falcon Nov 23, 2022, 8:23 PM

#

Did you mix it up or did I understand it wrong?

I assumed the way I created it, it was 1S = 100L = 10000T. Is it the other way around?

surreal widget Nov 23, 2022, 8:23 PM

#

Ah sorry

rare falcon Nov 23, 2022, 8:23 PM

#

#

Ok ok

surreal widget Nov 23, 2022, 8:24 PM

#

Substitute Solare with Lunare in my examples

rare falcon Nov 23, 2022, 8:24 PM

#

1L 50T = 150T yes

surreal widget Nov 23, 2022, 8:25 PM

#

I've never used the system FYI, hence my confusion

rare falcon Nov 23, 2022, 8:25 PM

#

I did write something like this to get merchants working in Splittermond: https://bitbucket.org/rpgframework-cloud/splittermond-fvtt/pull-requests/88

Bitbucket

rare falcon Nov 23, 2022, 8:25 PM

#

surreal widget I've never used the system FYI, hence my confusion

No one has 😄 Literally 70% of the issues in the system are from me

surreal widget Nov 23, 2022, 8:25 PM

#

Cool, lol

#

Well, with my implementation, I think it should be safe to then put Lunare as primary currency, with 100, 1, and 0.01 as the exchanges, respectively

rare falcon Nov 23, 2022, 8:29 PM

#

Then I'd have to use floats to represent the basePrice. As I already said I am new to JS and wanted to make sure I have exact values and therefore used integers. I don't know what it's called, but I guess you know what I am talking about, when using float to do simple maths and ending up with something like 2.00000000000003 or something like that.

Is it safe/wise/easy to just use a float instead?

surreal widget Nov 23, 2022, 8:29 PM

#

You don't, though

rare falcon Nov 23, 2022, 8:29 PM

#

😄 great

surreal widget Nov 23, 2022, 8:29 PM

#

So, if you continue to use your prices with parts

#

Like 10L 50T

#

Item piles will figure out how to represent that on its own side

#

I made it better, I'll show you with comments

rare falcon Nov 23, 2022, 8:31 PM

#

Ok, right now prices are stored in splittermond as a string. It'd normally be something like 10L 50T. I then added the basePrice, which just converts it to a single number. So you say it should already work with the string?

surreal widget Nov 23, 2022, 8:31 PM

#

That's what I'm describing what I'm doing

surreal widget Nov 23, 2022, 8:31 PM

#

surreal widget So in the `getItemPrices`, I've thought this up: ```js if (typeof overallCost ==...

This is what I'm putting into item piles directly

rare falcon Nov 23, 2022, 8:32 PM

#

Are you currently implementing it or is it already implemented?

surreal widget Nov 23, 2022, 8:33 PM

#

Am currently

#

Here, with comments:

// Get all the parts, split by number, remove empty strings, and spaces at the start/end of each part
const parts = overallCost.split(/([1-9]+\d*)/g)
  .filter(Boolean)
  .map(part => part.trim());

// If there's only one part (one number), use that to determine the cost
overallCost = 0;
if (parts.length === 1) {
  overallCost = Number(parts[0]);
} else {
  // Otherwise, go through each part
  for (let i = 0; i < parts.length; i++) {
    // If the current part is not a number, then the next part is the cost
    const cost = isNaN(Number(parts[i])) ? parts[i + 1] : Number(parts[i]);
    // If the current part is not a number, then it is the currency shorthand
    const potentialCurrency = (isNaN(Number(parts[i])) ? parts[i] : parts[i + 1]).toLowerCase();
    // Try to find the currency in the currency list setup 
    const currency = currencyList.find(curr => {
      const abbr = curr.abbreviation.toLowerCase();
      return abbr.includes(potentialCurrency) || curr.name.toLowerCase().startsWith(potentialCurrency);
    });
    // If we didn't find it, give up
    if (!currency) continue;
    // Otherwise add it to the overall fractional cost
    overallCost += currency.exchangeRate * Number(cost);
  }
}

#

currencyList being the merchant's (or entire system's) currency setup

#

Does any of that make sense? 🙂

rare falcon Nov 23, 2022, 8:34 PM

#

Ah now I get it

#

Basically the same thing I did only way better and system agnostic

surreal widget Nov 23, 2022, 8:35 PM

#

So even crazy people who do like L1 50 T can be handled

#

because it finds that L is not a number, so the next part must be a number

#

so, 1 tolare*

#

the next part is a number so the next one after that must be a string, so 50 Lunare

#

you get the gist

#

AAA

#

i'm so confused with the currencies sometimes

#

but you get the principle

#

I'll go try this out in splittermond now I think

rare falcon Nov 23, 2022, 8:36 PM

#

Yes, I do. If I understand it correctly, we did exactly the same thing

surreal widget Nov 23, 2022, 8:37 PM

#

Indeed we did

#

Mine just assumes people may be crazy

#

Which... is definitely a certainty

rare falcon Nov 23, 2022, 8:37 PM

#

surreal widget I'll go try this out in splittermond now I think

Are you sure? It's german only. Maybe I can help you

surreal widget Nov 23, 2022, 8:37 PM

#

I'll just quickly create a merchant and see myself 🙂

#

Then I'll send you a beta version to test out

rare falcon Nov 23, 2022, 8:38 PM

#

Great

surreal widget Nov 23, 2022, 8:44 PM

#

rare falcon Great

Neat.

rare falcon Nov 23, 2022, 8:44 PM

#

surreal widget Nov 23, 2022, 8:45 PM

#

lunare is the base currency, right?

#

Or is it actually Telare?

rare falcon Nov 23, 2022, 8:45 PM

#

There isn't really a base currency

surreal widget Nov 23, 2022, 8:45 PM

#

Ah okay

#

Well I'll make it lunare for item piles to have more wiggleroom

rare falcon Nov 23, 2022, 8:46 PM

#

Does it have to be though? I'd prefer the smalles one. Does it have any technical reason to be?

surreal widget Nov 23, 2022, 8:47 PM

#

Not really, not in this instance I suppose

rare falcon Nov 23, 2022, 8:47 PM

#

Telare are pretty much used all the time still. It's not like DnD where you run around and do everything with Gold

#

We only ever had more than 1 Solare two times

#

I am not even sure there is anything in the rulebook, that's more than 50L 😄

surreal widget Nov 23, 2022, 8:51 PM

#

Haha okay then

rare falcon Nov 23, 2022, 8:51 PM

#

Well besides magically crafted Items, but I am getting off topic^^

surreal widget Nov 23, 2022, 8:52 PM

#

Telare it is

surreal widget Nov 23, 2022, 8:55 PM

#

rare falcon Well besides magically crafted Items, but I am getting off topic^^

Try installing this directly in the foundry client 🙂
https://raw.githubusercontent.com/fantasycalendar/FoundryVTT-ItemPiles/next/module.json

#

It's the beta version

#

I'm looking into your issue now

rare falcon Nov 23, 2022, 8:59 PM

#

While we are at it. Can you replace the Lunare Icon with icons/commodities/currency/coins-assorted-mix-silver.webp ? Some update changed the Icon

surreal widget Nov 23, 2022, 8:59 PM

#

Sure can do

#

I'll also improve the handling of having the smallest currency being the primary one, I was basing most of my logic around the 5e system of gold being primary, and being split

rare falcon Nov 23, 2022, 9:02 PM

#

Didn't work for me:

surreal widget Nov 23, 2022, 9:02 PM

#

It's working, it's just always defaulting to the smallest currency

surreal widget Nov 23, 2022, 9:02 PM

#

surreal widget I'll also improve the handling of having the smallest currency being the primary...

This will fix it

#

Like if you buy it from the merchant

#

With a person who has Lunare

#

It'll use lunare to pay for it

rare falcon Nov 23, 2022, 9:03 PM

#

Ah yes. Good thing that's working. I thought it would also convert the price of 5000T to 50L in the merchants window^^

surreal widget Nov 23, 2022, 9:04 PM

#

Nah :p it's just displaying the "easiest" way to show it, because Telare is the primary currency

#

so it doesn't think it has to show higher currencies

#

I'll make it show higher ones if it can

rare falcon Nov 23, 2022, 9:04 PM

#

Now I see why it could be good to use Lunare as a base currency. hm...

surreal widget Nov 23, 2022, 9:05 PM

#

Yeah

#

It's like using dimes instead of dollars

#

So by using dollars as a primary one, dimes becomes a thing it tries to avoid

rare falcon Nov 23, 2022, 9:06 PM

#

Yeah it's a bit more complicated in splittermond unfortunately 😄 Most daily use items are <1L. Torches, Oils, Food. Only weapons and armor are more most of the time

surreal widget Nov 23, 2022, 9:06 PM

#

Try setting Lunare as primary, with 100, 1, 0.01

#

If something costs 50T it will show that

#

and use that

#

rare falcon Nov 23, 2022, 9:07 PM

#

Is it too complicated to convert it back to the currencies in the most sensible way?

surreal widget Nov 23, 2022, 9:07 PM

#

#

Nope, I can do it at the snap of a finger

#

https://github.com/fantasycalendar/FoundryVTT-ItemPiles/blob/master/src/systems/splittermond.js

#

It's all configured here

#

The next time you update, it'll just ask if you want to update, and it'll work

rare falcon Nov 23, 2022, 9:08 PM

#

Oh it already does when using lunare as the primary:

surreal widget Nov 23, 2022, 9:08 PM

#

Yeah, so it works like you expect? 🙂

#

I'd recommend the exchange rates of 100, 1, and 0.01 in any case

rare falcon Nov 23, 2022, 9:10 PM

#

I'd go for 1, 0.01, 0.0001 to have it exactly as i imagined it

surreal widget Nov 23, 2022, 9:10 PM

#

I don't get that

#

It's the same thing

#

that is just how much the primary currency is multiplied

rare falcon Nov 23, 2022, 9:10 PM

#

100, 1, 0.01:

surreal widget Nov 23, 2022, 9:11 PM

#

I see

#

That makes sense, thank you

#

Putting more priority on Solare

#

Convert to it if you can

#

Otherwise use Lunare, lastly Telare

#

I getcha

rare falcon Nov 23, 2022, 9:12 PM

#

#

Does it really put more priority on it? It only uses it if it is indeed at least 1S

#

It would never use it otherwise

surreal widget Nov 23, 2022, 9:13 PM

#

Indeed

rare falcon Nov 23, 2022, 9:13 PM

#

this looks best right now imho

surreal widget Nov 23, 2022, 9:13 PM

#

Nice, I'll use those

#

Does item piles make a bit more sense now? 🙂

rare falcon Nov 23, 2022, 9:13 PM

#

i don't know if it will break anything, though 😄

#

yeah, it's great, thanks

surreal widget Nov 23, 2022, 9:14 PM

#

The only thing that putting Solare as primary is that if you put just a simple "50" on an item price, it'll default to 50S

rare falcon Nov 23, 2022, 9:14 PM

#

Was a bit hard to understand everything when I wasn't sure how to get it running 😄

surreal widget Nov 23, 2022, 9:15 PM

#

You might want to put it on Telare, if that doesn't break anything

rare falcon Nov 23, 2022, 9:15 PM

#

surreal widget The only thing that putting Solare as primary is that if you put just a simple "...

well as my physics teacher always said "50 what? apples? bananas?"

surreal widget Nov 23, 2022, 9:15 PM

#

haha

#

fair

#

User error should be fixed on the user side

#

:p

rare falcon Nov 23, 2022, 9:16 PM

#

I think it's good like that. Will you set it as the splittermond defaults?

surreal widget Nov 23, 2022, 9:16 PM

#

Indeed

rare falcon Nov 23, 2022, 9:16 PM

#

Great

#

thank you

surreal widget Nov 23, 2022, 9:16 PM

#

Thanks for walking me through it!

#

I think it might fix your other bug too

#

Can you test?

rare falcon Nov 23, 2022, 9:17 PM

#

It does

#

awesome

#

What exactly did fix it? The new way of calculating the base price from the price-string or the new exchange rates or the new primary?

#

I think you forgot to reenable the german translation with 2.3.0.

surreal widget Nov 23, 2022, 9:26 PM

#

Huh, I did? I didn't touch any translation

#

Oh yeah

surreal widget Nov 23, 2022, 9:27 PM

#

rare falcon What exactly did fix it? The new way of calculating the base price from the pric...

And yeah I think both of those contributed

rare falcon Nov 23, 2022, 9:29 PM

#

Ok, thank you again, then. It's already late here, so I will head to bed. The next time I have some annyoing issue, it will be easier to figure out 😄

#

Oh I just remembered, there is a new item type in splittermond. npcattack.

This would be the new filter:

spell,strength,weakness,mastery,species,culture,ancestry,education,resource,npcfeature,moonsign,language,culturelore,statuseffect,spelleffect,npcattack

surreal widget Nov 23, 2022, 9:32 PM

#

Okayo, added

rare falcon Nov 23, 2022, 9:32 PM

#

Thanks

#Item Piles Splittermond Currencies