MidiQOL | Foundry VTT | Page 20

raven ore Oct 22, 2022, 11:22 PM

#

I still haven't resolved that either

short aurora Oct 22, 2022, 11:23 PM

#

It shouldn't, that's just the two things we're changing - the damage parts and, in this case, the flag containing the item macro. The damage seems right on my end - for one of the messages. :p

raven ore Oct 22, 2022, 11:23 PM

#

Kk

short aurora Oct 22, 2022, 11:24 PM

#

wait wtf now it's doing it right ._.

#

It ROLLS the first message though, which will be an issue if you have automation

#

I can see it just before it's deleted

raven ore Oct 22, 2022, 11:24 PM

#

That didn't eliminate the looping for me

short aurora Oct 22, 2022, 11:25 PM

#

How are you setting up this feature?

raven ore Oct 22, 2022, 11:25 PM

#

I don't auto-roll my attacks for players

#

so that's not a problem

#

short aurora Oct 22, 2022, 11:26 PM

#

Okay yeah, you need to change whatever field that is or toggle it off on the cloned item. Mine is an ItemMacro embedded in the item, that's what I'm updating out of with the clone.

#

Here's the unarmed strike of monk with the item macro embedded. Try to import it and give it a go, should leave 1 message (after rolling and deleting the first one) with updated damage values.

📎 fvtt-Item-unarmed-strike-monk.json

#

Although I think in your case it's just js item = item.clone({ "data.damage.parts": newDamage, "flags.midi-qol.onUseMacroName": "" }, { keepId: true });

#

Removes the macro name to run from the item and it shouldn't be able to loop anymore, because the cloned item doesn't know the macro

#

I still have no idea how this thing is deleting the first message though, commons.js just seems to do it, magic I tells ya

raven ore Oct 22, 2022, 11:31 PM

#

So, that does stop the loop sort of

#

I get the first prompt again, to drop the template or consume resources. But the macro dialog doesn't pop up again

#

I don't think it's going to work the same way it does with your item

#

I think somehow I need to update the existing card with different damage dice

#

and within the same workflow

short aurora Oct 22, 2022, 11:34 PM

#

In this case, it would definitely be easier to update the workflow before damage is rolled. For your other monk features, it seems like the flow of the macro is off. Needs to stop the original one from getting to the point where placement and resources are consumed, create the new "empowered" feature and roll that instead...

raven ore Oct 22, 2022, 11:36 PM

#

Yeah. I don't have a lot of experience with midi QoL, so I'm having to figure out a lot of these pieces as I go.

#

I see similar things being handled on the preDamageRoll step

#

But I would like to do as you said. I want to be able to modify the card

kind cape Oct 22, 2022, 11:38 PM

#

I just looked at the feature in question, and well.. Unless I misunderstood something about it its just a big collection of spells that can be upcast, right?

short aurora Oct 22, 2022, 11:38 PM

#

No, it's monk stuff, so they can change the fundamentals of the spell

raven ore Oct 22, 2022, 11:38 PM

#

Yeah, some of them are actual spells. Some of them are features that can change when additional ki points are used.

#

I'm trying to get the chat card to reflect those changes and allow for "upcasted" damage dice as well

kind cape Oct 22, 2022, 11:39 PM

#

Well, have you considered using Magic Items module and just creating them as "spells" in there? It can do upcast

raven ore Oct 22, 2022, 11:40 PM

#

Yeah. That doesn't quite do what I'm looking for. With that module, I can upcast with item charges or spell slots. But this is a resource that is used by multiple features already.

#

That also doesn't get me the dialogue options

kind cape Oct 22, 2022, 11:41 PM

#

As long as you put the "spells" onto the feature with the Ki points stored I don't see why it being used by other features would be a problem 🤔

raven ore Oct 22, 2022, 11:41 PM

#

Because there is no option to upcast with them, as far as I know

kind cape Oct 22, 2022, 11:42 PM

#

raven ore Oct 22, 2022, 11:42 PM

#

Isn't that a charge?

kind cape Oct 22, 2022, 11:42 PM

#

Yes? Not quite sure what else it would be

raven ore Oct 22, 2022, 11:43 PM

#

Charges vs Item Uses

#

Item Uses can have a secondary feature assigned

#

Which is what this requires

naive zenith Oct 22, 2022, 11:47 PM

#

Fotoply is right about Magic Items for Four Elements monk. Macros are another way but that's a method I just don't have mastery of for this. But the module worked for my players monk, when we were playing. Requires more upkeep on increasing Uses (Ki) and increasing the max Ki Upcast, but its worked for us.

#

Until either a) the 5e system implements something for this particular function or b) a module shows up to aid this process, gotta find workarounds.

scarlet gale Oct 22, 2022, 11:55 PM

#

Personally, I'd just slap an item macro onto the spell that asks if you want to upcast and change the workflow to do so. That also allows you to update the remaining ki with the macro too.

short aurora Oct 22, 2022, 11:59 PM

#

Toll the Dead in the example compendium has a simple method of changing the damage, we overcomplicated.

const theItem = await fromUuid(args[0].uuid);
let formula = theItem.system.damage.parts[0][0];
formula = formula.replace("1d4", "2d8"); // define the formula with both standard and new ki value here, check toll the dead for an example of the calculation
theItem.system.damage.parts[0][0] = formula;```

#

I'd still like to figure out the proper way to do empowered features that change fundamentally how the item works, not just scale damage, I think I'll deal with that another time

molten solar Oct 23, 2022, 12:06 AM

#

short aurora Toll the Dead in the example compendium has a simple method of changing the dama...

The proper way of doing that would be clone, not by making a local override to the item...

#

The same goes for the other thing. Clone.

short aurora Oct 23, 2022, 12:09 AM

#

What's does proper mean in this context? For the other thing, I would clone, easier than recreating the item, but we did not have much success with making clone play nice with midi

#

Not shown by the way, the example from midi has a damage formula calculation, this is just the proof of concept

#

Not throwing tposney under the bus, the above is just a snip for changing damage

molten solar Oct 23, 2022, 12:11 AM

#

You set theItem to have a new formula, but never change it back.

#

Making a clone that has the new formula gets around that.

short aurora Oct 23, 2022, 12:12 AM

#

True, but rolling that item proved to be the problem. There's presumably a trick to it, I could not find it.

molten solar Oct 23, 2022, 12:12 AM

#

That I wouldn't know. I do this in Roll Groups, just rolling a clone and that always works.

violet meadow Oct 23, 2022, 1:27 AM

#

Does this need the render() part?
I thought the setDamageRoll took care of all the rest

violet meadow Oct 23, 2022, 1:36 AM

#

molten solar That I wouldn't know. I do this in Roll Groups, just rolling a clone and that al...

Yeah the issue is that here you've already started rolling the item when you change stuff around. Works in the context of the midi Workflow.

You are not making a clone and then rolling that cloned item.

violet meadow Oct 23, 2022, 1:37 AM

#

short aurora True, but rolling that item proved to be the problem. There's presumably a trick...

What is not working (if something isn't, too many messages to go through!)?

raven ore Oct 23, 2022, 1:38 AM

#

So I've gotten pretty close with it, using a clone

#

The only issue I run into now is I need a way to disable the first dialog prompt

violet meadow Oct 23, 2022, 1:38 AM

#

Is that the consumption dialog?

raven ore Oct 23, 2022, 1:38 AM

#

The Usage Configuration prompt that asks if you want to Consume Resource or Place Measured Template

#

yeah

#

but only on the first roll

#

not the clone

violet meadow Oct 23, 2022, 1:39 AM

#

Will be included in next midi version. For the time being let me find the response from tposney

raven ore Oct 23, 2022, 1:39 AM

#

...shit lol

violet meadow Oct 23, 2022, 1:40 AM

#

<#1010273821401555087 message>

raven ore Oct 23, 2022, 1:41 AM

#

I don't think I know enough to understand how to use those pieces he mentions

#

Is that something I could do now?

#

Or need a later version?

violet meadow Oct 23, 2022, 1:41 AM

#

Actually I was trying to find a way to do witch bolt easily.

violet meadow Oct 23, 2022, 1:42 AM

#

raven ore Is that something I could do now?

You can use the hook now

#

So what is your macro?

#

Are you running it as an onUse preItemRoll?

raven ore Oct 23, 2022, 1:43 AM

#

📎 spendAdditionalKiPoints.js

#

Yup, exactly

violet meadow Oct 23, 2022, 1:44 AM

#

In the preItemRoll phase you can use a Hook.once function to pass the consumeUsage:false on the next item roll

#

I am on my phone now and it's not easy to write it properly

raven ore Oct 23, 2022, 1:45 AM

#

Ok. Yeah, I'm not sure how to use those. Will have to find an example or something.

violet meadow Oct 23, 2022, 1:46 AM

#

Ok let me see if I can write it

short aurora Oct 23, 2022, 1:56 AM

#

violet meadow What is not working (if something isn't, too many messages to go through!)?

It essentially boiled down to me being unable to create and then roll a Clone item within Midi's workflow, and not run the remainder of the original workflow. I could only figure out how to roll it and also finish the original workflow.

celest bluff Oct 23, 2022, 2:07 AM

#

violet meadow In the preItemRoll phase you can use a Hook.once function to pass the consumeUsa...

don't even need a hook

violet meadow Oct 23, 2022, 2:07 AM

#

raven ore Ok. Yeah, I'm not sure how to use those. Will have to find an example or somethi...

Hooks.once("dnd5e.preUseItem", (item,config,options) =>{
  console.log(item,config,options)
    foundry.utils.setProperty(config,'consumeUsage',false)
    foundry.utils.setProperty(config,'needsConfiguration',false)
})

Try this inside the macro

celest bluff Oct 23, 2022, 2:07 AM

#

you can just return it

#

if (lastArg.macroPass === "preItemRoll")  {        
    if(itemD.attunement < 2){
        ui.notifications.error(`This item requires attunement.`);
       return false;
    } else if ((actorData.spells?.spell1?.max || actorData.spells?.pact?.max) === 0) {
    ui.notifications.error(`No spell slots found on ${actorD.name}`);
    return false;
    }
}

violet meadow Oct 23, 2022, 2:08 AM

#

I think they just need to continue with the workflow, but not trigger the resource consumption dialog

celest bluff Oct 23, 2022, 2:08 AM

#

can abort it too

violet meadow Oct 23, 2022, 2:10 AM

#

Yeah still they don't need to abort from what I've surmised, just on the one roll of the item to not trigger the Configure dialog

violet meadow Oct 23, 2022, 2:10 AM

#

short aurora It essentially boiled down to me being unable to create and then roll a `Clone` ...

I have created infinite loops trying that more that once 😅

raven ore Oct 23, 2022, 2:11 AM

#

That actually just happened to me a little while ago. I panicked and shut my browser

short aurora Oct 23, 2022, 2:12 AM

#

I managed to sneak my way into avoiding the infinite loops, but would still have the original excessive workflow and I didn't really find a way around it.

#

Dialectikal's issue gave me the idea to run "empowerable" features that would do different things, so my idea is to clone the item in the workflow if player opts for it and add the additional stuff without changing the original, but that seems not in scope

violet meadow Oct 23, 2022, 2:13 AM

#

Yeah, from within an initiated workflow, you ~~cannot~~ 🤔 should not be able to stop it and start a new one for the same item.

celest bluff Oct 23, 2022, 2:13 AM

#

infinite loops are fun TOBYAYSPEED

violet meadow Oct 23, 2022, 2:15 AM

#

You might be able to do something like that if you created a totally different uuid of the item 🤔

#

Cause the workflow is attached to that now that I think about it

raven ore Oct 23, 2022, 2:15 AM

#

violet meadow ```js Hooks.once("dnd5e.preUseItem", (item,config,options) =>{ console.log(ite...

Where should this go in the macro?

#

Didn't seem to change anything

violet meadow Oct 23, 2022, 2:16 AM

#

Hmm so what is the premise of the macro? You got that in an ItemMacro | preItemRoll correct?

short aurora Oct 23, 2022, 2:17 AM

#

violet meadow Cause the workflow is attached to that now that I think about it

So if you clone an item and then do MidiQOL.completeItemRoll(cloneItem), it's getting snagged on the uuid?

raven ore Oct 23, 2022, 2:19 AM

#

violet meadow Hmm so what is the premise of the macro? You got that in an `ItemMacro | preItem...

Yeah. It initially generates one of these config windows, then I have another option to select a resource. Then, once that is selected, it prompts the second one of these.

violet meadow Oct 23, 2022, 2:19 AM

#

So if you have initiated the args[0].itemUuid workflow and in the preItemHook abort it, clone the item and call again MidiQOL.completeItemRoll(cloneItem) that one will still be the same item.

As such it will follow the same pattern in the macro and thus infinite loop 🤔

If that makes sense 😅

raven ore Oct 23, 2022, 2:19 AM

#

I just need that first box not to pop

celest bluff Oct 23, 2022, 2:19 AM

#

You can just toss it on all

raven ore Oct 23, 2022, 2:22 AM

#

I just had that segment added to the top of the macro. It never gets hit.

raven ore Oct 23, 2022, 2:23 AM

#

celest bluff You can just toss it on `all`

Not sure what this means. What is "all"?

violet meadow Oct 23, 2022, 2:24 AM

#

raven ore Not sure what this means. What is "all"?

How do you set up the macro execution?

short aurora Oct 23, 2022, 2:25 AM

#

violet meadow So if you have initiated the `args[0].itemUuid` workflow and in the preItemHook ...

I did not run into that, so maybe I did get it and it's the aborting part that's the problem. How do I abort a workflow?

raven ore Oct 23, 2022, 2:26 AM

#

violet meadow Oct 23, 2022, 2:26 AM

#

short aurora I did not run into that, so maybe I did get it and it's the aborting part that's...

Hmm you can return false in the preItemRoll, or you can try something like setProperty(workflow,'aborted',true) for a quick test

#

@raven ore oh are you on v9?

raven ore Oct 23, 2022, 2:29 AM

#

violet meadow <@196070360637112320> oh are you on v9?

Yeah

violet meadow Oct 23, 2022, 2:29 AM

#

oops

#

v10 only with the new item.use()

#

Sorry for that!

raven ore Oct 23, 2022, 2:30 AM

#

Oh, you mean the preUseItem thing?

violet meadow Oct 23, 2022, 2:30 AM

#

Different solution. Can you make one of the rolls to not consume resources?

#

yes

raven ore Oct 23, 2022, 2:30 AM

#

Ah, bummer

celest bluff Oct 23, 2022, 2:30 AM

#

raven ore Not sure what this means. What is "all"?

raven ore Oct 23, 2022, 2:31 AM

#

The consuming of resources isn't the problem

#

I need to eliminate that first prompt

violet meadow Oct 23, 2022, 2:31 AM

#

Yes that prompts for template placement and consumption

celest bluff Oct 23, 2022, 2:32 AM

#

I'd say remove the template and have warpgate create the crosshairs for the template.. think that should be possible

violet meadow Oct 23, 2022, 2:32 AM

#

So in the preItemRoll, you could eliminate the template and the resource consumption and then it should not prompt 🤔

celest bluff Oct 23, 2022, 2:32 AM

#

can do that too

violet meadow Oct 23, 2022, 2:33 AM

#

And then put them back in for the second call

raven ore Oct 23, 2022, 2:33 AM

#

Ok. Let me see if I can do that

molten solar Oct 23, 2022, 2:36 AM

#

https://github.com/krbz999/templatemacro/releases/tag/v0.0.1

violet meadow Oct 23, 2022, 2:36 AM

#

why do you do these things...

#

at this time

molten solar Oct 23, 2022, 2:37 AM

#

❤️

#

You can save the macros in the item, and then the macros transfer to the templates. 🙂

#

You can even edit them afterwards.

violet meadow Oct 23, 2022, 2:38 AM

#

That's the stuff!

molten solar Oct 23, 2022, 2:38 AM

#

You have Door Macro to thank for this.

#

I basically just copied it and changed all instances of door with template

#

(used Door Macro in tonight's session btw, never had players so excited about a dumb thing.)

violet meadow Oct 23, 2022, 2:39 AM

#

Everyday I will be going through that door from now on

#

I created some trap workflows... nasty stuff

short aurora Oct 23, 2022, 2:40 AM

#

violet meadow Hmm you can return false in the preItemRoll, or you can try something like `setP...

Returning false seems to work just fine actually, Midi comes up with a notification saying the original item's name is blocked but the cloned one seems to roll just fine. The other suggestion, can I refer to the workflow like that in a macro?

molten solar Oct 23, 2022, 2:40 AM

#

pre release, use with caution or whatever, toodle-oo!

violet meadow Oct 23, 2022, 2:41 AM

#

short aurora Returning false seems to work just fine actually, Midi comes up with a notificat...

You can reference the workflow as this in macros for MidiQOL, or going through the hoops to properly define it, ```js
const workflow = MidiQOL.Workflow.getWorkflow(args[0].uuid);

raven ore Oct 23, 2022, 2:42 AM

#

Oh! It works! but... it throws an error

#

All I did was include this:

foundry.utils.setProperty('consumeUsage',false);
foundry.utils.setProperty('needsConfiguration',false);

from what you had given me before

violet meadow Oct 23, 2022, 2:42 AM

#

So setProperty(this,'advantage',true) will give advantage to the current workflow

raven ore Oct 23, 2022, 2:42 AM

#

I was actually trying to test something else

celest bluff Oct 23, 2022, 2:42 AM

#

guess pearl of power isn't possible for pact magic, since it's supposed to give a 3rd level pact slot

short aurora Oct 23, 2022, 2:43 AM

#

Gotta do a lot of finagling for that one, at least

violet meadow Oct 23, 2022, 2:44 AM

#

raven ore All I did was include this: foundry.utils.setProperty('consumeUsage',false); fo...

I guess that stops everything cause there is an error 🤷

raven ore Oct 23, 2022, 2:44 AM

#

@violet meadow, any way to utilize those functions in this context that isn't breaky?

#

violet meadow Oct 23, 2022, 2:44 AM

#

You are misusing the setProperty

raven ore Oct 23, 2022, 2:45 AM

#

But... it works lol

violet meadow Oct 23, 2022, 2:45 AM

#

You need to setProperty on an object

short aurora Oct 23, 2022, 2:45 AM

#

violet meadow You can reference the `workflow` as `this` in macros for MidiQOL, or going throu...

Sweet, thanks. Now I can make stupid items more dynamically.

coarse mesa Oct 23, 2022, 2:45 AM

#

molten solar You can save the macros in the item, and then the macros transfer to the templat...

Magnifique... if only I was on v10

violet meadow Oct 23, 2022, 2:46 AM

#

short aurora Sweet, thanks. Now I can make stupid items more dynamically.

yeah my issue with that is the notification. You can supress it within the macro. There were a couple of scripts in #macro-polo iirc

molten solar Oct 23, 2022, 2:46 AM

#

coarse mesa Magnifique... if only I was on v10

How many macro modules must I make to drag you here?

coarse mesa Oct 23, 2022, 2:47 AM

#

I saw some v10 ATL mess Kaelad was fixing this morning, gave me the willies again

violet meadow Oct 23, 2022, 2:47 AM

#

Do that with Effect Macro

#

just 2 lines

#

(almost)

raven ore Oct 23, 2022, 2:47 AM

#

violet meadow You need to setProperty on an object

I'm not sure what to set it on. It doesn't work on actor.items.getName(itemData.name).

#

sorry, the item, I mean

violet meadow Oct 23, 2022, 2:48 AM

#

I mean you cannot use that as is in v9 afaik

#

It happened to ~~work ~~seem to work, because I think you broke the workflow with your macro, as it errored out

raven ore Oct 23, 2022, 2:50 AM

#

Ok. I don't see where I can disable the template and consume resource options otherwise

#

Been looking through the item properties

violet meadow Oct 23, 2022, 2:51 AM

#

molten solar How many macro modules must I make to drag you here?

Now make an Item Piles macro (well that doesn't make sense...)

Mimic a macro 😄

naive zenith Oct 23, 2022, 2:51 AM

#

Macro Macro?

violet meadow Oct 23, 2022, 2:52 AM

#

Only v10 for Moto Moto to take the 🪠

violet meadow Oct 23, 2022, 2:56 AM

#

raven ore Ok. I don't see where I can disable the template and consume resource options ot...

OK 🐻 with me.

You will need to change the properties of the Item in the workflow in the preItemRoll phase.
Get in there and change the workflow.item.data.data.target to not be a template so it doesn't trigger the dialog, and if it has uses change that too

raven ore Oct 23, 2022, 2:56 AM

#

Ok. So like just set value to 0 or something?

violet meadow Oct 23, 2022, 2:57 AM

#

You will need to save these details in flags, before changing them actually.
Then in the After Active Effects phase change the item back to the original

(can be done with a warpgate mutation too, much easier)

violet meadow Oct 23, 2022, 2:58 AM

#

raven ore Ok. So like just set value to 0 or something?

Yeah to anything that doesnt trigger that dialog

#

You told me that you didn't want the dialog to appear the 1st time, but the next time it should appear correct?

#

I haven't followed 100% the topic and its pretty late here, so I hope I am not confusing you unnecessarily!

raven ore Oct 23, 2022, 3:00 AM

#

Nope. That's right. I see where you're going. It's a workaround, but it should work, I think.

#

As long as it handles it before trying to pop that prompt

violet meadow Oct 23, 2022, 3:02 AM

#

Just test it quickly in a test item. Make an item with a target template 10 ft radius.

Use an Item onUse macro preItemRoll that does something like this.item.data.data.target = {}

#

Does it change before the dialog pops up?

raven ore Oct 23, 2022, 3:05 AM

#

Yeah, that works

violet meadow Oct 23, 2022, 3:05 AM

#

Same principle for item uses etc.

raven ore Oct 23, 2022, 3:05 AM

#

Yeah. Already tested

violet meadow Oct 23, 2022, 3:06 AM

#

So more or less that should get you going

raven ore Oct 23, 2022, 3:06 AM

#

I just need to copy the values, so I can add em back

violet meadow Oct 23, 2022, 3:06 AM

#

actually does it change back if the workflow finishes?

raven ore Oct 23, 2022, 3:06 AM

#

I mean so I can make the clone

violet meadow Oct 23, 2022, 3:07 AM

#

yeah I was just wondering about what happened in your test item

#

did the target revert to the initial one?

raven ore Oct 23, 2022, 3:07 AM

#

Oh, yup it wiped it out

#

Guess I'll have to add it back to the original as well

violet meadow Oct 23, 2022, 3:09 AM

#

I am too tired to think now, but it should be locally changed. Does a reload change it back?

raven ore Oct 23, 2022, 3:10 AM

#

After refreshing, it's still blank

violet meadow Oct 23, 2022, 3:10 AM

#

OK!

#

You need to set some Flags on the item to preserve the original ones before changing them, or just mutate the item with Warpgate

#

and revert it After Active Effects

raven ore Oct 23, 2022, 3:11 AM

#

Eh...

#

lol

#

I am not savvy with Warpgate

#

Thanks a ton for helping out this far, btw

scarlet gale Oct 23, 2022, 3:13 AM

#

molten solar https://github.com/krbz999/templatemacro/releases/tag/v0.0.1

What triggers does it have? Not at my PC to test it out.

raven ore Oct 23, 2022, 3:14 AM

#

Same with @short aurora and anybody else who chimed in

violet meadow Oct 23, 2022, 3:15 AM

#

You can find warpgate mutation scripts for items in the discord here, but also as examples in the Warpgate repo wiki and readme

Totally worth the time to read through it!

short aurora Oct 23, 2022, 3:15 AM

#

violet meadow yeah my issue with that is the notification. You can supress it within the macro...

Does it happen within the macro if it's the last line? I'll have a look at macropolo, seems to be some css shenanigans

violet meadow Oct 23, 2022, 3:16 AM

#

short aurora Does it happen within the macro if it's the last line? I'll have a look at macro...

I would imagine so. Haven't tried it yet

#

Is there a hook for ui notifications that you could hook once to supress the next one 🤷

dark canopy Oct 23, 2022, 3:19 AM

#

short aurora Does it happen within the macro if it's the last line? I'll have a look at macro...

#macro-polo message

short aurora Oct 23, 2022, 3:23 AM

#

Yeah I was just wondering if I could turn it back 'on' in the same macro, but guess I could hook on a midi stage once to do so anyway

violet meadow Oct 23, 2022, 3:24 AM

#

The thing is that if you return false you are off the preItemRoll phase, so just do it in a later one

dull condor Oct 23, 2022, 3:27 AM

#

https://media.discordapp.net/attachments/670336046164213761/1033581236830097468/unknown.png

#

guys why does it show slashing so much like this

violet meadow Oct 23, 2022, 3:28 AM

#

What version is this? And how is the item's damage set up?

dull condor Oct 23, 2022, 3:29 AM

#

#

v10 build 288

#

midi 10.0.15

violet meadow Oct 23, 2022, 3:32 AM

#

I can quickly check with your settings before going to bed, if you export them and DM to me

dull condor Oct 23, 2022, 3:32 AM

#

err how do i do that

violet meadow Oct 23, 2022, 3:32 AM

#

MidiQOL settings => Workflow Settings => Misc tab click export

#

OK I can replicate with your settings.

dull condor Oct 23, 2022, 3:37 AM

#

speaking of my workflow settings a lot of stuff doesnt work :/

#

like i cant proc the midi reactions menu

#

it worked for like once first i tried, now it doesnt work (not sure if module conflict)

violet meadow Oct 23, 2022, 3:39 AM

#

If you choose Merge Cards the damageType repeat stops

dull condor Oct 23, 2022, 3:39 AM

#

also is there a syntax i can put in "other formula" so that it can show a dmg type?

violet meadow Oct 23, 2022, 3:40 AM

#

1d4[slashing]

dull condor Oct 23, 2022, 3:41 AM

#

wheres merge cards?

violet meadow Oct 23, 2022, 3:41 AM

#

dull condor https://media.discordapp.net/attachments/670336046164213761/1033581236830097468/...

@gilded yacht 10.0.15 Without Merge Cards the damage type is repeated for a damage formula like 1d4 + @mod +2 Slashing.
Intended?

violet meadow Oct 23, 2022, 3:42 AM

#

dull condor wheres merge cards?

below the export button from before

#

3rd checkbox below

dull condor Oct 23, 2022, 3:43 AM

#

o i found it... problem... im running retroactive advantage and merge cards destroys that

#

if midi could have roll20 style "2 rolls by default (or 3 with elven accuracy)" that would be fantastic 👀

#

for atk rolls/saves etc (anything that can have adv/disadv)

violet meadow Oct 23, 2022, 3:45 AM

#

elven accuracy is an option in special traits of the character sheet

dull condor Oct 23, 2022, 3:45 AM

#

ye but the player would need to roll with adv to proc it yea?

violet meadow Oct 23, 2022, 3:46 AM

#

yes, or use midi flags to auto roll with advantage etc

dull condor Oct 23, 2022, 3:46 AM

#

the roll20 way is to always roll with all 2 (or 3) rolls, so that all rolls are 1 click

violet meadow Oct 23, 2022, 3:46 AM

#

but if you are using Advantage Reminder, probably that will not be the case as AR doesn't play well with Fast Forward rolls

dull condor Oct 23, 2022, 3:47 AM

#

violet meadow yes, or use midi flags to auto roll with advantage etc

hmm i never tried, how reliable is it?

violet meadow Oct 23, 2022, 3:48 AM

#

I use it all the time. Needs setting up but you can automate conditions pretty robustly (with DFreds CE that has predefined 5e conditions that work with MidiQOL automation)

#

That means spending some time to get the hang of it

dull condor Oct 23, 2022, 3:49 AM

#

that means ditching CUB right

#

i had trouble just getting conc tracking right 🙃

#

with midi + cub

#

or even midi alone...

violet meadow Oct 23, 2022, 3:50 AM

#

#

Crazy double 20s with disadvantage between 😄

violet meadow Oct 23, 2022, 3:51 AM

#

dull condor with midi + cub

For concentration it is one or the other. I use MidiQOL

dull condor Oct 23, 2022, 3:51 AM

#

how does this automation thing handle things like underwater (do i need to define on the map whats underwater) or retroactive things like warding flare

violet meadow Oct 23, 2022, 3:51 AM

#

CUB and DFreds can play together

dull condor Oct 23, 2022, 3:52 AM

#

or straight up declared advantage things like tides of chaos or inspiration

violet meadow Oct 23, 2022, 3:52 AM

#

dull condor how does this automation thing handle things like underwater (do i need to defin...

You can create a condition on the tokens affected that will be an Active Effect with all the flags it might need for disadvantage.

#

If you are already using Advantage Reminder and you are OK with that workflow going full automation with Midi means that you will need to learn to make things differently and you will have to decide if the time that you will need to spend is worth it or not!

#

Anyways, off to bed! If you need anything ask and there will be users around that can help 😉

dull condor Oct 23, 2022, 3:55 AM

#

im not using advantage reminder rn, using retroactive advantage

#

thx bro

#

gn ^^

violet meadow Oct 23, 2022, 3:55 AM

#

ah my bad!

cerulean ocean Oct 23, 2022, 4:12 AM

#

is there a way to reference how many weapons someone has equipped?

celest bluff Oct 23, 2022, 5:39 AM

#

cerulean ocean is there a way to reference how many weapons someone has equipped?

9x token.actor.itemTypes.weapon.filter(i=> i.data.data.equipped);
10x token.actor.itemTypes.weapon.filter(i=> i.system.equipped);

#

you can also mix in i.hasDamage

cerulean ocean Oct 23, 2022, 6:09 AM

#

celest bluff 9x `token.actor.itemTypes.weapon.filter(i=> i.data.data.equipped);` 10x `token.a...

So I want to reference the number of equipped items for the purpose of calculation … (Equip items)*(d4)
Can I do it?

#

Like to add as a damage calculation to a weapon

#

so the more of this item the player has and can equip the more damage it does

gilded yacht Oct 23, 2022, 6:40 AM

#

violet meadow <@378398557050503168> 10.0.15 Without Merge Cards the damage type is repeated fo...

@dull condor Yes and no. I tag all of the terms with the damage type when creating the damage list so that dice so nice damage dice are coloured correctly, but it was unintended that the non-merged card display. I'll see if I can juggle it so that the display is as before and the dice are still coloured.
Should be 'fixed' in 10.0.16, the side effect of that is that dice so nice damage dice won't be coloured according to the damage type for non-merge card rolls.

molten solar Oct 23, 2022, 8:47 AM

#

scarlet gale What triggers does it have? Not at my PC to test it out.

Creating, deleting, hiding, and revealing the template, and when a token enters, leaves, or moves within the template.

kind cape Oct 23, 2022, 9:20 AM

#

molten solar Creating, deleting, hiding, and revealing the template, and when a token enters,...

What about when a creature starts it's turn within the template 🥺

molten solar Oct 23, 2022, 9:24 AM

#

See, I thought of that

#

But that would be a combat hook, so you might as well use Effect Macro or something.

#

Though I'm gonna make an api function to easily get all templates that contain the token.

kind cape Oct 23, 2022, 9:25 AM

#

But there is a bunch of logic that would need to be implemented in each of the EM macros

#

Plus it would complement how EM does it really logically, e.g. EM can do it if you have an effect, TM can do it if you are standing in an effect 🥺

#

Also one more question: is the macro triggered locally or globally, and if locally as I assume, which client is it run on, the template owner or the token owner?

molten solar Oct 23, 2022, 9:39 AM

#

The one creating, deleting, hiding, or revealing the template, unless you set the script to be run as GM (using the first GM found, does not require Advanced Macros)

#

and the one moving the token (unless you set the script to be run as GM (using the first GM found, does not require Advanced Macros)).

#

In other words, same as Door Macro. Praise Door Macro.

kind cape Oct 23, 2022, 9:44 AM

#

Alright so it depends on the context, makes sense

molten solar Oct 23, 2022, 9:46 AM

#

Yeah this way it should let you do whatever you want. And of course no args. 😏

violet meadow Oct 23, 2022, 9:47 AM

#

Blasphemy shame

scarlet gale Oct 23, 2022, 10:06 AM

#

Entering and leaving is easy enough to use to add an effect to do combat turn macros

#

I'm interested in what variables are available to work with

#

Like if you stay in the template during a move does it have the start and ending coords

#

Wall of fire is a good example of what I'd try to setup

molten solar Oct 23, 2022, 10:11 AM

#

What would you need for that?

scarlet gale Oct 23, 2022, 10:13 AM

#

Another big one is spike growth

#

Calculate the delta move in a template to apply damage

#

Cloud kill another good one

#

But that should be already doable with what you already have

#

Spike growth that doesn't rely on a buggy AA template is all I want lol

molten solar Oct 23, 2022, 10:19 AM

#

scene (document), template (placeable), userId (string), gmId (string), and sometimes token (placeable)

#

token is null for triggers on template creation for example. No token involved.

scarlet gale Oct 23, 2022, 10:20 AM

#

Makes sense

#

How does it handle a template getting moved

molten solar Oct 23, 2022, 10:21 AM

#

It doesn't. Not a bad idea tho.

scarlet gale Oct 23, 2022, 10:21 AM

#

Can come up with cloudkill

#

I'd want to make sure a token that doesn't move, but otherwise leaves the template is captured

molten solar Oct 23, 2022, 10:23 AM

#

Would you want the top-left coords of a token or the center?

#

If I pass the previous and new coordinates

scarlet gale Oct 23, 2022, 10:24 AM

#

Whatever it uses already in the token info is probably easiest

molten solar Oct 23, 2022, 10:24 AM

#

That's the top left.

scarlet gale Oct 23, 2022, 10:25 AM

#

That would make it easier to do comparisons with other tokens

molten solar Oct 23, 2022, 10:35 AM

#

What would you want from a trigger when a template is moved?

#

Just its new coordinates?

scarlet gale Oct 23, 2022, 10:35 AM

#

Can't you grab that from the template?

#

Just a trigger honestly. So we could do cleanup on actors no longer in the template.

molten solar Oct 23, 2022, 10:37 AM

#

mmm. A helper function to get all tokens within a template could be fun.

#

We all agree that sharing at least 1 grid space is enough to be considered "inside", surely

scarlet gale Oct 23, 2022, 10:38 AM

#

I saw you mentioned that in your GitHub issues

molten solar Oct 23, 2022, 10:39 AM

#

Yeah only got the opposite currently - get all templates that contain a token

scarlet gale Oct 23, 2022, 10:39 AM

#

But yes

celest bluff Oct 23, 2022, 10:39 AM

#

Cloudkill is pretty easy with Active Auras

scarlet gale Oct 23, 2022, 10:39 AM

#

I'm trying to not use that

#

AA hates high ping players

celest bluff Oct 23, 2022, 10:41 AM

#

you can't use overtime time for this

#

have it deal damage on on and each start

scarlet gale Oct 23, 2022, 10:41 AM

#

See #1010273821401555087 message

celest bluff Oct 23, 2022, 10:41 AM

#

or i suppose you could have a overtime for each

molten solar Oct 23, 2022, 10:41 AM

#

(did you read the rest of the conversation or....)

celest bluff Oct 23, 2022, 10:42 AM

#

have it check for itself so doesn't apply twice

scarlet gale Oct 23, 2022, 10:42 AM

#

I was just giving examples of spells that could be reworked with Zhells new shiny template macros

molten solar Oct 23, 2022, 10:43 AM

#

Anyway. A trigger when a template is moved, which gives you template, scene, and maaaybe an array of token ids?

scarlet gale Oct 23, 2022, 10:43 AM

#

Plus AA not officially on v10

#

Yea

#

Or a helper

#

That we just pass the template ID or something

molten solar Oct 23, 2022, 10:44 AM

#

Yeah not much need to pass them to the trigger if I just make an api function.

scarlet gale Oct 23, 2022, 10:44 AM

#

If that isn't already core

molten solar Oct 23, 2022, 10:45 AM

#

Getting all tokens contained within a template?

#

No quick core method, but it's close.

scarlet gale Oct 23, 2022, 10:45 AM

#

I never messed with templates beyond initial targeting

#

A quick way to find all tokens in the already placed template is ideal

hot flower Oct 23, 2022, 10:50 AM

#

can someone help me out with something midi here. I'm trying to educate myself on damageOnlyWorkflow. I've written a super simple macro based on @gilded yacht's example of divine smite. it's this: ```js
console.log("args[0]:", args[0])
let target = await fromUuid(args[0].hitTargetUuids[0] ?? "");
console.log("target:", target);
let damageRoll = new Roll(2d6).roll();
console.log("damageRoll:", damageRoll);
console.log("actor:", actor);
console.log("token:", token);
console.log("itemCardId:", args[0].itemCardId);

new MidiQOL.DamageOnlyWorkflow(actor, token, damageRoll.total, "bludgeoning", target ? [target] : [], damageRoll, { flavor: "Falling Damage!", itemCardId: args[0].itemCardId })```

#

i've got it on a very basic item: it does 1d4 damage and rolls the itemMacro.

#

but I keep getting this error: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'length') [Detected 1 package: midi-qol] at createDamageList (utils.js:119:29) at new DamageOnlyWorkflow (workflow.js:3041:23) at eval (eval at callMacro (workflow.js:1591:15), <anonymous>:13:1)

#

everything is returning true actor, target, etc., in the console.log.

#

and the DamageOnlyWorkflow is taken straight from his example on his readme.

#

so... I'm not sure what I'm doing wrong.

scarlet gale Oct 23, 2022, 10:52 AM

#

Using that macro as is?

hot flower Oct 23, 2022, 10:53 AM

#

the macro I have posted above is the one I'm using.

molten solar Oct 23, 2022, 10:53 AM

#

await new Roll("2d6").roll();

#

Evaluating rolls is async

#

It probably chokes because damageRoll.total is undefined

scarlet gale Oct 23, 2022, 10:54 AM

#

Looks like the example is dated

hot flower Oct 23, 2022, 10:54 AM

#

yes, that fixed it. Tim's example on the page is out of date.

#

thank you.

#

thank you, @molten solar

celest bluff Oct 23, 2022, 10:55 AM

#

usually the system will mention rolls needs async:true or asyc:false in a console.warn

scarlet gale Oct 23, 2022, 10:59 AM

#

A trigger for a token starting its turn and ending its turn in the template sounds potentially useful, but it's also easy enough to just apply an effect macro for the same thing.

molten solar Oct 23, 2022, 11:02 AM

#

Yeah, I can't think of a situation in which you wouldn't have had the opportunity to apply an effect to them already

#

Either when the template was created, or when it was moved

scarlet gale Oct 23, 2022, 11:02 AM

#

Entering and leaving the template may also need the move coords too

molten solar Oct 23, 2022, 11:03 AM

#

Sure, already added

#

The token's coords, that is

scarlet gale Oct 23, 2022, 11:03 AM

#

Yep

#

Lmk when that version is out. I'd love to have a crack at spike growth and cloudkill with it.

coarse mesa Oct 23, 2022, 11:07 AM

#

Now we just need Token Macro

scarlet gale Oct 23, 2022, 11:07 AM

#

Isn't that just effect macros?

#

Well kinda

molten solar Oct 23, 2022, 11:10 AM

#

coarse mesa Now we just need Token Macro

Middle-mouse-click a token to trigger an embedded macro? lol

narrow saddle Oct 23, 2022, 11:11 AM

#

scarlet gale A trigger for a token starting its turn and ending its turn in the template soun...

That’s what I wanted with Hunger of Hadar however it works perfectly well with midi overtime and active auras.
Start of turn auto cold damage and end of turn if still in it acid damage with a save.

scarlet gale Oct 23, 2022, 11:11 AM

#

Anyone know an easy way to export effects as json?

coarse mesa Oct 23, 2022, 11:11 AM

#

If there was an easy way to have a template move with a token then we wouldn’t need auras. AA was painful in our session tonight again 😞

molten solar Oct 23, 2022, 11:11 AM

#

scarlet gale Anyone know an easy way to export effects as json?

put them in items

molten solar Oct 23, 2022, 11:11 AM

#

coarse mesa If there was an easy way to have a template move with a token then we wouldn’t n...

is Token Attacher not easy? I don't use it so I dunno

scarlet gale Oct 23, 2022, 11:12 AM

#

Attach the template with token attacher

coarse mesa Oct 23, 2022, 11:12 AM

#

molten solar is Token Attacher not easy? I don't use it so I dunno

It’s pretty manual afaik

molten solar Oct 23, 2022, 11:12 AM

#

I'm sure you can write a macro for it.

narrow saddle Oct 23, 2022, 11:12 AM

#

coarse mesa If there was an easy way to have a template move with a token then we wouldn’t n...

I ran a session last week with Darkmantles and the aura just followed them round. The aura of darkness was on the tokens.

scarlet gale Oct 23, 2022, 11:12 AM

#

It's easy enough to do manually

#

But that's not what we're in midi-qol for.

coarse mesa Oct 23, 2022, 11:13 AM

#

So template macro can replace AA then?

scarlet gale Oct 23, 2022, 11:14 AM

#

Technically yes

#

Keep in mind using template macros to do it is less user friendly

#

Build a bonus should be used when you can

molten solar Oct 23, 2022, 11:15 AM

#

This is my channel now. /s

coarse mesa Oct 23, 2022, 11:16 AM

#

If there was some way to use crosshairs or something to “stick” a template to a token or automatically have it stuck to the caster then we would be golden

scarlet gale Oct 23, 2022, 11:17 AM

#

Essentially template macros gives us the foundation to apply effects to those in it

molten solar Oct 23, 2022, 11:18 AM

#

coarse mesa If there was some way to use crosshairs or something to “stick” a template to a ...

A macro triggered when the template is created...?

scarlet gale Oct 23, 2022, 11:18 AM

#

I think token attacher has an api

#

It didn't seem well documented last I looked

#

But yes on template creation to call whatever function that module has to attach it would do it

coarse mesa Oct 23, 2022, 11:20 AM

#

That seems like the basic approach Atro was hinting at. Using templates for auras

scarlet gale Oct 23, 2022, 11:20 AM

#

https://github.com/KayelGee/token-attacher#macros

GitHub

GitHub - KayelGee/token-attacher

Contribute to KayelGee/token-attacher development by creating an account on GitHub.

violet meadow Oct 23, 2022, 11:21 AM

#

Oh damn I was about to post for the top left Vs center question but I saw 100 messages after

#

What happens with larger tokens?

scarlet gale Oct 23, 2022, 11:23 AM

#

Does foundry natively deal with that?

violet meadow Oct 23, 2022, 11:23 AM

#

Nope it's always top left I think. You need to get the size and test the center 🤔

coarse mesa Oct 23, 2022, 11:24 AM

#

scarlet gale https://github.com/KayelGee/token-attacher#macros

This does seem promising

molten solar Oct 23, 2022, 11:24 AM

#

The functions I stuffed in the API (in babonus as well) calculate distance between each center of every grid cell you occupy

#

So if you're Large, it calculates 4 centers

scarlet gale Oct 23, 2022, 11:25 AM

#

3 modules needed to replace 1, what an upgrade

molten solar Oct 23, 2022, 11:25 AM

#

It's the high automation way

scarlet gale Oct 23, 2022, 11:27 AM

#

AA also interacted with multi level modules, but I won't miss that

molten solar Oct 23, 2022, 11:27 AM

#

As in the Levels module?

violet meadow Oct 23, 2022, 11:28 AM

#

Damn interesting convo but I am on the road. will catch up later

molten solar Oct 23, 2022, 11:28 AM

#

I'm not touching that with a 10 ft pole

scarlet gale Oct 23, 2022, 11:28 AM

#

Multi level token apparently

#

I've never used it

kind cape Oct 23, 2022, 11:29 AM

#

Actually a good question, how do you interact with Levels and its volumetric templates?

scarlet gale Oct 23, 2022, 11:29 AM

#

Pretty sure that predates levels

molten solar Oct 23, 2022, 11:29 AM

#

kind cape Actually a good question, how do you interact with Levels and its volumetric tem...

how about

kind cape Oct 23, 2022, 11:29 AM

#

MLT was always a bit of jank, though the newer versions are less janky

kind cape Oct 23, 2022, 11:29 AM

#

molten solar how about <:no:829457740370935838>

What about elevation in general?

molten solar Oct 23, 2022, 11:30 AM

#

A much easier addition.

scarlet gale Oct 23, 2022, 11:30 AM

#

Nothing stopping us from doing that ourselves in the macro

kind cape Oct 23, 2022, 11:30 AM

#

scarlet gale Nothing stopping us from doing that ourselves in the macro

That is a fair point, though having it interact nicely with volumetric templates and levels would mean stuff blocked by roofs/floors 😉

molten solar Oct 23, 2022, 11:31 AM

#

yall bein greedy

scarlet gale Oct 23, 2022, 11:31 AM

#

Seems outside the scope

kind cape Oct 23, 2022, 11:31 AM

#

Always have been 😉

coarse mesa Oct 23, 2022, 11:31 AM

#

Sooo Spirit Guardians with Template Macro, Effect Macro and Token Attacher?

molten solar Oct 23, 2022, 11:32 AM

#

Don't be silly

#

You need Item Macro and Note Macro too

#

for no reason at all

kind cape Oct 23, 2022, 11:32 AM

#

😂

molten solar Oct 23, 2022, 11:32 AM

#

Ooooh

#

Dungeon puzzle: door can't be opened unless under the effect of Spirit Guardians. Door Macro™️ 😎

#

Apply macro directly to the door.

kind cape Oct 23, 2022, 11:34 AM

#

Apply forehead directly to door! 😄

molten solar Oct 23, 2022, 11:35 AM

#

Cody wrote in the email when it was approved that it made him want to run away screaming. 😦

coarse mesa Oct 23, 2022, 11:36 AM

#

As I’m not on v10 and don’t know how this works… can a template macro and any effect macros it calls all be on an item?

molten solar Oct 23, 2022, 11:38 AM

#

I put the macro config in both the item and on each template. When a template is created, it tries to find the item that created it (there is a flag in dnd5e for this now), and then it just takes the flag data from the item and copies it

#

So if you put the Template Macro in the item, all templates have them.

#

Effect Macros, however, are in effects, not items.

scarlet gale Oct 23, 2022, 11:40 AM

#

I'm going to embed the effect in the macro when I make it with what I'm doing

coarse mesa Oct 23, 2022, 11:40 AM

#

OK I’m adding CE to my list of modules for Spirit Guardians then

molten solar Oct 23, 2022, 11:41 AM

#

What does CE do in this case?

coarse mesa Oct 23, 2022, 11:42 AM

#

Keeps my effects tidy and gives me a nice description when they’re running

#

CE + EM is working great for me

scarlet gale Oct 23, 2022, 11:43 AM

#

game.dfreds.effectInterface.addEffect({ effectName: 'Effect Name', uuid }); a lazy way to do it

molten solar Oct 23, 2022, 11:44 AM

#

https://github.com/krbz999/templatemacro/releases/tag/v0.0.2

scarlet gale Oct 23, 2022, 11:44 AM

#

Just make the spirit guardians effect then add that effect via enter and leave

coarse mesa Oct 23, 2022, 11:44 AM

#

I just made Aura of Life using CE + EM … and AA 😦

molten solar Oct 23, 2022, 11:45 AM

#

Yall really don't like AA it seems. I thought you guys swore by it.

scarlet gale Oct 23, 2022, 11:45 AM

#

More like no other options

kind cape Oct 23, 2022, 11:45 AM

#

We swear by it as making a lot of stuff possible, but it's still janky

coarse mesa Oct 23, 2022, 11:45 AM

#

In theory it’s amazing, in practice it’s doing way more harm than it should

molten solar Oct 23, 2022, 11:46 AM

#

How does it work?

#

Applies effects every time a token moves?

scarlet gale Oct 23, 2022, 11:46 AM

#

Adds a new tab to effects that you configure and it updates effects to tokens around it

#

based on how it's configured

kind cape Oct 23, 2022, 11:46 AM

#

Not quite, it only applies if the token does not already have it, but other than that basically

#

(to the movement)

scarlet gale Oct 23, 2022, 11:47 AM

#

In reality, it it likes to have the same effect show up 2-4 more times than it should on nearby tokens

#

Cause reasons

#

¯_(ツ)_/¯

coarse mesa Oct 23, 2022, 11:47 AM

#

Except sometimes it does apply the AE even if the token already has it

molten solar Oct 23, 2022, 11:47 AM

#

I assume it runs through the GM?

kind cape Oct 23, 2022, 11:47 AM

#

Oftentimes those are not actual instances, as in they are not saved to the database, those are phantoms

#

But they still are treated as real in the local client of course

scarlet gale Oct 23, 2022, 11:48 AM

#

It picks a GM to handle it

#

I'm of the opinion for whatever reason it also selects a spare player or two

#

and that's where the phantom issues pop up

molten solar Oct 23, 2022, 11:49 AM

#

Ah, and then the player moving too quickly can trigger it multiple times due to latency.

scarlet gale Oct 23, 2022, 11:49 AM

#

or that

coarse mesa Oct 23, 2022, 11:49 AM

#

It seems to get really unhinged on my familiar especially

kind cape Oct 23, 2022, 11:49 AM

#

Yeah multiple phantoms are usually due to latency

molten solar Oct 23, 2022, 11:49 AM

#

tbh that might be impossible to avoid

kind cape Oct 23, 2022, 11:50 AM

#

Tbf, I'm not sure applying a full synchronized AE is the way to go tbh, I think that potentially a more local solution would be more stable and less laggy

molten solar Oct 23, 2022, 11:51 AM

#

What, praytell, is a sync AE

scarlet gale Oct 23, 2022, 11:51 AM

#

Can clients put active effects on non owned tokens?

coarse mesa Oct 23, 2022, 11:51 AM

#

My ignorant brain is saying why doesn’t it check if something already exists?

molten solar Oct 23, 2022, 11:51 AM

#

coarse mesa My ignorant brain is saying why doesn’t it check if something already exists?

Ask that twenty times and you might not get the answer before the 5th

kind cape Oct 23, 2022, 11:51 AM

#

coarse mesa My ignorant brain is saying why doesn’t it check if something already exists?

It does, most likely, but due to a race condition the check is performed multiple times before it gets too apply it

molten solar Oct 23, 2022, 11:52 AM

#

"no, no, no, no, yes" -> 4 effects

kind cape Oct 23, 2022, 11:53 AM

#

molten solar What, praytell, is a *sync AE*

Synchronized as in actual AE. Imagine if it instead calculated and applied a fake AE client-side that was never saved to the DB. No need for sockets then, though it might cause other issues 🙃

coarse mesa Oct 23, 2022, 11:53 AM

#

Is this why BG3 is taking so long? Auras are impossible?

molten solar Oct 23, 2022, 11:53 AM

#

kind cape Synchronized as in actual AE. Imagine if it instead calculated and applied a fak...

let's not.

kind cape Oct 23, 2022, 11:54 AM

#

coarse mesa Is this why BG3 is taking so long? Auras are impossible?

Nah, they just need to implement everything from the bottom up 😛

molten solar Oct 23, 2022, 11:57 AM

#

Probably easier since they got one 'client' (the game itself) doing an aura, while we got three parts; player moving, server side, and the GM, all trying to be in sync

#

though I havent touched bg3

coarse mesa Oct 23, 2022, 11:59 AM

#

molten solar Probably easier since they got one 'client' (the game itself) doing an aura, whi...

BG3 has co-op but I guess the server has more dominance

kind cape Oct 23, 2022, 12:00 PM

#

This did just give me an idea though.. If AA only ran on the GM (and yes, sometimes there are more GMs, ignore that), as in it just exited out early on non-GM clients, it might actually be less jank 🤔

scarlet gale Oct 23, 2022, 12:01 PM

#

I was looking at it's github, I'm pretty sure it already does that

molten solar Oct 23, 2022, 12:01 PM

#

I am letting you do that in TM, executing all scripts as GM.

scarlet gale Oct 23, 2022, 12:01 PM

#

@molten solar What's the variable names for location stuff that was added?

molten solar Oct 23, 2022, 12:03 PM

#

console.log(this)

coarse mesa Oct 23, 2022, 12:03 PM

#

Ok I’m off to bed now. With the brainpower in here I look forward to waking up to a solution to auras in FVTT 👋

late briar Oct 23, 2022, 12:09 PM

#

Heya, I am currently trying to automate my paladins Divine Smite on Foundry v10 using midi-qol.
I am using the Divine Smite from the Midi SRD and everything seems to work fine, except that I can not get the Smite critically hit.
Do I have to press some special keys in order for it to work?

pulsar pawn Oct 23, 2022, 12:11 PM

#

Hey man, could you drop me a DM on how to set it up correctly or just send me a screenshot?

scarlet gale Oct 23, 2022, 12:12 PM

#

pulsar pawn Hey man, could you drop me a DM on how to set it up correctly or just send me a ...

Do you have the module effect macros?

pulsar pawn Oct 23, 2022, 12:13 PM

#

(╯°□°）╯︵ ┻━┻

#

thought its a AE with a macro ...

scarlet gale Oct 23, 2022, 12:14 PM

#

Sorry, guess I didn't describe that well enough in the description. It uses the module Effect Macros, it's run as a end of turn macro inside the effect.

#

You'll also need the fork of Active Auras that works with v10

pulsar pawn Oct 23, 2022, 12:14 PM

#

I fixed AA myself, assuming that is the same fix tho x)

scarlet gale Oct 23, 2022, 12:15 PM

#

kind cape Oct 23, 2022, 12:19 PM

#

late briar Heya, I am currently trying to automate my paladins Divine Smite on Foundry v10 ...

Are you using the macro or no macro version?

late briar Oct 23, 2022, 12:20 PM

#

I tried both and neither worked.

#

Do I need to disable Auto Fast Forward of damage roles for it so players can manually click "Critical Hit" or "Normal Hit" for the damage roll?

kind cape Oct 23, 2022, 12:22 PM

#

If you hold down T while you roll it it should show the normal item card, then you can do critical from there.

Technically holding down C should force a critical, but not sure that works with fast-forward

late briar Oct 23, 2022, 12:23 PM

#

I did try using C but that only works with the chat-card buttons.

#

Is it possible to disable fastforward for certain spells? Otherwise I guess I have to remind myself and my players to hold T for divine smite 🙂

pulsar pawn Oct 23, 2022, 12:25 PM

#

scarlet gale

can you drop me the fork link for the fixed AA?

kind cape Oct 23, 2022, 12:26 PM

#

late briar Is it possible to disable fastforward for certain spells? Otherwise I guess I ha...

Might be possible with a macro actually, but not natively as far as I know

late briar Oct 23, 2022, 12:28 PM

#

Well everything is possible with a macro 😄
I guess I can also just roll without forwarding damage ever. One more click is not gonna hurt people... hopefully 😂

kind cape Oct 23, 2022, 12:29 PM

#

I'm looking at the workflow right now to see if its possible, give me a minute 😉

scarlet gale Oct 23, 2022, 12:31 PM

#

pulsar pawn can you drop me the fork link for the fixed AA?

https://raw.githubusercontent.com/fotoply/Active-Auras/main/module.json
I think it's this one.

kind cape Oct 23, 2022, 12:36 PM

#

late briar Well everything is possible with a macro 😄 I guess I can also just roll without...

Got it!

#

Which version did you prefer? The macro or non-macro version?

#

All you need to add is

const workflow = MidiQOL.Workflow.getWorkflow(args[0].uuid);
workflow.rollOptions.fastForwardDamage = false;

But it needs to happen at the right step.

So you can create a new macro in the world, call it something like Force damage dialog, then you put the code above into it.

Then in any item where you want to force the dialog you add in the following in the onUse macro section:

#

Its very important that it happens at that step through, as otherwise other things may reset the flag

late briar Oct 23, 2022, 12:41 PM

#

ah

#

So it needs to happen as late as possible but still early enough?

scarlet gale Oct 23, 2022, 12:42 PM

#

@molten solar Do you know if Foundry has a native way to count distance between grid spaces that uses the game settings for diagonals?

late briar Oct 23, 2022, 12:42 PM

#

kind cape Which version did you prefer? The macro or non-macro version?

I preferred the macro version.

#

Is the same workflow passed to all macros in the onUse section?

kind cape Oct 23, 2022, 12:43 PM

#

Yes

molten solar Oct 23, 2022, 12:43 PM

#

scarlet gale <@369247716225712139> Do you know if Foundry has a native way to count distance ...

it do

kind cape Oct 23, 2022, 12:43 PM

#

And also yes, it needs to happen before the damage roll but as late as possible

molten solar Oct 23, 2022, 12:44 PM

#

canvas.grid.measureDistance(original, other, {gridSpaces: true});

kind cape Oct 23, 2022, 12:44 PM

#

Also you can disregard the macro vs non-macro question, at first I thought I would have to modify the macro, but then I realized that you could just put it in world scope and add multiple 😛

scarlet gale Oct 23, 2022, 12:44 PM

#

what would original and other be in that context?

molten solar Oct 23, 2022, 12:44 PM

#

I think that uses whatever option you have set

#

Two placeables

#

uses their top-left corner, however

scarlet gale Oct 23, 2022, 12:45 PM

#

So not arbitrary coords?

#

hmm

molten solar Oct 23, 2022, 12:45 PM

#

No, for that you want to construct Rays and use canvas.grid.measureDistances

#

which takes an array of rays. 😄

#

an a-Ray if you will

#

or actually it takes an array of objects that has ray: Ray 🤔

scarlet gale Oct 23, 2022, 12:46 PM

#

Testing out my template macro and realized it's rounding in a not ideal way

molten solar Oct 23, 2022, 12:48 PM

#

not using the api?

scarlet gale Oct 23, 2022, 12:48 PM

#

oh, I didn't even look at that

pulsar pawn Oct 23, 2022, 12:49 PM

#

I get a ```js
await is only valid in async functions and the top level bodies of modules

message

scarlet gale Oct 23, 2022, 12:49 PM

#

pulsar pawn I get a ```js await is only valid in async functions and the top level bodies of...

Oh, hold on

#

easy fix

#

I was including my helper functions in that, so that was a copy and paste issue

#

I think that should fix it

scarlet gale Oct 23, 2022, 12:51 PM

#

molten solar not using the api?

Are you talking about your API for this module or the Foundry API?

pulsar pawn Oct 23, 2022, 12:51 PM

#

Unexpected identifier 'showMenu'

scarlet gale Oct 23, 2022, 12:52 PM

#

pulsar pawn `Unexpected identifier 'showMenu'`

bleh hold on

late briar Oct 23, 2022, 12:52 PM

#

kind cape Also you can disregard the macro vs non-macro question, at first I thought I wou...

okay, thanks a lot!

molten solar Oct 23, 2022, 12:52 PM

#

scarlet gale Are you talking about your API for this module or the Foundry API?

this module

#

You want all tokens within the template, or all templates that have the token, right?

scarlet gale Oct 23, 2022, 12:53 PM

#

not for this

pulsar pawn Oct 23, 2022, 12:53 PM

#

(offtopic: Is there a proper IDE like lines module for macro fields xX)

scarlet gale Oct 23, 2022, 12:53 PM

#

📎 Twilight_Sanctuary.js

#

I put the async on the wrong side lol

scarlet gale Oct 23, 2022, 12:54 PM

#

molten solar You want all tokens within the template, or all templates that have the token, r...

I'm currently setting up Spike Growth

pulsar pawn Oct 23, 2022, 12:54 PM

#

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'classes')
[Detected 1 package: effectmacro]
    at eval (eval at executeScripts (main.mjs:21:18), <anonymous>:5:33)
    at Object.eval (eval at executeScripts (main.mjs:21:18), <anonymous>:63:9)
    at EM.executeScripts (main.mjs:22:16)

scarlet gale Oct 23, 2022, 12:55 PM

#

On v10 right?

pulsar pawn Oct 23, 2022, 12:55 PM

#

correct

scarlet gale Oct 23, 2022, 12:55 PM

#

Person has levels in cleric?

molten solar Oct 23, 2022, 12:55 PM

#

scarlet gale I'm currently setting up Spike Growth

dont remember the spell offhand.

pulsar pawn Oct 23, 2022, 12:55 PM

#

The caster yes

scarlet gale Oct 23, 2022, 12:56 PM

#

molten solar dont remember the spell offhand.

I just need to calculate how my grid squares they moved

pulsar pawn Oct 23, 2022, 12:56 PM

#

oh wait, its a CE, that is applied to the caster by hand. is that a problem?

scarlet gale Oct 23, 2022, 12:56 PM

#

pulsar pawn oh wait, its a CE, that is applied to the caster by hand. is that a problem?

Yes

#

It's grabbing it via the origin, I expected that to be a feature

pulsar pawn Oct 23, 2022, 12:56 PM

#

Doesnt CE applying via name matching keep the origin? 😦

scarlet gale Oct 23, 2022, 12:57 PM

#

Are you setting this up so you press the convenient effect?

pulsar pawn Oct 23, 2022, 12:58 PM

#

No, i press the feature in the PCs sheet

scarlet gale Oct 23, 2022, 12:58 PM

#

that should work then

pulsar pawn Oct 23, 2022, 12:58 PM

#

(╯°□°）╯︵ ┻━┻

scarlet gale Oct 23, 2022, 12:58 PM

#

let me test locally

#

before pasting it again

#

And the feature is set to target self

#

Using DAE to make the effect?

pulsar pawn Oct 23, 2022, 1:00 PM

#

scarlet gale Oct 23, 2022, 1:01 PM

#

Yea, don't do it that way

molten solar Oct 23, 2022, 1:01 PM

#

scarlet gale I just need to calculate how my grid squares they moved

Maybe this is useful?

📎 message.js

scarlet gale Oct 23, 2022, 1:01 PM

#

on the feature, click the button that says DAE

#

and configure it there

pulsar pawn Oct 23, 2022, 1:01 PM

#

okay, so CE doesn't keep origin around?

scarlet gale Oct 23, 2022, 1:01 PM

#

or changes it in a way I didn't plan on when I made it

#

You'll also want to delete the CE or at least check don't apply CE for that feature

molten solar Oct 23, 2022, 1:05 PM

#

try gridSpaces: true and just use the parts you need

scarlet gale Oct 23, 2022, 1:05 PM

#

that still wants tokens

#

I need to edit it to just use my own provided coords

molten solar Oct 23, 2022, 1:05 PM

#

Yeah just change it up a bit to use coordinates

pulsar pawn Oct 23, 2022, 1:07 PM

#

Works now 👌

scarlet gale Oct 23, 2022, 1:07 PM

#

Coolio

pulsar pawn Oct 23, 2022, 1:08 PM

#

Is there a nice way to label the roll as "temp hp from twilight sanc" like?

scarlet gale Oct 23, 2022, 1:09 PM

#

You should be able to edit line 55

pulsar pawn Oct 23, 2022, 1:09 PM

#

that is midiqol code?

scarlet gale Oct 23, 2022, 1:09 PM

#

It's just using damageRoll.toMessage to make the message

#

I didn't want the full cardbox for Sanctuary every time it applied

#

because it can be quite spammy with a lot of allies

pulsar pawn Oct 23, 2022, 1:11 PM

#

yeah, just right now it provides no context on what is rolled ^^

scarlet gale Oct 23, 2022, 1:11 PM

#

Gonna sound dumb, but I don't actually know the format for making chat messages

#

that part was just a copy and paste

molten solar Oct 23, 2022, 1:14 PM

#

add flavor: "your flavor text here"

pulsar pawn Oct 23, 2022, 1:14 PM

#

already on it 😛

#

Works

scarlet gale Oct 23, 2022, 1:35 PM

#

@molten solar Any way to get the template when working inside "When Entered" and "When Left" ?

#

I need to look at the template to get it's radius so I can subtract that from the distance calculations when they're moving in and out of spike growth.

molten solar Oct 23, 2022, 1:38 PM

#

Is there not template in the macro when you move the template?

scarlet gale Oct 23, 2022, 1:39 PM

#

oh sorry, meant when entered

#

molten solar Oct 23, 2022, 1:40 PM

#

But template is the template you leave or enter. 🤔

#

console.log(template)

scarlet gale Oct 23, 2022, 1:41 PM

#

OH

#

I thought it was only the stuff in this I had to work with

molten solar Oct 23, 2022, 1:41 PM

#

Nah, this, template, scene, and token

#

token sometimes null, and this sometimes has different stuff

#

but template and scene should always be there

#

No documentation for pre-releases. 👍 😂

scarlet gale Oct 23, 2022, 1:42 PM

#

Cost of living on the edge

late briar Oct 23, 2022, 1:49 PM

#

@kind cape Hey, regarding the Divine Smite discussion from earlier.
So I have created a macro called "Force damage dialog" with the code you provided and added it as a onUse macro with the right trigger "Before Damage Roll".
Still, it seems the damage is rolled automatically and instantly.

#

Do I have to change something regarding the ItemMacro in the Divine Smite?

#

or do I have to name the macro without spaces?

kind cape Oct 23, 2022, 1:52 PM

#

Should not be nessecary, can you check in the console (F12) if there is any warnings/errors that appear when you use the item?

late briar Oct 23, 2022, 1:55 PM

#

nope. no errors, no warnings.

kind cape Oct 23, 2022, 1:56 PM

#

Could you take a screenshot of your details tab?

scarlet gale Oct 23, 2022, 1:57 PM

#

if (canvas.scene.grid.units != 'ft') return;
let x1 = this.coords.previous.x;
let x2 = this.coords.current.x;
let y1 = this.coords.previous.y;
let y2 = this.coords.current.y;
let ray = new Ray({x: x1, y: y1}, {x: x2, y: y2});
let [distanceFeet] = canvas.grid.measureDistances([{ray}], {gridSpaces:true});
let distance = distanceFeet / canvas.scene.grid.distance;
let damageDice = (4 * distance) + 'd4';
let diceRoll = await new Roll(damageDice).roll({async: true});
let diceTotal = diceRoll.total;
diceRoll.toMessage({
    rollMode: 'roll',
    speaker: {alias: name},
    flavor: 'Spike Growth Damage'
});
let token = canvas.tokens.get(this.tokenId);
await MidiQOL.applyTokenDamage(
    [
        {
            damage: diceTotal,
            type: 'piercing'
        }
    ],
    diceTotal,
    new Set([token]),
    null,
    null
);```
This is what I have so far, works well.  I just need to figure out what kind of dumb math I'll need to handle cases of the token starting outside of the template.

#

As of right now, throwing this inside of "When Staying" works great.

late briar Oct 23, 2022, 1:58 PM

#

@kind cape sure, here

kind cape Oct 23, 2022, 1:59 PM

#

And a screenshot of your macro?

molten solar Oct 23, 2022, 1:59 PM

#

scarlet gale ```js if (canvas.scene.grid.units != 'ft') return; let x1 = this.coords.previous...

Difference between template radius and distance to token starting position?

scarlet gale Oct 23, 2022, 2:01 PM

#

yea

molten solar Oct 23, 2022, 2:01 PM

#

you can also just do ```js
const {previous, current} = this.coords;
const ray = new Ray(previous, current);

late briar Oct 23, 2022, 2:01 PM

#

kind cape Oct 23, 2022, 2:03 PM

#

Hmm, could you try it on the non-macro version?

scarlet gale Oct 23, 2022, 2:04 PM

#

I'm sure there is some Ray thing I can do

late briar Oct 23, 2022, 2:05 PM

#

the non-macro version works

kind cape Oct 23, 2022, 2:05 PM

#

Hmm, the macro must be doing something then

late briar Oct 23, 2022, 2:06 PM

#

it does a new damage only workflow, but it still reads the "isCritical" from the args[0]

#

but not really something that should interfere with disabling fastforwarding before it happens...

kind cape Oct 23, 2022, 2:08 PM

#

Actually that might be interfering, since it might re-set the options based on your settings 🤔

#

Is the non-macro version adequate for you?

late briar Oct 23, 2022, 2:09 PM

#

sure

#

it seems to work RAW

molten solar Oct 23, 2022, 2:10 PM

#

scarlet gale I'm sure there is some Ray thing I can do

Or insist everyone moves one grid space at a time

kind cape Oct 23, 2022, 2:10 PM

#

Moving one grid at a time is probably also a good idea so that you don't get surprised with the amount of damage you suddenly take 😛

scarlet gale Oct 23, 2022, 2:11 PM

#

I thought about that lol

molten solar Oct 23, 2022, 2:11 PM

#

But if you manage to invent a 'distance travelled through template' function, I'd like to adf it to the api.

late briar Oct 23, 2022, 2:11 PM

#

@kind cape how did you find what fields and properties the workflow has?

scarlet gale Oct 23, 2022, 2:11 PM

#

Pretty sure my geometry teacher would be upset with me right now

#

I'm blanking on what to do

kind cape Oct 23, 2022, 2:12 PM

#

late briar <@132588829663035392> how did you find what fields and properties the workflow h...

const workflow = MidiQOL.Workflow.getWorkflow(args[0].uuid);
console.log(workflow);

As an onUse macro

#

Then you can explore the element in the console

late briar Oct 23, 2022, 2:12 PM

#

ahhh

kind cape Oct 23, 2022, 2:13 PM

#

There is also the source code for the workflow in the MIDI repo, which can be useful when trying to figure out timings 😛

late briar Oct 23, 2022, 2:14 PM

#

I think it doesn't show the dialog for damage since the spell itself has no damage

#

at least the macro version

scarlet gale Oct 23, 2022, 2:15 PM

#

@molten solar What happens when a token passes through a template, but winds up not landing in it?

#

Presumably it doesn't get counted for anything right?

molten solar Oct 23, 2022, 2:16 PM

#

correct

#

uses starting and ending coords only

scarlet gale Oct 23, 2022, 2:16 PM

#

makes sense

#

and hard to deal with

late briar Oct 23, 2022, 2:16 PM

#

though giving the item any damage doesn't fix it either. The args[0].isCritical parameter is still not true

#

actually, its not even false, its undefined.

scarlet gale Oct 23, 2022, 2:19 PM

#

Updated macro:

if (canvas.scene.grid.units != 'ft') return;
let {previous, current} = this.coords;
let ray = new Ray(previous, current);
let [distanceFeet] = canvas.grid.measureDistances([{ray}], {gridSpaces:true});
let distance = distanceFeet / canvas.scene.grid.distance;
let damageDice = (4 * distance) + 'd4';
let diceRoll = await new Roll(damageDice).roll({async: true});
let diceTotal = diceRoll.total;
diceRoll.toMessage({
    rollMode: 'roll',
    speaker: {alias: name},
    flavor: 'Spike Growth Damage'
});
let token = canvas.tokens.get(this.tokenId);
await MidiQOL.applyTokenDamage(
    [
        {
            damage: diceTotal,
            type: 'piercing'
        }
    ],
    diceTotal,
    new Set([token]),
    null,
    null
);

For now, it's a good proof of concept for spike growth.

steel apex Oct 23, 2022, 2:44 PM

#

How would I implement this? My Druid player loves Spike Growth.

scarlet gale Oct 23, 2022, 2:45 PM

#

Until Zhell's new module has a proper release, I'd stick with the current method using AA.

steel apex Oct 23, 2022, 2:45 PM

#

(Just need to remind myself what that is…)

scarlet gale Oct 23, 2022, 2:46 PM

#

I think midi has a sample item for spike growth

#

using active auras

#

I'm attempting to set up the spell in a way that doesn't use active auras

acoustic jasper Oct 23, 2022, 2:47 PM

#

I'm trying to make the new (OneD&D) Grapple for some playtesting. I'm using midi-qol.Overtime with "turn=end, saveAbility=str, saveDC=@attributes.spelldc, label=Grappled" - is there a way to change saveDC so it will be equal to [8 + your Strength
modifier + your Proficiency Bonus]?

vast bane Oct 23, 2022, 2:47 PM

#

I really really like active auras and hope its not being replaced

scarlet gale Oct 23, 2022, 2:47 PM

#

It's not, but a lot of us here find it mega buggy

late briar Oct 23, 2022, 2:50 PM

#

@kind cape could it be that the damage dialog does not actually change anything about the workflow being critical / not critical?

steel apex Oct 23, 2022, 2:50 PM

#

scarlet gale I'm attempting to set up the spell in a way that doesn't use active auras

I saw your comment about lag causing issues with auras. Not been using any auras for now but one of my players has very slow up/down speeds so this may well come into play.

kind cape Oct 23, 2022, 2:51 PM

#

late briar <@132588829663035392> could it be that the damage dialog does not actually chang...

I believe it should be setting the isCritical 🤔

vast bane Oct 23, 2022, 2:52 PM

#

I do not think that is an issue, it clearly states its best used in combat only and in combat nobody moves around all at once, a singular person moves at a time, no aura issues occur then, it only ever becomes an issue when many people/tokens are moving all at once and rarely are spells being cast tin these moments, its almost always just aura of protection that gets weird, and even then, the solution is to move in and out of the pally aura before you make a save if you have duplicate buffs on you.

late briar Oct 23, 2022, 2:53 PM

#

kind cape I believe it should be setting the isCritical 🤔

when I log the workflow from the item macro (divine smite) it shows that "isCritical" is undefined, hm...

kind cape Oct 23, 2022, 2:54 PM

#

late briar when I log the workflow from the item macro (divine smite) it shows that "isCrit...

Try logging the specific value. The object you see in the console is "live", so any changes that happen later on in the flow may impact the values you see

late briar Oct 23, 2022, 2:56 PM

#

is still undefined

molten solar Oct 23, 2022, 2:56 PM

#

acoustic jasper I'm trying to make the new (OneD&D) Grapple for some playtesting. I'm using midi...

Is that not the default when you use Strength to set the save dc?
If @attributes.spelldc means it can use roll data, can you use the item's roll data? If so, the DC is in there.

kind cape Oct 23, 2022, 2:58 PM

#

late briar is still undefined

No clue whats going on then

acoustic jasper Oct 23, 2022, 2:59 PM

#

molten solar Is that not the default when you use Strength to set the save dc? If `@attribute...

no - in OverTime i need to set a DC - I think it should work with saveDC=8+@abilities.str.mod+@smoky smeltiency (don't know how to include proficiency here)

molten solar Oct 23, 2022, 2:59 PM

#

@prof

acoustic jasper Oct 23, 2022, 3:01 PM

#

yeah, now it's working

late briar Oct 23, 2022, 3:15 PM

#

I could probably just give it a damage of 1d1, then if it crits its a 2 and otherwise a 1

#

hacky but it should work

#

kinda confusing though. I wonder how the tim does it for their games

late briar Oct 23, 2022, 3:34 PM

#

Ah... something else I just noticed is that the no macro version does not roll critical damage if its a fiend or undead

uneven bridge Oct 23, 2022, 3:36 PM

#

Hey guys, I was having an issue with the arcane ward macros that are not temp HP based in the Midi sample items not applying to damage the caster takes. Currently on version 9.280, Is there additional setup other than importing the feature and using it?

vast bane Oct 23, 2022, 3:36 PM

#

late briar Ah... something else I just noticed is that the no macro version does not roll c...

Smite works fine for me but I don't fast forward

#

make sure your activation condition settings are setup

celest bluff Oct 23, 2022, 3:37 PM

#

acoustic jasper no - in OverTime i need to set a DC - I think it should work with saveDC=8+@abil...

you can also do @abilities.str.dc

late briar Oct 23, 2022, 3:37 PM

#

vast bane make sure your activation condition settings are setup

I am using the one from the midi-srd... so it should already be setup

vast bane Oct 23, 2022, 3:37 PM

#

midi srd doesn't setup your midi settings for you

late briar Oct 23, 2022, 3:38 PM

#

my spell and mwak / rwak roll other damage is set to: activation condition and it rolls the normal damage for a fiend / undead but not the critical damage.

#

So basically normally it does 2d8 + 1d8 against undead. Then for a crit it should do 4d8 + 2d8, no?

#

since we double all damage dice on a critical hit

vast bane Oct 23, 2022, 3:38 PM

#

late briar my spell and mwak / rwak roll other damage is set to: activation condition and i...

are you hitting normal in the popout or crit?

late briar Oct 23, 2022, 3:38 PM

#

crit

celest bluff Oct 23, 2022, 3:39 PM

#

that standard dice roll won't apply crit

late briar Oct 23, 2022, 3:39 PM

#

oh wow

celest bluff Oct 23, 2022, 3:39 PM

#

you'll need to use either return damage roll or dnd5e roller

vast bane Oct 23, 2022, 3:39 PM

#

I think that option of smite is meant for non fast forward

#

I'm using the smite with the item macro and it detects fiend/undead and crits just fine

celest bluff Oct 23, 2022, 3:40 PM

#

I switched over to dnd5e roller for all macros

molten solar Oct 23, 2022, 3:40 PM

#

Ignore the +1d8 in the macro entirely, and use babonus. 😎

#

vanishes

vast bane Oct 23, 2022, 3:41 PM

#

we want to drag and drop premades so we can save on time, bab also is v10, we're on v9

vast bane Oct 23, 2022, 3:41 PM

#

late briar crit

why aren't you using the macro version of smite?

late briar Oct 23, 2022, 3:41 PM

#

because I originally wanted to also use auto forward

vast bane Oct 23, 2022, 3:42 PM

#

it won't crit cause theres no attack roll then

celest bluff Oct 23, 2022, 3:42 PM

#

my version auto fast forwards and uses the same target as the previous attack

late briar Oct 23, 2022, 3:45 PM

#

okay I disabled fast forward and for some reason it still auto rolls damage without any dialog... I think I just broke something 😂

vast bane Oct 23, 2022, 3:45 PM

#

wow I'm testing now and you are right, this v9 smite is broken

#

it is impossible to crit with either of them

late briar Oct 23, 2022, 3:46 PM

#

okay, good thing that I am not the crazy one now XD

vast bane Oct 23, 2022, 3:46 PM

#

Looks like I'm using Advantage reminder

late briar Oct 23, 2022, 3:46 PM

#

I could just write my own macro with a made up dialog

celest bluff Oct 23, 2022, 3:46 PM

#

this the midi sample version?

late briar Oct 23, 2022, 3:46 PM

#

yep

vast bane Oct 23, 2022, 3:46 PM

#

yep, both refuse to crit, either fast forward or normal

late briar Oct 23, 2022, 3:46 PM

#

vast bane Looks like I'm using Advantage reminder

same here

vast bane Oct 23, 2022, 3:46 PM

#

they don't give you a damage popout, they just happen

late briar Oct 23, 2022, 3:47 PM

#

yup

celest bluff Oct 23, 2022, 3:47 PM

#

9.x version with no macro?

late briar Oct 23, 2022, 3:47 PM

#

well I am on v10

vast bane Oct 23, 2022, 3:48 PM

#

Ok the no macro version works with crits

#

its the macro version that is borked

#

but you have to have fast forward off, cause its not attached to the weapon attack

late briar Oct 23, 2022, 3:49 PM

#

I think its borked because the item itself has no attack or damage roll

vast bane Oct 23, 2022, 3:49 PM

#

Might as well just use advantage reminder honestly at this point

celest bluff Oct 23, 2022, 3:49 PM

#

Divine Smite 10.0.8 does have if (args[0].isCritical) numDice = numDice * 2;

vast bane Oct 23, 2022, 3:49 PM

#

well, need the spell expense so probably stickin with the no macro version

late briar Oct 23, 2022, 3:49 PM

#

celest bluff Divine Smite 10.0.8 does have `if (args[0].isCritical) numDice = numDice * 2;`

yeah but how do you make isCritical true? XD

#

the dialog doesn't change it

celest bluff Oct 23, 2022, 3:50 PM

#

could be numdice isn't a number

#

let numDice = 1 + args[0].spellLevel;
change that to let numDice = 1 + Number(args[0].spellLevel);

late briar Oct 23, 2022, 3:51 PM

#

and then without fast forward, yes?

molten solar Oct 23, 2022, 3:51 PM

#

I thought the problem was you already established that args[0].isCritical was always falsy

celest bluff Oct 23, 2022, 3:51 PM

#

yeah it should always be false unless critical then true

molten solar Oct 23, 2022, 3:52 PM

#

Yes true is not false

late briar Oct 23, 2022, 3:52 PM

#

the problem is that there is no popup window ever to set if its critical or not

#

even with no fastforward it simply doesn't popup since the spell has no damage and so the system probably never wants to roll any

celest bluff Oct 23, 2022, 3:53 PM

#

oh wait... how does this macro know you have a crit in the first place

#

heh

late briar Oct 23, 2022, 3:54 PM

#

it doesnt

#

which is the confusing part

#

I thought the workflow would tell it, if you get the popup.

#

but I just made it give the popup and pressing crit doesn't work anyways

celest bluff Oct 23, 2022, 3:54 PM

#

yeah I think he forgot to include a workflow grabber to check your last attack

late briar Oct 23, 2022, 3:55 PM

#

You made a better version, right?

#

At least thats what you said earlier

celest bluff Oct 23, 2022, 3:55 PM

#

yeah, mine checks the workflow and everything else.. then applies crit if needed

late briar Oct 23, 2022, 3:56 PM

#

How do you get the previous workflow?

celest bluff Oct 23, 2022, 3:56 PM

#

filtering with MidiQOL.Workflow.workflows

#

I match it against weapons you own

late briar Oct 23, 2022, 3:57 PM

#

ah okay

#

and does MidiQOL.Workflow.workflows only contain recent workflows or all ever created ones?

celest bluff Oct 23, 2022, 3:58 PM

#

lemme see if my version 10 works right.. I updated it but I forget if I've tested it or not heh

#

it has all current listed workflows by token actors

#

You can only have 1 per scene token.actor

late briar Oct 23, 2022, 3:58 PM

#

oh

#

so my PC can only have one workflow at once. Wouldn't the new one override the previous one then immediately?

scarlet gale Oct 23, 2022, 4:00 PM

#

molten solar But if you manage to invent a 'distance travelled through template' function, I'...

My searching has led me here: https://github.com/williamfiset/Algorithms/blob/master/src/main/java/com/williamfiset/algorithms/geometry/LineSegmentCircleIntersection.js

celest bluff Oct 23, 2022, 4:00 PM

#

no, not until damage roll complete is done

late briar Oct 23, 2022, 4:00 PM

#

ahh

celest bluff Oct 23, 2022, 4:01 PM

#

actually you can have 2

#

one hasn't finished yet finalized till it's ended, then it trashes the previous workflow

molten solar Oct 23, 2022, 4:01 PM

#

scarlet gale My searching has led me here: https://github.com/williamfiset/Algorithms/blob/ma...

This looks a lot like the built-in methods Foundry already has for whether a template contains a point/token

scarlet gale Oct 23, 2022, 4:02 PM

#

molten solar This looks a lot like the built-in methods Foundry already has for whether a tem...

The idea is to use the move as a line segment then see where it collides with the template (circle in my case). Then just measure the distance with foundry.

vast bane Oct 23, 2022, 4:05 PM

#

ok so new report on v9 smite:

Macro version never crits
No Macro version's additional damage for fiend/undead does not roll additional dice for crit

late briar Oct 23, 2022, 4:05 PM

#

yup

#

can confirm that

#

time to get vscode and code a previous workflow grabber

vast bane Oct 23, 2022, 4:05 PM

#

I had no idea this was borked and my poor pally player never caught on either

#

I think I'm just gonna get a macro polo macro to expend a spell slot and use advantage reminder

late briar Oct 23, 2022, 4:06 PM

#

Good thing I literally try to automate as much as possible before every starting my first campaign / one shot

vast bane Oct 23, 2022, 4:06 PM

#

that way its all in the same attack

late briar Oct 23, 2022, 4:06 PM

#

vast bane I think I'm just gonna get a macro polo macro to expend a spell slot and use adv...

I also have advantage reminder installed. How do you get it all in the same attack?

#

just as situation bonus?

vast bane Oct 23, 2022, 4:08 PM

#

basically you make a button for [[/r 1d8]]{Fiend/Undead} and then [[/r 2d8]]{Level 1} and so on so a bunch of buttons.

#

and I'm going to add in a button that just expends a spell slot so he can do all of it in the popout

#

cause I aint makin no macros for this lol

late briar Oct 23, 2022, 4:10 PM

#

ahhh so you just add buttons to the chat card of the item

#

very roll20 😄

#

but if it works, it works

vast bane Oct 23, 2022, 4:10 PM

#

no

#

Advantage Reminder:

#

the buttons are here

late briar Oct 23, 2022, 4:11 PM

#

wait thats possible?

vast bane Oct 23, 2022, 4:11 PM

#

Thats Advantage reminder 😉

late briar Oct 23, 2022, 4:11 PM

#

I thought It can only highlight stuff and show some text

#

but the text can be buttons?!

vast bane Oct 23, 2022, 4:12 PM

#

it can also do document links and buttons for damage

#

late briar Oct 23, 2022, 4:12 PM

#

and you are showing that for every damage roll the pally does?

#

Do you use Advantage Reminder in combination with midi-qol?

vast bane Oct 23, 2022, 4:12 PM

#

yes but you can't fast forward if you use midi

#

otherwise you don't see these

late briar Oct 23, 2022, 4:13 PM

#

yep

#

how did you make it red though

#

isn't it just bold?

vast bane Oct 23, 2022, 4:13 PM

#

it pops it all into the situational bonus field when you press buttons for damage, but the smite, will actually activate the smite spell independent of the attack, but like we both found out, smite don't work right so I'm removing it and using advantage reminder fully

#

The red is part of advantage reminders settings, he added the ability to use specific colors or player colors

#

I'm red in my game, set to player colors

late briar Oct 23, 2022, 4:14 PM

#

ahh

vast bane Oct 23, 2022, 4:14 PM

#

theres probably way more functionality I don't know about in v10 as kaelad has done alot more in v10 for the module and I'm stuck in v9

late briar Oct 23, 2022, 4:15 PM

#

you have no fast forward at all, correct?

vast bane Oct 23, 2022, 4:15 PM

#

but what I like about advantage reminder is that its all UI stuff that I can figure out with my 3 brain cells and I don't have to write a bunch of macros

#

yeah my players were trained quickly to never fast forward

#

late briar Oct 23, 2022, 4:16 PM

#

All my players are from Roll20 without Premium, so they also are not at all used to fast forwarding stuff

#

so I guess I just disable all fast forwarding and work from there

vast bane Oct 23, 2022, 4:16 PM

#

still use midi for alot of things, but advantage reminder is great for the really situational stuff

late briar Oct 23, 2022, 4:16 PM

#

Can you share your midi settings?

vast bane Oct 23, 2022, 4:17 PM

#

I mean, I can share the whole enchilada, but really its just like 3 settings

late briar Oct 23, 2022, 4:17 PM

#

well then those 3 settings would be enough xD

vast bane Oct 23, 2022, 4:17 PM

#

the abilities and saves are outside in the main menu of midi, not in workflow, and then theres the attack ones in DM and Player tabs inside workflow

#

um...I'm on v9 so maybe same places?

late briar Oct 23, 2022, 4:18 PM

#

yeah

#

do you autoroll damage?

vast bane Oct 23, 2022, 4:18 PM

#

vast bane Oct 23, 2022, 4:18 PM

#

late briar do you autoroll damage?

when needed

#

Auto attack and Auto roll are not fast forward fyi

#

fast forward is the skipping of the two popouts, auto rolls are the skipping of having to click the button in chat to activate attacks and damage, very different( and I auto attack/when needed for that)

late briar Oct 23, 2022, 4:20 PM

#

Okay very good

vast bane Oct 23, 2022, 4:20 PM

#

late briar Oct 23, 2022, 4:20 PM

#

and you just setup divine smite as a passive effect that gives those messages?

vast bane Oct 23, 2022, 4:20 PM

#

#

The above is the player tab

#

I haven't fixed it to not use the midi sample item yet but yeah...

late briar Oct 23, 2022, 4:26 PM

#

its possible to have multiple messages too, right?

vast bane Oct 23, 2022, 4:30 PM

#

Yes

#

late briar Oct 23, 2022, 4:39 PM

#

Okay I definitely will use more of advantage reminder on the future.

vast bane Oct 23, 2022, 4:39 PM

#

his inline rolls module looks awesome too but its v10 only and alas I cannot use

#

Divine Smite with Advantage Reminder
Till a macro guru can clean it up, I'm just using a blank spell in their level 1 category to expend the slot

late briar Oct 23, 2022, 4:45 PM

#

I am very tempted to just write a dialog that shows up where you can select spell slot and whether its a crit or not for the divine smite,
but thats actually not in the games rules since it would have to trigger before any mwak damage roll...

vast bane Oct 23, 2022, 4:45 PM

#

late briar Oct 23, 2022, 4:45 PM

#

with your way they smite before knowing the normal damage, so its great

vast bane Oct 23, 2022, 4:47 PM

#

@fallen token Is there a way to correct the spacing between lines in advantage reminder so the buttons don't overlap?

quick mesa Oct 23, 2022, 5:27 PM

#

Is there a bug where a reaction check on magic items doesn't see reaction spells within the magic item? It seems to delay like it put out a choice dialog, but nothing pops up when Check Player reactions is set to On + Item Magic?

vast bane Oct 23, 2022, 5:37 PM

#

what is the item?

raven holly Oct 23, 2022, 5:55 PM

#

vast bane

I just set up something kinda similar for Minute Meteors, a macro to consume one of the meteors and then the additional damage as a separate button
As for spacing, maybe try a <br> before the Level 1 buttons?

late briar Oct 23, 2022, 5:58 PM

#

Currently still trying to automate / improve Divine Smite, I had the idea to use Roll Groups.
Now it seems that Roll Groups can add its buttons to the midi-qol item card shown in the chat, but it also wants to auto roll the combined damage.
Can I turn off auto rolling damage for specific items?

molten solar Oct 23, 2022, 5:59 PM

#

Any compatibility between Midi and RG will be nothing more than a happy coincidence.

#

I'm surprised it can even add the buttons.

late briar Oct 23, 2022, 6:02 PM

#

oh

#

well then ignore what I said xD

vast bane Oct 23, 2022, 6:03 PM

#

late briar Currently still trying to automate / improve Divine Smite, I had the idea to use...

#

also, I dunno if RG is like MRE, but MRE really screws up items for midi and uninstalling MRE would not fix it, you'd have to sit there replacing all the items for midi to work right again

late briar Oct 23, 2022, 6:04 PM

#

ewww

vast bane Oct 23, 2022, 6:04 PM

#

it was cause MRE added damage formulas and they'd stay there after you removed it, and midi does not like extra damage formulas, or needless versatile/other formulas

austere cypress Oct 23, 2022, 6:05 PM

#

Hey Yall, Im trying to use Midi QoL and Item Macros together, but when I use the Midi QoL Samples, it doesn`t do anything, and the console pops up this
"Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'itemData')
[Detected 1 package: itemacro]
at eval (eval at Item._executeScript (modules/itemacro/scripts/helper.js:82), <anonymous>:39:30)
at Macro.eval (eval at Item._executeScript (modules/itemacro/scripts/helper.js:82), <anonymous>:41:9)
at Item5e.Item._executeScript (modules/itemacro/scripts/helper.js:88)
at Item5e.Item.executeMacro (modules/itemacro/scripts/helper.js:60)
at HTMLDivElement.<anonymous> (modules/itemacro/scripts/helper.js:170)
at HTMLDivElement.dispatch (jquery.min.js:2)
at HTMLDivElement.y.handle (jquery.min.js:2)"
Can you help me figure it aout? 😛

dark canopy Oct 23, 2022, 6:05 PM

#

disable the item macro sheet hook

vast bane Oct 23, 2022, 6:06 PM

#

pretty sure nothing should be checked in Item Macros module settings if midi is installed, odd that this keeps coming up, is there something oing on with the v10 builds? Normally they are defaultd to off

austere cypress Oct 23, 2022, 6:06 PM

#

Yeah, both the Hooks and overrides are checked in item macros, i'll disable them

vast bane Oct 23, 2022, 6:07 PM

#

Did you install item macro before midi was ever in the world?

austere cypress Oct 23, 2022, 6:08 PM

#

I think so, yeah

austere cypress Oct 23, 2022, 6:08 PM

#

dark canopy disable the item macro sheet hook

Yay it worked ❤️ ❤️ thxthx

violet meadow Oct 23, 2022, 6:30 PM

#

The sheet hooks MUST be off in Item Macros settings to work with MidiQOL

austere cypress Oct 23, 2022, 6:55 PM

#

violet meadow The sheet hooks **MUST** be off in Item Macros settings to work with MidiQOL

Thx, I'm just getting started on foundry and I'm having trouble figuring stuff out still

violet meadow Oct 23, 2022, 6:56 PM

#

No worries. Just asking around the discord will most of the time get you there!

#

Also reading the readmes of the modules you are using is a really good way to get yourself acquainted with specific settings etc

austere cypress Oct 23, 2022, 6:59 PM

#

Yeah, I got a little bit overwhelmd but I'll go slowly and figute stuff out

#

I'm just trying out the sample items first jut to get a feel

violet meadow Oct 23, 2022, 7:11 PM

#

Sample items might be a bit advanced when just starting out 😄

But its a good way to check what can be done and get ideas 😉

ember trench Oct 23, 2022, 7:23 PM

#

Hey all! I'm trying to edit the Invisibility spell to get MidiQOL/DAE to drop the Invisible CE condition, as opposed to the CE Invisibility Spell. Not quite sure what I'm doing wrong. Any thoughts?

#

#

violet meadow Oct 23, 2022, 7:27 PM

#

ember trench

You are applying the DFreds CE first and then if absent you check for effects defined on the Item. MidiQOL checks the DFreds CE database against the name (Invisibility in this case) and applies the one that is found

You should change that to Item Effects first, or apply both and on the Item's detail page close to the bottom, check the Don't apply DFreds convenient effect, so as to not double up on conditions applied

ember trench Oct 23, 2022, 7:30 PM

#

violet meadow You are applying the DFreds CE first and then if absent you check for effects de...

Hell yeah, that did it!

#

To be clear, I did have to manually add that DAE to the Invisibilty spell, right? Or was that somehow redundant?

#

Like is there some system-level way to have Foundry reach for CE conditions by default when a spell references the condition? For example:

violet meadow Oct 23, 2022, 7:34 PM

#

It is redundant I think. DFreds should set the correct core status afaik

ember trench Oct 23, 2022, 7:36 PM

#

violet meadow It is redundant I think. DFreds should set the correct core status afaik

I might be running into an imported vs SRD content issue. I just checked the SRD Spell compendium and it looks right.

violet meadow Oct 23, 2022, 7:36 PM

#

Oof imports, yeah no idea then 🤷

kind cape Oct 23, 2022, 7:38 PM

#

My usual way is to create a CE that matches the name of the feature and then have it use macro.CE to apply the actual effects

violet meadow Oct 23, 2022, 7:38 PM

#

yeah but why 🤷 😅

kind cape Oct 23, 2022, 7:38 PM

#

It makes it clear where an effect comes from and if there are multiple conditions I can remove them by removing the parent effect

coarse mesa Oct 23, 2022, 7:39 PM

#

Plus the CE descriptions are ChefKiss

violet meadow Oct 23, 2022, 7:41 PM

#

I just meant why use the macro.CE. It should automatically apply it or I can be confused now 🍻

kind cape Oct 23, 2022, 7:41 PM

#

Well the effect is not named the same as the spell, so how would it know? 🤔

violet meadow Oct 23, 2022, 7:42 PM

#

Ah I went off the "matches the name of the feature" you mentioned

vast bane Oct 23, 2022, 7:42 PM

#

Macro ce uses effects icon instead of status I think as well

#

Helps us remember sources

zealous marten Oct 23, 2022, 8:49 PM

#

anyone have a zephyr strike build? i'm trying to figure out how to have an optional damage boost to an attack that then ends the spell

violet meadow Oct 23, 2022, 8:49 PM

#

zealous marten anyone have a zephyr strike build? i'm trying to figure out how to have an optio...

reminder of Zephyr Strike?

zealous marten Oct 23, 2022, 8:51 PM

#

1 minute concentration, during that time, you do not provoke attacks of opportunity. Once during the duration, you can add 1d8 force damage to a melee attack, adding 30 ft to your movement speed for that round (whether it hits or misses).

violet meadow Oct 23, 2022, 8:51 PM

#

zealous marten 1 minute concentration, during that time, you do not provoke attacks of opportun...

Optional bonus effects of MidiQOL for the damage part

zealous marten Oct 23, 2022, 8:51 PM

#

so rather complex. i can definitely just remember to keep track of it with the concentration effect over the actor's head if it's violently difficult.

violet meadow Oct 23, 2022, 8:52 PM

#

When you attack it drops concentration or not until the duration ends?

zealous marten Oct 23, 2022, 8:53 PM

#

nope, reread it, my apologies. stays in effect, just removes the option for the bonus damage/speed up

violet meadow Oct 23, 2022, 8:54 PM

#

zealous marten nope, reread it, my apologies. stays in effect, just removes the option for the ...

Give a quick read through the midiqol readme (link in the pins up top)

zealous marten Oct 23, 2022, 8:54 PM

#

how would one get to optional bonus effects? (i've piecemealed my way into this module so forgive me for the probably very basic answer)

#

literally just answered my question. thank you.

violet meadow Oct 23, 2022, 8:55 PM

#

I can help later if you need help setting that up.

zealous marten Oct 23, 2022, 8:56 PM

#

for sure. lemme see if i can manage it, and then if not, i'll definitely bug ya! appreciate you guys. this stuff isn't too hard, just tedious as hell. happy someone actually understands the underlying systems, it'd take me a week and a half of hyperfocus to get even close.

molten solar Oct 23, 2022, 8:56 PM

#

Could have the bonus always on, and use EM to remove the damage bonus on the first damage roll. 😎

zealous marten Oct 23, 2022, 8:56 PM

#

true, but that's assuming it's always the first hit, it's optional sadly

#

whenever they'd like

#

can also just check and make sure they're cool with it and do that...

fallen token Oct 23, 2022, 8:58 PM

#

vast bane <@806776572488450058> Is there a way to correct the spacing between lines in adv...

There's probably some CSS that can adjust the line spacing. I noticed the same issue with regular chat messages so I didn't bother adding any CSS to fix it

zealous marten Oct 23, 2022, 9:01 PM

#

got the "first attack" bonus cleared with the player. second question: when they attack, it give a movement speed bonus as well, but for 1 turn. is there a way to turn on a secondary effect (with it's own duration) when the first effect ends?

molten solar Oct 23, 2022, 9:01 PM

#

Yeah, swap it with a new array of changes in the effect data, rather than deleting the damage bonus

zealous marten Oct 23, 2022, 9:02 PM

#

ok, so i'm gonna look up what that means, and then that should work! thank you @molten solar

molten solar Oct 23, 2022, 9:03 PM

#

wait this isn't macro-polo...

zealous marten Oct 23, 2022, 9:03 PM

#

lol. i do be seeing you there a lot. appreciate you

#

so how does one swap the array? (i figured out what it meant in a basic sense)

molten solar Oct 23, 2022, 9:07 PM

#

With a script. How do you trigger it?

zealous marten Oct 23, 2022, 9:07 PM

#

so it's in a spell, and it's just adding an effect to the actor that adds a (loss on melee attack) +1d8 force melee damage bonus.

#

i'm assuming that i'm either looking at the wrong module. which is likely. or i'm not understanding the more intricate parts lol

vast bane Oct 23, 2022, 9:10 PM

#

its not exactly a spell people automate, its got heavy situational steps

zealous marten Oct 23, 2022, 9:11 PM

#

yeah. i generally tend to be difficult

vast bane Oct 23, 2022, 9:12 PM

#

I'd make the spellcast add an advantage reminder message that has a document link to a macro that will activate removal of said previous effect and then activate an expire on hit damage bonus and then another expire at end of turn walking speed bonus if I was being forced to automate it....but you could also just totm it.

zealous marten Oct 23, 2022, 9:12 PM

#

can def just go "you've got 30 extra feet of movement till the end of turn" out loud. lol

vast bane Oct 23, 2022, 9:12 PM

#

I think you will find the ranger doesn't use that spell unless its a oneshot

violet meadow Oct 23, 2022, 9:12 PM

#

Zephyr strike is 100% doable within MidiQOL /DAE with a bit of macroing

zealous marten Oct 23, 2022, 9:13 PM

#

probably gonna do that if i'm honest. otherwise it gets mucky. for sure with the macroing. lol. and you are correct. generally unless it's a new player who will definitely be doing & trying literally everything as much as possible. lol

#

the curious goblin. the most dangerous kind.

vast bane Oct 23, 2022, 9:14 PM

#

but how do you automate choice lol

#

thats the part that makes me think advantage reminder lol

violet meadow Oct 23, 2022, 9:14 PM

#

I will make a sample item for Zephyr Strike tomorrow. And another for Divine Smite for Moto with a twist. Will make it for v10 and then you need to change it back to v9

vast bane Oct 23, 2022, 9:14 PM

#

cause they have to choose when to use it

violet meadow Oct 23, 2022, 9:14 PM

#

vast bane but how do you automate choice lol

Optional bonus effects

vast bane Oct 23, 2022, 9:15 PM

#

that sounds v10ish

violet meadow Oct 23, 2022, 9:15 PM

#

Will prompt with every attack and they can click on it when they want

vast bane Oct 23, 2022, 9:15 PM

#

what is this voodoo and where do I turn it on?

#

or is it more js stuff?

violet meadow Oct 23, 2022, 9:16 PM

#

Nope midi flags

#

Check the readme

vast bane Oct 23, 2022, 9:16 PM

#

that literally sounds like advantage reminder lol

violet meadow Oct 23, 2022, 9:16 PM

#

Same thing like legendary resistance in midi sample items

zealous marten Oct 23, 2022, 9:16 PM

#

i'm reading the readme, and it's equally as confusing. i so love coding. but dear lord plain text helps.

vast bane Oct 23, 2022, 9:17 PM

#

I'll stick to UI friendly stuff like adv reminder

violet meadow Oct 23, 2022, 9:17 PM

#

zealous marten i'm reading the readme, and it's *equally as confusing*. i so love coding. but d...

It is a big one and quite scary to navigate at first

violet meadow Oct 23, 2022, 9:18 PM

#

vast bane I'll stick to UI friendly stuff like adv reminder

You do the same with AR. You need to create a flag on the item, no?

Same thing for the optional bonus effects.

zealous marten Oct 23, 2022, 9:18 PM

#

yeah... but now i'm determined.

violet meadow Oct 23, 2022, 9:18 PM

#

But it prompts on a separate window which can be tedious at times. But for something with has a finite duration 🤷

zealous marten Oct 23, 2022, 9:20 PM

#

so... flags.midi-qol.optional.Name.damage.mwak - add - 1d8. does it turn itself off after or do i need to add something somewhere?

violet meadow Oct 23, 2022, 9:21 PM

#

You need to give it a count of once.
And a label for good measure

zealous marten Oct 23, 2022, 9:22 PM

#

this is all in a macro yes? or in the effects area of the spell?

violet meadow Oct 23, 2022, 9:22 PM

#

But you will need to package it on a DAE on the Zephyr z strike item and that one to have a target of self in the 3rd available box

#

Zephyr Item’s title bar, click on DAE and create the effect in there.

zealous marten Oct 23, 2022, 9:24 PM

#

yeah, got there, Label: Zephyr Strike, transfer to actor on item equip checked right?

#

i feel like i'm 8 and learning how to make a minecraft map. lol

violet meadow Oct 23, 2022, 9:24 PM

#

Nope

#

This means that it will transferred on the actor when you drag the item in the character sheet

zealous marten Oct 23, 2022, 9:25 PM

#

oooh. so apply to self when item is rolled. so when they use the spell it applies

violet meadow Oct 23, 2022, 9:27 PM

#

Either that, or on the target details in the Item’s details tab choose Self (3rd box)

zealous marten Oct 23, 2022, 9:29 PM

#

gotcha. that works. alright, so where do the optionals go? i have now found the lines for count & label as well, but in the readme, so i'm lost as to where they are in the DAE interface

violet meadow Oct 23, 2022, 9:30 PM

#

zealous marten gotcha. that works. alright, so where do the optionals *go*? i have now found th...

Zephyr strike item, DAE tab in the title bar. Do you see it?

zealous marten Oct 23, 2022, 9:30 PM

#

yeah, i'm in the "Configure Acive Effect: Zephyr Strike" popup atm

violet meadow Oct 23, 2022, 9:30 PM

#

Ok in the effects tab of it

#

Add one new

#

Key mode value

zealous marten Oct 23, 2022, 9:31 PM

#

oh i'm dumb. gotcha. those are attribute keys, and since it's Midi, it needs to be override or custom right?

violet meadow Oct 23, 2022, 9:32 PM

#

Yes. Check readme if they need override it should say

zealous marten Oct 23, 2022, 9:33 PM

#

gotcha. so set the bonus, the count, and the label (so it's there, usable only once, and named). and it'll expire on it's own due to the "count" key yeah?

violet meadow Oct 23, 2022, 9:34 PM

#

And create a secondary effect for the movement part

#

Niche but you might use it 🤷

zealous marten Oct 23, 2022, 9:34 PM

#

is there a way to have it trigger the secondary movement effect when the first (dmg bonus) de-activates

violet meadow Oct 23, 2022, 9:35 PM

#

That can be done but needs a bit of macroing

#

Cannot help with that rn

zealous marten Oct 23, 2022, 9:35 PM

#

nah you're good, that makes it so much better. thank you!

covert mason Oct 23, 2022, 10:16 PM

#

How would I word proficiency in wisdom saves in an active effect?

late briar Oct 23, 2022, 10:27 PM

#

@violet meadow you are going to make a V10 midi-qol automated Divine Smite?

coarse mesa Oct 23, 2022, 10:35 PM

#

Does @vast bane need a v9 Divine Smite? The one I’m using works last time I checked. It’s a feature not a spell, you activate after a hit and it adds a temp effect with damage bonus. Works with undead and crits, even stacks with Hunters Mark etc properly

#

It has a prompt asking for what slot to use

#

I pieced it together from parts I found on this server iirc

violet meadow Oct 23, 2022, 10:39 PM

#

late briar <@547736620649021450> you are going to make a V10 midi-qol automated Divine Smit...

That was the plan 😄

#

But you still need to say when you want to use it 😄
(even though for a player of mine I can safely make a case to auto roll it when a nat 20 is rolled 😅 )

coarse mesa Oct 23, 2022, 10:46 PM

#

For reference, here's the Divine Smite (v9) macro I'm using... just whack it in an itemMacro on your class feature – activate it after attack but before you roll damage

// if effect, just remove it
const flag = `${actor.id}-${item.name}`;
const effect = actor.effects.find(i => i.getFlag("world", item.name) === flag);
if(effect) return effect.delete();

// find target
const target = game.user.targets.first();
if(!target) return ui.notifications.warn("You must have a token targeted.");

// generate radio buttons
const inputs = Object.entries(actor.getRollData().spells).filter(s => s[1].value > 0).map(i => [nth(Number(i[0].replace("spell",""))), i[1]]);
if(inputs.length < 1) return ui.notifications.warn("You have no spell slots remaining.");
const content = inputs.reduce((acc, e, i) => acc += `
    <tr>
        <th style="width: 50%">
            <label>${e[0]} (${e[1].value}/${e[1].max})</label>
        </th>
        <td style="width: 50%; text-align: center">
            <input type="radio" value="${e[0]}" name="group1" ${i === 0 ? "checked" : ""}>
        <td>
    </tr>
`, `<table style="width: 100%"><tbody>`) + `</tbody></table>`;

// show dialog
const choice = await new Promise(resolve => {
    new Dialog({
        title: item.name,
        content,
        buttons: {
            yes: {
                icon: `<i class="fas fa-check"></i>`,
                label: "Apply",
                callback: (html) => {
                    const value = html[0].querySelector("input[name=group1]:checked").value;
                    resolve(value.at(0));
                }
            },
            no: {
                icon: `<i class="fas fa-times"></i>`,
                label: "Cancel",
                callback: (html) => { resolve(false) }
            }
        },
        default: "no",
        close: (html) => { resolve(false) }
    }).render(true, {height: "100%"});
});
if(!choice) return;

// if target is fiend/undead, bonus die
const bonusDie = ["fiend", "undead"].includes(target.actor.getRollData().details.type?.value) ? 1 : 0;

// calculate total dice and damage
const dice = Math.min(5, 1 + Number(choice)) + bonusDie;
const damage = `+${dice}d8[radiant]`;

// create effect
const effectData = [{
    changes: [{key: "data.bonuses.mwak.damage", mode: CONST.ACTIVE_EFFECT_MODES.ADD, value: damage, priority: 20}],
    icon: item.data.img,
    label: item.name,
    origin: `Actor.${actor.id}.Item.${item.id}`,
    tint: "#000000",
    [`flags.world.${item.name}`]: flag,
    "flags.core.statusId": item.name,
    "flags.dae.specialDuration" : "DamageDealt",
    "flags.convenientDescription": "Your next attack deals additional damage."
}];
await actor.createEmbeddedDocuments("ActiveEffect", effectData);

// remove spell slot
await actor.update({[`data.spells.spell${choice}.value`]: actor.getRollData().spells[`spell${choice}`].value - 1});

function nth(n){return n + (["st","nd","rd"][((n+90)%100-10)%10-1]||"th")}

vast bane Oct 23, 2022, 10:50 PM

#

coarse mesa For reference, here's the Divine Smite (v9) macro I'm using... just whack it in ...

does it have to be an item macro?

#

can it be a folder macro?

coarse mesa Oct 23, 2022, 10:50 PM

#

definitely

vast bane Oct 23, 2022, 10:50 PM

#

cause then its great to use with advantage reminder 8)

coarse mesa Oct 23, 2022, 10:51 PM

#

yeah you could do that, but I'm not sure if it'd work if you've already started to roll damage

vast bane Oct 23, 2022, 10:51 PM

#

coarse mesa yeah you could do that, but I'm not sure if it'd work if you've already started ...

hmmm

coarse mesa Oct 23, 2022, 10:52 PM

#

could give it a try... our Paladin never forgets to activate it when he crits for some reason 🤔

#

he just has it as a hotbar button next to his halberd

vast bane Oct 23, 2022, 10:54 PM

#

not able to be run as a folder macro

#

#

must be using something native to item macro

coarse mesa Oct 23, 2022, 10:55 PM

#

Oh I thought you meant reference it from the folder in the OnUse field

#

It's not hard to put it in the Divine Smite class feature item, where it should live 🤷‍♂️

vast bane Oct 23, 2022, 10:56 PM

#

I don't want to use the hotbar

#

you can't document link item macros

coarse mesa Oct 23, 2022, 10:56 PM

#

you can't document link class features?

vast bane Oct 23, 2022, 10:57 PM

#

I'll stickwith my ugly method

#

theres a thought, make it an item macro and link the blank item lol

coarse mesa Oct 23, 2022, 10:57 PM

#

drag it to hotbar, remove from hotbar (it will still be in the folder)

molten solar Oct 23, 2022, 10:58 PM

#

Looks like one of mine. 🤔 And an older one at that.

coarse mesa Oct 23, 2022, 10:58 PM

#

molten solar Looks like one of mine. 🤔 And an older one at that.

It could be!

#

Before I even knew who I was yoinking from

molten solar Oct 23, 2022, 10:58 PM

#

I can tell by the reduce and the elongated indentation from Notepad++.

coarse mesa Oct 23, 2022, 10:59 PM

#

You must be proud that it's still chugging along just fine and in my opinion works the best

molten solar Oct 23, 2022, 10:59 PM

#

Oh wow, radio buttons. Glad I don't do that anymore!

coarse mesa Oct 23, 2022, 10:59 PM

#

Using a spell for Divine Smite? pffft

molten solar Oct 23, 2022, 10:59 PM

#

Yeah heck no

coarse mesa Oct 23, 2022, 11:00 PM

#

Who would want Divine Smite sitting in their spell list

vast bane Oct 23, 2022, 11:00 PM

#

I just use a spell to expend the slot, cause I don't do macro fu well

molten solar Oct 23, 2022, 11:00 PM

#

I made a new thing for my paladin player though. Item Macro embedded in the smite feature, clones it and rolls damage using all the system's hooks.

molten solar Oct 23, 2022, 11:00 PM

#

coarse mesa Who would want Divine Smite sitting in their spell list

Savages, the lotta them. Features are features!

coarse mesa Oct 23, 2022, 11:00 PM

#

molten solar I made a new thing for my paladin player though. Item Macro embedded in the smit...

You've built a mini midi just for them, that's so nice

molten solar Oct 23, 2022, 11:01 PM

#

Nah, I'm all about the QOL, not the Midi.

#

Having to tick off a spell slot and roll dice manually (or make it a spell) is mildly inconvenient, and thus the absolute worst.

coarse mesa Oct 23, 2022, 11:03 PM

#

There's something amazing about watching our vengeance paladin crit with maxed level smite and hunter's mark going... do many dice flying around. Having it all in one roll is neat

molten solar Oct 23, 2022, 11:04 PM

#

coarse mesa There's something amazing about watching our vengeance paladin crit with maxed l...

Last session the paladin player found the gem I made that gave everyone a +STR increased crit range

#

... during a fight against undead.

#

The undead dude's ability to heal himself for 60+ hp each round did not make much of a difference.

coarse mesa Oct 23, 2022, 11:07 PM

#

That sounds amazing... we almost got wiped out by three intellect devourers who got the jump on us. Stupid me for eschewing my headband of intellect

vast bane Oct 23, 2022, 11:09 PM

#

my only close player death so far in dotmm is from an intellect devourer

#

but I've murder hoboed the familliar 30 times

molten solar Oct 23, 2022, 11:10 PM

#

I haven't had a player death yet. I'm in the mood. Would you recommend it?

coarse mesa Oct 23, 2022, 11:10 PM

#

they're frickin dangerous against a party of dump INT dummies

molten solar Oct 23, 2022, 11:10 PM

#

They are level 9.

#MidiQOL