#dev-general | HelpChat | Page 345

static zealot Mar 12, 2021, 9:21 PM

#

I don't even know if I'll start watching season 7

old wyvern Mar 12, 2021, 9:21 PM

#

ep 2 is a pretty shitty excuse to get them out of a situation they couldnt get out of

#

Yea 6 was left incomplete coz of covid

#

They are going to wrap up the s6 story by s7 ep 3 apparently

#

The mirror master arc

static zealot Mar 12, 2021, 9:22 PM

#

The Boys was a good show. I can't say it was great but good

old wyvern Mar 12, 2021, 9:23 PM

#

||Earth 1 Wells is back, not thawn, the actual Wells who we saw thawn kill in the flashback||

static zealot Mar 12, 2021, 9:23 PM

#

wait what?

#

also they diged his bones...

#

and confirmed its him

old wyvern Mar 12, 2021, 9:23 PM

#

Yup

#

But

#

well

#

watch

#

xD

static zealot Mar 12, 2021, 9:24 PM

#

Sherlok is an interesting show but idk if I like it

#

oh Lost in space was nice tho

old wyvern Mar 12, 2021, 9:24 PM

#

Umbrella Academy is nice

static zealot Mar 12, 2021, 9:24 PM

#

yeah

#

also my first show that I actually watched and loved was Altered Carbon

#

idk why

#

I didn't really like shows until that one

old wyvern Mar 12, 2021, 9:25 PM

#

Whats that about?

static zealot Mar 12, 2021, 9:25 PM

#

a future where our conscience is stored on some kind of disks that are put in our necks and we don't really need the bodies anymore we can just change them

old wyvern Mar 12, 2021, 9:26 PM

#

O.o

#

Have you seen upload?

static zealot Mar 12, 2021, 9:26 PM

#

I don't think I have

old wyvern Mar 12, 2021, 9:27 PM

#

Similar concept, In the future people who die can be downloaded into a VR world

static zealot Mar 12, 2021, 9:27 PM

#

oh seems interesting

#

well in AC you can actually change bodies after you die if you have money

old wyvern Mar 12, 2021, 9:27 PM

#

😮

static zealot Mar 12, 2021, 9:28 PM

#

its pretty good anyways

#

you should watch it

old wyvern Mar 12, 2021, 9:28 PM

#

Yea, will do PlusOne

lunar cypress Mar 12, 2021, 9:32 PM

#

static zealot also my first show that I actually watched and loved was Altered Carbon

really?

static zealot Mar 12, 2021, 9:32 PM

#

yeah idk why I really liked it

lunar cypress Mar 12, 2021, 9:33 PM

#

In the beginning it was ok imo, but it got really dull and just centered around excessive violence later on

static zealot Mar 12, 2021, 9:33 PM

#

I love excessive violence

#

xD

stuck harbor Mar 12, 2021, 9:33 PM

#

blitz have u played katana zero?

static zealot Mar 12, 2021, 9:33 PM

#

nope

stuck harbor Mar 12, 2021, 9:34 PM

#

its very violent

static zealot Mar 12, 2021, 9:34 PM

#

Ic

#

I don't think I've actually played a lot of 2d games

lunar cypress Mar 12, 2021, 9:34 PM

#

I also do love me some violence, but AC just takes itself too seriously while it remains rather superficial story-wise

#

gotta love the atmosphere though

stuck harbor Mar 12, 2021, 9:35 PM

#

atmosphere

#

i love when pixel art games immerse me more than high quality ray traced AAA games

#

always fun

static zealot Mar 12, 2021, 9:35 PM

#

well idk a lot of shows that have actually good story for all seasons. Most of them are good in the beginning but just go bad after a while

#

idk I don't play a lot of AAA games either. I'm not really a "Gamer" I just play games that I can afford lmao xD the only games I bought because I liked them were the Tomb Raider games. the new ones

lunar cypress Mar 12, 2021, 9:37 PM

#

static zealot well idk a lot of shows that have actually good story for all seasons. Most of t...

true, but with AC I didn't particularly like it in the beginning either

static zealot Mar 12, 2021, 9:38 PM

#

maybe. tbh a lot of shows I watch and I just remember the feelings. Not the actual shows xD

#

for AC I do remember some stuff and usually that's because I liked them

jovial warren Mar 12, 2021, 9:42 PM

#

https://paste.helpch.at/wisagafesa.rb bets on this working first time?

static zealot Mar 12, 2021, 9:43 PM

#

I just see a lot of stuff so I'm going to say it won't work

jovial warren Mar 12, 2021, 9:43 PM

#

lol

#

what that does is this:

Load the plugin.conf file from the plugin's JAR
Create the data folder if it doesn't exist
Retrieve the main class attribute from the plugin's JAR manifest
Construct a new URLClassLoader for that plugin
Load the plugin's main class reflectively and instantiate it with the plugin's context

static zealot Mar 12, 2021, 9:46 PM

#

idk I'm to lazy to read it watching yt videos xD

old wyvern Mar 12, 2021, 9:46 PM

#

You could use apply on the folder instead of the first init block

#

And move the loader up if thats whats used by load I guess

jovial warren Mar 12, 2021, 9:46 PM

#

good point

jovial warren Mar 12, 2021, 9:46 PM

#

old wyvern And move the loader up if thats whats used by load I guess

wdym?

old wyvern Mar 12, 2021, 9:46 PM

#

The field right below it

#

Didnt look into what it was

#

just saying by name

jovial warren Mar 12, 2021, 9:47 PM

#

yeah I've removed that map now

#

list*

#

it was unnecessary

old wyvern Mar 12, 2021, 9:47 PM

#

ah ok

jovial warren Mar 12, 2021, 9:47 PM

#

each plugin has its own URLClassLoader instance

old wyvern Mar 12, 2021, 9:48 PM

#

Also you dont need the exist check for the file iirc

#

Just call mkdir instead

#

It just returns false if it didnt get created

jovial warren Mar 12, 2021, 9:48 PM

#

oh yeah

lunar cypress Mar 12, 2021, 9:49 PM

#

no parent class loaders?

old wyvern Mar 12, 2021, 9:49 PM

#

Also why the map to pluginloadstate

jovial warren Mar 12, 2021, 9:50 PM

#

old wyvern Also why the map to pluginloadstate

good point

old wyvern Mar 12, 2021, 9:50 PM

#

Could just be a fieldin the plugin class

jovial warren Mar 12, 2021, 9:50 PM

#

yeah

jovial warren Mar 12, 2021, 10:06 PM

#

https://i.imgur.com/PeIf0sO.png

Imgur

#

https://paste.helpch.at/emenehahag.cs

#

bruh

#

https://paste.helpch.at/acogonuqab.pl this is the new plugin manager btw

frail glade Mar 12, 2021, 10:23 PM

#

Clean

jovial warren Mar 12, 2021, 10:23 PM

#

thanks 🙂

#

@prisma wave can I ~~steal~~ your repo just to put the Krypton API on until I get my request to register org.kryptonmc on Maven Central approved btw? xD

#

https://tenor.com/PUSZ.gif

Tenor

#

https://i.imgur.com/6mlhkvl.png wait wtf no way

Imgur

#

they fixed highlighting?

#

about fucking time

#

right, here we go, moment of truth

onyx loom Mar 12, 2021, 10:54 PM

#

wym

#

isnt that normal highlighting?

ocean quartz Mar 12, 2021, 11:00 PM

#

Wdym fixed the highlighting?

jovial warren Mar 12, 2021, 11:00 PM

#

the blue

#

I haven't seen blue there in ages

#

I always get method call is ambiguous lol

#

https://i.imgur.com/0hU9mDr.png BOIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIII

Imgur

#

big pog

static zealot Mar 12, 2021, 11:05 PM

#

load Terrible Plugin on that

jovial warren Mar 12, 2021, 11:05 PM

#

terrible plugin is written in Java and uses Bukkit 😔

static zealot Mar 12, 2021, 11:06 PM

#

well can't you just shade in java?

#

and Bukkit

jovial warren Mar 12, 2021, 11:06 PM

#

doge_ahaha

#

you know Java is included in the JRE right?

#

the JDK is in the JRE

#

and for Bukkit

#

https://tenor.com/MF8L.gif

Tenor

static zealot Mar 12, 2021, 11:07 PM

#

why?

#

I'll just PR

#

it

jovial warren Mar 12, 2021, 11:07 PM

#

Bukkit is absolutely diabolical

#

also, I'm stupid lol

#

imagine making an initialize method and not making it open

#

🥲

#

finally, Krypton isn't fully useless anymore

#

still gotta test what happens if you instantiate another class in the constructor

#

actually that doesn't need loading

#

oh btw, on the topic of plugins, anyone up for making some simple plugins using the new Krypton API and giving me some feedback? 🙂

static zealot Mar 12, 2021, 11:17 PM

#

how much you paying? /s

jovial warren Mar 12, 2021, 11:17 PM

#

lol

#

🥲

#

just about to push the server update

winter iron Mar 12, 2021, 11:18 PM

#

is lombok bad?

jovial warren Mar 12, 2021, 11:18 PM

#

?plsnolombok

compact perchBOT Mar 12, 2021, 11:18 PM

#

FAQ Answer:

Why is Lombok bad?

It's a compiler hack - the Java compiler isn't designed to modify code, so it can cause difficult to debug errors, or worse
It requires an IDE plugin, so unless you've properly configured Maven, Gradle and your IDE, you'll get hundreds of compilation errors. This process takes time too, it's not easy
Lombok'd code won't show in Javadocs
The code generation is often unpredictable and difficult to debug, and often you'll have to do it "the hard way" anyway
Java is supposed to be explicit, Lombok hides a lot of key functionality into a subtle annotation which can be easy to miss
While IDEs support it with a plugin, it's usually more difficult to find specific things, like usages of a getter because they don't exist in the source code
Finally, Lombok'd bytecode doesn't match the source code, so it causes a pretty annoying warning in IntelliJ

static zealot Mar 12, 2021, 11:19 PM

#

winter iron is lombok bad?

short answer: yes, long answer: yes

winter iron Mar 12, 2021, 11:19 PM

#

damn got a whole ass bot made to answer the question

#

any more reasons why

static zealot Mar 12, 2021, 11:19 PM

#

yep

#

its bad

jovial warren Mar 12, 2021, 11:21 PM

#

oh btw, a few notes when making Krypton plugins:

Every plugin needs a description file, called plugin.conf, on its classpath (basically plugin.yml without main)
Every plugin must have its main class set in the manifest (can be done with the application plugin in Gradle)
Every plugin's main class must take context: PluginContext as an argument to its constructor

winter iron Mar 12, 2021, 11:21 PM

#

krypton bad

jovial warren Mar 12, 2021, 11:22 PM

#

wow

winter iron Mar 12, 2021, 11:22 PM

#

bukkit 1.7.10 good

jovial warren Mar 12, 2021, 11:22 PM

#

https://tenor.com/uhfw.gif

Tenor

nick young

▶ Play video

#

what kinda rock you been living under for the past like 8 years lol

winter iron Mar 12, 2021, 11:22 PM

#

im gonna become a hater

#

krypton bad

#

elara bad

#

kotlin bad

jovial warren Mar 12, 2021, 11:22 PM

#

Krypton good

winter iron Mar 12, 2021, 11:22 PM

#

clojure bad

jovial warren Mar 12, 2021, 11:22 PM

#

Elara good

#

Kotlin good

#

Clojure kinda meh

winter iron Mar 12, 2021, 11:23 PM

#

down bad if ur using clojure

jovial warren Mar 12, 2021, 11:23 PM

#

lol

#

Krypton is not bad though

old wyvern Mar 12, 2021, 11:23 PM

#

jovial warren Elara good

PlusOne

winter iron Mar 12, 2021, 11:23 PM

#

might start programming my plugins in html

old wyvern Mar 12, 2021, 11:23 PM

#

Even more so after upcoming changes

#

😌

onyx loom Mar 12, 2021, 11:23 PM

#

jovial warren Clojure kinda meh

i will not take this as an answer

#

say its dogshit rn

winter iron Mar 12, 2021, 11:24 PM

#

👀

jovial warren Mar 12, 2021, 11:24 PM

#

okay, Clojure bad

old wyvern Mar 12, 2021, 11:24 PM

#

onyx loom say its dogshit rn

Die

jovial warren Mar 12, 2021, 11:24 PM

#

now make me a plugin lol

old wyvern Mar 12, 2021, 11:24 PM

#

Pay me

onyx loom Mar 12, 2021, 11:24 PM

#

what for

old wyvern Mar 12, 2021, 11:24 PM

#

Orrrrr add embeded elara suppourt

#

For now till it compiles to jvm 🥲

jovial warren Mar 12, 2021, 11:25 PM

#

repositories {
    mavenCentral()
    maven { url 'https://libraries.minecraft.net/' }
    maven { url 'https://repo.bristermitten.me/repository/maven-public/' }
}

dependencies {
    compileOnly 'org.kryptonmc:krypton-api:0.11.1'
}
```ez

#

(top 2 repositories required because Kotlin and other dependencies of the API are in Maven Central and Brigadier has its own library)

old wyvern Mar 12, 2021, 11:26 PM

#

Shouldnt that resolve itself if you have them in them transitively in the compiletime classpath from your repository declarations?

jovial warren Mar 12, 2021, 11:27 PM

#

wat

#

    repositories {
        mavenCentral()
        maven { url 'https://libraries.minecraft.net' }
    }

    dependencies {
        api 'org.jetbrains.kotlin:kotlin-stdlib'
        api 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.4.3'

        api 'org.jetbrains.kotlinx:kotlinx-serialization-json:1.1.0'
        api 'org.jetbrains.kotlinx:kotlinx-serialization-hocon:1.1.0'

        api('net.kyori:adventure-api:4.6.0') {
            exclude group: 'org.checkerframework', module: 'checker-qual'
        }
        api('net.kyori:adventure-extra-kotlin:4.6.0') {
            exclude group: 'org.checkerframework', module: 'checker-qual'
        }

        api 'com.mojang:brigadier:1.0.17'
        api 'me.bardy:admiral:1.0'

        api 'org.apache.logging.log4j:log4j-api:2.11.1'
    }
```my dependencies

#

oh btw, @ocean quartz, you'll be happy to know that Krypton's CommandManager has a register method that directly accepts a LiteralArgumentBuilder 🙂

old wyvern Mar 12, 2021, 11:29 PM

#

According to docs, api is transitive so those depndencies should be available to any project depending on this

jovial warren Mar 12, 2021, 11:29 PM

#

¯_(ツ)_/¯

#

override fun register(command: Command) {
    val commandNode = dispatcher.register(literalArgument(command.name) {
        executes {
            val permission = command.permission ?: return@executes 1

            if (it.source.hasPermission(permission)) {
                CommandScope.launch { command.execute(it.source, it.input.split(" ").drop(0)) }
                1
            } else 0
        }
    })

    command.aliases.forEach { dispatcher.register(literalArgument(it) { redirect(commandNode) }) }
}
```this is the `register` function for commans btw lol

old wyvern Mar 12, 2021, 11:29 PM

#

Have you tried without the repos specified?

jovial warren Mar 12, 2021, 11:30 PM

#

oh it does actually work

#

maybe because it's cached, idk

#

Could not find org.jetbrains.kotlin:kotlin-compiler-embeddable:1.4.31. without repo

#

without Minecraft libraries: Could not find com.mojang:brigadier:1.0.17.

#

whatever kinda docs told you api is transitive, transitive my backside

prisma wave Mar 12, 2021, 11:34 PM

#

winter iron clojure bad

Take that back you waste of flesh

winter iron Mar 12, 2021, 11:34 PM

#

never

#

fight me

#

then ill consider

prisma wave Mar 12, 2021, 11:34 PM

#

I'd love to

#

Send your address

winter iron Mar 12, 2021, 11:34 PM

#

bet

#

ill send u a waypoint on google maps and u can get ur mom to drop u off

prisma wave Mar 12, 2021, 11:35 PM

#

sounds good

#

see you tomorrow

jovial warren Mar 12, 2021, 11:35 PM

#

lol

#

BM

#

me made it work

winter iron Mar 12, 2021, 11:35 PM

#

https://www.google.com/maps/place/DumbassProductions/@35.8615465,14.5426566,14z/data=!3m1!4b1!4m5!3m4!1s0x130e5b494ef43327:0x9582bd0caf0595b6!8m2!3d35.861513!4d14.5601662

DumbassProductions

#

see u there

#

💪

jovial warren Mar 12, 2021, 11:36 PM

#

lol

winter iron Mar 12, 2021, 11:36 PM

#

ill bring all my python2 buddies

prisma wave Mar 12, 2021, 11:36 PM

#

jovial warren me made it work

made what work

winter iron Mar 12, 2021, 11:36 PM

#

ur finished

jovial warren Mar 12, 2021, 11:36 PM

#

prisma wave made what work

plugin loading 😎

prisma wave Mar 12, 2021, 11:36 PM

#

winter iron ill bring all my python2 buddies

I'll chokeslam all of them

prisma wave Mar 12, 2021, 11:36 PM

#

jovial warren plugin loading 😎

très bien

winter iron Mar 12, 2021, 11:36 PM

#

ill body ur bum ass

prisma wave Mar 12, 2021, 11:36 PM

#

Try

winter iron Mar 12, 2021, 11:36 PM

#

built like a twig

jovial warren Mar 12, 2021, 11:36 PM

#

winter iron ill body ur bum ass

KEKW

prisma wave Mar 12, 2021, 11:36 PM

#

winter iron built like a twig

A very strong twig

winter iron Mar 12, 2021, 11:36 PM

#

i get paid to headbutt children

#

but u can get one for free

prisma wave Mar 12, 2021, 11:37 PM

#

I nolife a minecraft discord

#

Try me

errant geyser Mar 12, 2021, 11:37 PM

#

I read that as "ill bum your ass"... yeah gn

winter iron Mar 12, 2021, 11:37 PM

#

Lmao

#

gay as hell

#

i play roblox

#

minecraft aint shit to me

prisma wave Mar 12, 2021, 11:38 PM

#

Ew

#

Subhuman

winter iron Mar 12, 2021, 11:39 PM

#

3rd worlder

jovial warren Mar 12, 2021, 11:39 PM

#

errant geyser I read that as "ill bum your ass"... yeah gn

lol

#

oh yeah, BM, write me a plugin pls

winter iron Mar 12, 2021, 11:41 PM

#

ye do as he says

#

b i t c h

errant geyser Mar 12, 2021, 11:41 PM

#

Leave senpai alone

jovial warren Mar 12, 2021, 11:41 PM

#

https://tenor.com/JLiM.gif

Tenor

shut up

▶ Play video

jovial warren Mar 12, 2021, 11:41 PM

#

errant geyser Leave senpai alone

ikr

winter iron Mar 12, 2021, 11:42 PM

#

😠

#

im on smoke

jovial warren Mar 12, 2021, 11:42 PM

#

not surprised lol

winter iron Mar 12, 2021, 11:42 PM

#

whats that supposed to mean

#

:/

#

im getting off, my mom told me i need to rest before i beat bm

#

pce

jovial warren Mar 12, 2021, 11:43 PM

#

👋

ocean quartz Mar 12, 2021, 11:45 PM

#

jovial warren oh btw, <@!180369172046413824>, you'll be happy to know that Krypton's `CommandM...

Why would that make me happy? xD

jovial warren Mar 12, 2021, 11:45 PM

#

because you asked for Brigadier colour support lol

#

iirc

#

the coloured argument thingies

#

remember?

ocean quartz Mar 12, 2021, 11:46 PM

#

I think you're thinking Frosty

obtuse gale Mar 12, 2021, 11:48 PM

#

doesn't matter

#

that orange support dude

distant sun Mar 12, 2021, 11:48 PM

#

mf with brigadier support would be amazing

obtuse gale Mar 12, 2021, 11:49 PM

#

and on hover tooltips :partyparrot:

ocean quartz Mar 12, 2021, 11:55 PM

#

distant sun mf with brigadier support would be amazing

It's planned ;p

#

With hover tooltips

jovial warren Mar 12, 2021, 11:56 PM

#

https://imgflip.com/i/51iez2

Imgflip

Drake Hotline Bling

#

though my command system doesn't handle sub commands

#

but that's why you can register Brigadier literal argument builders lol

#

and why Admiral is embedded

#

literalArgument("time") {
    literalArgument("set") {
        literalArgument("day")
        literalArgument("noon")
        literalArgument("night")
        requiredArgument("time", integer)
    }
    literalArgument("add") {
        requiredArgument("time", integer)
    }
    literalArgument("query") {
        literalArgument("day")
    }
}

#

😎

#

should probably just remove the Argument suffix from those top-level functions tbh

surreal quarry Mar 13, 2021, 12:00 AM

#

probably cleaner without them

obtuse gale Mar 13, 2021, 12:01 AM

#

literalArgument("time", integer)
wat

#

I'll assume you intended requiredArgument instead

surreal quarry Mar 13, 2021, 12:01 AM

#

lol

jovial warren Mar 13, 2021, 12:01 AM

#

obtuse gale >`literalArgument("time", integer)` wat

haha yeah lol

ocean quartz Mar 13, 2021, 12:03 AM

#

jovial warren ```kotlin literalArgument("time") { literalArgument("set") { literal...

That's extremely ugly

obtuse gale Mar 13, 2021, 12:04 AM

#

Think of it like a directory tree

jovial warren Mar 13, 2021, 12:04 AM

#

literal("time") {
    literal("set") {
        literal("day")
        literal("noon")
        literal("night")
        required("time", integer)
    }
    literal("add") {
        required("time", integer)
    }
    literal("query") {
        literal("day")
    }
}

#

how's that instead?

ocean quartz Mar 13, 2021, 12:04 AM

#

Still ugly

onyx loom Mar 13, 2021, 12:04 AM

#

mf monopoly will never be topped

jovial warren Mar 13, 2021, 12:05 AM

#

onyx loom mf monopoly will never be topped

lol

#

"monopoly"

obtuse gale Mar 13, 2021, 12:05 AM

#

I quite like the tree structure

jovial warren Mar 13, 2021, 12:05 AM

#

cmd.getName().equalsIgnoreCase() monopoly will never be topped xD

onyx loom Mar 13, 2021, 12:05 AM

#

🤨

fierce jewel Mar 13, 2021, 12:25 AM

#

anyone have plugin for blocking 2nd hand on 1.16 ??

obtuse gale Mar 13, 2021, 12:29 AM

#

fierce jewel anyone have plugin for blocking 2nd hand on 1.16 ??

https://wiki.bristermitten.me/disallowing-offhand-usage-on-spigot-servers

Disallowing Offhand Usage On Spigot Servers

This guide talks about Disallowing Offhand Usage On Spigot Servers

jovial warren Mar 13, 2021, 12:30 AM

#

I got Haskell! yay!

fierce jewel Mar 13, 2021, 12:30 AM

#

doesnt work

onyx loom Mar 13, 2021, 12:31 AM

#

?

prisma wave Mar 13, 2021, 12:34 AM

#

jovial warren I got Haskell! yay!

A great achievement

obtuse gale Mar 13, 2021, 12:42 AM

#

tf is brigadier

#

Brigadier is a command parser & dispatcher, designed and developed for Minecraft: Java Edition and now freely available for use elsewhere under the MIT license.

jovial warren Mar 13, 2021, 12:57 AM

#

fierce jewel doesnt work

That's the point

#

One of those fake wiki page links gets posted when you ask a question in the wrong channel

obtuse gale Mar 13, 2021, 12:59 AM

#

https://tvtropes.org/pmwiki/pmwiki.php/Main/DontExplainTheJoke

TV Tropes

Don't Explain the Joke - TV Tropes

The Don't Explain the Joke trope as used in popular culture. Explaining a joke just makes it not funny, except in those rare cases where the hopelessness of …

jovial warren Mar 13, 2021, 12:59 AM

#

Stfu

obtuse gale Mar 13, 2021, 12:59 AM

#

nah thanks I'm good

jovial warren Mar 13, 2021, 12:59 AM

#

Lol

distant sun Mar 13, 2021, 1:16 AM

#

is possible to create a SHULKER inventory that has a certain color, eg red_shulker?

surreal quarry Mar 13, 2021, 1:46 AM

#

its probably similar to leather if i had to guess

glossy relic Mar 13, 2021, 1:46 AM

#

What's the command to get a workup on where server resources are going?

#

Like ram usage etc.

surreal quarry Mar 13, 2021, 1:47 AM

#

if there isn't like RED_SHULKER or something, it would probably be setting a meta property?

surreal quarry Mar 13, 2021, 1:48 AM

#

glossy relic What's the command to get a workup on where server resources are going?

maybe /timings

glossy relic Mar 13, 2021, 1:49 AM

#

surreal quarry maybe `/timings`

thanks

orchid crescent Mar 13, 2021, 6:00 AM

#

distant sun is possible to create a SHULKER inventory that has a certain color, eg red_shulk...

cast it to Shulker

#

then you are avaible to use setColor and getColor methods

#

wait are you asking creating inventories or just shulkers

#

and can you see the which color is it in inventory?

cunning oriole Mar 13, 2021, 8:44 AM

#

Hey, I was looking for someone who could update a jumppads 1.8.8 plugin to 1.12.2, it should use same configs and have same permissions. I can pay with Skrill or maybe paypal.

hot hull Mar 13, 2021, 8:52 AM

#

#816184744797929522

jovial warren Mar 13, 2021, 10:30 AM

#

Krypton has commands now 🙂

hot hull Mar 13, 2021, 10:32 AM

#

brigadier support?

#

as in colored args

jovial warren Mar 13, 2021, 10:43 AM

#

two of the register methods take LiteralArgumentBuilders lol

#

and it uses Brigadier internally

#

so if you want coloured arguments, you can just directly use that

#

for now anyway

prisma wave Mar 13, 2021, 10:46 AM

#

Ew API methods taking builders

jovial warren Mar 13, 2021, 10:47 AM

#

that's what Brigadier takes internally

hot hull Mar 13, 2021, 10:47 AM

#

oh god

obtuse gale Mar 13, 2021, 10:48 AM

#

it literally calls the method that takes the built node though so lmao

jovial warren Mar 13, 2021, 10:50 AM

#

the thing I could do I suppose is call root.addChild and take a LiteralCommandNode I guess

obtuse gale Mar 13, 2021, 10:51 AM

#

ArgumentBuilder#then also takes a built CommandNode too (that's the method the one that takes the builder calls)

#

Frcsty just had a deep orgasm

hot hull Mar 13, 2021, 11:01 AM

#

:moan:

#

Show the abomination that is the code for that Fefo

obtuse gale Mar 13, 2021, 11:12 AM

#

The only thing that makes it disgusting is the BukkitBrigadierCommandSource https://paste.helpch.at/ucuniyikos.java

#

Needlessly long af name

#

eeeeeeeeeeeeeee

stuck harbor Mar 13, 2021, 11:14 AM

#

no

#

we wouldn't

obtuse gale Mar 13, 2021, 11:15 AM

#

it would have good structure if it evolved, advanced and moved forward over time instead of being stuck and unwilling to improve like it is

#

the day paper hard forks

#

god I'm gonna have kids that day

stuck harbor Mar 13, 2021, 11:17 AM

#

man

#

just fork paper

#

and make a better one

#

called

#

cardboard

#

cardboardspigot yes

#

make it run on go

obtuse gale Mar 13, 2021, 11:18 AM

#

with tnt optimized for pvp righT?

stuck harbor Mar 13, 2021, 11:18 AM

#

idk I'm not a pvper

#

so sure

obtuse gale Mar 13, 2021, 11:19 AM

#

right

#

1.8ers are happy with that decision

stuck harbor Mar 13, 2021, 11:19 AM

#

lol

hot hull Mar 13, 2021, 11:22 AM

#

obtuse gale The only thing that makes it disgusting is the `BukkitBrigadierCommandSource` ht...

ew

obtuse gale Mar 13, 2021, 11:25 AM

#

@hot hull Here are your colored commands :kekw: https://github.com/KryptonMC/Krypton/blob/master/server/src/main/kotlin/org/kryptonmc/krypton/packet/out/play/PacketOutDeclareCommands.kt

jovial warren Mar 13, 2021, 11:26 AM

#

KEKW

#

yeah I'll change that now lol

#

thanks for reminding me

obtuse gale Mar 13, 2021, 11:27 AM

#

lol

#

also that packet id is wrong lmao

#

unless you do your own internal woes

jovial warren Mar 13, 2021, 11:28 AM

#

it is wrong, correct

#

that is because it has not been updated since BM wrote it for 1.15 lol

prisma wave Mar 13, 2021, 11:29 AM

#

🙄

obtuse gale Mar 13, 2021, 11:29 AM

#

lol

errant geyser Mar 13, 2021, 11:57 AM

#

Every time I click here there's something really dodgy now

#

why

hot hull Mar 13, 2021, 11:58 AM

#

wdym why, colored arguments!

old wyvern Mar 13, 2021, 12:15 PM

#

obtuse gale The only thing that makes it disgusting is the `BukkitBrigadierCommandSource` ht...

Is that commodore?

jovial warren Mar 13, 2021, 12:17 PM

#

can anyone here help me understand some Mojang whack please?

#

https://paste.helpch.at/lovipukahe.cs ze code

#

I've renamed the variables according to what I think they are

old wyvern Mar 13, 2021, 12:19 PM

#

What part do you want explained?

#

its a breadth first search through the provided node

jovial warren Mar 13, 2021, 12:19 PM

#

isn't breadth first search when you take a tree and you expand as far across as you can before moving down?

old wyvern Mar 13, 2021, 12:20 PM

#

Yes

#

Think of that snippet's execution like this:
Pass #1

Queue: RootNode

->Poll

Queue: 
Current: RootNode

Use result from Current;

-> Add children

Queue: RootNode#Child1, RootNode#Child2

Pass #2

Queue: RootNode#Child1, RootNode#Child2

->Poll

Queue: RootNode#Child2
Current: RootNode#Child1

Use result from Current;

-> Add children

Queue: RootNode#Child2, RootNode#Child1#Child1, RootNode#Child1#Child2

.... continue till queue is empty

jovial warren Mar 13, 2021, 12:26 PM

#

ah right

#

any idea if there's a cleaner way I can do that in Kotlin?

#

also since assignments in while statements aren't allowed

lunar cypress Mar 13, 2021, 12:28 PM

#

you never need that though

#

you can also do it recursively

old wyvern Mar 13, 2021, 12:28 PM

#

Break if empty

jovial warren Mar 13, 2021, 12:29 PM

#

lunar cypress you can also do it recursively

could I use tail recursion here?

lunar cypress Mar 13, 2021, 12:29 PM

#

yes

jovial warren Mar 13, 2021, 12:29 PM

#

so it's both clean and fast

old wyvern Mar 13, 2021, 12:29 PM

#

uh

#

not dfs

#

bfs

lunar cypress Mar 13, 2021, 12:30 PM

#

yes

old wyvern Mar 13, 2021, 12:30 PM

#

We need a queue not a stack tho

#

You could hack things together, But i assume its only going to end up more complicated

jovial warren Mar 13, 2021, 12:30 PM

#

I just need a map of elements to their respective indices

#

(a Map<CommandNode<*>, Int>)

lunar cypress Mar 13, 2021, 12:30 PM

#

"hack things together" if you say so

#

There's a pretty standard recursive implementation afaik

old wyvern Mar 13, 2021, 12:31 PM

#

Can you link me to an example?

jovial warren Mar 13, 2021, 12:32 PM

#

https://www.techiedelight.com/breadth-first-search/ looks like there is

Techie Delight

Admin

Breadth-First Search (BFS) – Iterative and Recursive Implementation

Breadth–first search (BFS) is an algorithm for traversing or searching tree or graph data structures. It starts at the tree root (or some arbitrary node of a graph, sometimes referred to as a 'search key') and explores the neighbor nodes first before moving to the next-level neighbors.

lunar cypress Mar 13, 2021, 12:32 PM

#

BFS(start_node, goal_node)
    return BFS'({start_node}, ∅, goal_node);

BFS'(fringe, visited, goal_node)
    if (fringe == ∅)
        return false;
    if (goal_node ∈ fringe)
        return true;
    return BFS'({child | x ∈ fringe, child ∈ successors(x)} \ visited, visited ∪ fringe, goal_node);
```from german wikipedia

jovial warren Mar 13, 2021, 12:33 PM

#

BFS'? isn't that the inverse of BFS?

lunar cypress Mar 13, 2021, 12:33 PM

#

I recently had to implement it as well though I did it iteratively because java

lunar cypress Mar 13, 2021, 12:33 PM

#

jovial warren `BFS'`? isn't that the inverse of `BFS`?

no

#

it's just the recursive helper

jovial warren Mar 13, 2021, 12:33 PM

#

ah right

#

any examples of that implemented in code that I might understand? lol

#

actually nvm, seems I have a Java example on this page I linked

#

but that still seems to use iteration

#

it's maths

lunar cypress Mar 13, 2021, 12:35 PM

#

pseudocode

jovial warren Mar 13, 2021, 12:36 PM

#

yeah that's mathematical-based pseudocode I think

#

∅ is the empty set iirc, and ∈ means the left thing is an element of the right set

old wyvern Mar 13, 2021, 12:37 PM

#

lunar cypress ``` BFS(start_node, goal_node) return BFS'({start_node}, ∅, goal_node); BFS...

Is that not just building a queue in an argument?

lunar cypress Mar 13, 2021, 12:38 PM

#

no

#

there is no order there

old wyvern Mar 13, 2021, 12:38 PM

#

The adding order

#

The union does pretty much the same thing here

lunar cypress Mar 13, 2021, 12:39 PM

#

jovial warren any examples of that implemented in code that I might understand? lol

well, depends on what your api looks like but this pseudocode is set-based and the operators can be understood fairly quickly
∅ - empty set
∈ - element of
\ - set difference
∪ - set union
{child | x ∈ fringe, child ∈ successors(x)} means essentially fringe.map(successors)

lunar cypress Mar 13, 2021, 12:39 PM

#

old wyvern The adding order

I don't think it requires that

old wyvern Mar 13, 2021, 12:39 PM

#

lunar cypress I don't think it requires that

wdym?

lunar cypress Mar 13, 2021, 12:40 PM

#

I do not think it assumes anything in terms of order

jovial warren Mar 13, 2021, 12:40 PM

#

also, if I was to go with iteration here btw, couldn't I just use a for loop? or will that not work

lunar cypress Mar 13, 2021, 12:40 PM

#

it should work with any set type

jovial warren Mar 13, 2021, 12:40 PM

#

actually no that won't work

lunar cypress Mar 13, 2021, 12:41 PM

#

what kind of for loop? you can't remove elements from the queue in kotlin when you do that

jovial warren Mar 13, 2021, 12:41 PM

#

true

lunar cypress Mar 13, 2021, 12:42 PM

#

https://haste.devcord.xyz/ekopusopep.java here's my iterative implementation (it additionally constructs a path)

jovial warren Mar 13, 2021, 12:43 PM

#

private fun RootCommandNode<*>.enumerate(): Map<CommandNode<*>, Int> {
    val result = mutableMapOf<CommandNode<*>, Int>()
    val queue = ArrayDeque<RootCommandNode<*>>()
    while (queue.isNotEmpty()) {
        val element = queue.poll()
        if (result.containsKey(element)) continue
        val size = result.size
        result[element] = size
        queue += element.children
        if (element.redirect != null) queue += element.redirect
    }
    return result
}
```that's the translated code I think

#

but that's ugly lol

#

I mean, saying that, chunkInSpiral is literally unreadable, so ya know

lunar cypress Mar 13, 2021, 12:43 PM

#

the "problem" with the recursive implementation is that you need immutable sets

jovial warren Mar 13, 2021, 12:44 PM

#

would my Kotlin code actually work btw?

lunar cypress Mar 13, 2021, 12:44 PM

#

Considering we're talking about very small graphs here (or so I assume) this probably won't matter but still it is something to take into consideration

jovial warren Mar 13, 2021, 12:45 PM

#

very small graphs? er... this may or may not include every single command that has been registered with the dispatcher on the server

#

idk about you, but that ain't small

old wyvern Mar 13, 2021, 12:45 PM

#

lunar cypress I do not think it assumes anything in terms of order

hmm true

lunar cypress Mar 13, 2021, 12:45 PM

#

jovial warren would my Kotlin code actually work btw?

do you want to traverse every node in the graph?

stuck harbor Mar 13, 2021, 12:45 PM

#

when you try to write pseudocode but end up writing python

#

that's me

#

🥲

jovial warren Mar 13, 2021, 12:45 PM

#

lunar cypress do you want to traverse every node in the graph?

I don't even really understand what the point of the code is, I just know I need it

old wyvern Mar 13, 2021, 12:45 PM

#

lunar cypress do you want to traverse every node in the graph?

He needs to traverse each one, yes

lunar cypress Mar 13, 2021, 12:45 PM

#

jovial warren idk about you, but that ain't small

that is pretty small in terms of depth I presume

jovial warren Mar 13, 2021, 12:46 PM

#

https://wiki.vg/images/a/ac/Command_graph_18w22c.png

lunar cypress Mar 13, 2021, 12:46 PM

#

We might have different ideas of what small is too

jovial warren Mar 13, 2021, 12:46 PM

#

that's an example graph from wiki.vg

#

(open that in the browser and zoom lol)

lunar cypress Mar 13, 2021, 12:46 PM

#

oh well that is considerable

stuck harbor Mar 13, 2021, 12:46 PM

#

maaaan

#

that's thicc

jovial warren Mar 13, 2021, 12:46 PM

#

and that's just the default map

#

not including all the custom commands from plugins

stuck harbor Mar 13, 2021, 12:47 PM

#

damn

old wyvern Mar 13, 2021, 12:47 PM

#

jovial warren ```kotlin private fun RootCommandNode<*>.enumerate(): Map<CommandNode<*>, Int> {...

You shouldnt need the contains check and the null check

jovial warren Mar 13, 2021, 12:47 PM

#

I just ideally need something that can be computed at least relatively fast

old wyvern Mar 13, 2021, 12:47 PM

#

Otherwise that should work

lunar cypress Mar 13, 2021, 12:47 PM

#

yeah I think the code works

prisma wave Mar 13, 2021, 12:47 PM

#

seems like recursion would be nicer here no?

jovial warren Mar 13, 2021, 12:48 PM

#

oh btw, in Kotlin's ArrayDeque, is it firstOrNull I want instead of poll btw?

jovial warren Mar 13, 2021, 12:48 PM

#

prisma wave seems like recursion would be nicer here no?

yeah maybe

#

Johnny said that

lunar cypress Mar 13, 2021, 12:48 PM

#

nicer yes, but too inefficient probably

jovial warren Mar 13, 2021, 12:48 PM

#

I just need something that can be computed extremely quickly

#

actually, thinking about it, if commands aren't registered after startup is complete, then I should only really need to compute this once

lunar cypress Mar 13, 2021, 12:49 PM

#

jovial warren oh btw, in Kotlin's `ArrayDeque`, is it `firstOrNull` I want instead of `poll` b...

isn't that just java.util.ArrayDeque

old wyvern Mar 13, 2021, 12:49 PM

#

yes

jovial warren Mar 13, 2021, 12:49 PM

#

lunar cypress isn't that just java.util.ArrayDeque

no, they have their own impl that extends MutableAbstractList

old wyvern Mar 13, 2021, 12:49 PM

#

Wait really?

#

1.4 thing?

jovial warren Mar 13, 2021, 12:49 PM

#

yeah

#

https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-array-deque/

old wyvern Mar 13, 2021, 12:50 PM

#

oh it existed from 1?

#

Didnt notice welp

jovial warren Mar 13, 2021, 12:51 PM

#

¯_(ツ)_/¯

old wyvern Mar 13, 2021, 12:52 PM

#

jovial warren oh btw, in Kotlin's `ArrayDeque`, is it `firstOrNull` I want instead of `poll` b...

removeFirst is closest I think, no need for the null check after already checking if the queue is empty

#

https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-array-deque/remove-first.html

Kotlin

removeFirst - Kotlin Programming Language

jovial warren Mar 13, 2021, 12:53 PM

#

so ```kotlin
private fun RootCommandNode<>.enumerate(): Map<CommandNode<>, Int> {
val result = mutableMapOf<CommandNode<>, Int>()
val queue = ArrayDeque<CommandNode<>>()

while (queue.isNotEmpty()) {
    val element = queue.removeFirst()
    if (result.containsKey(element)) continue
    val size = result.size
    result[element] = size
    queue += element.children
    if (element.redirect != null) queue += element.redirect
}

return result

}

#

still not sure about removing the contains or null check

old wyvern Mar 13, 2021, 12:54 PM

#

Why not?

#

It doesnt visit a node more than once

jovial warren Mar 13, 2021, 12:54 PM

#

alright, I'll remove them

old wyvern Mar 13, 2021, 12:54 PM

#

Actually the queue would require the null check huh

jovial warren Mar 13, 2021, 12:54 PM

#

also, the redirect can be null, and if it is, we don't want to add it

old wyvern Mar 13, 2021, 12:54 PM

#

yea nvm about that one

jovial warren Mar 13, 2021, 12:54 PM

#

I'll remove the contains check though

old wyvern Mar 13, 2021, 12:55 PM

#

Yea my bad, I was thinking from the Java perspective where it would just ignore the null value

prisma wave Mar 13, 2021, 12:55 PM

#

lunar cypress nicer yes, but too inefficient probably

wouldnt be that bad with tail recursion and persistent data structures

jovial warren Mar 13, 2021, 12:55 PM

#

if you wanna help me make this cleaner and just as fast if not faster, be my guest BM

lunar cypress Mar 13, 2021, 12:55 PM

#

Yeah well. One of those doesn't exist in kotlin unfortunately

jovial warren Mar 13, 2021, 12:55 PM

#

which one?

prisma wave Mar 13, 2021, 12:55 PM

#

there's ktx.persistent afaik

old wyvern Mar 13, 2021, 12:55 PM

#

persistent data structures

jovial warren Mar 13, 2021, 12:55 PM

#

what are those?

old wyvern Mar 13, 2021, 12:55 PM

#

really?

prisma wave Mar 13, 2021, 12:55 PM

#

which adds persistent data structures

#

yeah

lunar cypress Mar 13, 2021, 12:55 PM

#

Oh there is? Interesting

prisma wave Mar 13, 2021, 12:56 PM

#

yup

#

never used it

old wyvern Mar 13, 2021, 12:56 PM

#

jovial warren what are those?

Version based "immutable" data structures

jovial warren Mar 13, 2021, 12:56 PM

#

https://en.wikipedia.org/wiki/Persistent_data_structure oh that's kinda cool

prisma wave Mar 13, 2021, 12:56 PM

#

but it definitely exists

jovial warren Mar 13, 2021, 12:56 PM

#

so it's basically where the data structure preserves its previous state when it's modified?

lunar cypress Mar 13, 2021, 12:57 PM

#

The idea is, to dumb it down, have immutable data structures that don't need to copy everything when you "modify" them

prisma wave Mar 13, 2021, 12:57 PM

#

yeah

#

immutable but pretty much constant time "copying"

jovial warren Mar 13, 2021, 12:57 PM

#

lunar cypress The idea is, to dumb it down, have immutable data structures that don't need to ...

ah right

old wyvern Mar 13, 2021, 12:57 PM

#

for an example git handles commits like a node of a persistent tree I think

jovial warren Mar 13, 2021, 12:58 PM

#

so basically just immutability where it only copies the changes

old wyvern Mar 13, 2021, 12:58 PM

#

A bit more than the changes bard

lunar cypress Mar 13, 2021, 12:58 PM

#

I wanna see how kotlin's persistent data structures compare to clojures now

old wyvern Mar 13, 2021, 12:59 PM

#

The usefulness is that you dont need to copy the entire structure

jovial warren Mar 13, 2021, 12:59 PM

#

https://github.com/Kotlin/kotlinx.collections.immutable maybe this is what BM was referencing

GitHub

Kotlin/kotlinx.collections.immutable

Immutable persistent collections for Kotlin. Contribute to Kotlin/kotlinx.collections.immutable development by creating an account on GitHub.

old wyvern Mar 13, 2021, 12:59 PM

#

But you still need to copy more than the changes you made ussually

jovial warren Mar 13, 2021, 12:59 PM

#

first result for kotlin persistent data structures lol

lunar cypress Mar 13, 2021, 12:59 PM

#

old wyvern A bit more than the changes bard

Depends on the structure but yeah you can't reach that in most cases

#

The most beautiful (imo) persistent data structure is the classic singly linked list

#

Or cons

#

Even though it isn't very powerful it's perfect in a sense because you really do reach constant time and memory with addition/removal at the front

#

And it's the simplest list implementation that exists as well

prisma wave Mar 13, 2021, 1:02 PM

#

linked lists are great

prisma wave Mar 13, 2021, 1:02 PM

#

jovial warren https://github.com/Kotlin/kotlinx.collections.immutable maybe this is what BM wa...

yep thats it

lunar cypress Mar 13, 2021, 1:04 PM

#

Gonna benchmark this I think

#

It has something like transient in clojure as well i see

jovial warren Mar 13, 2021, 1:13 PM

#

private static CommandNode<SharedSuggestionProvider>[] getNodesInIdOrder(Object2IntMap<CommandNode<SharedSuggestionProvider>> nodes) {
    CommandNode<SharedSuggestionProvider>[] result = new CommandNode[nodes.size()];
    for (Object2IntMap.Entry<CommandNode<SharedSuggestionProvider>> entry : Object2IntMaps.fastIterable(nodes)) {
        result[entry.getIntValue()] = entry.getKey();
    }
    return result;
}
```trying to think what the purpose of this might be

#

actually maybe the client wants the nodes in ID order

#

that would make sense

#

is there a better way to basically reverse a map than that?

#

I was thinking that one of Kotlin's map extension functions might be the answer, but I can't seem to find one

old wyvern Mar 13, 2021, 1:21 PM

#

jovial warren I was thinking that one of Kotlin's map extension functions might be the answer,...

Use associate on the entries and return the reversed pair in it

gentle coyote Mar 13, 2021, 1:23 PM

#

o7, I am currently digging into the data conversion stuff using Mojangs DataFixer API.
I want to convert a (serialized) 1.12 item stack NBT data to a 1.16 one. The following code works:

NBTTagCompound converted = (NBTTagCompound) DataConverterRegistry.a().update(
        DataConverterTypes.ITEM_STACK,
        new Dynamic<>(DynamicOpsNBT.a, sourceCompound),
        -1,
        CraftMagicNumbers.INSTANCE.getDataVersion()
).getValue();

But it works just great for "normal" item stacks. As soon as the source Item Stack is a shulker chest it does some strange things :/

#

The biggest problem is the lack of documentation for this stuff. I also tried using the data converter type for a block entity, arranged it in different ways but everytime it either says that minecraft:black_shulker_box or shulker_box would be an invalid (namespaced?) key

jovial warren Mar 13, 2021, 1:26 PM

#

old wyvern Use associate on the entries and return the reversed pair in it

so ```kotlin
associate { it.value to it.key }

half harness Mar 13, 2021, 1:27 PM

#

How would I remove one of the tab completers?

jovial warren Mar 13, 2021, 1:28 PM

#

also, you can't call associate on a Map btw

old wyvern Mar 13, 2021, 1:29 PM

#

on the entries

#

theMap.entries.associate{ it.value to it.key }

jovial warren Mar 13, 2021, 1:29 PM

#

right, then what?

old wyvern Mar 13, 2021, 1:29 PM

#

You only wanted to reverse the map right?

jovial warren Mar 13, 2021, 1:29 PM

#

lemme see

old wyvern Mar 13, 2021, 1:30 PM

#

oh wait you wanted an array

jovial warren Mar 13, 2021, 1:31 PM

#

lemme see if I can work with the map

distant sun Mar 13, 2021, 1:33 PM

#

map.toMap()

jovial warren Mar 13, 2021, 1:33 PM

#

lol

old wyvern Mar 13, 2021, 1:34 PM

#

distant sun map.toMap()

map.toReversedMap()

jovial warren Mar 13, 2021, 1:35 PM

#

I think the reason why it's converted to a list is because I couldn't care less about the integer value, that's just used for ordering

old wyvern Mar 13, 2021, 1:37 PM

#

I see

jovial warren Mar 13, 2021, 1:38 PM

#

the ID is only used to order them in the array

old wyvern Mar 13, 2021, 1:38 PM

#

theMap.entries.associate{ it.value to it.key }.let { map -> Array(map.size(), Map::get) }

This should give you the same result as from the snippet

#

Probably not the most efficient way to do it tho

jovial warren Mar 13, 2021, 1:40 PM

#

yeah

old wyvern Mar 13, 2021, 1:40 PM

#

Maybe just use map

#

Wait nvm

#

hmm

jovial warren Mar 13, 2021, 1:42 PM

#

anyway, lemme test this out

#

seemed to work

#

the client now highlights the commands

old wyvern Mar 13, 2021, 1:44 PM

#

great

jovial warren Mar 13, 2021, 1:44 PM

#

oh btw, since I'm loading plugins myself and stuff, would it be necessary to add a shutdown hook to unload things?

#

just not sure if/what I need to ensure is safely closed

old wyvern Mar 13, 2021, 1:44 PM

#

To let the plugins know of their shutdown?

#

Yes

#

Please do

jovial warren Mar 13, 2021, 1:45 PM

#

also will add console parsing soon

#

it's just a thread right?

#

I just create a new thread and add it as a shutdown hook

old wyvern Mar 13, 2021, 1:45 PM

#

huh?

jovial warren Mar 13, 2021, 1:46 PM

#

Runtime.getRuntime().addShutdownHook()?

#

or is there something else I can use

old wyvern Mar 13, 2021, 1:48 PM

#

Yea ig, then unloading each plugin sends the unload event I assume?

jovial warren Mar 13, 2021, 1:48 PM

#

yeah it'll fire an event

old wyvern Mar 13, 2021, 1:48 PM

#

alright

jovial warren Mar 13, 2021, 1:48 PM

#

there's no filtering to say which plugin it goes to though

#

so it'll go to all plugins

old wyvern Mar 13, 2021, 1:49 PM

#

Should be fine

#

Does it unregister all other "listeners" registered by the plugin after unloading?

jovial warren Mar 13, 2021, 1:49 PM

#

oh also, would you know of a way that I could remove the while (true) in the start method in server btw?

old wyvern Mar 13, 2021, 1:49 PM

#

jovial warren oh also, would you know of a way that I could remove the `while (true)` in the `...

link to the class?

jovial warren Mar 13, 2021, 1:49 PM

#

old wyvern Does it unregister all other "listeners" registered by the plugin after unloadin...

there are no registered listeners

old wyvern Mar 13, 2021, 1:50 PM

#

jovial warren there are no registered listeners

wdym?

jovial warren Mar 13, 2021, 1:50 PM

#

it's all reactive

old wyvern Mar 13, 2021, 1:50 PM

#

Thats still a listener

#

That would run after a plugin is disabled

jovial warren Mar 13, 2021, 1:50 PM

#

yeah but there isn't really a way to unregister that

hot hull Mar 13, 2021, 1:50 PM

#

Gotta love spigot plugins

jovial warren Mar 13, 2021, 1:50 PM

#

hot hull Gotta love spigot plugins

lol

old wyvern Mar 13, 2021, 1:50 PM

#

You can filter with the plugins loadState or whatever that was

jovial warren Mar 13, 2021, 1:50 PM

#

yeah true

jovial warren Mar 13, 2021, 1:50 PM

#

old wyvern link to the class?

https://github.com/KryptonMC/Krypton/blob/master/server/src/main/kotlin/org/kryptonmc/krypton/KryptonServer.kt#L99

#

if I remove it, the main thread stops executing and so the JVM dies

#

in vanilla, this is solved by the runServer method, which calls ticking methods that tick the server

#

but that's not how Krypton is built, since everything that's done there I expect to do when I receive the data

old wyvern Mar 13, 2021, 1:52 PM

#

NettyProcess#run is blocking right?

jovial warren Mar 13, 2021, 1:52 PM

#

it's suspending yeah

#

that just sets up netty

quiet depot Mar 13, 2021, 1:53 PM

#

bardy you need to use non daemon threads

jovial warren Mar 13, 2021, 1:53 PM

#

quiet depot bardy you need to use non daemon threads

yeah not sure how to do that with coroutines

quiet depot Mar 13, 2021, 1:54 PM

#

no clue

#

another thing you could do though is have a queue of runnables and run them in that while loop

old wyvern Mar 13, 2021, 1:54 PM

#

jovial warren that just sets up netty

It suspends till the server needs to stop?

#

Use runBlocking

jovial warren Mar 13, 2021, 1:54 PM

#

old wyvern It suspends till the server needs to stop?

https://github.com/KryptonMC/Krypton/blob/master/server/src/main/kotlin/org/kryptonmc/krypton/NettyProcess.kt#L56

old wyvern Mar 13, 2021, 1:55 PM

#

finally {
    workerGroup.shutdownGracefully()
    bossGroup.shutdownGracefully()
}```

quiet depot Mar 13, 2021, 1:55 PM

#

bardy why is your formatting so fucked

jovial warren Mar 13, 2021, 1:55 PM

#

quiet depot bardy why is your formatting so fucked

what formatting?

#

also, I hardly wrote that netty process code btw, that was mostly BM

old wyvern Mar 13, 2021, 1:55 PM

#

Yea that part woudl be called when netty shuts down

quiet depot Mar 13, 2021, 1:55 PM

#

u've got newlines under your classes and objects

old wyvern Mar 13, 2021, 1:55 PM

#

withContext is suspending

quiet depot Mar 13, 2021, 1:55 PM

#

except it's inconsistent

#

not all declarations have a newline

#

huge fan of the no newline btw, highly recommend going that route

old wyvern Mar 13, 2021, 1:56 PM

#

use runBlocking and just call the blocking netty call at the end

jovial warren Mar 13, 2021, 1:56 PM

#

yeah the override fun initChannel should probably have a new line above it

old wyvern Mar 13, 2021, 1:56 PM

#

with an IO dispatcher if you really want to

#

Doesnt really matter

jovial warren Mar 13, 2021, 1:56 PM

#

wait what

#

how do I do that?

quiet depot Mar 13, 2021, 1:56 PM

#

I'm only talking about the class you linked first

old wyvern Mar 13, 2021, 1:56 PM

#

runBlocking

quiet depot Mar 13, 2021, 1:56 PM

#

KryptonServer

jovial warren Mar 13, 2021, 1:57 PM

#

where Yugi

old wyvern Mar 13, 2021, 1:57 PM

#

One sec

jovial warren Mar 13, 2021, 1:57 PM

#

quiet depot I'm only talking about the class you linked first

yeah that's basically my style lol

quiet depot Mar 13, 2021, 1:57 PM

#

#

it's inconsistent

jovial warren Mar 13, 2021, 1:57 PM

#

ik it's a mess, but it's basically just shoot first, ask questions later lol

quiet depot Mar 13, 2021, 1:57 PM

#

no newline looks better

#

i hate the newline

#

lots of people do it though

#

you do you ig

prisma wave Mar 13, 2021, 1:57 PM

#

is that github?

quiet depot Mar 13, 2021, 1:58 PM

#

yes

prisma wave Mar 13, 2021, 1:58 PM

#

hot theme

quiet depot Mar 13, 2021, 1:58 PM

#

it's github's dark theme

prisma wave Mar 13, 2021, 1:58 PM

#

is it?

quiet depot Mar 13, 2021, 1:58 PM

#

no addon

#

ye

prisma wave Mar 13, 2021, 1:58 PM

#

oh

#

lol

jovial warren Mar 13, 2021, 1:58 PM

#

I think it separates the declaration from the stuff inside of it nicely tbh

prisma wave Mar 13, 2021, 1:58 PM

#

looks different for me

jovial warren Mar 13, 2021, 1:58 PM

#

idk, I just like it

quiet depot Mar 13, 2021, 1:58 PM

#

oh nvm

#

I think I have both on

#

the gh dark theme and the extension

jovial warren Mar 13, 2021, 1:59 PM

#

I'll fix up the horrible code later anyway

#

for now, I'm operating under "shoot first, ask questions later"

quiet depot Mar 13, 2021, 1:59 PM

#

yeah I've got both on

jovial warren Mar 13, 2021, 1:59 PM

#

also, the spacing above the start function is inconsistent because of the way I group things

#

two things that go together get put next to each other

#

and things that don't go together are separated by a new line

quiet depot Mar 13, 2021, 2:00 PM

#

I don't see anything inconsistent about the start function

jovial warren Mar 13, 2021, 2:00 PM

#

no, above it

old wyvern Mar 13, 2021, 2:01 PM

#

Try this bard

#

https://paste.helpch.at/wiwucojeka.kt

quiet depot Mar 13, 2021, 2:01 PM

#

nor above it

#

in general I'm not a fan of this class

jovial warren Mar 13, 2021, 2:01 PM

#

you agree with my grouping?

quiet depot Mar 13, 2021, 2:01 PM

#

there's so much going on

#

way too much

jovial warren Mar 13, 2021, 2:01 PM

#

yeah I agree

#

not really all that much I can do about that though

quiet depot Mar 13, 2021, 2:01 PM

#

oh are you talking about these?

#

override fun player(uuid: UUID) = players.firstOrNull { it.uuid == uuid }
    override fun player(name: String) = players.firstOrNull { it.name == name }```

#

and there's always things you can do

jovial warren Mar 13, 2021, 2:02 PM

#

no, not those

#

just the fields

old wyvern Mar 13, 2021, 2:02 PM

#

Bard

jovial warren Mar 13, 2021, 2:03 PM

#

https://paste.helpch.at/ifapucihel.cs seemed to work

quiet depot Mar 13, 2021, 2:03 PM

#

idk grouping seems fine for the most part except for the fact that there's a good chance 99% of these fields simply shouldn't be here

jovial warren Mar 13, 2021, 2:03 PM

#

most of them are here because of the API

#

look at the interface this implements

quiet depot Mar 13, 2021, 2:03 PM

#

if your api forces you to write bad code then you need a new api

jovial warren Mar 13, 2021, 2:04 PM

#

no, that's not what I'm saying

#

just look at the class this implements, then you might understand why there's so many things in this class

quiet depot Mar 13, 2021, 2:04 PM

#

ig it all has to come together somewhere (unless you use guice like a pro)

jovial warren Mar 13, 2021, 2:04 PM

#

not saying you're wrong for calling me out for writing bad code, just saying there's an explanation

#

efe tf?

#

oh also, Piggy, what do you think of native Adventure support?

old wyvern Mar 13, 2021, 2:05 PM

#

You could also split up all the properties in the Server interface ig

jovial warren Mar 13, 2021, 2:05 PM

#

or group them better

quiet depot Mar 13, 2021, 2:05 PM

#

or use guice

old wyvern Mar 13, 2021, 2:06 PM

#

group them better as in?

quiet depot Mar 13, 2021, 2:06 PM

#

native adventure is good

jovial warren Mar 13, 2021, 2:06 PM

#

e.g. isOnline, isHardcore, difficulty and gamemode could all be grouped into some sort of server settings

quiet depot Mar 13, 2021, 2:06 PM

#

did you figure out reloading?

old wyvern Mar 13, 2021, 2:06 PM

#

Is that not what I just said xD

jovial warren Mar 13, 2021, 2:06 PM

#

quiet depot did you figure out reloading?

nope lol

jovial warren Mar 13, 2021, 2:06 PM

#

old wyvern Is that not what I just said xD

actually, yeah lol

#

the API is still a massive W.I.P anyway, so feedback is greatly appreciated

#

oh also, what do you guys think of the logger names for plugins?

#

they're currently Plugin - Name (to differentiate from Krypton classes)

#

%d{HH:mm:ss.SSS} %style{%-30.-30thread}{bright,cyan} %style{%-24.-24logger{0}}{bright,green} %highlight{%-6level} %msg%n that's my logging pattern lol

#

a.k.a https://i.imgur.com/payzQUD.png

Imgur

quiet depot Mar 13, 2021, 2:08 PM

#

ew

#

what logger is that

jovial warren Mar 13, 2021, 2:09 PM

#

it's a custom format I ~~stole from JDA~~ lol

quiet depot Mar 13, 2021, 2:09 PM

#

no

#

what logger

jovial warren Mar 13, 2021, 2:09 PM

#

it used to be a Logback format, but we're using Log4j2 now

quiet depot Mar 13, 2021, 2:09 PM

#

I'm a firm believer that logback is the best logger

jovial warren Mar 13, 2021, 2:09 PM

#

Log4j2 is apparently faster, supports logging more than just strings, and also can log async

#

if it was Log4j vs Logback, Logback all the way

#

but Log4j2 vs Logback, Log4j2

quiet depot Mar 13, 2021, 2:10 PM

#

%red(%d{yyyy-MM-dd HH:mm:ss}) %green([%thread]) %highlight(%level) %cyan(%logger{36}) - %msg%n

#

my format

#

i like it

#

relies on symbols rather than spacing for separation

jovial warren Mar 13, 2021, 2:10 PM

#

looks quite similar to Spigot's tbh

#

just with colours

#

lemme translate that to Log4j2 format and see it

quiet depot Mar 13, 2021, 2:11 PM

#

https://github.com/PiggyPiglet/DocDex/blob/master/common/src/main/resources/logback.xml

#

wow

jovial warren Mar 13, 2021, 2:12 PM

#

ooo

quiet depot Mar 13, 2021, 2:12 PM

#

just noticed a typo in the file policy

#

oh well

jovial warren Mar 13, 2021, 2:12 PM

#

https://i.imgur.com/vKBdWEO.png nice

Imgur

#

might use [PluginName] to indicate plugins instead of Plugin - PluginName

quiet depot Mar 13, 2021, 2:13 PM

#

change the thread colour

#

or change the info colour

jovial warren Mar 13, 2021, 2:13 PM

#

yeah because it clashes

quiet depot Mar 13, 2021, 2:13 PM

#

don't want them matching

jovial warren Mar 13, 2021, 2:14 PM

#

also, is saving logs to a file like vanilla does a good idea btw?

quiet depot Mar 13, 2021, 2:14 PM

#

it's basically essential

#

here's what mine looks like

lunar cypress Mar 13, 2021, 2:14 PM

#

and it's trivial with all major logging frameworks

jovial warren Mar 13, 2021, 2:15 PM

#

yeah Log4j2 should have no issues

#

also, Krypton doesn't support SLF4J natively btw, it uses Log4j2's API (basically SLF4J++)

quiet depot Mar 13, 2021, 2:15 PM

#

yeah that's not smart

#

I think

jovial warren Mar 13, 2021, 2:15 PM

#

I mean, you can add SLF4J compat by depending on log4j-slf4j-impl if you really want it, and it'll work fine

quiet depot Mar 13, 2021, 2:15 PM

#

actually there might not really be downsides to that with an app like krypton

jovial warren Mar 13, 2021, 2:16 PM

#

yeah, since all logging is managed centrally anyway

lunar cypress Mar 13, 2021, 2:16 PM

#

I don't see an issue with it because users are not supposed to choose a logger implementation

jovial warren Mar 13, 2021, 2:16 PM

#

^

quiet depot Mar 13, 2021, 2:16 PM

#

yeah it's more of a mistake for something like jda where you're expected to provide an impl

lunar cypress Mar 13, 2021, 2:16 PM

#

yeah

jovial warren Mar 13, 2021, 2:16 PM

#

yeah

#

oh also, Piggy, any ideas on what style I should use for the thread?

lunar cypress Mar 13, 2021, 2:16 PM

#

although I would only expose the slf4j api to the plugin api in case you want to change it

jovial warren Mar 13, 2021, 2:16 PM

#

I can use any ANSI colour

quiet depot Mar 13, 2021, 2:17 PM

#

I've posted my format

#

that's what I use

#

it's my favourite

#

so that's my recommendation ig

jovial warren Mar 13, 2021, 2:17 PM

#

lemme see what blue looks like

#

oh that's nice

quiet depot Mar 13, 2021, 2:17 PM

#

nah change the info to blue

jovial warren Mar 13, 2021, 2:18 PM

#

https://i.imgur.com/uoNxZKU.png

Imgur

quiet depot Mar 13, 2021, 2:18 PM

#

why's the name green?

jovial warren Mar 13, 2021, 2:18 PM

#

that's cyan lol

#

apparently

quiet depot Mar 13, 2021, 2:18 PM

#

should look like this

jovial warren Mar 13, 2021, 2:18 PM

#

according to Atom OneDark anyway

#

oh btw, Log4j2 has a Logback preset for highlighting

#

that might be nice

quiet depot Mar 13, 2021, 2:19 PM

#

try that

#

and change cyan to light blue

#

maybe that'll fix it

#

and thread back to green

jovial warren Mar 13, 2021, 2:20 PM

#

https://i.imgur.com/Ti39cnL.png this is with green thread and same cyan with Logback preset

Imgur

#

also, https://i.imgur.com/ukcLeaI.png wow I must've been tired last night

Imgur

quiet depot Mar 13, 2021, 2:21 PM

#

that atom one dark thing must just fuck with it

jovial warren Mar 13, 2021, 2:21 PM

#

yeah

#

oh also, actual programming question, lemme just bring up what I mean so I can try and explain this

#

https://github.com/KryptonMC/Krypton/blob/master/server/src/main/kotlin/org/kryptonmc/krypton/plugin/KryptonPluginManager.kt#L44 you see this?

GitHub

KryptonMC/Krypton

A fast, lightweight Minecraft server written in Kotlin - KryptonMC/Krypton

#

for whatever reason, if I use that, the folder generates in the root directory, not in the plugins folder

old wyvern Mar 13, 2021, 2:23 PM

#

"/plugins/"

#

Remove the first /

prisma wave Mar 13, 2021, 2:23 PM

#

imagine not using .resolve

#

😬

old wyvern Mar 13, 2021, 2:23 PM

#

wait no

#

hmm

jovial warren Mar 13, 2021, 2:23 PM

#

resolve instead of walk?

prisma wave Mar 13, 2021, 2:23 PM

#

no

#

instead of file constructor

jovial warren Mar 13, 2021, 2:24 PM

#

didn't know that existed lol

quiet depot Mar 13, 2021, 2:24 PM

#

o wait

jovial warren Mar 13, 2021, 2:24 PM

#

wait so what's the function?

quiet depot Mar 13, 2021, 2:24 PM

#

use a util from nio files

#

or if this "resolve" thing is a better alternative in kotlin, use that

prisma wave Mar 13, 2021, 2:24 PM

#

they do the same thing

jovial warren Mar 13, 2021, 2:24 PM

#

walk is basically the Kotlin equivalent of Files.walk

quiet depot Mar 13, 2021, 2:25 PM

#

idek know what that does

prisma wave Mar 13, 2021, 2:25 PM

#

walks over a directory

jovial warren Mar 13, 2021, 2:25 PM

#

^

#

basically collects everything inside of a directory into a sequence

quiet depot Mar 13, 2021, 2:25 PM

#

ah that clears it up

#

yugi the jdk is the default one

old wyvern Mar 13, 2021, 2:25 PM

#

piggy

quiet depot Mar 13, 2021, 2:25 PM

#

no need to explicitly declare it

old wyvern Mar 13, 2021, 2:25 PM

#

ah

#

Anyway

#

Cna you make it not delete the msg it if fails

#

Or atleast delay the deletion

jovial warren Mar 13, 2021, 2:25 PM

#

what message?

quiet depot Mar 13, 2021, 2:25 PM

#

make an issue pls

jovial warren Mar 13, 2021, 2:26 PM

#

oh right lol

old wyvern Mar 13, 2021, 2:26 PM

#

Alright

quiet depot Mar 13, 2021, 2:26 PM

#

I'm super busy with school work atm, haven't been able to open the ide in weeks

old wyvern Mar 13, 2021, 2:26 PM

#

I see

quiet depot Mar 13, 2021, 2:26 PM

#

and when I do get a little free time

prisma wave Mar 13, 2021, 2:26 PM

#

im gonna be extremely petty here and just say "collecting into a sequence" doesnt make sense

quiet depot Mar 13, 2021, 2:26 PM

#

don't usually spend it on coding

old wyvern Mar 13, 2021, 2:26 PM

#

Shall I fork and PR then?

quiet depot Mar 13, 2021, 2:26 PM

#

sure

#

yes pls

old wyvern Mar 13, 2021, 2:26 PM

#

Alrighty 👍

quiet depot Mar 13, 2021, 2:27 PM

#

make sure to test it though

old wyvern Mar 13, 2021, 2:27 PM

#

Sure

jovial warren Mar 13, 2021, 2:27 PM

#

prisma wave im gonna be extremely petty here and just say "collecting into a sequence" doesn...

-_-

quiet depot Mar 13, 2021, 2:27 PM

#

sorry it's a little bit of a hassle if you don't already have an environment setup

#

you need mysql

jovial warren Mar 13, 2021, 2:27 PM

#

prisma wave imagine not using .resolve

how do you do this btw?

old wyvern Mar 13, 2021, 2:27 PM

#

Yea, I do have mysql

jovial warren Mar 13, 2021, 2:27 PM

#

where is it?

quiet depot Mar 13, 2021, 2:27 PM

#

when you first run the bot it'll make a config and shit

#

populate it with db details

prisma wave Mar 13, 2021, 2:27 PM

#

jovial warren how do you do this btw?

File.resolve

old wyvern Mar 13, 2021, 2:27 PM

#

Ah alright

quiet depot Mar 13, 2021, 2:27 PM

#

it'll create the schematic, u just need to create a db and user

jovial warren Mar 13, 2021, 2:27 PM

#

prisma wave File.resolve

you sure that exists?

old wyvern Mar 13, 2021, 2:27 PM

#

Wait is it going to index everything? xD

quiet depot Mar 13, 2021, 2:27 PM

#

no

prisma wave Mar 13, 2021, 2:28 PM

#

jovial warren you sure that exists?

absolutely

old wyvern Mar 13, 2021, 2:28 PM

#

phew

#

Alright

quiet depot Mar 13, 2021, 2:28 PM

#

ur only modifying the bot right?

old wyvern Mar 13, 2021, 2:28 PM

#

Yes

#

Oh those are separate

quiet depot Mar 13, 2021, 2:28 PM

#

you can just use the public docdex instance then

old wyvern Mar 13, 2021, 2:28 PM

#

yea nvm

#

Alright

quiet depot Mar 13, 2021, 2:28 PM

#

https://docdex.helpch.at

#

just make sure that link is in the bot config

jovial warren Mar 13, 2021, 2:28 PM

#

prisma wave absolutely

the only resolve functions I can find do not match what I want at all

old wyvern Mar 13, 2021, 2:28 PM

#

quiet depot just make sure that link is in the bot config

oke 👍

quiet depot Mar 13, 2021, 2:29 PM

#

even if it did index everything it'd only fry your cpu for a couple mins

#

assuming it wasn't a potato

#

no biggie

old wyvern Mar 13, 2021, 2:29 PM

#

It aint a potato, but internet tho

quiet depot Mar 13, 2021, 2:29 PM

#

it doesn't index remotely

old wyvern Mar 13, 2021, 2:30 PM

#

wdym?

#

oh it comes with it

#

I see

quiet depot Mar 13, 2021, 2:30 PM

#

it'd either
i) crash
ii) take a really long time
iii) get you banned from the site, or by your isp, for an attempted dos attack

jovial warren Mar 13, 2021, 2:30 PM

#

@prisma wave oh right, ik where you want this now

quiet depot Mar 13, 2021, 2:31 PM

#

so it can realistically only index local javadocs

old wyvern Mar 13, 2021, 2:31 PM

#

I might get flagged by my isp but the other cases shouldnt happen I assume

quiet depot Mar 13, 2021, 2:31 PM

#

anyway none of that matters since you're only running the bot

old wyvern Mar 13, 2021, 2:31 PM

#

Yup

jovial warren Mar 13, 2021, 2:32 PM

#

oh btw Piggy, here's the comparison of the three logging frameworks for you: https://stackify.com/compare-java-logging-frameworks/

Stackify

Thorben Janssen

Java Logging Frameworks: log4j vs logback vs log4j2

Log4j, Logback, and log4j2 are all broadly used logging frameworks. What's the difference between them and which one should you prefer?

quiet depot Mar 13, 2021, 2:33 PM

#

i'll consider switching on my next project

jovial warren Mar 13, 2021, 2:34 PM

#

for those who can't be assed to read, basically, Log4j should not be used by anyone ever again ever, Logback is nice and better than Log4j but it has a few flaws, and Log4j2 is the best out of the three that improves on both

prisma wave Mar 13, 2021, 2:35 PM

#

elara/logging outdoes them all

jovial warren Mar 13, 2021, 2:35 PM

#

I second this notion

#

well, it will

quiet depot Mar 13, 2021, 2:35 PM

#

would elara/logging be a package for elara's package manager?

prisma wave Mar 13, 2021, 2:36 PM

#

probably

jovial warren Mar 13, 2021, 2:36 PM

#

indeed

stuck harbor Mar 13, 2021, 2:36 PM

#

elara/dotnet hmmm?

prisma wave Mar 13, 2021, 2:36 PM

#

maybe in stdlib

quiet depot Mar 13, 2021, 2:36 PM

#

u should start using random symbols in elara package manager

#

instead of using / in packages

#

elara¶logging

jovial warren Mar 13, 2021, 2:36 PM

#

when Elara is at least functional enough to do things, I'll start making the package manager

quiet depot Mar 13, 2021, 2:36 PM

#

makes perfect sense

stuck harbor Mar 13, 2021, 2:36 PM

#

elaraßlogging

jovial warren Mar 13, 2021, 2:36 PM

#

lol

prisma wave Mar 13, 2021, 2:36 PM

#

speaking of

#

we are reworking elara to be purely functional

#

ez

onyx loom Mar 13, 2021, 2:36 PM

#

lol

stuck harbor Mar 13, 2021, 2:36 PM

#

mmmm

jovial warren Mar 13, 2021, 2:37 PM

#

I swear it already is purely functional

#

thonking

prisma wave Mar 13, 2021, 2:37 PM

#

not purely

stuck harbor Mar 13, 2021, 2:37 PM

#

but wheres the data oriented?

#

no love for data oriented programming

#

sadge

quiet depot Mar 13, 2021, 2:37 PM

#

I thought data oriented was basically exclusively used for games

stuck harbor Mar 13, 2021, 2:37 PM

#

👀

jovial warren Mar 13, 2021, 2:37 PM

#

oh btw, as you're here Piggy, you wanna see how I got plugin loading to work in the end?

onyx loom Mar 13, 2021, 2:38 PM

#

well yes, elara/game has u covered

quiet depot Mar 13, 2021, 2:38 PM

#

sure

jovial warren Mar 13, 2021, 2:38 PM

#

https://github.com/KryptonMC/Krypton/blob/master/server/src/main/kotlin/org/kryptonmc/krypton/plugin/KryptonPluginManager.kt#L65

GitHub

KryptonMC/Krypton

A fast, lightweight Minecraft server written in Kotlin - KryptonMC/Krypton

stuck harbor Mar 13, 2021, 2:38 PM

#

when I see ::
is this a c?

jovial warren Mar 13, 2021, 2:39 PM

#

literally went to Nicole last night, told her I got plugin loading working and she was like https://i.imgur.com/kVso37H.png lol

Imgur

quiet depot Mar 13, 2021, 2:39 PM

#

loading was never the hard part?

jovial warren Mar 13, 2021, 2:39 PM

#

yeah it wasn't lol

quiet depot Mar 13, 2021, 2:39 PM

#

it's just everything after loading

prisma wave Mar 13, 2021, 2:39 PM

#

jovial warren I swear it already is purely functional

no previously it was very multiparadigm (return statements, while loops, no guarantee of purity) but we're reworking it a lot

jovial warren Mar 13, 2021, 2:39 PM

#

it was way easier than I thought

#

oh btw Piggy, you might be able to answer this

#

if I load the main class and that class calls constructors of other classes, those will be auto-loaded right?

#

actually I think I've already answered this myself but whatever lol

prisma wave Mar 13, 2021, 2:40 PM

#

monads in elara 😃

jovial warren Mar 13, 2021, 2:41 PM

#

oh btw, wdym by all the stuff that comes after loading?

quiet depot Mar 13, 2021, 2:41 PM

#

d;urlclassloader

ruby craterBOT Mar 13, 2021, 2:41 PM

#

java.net.URLClassLoader

public class URLClassLoader
extends SecureClassLoader
implements Closeable```
URLClassLoader has 1 extensions, 1 implementations, 11 methods, 2 all implementations, and  1 sub classes.

Description:

This class loader is used to load classes and resources from a search path of URLs referring to both JAR files and directories. Any jar: scheme URL (see JarURLConnection) is assumed to refer to a JAR file. Any file: scheme URL that ends with a '/' is assumed to refer to a directory. Otherwise, the URL is assumed to refer to a JAR file which will be opened as needed.

This class loader supports the loading of classes and resources from the contents of a multi-release JAR file that is referred to by a given URL.

The AccessControlContext of the thread that created the instance of URLClassLoader will be used when subsequently loading classes and resources.

The classes that are loaded are by default granted permission only to access the URLs specified when the URLClassLoader was created.

quiet depot Mar 13, 2021, 2:42 PM

#

jovial warren oh btw, wdym by all the stuff that comes after loading?

reloading/unloading

quiet depot Mar 13, 2021, 2:42 PM

#

jovial warren if I load the main class and that class calls constructors of other classes, tho...

if they're accessible

jovial warren Mar 13, 2021, 2:43 PM

#

quiet depot reloading/unloading

what should I do for unloading?

quiet depot Mar 13, 2021, 2:43 PM

#

you need to ensure there aren't any references to any of the classes of that plugin

jovial warren Mar 13, 2021, 2:43 PM

#

reloading is a no go for the moment, as I really don't want whatever kinda hacks we explained the other day to haunt me in my nightmares lol

quiet depot Mar 13, 2021, 2:43 PM

#

then close its classlader

#

god my o key is just not working today

jovial warren Mar 13, 2021, 2:44 PM

#

so if it's stored in a set that counts as a reference right?

quiet depot Mar 13, 2021, 2:44 PM

#

yep

jovial warren Mar 13, 2021, 2:44 PM

#

so I remove it from the set and then bam

quiet depot Mar 13, 2021, 2:44 PM

#

nope

#

well

jovial warren Mar 13, 2021, 2:44 PM

#

well, I remove it from the set and close the loader

quiet depot Mar 13, 2021, 2:44 PM

#

if it's only reference is in the set then yes

#

in an ideal world that's it

#

the garbage collector will come along and send it to purgatory

jovial warren Mar 13, 2021, 2:45 PM

#

do I need to do anything when the server is shut down btw?

#

or will the GC yeet the classes for me anyway

quiet depot Mar 13, 2021, 2:45 PM

#

they'll be yeeted

jovial warren Mar 13, 2021, 2:46 PM

#

so you're only talking about unloading the plugin whilst the server is still running then, right?

quiet depot Mar 13, 2021, 2:46 PM

#

yes

jovial warren Mar 13, 2021, 2:46 PM

#

yeah I ain't doing that yet

#

no chance

#

https://tenor.com/WL0W.gif

Tenor

quiet depot Mar 13, 2021, 2:53 PM

#

how does .class in java work?

#

e.g.

#

System.class```

#

is class a static variable generated at compile?

obtuse gale Mar 13, 2021, 2:54 PM

#

Compile time yes

quiet depot Mar 13, 2021, 2:54 PM

#

is it a static field?

obtuse gale Mar 13, 2021, 2:54 PM

#

Uh

quiet depot Mar 13, 2021, 2:55 PM

#

just thinking

#

imagine changing a classes class via unsafe lol

#

if System.class returned Class<String>

obtuse gale Mar 13, 2021, 2:55 PM

#

I mean 80% of Java is runtime reflection anyway lmao I wouldn't be surprised if that was too

obtuse gale Mar 13, 2021, 2:56 PM

#

quiet depot if System.class returned Class<String>

Mm surely you can change the Class object at the address of the other one.. I would assume?

quiet depot Mar 13, 2021, 2:57 PM

#

only if it's a field

obtuse gale Mar 13, 2021, 2:57 PM

#

Well it's gotta be somewhere lmao

quiet depot Mar 13, 2021, 2:58 PM

#

yeah but I don't see a method in unsafe which allows you to find the address of anything that isn't a field

ocean quartz Mar 13, 2021, 3:01 PM

#

Lol request paid is great, "Advanced java programmer" budget $5-$10

obtuse gale Mar 13, 2021, 3:02 PM

#

I can make an advanced Hello World for that

jovial warren Mar 13, 2021, 3:17 PM

#

quiet depot yeah but I don't see a method in unsafe which allows you to find the address of ...

gl using unsafe in Java 11

#

actually that's excluded isn't it

#

mainly because loads of articles cropped up about why it was dumb for Oracle to remove it lol

quiet depot Mar 13, 2021, 3:18 PM

#

yeah been doing some research I don't think what I originally described is possible

#

I'm gonna keep researching this

#

I refuse to believe that reliably unloading classes is simply impossible

jovial warren Mar 13, 2021, 3:24 PM

#

okay wtf ```
Exception in thread "DefaultDispatcher-worker-1" java.lang.NullPointerException: Parameter specified as non-null is null: method kotlin.io.FilesKt__UtilsKt.resolve, parameter $this$resolve
at kotlin.io.FilesKt__UtilsKt.resolve(Utils.kt)
at org.kryptonmc.krypton.plugin.KryptonPluginManager.load(KryptonPluginManager.kt:45)
at org.kryptonmc.krypton.plugin.KryptonPluginManager.<init>(KryptonPluginManager.kt:24)
at org.kryptonmc.krypton.KryptonServer$start$1$1.invokeSuspend(KryptonServer.kt:96)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

#

the parameter given to resolve is non null

#

that error is literally impossible

onyx loom Mar 13, 2021, 3:28 PM

#

🌚

jovial warren Mar 13, 2021, 3:30 PM

#

@prisma wave was your idea to use resolve, any ideas?

#

val dataFolder = pluginsFolder.resolve(description.name) this throws an NPE

jovial warren Mar 13, 2021, 4:37 PM

#

oh btw, also, is there a way I can use centralised versioning that I can access in code?

#

e.g. I have Krypton's version exposed to the API in the KryptonServerInfo object, but hard coding this value means I have to remember to update it on every release

#

is there a way I can just use gradle.properties or something to have Gradle able to read and use the version and also have it readable in code?

obtuse gale Mar 13, 2021, 4:40 PM

#

do how spigot does it and relocate the entire package just to add the version to it

#

you'll always carry the version in every class name that way 👍

jovial warren Mar 13, 2021, 4:41 PM

#

that's not what Spigot does

#

Bukkit uses pom.properties in META-INF to get the actual Bukkit version

obtuse gale Mar 13, 2021, 4:41 PM

#

sure, it definitely doesn't relocate org.bukkit.craftbukkit.Whatever to org.bukkit.craftbukkit.{nms}.Whatever

jovial warren Mar 13, 2021, 4:41 PM

#

idm updating the server version manually, since that's only in code

#

it's just the actual project version

obtuse gale Mar 13, 2021, 4:42 PM

#

it was sarcasm bardy because spigot is utter shit

jovial warren Mar 13, 2021, 4:42 PM

#

ah

#

maybe Gradle has a way to generate a pom.properties

errant geyser Mar 13, 2021, 4:43 PM

#

jovial warren oh btw, also, is there a way I can use centralised versioning that I can access ...

You can do it from Gradle cant you?

jovial warren Mar 13, 2021, 4:44 PM

#

wdym?

errant geyser Mar 13, 2021, 4:45 PM

#

In an old Spring project I had the version info pulled from the build.gradle using something Gradle has, I'll see if I still have it somewhere

#

It's part of Spring Boot, nvm

#

springBoot {
    buildInfo()
}```
Then I could use `BuildProperties.version`

jovial warren Mar 13, 2021, 4:50 PM

#

I could use Gradle to generate a krypton.properties file in META-INF or something and then read that at runtime

errant geyser Mar 13, 2021, 4:51 PM

#

Seems like the better way to do it

#

Unless you make a publicly accessible text file somewhere that you update that contains the version info that you download and read at runtime....
But that's horrible.

jovial warren Mar 13, 2021, 4:56 PM

#

that's not what I want either

#

I want to read Gradle build properties and write them to a file

#

I swear I'm gonna just add it to the manifest in a minute lol

#

there seems to be nothing on the net about how to do something like this

errant geyser Mar 13, 2021, 5:15 PM

#

How does Wolfram do stuff so quickly

#

I was writing a crappy Go program to find the factors of a number. It took like 20 minutes to complete for 600851475143 and Wolfram did it in about 6 seconds wtf

prisma wave Mar 13, 2021, 5:16 PM

#

Really good optimisations

#

Probably parallel computation too

#

And caching a lot of shit

jovial warren Mar 13, 2021, 5:17 PM

#

ah, BM, can you help me?

#

you know Gradle better than I do

paper kite Mar 13, 2021, 5:20 PM

#

hey, you all

#

I'm trying to make a plugin that randomly eliminates all the blocks in a column x,z of the world, close to a player

#

//x and z are the coords x and z close to the player, and y is the coord y of the player
 for (int i = (int)y; i < -1; i--) {
                Location block_location = new Location(world, x, i, z);
                Block block = block_location.getBlock();
                block.setType(Material.AIR);
            }

#

I tried to do this, but java is giving me an warning

#

"Loop executes 0 or one billion times"

stuck harbor Mar 13, 2021, 5:22 PM

#

idk but can you cast y to an int?

paper kite Mar 13, 2021, 5:23 PM

#

I actually don't know, good question

stuck harbor Mar 13, 2021, 5:23 PM

#

also, less than -1

#

and u do i--

paper kite Mar 13, 2021, 5:23 PM

#

yeah, bedrock is usually at y = 0

oblique heath Mar 13, 2021, 5:23 PM

#

should be greater than -1 ^

paper kite Mar 13, 2021, 5:23 PM

#

oh

#

wait

stuck harbor Mar 13, 2021, 5:23 PM

#

yeah

paper kite Mar 13, 2021, 5:23 PM

#

you are right

#

miss typed

stuck harbor Mar 13, 2021, 5:23 PM

#

if i starts below one, then it will be infinite

paper kite Mar 13, 2021, 5:23 PM

#

aaaaand the warning is gone

#

thank you!

#

I think you can cast from int to double, since double has a bigger storage

#

not sure, though

jovial warren Mar 13, 2021, 5:25 PM

#

and should probably be >= 0 instead of > -1

paper kite Mar 13, 2021, 5:25 PM

#

oh

jovial warren Mar 13, 2021, 5:25 PM

#

also, beware of the fact that the bedrock level will change in 1.17

paper kite Mar 13, 2021, 5:25 PM

#

yeah, yeah

oblique heath Mar 13, 2021, 5:25 PM

#

=0 does the same thing as > -1 if it's an int

jovial warren Mar 13, 2021, 5:26 PM

#

yeah ik, just a bit cleaner imo

paper kite Mar 13, 2021, 5:26 PM

#

but why should I change > -1 to >= 0?

oblique heath Mar 13, 2021, 5:26 PM

#

i suppose

paper kite Mar 13, 2021, 5:26 PM

#

oh

#

all right

#

I think It makes sense

#

all right, I think It's done. I'll test it

#

btw, this is how I did It

#

@Override
    public void run() {
        System.out.println("Task has been run");
        player_list = Bukkit.getOnlinePlayers();
        for (Player p : player_list) {
            Location loc = p.getLocation();
            double x = loc.getX();
            double y = loc.getY();
            double z = loc.getZ();
            World world = loc.getWorld();
            x += rand.nextInt(11) - 5;
            //y -= rand.nextInt(2) + 1;
            z += rand.nextInt(11) - 5;
            for (int i = (int)y; i >= 0; i--) {
                Location block_location = new Location(world, x, i, z);
                Block block = block_location.getBlock();
                block.setType(Material.AIR);
            }
            //p.sendMessage("Bloco em " + x + " " + y + " " + z + " foi removido");
        }
    }