#development | HelpChat | Page 75

worn jasper Feb 23, 2024, 5:45 PM

#

yes, but uuid IS an id.

#

there is legit no way to update an uuid of an account

#

it's the unique for each account.

graceful citrus Feb 23, 2024, 5:46 PM

#

updating on other tables has nothing to do with data type

dense galleon Feb 23, 2024, 5:46 PM

#

How much will the performance be impacted realistically lol

worn jasper Feb 23, 2024, 5:46 PM

#

the single case where that could be used, is if you want to transfer everything from x to y, but at that point just copy it, create a new user and delete the old....

graceful citrus Feb 23, 2024, 5:46 PM

#

you mark uuid as foreign or primary key and its no different

worn jasper Feb 23, 2024, 5:46 PM

#

dense galleon How much will the performance be impacted realistically lol

0

#

basically

graceful citrus Feb 23, 2024, 5:46 PM

#

worn jasper 0

uber big scales you will see a difference

#

on a minecraft plugin basically none

worn jasper Feb 23, 2024, 5:47 PM

#

I am speaking in the context we are now.

graceful citrus Feb 23, 2024, 5:47 PM

#

regardless there no point doing premature optimization

worn jasper Feb 23, 2024, 5:47 PM

#

^^

dense galleon Feb 23, 2024, 5:47 PM

#

I always fall for the premature optimization trap

worn jasper Feb 23, 2024, 5:47 PM

#

literally, we are not speaking about a company with millions of rows in an sql database

dense galleon Feb 23, 2024, 5:48 PM

#

To make "things more future-proof"

graceful citrus Feb 23, 2024, 5:48 PM

#

https://stackoverflow.com/questions/2346920/sql-select-speed-int-vs-varchar

#

take a look here @dense galleon

worn jasper Feb 23, 2024, 5:48 PM

#

and using uuid or id as primary key, will probably be one of the "less" factors when it comes to optimization in sql

graceful citrus Feb 23, 2024, 5:48 PM

#

comment by grzegorz

worn jasper Feb 23, 2024, 5:48 PM

#

since most of the time, it's a query issue

#

~~take hangar sql queries as an example, they quite need to be optimized, tbf they have already been a bit but not perfect yet~~

#

and tbh, "norms" can be taken in several ways

#

take hangar again as an example, if you scheck their database structure

#

god...

#

they are not respecting several normal forms

#

lol

#

but to be fair, it wouldn't make sense for them to respect them in their case.

#

normal forms are good to know in general and a good base, but there are cases where they are not good.

graceful citrus Feb 23, 2024, 5:51 PM

#

main difference would be on index size and you cant get out of querying for the uuid varchar at least once

worn jasper Feb 23, 2024, 5:51 PM

#

going by id is possible sure, but you would have to do at least one query to get that id with the uuid.

abstract current Feb 23, 2024, 5:52 PM

#

hi

graceful citrus Feb 23, 2024, 5:52 PM

#

worn jasper going by id is possible sure, but you would have to do at least one query to get...

ya, i can see it making a "difference" if you query a lot for the uuid

abstract current Feb 23, 2024, 5:52 PM

#

can somebody maybe help me with the connect feature of deluxemenus?

graceful citrus Feb 23, 2024, 5:52 PM

#

then it might be (probably not) worth it to query for it to get id once then use the id on a id-indexed table

worn jasper Feb 23, 2024, 5:52 PM

#

graceful citrus ya, i can see it making a "difference" if you query a lot for the uuid

in theory, you could get the id once on join, cache it and voila, do all the next queries with that id

graceful citrus Feb 23, 2024, 5:52 PM

#

ya exactly

worn jasper Feb 23, 2024, 5:52 PM

#

will it make a huge difference? maybe in hypixel, but not in 99.99999% of the cases

graceful citrus Feb 23, 2024, 5:53 PM

#

even in hypixel its probably not a huge difference

worn jasper Feb 23, 2024, 5:53 PM

#

yeah

graceful citrus Feb 23, 2024, 5:53 PM

#

but indexing file size wise it will since varchar index is quite size intensive

#

afaik

worn jasper Feb 23, 2024, 5:53 PM

#

so the question is, do you want to "over" optimize it at the cost of a tiny bit of ram or not lmao

worn jasper Feb 23, 2024, 5:53 PM

#

graceful citrus but indexing file size wise it will since varchar index is quite size intensive

true.

#

TLDR; it does make a tiny difference. Is it that noticeable? Very probably not.

#

Then it also depends on how your systems works, for instance, if you request all the data from the database on join and cache it all, then going with uuid probably won't make a difference.

worn jasper Feb 23, 2024, 5:55 PM

#

abstract current hi

Also, hi, focused on the conversation, mb. What do ya need?

graceful citrus Feb 23, 2024, 5:55 PM

#

worn jasper TLDR; it does make a tiny difference. Is it that noticeable? Very probably not.

if you have a lot of tables, it might be worth it to query for id then use the id for everything else maybe, but i would only do it AFTER it runs into a performance issue and not before

worn jasper Feb 23, 2024, 5:56 PM

#

^^

#

Also, if you care about performance, don't make the mistake some do cause it looks easier of using FROM several tables and then having a WHERE with their conditions, use (inner) joins, they are more performant.

#

And this, funnily enough, can have a huge impact in performance depending on your database from tests I did at school.

abstract current Feb 23, 2024, 5:58 PM

#

worn jasper Also, hi, focused on the conversation, mb. What do ya need?

oh np. i tried to use deluxemenus to connect from world to world in my server with multiverse core but i dont understand how i need to connect it

worn jasper Feb 23, 2024, 5:59 PM

#

abstract current oh np. i tried to use deluxemenus to connect from world to world in my server wi...

read the channel topic, not the place for that. #general-plugins

abstract current Feb 23, 2024, 5:59 PM

#

worn jasper read the channel topic, not the place for that. <#164280494874165248>

oh sorry

#

mb

grand island Feb 23, 2024, 7:07 PM

#

that just overcomplicating a database schema IMO

#

like now, to insert something for a new player you need to requests its generated id

#

from the database

atomic trail Feb 23, 2024, 7:23 PM

#

TriumphGui doesn't have a pane system right? To have sub-guis essentially

I'm trying to set up pages for a selection system basically. But not sure what the best option would be

#

@pulsar ferry Sorry for the @ just saw you were online so I hope its fine

pulsar ferry Feb 23, 2024, 7:25 PM

#

atomic trail TriumphGui doesn't have a pane system right? To have sub-guis essentially I'm t...

It doesn't, best option would probably be to extend the BaseGui and implement your own way of handling that
Or use a library that supports this kind of stuff a bit better, like incendo/Interfaces

atomic trail Feb 23, 2024, 7:27 PM

#

pulsar ferry It doesn't, best option would probably be to extend the BaseGui and implement yo...

Ah alright, havn't heard of incendo before, I'm just working on a plugin someone else made who uses IF (by stefvanschie) but I can't figure out how to update an item like gui.updateItem(slot, ItemStack) so now I use triumph gui lmao

pulsar ferry Feb 23, 2024, 7:28 PM

#

Will probably be hard to replicate the same thing, good luck :')

atomic trail Feb 23, 2024, 7:30 PM

#

I'll use TriumphGui and try to setup a system for the pages, it's just not very easy to handle properly imo

#

TriumphGui already has most of the functionality required actually. The filler basically works like a pane, just configured a bit. It already handles the area functionality

#

Wait Paginated GUI exists? lol

#

Didn't know that

worn jasper Feb 23, 2024, 7:46 PM

#

lol

atomic trail Feb 23, 2024, 7:52 PM

#

I can't remember, does the rows start at 0 or 1?

#

when using setItem etc.

worn jasper Feb 23, 2024, 7:53 PM

#

atomic trail I can't remember, does the rows start at 0 or 1?

0 I would assume

#

actually

#

maybe 1?

#

idk

#

try and see I suppose?

atomic trail Feb 23, 2024, 7:54 PM

#

Ye same lol

#

I'll test, just gotta make this compilable first

worn jasper Feb 23, 2024, 7:54 PM

#

I have it somewhere but too lazy to open intellij

#

just go to the method's code

#

and check it

atomic trail Feb 23, 2024, 7:54 PM

#

True

hollow barn Feb 23, 2024, 8:33 PM

#

on shoot:
if projectile is an arrow:
send "You Have Thrown A Pass!" to shooter
on projectile hit:
victim is a player
send "you have completed a pass" to shooter
okay so i have this but i want it to then wait until the victim is hit and then track the north and south amount from the shot to the hit and display that and im super confused on how to do that
im trying to transfer this from skript to a plugin how i do

graceful citrus Feb 23, 2024, 8:49 PM

#

listen to entity damage by entity event

#

then check for damager type, cast to arrow if arrow

#

then get shooter of the arrow for the second part

#

for first part you need this one

#

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/entity/EntityShootBowEvent.html

worn jasper Feb 23, 2024, 8:54 PM

#

hollow barn on shoot: if projectile is an arrow: send "You Have Thrown A Pass!" ...

This is not a place for skript 🤢

worn jasper Feb 23, 2024, 8:54 PM

#

graceful citrus https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/entity/EntityShootBowE...

it's skript xD

hollow barn Feb 23, 2024, 8:54 PM

#

worn jasper This is not a place for skript 🤢

no im asking how i would go about making it into a java plugin

worn jasper Feb 23, 2024, 8:57 PM

#

hollow barn no im asking how i would go about making it into a java plugin

oh kinda saw skript and skipped the next sentences you said lol

#

but yeah bitpex explained it

graceful citrus Feb 23, 2024, 9:07 PM

#

what would be the best way to send objects to another server? i am thinking of just using sockets and object streams but feeling like it might be a bit overkill

graceful citrus Feb 23, 2024, 9:07 PM

#

graceful citrus what would be the best way to send objects to another server? i am thinking of j...

serialize and send through redis / something third party i guess? (please ping anyone responds)

dusty frost Feb 23, 2024, 9:16 PM

#

graceful citrus what would be the best way to send objects to another server? i am thinking of j...

If they're on the same proxy, you could use Plugin Messaging if you want something internal

#

Otherwise yeah, serialize and Redis would be your best bet

#

Could go even harder and have a separate http backend and send messages through that

graceful citrus Feb 23, 2024, 9:17 PM

#

dusty frost Could go even harder and have a separate http backend and send messages through ...

i was thinking i could just do sockets since netty is included by default

dusty frost Feb 23, 2024, 9:17 PM

#

yeah but that doesn't really get you any of the resiliency

graceful citrus Feb 23, 2024, 9:17 PM

#

dusty frost If they're on the same proxy, you could use Plugin Messaging if you want somethi...

is plugin messaging still limited to targeting players?

dusty frost Feb 23, 2024, 9:18 PM

#

well you have to send it through a player's connection, so there has to be at least one online player

minor summit Feb 23, 2024, 9:18 PM

#

i mean any way you choose is gonna use sockets in the end

#

but going raw and de/serializing data to a byte stream yourself is kinda pepega

graceful citrus Feb 23, 2024, 9:18 PM

#

minor summit i mean any way you choose is gonna use sockets in the end

i mean yeah, question is do i just implement it myself or is there a better (already implemented) way

minor summit Feb 23, 2024, 9:19 PM

#

redis is a cool message broker

#

or how star suggested and make an http service to pipe things through

dusty frost Feb 23, 2024, 9:19 PM

#

yea redis is awesome

#

gets you lot of resiliency and even if the server is down or something, it will hold the message for em

graceful citrus Feb 23, 2024, 9:20 PM

#

i guess i could just serialize to json and send through redis

dusty frost Feb 23, 2024, 9:20 PM

#

yea that would probably be best

graceful citrus Feb 23, 2024, 9:23 PM

#

when switching servers through bungee order is
preconnect to other server
player connects to other server
disconnects from the current one
right?

#

or is it
preconnect
disconnect
connect

dusty frost Feb 23, 2024, 9:24 PM

#

second iirc

#

cause you're not allowed to be connected to two at once

graceful citrus Feb 23, 2024, 9:25 PM

#

i could probably just use the db then no? i need to store the data i want to send anyway so might as well just lock the row on leave and use that as "messaging" effectively

dusty frost Feb 23, 2024, 9:25 PM

#

i suppose lol

#

are you doing like a player data system or something?

graceful citrus Feb 23, 2024, 9:26 PM

#

ya synching some data between servers

dusty frost Feb 23, 2024, 9:26 PM

#

ah yeah you should look at HuskSync

#

https://github.com/WiIIiam278/HuskSync

#

It's what I use for my servers, uses Redis for super fast transfer and DB to persist data snapshots

worn jasper Feb 23, 2024, 9:30 PM

#

I did something like that a while ago with just mysql

#

worked without any issues

#

didn't even require redis

dusty frost Feb 23, 2024, 9:33 PM

#

yeah most of my fear is related to MPDB and that whole mess

#

so having a lightning fast Redis cache makes me feel a lot better 😌

worn jasper Feb 23, 2024, 9:33 PM

#

what could go wrong?

dusty frost Feb 23, 2024, 9:33 PM

#

latency, database connections, weird locking, etc.

#

with something as critical as player data, having more confidence is always good

worn jasper Feb 23, 2024, 9:35 PM

#

Eh, latency shouldn't be that big I would say

#

db connections? use a connection pool xd

graceful citrus Feb 23, 2024, 9:36 PM

#

worn jasper I did something like that a while ago with just mysql

i feel like there would be race conditions though with db only

#

you kinda need a "hey get this players data" message to be passed to other server

dusty frost Feb 23, 2024, 9:37 PM

#

worn jasper Eh, latency shouldn't be that big I would say

i mean these are just my lived experiences lol

#

idk what specifically went wrong

#

but people lost data and it was not cool

worn jasper Feb 23, 2024, 9:37 PM

#

if I recall correctly from when I did it, I waited 1-2s before making the request of the data on player join

dusty frost Feb 23, 2024, 9:37 PM

#

so just half-assing a player data system like that isn't what I would do lol

graceful citrus Feb 23, 2024, 9:37 PM

#

worn jasper if I recall correctly from when I did it, I waited 1-2s before making the reques...

thats such a bad solution though

dusty frost Feb 23, 2024, 9:37 PM

#

yeah HuskSync waits like 150ms lol

worn jasper Feb 23, 2024, 9:38 PM

#

graceful citrus thats such a bad solution though

barely noticeable by the players

graceful citrus Feb 23, 2024, 9:38 PM

#

would rather set up a seperate socket just for "hey data is ready"

#

not really about the player experience

dusty frost Feb 23, 2024, 9:38 PM

#

2 seconds is defo noticeable too lol

graceful citrus Feb 23, 2024, 9:38 PM

#

rather solution being bad

worn jasper Feb 23, 2024, 9:38 PM

#

you have transfer packets now too so, why not use them?

dusty frost Feb 23, 2024, 9:38 PM

#

what lol

worn jasper Feb 23, 2024, 9:38 PM

#

dusty frost 2 seconds is defo noticeable too lol

yeah 2 was extreme, it was like 800ms

dusty frost Feb 23, 2024, 9:38 PM

#

that's not really related to this

#

transfer packets are for swapping servers without a proxy

graceful citrus Feb 23, 2024, 9:38 PM

#

lets say for some reason your db insert / update

#

gets delayed for 2 seconds and player already ends up on the other server

worn jasper Feb 23, 2024, 9:38 PM

#

but couldn't you transfer data with it?

dusty frost Feb 23, 2024, 9:39 PM

#

no?

graceful citrus Feb 23, 2024, 9:39 PM

#

now you pull the old data then

dusty frost Feb 23, 2024, 9:39 PM

#

not like well

worn jasper Feb 23, 2024, 9:39 PM

#

I swear I saw that on patch notes

dusty frost Feb 23, 2024, 9:39 PM

#

and certainly not their entire player data

worn jasper Feb 23, 2024, 9:39 PM

#

and was even spoken here

dusty frost Feb 23, 2024, 9:39 PM

#

yeah it's like a few strings

#

and it's user editable

worn jasper Feb 23, 2024, 9:39 PM

#

I mean, in that case you could do the famous "hey, player data updated"

worn jasper Feb 23, 2024, 9:40 PM

#

dusty frost and it's user editable

oh shit

#

didn't know that

#

but yeah

graceful citrus Feb 23, 2024, 9:40 PM

#

worn jasper I mean, in that case you could do the famous "hey, player data updated"

i feel you have to for any robust solution

worn jasper Feb 23, 2024, 9:40 PM

#

redis is pog

#

idk tbf

#

I did then like, 4 years ago

#

xd

graceful citrus Feb 23, 2024, 9:40 PM

#

redis messaging channels is the way to go i guess

worn jasper Feb 23, 2024, 9:41 PM

#

plugin messaging is also nice personnally

#

but if safety is the issue then redis

graceful citrus Feb 23, 2024, 9:42 PM

#

worn jasper plugin messaging is also nice personnally

pluging messaging would be perfect if it didnt require a player

worn jasper Feb 23, 2024, 9:43 PM

#

graceful citrus pluging messaging would be perfect if it didnt require a player

what if you send it on disconnect like 100ms after

#

in theory the player will already be in the other server?

#

so there will be someone there xd

graceful citrus Feb 23, 2024, 9:43 PM

#

worn jasper what if you send it on disconnect like 100ms after

same issue, also you dont know if the player actually disconnected or switched servers i believe

worn jasper Feb 23, 2024, 9:44 PM

#

why is having a player even required?

#

does it send data to a player via the proxy?

#

or what

graceful citrus Feb 23, 2024, 9:45 PM

#

i got no idea honestly, but it would be so much more useful if it was just a connection between servers

worn jasper Feb 23, 2024, 9:47 PM

#

yeah, wonder why that's not a thing in more modern proxies

#

like velocity

#

paper and velocity could implement something like this

minor summit Feb 23, 2024, 9:48 PM

#

the minecraft protocol has a custom payload packet for client <-> server communication, plugin messages is just spigot's name for that

#

being a minecraft packet means that a player needs to exist to use it in its connection

worn jasper Feb 23, 2024, 9:49 PM

#

oh so it uses that "hack"

minor summit Feb 23, 2024, 9:49 PM

#

i mean it isn't a hack

worn jasper Feb 23, 2024, 9:50 PM

#

hence why I put it in ""

minor summit Feb 23, 2024, 9:50 PM

#

the purpose of the packet is to transmit custom data lol

worn jasper Feb 23, 2024, 9:50 PM

#

I would call it a mini hack cause it's actually being used in a way that "kinda" isn't meant to be used

minor summit Feb 23, 2024, 9:50 PM

#

why's that?

worn jasper Feb 23, 2024, 9:51 PM

#

1s mid valo

graceful citrus Feb 23, 2024, 9:53 PM

#

minor summit the minecraft protocol has a custom payload packet for client <-> server communi...

whats even the purpose? wouldnt the client need a mod to have the ability to react anyway then?

minor summit Feb 23, 2024, 9:54 PM

#

yes, the purpose is for mods to use that for their communication needs

#

it's also used for stuff like sending the server/client brand

#

debug markers too iirc

dusty frost Feb 23, 2024, 10:05 PM

#

yeah like Xaero's Mini/World Map use that for sending which map to use

#

which is very useful for servers behind proxies since the client has no way of knowing which server it's on

minor summit Feb 23, 2024, 10:06 PM

#

chunkyborder uses it because it's cool

dusty frost Feb 23, 2024, 10:10 PM

#

I think the Logblock Visualizer also uses it which is p cool

hoary scarab Feb 23, 2024, 10:13 PM

#

Kinda want to make a simple rest api to use between servers. So player isn't required.

dusty frost Feb 23, 2024, 10:14 PM

#

if only there was this highly optimized program that could act as a message queue between programs 😔

hoary scarab Feb 23, 2024, 10:15 PM

#

🤷 if only. I prefer my own way though 😉

worn jasper Feb 23, 2024, 10:38 PM

#

minor summit why's that?

I mean, it's intended for client/mods to communicate with the server, and basically what they do is "use" that to communicate between servers.

odd rock Feb 24, 2024, 6:39 AM

#

can i use javascript by nested?

sterile hinge Feb 24, 2024, 6:39 AM

#

what

odd rock Feb 24, 2024, 6:39 AM

#

%javascript_itemattloreline_%javascript_itemattlore_NeutralDamage,1%% this.

#

%javascript_
item_
attloreline_
%javascript_itemattlore_NeutralDamage,1%%

cerulean birch Feb 24, 2024, 8:09 AM

#

is it at all possible to create virtual worlds/runtime only worlds in bukkit where there's no folder created for them and they don't persist after restarts?

graceful citrus Feb 24, 2024, 10:55 AM

#

cerulean birch is it at all possible to create virtual worlds/runtime only worlds in bukkit whe...

yes and no, impossible if you want truly runtime only worlds

#

you can "fake" it by creating world and stopping the saves then deleting the files

graceful citrus Feb 24, 2024, 10:56 AM

#

graceful citrus yes and no, impossible if you want truly runtime only worlds

impossible without a server fork that is

cerulean birch Feb 24, 2024, 10:56 AM

#

ah unfortunate
ty for the response

graceful citrus Feb 24, 2024, 10:57 AM

#

cerulean birch ah unfortunate ty for the response

take a look at slime world manager

#

they change the way worlds are saved, might be able to hijack parts of that process to get rid of io operations by caching

cerulean birch Feb 24, 2024, 10:58 AM

#

sounds like bukkit doesn't give much of an option to not save worlds
ill take a look at swm though

graceful citrus Feb 24, 2024, 10:58 AM

#

you cant do it with bukkit, nms on the other hand should be possible

#

if you want to go that route

cerulean birch Feb 24, 2024, 10:59 AM

#

hm

#

it does make me think though if creating runtime worlds is even efficient

graceful citrus Feb 24, 2024, 10:59 AM

#

graceful citrus if you want to go that route

personally though, a fork is better when you need to edit source this extensively

graceful citrus Feb 24, 2024, 11:00 AM

#

cerulean birch it does make me think though if creating runtime worlds is even efficient

if you do not hold a huge world (aka small minigame worlds)

#

then it most likely is

#

since the chunks will need to be cached regardless

cerulean birch Feb 24, 2024, 11:01 AM

#

yeah but it would likely be dozens of relatively small worlds (possible 100+, or around 1 per online)

graceful citrus Feb 24, 2024, 11:01 AM

#

doesnt matter

cerulean birch Feb 24, 2024, 11:01 AM

#

hm

#

worlds themselves dont have much overhead/

graceful citrus Feb 24, 2024, 11:01 AM

#

a player being present = chunks around the player are loaded to memory

#

file is used for persistency

#

when player leaves the area

#

^ you can see how file can be avoided if each "world" would have a player present in your requirements

#

and you dont need persistency

cerulean birch Feb 24, 2024, 11:03 AM

#

i mean for performance overhead, whether having 30-100 small and near-identical worlds takes up significantly more memory than 1 massive world that has all those small worlds side by side

graceful citrus Feb 24, 2024, 11:03 AM

#

probably not much

#

you get the overhead of world stats

#

ideally you would group and tick those worlds individually with a custom fork

#

to make it truly scale

#

(similiar to how folia works, but way simpler without the region stuff)

cerulean birch Feb 24, 2024, 11:04 AM

#

i see

#

my issue with a fork (and kinda nms) is needing to keep maintaining that fork it every time I want to update server version

#

might be a small price to pay for some gains though

graceful citrus Feb 24, 2024, 11:06 AM

#

if the worlds are the same

#

you can probably just load one world and load from it each time

#

even utilize slime world api

graceful citrus Feb 24, 2024, 11:06 AM

#

graceful citrus you can probably just load one world and load from it each time

and simply not save

cerulean birch Feb 24, 2024, 11:07 AM

#

idea here is for a prison server, each world is a player's mine and only a certain region is modified. rest of the map is loaded either from a schematic or world, whichever way is better

graceful citrus Feb 24, 2024, 11:07 AM

#

go with folia

#

100%

cerulean birch Feb 24, 2024, 11:08 AM

#

considering it

graceful citrus Feb 24, 2024, 11:08 AM

#

single threaded ticking

#

will be your limiting factor

#

not io or memory

cerulean birch Feb 24, 2024, 11:08 AM

#

i mean

graceful citrus Feb 24, 2024, 11:08 AM

#

io is only heavy in the sense

cerulean birch Feb 24, 2024, 11:09 AM

#

most of the action would happen when a player breaks blocks, i dont think much would happen on actual ticks?

graceful citrus Feb 24, 2024, 11:09 AM

#

you need to wait for the operation, if you put io work on another thread then your cpu is smart enough

#

to do other stuff

cerulean birch Feb 24, 2024, 11:09 AM

#

ideally i dont want io though

graceful citrus Feb 24, 2024, 11:09 AM

#

you have to have io

#

at least once

cerulean birch Feb 24, 2024, 11:09 AM

#

well true

#

thats fine though

graceful citrus Feb 24, 2024, 11:10 AM

#

cerulean birch most of the action would happen when a player breaks blocks, i dont think much w...

everything happens on ticks

#

you break block = calculation happens next tick when server receives the packet

cerulean birch Feb 24, 2024, 11:10 AM

#

ah

graceful citrus Feb 24, 2024, 11:11 AM

#

unless you multithread but thats beside the point

cerulean birch Feb 24, 2024, 11:11 AM

#

folio does sound like it'd hel pthen

#

i also saw someone here working on a project where one world exists and all players mine there, but everyone sees a unique mining region dependant on blocks they broke themselves/etc)
not sure if thats discontinued/public or not, but i thought it was a good concept

graceful citrus Feb 24, 2024, 11:11 AM

#

its made for your exact use case

#

divides worlds into regions, so you can tick each "region" individually

cerulean birch Feb 24, 2024, 11:12 AM

#

hm

graceful citrus Feb 24, 2024, 11:12 AM

#

with a world where you spread players that much

#

you have the exact use case of folia

tight junco Feb 24, 2024, 11:12 AM

#

i'm gonna interject and say that its still incredibly experiemental and a large majority of plugins do not work on it due to how it works, your plugin selection will be quite limited

graceful citrus Feb 24, 2024, 11:13 AM

#

i assumed they are going with a custom plugin setup regardless

cerulean birch Feb 24, 2024, 11:13 AM

#

tight junco i'm gonna interject and say that its still incredibly experiemental and a large ...

i understand that, this would be customly made mostly though

graceful citrus Feb 24, 2024, 11:13 AM

#

especially if they want to do no io worlds etc

tight junco Feb 24, 2024, 11:13 AM

#

i expected that too but gotta specify to make sure

cerulean birch Feb 24, 2024, 11:13 AM

#

👍

graceful citrus Feb 24, 2024, 11:14 AM

#

cerulean birch 👍

just make sure you understand multithreaded programming properly if you want to do folia route

cerulean birch Feb 24, 2024, 11:14 AM

#

yeah

graceful citrus Feb 24, 2024, 11:14 AM

#

would also do j21 so you can use scopes etc

cerulean birch Feb 24, 2024, 11:15 AM

#

cerulean birch i also saw someone here working on a project where one world exists and all play...

any idea on this though? considering taking this route as well

graceful citrus Feb 24, 2024, 11:15 AM

#

structured concurrency makes your life easier

cerulean birch Feb 24, 2024, 11:15 AM

#

graceful citrus would also do j21 so you can use scopes etc

havent heard of that before

graceful citrus Feb 24, 2024, 11:15 AM

#

cerulean birch i also saw someone here working on a project where one world exists and all play...

you could do it with packets

#

java 21

cerulean birch Feb 24, 2024, 11:15 AM

#

i got that, i was talking about scopes

graceful citrus Feb 24, 2024, 11:15 AM

#

adds virtual threads and structured concurrency

cerulean birch Feb 24, 2024, 11:15 AM

#

oo

graceful citrus Feb 24, 2024, 11:16 AM

#

effectively coroutines if you used kotlin before

#

or i believe py has it too

cerulean birch Feb 24, 2024, 11:16 AM

#

sounds like a lot of research needs to be done

graceful citrus Feb 24, 2024, 11:17 AM

#

graceful citrus you could do it with packets

easily doable with packets afaik, but you would still get bottlenecked due to single threaded nature of paper - spigot - bukkit

cerulean birch Feb 24, 2024, 11:17 AM

#

also hypothetically, how would one go about forking paper or its forks like folia? i remember seeing about cloning projects and applying git patches or smthing, havent seen a fully comprehensive guide before though

cerulean birch Feb 24, 2024, 11:17 AM

#

graceful citrus easily doable with packets afaik, but you would still get bottlenecked due to si...

i see

graceful citrus Feb 24, 2024, 11:17 AM

#

less memory usage, cpu is the same

#

actually probably not

#

since you need to hold player state yourself then, so about the same

#

you just move who handles the data from server to plugin side

graceful citrus Feb 24, 2024, 11:18 AM

#

cerulean birch also hypothetically, how would one go about forking paper or its forks like foli...

check contributing.md

#

one sec

#

https://github.com/PaperMC/Paper/blob/master/CONTRIBUTING.md

#

@cerulean birch here

tight junco Feb 24, 2024, 11:19 AM

#

theres also the paper discord which'll help you a bit more when it comes to help and info about folia wicked

graceful citrus Feb 24, 2024, 11:19 AM

#

you need a linux instance or you can virtualize it with WSL

cerulean birch Feb 24, 2024, 11:20 AM

#

graceful citrus https://github.com/PaperMC/Paper/blob/master/CONTRIBUTING.md

i see

graceful citrus Feb 24, 2024, 11:20 AM

#

graceful citrus you need a linux instance or you can virtualize it with WSL

i just do WSL then hook to the wsl from windows with intellij (albeit a bit buggy sometimes)

cerulean birch Feb 24, 2024, 11:20 AM

#

graceful citrus you need a linux instance or you can virtualize it with WSL

dont remember needing to run linux to make a paper fork damn

graceful citrus Feb 24, 2024, 11:20 AM

#

you dont

#

it just takes quite long to do patches etc

cerulean birch Feb 24, 2024, 11:21 AM

#

so what does linux instance do for that

graceful citrus Feb 24, 2024, 11:21 AM

#

package managers

cerulean birch Feb 24, 2024, 11:21 AM

#

so just apt over homebrew?

graceful citrus Feb 24, 2024, 11:21 AM

#

if you got a server with docker

#

you can just set it up there as well

cerulean birch Feb 24, 2024, 11:22 AM

#

graceful citrus it just takes quite long to do patches etc

is this just a onetime process though to get started working on the fork

graceful citrus Feb 24, 2024, 11:22 AM

#

cerulean birch is this just a onetime process though to get started working on the fork

if you want to maintain it

#

you will thank yourself later for setting it up on anything unix

#

mac works too if you got one

cerulean birch Feb 24, 2024, 11:22 AM

#

i do

#

interesting
ill take a look into all that, ty

pulsar ferry Feb 24, 2024, 11:23 AM

#

Pretty sure paperweight works fine on windows now

graceful citrus Feb 24, 2024, 11:23 AM

#

pulsar ferry Pretty sure paperweight works fine on windows now

still slow no?

pulsar ferry Feb 24, 2024, 11:24 AM

#

Not really, at least when I tried

graceful citrus Feb 24, 2024, 11:24 AM

#

then scratch what i said

#

havent used the windows patcher in quite a while

dense galleon Feb 24, 2024, 1:00 PM

#

Uhh, I got this for loop inside of my saveData method to save player data to my database:

Set<NamespacedKey> namespacedKeys = PLAYER_DATA_REGISTRY.getPluginDataForNamespace(tableName).keySet();
int index = 0;
statement.setString(++index, dataKey.toString());
for (NamespacedKey namespacedKey : namespacedKeys) {
    PluginData<?> playerPluginData = playerData.getPluginData(namespacedKey);
    setValueInStatement(namespacedKey, playerPluginData, statement, ++index);
    statement.addBatch(); // Add to batch instead of executing immediately
}
statement.executeBatch(); // Execute all accumulated commands in the batch```Even though I printed the value of `namespacedKeys` in the console and 3 items are in there, the for loop seems to run only once before exiting. Why could that be?

#

There is no warnings or errors in the console

river solstice Feb 24, 2024, 1:08 PM

#

any ChatChat users wanna help out?

#

build.gradle:
compileOnly name: 'ChatChat-API-1.0.0-SNAPSHOT'

#

cloned the project, built the API.

#

if I include it from maven, I get an error:

[14:58:32 ERROR]: Could not pass event ChatChatEvent to M0-Pagrindai v1.0.0
java.lang.NoSuchMethodError: 'net.kyori.adventure.text.Component at.helpch.chatchat.api.event.ChatChatEvent.message()'
        at me.m0dii.pagrindai.submodules.chateditor.ChatEditorListener.onChat(ChatEditorListener.java:93) ~[M0-PagrindaiBase-1.0.0.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor4712.execute(Unknown Source) ~[?:?]

river solstice Feb 24, 2024, 1:37 PM

#

or am I using outdated plugin itself, though I downloaded the latest dev build

spiral prairie Feb 24, 2024, 2:18 PM

#

I just relocated adventure in my plugin because it doesn't have a message API

broken elbow Feb 24, 2024, 2:30 PM

#

river solstice or am I using outdated plugin itself, though I downloaded the latest dev build

You would have to use the relocated version of adventure

river solstice Feb 24, 2024, 3:57 PM

#

broken elbow You would have to use the relocated version of adventure

cant seem to find deserializers inside ChatChat

#

also I have a quite a few utility methods that use Components from adventure and they dont work with CC relocated ones

ocean crow Feb 24, 2024, 3:58 PM

#

river solstice also I have a quite a few utility methods that use Components from adventure and...

Stupid question, you have the right one imported? Are both imported?

river solstice Feb 24, 2024, 4:00 PM

#

well, the issue is, if I use the ChatChatEvent and get the event.message(), it returns me the relocated ChatChat component class

ocean crow Feb 24, 2024, 4:01 PM

#

Lemme setup a workspace for ChatChat, just kinda want to see for myself how it's structured

river solstice Feb 24, 2024, 4:01 PM

#

and I use adventure from paper itself

dense galleon Feb 24, 2024, 4:24 PM

#

When loading data from a database synchronously, I take it that if it takes longer than 50ms is when I should worry about performance

#

Since that's when the server may fall in TPS

sterile hinge Feb 24, 2024, 4:38 PM

#

no, you should worry before (in fact, you should just not do sync database access at all):

the latency might differ on the setup (db on the same host? TCP performance of the host?)
the latency might scale unexpectedly (it might take far longer with more data suddenly)
the main thread might already suffer performance-wise without your database access (if it's already taking up 40ms per tick, a 50ms database access would be bad)
depending on what you're doing, there might be multiple requests per tick suddenly

dense galleon Feb 24, 2024, 4:40 PM

#

Should I be accessing the database asynchronously even on startup/shutdown?

#

I access it asynchronously all the time except those

spring crescent Feb 24, 2024, 4:41 PM

#

Hey guys, what's the most optimal way of storing inventories or Container contents in MySQL? Here's what I'm currently doing.

if (event.getBlock().getState() instanceof Container) {
    Container container = (Container) event.getBlock().getState();
    Inventory inventory = container.getInventory();

    sqlHandler.insertContainer(container.getBlock().getLocation().getBlockX(),
            container.getBlock().getLocation().getBlockY(),
            container.getBlock().getLocation().getBlockZ(),
            InventoryUtils.inventoryToBase64(inventory)
    );
}

 public static String inventoryToBase64(Inventory inventory) throws IOException {
        ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
        BukkitObjectOutputStream dataOutput = new BukkitObjectOutputStream(outputStream);

        // Write the size of the inventory
        dataOutput.writeInt(inventory.getSize());

        // Save all the ItemStacks to the stream
        for (int i = 0; i < inventory.getSize(); i++) {
            dataOutput.writeObject(inventory.getItem(i));
        }

        // For PlayerInventory, save the armor contents as well
        if (inventory instanceof PlayerInventory) {
            for (ItemStack armor : ((PlayerInventory) inventory).getArmorContents()) {
                dataOutput.writeObject(armor);
            }
        }

        // Close the data output and convert the byte array output stream to Base64
        dataOutput.close();
        return Base64.getEncoder().encodeToString(outputStream.toByteArray());
    }

sterile hinge Feb 24, 2024, 4:41 PM

#

dense galleon Should I be accessing the database asynchronously even on startup/shutdown?

it might be acceptable there, but slowing down startup and shutdown isn't optimal either (although you can't really prevent it at shutdown I guess)

dense galleon Feb 24, 2024, 4:42 PM

#

sterile hinge it might be acceptable there, but slowing down startup and shutdown isn't optima...

I feel like slowing it down at shutdown makes sense though

#

I wouldn't want the plugin to start disabling itself as it's still saving data to the DB right?

sterile hinge Feb 24, 2024, 4:48 PM

#

yeah

heady maple Feb 24, 2024, 5:33 PM

#

Getting this error everytime I try to restart server, server randomly crashed @ 60 players
57921 Portal: 34222645
[17:05:35 INFO]: Max TNT Explosions: 100
[17:05:35 INFO]: Tile Max Tick Time: 50ms Entity max Tick Time: 50ms
[17:05:35 INFO]: Preparing start region for dimension minecraft:chunkworld

dusky harness Feb 24, 2024, 5:35 PM

#

heady maple Getting this error everytime I try to restart server, server randomly crashed @ ...

dont crosspost

terse osprey Feb 24, 2024, 5:40 PM

#

Truly horrifying error

dense galleon Feb 24, 2024, 5:54 PM

#

How does writing a plugin to handle MOTD in a waterfall/bungee network work?

torpid raft Feb 24, 2024, 6:04 PM

#

shouldnt be much different from writing a plugin to handle MOTD for a singleton server i imagine

river solstice Feb 24, 2024, 6:10 PM

#

ocean crow Lemme setup a workspace for ChatChat, just kinda want to see for myself how it's...

any news?

dense drift Feb 24, 2024, 6:33 PM

#

Is this chat chat integration for a private plugin? If so, you can fork it, replace the spigot api with paper and remove adventure so it uses the one from paper

brittle thunder Feb 24, 2024, 6:37 PM

#

ChatChat is out?

#

And wasnt it called ChitChat?

broken elbow Feb 24, 2024, 6:41 PM

#

No and No

torpid raft Feb 24, 2024, 6:47 PM

#

ChapChat

wet pier Feb 24, 2024, 7:04 PM

#

what is wrong ?

river solstice Feb 24, 2024, 7:08 PM

#

dense drift Is this chat chat integration for a private plugin? If so, you can fork it, repl...

it's ChatChat lol

dense drift Feb 24, 2024, 7:12 PM

#

Im talking about the plugin where you want to use the chatchat api

river solstice Feb 24, 2024, 7:12 PM

#

well

#

it's my plugin

#

and it's made with paper

#

this is the issue im facing

dense drift Feb 24, 2024, 7:13 PM

#

Ok, then you can do what I said, which is to make chatchat use adventure components from paper

river solstice Feb 24, 2024, 7:13 PM

#

is there a lazy way of doing it

#

cba re-writing CC

dense drift Feb 24, 2024, 7:14 PM

#

Is not a rewrite, just 2 changes in the build file of chatchat

river solstice Feb 24, 2024, 7:20 PM

#

not sure what's wrong here lol

#

dusky harness Feb 24, 2024, 7:21 PM

#

river solstice not sure what's wrong here lol

does it compile?

#

also, why do you have lines 17-18 when you have paper api 🤨

river solstice Feb 24, 2024, 7:22 PM

#

don't ask, haven't got around to removing it lol

#

alright I see there's a java version issue

#

dusky harness Feb 24, 2024, 7:23 PM

#

ah

river solstice Feb 24, 2024, 7:23 PM

#

how do you the thingy on build.gradle.kts

dusky harness Feb 24, 2024, 7:23 PM

#

thonking

river solstice Feb 24, 2024, 7:23 PM

#

sec

#

java {
    toolchain.languageVersion.set(JavaLanguageVersion.of(17))
}

#

ah it's set somewhere else

#

whatever

#

fixed

dusky harness Feb 24, 2024, 7:25 PM

#

dont u have to set the target/source compatibility versions

#

oh ok

river solstice Feb 24, 2024, 7:25 PM

#

yeh fucking around too much

#

should probably have a decent look at the project structure first

plush wigeon Feb 24, 2024, 7:30 PM

#

Is this where I come to get a hacked account back

river solstice Feb 24, 2024, 7:30 PM

#

?not-discord

neat pierBOT Feb 24, 2024, 7:30 PM

#

FAQ Answer:

Looking for discord support?
HelpChat is a Minecraft plugin and development support server and is not affiliated with discord in any way.
If you require support from discord, we recommend you to visit their official support website at https://support.discord.com
On this website, you can read their FAQs, or open a support ticket if necessary.

glossy bane Feb 24, 2024, 9:05 PM

#

I am having an issue with VaultAPI. My plug in is not able to detect it for some reason. I am compiling with JDK 17 for 1.20.4
My dependency import in the pom.xml is:

        <dependency>
            <groupId>com.github.MilkBowl</groupId>
            <artifactId>VaultAPI</artifactId>
            <version>1.7</version>
            <scope>provided</scope>
        </dependency>

When the function setupChat() runs, it returns false because chatProvider == null

private boolean setupChat() {
        final RegisteredServiceProvider<Chat> chatProvider = getServer().getServicesManager().getRegistration(Chat.class);
        if(chatProvider != null) {
            vaultChat = chatProvider.getProvider();
        }
        return vaultChat != null;
    }

Anyone have an idea why chatProvider.getProvider() is returning null?

dusky harness Feb 24, 2024, 9:18 PM

#

glossy bane I am having an issue with VaultAPI. My plug in is not able to detect it for some...

do you have a chat plugin?

glossy bane Feb 24, 2024, 9:18 PM

#

dusky harness do you have a chat plugin?

Yeah, I got EssentialsXChat installed

dusky harness Feb 24, 2024, 9:19 PM

#

hmm

#

and you're running setupChat in onEnable?

glossy bane Feb 24, 2024, 9:19 PM

#

Yep

#

public void onEnable() {
        if(!setupChat()) {
            getLogger().severe("Disabled due to no Vault dependency found!");
            getServer().getPluginManager().disablePlugin(this);
            return;
        }

dusky harness Feb 24, 2024, 9:22 PM

#

I'm not sure if EssentialsXChat supports Vault

glossy bane Feb 24, 2024, 9:23 PM

#

I also tried with UltraPermissions

#

Which has its own chat feature as well

dusky harness Feb 24, 2024, 9:23 PM

#

did you try LuckPerms?

glossy bane Feb 24, 2024, 9:23 PM

#

No, would prefer to use UltraPerms tbh

dusky harness Feb 24, 2024, 9:23 PM

#

because UltraPerms isn't listed either, and it's closed source so I can't check the source

glossy bane Feb 24, 2024, 9:23 PM

#

I should also clarify this plugin has worked before with UltraPerms and EssentialsXChat

dusky harness Feb 24, 2024, 9:24 PM

#

can you try installing luckperms to see if it returns null or not?

#

and you can remove it after

glossy bane Feb 24, 2024, 9:25 PM

#

Sure

dusky harness Feb 24, 2024, 9:25 PM

#

EssentialsXChat doesn't manage prefixes, groups, etc. (why is that even in the Chat vault api?) so it can't support Vault

#

I'd think that UltraPermissions would support it... but I can't check

glossy bane Feb 24, 2024, 9:26 PM

#

sigh

#

It worked with LuckPerms

dusky harness Feb 24, 2024, 9:26 PM

#

yeah ig UltraPerms doesn't support it for whatever reason

glossy bane Feb 24, 2024, 9:26 PM

#

But why doesn't EssentialsChat work?

dusky harness Feb 24, 2024, 9:27 PM

#

EssentialsXChat doesn't manage prefixes, groups, etc. (why is that even in the Chat vault api?) so it can't support Vault

glossy bane Feb 24, 2024, 9:27 PM

#

I see, hmm. The plugin I am trying to get to work is a custom global/local chat plugin

#

Something must have changed I guess

#

Cause this use to work with UltraPerms

dusky harness Feb 24, 2024, 9:28 PM

#

if this is for a private server, you can hook onto UltraPermissions API: https://ultrapermissions.com/wiki/api

Ultra Permissions

Ultra Permissions is the next level Permissions Plugin that can be fully controlled via In-Game Interfaces. It suggests you permissions based on installed plugins, visualises permissions checks and manages your chat all in one interface.

glossy bane Feb 24, 2024, 9:28 PM

#

Yeah, its a custom plugin for my server

glossy bane Feb 24, 2024, 9:53 PM

#

Apparently adding UltraPerms as a softdepend fixed it I think

dusky harness Feb 24, 2024, 10:03 PM

#

glossy bane Apparently adding UltraPerms as a softdepend fixed it I think

oh then it's probably registering it in onEnable instead of onLoad, and having its name start with a U doesn't help 🥲

glossy bane Feb 24, 2024, 10:25 PM

#

dusky harness oh then it's probably registering it in onEnable instead of onLoad, and having i...

Ah I see.

worn jasper Feb 24, 2024, 11:29 PM

#

how do you use shadowjar in kotlin dsl? (gradle)

graceful citrus Feb 24, 2024, 11:39 PM

#

worn jasper how do you use shadowjar in kotlin dsl? (gradle)

did you apply the shadow plugin?

#

https://imperceptiblethoughts.com/shadow/getting-started/

dusky harness Feb 24, 2024, 11:40 PM

#

worn jasper how do you use shadowjar in kotlin dsl? (gradle)

tasks.shadowJar {
    // stuff
}

#

or if that doesn't work, then tasks.withType<ShadowJar> or something like that

wet pier Feb 25, 2024, 6:32 AM

#

how can i get these value ?

#

i dont think i can use this

#

@dawn viper

dense drift Feb 25, 2024, 8:00 AM

#

PlaceholderAPI.booleanTrue()

cerulean birch Feb 25, 2024, 8:05 AM

#

how do I actually build a paper server jar while trying to make a fork? i cloned the repo, ran the ./gradlew applyPatches, all imports and everything seems to be in order. just not sure which specific tasks or command to run to get a jar and also where that jar will show up (not much of a gradle user)

#

nvm i think i found it. was looking in the wrong file

tight junco Feb 25, 2024, 8:09 AM

#

also surely its easier to ask this in paper discord

cerulean birch Feb 25, 2024, 8:18 AM

#

i just assumed that plenty of people here have experience with this and its not a very long explanation of which task/command to run and where it would show up

wet pier Feb 25, 2024, 8:31 AM

#

dense drift PlaceholderAPI.booleanTrue()

dense drift Feb 25, 2024, 8:31 AM

#

It is somewhere around these lines, probably on PlaceholderapiPlugin

wet pier Feb 25, 2024, 8:32 AM

#

dense drift It is somewhere around these lines, probably on PlaceholderapiPlugin

thonking

river solstice Feb 25, 2024, 10:46 AM

#

cerulean birch how do I actually build a paper server jar while trying to make a fork? i cloned...

it should be written in the docs

#

suggest giving it a read

cerulean birch Feb 25, 2024, 10:47 AM

#

river solstice it should be written in the docs

yeah it was in the main readme.md, i was looking at contributing.md trying to find building instructions

river solstice Feb 25, 2024, 10:47 AM

#

https://github.com/PaperMC/paperweight-examples

GitHub

GitHub - PaperMC/paperweight-examples

Contribute to PaperMC/paperweight-examples development by creating an account on GitHub.

#

looking at the wrong place ig

#

createReobfPaperclipJar

graceful citrus Feb 25, 2024, 12:48 PM

#

#general-plugins

dense galleon Feb 25, 2024, 5:49 PM

#

Do you guys make your configs in yaml or json?

#

Coming from the modding scene, I feel more comfortable with Json but idk if it really supported

river solstice Feb 25, 2024, 5:58 PM

#

yml is kinda to-go way

#

since its somewhat "built-in"

dusty frost Feb 25, 2024, 6:02 PM

#

yaml is just a much nicer human-editable configuration format than json

#

much less syntax to manually write

grand island Feb 25, 2024, 6:03 PM

#

^

#

toml / hocon is nicer but not that wide used

#

so yaml

river solstice Feb 25, 2024, 6:08 PM

#

dusty frost yaml is just a much nicer human-editable configuration format than json

true

digital temple Feb 25, 2024, 7:19 PM

#

is this possible to let it rain only in certain chunks in one world ?

torpid raft Feb 25, 2024, 7:22 PM

#

there might be better ways but one way can be by manipulating the biome of each chunk

#

since some biomes don't show rain

digital temple Feb 25, 2024, 7:31 PM

#

mhh i dont want to change the biom, because the non raining bioms are looking not good. Any other solution for e.g manipulate client packets ?

#

hypixel has this btw too. But i dont know how they do it

graceful citrus Feb 25, 2024, 7:40 PM

#

just call player.setPlayerWeather

#

on weather change events

#

@digital temple

#

and well check for chunk

terse osprey Feb 25, 2024, 7:42 PM

#

I don’t think it updates immediately (rain transitions slowly to clear etc). I’m assuming he wants a more seamless looking route but I don’t think this is do-able for a single dev.

#

And either way stated from bit and Ivan are probably your best bet

graceful citrus Feb 25, 2024, 7:44 PM

#

in conjunction with listening to this event (completely cancelling it)

#

player wont realize a difference

dusky harness Feb 25, 2024, 7:48 PM

#

digital temple hypixel has this btw too. But i dont know how they do it

i think it does what bitpex mentioned, checking when you enter a chunk

#

worldguard also has it btw

#

https://github.com/EngineHub/WorldGuard/blob/master/worldguard-core/src/main/java/com/sk89q/worldguard/session/handler/WeatherLockFlag.java

torpid raft Feb 25, 2024, 7:50 PM

#

downside to setting player weather is it doesn't make it 'rain in certain chunks' so much as it just makes it rain everywhere or not depending on what chunk you're in

#

i guess it really depends on which one you actually want

dusky harness Feb 25, 2024, 7:50 PM

#

true, but vanilla minecraft (ex desert biome) doesn't have support for only raining in certain areas iirc

torpid raft Feb 25, 2024, 7:51 PM

#

yeah all it does is not show the rain animation depending on chunk biome

terse osprey Feb 25, 2024, 7:56 PM

#

graceful citrus player wont realize a difference

Standing on the border of a chunk and looking into the distance seeing rain, only to then walk into that chunk and everything is clear. You’d be unable to tell from distance if a chunk is rain or clear

#

But it might not matter for the use-case shrug

digital temple Feb 25, 2024, 10:34 PM

#

graceful citrus just call player.setPlayerWeather

that sounds good to me. im checking if a player is entered a worldguard region and set the players weather

#

another problem with NameSpaceKeys
i will check, if the target itemstack has a specified key from ecoitems.
The current NBT tags shows that the key is this: PublicBukkitValues:{"ecoitems:item":"fishing_rod"}

NamespacedKey key = new NamespacedKey(Main.getInstance, "ecoitems:items");

but NamespaceKeys does only provide [a-z0-9/._-]
Any different solution to get the specified key ?

dusky harness Feb 25, 2024, 10:38 PM

#

digital temple another problem with NameSpaceKeys i will check, if the target itemstack has a s...

get the plugin instance of ecoitems

graceful hedge Feb 25, 2024, 10:38 PM

#

new NamespacedKey("ecoitems","item")

dusky harness Feb 25, 2024, 10:38 PM

#

oh

graceful hedge Feb 25, 2024, 10:38 PM

#

tho its marked as internal on spigot iirc

#

but paper good

digital temple Feb 25, 2024, 10:39 PM

#

graceful hedge new NamespacedKey("ecoitems","item")

Cannot resolve constructor 'NamespacedKey(Main, String, String)'

graceful hedge Feb 25, 2024, 10:39 PM

#

oh u remove the first arg

digital temple Feb 25, 2024, 10:40 PM

#

NamespacedKey key = new NamespacedKey("ecoitems", "items");

'NamespacedKey(java.lang.String, java.lang.String)' is marked unstable with @ApiStatus.Internal

graceful hedge Feb 25, 2024, 10:40 PM

#

yep

#

but ehm, ignore it (hehe)

digital temple Feb 25, 2024, 10:40 PM

#

sounds not like the best xd

graceful hedge Feb 25, 2024, 10:41 PM

#

Paper hasnt annotated it Internal, most stuff should run paper (if u dont run paper, u need to reconsider)

#

but ye

digital temple Feb 25, 2024, 10:41 PM

#

i run paper

#

but i will sell it too

graceful hedge Feb 25, 2024, 10:41 PM

#

if spigot some how yeets that and make it inaccessible to u, the api consumer, u can flame me

dusky harness Feb 25, 2024, 10:41 PM

#

dusky harness get the plugin instance of ecoitems

you can also use this 🙃 if u dont want to use internal

digital temple Feb 25, 2024, 10:42 PM

#

graceful hedge if spigot some how yeets that and make it inaccessible to u, the api consumer, u...

alright ill keep that in mind 😛

dusky harness Feb 25, 2024, 10:42 PM

#

i forget the exact code
like Bukkit pluginmanager getplugin or smth

graceful hedge Feb 25, 2024, 10:42 PM

#

correct

digital temple Feb 25, 2024, 10:47 PM

#

PersistentDataContainer data = itemStack.getItemMeta().getPersistentDataContainer();
NamespacedKey key = new NamespacedKey("ecoitems", "items");

String nskValue = "empty";

if(data.has(key, PersistentDataType.STRING)) {
    nskValue = data.get(key, PersistentDataType.STRING);
}

if(nskValue != null) {
    if(nskValue.equalsIgnoreCase(condition[1])) {
        meetCondition = true;
    }
}

condition[1] = fishing_rod but it fails on nskValue.equals check. Why is ecoitems stressful ._.

terse osprey Feb 25, 2024, 11:57 PM

#

What is “nskValue” actually set to?

terse osprey Feb 25, 2024, 11:58 PM

#

digital temple ```java PersistentDataContainer data = itemStack.getItemMeta().getPersistentData...

.

digital temple Feb 26, 2024, 12:09 AM

#

terse osprey What is “nskValue” actually set to?

nskValue = data.get(key, PersistentDataType.STRING);

#

the name from the item

dusky harness Feb 26, 2024, 12:18 AM

#

no but like what's the actual value

#

print out nksValue and condition[1]

digital temple Feb 26, 2024, 12:23 AM

#

its "empty" like defined befor. Because he failed in nskValue.equalsIgnoreCase

digital temple Feb 26, 2024, 12:24 AM

#

dusky harness print out nksValue and condition[1]

condition[1] is "fishing_rod" the name from ecoItems

dusky harness Feb 26, 2024, 12:25 AM

#

dusky harness you can also use this 🙃 if u dont want to use internal

try this

#

since that's what ecoitems would use itself

digital temple Feb 26, 2024, 12:25 AM

#

ill think you mean this

EcoItem ecoItem = EcoItems.INSTANCE.getByID(condition[1]);

dusky harness Feb 26, 2024, 12:26 AM

#

uh

#

no idea what that is

digital temple Feb 26, 2024, 12:26 AM

#

instead, what you mean ?

dusky harness Feb 26, 2024, 12:26 AM

#

dusky harness i forget the exact code like Bukkit pluginmanager getplugin or smth

this

#

or EcoItems.INSTANCE ig

digital temple Feb 26, 2024, 12:27 AM

#

digital temple ill think you mean this ```java EcoItem ecoItem = EcoItems.INSTANCE.getByID(cond...

thats exactly like i used here

dusky harness Feb 26, 2024, 12:27 AM

#

wait no you need EcoItemsPlugin

#

not EcoItems

#

wait

#

if you have the code imported

#

then just use that; there's probably a method for it

#

if not then #development message & #development message

#

oh wait

#

im looking in the source (wow, a paid open source plugin!)

digital temple Feb 26, 2024, 12:33 AM

#

dusky harness im looking in the source (wow, a paid open source plugin!)

yes xd

dusky harness Feb 26, 2024, 12:35 AM

#

@digital temple Try ```java
EcoItem ecoItem = ItemUtilsKt.getEcoItem(itemStack);
// do whatever

digital temple Feb 26, 2024, 12:36 AM

#

lol what is ItemUtilsKt

digital temple Feb 26, 2024, 12:37 AM

#

dusky harness <@249697106334318593> Try ```java EcoItem ecoItem = ItemUtilsKt.getEcoItem(itemS...

yep, worked, but i cant test it right now

dusky harness Feb 26, 2024, 12:37 AM

#

digital temple lol what is ItemUtilsKt

It represents https://github.com/Auxilor/EcoItems/blob/master/eco-core/core-plugin/src/main/kotlin/com/willfp/ecoitems/items/ItemUtils.kt#L17

#

The Kt is because it's not part of the actual class

digital temple Feb 26, 2024, 12:38 AM

#

hell na, kotlin ._.

#

but thanks a lot

#

how do you get this ?

dusky harness Feb 26, 2024, 12:40 AM

#

digital temple how do you get this ?

googled ecoitems, saw it was open source, and searched for persistentDataContainer

#

¯_(ツ)_/¯

digital temple Feb 26, 2024, 1:47 AM

#

good for now but currently i think i cant use this
ill get this error on building

java: cannot access com.willfp.libreforge.Holder
  class file for com.willfp.libreforge.Holder not found

digital temple Feb 26, 2024, 2:26 AM

#

aaaaalright

#

I find the solution finally. You can "test" a CustomStack from ecoItems with another ItemStack
Just use customItem.test(is)

case "ecoitems" -> {
    ItemStack is = Items.lookup("ecoitems:" + condition[1]).getItem();
    if(is != null && is.getItemMeta() != null && itemStack.getItemMeta() != null) {

        CustomItem customItem = Items.getCustomItem(itemStack);

        if(customItem == null) {
            return false;
        }

        if(customItem.test(is)) {
            meetCondition = true;
        }
    }
}

digital temple Feb 26, 2024, 2:28 AM

#

dusky harness <@249697106334318593> Try ```java EcoItem ecoItem = ItemUtilsKt.getEcoItem(itemS...

this will not work

icy sonnet Feb 26, 2024, 9:31 AM

#

guys I have a question, should I make a String class that just saves all messages so I can just call them as needed in my other classes?

river solstice Feb 26, 2024, 9:40 AM

#

any ChatChat devs/users can help me figure this out?
I have a custom format for staff-chat with priority (tried with higher AND lower number than default)

for me, it works fine, since, I suppose, I have some permission that changes it, but for my staff, only the channel prefix is applied, the else is inherited from default format

#

#

for the record, I have given them chatchat.channel.format.staff permission

#

well, nevermind

#

it was chatchat.channel.format.staff.staff

dense galleon Feb 26, 2024, 9:53 AM

#

Does anyone else struggle with plugins becoming too much of a web with each other? I have a core plugin which I know I want all my plugins to rely on, however there is also two other plugins (One used to add custom items, one as an economy plugin) which many of my other plugins will be depending on which I feel like will make things pretty hectic

#

The thing is that, I depend on that custom item plugin and that economy plugin mainly to just use 1-2 methods from their API I wrote

#

Is there a better way to go about this? It would be neat if my plugins could communicate with each other without depending on one another

worn jasper Feb 26, 2024, 10:36 AM

#

dense galleon Is there a better way to go about this? It would be neat if my plugins could com...

use your core for the main api, and make your core hook into the rest maybe?

#

so you use the api from your eco plugin through the core api

dense galleon Feb 26, 2024, 10:41 AM

#

worn jasper use your core for the main api, and make your core hook into the rest maybe?

But that would result in circular dependency

#

Since my currency and item plugins depend on the core plugin

worn jasper Feb 26, 2024, 10:49 AM

#

dense galleon Since my currency and item plugins depend on the core plugin

Then make another plugin that doesn't rely on the core and just forwards the other plugin's apis? idk

dense galleon Feb 26, 2024, 10:55 AM

#

How would that forward the other plugin's APIs? I assume it would need to depend on all those other plugins, and then those plugins will need to depend on that "api bridger" plugin which would result in circular dependencies again

merry knoll Feb 26, 2024, 11:36 AM

#

dense galleon How would that forward the other plugin's APIs? I assume it would need to depend...

look into di frameworks to get ideas on how dependency spagetti is solved

#

in your case of 2 3 dependencies it's probably not a big deal enough to use a framework for it

dense galleon Feb 26, 2024, 11:49 AM

#

merry knoll look into di frameworks to get ideas on how dependency spagetti is solved

Is DI framework like Dependency Injection, but in a bigger scope?

#

(instead of being between classes it is between plugins, in this case)

worn jasper Feb 26, 2024, 11:53 AM

#

dense galleon How would that forward the other plugin's APIs? I assume it would need to depend...

no, eco plugin has api -> bridge depends on it and implements it -> exposes their apis through the bridge plugin

#

if that makes any sense

#

eco plugin depends on core

#

but not on the bridge

dense galleon Feb 26, 2024, 12:01 PM

#

worn jasper no, eco plugin has api -> bridge depends on it and implements it -> exposes thei...

Ahh I see

#

Yeah that sounds like it makes sense

river solstice Feb 26, 2024, 2:06 PM

#

is there a way to parse legacy as well as minimessage formats to component?

#

ex. the text &chello <red>world would be parsed with both legacy and minimsg

grand island Feb 26, 2024, 2:28 PM

#

river solstice ex. the text `&chello <red>world` would be parsed with both legacy and minimsg

well, kind of

#

package ru.decalium.battlepass.util;

import net.kyori.adventure.text.Component;
import net.kyori.adventure.text.minimessage.MiniMessage;
import net.kyori.adventure.text.serializer.ComponentSerializer;
import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
import org.jetbrains.annotations.NotNull;


public final class MixedComponentSerializer implements ComponentSerializer<Component, Component, String> {

    private final MiniMessage miniMessage;
    private final LegacyComponentSerializer legacySerializer;

    public MixedComponentSerializer(MiniMessage miniMessage, LegacyComponentSerializer legacySerializer) {

        this.miniMessage = miniMessage;
        this.legacySerializer = legacySerializer;
    }

    @Override
    public @NotNull Component deserialize(@NotNull String input) {
        input = miniMessage.serialize(legacySerializer.deserialize(input)).replace("\\<", "<");
        return miniMessage.deserialize(input);
    }

    @Override
    public @NotNull String serialize(@NotNull Component component) {
        return miniMessage.serialize(component);
    }
}

#

you either replace all legacy color code with their MiniMessage equivalents, or first deserialize it as legacy, then serialize and deserialize again

river solstice Feb 26, 2024, 2:43 PM

#

eh I just used Kyorifier

#

transform the & shit to <> equivalents and only then parse MM

river solstice Feb 26, 2024, 2:44 PM

#

grand island you either replace all legacy color code with their MiniMessage equivalents, or ...

kinda tried that, didnt seem to work

#

the legacy codes got removed but no color applied

grand island Feb 26, 2024, 2:51 PM

#

river solstice eh I just used Kyorifier

whats that

river solstice Feb 26, 2024, 2:52 PM

#

https://github.com/lucyydotp/papi-kyorify

GitHub

GitHub - lucyydotp/papi-kyorify

Contribute to lucyydotp/papi-kyorify development by creating an account on GitHub.

#

since Im using ChatChat it already has it

merry knoll Feb 26, 2024, 3:22 PM

#

dense galleon Is DI framework like Dependency Injection, but in a bigger scope?

yes whole pattern is made to solve dependency spagetti

grand island Feb 26, 2024, 3:24 PM

#

isnt DI was made to invent object oriented programming

dense galleon Feb 26, 2024, 3:58 PM

#

merry knoll yes whole pattern is made to solve dependency spagetti

What about what Mr. afonso said? about that 'bridging' plugin?

worn jasper Feb 26, 2024, 4:59 PM

#

river solstice is there a way to parse legacy as well as minimessage formats to component?

why. just. why.

dusky harness Feb 26, 2024, 5:00 PM

#

grand island you either replace all legacy color code with their MiniMessage equivalents, or ...

Note that the second doesn't work bc minimessage will be escaped

river solstice Feb 26, 2024, 5:00 PM

#

worn jasper why. just. why.

cuz players dumb

worn jasper Feb 26, 2024, 5:01 PM

#

river solstice cuz players dumb

their problem.

dense galleon Feb 26, 2024, 5:21 PM

#

Are firework colors still not editable through paper?

#

When it comes to particles

worn jasper Feb 26, 2024, 5:23 PM

#

dense galleon Are firework colors still not editable through paper?

can't you edit it's meta?

#

There is also a class named FireworkEffect

merry knoll Feb 26, 2024, 5:27 PM

#

dense galleon What about what Mr. afonso said? about that 'bridging' plugin?

i kinda dont see the point

dense galleon Feb 26, 2024, 5:28 PM

#

No I don't mean the fireworks

#

I mean the particle called FIREWORK

dense galleon Feb 26, 2024, 5:28 PM

#

merry knoll i kinda dont see the point

I don't really get what you meant then with using a DI framework

merry knoll Feb 26, 2024, 5:28 PM

#

merry knoll i kinda dont see the point

all you would end up doing is that add another step as a dependency

river solstice Feb 26, 2024, 5:38 PM

#

worn jasper their problem.

eh, I wish

dense galleon Feb 26, 2024, 5:48 PM

#

merry knoll all you would end up doing is that add another step as a dependency

Wdym with a DI framework though?

#

looking it up online most things that pop up are about .net framework or simple dependency injection

merry knoll Feb 26, 2024, 5:52 PM

#

there are di frameworks for handling load orders and injecting dependencies

dense galleon Feb 26, 2024, 5:52 PM

#

What is a DI framework though

#

I'm not really following how this applies to plugins or how I'd use that in plugins which depend on one another

lunar tulip Feb 26, 2024, 5:54 PM

#

im tring to make a apply sytem from google froms to discord but i dont now what im dowing worng here

const POST_URL = "https://discord.com/api/webhooks/##################################";

function onSubmit(e) {
    const response = e.response.getItemResponses();
    let items = [];
https://script.google.com/home
    for (const responseAnswer of response) {
        const question = responseAnswer.getItem().getTitle();
        const answer = responseAnswer.getResponse();
        let parts = []

        try {
            parts = answer.match(/[\s\S]{1,1024}/g) || [];
        } catch (e) {
            parts = answer;
        }

        if (!answer) {
            continue;
        }

        for (const [index, part] of Object.entries(parts)) {
            if (index == 0) {
                items.push({
                    "name": question,
                    "value": part,
                    "inline": false
                });
            } else {
                items.push({
                    "name": question.concat(" (cont.)"),
                    "value": part,
                    "inline": false
                });
            }
        }
    }

    const options = {
        "method": "post",
        "headers": {
            "Content-Type": "application/json",
        },
        "payload": JSON.stringify({
            "content": "‌",
            "embeds": [{
                "title": "Some nice title here",
                "color": 33023, // This is optional, you can look for decimal colour codes at https://www.webtoolkitonline.com/hexadecimal-decimal-color-converter.html
                "fields": items,
                "footer": {
                    "text": "Some footer here"
                },
                "timestamp": new Date().toISOString()
            }]
        })
    };

    UrlFetchApp.fetch(POST_URL, options);
};```

merry knoll Feb 26, 2024, 5:58 PM

#

dense galleon I'm not really following how this applies to plugins or how I'd use that in plug...

lets say you got class a that depends on b and c

#

and c depends on b

#

normally you need to manually care about load orders

#

but with a framework you inject these classes

dense galleon Feb 26, 2024, 6:00 PM

#

Right but how do I make a framework? It feels kinda alien to me to be able to inject classes that are not present in my project

merry knoll Feb 26, 2024, 6:02 PM

#

you use stuff like singletons and factories

#

look into guice and dagger

dense galleon Feb 26, 2024, 6:25 PM

#

What about like

#

Having an interface in my core plugin, which for example my economy plugin implements?

#

So that I can use the methods from that economy plugin without actually having it as a dependency?

merry knoll Feb 26, 2024, 6:28 PM

#

then you lose modularity

#

and unit testability as well (not really used in bukkit development but still )

dense galleon Feb 26, 2024, 6:29 PM

#

merry knoll then you lose modularity

How so

atomic trail Feb 26, 2024, 6:35 PM

#

I know this is a very specific question but not sure where else to ask, the essentials discord doesn't really have support for dev questions.

Basically I use EssentialsX Chat to handle chat on a server. I want to add cosmetics to apply a color to player's usernames, ranks etc. and was working on making a ChatRenderer, but this will just override whatever Essentials uses right?

dense drift Feb 26, 2024, 6:41 PM

#

Is not like eseentials has any complex chat system. It will be better if you replace it entirely

worn jasper Feb 26, 2024, 7:09 PM

#

ChatChat on top

river solstice Feb 26, 2024, 7:13 PM

#

well

#

had a few issues with it already

#

an odd bug is that if you are in a different world X in location A, you can see the messages from the world Y in the same location

broken elbow Feb 26, 2024, 7:19 PM

#

btw, @river solstice the issue you had with ChatChat regarding Adventure not being present in the API, turns out I've already opened an issue regarding it, I just forgot 😭 https://github.com/HelpChat/ChatChat/issues/220

broken elbow Feb 26, 2024, 7:19 PM

#

river solstice an odd bug is that if you are in a different world X in location A, you can see ...

Also, can you open a ticket for this? I might be able to look into it these days.

worn jasper Feb 26, 2024, 7:30 PM

#

river solstice had a few issues with it already

PR them 🙂

#

open an issue (which already exists)

river solstice Feb 26, 2024, 7:33 PM

#

broken elbow Also, can you open a ticket for this? I might be able to look into it these days...

eh I'll just fix it myself

#

we are using it in production environment so it's kinda a dealbreaker rn

#

the issue is probably here

#

it's just comparing distances, but doesn't take world into the account.

#

Opened an issue just so you won't forget lol. https://github.com/HelpChat/ChatChat/issues/223

dense drift Feb 26, 2024, 7:52 PM

#

river solstice it's just comparing distances, but doesn't take world into the account.

pepoHahaLol

worn jasper Feb 26, 2024, 8:02 PM

#

river solstice the issue is probably here

hella clean code, gotta check ChatChat's source.
what's that color theme/plugin?

#

like variables have different colors, etc.

#

that's quite nice

merry knoll Feb 26, 2024, 8:03 PM

#

dense galleon How so

then everything is one package as dependency

#

what you probably want is something like gradle bundles im assuming

#

so you dont have to list each dependency every time

broken elbow Feb 26, 2024, 8:20 PM

#

worn jasper that's quite nice

Ngl, that would probably give me brain damage. If you want a nice theme (no changing colors for variables), I recommend Mattom One Dark. It is a modified version of Atom One Dark by Matt: https://gist.github.com/LichtHund/58eae0bdff2f67385de24a10a8af3c81

graceful citrus Feb 26, 2024, 8:22 PM

#

monokai pro filter spectrum is amazing as theme

dense drift Feb 26, 2024, 8:26 PM

#

worn jasper like variables have different colors, etc.

It feels weird tbh, I personally like it more when variables have different colors depending on the scope/type (fields, method parameter, variable)

broken elbow Feb 26, 2024, 8:27 PM

#

this + unused/used

worn jasper Feb 26, 2024, 8:44 PM

#

dense drift It feels weird tbh, I personally like it more when variables have different colo...

fair.

worn jasper Feb 26, 2024, 8:44 PM

#

broken elbow Ngl, that would probably give me brain damage. If you want a nice theme (no chan...

how th do I install this?

#

I use Atom One Dark so

#

Also, yeah now that I think more about it, it can really get messy with changing color variables

broken elbow Feb 26, 2024, 8:47 PM

#

#

For you it will probably be named Attom One Dark Copy when you import it. I modified it to give it a better name (in my humble opinion)

river solstice Feb 26, 2024, 9:05 PM

#

worn jasper 1. hella clean code, gotta check ChatChat's source. 2. what's that color theme/p...

you might not like it

#

worn jasper Feb 26, 2024, 9:05 PM

#

hell nha

#

bye

dusky harness Feb 26, 2024, 9:07 PM

#

🥲

river solstice Feb 26, 2024, 9:07 PM

#

worn jasper 1. hella clean code, gotta check ChatChat's source. 2. what's that color theme/p...

https://tenor.com/view/vince-mcmahon-crying-weeping-sad-mcmahon-gif-9909335632125829822

Tenor

#

no spaces around *

worn jasper Feb 26, 2024, 9:07 PM

#

shit font is big af in matt's one

dusky harness Feb 26, 2024, 9:07 PM

#

font is different than theme 🥲

#

thats just blitz's font

worn jasper Feb 26, 2024, 9:07 PM

#

how do I change font size?

dusky harness Feb 26, 2024, 9:07 PM

#

i think matt uses fire code tho

dusky harness Feb 26, 2024, 9:08 PM

#

worn jasper how do I change font size?

uhhh not sure

worn jasper Feb 26, 2024, 9:08 PM

#

found it

river solstice Feb 26, 2024, 9:08 PM

#

worn jasper Feb 26, 2024, 9:08 PM

#

dusky harness i think matt uses fire code tho

Fira code*

river solstice Feb 26, 2024, 9:08 PM

#

you might want to turn on the Change font size with Ctrl+Mouse

dusky harness Feb 26, 2024, 9:08 PM

#

river solstice

is that intellij?

river solstice Feb 26, 2024, 9:08 PM

#

yeah

dusky harness Feb 26, 2024, 9:08 PM

#

worn jasper Fira code*

oh yeah typo 💀

#

fire code

worn jasper Feb 26, 2024, 9:08 PM

#

ngl like it

#

although I wonder if there is an oled theme

dusky harness Feb 26, 2024, 9:09 PM

#

i think i use jetbrains mono

#

or fira code idk

#

one of those two

dusky harness Feb 26, 2024, 9:09 PM

#

worn jasper although I wonder if there is an oled theme

like completely black?

#

👀

river solstice Feb 26, 2024, 9:09 PM

#

worn jasper hell nha

💀

#

i kinda started with C#

#

and found the theme kinda nice

#

that's why I went with it in java too

worn jasper Feb 26, 2024, 9:10 PM

#

dusky harness like completely black?

basically

dusky harness Feb 26, 2024, 9:10 PM

#

river solstice i kinda started with C#

waaaaait what

#

i did not know

#

😮

#

game dev?

river solstice Feb 26, 2024, 9:11 PM

#

also that's not exactly fully the theme, I think rainbow brackets does some coloring for variables too

river solstice Feb 26, 2024, 9:11 PM

#

dusky harness game dev?

ASP.NET, Core, Framework

dusky harness Feb 26, 2024, 9:11 PM

#

ah

river solstice Feb 26, 2024, 9:11 PM

#

and yes, had quite a fair amount of Unity

dusky harness Feb 26, 2024, 9:11 PM

#

oh

river solstice Feb 26, 2024, 9:12 PM

#

#

🥹

#

in uni we made a shitty tower-defense style game

#

as well as few other ones

#

somewhat a FPS with multiplayer

#

and a VR game

#

based on Iron-lung game

worn jasper Feb 26, 2024, 9:15 PM

#

Computer Science?

#

or Software Development?

river solstice Feb 26, 2024, 9:17 PM

#

not sure about the term in english, but probably computer science, yeah

#

had a side study of game dev

#

and probably software dev too

#

but major is compsci, yeah

worn jasper Feb 26, 2024, 9:19 PM

#

makes sense

broken elbow Feb 26, 2024, 9:52 PM

#

dusky harness thats just blitz's font

It actually comes with a specific font and font size. I decreased mine.

river solstice Feb 26, 2024, 9:52 PM

#

https://github.com/M0diis 🤠

GitHub

M0diis - Overview

Programming various things for fun and knowledge.

Discord @ M0dii - M0diis

broken elbow Feb 26, 2024, 9:52 PM

#

broken elbow It actually comes with a specific font and font size. I decreased mine.

I think it comes with size 18 and I use 13 or 14

#

But I also just have scroll to change font size enabled

dusky harness Feb 26, 2024, 9:53 PM

#

broken elbow It actually comes with a specific font and font size. I decreased mine.

O interesting

river solstice Feb 26, 2024, 9:53 PM

#

Blitz review my issue right now!!

dusky harness Feb 26, 2024, 9:53 PM

#

Didn't know that was possible from color scheme

river solstice Feb 26, 2024, 9:53 PM

#

And others too..

broken elbow Feb 26, 2024, 9:53 PM

#

river solstice Blitz review my issue right now!!

Review your issue?

river solstice Feb 26, 2024, 9:53 PM

#

ChatChat

broken elbow Feb 26, 2024, 9:53 PM

#

It is an issue, alright?

river solstice Feb 26, 2024, 9:53 PM

#

Fix

#

The

#

Issue

#

😳

broken elbow Feb 26, 2024, 9:53 PM

#

Well, that's something compeltely different

#

you asked me to review it

#

I would say 4/5

#

Beautiful issue

#

lacks some details

river solstice Feb 26, 2024, 9:53 PM

#

Thank you

#

I tried ~~my best~~so hard

#

But got so far

#

But in the end

broken elbow Feb 26, 2024, 9:54 PM

#

Overall, decent. Would recommend to friends and family

river solstice Feb 26, 2024, 9:54 PM

#

Ir doesnt even matter

#

I might make some PRs, then you WILL have to review them

#

🦅

broken elbow Feb 26, 2024, 9:55 PM

#

ok. good

#

I'd rather do that

#

than fix the issues myself 🤣

river solstice Feb 26, 2024, 9:55 PM

#

the fix for my issue is like one line of code

broken elbow Feb 26, 2024, 9:55 PM

#

I am lazy and tired. I have at least 10 issues assigned to me on different projects

broken elbow Feb 26, 2024, 9:56 PM

#

river solstice the fix for my issue is like one line of code

Its never the fix. Its always the testing

#

And testing Spigot stuff is awful

river solstice Feb 26, 2024, 9:56 PM

#

Though I would like the chat range to be able to work through worlds (shared)

#

Might add that too

broken elbow Feb 26, 2024, 9:56 PM

#

Do it

river solstice Feb 26, 2024, 9:57 PM

#

broken elbow And testing Spigot stuff is awful

Test in production

#

😎

#

Who else better tests than consumers

broken elbow Feb 26, 2024, 9:57 PM

#

I don't have a production environment

#

You are my customer

#

So go fix and then go test

river solstice Feb 26, 2024, 9:57 PM

#

You just.. "fix" the issue, and hope noone creates another ticket

river solstice Feb 26, 2024, 9:58 PM

#

broken elbow So go fix and then go test

Already tested the fix

#

Works like a charm

#

Being Blitz Id argue your speed in fixing the issues

#

🥸

broken elbow Feb 26, 2024, 10:00 PM

#

Dude... I spent like 4 days figuring out why the hell our connection to the DB doesn't work, got multiple AWS tickets created in the process, and the connection still doesn't work sometimes. I am not the right person for the job (whatever the job might be)

river solstice Feb 26, 2024, 10:01 PM

#

25 open issues on ChatChat, how much you wanna bet I'll make a PR resolving them all tomorrow

#

🧌

river solstice Feb 26, 2024, 10:01 PM

#

broken elbow Dude... I spent like 4 days figuring out why the hell our connection to the DB d...

Yeesh

brittle thunder Feb 26, 2024, 11:09 PM

#

broken elbow I don't have a production environment

Setup staging, make github actions spin up a spigot server and bot iself

broken elbow Feb 26, 2024, 11:16 PM

#

I can't be bothered

lyric gyro Feb 27, 2024, 12:03 AM

#

how would i make something like %identifier_param_<BLOCK>%

broken elbow Feb 27, 2024, 12:08 AM

#

https://wiki.placeholderapi.com/developers/creating-a-placeholderexpansion/

lyric gyro Feb 27, 2024, 12:09 AM

#

i know how to make a normal placeholder

#

but not one with a variable in it

broken elbow Feb 27, 2024, 12:24 AM

#

I mean, everything after %identifier_ and before the ending % just comes to you as a string

#

so you would get param_<BLOCK> and it would be up to you to parse that

noble hemlock Feb 27, 2024, 1:08 AM

#

anyone knows the app to overview the maps with schematics?

worn jasper Feb 27, 2024, 6:27 AM

#

broken elbow Dude... I spent like 4 days figuring out why the hell our connection to the DB d...

question is why you use AWS for db?

broken elbow Feb 27, 2024, 4:23 PM

#

worn jasper question is why you use AWS for db?

Dw. it isn't for a minecraft plugin. Also, it is an issue from AWS that their support team just keeps ignoring.

worn jasper Feb 27, 2024, 4:26 PM

#

Using AWS is still a big mistake from what I have heard

#

overall relying too much on those services

#

make it hard to transition out of it later on

broken elbow Feb 27, 2024, 4:35 PM

#

I mean, it is a mistake if you don't have money

#

but if you're a company worth $14B

#

$18B*

#

it probably isn't that bad

#

these web service companies do make it hard to switch off from their platform for already existent apps but, they also make it easy to not have to maintain infrastructure

#

either way, this choice was made years ago, before I even knew what AWS is, or even what a function is.

spring crescent Feb 27, 2024, 4:42 PM

#

What's the standard for working with MySQL? Should I get data from the DB and update classes whenever the plugin is loaded, then periodically update it at some set interval, or should I only request data whenever I need it and update as needed? It should be noted that I'm working with contents of Container types so it can get big, also I'm using HikariCP for performance gains. Finally, I'm a bit confused, given DB actions are not symmetrical, or async, do I need to be treating them as async with scheduling? In my testing, it seems to be mostly instantaneous, but my DB is also local so idk. Can anyone provide some tips for me? This db thing is kicking my ass.

worn jasper Feb 27, 2024, 5:31 PM

#

broken elbow $18B*

so the company you work for is worth 18b?!

river solstice Feb 27, 2024, 5:33 PM

#

mine is only like 3b 😔

worn jasper Feb 27, 2024, 5:35 PM

#

spring crescent What's the standard for working with MySQL? Should I get data from the DB and up...

any database requests should be handled async (use the scheduler). Regarding the when to update, etc. it highly depends on the use case:

Data is only required every so often: Making a request each time is fine
Data is required all the time:
- Data is from a player: Request on join and cache it. You can then choose to "sync" the
  Database to the cache, aka make updates every x time or not.
- Data is required for 2+ players or whole server: Request on plugin start and cache it.

#

That's my recommendations. Should note that database requests don't take that long. (unless you do some very unoptimized queries or have a very very large size database)

spring crescent Feb 27, 2024, 5:38 PM

#

@worn jasper so data is being sent and requested every time someone places a container, or interacts with an inventory. Which could happen with n number of players.

worn jasper Feb 27, 2024, 5:38 PM

#

spring crescent <@310721759110496257> so data is being sent and requested every time someone pla...

Container = Chest?

spring crescent Feb 27, 2024, 5:39 PM

#

Chest, Shulker-Box, Furnace, Barrel, etc..

worn jasper Feb 27, 2024, 5:39 PM

#

Is that per player?

spring crescent Feb 27, 2024, 5:39 PM

#

Yes

worn jasper Feb 27, 2024, 5:39 PM

#

then follow the schema above

#

request on join and cache it

spring crescent Feb 27, 2024, 5:39 PM

#

And. I'm tracking the contents of said things.

worn jasper Feb 27, 2024, 5:39 PM

#

Same answer.

spring crescent Feb 27, 2024, 5:40 PM

#

So no fear of using too much resources?

worn jasper Feb 27, 2024, 5:40 PM

#

nha, resources are almost never the problem in mc plugins xD

#

when interacting with databases.

#

Just do them async, off the main thread, and you are fine.

spring crescent Feb 27, 2024, 5:41 PM

#

Lol okay, good to know. I was concerned that 1000+ containers, and their contents, would bloat RAM for minimal gain.

#

tyvm

worn jasper Feb 27, 2024, 5:41 PM

#

spring crescent Lol okay, good to know. I was concerned that 1000+ containers, and their content...

Would require probably way more than that xD

#

to be a ram issue

#

besides, when players leave, you remove it from cache

#

so, only things actually being used can be used.

spring crescent Feb 27, 2024, 5:42 PM

#

Unfortunately not. The containers are player agnostic

worn jasper Feb 27, 2024, 5:42 PM

#

You could in theory even go further down and only load data from loaded chunks

#

but no idea if that's efficient or not

worn jasper Feb 27, 2024, 5:43 PM

#

spring crescent Unfortunately not. The containers are player agnostic

wdym?

spring crescent Feb 27, 2024, 5:43 PM

#

Here's the project I'm building. https://github.com/mkaulfers/hardcore-seasons

worn jasper Feb 27, 2024, 5:43 PM

#

can't really check it all rn

#

But why exactly wouldn't you be able to remove from cache on player leave?

#

thought it was player specific only

#

or can other players access those containers too?

spring crescent Feb 27, 2024, 5:44 PM

#

Basically, the short and sweet is, containers act as a "Seasonal" reward for hardcore servers. Participating players who die, lose their stuff to the survivors. The survivor of x season, can go to a different server, non-hardcore, and claim all of the generated loot, items, etc..

#

Think of it kinda like an Async PubG type gamemode lol

worn jasper Feb 27, 2024, 5:45 PM

#

was never a pubg guy

spring crescent Feb 27, 2024, 5:45 PM

#

Fortnite?

worn jasper Feb 27, 2024, 5:45 PM

#

worn jasper You could in theory even go further down and only load data from loaded chunks

suppose you could try this? if you require other people to also have access to the containers while players are offline.

worn jasper Feb 27, 2024, 5:45 PM

#

spring crescent Fortnite?

hmhm

spring crescent Feb 27, 2024, 5:47 PM

#

I'm trying to setup some form of encouragement to give hardcore a shot. People might play it more if there's the potential for rewards if they outlive everyone. xD Eg why chest-data needs to be player-agnostic. Anyone can open a chest at any time and when they do I need to update it's contents such that the DB is always in-sync with what's going on in-game.

worn jasper Feb 27, 2024, 5:48 PM

#

spring crescent I'm trying to setup some form of encouragement to give hardcore a shot. People m...

DB doesn't really require to be fully in sync at all times. If you cache stuff, then that isn't an issue.

#

Just sync every few minutes, that should be fine, as said, you might give the chunk loaded idea a try

#

In theory, should be the most efficient.

spring crescent Feb 27, 2024, 5:49 PM

#

Yeh so my initial thought was to just cache it all in some data manager, and periodically update. I went away from that for fear of chewing up RAM which has now since been alleviated.

worn jasper Feb 27, 2024, 5:50 PM

#

You request data on chunk load, when it's unloaded, you put it a "awaiting removal queue" or whatever ya wanna call it, which removes it from cache after a minute or so, this makes it so that if the chunk is loaded again after a few seconds, no need to make a request, you just check if it's in that queue, if yes, get it back to the main cache and voila.

spring crescent Feb 27, 2024, 5:50 PM

#

I like that

worn jasper Feb 27, 2024, 5:50 PM

#

that's an idea on how it would be the most efficient I suppose

spring crescent Feb 27, 2024, 5:50 PM

#

Should be fairly straightforward to implement as well.

worn jasper Feb 27, 2024, 5:51 PM

#

You can use a caching library like caffeine for caching, it offers time based, size based and whatever caching

#

https://github.com/ben-manes/caffeine

river solstice Feb 27, 2024, 6:22 PM

#

brov

#

sterile hinge Feb 27, 2024, 6:22 PM

#

a true classic

river solstice Feb 27, 2024, 6:24 PM

#

https://tenor.com/view/orange-cat-staring-orange-cat-staring-cat-gif-13724146065807985297

Tenor

#

ChatChat

atomic trail Feb 27, 2024, 7:08 PM

#

worn jasper ChatChat on top

Does it support working on a proxy? And modifying the format? To apply colors to username etc.

broken elbow Feb 27, 2024, 7:11 PM

#

river solstice brov

it should've said this should never be null

river solstice Feb 27, 2024, 7:16 PM

#

real

worn jasper Feb 27, 2024, 7:16 PM

#

atomic trail Does it support working on a proxy? And modifying the format? To apply colors to...

No idea, check it

broken elbow Feb 27, 2024, 7:18 PM

#

river solstice real

bcz it shouldn't. the only case this should ever fail if the UUID of a player changes from when they join to when they quit. And the only time I've seen this happen was when people used those cross platform plugins

somber gale Feb 28, 2024, 12:10 AM

#

Someone here good with maven deploy?
I have a multi-module project with the root only having the pom.xml and no source...
Right now it seems there are issues with the dependency resolving as the modules seem to rely on the parent pom? Is there a way I can make it not needed?

Like I get an error like this if trying to deploy or install: https://paste.helpch.at/uwulinumoq.csharp
Only fix for me is to deploy the parent to local maven repo. Remote is currently skiped as I don't see why I should upload only a pom file for this... But this would obviously cause issues to anyone trying to get the dependency.

stuck canopy Feb 28, 2024, 2:27 AM

#

Is there a way to change a player's display name which is visible to specific players

#

I am trying to do this using ProtocolLib but I am not sure what Packet to use

dusky harness Feb 28, 2024, 2:29 AM

#

stuck canopy Is there a way to change a player's display name which is visible to specific pl...

displayname entirely? like both tab and nametag?

stuck canopy Feb 28, 2024, 2:31 AM

#

dusky harness displayname entirely? like both tab and nametag?

lets just say nametag

dusky harness Feb 28, 2024, 2:31 AM

#

stuck canopy lets just say nametag

oh

#

uh

#

hold on theres been a convo relating to this recently

dusky harness Feb 28, 2024, 2:33 AM

#

stuck canopy lets just say nametag

#development message
#development message
#development message
#development message

stuck canopy Feb 28, 2024, 2:36 AM

#

wait, theres a Entity called TextDisplay?

dusky harness Feb 28, 2024, 2:39 AM

#

stuck canopy wait, theres a Entity called TextDisplay?

display entities!!!

#

haven't used them myself since i dont really do mc much but

#

they seem cool

stuck canopy Feb 28, 2024, 2:41 AM

#

dusky harness display entities!!!

didn't know that existed

dusky harness Feb 28, 2024, 2:41 AM

#

stuck canopy didn't know that existed

i think they're pretty new
1.20 maybe

#

or 1.19 idk

terse osprey Feb 28, 2024, 4:45 AM

#

TextDisplays are awesome, my favorite part about them is they can’t be seen through walls (on Java) so you can’t see the names of NPCs or holograms through walls

hoary scarab Feb 28, 2024, 4:50 AM

#

Can do that with entities too. Think its a team object. HideName or something like that.

terse osprey Feb 28, 2024, 4:54 AM

#

Doesn’t that prevent the name from showing up?

hoary scarab Feb 28, 2024, 4:55 AM

#

It might. I'm pretty sure there was one that was specific to through walls. Similar to crouching.

terse osprey Feb 28, 2024, 4:55 AM

#

Erm I don’t think so but maybe, hidename prevents the name all together

hoary scarab Feb 28, 2024, 5:35 AM

#

https://www.spigotmc.org/resources/must-have-name-hide-no-lag-client-side.83899/ ?

terse osprey Feb 28, 2024, 5:41 AM

#

No idea, but I feel like you’re really trying to shoehorn this “issue” lol

#

There very well might be other ways of doing it, I was just stating the reason I like TextDisplays

hoary scarab Feb 28, 2024, 5:52 AM

#

Why is it an issue? Just showing its possible with normal entities.

terse osprey Feb 28, 2024, 5:54 AM

#

You’re solving a problem nobody is asking… OP (shadow) hasn’t stated that they can’t/wont use the solution somebody provided them. Maybe you’re just posting this alternative method for if somebody were to stumble upon it looking for a non TextDisplay solution?

#

Either way you do you king, if you want to juggle things with armorstands on the NMS side go for it you’re a king. But since textdisplayes were added I was providing my input in response to shadows lack of knowing about them

#

And again I’ll state if you want to go the entity route go for it, if it works for your usecase amazing. Nothing wrong with it

hoary scarab Feb 28, 2024, 5:58 AM

#

You’re solving a problem nobody is asking…

Can do that with entities too. Think its a team object. HideName or something like that.

It might. I'm pretty sure there was one that was specific to through walls. Similar to crouching.

https://www.spigotmc.org/resources/must-have-name-hide-no-lag-client-side.83899/

terse osprey Feb 28, 2024, 5:59 AM

#

… ok man 👍

dense galleon Feb 28, 2024, 3:51 PM

#

So, I've got this plugin called "Artifacts" which implements custom items for my network.
The current system I have is for any of my other plugins to use a Artifacts#registerArtifact method to register their own items.
This works fine, however if Plugin1 registers an artifact that for one reason or another Plugin2 might need to check for, Plugin2 will need to depend on Plugin1 just for that reason.

#

Which feels quite inefficient?

#

Currently each plugin implementing Artifacts holds static instances of these in a <PluginName>Artifacts class, but again this feels pretty inefficient.

merry knoll Feb 28, 2024, 4:12 PM

#

why not abstract away the artifact

#

as in pl1 depends on artifacts and uses artifact interface

#

to create and register

#

p2 does not need to know about p1's implementation details

#

it knows Artifact interface

#

etc

dense galleon Feb 28, 2024, 4:12 PM

#

Yeah I know but

#

If any other plugin needs access to one of these artifact instances

#

That other plugin needs to depend on the plugin implementing that artifact

merry knoll Feb 28, 2024, 4:13 PM

#

cache them to a name - anything thats global

#

effectively

dense galleon Feb 28, 2024, 4:13 PM

#

Okay well the current system I have otherwise is, my core plugin has a namespace package where I just store a bunch of public static final namespaces

merry knoll Feb 28, 2024, 4:14 PM

#

i dont see how p2 would need to know implementation details of p1

#

look at vault for example

#

you know you can access economy through vault

dense galleon Feb 28, 2024, 4:14 PM

#

merry knoll i dont see how p2 would need to know implementation details of p1

I mean, to do Plugin1Artifacts.ARTIFACT_1

merry knoll Feb 28, 2024, 4:14 PM

#

ah, are you caching them in a singleton or smt?

dense galleon Feb 28, 2024, 4:14 PM

#

merry knoll you know you can access economy through vault

Never really used Vault

merry knoll Feb 28, 2024, 4:14 PM

#

caching needs to happen on the artifacts plugin

#

not on individual plugins that implement stuff

#

you can ALSO cache there, but access needs to go through the main one

dense galleon Feb 28, 2024, 4:15 PM

#

Right, but I can't really have public static final variables there

#

The closest thing to that would be a public static final NamespacedKey, Artifact map

merry knoll Feb 28, 2024, 4:15 PM

#

yes you cant "register" then either

#

regardless

#

have a hashmap

#

with namespace:item as kety

#

key

#

and use that to cache - register - retrieve

worn jasper Feb 28, 2024, 4:16 PM

#

merry knoll not on individual plugins that implement stuff

he is trying to use things of p1 in p2 while p2 depends on p1 and p1 in p2, basically a loop if I understood correctly.

merry knoll Feb 28, 2024, 4:16 PM

#

nah

#

he wants to statically hold the reference

dense galleon Feb 28, 2024, 4:16 PM

#

worn jasper he is trying to use things of p1 in p2 while p2 depends on p1 and p1 in p2, basi...

I mean for now no, but I suppose that can also happen

worn jasper Feb 28, 2024, 4:16 PM

#

-.-

merry knoll Feb 28, 2024, 4:16 PM

#

but thats not possible since implementation and what is implemented

#

is abstracted away

dense galleon Feb 28, 2024, 4:16 PM

#

Does it make sense to have a class or multiple classes in my core plugin which holds a lot of singleton NamespacedKey objects?

merry knoll Feb 28, 2024, 4:17 PM

#

yes

#

thats how di frameworks kinda work

#

in a simple form as well

#

you provide them with a singleton - factory

dense galleon Feb 28, 2024, 4:17 PM

#

Okay cause that was my 'temporary solution'

merry knoll Feb 28, 2024, 4:17 PM

#

and they provide instances

dense galleon Feb 28, 2024, 4:17 PM

#

But then no matter what, I will have to go back to my core plugin and write new namespaces any time I add new instances of artifacts for example

#

I assume that's unavoidable though

merry knoll Feb 28, 2024, 4:18 PM

#

why not dynamically register them

dense galleon Feb 28, 2024, 4:18 PM

#

Wdym? Through a register() method?

merry knoll Feb 28, 2024, 4:18 PM

#

p1 calls register method

#

yes

#

if you need them all in one place make your register method

#

update a file or smt

dense galleon Feb 28, 2024, 4:18 PM

#

But how does p2 have access to NamespacedKeys registered through p1?

merry knoll Feb 28, 2024, 4:18 PM

#

it can be plain string

#

or a custom object as key

#

thats provided by the core

#

as in the interface

dense galleon Feb 28, 2024, 4:19 PM

#

Ah right so i'd just have to "manually" type the string myself

#

Meaning that if for one reason or another, p2, p3 and p4 need to get the same object reference registered by p1 i will have to repeat the RegistryClass.getRegistry().getValue("Something") for each?

merry knoll Feb 28, 2024, 4:21 PM

#

since these seem to be singletons

#

you can also use the class itself as the key

#

and depend - retrieve from there using it

#

which kinda defeats the purpose but its better than hard coding strings as namespaces

dense galleon Feb 28, 2024, 4:22 PM

#

Okay so recap

#

My core plugin should have some kind of Registry class that holds Map<NamespacedKey, Object> and a register() method to put items in this map?

merry knoll Feb 28, 2024, 4:23 PM

#

ideally not object

#

more like some interface

dense galleon Feb 28, 2024, 4:23 PM

#

yeah a more narrowed down scope

merry knoll Feb 28, 2024, 4:23 PM

#

ya

dense galleon Feb 28, 2024, 4:24 PM

#

In my case Artifact

merry knoll Feb 28, 2024, 4:24 PM

#

and in the case of these all being singletons

#

you can just go

#

LightningArtifact.class as key for example

#

and it gives you its already initialized instance

dense galleon Feb 28, 2024, 4:24 PM

#

is it fine for it to be an abstract class instead of an interface?

merry knoll Feb 28, 2024, 4:25 PM

#

i usually do interfaces first then dive into actual implementations*

#

but it does not matter honestly

merry knoll Feb 28, 2024, 4:25 PM

#

merry knoll i usually do interfaces first then dive into actual implementations*

it has to do with having to unit test everything at work though

dense galleon Feb 28, 2024, 4:25 PM

#

The Artifact class originally was an interface, but I need anything that extends it to have a bunch of code run in the constructor

merry knoll Feb 28, 2024, 4:25 PM

#

in spigot it doesnt matter honestly

#

you probably want a factory though

#

is my guess

dense galleon Feb 28, 2024, 4:26 PM

#

An Artifact interface with a Factory subclass? Or what do you mean

#

I don't even know if you can create subclasses in Interfaces tbh, never tried

merry knoll Feb 28, 2024, 4:27 PM

#

cant comment much without knowing the details

#

but having a lot of shared code usually signals that it can be factorized away

dense galleon Feb 28, 2024, 4:27 PM

#

https://paste.helpch.at/eririluwih.java That's the class I'm on about

#

Some of the code in there is a year old and I haven't looked at too much

merry knoll Feb 28, 2024, 4:29 PM

#

ah i see now, abstract class is fine probably

#

unless you run into an issue no point creating one when you dont feel any

dense galleon Feb 28, 2024, 4:34 PM

#

Okay though I'm thinking

#

if Artifacts depends on my core plugin, I don't really have access to the class ArtifactItem from my core plugin

#

Which means I'd have to move that abstract class to my core plugin right

#

Though is it really correct to have an abstract class in my API package of the core plugin?

merry knoll Feb 28, 2024, 4:38 PM

#

i would keep it seperate and depend on artifacts

#

on everywhere that uses it

#

if all your plugins will use it you can define it as a transient dependency

dense galleon Feb 28, 2024, 4:39 PM

#

Not all plugins no, it's just to do so that my map will store Artifact objects as values

#

Instead of just Object

merry knoll Feb 28, 2024, 4:39 PM

#

why is your map

#

based on the core

#

placed**

dense galleon Feb 28, 2024, 4:39 PM

#

Ah you recon all the artifacts should be in a map inside of my Artifacts plugin?

merry knoll Feb 28, 2024, 4:40 PM

#

yes

dense galleon Feb 28, 2024, 4:40 PM

#

For SRP

merry knoll Feb 28, 2024, 4:40 PM

#

artifact logic goes into artifact module etc

dense galleon Feb 28, 2024, 4:41 PM

#

However, my core plugin should have singleton instances of the NamespacedKeys to be placed in the map?

merry knoll Feb 28, 2024, 4:43 PM

#

if you use keys in other places yes

#

otherwise no

dense galleon Feb 28, 2024, 4:43 PM

#

Yeah I mean I might

merry knoll Feb 28, 2024, 4:43 PM

#

i would just modulerize it away personally

dense galleon Feb 28, 2024, 4:43 PM

#

But in case I want plugin2 to use an item from plugin1, i'd need that key to get the artifact

merry knoll Feb 28, 2024, 4:44 PM

#

since these are items you can follow mc convention on the namespaces honestly

#

minecraft:grass etc

#

and just go with string

#

i would also probably make a factory on the artifact module

#

to get these items

dense galleon Feb 28, 2024, 4:44 PM

#

yeah I mean my current namespacekey is plugin:item

dense galleon Feb 28, 2024, 4:45 PM

#

merry knoll i would also probably make a factory on the artifact module

A factory to get the items?

merry knoll Feb 28, 2024, 4:45 PM

#

instead of implicitly calling the "artifacs"

dense galleon Feb 28, 2024, 4:45 PM

#

I thought factory would be to build the items

#

am I missing something

merry knoll Feb 28, 2024, 4:45 PM

#

yes to build in your case

#

clone