#development | HelpChat | Page 12

lyric gyro Sep 2, 2022, 4:24 PM

#


import org.bukkit.Material;
import org.bukkit.World;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;
import org.checkerframework.checker.nullness.qual.NonNull;

import static org.bukkit.Material.*;

public class Listeners implements Listener {

    @EventHandler
    public void usedGoatHorn (PlayerInteractEvent e){
        Player p = e.getPlayer();
        Material goatHorn = e.getMaterial();
        if (goatHorn == GOAT_HORN){
            if (p.hasCooldown(goatHorn)){
              return;
            } else {
                World world = p.getWorld();
                world.spawnEntity(p.getLocation(), EntityType.GOAT);
            }


        }

        }


    }

#

what about now

hoary scarab Sep 2, 2022, 4:32 PM

#

public void onInteract(PlayerInteractEvent event) {
    Player p = event.getPlayer();
    Material goatHorn = Material.GOAT_HORN;
    ItemStack interactionItem = event.getInteractionItem();
    if(interactionItem == null)
        return; // No item.

    if(interactionItem.getType() != goatHorn)
        return; // No goat horn.

    if(p.hasCooldown(goatHorn))
        return; // Cool down

    World w = p.getWorld();
    w.spawnEntity(p.getLocation(), EntityType.GOAT);
}

lyric gyro Sep 2, 2022, 4:33 PM

#

hoary scarab ```java public void onInteract(PlayerInteractEvent event) { Player p = event...

this simplifies things a little bit

#

what is the item stack thing for

hoary scarab Sep 2, 2022, 4:34 PM

#

lyric gyro what is the item stack thing for

The item you clicked

lyric gyro Sep 2, 2022, 4:34 PM

#

Uhh it's not needed I think

tepid hawk Sep 2, 2022, 4:35 PM

#

is it possible to return a net.kyori.Component on placeholder request?

hoary scarab Sep 2, 2022, 4:36 PM

#

lyric gyro Uhh it's not needed I think

You can do either or. But you still have to check if its null

dusky harness Sep 2, 2022, 4:37 PM

#

tepid hawk is it possible to return a net.kyori.Component on placeholder request?

no, it's only Strings

hoary scarab Sep 2, 2022, 4:37 PM

#

I'll pretend I didn't see that @dusky harness 😉

dusky harness Sep 2, 2022, 4:38 PM

#

hoary scarab I'll pretend I didn't see that <@521485088995672084> 😉

I mean it was true, but I realized that was a while ago so I just deleted it

#

as it wasn't relevant

#

idk I don't feel like scrolling up and checking

dense drift Sep 2, 2022, 4:41 PM

#

tepid hawk is it possible to return a net.kyori.Component on placeholder request?

if the component can be represented as a String, sure, you have to serialize it with LegacyComponentSerializer

dense galleon Sep 2, 2022, 4:42 PM

#

How bad is it for performance to create a runnable for each mob present in a minigame I am making?

#

There can be up to 150-200 mobs in the minigame

dense drift Sep 2, 2022, 4:42 PM

#

x y problem?

dense galleon Sep 2, 2022, 4:42 PM

#

Hold on

#

I was about to get into specifics

#

The runnable would run every 10 ticks, will compare doubles and possibly change the value of a field present in its outer class

merry knoll Sep 2, 2022, 4:44 PM

#

dense galleon The runnable would run every 10 ticks, will compare doubles and possibly change ...

why not just create one runnable

#

and loop over the mobs / entities

dense galleon Sep 2, 2022, 4:45 PM

#

I already have a data class for each mob, would have been neat to have a runnable within that class which handles that logic

#

Instead of having a common runnable do that

merry knoll Sep 2, 2022, 4:45 PM

#

it wont be a big deal performance wise

#

runnable is just a version of a callback

dense galleon Sep 2, 2022, 4:46 PM

#

It's code which affects mobs AI, would feel weird to have each mob AI change in some MobManager class

merry knoll Sep 2, 2022, 4:46 PM

#

state machine?

#

again the runnable itself is not a big deal

#

it depends on what you do inside it

dense galleon Sep 2, 2022, 4:47 PM

#

okay that's kinda what I wanted to hear

merry knoll Sep 2, 2022, 4:47 PM

#

make sure to cancel the tasks as they die though

dense galleon Sep 2, 2022, 4:47 PM

#

Yeah of course

lyric gyro Sep 2, 2022, 4:48 PM

#

guys

#

I just figured out something really weird

dense galleon Sep 2, 2022, 4:48 PM

#

I'd literally just be comparing a few doubles together, and then setting a field from time to time

lyric gyro Sep 2, 2022, 4:48 PM

#

with goat horns

#

seriously

#

the first goat horn

#

"ponder" isnt considered a goat horn?

merry knoll Sep 2, 2022, 4:48 PM

#

i dont think it fits in the class though

#

architecture wise

lyric gyro Sep 2, 2022, 4:50 PM

#

lyric gyro "ponder" isnt considered a goat horn?

nvm, the server was just bitching with m

#

me

#

how do I pull a nbt tag from an item?

#

using nms

#

of course

clever relic Sep 2, 2022, 5:11 PM

#

Yeah. basically making a site for it and just want the basics:

All below will be vice versa

MP4 -> GIF
AVI -> MP4
FLV -> MP4
PNG -> JPEG etc
PDF -> DOC, DOCX```

lyric gyro Sep 2, 2022, 5:42 PM

#

uh I don't know of any one single godlike solution that does all of them but you'll be able to find plenty of solutions that can do specific types, e.g. ffmpg for video, another one for images, another for documents etc

dusky harness Sep 2, 2022, 5:47 PM

#

unless you want to pay for a conversion api just google like "convert png to jpg java"

icy shadow Sep 2, 2022, 5:50 PM

#

Ffmpeg can do all of those video and audio conversions yeah

lyric gyro Sep 2, 2022, 5:56 PM

#

lyric gyro how do I pull a nbt tag from an item?

bump

#

just cant figure out the method or how to do it

winged pebble Sep 2, 2022, 6:07 PM

#

https://www.spigotmc.org/threads/tutorial-the-complete-guide-to-itemstack-nbttags-attributes.131458/

lyric gyro Sep 2, 2022, 6:20 PM

#

winged pebble <https://www.spigotmc.org/threads/tutorial-the-complete-guide-to-itemstack-nbtta...

do I have to create a new item to get its nbt tag?

#

like

#

I want to make goat horns do different things

#

but I don't want to create a new item for them

winged pebble Sep 2, 2022, 6:22 PM

#

You have to have an instance of an item to set its nbt tags, yes

#

But not to read from them

lyric gyro Sep 2, 2022, 6:23 PM

#

i dont want to set nbt tags

#

just read them

#

like

#

if nbt tag = 5 (idk)
do something

winged pebble Sep 2, 2022, 6:23 PM

#

No, you don't need to create a separate item to read from it, you just use the item you already have

lyric gyro Sep 2, 2022, 6:24 PM

#

winged pebble No, you don't need to create a separate item to read from it, you just use the i...

that's what I wanted

#

so

#

how do i do it

winged pebble Sep 2, 2022, 6:24 PM

#

winged pebble <https://www.spigotmc.org/threads/tutorial-the-complete-guide-to-itemstack-nbtta...

^

lyric gyro Sep 2, 2022, 6:25 PM

#

winged pebble ^

Idk if this article helps

winged pebble Sep 2, 2022, 6:27 PM

#

Then you haven't read it

#

It shows how to read an nbt tag

lyric gyro Sep 2, 2022, 6:27 PM

#

where exactly

#

this thing is huge

merry knoll Sep 2, 2022, 6:27 PM

#

the whole thing

winged pebble Sep 2, 2022, 6:27 PM

#

Ctrl + f is your friend

lyric gyro Sep 2, 2022, 6:28 PM

#

yeah i tried that

winged pebble Sep 2, 2022, 6:29 PM

#

What did you search

lyric gyro Sep 2, 2022, 6:29 PM

#

read

winged pebble Sep 2, 2022, 6:29 PM

#

Do "get"

lyric gyro Sep 2, 2022, 6:30 PM

#

winged pebble Do "get"

do I have to worry about this nbttag compound stuff

#

what is it about

#

goddamn so much text

#

its making me confused

winged pebble Sep 2, 2022, 6:32 PM

#

No it's not lol

#

The first screen of text tells you how to get the NBT object, set a value in it, and how to retrieve a value from the nbt object

#

Essentially the basics of interacting with nbt

lyric gyro Sep 2, 2022, 6:34 PM

#

winged pebble The first screen of text tells you how to get the NBT object, set a value in it,...

hmm let me see

#

what is nbt compound though

#

and nms copy

winged pebble Sep 2, 2022, 6:34 PM

#

You have to get the NMS version of the item to get the NBT data

#

And NBTTagCompound is just the class that stores/interacts with nbt

lyric gyro Sep 2, 2022, 6:35 PM

#

winged pebble And NBTTagCompound is just the class that stores/interacts with nbt

Will I use this for what I am trying to do?

#

If a specific goat horn is played

#

Add potion effect absorption

winged pebble Sep 2, 2022, 6:36 PM

#

interacts with nbt

#

That answers your question I believe

lyric gyro Sep 2, 2022, 6:36 PM

#

understood

#

So what I have to do is

#

Get the nmscopy

#

Then do something with the compound idk

#

then write the code of what I want it to do?

#

And how nbt tags look like?

#

are they numbers

#

?

#

or something like that

winged pebble Sep 2, 2022, 6:37 PM

#

You'll have to explore that yourself

#

Idk how the data is stored in goathorns

lyric gyro Sep 2, 2022, 6:39 PM

#

@winged pebble It also mentions creating a NBTTCompound

#

But the person who wrote this is using apple as an example

#

Which doesn't have NBT tags I believe

#

But a goat horn does

#

so

winged pebble Sep 2, 2022, 6:40 PM

#

Basically iirc, getTag() can return null

#

So they are just giving it an instance if it is null

lyric gyro Sep 2, 2022, 6:41 PM

#

Christ

#

This is going to be difficult

#

But I'll try

#

that's the last thing I've got to do

#

till my plugin is finished

lyric gyro Sep 2, 2022, 6:48 PM

#

winged pebble Basically iirc, getTag() can return null

net.minecraft.server.v1_12_R1.ItemStack nmsApple = CraftItemStack.asNMSCopy(apple);

#

where do I put this

#

this net.minecraft.server thing

winged pebble Sep 2, 2022, 6:50 PM

#

That's just the package of nms you're using

#

It's the fully qualified name of the class you're accessing

lyric gyro Sep 2, 2022, 6:50 PM

#

I don't have to write this anywhere in my code then?

winged pebble Sep 2, 2022, 6:51 PM

#

You'll most likely have to adapt it for your version

lyric gyro Sep 2, 2022, 6:51 PM

#

yes

winged pebble Sep 2, 2022, 6:51 PM

#

As you can't just say ItemStack because you also have the bukkit ItemStack class so it needs to differentiate them somehow

lyric gyro Sep 2, 2022, 6:53 PM

#

winged pebble As you can't just say ItemStack because you also have the bukkit ItemStack class...

what do I got to do then

winged pebble Sep 2, 2022, 6:59 PM

#

Use the fully qualified name of the class

lyric gyro Sep 2, 2022, 6:59 PM

#

goddamn why am I so slow today

lyric gyro Sep 2, 2022, 7:00 PM

#

lyric gyro ```net.minecraft.server.v1_12_R1.ItemStack nmsApple = CraftItemStack.asNMSCopy(a...

where do i put this though @winged pebble

#

thats what I want to know

winged pebble Sep 2, 2022, 7:01 PM

#

All that line is doing is taking a bukkit item and giving you the nms version of it

#

So you need to do that first in order to access the nbt tags

lyric gyro Sep 2, 2022, 7:02 PM

#

i know

#

but where do i put it

#

i know what its doing

winged pebble Sep 2, 2022, 7:02 PM

#

What do you mean where do you put it?

lyric gyro Sep 2, 2022, 7:03 PM

#

winged pebble What do you mean where do you put it?

the line

#

where do i write it

winged pebble Sep 2, 2022, 7:03 PM

#

You put it wherever you're checking to see if the item in question is that item

lyric gyro Sep 2, 2022, 7:03 PM

#

ok

lyric gyro Sep 2, 2022, 7:05 PM

#

winged pebble You put it wherever you're checking to see if the item in question is that item

like this?

#

            if (p.hasCooldown(goatHorn)){
              return;
            } else {
                net.minecraft.server.v1_19_R1.ItemStack nmsHorn = CraftItemStack.asNMSCopy(GOAT_HORN);
                World world = p.getWorld();
                world.spawnEntity(p.getLocation(), EntityType.GOAT);
            }```

#

what does craftitemstack does btw

winged pebble Sep 2, 2022, 7:06 PM

#

CraftItemStack is just the class name

#

And you're accessing a static method from it

lyric gyro Sep 2, 2022, 7:06 PM

#

oh ok

#

get it

#

so uh

lyric gyro Sep 2, 2022, 7:06 PM

#

lyric gyro ```if (goatHorn == GOAT_HORN){ if (p.hasCooldown(goatHorn)){ ...

is this correct?

#

its asking me to add a dependency for it

winged pebble Sep 2, 2022, 7:07 PM

#

1.17+ doesn't include the version in the package name for nms

lyric gyro Sep 2, 2022, 7:07 PM

#

winged pebble 1.17+ doesn't include the version in the package name for nms

so what do I do

winged pebble Sep 2, 2022, 7:09 PM

#

You use the updated package name

#

lyric gyro Sep 2, 2022, 7:12 PM

#

winged pebble

what

#

nonono

#

I think I got it

#

I didn't need to use that

#

net.minecraft.server thing

#

just the ItemStack part

#

I didn't need to refer the package

winged pebble Sep 2, 2022, 7:13 PM

#

Potentially

lyric gyro Sep 2, 2022, 7:14 PM

#

winged pebble Potentially

'asNMSCopy(org.bukkit.inventory.ItemStack)' in 'org.bukkit.craftbukkit.v1_19_R1.inventory.CraftItemStack' cannot be applied to '(org.bukkit.Material)'

#

it's saying this

winged pebble Sep 2, 2022, 7:14 PM

#

Yup, makes sense

#

You're not giving it the parameter it's asking for

lyric gyro Sep 2, 2022, 7:15 PM

#

winged pebble You're not giving it the parameter it's asking for

what parameter do i use then

winged pebble Sep 2, 2022, 7:15 PM

#

It tells you in the error

lyric gyro Sep 2, 2022, 7:16 PM

#

winged pebble It tells you in the error

itemstack

#

Im trying to use a material

#

when it needs a itemstack?

winged pebble Sep 2, 2022, 7:16 PM

#

Correct

lyric gyro Sep 2, 2022, 7:16 PM

#

really whats the difference between these two

winged pebble Sep 2, 2022, 7:17 PM

#

Well the main difference is that CraftItemStack.asNMSCopy accepts an ItemStack as a parameter, and a Material is not an ItemStack

#

It's the difference between a Door and Wood

#

An ItemStack has more properties than a Material

lyric gyro Sep 2, 2022, 7:19 PM

#

so uh

#

what do I

#

put

winged pebble Sep 2, 2022, 7:20 PM

#

You give it an ItemStack

lyric gyro Sep 2, 2022, 7:21 PM

#

oh wait

#

I see now

#

I need to create an item stack

#

for the material goat horn

winged pebble Sep 2, 2022, 7:21 PM

#

You don't actually

#

You're using an event, right?

lyric gyro Sep 2, 2022, 7:22 PM

#

yeah

#

playerinteract event

winged pebble Sep 2, 2022, 7:22 PM

#

And how are you checking the material type?

lyric gyro Sep 2, 2022, 7:22 PM

#



import org.bukkit.Material;
import org.bukkit.World;
import org.bukkit.craftbukkit.v1_19_R1.inventory.CraftItemStack;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;

import static org.bukkit.Material.*;

public class Listeners implements Listener {


    @EventHandler
    public void usedGoatHorn (PlayerInteractEvent e){
        Player p = e.getPlayer();
        Material goatHorn = e.getMaterial();
        p.setCooldown(GOAT_HORN, 800);
        if (goatHorn == GOAT_HORN){
            if (p.hasCooldown(goatHorn)){
              return;
            } else {
                ItemStack nmsHorn = CraftItemStack.asNMSCopy(GOAT_HORN);
                World world = p.getWorld();
                world.spawnEntity(p.getLocation(), EntityType.GOAT);
            }


        }

        }


    }```

#

the whole thing

#

im checking material type with get material and an if statement if thats what you mean

winged pebble Sep 2, 2022, 7:23 PM

#

Oh, legit didn't know that getMaterial() was a method on that event

#

I've always just gotten it from the item

lyric gyro Sep 2, 2022, 7:24 PM

#

so

#

what do you suggest

winged pebble Sep 2, 2022, 7:24 PM

#

Get the item from the event instead

mystic gull Sep 2, 2022, 7:25 PM

#

Bukkit.getScheduler().getPendingTasks() will return all the pending tasks from my plugin or from the whole server?

lyric gyro Sep 2, 2022, 7:26 PM

#

winged pebble Get the item from the event instead

hmmm

#

so instead of getmaterial

winged pebble Sep 2, 2022, 7:26 PM

#

mystic gull Bukkit.getScheduler().getPendingTasks() will return all the pending tasks from m...

Returns a list of all pending tasks. The ordering of the tasks is not related to their order of execution.
Seems to suggest all of them

lyric gyro Sep 2, 2022, 7:26 PM

#

i would just be

#

material material = goathorn

#

or something like that

mystic gull Sep 2, 2022, 7:27 PM

#

winged pebble > Returns a list of all pending tasks. The ordering of the tasks is not related ...

oh ty

winged pebble Sep 2, 2022, 7:27 PM

#

lyric gyro i would just be

I mean, you can continue to get the Material from the event or from the ItemStack, that's your choice

#

I'm just saying that you can get the ItemStack from the event and pass that in asNMSCopy()

lyric gyro Sep 2, 2022, 7:27 PM

#

i think ill just create a new itemstack

winged pebble Sep 2, 2022, 7:28 PM

#

You do realize the issue with that, right?

lyric gyro Sep 2, 2022, 7:28 PM

#

what

winged pebble Sep 2, 2022, 7:28 PM

#

Imagine you have two boards, you write on one board, and in order to see what you have written on the board, you cut another board from a tree

#

The second board isn't going to have the writing that the first board does

#

You're trying to create a second board to read the writing on the first

#

The nbt data that you're trying to read, won't exist on the new itemstack that you create

lyric gyro Sep 2, 2022, 7:30 PM

#

oh

#

@winged pebble

#

I think ill have a break

#

I feel my head is full rn

#

and I cant understand this

#

can we do that later

nimble leaf Sep 2, 2022, 8:03 PM

#

Can PAPI run on Bungeecord?

#

or the API be accessed by a BungeeCord plugin?

#

I mean

#

I want to script a plugin with placeholders on Bungeecord

#

so all backends servers can access that placeholder

merry knoll Sep 2, 2022, 8:07 PM

#

nimble leaf Can PAPI run on Bungeecord?

no

merry knoll Sep 2, 2022, 8:08 PM

#

nimble leaf or the API be accessed by a BungeeCord plugin?

semi yes, if you implement it yourself

#

but you need to hook up to the servers individually and pull data to bungee

merry knoll Sep 2, 2022, 8:08 PM

#

nimble leaf so all backends servers can access that placeholder

but for this, a setup with both bungee + spigot plugins

#

is probably the best idea

#

spigot feeds the data to papi and bungee handles logic

nimble leaf Sep 2, 2022, 8:09 PM

#

at this point yes

#

Thanks for answering mate

lyric gyro Sep 2, 2022, 8:15 PM

#

winged pebble I mean, you can continue to get the Material from the event or from the ItemStac...

im back

#

could anyone help me with this

#

since deerjump isnt online

#

I just want to get the nbt tags of a goat horn

#

and make them do different stuff

#

depending on the horn

#

but idk how to get the nbt tags

#

ItemStack nmsHorn = CraftItemStack.asNMSCopy();

#

more specifically

#

idk what to put in the parameter

#

Material goatHorn = e.getMaterial();

#

we also have this

#

should I just make it an itemstack?

#

    public void usedGoatHorn (PlayerInteractEvent e){
        Player p = e.getPlayer();
        Material goatHorn = e.getMaterial();
        p.setCooldown(GOAT_HORN, 800);
        if (goatHorn == GOAT_HORN){
            if (p.hasCooldown(goatHorn)){
              return;
            } else {
                ItemStack nmsHorn = CraftItemStack.asNMSCopy();
                World world = p.getWorld();
                world.spawnEntity(p.getLocation(), EntityType.GOAT);
            }


        }```

#

the full thing

winged pebble Sep 2, 2022, 8:35 PM

#

Focus on one step at a time

#

In order to get an nbt value from an item, you need the NBTTagCompound from the item, since you can't access the NBTTagCompound from the Bukkit version of the item (org.bukkit.inventory.ItemStack), you need to pass in the Bukkit item you do have to CraftItemStack.asNMSCopy(), which gives you the NMS version of the item (net.minecraft.world.item.ItemStack), which does have access to the NBTTagCompound

lyric gyro Sep 2, 2022, 8:38 PM

#

yes

lyric gyro Sep 2, 2022, 8:39 PM

#

winged pebble In order to get an nbt value from an item, you need the NBTTagCompound from the ...

yeah i understood this part

#

im asking about the parameter though

winged pebble Sep 2, 2022, 8:40 PM

#

It doesn't seem like you do though

lyric gyro Sep 2, 2022, 8:40 PM

#

now I do

lyric gyro Sep 2, 2022, 8:40 PM

#

lyric gyro im asking about the parameter though

ik you gotta put an itemstack

#

But I don't have an itemstack for goat horn

winged pebble Sep 2, 2022, 8:40 PM

#

winged pebble I'm just saying that you can get the ItemStack from the event and pass that in a...

^

lyric gyro Sep 2, 2022, 8:40 PM

#

yes but how

#

if it's not an itemstack

#

it's a material

winged pebble Sep 2, 2022, 8:41 PM

#

It is

#

I didn't say get the Material

#

I said get the ItemStack

#

Look at the methods on PlayerInteractEvent

#

Which one gives you an ItemStack?

lyric gyro Sep 2, 2022, 8:42 PM

#

winged pebble Which one gives you an ItemStack?

the only thing related to an itemstack here is the nmshorn

winged pebble Sep 2, 2022, 8:42 PM

#

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/player/PlayerInteractEvent.html

#

Look at the methods of this class, and look for one that returns an ItemStack

lyric gyro Sep 2, 2022, 8:44 PM

#

is it getItem?

#

yeah it is

winged pebble Sep 2, 2022, 8:45 PM

#

Yup

#

then you can get that item and pass it into CraftItemStack.asNMSCopy()

#

Which will give you the nms version of the item the player interacted with in their hand

lyric gyro Sep 2, 2022, 8:47 PM

#

winged pebble then you can get that item and pass it into CraftItemStack.asNMSCopy()

ok

#

I think I got it

#

but the ide isn't allowing me to use getitem

#

like

#

p.getItem();

winged pebble Sep 2, 2022, 8:48 PM

#

What is p?

lyric gyro Sep 2, 2022, 8:48 PM

#

player object

winged pebble Sep 2, 2022, 8:49 PM

#

And what class has getItem() as a method?

lyric gyro Sep 2, 2022, 8:49 PM

#

oh

#

im stupid

#

and slow

#

lol

lyric gyro Sep 2, 2022, 8:50 PM

#

winged pebble And what class has getItem() as a method?

its player interact event

#

so in this case

#

hmmm

#

let me see

#

@winged pebble

#

It's playerinteract event

#

no wait

#

it's uhh itemstack?

winged pebble Sep 2, 2022, 8:53 PM

#

right, so get the ItemStack from the event and pass it through

#

e.getItem()

#

That is what you're looking for

#

e is your PlayerInteractEvent variable

lyric gyro Sep 2, 2022, 8:53 PM

#

oh

#

what does e do

#

it's the name of my "p.i.e" variable

#

im just lazy dont want to type the whole thing

winged pebble Sep 2, 2022, 8:54 PM

#

It's the event

#

lyric gyro Sep 2, 2022, 8:54 PM

#

yeah

#

do i have to erase the material object?

#

material material = e.getmaterial

#

or nah

winged pebble Sep 2, 2022, 8:55 PM

#

winged pebble I mean, you can continue to get the Material from the event or from the ItemStac...

^

lyric gyro Sep 2, 2022, 8:55 PM

#

I can't have both right?

#

that thing

#

with the boards you said

winged pebble Sep 2, 2022, 8:55 PM

#

There is no reason to get the Material from both the event and the Item

#

One or the other works fine

#

But you need the item because you need to pass it to asNMSCopy()

lyric gyro Sep 2, 2022, 8:56 PM

#

winged pebble There is no reason to get the Material from both the event and the Item

I think there is actually

#

if (p.hasCooldown(goatHorn)){

#

this

#

it gives me an error if i try to make it an itemstack

#

idk if you went silent because you are thinking on a solution or because you are thinking im stupid

#

well i am stupid

#

but ig i used all my brainpower for the day

#

and im slower than usual for some reason

winged pebble Sep 2, 2022, 8:59 PM

#

Well hasCooldown() only accepts a Material

lyric gyro Sep 2, 2022, 9:00 PM

#

see

#

that's why we need both the material and an itemstack

#

will it work if i just add getType on the end?

winged pebble Sep 2, 2022, 9:00 PM

#

I never said you didn't need Material

lyric gyro Sep 2, 2022, 9:00 PM

#

if (p.hasCooldown(goatHorn.getType())){

#

like that

winged pebble Sep 2, 2022, 9:01 PM

#

That works

lyric gyro Sep 2, 2022, 9:01 PM

#

so we can move on ig

#

now the parameter

#

no wait

#

if (goatHorn == GOAT_HORN){

#

we still have this

#

if (goatHorn = GOAT_HORN){

#

this to be more specific

#

so it says that it needs to be a material

winged pebble Sep 2, 2022, 9:02 PM

#

So do the same thing that you did for hasCooldown

lyric gyro Sep 2, 2022, 9:03 PM

#

yeah done

#

i think it works

#

it isnt giving me any more errors related to this

#

but we still have that parameter

#

what do i put there again?

#

        p.setCooldown(GOAT_HORN, 800);
        ItemStack goatHorn = e.getItem();
        if (goatHorn.getType() == GOAT_HORN){
            if (p.hasCooldown(goatHorn.getType())){
              return;
            } else {
                ItemStack nmsHorn = CraftItemStack.asNMSCopy();
                World world = p.getWorld();
                world.spawnEntity(p.getLocation(), EntityType.GOAT);
            }```

#

code btw

winged pebble Sep 2, 2022, 9:08 PM

#

For simplicity's sake, lets shuffle things around a little

Player p = e.getPlayer();
// p.setCooldown(GOAT_HORN, 800) You don't actually want this here. Worry about this later
ItemStack item = e.getItem();
if (item.getType() != GOAT_HORN) return;
if (p.hasCooldown(GOAT_HORN)) return;

// ...

lyric gyro Sep 2, 2022, 9:09 PM

#

if (item.getType() != GOAT_HORN) return;

#

i am sure this part is not needed

#

well

#

for your code

#

it might be

winged pebble Sep 2, 2022, 9:10 PM

#

It just verifies that the item you're interacting with is in fact a goat horn

lyric gyro Sep 2, 2022, 9:11 PM

#

            if (p.hasCooldown(goatHorn.getType())){
              return;```

#

isnt this good enough

#

?

#

i mean

#

its a mess of parenthesis

#

reminds me of middle school

winged pebble Sep 2, 2022, 9:12 PM

#

Couple reasons I changed things around:

you're calling the ItemStack variable goatHorn but you haven't yet verified that it's type is in fact GOAT_HORN
inverting the check and returning reduces indentation levels and improve readability

lyric gyro Sep 2, 2022, 9:14 PM

#

winged pebble Couple reasons I changed things around: 1. you're calling the ItemStack variable...

tbh if i just keep going this way ill end up making a mess of nested if statements

#

if i do your way

#

I can make an if statement with a bunch of switch statements inside

#

which look nicer

winged pebble Sep 2, 2022, 9:14 PM

#

No, my way eliminates the nesting

lyric gyro Sep 2, 2022, 9:14 PM

#

so I think I'll do your way

#

so i have a system where when you put on a certain block, you get a rainbow glass helmet. it constantly checks if the item on your head has certain nbt data, and if so, continues the loop. the issue, i want it so when you click on your helmet slot with the same item it stops the loop. although i do not know how to do this since they are same exact item. (clicking on rainbow glass helmet currently on head with glass would continue the loop as it would check for nbt data and obviously it would have that since same item).

winged pebble Sep 2, 2022, 9:15 PM

#

These two snippets are functionally the same

Player p = e.getPlayer();
ItemStack item = e.getItem();
if (item.getType() != GOAT_HORN) return;
if (p.hasCooldown(GOAT_HORN)) return;
// do something
``````java
Player p = e.getPlayer();
ItemStack item = e.getItem();
if (item.getType() == GOAT_HORN) {
  if (!p.hasCooldown(GOAT_HORN)) {
    // do something
  }
}
```But which one is easier to read?

lyric gyro Sep 2, 2022, 9:16 PM

#

winged pebble These two snippets are functionally the same ```java Player p = e.getPlayer(); I...

the first one of course

#

less curly braces

#

means more readability

#

                World world = p.getWorld();
                world.spawnEntity(p.getLocation(), EntityType.GOAT);```

#

just gonna

#

put this here

winged pebble Sep 2, 2022, 9:17 PM

#

Also, you should verify that the item isn't null

if (item == null || item.getType() != GOAT_HORN) return;

#

Forgot about that detail

lyric gyro Sep 2, 2022, 9:20 PM

#

@winged pebble

#

        p.setCooldown(GOAT_HORN, 800);
        ItemStack goatHorn = e.getItem();
        if (goatHorn == null || goatHorn.getType() != GOAT_HORN) return;
        if (p.hasCooldown(GOAT_HORN)) return;```

#

much better

winged pebble Sep 2, 2022, 9:21 PM

#

So then after those checks, you can be sure that it is a goat horn

lyric gyro Sep 2, 2022, 9:21 PM

#

holdup

#

instead of p.hascooldown(goat_horn)

#

wouldnt it be better if it was the object goat horn

#

not the material?

winged pebble Sep 2, 2022, 9:21 PM

#

No, because hasCooldown() only accepts a Material

lyric gyro Sep 2, 2022, 9:22 PM

#

will it work the same though?

winged pebble Sep 2, 2022, 9:22 PM

#

It only accepts a Material

lyric gyro Sep 2, 2022, 9:22 PM

#

I know

#

Im asking if your way

#

will it work the same

#

if i use material instead of the itemstack goathorn

winged pebble Sep 2, 2022, 9:22 PM

#

so passing item.getType() on a goat horn or passing in Material.GOAT_HORN is the exact same thing

lyric gyro Sep 2, 2022, 9:22 PM

#

ok

#

so now let me guess

winged pebble Sep 2, 2022, 9:23 PM

#

It only accepts Material, so you literally can't pass in the ItemStack

lyric gyro Sep 2, 2022, 9:23 PM

#

if (goatHorn.getType() = GOAT_HORN){

#

now I just add all the crap that I posted here

#

done

#

now

#

the parameter

#

@winged pebble what do I put there

#

im still not sure about what I should put there

#

oh wait

#

nevermind

#

net.minecraft.world.item.ItemStack nmsHorn = CraftItemStack.asNMSCopy(goatHorn);

#

im so stupid

#

and blind

#

I somehow knew it was this

#

all I had to do was check the quick solutions on intellij

#

lmao

#

now we can finally

#

finally

#

go to the next step

#

the compound

#

I think now I finally have an idea of what i've got to do

#

get the nbt tag with the compound

#

then

#

create an object with the nbt tag

#

and after that

#

switch

#

statements

winged pebble Sep 2, 2022, 9:34 PM

#

Well first you need to identify how you retrieve the specific type of goathorn from the nbt

#

Which is something you'll have to explore yourself

lyric gyro Sep 2, 2022, 9:35 PM

#

winged pebble Which is something you'll have to explore yourself

your free trial as teacher ends here then?

winged pebble Sep 2, 2022, 9:35 PM

#

I can't do everything for you

lyric gyro Sep 2, 2022, 9:35 PM

#

I know

winged pebble Sep 2, 2022, 9:36 PM

#

A big part of learning something new is fumbling with it yourself

lyric gyro Sep 2, 2022, 9:36 PM

#

yes yes

#

I'll try to do it by myself

#

this is hard

#

but I'll get the hang of it

winged pebble Sep 2, 2022, 9:36 PM

#

What I would do is print out the nbt data of the item to see how each goat horn is differentiated

lyric gyro Sep 2, 2022, 9:37 PM

#

just one last question

#

is this a good spot for my net.minecraft.server thingy

#

this is like

#

my first decent plugin

#

I wanted to make it open source

#

so I gotta make it readable

winged pebble Sep 2, 2022, 9:38 PM

#

At that point in the code, has the item been verified as a goat horn?

lyric gyro Sep 2, 2022, 9:38 PM

#

winged pebble At that point in the code, has the item been verified as a goat horn?

not yet

winged pebble Sep 2, 2022, 9:38 PM

#

Then no, not a good place for it

dusky harness Sep 2, 2022, 9:38 PM

#

lyric gyro is this a good spot for my net.minecraft.server thingy

make the variable names event, player, etc

#

instead of e and p

#

also I would put the ... nmsHorn = ... on one line

lyric gyro Sep 2, 2022, 9:39 PM

#

too long idk

#

I think i'll put it where it was before

#

right below getWorld

#

        if (p.hasCooldown(GOAT_HORN)) return;
        if (goatHorn.getType() == GOAT_HORN){

            World world = p.getWorld();
            net.minecraft.world.item.ItemStack nmsHorn = CraftItemStack.asNMSCopy(goatHorn);
            world.spawnEntity(p.getLocation(), EntityType.GOAT);```

#

the code if anyone has any objections

#

i'll also create my compound right below it

dusky harness Sep 2, 2022, 9:40 PM

#

dusky harness make the variable names event, player, etc

this

#

also
nms 🤢

#

but you already have it set up so I won't make a big deal out of it

lyric gyro Sep 2, 2022, 9:41 PM

#

you won't be saying this when you see what i'll do with these goat horns

winged pebble Sep 2, 2022, 9:41 PM

#

If only there was a GoatHornMeta 😛

dusky harness Sep 2, 2022, 9:41 PM

#

winged pebble If only there was a GoatHornMeta 😛

mhm

lyric gyro Sep 2, 2022, 9:41 PM

#

please god

dusky harness Sep 2, 2022, 9:41 PM

#

i wonder why spigot doesn't have it

#

smh md_5

lyric gyro Sep 2, 2022, 9:41 PM

#

this would make my life so much easier

dusky harness Sep 2, 2022, 9:41 PM

#

lyric gyro you won't be saying this when you see what i'll do with these goat horns

you don't need nms for it

lyric gyro Sep 2, 2022, 9:41 PM

#

I do

dusky harness Sep 2, 2022, 9:42 PM

#

nope

lyric gyro Sep 2, 2022, 9:42 PM

#

you know that goat horn that sounds like the THX opening?

#

yeah

#

I wanted to do so when you play it

#

a horde of goats spawn and attack mobs

dusky harness Sep 2, 2022, 9:42 PM

#

well it's not built-in to the spigot api
and this is such a common thing that it's basically documented so in this case it really doesn't matter

dusky harness Sep 2, 2022, 9:43 PM

#

lyric gyro a horde of goats spawn and attack mobs

o

#

💀

lyric gyro Sep 2, 2022, 9:43 PM

#

since

#

it's a goat horn

#

and its the best horn

#

so i figured it would have the best effect

lyric gyro Sep 2, 2022, 9:44 PM

#

lyric gyro it's a goat horn

horns are usually used in army to call a push or something like that

#

so you would be callin your soldiers

#

if people actually download this ill make it into a mod

#

idk how but ig ill try

dusky harness Sep 2, 2022, 9:44 PM

#

you mean plugin?

#

or like fabric/forge

lyric gyro Sep 2, 2022, 9:45 PM

#

forge

dusky harness Sep 2, 2022, 9:45 PM

#

o

lyric gyro Sep 2, 2022, 9:45 PM

#

but

#

that's for a really distant future

#

since afaik

#

spigot doesn't exist in mod creation

#

wait forge is an api right?

#

idk what it is

#

💀

winged pebble Sep 2, 2022, 9:46 PM

#

It's a framework

#

That's how I'd describe it

dusky harness Sep 2, 2022, 9:47 PM

#

using nbt api it'd be ```java
String type = new NBTItem(goatHorn).getString("instrument" /* or whatever the key is */);


I'd say forge/fabric itself are modding "platforms" which also have an API

lyric gyro Sep 2, 2022, 9:47 PM

#

NBTTagCompound hornsCompound = (nmsHorn.hasTag()) ? nmsHorn.getTag() : new NBTTagCompound();

#

Has tag and get tag

#

doesnt exist

dusky harness Sep 2, 2022, 9:48 PM

#

Anyways I've gtg now, cya

lyric gyro Sep 2, 2022, 9:48 PM

#

bye

dusky harness Sep 2, 2022, 9:48 PM

#

bye

winged pebble Sep 2, 2022, 9:49 PM

#

lyric gyro doesnt exist

That's because in 1.17+, they are just letters as names

lyric gyro Sep 2, 2022, 9:49 PM

#

Did they change anything else after 1.17 that I need to know?

#

what are these methods called now

winged pebble Sep 2, 2022, 9:50 PM

#

In 1.17+ they included support for Mojang Mappings

#

Which means the didn't need to manually map things as much anymore

#

So they left a lot of the names obfuscated

dusky harness Sep 2, 2022, 9:52 PM

#

winged pebble In 1.17+ they included support for Mojang Mappings

1.14.4*

#

ok me go bye

#

cya

lyric gyro Sep 2, 2022, 9:52 PM

#

will anyone tell me how do I call these methods or nah

#

bye

winged pebble Sep 2, 2022, 9:52 PM

#

dusky harness 1.14.4*

Not spigot

#

https://nms.screamingsandals.org/1.19/

#

Use this to find what you are looking for

dusky harness Sep 2, 2022, 9:57 PM

#

winged pebble Not spigot

yes spigot

#

screaming sandals has a gradle plugin to easily add multi version support

#

on the page deerjump sent

#

but its best if you keep 1.14.4+ support only or else it gets a little messy since below doesn't have mojang mappings

#

ok afk

lyric gyro Sep 2, 2022, 9:59 PM

#

winged pebble Use this to find what you are looking for

where exactly

winged pebble Sep 2, 2022, 9:59 PM

#

Follow the package

proud pebble Sep 2, 2022, 10:00 PM

#

lyric gyro ```NBTTagCompound hornsCompound = (nmsHorn.hasTag()) ? nmsHorn.getTag() : new NB...

they are named if you use the remapped jar instead of the regular one

#

they are named as such

#

theres a method for getting the tag or a new compoundtag if it doesnt exist

lyric gyro Sep 2, 2022, 10:01 PM

#

winged pebble Follow the package

there are like

#

5 or 6

#

different instances of compoundtag

winged pebble Sep 2, 2022, 10:02 PM

#

Which class does getTag and hasTag come from

lyric gyro Sep 2, 2022, 10:02 PM

#

why you askin me dude

winged pebble Sep 2, 2022, 10:02 PM

#

For your own good

lyric gyro Sep 2, 2022, 10:03 PM

#

            NBTTagCompound hornsCompound = (nmsHorn.hasTag()) ? nmsHorn.getTag() : new NBTTagCompound();```

winged pebble Sep 2, 2022, 10:03 PM

#

So hasTag and getTag belong to which class?

proud pebble Sep 2, 2022, 10:03 PM

#

itemstack

#

getOrCreateTag() exists btw

lyric gyro Sep 2, 2022, 10:04 PM

#

then why is the ide giving me an error

#

it says it cant resolve getTag or hasTag

#

in itemstack

winged pebble Sep 2, 2022, 10:04 PM

#

Because they are obfuscated for you

proud pebble Sep 2, 2022, 10:05 PM

#

Because your using the obfuscated jar, not the remapped version

winged pebble Sep 2, 2022, 10:05 PM

#

So use the link I sent to see the connection between the obfuscated names and the normal names

lyric gyro Sep 2, 2022, 10:05 PM

#

are you fucking KIDDING ME

winged pebble Sep 2, 2022, 10:05 PM

#

Or you can learn how to use the remapped jar

proud pebble Sep 2, 2022, 10:05 PM

#

with the regular spigot jar you have to deal with obfucated names

lyric gyro Sep 2, 2022, 10:05 PM

#

i will get used to it

#

i mean

dusky harness Sep 2, 2022, 10:06 PM

#

The Father

#

I am back

#

do you use gradle

lyric gyro Sep 2, 2022, 10:06 PM

#

maven

proud pebble Sep 2, 2022, 10:06 PM

#

tbh the remapped jar makes life so much easier

dusky harness Sep 2, 2022, 10:06 PM

#

Oh okay

#

then bye bye

lyric gyro Sep 2, 2022, 10:06 PM

#

bye

lyric gyro Sep 2, 2022, 10:06 PM

#

proud pebble tbh the remapped jar makes life so much easier

do I have to reinstall spigot

#

im not going to

proud pebble Sep 2, 2022, 10:07 PM

#

lyric gyro do I have to reinstall spigot

https://github.com/lunaiskey/LunixDev/blob/master/pom.xml

GitHub

LunixDev/pom.xml at master · lunaiskey/LunixDev

For testing stuff. Contribute to lunaiskey/LunixDev development by creating an account on GitHub.

lyric gyro Sep 2, 2022, 10:07 PM

#

winged pebble So use the link I sent to see the connection between the obfuscated names and th...

that's what I am trying to do

proud pebble Sep 2, 2022, 10:08 PM

#

look at this pom file, it has the md5 plugin and the extra text in the spigot dependancy thats required for remapped

#

all you have to do other then that is run buildtools with --remapped at the end

lyric gyro Sep 2, 2022, 10:09 PM

#

I have two spigot servers, do I have to do anything to them?

#

what is the primary difference between ofuscated and remapped

proud pebble Sep 2, 2022, 10:09 PM

#

it still works in 1.19.2, you just have to change the 1.18.2 to 1.19.2

lyric gyro Sep 2, 2022, 10:10 PM

#

im using 1.19

proud pebble Sep 2, 2022, 10:10 PM

#

lyric gyro what is the primary difference between ofuscated and remapped

the difference is in the ide only really, the md5 plugin is used to reobfuscate the code to be useable on servers

proud pebble Sep 2, 2022, 10:10 PM

#

lyric gyro im using 1.19

works for 1.19 too

lyric gyro Sep 2, 2022, 10:11 PM

#

all I have to do is run buildtools with --remapped at the end

#

and thats it?

proud pebble Sep 2, 2022, 10:11 PM

#

you have to reobfuscate for it to be useable

#

which is what the md5 plugin does.

#

to use the remapped jar just make the changes thats shown in the pom.xml i linked

lyric gyro Sep 2, 2022, 10:12 PM

#

cant i just paste whats in that file in my pom.xml file and make the few needed changes for my version

#

and run buildtools again

#

?

proud pebble Sep 2, 2022, 10:13 PM

#

you dont want to copy and paste my xml

lyric gyro Sep 2, 2022, 10:13 PM

#

hm

proud pebble Sep 2, 2022, 10:13 PM

#

copy and paste some, not all

#

22 to 54

lyric gyro Sep 2, 2022, 10:14 PM

#

can you send here what lines I need to change while I rerun buildtools?

proud pebble Sep 2, 2022, 10:14 PM

#

101 to 107

lyric gyro Sep 2, 2022, 10:14 PM

#

or

#

do I have to change the pom file first

proud pebble Sep 2, 2022, 10:14 PM

#

im telling you what to copy from my pom.xml tonyour pom.xml

lyric gyro Sep 2, 2022, 10:15 PM

#

what do I have to do first

#

or it doesnt matter the order

wintry grove Sep 2, 2022, 10:15 PM

#

Imagine using maven

lyric gyro Sep 2, 2022, 10:15 PM

#

couldnt be me

proud pebble Sep 2, 2022, 10:16 PM

#

copy 22-54 then copy 101-107

lyric gyro Sep 2, 2022, 10:16 PM

#

proud pebble 22 to 54

what this is to be exact

#

there is no 22 in my pom file

#

or 101

#

oh no

#

lMAO

proud pebble Sep 2, 2022, 10:17 PM

#

22-54 and 101-107, line numbers

lyric gyro Sep 2, 2022, 10:17 PM

#

Those are the lines

#

LMAO

#

im dumb

proud pebble Sep 2, 2022, 10:17 PM

#

then replace the 1.18.2 with 1.19

lyric gyro Sep 2, 2022, 10:17 PM

#

so I just put lines 22-54 in the same place?

proud pebble Sep 2, 2022, 10:18 PM

#

to your run.bat add --remapped to the end

lyric gyro Sep 2, 2022, 10:18 PM

#

ok

#

so

#

I'll do that

proud pebble Sep 2, 2022, 10:19 PM

#

lyric gyro so I just put lines 22-54 in the same place?

22-54 you dont replace, you just paste

#

then with 101 to 107 you replace your old with the new

lyric gyro Sep 2, 2022, 10:20 PM

#

Plugin 'net.md-5:specialsource-maven-plugin:1.2.2' not found

#

3 errors

#

all of them are this

proud pebble Sep 2, 2022, 10:20 PM

#

post the pom.xml

#

your

#

to helpchat paste

#

im on mobile, i cant see that

lyric gyro Sep 2, 2022, 10:22 PM

#

https://paste.helpch.at/igoceziway.xml

proud pebble Sep 2, 2022, 10:23 PM

#

you didnt change the 1.18.2 to 1.19

#

33 35 48 49

#

lines

lyric gyro Sep 2, 2022, 10:24 PM

#

i did just that now

#

the errors are still there

proud pebble Sep 2, 2022, 10:25 PM

#

weird

lyric gyro Sep 2, 2022, 10:25 PM

#

Plugin 'net.md-5:specialsource-maven-plugin:1.2.2' not found

proud pebble Sep 2, 2022, 10:25 PM

#

did you create the remapped jar with buildtools?

lyric gyro Sep 2, 2022, 10:25 PM

#

i still havent done that

proud pebble Sep 2, 2022, 10:25 PM

#

that will be why

lyric gyro Sep 2, 2022, 10:25 PM

#

ok

lyric gyro Sep 2, 2022, 10:27 PM

#

proud pebble that will be why

I'm done fixing the pom file

#

replaced lines 101 to 107

#

and changed the version

#

so now i'll run buildtools again

lyric gyro Sep 2, 2022, 10:29 PM

#

proud pebble to your run.bat add --remapped to the end

can you

#

explain to me how do I start buildtools again

#

I keep forgetting

#

I think I need to open a git bash

#

i cant remember that well

proud pebble Sep 2, 2022, 10:29 PM

#

you didnt create a bat file?

lyric gyro Sep 2, 2022, 10:29 PM

#

I think I just used git to run buildtools

#

since the bat file method wasnt working for me

proud pebble Sep 2, 2022, 10:31 PM

#

theres a spigotmc page on running buildtools

lyric gyro Sep 2, 2022, 10:31 PM

#

ik ik

proud pebble Sep 2, 2022, 10:31 PM

#

i think you just need the latest version of java running to use the bat file

grand zodiac Sep 2, 2022, 10:31 PM

#

    @Override
    public void onEnable() {
        getCommand("heal").setExecutor(new Heal());
        getCommand("feed").setExecutor(new Feed());
        getCommand("day").setExecutor(new Day());
        getCommand("time").setExecutor(new Time());
        getCommand("day").setExecutor(new Day());
        getCommand("noon").setExecutor(new Noon());
        getCommand("sunset").setExecutor(new Sunset());
        getCommand("night").setExecutor(new Night());
        getCommand("midnight").setExecutor(new Midnight());
        getCommand("sunrise").setExecutor(new Sunrise());
        getCommand("weather").setExecutor(new Weather());
        getCommand("sun").setExecutor(new Sun());
        getCommand("rain").setExecutor(new Rain());
        getCommand("gamemode").setExecutor(new Gamemode());
        getCommand("gmc").setExecutor(new Gmc());
        getCommand("gms").setExecutor(new Gms());
        getCommand("gmsp").setExecutor(new Gmsp());
        getCommand("gma").setExecutor(new Gma());
        getCommand("kill").setExecutor(new Kill());

        getServer().getPluginManager().registerEvents(new JoinLeaveListener(), this);
    }```

Anyone got suggestions on how I could compact this code and make it less messy?

winged pebble Sep 2, 2022, 10:32 PM

#

Doesn't really look that messy to me tbh

lyric gyro Sep 2, 2022, 10:32 PM

#

proud pebble i think you just need the latest version of java running to use the bat file

so

#

I just gotta create a bat file

#

with java -jar BuildTools.jar --rev 1.19 -- (i forgot what to put here)

#

and run it

proud pebble Sep 2, 2022, 10:32 PM

#

remapped

lyric gyro Sep 2, 2022, 10:32 PM

#

yeah

#

thats all?

proud pebble Sep 2, 2022, 10:33 PM

#

yep

lyric gyro Sep 2, 2022, 10:33 PM

#

k

proud pebble Sep 2, 2022, 10:33 PM

#

then you just update NBTTagCompound to CompoundTag and you should be good

lyric gyro Sep 2, 2022, 10:33 PM

#

wow

#

it instantly closed

#

amazing

proud pebble Sep 2, 2022, 10:34 PM

#

pause on the line below it

lyric gyro Sep 2, 2022, 10:34 PM

#

troubleshooting time

proud pebble Sep 2, 2022, 10:34 PM

#

write pause

#

itll stop it from closing instantly

lyric gyro Sep 2, 2022, 10:34 PM

#

are youf ucking kidding me

proud pebble Sep 2, 2022, 10:34 PM

#

no?

lyric gyro Sep 2, 2022, 10:34 PM

#

its because the run file is using java 8

#

instead of the java 17 i have installed

#

specifically for newer versions of minecraft

#

dont worry ik what i need to do

proud pebble Sep 2, 2022, 10:35 PM

#

yep

#

makesnsense

grand zodiac Sep 2, 2022, 10:35 PM

#

winged pebble Doesn't really look that messy to me tbh

Well if I add 100 commands which knowing the nature of the plugin I'm making I probably will before publishing it on SpigotMC, it'll look quite messy

#

Maybe not messy but just

#

Cluttered

#

So I'd like to compact it a little

lyric gyro Sep 2, 2022, 10:36 PM

#

uh

winged pebble Sep 2, 2022, 10:36 PM

#

Having 100 commands in a single plugin seems unlikely tbh

lyric gyro Sep 2, 2022, 10:36 PM

#

proud pebble makesnsense

proud pebble Sep 2, 2022, 10:36 PM

#

grand zodiac ```java @Override public void onEnable() { getCommand("heal").se...

java.exe

#

oops

#

wrong person

lyric gyro Sep 2, 2022, 10:36 PM

#

e
c

if you are wondering

#

oh yeah

#

forgot the .exe

#

still

#

it isnt working

#

wait

proud pebble Sep 2, 2022, 10:37 PM

#

hepto, id move all command registering to a seperate method like registerCommands()

lyric gyro Sep 2, 2022, 10:38 PM

#

im trying to run

#

buildtools

#

in a folder where i already ran buildtools

#

for the exact same version

#

thats why it isnt working

#

lmao

proud pebble Sep 2, 2022, 10:38 PM

#

doesnt matter afaik

lyric gyro Sep 2, 2022, 10:39 PM

#

yeah

#

thats not the reason

proud pebble Sep 2, 2022, 10:39 PM

#

whats the error when it attempts to build?

lyric gyro Sep 2, 2022, 10:39 PM

#

could not find or load main class

#

java.lang.classNotFoundException

proud pebble Sep 2, 2022, 10:40 PM

#

java.exe in the "" bit

#

remove the second java

#

otherwise its just like saying java java

lyric gyro Sep 2, 2022, 10:41 PM

#

yeah

#

that was the problem

#

i did this a few days ago

#

to run spigot on this version

#

to develop this plugin

#

now its building

grand zodiac Sep 2, 2022, 10:42 PM

#

proud pebble hepto, id move all command registering to a seperate method like registerCommand...

true, ty

lyric gyro Sep 2, 2022, 10:42 PM

#

wait @proud pebble

#

i have two versions of buildtools for 1.19

#

will this make a difference

#

or cause an error

proud pebble Sep 2, 2022, 10:42 PM

#

no?

#

no

#

it wont

lyric gyro Sep 2, 2022, 10:43 PM

#

it will only use the remapped version right

#

?

proud pebble Sep 2, 2022, 10:43 PM

#

tho id just delete both and redownload buildtools cus atleast its updated

lyric gyro Sep 2, 2022, 10:43 PM

#

proud pebble Sep 2, 2022, 10:43 PM

#

lyric gyro it will only use the remapped version right

yes since you told it to just use the remapped

#

huh

lyric gyro Sep 2, 2022, 10:44 PM

#

lyric gyro Sep 2, 2022, 10:46 PM

#

proud pebble huh

whats wrong

proud pebble Sep 2, 2022, 10:49 PM

#

copy the error into google

#

cus that should be working

#

unless im blind

#

update buildtools ig?

#

cus that might be why

lyric gyro Sep 2, 2022, 10:53 PM

#

proud pebble update buildtools ig?

i'll check

#

@proud pebble

#

I opened intellij

#

something was telling me to do it

#

and the 3 errors disappeared

#

and

#

getTag and hasTag

#

now exist

#

oh wait

#

now its telling me that

#

NBTTagCompound doesnt exist

#

cannot resolve symbol

winged pebble Sep 2, 2022, 11:01 PM

#

CompoundTag

#

Just look at the return type of getTag

lyric gyro Sep 2, 2022, 11:01 PM

#

done

#

now im set up ig

#

next step

#

@winged pebble

#

I'm not sure what I've got to do

#

I think I forgot

#

just say the next steps

proud pebble Sep 2, 2022, 11:12 PM

#

String hornSound = hornsCompound.getString("instrument");

lyric gyro Sep 2, 2022, 11:13 PM

#

proud pebble `String hornSound = hornsCompound.getString("instrument");`

so what this is

#

it's a string called hornsound

#

that gets instrument

#

which is like

#

the nbt tag?

#

I like to understand my code before I write it

proud pebble Sep 2, 2022, 11:14 PM

#

there are 8 types of goat horn sound right

#

this gets what is on the item

lyric gyro Sep 2, 2022, 11:15 PM

#

well what I wanted to do

#

is add a switch statement

#

that triggers a specific condition

#

when a specific horn is sounded

#

but for this

#

I need to know what the nbt tag looks like

#

right?

proud pebble Sep 2, 2022, 11:16 PM

#

switch(hornSound)

#

https://minecraft.fandom.com/wiki/Goat_Horn

Minecraft Wiki

Goat Horn

A goat horn is an item dropped by goats. It has eight variants, and each plays a unique sound when used which can be heard by players in a large radius.

#

scroll down to item data

#

itll show you every case

#

if you wanna know what the nbt looks like then use a nbt tooltip mod

lyric gyro Sep 2, 2022, 11:18 PM

#

                case("ponder_goat_horn")```

#

like this?

proud pebble Sep 2, 2022, 11:19 PM

#

thats not how switch statements work

#

close

lyric gyro Sep 2, 2022, 11:19 PM

#

how do they work then

#

im asking if the string is correct

proud pebble Sep 2, 2022, 11:20 PM

#

case "ponder_goat_horn" -> {
yourcodehere
}

lyric gyro Sep 2, 2022, 11:20 PM

#

of course I know how switch statements work smh

#

im just asking if the string name is correct

#

if I played the ponder horn

#

would it execute whats in there?

proud pebble Sep 2, 2022, 11:21 PM

#

if you are unsure, printbthe result of goatSound to either yourself or console

#

its what id do

lyric gyro Sep 2, 2022, 11:22 PM

#

proud pebble if you are unsure, printbthe result of goatSound to either yourself or console

if you are saying this then you are unsure

proud pebble Sep 2, 2022, 11:23 PM

#

im sure thats right

#

but to confirm it, do what i said

lyric gyro Sep 2, 2022, 11:24 PM

#

wait

#

https://paste.helpch.at/rukadiwixi.java

#

here's the whole thing

proud pebble Sep 2, 2022, 11:26 PM

#

ok?

lyric gyro Sep 2, 2022, 11:26 PM

#

proud pebble Sep 2, 2022, 11:27 PM

#

first

lyric gyro Sep 2, 2022, 11:27 PM

#

which one of these

#

ok

proud pebble Sep 2, 2022, 11:29 PM

#

you dont need the brackets in case

lyric gyro Sep 2, 2022, 11:29 PM

#

no shit

proud pebble Sep 2, 2022, 11:32 PM

#

then why do it?

lyric gyro Sep 2, 2022, 11:35 PM

#

proud pebble then why do it?

probably did it by accident

#

anyways

#

it didn't work

#

                case("ponder_goat_horn"):
                    world.spawnEntity(p.getLocation(), EntityType.GOAT);
            }```

#

are you sure its really "ponder_goat_horn"

proud pebble Sep 2, 2022, 11:36 PM

#

are you going to even try debug it?

wintry grove Sep 2, 2022, 11:36 PM

#

thats not how switch's work

#

at leaast the case part

#

it doesnt use parenthesis iirc

lyric gyro Sep 2, 2022, 11:37 PM

#

proud pebble are you going to even try debug it?

what does debugging do

lyric gyro Sep 2, 2022, 11:37 PM

#

wintry grove it doesnt use parenthesis iirc

i dont think it makes a difference

proud pebble Sep 2, 2022, 11:38 PM

#

lyric gyro what does debugging do

you figure out what went wrong

lyric gyro Sep 2, 2022, 11:39 PM

#

proud pebble you figure out what went wrong

tbh

#

im skeptical about the "ponder_goat_horn" part

proud pebble Sep 2, 2022, 11:39 PM

#

then print hornSound

lyric gyro Sep 2, 2022, 11:40 PM

#

in chat or console

proud pebble Sep 2, 2022, 11:40 PM

#

does it matter? you will figure it out either way

lyric gyro Sep 2, 2022, 11:40 PM

#

yeah

#

ill do it on chat

proud pebble Sep 2, 2022, 11:40 PM

#

its what i normally do

lyric gyro Sep 2, 2022, 11:41 PM

#

when this shit work

#

ill be the happiest man alive

#

bold of me to assume it will work

lyric gyro Sep 2, 2022, 11:44 PM

#

proud pebble its what i normally do

yeah it doesnt work

proud pebble Sep 2, 2022, 11:46 PM

#

so no output?

#

code?

lyric gyro Sep 2, 2022, 11:50 PM

#

proud pebble code?

https://paste.helpch.at/hohedocova.java

#

i play the goat horn

#

and nothing else happens

viral moth Sep 2, 2022, 11:50 PM

#

what is the output in your chat?

lyric gyro Sep 2, 2022, 11:51 PM

#

it was supposed to be

#

"Tá certo" and output the horn name or something like that

#

and spawn a goat

viral moth Sep 2, 2022, 11:51 PM

#

one of your if statements are preventing it

lyric gyro Sep 2, 2022, 11:51 PM

#

lyric gyro and spawn a goat

if you played ponder, specifically

lyric gyro Sep 2, 2022, 11:51 PM

#

viral moth one of your if statements are preventing it

which one

viral moth Sep 2, 2022, 11:51 PM

#

idk

#

debug it

#

just send a message to the player after each if statement to figure out how far it can get

proud pebble Sep 2, 2022, 11:52 PM

#

stick a sendmessage in every step of the if statements

#

also the 3rd one is uses

#

useless

lyric gyro Sep 2, 2022, 11:53 PM

#

proud pebble also the 3rd one is uses

the third if statement?

proud pebble Sep 2, 2022, 11:54 PM

#

yes, the third one, you already checked if the item wasnt null or wasnt a goathorn and returned

viral moth Sep 2, 2022, 11:54 PM

#

also, why are you doing if statements differently?

if (goatHorn == null || goatHorn.getType() != GOAT_HORN) return;
        if (p.hasCooldown(GOAT_HORN)) return;
        if (goatHorn.getType() == GOAT_HORN){```

your first 2 are fine, but since the last if statement doesnt have an else clause, why not just do the following

```if (goatHorn.getType() != GOAT_HORN) return;```

it wont affect how your code performs/what happens, but it makes it a lot easier to read without extra indentations

lyric gyro Sep 2, 2022, 11:54 PM

#

proud pebble yes, the third one, you already checked if the item wasnt null or wasnt a goatho...

thats why it isnt working

viral moth Sep 2, 2022, 11:54 PM

#

no

lyric gyro Sep 2, 2022, 11:56 PM

#

viral moth no

if the third if statement cant be executed

#

because it already returned

#

the whole code cant run

viral moth Sep 2, 2022, 11:56 PM

#

the first if statement and the 3rd one check the same thing, the 3rd one is completely redundant, but it isnt causing problems

viral moth Sep 2, 2022, 11:57 PM

#

lyric gyro because it already returned

well if the condition is false, then that's what should happen

#

oh

#

i found the issue

#

p.setCooldown(GOAT_HORN, 800);

#

if (p.hasCooldown(GOAT_HORN)) return;

#

you give them a cooldown and then check if they have a cooldown

lyric gyro Sep 2, 2022, 11:58 PM

#

wait

viral moth Sep 2, 2022, 11:58 PM

#

which they always will, since you are setting them on cooldown

lyric gyro Sep 2, 2022, 11:58 PM

#

this method isnt for checking if the item has a cooldown before you use it?

#

like

#

bruh

proud pebble Sep 2, 2022, 11:59 PM

#

you set the cooldown, check if the cooldown exists and return

lyric gyro Sep 2, 2022, 11:59 PM

#

hold up

proud pebble Sep 2, 2022, 11:59 PM

#

so you should set the cooldown after

lyric gyro Sep 3, 2022, 12:00 AM

#

like

#

above the world object?

#

where would you place it

viral moth Sep 3, 2022, 12:00 AM

#

at the end

#

very end would be best

proud pebble Sep 3, 2022, 12:00 AM

#

like right at the end

viral moth Sep 3, 2022, 12:00 AM

#

but

#

it just has to be after the check

proud pebble Sep 3, 2022, 12:01 AM

#

otherwise you cancelled out all your code

viral moth Sep 3, 2022, 12:01 AM

#

but still it should be at the end, because logically you go on cooldown after something has happened, wont affect how anything works but is a good practice

lyric gyro Sep 3, 2022, 12:01 AM

#

after the switch statements then?

#

#

i just put it here

viral moth Sep 3, 2022, 12:03 AM

#

put a break statement in your switch

lyric gyro Sep 3, 2022, 12:03 AM

#

k

#

i hope it works

#

also

#

I have another issue

#

when I use the horn

#

it goes on a 20 second cooldown

#

like I intended

#

but

#

If I try to use it again during the cooldown

#

it just resets it

#

why

viral moth Sep 3, 2022, 12:04 AM

#

send your code

lyric gyro Sep 3, 2022, 12:05 AM

#


import net.minecraft.nbt.CompoundTag;
import org.bukkit.World;
import org.bukkit.craftbukkit.v1_19_R1.inventory.CraftItemStack;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import static org.bukkit.Material.*;

public class Listeners implements Listener {


    @EventHandler
    public void usedGoatHorn (PlayerInteractEvent e){

        Player p = e.getPlayer();
        ItemStack goatHorn = e.getItem();

        if (goatHorn == null || goatHorn.getType() != GOAT_HORN) return;
        if (p.hasCooldown(GOAT_HORN)) return;
        if (goatHorn.getType() == GOAT_HORN){

            World world = p.getWorld();

            net.minecraft.world.item.ItemStack nmsHorn = CraftItemStack.asNMSCopy(goatHorn);
            CompoundTag hornsCompound = (nmsHorn.hasTag()) ? nmsHorn.getTag() : new CompoundTag();
            String hornSound = hornsCompound.getString("instrument");

            p.sendMessage(hornSound);
            switch(hornSound){
                case "ponder_goat_horn":
                    world.spawnEntity(p.getLocation(), EntityType.GOAT);
                    p.sendMessage("Tá certo.");
                    break;
            }



        }

        p.setCooldown(GOAT_HORN, 800);
        }


    }

viral moth Sep 3, 2022, 12:06 AM

#

not sure tbh

lyric gyro Sep 3, 2022, 12:06 AM

#

my guess

#

it was because the set cooldown wasn't in the right place

#

watching rick and morty while starting my server

dusky harness Sep 3, 2022, 12:07 AM

#

lyric gyro ```package me.systemoutprintln.dev.hornspawn.listeners; import net.minecraft.nb...

try making it so that if they have the cooldown, instead of just returning, cancel the event and return

lyric gyro Sep 3, 2022, 12:07 AM

#

hope my 4 gigs of ram can handle it lmao

lyric gyro Sep 3, 2022, 12:07 AM

#

dusky harness try making it so that if they have the cooldown, instead of just returning, canc...

ill try to do that

#

what do i use to cancel the event

dusky harness Sep 3, 2022, 12:08 AM

#

e.setCancelled(true) (also I'd recommend not naming variables one letter)

lyric gyro Sep 3, 2022, 12:09 AM

#

dusky harness try making it so that if they have the cooldown, instead of just returning, canc...

actually

#

I was right

dusky harness Sep 3, 2022, 12:09 AM

#

watching rick and morty while starting my server
?

#

Oh

#

oh I didn't see the message above it

lyric gyro Sep 3, 2022, 12:09 AM

#

the setcooldown just wasnt in the right place

dusky harness Sep 3, 2022, 12:09 AM

#

lol

#

if you're using IntelliJ press ctrl alt L

lyric gyro Sep 3, 2022, 12:09 AM

#

dusky harness > watching rick and morty while starting my server ?

sometimes I watch it on hbo max

lyric gyro Sep 3, 2022, 12:09 AM

#

dusky harness if you're using IntelliJ press ctrl alt L

what does it do

dusky harness Sep 3, 2022, 12:09 AM

#

format the code

lyric gyro Sep 3, 2022, 12:11 AM

#

the only thing is that it isn't spawning the goat and sending the chat message when i use the ponder horn

#

but I think I know why

#

ITS WORKING

#

FINALLY

lyric gyro Sep 3, 2022, 12:39 AM

#

why strength doesnt show up on potion effect type?

#

i think its cause its increase damage

#

weird

lyric gyro Sep 3, 2022, 12:56 AM

#

i kinda have a problem

#

I made it so that when you play a goat horn

#

it gives you a potion effect

#

like

#

if you play ponder it gives you absorption

#

but

#

when you play it

#

the effect just disappears a second after

#

wait

#

wait wait wait wait wait

#

are you telling me that

#

it's not based on seconds

#

but ticks

#

p.addPotionEffect(new PotionEffect(PotionEffectType.DAMAGE_RESISTANCE, 15, 1));

#

like this

#

that 15

#

is supposed to be 15 seconds

#

not ticks

#

ohhh

#

hold up gonna count tick by tick by hand

shell moon Sep 3, 2022, 1:16 AM

#

Cancelling the damage event still makes the "hit no damage" sound to the client in new versions

#

someone knows if that exists in legacy versions too?

lyric gyro Sep 3, 2022, 1:17 AM

#

lyric gyro if you play ponder it gives you absorption

I still have a problem though

#

The effect is activating even when you click with the left hand

#

you dont need to click with the right hand

shell moon Sep 3, 2022, 1:18 AM

#

what? whats your issue?

#

effect happening with both hands, both clicks, or what?

lyric gyro Sep 3, 2022, 1:19 AM

#

shell moon effect happening with both hands, both clicks, or what?

Well

#

Basically

#

If you play a goat horn (right click that is)

#

It will give you a potion effect

#

but if you click with the left hand

#

You won't play the horn

#

but it will still give you the effect

#

because both things are player interact event I believe

#

But I don't know how to solve this

shell moon Sep 3, 2022, 1:21 AM

#

"if you click with left hand"?

lyric gyro Sep 3, 2022, 1:21 AM

#

shell moon "if you click with left hand"?

oh

#

sorry

#

I meant

#

If you click with the left mouse button

shell moon Sep 3, 2022, 1:21 AM

#

why not checking which action it is then?

lyric gyro Sep 3, 2022, 1:22 AM

#

can I do that?

shell moon Sep 3, 2022, 1:22 AM

#

yes you can

#

read the methods available in the event

#

and you'll see the options

#

(and what others things you can do)

lyric gyro Sep 3, 2022, 1:23 AM

#

is it getAction?

shell moon Sep 3, 2022, 1:23 AM

#

yes

lyric gyro Sep 3, 2022, 1:24 AM

#

shell moon yes

hmmm

#

let me see

#

Idk how to write this line of code

#

how would it look like

#

oh

#

hold up

#

@shell moon

#

nvm i still need help

#

idk how to type this out

shell moon Sep 3, 2022, 1:28 AM

#

How?

#

exactly what you said

#

getAction

#

compare the action with what you want (or what you dont want)

#

if doesnt matter, return;

#

otherwise continue with your code

lyric gyro Sep 3, 2022, 1:29 AM

#

ik ik

shell moon Sep 3, 2022, 1:29 AM

#

CL5_Hmmm

lyric gyro Sep 3, 2022, 1:29 AM

#

do I have to import anything?

#

like create an object named action

shell moon Sep 3, 2022, 1:30 AM

#

indeed you have to

lyric gyro Sep 3, 2022, 1:30 AM

#

yeah

shell moon Sep 3, 2022, 1:30 AM

#

if what getAction returns something

lyric gyro Sep 3, 2022, 1:30 AM

#

cause when I do, it asks me to import block action

shell moon Sep 3, 2022, 1:30 AM

#

you need to check that

#

lets say Block#getType returns Material

#

then when you compare you use block.getType() == Material.STONE

#

you need to do something similar with getAction

#

check what it returns, and compare to the available options there

#

its enum

lyric gyro Sep 3, 2022, 1:32 AM

#

yo

#

why isnt the ide allowing me to use || in my if statement

shell moon Sep 3, 2022, 1:33 AM

#

¯_(ツ)_/¯

cinder forum Sep 3, 2022, 1:33 AM

#

lyric gyro why isnt the ide allowing me to use || in my if statement

send code

lyric gyro Sep 3, 2022, 1:33 AM

#

        if (p.hasCooldown(GOAT_HORN)) return;
        if (goatHorn.getType() == GOAT_HORN){

            World world = p.getWorld();
            Action action = e.getAction();
            if (action == Action.LEFT_CLICK_AIR || Action.LEFT_CLICK_BLOCK) return;```

#

ignore that first part