WyRIM - Better Bank UI

[winter gate]

Lets make a thread ig

[steel sable]

bookmarking

[winter gate]

so things i am thinking of adding are: tabs for saved searches, more filters i.e > and < for stats, sorting and merging same items into a single stack

btw, the mod is open source too 😎
https://github.com/encodeous/WyRIM

[hot shard]

would be awesome if you pr into artemis

[winter gate]

yah, thats smth im thinking about for the future

[scarlet escarp]

Holy moly this looks amazing

Just being able to use the scroll wheel to go up and down would be fantastic

[winter gate]

WyRIM - Better Bank UI

improved the search function :)

[steel sable]

nice!

[mortal swift]

This looks so good

[winter gate]

thanks! :D

[mortal swift]

I can't seem to compile it myself

Using SDK 18.0.1 and Gradle 8.1, it still considers it to be an older version of both despite of me setting it to act on a per-project basis

[winter gate]

whats the error?

also with the current revision, the mod cant actually store or retrieve any items from the bank. need to do a little bit of mapping between the bank ui and the new ui

@mortal swift

[mortal swift]

Error's simply that the project is using an outdated Gradle and Java version

Do you not simply have the jar to dist? 👀

[winter gate]

i didnt publish any jars yet, cuz its not ready to be actually used XD

but i can send a jar if you'd like

just to experience the powah 😈

[mortal swift]

Yes please

Maybe I can find some bugs and/or contribute on git

[winter gate]

sure

[winter gate]

also, the project uses java 17 since thats newest LTS that minecraft supports

[mortal swift]

It's a local issue from my side

I'll figure it out later

[winter gate]

here ya go

requires wynntils to be installed

[mortal swift]

Of course

[winter gate]

lol

if you want to access your bank normally, just hold shift while interacting

[mortal swift]

Oh that's awesome

How does storing work? Won't it mess up my pages?

[winter gate]

it doesnt yet 💀

but the way im thinking right now, is that it will find the first slot that it can go to

[mortal swift]

Oh I thought it was just temp brokey

I gotcha

[winter gate]

theres a lot of work that still needs to be done 😅

the mod was just started a few days ago :P

[mortal swift]

I'm very impressed so far then

[winter gate]

:D

[obsidian wyvern]

just a note that your whole project has to be lpgl3 if you depend on artemis, not the "included" parts only @winter gate

to be honest i still dont understand why you develop this as a separate mod but with basically wynntils' code style

i know it is wise to not try to contribute such big changes to new projects but it also has it's benefits

[obsidian wyvern]

also i wouldnt spend much time on that search function since there is pretty much a PR for that already

https://github.com/Wynntils/Artemis/pull/1860

it is kind of accepted, just final touchups needed

[winter gate]

heyo o/

[obsidian wyvern]

i would also like to state that i don't have any bad intentions with what im saying here, just trying to be as productive as possible for both of us

[winter gate]

this is kinda iffy, i could do a MIT and LGPL dual license, in addition, the dependency is dynamic so theres some clauses about that

[obsidian wyvern]

yeah i don't know the full license, neither do i care about it deeply. just wanting to let you know thats my understanding of it. I personally dont plan to take any action against it, whatever it is

[winter gate]

👍

[obsidian wyvern]

i like the idea though, i want(ed) to do something like this for TM a while back

but in a rather different way

[winter gate]

:o

[obsidian wyvern]

I would like to break away from MC containers partially and have a fully custom screen, seeing sell-slots in the same page as TM, advanced filters, etc

It is ulimately a very big project to work on which I never had motivation to start, and even if I did, I most likely would not finish it.

[winter gate]

also, this is just so that i can develop this out in my own way without being bogged down by different requirements. if the mod matures enough and gains enough traction i may decide to port it to wynntils

[winter gate]

yeahh, these things tend to snowball a little XD

right now im having to implement a dependency sorting algorithm to track item movements 💀

[obsidian wyvern]

Maintaining wynntils is a lot of time already.. and I have a half-finished project already..

[obsidian wyvern]

dependecy sorting?

[winter gate]

so right now the mod uses the idea of a virtual inventory

[obsidian wyvern]

this same thing can actually backfire since porting a lot of code is harder

[winter gate]

the inventory isnt backed on the server for obvious reasons

so the mod has to apply the diff changes between what the user interacted with in the ui and what is in the bank

there are a lot of edge cases, like item stack splitting, merging, moving across bank pages etc

so its easier to implement it using a graph

and apply graph dependency sorting :)

[winter gate]

i suppose, but i'd much rather to get this out there than to hassle with the existing codebase

i have limited time, and as a hobby project i just want to get it done 😅

[obsidian wyvern]

yeah i see that

[winter gate]

im open to suggestions ofc ;)

[obsidian wyvern]

either way, have fun with it. it sounds fun, kind of gives me ae2 vibes.

[winter gate]

xD

[obsidian wyvern]

well i wouldn't go and try to apply all changes at once

you are almost guranteed that wynn won't work at some point (thanks wynn bot for filtering me)

when i do custom screens like this, i always try to maintain the state of my custom screen on the actual gui

that way the screen is only a wrapper

[winter gate]

hmmm i see

[winter gate]

has this happened with wynntils components?

[obsidian wyvern]

wynn not working like it does? a lot of times 🙂 some weird screen desync? i dont remember, although we didnt go with an approach like yours ever I think

with all things it can be worth trying but i wouldn't put much effort into it

actually, yes, we had experinced a a TON of weirdness.. now that i think about it

[winter gate]

i thought about this- for other parts of the game i think its more practical to work around wynn. but i want to try to fundamentally change how the bank works

might not work ™️

[obsidian wyvern]

I can give you a present example: content book parsing is slow because scrolling the filter in "next" direction sends packets in a different way than scrolling in "previous" direction does

[winter gate]

ooh, it'd be amazing if you can share some of ur past trauma 😎

gg

[obsidian wyvern]

and our container query system cant handle previous scrolling for that reason

so we are stuck with slow queries

i am sure there is a sane way for it to work but we were too tired to get it work

[winter gate]

XD

[obsidian wyvern]

at that point we've been spending days on debugging 2.0.3 content book timeouts for random people

only random people got it. I got it once for a single afternoon

ALL my queries failed, then when it fixed itself, none did.

[winter gate]

yeahh, sometimes its not worth getting that extra 30% of speed

[obsidian wyvern]

so we also had to implement a tick delay for each of our action.

wynn is kind of weird about sending container set content / container set slot packets

[winter gate]

yeahh i've observed that too XD

[obsidian wyvern]

i can see no logic behind it other than it seems like it's wasting network resources

[winter gate]

i also have to deal with the nightmare item stacking

(which is why graph is great! i can undo operations)

XD

[winter gate]

i think at least for the bank, this hopefully will be less of an issue since most of the code is vanilla

🙏

anyway, gotta go cook some lunch

thanks for the input!

[obsidian wyvern]

yeah, have fun with it. i cant promise i ever will look back here, but i hope i do. lets hope i dont forget 😉

[winter gate]

😏

[scarlet escarp]

Imagine this but with the trade market

[tropic kestrel]

I NEVER NEED TO SORT MY BANK AGAIN

I love this

[foggy pasture]

this is so cool

[obsidian wyvern]

@winter gate (sorry for the ping) actually, would you mind if i experimented with doing something like this with the trade market?

obviously it would be really different in ways but still the same core concept

[winter gate]

not at all! actually i was thinking of exploring the trade market after finishing the bank component :)

we can compete to see who makes a better solution XD

[obsidian wyvern]

the trade market has to be state sycned like we talked about

my plan is to create a wrapper that can manipulate an active screen and display it to the user differently

[winter gate]

👍

[obsidian wyvern]

it’s really hard to do so it would be just an experiment for me

(kind of like you do here)

[winter gate]

😅

also feel free to use some of my ui components that i stole from minecraft

[obsidian wyvern]

either way, if you are done with this, and i am working on something remotely close, let me know, i am happy to work with you, if you want to

[winter gate]

for sure :P

[winter gate]

also, the wynntils scrollbar in the settings menu could be much better ™️
maybe when im done this ill port my scrollbar code into wynntils

[obsidian wyvern]

lmao yeah ik

[winter gate]

XD

anyway... back to dealing with this nightmare...

[obsidian wyvern]

have fun 🙂

[raven bison]

Gods work right here. Keep it up it’s looking great!

[winter gate]

Here's a preview look at WyRIM moving items around. just implemented the bare minimum for now, next step is to add some polish :)

[quiet ruin]

this is very nice. How do I run this or this is still in development?