#making-mods-general

1 messages · Page 278 of 1

lucid iron
#

It was still map last time i checked

reef kiln
#

Flash would say yes, I am sure. It was the complexity of doing it like those maps do that turned me off.

lucid iron
#

Which is around time of frontier farm release

calm nebula
#

Well, if sparrow friend is up for it

#

It's perfectly doable

#

I think if you ask Flash he wouldn't be upset with you

reef kiln
calm nebula
#

You could do it optionally

lucid iron
#

I don't remember that at all tbh

reef kiln
#

Maybe I am crazy.

lucid iron
#

The reason why i remember is cus the neighbourly buildings person was here asking about fixing up the map (their grandpa shed has a wider top)

#

And it was only problem on frontier farm

odd ginkgo
#

I remember that, the back corner of the grandpa's shed kept getting cut off

#

I think it's worth asking

reef kiln
#

Then I am crazy and remembering completely wrong. Not the first time.

lucid iron
#

But yeah if u wanna just do the changes in sve itself to buildingfy the whole thing you probably can LilyDerp

#

I forgor if sve has spacecore as dependency tho

calm nebula
#

Sve does not

#

(I keep forgetting this)

rigid musk
#

i cannot get these slimes to be the proper color for the life of me

image.png
#

they look like ghosts

#

i dont think you can move grandpa's shed btw, unless that was changed in a recent update

#

(or in 1.6)

#

i havent actually tried it ... pondering

reef kiln
#

No, I agree. I think I must have dreamed it up. My last few games never even fixed it. So it has been awhile my mind is probably tricking me.

brittle pasture
#

unless I missed something grandpa's shed is still baked into the map

lucid iron
#

Still thinking about buildingfy ginger island one day

calm nebula
#

If it was a thing ut would have to be within the last year

rigid musk
#

just the whole of ginger island

calm nebula
#

I agree it's doable

lucid iron
#

Yes (no just the farmhouse and obelisk)

calm nebula
#

I'm very out of the loop wrt to SVE though

reef kiln
calm nebula
lucid iron
#

Right yes

#

No frog not just can build here

#

I want to turn the obelisk farmhouse shipping into buildings

#

Since buildable is implicit for this it'd be set too

reef kiln
#

Oh

lucid iron
#

I am not 100% sure if it's doable in cp alone

#

Mainly because I don't know how parrot progression is remembered

golden spire
#

joja transforms Ginger Island into a giant warehouse

#

Jojar Island

orchid oak
#

Update: png didn't work

#

Not sure what else to try here

reef kiln
#

Or you loaded it wrong

lucid iron
#

It is png, but there's required folder names to follow and you can't go over 256x256 per portrait afaik

#

It also just doesn't work for some cases where the speaker is not a real npc

reef kiln
#

Thanks chuve. I was looking it up as you typed.

orchid oak
#

Because I know portraiture is supposed to help upload bigger portraits

#

Just unsure what size

reef kiln
#

Vanilla. There is a mod that lets you use hd portraits but I have never used it.

orchid oak
#

That mod is portraiture the one I'm trying to use atm

reef kiln
#

It has detailed instructions on the page I think.

hard fern
#

I don't think there's actually a limit 🤔

orchid oak
#

Then I likely uploaded it wrong honesty

#

Tho the file is a png and it has his name correctly

hard fern
#

Ex: several portraits for characters ive used have been larger than 256x256

gaunt orbit
#

there is no limit, but 256x256 is the display size of portraits (unless you have a ui mod that makes them bigger) so anything larger than that will get scaled down and lose detail

golden spire
#

not getting any errors?

gaunt orbit
#

additionally you need portraiture if you want to use any size above 64x64

orchid oak
#

Portraiture is what's not working here

gaunt orbit
#

actually you might be able to use spacecore as well

lucid iron
#

Whose portrait are you trying to make work

crude plank
#

Are you sure you're using portraiture correctly when you're testing?

lucid iron
#

Normal npc?

orchid oak
orchid oak
rigid musk
#

believe it or not... there's a large slime in this photo

image.png
golden spire
#

is it the player?

orchid oak
lucid iron
#

Normal npc then

#

Show us your folder structure

rigid musk
#

i hit them so you can see but they're just.. very clear lmao

image.png
ornate locust
#

oh thaaaat's too clear

orchid oak
rigid musk
reef kiln
ornate locust
#

That one Elden Ring boss lady but it's slimes

rigid musk
#

I was trying to see if they were changing color and was waiting for them to spawn and i couldnt find any until i started taking damage and squinted at my screen xD

ornate locust
#

not elden ring, Dark Souls 3

#

one of those dang games

#

Man they don't even leave a shadow

reef kiln
crude plank
#

There is an invisible mini-boss in elden ring too

lucid iron
#

What color did you use

rigid musk
# lucid iron What color did you use

ive been using every level of RGB possible but they remain ghost-like and weirdly transparent - for this specific instance I just set all of the values below 10

orchid oak
lucid iron
#

Oh it's rgb?

rigid musk
#

this one was with blue set to 255

image.png
lucid iron
#

I kinda assume hex lol

rigid musk
#

yeah but without an alpha value

#

(invisible slime colors)

ornate locust
#

Ghost Blue Slime is a neat effect though

rigid musk
#

it is pretty neat tbh but not exactly what i was aiming for xD

ornate locust
#

rip

rigid musk
#

its okay, i'm switching to FTM anyways so I'll have to edit things there

#

I was just trying to see if i could get it to work

lucid iron
#

Does this accept A

rigid musk
#

It does not, (I did try)

lucid iron
#

I think it's default P or something

rigid musk
#

* *Color- The color of the slime, specified with{ "R": 255, "G": 255, "B": 255 }``

#

it did that weirdly but thats from the SC documentation

orchid oak
lucid iron
#

!log

ocean sailBOT
#

Important note: Your computer username may appear in the log. If your username is your full name, please be aware of this before uploading it.

Please share your SMAPI log file. To do so:

  1. Open this page: smapi.io/log.
  2. Follow the instructions at the top of the page to upload the log file. (Don't copy & paste from the console window!)
  3. After uploading, it will show a green box with a URL to share. Post that URL here.

Please do it even if you don't see any errors. This has useful info like what mods and versions you have, what the mods are doing, etc. If the issue didn’t occur in your last session, please load the game to the point where the issue occurs, then upload the log.

To use this command, type !log.
gaunt orbit
#

no but that wouldn't make sense either

orchid oak
#

restarted pc, works now ty for tryna help 👍

image.png
gentle rose
rigid musk
calm nebula
#

(Driveby: I would be very surprised if Casey didn't use xna.color in her model)

#

(Alpha may not be documented but it probably will work)

inner harbor
#

I think im gonna need to know the RGB codes for the slimes soon. When i get the energy to get out of bed... my computer is like 2m away, ivr no real excuse.

reef kiln
#

Bed is a great excuse. 😇 😀

golden spire
#

I have ideas for 1 off jokes I could sometimes add in the game, but some of them feel such a waste of a user's resources that I never do them, especially when they likely would never even find it/see it

rigid musk
#

Because that did not work

golden spire
#

well I would assume so. Would be odd if it was something else

rigid musk
#

Yeah that.. did not work

ornate trellis
#

opacity goes from 0 to 1 did you keep that in mind

golden spire
#

that depends on the system being used

#

it can be 0 to 1 or 0 to 255

#

and looking at xna stuff, looks like it uses 0 to 255...

#

but whatever lily is doing might not support alpha anyway,

hot gale
#

Is it typically expected for new fish to be able to be put in an aquarium or would it be fine to just have a single sprite for them

acoustic summit
#

yes it is typically expected for them to have atleast one aquarium sprite. They need that to be seen in visible fish as well.

hot gale
#

Ahhh true

#

Damn

#

Thanks!

rigid musk
whole raptor
#

The original was updated later on too, although admittedly I did more "finetuning" with the 14 heart event and the Wizard's tower map (among other obsolete things and cleanup). Hence I still have no idea if I should hide it or remake it into some sort of patch 😅

lucid iron
#

Did you get in touch with the og author

ornate trellis
whole raptor
#

The perms were open and author was inactive for months at that point, so I made the 1.6 patch and then messaged Werewolf, but I never got any response

#

Huh.. so it's been almost a year since I left it in hibernation state 😅

image.png
sly perch
#

I feel like im having trouble understanding content patcher packs

#

the fromarea to area thing

#

is confusing me so much

tawny ore
#

FromArea is copy, ToArea is paste

sly perch
#

Which corner do i pick for the copy?

urban patrol
#

top left

lucid iron
#

This is similar to most image editors

sly perch
#

tysm

lucid iron
#

Top left of image is 0,0

urban patrol
sly perch
#

gotcha, thank you guys!

quaint wadi
#

heyyy could someone please send me mr qi's portrait? im on my phone and i dont have access to my computer rn and i wanna do an edit

#

^ the unpacked content file specifically

sly perch
quaint wadi
#

thank youu!!!

sly perch
#

no problem!!

latent mauve
#

(the sending of individual unpacked files is generally discouraged here, just FYI)

quaint wadi
#

oh! i didnt know that sorry

#

if i asked someone to dm me the file would that have been better?

uncut viper
#

the reason its discouraged is bc its distribution of game files which is generally a no-no, so whether its asked for in dm or in public is kind of the same

latent mauve
#

If you ask, you will generally be advised to unpack it yourself or wait until you are able to unpack it yourself, because distribution is the problem.

quaint wadi
#

ah. gotcha. i understand

latent mauve
#

You didn't know, so I just wanted to gently point it out to prevent future issues. ❤️

quaint wadi
#

i appreciate you letting me know :)

golden spire
#

I understand it but I always find it slightly amusing, "I have a problem with my mod, can anyone take a look?" "sure.." -uploads a zip with a whole bunch of game files- "here you go"

whole raptor
#

There are also times I see "Can you zip your whole mods folder and send it for troubleshooting" SDVkrobusgiggle

uncut viper
#

whole mods folder?!

golden spire
#

yes

lucid iron
#

thats a bit scary why

#

surely we can trust each other to have content patcher LilyDerp

whole raptor
#

It was more for mod compatibility issues between some frameworks iirc (as in by framework authors)

golden spire
#

or cases of just bizzareness

gaunt orbit
lucid iron
#

i thought its packed value think

gaunt orbit
#

technically it can be both

#

but I don't think it's an enum because it has constructors IIRC

#

Drawing.Color is an enum I think

#

just checked, xna color is a struct that acts as a wrapper for a packed value

#

wait Utility has a string-to-color conversion method

#

is that new in 1.6 or have I just been doing things the hard way this whole time

rancid musk
#

It's new

lucid iron
#

string to color my beloved

#

it does monogame named colors and 8 digit hex too

gaunt orbit
#

oh thank god

calm nebula
#

Including whatever the heck alpha is

gaunt orbit
#

how do struct properties work, anyways, if they're passed by value? are they still somehow mutable?

calm nebula
#

Boxed I assume

brave fable
# rigid musk

i'm not sure why a colour property wouldn't accept alpha, i do it all the time in my own mods when casting some json to Microsoft.Xna.Framework.Color. it'd just be "R": 255, "G": 255, "B": 255, "A": 255 for opaque white, or default colouration

#

if it's parsing names then those should include a preset alpha value too, so "Blue" would be fully opaque (A 255), and TransparentBlack would be fully transparent (A 0)

lucid iron
#

string text5 = (isMarried() ? "BusStop" : defaultMap.Value);

#

do i just have to do something about this to dehardcode spouse schedule...

#

and the Point right before

calm nebula
#

Probably!

lucid iron
#

oh theres a 2nd one

#

atra this seems like a smd thing Sleepden

calm nebula
#

I read nothing

#

Totally illiterate

lucid iron
#

when do spouse even go2 town anyways

#

im never married long enough to find out

uncut viper
#

some have jobs dont they

#

i think it would be bad if you married the valley's only doctor and then they never left their house again

lucid iron
#

Button this seems like a csk thing MedLurk

uncut viper
#

why

#

i dont know what you're even attempting to do

lucid iron
#

I guess it depends on if u needed to patch the parse schedule method

#

Let people decide where the spouse schedule starts

uncut viper
#

isnt that just a 0 schedule

lucid iron
#

The first map of spouse schedule seems to be hard coded to busstop

#

And i have zero idea if spacecore spouse 0 schedule works rn

uncut viper
#

yeah but CSK preempts the parser

#

unless im confusing which function you mean

#

what function is that snippet from

lucid iron
#

NPC.parseMasterScheduleImpl

uncut viper
#

ah, i thought it was from one of the special schedule replacers

lucid iron
#

if CSK let ppl just skip this thingy then ig it's fine?

#

my understanding of npc schedules is like, maybe 0.02

#

this was a complaint with leah and wizard marriage tho, cant start em at forest

uncut viper
#

from a glance at the parser though it seems like the 0 schedule stuff happens after that busstop stuff

# 
if (int.TryParse(location, out var _))
{
  location = previousGameLocation;
  index2--;
}

seems to be the only reason that it'd be used even without a 0 schedule and i dont know what the purpose of this is

#

otherwise a 0 schedule will override that isMarriage BusStop thing

lucid iron
#

theres a 2nd BusStop later

image.png
uncut viper
#

thats what im looking at

#

the 0 schedule thing is still below that

#

and so is the snippet i posted, too, which is what will run if the location is not bed

#

also wait

#

ur decompile has different local names

lucid iron
#

i wonder what was the actual issue then

#

does that matter yggy

uncut viper
#

no but it was confusing me til i realized

#

since theres 70 variables dealing with locations here

#

give or take

lucid iron
#

yea true, i am use -lv CSharp10_0

uncut viper
#

your locationName is my location

#

anyway i have no idea what spacecore does to spouse schedules nor am i gonna check

latent mauve
#

Question: There's no easy way to remove the smoke particles at the Travelling Cart, right?

uncut viper
#

nope

lucid iron
#

what smoke particles

uncut viper
#

hardcoded TASes

latent mauve
#

Beedle's sacks are smoking so I need to redraw that area again

#

To explain why there's smoke, I guess

uncut viper
#

the seller has a chimney

#

on their cart

latent mauve
#

^ yeah, those particles

uncut viper
#

you could editimage LooseSprites/Cursors to remove smoke when you're in the forest, i guess

#

it'd have some side effects though

#

that wasnt meant as a joke! just letting you know. its still viable

#

the raccoons also use the smoke, and something around x87 y9 that idr

latent mauve
#

I have this nonsense currently:

image.png
#

so I think I need to draw the chimney back in and just figure something out for what's gonna go there

uncut viper
#

oh the x87 thing is Marnie's chimney

#

tbh, if you just patch it on the days the seller is there, i really doubt anyone would notice

#

chu didnt even know it existed

latent mauve
#

I still have to change the pig, so redoing that area isn't the worst

lucid iron
#

maybe just put a torch there

uncut viper
#

be aware that the pig animating is also hardcoded

latent mauve
#

yeah

#

I'm aware of that one, I've been stalling because my current best option is making it a giant beetle instead

uncut viper
#

though ofc much easier to deal with still

#

unless you wanted to do that LOL

#

(not bc thats hard but bc its not as easy as "delete pig. goodbye pig" SDVpuffersquee)

latent mauve
#

Well, I can't easily negate the pig, because you'd still be able to click the empty space for oinks xD

uncut viper
#

i didnt even know it oinked

latent mauve
#

It does

uncut viper
#

you wouldnt want it to be transparent but you coulda made him a static box or bag

#

a box or bag that oinks

latent mauve
#

I did consider possibly having livestock travel with Beedle

lucid iron
#

make him ganon

latent mauve
#

Just random Cuccos around his travel site, LOL

uncut viper
#

pig beast ganon, reduced to beedle pet

latent mauve
#

nah

#

That doesn't work well with some of the other stuff in the mod. 🙂

old edge
#

does anyone know how I would go about conjuring up some C# code for detecting explosions on a particular tile.

uncut viper
#

(... lookin at the forst code i just realized i think BETAS Harmony can let you easily add more days that the traveling cart is there SDVpufferthinkblob)

#

(Forest just has a Property that returns true or false for it, which can easily be patched. good to know)

latent mauve
#

(I think it was in Spacecore, but I saw a feature yesterday that lets you detect if the Bookseller is in town for patches/triggers and I got very excited)

lucid iron
#

hm can you patch explosionAt

#

its a virtual so i wanna say it's fine

#

if u got your own GameLocation subclass you can just override it too

uncut viper
#

BETAS Harmony can patch anything that regular Harmony can

#

but it wont let you skip prefix

lucid iron
uncut viper
#

and it will only let you change the result of a function if its a typical type like bools, floats, etc

#

oh

#

i would probably opt for just GameLocation.explode

lucid iron
#

but this seems like more convienant if u really did just want specific tile Dokkan

#

explode is better if u want to know where bomb ofc

uncut viper
#

i guess it depends on if you want the tile the explosion happened at or all the tiles the explosion exploded

old edge
#

just one area by a wall since I'm paying homage to zelda

uncut viper
#

i guess you want explosionAt then

#

and check if the tile is inside a rectangle

lucid iron
#

the ginger island mushroom cave thing is basically what u want

#

cept the part where u need to harmony it ofc

uncut viper
#

if its an actual rock or terrain feature you're exploding, you dont need harmony either

#

there are SMAPI events for those lists

old edge
#

hmm I'm looking over the decompiled code

#

for this mushroom cave you speak

lucid iron
#

Stardew Valley/StardewValley/Locations/IslandNorth.cs

#

islandNorthCaveOpened

#

thats the cave where u rescue the professor from

#

it just checks if explode is some coord and then set the related flags to do the map patch

old edge
#

ok

fathom hound
#

Is there a way to make fish ponds swim-able or will I need C# for this?

#

Like, can I use CollisionMap on it?

#

Not sure if swim property is for maps, buildings, or furniture (if there even is one for CP)

normal summit
#

hi, for making mail mods should i just be using content patcher or using the mail framework mod? The modding wiki tutorial lists mfm as obsolete but it looks like it's still being used as a dependency for various mods.

uncut viper
#

MFM has some things it does that Content Patcher cannot do on its own still, but in the majority of cases nowadays you likely only ever need what can be done with CP

#

if you just want to simply send mail, CP is fine

drowsy pewter
#

see how on maps you have to walk through a sepcific tile to transition to swimming

fathom hound
#

Like if there’s stairs leading into the tub, could I make those stairs the tiles that change into swimsuit

drowsy pewter
#

i dont think so since buildings arent just a collection of map tiles

fathom hound
#

Ah darn SDVpetcatsad ty!

normal summit
#

Oh okay! Ty I'll just use content patcher but I'll take a look at mfm for fun too haha

vernal crest
rigid oriole
#

I'm new to using StardewUI and my data model contains a list "TodoItems" of objects which have a property "UncompletedSubtasks" which is also a list. I'd like each of the items in "TodoItems" to be an expander, with the "UncompletedSubtasks" of that item as a list of labels in the expander. I've got this so far:

<lane orientation="vertical">
    <expander *repeat={:TodoItems} layout="stretch content" margin="30,0,0,15">
        <label *outlet="header" text={:TaskName}  />
        <label *repeat={:UncompletedSubtasks} text={:this} margin="60,0,0,15"/>
    </expander>
</lane>

However, I've got a BindingException "Cannot bind multiple children to outlet (default) of view type Expander". What do I need to change to make this work?

#

When I remove the label with the *repeat attribute, the error leaves

old edge
#

how can I get an event to start with C#?

rigid oriole
#

ah. if I wrap the repeated labels in a parent element like a lane it works

somber lantern
normal summit
# vernal crest Could I grab a link from you to the page where MFM is listed as obsolete? I want...

Sure! https://stardewmodding.wiki.gg/wiki/Tutorial:_Sending_a_Letter_(Mail_Framework_Mod)

Stardew Modding Wiki
Tutorial: Sending a Letter (Mail Framework Mod)

PLEASE NOTE: Mail Framework Mod is obsolete in favor of Content Patcher. Backwards compatibility is maintained, but for new mods, CP should be used.
It's super easy to send a letter in Stardew Valley, thanks to frameworks like Mail Framework Mod.
Note: This tutorial assumes that you are already familiar with some modding basics, like making sur...

vernal crest
old edge
whole raptor
errant sparrow
#

Is there an easy way to check for someone swapping the toolbars? I was hoping it'd trigger the InventoryChanged event but no luck

spice inlet
errant sparrow
#

I've made a mod that auto sorts your tools in designated slots on your toolbar. I want it to also sort when you swap bars but I'd need some event to trigger off of

spice inlet
#

you could probably do a harmony postfix on the Farmer.CurrentToolIndex setter and build your own event that way

errant sparrow
#

Ah that sounds straightforward enough, thank you

lucid iron
proud wyvern
stark spindle
#

Hey all, is there a specific setting to remove a Custom NPC from the social menu using CP?

#

o wait i think i found it "SocialTab": "HiddenAlways"

craggy cape
#

question, if you convert, lets say a CRC mod into item extensions as an extranode, would it be applied to both versions of the mines and skull cavern? or is there a code snippet i need to add to do that?

#

an item extension mod i can find that adds new nodes to the cavern + dangerous mines just has them as configurable options :,3

lucid iron
#

Lumisteria has one

craggy cape
#

ooo

lucid iron
#

If the crc mod you are trying to use is kaya's, that had been converted already i believe

craggy cape
#

yea its kaya's lol

#

but didnt she delete it .ᐣ

errant sparrow
#

turns out there's simply a shiftToolbar method I can patch

craggy cape
lucid iron
#

Ah maybe different then

#

This is the one i was thinking of but it's not kaya anyhow

craggy cape
#

i know she also has more gems mod i tried to convert to IE but .. the converter refused xd

lucid iron
#

But hey more samples of how to do stuff

craggy cape
#

yea true

craggy cape
wet wadi
#

hi, may I ask why I am having this on smapi? I am currently fixing a mod

image.png
craggy cape
#

im just gonna double check if i used the right framework though xd CON and CRC are easy to mix up for me

vernal crest
craggy cape
wet wadi
craggy cape
wet wadi
craggy cape
#

ok after more digging, the mod mentions a clump that only spawns in the skull cavern :P although i dont know if the dangerous versions would be applied upon converting, i atleast got my question partially answered xdd

fathom hound
#

Additionally, it can be obtained by killing monsters or breaking crates/barrels as a special item in The Mines during the Danger In The Deep quest or after activating the Shrine of Challenge.

Where can I confirm that [[Auto_Petter]] can/can’t drop in barrels/crates during dangerous mines mode?

empty radishBOT
brittle pasture
vernal crest
wet wadi
somber lantern
# whole raptor The original is still getting 10 times the downloads my fix does so might be a g...

OMG no i18n ?! Urfff that’s such a pain for translators TvT - it’s part laziness from my part, part perilous for the mod coding :/
Thank you for the information anyways. I think I’ll keep up with linking it with your mod.

By the by, you had some ideas with implementing more content ? Because I wrote a few ideas for events and quests complimenting RomRas’s « lore », so… I wouldn’t mind talking about it with you SDVpufferlurk SDVpufferblush

vernal crest
# wet wadi

That's strange that it hasn't loaded the dialogue at all. Can you try debug loaddialogue lee characters/dialogue/marriagedialoguelee:rainy_day_4?

calm nebula
calm nebula
#

The patches

wet wadi
ocean sailBOT
#

Log Info: SMAPI 4.2.1 with SDV 1.6.15 build 24356 on Microsoft Windows 11 Home Single Language, with 6 C# mods and 1 content packs.

calm nebula
#

!patchsummary

ocean sailBOT
#

Can you do these steps to provide more info?

  1. Load your save and view the content that should be patched.
  2. Type patch summary directly into the SMAPI window and press enter.
  3. Upload your SMAPI log to https://smapi.io/log (see instructions on that page).
  4. Post the log link here.
To use this command, type !patchsummary.
vernal crest
fathom hound
#

i'd edit myself but i want to make sure i put the right info

wet wadi
ocean sailBOT
#

Log Info: SMAPI 4.2.1 with SDV 1.6.15 build 24356 on Microsoft Windows 11 Home Single Language, with 6 C# mods and 1 content packs.

fathom hound
calm nebula
#

Special item there is an item that can appear in the skull cavern chests

#

Which includes the autopetter

fathom hound
#

i just dont understand how auto petter can be both 0% special item found in dangerous mines crates but also able to be found

#

something is wrong on the wiki, whether its this page or the auto petter one

#

so which is it SDVsobastian

vernal crest
calm nebula
#

It's an incredibly low chance that got rounded probably tbh

wet wadi
fathom hound
calm nebula
#

Sure!

brittle pasture
fathom hound
#

thanks!

vernal crest
wet wadi
#

Sure I just booted that up

calm nebula
fathom hound
#

0.02%?

image.png
calm nebula
#

(No, that is 2%)

fathom hound
calm nebula
#

Again, please don't mess with this unless you're sure of what you're doing

fathom hound
calm nebula
#

If it is unclear open up the talk page and explain how it is unclear

fathom hound
#

im so confused now ): am i doing something wrong

calm nebula
vernal crest
# wet wadi

Okay that's wrong so that's why his marriage dialogue isn't loading. There should be no forward slash between the MarriageDialogue and the LEE. Did you change that from the original mod? This is what it looks like in the original mod that you sent me.

image.png
calm nebula
#

It cannot drop from crates and barrels

fathom hound
#

i know that part, its the crate/barrel part that isnt right

#

so that part should be taken out of wiki right?

calm nebula
#

It is right. I'm not sure why you think it's wrong tbh

fathom hound
#

breaking crates/barrels as a special item in The Mines during the Danger In The Deep quest

#

because they cant drop from crates/barrels

vernal crest
#

Atra it does say that it drops from breaking crates and barrels.

calm nebula
#

Hmmm

fathom hound
calm nebula
#

I'll take a look at it later

#

Please for the love of God do not edit the game wiki based on a glance

wet wadi
#

So I tried using a slash

calm nebula
#

Some places get repeatedly edited weirdly, if you think it's wrong please open the talk page and explain it there.

fathom hound
#

i wasnt gonna edit the wiki without getting confirmation from at least a few people so

vernal crest
#

I think that is a bit unfair on Anaira. She wasn't planning to edit the wiki based on a glance, she actively asked for help verifying it.

fathom hound
#

no need to make me feel silly when i wasnt oging to do that

#

thank you aba, im gonna go now, server is just not nice to me today lol, see ya SDVpufferheart

vernal crest
wet wadi
calm nebula
#

Okay, explaining the wiki a little bit

#

I double-checked the code for this

#
  1. That section - the special items - refer to items that can be dropped by either special monsters or special barrels
#

It refers to getSpecialItemForThisMineLevel which is called by monsterDrop (which explains the references to the dangerous mines.)

#
  1. "Normal" non dangerous crates can also call getSpecialItemForThisMineLevel
#

as far as I can tell (and this is a bit fuzzy because it's a long method) dangerous crates never will, hence the "0%"

#

this also matches from what I remember, and from when I checked that wiki page 2-3 years back

fathom hound
#

so it's just the auto petter page that's wrong then and should omit the bit where it says it can drop from barrels/crates in dangerous mines

#

(i'm not going to edit the wiki i refuse to be made a fool again)

golden spire
calm nebula
#

I'm annoyed because people quite often try to wade through the numbers with a cursory search (ie, just ctrl-f'ing for a specific item ID) and then edit it in.

#

it looks to me like this was added october 2023 on most of the pages

image.png
wet wadi
ocean sailBOT
#

Log Info: SMAPI 4.2.1 with SDV 1.6.15 build 24356 on Microsoft Windows 11 Home Single Language, with 6 C# mods and 1 content packs.

vernal crest
wet wadi
vernal crest
wet wadi
golden spire
#

where were you in the game when you ran it?

wet wadi
#

at my room

vernal crest
#

Can you warp to Lee and talk to him please?

#

And then report back about what happens

wet wadi
#

sure let me go there

golden spire
#

I'd just run it again.. because even if you ran patch summary in the introduction cutscene you should see more than that

      ChildGenders                                        | [X] 
      ChildNames                                          | [X] 
      Count                                               | [X] 0
      DailyLuck                                           | [X] 0.0010000000474974513
      Day                                                 | [X] 0
      DayEvent                                            | [X] 
      DayOfWeek                                           | [X] Sunday
      DaysPlayed                                          | [X] 0
      FarmCave                                            | [X] None
      FarmhouseUpgrade                                    | [X] 0
      FarmMapAsset                                        | [X] Farm
      FarmName                                            | [X] sdf
      FarmType                                            | [X] Standard
      FormatAssetName                                     | [X] (token returns a dynamic value)
      HasActiveQuest                                      | [X] 
...
#

that is what you get on the intro scene

shadow pagoda
#

Is there a good way to check for when a specific player says a dialogue within the unpacked files? I am looking for when Morris says We're currently processing your last Community Center development order....

wet wadi
ocean sailBOT
#

Log Info: SMAPI 4.2.1 with SDV 1.6.15 build 24356 on Microsoft Windows 11 Home Single Language, with 6 C# mods and 1 content packs.

wet wadi
#

here, I warped to where he is and talked

vernal crest
golden spire
#

I use my OS search tool to search the contents of all the files

#

that line is in ExtraDialogue in Data

shadow pagoda
vernal crest
calm nebula
#

(yes. that's what grep is for, or sublime find-in-files, or vscode find in project)

calm nebula
# wet wadi at my room

What do you think MarriageDialogueLee does, btw? it looks like you're not married to LEE in that save

golden spire
#

I also recommend VoidTools Everything for good 3rd party search tool if you're on Windows

vernal crest
# wet wadi here, I warped to where he is and talked

Okay that loaded the unmarried dialogue. So let's see how you go once you marry him. Can you copy debug hu 3 into your SMAPI window and then debug marry Lee. Then sleep once and try to talk to him again, then do the patch summary again.

vernal crest
golden spire
#

but the line is there

image.png
shadow pagoda
wet wadi
ocean sailBOT
#

Log Info: SMAPI 4.2.1 with SDV 1.6.15 build 24356 on Microsoft Windows 11 Home Single Language, with 6 C# mods and 1 content packs.

vernal crest
golden spire
vernal crest
#

I recommend using Sublime for searching file contents, it's nice and speedy.

#

Though I use Everything for searching for files and folders themselves

wet wadi
#

it showed this

shadow pagoda
# shadow pagoda this https://www.voidtools.com ?

I'm unsure if I did it correctly using Everything, I tried using the advanced search like so, but didn't seem to get any results. Sorry if this is a lot more simple than I'm making it out to be. I'm hoping to do this on my own so I don't have to keep asking every time I want to find a string

image.png image.png
golden spire
#

We're currently processing

#

one c

vernal crest
shadow pagoda
#

got it. thanks. Can you say again why you prefer sublime? I never used either applications before

vernal crest
#

For searching within files? Because it's fast. And I do "find in files" searches a LOT so that matters to me lol

#

It's the fastest for me out of Notepad++, VSC, and Sublime. But any text editor fancier than Notepad will probably be able to do a find in files search. I used Notepad++ to do it for months before someone convinced me to try Sublime.

vernal crest
# wet wadi

I just tried that with Sam and got the same thing, so it looks like that command doesn't work very well with those dialogue lines. That's okay, can you try the patch export characters/dialogue/marriagedialogueLEE again?

wet wadi
wet wadi
vernal crest
wet wadi
#

the file name of the marriage dialogue is just marriagedialogue.json

calm nebula
#

You can think of that as a generic file

#

The way marriage dialogue works

#

If the key exists in the MarriageDialogueNPC file it's used

#

But if it doesn't, the game checks MarriageDialogue for it

#

So please edit MarriageDialogueLEE and not the fallback file

#

Oh hang on

#

CP can add new assets

#

Just in the same what it can add Portraits/Lee, it can add Characters/Dialogue/MarriageDialogueLEE

vernal crest
# wet wadi it says on smapi that it should be marriagedialogueLEE.json

I think you are looking at the FromFile and thinking that it should be called marriageDialogueLEE.json. But it doesn't have to be called that. It can be called anything. It only matters to the game what the Target was. And the Target is fine. So can you open the file that it exported characters_dialogue_marriagedialogueLEE.json and check if Rainy_Day_4 is there?

calm nebula
#

Rainy_Day_4 doesn't necessarily need to be in there btw

#

It should have a backup in the generic MarriageDialogue

vernal crest
#

But it is in her dialogue file so it should be in the patch export, shouldn't it?

calm nebula
#

(I think, I'm not looking at the unpack at the moment)

#

Ah, if it is in the file it should be there!

#

Just saying it isn't necessarily an error if it isnt

#

It in theory defaults back to a Rainy_Day_4 line that I think likely is in the MarriageDialogue file

vernal crest
#

In general, yeah. In this situation sakimi was puzzled because SinZ's mod was saying that it couldn't load Rainy_Day_4 for LEE (as in the specific Lee file line) despite it clearly being present.

#

And so that's what we've been investigating this whole time.

calm nebula
#

Ah, okay!

vernal crest
#

And it looks like for some reason it just was not loading marriage dialogue for him in the other save...or something?

formal crown
#

SDVpufferlurkHi all, Is the smapi.io website working for y'all, or is there something wrong on my side?

calm nebula
#

....weird, was this when they had MarriageDialogue/Lee?

calm nebula
vernal crest
#

It might have been, I'm not entirely clear on exactly when she changed it.

calm nebula
#

What does downforeveryone say?

formal crown
#

hwll?

calm nebula
#

Hell

#

Sorry

vernal crest
#

Hmm yeah it's having a struggle for me now too

calm nebula
#

I can't access smapi.io but that isn't abnormal on my phone so

brittle parrot
#

What's the ID for barrels in the dangerous mines?

shadow pagoda
#

Related to the string dialogue. Is there a way to look through ILSpy to see when a string variable is called? In this case I am looking for Morris_StillProcessingOrder but putting that into search didn't seem to look anything up

image.png
formal crown
#

I mostly use isitdown, it says its down

#

I thought it must be an error since its in Pathos' control 😆

calm nebula
shadow pagoda
#

I did all this to debug that I was missing %&NL&% in this check 🤦‍♂️

jojaUpgrades.Keys.Any(id => Game1.player.mailForTomorrow.Contains(id)
fathom hound
#

No ID for dangerous barrels

ivory plume
#

(smapi.io seems to getting heavier traffic than usual for some reason; I just scaled it up so it should be back to normal.)

calm nebula
#

There is one - i forget what-

#

But it isn't checked in releaseContentw

#

Try. Uh

#

GetBarrelForMines?

#

Smth like that

brittle parrot
# fathom hound No ID for dangerous barrels

they are breakable containers that means they have IDs, cross refferncing every breakable barrel ID (118, 120, 122, and 124) they all can call getSpecialItemForThisMineLevel

Looking at a barrel from the dangerous mines it matches ID (BC)118, one of the barrels that has a case to get a special item and in the get special item which then checks mine difficulty

calm nebula
#

Yes, but there is a block at the top of the function that runs if the mines are dangerous and that returns immediately

#

So it doesn't make it to that switch case at all

#

Hence never getting to special items

brittle parrot
calm nebula
#

Top of release Contents

#

The difficulty block

#

I'm not at home so I can't point it out to you

#

It's right under the 1.6 special items

craggy cape
#

i have completely forgotten to account for the litter trash entirely, so when you get a trash item from the garbage, it shows up as an error item. Whoops. bigthinking

brittle parrot
# calm nebula The difficulty block 
if (location is MineShaft mine)
{
    mineLevel = mine.mineLevel;
    if (mine.isContainerPlatform(x, y))
    {
        mine.updateMineLevelData(0, -1);
    }
    difficultyLevel = mine.GetAdditionalDifficulty();
}```
#

Oooo I think IO sse the one you are talking about

#

one sec

calm nebula
#

Yeah

tiny zealot
# 
if (difficultyLevel > 0)
{
  ... bunch of stuff
  return;
}```
calm nebula
#

Sorry, I'm at work, I'll get back to you in like 36 hours haha

brittle parrot
#

lol

blissful panther
#

(36 hours? Short day today? SDVkrobusgiggle)

brittle parrot
#

there is a chunk of setup first lol

languid aurora
golden spire
fathom hound
#

ah okay thanks

craggy cape
#

stupid question, can items have multiple types within one category? or would i have to just copy my code and change the "type:" accordingly ..

#

like could i use "type: fish, [whatever the type trash items are from the garbage cans]" or..

#

actually wait lookin at the example i think i might have to just copy and change it

#

well, time to figure out how to make this compatable then. to the thread of mine i go

latent mauve
craggy cape
#

i made a mod that replaces the vanilla trash, both in texture and description/names

#

but it only effects the fishing trash

#

and the garbage trash is error items, so. tryna fix that xd

craggy cape
#

..wait it already.. has context tags.. hold on lemme send my json

#

the category is -20
the type is fish
and all items have the context tag of a color, and "trash_item" (aside from the joja cola)

#

would the nulling be neccessary even?

#

lemme try without it

#

..fixed the error texture atleast, i shall change the index then

image.png
#

okay nvm removing the null doubles the item actually, so i have to use null

brittle pasture
#

why are you removing the vanilla trash items

craggy cape
#

bc im replacing them, essentially

#

new name, new desc, new texture, but not as a new item

brittle pasture
#

You are adding new items though

gaunt orbit
craggy cape
#

well all i wanted to do was to change the name ( for some ) and the descriptions, but als oadd on a new texture 😭

#

the joja cola and the soggy newspaper are renamed in my mod

#

but everything else has a different description

craggy cape
gaunt orbit
#

If you're just changing tooltips and textures, why not do an image patch on the objects sheet and modify the language files?

calm nebula
craggy cape
#

why must i overcomplicate everything

#

i didnt even think of that method 😭

#

oog i just realized i put the image edits to the wrong file
hm. that explains a little

#

instead of maps/springobjects i put it to tilesheets..

cinder locust
#

Anyone know how exactly I could get an NPC to move in as a roommate rather than a spouse? Also, how would dialogue work in that case. I've made marriable npcs before but now I wanna make one as a roommate but I'm not exactly sure how to do so...

gaunt orbit
#

It's just a field in npc data

#

Unpack your game files and take a look at krobus's entry as a reference

tiny zealot
#

the dialogue works exactly like spouses (MarriageDialogueYourNameHere, etc), since from the game's perspective your roommate is your spouse, with different window dressing. you might have to do a bit more work (more coverage) to make sure no generic marriage lines get through

ornate trellis
#

ugh, im struggling with schedules, why

tribal ore
#

So, I just finished a C# implementation of Wedding Anniversaries that addresses all of the issues I was having. I want to open source it but I don't want to make a github account. What's best practice here? Creating a src/ directory in the mod?

ornate trellis
#

anyone know what this means? I have my location, i am in that map rn why cant she go there?

System.Collections.Generic.KeyNotFoundException: Required location 'VoidWitchCult.CP.TheFishmonger_LostIsland_EnchantedForest' not found.

tribal ore
ornate trellis
#

thats my own location

tribal ore
#

Sure, but schedule code is for NPCs to follow during the day. I don't think it depends on the player at all

#

Unless I'm very confused about what you're trying to do

#

You can set events in custom maps no problem

#

But schedules are finnicky

gaunt orbit
ornate trellis
#

npcs can go to custom locations, wut

vernal crest
vernal crest
tribal ore
#

But look at the Backwoods -- the player can go there but NPCs can't route through on their schedules

brittle pasture
ornate trellis
#

I did not exlude my own map from npc pathing

vernal crest
tribal ore
tiny zealot
#

honestly void i'm kind of expecting a typo

ornate trellis
#

especially considering that the house she spawns in and the map that the house is on she can walk on

tribal ore
gaunt orbit
ornate trellis
tribal ore
lucid iron
#

Like open sourcing through nexus?

ornate trellis
ocean sailBOT
#

Log Info: SMAPI 4.1.10 with SDV 1.6.15 build 24356 on Microsoft Windows 11 Pro, with 24 C# mods and 24 content packs.
Suggested fixes: One or more mods are out of date, consider updating them

tribal ore
#

Yep. Just put the src directly into the mod so ppl can look

tiny zealot
lucid iron
#

I guess you can do that sure, seems like a pain to me but i doubt people mind if it's just optional file

gaunt orbit
tiny zealot
#

optional file for source zip is another option, i guess, but i also wouldn't choose that

lucid iron
#

No one can ever pull request you though

#

Or conveniently browse things Dokkan

tawny ore
#

Just my personal opinion, but I don't bother doing any mod integrations for mods that are not open sourced in a git repository

#

I don't know if others follow the same thing, but that's just me

tribal ore
#

Yeah, I know it's not the best solution :/ I would put in the license that it is open sourced, but it may just not make it onto git

tiny zealot
tawny ore
#

Git isn't a nice to have thing when it comes to open source, to me it's a requirement

ornate trellis
#

im too blind to find my own mistakes

lucid iron
#

Like if you think this is a one off C# thing you will never touch again and don't really care if it explodes in future game update then sure you can do this

#

But if you have any intention of maintaining it then you are making things hard for yourself here

latent mauve
vernal crest
gaunt orbit
#

I agree that kantrip's decision is not best practice and makes things more difficult, but ultimately it is their choice to make

ornate trellis
blissful panther
#

Someone could set up a repo, you generate an SSH key, and you push to it exclusively using that, maybe?

No account, and still on public GitHub.

tawny ore
#

Yeah, do whatever pleases you, just trying to be real about the implications

#

I guess it depends on what you hope to accomplish by sharing your source

lucid iron
#

Yea definitely, i think everyone is just providing insight on the consequence of various approaches

latent mauve
tiny zealot
#

@ornate trellis it's this:
VoidWitchCult.CP.TheFishmonger_LostIsland_EnchantedForest
vs
VoidWitchCult.CP.TheFishmongerNPC_LostIsland_EnchantedForest

tawny ore
#

If you're wanting to encourage integrations/support, you may not get that the way you're intending to approach it

ornate trellis
tribal ore
#

I appreciate the discussion, honestly. I just have to decide if creating a github for this is actually worth it to me. Thank you all for your thoughts

ornate trellis
#

SIGH

lucid iron
#

Well again even if u literally just upload source as a zip on nexus

latent mauve
#

(I didn't even look at the location code, I was just comparing it to the mod internal name, LOL)

gaunt orbit
#

Why not prefix with modid?

lucid iron
#

You can still use git locally

tribal ore
lucid iron
#

Just do git init in a folder

ornate trellis
#

thats what i get for not using {{ModID}} in my schedules too

lucid iron
#

Then you can commit stuff just no push until you set a remote

tribal ore
gaunt orbit
vernal crest
# ornate trellis SIGH

Why are you even loading your schedule? If you switch to a blank load and then edit you can use tokens.

ornate trellis
#

my lord why is my computer lagging in everything rn

#

wait what

tribal ore
ornate trellis
#

i am uhh

gaunt orbit
#

The main utility of open source is the ability to contribute back to the project

lucid iron
#

If you got private server then u can just serve the repo right think

#

I'm not too sure how git hosting is setup

latent mauve
#

Loading blank.json is your friend with things like schedules for brand new NPCs.

lucid iron
#

But plenty of open source stuff just give u a .git url from their server

tribal ore
blissful panther
#

And trusting something just because source is available somewhere can be a massive false sense of security, anyway.

ornate trellis
#

i thought i did do that

tiny zealot
tribal ore
lucid iron
#

I was kinda assuming it's some hosting service you pay for tho

#

If it's like a home media server then disregard kyuuchan_run

tribal ore
vernal crest
blissful panther
#

You could set one up on a cheap $5/month VPS, honestly. Not free, but relatively light!

ornate trellis
#

oh true, I AM loading schedules

gaunt orbit
#

Yeah I'm paying $2/mo for my vps currently

ornate trellis
#

i am sorry if i answer weirdly atm i dont even see what i am typing rn?

blissful panther
#

(But then that's possibly a new account on the provider's site, so disregard!)

tawny ore
#

I have a home server that I reverse proxy on a VPS which connects to my home using an ssh tunnel

vernal crest
tawny ore
lucid iron
#

I wonder what you would type on the mod compat list if it was indeed "source available by a zip file hosted somewhere"

ornate trellis
#

I am loading my schedules in my dispo json lol

#

i mistook it cuz i was doing the blank thing for events n stuff

blissful panther
#

"Source embedded in assembly."

lucid iron
#

It's probably not a case the nexus parsing thing handles

vernal crest
lucid iron
#

Unfortunately to update that u also need a github acc to send a PR lol, but we can do it 4 u probably

tribal ore
#

Alright, I'll decide if it is ultimately worth it to me to set up a github for this before I publish. I may reverse course and just do it the easy way

ornate trellis
#

well, schedule loads

#

the schedule is in its own json

vernal crest
#

Still unusual imo

blissful panther
#

Don't forget you can also consider the likes of GitLab. It doesn't have to be GitHub, it's just... the one most people have an account on.

ornate trellis
#

idk man it was easier with one npc now i am a bit overwhelmed with resorting things and the fear of breaking targets etc

#

ok lemme see to do it blank wqay then

vernal crest
ornate trellis
#

ah

lucid iron
#

I was try something called codeberg cus it was mentioned, it's alright

ornate trellis
#

help my discord client jsut crashed lmao?

#

anyway

#

{ "LogName": "Schedule", "Action": "Load", "Target": "Characters/schedules/MermaidCalliope", "FromFile": "assets/blank.json" },

#

fuck

#

w/e

#

discord is annoying me with a damn opup i cant get rid off everything is going wrong rn

vernal crest
#

You can just use one code block to load your blank.json anywhere you need it btw

ornate trellis
#

i actually did both

#

i knew at some point i confused myself

#

I already had a wholeass block of include for anything with dialogue (includind schedule cuz schedule dialogue)

vernal crest
#

May I suggest being very, very organised and writing very clear comments (both as section headers and then also as explanations) to make your code as easy for you to follow as possible?

ornate trellis
#

I thought I did well with the headers, guess I was too "summing things up"

#

i think i did something really stupid where i am wondering if its so stupid its the reason things still work

vernal crest
#

Even a separate text file that functions as a table of contents of sorts might be helpful. So you could reference it to remind yourself of what things are stored in which files etc

ornate trellis
#

I think I need help fusing everything to one include...

#

so I got this is my content.json(just added the shcedules things)

{
            "LogName": "Fishmonger Includes",
            "Action": "Load",
            "Target": "data/events/VoidWitchCult.TheFishmonger_Fishmonger_GI_Inside, Data/Events/VoidWitchCult.CP.TheFishmongerNPC_LostIsland, Data/Events/IslandSouthEast, Characters/schedules/MermaidCalliope, Characters/schedules/TheFishmonger, Characters/schedules/CoolGalBernadette, Characters/schedules/PirateLadCaitrionaOFlannagain, Characters/schedules/SeaDudeBarnabas",
            "FromFile": "assets/blank.json",
        },

then I also got these

{
            "Action": "Include",
            "FromFile": "assets/Dialogue/ConstanceDialogue.json, assets/Schedule/ConstanceScheduleDialogue.json, assets/Dialogue/CalliopeDialogue.json, assets/Schedule/CalliopeScheduleDialogue.json, assets/Dialogue/BernadetteDialogue.json, assets/Schedule/BernadetteScheduleDialogue.json, assets/Dialogue/CaitrionaOFlannagainDialogue.json, assets/Schedule/CaitrionaOFlannagainScheduleDialogue.json, assets/Dialogue/BarnabasDialogue.json, assets/Schedule/BarnabasScheduleDialogue.json"
        },
        {
            "LogName": "Shedule Dialogue",
            "Action": "Load",
            "Target": "Strings/schedules/TheFishmonger, Strings/schedules/MermaidCalliope, Strings/schedules/CoolGalBernadette, Strings/schedules/PirateLadCaitrionaOFlannagain, Strings/schedules/SeaDudeBarnabas",
            "FromFile": "assets/Dialogue/BlankDialogue.json"
        },
#

why am i like this

vernal crest
#

You don't actually need schedule strings at all because you can just reference your dialogue files in schedules, but if you'd prefer to stick with them, you can just combine your two blank loads.

#

Don't be so harsh on yourself! I spent months with every single include in its own code block before I realised I could combine them lol

gray bear
#

omg u can have multiple files in include i wasn't even aware

tiny zealot
#

i still have most of my includes in their own actions

ornate trellis
#

I dont even know anymore what you mean with the strings part my brain aint processing englisch explanations anymore

#

augh i lied i also have a whole new block of dialogue blank loads i gotta add as well

vernal crest
# ornate trellis I dont even know anymore what you mean with the strings part my brain aint proce...

Like you know how you have the key Strings\\schedules\\MermaidCalliope:lostisland.000 in your schedule? You could make that Characters\\Dialogue\\MermaidCalliope:schedule.lostisland.1* instead and put the line in her regular dialogue file instead of a strings/schedules file.

*Replace MermaidCalliope with her actual internal name which I hope is prefixed with your mod ID like best practice recommends.

ornate trellis
#

sweats

#

shes just...MermaidCalliope runs

#

listen idk where I am anymore ok I am so deep in the sauce I fear changing things to more uniform because by now idk where all the places are where i used certain tokes and internal names and stuff evaporated

#

i think i gotta go through my stuff first before i work on more

vernal crest
#

Is this going to be an update to your existing fishmonger mod or its own new mod that Constance will be migrated into?

ornate trellis
#

an update

#

thats why i am reluctant to change internal names and stuff

#

at least for anything constance related

#

since her internal name is just TheFishmonger for example

lucid iron
#

You can use former names if you want

ornate trellis
vernal crest
# ornate trellis thats why i am reluctant to change internal names and stuff

Chu's suggestion is a good one but even if you discover that there are some IDs that you can't change without breaking things, I think it's still better to have all of your new things be done according to best practice even if it means there's a bit of inconsistency. To take SVE as an example, they've got a mix of stuff that's current best practice and stuff that isn't and it is annoying but not nearly as annoying as it would be if they had decided not to adopt best practices where they could.

I'd be happy to help go through all your stuff to update it and check for broken things, by the way. I've got a very good eye for detail in text (for the most part - sometimes my ADHD has to butt in and cause me to make fantastically embarrassing errors but even accounting for that I'm still strong in this area lol)

tiny zealot
#

always in favor of more modders drinking the {{ModId}} sauce. almost no one uses it for NPC internal names and it disheartens me

vernal crest
#

Ichor guess what

ornate trellis
#

i am a fan of {{ModID}} but i think the more stuff i added the more i got lost in it....

#

i tried putting all my includes in the same block in my content.json and i am still finding more

#

i am really starting to believe i do need help cleaning my stuff up in all these jsons

vernal crest
#

It's okay to need help! You're a very strong artist and if the json side is more difficult for you that's very understandable. I need a lot of help on the art side of mods.

vernal crest
tiny zealot
#

high five 🫸🫷

ornate trellis
#

i think i just kicked myself in the shin i accidentally deleted half a code block

vernal crest
#

Ctrl z is your friend

lucid iron
#

Void do you have version control setup

ornate trellis
#

do i have what

vernal crest
#

Anyway I'm going to bed now but my offer still stands Void so let me know if I can help! You can ping or hop in my thread or DM if you want to take me up on it SDVpufferheart

lucid iron
#

I guess not then Dokkan

ornate trellis
#

I might....ill try and see how i gonna do rn but youll know if i went insane or not xD

#

idk what that is chu i dont always know the englisch terms for things

#

i also jsut use notepad++ if that matters in the context

lucid iron
#

Version control is some kinda system to keep old versions around

#

In modding context it usually means you make a git repository and commit your changes

ornate trellis
#

git, huh

#

thats a very confusing place for me

tiny zealot
#

you can keep notes of what changes you are making and travel back in time to look at older versions of your files in case of regressions. it's very powerful and useful, strongly recommend

ornate trellis
#

i do have a github account that i never use tbh

tiny zealot
#

you don't have to use git specifically but it has won the war for dominance among similar offerings

lucid iron
#

Brb versioning my next mod with svn

golden spire
#

and "git" itself is just a version control system and not specifically to do with github

tiny zealot
#

(to be clear, git has earned its victory. it is broadly better than the others, although i do love to complain about its interface)

ornate trellis
#

well, maybe ill think about it. That is....after I detangled my mess in these jsons, sigh

#

i think i gonna be busy with that for a while

gray bear
#

(how do)

golden spire
#

how do

lucid iron
#

(how do what)

urban patrol
#

i just set up a github repository for myself a few days ago with github desktop. i’m not entirely sure i’m using it correctly XD but it’s been fantastic to be able to access and change files on my laptop AND desktop

gray bear
lucid iron
#

So for git specifically you can install git itself then git init in some existing folder you have

#

After that, add all files you want to track with git add <whatever> and lastly git commit -m "some message like initial commit"

#

There's various GUI that does what I'm describing in the back, sourcetree, github desktop etc

#

vscode git integration can probably do it too but i don't know where the right buttons are for any of these

tawny ore
#

VSCode's git support is pretty good

#

I often prefer it to the tools that were specifically designed for git

lucid iron
#

Many options basically i just do cli cus i never learned how to do it otherwise LilyDerp

tawny ore
#

It really shines whenever I'm dealing with merge conflicts

golden spire
#

apt-get moo

tawny ore
#

LazyGit is a nice cli-adjacent tool

lucid iron
#

Bea if u want to set it up i can help u if u ping me in like 6hrs

gray bear
#

i do and def need help. but in 6 hours it will be 2 am

normal root
golden spire
#

there will be tons of quick how tos online

lucid iron
#

Yeah it's widely used not sdv modding specific

gray bear
#

i will attempt t_pray

tiny zealot
#

i would offer to help with this sort of stuff, but as usual i cannot recommend that others do things the way i do (read: the insane grognard way)

golden spire
#

I don't use any versioning at all, probably should.. but I'm soooo lazy

lucid iron
#

Ichor do u do something worse than just using cli

gray bear
#

i am also lazy, but probably should because my updates tend to break many many things

lucid iron
golden spire
#

punchcards?

gray bear
#

well good thing i made a github account a long while ago and never used it tbh_blink

tiny zealot
lucid iron
#

Oh good Dokkan

normal root
#

Another good thing about having your mod on GitHub is that people can report bugs and translate the mod for you by opening issues/prs

gray bear
#

i've never felt the need to do bc all my mods are content patcher and if anyone wants the code they can just like, grab it.

lucid iron
#

That one is secondary to having commit history to me cus most of the time no one poke my spaget

#

That is why I didn't describe part where you actually push your repo anywhere Dokkan

gray bear
#

also i've absolutely no idea how github works really. im just a worm on a string

patent lanceBOT
lucid iron
#

As long as u are commit your changes u can locally view everything

tiny zealot
#

for me it is so, so helpful to timewarp. "oh, my new update broke something? let me just see how it used to work" and you can just... diff the file between then and now, without having to like download your old version and manually compare shit. or you can just git checkout 1.4.1 or whatever your tag is and boom everything is just how it was then

golden spire
#

you don't need to use github at all.. can just have it on your local machine... depends what you are really wanting out of it

gray bear
#

time travel

tawny ore
#

GitHub (or any remote repository) is nice to have in case your computer explodes

#

Which has happened to me once

gray bear
#

i have a nasty habit of archiving absolutely nothing

uncut viper
#

also nice in case you want to check something on mobile or work on a mod from a computer that is not your usual

gray bear
#

sometimes i need to redownload my mods from nexus PensiveButtPuffer

lucid iron
#

Tbh i do that bc otherwise nexus shows update available pippleDot

ornate locust
#

I know Gil is a map tile, but if I put him as talking in a cutscene in the Adventurer's Guild, will that... work?

lucid iron
#

Like giving him a dialoguebox?

tiny zealot
#

i make a tag for every release i do, so i can always get the code exactly as it was when i built the version that users download. that's also extremely helpful when i have a bug report, and maybe i've been working on that part of the code in the meantime, so i might need to see both versions and boom, it's easy

ornate locust
#

Yeah, I'm making an event and I want him to interject.

gray bear
urban patrol
lucid iron
#

Iirc there's a event thing where you change the name and portrait

#

So you can just make whomever "gil" for a bit

gray bear
#

im going to assume i need to downlaod git

image.png
lucid iron
#

I don't know if gil has a real enough character entry to make normal way work

#

Should try both

tiny zealot
ornate locust
#

Gotcha. I'll try it the normal way first and we'll see if it explodes

normal root
ornate locust
#

I know he has a dialog gile because I found it

#

but I don't know how it hooks in

urban patrol
ornate locust
#

I had a power supply do that after a bad storm, wouldn't recommend it

#

Hell of a way to find out your house wiring's messed up though

gray bear
#

welp im stuck on step 3

#

don't got a rep to clone. do i make a new one? e_think

normal root
#

Yeah, go to GitHub and in the top right click the add button, then add new repository

latent mauve
ornate locust
#

Ooh. Cool, thanks

urban patrol
ornate locust
#

Well he has portraits that are used

latent mauve
#

He has portraits, they are used for the Desert Festival dialogue

golden spire
#

SVE,Wilford,DD,L&O,Ayeisha,LittleRSH,Sunberry,Juliet+Jessie

TownSVEplus.png
gray bear
#

so many more buildings

latent mauve
#

Gil doesn't have a 'sprite' as defined in the usual manner though, and his sprite data is mostly nulled.

urban patrol
uncut viper
golden spire
#

only in Tiled

latent mauve
#

Since Gil uses Cursors and Cursors_1_6 exclusively for his appearance

gray bear
#

otherwise he's a map patch

urban patrol
latent mauve
#

Yep, that's essentially what Gil is too. 🙂

golden spire
#

probably are some things I am forgetting and aware of a couple of things that have not been updated in ages so not included (Riley)

gray bear
#

he does use his portrait when giving u stuff in monster hunting quests

latent mauve
#

A Map tile NPC is not prevented from having a portrait. 😄

gray bear
#

atleast he tech has an option to walk away

#

Gunther is simply stuck there

latent mauve
#

Gunther's sprite is kind of like Qi's, only the front view of walking is modeled. xD

urban patrol
#

yeah mine has a portrait lol but his dialogue is just a tiledata dialogue string lmao

latent mauve
#

If you tried to make him walk to the side or up with his vanilla sprite, he'd teleport like Qi does every few frames.

tiny zealot
#

hey at least those guys have names and portraits! poor hat mouse is just a blob in Cursors and three strings

gray bear
#

tbf neither does the wizard really

#

oh wait no

#

are those walking sprites

latent mauve
#

Wizard is fully modelled

#

Now, the Governor on the other hand.

#

He is just never seen from the side ever.

gray bear
#

so is Morris, for his 2 events

latent mauve
#

or back.

urban patrol
#

even leah’s ex has full sprites i’m p sure

tiny zealot
#

wizard even has a few animation frames (some kind of meditating pose?) but the animation when he stands up in that one event is, like, coded wrong, and it looks goofy

gray bear
#

the.... the dude who sells books is also fully modeled?

#

does he go anywhere

latent mauve
#

Marcello's also the balloon rental guy from Harvey's heart event

gray bear
#

ah!

latent mauve
#

So it gets repurposed there.

urban patrol
#

a man of many talents

gray bear
#

he does it all

golden spire
gray bear
#

govenor is literally just 🧍‍♂️

image.png
ornate locust
#

why isn't- AH HECK, Loadables bites me again

gray bear
#

i mean hey grandpa in character is a single stray pixel

ornate locust
#

alright NOW let's see if this runs

gray bear
#

not much left of him

image.png
ornate locust
#

Adventurer's Guild doesn't have its own event file, gotta load that empty

urban patrol
gray bear
#

a single spec of ash PensiveButtPuffer
please don't ping me in replies

urban patrol
#

shit sorry

elfin palm
#

question! Im making some farmer hair sprites for the first time, and I have a few questions: 1.farmer assets can go outside the 16x32 square right? 2. does anyone have an example of how they organized their hair spritesheet? and making it animated is just a matter of having 2 extra hair frames per angle im assuming?

gray bear
#

i think grandpa's actual sprite is in cursors?

golden spire
#

anyone done this guy's backstory yet? or does he just work in the city during good weather

image.png
gray bear
#

he stole from the mermaid

fossil osprey
#

fandom's theory is he's a ghost

ornate locust
#

I figure he's a dead mermaid's lover

tiny zealot
#

doesn't the library book explicitly say he's a ghost?

gray bear
#

def dead

#

why is grandpa's one white pixel there anyway

#

his actual sprite resides in cursors

golden spire
#

He's not dead, he's just resting

urban patrol
tiny zealot
uncut viper
gray bear
#

rumored so not confirmed but probably

golden spire
#

scooby doo

elfin palm
#

ah, I figured since a bunch of FS mods go outside the square we could too

golden spire
#

unmask him

#

and you find out it's Lewis

gray bear
#

well if ur using FS you can

uncut viper
#

nope. FS does it's own completely separate stuff

gray bear
#

i think you're gonna need that for if u want animated hair anyway

#

don't think the regular game has that feature

uncut viper
#

you can't just add extra frames willy nilly so yeah I think you need FS for that too

#

in general you cannot just add extra things somewhere they aren't usually, when it comes to using vanilla assets

gray bear
#

game doesn't like that™️. like if u want a bigger portrait u need a special framework

crude plank
#

I would like to formally thank Khloe for leaving the honk button in BGM SDVpuffersquee

gray bear
#

stardew has become untitled goose game 2

crude plank
#

it indeed makes the game menu... better

rancid musk
#

I plan on having that trigger some debug logging at... some point. Just so I can make people go hit it.

crude plank
#

"let's figure out what's wrong, just honk for me please"

ornate locust
#

can you pass more than one token into i18n and what would be the format for that??

flat sluice
ornate locust
#

Aha thank you. Ironically yes, I am also gendering the wizard

flat sluice
golden spire
#

gif comparison

Towncompare.gif
ornate locust
#

I've already set my own, I just hadn't used more than one in a single key before

golden spire
#

probably should do the beach/forest another time

ornate locust
#

:|

#

why did that cause the event to just not fire

#

heck

#

it was firing before, just not passing the token right... now it's not- why. It's not even throwing errors, give me information

golden spire
#

does the event exist if you patch export the correct Data/Events/File ?

ornate locust
#

it does not. Inexplicably, it gives me some grandpa events, not not that one

ocean sailBOT
#

@ornate locust You leveled up to Farmer. You're now a prettier shade of blue. Thanks for sticking around!

golden spire
#

so it's not being patched in for whatever reason, rather than a problem with the event triggers

ornate locust
#

it was working before I changed the tokens... Could that just cause it not to patch in at all?

#

{{i18n:MV.Municipal.GuildIntro.06 |RasJob={{Lowercase:{{RasJob}}}} |RasGenderHe={{Lowercase:{{RasGenderHe}}}}}} like this is what I'm doing

#

is it different in events or something?

#

wait I think I found a typo

#

cross fingers

#

nope. Ugh. I have errands to run, I'll figure it out later.

faint ingot
golden spire
#

you do

golden spire
faint ingot
#

Oh like just add an image of one to the exterior and you do the rest?

golden spire
#

yes, I'll let you choose whether to have a standard box, if you want a "maislot" in the wall.

#

I'd imagine a "police station" probably wouldn't just have an external mailbox.. 😛

faint ingot
#

probably a mail slot is fine I'm adding a garbage can next patch to the one tile that isn't used by the station repair event

latent mauve
#

I might take inspiration from Ayeisha to have Malon do Lon Lon Milk deliveries to residents in my Zelda mod. xD

golden spire
normal root
#

If I’m editing buildingdata in c# and I’m making a new upgrade for a building and I’m changing building.IndoorMap, do I do it like assets/Greenhouse1.tmx? the assets folder is in the same directory as my DLL file

ornate locust
#

and now we are back to why is this event exploding

#

I have a rice krispie treat, it is time for science

gaunt orbit
normal root
#

Oh ok thank you so much!

gaunt orbit
#

Let me know if you want help or advice for that

ornate locust
#

Okay, so can you pass tokens into i18n in events at all? Because if I remove the bits for the tokens... the event loads

#

It doesn't load at all if I add the bits that hook up the tokens

latent mauve
#

Typically it's safer to not include your tokens inside an i18n (because you don't run the risk of someone accidentally translating your token), but I don't know that it would stop it from working if it's implemented correctly.

ornate locust
#

Like it won't even patch in AT ALL if there are tokens passed into there

latent mauve
#

do your tokens parse on their own?

ornate locust
#

Guess that's my next stop on this

latent mauve
#

try patch parse <token> to see if you can get it to work.

ornate locust
#

ah thank you

whole raptor
latent mauve
#

patch parse "assets/{{Variant}}.{{Language}}.png" "Pathoschild.ExampleContentPack"
and
patch parse "assets/{{Season}.png"
are the examples from Content Patcher's documentation.

#

the first example has the mod ID in it as the second argument, which is needed for dynamic tokens, IIRC

ornate locust
#

Yeah my tokens are working

latent mauve
#

I'm wondering if your format is just wrong because of how i18n works

golden spire
ornate locust
#

and I had read that part of the content patcher stuff, it looks like that

latent mauve
#

Right, but what is your actual translation?

#

Does it use all of those tokens in it?

#

Also, you are using EditData and not Load for the event code, yes?

#

!mh

ocean sailBOT
#

For help with modding issues, please ask in #1272025932932055121! When asking for assistance there, sharing an error log will help others identify your issue (see https://smapi.io/log for instructions).

To use this command, type !mh.
pine elbow
#

ty

ornate locust
latent mauve
#

only other thing would be the Lowercase, but again, I'm not entirely sure how that works or if it would stop it from working.

ornate locust
#

I tried removing that and it didn't help

latent mauve
#

hmm

ornate locust
#

the only thing that fixed it was removing the bits that pass through the tokens

#

And obviously the text is messed up that way, but the event loads

latent mauve
#

and it's only broken in events?

#

maybe someone else who's played with events more could chime in, but is it possible that there's a symbol that needs to be escaped somewhere because the event is a slash-delimited thing?

ornate locust
#

I've used one of the tokens in dialog and it worked, yeah

latent mauve
#

did you post your event code already?