making-mods-general

[haughty tusk]

One message removed from a suspended account.

[woeful lintel]

Ok, so I'll try to make a custom MaxDict class based on Dictionary that keeps track of the max, so that I have Add and Last in O(1) and Remove in O(n)

[tiny zealot]

yes, ModBuildConfig/SMAPI knows where to look for SDV in particular default game paths. if you have it somewhere else, you need GamePath

[haughty tusk]

One message removed from a suspended account.

[woeful lintel]

But if I have time later I'll try making a MaxSortedDictionary as a binary tree that also keeps track of the max in O(1) in Add, Remove and Last

I wonder if it's possible to go into the innards of the SortedDictionary to directly have access to the binary tree's nodes

[granite bluff]

did they change the name of the JoshHouse map, eventually?

[hallow prism]

no, it would break compat with lot of stuff

unless you mean something else than CA/the game by "they"

[granite bluff]

oh i recognized a big bed was added and my map overlay won't load... so i thought the map may have been resized or it's name changed to AlexHouse or so.. 🤔

where do i get the new original maps again? it's too long ago. maybe i will find the error by comparing them

[tiny zealot]

!unpack unpack your content folder for the original maps

[ocean sail]

Follow this guide to unpack the game's content files in order to see and explore how the game data is structured.
It's helpful when making your own mods, or just to learn about how the game works!

To use this command, type !unpack.

[woeful lintel]

@calm nebula what do you think about that? I'd like your opinion before committing to this (especially because I'm not sure I fully understand C# inheritance rules)

class MaxSortedDict<TValue> : SortedDictionary<int, TValue>
{
    int max_key = int.MinValue;

    new public void Add(int key, TValue value)
    {
        if (key > max_key)
            max_key = key;  // O(1)
        
        base.Add(key, value);
    }

    new public void Remove(int key)
    {
        base.Remove(key);

        if (key == max_key)
            max_key = Keys.Max();  // O(n)
    }

    public TValue LastValue()
    {
        return this[max_key];  // O(1)
    }
}

[blissful panther]

I assume this is to avoid LINQ's .Max()? If it is, I have zero additional input!

[lucid iron]

What if u put the thing in a dict and a heap

[woeful lintel]

I don't really understand how, nor what it would achieve

oh, like the keys of the dictionary in a heap?

[haughty tusk]

One message removed from a suspended account.

[woeful lintel]

it feels like it would be as costly to remove keys from it tho

[haughty tusk]

One message removed from a suspended account.

[woeful lintel]

you can choose the mod dir

I do this: SMAPI_MODS_PATH="Mods (dev)" "$SVPATH/StardewModdingAPI"

[haughty tusk]

One message removed from a suspended account.

[tiny zealot]

not required. you can just make a copy of your game folder and run from there

[haughty tusk]

One message removed from a suspended account.

[blissful panther]

There is no DRM on the Steam version, so it's not even a factor.

[haughty tusk]

One message removed from a suspended account.

[haughty tusk]

One message removed from a suspended account.

One message removed from a suspended account.

One message removed from a suspended account.

[knotty phoenix]

I think CA is a pretty cool guy. He leaves out DRM and doesn't afraid of anything

[near sierra]

Right now, in the mod my team is creating, we're trying to gain the ability to create events in a new area to this mod. However, one of my partners tried this, and it didn't work. How should we go about making it possible to create events in a new area to our mod?

[hallow prism]

load an empty file

then edit it

i assume you are trying to edit the file to add events, which doesn't work in new areas because the file doesn't exist yet

so you create it (by loading it) then edit it (to add the events)
In this way because tokens don't work on load, and people usually do use tokens (if only for translation), so it'll save you an headache later

[near sierra]

Okay. Thanks.

[hallow prism]

sure, if it doesn't work you can return and show the code 🙂

[near sierra]

Right now, my partner is trying to load a JSON file associated with the map that doesn't exist. I know that some file systems, like the one in C#, when writing to a file, will just create it if it doesn't already exist in its directory. Does Content Patcher also do this?

Plus, I'm thinking we actually need to go into the .tmx file associated with our new map, rather than creating a JSON file for the events, given how the other events are handled.

[fierce pine]

might be a bit stubborn but is there another tool to convert json only to xnb

tried to XNBArchive i don't think it works in 1.6+

[hallow prism]

no, if you edit a non existing file it doesn't create it with CP

[near sierra]

Okay. So I should just create it manually in the right directory, then?

[hallow prism]

(pls don't ping me on reply) yes as i suggested

[near sierra]

Understood.

[velvet narwhal]

Xnbs will get overrun by content patcher mods.
Will break upon any whisper of the wind
And are highly incompatible with any other mods.
There aren't many converters because it's not a reasonable choice for PC mods.

[fierce pine]

is whisper of the wind an expression or the name of something

[velvet narwhal]

An expression

[fierce pine]

oh okay

[velvet narwhal]

One minor patch of the main game will break an xnb

[fierce pine]

i guess i'll just revert the xnb weird stuff i've done then lol ;v;

[near sierra]

So how do I go about this, then? What file type do I store events associated with our new area in?

[hallow prism]

how are you making your mod currently?

[velvet narwhal]

huh?-

if you're using content patcher, it's all newtonsoft json

[tiny zealot]

conversation collision

[velvet narwhal]

i see, i am a victim of war

if you're using c# you can just load a new blank .json asset into the specified filepath -> Data/Events/<YOURMAPNAME>

[near sierra]

I see. I’ll try that.

[near sierra]

So I do use JSON for this.

[scenic heath]

How would one go about creating a new seed item via content patcher, or is that at all possible? I've not done any Content Patcher modding before.

[velvet narwhal]

!unpack

[ocean sail]

Follow this guide to unpack the game's content files in order to see and explore how the game data is structured.
It's helpful when making your own mods, or just to learn about how the game works!

To use this command, type !unpack.

[velvet narwhal]

https://stardewvalleywiki.com/Modding:Items#Objects
you'll need to create the seed / harvestable crop item

https://stardewvalleywiki.com/Modding:Crop_data
as well as connecting said crop

[fierce pine]

wondering
is there a file with like the translation of each name or word that i can just edit

[scenic heath]

That's the i18n folder, isn't it?

[velvet narwhal]

i don't understand what you mean by translation of each name

[hallow prism]

#making-mods-general message this sounds like a good start

[near sierra]

Here's the current file structure (At least, the parts that would be relevant to this question):

[hard fern]

i18n folder has all the "things" to be translated, and in the actual dialogue is where you'd have them appear depending on language right?

[hallow prism]

i do not want to be pinged and i don't have time to look at the moment

[velvet narwhal]

since it's all content patcher, you need to use https://github.com/Pathoschild/StardewMods/blob/develop/ContentPatcher/docs/author-guide.md#actions the load action
with a blank.json that is quite literally { } in said json, load that file into your data/events/<mapname> and you'll be able to editdata events into that location

[scenic heath]

I had a look at that one, it seems to edit a crop in another mod, I did just find this one that has the Object and Crops folders, which seems closer to what I want

[hallow prism]

congrats on managing to search

[velvet narwhal]

names are determined by data/characters in their internal name https://stardewvalleywiki.com/Modding:NPC_data#Main_data
and then translated to the strings data file

[scenic heath]

Sorry, I've not done content patcher modding before, I used json assets many years ago and not done any modding since then. Was just trying to wrap my head around how to do things properly in the current game.

[hallow prism]

it's ok to want to learn, but if you already know what you need, asking here will only slow you down

if after looking at stuff you ask questions it's far more efficient

(especially with example)

[fierce pine]

e
not by their name in NPCNames?

[velvet narwhal]

i don't know what reserialized xnbs look like, nor do i care to find out, it's determined (via json reading and c# reserialization) through the "DisplayName" field

[rain basalt]

Most CP is structure and data insertion so if you find another mod similar to what your trying to do you can open it to see how the structure works, make edits and see what changes then create your own mod based on what you learn.

Then bug us in chat when you run into problems lol

[fierce pine]

because like this sounds logic but it's wrong

[velvet narwhal]

is there a reason why you're hellbent on xnb? if you're modding for console then it makes sense, but if you're modding for pc it makes less sense

[whole raptor]

It makes NO sense...

[rain basalt]

!xnb

[ocean sail]

XNB mods often break the game and are not recommended. See:

• using XNB mods for more info and a list of Content Patcher alternatives;
• reset your content files to fix problems caused by XNB mods.

For mod creators, see editing XNB files for help unpacking & editing them (including for use with Content Patcher).

To use this command, type !xnb.

[velvet narwhal]

content patcher is quite literally less than 100 letters in a mod to change the displayname of an npc

[fierce pine]

i don't really know tbh ;_; it just sounds a bit easier to edit its xnb

[velvet narwhal]

it's more work, actually

[whole raptor]

!znbzola is more appropriate here

shit...

!xnbzola

[ocean sail]

XNB mods often break the game and are not recommended. See Modding:Using XNB mods for more info (and a list of Content Patcher alternatives), and you can reset your content files to fix problems caused by XNB mods.

For mod creators, see Modding:Editing XNB mods for help unpacking & editing them (including for use with Content Patcher).

To use this command, type !xnbzola.

[hallow prism]

xnb are only easier to edit in short term thing, but not on complex things, and they are way harder to debug

if only in hope to get help, using CP is more reasonable

[rain basalt]

Not at all lol CP is like edit data then target file name then New name like a-souron said CP can be done in 100 lines or less for basic edits

[hallow prism]

it's not that people will not want to help for XNB (even if it's a factor), it's that it's not really possible to know what's wrong

[rain basalt]

Xnb you have to unpack make edit repack pray debug try again delete all game files reinstall game files try again pray o god it works

[gaunt heath]

And god help you if the game updates

Which it will

[rain basalt]

The dark days of stardew modding

[velvet narwhal]

god help me the daily beta updates

"did something break today?"

[gaunt heath]

Pathos appeared and showed us the light

[whole raptor]

https://tenor.com/view/dark-souls-praise-gif-25000256

[blissful panther]

Wow. CP didn't exist until 2018?

[hallow prism]

i modded the game before CP happened

and got burnout by making manual variations of stuff

overlay is what made me return to modding

(when i discovered it)

[velvet narwhal]

god i remember all of the xnb npcs and thinking "damn this a lot of work"

[rain basalt]

Speaking of beta need to report a bug to one of the authors lol it says update available yet there’s no update so smapi just says screw it

[blissful panther]

When it happened...

[velvet narwhal]

came in 2018, usurped a lot of frameworks in the wake of 1.6

[rain basalt]

1.6 was a god send

[velvet narwhal]

i just thought of a brand new meme hold on

[next plaza]

Fun bit of history: Pathos asked if I wanted to add xnb editing to JA back then. If I had said yes, we probably wouldn’t have Cp today (and JA would definitely not have reached CPs full scope)

[velvet narwhal]

casey being the first butterfly flap

[hallow prism]

casey was also the butterfly flap for the item id change in 1.6

[next plaza]

I’m secretly a butterfly not a cat I guess

[lucid iron]

What would xnb editing in ja look like

[rain basalt]

🦋

[next plaza]

Much more limited, doubt I would’ve come up with even half of CPs features

Like tokens

[lucid iron]

Well tokens wasn't in cp 1.0 either right

[rain basalt]

Ug why is spacecore beta not working

[next plaza]

I’m too lazy to go in git and check

Did SpaceCore break again

[rain basalt]

Smapi says so

[next plaza]

Or are you using the nexus build which is out of date

[rain basalt]

I’m
Redownloading mabey I’m using old build again

[velvet narwhal]

what's latest beta build? 1.26?

[next plaza]

The newest build I only posted on discord

[rain basalt]

1.6.9

[brittle pasture]

1.25.3-beta from Nexus also didnt work for me last night

[velvet narwhal]

sorry i meant that @ casey

[next plaza]

Search for has:file from:kittycatcasey and find the most recent one I uploaded

I should
Probably fix the nexus build at some point

[velvet narwhal]

(1.26 says outdated)

#making-mods-general message

[next plaza]

That one doesn’t work?

Big sigh

[velvet narwhal]

[SMAPI] - SpaceCore 1.26.0 because it's no longer compatible. Please check for a new version at https://www.nexusmods.com/stardewvalley/mods/1348 or https://smapi.io/mods yeup

[next plaza]

Could you find the entry in trace and tell me what’s broken?

[rain basalt]

Someone should pin that lol

[next plaza]

Remind me in 8 hours to fix SpaceCore for 1.6.9 beta

[patent lance]

But of course, dear kittycatcasey (#6323364) (8h | <t:1729899406>)

[rain basalt]

Timer started lol

[velvet narwhal]

[08:35:40 TRACE SMAPI] Broken code in SpaceCore.dll: reference to Netcode.NetList2<SpaceCore.Dungeons.SetPieceNetData,Netcode.NetRef1<SpaceCore.Dungeons.SetPieceNetData>>.RemoveWhere (no such method).
(pinging so that it goes into your inbox)
https://smapi.io/log/7b12361e4bde419c84178442ed323436?format=RawView
#making-mods-general message

[next plaza]

That should’ve been fixed already?

[blissful panther]

I genuinely wonder what the landscape would look like now if it had gone the other direction...

[rain basalt]

Mabey you fixed after you uploaded code lol

[next plaza]

A lot less flexible and accessible for non programmers

[next plaza]

Nah, because I remember blueberry pinging me with this exact error

[velvet narwhal]

oh i didn't build from your source if that makes sense

[rain basalt]

I’ve grabbed wrong files and zipped to nexus before specially when I keep like 7 of the same version with different edits

[next plaza]

I mean, I just use the version the mod build config packages for me

[rain basalt]

Sad part is I don’t use space core .yet for my mods was gona start looking at using though for an idea I’m working on so wanted to play with it in beta 😉 so 7 hours 53 min and counting

[hallow prism]

well play with it in non beta and be patient

[velvet narwhal]

oh

i see

[rain basalt]

I’m always patient but I’m prepping my mods for 1.6.9 so no playing yet

[hallow prism]

yeah putting pressure on mod authors is the summum of patience

[velvet narwhal]

#making-mods-general message

[rain basalt]

lol they asked to be reminded in 8 hours to fix it

[whole raptor]

1.6.9 is only gonna affect C# mods, right?

[velvet narwhal]

THERE WERE TWO 1.26.0'S

[rain basalt]

Well some yes but also should add new files to play around with as well

[velvet narwhal]

yes, and uh, flavored item colored sprites iirc for cp

[lucid iron]

Fish pond data changes

But CP has compat stuff I think

[rain basalt]

Was it just pond or map as well

[velvet narwhal]

update: i have found your second 1.26.0 and that one is just fine, so you're gonna just get dinged by uber for no reason

[calm nebula]

Looks fine. I would need to know more about expected usage to have intelligent comments

[next plaza]

.timer remove 6323364

[patent lance]

Timer removed.

[rain basalt]

Dang lol

[velvet narwhal]

oh nice no more ding

[rain basalt]

Link the proper file if you can plz lol

[next plaza]

Might want to link the newer build here so celestial can access it

[velvet narwhal]

yeah one sec

[rain basalt]

[velvet narwhal]

#making-mods-general message

i had to like, backtrack through blueb's messages because for some reason hasfile didn't find this one

[rain basalt]

Hmm 🤔 if someone has the power to pin it we could reference it till Casey updates on nexus

[next plaza]

I could pin it

[velvet narwhal]

i have it stowed away somewhere in my own discord

[next plaza]

But I’m not sure if that makes sense

[velvet narwhal]

tbh i just take discord links like that and stash them somewhere like a squirrel with nuts

[next plaza]

Ideally I’d just update the nexus build

[rain basalt]

lol I used to do that had a whole excel spreadsheet once but then I had to start searching the spreadsheet

[velvet narwhal]

though, now we have forwarding

so if you do have some kinda personal data dump discord you can just forward it

[rain basalt]

🤔 I realy should make a discord for my projects lol I have like 30-40 private chats going for them

[calm nebula]

You're important enough❤️

[blissful panther]

My clicky finger's hovering over that pin button.

[woeful lintel]

It feels so good to finish a huge chunk of a rework

I don't have to touch the config setup anymore

It's almost 2 a.m., I'll do asset requests tomorrow

[gaunt heath]

(I also encountered this yesterday and assumed you knew already)

I've been goblining around with the custom light masks. I just dropped down to the main Stardew version to work on them for the time being

[lofty ruin]

Can y'all tell me what to change in order for this to work? https://smapi.io/json/content-patcher/10feea4fbde447f393ca41ee9043664c

[velvet narwhal]

wdym work

[lofty ruin]

Because my NPC hasn't been able to talk

[velvet narwhal]

has it been "..." or is it some other error, cause if your npc spawns that means it's working as intended afaik

[blissful panther]

Is your test save still within the window for the Introduction dialogue key to exist?

[lofty ruin]

My NPC spawns and his schedule works, but you can't talk to him at all

Not even the text box shows up

And there's no error alluding to a possible problem

[blissful panther]

Okay, it's not my thought then!

[lofty ruin]

Yup

[velvet narwhal]

it's probably just because there's no dialogue lines to pull from since all of your keys are ""

you can circumvent it if you don't want to write anything by replacing the string with an i18n key

so instead it just brings up a (no translation)

[hallow prism]

hmm

[lofty ruin]

But even the introduction doesn't show up

[hallow prism]

at some point npcs with no dialogue would default to "hi"

[velvet narwhal]

could also be your data/character in itself, but i assume you have it set to CanSocialize: true

[hallow prism]

it's also possible your npc internal name is {{modid}}_aven and it's why it's not working

we'll need the full json

not bit of them

[velvet narwhal]

tis a reason why the npc command has several examples and is a scrolling nightmare

[swift arrow]

where do i put the smapi mods manually

[velvet narwhal]

are you creating a mod or did you want to play modded?

[swift arrow]

i wanna play modded

[velvet narwhal]

!getstarted

[ocean sail]

If you would like a guide to setting up mods for Stardew Valley, check out the getting started guide! https://stardewvalleywiki.com/Modding:Player_Guide

To use this command, type !getstarted.

[velvet narwhal]

and this is the place for making mods, you'll want #modded-stardew

[swift arrow]

thanks

[rain basalt]

just had a panic attack logged into vortex to check messages and had 99+ missed alerts was like wth was a site glitch not clearing read messages lol

[tepid escarp]

Is there a way to stop dating someone in an event, if so, what would the command be please?

[velvet narwhal]

spacecore handles that

https://github.com/spacechase0/StardewValleyMods/tree/develop/SpaceCore
setEngaged npc asRoommate weddingOffset - npc = NPC internal ID, asRoommate = true if this is a roommate, false otherwise,

[rain basalt]

asking programing wise or just want to dump your partner in general

[velvet narwhal]

i assume via eventcommand, which is, a spacecore feature and isn't vanilla

[lofty ruin]

(Content.json) https://smapi.io/json/content-patcher/8480811414d14b9ca16f3967456a5750

(manifest.json) https://smapi.io/json/content-patcher/75eb2200c00d4273851fdf44f60c0c9c

[velvet narwhal]

what does your dispos.json look like

[lofty ruin]

https://smapi.io/json/content-patcher/ce6143b8e1d5467582056b7b7176a7bb (Dispos.json)

[tepid escarp]

Ah thank you, thought it was just via content patcher

[rain basalt]

missing alot of charecter info if you compare it to normal charecter data

[velvet narwhal]

technically the npc shouldn'tve spawned because it doesn't have an actual 'home'

[vernal crest]

I thought they spawn in Town by default if their home isn't set

[uncut viper]

if they have no home they get put in Town at x29, y67

[velvet narwhal]

yeah but i don't remember if they get auto-set to a simplevillager or not if they don't have a home

[vernal crest]

Given that it's an optional field, I doubt it

[velvet narwhal]

unsure what other thing isn't being active for the npc to be there, but dialogue isn't
even if it's empty strings it'd still give a smapi error of said empty string

[latent mauve]

can you upload your dialogue JSON as well?

just in case

[vernal crest]

#making-mods-general message

[latent mauve]

oh, I missed the dialogue file then

sorry, just saw the last few

Ah!

[hallow prism]

well, i would change for a more solid name, but indeed maybe the social thing is needed for the dialogue as someone suggested

so i would try that

[velvet narwhal]

it's set as default: true so i don't... think? that's it

[latent mauve]

CanSocialize is definitely needed, but is True by default.

[hallow prism]

hmm

the thing is, i remember something weird about needing gift taste for can socialise (or so i do believe) BUT

non social npcs can have dialogue so

[reef palm]

Intro won't fire if you don't have gift tastes.

[hallow prism]

is it true for all CT?

[reef palm]

Yep!

[velvet narwhal]

is the gifttastes.json empty then?

[reef palm]

It's how I found I missed my gifttastes include when I converted to 1.6 lol

[latent mauve]

Yeah, that was gonna be my next question, if there isn't a required fallback key for dialogue (which I don't see anything about, so I don't think there is!)

[hallow prism]

no idea what's in the include

i'm not even sure i saw a log

[latent mauve]

I didn't see one but I missed the dialogue one too

[vernal crest]

They didn't share a log

[uncut viper]

(that said though I didn't get any errors for my quick NPC when there were no strings at all causing them to not speak so I don't know if SMAPI would care about them being empty?)

[vernal crest]

I just checked and empty strings still show the dialogue box

[uncut viper]

fair nough

[latent mauve]

Dialogue isn't required for NPC load at all, but GiftTastes typically is

[hallow prism]

(i will step back a bit)

[lofty ruin]

Yup

[velvet narwhal]

weird, i thought an empty gifttaste would default to the npc not spawning at all

[latent mauve]

It's meant to

[hallow prism]

npcs can be antisocial

[reef palm]

Anti-social NPCs can have no gift tastes

[velvet narwhal]

well default, this one is social

[latent mauve]

^

[velvet narwhal]

since the field wasn't specified

[vernal crest]

!log Can you share your log, please? After you've tried talking to your NPC.

[ocean sail]

Important note: Your computer username may appear in the log. If your username is your full name, please be aware of this before uploading it.

Please share your SMAPI log file. To do so:

1. Open this page: smapi.io/log.
2. Follow the instructions at the top of the page to upload the log file. (Don't copy & paste from the console window!)
3. After uploading, it will show a green box with a URL to share. Post that URL here.

Please do it even if you don't see any errors. This has useful info like what mods and versions you have, what the mods are doing, etc. If the issue didn’t occur in your last session, please load the game to the point where the issue occurs, then upload the log.

To use this command, type !log.

[uncut viper]

aren't ItemDeliveryQuests and Winter star participants supposed to be GSQs?

[lofty ruin]

I have this as well

That works just fine

[velvet narwhal]

true/false/null/gsq iirc

[hallow prism]

(i prefer no ping when i'm stepping back of a discussion)

[uncut viper]

but it would still need to be a string, right?

[velvet narwhal]

well gsqs are bools, so... no?

[uncut viper]

GSQs are strings

[lofty ruin]

Which one? Dialogue?

[uncut viper]

They resolve to true or false but it's a string that gets parsed

[vernal crest]

Not your json, the log. Read this and follow the instructions: #making-mods-general message

[uncut viper]

Otherwise you couldn't write a GSQ there

[velvet narwhal]

mine is "WinterStarParticipant": true,

(but i also have the winterstargifts set)

[vernal crest]

Mine is also "WinterStarParticipant": true,

[velvet narwhal]

i think if it's set into a string, it'll tryparse bool? i honestly don't know how it deals with it

[uncut viper]

it's possible that the game checks if it's a bool too and sets it appropriately, I wasn't sure and can't check right now but it was the only thing I could think of to suggest looking at

If something is a GSQ you cannot just try parse it and store as a bool

[uncut viper]

If you wrote "SEASON spring" as your GSQ for it that makes no sense to store as true/false permanently

[velvet narwhal]

i treat spousewantschildren/spouseadopts the same exact way, if i wanted it to be a gsq i throw quotes, if i just wanted the true/false i leave it quoteless

oh true

y'know i'mma just dig into it

[uncut viper]

then the game probably does just check if it's a bool and sets it to the bool in string form instead I imagine

[rain basalt]

for some reason that reminds me of Einstein

[uncut viper]

because the field is a string. you can't store a bool in a string field

[latent mauve]

Yeah, I even noted in my NPC Builder sheet that "WinterStarGifts": [ ], should be used by default if no specific values for the gifts but WinterStarParticipant is anything but false, to prevent errors.

Which I noted because of the wiki, so that is a thing even if I'm not sure why right now.

[calm nebula]

This actually CP magic

Everything is actually a jtoken

[velvet narwhal]

shit i love CP magic

[uncut viper]

there ya go then. CP magics it into a string

[calm nebula]

It just parses it

[uncut viper]

but can't handle my vector2s...

[velvet narwhal]

CP: It Just Works ™️

[uncut viper]

in which case I've got nothing else for the NPC error

[vernal crest]

Hopefully once they get a log it will help

[velvet narwhal]

even if i don't use the fields for my npc, i just include them either as nulls or empty lists cause like

it doesn't harm me, and who knows, maybe i'll add it later

[vernal crest]

Welp, it is way too late at night for me to wait for them any longer

Good luck y'all

[velvet narwhal]

do enums care about caseSensitivity?

wait

BirthSeason (Optional if non-social) The season name (case-sensitive) for the NPC's birthday. One of spring, summer, fall, or winter. Default none.

so it should be Summer instead? cause both of my NPCs have the capitalized version

[latent mauve]

I mean, my NPC Builder makes them capitalized as well and Aba didn't mention that throwing an error when they tried it out.

[velvet narwhal]

i go check that

[latent mauve]

I can go peer into Data/Characters base files again

[velvet narwhal]

i came across it because uh

[latent mauve]

it's capitalized in the unpacked Data/Characters vanilla file

sooooo

[velvet narwhal]

i can't tell if it does or doesn't care

i gotta try on a different npc

[latent mauve]

I mean, it's not broken any of my character edits that just change those dates xD

[velvet narwhal]

hmm yep that ain't it

welp there went my idea

OH NO

unrelated, sorry i laughed viscerally

[lofty ruin]

Very late to this but here's the log

https://smapi.io/log/c9d8ee7a74794558aa5862ae492798eb

[ocean sail]

Log Info: SMAPI 4.0.8 with SDV 1.6.8 build 24119 on Microsoft Windows 11 Home, with 22 C# mods and 29 content packs.
Suggested fixes: One or more mods are out of date, consider updating them

[velvet narwhal]

when working with an npc, your best bet is to do it in isolation

unless you specifically need a framework like sprites in detail or spacecore

[lofty ruin]

You think it might be a mod that's messing with the dialogue?

[velvet narwhal]

i'm not seeing any errors [14:43:26 TRACE SMAPI] Content Patcher loaded asset 'Characters/Dialogue/Aven' (for the 'Aven - Custom NPC' content pack).

[lofty ruin]

Me neither

That's why I figured my best bet was to ask here

[velvet narwhal]

winterstar shouldn't be affecting dialogue, because it made the npc spawn
the portrait and the character loaded
the data/character, data/npcgifttaste, character/schedule all loaded

[latent mauve]

just to confirm, you don't have the Aven NPC excluded from "Socialize" within Custom NPC Exclusions, right?

[lofty ruin]

Schedule.json ( https://smapi.io/json/content-patcher/fc49012ca66e40c592fb44c0d3ee2d46)

[lofty ruin]

I don't think so

Lemme check

[velvet narwhal]

if the schedule is included then you need the editdata action

did you say they're not moving, at all?

[lofty ruin]

Works just fine though

Yeah

He moves

[latent mauve]

Did you upload the whole Schedule JSON or just copy/paste the entries?

[velvet narwhal]

oh

[lofty ruin]

That's the whole schedule

That's all that's in the file

[velvet narwhal]

that's.... strange

[latent mauve]

I know you loaded blank.json for the Schedules target, but you are missing the action to actually use the schedule values once you've included Schedules.json, I think?

I'm honestly confused at what I'm looking at

[velvet narwhal]

same

[14:42:57 TRACE SMAPI] Content Patcher edited Characters/schedules/Aven (for the 'Aven - Custom NPC' content pack).```

is content patcher doing magic on it's own

[latent mauve]

maybe?

It shouldn't be doing that

[uncut viper]

when i asked this morning they said their schedule.json had EditData and stuff in it, did you change it Kerain?

[latent mauve]

I was expecting something like:

"Target":"Characters/schedules/Aven",
"Entries":{
  "Spring_1": "800 BusStop 10 15 0/1200 Forest 45 90 2/1800 Saloon 20 18 1/2200 BusStop 5 5 0",
  "Rainy_Day_1": "900 BusStop 10 15 0/1300 Saloon 22 18 2/1800 Home 5 5 1",
  "Friday": "800 Town 50 60 3/1200 Beach 15 35 1/1700 Saloon 22 18 2"
}}```

[velvet narwhal]

i don't think friday is even valid

it's shorthand isn't it?

[latent mauve]

yeah

Should be "Fri"

[velvet narwhal]

oh right, i was writing more pig latin that's why i had vs up

[uncut viper]

unrelated question about maps as i finalize my content entry: if im replacing a mine floor map with a custom one why does the original get to write the tilesheet image source as just "mine" (for Maps/Mines/mine.png) but I have to write "Mines/mine"?

[lofty ruin]

So no

He's fine

I even deleted some mods

[hallow prism]

because they are in map/mines

you aren't

[lofty ruin]

Yeah, because you said it was wrong

Then it started working when I changed it

[hallow prism]

they are one level deeper

[uncut viper]

no, i said the way you had it in your dialogue.json was correct (and the same concept applied to schedules.json), and to change your Load into an Include

[calm nebula]

Blame Pathos

[uncut viper]

if im replacing Mines/10.tmx for example though during the AssetRequested event, arent i one level deeper though?

(sorry for the ping)

[hallow prism]

(i pinged, it's fair)

[uncut viper]

(i like being pinged )

[velvet narwhal]

(anyone else got the spooky new discord pings?)

[hallow prism]

so you are doing C# i assume? in which case i have no idea 😄

but my theory is that stuff is applied in a way that some stuff is hardcoded for mines by the game but not for our map edits

[rancid temple]

Spooky? I've had new ping sounds for a few days now and I don't like them *grumbles about change*

[uncut viper]

yup! replacing the mine map directly as it loads cause it was the quickest and easiest way lol

[latent mauve]

Forwards don't work right for me when I try to add messages, LOL

But, Kerain, try to match your schedule json to this: #making-mods-general message ?

So the EditData is back

[lucid iron]

i think i ask this b4 too, but is there any way to disable interpolation of NetPosition temporarily

[calm nebula]

It has to do with how smapi assigns your tilesheet references when you load a map

It isn't relative to your map

But relative to the Maps djr

Hence: Blame Pathos

[uncut viper]

ah, so it is a smapi thing. got it. as long as i can be sure that im not doin anythin wrong and it works long enough to be judged im good

[hallow prism]

i wonder if having it in the mines folder would solve this, i don't remember if i got a chance to test it one day

[uncut viper]

id assume it works the same way since i effectively am doing a Load action onto Maps/Mines/10 but thats an atra question for sure

[hallow prism]

i will read stuf when back, but with (ideally just CP) can i have something like applying a map patch after offering a specific item somewhere? like in theory in an event it's doable?

[uncut viper]

if you can find some way to set a mail flag that sounds doable to me, though i think itd depend on how you were handling the item offering (unless the item offering is what you were asking about too)

[hallow prism]

(pings allowed, solutions that involves an existing framework and are easier allowed, suggesting to make custom C# is forbidden, you have 30 minutes)

[uncut viper]

yes chef /lh

[velvet narwhal]

special order? -> map patch

[hallow prism]

it's also part of the whole thing, i think event should handle this but maybe there's easier way

hmm, i want stuff to be temp, a special order each time will maybe be annoying?

[velvet narwhal]

oh you want the map patch to be temporary? i usually set fake conversation topics if i want it to have a specific amount of days

[rain basalt]

twidles thumbs sigh vortex taking forever for the final update lol

[uncut viper]

i think it might be easier in this case to brainstorm if you could explain the whole process in specifics, i think. like, do you want the item to be offered on a pedestal? just given to somewhere/something and then deleted? does it need to be a specific item? etc etc

[velvet narwhal]

looks at DH
MEEP interaction? if you wanted the tile property

[hallow prism]

So i have this old existing mod when donating a gold bar would open the passage to a new map for a day

I want to redo it with cp+ftm and possibly open for the whole week or something

It was done using tmxl and lua which is no longer an option

[calm nebula]

Spacecore trigger action?

[uncut viper]

making the map patch apply immediately would be the tricky part i think?

unless the actual entrance was on a different map from the donation spot

[next plaza]

So, I'm not sure how you could do the offerring part

[velvet narwhal]

item -> trigger action -> event -> apply map patch upon 'location change' and it should work, but yeah the offering part confu-UNLOCKABLE BUNDLES?

[next plaza]

But the immediate patch part could be done with SpaceCore's spawnables set piece functionality I think

[hallow prism]

My current solution is a bit convoluted (event checking for item and removing it at the end if choice is yes)

[uncut viper]

you could set up a mini shop with one gold bar as a trade item that gives you a ticket of some sort, then have the ticket be used with spacecore OnItemUsed to be consumed?

[next plaza]

An offerring tile action that triggers a trigger action should be easy C#

[tardy adder]

why you do dis IE?
https://smapi.io/log/708cd3fd522e451985d91d5e5bc83e4d

[ocean sail]

Log Info: SMAPI 4.0.8 with SDV 1.6.8 build 24119 on Microsoft Windows 10 Home, with 20 C# mods and 4 content packs.
Suggested fixes: One or more mods are out of date, consider updating them

[velvet narwhal]

casey is disqualified, c# forbidden

[next plaza]

Not if it's part of SpaceCore!

[velvet narwhal]

oh you'll make it?

[next plaza]

Then it counts under using frameworks

[velvet narwhal]

someone didn't nullexception

[hallow prism]

Do you have context, like what mod youre trying to do?

[tardy adder]

I don't even know why since it is an item that doesn't even use IE

[uncut viper]

pressActionButton seems like a risky thing to patch

[lucid iron]

sometimes i mixup StardewModdingAPI.Framework.SCore with SpaceCore

[tardy adder]

totem summoning MNE event

and it works flawlessly

[hallow prism]

Hmm i can definitively wait a bit if it makes thing easier in the end

[tardy adder]

so 9-9 why you red me out IE

[next plaza]

So do the users 😔

[rancid temple]

When it comes to SpaceCore, aren't we basically the users

[next plaza]

Not the mod maker users

[velvet narwhal]

i don't know how MNE works, but wouldn't you be able to just use a 'usefortriggeraction' -> triggeraction for the event ID?

[next plaza]

The normal mod users

[uncut viper]

hey i make do pretty well without spacecore ill have yo uknow

[next plaza]

Who freak out when they see any red in the console

[calm nebula]

Lollllllll

Got it

Hey Casey what happens if I patch SCore

[velvet narwhal]

my favorite is them freaking out about a 'new yellow' when they live on red/yellow errors

[tardy adder]

More like I don't freak out but rather if I release it, users will freak out 9-9

[lucid iron]

just log to info at every tick

[tardy adder]

so I'd rather not explain yes it will be red, nah don't freak out, it works

[lucid iron]

cant see red/yellow then

[uncut viper]

if you want, you can patch whatever function in SMAPI does the logging to make all output yellow or white instead of red

[next plaza]

Pathos appears out of a nearby bush and looks at you disapprovingly

[uncut viper]

then it doesnt look scary

[tardy adder]

Yeah, I am just trying to figure out why IE don't like it

[velvet narwhal]

if you can share how your totem works we can probably look

cause tbh i don't use item extensions (but i also only have a regular warp totem through spacecore)

[tardy adder]

the thing is... the totem is using spacecore >->

so idk why IE is involved...

[uncut viper]

maybe IE doesnt like it when the totem is consumed on use?

[tardy adder]

[uncut viper]

it might be trying to check the item in the pressActionButton code but spacecore already yeeted it. dunno. never used IE

[tardy adder]

IE stop checking Spacecore out

[uncut viper]

does it work if you make the totem not consumed?

[lucid iron]

you already checked that it only happens if IE is present right

[tardy adder]

Yes

[lucid iron]

even without and IE on that particular item

[uncut viper]

its a pretty solid guess tbf since its only patched by IE

[tardy adder]

Again, it works as intended, just figuring out why its freaking IE out so it doesn't freak the users out

[uncut viper]

i would still check if it errors when the totem is not consumed on use then

not saying that you should leave it unconsumable when you release. just would be good to know for letting the IE author know

if it is indeed the case

[tardy adder]

Hold my Junimo, I am gonna do more test to see how IE is happy

[uncut viper]

meanwhile if someone could convince me to finish this nexus mod page thatd be great bc thats literally been the only thing stopping me from putting my contest entry up for like 3 days

[velvet narwhal]

you can be as lazy as me with my description page

[calm nebula]

What if I commit memory crimes instead

[velvet narwhal]

roslyn comes out of the bushes instead

[lucid iron]

when is it important to implement IDispose

i was wondering if i should do that for the queued draw thing

[tardy adder]

Ah damn it doesn't like when spacecore removes item

[next plaza]

How are you removing the item

Are you using the trigger action, or the consume on use thing

[tardy adder]

trigger action

[next plaza]

That'll happen without IE too (or it used to)

That's why I added this field:

[tardy adder]

yeah that is not working

so I just used trigger action for it 9-9

[next plaza]

ConsumeForTriggerAction: true; isn't working?

[tardy adder]

nope

[next plaza]

Hmm

1.6.9 or 1.6.8?

Any errors?

[tardy adder]

.8

[patent lance]

If the current day of the week ends in a "y", then yes. Otherwise, hell no, your calendar is fucked, you've got bigger problems.

[tardy adder]

no errors

[next plaza]

Oh wait

Did you say this was a warp totem?

[hallow prism]

huho. I'm french. The bot is not wrong

[tardy adder]

no, it's a night event totem

it's a... idk what I am doing but it works kinda totem

😄

[next plaza]

Can you show me your object extension data patch?

[calm nebula]

Roslyn doesn't care about memory crimes:P

[tardy adder]

                "Totem.earthquake": {
                    "CanBeShipped": false,
                    "UseForTriggerAction": true,
                    "ConsumeForTriggerAction": true,
                    "MaxStackSizeOverride": 1,
                    "CategoryTextOverride": "{{i18n: TotemCategoryDark}}",
                    "CategoryColorOverride": {
                        "R": 9,
                        "G": 43,
                        "B": 59,
                        "A": 255
                    },
                },

[next plaza]

Hmm

Does it work without IE?

[tardy adder]

Yeah, I am using IE for something else entirely

[next plaza]

I mean without IE installed

[rain basalt]

sent you a pm hope you got it lol

[next plaza]

I don't check my DMs when they aren't from friends, is it something that needs to be DMed?

[rain basalt]

was a log of issue with space core and what caused it

[next plaza]

That can go here

[next plaza]

Also, can you run harmony_summary in the SMAPI console and then get me a log?

[rain basalt]

hit esc

lol and you get a nice red text

[tardy adder]

no (even IE yeet it doesn't consume) and hold up let me get it up again

[next plaza]

What's the error?

[rain basalt]

sec loading now

sorry didnt colaps

[rancid temple]

!log why no log site

[ocean sail]

Important note: Your computer username may appear in the log. If your username is your full name, please be aware of this before uploading it.

Please share your SMAPI log file. To do so:

1. Open this page: smapi.io/log.
2. Follow the instructions at the top of the page to upload the log file. (Don't copy & paste from the console window!)
3. After uploading, it will show a green box with a URL to share. Post that URL here.

Please do it even if you don't see any errors. This has useful info like what mods and versions you have, what the mods are doing, etc. If the issue didn’t occur in your last session, please load the game to the point where the issue occurs, then upload the log.

To use this command, type !log.

[tardy adder]

https://smapi.io/log/6eb4135a63f84bb882c21bb9e9d3ea01 ?

[ocean sail]

Log Info: SMAPI 4.0.8 with SDV 1.6.8 build 24119 on Microsoft Windows 10 Home, with 19 C# mods and 4 content packs.
Suggested fixes: One or more mods are out of date, consider updating them

[rain basalt]

https://smapi.io/log/c1342eeafbbf4bd8ae05d0ee1523a42d

[ocean sail]

Oops, couldn't parse that file. Make sure you share a valid SMAPI log.

[next plaza]

Fixed that already in whatever version I have when blueberry mentioned it before

[rain basalt]

<.< k

[velvet narwhal]

#making-mods-general message < this ver

[rancid temple]

Yeah that'll happen when you only put part of a log

[rain basalt]

thats the one im using

[velvet narwhal]

i'm on that ver and beta runs just fine, unless you're not using it in beta?

[rancid temple]

I'm also using that version and don't get red text when hitting escape

[rain basalt]

im in beta

[next plaza]

Hmm, does it work without Cloudy Skies installed? (Looking at the code, I doubt it, but I'm not sure what else to try)

[velvet narwhal]

oh y'know what

i just got it

[tardy adder]

->

Need cloudy skies tho nauuur

[rancid temple]

What'd you do?

[rain basalt]

ill just wait for official update lol

[velvet narwhal]

1 sec

[next plaza]

Did it work without it?

Just for testing

If it does break I can talk to Khloe

[velvet narwhal]

my liege https://smapi.io/log/3d0a61950ec04b60bdaa57102acc12ea

[ocean sail]

Log Info: SMAPI 4.1.0-beta.5 with SDV 1.6.9 'beta' build 24298 on Microsoft Windows 10 Home, with 7 C# mods and 2 content packs.
Suggested fixes: One or more mods are out of date, consider updating them

[tardy adder]

Wait I booting the thing again

[next plaza]

Like I mentioned, I already fixed this locally 😛

[velvet narwhal]

is there........

a 3rd 1.26.0?

[rain basalt]

lol

they said locally

so probably 1.26.1

[next plaza]

I don't update the version until release

So the full release will also be 1.26.0

[rain basalt]

evil

[next plaza]

I forgot to put it in it's own commit, but it's this one: https://github.com/spacechase0/StardewValleyMods/commit/9e18d54d5ddcf7a835a5e21052ba6dc8ea3af3b5#diff-8ff7caa5d5c41640bd4586d965fbe2bc7126bfb46bddcfea469f36c63f4e4ba0

[tardy adder]

Nope 9-9

[brave fable]

really just look at mine, 2 lines of text, a config note, and a source link. you don't need to do much haha

[next plaza]

Hmm

Is the totem actually working?

[uncut viper]

but the images and what if i dont write enough and the judges miss some of my mod...

[tardy adder]

Yup

[velvet narwhal]

just don't make it pixels or else nexus is gonna give it the crunchy cat

[next plaza]

Can you run patch export spacechase0.SpaceCore/ObjectExtensionData and upload the resulting file?

[tardy adder]

I use it and boom night event is set to happen

[brave fable]

have you considered actually appending a dash version number to your releases to avoid confusing people about whether to use 1.26.0, 1.26.0, 1.26.0, or the fourth secret 1.26.0

[tardy adder]

oki hold up

[brave fable]

or whether they need to upgrade to the just-released 1.26.0

[next plaza]

I have considered it, and decided I would rather confuse people /s

[velvet narwhal]

1.26.0001

blueb's the only one who can give you error reports then cause i'm too lazy to rebuild

[next plaza]

I think the manifest builder gets confused when I do that with my dependant mods

But maybe that was only an issue with the -Debug stuff

[brave fable]

i downgraded to sdv1.6.8 for the event, have fun troubleshooting

[whole raptor]

Are the keys in Objects case sensitive in CP?
"Displayname": "Pufferchick",
DisplayName vs Displayname

[finite ginkgo]

cp should already handle case sensitivity for keys

[rain basalt]

keys should be fine but references can be for values

[rancid temple]

Keys are fine, though staying in habit to use case sensitivity is probably for the best since some things are still case sensitive in different places

[rain basalt]

so if you reference pufferchick it may not work

[hallow prism]

(i just know that seeds ID are case sensitive)

[whole raptor]

Oh I see, I saw that example on the wiki and got confused why is it like that 😅 (also found out my converter does care about case senstivity...)

[tardy adder]

OH ITS ACTUALLY NOT DOING THE THING

  "Totem.earthquake": {
    "CategoryTextOverride": "Dark Ancient Carved Weather Totem",
    "CategoryColorOverride": {
      "B": 59,
      "G": 43,
      "R": 9,
      "A": 255
    },
    "CanBeTrashed": true,
    "CanBeShipped": false,
    "EatenHealthRestoredOverride": null,
    "EatenStaminaRestoredOverride": null,
    "MaxStackSizeOverride": 1,
    "TotemWarp": null,
    "UseForTriggerAction": true,
    "GiftedToNotOnAllowListMessage": null,
    "GiftableToNpcAllowList": null,
    "GiftableToNpcDisallowList": null
  },

Well then that explains some things 9-9

[next plaza]

Did you maybe copy paste that block with some different values?

So like you have two "Totem.earthquake" entries

[tardy adder]

Nope

It's just one entry in this test

[next plaza]

...I don't see the consume for trigger action field at all there

Hold on

[patent lance]

New quote added by atravita as #6243 (https://discordapp.com/channels/137344473976799233/156109690059751424/1299469381448761347)

[tardy adder]

So consume for trigger action is only for the beta?

[velvet narwhal]

nope that's been there

[next plaza]

Your SpaceCore is out of date

[tardy adder]

Yeah I have the most recent one downloaded

[next plaza]

No you don't

If you did that message wouldn't show on your log

[tardy adder]

The only other one is 1.25.3-beta

[next plaza]

Your version is from april

[rancid temple]

Did you perhaps download the latest version and not install it?

[next plaza]

????

[uncut viper]

are you sure you're using the right mod folder or star drop profile

[rancid temple]

Ask me how I know how to- I've done this

[tardy adder]

Yeah that's the one I had 9-9

Wth

[hallow prism]

who didn't?

[velvet narwhal]

"which one is my dev folder? fifk"

[next plaza]

The ones who use separate workspaces instead of separate profiles in stardrop 😎

[uncut viper]

if you set SMAPI to use your Downloads folder as the mod folder you never need to worry about installing

[tardy adder]

LET ME REDOWNLOAD AND DELET

[hallow prism]

"hey pathos i have an issue?"
a very patient pathos : "if you update, does this help?"
me : wither in shame

[rancid temple]

Every time

[tardy adder]

sigh wait

Let me redownload the folder

[whole raptor]

This might be problematic

[next plaza]

Welp, definitely need to mute #1299467893682999447

[tardy adder]

-> with my slow ass internet

[next plaza]

You can't use tokens in your i18n file

[calm nebula]

Does it ping you???

[next plaza]

No but it marks this server as unread every time someone tricks/treats

[uncut viper]

It doesn't ping but it's gonna be hella active

[velvet narwhal]

it shouldn't, but it's distracting

[calm nebula]

Oh. I just have the whole server on mute

[uncut viper]

I just mute the whole server

[calm nebula]

Sorry.

[next plaza]

I don't have the server muted, just most of the channels

Pretty much just a few modding channels and #haunted-chocolatier are unmuted

[calm nebula]

You have to slip into my dms to consistently get my attention these days

[velvet narwhal]

i only have the event channels and making mods unmuted

[uncut viper]

is that granting permission?

[calm nebula]

You may DM me

I like you.

(But not in that way )

Just as a person

[next plaza]

I DM atra sometimes, glad they put up with my nonsense

[rancid temple]

Specifically the keys? I know you can pass in tokens to values but that's kinda sketchy with translators

[tardy adder]

me: have an issue
a very patient casey: does updating it help?
me : wither in shame

[next plaza]

You can pass in keys but you have to explicitly do it, and it only works for the values.

[uncut viper]

ill DM you pufferhearts but I don't have nitro so they'll just be in text form and you'll have to deal with it

[tardy adder]

idk how I had the wrong one when I had already downloaded and put the recent one

[velvet narwhal]

ascii pufferhearts

[tardy adder]

https://tenor.com/view/cat-hide-sofa-gif-5892045

[next plaza]

(My Content Patcher alternative automatically pulls in surrounding variables to pass to i18n so you don't have to explicitly do it every time)

[rancid temple]

DM screenshots of pufferhearts

[calm nebula]

I'm glad you put up with MY nonsense lol

[fading walrus]

[velvet narwhal]

i can only imagine the kind of crimes ya'll dm each other about

[fading walrus]

Ope I got candy

[uncut viper]

i wish I got candy just for showing up places

[fading walrus]

I've been on break since before the event started so I admit I'm out of the loop with what got implemented lol

[velvet narwhal]

am i out of candy yet

[next plaza]

What's a candy? Ignore the empty starburst bag next to my monitor

[velvet narwhal]

mom lets you have starbursts? i just have these apple cinnamon quaker rice crisps

[rancid temple]

I assume it'll be the money in Haunted Chocolatier /j

[next plaza]

My parents are in another state 😛

[uncut viper]

that'd be cute

[tardy adder]

Oh look it now works without complaints

Imma show myself out

[next plaza]

It looks like the #1299467893682999447 isn't updating with everything, seeing as there are no messages mentioning me (unless I missed it) but /stats shows I have one treat received

[uncut viper]

The channel didn't exist immediately when the trick or treating started

[rancid temple]

Maybe the bot is silently dying

[uncut viper]

That said it is also missing some things

[velvet narwhal]

i went and gave out candy to necro'd posts before i could get narc'd on

[uncut viper]

so it could be either

[fading walrus]

It better not be for aquo's sake /lh

[tardy adder]

A very patient casey dealing with my brain

Anyway back to doing more chaotic stuff with spacecore :3

[rain basalt]

good times

so mod started at 2kb now its 17kb lol

[velvet narwhal]

[heady crest]

been trying to figure this out for a while can some1 help

[whole raptor]

Now I broke object handling completely... WHEN

[finite ginkgo]

UnlockConditions is a string taking a GSQ, not an array

[heady crest]

gsq?

[uncut viper]

game state query

where did you get that current format you were trying from?

[finite ginkgo]

[[Modding:Game_State_Query]]

damn it

[heady crest]

ah

[heady crest]

it was just a shot in the dark

[uncut viper]

https://stardewvalleywiki.com/Modding:Game_state_queries

you should basically never be taking shots in the dark

[finite ginkgo]

ofc it was plural

[uncut viper]

"you get one (1) Game State Query in 1.6 and thats IT"

[finite ginkgo]

"now you get two (2) Game State Queries instead"

[uncut viper]

deux gsq does have a nice ring to it

[velvet narwhal]

"before button, we only had 3 triggers! and spacecore"

[uncut viper]

we had to trigger our actions uphill, both ways! in the snow!

[velvet narwhal]

actually did spacecore even have a trigger? i only know of the manual one

[finite ginkgo]

I mean, Manual would indeed be a trigger

[next plaza]

OnItemUsed and eaten

[uncut viper]

Manual is technically a vanilla one anyway innit?

[next plaza]

Yeah, it just doesn't use it

[uncut viper]

just only used by mods

[velvet narwhal]

only knew manual existed because of spacecore

[uncut viper]

tbf its not actually listed on the wiki

you'd only know either through spacecore or the decompile

[calm nebula]

To be fair

Toooo be fair

[uncut viper]

and i guess maybe through the fact that "Manual" doesnt have the spacecore modid prefix

[whole raptor]

Nvm, I'm an idiot

[calm nebula]

If you're using c$ you can decompile lol

[velvet narwhal]

don't be mean to you

[uncut viper]

is that being fair or is that just what was implied already because you dont need to use C# to use the manual trigger! you just need to use spaceccore

[velvet narwhal]

i am probably, one of the strangest in regards of "baby's gonna first start modding, i'm gonna extensively read spacecore docs"

[calm nebula]

Hey, I read blog posts on how the net GC works

[velvet narwhal]

no please not the rabbit hole of roslyn, please don't send me back there i'll never get anything done

[velvet narwhal]

i lost 3 hours reading the efficiency of the switch compiling of roslyn because of your link 🫵

[rain basalt]

only 3 hours?

so crazy question what happens if you break the 4th wall during map making and go beyond a map size?

[next plaza]

I think in one direction things stop appearing, and in the other things don't layer properly

[hallow prism]

WIP

[rain basalt]

hmm ok what if you did map incertion at cordinates to layer a map next to other maps? think it would work

[next plaza]

What do you mean?

You can't have multiple maps for one location

[rain basalt]

so say you load a blank 2000x2000 map then layer a 155x199 map starting at cord 0,0 and next one starting at 0,200 and so on

[next plaza]

What do you mean by layer a map

[uncut viper]

Everything is always just in one single "Map"

you can have tiles wherever separated by void if you want but its still just one Map

[rain basalt]

wish CP you can over write map data

with other maps sets

[uncut viper]

everything becomes one map

[next plaza]

Yeah, and even if you could have multiple maps in one location, it wouldn't fix it

It's a matter of the coordinates becoming too large

[rain basalt]

just wondering if using CP to create the map would fix the layering issue

[next plaza]

Nope

[rain basalt]

k

just a thought

[velvet narwhal]

#making-mods-general message
roku did the testing on it

[rain basalt]

good to know second crazy question anyway to make robin build on other maps?

[next plaza]

Yeah it's a map property

https://stardewvalleywiki.com/Modding:Migrate_to_Stardew_Valley_1.6#Build_anywhere

[rain basalt]

i feel dumb lol i totaly missed that when looking ...

[scenic heath]

Apologies for what I assume is an obvious answer, but I searched and could only find one unanswered forum post from 2021. How do you reference a (dependency) mods item ID in a recipe, if it's possible to do so at all?

[brittle pasture]

open its mod files, see what its item IDs are defined as in Data/Objects, then use that one

[rain basalt]

when the mod loads it should have an id in data/objects but you should also set the depedancy in your manifest to make shure your mod loads after

[scenic heath]

Ah, the ID is a string and not a number that is more likely to clash. That makes sense! Thank you and sorry again for the dumb questions.

[brittle pasture]

they were numbers back in 1.5

1.6 made them strings, so you can now use whatever you wanted and not needing to worry about conflicts with other mods

(thus, we recommend putting your unique mod ID in your item IDs and other IDs to reduce conflict)

[sweet sphinx]

so, I got an art app, and notepad++, is there anything else I need to start learning modding?

[brittle pasture]

!startmodding check out the guide here

[ocean sail]

Making mods can be broadly divided into two categories:

• Content packs are formatted text files, and don't need any programming knowledge. They can add/edit NPCs, maps, new items, shops, and more. To get started, see the list of framework mods, the wiki tutorial for Content Patcher, and there might be relevant guides on the tutorial wiki.
• C# mods use programming code to change fundamental game mechanics. See getting started with C# modding.

Usually it’s easier to start with making content packs, since you don't need to learn programming.

To use this command, type !startmodding.

[brittle pasture]

check out the first bulletpoint

[sweet sphinx]

ooo~ tutorial

[brittle pasture]

what do you want to make?

you may not need to touch C# at all

[sweet sphinx]

more animal variants, like dog breeds, and colours of rabbits and such

[brittle pasture]

then the Content Patcher tutorial is perfect then

these will also be useful:
https://stardewvalleywiki.com/Modding:Animal_data
https://stardewvalleywiki.com/Modding:Pets

[sweet sphinx]

thanks

[brittle pasture]

lastly, also unpack the game to see how the base game defines their farm animals and pets

!unpack

[ocean sail]

Follow this guide to unpack the game's content files in order to see and explore how the game data is structured.
It's helpful when making your own mods, or just to learn about how the game works!

To use this command, type !unpack.

[sweet sphinx]

thanks

[rain basalt]

unless its been updated xnb hack wont do beta

[lucid iron]

u need stardewxnbhack 1.1.1

https://github.com/Pathoschild/StardewXnbHack/releases/tag/1.1.1

[rain basalt]

hmm ill redownload mabey it was corrupt but last i tried it it just gave error message and stoped

hmm working with redownload might need to fix my extracter

[sweet sphinx]

so I got to the content.json part, and I'm looking though the things you can do with it, but I'm not seeing how you can add the option for animals to be multiple skins, like the chickens have white and brown from one animal, I wanna add more chickens(and other animals) the game can select from when buying, I don't wanna replace an already existing animal

[rain basalt]

you have to make a seperate entitiy

then reference it under the options like chickens do for brown or white

[brittle pasture]

farm animal skins are kinda weird. White, Brown and Blue chickens are different animal, but the shop's coded so that when you buy a chicken you randomly get 1 of 3
Stardew 1.6 also supports an animal skin system where if an animal as multiple skins you will randomly get one of them on purchase

[sweet sphinx]

ahh

[rain basalt]

or hatch

[brittle pasture]

if you're adding new skins I recommend the latter option, since you'll have to reduplicate all the logic if you go the former route

[sweet sphinx]

cool, so how do I go about doing that?

[rain basalt]

look at data/farmanimals.json

[brittle pasture]

so on this page: https://stardewvalleywiki.com/Modding:Animal_data
each animal entry has a "Skins" field

you want to use EditData and TargetField to edit the white, brown and blue chickens' Skins field

and add your own entries

[velvet narwhal]

breaks out the targetfield copy paste

[sweet sphinx]

and that's not gonna overwrite the vanilla chickens, if say I add a "red" chicken, there'll be 4 chicken skins then?

[rain basalt]

your just adding to the target data field

[brittle pasture]

you need to make your red chicken a skin of either brown, white, or blue (or all of them)

you can add a red chicken as a separate animal, but you'll have to redefine produce drops, display names, hatching, basically all the logic

[rain basalt]

or just copy and paste and add entry

[brittle pasture]

and it won't be compatible with mods that modify chickens produce

[sweet sphinx]

yee, I'll worry about the sprites in a bit, I'm- I don't mind redefineing things if it means I don't make a white chicken red, and can have all 4 chicken types

[brittle pasture]

if you do go the separate red chickens route that's a pretty convenient excuse to add a unique drop from them!

[scenic heath]

Spicy Eggz

[sweet sphinx]

reddish eggs

[rain basalt]

lol

[scenic heath]

Reggs

[velvet narwhal]

    "Changes": [
        {
            "Action": "EditData",
            "Target": "Data/FarmAnimals",
            "TargetField": [ "White Chicken", "Skins" ],
            "Entries": {
                "{{ModId}}_RedChicken": {
                "ID": "{{ModId}}_RedChicken",
                "Weight": 1.0, //2.0 will double chance
                "Texture": "//define your texture that you loaded here",
                "BabyTexture": "//define your texture for babies that you loaded here"
                }
            }
        }
    ]
}```

[sweet sphinx]

honestly tho, "red" chickens, rly Road Island Reds, have brown eggs

[velvet narwhal]

i don't know what the texture/harvestedtexture/babytexture looks like, if it's all one list or if it's like data/shops where texture is the main and the others are inside, but looking at data/farmanimals it looks like they need their own separate entities

[brittle pasture]

yeah that's perfect for adding red chickens as a new skin. red chickens as a new animal will need to be different

Texture and BabyTexture are separate fields, yes, so that looks perfect

[sweet sphinx]

the chickens all have separate baby sprite files, tho the ducks use the baby white chicken sprite

[velvet narwhal]

you want a whole ass new animal copy paste here you go:
ripped straight from white chickens
https://smapi.io/json/content-patcher/399778583c3a424faa41900f2ac42999

[sweet sphinx]

thank you dearly

[velvet narwhal]

smapi deletes my comments, but you can infer to replace the [Localized] parts with your own descriptions, replace the textures with the targets that you loaded to

[sweet sphinx]

do they gotta be in brackets?

[velvet narwhal]

nope

just "text here" if you're not gonna use translations

[rain basalt]

anyone ever have to many ideas going on but struggle to work on just one at a time...

[brittle pasture]

(if you do want your mod to be translatable later, https://stardewvalleywiki.com/Modding:Translations is a good read)

but for now something like "DisplayName": "Red Chicken" is perfectly servicable

[proud kite]

😭 hey yall i was tryna update this gojo mod to 1.6 and i tested him for the first time and ||hes cut in half 😭|| any idea what could cause this? just updated his dispo to 1.6 and content format

[sweet sphinx]

mk

[rain basalt]

is the top half missing the whole time or just during bubbles

[velvet narwhal]

wdym update to 1.6?

[scenic heath]

So, apologies for jumping in here, but I am confused as to what I've done wrong here. The recipe inputs work, but the output doesn't and is an error item. I assume I've done something blindingly obvious wrong here but I've not been able to work out exactly where. https://pastebin.com/6BE8TuPq

[brave fable]

did you make his npc size x:16, y: 16?

its meant to be 16, 32 if so

[proud kite]

he wont move and this is all i can do to get him to face me 😭

[uncut viper]

(please use the smapi uploader in the future)

[brittle pasture]

that likely means your ID for the output is wrong

[proud kite]

his dispositions was 1.5 format so he was kinda not working with farmhouse mods like polaymory sweet etc

[uncut viper]

(also why are you using format 1.18.0)

[brittle pasture]

if you have Lookup Anything, you can enable debug fields and look up the "Quality Line Sprinkler" item in game

oh yeah didnt notice the pastebin above the image, your id is most likely wrong yeah

[scenic heath]

I am just co-opting the existing upgrade sprinkler mod that wasn't updated for 1.6 but smapi seems to automigrate it and I am too smoothbrained to know how to modify it for the new format.

[scenic heath]

Gotcha.

[brittle pasture]

the item ID seems to be rtrox.LineSprinklersRedux_QualityLineSprinkler, but your first recipe has QualityLineSprinkler only as the output

[scenic heath]

See I tried that id but it didn't seem to work, but maybe I did something wrong

[brittle pasture]

just changing it to "2.3.0" should be fine for now, it doesn't make a difference but it's good practice

[velvet narwhal]

i honestly don't know how an outside mod is going to deal with cp's auto-patching, but you can probably just take the same ID and create the data/character and fill it out appropriately https://stardewvalleywiki.com/Modding:NPC_data
if this is a personal edit, just yeet the data inside of the dispositions and replace it with the necessary formatting
https://github.com/Aviroen/Custom-NPC-Edelweiss/blob/master/data/Edelweiss.json

[scenic heath]

"Line Sprinkler to Quality": "rtrox.LineSprinklersRedux_LineSprinkler 1 336 1 338 1/Field/rtrox.LineSprinklersRedux_QualityLineSprinkler/false/Farming 6",

[velvet narwhal]

it looks like you'll also need to add gifttastes since old dispos... didn't... have it? i don't know i never dealt with npcs in 1.5

[uncut viper]

current dispos dont have gift tastes either

its still its own asset

[brittle pasture]

in that case we need to fetch the correct ID, either from double checking in the mod files or via Lookup Anything (with Debug Fields on)

[velvet narwhal]

i may be blind and couldn't find the gift taste file

[uncut viper]

Data/NPCGiftTastes

[velvet narwhal]

oh no i meant in this gojo mod

oh it's in the content.json silly me

[scenic heath]

Are these not the correct ones? I turned on debug in lookup anything but I wasn't seeing any ids.

[proud kite]

ohhh im so misguided i thought i could just make the edits and itll run... is it to do with unique ID? out of curiosity

[velvet narwhal]

this npc isn't using a unique id

so the internal name should just be "Satoru" like how it's created, and it'll probably bode well from an outside mod, if you set your mod dependent upon this mod

[uncut viper]

(can you use BC's in crafting recipes yet? i thought that was something coming in 1.6.9 but i cannot remember and am possibly confusing it with something else)

[brittle pasture]

ah I think I see what's going on; they're big craftables. you need to set the false field in your recipes to true

it determines whether the output is an Object or a BigCraftable; with false being the former

[scenic heath]

Oh wow, how did I miss that

reading the mod explains the mod (not sarcasm, it's true in the original line sprinkler mod too)

[brittle pasture]

(though it's weird the ingredients are fine though? But just in case also add (BC) before the ingredient names)

(not the produce, that's covered by the bool)

[scenic heath]

That's all it was, it's all working now. Thank you again.

[proud kite]

okay so, i take the new data changes i made from the modding wiki, and create a whole new mod? is the dependecy also a file i have to add or something?

[velvet narwhal]

you don't have to make a whole new mod, if it's personal use, but if you plan to release (i just checked perms and you can release so long as you ref and credit the original) you set your manifest dependency upon the uniqueid of this one so that your edits load after

[proud kite]

okay awesome thank you

for the uhh cut in half thing i believe ive updated the data to 1.6 could it be a spouse room issue or something? hes stuck right above the spouse room

[velvet narwhal]

you set his size appropriately to x = 16 and y = 32?

[proud kite]

i thinkkk i skipped on adding it due to optional on the wiki, let me shove that in there and try real quick!

[velvet narwhal]

even if you didn't specify a spouse room i think it just defaults to abigail's room anyway

[calm nebula]

It occurs to me it would be easy enough to make a mod that reads from the old assets and edits them into the new

Now....who should I conscript into that....

[uncut viper]

chu

[calm nebula]

I was thinking you actually

[uncut viper]

ill be honest i dont actually kno what you're talking about ive not been paying attention to chat much

i just always appreciate a good opportunity to sign chu up for more mod work

(sorry chu your name is short and easy to type)

[calm nebula]

Chu2.7 immediately goes back to the full name

[uncut viper]

whats this asset loading and editing mod idea anyway whats the functionality there

[velvet narwhal]

old 1.5 disposition into new data/character

though i thought CP already pseudo does it?

it just kinda... gets mad at you about it

[brittle pasture]

I think CP migrates the file/syntax itself, before the loading? disclaimer: I pulled this guess out of my ass

[calm nebula]

But it forgot to do data/spouserooms, button

[uncut viper]

that sounds more like a PR to CP

[velvet narwhal]

i am blind i do not look at cp's guts

[uncut viper]

which sounds like an atra thing

[calm nebula]

Wait a minute

Heyyyyyyy

[uncut viper]

heyyyyyyyy

[velvet narwhal]

atra dms casey

[uncut viper]

cmon you love making pull requests!

[calm nebula]

No I don't!

[uncut viper]

coulda fooled me

[tender bloom]

PRs are perfect for you! they're for other people's mods!

no maintenance!

[calm nebula]

hides behind witchperson

[tender bloom]

hahaha

[uncut viper]

and if it breaks they get the bug reports instead!

[tender bloom]

I'm not tall enough to hide behind

maybe if I'm wearing a witch hat

[young rampart]

Sorry to bother everyone, but I play a modded farm and have no experience on the mod creation process. What would be the best way to go about trying to commission a mod to be made that I would like to add to my game?

[uncut viper]

!commissions

[ocean sail]

If you're looking for people who do mod commissions (either art or code), here's a wiki page with a non-comprehensive list of people who do them: https://stardewmodding.wiki.gg/wiki/Stardew_Mod_Commissions

To use this command, type !commissions.

[young rampart]

Alright I'll look into that. Thank you.

[tender bloom]

you can also ask around in #modded-stardew to see if anyone has suggestions on similar mods, if what you want isn't super super specific

another common thing is for people to commission art but do the work themselves to put the art into the game

[young rampart]

I've looked around on Nexus and I don't think they have what I want there. Basically I want a single player mod that let's me fully control cabins including putting spouses in them.

[tender bloom]

that's either C# or you can launch multiple instances of the game

it's a huge pain to swap between the instances to actually play though, I would mainly do this to cheat in stuff for testing

there's not a lot of C# commisionees but there's a couple!

[proud kite]

ok back with an update: added pixel animations and size

[young rampart]

I'll go look on the commissions page. Thank you everyone.

[velvet narwhal]

animationDescriptions don't really matter except for the schedules
as soon as an NPC is a spouse though, they lose all personality

[uncut viper]

(uh oh. i think i discovered i actually owe nexus an apology...)

[velvet narwhal]

that being said, i have absolutely no idea why he's still headless

[uncut viper]

turns out this is not nexus's fault. i did not realize that paint.net saved its, uh, save settings between launches. it saved this banner image in 4-bit depth, instead of something sensible. (it was in 4-bit because the giga^2 maze was fucking huge with full colour data)
oopsie

[velvet narwhal]

you did it, You made the crunchy controller

[uncut viper]

feature not a bug

[proud kite]

"TextureName": null,
"Appearance": null, //new appearance system, highly customizable, see: Outfits.json
"MugShotSourceRect": null, //change the position of their headshot in the calendar/map/etc if they're shorter/taller than normal
"Size": {
"X": 16, //this is for how wide each character sprite is
"Y": 32 //this is for how tall each character sprite is

[velvet narwhal]

lore accurate headless idk

[proud kite]

this is whats needed for the "size" right?

[velvet narwhal]

yes

[proud kite]

it gagged me a little when i launched the game not gonna lie

[velvet narwhal]

oh it's pulling strangely

hold on what does the character sheet look like

you can delete, whole assets are frowned but it's good to know yours isn't screwed up somewhere
for some reason, it's pulling the index incorrectly, are you using some kind of HD sprites mod?

[proud kite]

sorry!

[proud kite]

nope! just a portrait hd mod

[lucid iron]

I thought you have to put Width and Height

Not X and Y

[velvet narwhal]

size is x/y, width is the spouserooms

[lucid iron]

Should double check if that field is actually a Rectangle instead of Vector2

[velvet narwhal]

(Optional) The pixel size of the individual sprites in their overworld sprite spritesheet. Specified as a model with X and Y fields. Defaults to (16, 32).

[sweet sphinx]

what is "ShopMissingBuildingDescription"?

[velvet narwhal]

yeah that's weird

it's starting the index as if it's right here

[proud kite]

oh i see what u mean

wow

[sweet sphinx]

like, is this the line for when you're missing the required building?

[velvet narwhal]

yep, no idea, it's probably some incompatibility in your modlist

[proud kite]

the recolor you have is gorgeous! thank you for tinkering 😭 going to remove farmhouse fixes and see if thats it

[velvet narwhal]

this is vanilla

[proud kite]

this is what happens when reshade and a recolor are combined

mind control

[velvet narwhal]

i usually can't live without nightshade but is not dark outside, i don't need it

but uh, wow, that's a fun one to try and fix because it's kinda everywhere

[proud kite]

hes saved from his fate (it was the size input that fixed it - just didnt hit save on dispo before i launched 😭 )

[proud kite]

thank you so much

[rain basalt]

reminds me of kakashi

[sweet sphinx]

success: the mod is running and red chickens are listed in Marnies shop

their sell icon is the normal white & brown chicken tho

[rain basalt]

ok updates been out for 4 hours now no bug reports onward to the next mod lol

[rain basalt]

change this section
"ShopTexture": "LooseSprites\Cursors",
"ShopSourceRect": {
"X": 0,
"Y": 448,
"Width": 32,
"Height": 16

unless you added as a skin

[sweet sphinx]

it's not a skin(tho I might wanna change it to one later, after I figure out how to add whole new animals)

[rain basalt]

you can reference your current sheet if you want to make is simple

[sweet sphinx]

ooo~ good idea

[atomic vale]

So I want to add an new item that the raccoons sell after the 6th request how do I code this? I also want to change the price of the magic rock candy

[rain basalt]

so make item then add it to that shop menu

use mail tag for 6th quest

[atomic vale]

?

[rain basalt]

all quest actions have a reference tag

like blue chickens

[atomic vale]

And were can I find all of this?

[rain basalt]

"Id": "BlueChicken",
"Condition": "RANDOM 0.25, PLAYER_HAS_SEEN_EVENT Current 3900074",

[uncut viper]

raccoons do not use mail flags

they use WORLD_STATE_FIELD gsqs

[atomic vale]

I can't find the shop name or anything

[uncut viper]

a lot of things do not use mail flags

[velvet narwhal]

the bright yellow jumpscared me

[uncut viper]

(i chose it bc its bright and noticeable )

[rain basalt]

under data/shops.json there is a racoon shop info

[atomic vale]

thx

[rain basalt]

"Condition": "WORLD_STATE_FIELD TimesFedRaccoons 6",

with conditions

[rain basalt]

..< my eyes

[naive depot]

Hey guys, anyone know a way to make the screen fade to black/make the screen turn black?

[rain basalt]

https://tenor.com/view/blinding-light-jerry-smith-rick-and-morty-too-bright-adult-swim-gif-9951096662630262377

[lucid iron]

golden bootton

[rain basalt]

press menu button on monitor slowly lower brightness to 0 (joking)

[naive depot]

That surely is one way

[velvet narwhal]

in what context do you want this screen fade

cause there's A Lot Of Ways

[naive depot]

uh

I need to setup up a transition

before warping

[velvet narwhal]

(your halloween costume is now the gold youtube play button)

[sweet sphinx]

ok, now I'm confused

[velvet narwhal]

transition before warping? like using a warp totem?

[naive depot]

ye kinda

I'm making a funny little multiplayer mod

where everyone has a seperate farm

but you all can go to a pelican town

[sweet sphinx]

do I need to specify in the .json that it's a .png file it's looking for?

[naive depot]

and before I connect to the server I want to fade the screen to black

so you don't just see people appear

[lucid iron]

you need to do a Load

[uncut viper]

before you connect to the server?