In-App Mod downloader

[hard trail]

Can you add the feature to browse through mods from Modrinth and Curseforge and download them? Is much easier then putting it in the right folder

[tulip trellis]

we literally have that

wait no

im thinking of modpack

[plucky wagon]

Yep, we need this so bad

[polar fog]

That's against curseforge ToS to do automated downloads

[tulip trellis]

wdym

how else can you download mods

[jovial root]

Could you elaborate a bit? I don't understand how download mods is a break of ToS for curseforge?

[polar fog]

Curseforge only wants people to download mods via a browser normally or via the curseforge client. That's why certain mods must be downloaded manually when installing a modpack via a client like ATLauncher. They want to control from where things are downloaded to enforce the ToS. They're actively trying to make it inconvenient to download mods outside of browsers and the curseforge client

[jovial root]

if thats the case, the user could be notified to download the certain mods from curseforge itself, the same way prism does it, but thats upto the devs to consider

[plucky wagon]

No offense to them but that's just fucking stupid and ridiculous

[tulip trellis]

i agree

[polar fog]

Moving data is expensive to be fair. They want to keep costs down

Being the #1 mod hoster isn't cheap

[kindred bridge]

trying to add this to the current launcher would be hell and really really janky

am sorry

it will probably be in the rewrite but not here and not soon

[upbeat blaze]

It's most likely for protection, look at TLauncher, the malwared one, curseforge mods and other mods you download from the launcher come from their own server because of "issues" and you don't know if the mod jar file has been tampered with 'specially since TLauncher was ratted out for having malware so Curseforge might be on the right track here

[kindred bridge]

protection my ass

they want it because curseforge client has telemetry and ads and overwolf daddy wants money for his investment

[jovial root]

Overwolf daddy 💀
https://cdn.discordapp.com/emojis/1318228043243720825.webp?size=48

[kindred bridge]

they sold themselves out

i hold no mercy for that

[hard trail]

But Zalith Launcher can?

[kindred bridge]

yes?

we know

so can prism

"wants" ≠ "allows"

[hard trail]

Okay, but would Modrinth work?

[tulip trellis]

yes

[hard trail]

Nice, there are more important mods anyway

[kindred bridge]

it just does

no bullshit needed

[hard trail]

Wdym?

I didn’t ask for an explanation

I just asked if it would work

[kindred bridge]

it already works

and it will keep working

[hard trail]

Amethyst has a mod downloader? Are you kidding me?

[kindred bridge]

no?

what are u asking

am confused

[hard trail]

I mean, the title is "In-App Mod downloader"

I asked if it would work to download Modrinth mods

From Amethyst

[kindred bridge]

totally possible but with how the folders are structured, really prone to random breakage

id rather not write something that works 50℅ of the time

[fallen estuary]

so we ain't getting a mod installer or what

wait it is approved

[hard trail]

Yipieeeee

[kindred bridge]

for rewrite

[real jay]

that would be awesome

[night dust]

shit would work on iOS

[kindred bridge]

still wont

[night dust]

would

[kindred bridge]

i dont see how ios could properly read and process prism instances as expected

not without changing the folder structure

[kindred bridge]

probably explain why you think it would work without any changes to how we store shit

[night dust]

doesn't the launcher literally download jars from microsoft's server

we can just change how it's stored when it comes to mod jars

[kindred bridge]

this suggestion includes supporting prism instances

[night dust]

i'm not thinking about prism instances

i'm thinking about the title and the title only

[kindred bridge]

too bad, adding a shitty mod downloader isnt forward thinking

thats simple to do

but am not making a ui for that

[night dust]

also where is "support prism instances" from OP

??

[kindred bridge]

this is a duplicate

[night dust]

oh

fruhh

[night dust]

no one's telling you to make one

[kindred bridge]

multiple ppl have suggested supportijg prism instances

[night dust]

but you approved "in-app mod downloader"

[kindred bridge]

if we do that first the mod stuff will come manually

[kindred bridge]

no more JANK

[night dust]

i'm not saying get it done immediately but now that's it's approved people are expecting something related to "in- app mod downloader"

[kindred bridge]

fcl already has a inapp mod downloader

[night dust]

and NOT a prism instance thing

you don't have to add everything at incr

once

[kindred bridge]

if we randonly add a mod installer, we will need to rewrite it when prism is also done

because those two are tied together

[night dust]

^ you could or you couldn't

up to you

just keep it in mind

now that it's publicly approved

[kindred bridge]

we don't, but using a solid foundation that someone else already built is gonna make life easier

no more jank

fuck that

[kindred bridge]

planned does not mean plans dont change

[night dust]

you know how the android community is

but on a real note maybe they gotta learn

[night dust]

jank is just 💔💔💔💔

(i jailbroke for a reason)

[kindred bridge]

i think they died down

like the shitty ones just retreated away from en

at least for now

[kindred bridge]

note that i can only implement android

i cannot develop the ios side

this featured is a frontend thing

[night dust]

ik

[mint field]

Just use modrinth

Questcraft uses modrinth for its built in mod menu so I dont see why it wouldn't work here

Oh a dev already said that, I should read before typing 🗣🔥

[upbeat dock]

there are good mods in CurseForge that don't exist in Modrinth

[kindred bridge]

cf sucks oml

[upbeat dock]

shrug

[mint field]

All the mods I've ever wanted were on both so idrtim

[fierce dirge]

cough I can do IOS side if you would like

[kindred bridge]

all PRs are welcome

but on ios, its up to duy to accept em

[fierce dirge]

Any specific UI or feature parity you would like?

[kindred bridge]

dunno, but ill probably take forever to add this on the android side

ive been really scared to replace all the garbage and rewrite it

[fierce dirge]

Just give me a overview on what you would like and I’ll do my best to emulate it on the IOS side lol

[fierce dirge]

Didn’t look that messy, I’ve seen MUCH worse

[kindred bridge]

fair point

i should just do it and tske the blame for the shitter code i write

[fierce dirge]

I mean

I could also do it

[fierce dirge]

You need access to a curseforge api key with the modpack and mods scope if you want to locally develop

[kindred bridge]

i have access to two of them

[fierce dirge]

Gotcha

I have my own atm so

[kindred bridge]

the amethyst one should be public i think

[fierce dirge]

Why would a private API key be public

[kindred bridge]

prism literally has theirs in the open bro

[fierce dirge]

So you are saying me going though the form was pointless

waow

[kindred bridge]

thats intended for public use

the only u get for free from cf studios is good enough for private testing

[fierce dirge]

so the one from https://console.curseforge.com/#/

[kindred bridge]

yes

thats fine for private dev afaik

[fierce dirge]

The default API keys you get does not have modpack or mod scope

you need to request though a form for them to enable support for those scopes

[kindred bridge]

ehe why does mine do

[fierce dirge]

Was it a legacy key before the switch?

[kindred bridge]

ig old api key privilege

[fierce dirge]

thats exactly what it is

[kindred bridge]

but i already regenerated it, still has it

weird

[fierce dirge]

tied to acc

[kindred bridge]

ooh cool

hehehehehhee

been wonderibg how that worked

thanks for telling

[fierce dirge]

My mock idea is a UI where you can select a profile then have it automatch the loader and mc version with the mods list

I made a rough one back then in the old pojav server

The UI was trashhh

mainly cause I was still new to developing but I got a little under 6 months so I think I can do better

[kindred bridge]

mfw i have no ui ideas