#Why doesn't tag time go down in the scoreboard
1 messages · Page 1 of 1 (latest)
- the issue is because you never actually remove from {tagtime}, you only remove from {tagtime.%player%} so either change to using players or dont
- use lists (seperated with :: instead of .)
- thats a really inefficient way of updating the scoreboard, consider using a function to update it whenever a value is updated
- and if you are going to loop every tick, use a periodical event instead
- stop using console commands, use vanilla skript effects
unhelpful statement
instead of saying that this is horribly coded, it'd be better just to say what is bad about the code so they can improve
The whole entire script.
cool
but that doesn't help them improve
so be specific instead of making a blunt, unhelpful and discouraging statement
Discouragement is encouragement to the new.
that is probably the dumbest statement i have ever heard
hearing someone say how your skript sucks, especially when you're a newbie, is probably one of the most discouraging things
i dont see how anyone could feel encouragement after hearing that
no point arguing with you, lets keep this on-topic
to add on:
- the explode() function can be optimized by using a loop directly inside the damage event
- consider checking your if statements first so that its more readable, for example (your code):
if {inqueue} is false:
if {thegamerunning} is false:
your code here
else:
send "&aThe game is already running!"
else:
send "&aYou are already in queue" to player
just use:
if {inqueue} is false:
send "&aThe game is already running!"
exit
else if {thegamerunning} is false:
send "&aYou are already in queue" to player
exit
your code here
makes it 10000x more readable
Its a little unusual to set {_online} after using it in the loop, as it means
- for the first showing of the scoreboard it will be null
- (since its also after the wait), it might also be inaccurate, as a player could join in that small window.
Personally, i would just stick the expression right into the scoreboard
make wait 1 tick -> wait 1 second
you dont need to update scoreboards that super fast
better yet, don't use a periodical
make the scoreboard into a function that is updated whenever a variable changes (such as {tagtime})
or just use a scoreboard plugin