#Refactor Branch Bugs

2415 messages · Page 3 of 3 (latest)

brazen plover
#

ok i will work on that in a second

#

well i didnt get the same crash as you but i did get a diffrent crash

📎 message.txt
clear oar
#

i notice my talisman is the 2.0.2 stable and not the dev version

#

can't seem to find the download for the dev version though to rule it out

rotund blade
#

actually dropshot does something different

#

so I don’t think it will break with the Steamodded change

nimble crane
brazen plover
#

one moment

#

@clear oar

clear oar
#

I only see the 2.0.2 release

brazen plover
#

use this link

clear oar
#

i only see the main branch and the 2.0.2 under it, not sure where i'd grab the 2.1.0 dev version from

brazen plover
#

main is 2.1.0

rotund blade
nimble crane
#

^

rotund blade
#

it prevents any issues due to cantread

#

(not that GitHub’s UI makes that easy to find, though)

clear oar
#

yeah github is uh... not exactly a download portal

#

i am familiar with it but like

#

do you mean "you need to grab the code as .zip" or "you need to grab the latest release"

rotund blade
clear oar
#

that answers my question though

nimble crane
#

btw any word on #github message ? tried fixing crash meacap had regarding spectrogram, but havent been able to test yet
maybe i should download wine

clear oar
brazen plover
#

well now i have the direct link in my github bookmarks folder

nimble crane
#

also, any word on if we'll swap the effects for gemini and oil lamp? read somewhere that we might be doing it but not sure on status

rotund blade
#

We basically are?

#

Gemini at X2 will be modifiable

#

Oil Lamp definitely won’t but I also might nerf if more

nimble crane
#

either x1.5 or x1.2 for oil lamp imo, maybe based on gameset

nimble crane
bronze swift
#

Dragokillfist be like: how do I resize images

My brother in christ resize.py

brazen plover
#

i dont know how to use it

nimble crane
#

py
wokesip

#

finally something i understand

brazen plover
#

im a lua person not a python person

#

and im running on 2 hours of sleep

nimble crane
#

you literally just put the .py into the 2x asset folder

bronze swift
nimble crane
bronze swift
#

what were you using to resize btw

brazen plover
#

using the drawing software i use

bronze swift
#

if it has a setting for how it processes images select "nearest neighbor"

#

when it comes to scaling

zealous trench
#

this is one of the only things that i think needs a flat out removal

#

even small manip is insane on some jokers

rotund blade
nimble crane
#

i can see your point

#

kinda agree with it, at least for modest

zealous trench
#

it cannot be balanced

#

unless literally every joker is designed around it

nimble crane
#

i see your point

#

imo it should be like
modest: none (except maybe current gemini, but that is a really, really big maybe)
mainline: current, but with immutable oil lamp and maybe 1.2x (or 1.1x)
madness: full power gemini (with rework), and maybe non-immutable oil lamp

brazen plover
zealous trench
#

the problem with 1.2x or 1.1x is that if you give it enough rounds, it is still insane scaling

orchid frost
#

making a nerf to pity prize to stop infiite booster chains with retriggers and blueprint/brainstorm

#

would yall rather have it self destruct and remain common or have it work once per turn and get a rarity increase

orchid frost
#

or self destructs or something

warm moth
#

i think it's heiroglyph

#

ok i looked it up i think it's because i picked omeganum + heiroglyph usage

rotund blade
#

I can try fixing this myself

nimble crane
#

home now so i can try

rotund blade
#

first issue I noticed was that it should be in card.ability and not a local variable

#

but still not working

#

looks like the context.before part is never called

nimble crane
#

it should, i based it off the smods example

rotund blade
#

works now

#

had to change cardarea check to G.jokers

#

also gonna add in a debuff check

nimble crane
#

good idea

rotund blade
#

fixed and merged now

nimble crane
zealous trench
simple timber
#

nerfing oil lamp 😔 it being so busted is the best part of cryptid

abstract folio
#

all these newgen cryptid players have no idea

#

back then we used multiply + speculo

hearty flint
#

On the lengedary sleeve (maybe deck too), the legendary message pops up even if you got no available joker slots

nimble crane
#

do you still get the joker?

#

if no, i'll try fix it

#

if it's yes then it's probably intentional

hearty flint
#

I do not since my joker slots are full

nimble crane
nimble crane
#

my goals for today

nimble crane
hearty flint
#

Oh maybe, it went too fast for me so I thought it tried to add a legendary

nimble crane
#

looking for ccd code to try fix other issue, no idea where it is

abstract folio
#

takes 3 patches for a slightly better ccd ui

image.png
#

i hate ui code

#

(might even be arguably worse sometimes)

nimble crane
abstract folio
#

i see how to make it have both names

#

it's not even particularly difficult, it's just an anxiety filled yawnfest of many messy overwrites

idle patio
#

also remember the +2 Chips text

timber path
#

Getting this crash at end of round when it tries to bring up the income summary

📎 message.txt
rotund blade
#

So… what important bugs are left to fix?
I think the refactor branch is finally pretty much feature complete and ready to be merged besides any last bugs

orchid frost
#

decks

hearty flint
#

Is cross mod compat coming later?

orchid frost
#

i think it's already there but I don't know how it works

hearty flint
#

I wasn't able to get it working 😔

orchid frost
#

there also still a lot of stuff I still want to do before merge 😭

#

i'm running out of time

hearty flint
#

Btw would you like a PR only to delete all whitespaces?

orchid frost
#

yeah go ahead

hearty flint
orchid frost
#

just been getting busy

#

and tired

#

😔

hearty flint
#

I know Cryptid is huge and all but don't take it as a full-time job or you'll lose interest and get tired

orchid frost
#

not that kind of tired

hearty flint
#

Oh

orchid frost
#

lol

hearty flint
#

Here I was being so inspirational 😔

slender trail
#

You tried ✊

slender trail
rotund blade
rotund blade
#

And get that set up to be automatic

#

idk how that works on GitHub tho

orchid frost
#

there was that one thing a long time ago

#

probably similar to this but different

rotund blade
#

or even the same xd

#

we just never did it for some reason

orchid frost
#

it never happened because of the merge conflicts that pr had

#

a

#

ig now we can start from scratch

rotund blade
#

this is peak

image.png
#

(going through every file and styluaing it)

hearty flint
nimble blaze
#

well, that seems incorrect
... should probably make sure this isn't somehow caused by my mod clusterfuck, though

image.png
royal nacelle
#

i think thats intentional

chilly cairn
royal nacelle
#

bc if it was an accident it would probably display nil

chilly cairn
#

I've seen it too

royal nacelle
nimble blaze
royal nacelle
#

what

#

oh i didnt see that

nimble blaze
#

yeah

#

ohhhh, i see what's going on
it's supposed to be the a/an variable but something's up in the info queue

nimble crane
brazen plover
#

i did fix green seal

#

as for double sided jank i can probably work on it

nimble crane
#

gl

brazen plover
#

well it shouldnt be too hard

hearty flint
rotund blade
#

This one was never migrated to the new pool system

#

Will fix

hearty flint
zealous trench
#

we're nerfing it for the balanced modes

orchid frost
#

Just implemented this, it's probably a big qol for some players so update now

nimble blaze
#

i think this is technically item remover's problem, but the modification decks' UI doesn't play well with it (clicking anything disables them and you have to click again)

#

also returning from the modification decks' selection ui defaults to the continue tab if you have a saved run

tulip valve
#

'the seraph' consumable does not seem to work, screenshot is with Misprint Deck, so maybe the value of "#cards to select" is randomized but the tooltip does not update?

image.png
#

last pull was ~20 minutes ago

brazen plover
#

oh lemme fix it rq

tulip valve
#

probably the tooltip, I got another one that can be used with one but not with two cards selected

image.png
rotund blade
#

that 2 looks hardcoded 😭

brazen plover
#

is that what mod_conv means

brazen plover
#

tho lemme test before i make a PR

#

yep

#

so now i did fix it

rotund blade
#

nice

brazen plover
#

for the loc_vars it was (self, info_queue)

rotund blade
#

that’s so silly

brazen plover
#

the only reason i found it out was cuz in the return "card" was marked global

rotund blade
#

I kinda want to merge refactor tomorrow (it’s ok if it’s a little buggy)

brazen plover
#

i will be on watch for any bugs that arise

nimble crane
#

we're at the point where it's basically 99% done i think

brazen plover
#

and the fact of how active i am

nimble crane
#

^

nimble crane
#

btw whats status on phantom double scale?

nimble crane
#

(random crash)

timber path
#

Also getting this, no astrals should be scoring (though I do have some)

Oops! The game crashed:
main.lua:2547: [SMODS Cryptid "lib/calculate.lua"]:266: attempt to index a number value

Additional Context:
Balatro Version: 1.0.1n-FULL
Modded Version: 1.0.0~ALPHA-1418a-STEAMODDED
LÖVE Version: 11.5.0
Lovely Version: 0.7.1
Platform: Windows
Steamodded Mods:
    1: Hey, Listen! by SleepyG11 [ID: HeyListen, Version: 1.0.3-dev, Uses Lovely]
    2: Nopeus by jenwalter666, stupxd [ID: nopeus, Version: 2.2.3, Uses Lovely]
    3: Cryptid by MathIsFun_, Cryptid and Balatro Discords [ID: Cryptid, Priority: 2147483647, Version: 0.5.4~dev22, Uses Lovely]
    4: Jen's Library by jenwalter666 [ID: JenLib, Version: 0.3.5]
    5: Galdur by Eremel_ [ID: galdur, Priority: -10000, Version: 1.2, Uses Lovely]
    6: Talisman by MathIsFun_, Mathguy24, jenwalter666, cg-223 [ID: Talisman, Version: 2.1.0~dev, Uses Lovely]
        Break Infinity: omeganum
    7: Cartomancer by stupxd aka stupid [ID: cartomancer, Priority: 69, Version: 4.9, Uses Lovely]
    8: DebugPlus by WilsontheWolf [ID: DebugPlus, Version: 1.3.1, Uses Lovely]
    9: Incantation by jenwalter666, MathIsFun_ [ID: incantation, Priority: 9e+301, Version: 0.5.10, Uses Lovely]
    10: Hand Names by Borb [ID: HandNames, Version: 0.0.1]
    11: Blueprint by stupxd aka stupid, Jonathan [ID: blueprint, Priority: 69, Version: 3.2, Uses Lovely]
Lovely Mods:
# 
Stack Traceback
===============
(3) LÖVE function at file 'boot.lua:352' (best guess)
Local variables:
 errhand = Lua function '(LÖVE Function)' (defined at line 553 of chunk [lovely debugplus.console "console.lua"])
 handler = Lua function '(LÖVE Function)' (defined at line 553 of chunk [lovely debugplus.console "console.lua"])
(4) global C function 'error'
(5) Lua field 'update' at file 'main.lua:2547'
Local variables:
 dt = number: 0.0322116
 success = boolean: false
 msg = string: "[SMODS Cryptid \"lib/calculate.lua\"]:266: attempt to index a number value"
(6) Lua function '?' at file 'main.lua:1079' (best guess)
(7) global C function 'xpcall'
(8) LÖVE function at file 'boot.lua:377' (best guess)
Local variables:
 func = Lua function '?' (defined at line 1050 of chunk main.lua)
 inerror = boolean: true
 deferErrhand = Lua function '(LÖVE Function)' (defined at line 348 of chunk [love "boot.lua"])
 earlyinit = Lua function '(LÖVE Function)' (defined at line 355 of chunk [love "boot.lua"])
nimble crane
#

phantom double scale gaming

tulip valve
#

Crashed when using a "Risti" planet card from a planet pack, I would have had one more choice left afterwards, but reloading after the crash skipped past the planet pack without applying said card

📎 message.txt
timber path
#

Been a long time since I've worked with lua so best I can manage is an unhandled crash at end of round instead of a handled crash in calculation 🥲

nimble crane
#

phantom double scale

orchid frost
#

But apparently it’s caused by a card with corrupted data

#

So ig you could try spamming hanged man?

timber path
#

Not really sure how it'd have happened since I've not done any deck changes since the last round except using some of my cryptid playing cards to duplicate themselves, mb that's useful idk

nimble crane
#

had an idea

#

in 2 am sleepylirium form

#

what if

#

actually question

#

uhh

#

(i forgor)

#

can the calculate function be activated with specific contexts even if that context isn't otherwise active?

#

so like

#

hook

#

just hook

#

(does that need more info)

timber path
brazen plover
timber path
#

Seems to crash about the frame my deck is fully rebuilt

#

As in, as soon as the number hits 39/39 in the bottom right

#

nothing in the log even on debug

image.png
craggy fractal
#

payload seems to be broken(crash when the interest money screen is supposed to load), im on the latest github release

📎 message.txt
brazen plover
craggy fractal
#

refactor

orchid frost
#

ps pot of jokes being invisible is known i'll fix later

craggy fractal
#

i just downloaded the newest version to make sure

brazen plover
#

was the payload bug not fixed?

craggy fractal
#

maybe its because i downloaded the new version after i started that run?

orchid frost
#

I think it’s a diff bug with interest

#

That wasn’t fixed yet

#

Idk

brazen plover
#

seems like a talisman crash if im not mistaken right

#

oh is "silly cars" your mod?

craggy fractal
#

yeagh

#

lmao

brazen plover
#

are you sure its not your mod causing the bug

craggy fractal
#

idk lemme check

brazen plover
#

what is at the common_events.lua on line 1240

craggy fractal
#

yeah its not

craggy fractal
#

or my mod

abstract folio
#

Mods/lovely/dump/functions/common_events.lua

#

you can send it

craggy fractal
brazen plover
# 
        if num_dollars > 60 or num_dollars < -60 then```
#

the second line that is pasted is line 1240

#

so i pasted lines 1239 and 1240

craggy fractal
#

am i supposed to do something with that /genq

abstract folio
#

where is that patch coming from

#

wait

#

is that

brazen plover
#

thunk code?

abstract folio
#

that's vanilla code i believe

#

nvm

rotund blade
#

Talisman support with bignum money and dollar row is kinda jank

abstract folio
#

steamodded patches that line but

#

still vanilla kinda

brazen plover
#

do you have a version with the attempt of bignum money support

rotund blade
#

I didn’t patch it properly because I cba to make 20 patches just to make it not say naneinf

#

Probably will do later

abstract folio
#

no but that's a comparison

#

so it's crashing

brazen plover
#

yea, the same crashes with the proccess of my version of almanac to work in new calc

rotund blade
#

Talisman should probably latch that line then

brazen plover
#

hmmm.... i wonder if you could make a function that makes those comparisions read like a to_big() comparision

#

assuming no one has tried that yet

rotund blade
#

luajit2:

brazen plover
#

oh is that what it does?

rotund blade
#

one of the improvements is it makes those comparisons automatic

#

if compiled a certain way

#

when it’s stable I want to bundle it with Talisman/Cryptid releases

brazen plover
#

oh.... well that is what i have been running

#

probably why i wasnt getting many crashes others were having

brazen plover
#

@orchid frost what happened to potofjokers?

orchid frost
#

I messed up and removed the sprite

#

While fixing something else

brazen plover
#

ok that is what i figured

slender trail
timber path
brazen plover
timber path
#

Not yet, will try if I run into again

bleak ridge
#

Is it known that Exponents aren't triggering?

rotund blade
#

Golden doesn't seem to be working for me on playing cards

#

also there's this issue, might have to do with the combination of edition+enhancement here

rotund blade
nimble crane
# rotund blade

i think this can be fixed by changing trigger for it from post_trigger to post_trigger and context.individual

#

cant check, recreate or fix on my end though bc calculator hell

bleak ridge
#

Huh. I tried with multiple Scalae Exponentia and Primus but nothing happened.
Maybe it's a problem with the other mods I have.
I'm using Nopeus, Catomancer, Incantation, and extra joker packs on the refactor.

#

And Debug Plus

craggy fractal
#

i dont think the xchips joker is triggering with cards that were originally not 4s(strength, death)

#

and its also not working with seltzer

nimble crane
#

looking at code for it

#

if i'm understanding it correctly (can't check in-game description), it only increases if played hand contains 4/7, not when a 4/7 is scored

#

as such, multiple won't do anything, nor retriggers

craggy fractal
#

it wasnt working like that until now

nimble crane
#

send ss of card text so i can confirm

craggy fractal
nimble crane
#

doesn't work like that in the code ```py
if context.cardarea == G.play and context.individual and not context.blueprint then

#

there's no for loop to iterate over played/scored cards

#

its just "if card = rank 4 or 7, increase xchips"

craggy fractal
#

thats crazy 💀

#

im assuming it was changed recently?

#

or my game was doing a funny

craggy fractal
nimble crane
craggy fractal
#

interesting

nimble crane
#

either way

nimble crane
craggy fractal
#

wait

#

if its being copied it just doesnt work?

#

oooohhhhhh

#

ok

#

i cant read

#

WHAT

#

💀

#

is this joker just supposed to be weird like that

brazen plover
hearty flint
craggy fractal
#

its also working with "exposed" joker

abstract folio
#

why not get_id?

image.png
#

this is immediately fucked with stones

#

and stuff like maximised

abstract folio
#

it's passing context.blueprint when retriggering context.individual

#

like wtf

cedar shard
#

also seraph has a missing texture

nimble crane
#

use talisman 2.1

craggy fractal
#

idk if this is the right place but jokerdisplay seems to be wonky with ceirtan jokers that increase values

image.png image.png
#

going to menu and then back to the game seems to fix it temporarily though

#

its in fact not temporarily it just outright fixes it lmao

cedar shard
#

2.0.2???

#

how is there a 2.1 i downloaded latest as 2.0.2

#

oh wait pogger vepro mention!!!

cedar shard
rotund blade
simple timber
craggy fractal
nimble crane
orchid frost
#

Idk what that dude is talking about

#

You 100% can it’s just not bp compatible

rotund blade
#

@nimble crane gilded still appears to be borked

#

gonna try fixing myself

nimble crane
#

gl

#

if it helps, the exact code (which works for me) is ```lua
local gold_edition = {
object_type = "Edition",
key = "gold",
order = 5,
shader = "gold",
weight = 7,
extra_cost = 2,
in_shop = true,
config = { dollars = 2, active = true },
loc_vars = function(self, info_queue)
return { vars = { self.config.dollars } }
end,
sound = {
sound = "cry_e_golden",
per = 1,
vol = 0.3,
},
on_apply = function(card)
-- Randomize offset to -1..1
card.edition.cry_gold_seed = pseudorandom("e_cry_gold") * 2 - 1
end,
calculate = function(self, card, context)
if context.post_trigger or (context.using_consumeable and context.consumeable == card) or (context.main_scoring and context.cardarea == G.play and self.config.active) then
SMODS.calculate_effect({ p_dollars = self.config.dollars }, card, true)
self.config.active = nil
else if not self.config.active then
self.config.active = true
end
end
end,
}

rotund blade
#

think I fixed it

#

also in the process I refactored consume-able to be a one-liner

calculate = function(self, card, context) -- haha one liner
        return context.using_consumeable and {p_dollars = card.ability.extra.money}
    end,
#

working golden code

# 
if
            (
                context.post_trigger -- for when on jonklers
                and context.other_card == card
            ) or (
                context.main_scoring -- for when on playing cards
                and context.cardarea == G.play
            ) or (
                context.using_consumeable -- for when using a consumable
                and context.consumeable == card
            )
        then
            return { p_dollars = self.config.dollars }
        end
#

what were the other bugs again?

nimble crane
#

green seal (unless someone did that, i still don't know), hook and double sided

rotund blade
#

I know there's one limitation that I want to fix later
Basically if you make modificaitons to a profile there's not an easy way to see if it was originally modest, mainline, or madness

orchid frost
#

Oh yeah also add a button to reset modifications

#

Sometimes I change something and then forget what it was when I want to go back to normal

rotund blade
#

good call

#

lemme check if green seals got fixed

#

appears they did

rotund blade
rotund blade
#

SUS isn't working at all

brazen plover
#

oh i will look into it after i to_big a thing quick

rotund blade
#

I was so sad because I had a triboulet retrigger build and SUS would've been a great pickup

orchid frost
#

ugh what is sus doing now 😔

#

maybe it needs an entire rewrite

brazen plover
#

probs being sus

rotund blade
#

ok i figured it out

bronze swift
rotund blade
#

replaced not context.cardarea with context.cardarea == G.jokers and it works

orchid frost
#

is this a bettercalc moment

#

e

brazen plover
#

ah i see, also @chilly cairn fixed the obsidian orb message overflow

#

like the large amount of pop ups

chilly cairn
orchid frost
brazen plover
#

oh does it

#

lexi is doing more testing atm now

orchid frost
#

yeah because vanilla blinds don't use recalc_debuff last time I checked

stiff orbit
orchid frost
#

also it isn't really a cryptid issue specifically because it's steamodded that spams that obnoxious message

rotund blade
#

by the way I've decided I'll merge the refactor branch at some point tomorrow

#

so we have a bit more time to iron out bugs and finalize things

stiff orbit
rotund blade
#

yeah

#

also your issue is just outdated talisman

#

so update that

stiff orbit
#

Ok thanks

rotund blade
#

actually tbh

#

i might just ship it

#

right now

stiff orbit
brazen plover
#

tho could be something on my end

#

probs something on my end, but it happens when hovering over cat tag

#

oh and on mainline

rotund blade
#

unpinned this since refactor branch is merged now

#

we had good discussions here tho so lmk if you want a pinned bugfixing forum or something along those lines

little parrot
#

wow

stiff orbit
#

@rotund blade should I still send every crash report and if yes where do i send them

rotund blade
abstract folio
#

just somewhere we can look at and add bugs to be fixed

rotund blade
#

I can try setting one up later

#

Ping me if I forget

stiff orbit
rotund blade
#

yes

#

I’ll probably just make a bugfixing post like this

stiff orbit
#

good thing i reminded you