#Missing Smart Collection thumbnails for Jellyfin-augmented local libraries

1 messages · Page 1 of 1 (latest)

maiden edge
#

Noticed when creating a smart collection that none of the thumbnails were loading. When inspecting the HTML source, I saw the thumbnails were referencing the thumbnail files created by Jellyfin.

Two issues with this I guess:

  1. The URL used for the img src doesn't use file://, so the URL ends up being relative to the /web/ dir of the Tunarr URL, e.g. on Windows: http://localhost:8000/web/Z:\movies\blah.mkv etc
  2. Even with the above fixed, browsers won't allow Tunarr to serve up local files (since it's a security issue), so the thumbnails would have to be served some different way

Pre-Jellyfin, thumbnails worked fine as there Tunarr was using thumbnails from Plex instead, rather than from the local library.

arctic edge
#

i think this is a bug in the way the thumbnails are getting chosen to load. it should only attempt to load directrly via the thumbnail.path attribute if it is a remote URL

maiden edge
#

yeah that'd make sense and would solve both

arctic edge
#

otherwise it should hit the Tunarr API endpoint to load artwork

#

what is the URL it is trying to load

maiden edge
#

is above, though discord converted the backslashes to forward slashes

arctic edge
#

or rather, can you see what is being returned for the artwork for the broken items

#

gotcha, that is why

maiden edge
#

<img src="F:\TV\Divorced without Parents\Season 07\Divorced without Parents S07E12-thumb.jpg" style="border-radius: 5%; height: auto; width: 100%; visibility: hidden; z-index: 2; display: none;">

#

for example

#

minor substitutions made 🙂

arctic edge
#

ya ok that'll do it

#

i just committed a fix

#

and of course, as i expected, this whole thing broke release automation

#

you win - first issue with a fix and now 1.0.1 is going out 😛

maiden edge
#

sorry, i should have noticed it earlier! i had chalked it up to something else because i know i had seen the thumbnails before

arctic edge
#

all good, that was a very recent change. i'm surprised i didn't see it sooner, but i think there are some cases where the backend don't return the path if it is not remote in the first place

maiden edge
#

btw generating the releases, do you have to pay for that?

arctic edge
#

i dont. i use a fork of release-please (since the original repo is basically dead). it has it's pros and cons and has generally been OK, but the multi-channel release pipeline was a total PITA to setup with it

maiden edge
#

ahh ok cool

arctic edge
#

the only thing I pay for w/r/t Tunarr is an Apple Dev account license so i can properly sign those binaries

maiden edge
#

yeah gotcha

#

confirmed the fix, we're back in biz 😄

arctic edge
#

wooo!

#

thanks for the quick report

maiden edge
#

noticed something else, want me to create a new post for it? it's one minor thing and then i guess a question that's probably a feature request

arctic edge
#

yea new post would be good! for searchability

maiden edge
#

will do!

maiden edge
#

ah, doesn't impact public repos

arctic edge
#

I think we're ok "Standard GitHub-hosted or self-hosted runner usage on public repositories will remain free"