#code review?

1 messages · Page 1 of 1 (latest)

loud wave
#

Do you have a github repo, I can look at it

prisma geode
#

uh

#

lemme try and set that up rq

#

like install git n stuff

#

i havent been using it 😭

loud wave
#

I would highly recommend learning about version controlling your code, especially since Godot can have some project breaking bugs (ie Themes suddenly spike in size)

prisma geode
#

kk

prisma geode
#

its on the github website

#

how do i let you see it?

#

or pull it

#

or whatever

loud wave
#

If your repository is public you can paste the link

prisma geode
loud wave
#

That worked, I can look through it now

prisma geode
#

the main thing im worried about is how i keep track of where the cards are

loud wave
#

The cards will only exist on either the stack, discard, or grid. So my suggestion would be to make the card a child of wherever it is supposed to be and then have the parent determine if the card should be visible/interactable.

prisma geode
#

o

#

i did that once and someone told me it was a bad idea (idk why tho)

loud wave
#

Then if you want to find the location of any card, you can either use get_node() from the root like you currently do in a few places. Or you could keep a dictionary that maps a cards name to it's reference.

loud wave
prisma geode
#

i still have the project that was made like that but i couldnt get the card switching down

#

so then i restarted with this approach

loud wave
#

Honestly, I think everything else in your project looks fine (I have seen way worse lol).

prisma geode
#

thats... scary

loud wave
#

Yeah gddeadinside

prisma geode
#

i thought i was on the lower end (maybe i am but i didnt know it got worse)

loud wave
#

Most of the changes I would make are pretty much just nitpicks about style. The overall design isn't bad

prisma geode
#

k

#

also 1 more thing

#

lemme find it rq

#

if you can look at On_Release_Card.gd

#

in the states folder

#

wait

#

lemme figure out how this works again 😭 (worst part is i just made this)

#

right so im using the file path of the scene to determine what the target is

#

this doesnt seem like a good way to do it (i kinda dont like how moving them around in the folders breaks everything)

#

i was wondering if theres any other way to differentiate between them that looks better

loud wave
#

There are a couple of ways to do this, I would just add a group to the node you are checking

prisma geode
#

oh so like a group for all the screws and a group for all the empty cards?

loud wave
#

Yeah