#Weapon Swapping
sudden compass
worthy onyx
How is your node structure?
Do you have all gun models instantiated at the same time?
sudden compass
sudden compass
How is your node structure?
Do you have all gun models instantiated at the same ...
uh
worthy onyx
So each gun has a camera that holds the script. But the script has specific code for each gun all clumped in the same script?
sudden compass
no its 2 scripts
worthy onyx
Different ones?
sudden compass
weaponscript is just what i made the class name for the shotgun script
cus originally it was the only weapon
but now i added the pistol
sudden compass
this and
sudden compass
this
are the same script edited for each weapon
so same but not same
pistol_cam and view_model
worthy onyx
This is a pretty odd approach, i'm thinking on how to make this work without changing too much stuff.
sudden compass
sorry ive used godot for only 6 days XD
im surprised i even get to have errors to do with weapons in unity basic movement took me a week or so :P
worthy onyx
Honestly i'd start by reworking the scripts. I see the shotgun script still has pistol specific stuff.
You can also use inheritance to avoid having 2 identical scripts.
Like, you can have a "Weapon" class that is not attached to any node, but rather meant to be expanded by each weapon:
##Weapon.gd
class_name Weapon
extends Node3D
@export var fps_rig: Node
@export var animation_player: Node
@export var fire_rate: Node
@export var weapon_sound: Node
@export var weapon_cocking: Node
@export var light: Node
@export var emitter: Node
@export var flash_time : float = 0.02
@export var aim_emitter: Node
var in_use = false;
var aiming = false;
var can_fire : bool = true
signal weapon_fired
signal aim_weapon_fired
func add_muzzle_flash() -> void:
light.visible = true
emitter.emitting = true
await get_tree().create_timer(flash_time).timeout
light.visible = false
##And all the other code you may need.
Then, you can add a new script to the shotgun/pistol and automatically include all of this code just by extending it:
##Pistol.gd
extends Weapon
If, for example, you want the _input() function to work differently for the new script, you can declare it again in said script and it will overwrite the one from the "Weapon" script.
extends Weapon
func _input(event):
##Different code goes here
With @export you can define diferent nodes like "weapon_sound" per scene. Using the inspector.
Or you can just keep using @onready if both will have nodes with the same names.
sudden compass
Honestly i'd start by reworking the scripts. I see the shotgun script still has ...
okok
thankyou!
where would that script go?
like would i put that in the main scene then?
worthy onyx
The first one wouldn't be in any node.
It would just be in any folder inside your project.
It just exists to define the "Weapon" class and all its code.
sudden compass
ah okok thanks for clearing that up
worthy onyx
Actually, if you add a gun that does not need different code. You can indeed use that script for it.
sudden compass
well
only the shotgun needs different code atm
but eventually both will
because different muzzle flashes
maybe if i add a bow and arrow (very probable) it will just use that
worthy onyx
Does the muzzle flash need different code or a different node?
Because if for example you're using an AnimationPlayer for the muzzle flash in all cases, using a different AnimationPlayer wouldn't require any extra code. You just set it to use that node if you're using @export or make it have the same node name if you're using @onready
It would probably need the animations to be called the same too, tho.
worthy onyx
Depends on your approach.
sudden compass
and do i delete the second viewports?
worthy onyx
@export does not care about names.
@onready would need it to be the case.
worthy onyx
and do i delete the second viewports?
I'd delete the viewports yeah. They are a performance hog and complicate things a lot.
sudden compass
but its so the weapon cant clip
worthy onyx
Aaah, right. Forgor.
You can use the same viewport.
Just make all weapons a child of the same viewport instead of having one for each.
sudden compass
so put both cameras in the same viewport then?
worthy onyx
That should work.
You also only need 1 camera.
Format would be:
SubViewport
|->Camera
|->Pistol
|->Shotgun
sudden compass
That should work.
You also only need 1 camera.
oh?
sudden compass
Format would be:
SubViewport
|->Camera
|->Pistol
|->Shotgun
lemme do that
sudden compass
Format would be:
SubViewport
|->Camera
|->Pistol
|->Shotgun
got sidetracked let me do it now
sudden compass
Format would be:
SubViewport
|->Camera
|->Pistol
|->Shotgun
it it like camera and then pistol and shotgun inside it?
or camera and pistol and shotgun are siblings
this ok?
@worthy onyx sorry for tag ur very helpful XD ur helping me understand
and i only have 15 mins left
or this
sudden compass
I went out, sorry.
The first structure was good, but both work
i broke it all
sudden compass
I went out, sorry.
The first structure was good, but both work
completely and utterly broke it all
the pistol doesnt even exist
but like its there
but its not
sudden compass
ok its slightly better now
sudden compass
ok its still shit tho
sudden compass
class_name Weapon
extends Node3D
@export var fps_rig: Node3D
@export var animation_player: AnimationPlayer
@export var fire_rate: Timer
#@export var weapon_sound: AudioListener3D
#@export var weapon_cocking: AudioListener3D
#@export var light: Node
#@export var emitter: Node
#@export var flash_time : float = 0.02
#@export var aim_emitter: Node
var in_use = false;
var aiming = false;
var can_fire : bool = true
signal weapon_fired
signal aim_weapon_fired
func _ready():
pass
#func sway(sway_ammount):
#fps_rig.position.x -= sway_ammount.x * 0.00005
#fps_rig.position.y += sway_ammount.y * 0.00005
#func add_muzzle_flash() -> void:
#light.visible = true
#emitter.emitting = true
#await get_tree().create_timer(flash_time).timeout
#light.visible = false
extends Weapon
@export var pistol : Node3D
@export var shotgun : Node3D
var pistol_in_use : bool = true
var shotgun_in_use : bool = true
func _input(event):
if can_fire:
if event.is_action_pressed("left_mouse") and pistol_in_use:
fire_rate.start()
can_fire = false
if aiming:
$AnimationPlayer.play("aim_fire")
emit_signal("aim_weapon_fired")
$pistol_sound.play()
else:
$AnimationPlayer.play("fire_pistol")
emit_signal("weapon_fired")
$pistol_sound.play()
if event.is_action_pressed("itemslot2"):
if pistol_in_use:
$AnimationPlayer.play("unequip_pistol")
pistol_in_use = false
pistol.hide()
else:
$AnimationPlayer.play("equip_pistol")
pistol_in_use = true
shotgun_in_use = false
pistol.show()
shotgun.hide()
if event.is_action_pressed("right_mouse") and pistol_in_use:
if not aiming:
aiming = true
$AnimationPlayer.play("aim_down_sight")
elif event.is_action_released("right_mouse") and pistol_in_use:
if aiming:
aiming = false
animation_player.play("stop_aim")
func _on_fire_rate_timeout():
can_fire = true
extends Weapon
@export var pistol : Node3D
@export var shotgun : Node3D
var shotgun_in_use : bool = true
var pistol_in_use : bool = false
func _input(event):
if can_fire:
if event.is_action_pressed("left_mouse") and shotgun_in_use:
fire_rate.start()
can_fire = false
$shotgun_sound.play()
$shotgun_cocking.play()
if aiming:
animation_player.play("aim_fire")
emit_signal("aim_weapon_fired")
else:
animation_player.play("fire_shotgun")
emit_signal("weapon_fired")
if event.is_action_pressed("itemslot1"):
if shotgun_in_use:
animation_player.play("unequip_shotgun")
shotgun_in_use = false
shotgun.hide()
else:
animation_player.play("equip_shotgun")
shotgun.show()
shotgun_in_use = true
pistol_in_use = false
pistol.hide()
if event.is_action_pressed("right_mouse") and shotgun_in_use:
if not aiming:
aiming = true
animation_player.play("aim_down_sight")
elif event.is_action_released("right_mouse") and shotgun_in_use:
if aiming:
aiming = false
animation_player.play("stop_aim")
func _on_fire_rate_timeout():
can_fire = true
weapon,gd
worthy onyx
```
class_name Weapon
extends Node3D
@export var fps_rig: Node3D
@export var an...
What is the issue currently?
sudden compass
What is the issue currently?
right now its this because im trying to make only one weapon useable at once (for obvious reasons)
worthy onyx
I mean, this wouldn't do anything.
This runs once when the node is added and doesn't do anything.
WeaponType.SHOTGUN is the same as just leaving a "1"
What code do you run when changing weapons?
sudden compass
What code do you run when changing weapons?
ill show you
this and the inverse for shotgun
brave jetty
Neither pistol nor shotgun have a script
worthy onyx
They do, they are a above
#1266152812040028252 message
distant sphinx
so which nodes did you export - having these two nodes with the same names is probably not helping you
worthy onyx
this and the inverse for shotgun
And this doesn't work?
brave jetty
But that’s $shotgun/shotgun that has the script
worthy onyx
My GPU is kinda having issues, anything 3D just renders as random coloured triangles.
Its a weird issue with my cobbled-togheter Windows version, i'll fix it someday :p
sudden compass
its not anything fancy i think it might run
worthy onyx
Ok, send it.
sudden compass
the gpu particles are currently disabled
fair warning ESC closes the game
test build exported for my friend tani and i spelt it wrong XD
little root
this and the inverse for shotgun
which scirpt is this in?
worthy onyx
I tought you meant the project folder. Sorry but i am not running an exe i found online.
sudden compass
I tought you meant the project folder. Sorry but i am not running an exe i found...
oh yea i can send that too
sudden compass
which scirpt is this in?
pistol
and the other in shotgun
how do i export the project? just zip it in file manager?
devout berry
I wrote a little example on how enums work.
extends Node3D
class_name WeaponSwapExample
enum WeaponType {PISTOL, SHOTGUN, A_GIANT_BANANA}
var selected_weapon: WeaponType
func _ready():
# This sets selected_weapon as pistol
selected_weapon = WeaponType.PISTOL
# This swaps weapon to selected_weapon
swap_weapon(selected_weapon)
func swap_weapon(weapon_to_swap_to:WeaponType):
# These check which weapon was selected
if weapon_to_swap_to == WeaponType.PISTOL:
print("pistol selected")
elif weapon_to_swap_to == WeaponType.SHOTGUN:
print("shotgun selected")
elif weapon_to_swap_to == WeaponType.A_GIANT_BANANA:
print("yum yum banana")```That would work
sudden compass
I wrote a little example on how enums work.
```swift
extends Node3D
class_name...
swap_weapon doesnt exist in this context though right?
sudden compass
That would work
devout berry
swap_weapon doesnt exist in this context though right?
What do you mean? Like in your own code?
Yeah I just wanted to give you an example on how enums work.
sudden compass
What do you mean? Like in your own code?
Yeah I just wanted to give you an examp...
no i meant in the example
swap_weapon doesnt exist
devout berry
It does, it's a func below ready
sudden compass
oh im slow sorry
devout berry
Enums are just numbers internally btw.
It's a lot like doing int weapon_type except you get to name them so it's much easier to remember what is what. It'd be harder to remember what 0, 1, 2 mean.
sudden compass
yea i read the documentation
its like emum {chicken, banana, orange}
is same as
chicken = 1
banana = 2
orange = 3
righr?
devout berry
0, 1, 2. but yeah you got the idea!
worthy onyx
Ah, i had discord muted, didn't hear the DM
worthy onyx
is actual ?
Yeah, basically like that.
Internally it is considered a constant Dictionary off String : int.
sudden compass
Yeah, basically like that.
Internally it is considered a constant Dictionary of...
i think chicken and banana makes more sense then that
little root
i think architecturally, it doesn't make sense for your pistol script to be responsible for switching to your shotgun., you'd be better off having a common parent thats responsible for switching
also, whats the purpose of your
pistol: Node3D
--- pistol: Node3D structure?
why not just have the script on the parent, and get rid of the second node3d?
sudden compass
also, whats the purpose of your
pistol: Node3D
--- pistol: Node3D structure?
...
i just want it to look tidier XD
little root
turn each weapon into a scene of its own, so its children are hidden
worthy onyx
I've honestly done it like this before.
But i always make sure that, in this case the "Weapon" script, has a way to get all other weapons.
sudden compass
there is the > arrow for that
sudden compass
I've honestly done it like this before.
But i always make sure that, in this cas...
does it?
worthy onyx
atm you have to manually keep a variable for each gun and replicate the code in both scripts.
sudden compass
atm you have to manually keep a variable for each gun and replicate the code in ...
even with this in weapon.gd?
worthy onyx
The thing is that you'll have to create a new variable for each new gun you implement.
It is not BAD, but considering the over-reliance on a single class for handling all guns, it is a bit messy.
sudden compass
The thing is that you'll have to create a new variable for each new gun you impl...
so i should use enum? or what would be better
worthy onyx
I would recommend relying on enums, yeah.
sudden compass
so keep this then
worthy onyx
I can't open the project you sent me sadly
sudden compass
because 3d?
worthy onyx
Probably my GPU
sudden compass
if you go to my stream its open
worthy onyx
your stream?
worthy onyx
Oh damn, that's fancy.
sudden compass
its built into discord
little root
Quick question, not strictly about your current issue. but are you using shotgun.hide() in an effort to "turn off" the shotgun?
sudden compass
to make it so they dont both display at the same time
turning off is next on the list
little root
ok, just wanted to check you were aware its code would still run even when hidden 🙂
sudden compass
no problem :)
worthy onyx
So, i'd start by implementing a function to get all guns, and also make the script keep track of their type.
##To add to Weapon.gd
const WEAPON_GROUP := "_WEAPONS"
@export var type: WeaponType
## Register this weapon in the group when it enters the scene.
func _ready():
get_tree().add_to_group(WEAPON_GROUP)
## Get all weapons in the group
func get_weapons() -> Array[Node]:
return get_tree().get_nodes_in_group(WEAPON_GROUP)
##Lets you get the specific weapon.
func find_weapon(weapon_type: WeaponType) -> Node:
for weapon: Node in get_weapons():
if weapon.type == weapon_type:
return weapon
You'd also have to set each gun's type on the scene using the @export above.
sudden compass
worthy onyx
Ah, right.
Add a "return null" at the bottom of the function.
If it cannot find a weapon of the given type, it needs a fail safe.
sudden compass
same error am i putting it in wrong place?
worthy onyx
It has to be at the same level as the "for"
sudden compass
fixed
ty
shotgun in use still broken
should it just be if WeaponType.SHOTGUN
or even just WeaponType.SHOTGUN
worthy onyx
How are you deciding which gun is active?
worthy onyx
I mean, do you have a variable that says which is active?
sudden compass
oh, shit no i dont
worthy onyx
For equipping weapons, you can use a static variable to ensure only one is active at a time and make it accessible to all Weapon nodes.
static var equipped_weapon: Weapon
That way, all guns can just do this to set themselves as equipped:
equipped_weapon = self
in weapon.gd?
worthy onyx
Yeah
sudden compass
where does equipped_weapon = self go
worthy onyx
Now any gun can check if they are equipped with "if equipped_weapon == self"
Or even know the type of the equipped one with "if equipped_weapon.type == WeaponType.SHOTGUN"
In the function for equipping the gun.
worthy onyx
This kind of stuff doesn't do anything tho.
sudden compass
oh
worthy onyx
It is the same as doing
1
not 0```You can just remove that from _ready():
When you do "equipped_weapon = self", you automatically unset that variable from ALL weapons and set it to the new value.
As in, now all weapons know what is equipped, and only one can be equipped at a time.
sudden compass
should i add a 3rd weapon type that is NONE
so both know that nothing is equipped
worthy onyx
Ah, you want to set the equipped_weapon as a "WeaponType"?
worthy onyx
In that case, change the typing of the variable from "Weapon" to "Weapon.WeaponType"
And instead of "= self". Do "= type"
sudden compass
type.<WEAPONTYPE>?
well technically setting it to self auto sets it as a weapon type no?
worthy onyx
well technically setting it to self auto sets it as a weapon type no?
No, because self is the node itself, which is a "Weapon" class.
WeaponType is an enum BELONGING to the Weapon class.
You can still use the node to get its type tho.
worthy onyx
Ah, i gave the wrong syntax.
It is just "add_to_group(WEAPON_GROUP)"
Apparently the SceneTree doesn't need to be referenced to add them.
sudden compass
Ah, i gave the wrong syntax.
It is just "add_to_group(WEAPON_GROUP)"
thats not the error i think
oh it was maybe?
idk
worthy onyx
Did you save before running again? There's no reference to any SceneTree there.
worthy onyx
Happens if you save while the game is running. You have to stop it first.
sudden compass
oopsies
STILL INVALID GET INDEX IN USE ON NODE3D
oh i guess it can just be if WeaponType.SHOTGUN
worthy onyx
STILL INVALID GET INDEX IN USE ON NODE3D
Maybe you set a non Weapon node as the shotgun?
sudden compass
Maybe you set a non Weapon node as the shotgun?
why?
i dont have a non weapon node?
worthy onyx
i dont have a non weapon node?
Any node that does not have a script that extends Weapon (or Weapon.gd itself) is not a Weapon node.
Also, ofc. "in_use" must be defined in Weapon.gd
Altho is there any difference between in_use and equipped_weapon?
sudden compass
Altho is there any difference between in_use and equipped_weapon?
oh, no there isnt i dont think
all broken again :(
worthy onyx
How so?
Worth noting that the changes so far are for a rework of how the gun system works. My changes alone aren't meant to work out of the box.
You still need to modify the existing code to work with the new changes.
worthy onyx
That's normal, errors means that you are being told what to do next.
sudden compass
is this correct for unequipping
sudden compass
That's normal, errors means that you are being told what to do next.
no errors, just stuff doesnt work how i want it to
worthy onyx
Nope, there you're just referencing the value, but you aren't actually changing anything.
You'd have to do "equipped_weapon = WeaponType.EMPTY"
worthy onyx
The type of the variable (equipped_weapon) is still Weapon, you have to change it to be Weapon.WeaponType
sudden compass
iirc = if i recall correctly?
worthy onyx
yep
sudden compass
hmm
why can weapon type not be weapon variable
oh cus weapon and weapontype arent the same?
worthy onyx
Because Weapon is a Node.
WeaponType is an enum (a Dictionary, internally)
sudden compass
so remove weapon.?
worthy onyx
Replace it with Weapon.WeaponType (or maybe just WeaponType).
I probably should have mentioned earlier, enum names can be used as types for purposes of type casting.
sudden compass
both give the same error
worthy onyx
That's impossible, are you sure you're saving?
Can you show me the code where this error pops up?
worthy onyx
And the equipped_weapon definition was modified to be like this?
var equipped_weapon: Weapon.WeaponType
worthy onyx
I should have clarified what i meant with "definition".
worthy onyx
There's some code further down that is trying to do the opposite you're doing here. Putting a Weapon in the variable instead of a WeaponType
worthy onyx
It says line 35
That function is just getting values, it is not setting anything.
worthy onyx
Yep, that could simply be replaced with: "equipped_weapon = type"
sudden compass
now its just the cannot get property from enum value
worthy onyx
WeaponType still has a "SHOTGUN" value, right?
worthy onyx
I'm trying to figure out what is wrong here.
The enum and its value exist. I don't understand what it is complaining about.
aaah, equipped_weapon is not a Weapon anymore. It doesn't have a "type" property.
equipped_weapon is the WeaponType itself.
sudden compass
so that means i just put equipped_weapon = [weapontype here] ?
worthy onyx
yeah, that should work (with double =)
worthy onyx
Like this:
equipped_weapon == WeaponType.SHOTGUN
equipped_weapon changed to be a WeaponType, but you still need to specify from where "SHOTGUN" is coming from in the right half.
sudden compass
is
worthy onyx
Also, you never did "equipped_weapon = WeaponType" right?
sudden compass
this?
worthy onyx
I mean after that definition.
sudden compass
no, i didnt
worthy onyx
If you where to write 2 lines like this:
equipped_weapon
WeaponType.SHOTGUN```
Does it throw an error?in ready?
worthy onyx
Anywhere, really. I imagine this error is happening without the game running (?)
sudden compass
sudden compass
Anywhere, really. I imagine this error is happening without the game running (?)
yea
sudden compass
YAY
now the errors arent in the weapon gd
time for shotgun
extends Weapon
func _input(event):
if can_fire:
if event.is_action_pressed("left_mouse") and equipped_weapon == WeaponType.PISTOL:
fire_rate.start()
can_fire = false
$shotgun_sound.play()
$shotgun_cocking.play()
if aiming:
animation_player.play("aim_fire")
emit_signal("aim_weapon_fired")
else:
animation_player.play("fire_shotgun")
emit_signal("weapon_fired")
if event.is_action_pressed("itemslot1"):
if equipped_weapon == WeaponType.SHOTGUN:
animation_player.play("unequip_shotgun")
equipped_weapon == WeaponType.EMPTY
shotgun.hide()
else:
animation_player.play("equip_shotgun")
shotgun.show()
shotgun.in_use = true
pistol.in_use = false
pistol.hide()
if event.is_action_pressed("right_mouse") and equipped_weapon == WeaponType.SHOTGUN:
if not aiming:
aiming = true
animation_player.play("aim_down_sight")
elif event.is_action_released("right_mouse") and equipped_weapon == WeaponType.SHOTGUN:
if aiming:
aiming = false
animation_player.play("stop_aim")
func _on_fire_rate_timeout():
can_fire = true
this is shotgun.gd
do i need to change or remove anything here
its throwing errors at me about in_use
worthy onyx
I'd just remove in_use altogheter. Maybe replace it with a function if you need to.
func is_in_use() -> bool:
return type == equipped_weapon
sudden compass
its throwing errors at me about in_use
fixed those now were back to both weapons functioning no matter of visibility or equipped_weapon
worthy onyx
Do you have any code that prevents the guns from working when the other is equipped?
In shotgun you only allow firing if the PISTOL is active, idk if that was intentional.
sudden compass
Do you have any code that prevents the guns from working when the other is equip...
no
sudden compass
In shotgun you only allow firing if the PISTOL is active, idk if that was intent...
it was not
why would that be intentional 😭
maybe it was
past me might me smarter
because i change this to shotgun and now the pistol sounds play when i try to fire
worthy onyx
I don't see any code related to the pistol's sound there.
Unless $shotgun_sound has the sound of the pistol by mistake.
sudden compass
no because its pistol fire rate too
worthy onyx
Or the AnimationPlayer is in charge of the sound.
sudden compass
its not
extends Weapon
func _input(event):
if can_fire:
if event.is_action_pressed("left_mouse") and equipped_weapon == WeaponType.PISTOL:
fire_rate.start()
can_fire = false
if aiming:
$AnimationPlayer.play("aim_fire")
emit_signal("aim_weapon_fired")
$pistol_sound.play()
else:
$AnimationPlayer.play("fire_pistol")
emit_signal("weapon_fired")
$pistol_sound.play()
if event.is_action_pressed("itemslot2"):
if WeaponType.PISTOL:
$AnimationPlayer.play("unequip_pistol")
equipped_weapon = Weapon.WeaponType.EMPTY
pistol.hide()
else:
$AnimationPlayer.play("equip_pistol")
equipped_weapon == WeaponType.PISTOL
pistol.show()
if event.is_action_pressed("right_mouse") and equipped_weapon == WeaponType.PISTOL:
if not aiming:
aiming = true
$AnimationPlayer.play("aim_down_sight")
elif event.is_action_released("right_mouse") and equipped_weapon == WeaponType.PISTOL:
if aiming:
aiming = false
animation_player.play("stop_aim")
func _on_fire_rate_timeout():
can_fire = true
The pistol is slot 2, right?
sudden compass
correct
worthy onyx
It is starting to get a little too bloated in _input()
I'd make a separate function to change weapons, that is called from inside _input()
You could tell the function which WeaponType you are trying to change to, or simply the slot. Then use that to run the rest of the logic.
At least i couldn't find out what is the issue myself without breakpoints, in the current code.
sudden compass
You could tell the function which WeaponType you are trying to change to, or sim...
the slots are not connected to any inventory system yet the inputs are named pre-emptively
worthy onyx
That is fine, you just need to know what weapon to bring out.
Like:
if event.is_action_pressed("itemslot2"):
change_weapon(WeaponType.Pistol)
i need change_weapon function?
worthy onyx
That is an example, altho that would be a good way yo offload some code.
The issue rn is the complexity of the functions you're using. Which is making it too hard to discover what is the culprit.
This is a common issue with bloated code, which is why it is always recommended to break things down into separate functions
sudden compass
ok so how do i make this function
as in format
my code is always way too much in 1 function
here is my player.gd
well part of it
have to make it ,txt
worthy onyx
As an example:
func change_weapon( type_to_equip : WeaponType):
##If you select the same weapon already equipped, unequip it.
if type_to_equip == type:
equipped_weapon = Weapon.WeaponType.EMPTY
if type_to_equip == WeaponType.PISTOL:
$AnimationPlayer.play("unequip_pistol")
if type_to_equip == WeaponType.SHOTGUN:
$AnimationPlayer.play("unequip_shotgun")
##If it is different.
else:
equipped_weapon = type_to_equip
if type_to_equip == WeaponType.PISTOL:
$AnimationPlayer.play("equip_pistol")
if type_to_equip == WeaponType.SHOTGUN:
$AnimationPlayer.play("equip_shotgun")
##Rest of the code...
this goes in the pistol?
sudden compass
okok
u silly billy
u put weapon.weapontype.empty instead of just weapontype.empty
im pro game dev i see it from 1 billion light years away
worthy onyx
Ya, i don't remember which language complains about not being explicit. So now i do it automatically
sudden compass
ah you know lots?
worthy onyx
Aside from GDScript i learned trough Java coding (which i forgor now)
I am sure i can still do stuff in lua and i am currently trying to master C#
I tried JavaScript but it is so bad i prefer not learning it lol
worthy onyx
Screenshot?
sudden compass
its in game
worthy onyx
Of the code i mean. The one in _input is probably at fault.
worthy onyx
You need an _input() function to control stuff with inputs.
sudden compass
if event.is_action_pressed("itemslot2"):
if WeaponType.PISTOL:
$AnimationPlayer.play("unequip_pistol")
equipped_weapon = Weapon.WeaponType.EMPTY
pistol.hide()
else:
$AnimationPlayer.play("equip_pistol")
equipped_weapon == WeaponType.PISTOL
pistol.show()
so this should be in weapon script then?
worthy onyx
Ah, i tought you where using the change_weapon() function
sudden compass
no i start game and press 1 (itemslot1) and it equip animation
and i press again... equip animation
and again... same same same u get it
worthy onyx
Then what did you change that could cause that issue of constant unequipping?
worthy onyx
As i said earlier, you either need to start decoupling code into separate functions or run trough your code line by line and ensure the logic is correct.
Normally i'd use breakpoints to debug this (if i had to make a function this large). But i can't do that remotely.
sudden compass
sudden compass
Normally i'd use breakpoints to debug this (if i had to make a function this lar...
istg i will open teamviewer rn 😭
this shit is making me insane
worthy onyx
I have stuff to do, so i don't think i can keep helping with this for today.
Even with team viewer (which i don't have installed) we would just be trying to untangle spaghetti without fixing any of it.