rebuild github mod package to local

[mental iron]

Hi, i want to make a change to a library from github, but i don't know if this the correct way or not. The library i use is https://github.com/sijms/go-ora

after i clone from git, i make change the go.mod

// module github.com/sijms/go-ora/v2
module go-ora-local

go 1.17

require golang.org/dl v0.0.0-20230616140434-092be8a72776 // indirect

but then all the file will have error could not import from github.com/sijms/go-ora/v2

currently i manuall change the import package of each file. Is there any idioms way to do this ? thank you

[swift epoch]

do not change the module name to something else

that's the most simple solution

[swift epoch]

Anyway, why are you changing it? if you want test packages localy, use go.work

[mental iron]

if i don't change it, then it produce error could not import from github.com/sijms/go-ora/v2 , which is actually this source code itself

[swift epoch]

I just tested, there are no error that cannot import it

if you don't change the codes

use go get instead git clone

[mental iron]

no, i need to make change in the code, i mean i'm not in the consumer side of the dependencies, but something like contributor i guess ?

[swift epoch]

Use go.work as I said

https://go.dev/doc/tutorial/workspaces

[mental iron]

is it similar to mod replace ?

[swift epoch]

yes, but only at your localhost

[mental iron]

so basicly, when we're contributing to library, we can't just git clone and the mod magicly auto format the import ? but we still need to tweak the mod with replace / go.work ?
(sorry, this is my first time in the world of open source contributing)

[swift epoch]

I'm not a advanced contributer in go, so Idk. And I reject the go.work idea I said, it's not for your case. Basicly, the package shouldn't have error when you run go test with the package installed anywhere, so I think you should just contact the author? maybe?

[mental iron]

the package is working if you use go get. And it's actually fine

[swift epoch]

And remember to check your command, it should be go test /path/to/go-ora/v2

[swift epoch]

Do not edit package when using go get anyway

I mean, do not edit the package download from go get

[swift epoch]

or chdir into /path/to/go-ora/v2, and do go test .

[mental iron]

😭

[swift epoch]

The author made a bad folder structure, a go.mod shouldn't under another go.mod

[mental iron]

i need to make change in the go-ora/v2/parameter_decode_array.go
the switch case is somehow not handling some of []driver.value i need. Therefore i need to trace and tweak it

that's why i need to make change in the library itself

[mental iron]

i'm agree with this, but since the project is before 1.18 , it is what it is i think 😅

[swift epoch]

And yeah, where and what is inside your main.go?

if the main.go is not under go-ora/v2, you should use go.work then

[mental iron]

it's in another project. But the concern is not in my project

[swift epoch]

what's your project's go.mod

it could be your project issue

[mental iron]

module some_module
replace github.com/sijms/go-ora => ../go-ora

[swift epoch]

So here it is

you should use replace github.com/sijms/go-ora/v2 => ../go-ora/v2

and never use replace now, use go.work instead

[mental iron]

no, even i replace it the v2, the local project itself is error

even go.work redirecting to my local go-ora/v2, the local go-ora/v2 itself is in error

[swift epoch]

I don't think you have to redirect in go.work

just use

go **

use (
  /path/to/go-ora/v2
  /path/to/your/project
)

[mental iron]

this is in my project. But the problem is not in my project, but the local library itself 😭

[swift epoch]

trust other libraries

[mental iron]

no😭

i'm between laughing and crying here sir😭

[swift epoch]

well, if I have time later, I will taking this with you, but now I have other things todo

[mental iron]

okay, thank you for the time 🙏