io.ReadAll and errors

[dapper mantle]

Hey, all. Can someone explain the last sentence in the io.ReadFull docstr

If r returns an error having read at least len(buf) bytes, the error is dropped.
In particular, why would io.ReadFull ever read more than len(buf) bytes?

[leaden shadow]

ReadAll does not take a buf as input, you are confusing ReadFull and ReadAll.

[dapper mantle]

A simple typo, but yes: the question is about io.ReadFull.

[leaden shadow]

@dapper mantle see this: https://github.com/golang/go/commit/665af046c29eafd35460e985a10ce74b1d9d3ef8
abd this: https://github.com/golang/go/issues/20477

[leaden shadow]

it's really not about ReadAll, the text you cited is from ReadFull's documentation

[dapper mantle]

I can't type. Yes, io.ReadFull.

[leaden shadow]

ReadAll grows an internal buffer forever until io.EOF is returned, it doesn't care about considerations like that

[leaden shadow]

yeah 🙂 well I linked the commit and the issue that prompted the addition of this line, I hope it helps you

[fallow cobalt]

ugh, you beat me by a full minute #go-chat message

[dapper mantle]

Not a competition! I appreciate you both :}

[fallow cobalt]

yes it is!

[dapper mantle]

oh, then you lost 😮

[leaden shadow]

who is counting points ?

[fallow cobalt]

idk but I'm evidently losing