#Some Artifacts Are Created w/ No Modifier

1 messages · Page 1 of 1 (latest)

dusk crane
#

So (some? most?) artifacts gained during the Trial of Greed are created with no modifiers except the placeholder +0.01 Prestige. They're good for selling, but not much else.

I believe it may be due to the way get_treasure_reward is written in common\scripted_effects\expedition_trial_of_greed_effects.txt, specifically all the create_artifact = { ... } blocks, e.g.:

    name = artifact_elf_dagger_name
    description = artifact_elf_dagger_description
    # creator = scope:creator
    visuals = dagger
    type = dagger
    modifier = artifact_placeholder_modifier
    wealth = scope:wealth
    quality = scope:quality
    save_scope_as = newly_created_elf_artifact
}
scope:activity = {
    add_to_variable_list = {
        name = artifact_rewards
        target = scope:newly_created_elf_artifact
    }
}```
Looking at the code for the regular expedition artifacts, I believe you need a block between the _create_artifact = {...}_ and _scope:activity = {...}_ of:
```scope:newly_created_elf_artifact = {
    # Rarity determines prowess bonus
    add_scaled_artifact_modifier_prowess_effect = yes
    add_elf_weapon_modifier = yes
}```
(Or the equivalent for _artifact_elf_armor_mail_ or _artifact_elf_axe_)
#

Also might be relevant, though it seems to work regardless, is the code for expedition.0042 in events\activities\expedition_activity\expedition_events.txt, specifically the part on lines 180-186:

    random_list = {
        create_elf_expedition_artifact_effect = {
            OWNER = scope:host
        }
    }
}```
According to the tool ck3tiger (as well as checking against base game code), _random_list_ expects a number rather than just the scripted effect itself (e.g. it should be _random_list = { 1 = {  create... } }_, though at that point the _random_list_ isn't needed). It still seems to work in this case though, so /shrug.


Also also, in _common\scripted_effects\expedition_reward_effects.txt_, lines 328-332, there's an extra "assign prowess and elf weapon modifier" block that doesn't seem to be needed, and you additionally have _elf_weapon_modifier = yes_ instead of **add**_elf_weapon_modifier = yes_.
daring lintel
dusk crane
#

oop, sorry if it's been reported already!

daring lintel
#

Im currently working on re-doing the expedition loot table as we speak!

daring lintel