#Buttery Fixes

1 messages Ā· Page 6 of 1

trim breach
#

well

#

i'd venture to guess this is more a problem with enhancedtweaks

#

especially if it doesn't consistently replicate

#

i wasn't able to replicate it

hazy goblet
ruby dagger
#

@trim breach Is this actually a bug, or

trim breach
#

yes

#

otherwise i wouldnt have fixed it

smoky current
#

i remember it did this just a couple months ago or so

ruby dagger
smoky current
#

common sense

ruby dagger
#

What

#

How is that common sense

#

I thought it was a design choice

trim breach
#

it's definitely not

#

if you see the way the code is written it becomes apparent it is an issue

#

playDelayedMusicCoroutine != null does not mean music is actively playing

#

because it gets set to null immediately after PlayRandomOutsideMusic gets called (which starts playing music)

#

the problem is that if the code terminates early before playDelayedMusicCoroutine gets set back to null, it never gets set null again under any circumstance

#

and that cancels music for the rest of the session

#

all time-of-day cues from the clock changing

#

all ambient tracks from morning/noon

#

the company music

trim breach
#

or if you are inside the building/ship when it rolls a random chance for music to play

#

pretty clearly not intended

smoky current
#

also common sense

trim breach
#

anyways

smoky current
#

sessions usually last anywhere from 30m to multiple hours

trim breach
#

my fix does the behavior that you would expect

smoky current
#

why would the music only play once

trim breach
#

if music is not playing when PlayTimeMusicDelayed gets called again

#

it will set the coroutine handle back to null and allow music to play again

#

so music can play again as long as a track is not actively playing

#

and I also carried forth zeekerss' design intent that the company won't play music if you visit it multiple times in quick succession

#

it only plays music once unless you leave, spend a day elsewhere, and come back (since there is unused code for the company not playing music unless it's been x number of hours since the previous visit)

smoky current
#

yknow buttery

#

in a way im almost kinda upset masked behavior got fixed LOL

#

i kinda was excited to tackle that

ruby dagger
#

Nothing to keep you calm and whatnot

smoky current
#

oh i guess

#

idk it just seems kinda lame to me

ruby dagger
#

So this should def be a toggleable fix Imo

smoky current
#

i dont like how stingers are implemented either

ruby dagger
#

Stingers suck šŸ’”

trim breach
#

i would concede it being a possible design decision

#

except that if the music breaks

ruby dagger
#

I meant like

#

the way they were coded

#

lol

trim breach
#

you don't hear time-of-day cues throughout the course of the day anymore

#

or for the rest of the session

ruby dagger
#

Yea

trim breach
#

there is no possible way that could be intended

ruby dagger
#

That's what I liked abt it

smoky current
#

to each their own ig lol

#

butteryyyy

#

i dont wanna take screenshots

#

im cry

trim breach
#

considering how sinister the later cues sound and the fact that you basically never get to hear them in game because of this bug

#

i would argue it's not silent because it's unsettling

#

lol

#

anyways im pretty adamant this is a bug and if anything it's so minor it doesn't need to be a config setting

#

you dont hear music if you are inside the building or the ship when it's supposed to play

#

and time of day cues don't play inside of things either

#

only when the clock is visible

smoky current
#

wonder if it owuld be hard to make a music slider plugin that just goes on the options menu

#

i kinda wanna try that

trim breach
#

and the only thing we know for certain is meant to play more than once is the company visit music

#

since he has code specifically hooked up to do that, that just no longer works because he removed the hours system

olive maple
#

Ooughhh new legal company update….

#

I have no idea what it is……

trim breach
#

i accidentally uploaded it under the wrong name

#

it's just client-side changes that my friends use

#

on our profile

#

i don't recommend using it and i will offer absolutely no support for it

#

but like

#

it's there now, i suppose

#

Lol

thorn breach
#

@trim breach i wonder if this is something you'd be interested in

#

me and zaggy were looking into navmesh areas and their costs

#

turns out the trap navmesharea cost is 3 times higher than other areas

#

and in spike trap, it has this navmeshmodifier+volume but this seems like a mistake

#

like, this wont really matter to the enemy when pathing through it

#

but something of this size might actually get the enemy pathing differently

trim breach
#

that is weird

#

im not sure how safe it is to change this in a clientside mod

#

my guess is it's "probably ok"

#

since only one client controls each navmeshagent

#

and as long as i dont change the surface it shouldnt change how random obstacles spawn with the given map seed

smoky current
trim breach
#

@smoky current yes, it is client side

#

it has a few server-side changes that only require the host to install it

#

and several more than indiviudal clients can use

#

but none of them require all clients to have the mod installed simultaneously

smoky current
#

that's kinda swag

eternal lantern
#

In the changelog it mentions unclamping forest keepers sight timers. Is that the bug where giants ā€œstealth meterā€ doesn’t decrease unless they’re looking at a different player?

#

FairGiants also fixes this and I was wondering if I should turn that off in FairGiants config.

trim breach
#

no

#

i fixed the overflow

#

where if a giant is watching other players, your sight timer can go down into the negatives

#

or, more problematically, it going far above 100% while a giant is chasing you

#

meaning it needs to watch other players for a really long time to forget about you

eternal lantern
#

Okay thank you

#

I don’t think FairGiants fixes that anyway so both mods work pretty well together

smoky current
#

this can be fixed by adding blockers to the railing im pretty sure

#

but idk if this would fit in BF

eternal lantern
#

ButteryFixes is client side right? You probably can’t change that on a client side mod.

hollow fable
#

ButteryFixes has some host only features

#

It could be possible?

paper garden
#

It's a mod that not everyone is required to have

hollow fable
#

-_- I know that

paper garden
#

I would assume something like this would make it not

#

but what do I know

hollow fable
#

Only modders will know if that's possible client-side

eternal lantern
#

Maybe for host only, but only people who have made that kind of mod would know.

hollow fable
#

Sry, I meant host only

gilded lintel
#

I got a "[Warning:Buttery Fixes] Error occurred while despawning spike trap (could not find network object, or it was not network spawned yet)" .. is this normal?

trim breach
#

yeah that is fine

#

weird that it popped up

trim breach
#

changing navmesh on individual clients

#

but i feel at least sorta confident it would work

#

as long as it happens inside the building only

hollow fable
#

Minor request: Change the typo from the default suit to match others. The tooltip just says "Change suit", while the others use "Change: (name) suit", it could be "Change: Orange suit" or "Change: Decoy suit" (kinda lame)

trim breach
#

lol i have no idea where "decoy suit" comes from

#

i saw it on the wiki back in like december 2023 and figured it must be based on something

#

but it's definitely not

#

it's just called the Orange suit

#

but anyways sure

#

i could do that

#

what do we think is better?

#

should it say "Change suit" until you have 2+ suits

#

at which point it'll be "Change: Orange suit" next to whatever else you have on the rack

#

or should it just be "Change: Orange suit" by default

hollow fable
#

the latter seems better and easier

lilac adder
#

For the first idea Maybe not show "change suit" till you have 2+ suits cuz that doesnt make sense

smoky current
#

seems pointless to me

#

maybe it shouldnt display anything tbf xp

#

but idk if theres bugs that give you a different suit when you dont have any unlocked

#

so

trim breach
#

the more i thought about it the more i think it's probably intended to just say "Change: Orange suit" all the time

#

and it's just a bug that they don't

#

on challenge moons you start with only the purple suit and it says "Change: Purple suit"

smoky current
#

i have this mod that changes it to say decoy suit but i have no idea why its called that

#

i just have it so its at least consistent

trim breach
#

idk the wiki says that it's called that but i have no idea where people got that idea

smoky current
#

classic lc wiki

trim breach
#

maybe it was called the decoy suit in some old version because it was unlocked from the start and never appeared in the store

#

but at least in the current version (and all versions to my memory) it's been the "Orange suit"

trim breach
#

the text gets changed in UnlockableSuit.Update() when suitID gets matched to syncedSuitID.Value (a networked variable)

#

this will happen pretty much immediately after purchasing the suits

#

i assume it's just in Update() in case of netlag

#

but anyways

#

the reason it doesn't work for the orange suit is because suitID defaults to 0 (as an integer)

#

and the orange suit is the unlockable located at index 0, since it was the first one zeekerss added to the game

#

so it spawns in already matching the eventual syncedSuitID value it would normally be assigned

#

and thus the code to update its text never happens

calm bobcat
#

speaking of suits, do you know what the bee suit's texture file name is? (I've been looking but I can only find the pajama suit)

trim breach
#

orange suit (brown suit in v65): ScavengerPlayerModel
green suit: ScavengerSuitGreen
hazard suit: ScavengerSuitYellow
pajama suit: SuitPajamas
purple suit: ScavengerSuitPurple
bee suit: ScavengerPlayerModelBee
bunny suit: ScavengerPlayerModelBunny

also ScavengerSuitBurnt for the old bird ragdoll

calm bobcat
#

ohhh

#

thats why

#

its Scavenger

smoky current
#

i wish there was a nyaa kitty cat suit

#

with whiskers

trim breach
#

i want a glow in the dark skeleton suit

#

it's part of more suits (cool) but i hate that mod and also it has mt dew tanks for some reason

#

because it's funny

#

or something

#

probably

#

anyways the bee and bunny suit have opened the doors for more creative suits and i hope to see some

#

collecting suits is my favorite part of the run because im the weirdo

#

and the only thing we have in the way of "more official suits" right now is the brown suit

meager estuary
#

ButterySuits mod coming soon??

trim breach
#

it's for all the suit enthusiasts out there

hazy goblet
#

Man i just want a mod that restores the birthday suit on the anniversary

#

Unless it’s been completely ripped from the game never to see the light of day again

trim breach
#

Lol

#

you can either enable the party hats all the time or they will automatically enable themselves on the day of the anniversary

hazy goblet
#

Oh

#

Huh

#

I thought that mod was like

#

Everyone has to have it

#

Right?

#

Cuz it’s a suit that does exist in the game already just it isn’t useable by normal means so

#

Right??

#

So i assssummeee it’s host only? robloxkid?

trim breach
#

no everyone needs the mod

#

otherwise it'll show up as an orange suit clone

#

and might cause bugs

#

probably will* cause bugs

trim breach
#

and then replaced it again with the orange suit in v66

#

and removed the party hat

hazy goblet
trim breach
#

the assets have to be modded back in

hazy goblet
#

oh well lmao

#

A request change i think would be neat is to have some more options for the game’s resolution

trim breach
#

well, i only put it in this mod because the two options i enable are in the original game, just unused

#

if you want other settings im pretty sure LCUltrawide Community is the mod everyone recommends for that

#

just set my mod's config to "DontChange"

hazy goblet
#

Yo sick

#

Ty

trim breach
#

unused in the main game

#

and they existed before the cutscenes did

#

on that note

ionic lion
#

yeah

smoky current
#

skibidi

ionic lion
smoky current
smoky current
#

+10000 aura

meager estuary
smoky current
#

max skibi aura 😭

ionic lion
meager estuary
smoky current
#

im gonna stop before buttery crucifies me

summer falcon
#

Hi Buttery,

not sure what but something is conflicting (afaik only on the host) with your FireExit rotation fix. I host the game, my friends all join, they say they face forward no problems as they use the fire exit, but for me, im always facing the fire exit, we use the same profile (shared via code) and i just re-imported using the code to a new profile and still get the bug.

I have made a test profile , and getting no issues, so its a mod conflict.. will try to narrow it down later but i dont have time right this second so figured id share the information incase its something obvious.

according to the log, the fix is "happening", but im not being turned (or being turned twice, i d k).

#

profile code where i have the issue .. 0194be98-205f-cd9f-c5a9-1abfabe29ff1

trim breach
#

having a log would be most helpful

summer falcon
#

Gale Debug info = mods + logs in one.

trim breach
#

oh i see

#

discord preview didnt show so i thought it was just a mod list

summer falcon
trim breach
#

hmm

#

not really what i expected

#

you are correct that your logs seem to suggest it would be fine

summer falcon
summer falcon
#

well RIP... apparantly its a conflict with my own mod (only the latest patch though x.x) i dont understand what though...

0194bf77-0839-0c7e-2071-e3558555a9c7

v0.4.4 of LI is breaking it, v0.4.3 of LI and its fine.

i just dont see any changes i made in v0.4.4 that would lead to me stopping a player being rotated :S and it only affects the host.. not the client.. i loaded client + host, client rotates fine, host doesnt.
https://github.com/VirusTLNR/LethalIntelligence/compare/1ecb0a9..b07c981

trim breach
# summer falcon well RIP... apparantly its a conflict with my own mod (only the latest patch tho...
        [HarmonyPatch(typeof(RoundManager), "SetExitIDs")]
        [HarmonyPostfix]
        static void PostSetExitIDs(RoundManager __instance)
        {
            if (Configuration.fixFireExits.Value)
            {
                foreach (EntranceTeleport entranceTeleport in Object.FindObjectsByType<EntranceTeleport>(FindObjectsSortMode.None))
                {
                    if (entranceTeleport.entranceId > 0 && !entranceTeleport.isEntranceToBuilding)
                    {
                        entranceTeleport.entrancePoint.localRotation = Quaternion.Euler(entranceTeleport.entrancePoint.localEulerAngles.x, entranceTeleport.entrancePoint.localEulerAngles.y + 180f, entranceTeleport.entrancePoint.localEulerAngles.z);
                        Plugin.Logger.LogInfo("Fixed rotation of internal fire exit");
                    }
                }
            }
        }
#

as long as you dont interfere with this function

#

it should work

#

obviously a long shot but is there any chance that you are possibly are preventing SetExitIDs from being run?

#

that's the function that assigns the entrance teleports their IDs, so you'd probably run into other more major issues if you were interrupting it

summer falcon
#

AH.

#

but this still makes no sense.

trim breach
#

like, if SetExitIDs doesn't run, i'm pretty sure it will just complain that the entrances were blocked

summer falcon
#

so, as something i did before 0.4.4, i am calling SetExitID's early...

#

but the issue only occurs in 0.4.4

#
private static void earlyCallSetExitIDs()
        {
            float startTime = Time.timeSinceLevelLoad;
            while (RoundManager.FindMainEntrancePosition(false, false) == Vector3.zero && Time.timeSinceLevelLoad - startTime < 15f)
            {
                new WaitForSeconds(1f);
            }
            Vector3 mep = RoundManager.FindMainEntrancePosition(false, false);
            RoundManager.Instance.SetExitIDs(mep);
        }

this is all im doing...

so i think i understand the issue.. x.x

my code is only running on the host. im calling it early because i need the ID's to be set before i run my code... so its running TWICE on the host. meaning i assume... its rotating (your code) twice.

trim breach
#

that would make sense

#

yes

summer falcon
#

let me relook at what i did in 0.4.4.. but it doesnt make sense why only 0.4.4 is breaking it x.x

#

yeah, from what i can tell, the code calling that hasnt changed since 0.3.8?

yet 0.3.8-0.4.3 work fine. x.x

ill maybe add a post fix to the setting of the ID's and see how many times it runs.. cause.. i dont get it.

#

yeah, it seems thats the issue, still dont get why it doesnt run twice on v0.4.3

#

ok, 0.4.3 DOES call it twice.. for some reason though it doesnt break it, when 0.4.4 does, ill look at making it run only once for 0.4.5.. or somehow get around calling it early.

trim breach
#

imo

#

you are probably asking for trouble with other mods if you are re-calling a vanilla function that normally only gets called a set number of times

#

there could be any number of other mods conflicting with that

#

the function in setexitIDs is quite simple and the safest bet for you is probably to just copy its logic completely into a custom function that you call early on the host as needed

summer falcon
#

yeah i think when i called it, i thought it wouldent re-call.

trim breach
#

but that is only my perspective

trim breach
#

yesfox v1.1, for example, has to generate and delete weeds multiple times when landing on a moon for the first time to calculate spots where weeds should be allowed to grow (since some AI nodes don't support spawning enough weeds for the fox to appear)

summer falcon
#

in fairness, i normally wouldent do it xD i wanted it to run only once, just didnt realise it would run a second time.

trim breach
summer falcon
#

im just going to try and postfix SetExitIDs itself.. and test.. and pray that it doesnt interfere with what im trying to do.

trim breach
#

except that i accidentally fucked up dopadream's snowy weeds mod which caused an awful memory leak

summer falcon
#

ouch xD

trim breach
#

because every time i generated weeds, it would assign all of those weeds a new material, then i'd delete all of the new weeds and generate new ones again

#

technically this memory leak was an issue before and would show up after enough playtime, but it got like 10x worse because yesfox 1.1 was causing this mod's patches to be called way more frequently than it would normally

#

normally just once per landing

summer falcon
#

well ive now basically replicated the function (like i normally do), just thought in this case i couldent, but it seems to be working and doing the same as the vanilla code..

i teleport on host and client through each fire exit on march, and they all lead to the same places, so i think thats conclusive proof its working.. so ill push that in my next update, and thankfully.. i seem to be the first person who noticed (well.. reported..) it.. xD thanks for the help.

trim breach
#

sure

#

glad it's working now

trim breach
#

so it makes sense that the scene load + dungeon generation should be instantiating all the entrance teleports in the same order

#

and it's probably pretty safe to assume those won't get re-ordered at any point

#

also, even if they were getting re-ordered, it would cause issues with vanilla's function since it has no safeties for ordering :p

#

i think you're probably pretty good

#

on that front

summer falcon
daring steeple
#

It should be ordered as you mentioned but in the event they aren’t

ruby dagger
#

Apparently meteors turning you into a masked corpse upon death is a bug, but I doubt that considering how specific it is

#

If ButteryFixes ever fixes it, please make it an option

kindred wraith
#

oh so decoy suit is actually fake ?

trim breach
#

someone told me that

#

before

#

but im pretty sure that is just completely wrong

#

meteors have no unique kill behavior

#

they are just a gigantic explosion

#

like from a landmine

thorn breach
#

most if not all explosions just call landmine static method right?

trim breach
#

yes

#

it would just spawn the default explosion ragdoll (which is just the default ragdoll iirc)

#

butteryfixes has a little bit of a hack to spawn burnt bodies from explosions

#

but i dont actually replace the ragdoll prefab

#

i just reskin the suit on the body that gets spawned

#

and spawn the smoke particles separately

hearty shale
trim breach
#

well

#

then let me try and put this to bed

eternal lantern
#

I can confirm it, I’ve seen it happen firsthand.

trim breach
#

i guess im wrong then

#

there must be a kill trigger on the prefab or something

#

anyways

trim breach
#

i will fix this in the next update

#

which should be pretty soon, most likely today

#

i've had it ready for a bit (it's small) but i was holding on to it in case anything else cropped up

#

and something has, obviously, cropped up

hearty shale
#

Ayy finally getting it fixed

#

The first time I encountered it, it caught me SO off guard

#

I was on Titan iirc testing something and got hit

#

And was on singleplayer I think

trim breach
#

yeah sorry for not exercising proper due diligence last time

hearty shale
#

And saw like half a second of me as a mask

#

And was SO confused

trim breach
#

it is just one of those bugs that is so crazy specific it is hard to believe

#

but you were totally right the whole time

#

lmfao

hearty shale
#

Yeah you’re good!

#

No worries

#

It’s such a minor (and comically specific/weird) issue

trim breach
#

pretty sure zeekerss just made a typo, he gave the meteor's crushing trigger death animation 5

#

in comparison, death animation 6 would spawn an empty burnt suit (like the old bird's blowtorch)

#

and probably is what he meant to enter

hearty shale
#

Ahhhh yep

#

I do wish he was more diligent with bug fixes

#

Especially since pretty much every bugfix/performance mod is open source and the devs would likely gladly assist him with stuff

#

I’m hoping the next big Lethal update has quite a few fixes

#

Especially since it’ll presumably be the end of early access and add a nice bit of content

trim breach
#

speaking of corpse fixes

#

i ran into this one by accident last time i played with my friends

#

so i'll be able to address this too

hearty shale
#

Okay but that’s so funny

trim breach
hearty shale
#

Spider respects the drip

trim breach
#

i kind of expect we have more content updates in the pipeline, i think he was just losing interest in working on the game without a clear vision of the ending

hearty shale
#

I feel like i recall Zeekerss hinting that it might be in a patreon update a while back, but it may have been that he was just stating it won’t leave until he gets the ending done, not that it’ll leave WHEN he gets the ending done

trim breach
#

there's a lot that i imagine will change with the big bad drill update, and i think most people are under the impression that's going to be the big update that leaves early access

#

iirc he was wanting a break because if he didn't take a break

#

he'd just rush to get the ending done and stop working on the game

hearty shale
#

Yeah

#

And he said he plans to support the game even after it leaves

trim breach
#

and that sort of phrasing implies, to me, he wants to do more general content updates before that point

#

but that's just my interpretation

trim breach
#

no respect

#

multi tasking

#

also embrion manor is funny

#

the spider launched me into the ceiling from ground floor when it webbed me

trim breach
ruby dagger
trim breach
#

no

ruby dagger
#

Time to not update ButteryFixes then, lord

trim breach
#

okay

#

you are free to do as you wish, but "meteors spawn tragedy masks on players that they kill" is completely impossible to justify as anything other than a bug and i don't see any reason why it needs to be configurable

smoky current
#

ye dont make it a toggle

#

pointless config bloat

#

narpy can just stay on the previous version forever

trim breach
#

i guess so

trim breach
#

having a giant config is a genuine concern of mine

thorn breach
#

the bigger the better they said...

trim breach
#

i've tried to limit it to the options that matter most for gameplay

#

and outside of being practically 110% a bug

#

there is no gameplay effect from meteor showers spawning burnt corpse instead of tragedy corpses

ruby dagger
#

Can’t it not be aesthetic? It’s interesting that meteors turned you into masked, but nobody else sees it that way, only as another bug

trim breach
#

chameleon has set a precedent of everything being configurable because it's a lot of big features bundled together

pine kestrel
#

Oh no!

trim breach
#

but butteryfixes is a ton of extremely minute changes across so many things that if everything were configurable, the config would be completely unwieldy

dense oriole
ruby dagger
#

True

trim breach
#

why would being crushed by a meteor spawn a tragedy mask on your face

#

from a technical standpoint, the only reason this occurs is because the kill trigger on the meteor

#

(damage type Crushing, dying to masks is either Suffocation if it was an item or Strangulation if it was an enemy)

#

has a death animation value of 5, and the Tragedy corpse's ID is 5

#

it's extremely likely zeekerss just made a typo when entering a value of 6, since that spawns the burnt corpse

small lichen
#

Buttery is just fixing things Zeekers made a mistake on lol. I'm sure sometime in the far future it will be fixed in vanilla and gone forever.

thorn breach
#

its funny that causes of death is an enum, death animation is an int, and their links are very confusing

trim breach
#

i fixed the cruiser killing old birds in some turbo old version of the mod

#

and it got pushback so i made it a config option

#

in the very next update to the basegame zeekerss fixed it himself so i removed the config

#

and iirc it still got pushback even though the setting was functionally useless anyway

#

obviously very little of the changes i have made are 100% objective, and it's impossible i havent made at least 1 change that zeekerss wouldn't make himself if he was aware of it

#

and it's pretty likely at least one of those changes isn't in the config

#

but i can almost guarantee there is no way he intentionally made meteors spawn tragedy corpses

#

and it's such a rare occurrence, with consequences that are purely visual, that I just don't think there is value in adding it to the config

#

and so that is where i sit

thorn breach
jolly raven
#

the only thing I've ever disliked that butteryfixes adds is the uh

#

item interact spam thingy

#

where you could spam hair dryers

smoky current
#

my ears are thankful

jolly raven
#

idk i just do not understand why that was seen as a bug (though it's probably like, something in the code was meant to stop the items from doing that but bleh)

smoky current
jolly raven
#

they also could only be spammed like, 5 times cuz they'd run out of battery but to each their own ig

jolly raven
#

if the problem's that bad I think you just need to talk to whoever you play abt it

smoky current
#

its not

#

because i have a mod that fixes it

#

xp

ruby dagger
jolly raven
#

booo

ruby dagger
#

I thought GeneralImprovements fixed that

#

Why is this literally not an option, it unnecessarily removes fun from the game šŸ’”

jolly raven
#

bro just won't let me stim in peace gadayum..

jolly raven
smoky current
#

i just have silly friends who like to spam buttons, who doesnt, mean of you to assume i need better ones

ruby dagger
#

Not like there are alternatives to ButteryFixes, which is why I’m so frustrated with these two changes

smoky current
#

not that deep bro

jolly raven
smoky current
#

u literally said get better friends how else am i supposed to take that loll

jolly raven
#

all im saying is if the problem is actually really that bad you could just, yknow talk to them, I don't see why that was seen as a bug (cuz it's a fixes mod, not like a qol mod or whatever)

smoky current
#

that seems pretty black and white to me

jolly raven
smoky current
#

on what planet

ruby dagger
#

Mars

jolly raven
#

🤷

#

if you wanna think it's that deep then go ahead

#

we're talking about spamming a button in what world would I take it that seriously

smoky current
#

im just saying ur wording could be better

#

that's all

jolly raven
#

you got the point which is what mattered, like I said I didn't intend for you to either take offense or take literally cuz the subject matter is like, super dumb and I wasn't even suuper complaining about it, it was all in good fun

#

sorry you took it that way! I'll be better šŸ‘

hearty shale
ruby dagger
trim breach
hearty shale
#

Oh thank god someone got it

trim breach
#

the hairdryer had the default which makes me think he probably forgot to set it manually

#

and also the sound effect of the hairdryer is turning on/turning off

#

so it stacking just inherently does not make sense

ruby dagger
trim breach
#

maybe so

hearty shale
#

Yeah while technically objective, it likely isn’t meant to be stacked bc that’s not how hairdryers work

trim breach
#

i am sympathetic to that but i am not empathetic to it

#

Lol

mighty ivy
#

This mod has a low, high and vanilla option for game resolution.

Is there any possibility to have a resolution that's between vanilla and low?

Im trying HDlethalcompany and the resolution remains unchanged ni matter the value i try.

Eitherway very good mod. Thanks for making it.

smoky current
#

use LCUltraWideCommunity

#

or whatever

#

HD lc is bad dont use it

mighty ivy
#

But i dont have an ultra wide monitor

hearty shale
#

HDLethalCompany
Found the issue

smoky current
#

doesnt matter

#

neither do i

mighty ivy
smoky current
#

but it works for setting resolutions

#

it has a config

hearty shale
#

Yeah the name is misleading

smoky current
#

i mean not really

#

it adds native ultrawide support

#

out of the box

mighty ivy
#

I tried to use hdlethal to lower game resolution

smoky current
#

but it has additional functionality that being setting manual resolutions

trim breach
#

the resolution setting in this mod is just a tiny bonus

#

since i discovered they existed in the game, just unused

#

if you want better support, lcultrawide community is probably your best choice

hearty shale
#

Automatically scales the game to the native equivalent of any resolution/aspect ratio

trim breach
#

and i made sure the DontChange setting wouldnt interfere with those

hearty shale
#

With further changes done through config

mighty ivy
smoky current
#

dontchange is default right?

mighty ivy
#

Yea

trim breach
#

yes

smoky current
#

cool

trim breach
#

low quality has a noticeable impact on visuals

#

high quality has a noticeable impact on performance

#

best to just let players decide

mighty ivy
#

Low quality makes for great desktop background if you use no visor and no hud

smoky current
#

if my pc was working id have made an invisible hands mod by now

mighty ivy
#

You're saying that low option is hidden in the game itself and unused?

smoky current
#

yes

mighty ivy
smoky current
#

and high is used in another

mighty ivy
#

I see

trim breach
#

low is used in the v50 intro and high in the v60 intro

#

but im almost certain both existed beforehand

smoky current
#

they did yes?

trim breach
#

high definitely existed before v60 at least

smoky current
#

didnt bf have the option before that

trim breach
#

BF didnt exist before v50 iirc

smoky current
#

wtf

#

im tweaking

trim breach
#

but it did before v60 yeah

smoky current
#

i thought it existed in v49

trim breach
#

i dont think so

#

but idk

#

its been a while in any case

trim breach
#

which released right before april fools, iirc

trim breach
paper garden
#

v50 full release was april 13th

#

bf was between v50 v55

trim breach
#

@radiant nymph i am looking at caching vehiclecontroller in the next update

#

given that diffoz is on indefinite hiatus

#

i feel like it really belongs elsewhere since butteryfixes is not primarily a performance mod

#

but i dont feel like making a PR and i definitely dont feel like making a separate mod

#

so hopefully someone will pick this issue up and put it somewhere it belongs better in the future

trim breach
#
[Debug  :Buttery Fixes] Transpiler (BushWolfEnemy.Update): Cache Cruiser script
[Debug  :Buttery Fixes] Transpiler (ClipboardItem.Update): Cache Cruiser script
[Debug  :Buttery Fixes] Transpiler (ForestGiantAI.OnCollideWithPlayer): Cache Cruiser script
[Debug  :Buttery Fixes] Transpiler (Landmine.SpawnExplosion): Cache Cruiser script
[Debug  :Buttery Fixes] Transpiler (MouthDogAI.OnCollideWithPlayer): Cache Cruiser script
[Debug  :Buttery Fixes] Transpiler (SprayPaintItem.TrySprayingWeedKillerBottle): Cache Cruiser script
[Debug  :Buttery Fixes] Transpiler (StartOfRound.SyncShipUnlockablesClientRpc): Cache Cruiser script
[Debug  :Buttery Fixes] Transpiler (Terminal.LoadNewNodeIfAffordable): Cache Cruiser script
#

probably the kidnapper fox is the only one that has a major effect

#

since that is causing massive framelag when the fox is grappling players

#

but SpawnExplosion is called by every single source of explosions

#

meteors, old bird rockets, even easter eggs

#

so it will probably help with lag spikes during those as well

hollow fable
#

it's really stupid but some suits uses Change suit: (Name) suit and others uses Change suit: (Name) Suit (Purple, Bee and Bunny)

#

I shall curse everyone who read this Trollface

meager estuary
trim breach
#

hi

#

i moved some stuff out of buttery fixes into that plugin

#

and included more fixes

#
  • more stuff to come in the future
#

thanks everyone

meager estuary
#

Sounds good

gilded lintel
#

Hi Buttery, does the fixing of the flashlight errors in ButteryFixes clash with ReservedFlashlightSlot mod? The reserved mod turns off all other flashlights and laser pointers in your slots when you turn a new one On, seems to be working as expected with reserved (does indeed turn others off) but was wondering if you're aware of the reserved slot doing that

trim breach
#

im not aware of any issues and i have a limited amount of experience using both together

eternal lantern
gilded lintel
#

I've removed ReservedSlot mods as I just prefer more "vanilla" slots with HotbarPlus, however I have noticed something interesting with your flashlight fixes in ButteryFixes compared to vanilla (and without ReservedSlots)

to re-create this test:
be in a game with at least 1 other player
buy 2 flashlights for 1 person (for me I tested the Host having these 2 flashlights)
turn on 1st flashlight then scroll to your 2nd flashlight so it is in your hand (Don't turn on 2nd flashlight)
have the Client observe the existence of the light beam from your 1st flashlight

in Vanilla:
Both the Host and the Client looking at the Host will not see the light beam
with ButteryFixes:
Host will still see the light beam, Client will not see the light beam

This can create some confusion since some players will think other players are walking around without a flashlight on, but they are.
This situation is not common though, since it requires someone having at least 2 flashlights and repeating the above steps, and you would normally give someone one of the flashlights if they do not have one, unless you're a big meanie Trollface

I'm not sure if this is specific to a Client looking at Host, or if vice versa results are the same, I can test that though if you need

Another side effect of this is if the player with 2 flashlights turns on both flashlights they will have both the beam from the flashlight in the hand and the beam from the "pocketed" flashlight simultaneously but the Client will only see 1 beam, this effect might keep stacking with even more flashlights but its hard to tell since the pocketed beams end up in the same position as each other (this is with ButteryFixes but it may explain some decisions made by Zeekerss here in vanilla)

hollow fable
#

I would also like to add something strange that happened with me atleast 3 times but i never reported because i didn't know butteryfixes fixed flashlights, but the pro-flashlight was on and with the light beam but without battery

#

if you had it in hand it would light the way but if it was in the inventory it wouldn't

#

I know that this happened once when my friend died with the flashlight and dropped at the floor

#

The other occasion was dropping all scrap at the main entrance, which i dropped the flashlight because it was close to dying and then when I went back to the ship the flashlight was still on

gilded lintel
hollow fable
#

Nope, I'm mostly vanilla with a lot of QoL mods, bug fixes and minor changes

gilded lintel
hollow fable
#

But I did have HotbarPlus at the time?

#

I didn't use any extra slots

#

And took it off because it had some weird shenanigans when moving between items in the inventory (weird hand movement)

hollow fable
trim breach
#

if you have multiple flashlights in your inventory

#

say, a pro flashlight and a laser pointer

#

only one can display on your helmet at a time

#

and the other will "turn off" but will stlil use up battery

#

but my patch unintentionally caused problems where clients wouldn't be able to see pocketed flashlights at all

#

(or something similar to that - the point is it didn't work right for clients)

#

because some values that i reference would only be assigned properly on the host

#

so basically, my patch only affects the local player

#

you will see other players being subject to vanilla behavior

#

because i don't think there is an extremely realistic & performant way to account for every player's inventory to properly track flashlight beams

#

but it should work properly for your own flashlights in all cases

jade coral
#

Hi. I noticed the mod fixes some buggy behaviors from nutcrackers that would allow killing them easily. It's nice, but considering those bugs have been in the game for a while now and that they affect gameplay quite a lot, I wonder if it would be possible to get an option to disable the fixes?

trim breach
#

normally i am willing to add options for these sorts of things but in the case of the nutcracker i don't think i will

#

the dog jump cheese has an option, but you are also limited by your stamina in the original game when utilizing that technique, so it is not as major of an issue

#

bee hives see a major dip in price when next to the ship and some people just aren't going to jive with those changes

#

etc.

#

but with the nutcracker it is just super lame and not fun that you can jump through a nutcracker while it's reloading and kill it without any danger to yourself

#

there is no skill requirement or limiting mechanic there, like stamina with dogs

paper garden
#

Wasn't that fixed in vanilla?

trim breach
#

no

#

but i fixed it months ago

#

probably in july or august, but it's in the changelog somewhere

#

i don't remember exactly

#

anyways

#

the other major thing i fixed about nutcrackers is the soccer ball blocking their vision completely

#

and im also not interested in adding a config option for that because it was a bug that used to apply to all enemies

#

and zeekerss fixed it for all enemies except nutcrackers (since they use separate line-of-sight functions)

paper garden
#

Was it this

trim breach
#

so i guarantee it would be fixed if he was made aware nutcrackers still exhibited the issue

trim breach
trim breach
#

but that's a bit more of a gamble

ruby dagger
#

How would he not know about it?

trim breach
#

how did he not know you could kill old birds with the cruiser in v55

#

he didnt patch it in v56

#

or any of the v56 hotfixes

#

but he became aware of it at some point and fixed it because it's not a thing in v60 anymore

ruby dagger
#

I meant up until this point

trim breach
#

just because it's an exploit he hasn't fixed in an update doesn't mean he knows about it and abides by it being in the game

#

he fixed several other nutcracker cheeses

#

like making them point their gun downwards if you crouch underneath their feet

#

since that used to let you dodge their gunshots

trim breach
#

etc.

#

there is always the chance he does know and has decided not to fix it, but at least IMO i think it's more likely he just doesn't know about it

#

anyways

#

i got a little bit sidetracked

jade coral
trim breach
#

tl;dr: i dont think i will make any of the nutcracker cheese fixes configurable, sorry

#

i make a lot of fixes in this mod that are to the player's benefit and i think it is fair that i make a few non-configurable fixes that are not to the player's benefit as well

#

and while i have sometimes exposed changes as a config option to allow for customization, i have become less prone to doing that recently as the mod's scope has grown

jade coral
#

I do have to ask, does that fix also affect clients?

trim breach
#

TBH if i implemented the dog jump cheese fix today i probably wouldnt have made it a setting now (especially since zeekerss patched the other silent movement bug with dogs)

#

but i'm not going to go back and remove the setting that already exists, in any case

trim breach
#

so both the soccer ball and reload cheese fixes apply to all players if the host has the mod

#

and apply to no players if the host doesn't

jade coral
#

Hmm, that's concerning, 'cause I don't mind having that stuff on my end, but affecting clients can make for a bad experience if they don't know about the fixes

#

Well, thanks for the answer

trim breach
#

if that is a concern of yours, you probably shouldn't be using my mod then, yeah

#

and i dont mean that to be disrespectful

#

if it comes off like that

#

but i think my vision of a fix mod and what you want out a fix mod are just not compatible with each other, and that's fine

#

although this mod is vanilla compatible i mostly designed it for use when playing with my friends, where they are all aware of the mod and what it fixes

ruby dagger
#

I don’t really get not making config options unless it’s just annoying to code so much of them, because it doesn’t really hurt anything

trim breach
#

and all of us have it installed

trim breach
#

does that make it right? idk, different people will feel different ways about that

#

i also don't like having gigantic configs for this mod, and if i made every change configurable, the config would be entirely unusable by any sane user

#

if you disagree with my philosophy for this mod i think it is just genuinely better to not use it

#

and it's fine if you don't agree with it, because i designed the mod for my own personal use and just publicized it in the case other people are interested in using it

#

that's kind of my stance on everything

trim breach
ruby dagger
#

Can’t argue with that

trim breach
#

and with butterybalance i am also going through the process of making everything configurable because all of those changes are subjective and far more likely to conflict with others' modpacks

#

(but they may still want it for individual features)

trim breach
#

but i can not possibly make everything in butteryfixes configurable

hollow fable
#

you must sacrifice the cheeses in order to get the fixes

trim breach
#

there doesn't need to be a checkbox for "cap dog suspicion level at 11: yes/no"

#

or a checkbox for "make old birds stop sliding without animations on the game over screen if all players die"

#

or a checkbox for "make TZP audio distortion not persist if you quit and rehost the game"

#

etc.

jolly raven
ruby dagger
trim breach
#

yes

#

but alas

#

butterybalance is going to have like 100 settings in it

#

and it will require a sitdown with a book and a coffee to go through and configure everything on first install

#

but at least no one can say i didnt try

jolly raven
#

very much appreciated

ruby dagger
#

Wait, who’s reading a book while configging a mod anyway

jolly raven
#

it's for the aura, dumbass

ruby dagger
#

Holy shit hi vagita

gilded lintel
# paper garden Was it this

Is this so you can't jump through the Nutcracker while it is reloading and get free hits from behind? If so, good šŸ™‚

trim breach
#

yes

#

if you hit a nutcracker and it's not actively targeting a player, it will switch target to you

#

in most cases that patch won't do anything, because vanilla already does that in most cases

#

but it won't do that behavior if the nutcracker is in the middle of its attack state, because i guess zeekerss intended for it to always know who it's targeting in the attack state

#

so if you jump through the nutcracker while it's reloading (and not doing line of sight checks)

#

it forgets about you but remains in its attack state

#

and so hitting it won't reaggro it or turn it around in vanilla

#

but in my patch it does

#

i dont remember why they freeze in place if you jump through them

#

normally, if they lose their target in attack state, they start spinning wildly and stomping in random directions

trim breach
dense oriole
#

Wheres my 10000 configs?

#

i need all the configs

ruby dagger
#

1 year sober from configs

dense oriole
#

def not sober from complaining

ruby dagger
#

Hi Narpy

ruby dagger
dense oriole
#

each config you ask for 10 are removed

ruby dagger
#

Schrƶdinger’s config

ruby dagger
#

Why are you sniffing me

dense oriole
#

cuz you stinky

#

and must bathe

paper garden
#

yes hyello can i have the uhhhhhhhhhhh

#

config deluxe

dense oriole
#

make that a config

paper garden
#

with a side of config

#

and a config for the drink

dense oriole
#

Bathe narpy config

pine kestrel
#

Buttery greed

ruby dagger
trim breach
#

@radiant nymph just to let you know pre-emptively

#

i made a conservative fix for that weird baboon thing you were experiencing

#

im not gonna push an update just for that but it will be in the next update i release

radiant nymph
#

Yay šŸ˜„

meager estuary
#

Somehow I have not mentioned this yet, a way to check a Shotguns’s ammo would be very nice. The tech with the sound effects is unintuitive imo and it bothers when playing tough mods where weapons are paramount

#

I know there are some mods that do this already, but they are quite old, plus I think it would be a nice addition to this mod

meager estuary
#

The mod already has a few settings that are not necessarily bug fixes

hollow fable
#

Better Shotgun Tooltip has some great features for the shotgun
-> Ammo Indicator
-> Improved safety text
-> Colorized tweaks

meager estuary
#

Are those maintained though? LCAmmoCheck in particular seems like it could break any day

hollow fable
#

BetterShotgunTooltip updated 3 weeks ago

meager estuary
#

Well I guess I am just stingy then

hollow fable
#

the source doesn't seem to use GameObject.Find

#

so it won't tank your performance

#

although i wished there was a alternative for ShowCapacity 😭

meager estuary
#

This is why I went to Buttery, I can put faith in her to not make mistakes like this

hollow fable
#

I've been hesitant to ask if it's too much to ask to integrate this into ButteryFixes, it bothers sometimes having a lot of minor mods that does simple features
https://thunderstore.io/c/lethal-company/p/the_croods/NoTerminalSway/
https://thunderstore.io/c/lethal-company/p/LeKAKiD/SignalTranslatorAligner/
https://thunderstore.io/c/lethal-company/p/ViViKo/SpectateDeathCause/

#

It's okay if you don't want to

eternal lantern
#

If that’s any help

hollow fable
#

I like some of the features from GeneralImprovements, but idk why buy my games performs a lot worse and requires more RAM

#

i'm not interessed in all of the features he has to offer, because i know other mods do somethings better

#

The only things GI has advantage over all others are the monitors honestly

trim breach
#

maybe i will freeze the camera on terminal

#

the other two are less fix-y and more just qol

hollow fable
#

i would consider the last one a QoL

#

the second one is a in-between

gilded lintel
trim breach
#

that sort of thing bugs me too so i might look into it

hollow fable
trim breach
#

not 100% sure of all the terminal's inner workings and im a bit worried about breaking things

hollow fable
#

typing when opening the terminal

trim breach
#

well

#

i'd like to avoid just copying other mods' patches into this if possible

#

im also not sure if this is licensed to allow that

#

also there is some tendency of old mods to implement features incorrectly and not be completely functional

#

maybe this one is not an example of that, but it's another reason i'd rather just investigate and solve the issue myself

hollow fable
#

oh ok

trim breach
#

might have to do with this

if (this.selectTextFieldCoroutine != null)
{
    base.StopCoroutine(this.selectTextFieldCoroutine);
}
this.selectTextFieldCoroutine = base.StartCoroutine(this.selectTextFieldDelayed());
private IEnumerator selectTextFieldDelayed()
{
    this.screenText.ActivateInputField();
    yield return new WaitForSeconds(1f);
    this.screenText.Select();
    yield break;
}
#

it's probably that 1s delay that eats your inputs

hollow fable
trim breach
#

this is bad

#

objects with netcode shouldn't be interacted with before all clients have joined the game

#

that's why zeekerss disabled it in vanilla

#

you can get desync from using stuff like this, in the same way latejoin causes desync

hollow fable
#

didn't about that

#

but i have been using since the first weeks of LC modded and never had problem?

#

ok maybe the boombox

trim breach
#

this is not an extremely harmful example

#

but noisemaker props (clown horn, airhorn, hairdryer, and cash register) are seeded by RNG

#

to produce sounds of different "volume" (not audio volume, but noise volume for AIs, how intensely enemies will hear it) and radius

#

it's seeded by using the map seed

#

so if a user picks up a clown horn, honks it a couple times, and then a new player joins the game

#

it will have different seeds on each client and it will create different degrees of noise for each of them

#

that doesn't matter in a ton of cases, since hearing is mostly host-sided, but it just makes for an easy-to-explain example for why items with networked interaction shouldn't be messed with before all players are in the game

daring steeple
trim breach
#

@daring steeple if a coroutine ends itself, it will not set its own reference to null

hollow fable
trim breach
#

that caused the bug with music

daring steeple
#

yee so you gotta set it to null after that in that snipp right

#

otherwise the logic will goof

trim breach
#

that simon tendo (another user in this server) discovered the cause of

trim breach
#

if the coroutine exists, it'll try to stop it, even if it has already been stopped

#

but that doesn't throw an error

#

and afterwards, it'll start a new coroutine and that will become the new reference

#

so all will be fine

#
public void PlayTimeMusicDelayed(AudioClip clip, float delay, bool playRandomDaytimeMusic = false)
{
    if (this.playDelayedMusicCoroutine != null)
    {
        Debug.Log("Already playing music; cancelled starting new music");
        return;
    }
    this.playDelayedMusicCoroutine = base.StartCoroutine(this.playSoundDelayed(clip, delay, playRandomDaytimeMusic));
}
#

it is a problem here

#

because the only part of the code that ever sets playDelayedMusicCoroutine to null is the coroutine itself, if it reaches the end

#

but there are several spots where it can terminate early and it doesn't clean up its handle

#

which causes it to be non-null for the rest of the session and completely mutes music

#

it's only a problem because that return statement exists, though

#

also the logic of this statement is incorrect to begin with, because playDelayedMusicCoroutine isn't non-null when music is actively playing, it's non-null when the game has music "queued" and is waiting to play it after a couple of seconds

#

once the actual music track begins the coroutine gets set to null and the coroutine ends

#

if it doesn't terminate early

#

but that's sort of unrelated to your question

trim breach
#

i know for a fact if the coroutine expires within its own code (due to a yield break or running out of instructions to execute), it will not set its handle to null

#

im pretty sure the Coroutine variable and the actual coroutine have no communication together at all

#

the variable is basically just a pointer to a coroutine that may or may not still exist and may or may not still be executing

#

you can't actually fetch any information from it

#

you should explicitly set it to null whenever you want to free it, or whenever your coroutine ends itself, if you are intending to persistently track whether it's running

trim breach
#

because either the coroutine ended itself, and you replace it with another one (and update your reference)

#

or it hasn't ended itself, but you force it to stop, and then replace it etc.

trim breach
#

if you pick up a flashlight and turn it on, and a new player joins, the flashlight's state will be desynced between the two of you

#

boomboxes are seeded in the same way noisemaker props are seeded and it causes track selection to be wrong

#

i would say it's probably fine to allow networked objects to be picked up, just not used before the host starts the game

#

but that wouldn't be true for easter eggs, since you could drop them and cause them to explode

daring steeple
#

in theory a networked seed system doesn't seem to hard to make but maybe injecting it into the base game is annoying

trim breach
#

and there might be other examples of problematic networked items

trim breach
#

but you are right about the second thing

hollow fable
#

i understand it now

#

kinda sad

trim breach
#

i know i certainly have no interest in injecting the whole thing in a mod

#

this mod covers a couple things that are problematic

#

like the boombox track desync i mentioned

#

but it doesn't sync all items' entire states and unless it is 100% paritous, i'd rather deal with the inconvenience than have desync potentially ruin a session

#

most forms of desync are persistent until the lobby is rehosted and that sucks because it kills the momentum of a session

gilded lintel
gilded lintel
#

Something I found that might suit ButteryFixes though is the spawn "vents" in the Mineshaft Caves, it seems only the Host can see them

radiant nymph
#

So @trim breach Dunno if this might be a useful Break Through for finally creating a bug fix for Furniture Items borking saves but I made a Discovery last night

trim breach
#

oh

#

yeah

#

it's all based on numerical indexing

#

you are correct

#

someone could probably make a SmartItemSaving adjacent mod for unlockables (furniture, upgrades, suits)

#

and save/load by names instead of numerical indices

radiant nymph
trim breach
#

and that would be the easiest way to make something work with "almost all pre-existing mods"

#

which just add themselves to the unlockables list without doing much else

#

that someone wont be me

#

at least not any time soon

#

though

radiant nymph
#

Yeah the people I know I could see looking into doing this though would be you, @mighty night, or @exotic elm

#

Maybe @eternal thorn if he feels like adding it to LethalFixes

trim breach
#

my guess is probably not lethal fixes

#

it would deviate not-insignificantly from vanilla behavior

radiant nymph
#

Yeah fair

trim breach
#

but i think it'd be easier to implement and account for than items

#

since unlockables are all in a list

#

and you can only buy one of each

#

and perhaps in the future i might release something for it

#

but my backlog is huge and this is not high priority for me

hearty shale
#

Wow, I can’t believe it’s releasing tomorrow at 3:30 PM

fleet lintel
#

we all know buttery is a fake modder because she actually works on stuff and releases it

radiant nymph
#

@quiet tinsel Maybe you'd be interested in potentially fixing this btw, since Buttery mentioned it could be done in a way similar to SmartItemSaving

hollow fable
#

NoTerminalSway update agony

radiant nymph
#

@woven token

#

Maybe you too

woven token
#

Hmmmm

#

I'll have a look

radiant nymph
# woven token I'll have a look

Yeah cus if this can be done it will finally fix the issue of having to make new saves whenever you add or remove furniture

#

It makes a lot of sense Zeekerss would have done numerical indexing though cus his save file stuff has all been rather simple

trim breach
#

sorry

woven token
trim breach
#

kinda wanna lock the camera when charging items or pulling the lever too

#

the twitchiness of those bothers me

radiant nymph
trim breach
#

@hollow fable the update with terminal locking is out

#

it's a bonus setting that's turned off by default

#

just in case of conflicts or weird bugs causing it to get stuck

#

but i wrote it to be generally safe

#

and in all of my testing it worked fine

hollow fable
#

yoiled thx

#

You also patched the forest keeper sfx on foggy moons? Fish

gilded lintel
trim breach
#

i knew i forgot to put something on the changelog

hollow fable
#

Could the money square get larger to fit all the credits inside it? (ignore the fact that i have that much money)

trim breach
#

i might do something about this

#

zaggy was very nice and contributed a patch for the hygrodere that makes its "spreading" behavior way less buggy

radiant nymph
#

lol

trim breach
#

does GI do this?

#

i don't remember that but i guess maybe i just never noticed

#

or it was added after i migrated away

#

i am having to update for generalimprovements compat in the next update because I saw shaosil mention he added ladder sprinting

paper garden
#

BetterStamina greed

trim breach
#

does betterstamina include ladder sprinting too?

#

i see

#

i wasn't aware

#

i will add it to the list as well

#

for next patch

paper garden
#

It should yeah

#

Though I think it’s not a default thing if I remember right

#

Unsure

trim breach
#

maybe not but it wont work at all right now

paper garden
#

Yeah

trim breach
#

i'd rather revert to vanilla behavior (even if it lets you waste stamina on ladders) as long as you are using a mod with the potential to add ladder sprinting

paper garden
#

Don’t have my PC to check the exact configs it has relating to it

#

but I can imagine it allows to basically fix it manually

hollow fable
#

Just something very minor that bugs me and my friends sometimes

#

"money exceeds 999"

trim breach
#

speaking of terminal improvements

#

vanilla apparently has some text that says [No items available] when the decor rotation is empty

#

but it's completely impossible for that to occur because the shop is always stocked with either 4 or 5 decorations

#

as some QoL im gonna add a bonus setting to filter out decorations you've already bought

#

i know terminalformatter already does that and maybe another mod (darmuh's terminal stuff perhaps?)

#

but i'd like to restore this feature for the vanilla shop

calm bobcat
#

that would be cool

trim breach
hollow fable
#

That's cool

trim breach
#

i was kind of waiting for general improvements to update

#

before i released this

#

since i needed to cancel my ladder stamina patch when GI is installed to prevent their ladder sprint patch from working

#

but since that got delayed a couple more days i might just release mine early

#

and you will just have to deal with not sprinting on ladders for a day or two

#

for people using both BF and GI

trim breach
#

so it looks ok when you have up to $10,000,000 credits (the max in vanilla)

hollow fable
#

You're the best

trim breach
#

i will post in just a couple minutes, trying to figure out why it's not updating the first time you boot the terminal

#

it'd still look wrong if you load a save with 1000+ credits up until you first spend money

#

once i get that fixed it ought to be ready

hollow fable
#

Take your time alright

meager estuary
#

Very epic

#

While we are focused on the small things, I have noticed that things like Plastic Fish, Extension Ladder, and Whoopie Cushion have no pickup/equip noise, could this be fixed?

trim breach
#

i think some items are lacking pickup sounds by design

#

but it is on my checklist to go through and add some where they make sense

#

i've done it a couple times before

#

for example the garbage lid and metal sheet have no pickup noises

#

but tea kettle, large axle, and v-type engine all do

#

previously i added a pickup sound to the metal sheet but i never went back and add it to the garbage lid after v60

#

oh wait nvm apparently i did

thorn breach
#

my favourite drop sound is zetdog (i think its called)

trim breach
#

hum

#

there is this sound but i feel like it's a bit noisy for plastic fish and plastic cups

trim breach
#

plastic fish, plastic cups, whoopie cushions, and candy are 4 items i'm not sure what to do for the pickup sound

meager estuary
#

I can see Whoopie having no noise but the others should imo

meager estuary
trim breach
#

i guess it sounds ok, to me it just seems kinda chunky

#

hard to describe

meager estuary
#

I think it is fine, it is part of the LC jank

#

Extension Ladder should have metal pickup noise

trim breach
#

i realize i never gave the glass SFX to perfume and pickle jars

meager estuary
#

True

trim breach
#

those are probably plastic, yeah? i gave them plastic sounds but i guess glass could also work

meager estuary
#

Pill Bottles like that are plastic, I have small orange bottles like that

trim breach
#

yeah

#

i actually have a couple of both shades at my place

#

the vanilla LC shade and the deeper scarlet one from upturned variety

#

all of mine are plastic but i wasn't sure how universally standard that was

#

plastic probably fine then

meager estuary
#

Btw what is the Magic 7 Ball drop noise?

#

Just a faint clunk, seems to be exclusive to it

trim breach
#

i think it was given a new unique one in either v56 or v60

#

i dont remember anymore

#

"DropBall"

meager estuary
#

Weird, that one always seemed off to me, it is such a quiet and short sound, especially given how it is heavy

trim breach
#

i think it fits

#

i do think it's weird that it was given a unique sound so late after launch though

#

i dont even remember what it used to use before

meager estuary
#

You could use that noise for candy

#

If you want to emphasize how small it is

trim breach
#

apparently:

  • boombox
  • maneater
  • teeth
  • extension ladder
  • golden cup
  • fancy lamp
  • plastic fish
  • garbage lid
  • apparatus
  • tattered metal sheet
  • plastic cup
  • radar booster
  • soccer ball
  • whoopie cushion

all lack grab SFX

#

some of these make sense

#

there are also a couple items with wrong pickup sounds

#

like tethpaste, pill bottles, candy, hairbrush, etc. sounding like metal

meager estuary
#

Darn, much more than I thought

#

A lot of these are easy to pick noises for though

trim breach
#

well, the teeth have the chattering

#

and i already fixed a few, like the golden cup, garbage lid, metal sheet, etc.

#

some others i am less sure what to do with

meager estuary
trim breach
#

i feel like that sorta makes sense

#

toy robot is metallic and it's a good cue to indicate that

#

teeth aren't

#

teeth also have a higher chance to chatter than toy robots have to

#

dance/sing/whatever

#

but maybe i could give them a plastic sound

meager estuary
trim breach
#

i'm not sure about apparatus because there is a very specific sound to it when it gets unplugged

trim breach
# trim breach

also it might just be me but i still feel like this doesn't fit the tiny plastics

#

if nothing else i do think it fits the soccer ball

meager estuary
trim breach
#

unfortunately not easily

#

grab sound is defined globally for every instance of an item

meager estuary
#

Darn

meager estuary
#

It is kinda just a catch-all for non-metallic

#

Even though Bottles are conductive

trim breach
#

also bottles aren't conductive

#

maybe in an earlier version they were, idk

#

whoopees were conductive until v50

#

flasks were conductive until like v62

meager estuary
#

Makes sense, glass is not conductive irl

trim breach
#

yeah

meager estuary
#

Should we change Zed Dog drop noise? It makes no sense but at this point it is a meme

trim breach
#

i actually did that a while ago

meager estuary
#

Oh

trim breach
#

but then i found out zeekerss and zedfox had a discussion about it

#

and it's actually canon that there's something metallic inside of it

#

which is why it has a weird drop sound and is conductive

#

lol

#

so i reverted it

meager estuary
#

Add that to the tally of things we will never understand

#

Would love to see Zedfox’s idea

calm bobcat
#

I think the joke is that the zedfox is filled with lead

meager estuary
#

I am inclined to believe that

#

Oh yeah I wanted to ask because I want to confirm what I think I heard somewhere, is not being able to pick up stuff before the lobby is started intentional? I had heard that using mods to bypass this opens the door for desyncs, is this true?

trim breach
#

yes that is intentional

#

yes it can cause desync

meager estuary
#

Cool cool

hollow fable
#

btw

trim breach
#

it is somewhat irritating but i think a minor annoyance is greatly preferable to mid-match desyncs

meager estuary
#

Definitely

trim breach
#

so it is at least the lesser of two evils

hollow fable
#

Using AdditionalNetworkingExperimental new feature that syncs noise from objects fix these desyncs caused by AlwaysPickup?

trim breach
#

it will definitely help

#

but i assume it doesn't account for equipment which is the more notable problem

#

jetpacks, flashlights, etc.

trim breach
#

the fancy lamp is kind of eghhh

meager estuary
#

Is this the cause of most desyncs or is network lag more responsible you think?

trim breach
#

i think the plastic sound gives bad player feedback because it's actually metallic and conductive

#

but the metal sound is really rough and feels weird for a lamp

#

feels like a chunk of metal

meager estuary
#

I always see lamps as heavy metal things

trim breach
#

but one time my friends and i got this really weird bug where a jetpack's active state got bugged out and im willing to bet it's because of pickup-before-start

#

it was pretty disastrous because a couple of us saw/heard a jetpack constantly running

#

and at one point one of my friends got launched into the water on gordion because they were wearing a jetpack that randomly propelled them off the map

#

despite being turned off