BepInEx Faster Load AssetBundles Patcher

[tulip fjord]

How bad is it?

Configs I mean

Can I start using that as an excuse to not make configs 😂

[grand coral]

I mean Terbium fixes the issue with configs using a lot of ram

lol

It's it's whole purpose

[plucky stump]

Published v0.6.3

[0.6.3] 2024-06-18

Added

• Deleting of unknown cached assetbundles on start up (unknown means that bundle doesn't have a metadata info).

And updated readme to include incompatibilities with mods: IntroTweaks and XUnity_Autotranslator

[steel quiver]

waiting for the @grand coral RAM report 🫡

[grand coral]

This won't affect ram usage, it just fixes the issue where it didn't auto delete cached assetbundles that aren't being used

Also I fixed my high ram issue by removing Lethal Resonance

lol

[plucky stump]

probably sound API should add compression option when loading a audio clip

https://docs.unity3d.com/ScriptReference/Networking.DownloadHandlerAudioClip-compressed.html

or even streaming for background music
https://docs.unity3d.com/ScriptReference/Networking.DownloadHandlerAudioClip-streamAudio.html

[plucky stump]

private unsafe void Start()
{
    var path = @"";

    using var stream = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.None, 16 * 1024 * 1024, FileOptions.SequentialScan);

    var buffer = UnsafeUtility.Malloc(4096, 16, Allocator.Temp);
    var span = new Span<byte>(buffer, 4096);

    var hash = new Hash128();

    int readBytes;
    while ((readBytes = stream.Read(span)) > 0)
    {
        hash.Append(buffer, (ulong)readBytes);
    }

    UnsafeUtility.Free(buffer, Allocator.Temp);

    var hashBytes = new byte[16];
    var readableHash = UnsafeUtility.As<Hash128, ReadableHash128>(ref hash);
    BinaryPrimitives.WriteUInt64LittleEndian(hashBytes, readableHash.u64_0);
    BinaryPrimitives.WriteUInt64LittleEndian(hashBytes.AsSpan(8), readableHash.u64_1);

    Assert.AreEqual(hash.ToString().ToUpperInvariant(), HashToString(hashBytes));
}

public static string HashToString(Span<byte> hash)
{
    Span<char> chars = stackalloc char[hash.Length * 2];

    for (var i = 0; i < hash.Length; i++)
    {
        var b = hash[i];
        b.TryFormat(chars[(i * 2)..], out _, "X2", CultureInfo.InvariantCulture);
    }

    return chars.ToString();
}

public readonly struct ReadableHash128
{
    public readonly ulong u64_0;
    public readonly ulong u64_1;
}

IDK how to make hashing a file even faster

this implementation hashes a file of 100MB for 100ms

[steel quiver]

really that was it?

[grand coral]

Yeah

[grand coral]

@misty rock you may wanna look into these suggestions, it might help with the ram usage from LR

[steel quiver]

but going back to when you said 0.6 was using less RAM than 6.2 or whatever. Is that still the case even to latest?

[grand coral]

Ram usage with 0.6.2 is the same as it was with 0.6 for me if I were to have LR disabled with 0.6 and 0.6.2+, I think the difference is that the new hashing method doesn't lower the ram usage of mods adding a lot of sounds at all, which is why DiFFoZ suggested Bongo's API needs to do it itself

[steel quiver]

Ah gotcha. Thank you for clearing that up for me.

[grand coral]

Yeah I don't recommend using LR currently, unless you're okay with the game using up a lot of extra ram ☠️

[steel quiver]

been on the journey now for A WHILE trying to make my profile for lethal not use too much RAM for my friends with let’s just say, not a lot of RAM.

[plucky stump]

If i would make a modpack then I would just add a big warning system requirements, like 16GB of RAM and 8GB of VRAM

my rx580 with 8gb of vram is always full when playing with mods

on like 1050ti with 4gb you get a lot of ram usage

[grand coral]

Yeah my friends struggle sometimes to run my pack with 16gb of ram, and after the Faster Load update seeing that LR was changing the game to use around 7.8gb of ram I was like "Eeesh"

"Maybe that's why some of them had trouble and I didn't before"

Lol

My guess would be the ones with high ram usage especially have lower vram

My card has 12gb

[misty rock]

streaming doesn't help at all with that
compression: maybe

[grand coral]

Yeah the compression stuff will probably help

[plucky stump]

Published v0.6.4. Just bug fixing

[0.6.4] 2024-06-18

Changed

• Internal size of stream buffer to speed up hashing.

Fixed

• Bundle with enabled flag ShouldNotDecompress is not updating last access time.
• Deletion of temp assetbundles called twice.

And I have decided to not publishing separate nightly package. Instead I will just update the main package, but all experimental stuff can be toggled with config option.

[fervent niche]

my modpack doesnt seem to launch with this mod enabled for some reason, it was working fine until this mod was updated the other day (todays update didnt fix it)
I tried to manually delete the cache and mod configs, and also disabled introtweaks, but it still didnt work

[misty rock]

nope it seemingly does absolutely nothing

[fervent niche]

ok, found the culprit after actually looking at the logs, and its... GameyStew-HutchersonWhistle-1.0.3 that was causing the game to not load up when faster load assetbundles patcher is enabled 🤦‍♂️

[plucky stump]

lol not sure why

[grand coral]

So it seems like GeneralImprovements is pretty unoptimized as a whole, are there any features specifically that stand out as the cause or would I be better off disabling it for now?

Since Shaosil is taking a break from LC modding

[plucky stump]

Probably better monitors are still unoptimized and causing lag spikes

[grand coral]

Yeah even disabling those I noticed the game still performs lower than disabling it though while on the ship

So it's probably a number of things, those are certainly part of it though

[plucky stump]

I can try to enable profiling with GI

[grand coral]

Yeah you might find some interesting stuff I'd imagine

[plucky stump]

may you send your profile code

[grand coral]

01902e80-4b08-c068-393c-91f41955811d

[plucky stump]

yeah GI still causing lag spikes due to monitors

[versed sand]

tbh i feel like the monitor aspect of GI should be its own mod and not a GI addition but I can also understand why they would want to just keep it all in one mod

[grand coral]

Even with better monitors off? Eesh

Well Open Monitors and a few seperate mods are good alternatives to it

I guess I'll do away with it

[grand coral]

Well I guess disabling Better Monitors would still improve performance enough

[steel quiver]

Sucks cuz GL has a lot of the built in quality of life shit

[grand coral]

If you disable Better Monitors it helps a ton tbh, removing it entirely will net a bit more performance but if you're using a lot of it's features I don't recommend that

Better Monitors ruins frame time consistency across the whole game it seems

Disabling it helped so much

[plucky stump]

here top memory usage when in ship

please note that some mods will not show in profiler because of using unity api not at main thread

for example, sound api will not show here

fixed*

[grand coral]

So it seems like lowering suit mods would help

lol

@tulip fjord btw why is the duck song included when you don't have the duck added yet?

XD

[steep needle]

are the suits still a problem even with mods that remove the rack and stuff from the ship?

[plucky stump]

say thanks to LoadAllAssets

[plucky stump]

yes, because you still need suit texture to apply

suits mod doesn't load texture when needed

[steep needle]

ic

[grand coral]

I wonder which suits are the most unoptimized now

[tulip fjord]

cuz

[plucky stump]

from memory profiler looks like all of them

because texture size is 2048x2048

[grand coral]

Fun

Why don't they just use 1024x1024?

That would help a ton

[plucky stump]

note: Graphics category means VRAM usage not RAM

[grand coral]

Does using a config like More Suits' and excluding them from loading reduce ram usage?

Okay yeah it does

I disabled all the ones added by More Suits in it's config, and I just removed More Jammies

that helps

[grand coral]

Maybe set it so it doesn't load for now to free up ram usage? lol Or add a config option

[plucky stump]

also, GC allocation per frame is 4KB

and spike up to 110KB

[grand coral]

So are there any mods btw that showed up as unoptimized that aren't listed in the profiler?

[tulip fjord]

maybe next update

[plucky stump]

here some major GC allocation

[grand coral]

LethalEmotesAPI having fun huh

Unfortunately til SoundAPI gets fixed I have to use it right now cus TooManyEmotes' emote audio won't loop lol

I do wonder if there's a way LethalEmotesAPI could be optimized though

[plucky stump]

allocation per frame:

AudioReverbTrigger.OnTriggerStay [LC]
StartOfRoundPatch.Update [Diversity]
PlayerControllerBPatch.FixCriticallyInjuredState [TestAccountFixes]
PlayerControllerBPatch.Update [Diversity]
PlayerControllerBPatch.ManageBodyReplacments [ModelReplacmentAPI]
PlayerControllerBPatch.Update [GeneralImprovements]
Patches.Player_Update [NiceChat]
GeneralPatches.ReadInput [LC-Vega]
HUDManagerPatch.UpdateScanNodes [GeneralImprovements]
HUDManagerPatch.Update [GeneralImprovements]
HUDManagerPatch.SetValueForCorrectType [InsanityDisplay]
MeterHandler.EnableCompatibilities [InsanityDisplay]
PlayerControllerBPatch_C.Update_patch [BetterItemScan]
AudioMixerSetFloatPatch.Prefix [MoreCompany]
MoreCompanyCosmeticManager.RefreshCosmetics [ModelReplacmentAPI]
NullReferenceException every frame [ModelReplacmentAPI]
DependencyChecker.IsTelevisionControllerInstalled [TestAccountFixes]
NewStaminaMeter.UpdateMeter [AccurateStaminaDisplay]
CobwebChecker.IsPlayerValid [TestAccountFixes]
CobwebChecker.HandleCobweb [TestAccountFixes]

Patches_Enemy.Fix_NearActivityDead [LethalFixes]
ChangeMidDay.MoveTimeOfDayPatch [WeatherTweaks]
DissonanceVoip.WaveFileWriter [called by Mirage]

[grand coral]

NiceChat is allocating per frame? 🤔

[plucky stump]

yeah

[royal cloud]

@grand coral do you use r2modman? i know you tinker with your config a lot and i do too, have you ever noticed high ram usage after tinkering for a while? i just noticed that i swapping between config, online mods and installed mods tabs doesnt free up ram and just constantly consumes more and more till a restart

[plucky stump]

for some reason it updates character limit of input field every frame

[grand coral]

Okay so I wasn't crazy when I thought the game ran better with HideChat instead

This also may explain why there's a performance gain at times with GI full on disabled

Although Better Monitors is what affects it most

[slim silo]

did someone say performance

[grand coral]

Btw why is scan nodes allocating when I have it's scanning stuff turned off?

Wha?

Maybe cus of this?

[slim silo]

FixCriticallyInjuredState and Patches.Player_Update was unexpected

[royal cloud]

i was about to ask if you had that on, could be

[grand coral]

I'll turn that off then

[slim silo]

same

[royal cloud]

i know nothing so dont take my word for it LOL

[grand coral]

For TestAccountFixes

[royal cloud]

doesnt hurt to try

[grand coral]

That was for the Player Speed Fix which @queen heath made to fix players being stuck permanently crippled

Which is a bug that happens from mods sometimes

[plucky stump]

I can check the code later to see why

[grand coral]

Like the Shockwave Drone or Lethal Doors Fixed

[slim silo]

i don't have neither of these mods, so it would be safe to disable it?

[grand coral]

Also the thing for BetterItemScan makes sense

[grand coral]

Yeah

Cus I noticed ScanTweaks performs smoother

[grand coral]

@pastel hound What's the ReadInput patch for?

[grand coral]

@queen heath lmao CobWeb checker having fun it looks like

[plucky stump]

if dev needs more info which one causing allocation, ping me

[grand coral]

Also HudManager.Update

I'm guessing is for Lightning Warnings?

I had theorized that might be causing hud manager spikes

[plucky stump]

here example

[pastel hound]

That's what I use for the activation hotkey

[grand coral]

Yeah for Hud Manager looking at GI's github it seems it would be the Lightning Warnings and hiding empty subtext of scan nodes

[grand coral]

Ah well I don't even have that feature on D;

So shouldn't it not be allocating per frame if disabled?

it's still calling that function I guess even when set to not be used

That needs fixed probably

[pastel hound]

Yes, because it still gets patched. I made it that way so you can change the config mid game if you want to

[grand coral]

Ahhhhh

[pastel hound]

I guess I could add an option to disable it if need be

[grand coral]

Yeah that's a good idea

Just so it's not allocating per frame

@plucky stump btw is Elads more optimized than AccurateStaminaDisplay? I kind of wanna keep InsanityDisplay I really like that mod lol

[plucky stump]

it's for lighting warning AND updating current hp text

every frame if hp is not even changed

[grand coral]

I knew it

I knew the hp text made fps worse

I

knew it

lol

[plucky stump]

uhh idk

[grand coral]

Was I right about the empty text of scan nodes being used for UpdateScanNodes btw?

[plucky stump]

yeah

[grand coral]

Okay yeah I figured lol

If Elads is more optimized it'll also work for replacing the hp text

[plucky stump]

lesson learned, disable diversity on dev build

or it will spawn 300K of walkers

[grand coral]

Lol

[grand coral]

For insanity display

it looks like Treys Health Text is automatically compatible, so I can use that and disable it's compatibility patches

[grand coral]

@languid raft I wonder if you could maybe optimize this, so it's not always calling that function per frame but only when it needs to update

For AccurateStaminaDisplay

cus I really like it

Cus it seems like rn it always calls that

Even if you're just idle or not sprinting

[plucky stump]

Experimentation seed 87037585
TIME 12 AM

uhh

[grand coral]

@median lintel

lol

[plucky stump]

looks like F# is allocating a lot of garbage

[grand coral]

@median lintel Looks like it's time to switch Mirage to C# XD

[languid raft]

@grand coral maybe

i can take a look at what it's allocating

i havent really messed with accuratestaminadisplay in forever

i need to update the stamina meter every frame though

because otherwise, the vanilla code will update it and it will look wrong

i can't get around that

[pastel hound]

Yeah I was about to say that lol

[languid raft]

i suppose there is the option of just removing some code from vanilla with a transpiler but it would still require a considerable rework of my code to take advantage of that sort of optimization

it is true im probably doing a lot of work per frame though

and it might not all be necessary

[grand coral]

If that just showed up for LethalFixes then it might have been called cus an enemy was near the door

[median lintel]

hellnah i aint switching back to c#

if that specific part of the code is causing all those extra allocations i'll rewrite that part though

btw diffoz how are you profiling the game? i was using dottrace to profile content warning before, but i outta just use the standard that everyone uses here

not sure why WaveFileWriter itself would be causing allocations but i'll look into it

[plucky stump]

here call stack

[plucky stump]

you need dev build of UnityPlayer.dll to profile

you can find it here

C:\Program Files\Unity\Hub\Editor\2022.3.9f1\Editor\Data\PlaybackEngines\windowsstandalonesupport\Variations\win64_player_development_mono

Just copy UnityPlayer.dll and WinPixEventRuntime.dll

[plucky stump]

nope

no enemies and still allocating

[slim silo]

could you check my profile too if it isn't asking too much = )

01903364-a5dc-dce0-752e-5408dfc8c0ad

[plucky stump]

omg why weather tweaks spam about that it got some data

[plucky stump]

no sorry, profiling takes time

[slim silo]

ok = (

[plucky stump]

2 MB per second to write that

probably because of sqlite logger

[grand coral]

Interesting

[grand coral]

Lol @frosty meadow

[plucky stump]

ah reflection moment

it causing gc allocation

[grand coral]

Ahhhh

@royal fulcrum is a good dev tbh so he can likely find a way to fix that

[plucky stump]

not sure why reflection used, because game libs on BepInEx nuget server already makes everything public

[grand coral]

I have a lot of respect for him lol

[grand coral]

Dunno

[median lintel]

btw just for expectations sake @grand coral any optimizations will probably have to be done after the release of v2

[grand coral]

I was making some jokes but still lmfao

[median lintel]

yeah ik i just meant cuz i actually do plan on optimizing it

was already planning to b4 this post

[grand coral]

Are you able to maybe optimize some of these things before V2 though?

[median lintel]

the specific part that diffoz screenshotted is something i know is doing a ton of allocations that i can definitely reduce

[grand coral]

This likely explains why some people used to mention they experienced a performance hit from Mirage

[median lintel]

nah people who talk about performance hits has always been from log spam in the past

[grand coral]

Ahhh

[grand coral]

Yeah I was gonna say, any optimizations you can push as an update for V1 while we wait for V2 would be appreciated

c;

[median lintel]

every time i've seen someone complain about mirage having a performance hit, their logs are filled with errors (that's not even from mirage actually), probably an incompat

[grand coral]

I'm not taking Mirage out

lol

[median lintel]

the thing is, i don't wanna hold v2 back so i'm prob not gonna look into it until after v2 is released

v2 is already coming out waaaaay later than i planned

so i just wanna get it out first, take a break, and then start doing optimizations

[thin perch]

[median lintel]

yeah ik im just saying for transparency

just so u know that optimizations are something i'm gonna look into eventually

[grand coral]

I think that's stuff Mrov logs that he just hid with WeatherTweaks beta btw, I remember when I first started using Beta seeing that same spam in the actual logs

Back when it was just me helping test it for him

God that feels like ages ago

XD

You could try testing StableTweaks and seeing if it does the same

[grand coral]

@candid gale Any chance you may be able to look into some of these things, the NRE's every frame especially?

[candid gale]

You might want to consider adding some context.

[grand coral]

@queen heath why is TestAccountFixes constantly looking for Television Controller per frame?

[grand coral]

@plucky stump can probably give you the additional info you need

Basically that is stuff being called constantly per frame, which introduces lag

Idk why NRE's are being thrown though

The other stuff I consider minor but NullReferenceException Errors need fixed

[plucky stump]

here call stack

[candid gale]

Oh that's extremely helpful, thanks.

[grand coral]

I wonder if this explains Model Replacers not despawning when paired with More Company too

[candid gale]

Only time will tell.

[grand coral]

I guess we'll see ^^

I hope that might be the cause of it

It's interesting how this only showed up through profiling

I could never get anything through logs

[plucky stump]

this is because of try/catch using

[candid gale]

Thanks for the info, that's just what I needed. I've stepped back from modding recently since my mod is in a functional state, and I've got other life related things that require my attention, but I'll see if I can't get this fixed in the week.

[runic steeple]

wait so ct, ship windows and more suits tank performance?

[grand coral]

I wonder btw if for issues like this in the future if you can add an option for extensive logging so errors like this can be debugged easier

That way we can enable the logs that would normally be hidden by try/catching

[plucky stump]

CT can a bit tank performance

because it using HDRP realistic sky

[grand coral]

More Suits if you don't use any of it's suits

exclude them

I set them all as excluded lol

I use suits from other mods but none of the ones from More Suits itself

[runic steeple]

more suits is the only suit mod i got lol

[grand coral]

Ah then you can just set the ones you never use as exclusions

[runic steeple]

oh true

[grand coral]

It will prevent them from being loaded

[runic steeple]

like, does it tank only when ur in ship/orbit? or the whole time ur playing u think?

[plucky stump]

in ship only

[queen heath]

Because I'm an idiot

[runic steeple]

not a huge deal to me then ig

[plucky stump]

but if you're running out of VRAM I would suggest to remove CT

[runic steeple]

why

[grand coral]

Lol you'll hotfix it you aren't an idiot

Also is there a way some of those other things can be set to not constantly update or no? Gonna guess not

[plucky stump]

because if not enough of VRAM then game will use slow RAM

[queen heath]

Sometime today

[queen heath]

Like?

[grand coral]

@queen heath you can look through this

CobWebChecker and the Player Speed Fix stuff

[languid raft]

oh that's probably part of the problem with accuratestaminadisplay

it uses reflection to pull "hinderedMovementPrev" or whatever it's called on PlayerControllerB

[grand coral]

The Spider Web Fix needs a fix anyways, cus clients get zoomies when walking through them atm lol

[queen heath]

Well, wouldn't know how to make those fixes work without.

If there's an update method with a less frequent call rate, I'd love to know

[grand coral]

Yeah idk if you can tbh

That's why I asked

[queen heath]

*Sometimes

It's not always like that

[grand coral]

It's been like that for Wesley everytime

Ahaha

[queen heath]

So far, I have only run into this issue once so far, so there has to be a trigger.

I might have an idea on how to fix that

[runic steeple]

sorry im ignorant. do u think disabling some moons should help my game run better and crash less often? i play on laptop and sometimes it crashes when i play with a lot of mods

[tiny cairn]

My friend and I checked it just yesterday, we had stable crashes but we have a very large modpack, ~30 planets and dozens of interiors + JJ suits + Anime Suits that take up a lot of memory.
The crashes were very different

• when a mob kills
• when the moon loads, but if I launched it solo and then in the lobby then everything is ok
• random when interacting with scrap
  But as soon as we got rid of 15+ planets, all crashes disappeared

I don't know what exactly influenced it, but everything suggests that reducing the modpack will lead to a more stable game.

[grand coral]

@plucky stump It looks like PlayerControllerB stuff for GI also includes the AutoChargeOnOrbit feature which is disabled by default, I'll use OrbitRecharge by Mrov instead cus it doesn't mess with that, and also the FlashlightFix stuff as well

[runic steeple]

thanks

[median lintel]

wait whats CT

[grand coral]

Celestial Tint

[median lintel]

ah

i'm so glad my gpu is good enough for it to not matter then

i love that mod

[tiny cairn]

The mod is extremely good, in my case after several launches it reduced the loading time from 2:30 to 1 minute (with already deleted some moons)
And for a friend from ~6-7 minutes to 2

[runic steeple]

ive got 4 gigs of vram total

[plucky stump]

💀

the game itself using 2GB of vram

1GB for OS and other apps

[grand coral]

What's calling the PlayerControllerB stuff in Diversity?

DressGirlIsolation maybe?

I have the player conditions and fulldarkness stuff disabled

[plucky stump]

• checking conditions
• saving the last used flashlight id item
• interaction stuff (with door and centipede)

[grand coral]

Ahhhh

[granite ravine]

Late to the party but also ignoring the fact it’s setting always even if it’s the same tmp has a SetText function which doesn’t allocate iirc

[grand coral]

Yeah that stuff all explains why GI was making my game perform worse than disabling it, I turned off all that stuff that was constantly allocating

[grand coral]

I'll disable the Centipede revamp, I don't really find it to be super useful anyways

[runic steeple]

oh well

my laptop can only get 60 fps max anyway

[grand coral]

Flashlight makes sense, cus of the Bracken stuff, which sometimes bugs out

@crisp hinge maybe you can add an option to allow disabling the Bracken flashlight stuff? Cus half the time I get bugged with a super dull flashlight anyways cus a bracken dies near me or one kills me lol

I do like the Flashlight features though

I think having it flicker alone does the job to let you know there's a bracken though

[slim silo]

General Improvements just keeps getting worse each time we dig deeper, guess i'll have to disable it 😭

[grand coral]

You can disable all the features that are causing issues

So the problematic features are

[runic steeple]

i thought it was just the better monitors?

[grand coral]

Better Monitors, OnlyAllowingOneFlashlight, AutoChargeOnOrbit, LightningWarnings, ShowHitPoints, HideEmptySubtextOfScanNodes, and all other Scanner Related Features such as ScanFix, ScanningTools, Dropship Scan Node, etc

[grand coral]

Nope

it's all that I just listed

[plucky light]

how badly does it affect performance?

[slim silo]

Does LightningWarnings have any substitute?

[grand coral]

Not that I'm aware of, but it causes hud manager spikes so I'd recommenmd turning it off

[slim silo]

F

[grand coral]

Perhaps @errant mulch could add an alternative to HotBarPlus

Similar to the energy bars

[runic steeple]

.

[grand coral]

It's constantly calling per frame, so you'll get frame time inconsistencies, stutters sometimes

etc

[slim silo]

Then... are the masked configs in GI also heavy?

Or dropship/tool scan nodes

[errant mulch]

tl;dr?

[grand coral]

The Show player names feature has a lot of bugs

[plucky light]

what are frame time inconsistences

[grand coral]

and yes GI's scan stuff as a whole

cause performance issues

[grand coral]

Basically you may notice a lag spike that will last for around 20 seconds

sometimes 30

etc

Inconsistencies means it's random

[slim silo]

Basically: Disable half of GI to get rid of lag

[grand coral]

GI's feature for Lightning Warnings is doing a no no and always calling on the hud manager lol

[plucky light]

have you experienced those before? was it something really bad or something your barley noticed unless you REALLY paid attention

[grand coral]

So I was thinking you might be able to implement an alternative to Hotbarplus, it's been bothering me that GI's feature never worked for extra slots or Reserved Items anyways

[grand coral]

I've been noticing it, it's why I asked DiFFoZ to profile my pack

I wanted to finally optimize it

[plucky light]

I see

that sucks man I really liked some GI's features

[errant mulch]

Oh, for lightning warning. Possibly. I'll think of a proper implementation, and if it doesn't sound too bad, I might do it sometime. I can't promise a timeframe lol

@grand coral

[grand coral]

Okay ^^

[plucky light]

is GI the only mod causing major issues? this thread has a lot of messages rn so I don't wanna read through all of them

[grand coral]

It's hard to say tbh, there might be others that I don't have in my pack

[plucky light]

ah, ok

Well I guess i'll just disable the features mentioned here for now

[grand coral]

The good thing is all those features that are problematic can be disabled, and @frosty meadow's OrbitRecharge can be used as an alternative to the GI feature cus it doesn't constantly call stuff

https://thunderstore.io/c/lethal-company/p/mrov/OrbitRecharge/

[plucky light]

oh fire, glad there's an alternative mod for that feature

[plucky stump]

also, zeekers made FoliageDetailDistance to leaking material every frame

[grand coral]

Weird, is that being caused by a moon?

Ohhhh I see

Ty Zeekerss

[plucky stump]

experimentation

[grand coral]

lol

I hope he fixes that in V55

6 days

🥺

[slim silo]

6 days until half of the mods break

[plucky stump]

every second*

[grand coral]

I for some reason have doubts

It's mostly gonna add content like the car, a new enemy, maybe Liquidation as a moon

Probably Bug Fixes

[plucky stump]

for car he probably changed player movement

[slim silo]

Hard to believe liquidation is coming in v55, probably in v60

[grand coral]

Some things might break but I don't think it will be as drastic as V50

[plucky stump]

that may cause patch issues

[slim silo]

Would be cool if he did optimizations, but that is unlikely

[grand coral]

Possible

[plucky stump]

he did optimization - reduce resolution to 480p

[grand coral]

Oh yeah and it looked like a new emote was added too, he showcased it in the trailer

[plucky stump]

😂

[slim silo]

https://tenor.com/view/floppa-floppa-spin-floppa-spins-big-floppa-big-floppa-spin-gif-21340110

Next big update: Graphic settings 🤯

[plucky stump]

LethalPosters leaks textures

every new moon I guess??

and also textures are readable so memory usage doubles

[grand coral]

Oof so I guess I'll remove that then

[granite ravine]

tbh under the assumption v100 would be contextually 1.0 it would make a lot of sense to do a bulk of the optimisations abit later

[plucky stump]

For LethalEmotesAPI you can enable Dont Show DMCA Prompt in global config to prevent GC allocation

see here

Sadly that option is not visible within lethal config

[grand coral]

I'm not seeing it in R2 either hmmmm

[plucky stump]

this is because it's global config

check it here

C:\Users\USERNAME\AppData\LocalLow\ZeekerssRBLX\Lethal Company\LethalEmotesAPI

[grand coral]

I've never actually seen it popup tbh but I set it to true, dunno why that option got added when you can just set it to DMCA friendly mode anyways, guess for people who don't have it set as a reminder if they're streaming

[grand coral]

@mint grove any chance you can possibly fix this soon and have it show up in LethalConfig?

[plucky stump]

looks like the toggle created but not passed to lethal config init

or that toggle it's for internal config manager idk

[grand coral]

https://thunderstore.io/c/lethal-company/p/souper194/HDVanillaPosters/ I wonder if this might be a good alternative to LethalPosters, the thing is I've not seen anyone use it so I'm skeptical of it lol

I just hate the low res posters the vanilla game has

XD

Did Diversity's poster leak textures at all btw or was it fine?

;o

[plucky stump]

I would not recommend to use it

16k size texture

[grand coral]

Oof

[plucky stump]

and plus texture is readable

[grand coral]

Ye

[plucky stump]

diversity poster?

[grand coral]

Yeah Diversity adds a poster to the ship, although with my pack the terminal hides it

[plucky stump]

looks like fine

[grand coral]

👍

[plucky stump]

accessing terminal lag spikes 20ms and generating 250KB of garbage

[grand coral]

Does it say which mod is causing that? I do have a few that touch the terminal

[plucky stump]

LethalEmotesAPI.dll!::BoneMapper.UnlockBones() /home/runner/work/LethalEmotesAPI/LethalEmotesAPI/CustomEmotesAPI/Core/BoneMapper.cs:1273
ES3Reader [save preferences]

[grand coral]

🤔

@mint grove why are you lagging the Terminal?

XD

[plucky stump]

there's a lot of mods that subscribes to terminal activation

[grand coral]

Yeah

I know GhostCodes could probably cause some terminal lag, Darmuh's terminal stuff might

GeneralImprovements also has a patch for the Terminal

go figure

Lmfao

[plucky stump]

mrov binding config option every log lol

[grand coral]

Lmaooo @frosty meadow

Mrov Mark of Stability strikes again

XD

[grand coral]

I still don't know why LethalEmotesAPI hits it so hard

[plucky stump]

probably because of external call to get an array of bones

https://github.com/Wet-Boys/LethalEmotesAPI/blob/main/CustomEmotesAPI/Core/BoneMapper.cs#L1278

3 times per bone

can't say without testing

[grand coral]

That would make sense

[plucky stump]

sound api is also generating garbage

for call stack due to string manipulation

[grand coral]

@misty rock

Wonder if you can look into resolving this

[misty rock]

wharg

[grand coral]

DiFFoZ is profiling my pack and found something with SoundAPI

[misty rock]

yeah i meant like more specifically 😭

[grand coral]

Can you give Bongo the call stack?

[grand coral]

He should be able to post the call stack, I know he did earlier for Bunya so Bunya can fix a long standing issue with MRAPI

[grand coral]

@misty rock

[misty rock]

oh yeah that stuff

[tulip fjord]

String manipulations expensive?

[grand coral]

Yep it looks like it

[misty rock]

no im just being stupid

[grand coral]

Ahhhh

[tulip fjord]

Yeah I figured lol, that'd be weird if it was

[grand coral]

That's the second time someone said that today lol

@queen heath said the same thing earlier

Hehe

[grand coral]

It's good he found this while you're working on an update for the API

[royal fulcrum]

I use the LC nuget for the GitHub build only (mainly cuz I don't want to rely on that being updated to be able to update the mods)

[plucky stump]

here profiler data of me opening terminal

[royal fulcrum]

I'll probably change my reflection stuff to use the harmony ___ fields (not sure if that'd actually improve the performance though)

[plucky stump]

yeah it should improve performance

[royal fulcrum]

The reason why I said I'm not sure if it will is since I guessed that it'd probably use reflection too

[misty rock]

i have no clue how to use profilers lol

[queen heath]

Technically you could publicize the Assembly yourself in that case 🤔

[plucky stump]

https://tenor.com/view/buh-b-u-h-cat-silly-кот-gif-2242355352608793340

[misty rock]

https://tenor.com/view/bocchi-the-rock-gif-3672785827050800275

[plucky stump]

https://cdn.discordapp.com/attachments/874214351052111895/1249381110056616068/4x5-ezgif.com-webp-to-gif-converter.gif

[thin perch]

time to google

[grand coral]

Btw @plucky stump Would setting this to false fix InsanityDisplay calling SetValueForCorrectType?

Cus if so I'll disable it

[plucky stump]

im not sure

ask the dev

[grand coral]

@elfin osprey

I tried checking the github and it doesn't show why that's called

[frosty meadow]

OH NO I DIDN'T 😳

[plucky stump]

https://media.discordapp.net/attachments/1168516853895790655/1252665933525159936/ezgif.com-animated-gif-maker_2.gif

[steep needle]

what are these gifs 😭

[plucky stump]

https://cdn.7tv.app/emote/65a5fa344ccf31a33fcee93d/4x.gif

xd

use them every day lol

[steep needle]

https://media.discordapp.net/attachments/549611835519664148/1156511134774460436/MeowMeowBruh.gif?ex=65153c6d&is=6513eaed&hm=658488bcf52196ebc1df3cf16fc650d0ea053e32c7fd7714faf7e181fe95a355&

[frosty meadow]

oh 😳

well

I have some things to fix

[tulip fjord]

weather tweaks made by zeekerss confirmed???

[frosty meadow]

that's why the game runs badly!

[elfin osprey]

disabling the accurate meter won't stop it from being called because the mod is not optimised 😔 so it's ran every frame (it's also not related to that setting)

[plucky stump]

LethalPerformance mod when

[tulip fjord]

you got thjis, i believe in you

[grand coral]

Ahhhhh

I hope you can optimize it soon bud

^^

I love the mod a lot

lol

[elfin osprey]

i'll do my best 🙏

[grand coral]

🙏

Btw @tulip fjord Can you look into why the ambient enemies from CodeRebirth can't be scanned when using ScanTweaks?

I don't know why they can't be

[tulip fjord]

who made that mod before i make a guess and blame the likely culprit?

[grand coral]

Saradora

[tulip fjord]

oh i have no idea who that person is, ill look into it ig

thought it was test account

[grand coral]

LOL

@queen heath the shade being given to you

XD

[grand coral]

He is the one that recommended it though so you can still blame him

[tulip fjord]

it's fine lol, but i also have no idea why it wouldnt work, you'd need to ask that dev

[tulip fjord]

@mint pond i handle components for those enemies the same as any other scrap/enemy as far as im aware, not sure why they wouldnt work

[plucky stump]

will probably work on this mod

[frosty meadow]

performance tweaks

[mint pond]

Helloo!
I'll see what i can find later today when i'm done working c:

[tulip fjord]

that'd be nice, ty

[queen heath]

Pfff

[royal fulcrum]

changed in v1.1.4 https://github.com/1A3Dev/LC-LethalFixes/releases/tag/v1.1.4

[mint pond]

so from what I see it's because your scan node colliders are marked as Trigger whereas the vanilla stuff is not.
The collision check in the vanilla code doesn't specify if it should hit triggers or not and honestly I don't really remember why I do 🤔, but it didn't cause any issues since none of them are triggers in vanilla

[tulip fjord]

they're marked as triggers? thats odd

ill give them a check

[tulip fjord]

this is for the snailcat

[mint pond]

yeah, "Is Trigger" is checked

[tulip fjord]

ahhh

thats what u meant

wait vanilla doesnt have that?

[mint pond]

nope 😄

[tulip fjord]

that's a bit shocking, you're supposed to collide with scannodes

huh

[mint pond]

probably that collisions with the ScanNode layer is disabled entirely for the player so it doesn't matter in the end

[tulip fjord]

you'd be surprised

[mint pond]

but I suppose it is a bit counterintuitive :D

[tulip fjord]

the player is filled with the most random layers ever that they are considered

im pretty sure the player has some railing collider layer embedded into them

it was something stupid like that last i checked

as in their box collider is put into that layer i believe

it might not be railing, might be "placeable ship objects"

[mint pond]

mm i admit i didn't really look too much into the player or the physics haha

[tulip fjord]

they're weird

while you're here, mind if i ask a couple questions?

[mint pond]

yeah sure

[tulip fjord]

the lethalMDK

what is up with that lmao

[mint pond]

that's just a thing i started making in case i did other mods but there is basically nothing in it lol
it's mostly shortcuts for layers, tags, and prefabs

[tulip fjord]

icic, the decompiled code... confused me quite a bit as it was just a million const strings lmao

[mint pond]

lmao

[tulip fjord]

whats the unity mdk for though?

[granite ravine]

when does that prefab stuff in lethalMDK collect

[mint pond]

it doesn't, it collects when I use the Debug version of the "mod", but the Release version doesn't have the collection code

[mint pond]

a few utilities for patching objects for Unity games in general, I can basically spawn a component on any prefab with just a few lines of codes

[granite ravine]

i feel bad for being a dick here but you'll have to do that collection post LLL initialization

otherwise you might get fake prefabs

[mint pond]

I'm sorry what is "LLL"? 😭
also no need to feel bad, I can make mistakes like anyone else and if I do I'm interested to know haha

[granite ravine]

lethallevelloader, predominant custom content api

due to assetbundle reasons you might accidently collect asset rip versions of the prefabs you want

[mint pond]

Oo ok ok, well I basically just run the mod once when the game updates in full vanilla to avoid that

[granite ravine]

huh

no

this call will give you results you dont want

if you don't call it at the right time w/ LLL installed

[mint pond]

it's technically a risk if there are modded prefabs with the exact same name as vanilla prefabs yeah
otherwise it just won't do anything to those prefabs
but this is the only way that I found to collect prefabs, since some of them don't get loaded until you are basically inside the ship!

[granite ravine]

sure but if you collect the modded one instead of the real one

and then i destroy the modded one..

[mint pond]

I'm not sure what you mean, sorry D:

[granite ravine]

youll be grabbing the wrong object

which will be destroyed

and it will break your stuff

[mint pond]

i haven't really used LLL so i admit i have no idea how it works, why would the prefabs be destroyed?

[languid raft]

@grand coral i should be able to at least remove the reflection call from accuratestaminadisplay which should help with gc alloc

i can take a look at a few other changes i might be able to make but i'll probably just release that one change as a hotfix in the meantime

im still sitting on updates to butteryfixes and enemysoundfixes and don't want to spend time rewriting ASD at the same time

[granite ravine]

custom content references asset ripped versions of basegame content

I have to replace references to asset ripped versions with the real ones at runtime

but like you i can only do that when i can actually access them

[mint pond]

Oh, okay i think i see

that does seem like a problem

[grand coral]

Sounds good 🙂

[grand coral]

@plucky stump it also looks like GeneralImprovements might cause HudManager spikes if using the LbstoKG option as well so I'm disabling that

[plucky stump]

from the code it doesn't seem to can cause any lag spikes

[grand coral]

Ah okay good

I just saw it inside of the HudManager entry and got worried it might lol

[plucky stump]

Transpiler patch just happens at start up

[grand coral]

Ah okay good

[plucky stump]

from the code it does a lot of overhead to do the patch but after that it will be fast

https://github.com/DiFFoZ/RTLC/blob/main/RTLC/Patches/Patch_HUDManager.cs#L22
Can be really simplified to that code

[grand coral]

Yeah, I wonder if any of the other Kilograms mods might do it without so much overhead

We also really need a mod that improves the scanner that doesn't spike the hud manager or allocate constantly, I liked ScanTweaks but it breaks scan nodes for so many mod items

[steel quiver]

what mods are you using to replace the features you used with general improvements

[grand coral]

You mean with the stuff I disabled? I just added OrbitRehcharge by Mrov and @errant mulch is gonna look into doing a proper implementation of Lightning Warnings for HBP

Treys Health Text to replace HitPoints

And if you want stuff for the scanner that don't provide issues

These are all good

I recommend never using the ScanFix feature in GI

it is heavily unoptimized

@plucky stump Just wondering since there is no way to fully disable the FlashlightFix feature in GI, but is that also causing problems? The most I could do was Disable OnlyAllowOneLight to lower it's gc alloc stuff

[thin perch]

https://tenor.com/view/looney-tunes-daffy-notes-writing-gif-13673626

(copies lunx’s homework)

[slim silo]

for some reason, Treys Health Text is buggy when you join a lobby the second time (at least in my modpack)

[grand coral]

🤔 you likely have a conflict did you get any errors?

Oh also if you use InsanityDisplay

[slim silo]

didn't check the logs, but i will do that rn

[grand coral]

Disable all the compatibility patches if you don't use any of the stuff it tries to find compat for

I'd also just recommend temporarily removing it

[slim silo]

ik, i disabled

[grand coral]

The dev has said it's unoptimized and plans to optimize it soon

[slim silo]

ok

[grand coral]

But disabling the compatibility patch stuff alone should reduce the gc alloc stuff a lot

AccurateStaminaDisplay should be much better now

Since Buttery pushed the fix to remove it using reflection stuff

[slim silo]

i don't use AccurateStaminaDisplay

[thin perch]

InaccurateStaminaDisplay is my cup of tea

[grand coral]

I honestly like AccurateStaminaDisplay for the color changes cus I have MoonSwept in my pack, so it's nice watching the color change from the TZP drone lol

But yeah it's not essential

[thin perch]

what’s moon swept

[grand coral]

@lyric owl

Time to educate the youth

lol

[slim silo]

i played too much LC, i'm too dependant of having that extra chance of getting away with the invisible extra stamina

[thin perch]

[slim silo]

Trying to get Treys log but ended up getting shutter dissapearing log

lol

[grand coral]

Oh yep lol

@queen heath the shutter switch vanishes if you leave and reenter a lobby

XD

[plucky stump]

LGTM

[grand coral]

LGTM?

[plucky stump]

from code it looks like fine

Looks Good To Me

[grand coral]

Okay good ^^ so the OnlyAllowingOneLight feature was all that needed disabled then

Good

[lyric owl]

Drug drone.

[grand coral]

And very buggy Turret

lmao

[lyric owl]

Nuh uh

[grand coral]

Everytime I try reenabling that thing

LOL

It's so buggy

Getting shot through a wall

Lmaooooooo

I love MoonSwept but the Turret needs some love

XD

[steel quiver]

Ah okay so you keep GI still just disable the unoptimized stuff. Is everything you said in that message regarding replacements what you disable in GI

[grand coral]

Yeah don't use any of this stuff in GI basically

[steel quiver]

got it thank you so much!

[lyric owl]

[lyric owl]

I don’t have it wall hack personally

It’s movement is a little weird

But I haven’t had it wall jack

Hack*

[slim silo]

tried somethings to get any log of what's happening but no progress

treys doesn't show any errors

but the HUD should be like this

The only mods i have that messes with the HUD are:
NilsHUD, VoiceHUD, InsanityDisplay, Oxygen, PingDisplay, HideChat, HotbarRD, JetpackWarning, LCBetterClock, ToggleMute, EnhancedIcons, ShowCapacity and other minor mods, i will test disabling some to see if i can find the incompatible one

[grand coral]

If you're using Treys I would remove NilsHud tbh, Nils is pretty buggy

[slim silo]

let me test

[grand coral]

I need to look into the others

ShowCapacity I know is a bit buggy as well and hasn't updated in a long time but idk if it'd conflict

[slim silo]

you wouldn't believe it

it was NilsHUD indeed

taking it off...

[slim silo]

why is ShowCapacity buggy?

[grand coral]

I know I ran into some oddities with it, can't even remember what anymore cus it was so long ago

[slim silo]

well, it worked fine with me

any other mod that may increase GC alloc?

[grand coral]

Unless you have DiFFoZ profile the mods you use it's hard to say

Also you can use WeatherTweaks stable instead of Beta if you want WeatherTweaks to not use gc alloc, it's the patch in Beta that's used for Progressive Weathers doing it

[slim silo]

i also don't use BetaWeatherTweaks, so i'm safe

[slim silo]

what's his profile?

[grand coral]

Meaning you send him your pack code

and he'll profile it

for you

[slim silo]

a

well, i tried yesterday but he said it was hard profilling

but it's okay, i do suspect some mods that could cause gc alloc

[grand coral]

Btw @plucky stump would the HidePlayerNames feature cause any PlayerControllerB spikes? Since it shows them while in orbit and hides them when the ship is landed? It doesn't look like it would

[plucky stump]

nope it wont cause any lag

[grand coral]

👍 Yeah the patch looked very simple so I didn't think so

[plucky stump]

I'm currently learning how HDRP working underhood

so I can try to find some options that I can disable to reduce render time

[grand coral]

Noice so you really are working on that Optimization mod 😄

[plucky stump]

Oo Burst compiler is working in LC

that's nice

[plucky stump]

The first thing that will be in LP (LethalPerformance) is enabling burst in rendering code

and in other parts

[errant mulch]

So how did the lightning warnings work with GI? I haven't actually used it, but was it just a texture that flashed over item slots that had a metal object?

[tulip fjord]

Pretty much

[grand coral]

Yeah basically ^^

It would highlight the hotbar when an item was about to be hit by lightning, but it was never compatible with your mods properly, it would never work with Reserved Items or any additional slots just the original 4 lol

[grand coral]

Do you plan to release this soon? So we can get this feature since it seems to help a lot :3

[plucky stump]

I'm not at home

idk maybe after 6 hours will publish the mod

[deep bobcat]

how much of a difference does burst make?

[grand coral]

👍

[plucky stump]

no measurements wasn't made yet

[slim silo]

I would love to test the mod, but i will travel this weekend

😔

[plucky stump]

#1253705079605956640 message

[grand coral]

Just noticed by Why does Celestial Tint load an 8k texture?

☠️

No wonder it's ram hungry for people low on VRam hoooly

[plucky stump]

nah it's just name

it's actually x2048 texture

but 0.5GB is for skybox

[grand coral]

Ahhhhh

[plucky stump]

update got delayed, but we will get more things in the next update

[grand coral]

Ahhh I wonder what else he's adding

[grand coral]

Btw @plucky stump I wanted to ask since I have a friend that is pretty convinced of this, will using things like LCUltrawide lower performance due to increased resolution since the game uses HDRP?

Cus in my case I haven't experienced that, I'd say it runs better capped at 1080p

[plucky stump]

ofc increasing resolution will decrease the performance

[grand coral]

What would you cap it to personally?

[plucky stump]

For me meh, use the original game resolution, but my friend with 4k he really needs that mod

because 480p on 4k monitor is reallly bad

[grand coral]

Yeahhhh

[amber marsh]

It's 520p actually.

[plucky stump]

[tiny cairn]

1080p half render = 540p ☝️🤓

[plucky stump]

updated lunx profile to the latest version and here some results:

• ModelReplacmentAPI doesn't throw NRE every frame (but still do string.ToLower thing)
• loaf sound api still do string allocation
• TestAccountFixes still allocating due to checking dependency of television controller
• MrovLib is still binding config option every log 😭

[slim silo]

Why is TestAccountFixes checking that

[queen heath]

TelevisionController causes issues with the Grab Fix.

And that check exists to fix that.

I'm guessing it's about this:

    [HarmonyPatch(nameof(PlayerControllerB.SetHoverTipAndCurrentInteractTrigger))]
    [HarmonyPrefix]
    [HarmonyBefore("com.kodertech.TelevisionController")]
    // ReSharper disable once InconsistentNaming
    public static bool BeforeSetHoverTipAndCurrentInteractTrigger(PlayerControllerB __instance) =>
        DependencyChecker.IsTelevisionControllerInstalled()
|| HandleSetHoverTipAndCurrentInteractTrigger(__instance);

I did improve the DependencyChecker though. It's no longer looping through all mods every frame

Nevermind... I just realised that I'm dumb

Next Update actually improves the DependencyChecker 😅

[queen heath]

Turns out, checking for TelevisionController was unnecessary anyway...

[grand coral]

Lmao

GJ Testy

At least you fixed it though

[frosty meadow]

i know, didn't get around to do that yet 😭😭😭

[grand coral]

@candid gale @misty rock lol

[grand coral]

I believe in you, do it today pls 🙏

[frosty meadow]

I will try

[queen heath]

The skybox is 2k, but the planet is 4k, right?

[grand coral]

@plucky stump could you tell @misty rock what he needs to change to fix SoundAPI's issues? Maybe you could push a pr on his github since he doesn't know how to profile it himself?

[brave mirage]

Bongo is a baka confirmed?! 🤯 🤯 🤯

[tulip fjord]

Or hes sleeping

[frosty meadow]

😳😐

why would you say it like that 😭

[grand coral]

Bongo said before he doesn't know how to profile his mod in this thread

Like just yesterday

XD

[tulip fjord]

Damn, sounds like it's gonna stay an issue forever

Oh well

[grand coral]

Or DiFFoZ can push a pr for him as I said

XD

[frosty meadow]

😳

[brave mirage]

eternal skill issues 😔

[deep bobcat]

just fix this other guy's mod for me please

[grand coral]

Lmao

Maybe Bongo will figure it out we'll see but pr's don't hurt

[plucky stump]

https://cdn.discordapp.com/attachments/1155590226362761367/1253863181080723559/4x.gif

[plucky stump]

Skybox is 16k(?) and texture of the planet is 2k

I cannot see the size of render texture from profiler

[grand coral]

Skybox texture needs to be reduced sheesh

That explains the ram usage

ShipWindows' Skybox is 2k, optionally 4k if you download the 4k one

[grand coral]

Idk what I said wrong there tbh, I felt I was wording it pretty nicely 😭

If I worded it wrong probably an Autism moment x.x

I slightly edited the message, I think I saw what I did lmao

Hope it sounds better

🙏

[grand coral]

Okay yeah disabling SoundAPI helps quite a bit for performance

I hope Bongo manages to optimize the string allocation stuff soon

@plucky stump Would this be why I had lag on Auralis earlier after a bunch of dogs spawned in? I noticed it was quite laggy

[plucky stump]

maybe

¯_(ツ)_/¯

[grand coral]

Did you manage to test how much SoundAPI was reducing performance?

;o

[grand coral]

I got very similar fps loss from a Thumper seeing me yesterday which was funny tbh

https://clips.twitch.tv/FancyHungryFloofCharlietheUnicorn-zaRKpwPLzdryZVnW

Was convinced it was LR but that might be a red herring lol

Especially since I got the same frame drops from dogs today

[grand coral]

Btw Mrov should have the issue with MrovLib fixed now

He pushed an update earlier for that

[slim silo]

So loafSoundAPI is the last one from the list

[grand coral]

@misty rock is probably looking into optimizing that to fix this I'd imagine it shouldn't be lagging like that

[slim silo]

Those optimizations better put my game in 1000000000 fps

[grand coral]

Well in the meantime I would recommend to temporarily disable it

[slim silo]

Chilling

[plucky stump]

Oh and Terbium hiding username from logs also causing gc allocation

so if you have a lot of debug logs then it will cause some performance drop

GC allocs:

mscorlib.dll!System::String.ToLower()
ModelReplacementAPI.dll!::PlayerControllerBPatch.ManageBodyReplacements()

GeneralImprovements.dll!GeneralImprovements.Patches::PlayerControllerBPatch.Update()

UnityEngine.CoreModule.dll!UnityEngine::Object.get_name()
LC-VEGA.dll!LC_VEGA.Patches::GeneralPatches.ReadInput()

mscorlib.dll!System::String.ToLower()
UnityEngine.CoreModule.dll!UnityEngine::Object.get_name()
HotbarPlus.dll!HotbarPlus.UI::EnergyBarManager.UpdateEnergyBars()

WeatherTweaks.dll!WeatherTweaks::ChangeMidDay.MoveTimeOfDayPatch()

mscorlib.dll!System::String.Join()
mscorlib.dll!System::Int32.ToString()
ScanTweaks.dll!ScanTweaks::CustomScanNodeProperties.Update()

FOLIAGE MATERIAL LEAK

[plucky stump]

yeah

it allocs on every sound that game requests

Call Stack:
UnityEngine.PhysicsModule.dll!UnityEngine::Physics.Query_SphereCastAll()
UnityEngine.PhysicsModule.dll!UnityEngine::Physics.SphereCastAll()
DMDASM.39357E4E.Cecil.dll!::DMD<HitShovel>?-1820379992._Shovel::HitShovel()
DMDASM.BD662577.Cecil.dll!::DMD<>?-1820379992.Trampoline<Shovel::HitShovel>?58948300()
Nyxchrono-DoorBreach.dll!Nyxchrono.DoorBreach::Hooks.Shovel_HitShovel()
DMDASM.56843B9D.Cecil.dll!::DMD<>?-1820379992.Hook<Shovel::HitShovel>?1832997512()
Assembly-CSharp.dll!::<reelUpShovel>d__14.MoveNext()
UnityEngine.CoreModule.dll!UnityEngine::SetupCoroutine.InvokeMoveNext()

[grand coral]

Yeah I took out ScanTweaks

I use no scanner mod now

[slim silo]

DoorBreach? That's unexpected

[grand coral]

DoorBreach I've seen error when trying to hit Snare Fleas

[plucky stump]

wait looks like it's game code causing allocation

[slim silo]

DoorBreach always worked fine with me never noticed fps drop

[grand coral]

WeatherTweaks shouldn't do that according to Mrov

If all progressive Weathers are disabled

[plucky stump]

MeleeFixes.dll!MeleeFixes::MeleeHelper.FilterDuplicateHits()
DMDASM.39357E4E.Cecil.dll!::DMD<HitShovel>?-1820379992._Shovel::HitShovel()
DMDASM.BD662577.Cecil.dll!::DMD<>?-1820379992.Trampoline<Shovel::HitShovel>?58948300()
Nyxchrono-DoorBreach.dll!Nyxchrono.DoorBreach::Hooks.Shovel_HitShovel()
DMDASM.56843B9D.Cecil.dll!::DMD<>?-1820379992.Hook<Shovel::HitShovel>?1832997512()
Assembly-CSharp.dll!::<reelUpShovel>d__14.MoveNext()
UnityEngine.CoreModule.dll!UnityEngine::SetupCoroutine.InvokeMoveNext()

MeleeFixes alloc a bit

[grand coral]

@languid raft ☠️

[languid raft]

there probably isn't much that i can do about that

or, at least, i would have to hyper-complicate my approach

[slim silo]

What is PlayerControllerBPatch from General Improvements

[languid raft]

im pretty sure the shovel already allocs by default anyway

[grand coral]

AutoChargeOnOrbit and OnlyAllowingOneLight as far as I'm aware

Possibly the Flashlight Fix integration itself

[slim silo]

Ah

Fine then

[plucky stump]

Hitmarker looks like instantiate UI stuff on every hit(?)

[slim silo]

I disabled anyway

[plucky stump]

that cause loaf API to kick in

[grand coral]

@hardy patrol Anyway you can optimize this?

I like Hitmarker but not enough for it to cause ui spikes

I guess I gotta part with it

[slim silo]

Blud is gonna blackmail every modder to optimize his mods 😂

[languid raft]

there is going to be alloc no matter what

some functionality just requires it

[grand coral]

Yeah

[languid raft]

it's just a matter of not over-allocating when it's not necessary

[grand coral]

Exactly

SoundAPI was causing lag due to this

Which that lag was recent for me

[grand coral]

I'm guessing with SoundAPI disabled HitMarker should be fine most likely

[grand coral]

The Energy bars should be fine, as far as I'm aware they only alloc when the Energy bars are updating right?

Basically while holding a flashlight or walkie

[plucky stump]

yeah

[grand coral]

Yeah they should be okay then, they probably alloc on the same level the vanilla ui does then for updating that

As long as it's not constantly allocating per frame or over-allocating lol

[grand coral]

The duality with this, performance drop or slightly more ram usage from configs

I guess slightly more ram usage for now is more ideal

[granite ravine]

true but i think for a lot of these cases its mostly string related and easy to modify to improve it

just due to all the non-alloc based string options available

[grand coral]

Yeah most likely

[granite ravine]

kind of a thing where it's not really a problem until it is

@plucky stump just out of curiousity not asking for any specific case, but are you familar with how unity's canvas dirtying works?

[grand coral]

@errant mulch I wonder if the Energy Bars need to alloc or if they can use a non-alloc based string option like Batby suggested

[plucky stump]

I only know the reasons of why canvas getting dirty, so no

[granite ravine]

thats kinda what i meant yeah

had to do a bunch of research on it last year

wouldn't be suprised if a lot of ui stuff, basegame and mods are triggering canvas rebuilds way more than they need to

[plucky stump]

iirc game uses Animator to animate some UI stuff

and animator is kinda bad for this due to causing canvas rebuild

[granite ravine]

from what i was told 2022 is recent enough to where that isn't a problem?

i could be wrong

i know what your talking about tho

at the very least tho it would be causing rebuilds of stuff in the canvas that isn't moving every keyframe tho which isn't ideal

[plucky stump]

Just checked and it still a problem

With Animator / Without Animator

[grand coral]

0190435b-dffc-b193-c94e-16ba61e936c0 My current pack if you wanna test it out

I took out Terbium and SoundAPI

I did test BetaTweaks with all the progressive weathers off again after that change and there's still some weird performance issues compared to StableTweaks so I let Mrov know about it

[hardy patrol]

Yeah, I probably can hehe x3

[grand coral]

🙂

[hardy patrol]

Real

[grand coral]

You might be able to use a non-alloc based string like Batby suggested

[languid raft]

im not doing string comparisons

[grand coral]

Fair

I mean if your mod is only allocating a little it probably won't really hit performance much

[languid raft]

FilterDuplicateHits is creating two empty lists (for IHittables and EnemyAIs), then returning it back to the shovel script before it calculates damage

[grand coral]

Ahhhhh

I mean I guess if people are really concerned about the allocation stuff you could make that patch a config option I suppose

[languid raft]

on each IHittable I have to check a boolean property (to see if it can actually receive damage) and then I have to check if it's an EnemyAICollisionDetect, and if so, check if that enemy wasn't already added to another list of EnemyAI (to prevent the same enemy from having two colliders registered and damaged)

the problem is probably me allocating two empty lists but I don't know any other non-complicated way to do that sort of work

[grand coral]

Hmmmm

Yeah that's why for the time being you could make it a config option I suppose

[languid raft]

i suppose, but is it actually causing a perceivable performance impact, in practice?

like, have you tried with the mod enabled and disabled and noticed a difference?

[grand coral]

Honestly no, idk if DiFFoZ did though

[languid raft]

that function* is what prevents shovels from dealing double damage to certain enemies as well as other players

[grand coral]

I've never noticed Hotbarplus causing performance issues either lol

[grand coral]

Yeah although for some reason it seems clients can still double hit enemies sometimes

Idk why

XD

[languid raft]

i havent noticed that issue but my friends havent played the game a ton recently

blame GSG cuz i've been mostly busy with DRG season 5 loll

[grand coral]

I almost wonder if it's a DoorBreach problem

[languid raft]

it's why this next buttery fixes update has been so fuckin delayed

[grand coral]

Since that's the other mod that really touches shovels

[languid raft]

maybe, it's not something i've used before so i'm not sure what it is doing

I tried to keep my changes relatively lightweight, the duplicate hit filter is the only part that should be causing issues, if any at all

but I think it would take a much more complicated approach to optimize what I'm currently doing with it

[grand coral]

Yeah I guess personally if people don't mind the bug a config option can be added, I never really personally minded Hoarding Bugs being 2 hits for example lol it was mostly the issues with players dying to 1 hit that bugged me XD

[granite ravine]

@languid raft A Hashset would be better for this kind of thing, no?

[languid raft]

possibly

i am unfamiliar with them

[granite ravine]

they don't allow for duplicates

[grand coral]

Ooh

[granite ravine]

im pretty sure trying to use .Add with a duplicate just safely fails

[languid raft]

oh that sounds perfect actually

[granite ravine]

faster lookups too

https://stackoverflow.com/questions/6391738/what-is-the-difference-between-hashsett-and-listt

[languid raft]

I need to update meleefixes to fix some bugs with the knife

[grand coral]

I was actually gonna ask if you had suggestions I'm glad you just popped in naturally cus I didn't wanna ping ya ^^

[languid raft]

it is worth clarifying that, regardless, I have to send a list back to the shovel function for it to iterate through targets

unless I use a transpiler to rewrite a significant portion of the shovel's damage logic

[granite ravine]

i don't think it would be a problem as it is right now but in theory you could collect the IHittable's in a hashset on a prefix to their creation or something too to avoid the tryget

yeah i don't know the context of whether any of this matters or not

[languid raft]

so making it a hashset and then using tolist (if that's supported) might make the benefit negligible

[granite ravine]

btw if your looking for more stuff to look at for your fixes mod there's a pretty gross findobjectsoftype call in AudioPresetTrigger that could be avoided by collecting references on a awake prefix

it looks pretty notable tbh but i haven't benchmarked it

[languid raft]

also, part of the problem is that I'm checking a separate list for duplicates - I'm not adding unique IHittables to the list that I'm returning to shovelHit(), I'm adding IHittables that point to unique EnemyAI instances

it is kind of a complicated approach

I think that a hashset might implement better into the shotgun damage pre-process in butteryfixes though

where I don't have to fool around with two separate lists

[granite ravine]

actually

[languid raft]

lol yeah zeekerss has a lot of find calls in bad places

[granite ravine]

if its being casted to a list anyway

i wonder if you could just cast it earlier then remove from it

then you don't need any new list right

[languid raft]

that's what im thinking about

right now, what I'm doing is creating a new list, then iterating through the existing list that gets passed into the function

mostly because that was just the simplest way to do it

I think that I could sort of easily fix that by instead just removing stuff from the original list, which would reduce some of the allocation

[granite ravine]

yee

[languid raft]

although the shovel's targets are sorted by distance, and removing from the list would require iterating through it twice, or iterating through it backwards (meaning i need to reverse the sorting of the list)

[granite ravine]

why?

[languid raft]

or wait

I think I'm getting my wires crossed

[granite ravine]

sorted means sorted homie

[languid raft]

well, removing from a list in the middle of a foreach iterator is bad

[granite ravine]

2m, 5m, 7m

if you remove 5m it's still gonna be sorted right

[languid raft]

but I think a for loop is fine

[granite ravine]

you can just for loop it then use RemoveAt(i)

[languid raft]

I'm pretty sure it's already a for loop as-is

yeah

RemoveAt should be fine

[granite ravine]

the conversation is funny tho

because this is all probably worthless compared to the findobjectsoftype call it uses for the sound thing

[languid raft]

well

I do replace a dumb FindObjectOfType<RoundManager> with RoundManager.Instance

[granite ravine]

ye

[languid raft]

for the shovel's audible noise

I didn't look too deeply if there's anything else I could replace like that

relating to the shovel

[languid raft]

what are you referring to here?

i'm not seeing AudioPresetTrigger anywhere

[granite ravine]

my b

audioreverb

AudioReverbTrigger.ChangeAudioReverbForPlayer()

[languid raft]

ah

i was going to say that seems probably ok, since it only happens with teleporters (entrance doors or actual teleporter furniture)

but it apparently gets called every physics timestep by AudioReverbTrigger.OnTriggerStay

So!!

[plucky stump]

I will try to optimize it 👍

[granite ravine]

you'd just have to manage your own list of them via patches on awake and ondestroy

[languid raft]

will probably move further discussion back over to my thread, but just to follow up on earlier convo, new version of meleefixes utilizes a hashset and removes items from the initial list rather than allocating 2 empty lists, which should minimize performance impact as much as possible

still need to add some fixes for the knife and test that everything works ok with the refactor before i can release it tho

[grand coral]

Looking forward to it 💜

[azure rune]

I mean two empty lists being allocated when you hit an enemy is basically nothing

[hardy patrol]

@languid raft I knew there was something weird with how enemies take damage especially hoarding bugs since my Hitmarker mod shows that two hits were registered when hitting once

It's really weird

[languid raft]

yes many enemies have multiple colliders attached to the same hit detector

and each one will call the damage function

[hardy patrol]

That's also why I removed hit detection from players because it was showing 4 messages

[languid raft]

players are kinda even dumber

players only get hit twice but the damage function gets called twice by each hit

[hardy patrol]

Someone should report this to Zeekers if nobody has already

[languid raft]

which is why you take 4x damage

and also why it ignores "death resistance"

[languid raft]

this bug, im nearly certain, is also why "Sustained the most injuries" desyncs in multiplayer, btw

at least it is one of the reasons

[hardy patrol]

Okie

[tulip fjord]

@plucky stump Hey are you cool with sending me a friend request? There's something I'd like to ask in dms, sorry for disturbing if you're busy lol

(Dms locked and friend requests locked lol)

[grand coral]

@hybrid finch It's been a while since you updated DoorBreach, but maybe you can look into fixing this c;

[plucky stump]

щзутвув вь куйгуыеы

buh

[plucky stump]

sent request

[plucky stump]

if other modders looking at this thread, probably look at ZString library
https://github.com/Cysharp/ZString

here that lib on thunderstore
https://thunderstore.io/c/lethal-company/p/dotnet_lethal_company/ZString/

And also at Unity ListPool implementation

fyi all HDRP rendering is just get the list from the pool, do something and return the list to the pool

[hybrid finch]

maybe

no promises, I'd have to download the latest vers of the game and decomp and figure out what I gotta do to make it work again

[grand coral]

I mean the mod works it's just more so fixing that issue lol

There's also been a long standing issue where if you try to kill a snare flea while it's on your head with a shovel you can't and DoorBreach gives an error

lol

[hybrid finch]

ok that one confuses me. Zeekerss must've made some big changes

[grand coral]

https://thunderstore.io/c/lethal-company/p/4902/No_Console_Spam/ @plucky stump thoughts on this mod? ;o

[plucky stump]

https://tenor.com/view/try-it-and-see-give-it-a-try-try-try-and-see-try-it-yourself-gif-24095805

[iron edge]

why can i hear the text

[steel quiver]

lmk if you ever test that

[next nymph]

If only Zeek learned from this

[hybrid finch]

https://tryitands.ee

[earnest turret]

hey so I grabbed the code to see if I could improve my modpack based on any of your configs and...
Lunx where's the console?
What did you do to it? Did you eat it?

[next nymph]

You probably have to reenable to via Bepinex's config file

[earnest turret]

yeah seems like it lmao

thanks a lot

[next nymph]

Yw

[earnest turret]

btw do you guys know which sounds are the most taxxing in terms of ram usage for lethal resonance?
I already disabled footsteps and ambient sounds

[hardy patrol]

They ate it x3

[primal radish]

yummy ram :]

[grand coral]

LR isn't really the issue atm it's SoundAPI itself

[azure rune]

I don't think it should be causing high ram usage, since those strings are noy kept in memory for very long. It's more a performance problem due to the garbage collector having to scoop them all up

[grand coral]

LR is what increases ram, SoundAPI causes performance issues

[grand coral]

Btw please update LR to remove the reused Vanilla Sounds like the Breaker Box sound when you can

So it's not wasting extra ram just for a sound reused from the base game XD

[steel quiver]

hey @grand coral what’s your current profile code for lethal!

[grand coral]

Later potentially, I think I'm gonna full on remove GeneralImprovements from my pack

The Terminal patch likes to nuke itself sometimes

This one specifically, and @abstract gate has stated it can't be disabled

[slim silo]

any mod that does the SnapObjectsByDegrees?

[languid raft]

"SnapRotateFurniture"

[grand coral]

Dunno, I use LethalPipeRemoval to have a set position for the Terminal and Cabinet

[languid raft]

controls are different but it still works

[slim silo]

ok, and LockCameraAtTerminal?

[languid raft]

unsure

there's too much stuff in generalimprovements for me to want to disable it

[grand coral]

Yeah from what I understand that Terminal Patch can be disabled I think

I need to test though

[languid raft]

you can disable the auto-adjust credits

and the code causing this exception will be skipped

[grand coral]

Yeah it needs to be set to -1