🔱 Enhanced Monsters

[wooden copper]

Good question

[heavy linden]

Quick question, is there a way to heighten the chances of the Nutcracker dropping a shotgun?

[wooden copper]

disabling "pickupable" in the Nutcracker enemy data

[heavy linden]

Thank you 😁

[wooden copper]

For now that's the workaround
I'll work on reimplementing loots soon

[digital mural]

I just hope you can figure out why the bodies disappear for clients when they're set to not be able to be picked up lol

[wooden copper]

That's indeed a very weird thing but I think I know why

[digital mural]

Hoping you might get a fix out soon, cus your mod allows the game to boot quicker compared to SellBodies

[wooden copper]

eeee

hopefully

[still beacon]

does it impact loading that much?, I've never seen it cause excessively long loading times. maybe it's just an issue with large modpacks?

[digital mural]

It's not excessively long, just slower probably cus of the large assetbundle

[cyan cloak]

It takes about 3 seconds on my end, I don't think there's any issue with the mod

[digital mural]

That's still a lot to add to boot times when you have a lot of mods lol

[wooden copper]

It's more than my mod then yeah

It makes sense as the corpses are generated during the game, and not before the game start

[hybrid cloak]

oh yeah we just played this mod the other day

and that client side creatures thing is a huge problem

[wooden copper]

Really ? It didn't happen to me during my previous gameplays

[hybrid cloak]

It happened throughout the game

I personally didnt see it cause i was the host

[outer hare]

the manticoils doesn't have a death animation, so it's death state is the idle animation

[hybrid cloak]

theres also a huge error in the model of the spider

like

css error in gmod

[karmic nest]

wait huuuuh?

[outer hare]

the "Spider"?

[karmic nest]

what is this?

[outer hare]

that's the "Arachnophobia" mode

[hybrid cloak]

they are in each other

like

next time ill see it ill show u

[outer hare]

yeah

It's bugged

[hybrid cloak]

https://tenor.com/view/dexter-gif-13481320143050343709

[outer hare]

althoualthough I thought they had fixed it

[hybrid cloak]

nah still broken

idk

cool mod tho

[austere ermine]

They do

It's just bugged

I remember seeing it before v45

They would flip backwards on their back like snare fleas upon death

[outer hare]

oh

[austere ermine]

Idk why of all things from pre-v45, this is something I remember distinctly of it

[hybrid cloak]

it was the best version?

[austere ermine]

Absolutely not vro

The current version we have rn is definitely the best

Sure, it's nostalgic, and I have fond memories of it, but I'd be taking to piss to say it solos over v60

[hybrid cloak]

any version with rail cheese and titan jumps are good

[austere ermine]

Titan jump

What is this?

Rail cheese
cheese
Skill issue

Even so, you can just reenable it with ButteryFixes

There, there's your golden era of Lethal Company back, I guess

But it ultimately had to go for the greater good, whether you like it or not

I long for the day jester and coil-head trapping is patched

[hybrid cloak]

look up lethal company my way

[austere ermine]

Why can't you just explain it

[hybrid cloak]

#fixmanticoil

[wooden copper]

Well arachnophobia works on my machine

I guess I'll have to check out what's happening, good thing I'm on vacation next week

[wooden copper]

That's weird, the arachnophobia works on my end

[long wraith]

@wooden copper Do you not remove EnemyAI compoment when creating prefabs? I checked and it doesn't from what I see.

[wooden copper]

No the enemy ai components are removed

What I do is that I search for all gameobjects with an enemy ai components in game resources, I load it, and during the copy I skip some gameobjects and remove some components

[long wraith]

I see.

It would be funny though if my mod made slimes eat dead enemy corpses but I haven't tested interactions with this mod and sellbodiesfied yet.

And I wan't them to just for Lunxara.

[wooden copper]

Shouldn't be too hard to interact with my mod tbh

It works basically the same way than standard items

The enemy scrap names are all the same

And simple way to find dead mobs

I have a specific component class "EnemyScrap"

[long wraith]

I assume I can search for objects with that compoment

[wooden copper]

Sure

You can make soft dependencies

I already showed how to do that

I recommend making a static inline method for implementation tho

[long wraith]

Do you save the instantiated scrap into a list or you just instantiate them?

[wooden copper]

[MethodImpl(MethodInlining.ForceInlone)]
public static MyMethodWrapped()
{
  if(DependencyLoaded)
    MyMethod()
}

[wooden copper]

Ehmm

No I just instantiate them and the game does its stuff

[long wraith]

k thats all I need

[wooden copper]

That said you can probably just add a patch on the method I use for their instantiation

But, within a soft dependency

[long wraith]

actually youre right I dont need to search for the objects.

[wooden copper]

Searching for objects is extremely expensive

[long wraith]

Yeah it should be only done when you have no other alternative.

Only time I use it is to generate config on booting up. I then either copy already existing lists or add them to a list when they're created

[wooden copper]

I c I c

[outer hare]

try killing one manually

It may be a Imperium issue

[hybrid cloak]

No ive seen it without imperium

Maybe its one of imperiums dependecies, idk

[hybrid cloak]

u should make it compatible that would be fun prob

@wooden copper what are the prefab names for the ur scrap items anyway

[wooden copper]

Dead {mob name}

[hybrid cloak]

so like this?

or no spaces?

[wooden copper]

Some have spaces some other don't

The prefabs are the original mob name with "Dead " before

[median beacon]

I have here an image of my config, as far as I can tell, it's an exact copy of Flamsey's plus some other entities from my modpack. Despite this, I still can't place any dead entities in the Meat Grinder. So far I've tested the dead Manticoli and Dead Hoarding Bug. Did I do something wrong?

@wooden copper

[wooden copper]

Hmm I'd have to check in game with Unity Explorer, I'll do that tomorrow, please ping me so I remember to do it

[hybrid cloak]

Use SellBodies. The spider doesnt fucking work

You see the spider in arachnophobia mode for like a split second

When u pick it up

And it glitches with arachnophobia off

[median beacon]

@wooden copper Reminder.

[wooden copper]

Thanks I forgot about it

I'm doing that when I'm home in a couple minutes

[median beacon]

Alright.

[wooden copper]

Works on my machine

Might inspect that but it works on my machine so far

[wooden copper]

Okay sooo

DoublewingedBird propized

@median beacon that's the PREFAB NAME of the dead manticoil

HoarderBug propized

for the hoarding bug

these names are all generated at runtime, that's why I don't know them

PufferEnemy propized for the spore lizard

Centipede propized for the snare flea

BaboonHawkEnemy propized for the baboon hawk

[wooden copper]

Yeah okay so I figured out what's happening

workaround: pick it up and drop it

MouthDog propized

[median beacon]

Where can I find a list of all these names? And how would I go about finding them for modded entities?

[wooden copper]

You'd need UnityExplorer and have at least one of the dead bodies spawned in the game

then you'd have to navigate to find it

that's what I did right now

Otherwise, it's original prefab name + propized at the end

[median beacon]

Great, thank you so much.

[hybrid cloak]

Or i just use sellbodies until this mod is overhauled

[wooden copper]

that too

if you're too picky yeah

[hybrid cloak]

nah its just that my friend is deathly afraid

its so crazy

ive never seen anything like it before

[wooden copper]

Hmmm

[wooden copper]

Maybe it's not the best idea to play horror games then

[median beacon]

@wooden copper Apologies for the bother, but I have one more question: what do you mean by "propized"?

[wooden copper]

It became a prop

That's just the name

name of the prefab + "propized"

[digital mural]

Hey out of curiousity are you still planning to fix the issue of bodies disappearing for clients in Multi if they're set to not be picked up?

For me it mostly happens with Masked and Nutcrackers

[wooden copper]

Masked is not changed by Enhanced Monsters yet iirc

And Nutcrackers, I'll see

[digital mural]

It's a side effect I think, it's any enemy body that's not able to be picked up

[digital mural]

@wooden copper I imagine it's just a side effect of the pr Entity gave you a while ago to fix the client desync issues, probably a missing check for if the body is set to not be picked up to not teleport it for clients most likely

Since it's any enemy that's not able to be picked up, whether that is masked Bodies, Nutcrackers if turned off, etc

@still beacon I would imagine it's just an if statement or something that needs added right?

[wooden copper]

I'll check that

[wooden copper]

Is it really only specific to those two entities ?

[digital mural]

I think it's just any entity that's not able to be picked up, it's just in my pack it's only Masked and Nutcracker bodies lol

[wooden copper]

that's really weird

[digital mural]

Yeah I think there's just a check missing so the body gets tped away for clients even when they're set to not be picked up, cus they're fine for me as host lol

Probably an easy fix that needs to just look for the config value I'd assume

[wooden copper]

Yeah I really don't know as I never experienced that, I just simply can't visualize what you're telling me, I'll have to try it with someone cus in local it worked correctly

[digital mural]

I reproduced it in Lan

with 2 clients

for me as host the body would spawn, but not for the client

[wooden copper]

Hmm

I'll check both with my mod only AND with your modpack

it may be a conflict idk

I may know where this come from IF it is due to a conflict

[digital mural]

I would be curious lol, cus SellBodies doesn't have the issue

[wooden copper]

Yes that'd make sense

[digital mural]

Did you ever manage to look into the issue at all?

[wooden copper]

no busy with the exams of the end of the year

[digital mural]

Well I've decided to regen the config and noticed that some of the offset and rotation values and stuff are different from before, wonder if that might fix anything lol

[wooden copper]

Honestly I don't know lol

Maybe yes

[hybrid cloak]

Rip this mod broke lol

[wooden copper]

I'm gonna fix it then

It's good to know i'll have to inspect at least to make it work again

[wooden copper]

I'm very happy that i've reached 70k downloads for the mod on Thunderstore, it's insane

I'll definitely make a patch very soon

[digital mural]

I look forward to it, while I've been enjoying using SellBodies in the meantime while waiting for you to fix things the weird parenting stuff it does bothers me

[wooden copper]

Yeah I'll try but I never experienced such issues personally that's why I'm skeptical

[digital mural]

idk why the bodies that can't be picked up bug out on clients

I should test if I can repro it on a Test build of my pack I have made a lot of changes

@wooden copper I see why

Apparently on the client an ownership rpc error throws

What I see as host

Client doesn't see them

[wooden copper]

oh I see

pretty simple fix

I'll fix the mod for v70 and fix this issue as well

[wooden copper]

hold on

masked are not supported by my mod yet

[wooden copper]

this is the client's side right ?

[digital mural]

Yeah

And that same thing is probably why when Nutcrackers are set to not be picked up also is why they vanish for clients

along with other enemies when it's disabled

[wooden copper]

Hmm

there's nothing I see that could trigger such errors

Hmmm

this should prevent the rest of the code from running

I don't understand why this happens but doesn't prevent the mob to "be"

[digital mural]

I'll add BetterServerRPCErrorLog and see if it explains what's happening

@wooden copper

maybe this helps

So it errors on the UpdateEnemyPositionServerRPC on clients, so the body is never spawned when it's not set to be picked up

[wooden copper]

interesting

good to know alright

lmk if this works @digital mural

[digital mural]

Will test it as soon as I have the chance

[digital mural]

@wooden copper Yeah this fixes it

So you should be good to push this update

c;

[wooden copper]

Does it work on V70 ?

[digital mural]

Yes

I was testing on v72

current version

No idea if you wanna add compat with the new enemy though in some way

that might be some effort

lol

[wooden copper]

I have never met the new enemy so idk how it works

[digital mural]

Fair

[wooden copper]

I'll release the update today when I'm free

[digital mural]

Alright

[wooden copper]

I'll also inspect the arachnophobia thing

[wooden copper]

Fix 1.3.10

See changelogs.
https://github.com/VELD-Dev/Enhanced-Monsters/releases/tag/1.3.10
https://thunderstore.io/c/lethal-company/p/VELD/Enhanced_Monsters

[long wraith]

The new enemy seems to technically work with the mod but death animation doesn't play and a red box, probably collider, appears when you pick it up.

[wooden copper]

I hate when this happens

[still beacon]

I guess I'll have to recompile every single one of my mods too, if I remember correctly that error is caused by a new enemy being added

[wooden copper]

that one is due to my mod having bad sync code

[digital mural]

SellBodies works fine although it doesn't register anything for the new enemy if you manage to kill it

Not even a custom body drops it drops nothing lol

[wooden copper]

Does the new update make Enhanced Monsters suit your gameplay requirements @digital mural ?

[still beacon]

This confirms that it needs to be recompiled. Sellbodies has an internal list of vanilla mob names and treats them as such, if it is not in that list and is not in the blacklist it defaults to a drop of modded enemies

[digital mural]

Yeah, idk if any of your other mods need recomps but it doesn't hurt to check I suppose

I imagine it drops nothing for the bird cus it tries to find a drop for a vanilla enemy

[wooden copper]

btw @still beacon I have installed your Arlecchino's hast weapon mod but I never found it in game

[dire grail]

Does this mod work? I plan to add it to my modpack if it does

[digital mural]

Yes

[wooden copper]

the update I just released fixes it for v70 and fixes a bug that was occurring in the v1.3.9

[dire grail]

So there's also no issues?

[wooden copper]

i'd not say there 'no' issues

but it's honestly playable

[dire grail]

Oke thank you I'll be using this from now on

[wooden copper]

I'll soon release an update that allows custom drops on enemies

and it will reimplement correctly the nutcracker's drop

[dire grail]

That's nice i guess that's for modded enemies to have their own drops like the Nutcracker

[wooden copper]

yeah and it's fully configurable

and the configs synchronize when you connect to someone btw

So like the custom ranks you have on your end for enemies will be the same on other's POV

Rank is the most useless feature of this mod yet one of the ones I prefer

[dire grail]

It's actually pretty useful if the money the bodies give depended on the modded monsters rank

[wooden copper]

it's not really how it works

You can set whatever value you want, but the rank can give a hint on the value of the monster

it does not depend but that's how it's configured by default

[still beacon]

The scythe has a rarity of 10, but you can buy it in the shop for 378 credits.

[wooden copper]

oh fr ? dang

I'll continue to look for it then :p

[dire grail]

close enough

Still a good feature

[wooden copper]

👍

[long wraith]

There is a bug that makes Circuit Bees killable by Giant Sapsucker. Haven't tested other combinations but pretty sure the mod makes unkillable enemies killable.

Found it: https://github.com/VELD-Dev/Enhanced-Monsters/blob/74c82de7c1cf948df1632b1effc0f28f9470047a/Patches/EnemyAI_Patches.cs#L41-L44

That's big oversight in design as if an enemy suck as Sapsucker directly calls the method it will set the enemy as dead regardless if the enemy would be dead without this code.

Not sure what the intent behind it is

[wooden copper]

ah yeah that's right

[wooden copper]

Zeekers moment

I'll fix that

[midnight quiver]

whats the point of this code?

this probably messes with some of my code, forcefully setting the enemy to dead at a killenemy postfix

[wooden copper]

just a check in case

[midnight quiver]

no im just confused why you're setting isEnemyDead to true

[wooden copper]

Idk it was just in case

I'll remove that then

[long wraith]

the only purpose I can think of is to force immortal enemies to die but that could've been done by setting in it's enemyType canDie bool to true.

[midnight quiver]

please dont do that either

[wooden copper]

yep

[hybrid cloak]

could there be melanie farm and cooking support in the next update?

i cant figure out the prefab name

[digital mural]

Lmk when the update goes live that patches that out lol, since it sounds problematic

[wooden copper]

Soon

[wooden copper]

like I make the support myself ?

[pine sinew]

Nah Melanie has to make the support, I already told them abt this mod

Right now their cooking mod only supports SellBodies which I assume handles things differently than your mod

[digital mural]

Veld has already been talking to Mel about it lol

[pine sinew]

I'm seeing it right now

Going through my wake up scroll

[digital mural]

yeah I did the same after waking up

[wooden copper]

I'll find out no worries

[wooden copper]

Alright I have added the support

It should work now

maybe

can any1 ping me if they're down to test it now ?

or up to test it now, I never know how you say in english

So yeah if anyone can try this new version :p

(with and without MelanieMelicious' Farming & Cooking mod

[wooden copper]

Well I think I'll release it

Fix 1.3.11

https://github.com/VELD-Dev/Enhanced-Monsters/releases/tag/1.3.11
https://thunderstore.io/c/lethal-company/p/VELD/Enhanced_Monsters/

[coarse sphinx]

Could you add a config to disable the ranking feature when scanning?

[wooden copper]

??

Why ?

I guess I could add that when the Rank field in the config is empty, then it's skipped on a mob

But why would you disable it ?

[coarse sphinx]

I just like when people have to check the bestiary to see how dangerous a monster is

[wooden copper]

hmm

skeptical hmm

[coarse sphinx]

it still has the rank text and the box

[wooden copper]

i said "i guess I could add"

[coarse sphinx]

ok thanks

[wooden copper]

will be implemented in next update

[hybrid cloak]

Idk i tried using the config for melanie's but the prefab names unityfinder was giving me didnt work

@wooden copper does the manticoil have its old death animation back?

[wooden copper]

I have not changed that

Ans the melanie mod should work now

[wooden copper]

Fix 1.3.12

https://thunderstore.io/c/lethal-company/p/VELD/Enhanced_Monsters/
https://github.com/VELD-Dev/Enhanced-Monsters/releases/tag/1.3.12

I have added this to the README by the way

[outer hare]

Cool!

[wooden copper]

it was already possible before but I did not explain how to do it

Now it's documented

[outer hare]

Sorry for not testing a lot this, I've been... Busy, with other things :']

[wooden copper]

No problem !

I've seen really cool stuff in #mod-showcase :p

[outer hare]

Thanks! We are trying to do our best on that

[wooden copper]

Perfect, now I will start working on a proper implementation of mob drops !

It's time to backup your custom settings folks !

[wooden copper]

Can't wait to test that mod 😮

i'm ashamed

Yep well the changelog file will be fixed in next update

[coarse sphinx]

@wooden copper

its still not working even with the update

[wooden copper]

Hmm

you are the host right ?

[coarse sphinx]

yeah

[wooden copper]

I don't see what could cause that then

it should work

[coarse sphinx]

019764a7-aaf9-259b-beb5-464f2b7a77d1

[wooden copper]

So I don't see why it does not

[wooden copper]

no mod should change this behaviour

it's from Enhanced Monsters

I just don't see why it happens

[coarse sphinx]

oh

[wooden copper]

Inside the config, you've set the rank to "" right ?

not " "

[coarse sphinx]

yeah

oh wait

I think that it may have not been updated

hold on

[wooden copper]

sigh

alright

going back to the new features

1.3.12

[coarse sphinx]

it works but there is still a empty red box

[wooden copper]

The box have always been there Jori

I just decided to use it for my mod

but it have always been there

[wooden copper]

75k total downloads 🎉

(the fact that I have released LOTS of updates helps a lot)

[digital mural]

@wooden copper Seems the bug where bodies don't disappear for clients is back

lol

after they're picked up the original is there

[wooden copper]

ah if it's just that

not a big deal

it's playable at least

that's because only the host is setting the position now

¯_(ツ)_/¯

[wooden copper]

Yeah I have experienced the bodys it's quite disturbing in game even if it's totally playable @digital mural

I'll definitely fix that soon

[digital mural]

Okay ^^

[wooden copper]

i have never played Lethal Company with anyone else than my highschool buddies and Monoxide, I'll maybe hop into https://discord.com/channels/1168655651455639582/1207001561109241886 someday

[digital mural]

Do you have any idea why it happens? Cus iirc Entity's pr was supposed to fix it but then that led to bodies that can't be picked up being unable to be seen

[wooden copper]

Yes basically the solution of Entity creates this big but makes original bodies disappear while my solution fixes that bug but causes bodies to be duplicated again

[pine sinew]

i don't think scrap e is a candy dispenser

(in reality, it seems his body disappeared when he's dead)

[wooden copper]

🤔

Looks like the body is under the map maybe

[obsidian sail]

pre-buried

even cleans himself up

[wooden copper]

lmao

[dreamy coyote]

what's the main difference with this mod and sellbodies?

[pine sinew]

this mod works with modded enemies

[wooden copper]

It also have a ranking system and is much more configurable

[wooden copper]

@still beacon do you know if I'm forced to use SyncPositionToClients() to sync pos ?

I guess that you might know a little bit of that since you're the one who made that pr back then iirc

I don't understand why it doesn't work properly

[still beacon]

I don't understand completely that function either, I only know that it has to be executed by all players to ensure that the body placement is correct after you move it

If you don't execute that function for all players sometimes the enemy get desync

[still beacon]

I know it's late to answer but, the two mods have the same goal but in terms of how they work they are completely different. Sell Bodies spawns custom props while Enhanced Monsters uses and generates props dynamically. Both mods are valid and you should choose based on your preferences. In my opinion Enhanced Monsters is better than Sell Bodies (and I am fully aware that I am shooting myself in the foot by saying this)

[digital mural]

Enhanced Monsters is better but currently has a few bugs/issues that need addressed. Stability Wise SellBodies is still a bit better til then

And no your opinion is valid since you don't have as much free time anymore

[wooden copper]

Sell bodies is more stable in the current state though

[dreamy coyote]

If it works for biodiversity it serves the purpose I need, although I will say sell does fixed has a cute feature I wish was carried over (dead tulip snakes becoming pale)

[wooden copper]

The dead manitocoils can be held and they look like they're your pet

I was asked to add this by Lunxara or Moroxide

[digital mural]

Moroxide probably I was wondering why they weren't actually dead lmao

[wooden copper]

Yeah

[hybrid cloak]

Can u turn this off

I want roadkill

[wooden copper]

There's no death animation for manitocoils so no

U can try to disable that yourself with the config but tedious

[hybrid cloak]

K

But then how does this image exist

[wooden copper]

That's with sellbodies ?

Can't remember if that feature is with manticoil or the other birds

[outer hare]

I actually asked about the rotation of the creature, I assumed the manticoil didn't have a dead body and was that way by default, so I asked to change the rotation to make it look like you had it as a pet.

But yeah, I may be to blame for not having explained myself well, dw

[dreamy coyote]

so for example if I wanted hoarding bugs to drop a scrap on death instead of as a body would it look something like this?

[wooden copper]

Erm

I mean

It would look like and something like that, i think approximately is appropriate, but in anycase, this feature is not implemented yet.

[dreamy coyote]

oh, okay

[shut umbra]

how do i do this again

[wooden copper]

it's better to check in game

like with Unity Explorer

[shut umbra]

oh yea that thing
here we go...

[digital mural]

@wooden copper Mod breaks when paired with latest Code Rebirth

Fixed it by disabling the Shrimp Dispenser

Odd

I don't see why Enhanced Monsters is hooking into this method anyways though

[wooden copper]

Which one ? Currently on phone for this weekend

[digital mural]

Tbf this actually might be a ReXuvination issue

[digital mural]

@wooden copper I see the issue here

Enhanced Monsters is trying to register one of the weathers as an enemy

[wooden copper]

Ugh

Tornados are also registered as enemies but they have no specific tag telling that they're not actual enemies

Hard to identify them

[midnight quiver]

they should have everything an enemy needs, the problem is that you're checking stuff before StartOfRound is created and i access startofround in QuicksandTrigger.Awake patch

i can update rexuvination to null check for startofround but its a bit iffy

[wooden copper]

It works with almost every enemies, it seems to be very exclusive to few weather elements, cus it even works with the tornadoes

[midnight quiver]

yeah Hurricane is an enemy that contains a QuicksandTrigger component inside it

which i patch with my other mod Rexuvination

so im releasing a fix on Rexuvination that null checks startofround.instance

[polar berry]

red cube sapsucker jumpscare

[wooden copper]

wait that's weird it wasn't doing it before

oh well maybe it was

I never killed one

[pine sinew]

dead maneater

looks a bit weird

[wooden copper]

Yeah, known issue

Quite annoying problem that is quite complex to fix

[still beacon]

I don't remember exactly how the mod works but isn't it enough to check all the objects (even the children) to see which are visible and which are invisible?

[wooden copper]

I can't really make something that checks for MeshRenderers

Because they use exactly the same script as standard mesh renderers

[coarse sphinx]

@wooden copper Has this mod been updated for v73?

[wooden copper]

Not yet

I'll make a quick update when I'll be in vacation

[still beacon]

It should actually be quite simple, just delete all the components that have a disabled meshrenderer or that are not visible based on the Camera.main cullingmask when you generate the prop

[wooden copper]

issue is that they are disabled at runtime it seems

And even then, it may break compatibility with arachnophobia mode

But there's probably something to do with that yeah

[still beacon]

I did it lol

It took longer than expected but I was sure it could be done

[wooden copper]

Oh okay, impressive

Did you make a PR ?

[still beacon]

Not yet, I wanted to see if I could fix a problem the Kidnapper Fox is having. I'm not 100% sure, but I think the base instance is "compacted" to a point because it doesn't have animations.

[still beacon]

I didn't find the time to fix the Kidnapper Fox issue in the end, so I made the PR with the possible "fix"

[coarse sphinx]

Any status update on this?

[still beacon]

one thing, since you ask, would you like to try the recompiled version of the mod for v73?

[coarse sphinx]

Yes ofc

[still beacon]

besides being recompiled it also has the possible fix that removes the "cubes" from the item meshes

I only tested with the cave dweller and it seemed to work

[coarse sphinx]

Yeah it works

[wooden copper]

Not yet

[coarse sphinx]

The version Enity has seems to work in v73.

[wooden copper]

I appreciate your contribution @still beacon ! 😄

[coarse sphinx]

just tested

[wooden copper]

Nice !

I'll merge when they make the PR and make a new release

[still beacon]

i made the PR 5 days ago

[coarse sphinx]

I dont see the netcode command updated in the .csproj

[wooden copper]

I'm sorry. I didn't check 💀

[still beacon]

Because from what I've seen, this mod doesn't use the netcode patcher. Furthermore, it wouldn't be necessary to modify the code anyway; it would be enough to apply the netcode patcher with the right parameters to the command.

[coarse sphinx]

So then why was it broken in v73?

[still beacon]

idk I have no one to try multiplayer with

99% of the time you just need to recompile the mod and that's it

[coarse sphinx]

it seems they use a rpc here

{ [HarmonyPostfix] [HarmonyPatch(typeof(MaskedPlayerEnemy), nameof(MaskedPlayerEnemy.KillEnemyServerRpc))] private static void KillEnemyServerRpc(MaskedPlayerEnemy __instance, bool destroy) { Plugin.logger.LogInfo("Hey. Spawn a mimic mask. now."); }

[coarse sphinx]

The mod is working in v73 just tested. The only thing that is not is the masked mask which is because of the netcode.

[still beacon]

This is not a custom RPC, it's simply a patch of an existing RPC of the game (so you don't need the netcode patcher anyway)

[coarse sphinx]

oh, so then it was already v73, lol

[wooden copper]

1.3.13

https://new.thunderstore.io/c/lethal-company/p/VELD/Enhanced_Monsters/

Thanks @still beacon for your contribution by the way

[outer hare]

Hey!
I'll test it soon!

[wooden copper]

👍 thank you 😄

[wooden copper]

Is there any issue with syncing ?

[outer hare]

I've not been able to test this with friends

I'll try to do that soon

[wooden copper]

Have you been able to test ?

[polar berry]

hey came back to this mod for the 6th time and I'm happy the gray cube is gone from the maneater!

But all the enemies bodies are completely not there for any of the clients. (idk if its a mod confliction or what)

Log from the session (I was the host, I'll bring my friends log over in a second)

[wooden copper]

What ? I'll try to check the logs asap

Thanks for your reports nonetheless !

So wait, there were not any enemy body ?

Wdym

Normally there shouldn't be conflicts with any mod except SellBodies, as we patch the same functions

[polar berry]

As the host I can pick up their bodies, but as the client you can't even see the body in the hosts hand, it's not even an item for them. I'll double check later today. (Could be because I changed some of the data in a folder for enemy pricing and grades without sending to the client.)

[wooden copper]

Ah so there are sync issues

Hmm

[polar berry]

the issue might be on my end. I'll test it out with my friend later today.

I was just wayy too tired to handle it or figure it out on that day 😭

[wooden copper]

No worries, and I really think it comes from the mod tbh

This is not meant to happen

So yeah I think the networking is failing, I'll have to inspect

[wooden copper]

My studies have been exhausting, I'm afraid even during my vacation I won't be able to work on the mod 🫡

[real void]

I have a question, why when killing monsters and picking up their bodies, after dropping they disappear

[wooden copper]

They probably have their models under the ground

That's a known issue for modded monsters

[real void]

Yeah, that seems to be the problem.

[real void]

Then I will use Sell Bodies until it gets fixed

[wooden copper]

I don't know how to fix that xd

The grab collider should still be above the ground tho

Somewhere

The best way to fix it is to see if other people modified the config file to fix the enemy model position

[real void]

I was testing solo

[wooden copper]

No what I meant

Is to ask to other players here

If they have a config file with fixed transforms for the monster that has the problem on your side

[wooden copper]

Please check out my new mod

#1463096427965059103

[hybrid cloak]

@wooden copper r u coming back to fix the spider at some point?

[wooden copper]

I honestly don't know how to fix that, the complexity to fix it is downright absurd considering how many actions are required to fix this, thanks to Zeeker's code.
The weirdest thing is that the arachnophobia mode used to work, at least when I tried it

I will look into it an ultimate time but I can't guarantee anything

[hybrid cloak]

ty

[hybrid cloak]

was the creatures only being hostside fixed?

[wooden copper]

Possibly

[hybrid cloak]

Spoiler alert: it was not

[fresh relic]

does anyone know if the mod is broken or not? when I try to use it it is completely dysfunctional, no features working. the enemies file is also missing aswell as the config folder. when I try adding it back the mod still doesn't work despite having the proper path to the config.

I've tried reinstalling and rebooting the game and nothing has worked to fix it.

[wooden copper]

Might be an issue with v80

I'll recompile the mod when I'm home this weekend

[hybrid cloak]

V80 came out???!

[pine sinew]

no

[wooden copper]

then I don't know why it doesnt work

cus it works for other people including me, to some extent

without the logs it's hard to tell what the error comes from

[hybrid cloak]

its only hostsided though which sucks

[wooden copper]

Hmm that's still weird as it used to work on my end

Unfortunately, I'm really too busy to check these days

[wooden copper]

Thanks to @novel loom I have found out about the bug as he's the only one who provided me logs with bug issues

Apparently with v73 the prefabs don't register correctly

[pine sinew]

oh mr veld if youre working on this mod there another little issue i noticed

the sounds for dropping the dead bodies are global

just wanted to let you know abt that before something gets pushed

[obsidian sail]

oh hell yeah

about finding out the issue, not about the global dropping sounds

[wooden copper]

customizable

you can customize it

it's in the config files

oh ye mean

Like

okay i see

The audio source ?

[wooden copper]

I believe it's a LethalLib issue

Was it recompiled for v73 ?

my game won't run, it's locked in the logs ;-;

aight it was just taking its life

anyone down to try the mod ?

I need to do many tests to fix

Wait

they never were registered 🤔

oh I thought it was behind the scenes with RegisterScrap

I see

[novel loom]

Not exactly sure how to do it, but if you're willing to help me out in getting something set up, we can do a test run sometime

I'm used to launching the game through Lethal Enhanced Party Edition

but i dont know if that's good enough to use for testing things, or if there's something better

[wooden copper]

I have a little modpack for testing

[novel loom]

What's it called?

[wooden copper]

019cf303-6c45-2087-bd8a-707e7e0cd2c8

that's not a real modpack

that's just a profile code

[novel loom]

Okay, i think i have everything. 23 mods, right?

[wooden copper]

Yes

And you have to add the mod zip

i'd prefer someone who has experience with that but uhh...

not a big deal

You unzip this in the plugins folder

Of course if you do not trust it, do not install it

I'll ask to @little elk :)

(test networking)

[novel loom]

Does the zip go in the lethal company files, or in the r2modman/gale mod manager files somewhere?

I'm not experienced with this, but I'm willing to try if it helps out

Are you up for testing now, or do you want to do it some other time?

[wooden copper]

Plugin folder

Unzip it there

Like any other mod

In gale, do Open Profile Folder, go into bepinex/plugins and unzip it here

On gale it should be under File > Open Profile Folder

[austere ermine]

Are you interested in compatibility with Death Animations?

Considering certain entities like spore lizards do not have death animations of their own in vanilla; you used their idle animation in place for what doesn't normally exist for their corpse item, but this conflicts with Death Animations as its death animation for spore lizards does not match its Enhanced Monsters corpse item, leading to their transformation from enemy to object looking weird

[pine sinew]

i was gonna say this

i think enhanced monsters will use deathanimations but only the last frame, and only if animate is off

if animate is on they just do their standing i think

[wooden copper]

There is a parameter in the settings of each entity that lets you set any animation state name the mod will set the enemy to when it dies

I don't know if I'm clear, my sentence sounds complicated to me... I'll try to rephrase

Oh I see yeah alright

So I should use Death animation to force these

I see...

Thing is it would be easier to just add it as a dependency

[pine sinew]

What is this parameter called

I dont recall seeing it in the json?

Also you could add it as a dependency but it depends on everythingcandiealternative

So your choice if you want that mod associated too

[austere ermine]

I don't know the parameter for the Spore Lizard's death animation though, it's not easily accessible

Uhm

@shut moat Do you know ?

[shut moat]

if you're talking about the animation transition parameter, it's the same as vanilla

which is KillEnemy

everythingcandie pretty much sets off a KillEnemy trigger for all enemies whether or not that trigger actually corresponds to an animation

so what I did in DeathAnimations is just attach a transition into my custom animation which is called when KillEnemy is triggered

pretty much the same structure as what mortal enemies in vanilla have

I haven't looked into how enhancedmonsters handles animations but if vanilla immortal enemies are excluded from using the death animation manually (via a blacklist or something of that sort) then you could check whether deathanimations is installed and include them

if you'd like the .anim file names then I'd have to boot up unity

but yeah the animation container/controller is in the same structure as vanilla mortal enemies

[wooden copper]

EverythingCanDie compatibility is intended

I'll add it as soft dependency but it's a little complex... Hmm

[wooden copper]

DeathAnim or something

It's been a while

[wooden copper]

The death animation for all the enemy data entries are the same

[wooden copper]

That's not What happens

It waits for the end of the death animation (default one, if it finds it), replaces enemy with its generated scrap, and the scrap takes the default death anim name sets it to last frame if it finds it

[shut moat]

ah

gotcha

is there a pointer to the default death animations in vanilla or are they set manually within the mod?

I mean how does it diffrentiate the death animation from the other animations in the container

[austere ermine]

What would we put for the spore lizard, then?

[wooden copper]

They're hard coded, I would need to check every animation controller or every enemy AI kill enemy to set it to the right one

I just don't really have enough time for that these days

And it's not reliable for modded monsters

So I have just put a setting in the metadatas of enemies

[pine sinew]

that parameter isn't present by default

do we have to add it ourself?

[wooden copper]

Oh hmm

Ah right, so I forgot to set it correctly

Ah sike

[shut moat]

ahh I get it now

I thought y'all meant vanilla parameters

hmm the unity project for death animations is bugging right now but I'll take a look at what I named the animations when I'm more available to fix wtv is causing the editor to halt during load

[shut moat]

GirlIdleDeath
PufferDeath
CoilheadDeath
ClaySurgeonDeath
JesterDocileDeath and JesterAggressiveDeath (I assume there's no support for multiple of them but I thought I'd still say)
RadMechDeath

I'm going to have to make some adjustments to the ghost girl

[wooden copper]

Alright, nice

[austere ermine]

Do you, or really anybody, happen to know if this was fixed yet?

Whether Enhanced Monsters/Death Animations fixed it

[austere ermine]

Unrelated, but is compatibility with Enemy Skin Registry possible?

[wooden copper]

I doubt it to be honest, would need to be inspected but I just really don't have time

[wooden copper]

I got no info about the patch I made so idk

[austere ermine]

Wdym?

There was nothing uploaded to Thunderstore

[wooden copper]

I mean this

[pine sinew]

testing some stuff for darmuh rn but i can test ur patch after that

[wooden copper]

Thanks 😄

[novel loom]

I haven't been able to test this, sorry. I don't know anyone actively in here who are up for testing stuff, so i thought the best chance was to hop on with you some time and try it out. But if you're busy and if anyone's up for testing this in a week or two i'll be able to try it out with them then

[pine sinew]

so its occurring to me i never asked what its supposed to patch

i tested for deathanimations compat and still no worky

but idk what else its supposed to fix

[wooden copper]

It's meant to fix desyncs

Nothing else for now

[pine sinew]

oh, i dont have a way to test that then

i'm not due to get my tester on for at least a few days

[wooden copper]

It's not urging anyways

[austere ermine]

Maneaters aren't adults in their item state??? 😭

[pine sinew]

yea theyre fucked up

last time i remember killing a maneater with this mod it had a white box around its body

[wooden copper]

It's a little complex to do that so uh

[wooden copper]

I think this was fixed a while ago

Thanks to Entity

[unborn heron]

@wooden copper Mod likely needs a recompile for v81, the bodies only show up for the host

[wooden copper]

Already existing issue

Havent figured why it happens

[still beacon]

I can't guarantee anything but I might try to take a look at the code today to fix the various sync issues.

If I can fix this mod at least people will (maybe) stop pestering me to remove EE from my mod (sellbodies)

[still beacon]

can you try this, unfortunately I can't test it in multiplayer so I don't know if the new networking works as it should.

[unborn heron]

I unfortunately can't rn, best I can do when I get a chance is LAN which anyone can do tbf

I'm currently rotting in bed due to being hungry and depressed so

[wooden copper]

Ah, the Easter eggs ? I don't know why they're so upset about it

I had proposed fixes but nobody tried them so the changes are still standby

[wooden copper]

This should have fixed it but I got no return about it

I can't remember, maybe I had made various tweaks with this one too, I can't remember

[still beacon]

@wooden copper Anyway, yesterday I did some refracting of the code to keep it cleaner. If you want to take a look at it, I can do a quick PR

[unborn heron]

I mean I might be able to look at it sometime today but y'all can test desyncs via 2 local LAN sessions. I do it all the time for things like moons and interiors that use JLL scripts that may not behave the way I think over the net

It's not like you need other people to test multiplayer sync

[wooden copper]

Yeah sure, thanks for contrib

[wooden copper]

Ah right I forgot about that

Unfortunately I'm not at home this weekend so uh

[unborn heron]

fair, I will likely test in a bit, just something to keep in mind for the future

[wooden copper]

True

[unborn heron]

@still beacon so: body technically spawns for every player now, however it does not sync properly when picked up and only the host can interact with it. logs attached

[unborn heron]

using this dll specifically

[still beacon]

thx, I found the problems and managed to test the fixes since I had time (the PR also has those fixes)

[wooden copper]

I remember having this issue when I started making the mod

[wooden copper]

I have merged the PR @still beacon

I'll build during this day and publish the 1.14.0

[wooden copper]

Hi all !

1.4.0

https://new.thunderstore.io/c/lethal-company/p/VELD/Enhanced_Monsters/
Thanks to @still beacon for his contribution 😄

oh I forgot to add your name to the Attributions section of the README

sorry entity 🙁

I will add it right now so it's done for the next update

[still beacon]

np, luckily I don't suffer from "main character syndrome" so everything is ok

[wooden copper]

Glad to hear it xd

[wooden copper]

If anyone encounters bugs in the latest update, please let me know 😄

[unborn heron]

Will do, haven't played it yet sadgely

[wooden copper]

No worries mate

[unborn heron]

Would you consider adding a config option for this? Bit of a pet peeve of mine to have things modifying the version number and I know one mod actually throws an error cuz it's modifying the version number string (which admittedly is a gullible way to check that, but also a setting would be nice)

[wooden copper]

I'll remove that next update

I'll just remove it

[unborn heron]

okii ^^

[pine sinew]

ceases to exist if u use emblem

[unborn heron]

Don't really currently use Emblem, just NeatMenu and NoMoreCompanyLogo

I'd want my own Emblem theme if I did but I'm too lazy for allat

[pine sinew]

didnt know about neatmenu

i might need this

[pine sinew]

ok nvm

emblem overrides it

[unborn heron]

NeatMenu should work with Emblem, if it's overridden then it's a specific theme issue

[pine sinew]

ill get my emblem cfg and see if its doing anything funny

does applying colors to the buttons cause an override

[unborn heron]

Shouldn't. I know a few emblem themes change the MoreCompany logo color but the remaining buttons should be the normal colors

[pine sinew]

i add a custom menu item if that would cause it

[unborn heron]

Shouldn't but depends on how Emblem handles it

My buttons are just kinda additions to the vanilla MenuContainer

[pine sinew]

i also change the line height would that do it