Lobby Control & Matty's Fixes | Lethal Company Modding | Page 6

naive smelt Apr 6, 2024, 10:16 AM

#

ye they are in ther

unreal oriole Apr 6, 2024, 10:17 AM

#

please disable the Db logging in AsyncLoggers

naive smelt Apr 6, 2024, 10:17 AM

#

on it

unreal oriole Apr 6, 2024, 10:17 AM

#

~~or use AsyncLoggers_Experimental~~ but i will push it to release really soon so not really needed

naive smelt Apr 6, 2024, 10:20 AM

#

yep i can see them now after disabling dbloggin in asyncloggers

#

thank you!

unreal oriole Apr 6, 2024, 10:21 AM

#

no problem, it's a bug i've already fixed but as the version has some other changes i'm still testing

unreal oriole Apr 6, 2024, 4:14 PM

#

@fallen talon soo i'm not using vscode but Rider from JetBrains and neither the nuget package nor the dotnet terminal command works fror downloading it 😅
thx for the help in advance

fallen talon Apr 6, 2024, 4:14 PM

#

unreal oriole <@290259615059279883> soo i'm not using vscode but Rider from JetBrains and neit...

the only thing I'm seeing being an issue @unreal oriole is that adding a network prefab using native NetCode will break vanilla compatibility

#

So that might not be an option

unreal oriole Apr 6, 2024, 4:15 PM

#

oh... yeah i'd like to keep vanilla comp if possible

fallen talon Apr 6, 2024, 4:15 PM

#

I have an idea of how to fix it but haven't had time to implement that yet

unreal oriole Apr 6, 2024, 4:15 PM

#

not really necessary but would be nice if possible

fallen talon Apr 6, 2024, 4:15 PM

#

unreal oriole <@290259615059279883> soo i'm not using vscode but Rider from JetBrains and neit...

I develop using rider :)

fallen talon Apr 6, 2024, 4:15 PM

#

unreal oriole not really necessary but would be nice if possible

aye

fallen talon Apr 6, 2024, 4:19 PM

#

unreal oriole <@290259615059279883> soo i'm not using vscode but Rider from JetBrains and neit...

I'm interested in this though - which command did you try and what error did it yield ?

unreal oriole Apr 6, 2024, 4:19 PM

#

dotnet tool install -g Evaisa.NetcodePatcher.Cli this just returns that no dotnet is present, which i belive is an issue with CMD not using the project dotnet installation probably

#

while nuget says:

unreal oriole Apr 6, 2024, 4:22 PM

#

fallen talon the only thing I'm seeing being an issue <@402567749479432195> is that adding a ...

also differently from Netcode Validator i guess i have to manually add the Components to the gameObjects and sync them with the network object 🤔

nocturne rock Apr 6, 2024, 4:25 PM

#

auto correct brother is expierimental still okay to use or should i move to original

unreal oriole Apr 6, 2024, 4:27 PM

#

at the moment they are aligned

#

i will always keep experimental at least in line with the release branch

fallen talon Apr 6, 2024, 4:29 PM

#

unreal oriole also differently from Netcode Validator i guess i have to manually add the Compo...

I'm not sure of the extent of what runtime validator lets you do, but native NetCode is quite strict

unreal oriole Apr 6, 2024, 4:31 PM

#

netcodeValidator.BindToPreExistingObjectByBehaviour<PlayerNetworking, PlayerControllerB>();
netcodeValidator.BindToPreExistingObjectByBehaviour<ShotgunNetworking, ShotgunItem>();

it allowed me to do this and not have to create the *Networking objects as it would create them himself 🤔

verbal zenith Apr 6, 2024, 4:31 PM

#

that also would likely break vanilla compatibility

fallen talon Apr 6, 2024, 4:38 PM

#

verbal zenith that also would likely break vanilla compatibility

Just in a much harder to identify way 😂

unreal oriole Apr 6, 2024, 4:38 PM

#

rip

fallen talon Apr 6, 2024, 4:38 PM

#

unreal oriole rip

what on earth 😂

#

you copy pasted from the readme

unreal oriole Apr 6, 2024, 4:39 PM

#

yup as is

#

fallen talon Apr 6, 2024, 4:40 PM

#

Wat

#

Oh

#

Oh god

#

Is your code on GitHub

#

I see the issue 😭😭

#

bestie have you heard of 'SDK-style' projects

unreal oriole Apr 6, 2024, 4:42 PM

#

i havent pushed this changes to github yet. but yeah the PostBuildTarget has to be rewritten at one point

#

i just retrofitted the one from ShipLobby

fallen talon Apr 6, 2024, 4:42 PM

#

unreal oriole i havent pushed this changes to github yet. but yeah the PostBuildTarget has to ...

no that's fine

#

that's not causing this

#

You're using an old csproj format

#

Well, 'style'

unreal oriole Apr 6, 2024, 4:44 PM

#

as i said all this files come from ShipLobby origianlly.. i need to take my time and redo the project files

fallen talon Apr 6, 2024, 4:44 PM

#

unreal oriole as i said all this files come from ShipLobby origianlly.. i need to take my time...

At the top of the csproj remove the Import line

#

Then change the Project line to read

unreal oriole Apr 6, 2024, 4:44 PM

#

i've had so many issues

fallen talon Apr 6, 2024, 4:44 PM

#

<Project Sdk="Microsoft.NET.Sdk">

#

You can keep the xmlns attribute if you like

unreal oriole Apr 6, 2024, 4:46 PM

#

Duplicate 'Compile' items were included
🤔

fallen talon Apr 6, 2024, 4:46 PM

#

unreal oriole Duplicate 'Compile' items were included 🤔

Remove all the explicit compile tags

#

They are implicit now

unreal oriole Apr 6, 2024, 4:47 PM

#

The "ResolvePackageAssets" task was not given a value

#

hahaha so many problems

fallen talon Apr 6, 2024, 4:47 PM

#

unreal oriole `The "ResolvePackageAssets" task was not given a value`

Where is it used ...

unreal oriole Apr 6, 2024, 4:48 PM

#

fallen talon Apr 6, 2024, 4:50 PM

#

Convert packages.json to <PackageReference> tags inside an ItemGroup in the csproj

#

Then delete packages.json

unreal oriole Apr 6, 2024, 4:51 PM

#

i do not have the packages.json

fallen talon Apr 6, 2024, 4:51 PM

#

Good

#

Delete all the property groups at the top of your csproj

#

Add a single one in their place

unreal oriole Apr 6, 2024, 4:52 PM

#

nop

fallen talon Apr 6, 2024, 4:52 PM

#

Set

AssemblyName (you know)
Product (mod name, can have spaces)
Version (whatever)
do not set output type
set TargetFramework to netstandard2.1
set LangVersion latest

fallen talon Apr 6, 2024, 4:52 PM

#

unreal oriole nop

we're not there yet lol

fallen talon Apr 6, 2024, 4:52 PM

#

fallen talon Set - AssemblyName (you know) - Product (mod name, can have spaces) - Version (...

and screenshot the result

unreal oriole Apr 6, 2024, 4:54 PM

#

#

do i need to write the netstandard part?

fallen talon Apr 6, 2024, 4:55 PM

#

unreal oriole do i need to write the netstandard part?

Abso-fucking-lutely

unreal oriole Apr 6, 2024, 4:56 PM

#

fallen talon Apr 6, 2024, 4:56 PM

#

unreal oriole

TargetFrameworkVersion specifies a version of '.Net Framework' to use with your project

#

but we want to use Netstandard, not net framework

fallen talon Apr 6, 2024, 4:56 PM

#

unreal oriole

Getting somewhere now

#

show the project tag real quick?

unreal oriole Apr 6, 2024, 4:57 PM

#

thanks for the help btw... one day i would have had to do all this, but i was procastinating 😅

#

<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
    <PropertyGroup>
        <RootNamespace>AdditionalNetworking</RootNamespace>
        <AssemblyName>AdditionalNetworking</AssemblyName>
        <Product>Additional Networking</Product>
        <Version>0.1</Version>
        <TargetFramework>netstandard2.1</TargetFramework>
        <LangVersion>Letest</LangVersion>
    </PropertyGroup>
    <ItemGroup>
        <Content Include="GameDirectory.targets"/>
        <Content Include="PostBuildEvents.targets"/>
    </ItemGroup>
    <ItemGroup>
      <PackageReference Include="System.Runtime" Version="4.3.1" />
    </ItemGroup>
    <ItemGroup>
      <PackageReference Include="TeamBMX.LobbyCompatibility" Version="1.0.1" />
    </ItemGroup>
    <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets"/>
    <Import Project="PostBuildEvents.targets"/>
    <!-- Embedded Debug -->
    <PropertyGroup>
        <DebugSymbols>true</DebugSymbols>
        <DebugType>embedded</DebugType>
        <PathMap>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)'))=./</PathMap>
    </PropertyGroup>
</Project>

fallen talon Apr 6, 2024, 5:00 PM

#

unreal oriole ```xml <?xml version="1.0" encoding="utf-8"?> <Project Sdk="Microsoft.NET.Sdk" x...

Remove the Import project tag that imports Microsoft.csharp.targets

fallen talon Apr 6, 2024, 5:00 PM

#

unreal oriole thanks for the help btw... one day i would have had to do all this, but i was pr...

No worries lmao, I've been fixing people's build system setup since December

unreal oriole Apr 6, 2024, 5:01 PM

#

now complains in the AssemblyInfo

fallen talon Apr 6, 2024, 5:01 PM

#

unreal oriole now complains in the AssemblyInfo

Delete it

#

Delete the whole properties folder

unreal oriole Apr 6, 2024, 5:01 PM

#

i mean it's my fault for not starting from the template but forking from a decently old mod

unreal oriole Apr 6, 2024, 5:02 PM

#

fallen talon Delete the whole properties folder

It compiled 💪

#

now to see if it worked time to dnspy

fallen talon Apr 6, 2024, 5:04 PM

#

unreal oriole i mean it's my fault for not starting from the template but forking from a decen...

Meh, it's nice to pick up where someone left off and fix them up

unreal oriole Apr 6, 2024, 5:04 PM

#

doesn't seem so 🤔

#

Rpcs do not have any netcode attached

fallen talon Apr 6, 2024, 5:05 PM

#

unreal oriole now to see if it worked time to dnspy

Are you spying with rider's decompiler

unreal oriole Apr 6, 2024, 5:05 PM

#

dnSpy

fallen talon Apr 6, 2024, 5:05 PM

#

Did you definitely refresh the caches

unreal oriole Apr 6, 2024, 5:05 PM

#

i never had the file open in DnSpy till now

fallen talon Apr 6, 2024, 5:06 PM

#

Is there an _original.dll in your output folder

#

which should be bin/netstandard2.1

unreal oriole Apr 6, 2024, 5:06 PM

#

nvm was reading from obj

fallen talon Apr 6, 2024, 5:06 PM

#

:)

unreal oriole Apr 6, 2024, 5:06 PM

#

yeah the one in bin has the patch

fallen talon Apr 6, 2024, 5:07 PM

#

obj is intermediate files

#

bin output

#

both should be excluded from version control

unreal oriole Apr 6, 2024, 5:08 PM

#

yeah they are excluded

#

ok and it correctly used the patched one for the zip file

#

yeah adding the component with AddComponent does not sync it with the NetworkObject 🤔

#

i guess i should make somehow static Rpcs and passing the networkObject they refer to as the first parameter 🤔

fallen talon Apr 6, 2024, 5:31 PM

#

unreal oriole i guess i should make somehow static Rpcs and passing the networkObject they ref...

non

#

Make your own network prefab

#

instantiate it when the session starts

#

and you can use NetworkObjectReference params to refer to other network objects if you need to

unreal oriole Apr 6, 2024, 5:32 PM

#

yeah that's what i'm doing now i belive 🤔

fallen talon Apr 6, 2024, 5:33 PM

#

unreal oriole yeah that's what i'm doing now i belive 🤔

looks good so far

unreal oriole Apr 6, 2024, 5:33 PM

#

with now i mean now that i'm rewriting

fallen talon Apr 6, 2024, 5:33 PM

#

Aye

#

When you setup the new prefab, there's a big gotcha

#

which is assigning the globalObjectIdHash on the network object

#

It isn't done for you when you AddComponent at runtime

unreal oriole Apr 6, 2024, 5:34 PM

#

yeah i do not know how to do that so, once i finish this part i was going to ask how to do it

fallen talon Apr 6, 2024, 5:34 PM

#

unreal oriole yeah i do not know how to do that so, once i finish this part i was going to ask...

basically you use BepInEx's assembly publicizer to make the field public, and assign it as usual

#

one sec

unreal oriole Apr 6, 2024, 5:35 PM

#

no i mean even making the prefab itself

fallen talon Apr 6, 2024, 5:36 PM

#

https://github.com/BepInEx/BepInEx.AssemblyPublicizer

GitHub

GitHub - BepInEx/BepInEx.AssemblyPublicizer

Contribute to BepInEx/BepInEx.AssemblyPublicizer development by creating an account on GitHub.

fallen talon Apr 6, 2024, 5:36 PM

#

unreal oriole no i mean even making the prefab itself

oh, I see

#

You can new GameObject at runtime

#

Unity says it's ill advised but Shruge

unreal oriole Apr 6, 2024, 5:37 PM

#

i do already use the assembly publicizer. made things so easy to reference instead of having to use Reflection

fallen talon Apr 6, 2024, 5:37 PM

#

unreal oriole i do already use the assembly publicizer. made things so easy to reference inste...

yeah it's crazy

#

basically

make a new GameObject (your container) with hide flags 'hide and don't save'; Object.DDOL it; disable it
make a new GameObject (your prefab) with a recognisable name, and set its parent transform to the container transform
add a network object component to the prefab and set its object id
add your behaviour to your prefab

#

I think that's it

unreal oriole Apr 6, 2024, 5:45 PM

#

when you suggest to do so?

#

like MoreCompany does in [HarmonyPatch(typeof(NetworkSceneManager), "PopulateScenePlacedObjects")] ?

fallen talon Apr 6, 2024, 6:38 PM

#

unreal oriole like MoreCompany does in `[HarmonyPatch(typeof(NetworkSceneManager), "PopulateSc...

that is for adding network behaviours to existing in-scene placed network objects

#

I create my prfab in the plugin Awake

#

Register it in GameNetworkManager.Awake, then spawn it at... StartOfRound.Start

#

I think

unreal oriole Apr 6, 2024, 8:24 PM

#

@fallen talon something like this?

fallen talon Apr 6, 2024, 8:25 PM

#

unreal oriole <@290259615059279883> something like this?

Remove the setactive false for the prefab

unreal oriole Apr 6, 2024, 8:25 PM

#

mmk

fallen talon Apr 6, 2024, 8:25 PM

#

other than that, yeah looks ok

unreal oriole Apr 6, 2024, 8:26 PM

#

then how do i spawn it in the StartOfRound Start?
i instantiate the prefab as is?

#

also i do acces the components with a static Instance property it should work right?

#

do not mind the comment i have to change it

hexed loom Apr 6, 2024, 9:06 PM

#

Latest version of lobby control isn't loading. I can provide logs if you need more info.

unreal oriole Apr 6, 2024, 9:06 PM

#

AsyncLoggers is failing to move the DB and that is cascading to other mods

hexed loom Apr 6, 2024, 9:06 PM

#

Getting the same error for matty's fixes

unreal oriole Apr 6, 2024, 9:07 PM

#

user AsyncLoggers Experimental or disable DBLogging till i push it to release

hexed loom Apr 6, 2024, 9:07 PM

#

Copy that, thank you!

unreal oriole Apr 6, 2024, 9:07 PM

#

np

hexed loom Apr 6, 2024, 9:13 PM

#

Experimental seems to be working. No errors in the log and mod is functioning as expected.

unreal oriole Apr 6, 2024, 9:24 PM

#

unreal oriole then how do i spawn it in the StartOfRound Start? i instantiate the prefab as is...

@fallen talon if i run the NetworkObject.Spawn() on the host it works but then it complains on the clients as the prefab cannot be found 🤔
is there a way for me to initialize it w/o having to Spawn it?

fallen talon Apr 6, 2024, 9:27 PM

#

unreal oriole <@290259615059279883> if i run the NetworkObject.Spawn() on the host it works bu...

you have to register the prefab

#

with (something) AddPrefab

#

on all clients

unreal oriole Apr 6, 2024, 9:30 PM

#

🤔 no way ( even using the publicizer ) to mark the NetworkObject as spawned w/o actually running the Spawn? ( like MoreCompany does for the extra players)

fallen talon Apr 6, 2024, 9:31 PM

#

unreal oriole 🤔 no way ( even using the publicizer ) to mark the NetworkObject as spawned w/...

what benefit would there be to doing so?

#

the object would not exist on the clients' machines so there would be nothing to receive RPCs

unreal oriole Apr 6, 2024, 9:31 PM

#

trying vanilla comp 😅 if not i'll go the prefab way

#

yeah i'm trying to have it as clientOptional

fallen talon Apr 6, 2024, 9:39 PM

#

unreal oriole 🤔 no way ( even using the publicizer ) to mark the NetworkObject as spawned w/...

even if there were, I don't think it'll work with people that do have the mod

#

imagine you were spawning 1000 of these at the same time

#

how is NetCode supposed to know which instances should represent the same network object across the network

unreal oriole Apr 6, 2024, 9:42 PM

#

nvm going the perab way... sadly i still cant find how to register the prefab 🤔

unreal oriole Apr 6, 2024, 10:07 PM

#

ok got it with a postfix in NetworkManager :/

#

@fallen talon really thanks for the help and the moral support 😂
now it's all on me and my ability to code decently 😅

fallen talon Apr 6, 2024, 10:59 PM

#

unreal oriole ok got it with a postfix in NetworkManager :/

Aye I do mine in a postfix to one of GameNetworkManager's lifetime methods

#

but it's same kinda thing

unreal oriole Apr 7, 2024, 5:55 PM

#

fallen talon the only thing I'm seeing being an issue <@402567749479432195> is that adding a ...

can confirm this prevents vanilla clients from connecting :/

fallen talon Apr 7, 2024, 5:55 PM

#

Aye

unreal oriole Apr 7, 2024, 5:56 PM

#

ping me if you'll ever find a way to avoid that 😅

fallen talon Apr 7, 2024, 5:56 PM

#

I've an idea for a library that allows registering 'mod-specific' prefabs

#

which would get around it

#

But I don't have time presently

unreal oriole Apr 7, 2024, 5:56 PM

#

[Netcode] NetworkConfig mismatch. The configuration between the server and client does not match

fallen talon Apr 7, 2024, 5:57 PM

#

Correct

#

Would you like me to explain why it says that

unreal oriole Apr 7, 2024, 5:57 PM

#

no i do understand why. and it makes sense

#

it would be nice if i had a way to add my components w/o making prefabs but while i could do it for the ShotgunItem i cannot add it to the Player Object as it does not have a prefab

fallen talon Apr 7, 2024, 6:00 PM

#

unreal oriole it would be nice if i had a way to add my components w/o making prefabs but whil...

you can use the more company method for editing in scene placed objects

#

and there is a prefab somewhere, it's just not used all the time

unreal oriole Apr 7, 2024, 6:01 PM

#

if i do that in the PopulateScenePlacedObjects will it correctly attach the components to the networkObject?

fallen talon Apr 7, 2024, 6:05 PM

#

unreal oriole if i do that in the `PopulateScenePlacedObjects` will it correctly attach the co...

yes it will - however you'll still be breaking vanilla compatibility (potentially)

unreal oriole Apr 7, 2024, 6:06 PM

#

uh? does unity complain if a client receives an Rpc for a non existing component?

fallen talon Apr 7, 2024, 6:06 PM

#

unreal oriole uh? does unity complain if a client receives an Rpc for a non existing component...

network behaviours are assigned an index based on a traversal of the network object's children and their components

#

I think it's breadth first

#

So if you add a network behaviour to the root GameObject, it's possible that you offset the indexes of some of the vanilla behaviours

unreal oriole Apr 7, 2024, 6:07 PM

#

    public ushort NetworkBehaviourIdCache;

this one?

fallen talon Apr 7, 2024, 6:08 PM

#

which means that RPCs intended for another behaviour, get received by your behaviour instead

fallen talon Apr 7, 2024, 6:08 PM

#

unreal oriole ```c# public ushort NetworkBehaviourIdCache; ``` this one?

as the variable name implies that is just a cache value

unreal oriole Apr 7, 2024, 6:09 PM

#

mmm 🤔

fallen talon Apr 7, 2024, 6:09 PM

#

fallen talon which means that RPCs intended for another behaviour, get received by your behav...

and RPCs from your behaviour are received by a vanilla behaviour

#

(when playing with a vanilla client)

#

so although it appears to work, it actually fucks a lot of shit up potentially

unreal oriole Apr 7, 2024, 6:09 PM

#

yeah, just trying to find it in code

#

ik i'm trying to do stuff i'm not supposed to

#

but isn't that 90% of what modding is 🤣

fallen talon Apr 7, 2024, 6:16 PM

#

https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/blob/release/1.5.2/com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs#L1193 @unreal oriole

GitHub

com.unity.netcode.gameobjects/com.unity.netcode.gameobjects/Runtime...

Netcode for GameObjects is a high-level netcode SDK that provides networking capabilities to GameObject/MonoBehaviour workflows within Unity and sits on top of underlying transport layer. - Unity-T...

unreal oriole Apr 7, 2024, 6:18 PM

#

thanks 😬

fallen talon Apr 7, 2024, 6:19 PM

#

unreal oriole thanks 😬

😛

unreal oriole Apr 7, 2024, 6:20 PM

#

i'll have to wait for your library then i guess 🤔

#

will work as a Everyone mod for now

grim terrace Apr 7, 2024, 6:24 PM

#

@unreal oriole

Matty Fixes: Error report when trying to read the Pentagram from Scarlet Devil Mansion.
A non-interactive texture used to spawn enemies.

[18:21:54.6282042] [Error :Matty's Fixes] Pentagram crashed! System.InvalidOperationException: Nullable object must have a value.
at System.Nullable1[T].get_Value () [0x00008] in <787acc3c9a4c471ba7d971300105af24>:IL_0008 at MattyFixes.Patches.ItemPatches.CalculateColliderBounds (UnityEngine.GameObject go) [0x00272] in <0546a62864534675ab1f246fbe6d32dd>:IL_0272 at MattyFixes.Patches.ItemPatches.StartPrefix (GrabbableObject __instance) [0x001be] in <0546a62864534675ab1f246fbe6d32dd>:IL_01BE [18:21:54.6493922] [Error :Matty's Fixes] Bomb Failed to mark prefab Mesh Readable! System.ArgumentException: Mesh 'BlueWirePath' index buffer is null at (wrapper managed-to-native) UnityEngine.Mesh.GetIndexBufferImpl(UnityEngine.Mesh) at UnityEngine.Mesh.GetIndexBuffer () [0x00012] in <e27997765c1848b09d8073e5d642717a>:IL_0012 at MattyFixes.Patches.ItemPatches.MakeReadableMeshCopy (UnityEngine.Mesh nonReadableMesh) [0x00088] in <0546a62864534675ab1f246fbe6d32dd>:IL_0088 at MattyFixes.Patches.ItemPatches.MakeMeshReadable (UnityEngine.GameObject go, System.Boolean updateOriginal, System.Collections.Generic.Dictionary2[TKey,TValue] reverseMap) [0x0004b] in <0546a62864534675ab1f246fbe6d32dd>:IL_004B
at MattyFixes.Patches.ItemPatches.StartPrefix (GrabbableObject __instance) [0x00125] in <0546a62864534675ab1f246fbe6d32dd>:IL_0125

#

Lobby Control: Error report, disliked Weather Tweaks. End of round break, unable to pull the lever. Lobby Control v2.3.5/WeatherTweaks 0.4.6

📎 message.txt

unreal oriole Apr 7, 2024, 7:10 PM

#

grim terrace <@402567749479432195> Matty Fixes: Error report when trying to read the Pentag...

[18:21:54.6493922] [Warning:Matty's Fixes] Bomb Added to the ignored Meshes!
that's perfectly fine MattyFixes intercepted the error and handled it

#

oh wait no pentagram is failing.. let me chec

#

bomb is handled

#

😂 it's an exception while logging another exception... all fine you can ignore it. problem is somewhere else

#

probably on WeatherTweaks

solar monolith Apr 7, 2024, 7:44 PM

#

another option that should completely avoid adding a new NetworkBehaviour would be to just manually add the messages to the vanilla ones like I did in NutcrackerFixes

#

it's a lot more work than using a code generator though of course

#

it would be cool if those patchers supported generating messages and attaching them to existing behaviors

unreal oriole Apr 7, 2024, 7:45 PM

#

yeah i'm deciding if it is worth going the full manual way or not 🤔

#

on another note @fallen talon any idea why after your changes to the csprj i get this errors compiling?

Error CS7069 : Reference to type 'Label' claims it is defined in 'mscorlib', but it could not be found

fallen talon Apr 7, 2024, 9:19 PM

#

unreal oriole on another note <@290259615059279883> any idea why after your changes to the csp...

use nuget package references to reference BepInEx instead of local .dll references

unreal oriole Apr 7, 2024, 9:20 PM

#

but i need the publicized dll for AsyncLoggers 🤔

#

or can i publicize a nuget?

fallen talon Apr 7, 2024, 9:21 PM

#

you can publicize a package reference

#

https://github.com/lc-sigurd/sigurd/blob/main/NuGet.Config

#

add that file to your project root (with the .sln)

#

Then remove the BepInEx, harmony references and package reference BepInEx.Core , version 5.4.21

unreal oriole Apr 7, 2024, 9:23 PM

#

fallen talon use nuget package references to reference BepInEx instead of local .dll referenc...

now it's complaining about the AssemblyInfo Attribute and MonoMod crashes on boot 🤔

Warning CS0436 : The type 'IgnoresAccessChecksToAttribute' in 'C:\Users\frnmt.nuget\packages\bepinex.assemblypublicizer.msbuild\0.4.1\contentFiles\cs\any\IgnoresAccessChecksToAttribute.cs' conflicts with the imported type 'IgnoresAccessChecksToAttribute' in 'MonoMod.Utils, Version=25.0.3.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\frnmt.nuget\packages\bepinex.assemblypublicizer.msbuild\0.4.1\contentFiles\cs\any\IgnoresAccessChecksToAttribute.cs'.

fallen talon Apr 7, 2024, 9:24 PM

#

unreal oriole now it's complaining about the AssemblyInfo Attribute and MonoMod crashes on boo...

Remove the monomod reference

unreal oriole Apr 7, 2024, 9:24 PM

#

i do not have monomod references

fallen talon Apr 7, 2024, 9:24 PM

#

show me your whole csproj

unreal oriole Apr 7, 2024, 9:25 PM

#

📎 LobbyControl.7z

fallen talon Apr 7, 2024, 9:25 PM

#

Plaintext please

#

I'm on my phone

unreal oriole Apr 7, 2024, 9:25 PM

#

📎 LobbyControl.csproj

fallen talon Apr 7, 2024, 9:26 PM

#

thanks

unreal oriole Apr 7, 2024, 9:26 PM

#

📎 PostBuildEvents.targets

#

hahaha thx for the support

fallen talon Apr 7, 2024, 9:28 PM

#

Remove the Import line at the top of the csproj

#

I don't think you need the system.runtime reference

#

I don't think you need the ReferencePath thing

#

Don't think you need the PathMap thing either

unreal oriole Apr 7, 2024, 9:29 PM

#

the refernce was put by rider apparently XD

#

still complaining about the attribute

fallen talon Apr 7, 2024, 9:31 PM

#

you have References in your post build event file 😭😭

#

Move all the references to csproj

unreal oriole Apr 7, 2024, 9:32 PM

#

nothing changed

fallen talon Apr 7, 2024, 9:32 PM

#

Correct

#

Send me the new iteration of the csproj, preferably with a .txt extension

#

(mobile OS when magic header: 🙈🙈)

unreal oriole Apr 7, 2024, 9:33 PM

#

📎 LobbyControl_-_Copy.txt

fallen talon Apr 7, 2024, 9:34 PM

#

unreal oriole now it's complaining about the AssemblyInfo Attribute and MonoMod crashes on boo...

oh this warning can be safely ignored

#

sorry, I thought it was a compile error

unreal oriole Apr 7, 2024, 9:34 PM

#

it's breaking the boot tho

fallen talon Apr 7, 2024, 9:34 PM

#

MonoMod crashes on boot?

fallen talon Apr 7, 2024, 9:35 PM

#

unreal oriole it's breaking the boot tho

I mean, it isn't

unreal oriole Apr 7, 2024, 9:35 PM

#

once i try to load the mod ingame

fallen talon Apr 7, 2024, 9:35 PM

#

Something is

#

But it's not that lol

unreal oriole Apr 7, 2024, 9:35 PM

#

hahaha

fallen talon Apr 7, 2024, 9:35 PM

#

do you have any logs at all

#

or is it a really bad one

unreal oriole Apr 7, 2024, 9:37 PM

#

i remvoed the other mods so ( about LobbyControl ) only a Parameter __runOriginal does not contain a valid index from Harmony appears 🤔

#

once i fix this i'll try and report the monomod error from async

fallen talon Apr 7, 2024, 9:38 PM

#

unreal oriole i remvoed the other mods so ( about LobbyControl ) only a `Parameter __runOrigin...

sounds like your monomod hookfiles need regenerating

unreal oriole Apr 7, 2024, 9:39 PM

#

❓

fallen talon Apr 7, 2024, 9:39 PM

#

unreal oriole i remvoed the other mods so ( about LobbyControl ) only a `Parameter __runOrigin...

Wait, from Harmony??

#

What on earth have you done

unreal oriole Apr 7, 2024, 9:39 PM

#

yeah from harmony... i'm doing one mod at a time

fallen talon Apr 7, 2024, 9:39 PM

#

unreal oriole i remvoed the other mods so ( about LobbyControl ) only a `Parameter __runOrigin...

I don't think runOriginal is a thing

#

can you ctrl F for __runOriginal in your code

unreal oriole Apr 7, 2024, 9:40 PM

#

https://harmony.pardeike.net/articles/patching-injections.html#__runoriginal

#

and was working before so 🤷

fallen talon Apr 7, 2024, 9:41 PM

#

Hmmge

fallen talon Apr 7, 2024, 9:41 PM

#

unreal oriole and was working before so 🤷

is it a ref bool

unreal oriole Apr 7, 2024, 9:41 PM

#

nope a normal bool

fallen talon Apr 7, 2024, 9:41 PM

#

nvm it doesn't need to be

#

I'm confusion about what you've done lmao

unreal oriole Apr 7, 2024, 9:42 PM

#

oh well i removed it and it works now... but kinda would like to still have it ( it was a nice redundancy check if another mod was suppressing the call )

fallen talon Apr 7, 2024, 9:42 PM

#

aye

unreal oriole Apr 7, 2024, 9:43 PM

#

back to Async... BepInEx is not publicized even with the Nuget.config

fallen talon Apr 7, 2024, 9:48 PM

#

unreal oriole back to Async... BepInEx is not publicized even with the Nuget.config

you need the publicize = true

unreal oriole Apr 7, 2024, 9:49 PM

#

fallen talon Apr 7, 2024, 9:49 PM

#

like you had on the other references

#

hang on

unreal oriole Apr 7, 2024, 9:49 PM

#

😅 😭

#

everything is broken

fallen talon Apr 7, 2024, 9:49 PM

#

I know why it is but is tricky to explain

#

BepInEx.baselib

#

Add that package reference and publicize it

unreal oriole Apr 7, 2024, 9:54 PM

#

that compiled 🎉

#

and no monomod errors

#

ok monomod errors come from @brisk sierra MonoMod_Debug_Pattcher 🤔

#

📎 message.txt

fallen talon Apr 7, 2024, 10:00 PM

#

Lol

brisk sierra Apr 7, 2024, 10:00 PM

#

yeah, see the message that I posted #1220288559760805988 message

unreal oriole Apr 7, 2024, 10:01 PM

#

why did i even had LethalLib in my debug profile... nothing was uisng it 😂

#

problem solved... it was not a problem 😅

#

really thanks @fallen talon 🙏

#

now i would be happy to remove the Attribute warning but evrything is working so i can just ignore my OCD and leave it be 😂

fallen talon Apr 7, 2024, 10:10 PM

#

unreal oriole now i would be happy to remove the Attribute warning but evrything is working so...

you can ignore particular warnings in MSBuild by setting some property

#

https://github.com/lc-sigurd/sigurd/blob/90b885a2612fb4667bcf4b882d128cea6038976b/Directory.Build.props#L14

kindred cove Apr 7, 2024, 10:11 PM

#

unreal oriole probably on WeatherTweaks

what did i break again 😳

unreal oriole Apr 7, 2024, 10:12 PM

#

kindred cove what did i break again 😳

too late.. it was alsready diagnosed to not be neither of us fault 😂

kindred cove Apr 7, 2024, 10:12 PM

#

https://tenor.com/view/spongebob-squarepants-nickelodeon-sigh-phew-gif-5752975

Tenor

Sigh of Relief

▶ Play video

devout nacelle Apr 8, 2024, 4:10 AM

#

Pst

#

what is uh

#

hidden solstice Apr 8, 2024, 8:40 AM

#

ah blue wire is sus again

#

unreal oriole Apr 8, 2024, 1:18 PM

#

unreal oriole if i do that in the `PopulateScenePlacedObjects` will it correctly attach the co...

@fallen talon reporting in case you're still intrested:

#

i've got it working using a mixed approach

#

i do create the prefab "GlobalObject" but i do not register it as a NetworkPrefab, instead i add it with a postfix in PopulateScenePlacedObjects

#

this means that if the host has the mod the Object gains a NetworkObjectID otherwise it stays with id 0

#

id 0 is invalid so no broken rpc is sent to a vanilla host. and i keep track on the host side of which clients report having the mod so i do not send Rpcs to clients that do not have it

#

so far it seems to be working as expected 🤔

fallen talon Apr 8, 2024, 4:32 PM

#

unreal oriole i do create the prefab "GlobalObject" but i do not register it as a NetworkPrefa...

that's an interesting approach, I like it

#

Perhaps I can do that for csync as a stopgap

unreal oriole Apr 8, 2024, 4:34 PM

#

it does throw the "cannot find prefab" error on vanilla clients but they proceed without issues so it seems to be all fine

unreal oriole Apr 8, 2024, 8:08 PM

#

for the sake of modpack makers and hopefully vanilla speedrunners, i've released:

#

TooManyItems

small mod containing a standalone version of Lobby Control Item Limit remover ( both saved and synced items ) and Matty's Fixes OutOfBoundsFix ( prevent items from falling below ship )

Thunderstore

TooManyItems v1.0.0

Remove limits to amount of items in a lobby

vagrant root Apr 8, 2024, 8:08 PM

#

first like let's go

kindred cove Apr 8, 2024, 8:10 PM

#

#

i'm doing my part 🫡

unreal oriole Apr 8, 2024, 8:10 PM

#

it's not even on r2 yet 😂

vagrant root Apr 8, 2024, 8:11 PM

#

unreal oriole it's not even on r2 yet 😂

😛

unreal oriole Apr 8, 2024, 8:12 PM

#

also MIT license if anybody ,in a future where i'm not modding anymore, wants to keep it alive

vagrant root Apr 9, 2024, 12:54 AM

#

@unreal oriole Did you break something?

#

Cus lobbies are being hard capped at 4 right now

#

When a 5th joins they instantly get kicked

#

What have you done sir?

vagrant root Apr 9, 2024, 1:20 AM

#

@unreal oriole Downgrading Lobby Control to 2.3.5 fixed it

#

Bls fix

vagrant root Apr 9, 2024, 4:18 AM

#

@unreal oriole I should also state the new update made TwoRadarMaps throw some pretty big stack traces too, I think your new radar patch might have been conflicting with it

solar monolith Apr 9, 2024, 7:13 AM

#

when does it print those errors and do you have an example log?

vagrant root Apr 9, 2024, 7:13 AM

#

solar monolith when does it print those errors and do you have an example log?

Let me reupdate it rq

solar monolith Apr 9, 2024, 7:14 AM

#

I do quite a lot of patches to things relating to the radar map, but I didn't recognize what issue LobbyControl is fixing with the recently added patch yet

vagrant root Apr 9, 2024, 7:15 AM

#

#

On startup

#

#

This error under it

#

Idk why 2.3.6 is breaking more than 4 people from joining though that's a big issue too

solar monolith Apr 9, 2024, 7:16 AM

#

does an error not coincide with that too? seems like there probably would be one

vagrant root Apr 9, 2024, 7:17 AM

#

I never got one earlier when a 5th person tried to join

#

I looked

#

They would just join and then instantly get dced

solar monolith Apr 9, 2024, 7:17 AM

#

oh curious

vagrant root Apr 9, 2024, 7:18 AM

#

It's weird that it's breaking your mod like that though

vagrant root Apr 9, 2024, 7:19 AM

#

solar monolith oh curious

https://github.com/mattymatty97/LTC_LobbyControl/blob/lobby_control/LobbyControl/src/Patches/JoinPatches.cs There's the new code though

GitHub

LTC_LobbyControl/LobbyControl/src/Patches/JoinPatches.cs at lobby_c...

A mod for Lethal Company to allow control of the lobby you're in orbit in between missions. - mattymatty97/LTC_LobbyControl

#

You may be able to see what got brokey

#

XD

solar monolith Apr 9, 2024, 7:28 AM

#

vagrant root It's weird that it's breaking your mod like that though

it surprises me that it didn't happen sooner given that Matty already had a fix for a radar bug in this mod

#

I touch just about every single function related to radar targets to fix the vanilla bugs with it

vagrant root Apr 9, 2024, 7:29 AM

#

Haha

#

Yeah and sadly there's no config option to disable the radar patch in Lobby Control rn either for compat

#

@unreal oriole You may wanna add the option to disable Lobby Control's radar fix so it doesn't break TwoRadarMaps

solar monolith Apr 9, 2024, 7:32 AM

#

I'll take a look first and see if we're duplicating patches here

vagrant root Apr 9, 2024, 7:32 AM

#

solar monolith I'll take a look first and see if we're duplicating patches here

👍

unreal oriole Apr 9, 2024, 7:39 AM

#

we might be, i'll add a config swich for it

#

what i do is in PlayerControllerB.SendNewPlayerValuesClientRpc i remove

#

and replace it with

#

@solar monolith 🤔

#

about the player count i have not changed anything from the previous Experimental release ( well other than the csprj files, but thoose should not cause this kind of issue )

#

@fallen talon right?

unreal oriole Apr 9, 2024, 7:43 AM

#

vagrant root Cus lobbies are being hard capped at 4 right now

any logs for this problem?

vagrant root Apr 9, 2024, 7:44 AM

#

unreal oriole any logs for this problem?

Like I said it wouldn't throw any errors

#

It would just insta kick the 5th player that tried to join

unreal oriole Apr 9, 2024, 7:44 AM

#

no i need the normal info/debug lines around the time the 5th joined

vagrant root Apr 9, 2024, 7:44 AM

#

Well I don't have the logs anymore unfortunately v.v

solar monolith Apr 9, 2024, 7:46 AM

#

unreal oriole and replace it with

ah, this is actually pretty similar to the patch I applied, hadn't got to my PC to check what I did all that time ago lol

#

mine uses a function I wrote to find the index of the transform, but honestly your solution using the existing function is nicer and I should've thought of doing that lol

#

only downside is it breaks the assumption that something will assign to TransformAndName.name there

#

not sure what the best way to make the second patch that runs fail silently if the other already did it

unreal oriole Apr 9, 2024, 7:48 AM

#

yeah because i Nop the shit out of the original call
🤣

solar monolith Apr 9, 2024, 7:48 AM

#

why not just delete the instructions though?

#

I guess it's a bit more of a pain and doesn't really matter though

unreal oriole Apr 9, 2024, 7:49 AM

#

i prefer to keep the index values.. i know of some mods that patch using specific instuction numbers instead of iterating 💀

solar monolith Apr 9, 2024, 7:49 AM

#

if you really wanted to make my life miserable though you could look at the other bug fixes that I have in https://github.com/Zaggy1024/LC_TwoRadarMaps/blob/main/TwoRadarMaps/Patches/PatchVanillaBugs.cs lmao

solar monolith Apr 9, 2024, 7:50 AM

#

unreal oriole i prefer to keep the index values.. i know of some mods that patch using specifi...

I refuse to acknowledge it if someone does that

#

I didn't know that was a thing and I will promptly forget that I heard you say that

#

but yeah, I should definitely make my patch work the way yours does, there's no reason for me not to I think

#

as far as the function called anyway

unreal oriole Apr 9, 2024, 7:53 AM

#

it took me a while to figure out too.. originally i was iterating over all the radar targets and re-assigning the names based on the components of the transform ( in Matty Fixes ) but that somehow was still not working 🤔

solar monolith Apr 9, 2024, 7:53 AM

#

huh, that's odd

#

also did you figure out why the names become mismatched? it (or one of the causes at least) is a pretty fun one

unreal oriole Apr 9, 2024, 7:54 AM

#

#

yeah it's the damned radar boosters

#

(also got flagged by automod for that message 😭)

#

what a stupid way of ensuring the boosters are at the end of the list

solar monolith Apr 9, 2024, 7:56 AM

#

I don't think it's so much ensuring they're at the end of the list as it is ensuring that they have a consistent order across clients

#

but yeah it's a bit of a silly mistake

#

I was a bit confused reading your changelog though since I think it mentioned late joining?

unreal oriole Apr 9, 2024, 7:57 AM

#

yeah the name mismatch only happens if late joining

solar monolith Apr 9, 2024, 7:57 AM

#

oh no that's not true

unreal oriole Apr 9, 2024, 7:57 AM

#

as before the first land there is no way to enable a booster 😏

solar monolith Apr 9, 2024, 7:58 AM

#

wait huh?

unreal oriole Apr 9, 2024, 7:58 AM

#

you cannot grab a booster before landing

solar monolith Apr 9, 2024, 7:58 AM

#

the players' network IDs don't depend on the order in which they join

unreal oriole Apr 9, 2024, 7:58 AM

#

unless another mod allows it

solar monolith Apr 9, 2024, 7:58 AM

#

so I'm not sure what landing has to do with it

#

you can repro the issue by just having two players join a lobby in orbit and then spawning a radar booster and activating it

unreal oriole Apr 9, 2024, 7:58 AM

#

it sorts them based on the GameObject NetworkID that is based on the host 🤔

solar monolith Apr 9, 2024, 7:58 AM

#

can even go to the test map with dev tools to pick it up so you can do it in orbit

unreal oriole Apr 9, 2024, 7:59 AM

#

and activating it

#

that's the point you cannot in vanilla before landing

#

you cannot even grab it

solar monolith Apr 9, 2024, 7:59 AM

#

sure, but what does that have to do with late joining? the players can already be in the lobby and it'll do it

#

oh wait you mean because the names don't get replaced I suppose

#

it's odd because I'm pretty sure I saw it happen without joining after the sorting happened, but maybe that was due to some code I had in TwoRadarMaps

unreal oriole Apr 9, 2024, 8:01 AM

#

the bug happens only if you join a lobby with a radar booster active... that is only possible when late joinig ( or if a mod like GI allows you to pick up the booster before landing )

solar monolith Apr 9, 2024, 8:02 AM

#

the radar booster doesn't have to be active, it just has to have been activated in the past

unreal oriole Apr 9, 2024, 8:02 AM

#

instead of "you" is better to say "a player"

solar monolith Apr 9, 2024, 8:02 AM

#

but yeah

#

in vanilla, I suppose I see what you mean

#

iirc the reason why it happened more often for me was because of another vanilla bug fix, where I would sort the transform list immediately on load to keep the order consistent

#

since otherwise you can switch and it'll keep the same target

#

I had forgotten that part

#

I think what I can do to make it soft fail in TwoRadarMaps is check if there's still an assignment to TransformAndName.name in the function, and if not, I can print nothing if your mod is present and print an error if not

#

and perhaps same on your end?

unreal oriole Apr 9, 2024, 8:06 AM

#

i mean i just plan on putting a config toggle and allow users to just toggle it off if they have TwoRadarMaps

solar monolith Apr 9, 2024, 8:07 AM

#

hmm I see

#

I'd rather it require no user input so maybe I'll soft depend so that I can always load after and check that

#

a config option will just lead to more questions from users

#

either "do i leave this option on?", "what does this option do?" or "why am I getting this error in TwoRadarMaps??"

unreal oriole Apr 9, 2024, 8:08 AM

#

yeah without soft depending there is no way to ensure either of us load before the other 😅

solar monolith Apr 9, 2024, 8:09 AM

#

right, but if we both check the same thing then it's the same effect

#

I'm fine with either solution

#

it's easy enough on my side since I have a lot of utilities for transpilers

#

if I just

soft depend on LobbyControl
check if there is no stfld TransformAndName.name
check if there is a call to ManualCameraRenderer.ChangeNameOfTargetTransform()
then it should be fine, and I can add checks for any other mods adding a similar patch easily

#

and I'll also know if an update breaks either patch

unreal oriole Apr 9, 2024, 8:13 AM

#

up to you, i'll add my config toggle anyways

#

the other thing i still need to find how to fix is the spectator boxes and the "Unknown" names :/

solar monolith Apr 9, 2024, 8:14 AM

#

I've only ever seen Unknown perhaps one time where a player actually successfully joined (not even sure about that instance), idk how that happens

#

didn't you try to make a patch for that already? or was that in the unreleased networking mod?

unreal oriole Apr 9, 2024, 8:16 AM

#

yeah i did try to wait for steam to respond with the new player name ( NameFix patch in Matty Fixes ) but many people reported that was not working

#

and as i do not know of a reliable way of replicating the issue + only happens in online mode

solar monolith Apr 9, 2024, 8:16 AM

#

do you know where the "Unknown" string is coming from? I would've expected it to default to the unset name of "Player #[0-9]"

unreal oriole Apr 9, 2024, 8:16 AM

#

it's quite tricky to debug

solar monolith Apr 9, 2024, 8:17 AM

#

is it associated with any mods or does it happen on vanilla? it's bizarre that I've never seen it really

unreal oriole Apr 9, 2024, 8:17 AM

#

it comes from steam api, steam has not received thr player values yet ( as the request is async but zeekers does not wait )

#

so the default strting is "Unknown"

#

i'll send you the code line in a few min

solar monolith Apr 9, 2024, 8:19 AM

#

the new Friend(ulong).Name getter doesn't wait for a response?

unreal oriole Apr 9, 2024, 8:19 AM

#

the string itself is in the native code of Facepunch so i had to dig in the documentation to find it 😅

unreal oriole Apr 9, 2024, 8:19 AM

#

solar monolith the `new Friend(ulong).Name` getter doesn't wait for a response?

nope

solar monolith Apr 9, 2024, 8:20 AM

#

huh...

#

maybe you could somehow artificially throttle your connection to steam

unreal oriole Apr 9, 2024, 8:20 AM

#

if steam has the friend in cache it just returns the cache otherwise it send a request and returns "Unknown" until it has a proper value

solar monolith Apr 9, 2024, 8:20 AM

#

but I suppose it might use some sort of cache for the logged-in player on Steam?

#

oh

#

I see

#

that would make sense why I don't see it then, I never play with randoms lol

#

I wonder, have you sniffed for the packet it sends to request the username? if it's on its own domain, maybe you could just block it in hosts

#

...if that would still let you launch the game lol

unreal oriole Apr 9, 2024, 8:22 AM

#

Screenshot_2024-04-09-10-21-58-049_com.github.android-edit.jpg

#

the request is a task you can wait for and once it completes in theory the original Frined object has all the values

solar monolith Apr 9, 2024, 8:31 AM

#

how did you use the task? using Unity's async functionality?

unreal oriole Apr 9, 2024, 8:31 AM

#

😅 .

#

i poll it in StartOfRound.LateUpdate 😅

#

it's quite the bad system ik

#

but was there as Experimental

#

i'm an idiot.... i'm supposed to .Start the task ( or schedule it as a Corutine ) right?

solar monolith Apr 9, 2024, 8:35 AM

#

hmmm

#

honestly I'm not experienced with using async, so I'm not sure

#

I think that would make sense, though, I would assume the await keyword would call that itself

#

it is syntactic sugar after all (afaik)

#

I wonder if you can call StartCoroutine(Task) and have it automatically wrap that in an Enumerable

unreal oriole Apr 9, 2024, 8:42 AM

#

goggling a bit it seems to be ConfigureAwait instead 🤔

solar monolith Apr 9, 2024, 8:43 AM

#

wait, what is that supposed to do in this case?

#

that sounds like it applies when awaiting it, to keep the continuation on the thread that the task was run on? but maybe I'm misreading

#

all this just makes me wish they'd used the promises model instead lol

#

async is cool when you can just propagate the asynchronicity all over the place

unreal oriole Apr 9, 2024, 8:49 AM

#

somewhere else they said to use

solar monolith Apr 9, 2024, 8:50 AM

#

hmm

vagrant root Apr 9, 2024, 8:50 AM

#

@unreal oriole Hopefully you can reproduce the issue where players get insta kicked with more than 4 players

unreal oriole Apr 9, 2024, 8:51 AM

#

vagrant root <@402567749479432195> Hopefully you can reproduce the issue where players get in...

i do not have friends 😭, well i do but not enough to get to 5 😅

vagrant root Apr 9, 2024, 8:51 AM

#

I'm gonna guess you accidentally changed something when you did the new radar patch

vagrant root Apr 9, 2024, 8:51 AM

#

unreal oriole i do not have friends 😭, well i do but not enough to get to 5 😅

Would testing it in lan work though?

#

Or does it have to be online?

unreal oriole Apr 9, 2024, 8:51 AM

#

lan uses a different system and normally bypasses all checks

solar monolith Apr 9, 2024, 8:52 AM

#

unreal oriole somewhere else they said to use

hmm, that seems weird to me if the RequestInfoAsync method is already supposed to run off the main thread, but honestly none of this makes much sense to me lmao

#

async is confusing as hell to me

vagrant root Apr 9, 2024, 8:52 AM

#

unreal oriole i do not have friends 😭, well i do but not enough to get to 5 😅

I guess check the code between 2.3.5 and 2.3.6 it's probably an unintentional edit that's forcing the lobby to 4 players somehow

unreal oriole Apr 9, 2024, 8:52 AM

#

solar monolith async is confusing as hell to me

hard agree

#

i like to explicitly tell if stuff needs to run on another thread

#

and be able to start/stop the thread/executor myself

solar monolith Apr 9, 2024, 8:53 AM

#

I just find promises to make much more sense to me

vagrant root Apr 9, 2024, 8:53 AM

#

For all we know it could be due to 2.3.6 breaking TwoRadarMaps somehow

solar monolith Apr 9, 2024, 8:53 AM

#

you call a function, it starts running off the main thread, then you can immediately chain some action to run after that function finishes

#

simple

unreal oriole Apr 9, 2024, 8:54 AM

#

vagrant root I guess check the code between 2.3.5 and 2.3.6 it's probably an unintentional ed...

litterally the only addition is the RadarPatch

solar monolith Apr 9, 2024, 8:54 AM

#

reading the code can be kinda ugly with all the indented chained function calls, but logically it makes sense and as long as you have an event loop you shouldn't end up with all this async virus crap

vagrant root Apr 9, 2024, 8:57 AM

#

unreal oriole litterally the only addition is the RadarPatch

Yeah so quite possibly it's due to it breaking TwoRadarMaps

#

Since both mods are attempting to patch the radar

solar monolith Apr 9, 2024, 8:57 AM

#

it shouldn't be, that error should be harmless

#

well

#

actually I suppose the patches stop in TwoRadarMaps where that one fails, but I'm not sure how that could cause issues when I don't touch anything related to the lobby size

#

(barring errors when joining on either the host or the client)

vagrant root Apr 9, 2024, 9:00 AM

#

It could be the method Matty is using is failing to register more than 4 people on the radar, and when a 5th person joins they get kicked due to it

#

I'll have to test if it's fixed later after Matty pushes the update that allows me to disable his radar patch

unreal oriole Apr 9, 2024, 9:01 AM

#

were you using Exprimental before or stable?

vagrant root Apr 9, 2024, 9:01 AM

#

unreal oriole were you using Exprimental before or stable?

Stable.

#

2.3.6

unreal oriole Apr 9, 2024, 9:01 AM

#

oh

#

then i need to check the diff even before

vagrant root Apr 9, 2024, 9:01 AM

#

I had to roll back to 2.3.5 to fix the issue

#

So you broke something I just dunno what

#

Lol

unreal oriole Apr 9, 2024, 9:03 AM

#

no i mean before checking the 2.3.6 were you using stable 2.3.5 or Expreimental 3.6.0?

vagrant root Apr 9, 2024, 9:03 AM

#

Stable 2.3.5

#

I stopped using Experimental after you deprecated it

#

Lol

#

So are you saying the breaking change might have been in Experimental first?

unreal oriole Apr 9, 2024, 9:04 AM

#

it might but i can't find where

vagrant root Apr 9, 2024, 9:04 AM

#

Cross check your code differences, there is some code on your github you changed 5 days ago

#

https://github.com/mattymatty97/LTC_LobbyControl/blob/lobby_control/LobbyControl/src/Patches/LobbyPatcher.cs My guess if it isn't the changes to the radar it's something in this

GitHub

LTC_LobbyControl/LobbyControl/src/Patches/LobbyPatcher.cs at lobby_...

A mod for Lethal Company to allow control of the lobby you're in orbit in between missions. - mattymatty97/LTC_LobbyControl

solar monolith Apr 9, 2024, 9:05 AM

#

@unreal oriole what about calling directly into Steamworks.SteamFriends.RequestUserInformation() in a coroutine until it returns false, then getting Friend.Name?

vagrant root Apr 9, 2024, 9:06 AM

#

https://github.com/mattymatty97/LTC_LobbyControl/blob/lobby_control/LobbyControl/src/Patches/SavePatches.cs I doubt the changes to this would cause the insta kick issue

GitHub

LTC_LobbyControl/LobbyControl/src/Patches/SavePatches.cs at lobby_c...

A mod for Lethal Company to allow control of the lobby you're in orbit in between missions. - mattymatty97/LTC_LobbyControl

solar monolith Apr 9, 2024, 9:06 AM

#

looks like that's what RequestInfoAsync() does anyway, so it running as a task is pretty much pointless except it makes it harder for you to wait for it

vagrant root Apr 9, 2024, 9:06 AM

#

But it was changed 5 days ago as well

#

It's most likely something in JoinPatches or LobbyPatcher

solar monolith Apr 9, 2024, 9:07 AM

#

@vagrant root did you check if the players having trouble joining were getting errors on their ends?

#

I should've asked specifically about that before but I didn't think of it

vagrant root Apr 9, 2024, 9:08 AM

#

solar monolith <@165179734194520073> did you check if the players having trouble joining were g...

I asked and they said the only thing they got was the warning of MoreCompany's error being supressed

solar monolith Apr 9, 2024, 9:08 AM

#

humm

vagrant root Apr 9, 2024, 9:08 AM

#

Something is broken and doesn't wanna toss an error

solar monolith Apr 9, 2024, 9:08 AM

#

if it was anything to do with missing radar targets, I wouldn't really expect it to cause the player to disconnect, but it also should print an error if it did

unreal oriole Apr 9, 2024, 9:09 AM

#

i'd need to see the logs... the only thing i removed from v2.3.5 was actually the code that was casuing the lobbies to be half the size 😅

#

but i completly removed all the code about it so it is as it was abck in v 2.1.x

vagrant root Apr 9, 2024, 9:09 AM

#

unreal oriole i'd need to see the logs... the only thing i removed from v2.3.5 was actually th...

Can you check the log from my friend earlier that I sent to flip in TooManyEmotes?

#

#1184362437550555176 message this one

#

Maybe you'll find something

#

But I know it never sent anything in my logs

#

I checked

#

Let me see if loading up in a lobby solo says anything, cus it wouldn't log anything earlier I checked the log literally right after someone joined and got kicked too

#

and nothing was logged

unreal oriole Apr 9, 2024, 9:13 AM

#

as fas as i can see there is an exception from Weather Tweaks but then the disconnection is because the host closed the game 🤔

#

[00:29:30.2103413] [Info   : Unity Log] disconnecting client id: 0
[00:29:30.2103413] [Info   : Unity Log] Host disconnected!
[00:29:30.2103413] [Info   : Unity Log] False
[00:29:30.2103413] [Info   : Unity Log] Host quit! Ending game for client.

vagrant root Apr 9, 2024, 9:13 AM

#

Is it due to your rename thing?

#

📎 message.txt

#

Nice btw

unreal oriole Apr 9, 2024, 9:14 AM

#

there are so many NREs in your logs... it's incredible you can still play 😅

vagrant root Apr 9, 2024, 9:15 AM

#

Yeah TooManyEmotes breaks when someone rejoins a lobby

#

idk why

unreal oriole Apr 9, 2024, 9:16 AM

#

i mean in this log the client joins correcntly playes and disconnects once the host disconnects...

vagrant root Apr 9, 2024, 9:16 AM

#

Flip has been trying to fix it

#

Yeah I ended up disconnecting it

unreal oriole Apr 9, 2024, 9:17 AM

#

this does not show any of the 5th player failing to join

vagrant root Apr 9, 2024, 9:17 AM

#

Cus someone kept dcing

#

I told you

#

it doesn't log the 5th

#

Idk why

#

🤷‍♀️

#

Hold on one sec

unreal oriole Apr 9, 2024, 9:17 AM

#

was this from your pov? no as this seems from Player (3)

vagrant root Apr 9, 2024, 9:17 AM

#

Yeah that wasn't my pov

#

Like I said I don't have the logs anymore

#

XD

#

I should have saved them but it never logged anything

#

Unless you got 4 people that feel like popping into a lobby rn

#

Gonna be hard to maybe get anything

#

Lmfao

unreal oriole Apr 9, 2024, 9:18 AM

#

cough~~DbLogging~~cough

vagrant root Apr 9, 2024, 9:19 AM

#

Well excuse me for disabling it cus it kept leaving partially written files behind on top of the full log

#

Lol

unreal oriole Apr 9, 2024, 9:19 AM

#

😂 jokes aside, well see

tacit lynx Apr 9, 2024, 9:19 AM

#

foggy

unreal oriole Apr 9, 2024, 9:20 AM

#

you can tweak the size ( i agree 100Mb is a bit too much ) and it will only keep two files.. same as the normal LogOutput 🤔

#

just a bit more compact and easy to navigate

vagrant root Apr 9, 2024, 9:20 AM

#

@steady gulch do you still have your player-prev.log? You were the 5th that tried to join that game and you kept getting kicked maybe you have something

unreal oriole Apr 9, 2024, 9:21 AM

#

was it v49 or v50 btw?

vagrant root Apr 9, 2024, 9:21 AM

#

v49

unreal oriole Apr 9, 2024, 9:21 AM

#

double weird

vagrant root Apr 9, 2024, 9:21 AM

#

unreal oriole double weird

I have a suggestion

#

Don't break your mods

#

c;

#

XD

unreal oriole Apr 9, 2024, 9:22 AM

#

if (going to break)
 dont;

vagrant root Apr 9, 2024, 9:23 AM

#

Skill Issue

vagrant root Apr 9, 2024, 9:28 AM

#

unreal oriole ``` if (going to break) dont; ```

Btw

#

The errors she got

#

The 2nd one was when kicked

#

So

#

What did you do sir?

#

XD

unreal oriole Apr 9, 2024, 9:29 AM

#

that feels like a MoreCompany issue tbh

#

and i haven't touched MC at all...

vagrant root Apr 9, 2024, 9:29 AM

#

Yeah but why is it happening only after the 2.3.6 update?

#

and only with 2.3.6

#

👀

tacit lynx Apr 9, 2024, 9:30 AM

#

I get that second error

#

simply for just leaving a save

#

and I think i've had it for a while and just haven't thought anything of it

vagrant root Apr 9, 2024, 9:31 AM

#

So maybe Lobby Control made MoreCompany throw an exception and cus Lobby Control supresses them

#

....

#

Gdi Matty

#

XD

unreal oriole Apr 9, 2024, 9:32 AM

#

nah i suppress only one specific exception in AddPlayerChatMessageClientRpc

vagrant root Apr 9, 2024, 9:33 AM

#

Hmmmm

unreal oriole Apr 9, 2024, 9:33 AM

#

tacit lynx Apr 9, 2024, 9:40 AM

#

tacit lynx and I think i've had it for a while and just haven't thought anything of it

I did find where it started appearing after sifting through my old codes, though it started with the error only appearing once but idk if that is relevant

unreal oriole Apr 9, 2024, 9:43 AM

#

Lobby Control Experimental v3.7.0

config toggle for RadarFix
small code cleanup

vagrant root Apr 9, 2024, 9:43 AM

#

unreal oriole ## [Lobby Control Experimental v3.7.0](<https://thunderstore.io/c/lethal-company...

Let's see if disabling the Radar Fix fixes it later shall we

#

XD

#

If it does I'mma be like

#

"Matty how?"

unreal oriole Apr 9, 2024, 9:44 AM

#

i'd be super confused too

solar monolith Apr 9, 2024, 10:16 AM

#

just pushed out an update for TwoRadarMaps that adds that soft dependency and skips the patch silently if LobbyControl is present

#

that should hopefully allow TwoRadarMaps to fully function alongside LobbyControl again

unreal oriole Apr 9, 2024, 10:18 AM

#

i'm waiting to locate the player limit problem before pushing mine to stable

solar monolith Apr 9, 2024, 10:19 AM

#

no worries, the config option shouldn't really be necessary now

#

still good to have it obviously

#

also not sure if you saw this message, but perhaps it could solve your "Unknown" player problem? #1211989201793449994 message

#

it being set up as a task is kinda funny because all the task does is poll that off the main thread

unreal oriole Apr 9, 2024, 10:20 AM

#

maybe? i've pushed the Task.Run one to Matty Fixes and will wait a bit for reports if it is working or not

solar monolith Apr 9, 2024, 10:20 AM

#

there's no point in polling it off the main thread if you still have to poll on the main thread lmao

#

how are you setting the name after Task.Run()?

#

i.e. how do you synchronize back to the main thread?

unreal oriole Apr 9, 2024, 10:21 AM

#

i poll it on the main thread because i do not want to get in a race condition with another player joining and both of them trying to write the same things

#

so i just have it run in the lateUpdate in sync with the rest of the unity calls

solar monolith Apr 9, 2024, 10:22 AM

#

wait, I'm confused, that's basically what I'm suggesting, but without cutting out the middleman (task thread)

unreal oriole Apr 9, 2024, 10:22 AM

#

on the main thread i check if the task is completed and if it is then run the code for changing the name

#

https://github.com/mattymatty97/LTC_MattyFixes/blob/matty_fixes/MattyFixes/src/Patches/NamePatches.cs

GitHub

LTC_MattyFixes/MattyFixes/src/Patches/NamePatches.cs at matty_fixes...

A collection of Fixes for the vanilla game, with focus on vanilla compatibility. - mattymatty97/LTC_MattyFixes

solar monolith Apr 9, 2024, 10:23 AM

#

the Task is a lie, it doesn't even really have anything to do off the main thread except poll every 50ms or something: https://github.com/Facepunch/Facepunch.Steamworks/blob/master/Facepunch.Steamworks/SteamFriends.cs#L268-L282

unreal oriole Apr 9, 2024, 10:24 AM

#

🤣 wow Steam

solar monolith Apr 9, 2024, 10:24 AM

#

I'd also suggest starting a coroutine on the PlayerControllerB, then you don't have to keep a dictionary and all that boilerplate

#

Enumerable UpdateName(PlayerControllerB player, SteamId steamID)
{
  yield return new WaitUntil(() => !RequestUserInformation(steamID, true));
  drawTheRestOfThePlayerName();
}

#

it looks like on the Steam API side, there actually is a callback, so I'm not sure why Facepunch doesn't use that

#

probably just because it's easier to poll it, which is kinda fair, but it would be nice if it exposed that callback so you could just react to that

#

(if Unity had a way to synchronize to the main thread anyway)

#

or... this docs comment seems to indicate it has a callback, but I can't find a reference to it anywhere else in the includes

unreal oriole Apr 9, 2024, 10:34 AM

#

there is indeed an event

solar monolith Apr 9, 2024, 10:34 AM

#

oh weird

#

I wonder why I can't find that type defined anywhere

unreal oriole Apr 9, 2024, 10:35 AM

#

because things don't really map from native c to the library XD... as this is not using a type at all

solar monolith Apr 9, 2024, 10:35 AM

#

the headers are C++, I would've expected to see a typedef or something thonk

unreal oriole Apr 9, 2024, 10:35 AM

#

and i belive that event is the one https://thunderstore.io/c/lethal-company/p/Lauriichan/FriendPatches/ uses

Thunderstore

FriendPatches v1.0.4

Fixes late joining players having 'Unknown' as name and added the ability to see players you played with in the 'Recently played' interface of Steam.

solar monolith Apr 9, 2024, 10:36 AM

#

oh nice

unreal oriole Apr 9, 2024, 10:36 AM

#

yeah they just never start the request 😂

#

so they only receive updates for the actual friends you have on steam and not the other players in the lobby

solar monolith Apr 9, 2024, 10:37 AM

#

oh I see

unreal oriole Apr 9, 2024, 10:39 AM

#

solar monolith ```cs Enumerable UpdateName(PlayerControllerB player, SteamId steamID) { yield...

also i decided to also request the avatar as it will be needed in the spectator menu

#

as we're already in an async context waiting a bit more is not an issue

solar monolith Apr 9, 2024, 10:39 AM

#

would probably be good to check whether that callback runs on the main thread before using it though, I'm guessing that it doesn't since the Facepunch.Steamworks library doesn't look like it has Unity-specific functionality

#

ah I see

#

fair enough

unreal oriole Apr 9, 2024, 10:39 AM

#

#

i'm not going to use the callback and have to try and figure out which player the Friend object blelongs to tbh

solar monolith Apr 9, 2024, 10:40 AM

#

yeah

#

I wouldn't either really

#

polling it is fine, it'll only run for a short time after a join

unreal oriole Apr 9, 2024, 10:40 AM

#

should i add some kind of delay between polling?

solar monolith Apr 9, 2024, 10:41 AM

#

I personally wouldn't unless the function call really takes a while

#

you could profile it to make sure it's quick, but I would imagine it just has to read some thread-shared bool and return it

#

it'll be kinda rough if it is slow, though, because that'll mean that if you poll and wait x seconds and poll again, it'll have a really ugly effect on frametimes

#

I think Zeekers and a lot of modders have a bad habit of thinking that just because they make something run less often it's fine for it to take a while

#

I see my frametime spike to double its normal value periodically way more often than I'd like

#

the way the AI does its calculations once every 200ms for example

unreal oriole Apr 9, 2024, 10:45 AM

#

solar monolith you could profile it to make sure it's quick, but I would imagine it just has to...

i belive too but have no real way to profile it tbh

solar monolith Apr 9, 2024, 10:46 AM

#

just toss it in a manual loop with yield return null and then StopWatch it

#

oh wait

#

I forgot you can't test it waiting

#

in that case I would just leave it as you wrote it and hope for the best lol

#

maybe if you know someone that commonly has that issue though, you could print out an average runtime for the function when it finishes and get that from them

#

anywho though I need to stop rambling so much and get off of here lol

unreal oriole Apr 9, 2024, 10:49 AM

#

i mean 90% of the cases it is going to return immediatly as all players will have each other as friends... some random latejoining might slightly slow down on join but it will not be called that frequently anyways 🤔

solar monolith Apr 9, 2024, 10:53 AM

#

yeah, hopefully even if it is somehow a long-running function it'll still end the coroutine fairly quickly

#

I'm sure it's fine

unreal oriole Apr 9, 2024, 10:53 AM

#

i just had a bunch of steam errors while booting and was so worried... turns out i started my debug instance with Steam closed 🤣

#

[10:54:23.6859710] [Warning:Matty's Fixes] Late Friend update Completed Player 0 (||xxxxxxxxxxxxxxxxx||) has name The__Matty
at least for the localhost it seems to be working w/o any slowdowns

wooden hamlet Apr 9, 2024, 10:55 PM

#

So was this an issue anyone else is having? #1211989201793449994 message I was holding off on updating to 2.3.6, but I haven't seen anyone else mention anything about that

vagrant root Apr 10, 2024, 12:40 AM

#

@unreal oriole esperimental build is super brokey

#

📎 message.txt

#

So something is fucked with your radar patch for sure

#

Cus I had it disabled

#

and noone could join

#

Good job

#

XD

vagrant root Apr 10, 2024, 12:44 AM

#

vagrant root

Wait @solar monolith I just saw your TwoRadarMaps update go live was this cus of you? XD

solar monolith Apr 10, 2024, 12:44 AM

#

oh I..guess so

#

it shouldn't patch if you have LobbyControl though thonk

#

that is the error I was fixing though, yeah

#

it didn't stop my friends from joining, though, they just didn't have names

vagrant root Apr 10, 2024, 12:46 AM

#

So LobbyControl is preventing joins then

#

FFS Matty

#

https://tenor.com/view/angryjoe-you-done-messed-it-up-failure-failed-gif-18074828

Tenor

timid atlas Apr 10, 2024, 3:24 AM

#

So I have Lobby Control installed and the fix to prevent multiple players from connecting at once enabled, but some of my friends still end up joining into the black screen, even if they were apparently the only person joining at that time?

#

I was under the impression the join queue is intended to fix that

vagrant root Apr 10, 2024, 4:32 AM

#

timid atlas I was under the impression the join queue is intended to fix that

You can try increasing the time but I've noticed it isn't helping me that much, I think I'm just gonna start using LobbyInviteOnly instead to make things easier

unreal oriole Apr 10, 2024, 6:33 AM

#

vagrant root

that's not lobby control, it's matty fixes NameFix patch throwing a fit with More Company

vagrant root Apr 10, 2024, 6:35 AM

#

unreal oriole that's not lobby control, it's matty fixes NameFix patch throwing a fit with Mor...

Okay got you

#

But still

#

Why with the radar patch disabled do people get insta kicked when trying to join?

#

You majorly broke something with your radar patch

#

fr

unreal oriole Apr 10, 2024, 6:35 AM

#

no idea why yet tho, i've just woken up and am from mobile in bed 😂😅

vagrant root Apr 10, 2024, 6:36 AM

#

Yeah cus with 2.3.6 at least 4 people could join then the 5th got insta kicked

unreal oriole Apr 10, 2024, 6:36 AM

#

i need logs for that. still

vagrant root Apr 10, 2024, 6:36 AM

#

with Experimental and the radar patch disabled

#

insta kick

#

Again it logged nothing

#

What I sent you

#

Is what it logged

#

LOL

#

Something is mad brokey sir.

unreal oriole Apr 10, 2024, 6:37 AM

#

i need the info lines! not the missing errors 😅

vagrant root Apr 10, 2024, 6:37 AM

#

Well

#

Easy solution

unreal oriole Apr 10, 2024, 6:37 AM

#

i need to see what went well and check where it stops sending the info lines

vagrant root Apr 10, 2024, 6:37 AM

#

I add the Experimental build to my pack

#

and you hop on with me

#

XD

#

Cus you should get the logs pretty easily since it'll insta kick you

#

XD

unreal oriole Apr 10, 2024, 6:38 AM

#

vagrant root Something is mad brokey sir.

no shit Sherlock 🤣

#

but well, things have to break for me to be able to fix them no? 😏

vagrant root Apr 10, 2024, 6:38 AM

#

Yeah this is why you just attempt to join my lobby lol

#

018ec6bb-a46e-2361-cad6-7258dc274f5b

#

XD

unreal oriole Apr 10, 2024, 6:39 AM

#

let me get out of bed 🙃😴

vagrant root Apr 10, 2024, 6:39 AM

#

Haha

#

We gonna fix your brokey mod

unreal oriole Apr 10, 2024, 6:52 AM

#

vagrant root 018ec6bb-a46e-2361-cad6-7258dc274f5b

v50 o v49?

vagrant root Apr 10, 2024, 6:54 AM

#

v49

unreal oriole Apr 10, 2024, 6:59 AM

#

swapping back

vagrant root Apr 10, 2024, 7:00 AM

#

Got it

#

Idk why but TooManySuits somehow got disabled

#

🤔

#

So reenable that if it's disabled on your end

#

XD

unreal oriole Apr 10, 2024, 7:01 AM

#

oh sure

#

i'm up

vagrant root Apr 10, 2024, 7:02 AM

#

Yeah I noticed the suit rack was going brrr

#

Lmfao

unreal oriole Apr 10, 2024, 7:04 AM

#

do you need to invite me?

vagrant root Apr 10, 2024, 7:04 AM

#

Nah I have it as friends-only

#

You should be good to just try and join

unreal oriole Apr 10, 2024, 7:04 AM

#

need to see host logs then.. on client side it just says that the host refused the connection

vagrant root Apr 10, 2024, 7:04 AM

#

I added LobbyInviteOnly cus I can't seem to ever configure the lobby delay properly and people overlap constantly

#

It doesn't even say you tried to join

#

Hmmmm

#

You reenabled TooManySuits right?

unreal oriole Apr 10, 2024, 7:05 AM

#

yeah

vagrant root Apr 10, 2024, 7:05 AM

#

I can't see you online

#

Maybe that's why Steam is declining your connection

unreal oriole Apr 10, 2024, 9:41 AM

#

what i find wierd is that if RadarPatch is disable it litterally does not touch the code 🤔

#

@solar monolith can you confirm this would not do anything if the config is false 🤔

solar monolith Apr 10, 2024, 9:42 AM

#

yeah that should do it

unreal oriole Apr 10, 2024, 9:42 AM

#

it was like this already tho

vagrant root Apr 10, 2024, 9:42 AM

#

I'm gonna guess the issue with people getting kicked earlier

#

was a mix of MattyFixes Name Patch and the NRE from TwoRadarMaps

#

5th player issue though still unsure about

#

But the person who got kicked instantly when they tried to join as the only person was @tidal shadow

unreal oriole Apr 10, 2024, 9:44 AM

#

i'm moving the Queue code from Postfixes to Finalizers so even if another mod breaks the Rpc i'm waiting for Lobby Control should still be able to detect it has run and not kick players 🤔

rich trail Apr 10, 2024, 9:45 AM

#

I had some funky stuff going on when opening the lobby for the new fifth player when the other fifth left, every other person joining kicked another one beevil

vagrant root Apr 10, 2024, 9:45 AM

#

unreal oriole i'm moving the Queue code from Postfixes to Finalizers so even if another mod br...

That might work

unreal oriole Apr 10, 2024, 9:45 AM

#

rich trail I had some funky stuff going on when opening the lobby for the new fifth player ...

if you are in v50 that's a vanilla "bug"

#

zeekers put code to prevent backfilling

rich trail Apr 10, 2024, 9:46 AM

#

thanks zeekeers

unreal oriole Apr 10, 2024, 9:46 AM

#

so i'll have to patch it once v50 releases

vagrant root Apr 10, 2024, 9:46 AM

#

The code is actually useful

#

Because if someone joins when the ship is landing it closes out the lobby

#

Rather than getting all the networking issues and desyncs

#

I found that out when someone joined once after I pulled the lever

#

then when it landed

#

the Lobby closed

#

sent us all back to main menu

unreal oriole Apr 10, 2024, 9:47 AM

#

it's not the join while landing fix tho.. this is littrally about players in orbit even before starting the game

vagrant root Apr 10, 2024, 9:47 AM

#

Yeah I get you

rich trail Apr 10, 2024, 9:49 AM

#

also correct me if I'm wrong but is it lobby control that's making desynced players drop their inventory?

unreal oriole Apr 10, 2024, 9:49 AM

#

yes

#

thats the force_drop config

rich trail Apr 10, 2024, 9:49 AM

#

ty

vagrant root Apr 10, 2024, 9:49 AM

#

@unreal oriole fix for shovels turning invisible when?

rich trail Apr 10, 2024, 9:49 AM

#

an eyeless dog killed my friend cause of this once greed

unreal oriole Apr 10, 2024, 9:50 AM

#

it's better on as it prevents worse issues tbh but you can disable it and the bugged player will not be able to pick up anything untill you type lobby forcedrop in the terminal ( or he relogs )

vagrant root Apr 10, 2024, 9:50 AM

#

It's always weird seeing someone randomly holding an invisible shovel, or worse they have nothing in their hand and you just hear the sound of the shovel

rich trail Apr 10, 2024, 9:51 AM

#

unreal oriole it's better on as it prevents worse issues tbh but you can disable it and the bu...

Ohhhh thanks for elaborating, I'll look into that

unreal oriole Apr 10, 2024, 9:51 AM

#

unreal oriole it's better on as it prevents worse issues tbh but you can disable it and the bu...

btw this behaviour is the normal vanilla bug and not from my mod

vagrant root Apr 10, 2024, 9:51 AM

#

would sync on use fix the invisible shovel thing?

#

Or no?

unreal oriole Apr 10, 2024, 9:52 AM

#

showels do not use the use rpc sadly so not

vagrant root Apr 10, 2024, 9:53 AM

#

unreal oriole showels do not use the `use` rpc sadly so not

I wonder if the golden shovel mod avoids the bug somehow

unreal oriole Apr 10, 2024, 9:53 AM

#

the new AdditionalNetworking in theory will fix any desync issues

#

but it is highly experimental atm... still would love feedback on it 😂

unreal oriole Apr 10, 2024, 9:54 AM

#

unreal oriole the new AdditionalNetworking in theory will fix any desync issues

basically makes so the clients explicitly tell what's in their inventory and what slot they are on instead of relying on the other side to guess 😄

solar monolith Apr 10, 2024, 9:56 AM

#

vagrant root was a mix of MattyFixes Name Patch and the NRE from TwoRadarMaps

wait so that's confirmed now, that TwoRadarMaps patches failing caused the disconnects?

vagrant root Apr 10, 2024, 9:57 AM

#

solar monolith wait so that's confirmed now, that TwoRadarMaps patches failing caused the disco...

I think so yeah, cus when Matty joined my lobby with experimental installed with the RadarFix disabled he didn't dc

solar monolith Apr 10, 2024, 9:58 AM

#

weird, wish I knew how it did that with no errors being logged

#

very bizarre

unreal oriole Apr 10, 2024, 9:58 AM

#

MattyFixes namefix stuff was failing to create corutines on the playerobject because MoreCompany disables them btw @solar monolith 🤦 , i had to create the corutines on the StartOfRound instead

solar monolith Apr 10, 2024, 9:58 AM

#

it wat

#

why

#

how

vagrant root Apr 10, 2024, 9:58 AM

#

I think the Name Fix in MattyFixes caused the dc when TwoRadarMaps threw the NRE earlier

#

cus you said it would cause names to not work

unreal oriole Apr 10, 2024, 9:59 AM

#

it's the same issue as the wall player bug... MoreCompany for "performance" reasons sets the playerobjects to Inactive

solar monolith Apr 10, 2024, 9:59 AM

#

well it causes the patch in TwoRadarMaps not to work, but it shouldn't prevent Matty's mods from working

vagrant root Apr 10, 2024, 9:59 AM

#

Idek anymore

#

it could have been that cus the code was throwing a NRE some patch in Matty's mods kicked the player

solar monolith Apr 10, 2024, 10:00 AM

#

unreal oriole it's the same issue as the wall player bug... MoreCompany for "performance" reas...

oh but wouldn't the be active by the time the name needs to be gotten? I thought the steam name code ran after the players get teleported

unreal oriole Apr 10, 2024, 10:00 AM

#

apparently no. they activate the object way later

solar monolith Apr 10, 2024, 10:01 AM

#

wowee

#

that's some interesting behavior indeed

#

I guess it doesn't really matter where the coroutine runs though

#

any idea what happens if a player joins, DCs and then is immediately replaced by another before the first name request finishes?

#

will the name be guaranteed to be correct?

unreal oriole Apr 10, 2024, 10:03 AM

#

the second corutine should be scheduled and complete after the first 🤔

#

maybe i shuld cancel the corutine if user DCs

solar monolith Apr 10, 2024, 10:05 AM

#

yeah, if the second is cached it presumably completes first

unreal oriole Apr 10, 2024, 10:07 AM

#

not a pressing matter but i will make sure to handle it in the next iteration

unreal oriole Apr 10, 2024, 10:25 AM

#

there you go 😄

vagrant root Apr 10, 2024, 10:28 AM

#

Okay what did you change?

unreal oriole Apr 10, 2024, 10:29 AM

#

solar monolith any idea what happens if a player joins, DCs and then is immediately replaced by...

handles this edge case

vagrant root Apr 10, 2024, 10:29 AM

#

Ahhh

unreal oriole Apr 10, 2024, 6:17 PM

#

Lunxara would you mind testing the Networking mod too today?

vagrant root Apr 10, 2024, 6:19 PM

#

unreal oriole Lunxara would you mind testing the Networking mod too today?

You released a new mod?

unreal oriole Apr 10, 2024, 6:21 PM

#

oh i never posted it here

#

it's the mod i was having lordfire helping set up

#

AdditionalNetworking Experimental

Thunderstore

AdditionalNetworking Experimental v0.0.2

Use more Explicit networking for stuff like selected slot and inventory.

#

it even allows people to not desync while having this settings from GI

#

set to different values from each other

kindred cove Apr 10, 2024, 6:24 PM

#

let's gooo 🔥

#

another matty W

unreal oriole Apr 10, 2024, 6:24 PM

#

it is in higly experimental state tbh... i'm 70% sure it will break somehow XD

unreal oriole Apr 10, 2024, 6:25 PM

#

kindred cove another matty W

i'm starting to have quite few mods under my name 😂

versed bramble Apr 10, 2024, 6:26 PM

#

unreal oriole it even allows people to not desync while having this settings from GI

I never got this to work for some reason

vagrant root Apr 10, 2024, 6:27 PM

#

Matty's mods already breaking my game

#

Matty: "Break it more!!!"

#

XD

unreal oriole Apr 10, 2024, 6:27 PM

#

normally you can't as the position of items in the inventory is only guessed by the clients so, having the values not aligned will 100% cause desyncs

vagrant root Apr 10, 2024, 6:27 PM

#

I'll see if it works okay though

unreal oriole Apr 10, 2024, 6:27 PM

#

versed bramble I never got this to work for some reason

this mod should fix that by making the client tell everybody else how it's inventory is laid out

vagrant root Apr 10, 2024, 6:27 PM

#

At least if it breaks you'll hopefully be there to catch the error

versed bramble Apr 10, 2024, 6:28 PM

#

I mean I never got it to work even for myself

#

It would just place the item in my held slot instead

#

Maybe an incompatibilty with Hotbar Plus

unreal oriole Apr 10, 2024, 6:28 PM

#

vagrant root At least if it breaks you'll hopefully be there to catch the error

at <t:1712779200:t> sure

vagrant root Apr 10, 2024, 6:29 PM

#

unreal oriole at <t:1712779200:t> sure

I was gonna say

#

It's already almost <t:1712773800:t> XD

unreal oriole Apr 10, 2024, 6:29 PM

#

shh...

#

i forgot i need to account for my timezone in the site i use to get timestamps

vagrant root Apr 10, 2024, 6:46 PM

#

It's all good lol

vagrant root Apr 10, 2024, 6:48 PM

#

unreal oriole i forgot i need to account for my timezone in the site i use to get timestamps

I'm guessing your mod gets rid of the need for the syncing patch for shotguns in NutcrackerFixes

unreal oriole Apr 10, 2024, 6:49 PM

#

yeah shotguns have a specific rpc for ammo and safety

vagrant root Apr 10, 2024, 6:49 PM

#

If anything I just dislike how cracked Nutcrackers are sometimes cus of NutcrackerFixes lol

#

Yesterday I had a Nutcracker shoot 3 times before reloading

#

XD

unreal oriole Apr 10, 2024, 6:50 PM

#

tho opposite of NutcrackerFixes, which is server-authoritative, this is owner-authoritative. meaning a potential cheating client could spoof infinite ammo 😅

vagrant root Apr 10, 2024, 6:50 PM

#

Lol

unreal oriole Apr 10, 2024, 6:51 PM

#

but i mean, cheating is a whole other topic. and i do not plan on making any anti-cheat mod for a while 🙃

unreal oriole Apr 10, 2024, 6:52 PM

#

unreal oriole tho opposite of NutcrackerFixes, which is server-authoritative, this is owner-au...

i should make that mod 🤔, shotgun minigun. with a mag of 30 rounds 🤣

vagrant root Apr 10, 2024, 6:52 PM

#

Pls no

#

Nutcrackers would be death

unreal oriole Apr 10, 2024, 6:52 PM

#

also no delay between shots like the turrets

#

jk obiuvsly.

kindred cove Apr 10, 2024, 7:02 PM

#

unreal oriole also no delay between shots like the turrets

😐

#

please do

vagrant root Apr 10, 2024, 7:04 PM

#

With how cracked the Nutcracker already is in V50 mrov?

#

mrov wants to die

#

XD

vagrant root Apr 10, 2024, 7:05 PM

#

unreal oriole also no delay between shots like the turrets

So btw should anything in Lobby Control be disabled for compat with AdditionalNetworking or no?

unreal oriole Apr 10, 2024, 7:08 PM

#

nope

#

if AdditionalNetworking works as intended noone of LobbyControls InventorySync patches should trigger

unreal oriole Apr 10, 2024, 7:39 PM

#

kindred cove please do

here you go 🤣

vagrant root Apr 10, 2024, 7:47 PM

#

unreal oriole here you go 🤣

The way it's head keeps spinning

#

The nutcracker's ai can't even properly react to this

unreal oriole Apr 10, 2024, 7:48 PM

#

i can crank it up even more 😏

#

sadly nvidia does not record audio for some reason 🤷

#

yeah no that's as fast as they can shoot

kindred cove Apr 10, 2024, 8:04 PM

#

unreal oriole here you go 🤣

https://www.youtube.com/watch?v=NDUqoy3mJ8M

YouTube

Xagon SFX

Tyler1 brrr gun sound

▶ Play video

analog eagle Apr 10, 2024, 8:23 PM

#

vagrant root The way it's head keeps spinning

gotta replace the reload animation with something else yknow broiled

solar monolith Apr 10, 2024, 10:05 PM

#

vagrant root Yesterday I had a Nutcracker shoot 3 times before reloading

wot that is probably not NutcrackerFixes

#

it doesn't do anything with ammo until someone picks it up

polar briar Apr 11, 2024, 5:24 AM

#

So is the fifth player joining issue fixed on the current versions of MattysFixes and Lobby Control?

unreal oriole Apr 11, 2024, 5:58 AM

#

we've not been able to reproduce it yet so,it's unknown if it is even an issue or not

vagrant root Apr 11, 2024, 5:59 AM

#

unreal oriole we've not been able to reproduce it yet so,it's unknown if it is even an issue o...

Hey got a job for you, you should see what flip changed in the new update for TME that murdered my network earlier

#

XD

#

He seems to not be sure why it happened

#

But it did, and it was bad.

#

I since made the decision to remove it and go back to BadAssCompany

#

I'll have to link you the part of the vod later where it happened

vagrant root Apr 11, 2024, 6:53 AM

#

@unreal oriole weird bug

#

But it seems enemies like Coils can't target other players when outside, any idea what might cause that?

humble mural Apr 11, 2024, 6:56 AM

#

vagrant root would sync on use fix the invisible shovel thing?

WAIT

#

invisible shovel is not a mod problem??

#

cuz sometimes my shovel is invisible

#

and i cant use it

#

until i drop it and randomly shows up a few seconds later

vast estuary Apr 11, 2024, 7:25 AM

#

sup, isnt this mod supposed to fix the "spawn in a wall" issue when players join at the same time ? because i had it with friends, with this mod enabled

unreal oriole Apr 11, 2024, 7:28 AM

#

it has some code to mitigate it, but we've never been able to fully fix it as it's not a bug from the game itself but comes from MoreCompany

#

Lobby Control JoinQueue system is the one responsible to ensure only one player at a time can join. but depending on the ping and hardware of the connecting client they might not complete the connection in time before another player is allowed to join.

#

try increase the connection_delay_ms value until you find a good value

#

too high values will have your players wait a lot in the loading screen

vast estuary Apr 11, 2024, 7:34 AM

#

i'll try to do that, thanks

earnest plank Apr 11, 2024, 6:12 PM

#

lobby control was causing people to not hear each other talking and making people invisible I disabled it

ocean cape Apr 11, 2024, 6:41 PM

#

I've also had an issue where I couldn't hear another player (others in the game could hear that player). I didn't check to see if it was Lobby Control causing it, though.

earnest plank Apr 11, 2024, 6:50 PM

#

Yes @unreal oriole Lobby Control is causing major error

earnest plank Apr 11, 2024, 6:51 PM

#

ocean cape I've also had an issue where I couldn't hear another player (others in the game ...

Well yea I switched to late and control company and it fixed that issue

unreal oriole Apr 11, 2024, 6:59 PM

#

if you don't have a log for me to debug i can't do much, but me and many others have been playing without any issues using Lobby Control so i actually doubt it's caused by the mod

#

i will still try to find the issue but you need to give me something to start with

#

@vagrant root i rememebr you had something similar happen a long time ago, but was caused by the SCP mod and dying again from the SCP fixed it 🤔

vagrant root Apr 11, 2024, 7:13 PM

#

unreal oriole <@165179734194520073> i rememebr you had something similar happen a long time ag...

Yeah it was somehow for a friend, but I don't think the SCP mod actually caused it tbh cus we've taken off from aggroed shy guys plenty of times and never reproduced it

valid prawn Apr 11, 2024, 7:45 PM

#

i seem to be only be able to reload one shell in the shotgun

vagrant root Apr 11, 2024, 7:49 PM

#

valid prawn i seem to be only be able to reload one shell in the shotgun

I have had this before, idk what causes it

valid prawn Apr 11, 2024, 7:50 PM

#

I get this in the log

vagrant root Apr 11, 2024, 7:51 PM

#

@unreal oriole Are you ever gonna fix this? XD

📎 message.txt

#

Pretty sure that's related to LGU is it not?

#

😂

unreal oriole Apr 11, 2024, 7:52 PM

#

yeah thoose are bugs from their side. there would be no errrors of people just marked the meshes are readable in editior 😂

vagrant root Apr 11, 2024, 7:52 PM

#

Btw @solar monolith TwoRadarMaps seems to throw this if you disconnect and rejoin a lobby

📎 message.txt

unreal oriole Apr 11, 2024, 7:52 PM

#

line below that should say Bomb added to broken meshes

vagrant root Apr 11, 2024, 7:53 PM

#

unreal oriole yeah thoose are bugs from their side. there would be no errrors of people just m...

@empty nest bls fix

unreal oriole Apr 11, 2024, 7:57 PM

#

i mean even base game should do it 😂
i'm just using a "hack" to read an unreadable mesh and create a new readable one to replace the first...
but it does not work everywhere

solar monolith Apr 11, 2024, 8:00 PM

#

vagrant root Btw <@193574164639121409> TwoRadarMaps seems to throw this if you disconnect and...

I highly doubt that's the first error in the log

vagrant root Apr 11, 2024, 8:00 PM

#

solar monolith I highly doubt that's the first error in the log

No it's not, the other mod that didn't like leaving and rejoining a lobby was Insanity Display

#

lol

solar monolith Apr 11, 2024, 8:01 PM

#

yeah.... that is probably not my problem then lol

#

I can't do anything about it if Terminal.Start() never finishes

vagrant root Apr 11, 2024, 8:01 PM

#

Yeah it just didn't like the terminal being hidden it looks like

📎 message.txt

#

and true

solar monolith Apr 11, 2024, 8:02 PM

#

it didn't like the fact that the entire game was broken in fact

vagrant root Apr 11, 2024, 8:02 PM

#

Haha

#

Why does the game break a lot when you rejoin a lobby anyways?

solar monolith Apr 11, 2024, 8:03 PM

#

could be any number of things

#

some value lingering from a previous game most likely

vagrant root Apr 11, 2024, 8:04 PM

#

Probably

vagrant root Apr 11, 2024, 8:23 PM

#

@unreal oriole So what all did you fix with AdditionalNetworking? lol

unreal oriole Apr 11, 2024, 8:31 PM

#

problems with reserved items, and added boombox track sync 😏

empty nest Apr 11, 2024, 8:37 PM

#

vagrant root <@270279035274133506> bls fix

What am I supposed to do? KittyHappy

vagrant root Apr 11, 2024, 8:38 PM

#

empty nest What am I supposed to do? <:KittyHappy:758704267791302667>

Fix the readable mesh error with the bomb sir

empty nest Apr 11, 2024, 8:38 PM

#

Okay.

#

How?

#

KittyHappy

#

Because I wasn't around when the bomb was made.

vagrant root Apr 11, 2024, 8:38 PM

#

@unreal oriole tell this man how to fix

#

c;

empty nest Apr 11, 2024, 8:38 PM

#

So I have no idea what to change.

vagrant root Apr 11, 2024, 8:39 PM

#

Yeah I'm sure Matty could tell you what needs changed

unreal oriole Apr 11, 2024, 8:40 PM

#

well i do not really know how the editor works.. i know that you need to mark the mesh as readable 🤔 should be a tickbox somewhere in the mesh editor

empty nest Apr 11, 2024, 8:41 PM

#

And is it just the blue wire thing?

#

Or the whole thing?

#

Or the blue wire is just the first thing it finds?

unreal oriole Apr 11, 2024, 8:42 PM

#

if you do the whole thing my mod will be able to avoid touching it

#

i only knwo it fails on the blue wire but other things after the blue wire might break too

empty nest Apr 11, 2024, 8:42 PM

#

Oki, will look at the whole thing

unreal oriole Apr 11, 2024, 8:42 PM

#

empty nest Or the blue wire is just the first thing it finds?

yeah first thing it cannot convert that findes

empty nest Apr 11, 2024, 8:42 PM

#

Don't even know why it's not readable.

vagrant root Apr 11, 2024, 8:43 PM

#

empty nest Don't even know why it's not readable.

Probably was an oversight

empty nest Apr 11, 2024, 8:47 PM

#

So this thing over here?

unreal oriole Apr 11, 2024, 8:48 PM

#

yeah

#

should be that

empty nest Apr 11, 2024, 8:48 PM

#

And it's only the bomb or you can't tell?

unreal oriole Apr 11, 2024, 8:48 PM

#

pentagram too but that's not yours right?

empty nest Apr 11, 2024, 8:49 PM

#

Pentagram is.

#

Because exorcism contract things

unreal oriole Apr 11, 2024, 8:49 PM

#

empty nest And it's only the bomb or you can't tell?

i mean tbh it would be awesome if all grabbables were readable... so my hackpatch does not need to run and try to spoof GPU memory 😅

empty nest Apr 11, 2024, 8:50 PM

#

Yeah, that's what I am doing right now.

unreal oriole Apr 11, 2024, 8:50 PM

#

if any of the items are metallic ( can get lighting ) that will also fix the particles

#

and the zero surface area spam when they are targeted

empty nest Apr 11, 2024, 8:53 PM

#

Okay, I think got all of them if not most.

#

Gonna have dinner soon so I don't know if you wanna test it or if you can wait til I come back.

#

In case you want to, here's the asset bundle! leaves

📎 shipupgrades

vagrant root Apr 11, 2024, 8:57 PM

#

empty nest In case you want to, here's the asset bundle! *leaves*

No more bomb error

#

You fixed it

#

c;

#

So time for you to push it to Thunderstore when you get back it seems

unreal oriole Apr 11, 2024, 10:40 PM

#

as i was saying it's such a simple fix on their ( modders/zeekers ) side. while it's super complicated on mine

vagrant root Apr 11, 2024, 11:07 PM

#

@solar monolith Got some good news, TwoRadarMaps no longer throws that error after the new update WhiteSpike pushed for LGU, so I guess it was a bug from LGU lol

vagrant root Apr 13, 2024, 2:20 AM

#

@unreal oriole so can confirm it was TwoRadarMaps that prevented a 5th player from joining before, using 2.3.6 rn with the latest version of TwoRadarMaps and we got a group of 5 with no issues

#

@solar monolith so I guess the radar patches just hated each other before you fixed compat XD

solar monolith Apr 13, 2024, 2:21 AM

#

weird

unreal oriole Apr 13, 2024, 6:40 PM

#

just for the sake of the records:
All my mods work in v50

#

in the next few days i'll post a new version of LobbyControl as there is now a better way to handle the Transparent Player

devout nacelle Apr 14, 2024, 6:27 AM

#

@unreal oriole

#

pst

tacit lynx Apr 14, 2024, 6:32 AM

#

it's LethalMatt's

devout nacelle Apr 14, 2024, 6:32 AM

#

ooooooooooh

tacit lynx Apr 14, 2024, 6:32 AM

#

ty discord

devout nacelle Apr 14, 2024, 6:32 AM

#

wrong matt

#

yea they are vandalizing the doc :(

tacit lynx Apr 14, 2024, 6:34 AM

#

rip

#

can always revert to a previous version

hallow lantern Apr 14, 2024, 7:08 AM

#

I have been summoned

tacit lynx Apr 14, 2024, 7:09 AM

#

vandalism of your doc is happening a bit methinks

hallow lantern Apr 14, 2024, 7:11 AM

#

Moderating the doc has been nightmarish, the doc has taken on a life of its own

tacit lynx Apr 14, 2024, 7:11 AM

#

Unluck

timid atlas Apr 14, 2024, 7:12 AM

#

Hey there, I had an issue occur while playing with Lobby Control (among other mods) enabled on v50. I'm not positive that it's actually caused by Lobby Control (I'm thinking it was actually TooManyEmotes, but I disabled four mods, those being TooManyEmotes, TooManyEmotes Scrap, Lobby Control, and Matty_Fixes), but it was among the mods I disabled and never ran into the issue again. Info on the issue is here, to avoid repeating it: #1184362437550555176 message

#

In my uneducated opinion given the nature of the warnings being spammed it was most likely TME's doing but I just wanted to drop it in here just in case

hallow lantern Apr 14, 2024, 7:15 AM

#

What kind of vandalism

#

Just did a glance over and things are fine for the most part

tacit lynx Apr 14, 2024, 7:15 AM

#

Had 2 cases one just completely deleted everything, other was just more mild

timid atlas Apr 14, 2024, 7:15 AM

#

hallow lantern What kind of vandalism

Well for one earlier today literally half of the document got blanked out lmao

tacit lynx Apr 14, 2024, 7:15 AM

#

Both were reverted to a previous version

hallow lantern Apr 14, 2024, 7:15 AM

#

Someone keeps marking my unreleased mod as working which is hilarious

timid atlas Apr 14, 2024, 7:16 AM

#

Saw some instances of people replacing mod names with nonsense

tacit lynx Apr 14, 2024, 7:16 AM

#

love to see the double CelestialTint

hallow lantern Apr 14, 2024, 7:16 AM

#

It is at this point

#

If the document implodes

#

I am no longer responsible

tacit lynx Apr 14, 2024, 7:17 AM

#

I mean there's always the option of just locking it and having some select people edit it or something ig

#

At the point where the bulk of mods are probably on there and most work (but that's also a reason to just let it implode)

hallow lantern Apr 14, 2024, 7:18 AM

#

V50 doesn't change a whole awful lot that most mods work so I'm fine continuing to let the community freely edit it

#

Kinda amazing it has lasted this long tbh

tacit lynx Apr 14, 2024, 7:19 AM

#

Version history and revert function does wonders

unreal oriole Apr 14, 2024, 9:39 AM

#

timid atlas Hey there, I had an issue occur while playing with Lobby Control (among other mo...

please do not give the blame to "all" the mods, just stating you disabled a bunch of them and they are all the casue will not help diagnosing the issue and will only make other people avoid all the mods you list as the cause

#

in this specific instance it definitely seems to be caused by TooManyEmotes while stopping an emote

vagrant root Apr 14, 2024, 9:41 AM

#

unreal oriole please do not give the blame to "all" the mods, just stating you disabled a bunc...

So what was changed in the new experimental build lobby man?

#

😛

unreal oriole Apr 14, 2024, 9:41 AM

#

dropped v49 support

#Lobby Control & Matty's Fixes

TooManyItems

Lobby Control Experimental v3.7.0

AdditionalNetworking Experimental