Starlancer AIFix v3.13.2 | EnemyEscape v3.0.0 | Lethal Company Modding | Page 3

faint copper Feb 28, 2024, 5:55 AM

#

that would increase the number of renderers significantly

rocky fable Feb 28, 2024, 5:55 AM

#

Barch's mod lol I wear a few cosmetics tbh

faint copper Feb 28, 2024, 5:56 AM

#

god I still really wonder what's destroying those renderers without destroying the masked itself

copper yew Feb 28, 2024, 5:56 AM

#

mirage only sets the mimicking player, cosmetics are still set by other mods (like AC, MC, etc)

faint copper Feb 28, 2024, 5:56 AM

#

that is really weird, especially if it's doing it to the base meshes

#

if it sets it to mimicking a random player, that might do it

copper yew Feb 28, 2024, 5:57 AM

#

yeah mirage does that

#

what's your hunch on why mimicking a random player might cause it though

faint copper Feb 28, 2024, 5:57 AM

#

yeah, maybe a mod with cosmetics is seeing that and adding cosmetics to the masked so the renderer count is really high

gleaming robin Feb 28, 2024, 5:57 AM

#

Just to confirm, Zaggy
logger.LogWarning($"Found null reference inside {___thisNetworkObject.gameObject.name} ({ ___thisEnemyIndex}, {___thisNetworkObject.NetworkObjectId})'s skinnedMeshRenderers. Removing to prevent potential null reference exceptions.");

faint copper Feb 28, 2024, 5:57 AM

#

👍

copper yew Feb 28, 2024, 5:57 AM

#

ah yeah true, makes sense that the renderer count could be really high

rocky fable Feb 28, 2024, 5:58 AM

#

Everytime a damn masked is spawning I keep getting annoying thumpers

copper yew Feb 28, 2024, 5:58 AM

#

so in this case it's more likely a non issue

faint copper Feb 28, 2024, 5:58 AM

#

well

rocky fable Feb 28, 2024, 5:58 AM

#

I can't get shit if I'm dying lmfao

faint copper Feb 28, 2024, 5:58 AM

#

I wouldn't call it a non issue until I know what causes it, but sure

gleaming robin Feb 28, 2024, 5:58 AM

#

@rocky fable want another beta version?

rocky fable Feb 28, 2024, 5:59 AM

#

it spammed it the same way again huh

📎 message.txt

#

Let me enable debug for log output

faint copper Feb 28, 2024, 5:59 AM

#

ah heck I need to know

#

so repro steps is just spam vow?

copper yew Feb 28, 2024, 5:59 AM

#

rocky fable it spammed it the same way again huh

this never stops?

gleaming robin Feb 28, 2024, 5:59 AM

#

@rocky fable there's a more informative version

rocky fable Feb 28, 2024, 6:00 AM

#

gleaming robin <@165179734194520073> there's a more informative version

oki

gleaming robin Feb 28, 2024, 6:00 AM

#

faint copper so repro steps is just spam vow?

make sure to grab the code

copper yew Feb 28, 2024, 6:00 AM

#

@gleaming robin i think you should print the # of mesh renderers there are before removing them from the list

faint copper Feb 28, 2024, 6:00 AM

#

yep yep

copper yew Feb 28, 2024, 6:00 AM

#

just makes it easier to know if that's the cause of the huge amount of logs

gleaming robin Feb 28, 2024, 6:00 AM

#

oh good idea

copper yew Feb 28, 2024, 6:00 AM

#

also maybe add a counter for # of nulls found and print it after the loop

rocky fable Feb 28, 2024, 6:01 AM

#

Well hopefully I get more info from this dll to find out why it's going so nuts

#

Likely cosmetics I think

gleaming robin Feb 28, 2024, 6:01 AM

#

If you wanna wait a sec I'll have this new version ready

rocky fable Feb 28, 2024, 6:01 AM

#

Okay

#

For now I'll head back and see what shows up in the debug in the current live build lol

faint copper Feb 28, 2024, 6:03 AM

#

holy loading time

copper yew Feb 28, 2024, 6:03 AM

#

thats what i say every time i load lunxara's modpack to debug

rocky fable Feb 28, 2024, 6:03 AM

#

Tbf it was really slow before

#

I nuked LogNeuter and disabled TooManyEmotes to help speed it up

#

XD

gleaming robin Feb 28, 2024, 6:04 AM

#

copper yew also maybe add a counter for # of nulls found and print it after the loop

How's this look?

copper yew Feb 28, 2024, 6:04 AM

#

where's the prints for the counters 👀

gleaming robin Feb 28, 2024, 6:04 AM

#

oops forgot that

#

shush

copper yew Feb 28, 2024, 6:04 AM

#

loool

gleaming robin Feb 28, 2024, 6:05 AM

#

Just put this after the for loops, yea?
logger.LogWarning($"Found {skinNull} null SkinnedMeshRenderers and {meshNull} null MeshRenderers.");

copper yew Feb 28, 2024, 6:06 AM

#

ya

faint copper Feb 28, 2024, 6:06 AM

#

#

this is supposed to be foggy

gleaming robin Feb 28, 2024, 6:06 AM

#

Also ty @faint copper for teaching me $ interpolation, that's so much more readable lol

faint copper Feb 28, 2024, 6:06 AM

#

new exploit just dropped perhaps??

faint copper Feb 28, 2024, 6:06 AM

#

gleaming robin Also ty <@193574164639121409> for teaching me $ interpolation, that's so much mo...

yeah it's way nicer, happy to help

rocky fable Feb 28, 2024, 6:06 AM

#

faint copper

Man when I go foggy I can't see shit

#

You're lucky lol

gleaming robin Feb 28, 2024, 6:07 AM

#

Alright nerds, try this one @_@

#

This should give a crystal-damn-clear log of what's happening

faint copper Feb 28, 2024, 6:07 AM

#

wow what mod makes me move like a thumper

rocky fable Feb 28, 2024, 6:07 AM

#

faint copper wow what mod makes me move like a thumper

Oh it's a mix of BetterStamina and LethalUtilities XD

#

I did that to restore the speed perks I had with AC

#

☠️

gleaming robin Feb 28, 2024, 6:08 AM

#

rocky fable I can't get shit if I'm dying lmfao

also you have so many mods, why not add on a god-mode one? 🤭

rocky fable Feb 28, 2024, 6:08 AM

#

gleaming robin also you have so many mods, why not add on a god-mode one? 🤭

Lol

#

It was smaller

#

But then I nuked AC and found alternatives to replace it and well

#

XD

#

You gotta love that instant ship land

#

Lmfao

#

Nyooooooom

faint copper Feb 28, 2024, 6:16 AM

#

that is pretty nice lol

#

no luck getting masked on the first two tries, time to spawn them myself lol

copper yew Feb 28, 2024, 6:20 AM

#

impossible for me to get null meshes again :(

#

spawning them myself never does anything, they're always non-null

#

at least so far

rocky fable Feb 28, 2024, 6:20 AM

#

📎 message.txt

faint copper Feb 28, 2024, 6:21 AM

#

oh, it did clear them out, nice

gleaming robin Feb 28, 2024, 6:21 AM

#

Lunxara is the queen of finding null refs here

copper yew Feb 28, 2024, 6:22 AM

#

damn now i wish the log also printed the object's name for the ones at the end

gleaming robin Feb 28, 2024, 6:22 AM

#

Maybe test it with 0 cosmetic mods now?

gleaming robin Feb 28, 2024, 6:22 AM

#

copper yew damn now i wish the log also printed the object's name for the ones at the end

wdym?

gleaming robin Feb 28, 2024, 6:23 AM

#

gleaming robin Maybe test it with 0 cosmetic mods now?

I'm almost positive this why there are so many

rocky fable Feb 28, 2024, 6:23 AM

#

Still wonder what causes the CalculatePolygonPath spam now

#

Yeah it's definitely gotta be cosmetics

copper yew Feb 28, 2024, 6:24 AM

#

CalculatePolygonPath comes from this from what i remember

gleaming robin Feb 28, 2024, 6:24 AM

#

rocky fable Still wonder what causes the CalculatePolygonPath spam now

Doubtful that it's AI Fix at least, there'd have to be some really bizarre mod conflict for it to be at fault

copper yew Feb 28, 2024, 6:24 AM

#

patching them out got rid of it, but i removed the patches cuz i didn't know if it was unintentionally causing other bugs

rocky fable Feb 28, 2024, 6:24 AM

#

copper yew CalculatePolygonPath comes from this from what i remember

Ah I wonder if it could be set to just not spam it so much though

copper yew Feb 28, 2024, 6:25 AM

#

gleaming robin wdym?

like for the counter logs, would be nice if it printed which enemy ai it is, but not a big deal

faint copper Feb 28, 2024, 6:25 AM

#

oh, diversity broke everything and I can't land again now

#

rip

rocky fable Feb 28, 2024, 6:25 AM

#

faint copper oh, diversity broke everything and I can't land again now

Yeah had that happen earlier too

gleaming robin Feb 28, 2024, 6:25 AM

#

copper yew like for the counter logs, would be nice if it printed which enemy ai it is, but...

ohhhhhh

#

I can add that rq :P

rocky fable Feb 28, 2024, 6:25 AM

#

Chaos said he's looking into it

copper yew Feb 28, 2024, 6:25 AM

#

rocky fable Ah I wonder if it could be set to just not spam it so much though

even if it didn't log it, stack traces are kinda expensive

rocky fable Feb 28, 2024, 6:25 AM

#

faint copper oh, diversity broke everything and I can't land again now

If you notice LethalThings throws an error there too, almost like a conflict is happening

copper yew Feb 28, 2024, 6:26 AM

#

faint copper oh, diversity broke everything and I can't land again now

oh i wonder if that's why my ship kept getting frozen today

gleaming robin Feb 28, 2024, 6:27 AM

#

Go forth, test subjects

rocky fable Feb 28, 2024, 6:27 AM

#

You're on a roll tonight Starlancer

#

XD

copper yew Feb 28, 2024, 6:27 AM

#

tbh it's probably enough of a test if lunxara takes off cosmetics and sees if it's mostly gone

#

if it is then it's confirmed a non-issue

gleaming robin Feb 28, 2024, 6:27 AM

#

It was just one sentence 🤭

#

Fair, but also

#

information 🤓

copper yew Feb 28, 2024, 6:27 AM

#

true might as well

rocky fable Feb 28, 2024, 6:27 AM

#

Yeah plus

#

it might be able to be fixed too

#

If it's cosmetics

copper yew Feb 28, 2024, 6:28 AM

#

it's not an issue though in that case

#

the tests here is just to confirm if it is or not

gleaming robin Feb 28, 2024, 6:28 AM

#

the cosmetics would just increase the # of renderers, not effect the actual NREs themselves

copper yew Feb 28, 2024, 6:28 AM

#

if removing the cosmetics makes the logs not spam then all starlance has to do is to only print once instead of on each iteration

faint copper Feb 28, 2024, 6:28 AM

#

@copper yew do you have cosmetics equipped? if not, I would wonder what those two null renderers were in your logs

#

I would assume it's all renderers, not just the cosmetics ones

#

but maybe I'm wrong

gleaming robin Feb 28, 2024, 6:29 AM

#

faint copper <@497541811359711263> do you have cosmetics equipped? if not, I would wonder wha...

Comedy and Tragedy mask, probably

copper yew Feb 28, 2024, 6:29 AM

#

if cosmetics carry on from save to save then yeah i should have cosmetics

faint copper Feb 28, 2024, 6:29 AM

#

MoreCompany just stores them in a .txt file, so it should, yeah

copper yew Feb 28, 2024, 6:29 AM

#

ah then yeah i do have cosmetics on

faint copper Feb 28, 2024, 6:29 AM

#

how many?

copper yew Feb 28, 2024, 6:30 AM

#

sec i need to see how to even check

rocky fable Feb 28, 2024, 6:30 AM

#

I will say the way AC handled cosmetic presets was awful, anyone who imported a profile code would have to set it all up again

copper yew Feb 28, 2024, 6:30 AM

#

i haven't touched it in a long time

faint copper Feb 28, 2024, 6:30 AM

#

it'll be in the bottom right of the main menu

rocky fable Feb 28, 2024, 6:30 AM

#

I hope when ProfX does their version of presets and stuff it's not like that

faint copper Feb 28, 2024, 6:30 AM

#

I'm curious whether ProfX's thing will end up being a competitor for LMM

rocky fable Feb 28, 2024, 6:31 AM

#

Lol maybe

faint copper Feb 28, 2024, 6:31 AM

#

if they're both planning on doing cosmetics support anyway

copper yew Feb 28, 2024, 6:31 AM

#

i have 2 cosmetics on

faint copper Feb 28, 2024, 6:31 AM

#

ah then that makes sense

#

it was always a pair of renderers being null in your logs

copper yew Feb 28, 2024, 6:32 AM

#

yeah

faint copper Feb 28, 2024, 6:32 AM

#

so this might just be MoreCompany being a silly goose somehow... but I still want to know why they're destroying their models >:(

rocky fable Feb 28, 2024, 6:33 AM

#

Meanwhile me XD

gleaming robin Feb 28, 2024, 6:34 AM

#

rocky fable Meanwhile me XD

well then

gleaming robin Feb 28, 2024, 6:35 AM

#

faint copper it was always a pair of renderers being null in your logs

I love things are making sense

rocky fable Feb 28, 2024, 6:36 AM

#

Ayyyy lmfaoooooo

#

Something broke

#

copper yew Feb 28, 2024, 6:36 AM

#

oh god

rocky fable Feb 28, 2024, 6:36 AM

#

Have not had this happen in ages

copper yew Feb 28, 2024, 6:36 AM

#

whats the logs

#

are they stuck?

rocky fable Feb 28, 2024, 6:36 AM

#

copper yew Feb 28, 2024, 6:36 AM

#

it's this again

rocky fable Feb 28, 2024, 6:36 AM

#

Spamming

copper yew Feb 28, 2024, 6:36 AM

#

it's the literal bug that people kept thinking came from mirage

#

and i know for a fact that it's not

gleaming robin Feb 28, 2024, 6:37 AM

#

MEO possibly?

copper yew Feb 28, 2024, 6:37 AM

#

nah MEO doesn't touch these functions

gleaming robin Feb 28, 2024, 6:37 AM

#

@rocky fable do you have Lethal Escape?

rocky fable Feb 28, 2024, 6:37 AM

#

Weird how I haven't had it until just now with that new update for your AI Fix

#

Nope

faint copper Feb 28, 2024, 6:37 AM

#

@rocky fable since you seem to be able to reproduce the issue much more easily, if you want to test with this version of OpenBodyCams, I co-opted the debugging option to print when a model referenced by an AI is deleted

📎 OpenBodyCams.dll

copper yew Feb 28, 2024, 6:38 AM

#

gonna go grab some food and whatnot and then check back here later

faint copper Feb 28, 2024, 6:38 AM

#

(so make sure ModelDestructionDebuggingPatchEnabled = true)

gleaming robin Feb 28, 2024, 6:39 AM

#

rocky fable Weird how I haven't had it until just now with that new update for your AI Fix

The only Update() I touch directly is JesterAI, unless LEsc is present in which case I do a simple conditional on EnemyAI.Update()

#

@faint copper I'm preemptively condensing the warnings so that only a single one gets printed per enemy after all the iteration is done behind-the-scenes. Is this informative enough, too informative, not informative enough?
logger.LogWarning($"Found and removed {skinNull} null SkinnedMeshRenderers and {meshNull} null MeshRenderers in {___thisNetworkObject.gameObject.name} ({___thisEnemyIndex}, {___thisNetworkObject.NetworkObjectId} to prevent potential null reference exceptions.");

faint copper Feb 28, 2024, 6:41 AM

#

rocky fable

this looks like it's a null EnemyAI.agent thonk who is deleting a NavMeshAgent without deleting the EnemyAI it's attached to??

rocky fable Feb 28, 2024, 6:41 AM

#

I wonder if it's another vanilla bug

faint copper Feb 28, 2024, 6:42 AM

#

I wouldn't really think so

rocky fable Feb 28, 2024, 6:42 AM

#

Hmmmm

#

I know I got it a lot before at one point but it stopped and this is the first time it's happened in a bit

#

Is there any mod in my list that stands out as the potential cause?

faint copper Feb 28, 2024, 6:44 AM

#

it's very hard to say

rocky fable Feb 28, 2024, 6:44 AM

#

Oh hey

faint copper Feb 28, 2024, 6:44 AM

#

anything that messes with AI in general or masked in particular I guess

rocky fable Feb 28, 2024, 6:44 AM

#

Nvm thought I found it

#

Lol

faint copper Feb 28, 2024, 6:44 AM

#

thing is, something literally has to be setting EnemyAI.agent = null for that error to happen, otherwise we'd be seeing another frame on the stack there in one of Unity's functions

#

which is.......... not good

rocky fable Feb 28, 2024, 6:45 AM

#

Got it

#

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
StarlancerAIFix.Patches.AIFix.EnemyMeshPatch (UnityEngine.SkinnedMeshRenderer[]& ___skinnedMeshRenderers, UnityEngine.MeshRenderer[]& ___meshRenderers, Unity.Netcode.NetworkObject& ___thisNetworkObject, System.Int32& ___thisEnemyIndex) (at <96990cc55c4f4b44aa802759fbb89746>:IL_012C)
(wrapper dynamic-method) EnemyAI.DMDEnemyAI::EnableEnemyMesh(EnemyAI,bool,bool)
StartOfRound.SetPlayerSafeInShip () (at <af9b1eec498a45aebd42601d6ab85015>:IL_008B)
AudioReverbTrigger.ChangeAudioReverbForPlayer (GameNetcodeStuff.PlayerControllerB pScript) (at <af9b1eec498a45aebd42601d6ab85015>:IL_0177)
AudioReverbTrigger.OnTriggerStay (UnityEngine.Collider other) (at <af9b1eec498a45aebd42601d6ab85015>:IL_018B)

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
MaskedPlayerEnemy.CalculateAnimationDirection (System.Single maxSpeed) (at <af9b1eec498a45aebd42601d6ab85015>:IL_0021)
(wrapper dynamic-method) MaskedPlayerEnemy.DMDMaskedPlayerEnemy::Update(MaskedPlayerEnemy)

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
MaskedPlayerEnemy.LookAtFocusedPosition () (at <af9b1eec498a45aebd42601d6ab85015>:IL_0185)
MaskedPlayerEnemy.LateUpdate () (at <af9b1eec498a45aebd42601d6ab85015>:IL_0017)

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
MaskedPlayerEnemy.CalculateAnimationDirection (System.Single maxSpeed) (at <af9b1eec498a45aebd42601d6ab85015>:IL_0021)
(wrapper dynamic-method) MaskedPlayerEnemy.DMDMaskedPlayerEnemy::Update(MaskedPlayerEnemy)

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
MaskedPlayerEnemy.LookAtFocusedPosition () (at <af9b1eec498a45aebd42601d6ab85015>:IL_0185)
MaskedPlayerEnemy.LateUpdate () (at <af9b1eec498a45aebd42601d6ab85015>:IL_0017)

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
MaskedPlayerEnemy.CalculateAnimationDirection (System.Single maxSpeed) (at <af9b1eec498a45aebd42601d6ab85015>:IL_0021)
(wrapper dynamic-method) MaskedPlayerEnemy.DMDMaskedPlayerEnemy::Update(MaskedPlayerEnemy)

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
MaskedPlayerEnemy.LookAtFocusedPosition () (at <af9b1eec498a45aebd42601d6ab85015>:IL_0185)
MaskedPlayerEnemy.LateUpdate () (at <af9b1eec498a45aebd42601d6ab85015>:IL_0017)

faint copper Feb 28, 2024, 6:45 AM

#

unless I'm wrong and it's possible for it to inline a native function at least

tulip vault Feb 28, 2024, 6:45 AM

#

@faint copper hear me out

rocky fable Feb 28, 2024, 6:45 AM

#

Something happened in AiFix

tulip vault Feb 28, 2024, 6:45 AM

#

navmeshagent is a component right

faint copper Feb 28, 2024, 6:45 AM

#

sure

rocky fable Feb 28, 2024, 6:45 AM

#

@gleaming robin

tulip vault Feb 28, 2024, 6:46 AM

#

in theory could you implement OnDestroy and intentionally throw an error to get the stack trace of the mod causing it?

faint copper Feb 28, 2024, 6:46 AM

#

isn't OnDestroy deferred?

rocky fable Feb 28, 2024, 6:46 AM

#

Can you make sense of what happened there?

faint copper Feb 28, 2024, 6:46 AM

#

but I do have a hook on Object.Destroy() and Object.DestroyImmediate() for this kind of purpose in OpenBodyCams

rocky fable Feb 28, 2024, 6:47 AM

#

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
StarlancerAIFix.Patches.AIFix.EnemyMeshPatch (UnityEngine.SkinnedMeshRenderer[]& skinnedMeshRenderers, UnityEngine.MeshRenderer[]& meshRenderers, Unity.Netcode.NetworkObject& thisNetworkObject, System.Int32& thisEnemyIndex) (at <96990cc55c4f4b44aa802759fbb89746>:IL_012C)
(wrapper dynamic-method) EnemyAI.DMDEnemyAI::EnableEnemyMesh(EnemyAI,bool,bool)
StartOfRound.SetPlayerSafeInShip () (at <af9b1eec498a45aebd42601d6ab85015>:IL_008B)
AudioReverbTrigger.ChangeAudioReverbForPlayer (GameNetcodeStuff.PlayerControllerB pScript) (at <af9b1eec498a45aebd42601d6ab85015>:IL_0177)
AudioReverbTrigger.OnTriggerStay (UnityEngine.Collider other) (at <af9b1eec498a45aebd42601d6ab85015>:IL_018B)

this is before it spammed

faint copper Feb 28, 2024, 6:47 AM

#

rocky fable Can you make sense of what happened there?

hard to say without knowing what exactly is the code in that function

#

that's Starlancer's code

rocky fable Feb 28, 2024, 6:47 AM

#

Yep

gleaming robin Feb 28, 2024, 6:47 AM

#

hmm

faint copper Feb 28, 2024, 6:47 AM

#

technically you could grab ILSpy to find the exact line that that IL_XXXX instruction points to

#

that'll tell you exactly what is null in most cases

gleaming robin Feb 28, 2024, 6:48 AM

#

faint copper that'll tell you exactly what is null in most cases

I have ILSpy, how do I find that point?

faint copper Feb 28, 2024, 6:49 AM

#

open the specific assembly that was running when the stack trace was generated and go to the method that was running, then at the top switch the language dropdown to IL

#

then it'll show bytecode indices in hex that those ones in the stack trace refers to, the stack trace points to the first instruction of that line so there will be a few after and one will be dereferencing null

rocky fable Feb 28, 2024, 6:50 AM

#

@copper yew btw in thise case a stack trace happened in Starlancer's code

gleaming robin Feb 28, 2024, 6:50 AM

#

well 012C is my logger apparently 🤔

rocky fable Feb 28, 2024, 6:50 AM

#

In other cases it was probably some other mod lol

faint copper Feb 28, 2024, 6:51 AM

#

gleaming robin well 012C is my logger apparently 🤔

if it's a logging line, it probably could be derefing something else too, those lines would probably be quite long in the IL

#

since I assume it's one of your string-interpolated prints

gleaming robin Feb 28, 2024, 6:52 AM

#

yea

#

is there a way to provide text in Discord in a dropdown, rather than creating a txt file?

faint copper Feb 28, 2024, 6:53 AM

#

I don't know of one, but I haven't looked into it

gleaming robin Feb 28, 2024, 6:54 AM

#

📎 IL.txt

#

eh, no worries

#

well heck, it didn't reach

#

regardless, there's the full IL of my EnemyMeshPatch

faint copper Feb 28, 2024, 6:55 AM

#

oh

#

hmm

gleaming robin Feb 28, 2024, 6:55 AM

#

Is it because I forgot a ) ?

faint copper Feb 28, 2024, 6:55 AM

#

nah

#

that's not evaluated, that's part of the string

gleaming robin Feb 28, 2024, 6:56 AM

#

ah right

#

So is it acting like one of my interpolated references is null?

copper yew Feb 28, 2024, 6:59 AM

#

is it possible that the network object can for whatever reason be null

#

i remember there was an issue like this that happened when i was debugging a mod conflict with mirage

gleaming robin Feb 28, 2024, 6:59 AM

#

If the NO is null, I think the whole enemy GO just doesn't exist

faint copper Feb 28, 2024, 7:00 AM

#

it wasn't null before though, I don't see why it would be now

copper yew Feb 28, 2024, 7:00 AM

#

maybe it's possible for a mesh renderer to be null while the network object still exists, and vice versa though, idk

gleaming robin Feb 28, 2024, 7:01 AM

#

rocky fable [Error : Unity Log] NullReferenceException: Object reference not set to an inst...

I don't suppose you still have the full log of this?

rocky fable Feb 28, 2024, 7:01 AM

#

📎 LogOutput.log

#

I haven't booted the game up since lol

gleaming robin Feb 28, 2024, 7:02 AM

#

oh hella

#

for future tests, just upload the log and maybe a small screenshot of the error

copper yew Feb 28, 2024, 7:02 AM

#

i wonder what the hud manager error is cuz i always see it

rocky fable Feb 28, 2024, 7:02 AM

#

same tbh

faint copper Feb 28, 2024, 7:03 AM

#

MoreCompany sends a message in the chat to synchronize cosmetics but it sends the player ID as -1

#

for some reason their patches aren't currently preventing that from causing an error

copper yew Feb 28, 2024, 7:03 AM

#

i remember this being reported on the AC thread that this happened with a user that installed AC as well though

faint copper Feb 28, 2024, 7:03 AM

#

hmm interesting

#

maybe I'm wrong then

tulip vault Feb 28, 2024, 7:04 AM

#

might be because prefix return false doesn't stop other prefixes on the same function from running

copper yew Feb 28, 2024, 7:04 AM

#

nah maybe u are right, im gonna see if i can find the msg just to make sure

faint copper Feb 28, 2024, 7:04 AM

#

the other hook should be in the stack then

copper yew Feb 28, 2024, 7:05 AM

#

alright i cant find the message, i think i just remembered wrong

copper yew Feb 28, 2024, 7:05 AM

#

faint copper MoreCompany sends a message in the chat to synchronize cosmetics but it sends th...

ur probably right on this

faint copper Feb 28, 2024, 7:05 AM

#

I haven't looked too deeply into it yet honestly

#

it used to be fine, they didn't change how it worked

#

at least not fundamentally

#

#

finally

#

so it is just MoreCompany being silly

#

someone probably ought to make a PR to it to make it update the mesh arrays when this happens

#

not sure if this actually breaks anything seriously though, since I don't know the exact purpose in vanilla for those arrays and hiding the renderers

#

but now that I solved the mystery I really gotta go sleep stitchDeadTired

#

curiosity will be the death of me

rocky fable Feb 28, 2024, 7:11 AM

#

faint copper curiosity will be the death of me

I feel that lol

gleaming robin Feb 28, 2024, 7:13 AM

#

rocky fable

This is actually showing my code repeating for entities I think? It's a little hard to tell the specifics as to when things are happening without the Unity LogInfo breaking things up

#

rocky fable Feb 28, 2024, 7:15 AM

#

Hmmm maybe

gleaming robin Feb 28, 2024, 7:17 AM

#

Yea it looks like something is calling EnableEnemyMesh more than normal

faint copper Feb 28, 2024, 7:17 AM

#

I think that the SetPlayerSafeInShip function just gets called constantly until the ship is in orbit

#

or at least for a certain period upon leaving

gleaming robin Feb 28, 2024, 7:18 AM

#

idk why that'd be calling a stack trace tho

#

copper yew Feb 28, 2024, 7:22 AM

#

imo you should still log and see if the network object is null

gleaming robin Feb 28, 2024, 7:23 AM

#

copper yew imo you should still log and see if the network object is null

Like this? Or is there a better way?
if (___thisNetworkObject == null) { logger.LogWarning("___thisNetworkObject is null."); }

copper yew Feb 28, 2024, 7:25 AM

#

yeah, and do one for ___thisNetworkObject.gameObject as well just in case

#

might as well have that extra info

gleaming robin Feb 28, 2024, 7:26 AM

#

ah debug code

#

This is the last one for tonight. It's 2:30 AM 🤭

📎 StarlancerAI.dll

#

Hope y'all find something useful :3

rocky fable Feb 28, 2024, 7:28 AM

#

Inb4 it was LC_MaskedFix that broke it

#

XD

gleaming robin Feb 28, 2024, 7:28 AM

#

~~also I guess I should add the Code role to myself~~

gleaming robin Feb 28, 2024, 7:28 AM

#

rocky fable Inb4 it was LC_MaskedFix that broke it

I will riot

#

Wait, are you saying it did break it, or just that it'd be silly?

rocky fable Feb 28, 2024, 7:28 AM

#

No I'm just saying inb4 it's that to be silly

#

Lol

gleaming robin Feb 28, 2024, 7:29 AM

#

ah kk

#

Go break it some more Lunxara, I'm counting on you 🤭

rocky fable Feb 28, 2024, 7:29 AM

#

@copper yew gonna neeed you to help me break it

#

👍

copper yew Feb 28, 2024, 7:31 AM

#

ah shit im not on my pc rn

rocky fable Feb 28, 2024, 7:48 AM

#

Lol holy fuck

#

it broke hard lmfao

rocky fable Feb 28, 2024, 7:50 AM

#

copper yew ah shit im not on my pc rn

#

Look at how fast that log is zoomin lmfaoooooooooooo

#

NYOOOOOOOOOM

copper yew Feb 28, 2024, 7:50 AM

#

jeeeesus

#

howd u replicate that

rocky fable Feb 28, 2024, 7:51 AM

#

I put bees on the ship

#

and left

#

and they didn't despawn

#

LMFAO

#

Hold on lemme show the light show in game

#

Lmao the size of this log

#

Btw looks like the masked enemy had some fun too

#

📎 LogOutput.log

#

@gleaming robin hope you have fun with this one

#

XD

#

Love how that latest upate of the ai fix to debug with Starlancer set managed to break that hard

#

XD

#

and with that I readded EnemyFix lol I doubt the next live build will break that hard but

#

XD

pastel spoke Feb 28, 2024, 10:28 AM

#

Does this mod help with the LethalEscape mod?

white summitBOT Feb 28, 2024, 10:28 AM

#

Hello, @pastel spoke, we have a dedicated support channel and forum here: #help-and-troubleshooting #1185732310700654732
Anyone responding is a volunteer so be patient.

lean cargo Feb 28, 2024, 10:32 AM

#

pastel spoke Does this mod help with the LethalEscape mod?

Yep!

#

At least it should

pastel spoke Feb 28, 2024, 10:34 AM

#

Aight

#

thanks

undone copper Feb 28, 2024, 10:57 AM

#

what relation does this mod have with lethalescape

golden basin Feb 28, 2024, 11:51 AM

#

It should give more compatibility to lethal escape

undone copper Feb 28, 2024, 12:15 PM

#

very good.. ive had it together for a long while just wasnt even sure what this did lol

#

but it came w a few fixes, so i kept it..

gleaming robin Feb 28, 2024, 4:30 PM

#

rocky fable <@244591333866602496> hope you have fun with this one

#

@pastel spoke @undone copper
Prior to this update, SLAI didn't really interact with LEsc. SLAI in general is more for allowing moon creators to be silly with their indoor/outdoor spawnlists. With this update however, I fix an incompatibility where outside jesters would break and go immediately and permanently aggressive when both SLAI and LEsc were enabled :3

pastel spoke Feb 28, 2024, 4:33 PM

#

Ah I see

#

thanks for the clarification

gleaming robin Feb 28, 2024, 4:45 PM

#

@faint copper ??????????

faint copper Feb 28, 2024, 4:47 PM

#

I would guess it's argument 1

#

not sure why sometimes the IL index is misaligned, but it might just be because the lines starts are indicated by a truncated number

#

generally one line will contain more than one instruction, so I think it's likely they store them in a bit shifted number

gleaming robin Feb 28, 2024, 4:49 PM

#

Ah. When you say argument one, are you referring to the gameObject?

faint copper Feb 28, 2024, 4:49 PM

#

it would also explain the occasional nop

#

I mean the ldarg.1

#

which would correspond to the zero-indexed parameter #1 for the method that the IL is in

gleaming robin Feb 28, 2024, 4:50 PM

#

oh so that'd be thisEnemyIndex?

faint copper Feb 28, 2024, 4:51 PM

#

oh maybe it's ldarg.2

#

I can't see with the red circle there lol

#

gleaming robin Feb 28, 2024, 4:51 PM

#

oh sorry xP

faint copper Feb 28, 2024, 4:52 PM

#

ah yep arg 2

#

judging by the following call, it must be the NetworkObject

gleaming robin Feb 28, 2024, 4:53 PM

#

I guess it would make sense to clear out the NetworkObjects upon leaving actually. Would that be why those errors started getting thrown?

faint copper Feb 28, 2024, 4:53 PM

#

but also, I wonder, are you using .NET Standard 2.1?

#

if you do, then putting the .pdb next to the dll should give you line numbers instead

#

or there's also a pinned message in #dev-general I think that explains a way to embed debug symbols

faint copper Feb 28, 2024, 4:54 PM

#

gleaming robin I guess it would make sense to clear out the NetworkObjects upon leaving actuall...

not sure what you mean, this seems to indicate that the NetworkObject is null going into the method

#

but I guess that qwbarch had mentioned that you should print whether it was null, was it null when those errors occurred?

gleaming robin Feb 28, 2024, 4:56 PM

#

Actually yes

faint copper Feb 28, 2024, 4:58 PM

#

ah, that would explain it then

#

how are you checking if it's null? with == null?

gleaming robin Feb 28, 2024, 4:59 PM

#

yea

#

faint copper Feb 28, 2024, 4:59 PM

#

because it's worth noting that you can use is null to check whether the field has been set to null

#

the == operator is overloaded to also check whether an object has been Destroy()ed in Unity, but is null bypasses that so you can tell if someone did thisNetworkObject = null

#

if it wasn't set to null then that means that someone Destroy()ed it without also Destroy()ing the object it's attached to, which would seem very strange to me

#

unless that's some quirk of Unity's netcode

gleaming robin Feb 28, 2024, 5:02 PM

#

Hm. I'll add in another debug line above for "is null" and then we can see both ways. Guess I gotta download Lunxara's code 🤭

faint copper Feb 28, 2024, 5:02 PM

#

lemme modify OpenBodyCams to print when that gets destroyed too so you can test for two things at once

gleaming robin Feb 28, 2024, 5:03 PM

#

kk, should I check for NetworkObjectId to be nulled as well?

#

oh nvm, it can't be lol

faint copper Feb 28, 2024, 5:03 PM

#

isn't that an int? it shouldn't be possible for that to be null

#

yea

#

well, a ulong I guess

gleaming robin Feb 28, 2024, 5:04 PM

#

yea that

#

I know this is useful, but also this is dumb lol

gleaming robin Feb 28, 2024, 5:05 PM

#

faint copper if you do, then putting the .pdb next to the dll should give you line numbers in...

you were right btw, good to know for the future

faint copper Feb 28, 2024, 5:06 PM

#

📎 OpenBodyCams.dll

#

untested but should print a stack trace when any NetworkObject held by an EnemyAI.thisNetworkObject is destroyed

#

(OpenBodyCams is present in Lunxara's profile, so you probably want to disable that first)

#

oh, you'll also need to enable the ModelDestructionDebuggingPatchEnabled option in OpenBodyCams to get that to print, can be done at runtime

gleaming robin Feb 28, 2024, 5:08 PM

#

kk

#

I know these errors are interesting, but they're really just a result of my logging, right? Not my mod failing?

golden basin Feb 28, 2024, 5:09 PM

#

faint copper (OpenBodyCams is present in Lunxara's profile, so you probably want to disable t...

a few things broke in her pack, i sent her a list but i never saw her report the bugs >:C

#

openbodycams, diversity's bracken and one more other mod, cant remember which

faint copper Feb 28, 2024, 5:10 PM

#

hmm, I know the black screen thing was still unresolved last I heard, but I haven't been able to reproduce it even using her profile

gleaming robin Feb 28, 2024, 5:20 PM

#

Okay so that was weird

#

Even after I left the planet, the masked was still registered in the system and throwing update/late update errors

faint copper Feb 28, 2024, 5:40 PM

#

yeah, I wondered if it was not getting despawned correctly

gleaming robin Feb 28, 2024, 5:55 PM

#

Yeah, anytime I step into the ship EnableEnemyMesh fires, so I might need to find a better method to hook into

gleaming robin Feb 28, 2024, 7:00 PM

#

@copper yew how are you going about removing the mask from the MaskedEnemy?

#

nvm, thought I was on to something with that

rocky fable Feb 28, 2024, 7:22 PM

#

gleaming robin

You told me to break it but I didn't expect that build to break the game that hard XD

#

Freaking out cus the bees didn't despawn

#

Lol

gleaming robin Feb 28, 2024, 7:23 PM

#

yea that was amazing lol

rocky fable Feb 28, 2024, 7:23 PM

#

It really was XD

gleaming robin Feb 28, 2024, 7:24 PM

#

Also with your code masked were completely borked

rocky fable Feb 28, 2024, 7:24 PM

#

Yeah which is funny cus the only 3 mods that touch them are

gleaming robin Feb 28, 2024, 7:24 PM

#

So I've had to switch to a more condensed testing environment 🤭

rocky fable Feb 28, 2024, 7:24 PM

#

Mirage, MEOFork, and LC Masked Fix

#

lol

#

No other mod there should touch them

#

If Mirage and MEOFork don't touch those functions that were breaking like qwbarch said

#

Hmmmm

#

LC Masked Fix?

#

XD

gleaming robin Feb 28, 2024, 7:27 PM

#

well

#

I just tried it with this modlist and the masked was still AI-dead

rocky fable Feb 28, 2024, 7:28 PM

#

Oh Huh

#

@copper yew

#

Bruh if it's OpenBodyCams somehow

#

☠️

#

There's no way right?

gleaming robin Feb 28, 2024, 7:28 PM

#

gonna test with no mirage, then with no bodycam + with mirage

rocky fable Feb 28, 2024, 7:28 PM

#

Yeah

gleaming robin Feb 28, 2024, 7:28 PM

#

~~I really should be working on my moons~~

rocky fable Feb 28, 2024, 7:29 PM

#

gleaming robin ~~I really should be working on my moons~~

Haha I feel you XD

ornate onyx Feb 28, 2024, 7:29 PM

#

gleaming robin ~~I really should be working on my moons~~

Bro i still havnt tried any of your moons

gleaming robin Feb 28, 2024, 7:29 PM

#

ornate onyx Bro i still havnt tried any of your moons

hold off then

#

new update is big

ornate onyx Feb 28, 2024, 7:29 PM

#

Even though i read every changelog and shit

rocky fable Feb 28, 2024, 7:29 PM

#

After all this hard work I've been seeing this man do to fix the masked

#

Gonna use them for sure lol

#

Every Starlancer mod is a must now

ornate onyx Feb 28, 2024, 7:30 PM

#

gleaming robin new update is big

I have it in my pack its just i had a lotta of issues to fix cuz i had reconfig a lot of stuff cuz i removed AC

gleaming robin Feb 28, 2024, 7:33 PM

#

rocky fable Every Starlancer mod is a must now

That's very sweet of you to say :3

#

I want more people to use my music tbh

#

I haven't heard anyone talk about it

rocky fable Feb 28, 2024, 7:34 PM

#

Added it

#

Time to go buy Boombox

gleaming robin Feb 28, 2024, 7:35 PM

#

@faint copper just gonna go ahead and upload this for reference. This is just with AIFix, BodyCam, and DanceTools

📎 LogOutput.log

rocky fable Feb 28, 2024, 7:35 PM

#

gleaming robin <@193574164639121409> just gonna go ahead and upload this for reference. This is...

It brokey again?

gleaming robin Feb 28, 2024, 7:35 PM

#

Nope, Masked worked fine

rocky fable Feb 28, 2024, 7:35 PM

#

Okay okay good

gleaming robin Feb 28, 2024, 7:36 PM

#

Now testing with just Mirage

rocky fable Feb 28, 2024, 7:36 PM

#

I wonder what in Mirage's code is doing it then now or if the 2 mods have a weird conflict lol

gleaming robin Feb 28, 2024, 7:36 PM

#

we finna find out

faint copper Feb 28, 2024, 7:36 PM

#

gleaming robin <@193574164639121409> just gonna go ahead and upload this for reference. This is...

am I wrong or does this have no null renderers in the logs?

gleaming robin Feb 28, 2024, 7:37 PM

#

faint copper am I wrong or does this have no null renderers in the logs?

I believe you are correct, which means the null renderers are probably the fault of cosmetics?

faint copper Feb 28, 2024, 7:37 PM

#

sorry I meant null not non-null

#

guess you got the idea though lol

gleaming robin Feb 28, 2024, 7:37 PM

#

also, this is just with Mirage and DanceTools 😬

rocky fable Feb 28, 2024, 7:38 PM

#

OOF

#

@copper yew

#

Fix

#

Lol

#

I'm vibing to this boombox right now

#

XD

gleaming robin Feb 28, 2024, 7:39 PM

#

gleaming robin also, this is just with Mirage and DanceTools 😬

yea this is definitely Masked = Broken

#

I'm gonna test your code again, but without Mirage

rocky fable Feb 28, 2024, 7:39 PM

#

Yeah go for it

#

Now it's just isolating the issue in Mirage's code somehow if it's fine with MEOFork lol

gleaming robin Feb 28, 2024, 7:41 PM

#

No breaking or nulls upon spawn

rocky fable Feb 28, 2024, 7:41 PM

#

Weird

#

Did you also test with the option for compat with Mirage unticked?

#

Wonder if that MimickingPlayer flag is causing something

gleaming robin Feb 28, 2024, 7:43 PM

#

Ah, I didn't

#

No nulls upon leaving. Gonna try again with a shit-ton of cosmetics

copper yew Feb 28, 2024, 7:43 PM

#

gleaming robin <@193574164639121409> ??????????

see i knew that thing is null 😭

rocky fable Feb 28, 2024, 7:43 PM

#

gleaming robin Feb 28, 2024, 7:43 PM

#

welp, the game crashed xD

rocky fable Feb 28, 2024, 7:44 PM

#

untick that option to allow MEOFork to control them similarly XD

gleaming robin Feb 28, 2024, 7:44 PM

#

kk

copper yew Feb 28, 2024, 7:44 PM

#

faint copper the `==` operator is overloaded to also check whether an object has been `Destro...

TIL never knew this

rocky fable Feb 28, 2024, 7:44 PM

#

Was standing in the lobby vibing to boombox when I screenshotted that

gleaming robin Feb 28, 2024, 7:45 PM

#

Is mine the only music mod you have? Just checking to make sure you were hearing my songs 🤭

copper yew Feb 28, 2024, 7:45 PM

#

gleaming robin <@497541811359711263> how are you going about removing the mask from the MaskedE...

ill send the patch in a sec

rocky fable Feb 28, 2024, 7:45 PM

#

Yeah it was definitely your songs haha

#

The only other mod I have that might is Lethal Resonance but it doesn't touch the radio right now as far as I'm aware

copper yew Feb 28, 2024, 7:46 PM

#

gleaming robin also, this is just with Mirage and DanceTools 😬

mirage doesnt affect these methods though, weird...

gleaming robin Feb 28, 2024, 7:46 PM

#

copper yew ill send the patch in a sec

kk, I'm gonna test it with MEO fork compat disabled + no cosmetics, then with a ton of cosmetics. I'll have to test your patch later unfortunately, I gotta go to the store 🤭

rocky fable Feb 28, 2024, 7:48 PM

#

copper yew mirage doesnt affect these methods though, weird...

That's why I theorized something with the MimickingPlayer flag may be doing it

#

We know something is going brrrrr

#

XD

gleaming robin Feb 28, 2024, 7:49 PM

#

Masked AI didn't break, testing with many cosmetics now

#

gdi it crashed again

rocky fable Feb 28, 2024, 7:50 PM

#

☠️

#

If that's the case I wonder wtf in Mirage could even cause it

gleaming robin Feb 28, 2024, 7:51 PM

#

cursed

rocky fable Feb 28, 2024, 7:51 PM

#

Haha

copper yew Feb 28, 2024, 7:51 PM

#

mimickingPlayer wouldn't be my problem

#

this issue might be MC not doing a null check

rocky fable Feb 28, 2024, 7:51 PM

#

True

#

So maybe a compatibility patch for MoreCompany would need to be made

copper yew Feb 28, 2024, 7:52 PM

#

@gleaming robin this is how i disable mask textures: https://github.com/qwbarch/lc-mirage/blob/83691cb735359303431b87eddf5346c180f5b407/package/mirage/src/Mirage/Patch/SpawnMaskedEnemy.fs#L98-L104

GitHub

lc-mirage/package/mirage/src/Mirage/Patch/SpawnMaskedEnemy.fs at 83...

A Lethal Company mod that mimics player voices. Contribute to qwbarch/lc-mirage development by creating an account on GitHub.

#

idk if you can read that since it's F# but GetComponentsInChildren<Transform>() i think returns a List<Transform>

#

so i just filter for only the ones with HeadMask in its name

#

and set it as non active

gleaming robin Feb 28, 2024, 7:55 PM

#

Well to further add to the confusion, still no nulls

rocky fable Feb 28, 2024, 7:56 PM

#

So MEO has whatever is causing this dealt with

#

Or doesn't touch what might be doing it

gleaming robin Feb 28, 2024, 7:56 PM

#

I had disabled Diversity and Symbiosis earlier bc they were annoying me (the sassy ship voice, but I don't even remember why Symbiosis was), so I'll test that later

#

I gotta head to the store tho, so I'll be back later y'all 👋

rocky fable Feb 28, 2024, 7:56 PM

#

gleaming robin I had disabled Diversity and Symbiosis earlier bc they were annoying me (the sas...

Symbiosis includes a fix for the Yippee

#

Lol

#

Also you can disable the ship voice in Diversity

#

🤣🤣😭😭

#

I love the new voice

#

:3

gleaming robin Feb 28, 2024, 7:58 PM

#

It just got grating after hearing it so much so fast in my loading and exiting 🤭

rocky fable Feb 28, 2024, 7:58 PM

#

lol that's fair

copper yew Feb 28, 2024, 8:02 PM

#

MEO wrote its own patch to apply MC cosmetics it seems:

internal class MoreCompanyPatch
    {
        public static void ApplyCosmetics(MaskedPlayerEnemy masked)
        {
            //IL_00de: Unknown result type (might be due to invalid IL or missing references)
            //IL_00e8: Unknown result type (might be due to invalid IL or missing references)
            if (!MainClass.showCosmetics || MainClass.playerIdsAndCosmetics.Count == 0)
            {
                return;
            }
            Transform val = ((Component)masked).transform.Find("ScavengerModel").Find("metarig");
            CosmeticApplication component = ((Component)val).GetComponent<CosmeticApplication>();
            if (Object.op_Implicit((Object)(object)component))
            {
                component.ClearCosmetics();
                Object.Destroy((Object)(object)component);
            }
            List<string> list = MainClass.playerIdsAndCosmetics[(int)masked.mimickingPlayer.playerClientId];
            component = ((Component)val).gameObject.AddComponent<CosmeticApplication>();
            foreach (string item in list)
            {
                component.ApplyCosmetic(item, true);
            }
            foreach (CosmeticInstance spawnedCosmetic in component.spawnedCosmetics)
            {
                Transform transform = ((Component)spawnedCosmetic).transform;
                transform.localScale *= 0.38f;
            }
        }
    }

#

but for mirage i let morecompany handle that themselves

#

which means it's probably an MC bug

rocky fable Feb 28, 2024, 8:02 PM

#

Yeah

#

So it seems it's time to implement that patch ^^

copper yew Feb 28, 2024, 8:03 PM

#

nope that means MC has to fix it 😛

#

(if it really is MC at least)

#

which i'll report after i test it a bit to make sure

rocky fable Feb 28, 2024, 8:03 PM

#

👍

#

It could also be weirdness somehow regarding having MC handle the cosmetics itself vs a patch

copper yew Feb 28, 2024, 8:04 PM

#

cosmetic mods are supposed to handle it themselves

#

idk why MEO even has a custom patch for it

rocky fable Feb 28, 2024, 8:04 PM

#

If that's really the case though then uh

#

Why did that bug also happen with [REDACTED] before?

copper yew Feb 28, 2024, 8:04 PM

#

dunno

rocky fable Feb 28, 2024, 8:04 PM

#

Hmmmmm

copper yew Feb 28, 2024, 8:04 PM

#

tbf idk waht the issue is yet since it's never happened to me

#

other than just looking at the error messages

rocky fable Feb 28, 2024, 8:05 PM

#

Yeah it's odd

empty pivot Feb 28, 2024, 8:05 PM

#

gleaming robin It just got grating after hearing it so much so fast in my loading and exiting �...

I almost went at lethalresonance for it lol

#

I never expected Diversity of all mods to f with the ship voice 🤣

rocky fable Feb 28, 2024, 8:06 PM

#

empty pivot I almost went at lethalresonance for it lol

"Yoohoooo dogs they're in here fresh and full of fear!!!!"

empty pivot Feb 28, 2024, 8:06 PM

#

it says that???

rocky fable Feb 28, 2024, 8:06 PM

#

It does if a dog is close to the ship yeah, the new voice is a troll

#

It's great XD

empty pivot Feb 28, 2024, 8:07 PM

#

all I know is that it bugs me when the quota is reached because I was doing testing prior to the nuclear fallout

#

haven't been able to play any session after diversity's update

rocky fable Feb 28, 2024, 8:07 PM

#

I love the new voice tbh

empty pivot Feb 28, 2024, 8:07 PM

#

not due to diversity- due to the fallout 'n poor timing

rocky fable Feb 28, 2024, 8:07 PM

#

Yeah I already got my replacements going

empty pivot Feb 28, 2024, 8:08 PM

#

doesn't help that during the testing of ensuring the next session is ready - the save I had was on deadline day

#

so EVERY DAMN TIME I launched the cheat-save to test things, I always hear him yapping

#

and you can't even disable the bastard by pressing E on the speaker

rocky fable Feb 28, 2024, 8:08 PM

#

Lmao

#

That's when you land the ship and sell stuff

#

XD

empty pivot Feb 28, 2024, 8:08 PM

#

so I'm well aware of his quota talk and can't-disable-me jargon-

#

but the darn mods I was testing could be tested on company building >n>

#

selling things, testing prices, items, etc

#

it just so happened* to be convenient to have a cheat save on deadline day so stuff sells at 100%

#

lotta good all that balancing did 😒

#

wasted damn hours is what it concluded to be.

copper yew Feb 28, 2024, 8:10 PM

#

gleaming robin No breaking or nulls upon spawn

wait so how do i reproduce this error again? lmk when ur free

rocky fable Feb 28, 2024, 8:57 PM

#

copper yew wait so how do i reproduce this error again? lmk when ur free

for me I had it happen when I went to Vow with the most recent 2 dev builds of AIFix when a Masked would spawn in if that helps, I'd use the latest one though since it'll report more specific errors

#

Just prepare to have the game freak out if you leave the planet XD

copper yew Feb 28, 2024, 8:59 PM

#

it spams it nonstop right

#

im assuming until the ship goes back to space

rocky fable Feb 28, 2024, 8:59 PM

#

copper yew it spams it nonstop right

yeah

copper yew Feb 28, 2024, 8:59 PM

#

ah ic

rocky fable Feb 28, 2024, 9:00 PM

#

copper yew ah ic

You got this

#

👍

gleaming robin Feb 28, 2024, 9:30 PM

#

copper yew MEO wrote its own patch to apply MC cosmetics it seems: ```c# internal class Mor...

Sorry, are you saying you think this is causing the null renderers?

copper yew Feb 28, 2024, 9:38 PM

#

gleaming robin No breaking or nulls upon spawn

referring to this

gleaming robin Feb 28, 2024, 9:38 PM

#

Okay I'm increasingly confused. I can't get any null renders to happen

gleaming robin Feb 28, 2024, 9:39 PM

#

copper yew referring to this

Just trying to be clear, you think it's causing or fixing them?

copper yew Feb 28, 2024, 9:39 PM

#

causing, although i'm not entirely sure on it so i need to confirm it myself before i report it to MC

opal bane Feb 28, 2024, 9:39 PM

#

@gleaming robin I am out of the loop. What is Seamless Dungeon? This sounds like something I will want to have.

gleaming robin Feb 28, 2024, 9:39 PM

#

opal bane <@244591333866602496> I am out of the loop. What is Seamless Dungeon? This sound...

It's currently WIP, not released

#

https://discord.com/channels/1168655651455639582/1202534076855357480

opal bane Feb 28, 2024, 9:40 PM

#

ty!

rocky fable Feb 28, 2024, 9:40 PM

#

Btw @gleaming robin I would love a way to disable the vanilla boombox tracks now lol

gleaming robin Feb 28, 2024, 9:40 PM

#

copper yew causing, although i'm not entirely sure on it so i need to confirm it myself bef...

That makes it worse that I'm not getting any nulls @_@
Unless... Lunxara were you on a previous version when you successfully encountered the NREs?

rocky fable Feb 28, 2024, 9:41 PM

#

The vanilla ones suck XD

rocky fable Feb 28, 2024, 9:41 PM

#

gleaming robin That makes it worse that I'm not getting any nulls @_@ Unless... Lunxara were yo...

The bug where the masked would stand in place?

gleaming robin Feb 28, 2024, 9:41 PM

#

Aww no they don't (well a couple do xD)

rocky fable Feb 28, 2024, 9:41 PM

#

It doesn't happen with the current live version of the AIFix for whatever reason

#

It started with the 2 most recent debug builds

copper yew Feb 28, 2024, 9:42 PM

#

gleaming robin No breaking or nulls upon spawn

idk if i was misunderstanding actually, but just to be clear, i was referring to the error message in this screenshot

gleaming robin Feb 28, 2024, 9:42 PM

#

oh heck

#

maybe my checks are somehow breaking Mirage

rocky fable Feb 28, 2024, 9:42 PM

#

It's still good to figure out what is happening though

#

Yeah possible

gleaming robin Feb 28, 2024, 9:42 PM

#

lemme try without the debug builds

copper yew Feb 28, 2024, 9:42 PM

#

gleaming robin maybe my checks are somehow breaking Mirage

i highly doubt it though

#

ill send you what i interact with from MaskedPlayerEnemy

gleaming robin Feb 28, 2024, 9:43 PM

#

copper yew idk if i was misunderstanding actually, but just to be clear, i was referring to...

ohhh I absolutely could be wrong, but I don't think that error matters for what we're doing

copper yew Feb 28, 2024, 9:43 PM

#

ah

#

but either way

gleaming robin Feb 28, 2024, 9:44 PM

#

that just happened to be there 🤭

copper yew Feb 28, 2024, 9:44 PM

#

mirage really doesn't do much with masked enemies

#

https://github.com/qwbarch/lc-mirage/blob/83691cb735359303431b87eddf5346c180f5b407/package/mirage/src/Mirage/Unity/MimicPlayer.fs#L38-L48

GitHub

lc-mirage/package/mirage/src/Mirage/Unity/MimicPlayer.fs at 83691cb...

A Lethal Company mod that mimics player voices. Contribute to qwbarch/lc-mirage development by creating an account on GitHub.

#

only sets the mimicking player, suit, etc, if the masked enemy isn't null

rocky fable Feb 28, 2024, 9:44 PM

#

copper yew https://github.com/qwbarch/lc-mirage/blob/83691cb735359303431b87eddf5346c180f5b4...

Then that would mean it might be breaking something with the cosmetics right? Didn't you theorize it was something to do with how Mirage handles MC's cosmetics compared to MEO

gleaming robin Feb 28, 2024, 9:45 PM

#

okay so if I remove AI fix Mirage doesn't break :B

rocky fable Feb 28, 2024, 9:46 PM

#

gleaming robin okay so if I remove AI fix Mirage doesn't break :B

Yeah same if when you use the current live 3.1.0 version

gleaming robin Feb 28, 2024, 9:46 PM

#

lemme just retest the debug version to be sure

rocky fable Feb 28, 2024, 9:46 PM

#

You got this

gleaming robin Feb 28, 2024, 9:47 PM

#

lmao yep, something in the debug version breaks masked xD

rocky fable Feb 28, 2024, 9:47 PM

#

I will say the debug version before the 2 most recent ones gave me no issues

gleaming robin Feb 28, 2024, 9:47 PM

#

wtf

rocky fable Feb 28, 2024, 9:47 PM

#

Maybe cross check the code

#

Could be an accidental edit that borked something

gleaming robin Feb 28, 2024, 9:47 PM

#

I'm gonna comment each new line til it works

#

tho...I have a theory :S

copper yew Feb 28, 2024, 9:47 PM

#

rocky fable Then that would mean it might be breaking something with the cosmetics right? Di...

it's not that i handled cosmetics to begin with

rocky fable Feb 28, 2024, 9:47 PM

#

gleaming robin tho...I have a theory :S

Oh?

copper yew Feb 28, 2024, 9:47 PM

#

it's that i set the mimicking player after cosmetic mods tries to read it

#

my fix was that i just made sure mine runs first

copper yew Feb 28, 2024, 9:48 PM

#

gleaming robin okay so if I remove AI fix Mirage doesn't break :B

what's your current changes? i'm surprised anything that you have breaks mirage tbh

gleaming robin Feb 28, 2024, 9:48 PM

#

it's just the extra logging

copper yew Feb 28, 2024, 9:48 PM

#

what the

#

can the gods tell me how that would break compat

#

😭

gleaming robin Feb 28, 2024, 9:49 PM

#

nope

#

but I might be able to in a min

copper yew Feb 28, 2024, 9:49 PM

#

you might be god himself

rocky fable Feb 28, 2024, 9:50 PM

#

I guess Masked enemies don't like to report extra logs

#

XD

gleaming robin Feb 28, 2024, 9:50 PM

#

Maybe I should do like my friend suggested and split the NRE patch into a separate mod

#

since it's not really AI

rocky fable Feb 28, 2024, 9:51 PM

#

You could, would you call it StarlancerMaskedFix?

gleaming robin Feb 28, 2024, 9:52 PM

#

Possibly. Or more descriptively StarlancerNullMeshFix

rocky fable Feb 28, 2024, 9:52 PM

#

Ye

copper yew Feb 28, 2024, 9:52 PM

#

gleaming robin Maybe I should do like my friend suggested and split the NRE patch into a separa...

yeah true actually

gleaming robin Feb 28, 2024, 9:52 PM

#

or NREMeshFix, they're all confusing lol

copper yew Feb 28, 2024, 9:52 PM

#

StarlancerMeshFix for the brand

rocky fable Feb 28, 2024, 9:52 PM

#

I'd be down to have it be seperated if you'd prefer that

queen furnace Feb 28, 2024, 9:53 PM

#

@rocky fable what was the bug that spawn a random player model when you tp someone from ?

#

gleaming robin Feb 28, 2024, 9:53 PM

#

copper yew StarlancerMeshFix for the brand

yea sorry, the Starlancer was implied for NREMeshFix lol

rocky fable Feb 28, 2024, 9:54 PM

#

queen furnace <@165179734194520073> what was the bug that spawn a random player model when you...

Wdym?

queen furnace Feb 28, 2024, 9:55 PM

#

I have this bug and i think i remember you was talking about it, i wanna find the culprit

rocky fable Feb 28, 2024, 9:58 PM

#

I haven't had any bugs relating to tping in a bit

queen furnace Feb 28, 2024, 9:58 PM

#

Yeah it was a while ago i think

rocky fable Feb 28, 2024, 9:58 PM

#

Only time I did was with a bug that got patched in the recent Mirage versions

#

So

#

I can't tell you

queen furnace Feb 28, 2024, 9:59 PM

#

wasn't it latecompany or something ?

rocky fable Feb 28, 2024, 9:59 PM

#

LateCompany causes radar desyncs but so does every late join mod

queen furnace Feb 28, 2024, 9:59 PM

#

oh

rocky fable Feb 28, 2024, 9:59 PM

#

Like I said I can't help you lol

queen furnace Feb 28, 2024, 10:00 PM

#

Ok, Thanks anyway !

copper yew Feb 28, 2024, 10:00 PM

#

whats a radar desync

#

should i not be using LateCompany

sturdy aspen Feb 28, 2024, 10:00 PM

#

empty pivot I almost went at lethalresonance for it lol

Gawd daymn, yall bloodthirsty

copper yew Feb 28, 2024, 10:01 PM

#

pixel was about to get hit by strays

sturdy aspen Feb 28, 2024, 10:01 PM

#

copper yew pixel was about to get hit by strays

Dude fr

#

Also unrelated but audio knight is a sick name

copper yew Feb 28, 2024, 10:02 PM

#

speaking of which

#

i've been curious

#

@gleaming robin are you a sound engineer and a game dev

gleaming robin Feb 28, 2024, 10:02 PM

#

idk what would make you think that
https://thunderstore.io/c/lethal-company/p/AudioKnight/StarlancerMusic/

Thunderstore

StarlancerMusic v1.1.0

Original music for Lethal Company. Part of my Starlancer Series!

copper yew Feb 28, 2024, 10:03 PM

#

oh just cuz the name AudioKnight 😛

#

OH SHIT

#

u have a spotify

#

time to check it out

gleaming robin Feb 28, 2024, 10:03 PM

#

(also not a professional game dev or anything, I put out one short horror game a few years back that was okay for my very first release, but I would have done things way differently now)

gleaming robin Feb 28, 2024, 10:03 PM

#

sturdy aspen Also unrelated but audio knight is a sick name

big preesh ✨

#

@copper yew found it

#

if I directly reference the gameObject it breaks everything

copper yew Feb 28, 2024, 10:10 PM

#

THAT'S IT?

#

like when it's null right

gleaming robin Feb 28, 2024, 10:11 PM

#

yep, and gonna do one more hyper-specific test

copper yew Feb 28, 2024, 10:11 PM

#

it's crazy how one small thing can break everything else

#

kinda like when i had a mod conflict with mirage regarding dead bodies

gleaming robin Feb 28, 2024, 10:17 PM

#

Yee

#

So it completely breaks upon any reference to a component of ___thisNetworkObject

#

so gameObject or NetworkObjectId

empty pivot Feb 28, 2024, 10:19 PM

#

sturdy aspen Gawd daymn, yall bloodthirsty

keyword: almost -3-

#

I did dig through all recently updated mods (I log when things get updated, to ensure I know what fucked something up)

#

tested diversity, it stopped. :p

#

but YOU DID UPDATE ON THE SAME HECKIN' DAY~ -3-

copper yew Feb 28, 2024, 10:24 PM

#

gleaming robin So it completely breaks upon any reference to a component of `___thisNetworkObje...

didn't you do null checks anyways though?

#

that's why i mentioned to do the null checks, since it seemed like the network object was null

#

and if you get a null refernece exception, everything else that was supposed to run after your patch won't run anymore

gleaming robin Feb 28, 2024, 10:29 PM

#

yea I guess I misunderstood the assignment

#

tho I did run the code by you and Zaggy :P

#

Finally getting somewhere

#

A more useful chunk

#

The first cycle is null, the second cycle has 0 null renderers, then the 3rd finds 159 null renderers

#

Gonna test with removing Mirage again, just to see

copper yew Feb 28, 2024, 10:37 PM

#

niceee

copper yew Feb 28, 2024, 10:37 PM

#

gleaming robin Gonna test with removing Mirage again, just to see

lmk, thanks for the tests ❤️

gleaming robin Feb 28, 2024, 10:44 PM

#

Without mirage, it went back to 8 mesh renderers and 0 of them were null. I had forgotten to re-enable MEOF's compat setting, so I did that and it went back up to 326 with 159 null

#

@copper yew I disabled MEOF and all of the null renderers disappeared

#

Took off all my cosmetics, number of renderers went back down to 8 from 167.
0 nulls

#

so for some reason MEOF's compatibility setting with your mod seems to be the issue?

rocky fable Feb 28, 2024, 10:52 PM

#

Why is MEOF causing a bunch of null renderers?

#

Huhhhhhh

#

@devout sedge

#

Need you to shine some light on this XD

rocky fable Feb 28, 2024, 10:54 PM

#

gleaming robin so for some reason MEOF's compatibility setting with your mod seems to be the is...

It's interesting how stuff like this happens

devout sedge Feb 28, 2024, 10:56 PM

#

idk exactly, but MEO yoinks a reference of the masked prefab around the start of the game. for some reason, it uses the ship terminal's 'Start' method for this

#

if AI fix makes copies and modifies them, there will be a mismatch as MEO would replace them with the old prefabs

gleaming robin Feb 28, 2024, 10:59 PM

#

The NRE issue was present beforehand, which is what sent me down this rabbit-hole lol
All I'm doing is checking for null renderers and then removing them

copper yew Feb 28, 2024, 11:01 PM

#

wait so with just mirage and meof the problem isnt there?

devout sedge Feb 28, 2024, 11:02 PM

#

so something is adding a heck ton of a lot of mesh renderer?

copper yew Feb 28, 2024, 11:02 PM

#

ill take a look at MEOF later to see if i have any ideas, but i remember coppertiel's changes looking fine to me

rocky fable Feb 28, 2024, 11:02 PM

#

copper yew ill take a look at MEOF later to see if i have any ideas, but i remember coppert...

Could be something in just the base MEO code tbh

devout sedge Feb 28, 2024, 11:02 PM

#

it's mostly the same with only a few changes

gleaming robin Feb 28, 2024, 11:02 PM

#

copper yew wait so with just mirage and meof the problem isnt there?

I'd need to check that in isolation, but this test shows that MEOF + Mirage + MEOF Compatibility Patch = null renderers

devout sedge Feb 28, 2024, 11:03 PM

#

it might be something with more company cosmetics?

copper yew Feb 28, 2024, 11:04 PM

#

if MC is open source i might take a look there later

rocky fable Feb 28, 2024, 11:04 PM

#

copper yew if MC is open source i might take a look there later

It is swipez has a github

copper yew Feb 28, 2024, 11:04 PM

#

ah nice

#

it does sound like an MC issue though

rocky fable Feb 28, 2024, 11:05 PM

#

https://github.com/notnotnotswipez/MoreCompany

GitHub

GitHub - notnotnotswipez/MoreCompany

Contribute to notnotnotswipez/MoreCompany development by creating an account on GitHub.

tulip vault Feb 28, 2024, 11:05 PM

#

Looking into this

copper yew Feb 28, 2024, 11:05 PM

#

cuz coppertiel's compat change makes MEOF not apply cosmetics

tulip vault Feb 28, 2024, 11:05 PM

#

yup

#

ew

copper yew Feb 28, 2024, 11:05 PM

#

and mirage just gets MC to do it directly instead

tulip vault Feb 28, 2024, 11:05 PM

#

#

I'm guessing it might be this

rocky fable Feb 28, 2024, 11:06 PM

#

Batby over here finding the issue in a hitch

copper yew Feb 28, 2024, 11:06 PM

#

so fast 😂

rocky fable Feb 28, 2024, 11:06 PM

#

Gotta love Batby 💜 Batby is a pro

gleaming robin Feb 28, 2024, 11:07 PM

#

Hey now, I did a lot 😤

tulip vault Feb 28, 2024, 11:07 PM

#

one sec

rocky fable Feb 28, 2024, 11:07 PM

#

gleaming robin Hey now, I did a lot 😤

You did 💜 you both are pros lol

tulip vault Feb 28, 2024, 11:07 PM

#

ill post more

copper yew Feb 28, 2024, 11:07 PM

#

gleaming robin Hey now, I did a lot 😤

ily

rocky fable Feb 28, 2024, 11:07 PM

#

I love all of you 💜

#

Amazing mod devs each of you

gleaming robin Feb 28, 2024, 11:10 PM

#

@tulip vault Assuming I keep this fix, I might push it into a separate mod. Is there a better place to call it than prefixing EnableEnemyMesh? It fires frequently inside the ship

rocky fable Feb 28, 2024, 11:10 PM

#

gleaming robin <@97329742172151808> Assuming I keep this fix, I might push it into a separate m...

I think you should definitely keep it

gleaming robin Feb 28, 2024, 11:11 PM

#

It does seem handy as a safety-net

tulip vault Feb 28, 2024, 11:11 PM

#

until you learn transpilers you could probably get away with just remaking that function w/ the null check built in and prefix returning false tbh

rocky fable Feb 28, 2024, 11:11 PM

#

Pushing it as a seperate mod makes sense, and you might even be able to merge in a fix for what MC is doing as well

gleaming robin Feb 28, 2024, 11:12 PM

#

tulip vault until you learn transpilers you could *probably* get away with just remaking tha...

Ah and then it would only be firing as often as vanilla

devout sedge Feb 28, 2024, 11:13 PM

#

are cosmetics accidentally being added to the masked enemy prefab? does the number of mesh renderers build up over time?

tulip vault Feb 28, 2024, 11:13 PM

#

gleaming robin Ah and then it would only be firing as often as vanilla

and you wouldnt need to validate the list, just null check before the comparison (allow nulls to exist in the list)

#

since in this context it's not really your responsability to validate the lists, as it's a mod/s issue

gleaming robin Feb 28, 2024, 11:15 PM

#

devout sedge are cosmetics accidentally being added to the masked enemy prefab? does the numb...

There's 8 mesh renderers by default. My situation where I had a bunch of cosmetics bumped it up to 167 (an increase of 159), the compatibility patch then made it 326 (which was another increase of 159), so it's doubling them, but only once

tulip vault Feb 28, 2024, 11:16 PM

#

The primary issue here I believe is something the MoreCompany dev missed, and the masked enemy overhaul dev might have missed it too

#

it's doubling them because both mods do the same thing

#

i dont know how that happened but

#

#

both add the cosmetics to the mimic

devout sedge Feb 28, 2024, 11:17 PM

#

yeah, it's called here https://github.com/Capital-Asterisk/MaskedEnemyOverhaul/blob/671d11d8cab4d76162a34510c3e17219a4e893b4/Patches/MaskedVisualRework.cs#L79C1-L79C61

#

i never really touched this part, left it as is

rocky fable Feb 28, 2024, 11:18 PM

#

So essentially to fix the issue of it doubling would be for MEOF to get an update that removes that patch basically

#

Since they're both doing the same thing

tulip vault Feb 28, 2024, 11:19 PM

#

thats not the main issue

rocky fable Feb 28, 2024, 11:19 PM

#

Ah okay okay

devout sedge Feb 28, 2024, 11:19 PM

#

if this somehow doesn't happen on the original MEO then that would be strange

rocky fable Feb 28, 2024, 11:19 PM

#

It likely does

tulip vault Feb 28, 2024, 11:19 PM

#

I'm still trying to figure it out but I can't actually find where any of this gets called before Start in order for these components to even be in the list

#

but regardless

#

both mods versions of this code don't consider adding or removing from the enemyAI.meshRenderers and enemyAI.skinnedMeshRenderers list when they destroy stuff

#

im assuming because obv. the system was built for players and the mimic stuff was kinda chucked on ontop which might of had a little less research

#

(and of course, in normal circumstances it doesn't\ throw an error)

tulip vault Feb 28, 2024, 11:21 PM

#

tulip vault I'm still trying to figure it out but I can't actually find where any of this ge...

ohhhh im dumb

#

yeah were good

#

is the more company dev and/or the masked enemy overhaul dev contactable on here?

rocky fable Feb 28, 2024, 11:22 PM

#

tulip vault is the more company dev and/or the masked enemy overhaul dev contactable on here...

The MEO dev is yeah, granted he's not very active rn

tulip vault Feb 28, 2024, 11:22 PM

#

mhm

rocky fable Feb 28, 2024, 11:23 PM

#

That's why Coppertiel is actively maintaining the fork currently with HomelessGinger's blessing

tulip vault Feb 28, 2024, 11:23 PM

#

if someone wants to make a little mod that fixes this or if @gleaming robin wants to put it in their mod for now just let me know and i can explain the exact thing you'd want to do to fix this

#

ahhh

rocky fable Feb 28, 2024, 11:24 PM

#

So I'm sure MEOF could implement the fix

devout sedge Feb 28, 2024, 11:26 PM

#

I can probably just move the ApplyCosmetics line up into if (!Plugin.DontTouchMimickingPlayer)'s block

#

there's no point in calling ApplyCosmetics if it doesn't even touch mimickingPlayer

#

assuming of course that its purpose is to change the mimicking player and cosmetic after MoreCompany had set it

#

though I have a feeling this is something that had just never worked

#

since MoreCompany's code runs after MEO

gleaming robin Feb 28, 2024, 11:28 PM

#

tulip vault if someone wants to make a little mod that fixes this or if <@244591333866602496...

I've got the null-check code ready to go, and it would be a nice safety net in case other mods end up doing a similar thing.
In this case would a transpiler still be better if it can just be avoided by ignoring the nulls?

tulip vault Feb 28, 2024, 11:29 PM

#

@devout sedge Basically because MC and/or MEO uses SetEnemyOutside() as a target to do this code it does add any potential cosmetics to the mimic before it collects them via GetComponentsInChildren because Start happens on the next frame

But, .ClearCosmetics doesn't strip destroyed .GameObjects from those lists.

In theory the easiest way to resolve this might be postfixing MC's .ClearCosmetics, Checking if the gameobject the component is attatched to has a EnemyAI (or derivative) component and then if it does validating those lists and removing any nulls

devout sedge Feb 28, 2024, 11:34 PM

#

MEO postfixes MaskedPlayerEnemy::Start. as of now I don't have much knowledge of what order these are called

devout sedge Feb 28, 2024, 11:37 PM

#

tulip vault

and what's wrong with this function?

copper yew Feb 28, 2024, 11:39 PM

#

devout sedge since MoreCompany's code runs after MEO

i wonder why MEO has a custom patch for it then if MC applies after anyways

devout sedge Feb 28, 2024, 11:39 PM

#

^ i'm now unsure about this, after "Start happens on the next frame"

tulip vault Feb 28, 2024, 11:39 PM

#

ye gimmie sec

#

writing up in detail

devout sedge Feb 28, 2024, 11:42 PM

#

all this random 'anything can change anywhere' nonsense makes me feel like eventually porting a certain framework of mine to C#

gleaming robin Feb 28, 2024, 11:45 PM

#

gleaming robin I've got the null-check code ready to go, and it would be a nice safety net in c...

I just ran a test and for some reason the null check didn't work. I might've copied it back down wrong, but I'm gonna eat some dinner and be back later

tulip vault Feb 28, 2024, 11:47 PM

#

this will be two messages holdup

copper yew Feb 28, 2024, 11:48 PM

#

devout sedge all this random 'anything can change anywhere' nonsense makes me feel like event...

are u talking about a dynamically typed language

undone copper Feb 28, 2024, 11:48 PM

#

a jester followed us with lethalescape t o the ship as intended, but it appeared closed even when eating us... should i be asking here?

copper yew Feb 28, 2024, 11:50 PM

#

undone copper a jester followed us with lethalescape t o the ship as intended, but it appeared...

if you have starlancer ai fix then probably yeah, audioknight just went to get dinner so give him a bit

undone copper Feb 28, 2024, 11:51 PM

#

im going to sleep in a few mins too haha it ok

#

just keeping this here then

tulip vault Feb 28, 2024, 11:51 PM

#

In basegame, EnemyAI does this in Start()

    public virtual void Start()
        this.agent = base.gameObject.GetComponentInChildren<NavMeshAgent>();
        this.skinnedMeshRenderers = base.gameObject.GetComponentsInChildren<SkinnedMeshRenderer>();
        this.meshRenderers = base.gameObject.GetComponentsInChildren<MeshRenderer>();

This populates the list with all the found Renderers attatched to the parent and/or it's children.

More Company applies cosmetics to the mimic in the function that spawns the mimic, utilizing the basegame call ofMaskedPlayerEnemey.SetEnemyOutside() that is called on the same frame. This means it's running before Start() so the basegame code above is correctly adding these new cosmetics to those lists.

There's two big issues though, first one being on More Company's side. This is a problem caused by More Company but on it's own never actually happens on it's own.

The ClearCosmetics() function in More Company here

    public void ClearCosmetics()
        {
            foreach (var spawnedCosmetic in spawnedCosmetics)
            {
                GameObject.Destroy(spawnedCosmetic.gameObject);
            }
            spawnedCosmetics.Clear();
        }

Was built for players, not mimics. When the Cosmetic GameObject is destroyed, the components on it are destroyed too. This includes the MeshRenderer's which are not being removed from the EnemyAI lists that obtained them on Start().

#

the second issue, being on MEO's Side, is the problem that causes the problem in More Company to actually occur.

The ApplyCosmetics() function here (stripped of irrelevant code to fit in the message) is run on a Postfix to EnemyAI.Start().
        public static void ApplyCosmetics(MaskedPlayerEnemy masked)
        {
            Transform cosmeticRoot = masked.transform.Find("ScavengerModel").Find("metarig");
            CosmeticApplication cosmeticApplication = cosmeticRoot.GetComponent<CosmeticApplication>();
            if (cosmeticApplication)
            {
                cosmeticApplication.ClearCosmetics();
                GameObject.Destroy(cosmeticApplication);
            }


            List<string> playerCosmetics = MoreCompany.MainClass.playerIdsAndCosmetics[(int)masked.mimickingPlayer.playerClientId];
            cosmeticApplication = cosmeticRoot.gameObject.AddComponent<CosmeticApplication>();
            foreach (var cosmetic in playerCosmetics)
            {
                cosmeticApplication.ApplyCosmetic(cosmetic, true);
            }
        }

#

This code finds the CosmeticApplication that was already added via More Company before the EnemyAI.Start() ran and runs ClearCosmetics() on it. Destroying every Cosmetic MeshRenderer that was already added to the mimic and included in the lists that were populated in Start(). So now the list has null references. Also. Because this code is running as a Postfix, the Cosmetics MEO is re-adding have missed the window to be automatically added to those lists via the basegame code, and code has not been added to manually add these new Renderers to the lists after the fact. So in theory the Mimic's .meshRenderers and .skinnedMeshRenderers lists have both null references and are missing the actual cosmetic meshrenders that didn't get destroyed.

#

long ahhh post

devout sedge Feb 28, 2024, 11:55 PM

#

copper yew are u talking about a dynamically typed language

you seem to like F#? not really language-related though. another project of mine has a task system that can very effectively order tasks based on a description of how they access certain variable. 'Task A writes to a queue, Task B reads from it, so Task A runs before Task B' but with a bunch of other weird things that allow it to be perfectly rolled into a game loop

gleaming robin Feb 28, 2024, 11:57 PM

#

undone copper a jester followed us with lethalescape t o the ship as intended, but it appeared...

Still not quite back, but can you send the log?

undone copper Feb 28, 2024, 11:58 PM

#

oh unfortunately i dont have it........

#

but if ithappens again ill be sure to grab it

#

ive started another game since

#

several

devout sedge Feb 28, 2024, 11:58 PM

#

tulip vault In basegame, EnemyAI does this in Start() ```cs public virtual void Start() ...

nice. so one way to go about this is make a custom ClearCosmetics function for mimics in MEO, or manually clear meshRenderers?

copper yew Feb 29, 2024, 12:01 AM

#

devout sedge you seem to like F#? not really language-related though. another project of min...

im actually not a big fan of f#, i just wanted to try it out so i used it for mirage.
it's still more ergonomic than c# (imo) so ill probably still use it for lc mods

never really heard of this task system type of thing for game loops. is there a name for this pattern?

tulip vault Feb 29, 2024, 12:01 AM

#

on a "just fixing the issue" side of things answer. i would just postfix whatever version of ApplyCosmetics and ClearCosmetics is being used to check if the gameobject that has the CosmeticApplication component has a enemyAI, and if it does ensure those two lists either have nulls removed or new meshrenderers added

on a specific to your side of things answer, i would look into if still need to be doing all the MoreCompanyCosmetic related stuff in MEO. as from a glance it kinda seems like at some point MC adapted the patch MEO implemented directly

devout sedge Feb 29, 2024, 12:10 AM

#

copper yew im actually not a big fan of f#, i just wanted to try it out so i used it for mi...

afaik, it's original. I personally call it the "Sovapine-2 Non-Kikiki Pipeline Subsystem." "Kikiki" refers to uncertainty/randomness on when memory locations are modified. at least for what I'm using it for, it works far too well for making a game composable and perfectly fits my game's systems. i think it sometimes makes me sound like a conspiracy theorist when I talk about it.

devout sedge Feb 29, 2024, 12:10 AM

#

tulip vault on a "just fixing the issue" side of things answer. i would just postfix whateve...

is any other mod besides MEO using ClearCosmetics on masked?

tulip vault Feb 29, 2024, 12:12 AM

#

Wouldn't know

rocky fable Feb 29, 2024, 12:14 AM

#

devout sedge is any other mod besides MEO using ClearCosmetics on masked?

Not that I can tell

#

None of the ones I've used have anyways

devout sedge Feb 29, 2024, 12:16 AM

#

ClearCosmetics touching EnemyAI introduces additional coupling that seems like a bad idea. since meshRenderers is set by EnemyAI, i'd say it makes sense for something postfixed in MaskedEnemy to modify it

copper yew Feb 29, 2024, 12:17 AM

#

devout sedge afaik, it's original. I personally call it the "Sovapine-2 Non-Kikiki Pipeline S...

interesting, is your source available? just wanna take a look at how this works

devout sedge Feb 29, 2024, 12:18 AM

#

quite moderate in size and it's C++, good luck https://github.com/TheOpenSpaceProgram/osp-magnum/blob/master/test/tasks/main.cpp

gleaming robin Feb 29, 2024, 2:25 AM

#

Update on the NRE situation @copper yew @rocky fable @devout sedge :
Until/Unless a solution presents itself to sweep through the enemy mesh renderers once and clear out the nulls, I have managed to successfully replace the EnableEnemyMesh code via prefix to simply ignore any null instances, thus preventing any NREs.

#

oh and @faint copper

last robin Feb 29, 2024, 2:25 AM

#

So what does this do?

rocky fable Feb 29, 2024, 2:25 AM

#

gleaming robin Update on the NRE situation <@497541811359711263> <@165179734194520073> <@188063...

Ayyyyyyy

gleaming robin Feb 29, 2024, 2:25 AM

#

last robin So what does this do?

The mod, or what I just posted about?

last robin Feb 29, 2024, 2:26 AM

#

The mod

gleaming robin Feb 29, 2024, 2:27 AM

#

A helper mod that automatically assigns the correct interior or exterior AI to an enemy when they spawn depending on if they are inside or outside of the dungeon.

Most moon creators will be adding this as a dependency so they can put enemies on either spawn list, but it can also be used by normal modders that want to force spawn enemies outside for fun

faint copper Feb 29, 2024, 2:29 AM

#

tulip vault

oh this makes so much sense

golden basin Feb 29, 2024, 2:30 AM

#

lovely

faint copper Feb 29, 2024, 2:30 AM

#

gleaming robin Update on the NRE situation <@497541811359711263> <@165179734194520073> <@188063...

the only better time to check the arrays would be when MoreCompany or MaskedEnemyOverhaul delete and respawn the cosmetics, but those mods should do it themselves

#

seems good to me

#

but really imo it feels out of scope for your mod since I don't believe anything you do triggers this

#

is qwbarch looking at making a PR for MoreCompany? I saw they were looking at the source earlier

gleaming robin Feb 29, 2024, 2:35 AM

#

golden basin lovely

Yea I'll be pushing out an update shortly and no one will have to deal with that 🤭

golden basin Feb 29, 2024, 2:36 AM

#

lol

#

dunno if its the AI fix but theres insane client desync ongoing when we play

#

i cant imagine it being the AI fix

devout sedge Feb 29, 2024, 2:37 AM

#

i'm currently fixing the null mesh renderers

gleaming robin Feb 29, 2024, 2:37 AM

#

faint copper but really imo it feels out of scope for your mod since I don't believe anything...

I'm torn tbh, because technically this is in the EnemyAI class, and I feel like eventually most people that have the masked mods will probably have AIFix.
I also feel like having a separate mod for just prefixing EnableEnemyMesh is overkill.

But I also recognize what my programmer friend called "the separation of concerns"

gleaming robin Feb 29, 2024, 2:37 AM

#

devout sedge i'm currently fixing the null mesh renderers

oh well there we go then

faint copper Feb 29, 2024, 2:38 AM

#

what I mean is that modifying EnableEnemyMesh() is a bandaid fix, it really ought to be fixed by the people causing the issue

#

I guess they just ~~haven't~~ hadn't realized that they're causing it yet

#

it's a really specific issue, it shouldn't happen with other enemies normally

gleaming robin Feb 29, 2024, 2:39 AM

#

I'll push an update removing the patch, saying that MEOFork is implementing its own fix which would make mine redundant. Ty @devout sedge

gleaming robin Feb 29, 2024, 2:39 AM

#

faint copper it's a really specific issue, it shouldn't happen with other enemies normally

Yea Coppertiel is the dev for MaskedEnemyOverhaulFork

faint copper Feb 29, 2024, 2:39 AM

#

was typing and not reading lol

gleaming robin Feb 29, 2024, 2:39 AM

#

🤭

#

All my coding the past 24 hours wasn't for naught at least, since it helped isolate the problem.

faint copper Feb 29, 2024, 2:40 AM

#

yeah, it's been around for a while, it'll be nice to have one weird spam bug removed

#

it may have also been the cause of some enemies not despawning, but not sure

#

I think there was a mod that was aiming to fix that by just despawning the enemies sooner, wouldn't be surprised if the underlying issue was the null pointers when hiding the enemies before the ship leaves

copper yew Feb 29, 2024, 2:42 AM

#

yeah the enemies not despawning had to do with null exceptions

#

so it could be related

#

i remember network objects being null was the issue

#

where the vanilla code tries to call networkObject.Despawn(), but the network object is null

#

if i remember right at least....

copper yew Feb 29, 2024, 2:43 AM

#

gleaming robin All my coding the past 24 hours wasn't for naught at least, since it helped isol...

❤️

faint copper Feb 29, 2024, 2:43 AM

#

oh, that does seem odd and perhaps unrelated then

#

I'd have to spend a bunch of time reading the surrounding code but I got better things to do lol

#

I guess we'll find out if that still happens eventually

copper yew Feb 29, 2024, 2:44 AM

#

EnemyFix seemed to be enough for people i just never bothered looking at it any deeper

gleaming robin Feb 29, 2024, 2:46 AM

#

Well now that that's handled, time to fix the Jester. Again. @_@

tulip vault Feb 29, 2024, 2:48 AM

#

faint copper what I mean is that modifying `EnableEnemyMesh()` is a bandaid fix, it really ou...

if you scroll up i explained the problem

faint copper Feb 29, 2024, 2:48 AM

#

oh I know the problem

#

I found it yesterday, at least partially

#

I didn't know that MaskedEnemyOverhaul was creating the cosmetics before MoreCompany tried to, but yeah

devout sedge Feb 29, 2024, 2:49 AM

#

this should fix the null renderers

📎 MaskedEnemyRework.dll

tulip vault Feb 29, 2024, 2:49 AM

#

faint copper I didn't know that MaskedEnemyOverhaul was creating the cosmetics _before_ MoreC...

after but same difference

faint copper Feb 29, 2024, 2:49 AM

#

hmmm

tulip vault Feb 29, 2024, 2:49 AM

#

tulip vault In basegame, EnemyAI does this in Start() ```cs public virtual void Start() ...

.

faint copper Feb 29, 2024, 2:50 AM

#

#1206494982521753620 message

#

the initially-created cosmetics would not show up as being destroyed, so this indicates to me that MoreCompany was calling it later

#

I may be wrong though, but that's why I believe it to be the case

devout sedge Feb 29, 2024, 2:54 AM

#

devout sedge this should fix the null renderers

oh ok nevermind this then (actually idk)

faint copper Feb 29, 2024, 2:54 AM

#

also, the stack trace I got indicates that MoreCompany is doing it in the AI interval function? so it would be well after Start()

#

bottom line is MoreCompany needs to fix the issue too

#

but yeah, I wouldn't expect patching it on MEO's side would fix it

gleaming robin Feb 29, 2024, 2:55 AM

#

uh, should I keep my null-check in then?

faint copper Feb 29, 2024, 2:56 AM

#

well.. I wouldn't take my word for it rather than testing to see if the errors are still present, but if your goal is to prevent those errors, I would imagine so

gleaming robin Feb 29, 2024, 2:57 AM

#

to heck with it, I might as well keep it in until I hear it's been solved elsewhere, won't hurt anything and it'll prevent bs @_@

copper yew Feb 29, 2024, 2:58 AM

#

i'm probably gonna try and reproduce the error and just open a PR for MC later

#

@gleaming robin how do i reproduce that exact error

#

probably going to try it tonight

gleaming robin Feb 29, 2024, 3:00 AM

#

I recommend installing DanceTools by dancemoon for ease of testing.

Disable the ai fix
Land on a moon. (Cosmetics may or may not be required, and Vow was my testing ground bc of last night lol)
Spawn a Masked. (Hit tilde, type "enemy masked")
Step out of the ship.
Your log should now be flooded with NREs

copper yew Feb 29, 2024, 3:00 AM

#

is just having mc + meo/meof enough for the test? or should i use your profile code as well

gleaming robin Feb 29, 2024, 3:02 AM

#

iirc it was the meof compatibility patch that triggered the NREs, so it might need mirage as well, but you can try it without, it's a pretty quick test

copper yew Feb 29, 2024, 3:03 AM

#

ah bet, thanks for the detailed steps

devout sedge Feb 29, 2024, 3:03 AM

#

the exception occurs in a patched EnableEnemyMesh though?

gleaming robin Feb 29, 2024, 3:04 AM

#

Calling EEM is what throws the NREs even without modification

devout sedge Feb 29, 2024, 3:08 AM

#

i'm testing right now. With AI fix I can see

[Warning:Starlancer AI Fix] Found null reference inside MaskedPlayerEnemy(Clone)'s meshRenderers. Removing to prevent potential null reference exceptions.

gleaming robin Feb 29, 2024, 3:09 AM

#

The null still exists, but the NRE doesn't occur with the patch

#

The live release of SLAI removes the nulls, but bc of how EEM is called, its kinda spammy. So I'm gonna push new code that instead just replaces EEM so that it has a null-check built into it

copper yew Feb 29, 2024, 3:14 AM

#

whats EEM

gleaming robin Feb 29, 2024, 3:14 AM

#

EnableEnemyMesh

copper yew Feb 29, 2024, 3:14 AM

#

ah

tulip vault Feb 29, 2024, 3:14 AM

#

gleaming robin The live release of SLAI removes the nulls, but bc of how EEM is called, its kin...

ill slide in dms a sec

copper yew Feb 29, 2024, 3:15 AM

#

does that mean a fix for MC won't really be needed

gleaming robin Feb 29, 2024, 3:22 AM

#

I'm cookin with my sous chef

faint copper Feb 29, 2024, 3:28 AM

#

copper yew does that mean a fix for MC won't really be needed

nah, it's still a bandaid to just ignore the nulls

#

if the enemy doesn't know about all attached models then it can't hide properly

copper yew Feb 29, 2024, 3:30 AM

#

honestly if audio knight's changes is good enough as a bandaid fix, im prob gonna skip working on a pr for mc

#

since i'd rather just work on other things if the bandaid fix works

faint copper Feb 29, 2024, 3:31 AM

#

yeah, fair enough

gleaming robin Feb 29, 2024, 3:32 AM

#

I'll handle it for now 🫡

#

~~Just gotta figure out how to make the LEsc jester stop acting like a CLOWN~~

devout sedge Feb 29, 2024, 3:57 AM

#

copper yew does that mean a fix for MC won't really be needed

still very much a bug on MC's end though

#

i think this might be related to the 'invisible masked with floating cosmetics' issue that I've seen a few times

#

though that was a while ago

copper yew Feb 29, 2024, 4:00 AM

#

ah

#

i'll still try and fix it for MC later then

rocky fable Feb 29, 2024, 4:05 AM

#

So updates inc soon?

#

;o

gleaming robin Feb 29, 2024, 4:05 AM

#

rocky fable So updates inc soon?

From who, specifically? 🤭

rocky fable Feb 29, 2024, 4:05 AM

#

Idk lmfao sounded like you were gonna push a mod and Coppertiel is implementing a fix into MEOF

#

and now barch may be implementing a fix into Mirage

#

XD

copper yew Feb 29, 2024, 4:06 AM

#

i'm not implementing it into mirage

#

it's an MC bug

#

if i add a fix it'd be to MC directly

tulip vault Feb 29, 2024, 4:07 AM

#

devout sedge i think this might be related to the 'invisible masked with floating cosmetics' ...

that would line up if MEO's cosmetics were being instansiated but not added to that list

gleaming robin Feb 29, 2024, 4:07 AM

#

ah, my understanding is that barch is gonna put in a PR later for MC, idk about Coppertiel, and I've decided I'm gonna try to make my null-remover better rather than swapping it to a null-check

rocky fable Feb 29, 2024, 4:07 AM

#

gleaming robin ah, my understanding is that barch is gonna put in a PR later for MC, idk about ...

Noice ^^

#

I look forward to your fix

#

💜

gleaming robin Feb 29, 2024, 4:08 AM

#

trying to address this first lol

rocky fable Feb 29, 2024, 4:09 AM

#

Haha

gleaming robin Feb 29, 2024, 4:11 AM

#

so far I'm unable to replicate that specific issue, but I have found that an LEsc jester breaks if its aggressive inside and then warps outside. It'll shut the box, move to one spot, and then not navigate on its own, only when it sees a player again

#

allowing it to attack outside in the first place was tricky, and idk if I can get it to keep its aggro behavior upon warp, but I do want to at least address the nav breaking

devout sedge Feb 29, 2024, 4:17 AM

#

For the renderer stuff, I guess there's kind of a rule that mod devs have to follow: "adding or removing MeshRenderers from enemies must update EnemyAI meshRenderers & skinnedMeshRenderers."

MC should either...

Follow the rule above and fix MimicPatches.cs and update renderers. (MEO has to fix this too) or...
Add EnemyAI support for CosmeticApplication. This probably practical, but I'm not a fan of it as it adds side-effects to existing functions and bloats CosmeticApplication.

copper yew Feb 29, 2024, 4:27 AM

#

im more of a fan of the first option

faint copper Feb 29, 2024, 4:32 AM

#

I think given that CosmeticApplication is attached to an EnemyAI, it would be nice if it did it automatically, but obviously the downside is that it will be allocating and throwing away as many arrays as there are cosmetics because it doesn't apply all of the cosmetics in one function call

#

so yeah, first option probably better as the API stands

gleaming robin Feb 29, 2024, 4:50 AM

#

I wanna put the jester under a hydraulic press

sturdy aspen Feb 29, 2024, 5:20 AM

#

gleaming robin I wanna put the jester under a hydraulic press

mood

sturdy aspen Feb 29, 2024, 5:20 AM

#

gleaming robin I wanna put the jester under a hydraulic press

make a mod

gleaming robin Feb 29, 2024, 5:51 AM

#

Alright so I fixed the nav issue, I think. Testing my latest code I haven't had the issue pop up again.
As far the whole "jester attacking while still in box" thing, that should already be fixed and I couldn't replicate it

gleaming robin Feb 29, 2024, 6:17 AM

#

@copper yew @rocky fable @faint copper let's fucking GOOOOOOOOOOOO. Only fires if the null-check finds a null so it only logs one time

rocky fable Feb 29, 2024, 6:18 AM

#

gleaming robin <@497541811359711263> <@165179734194520073> <@193574164639121409> let's fucking ...

Ayyyyyyyy

#

No more log spam

#

😄

gleaming robin Feb 29, 2024, 6:20 AM

#

just tidying up the log message, then I'll test again and if all goes well push the update

rocky fable Feb 29, 2024, 6:21 AM

#

Look at this chad out here doing work

copper yew Feb 29, 2024, 6:28 AM

#

dubbbbb

gleaming robin Feb 29, 2024, 6:34 AM

#

Lunxara's bepinex is config'd differently then mine so it's missing the info-padding in-between these but I spawned 3 masked with small delays between each - after each spawn, I crossed the "set safe in ship" threshold to trigger EnableEnemyMesh.
Each one only logged one instance of null renderers! And referencing the gameObject didn't break everything!

rocky fable Feb 29, 2024, 6:35 AM

#

Let's gooo 🙂

rocky fable Feb 29, 2024, 6:35 AM

#

gleaming robin Lunxara's bepinex is config'd differently then mine so it's missing the info-pad...

Is there something I should toggle to add that?

#

lol

gleaming robin Feb 29, 2024, 6:37 AM

#

For saving it to the actual log file afterwards

rocky fable Feb 29, 2024, 6:37 AM

#

👍

gleaming robin Feb 29, 2024, 6:38 AM

#

idk about anyone else, but I like seeing how much stuff occurs in-between things happening

#

Here's a slightly better log that I edited a bit

#

I'm so pleased lol

rocky fable Feb 29, 2024, 6:43 AM

#

gleaming robin Here's a slightly better log that I edited a bit

💜

#

You did a great job!!!!

copper yew Feb 29, 2024, 6:49 AM

#

niceeee good shit

#

logs look way better now for sure

gleaming robin Feb 29, 2024, 6:53 AM

#

StarlancerAIFix v3.2.0
- Optimized the NRE patch. It now only runs the null removal if a null reference is found, which also means it doesn't spam the log.
- Fixed an issue where jesters would get stuck in place if they entered the attack behavior outside and then lost their targets.

#

https://thunderstore.io/c/lethal-company/p/AudioKnight/StarlancerAIFix/

Thunderstore

StarlancerAIFix v3.2.0

Automatically assigns interior/exterior AI for enemies based on their spawn location. Also fixes a null reference exception regarding EnableEnemyMesh(). Part of my Starlancer Series!

#

Starlancer AI Fix v3.2.0

#

@rocky fable Be sure to share the logs of the fix working out in the wild!

copper yew Feb 29, 2024, 7:11 AM

#

what's the error log supposed to look like again? i'll share it in #1200695291972685926

rocky fable Feb 29, 2024, 7:12 AM

#

copper yew what's the error log supposed to look like again? i'll share it in <#12006952919...

You should post an update for Mirage btw, so you can make it a recommended mod

copper yew Feb 29, 2024, 7:12 AM

#

yeah i will on my next update

rocky fable Feb 29, 2024, 7:12 AM

#

Starlancer's AI Fix is now needed by everyone

copper yew Feb 29, 2024, 7:12 AM

#

just don't wanna push an update just to change the readme xd

gleaming robin Feb 29, 2024, 7:23 AM

#

copper yew what's the error log supposed to look like again? i'll share it in <#12006952919...

either one of these, though the actual bepinex window screenshot still has the "(Unity.Netcode.NetworkObject)" piece

vapid verge Feb 29, 2024, 7:45 AM

#

empty pivot I never expected **Diversity** of all mods to f with the ship voice 🤣

your suffering helped me firgure out how to solve my suffering lmao, thank you

rocky fable Feb 29, 2024, 7:53 AM

#

There you go btw

#

gleaming robin Feb 29, 2024, 8:00 AM

#

LET'S GOOOOOO
I love seeing the variation in the number as well, I'm assuming the two masked had different numbers of cosmetics on?

rocky fable Feb 29, 2024, 8:02 AM

#

They would have both been mimics of me since I was solo, but I never came across the other one I boxxed one cus it popped out of a vent in front of me XD

gleaming robin Feb 29, 2024, 8:06 AM

#

Ohhh you left before the other one fully spawned?

rocky fable Feb 29, 2024, 8:08 AM

#

Possible lol idk

gleaming robin Feb 29, 2024, 8:11 AM

#

Only explanation I can think of for one having 2x as many nulls

rocky fable Feb 29, 2024, 8:11 AM

#

Yeah it would make sense

#

The game certainly performs better without masked spamming NRE's though lol

#

Masked no longer go brrrrr on game performance

gleaming robin Feb 29, 2024, 8:12 AM

#

I'm glad there's a tangible benefit!

#

Was slightly worried that the performance hit wouldn't be mitigated all that much and the main benefit would be a cleaner log
So I'm quite pleased with it being actually effective in that regard

rocky fable Feb 29, 2024, 9:06 AM

#

This one showed up self aware. It was like "Hold up hold up I can explain"

#

XD

gleaming robin Feb 29, 2024, 2:26 PM

#

It was thinking "well ONE of us has to change"

raw rivet Feb 29, 2024, 4:56 PM

#

So, how does this mod work with stuff like the SnatchinBracken which modifies the AI for that enemy?
Will it lose its custom behaviour once its outside and be replaced with this one's?

gleaming robin Feb 29, 2024, 5:09 PM

#

raw rivet So, how does this mod work with stuff like the SnatchinBracken which modifies th...

This is generally designed with compatibility in mind, and only specifically touches Jester, Sandworm, and SpringMan AIs.

The general portion of the patch just gives enemies the appropriate navigation capabilities when they spawn, depending on whether they spawn inside or outside the facility. It doesn't touch any actual behaviors.
The Jester patch is necessary because it has some hardcoded stuff to look inside the facility for players, I give it logic to be aware of players while outside.
The Sandworm patch is a simple reset of its position to a random inside node after it attacks indoors, otherwise it warps to the surface and becomes broken.
The SpringMan patch is a simple patch to let it resume its walking animation once it becomes completely cut-off from players. Purely an aesthetic fix.

All of those are postfixes. I have one prefix for EnableEnemyMesh that detects and removes any null renderers it finds to prevent any Null Reference Exceptions from occurring, which right now is mainly caused by MoreCompany + MaskedEnemyOverhaul, but even after they fix it on their end will serve as a handy safety net to catch any edge-case occurrences.

There's also one patch that's dependent on Lethal Escape or the WIP Seamless Dungeon mod, that does a postfix check on Update() to ensure that the enemy has the correct navigational ability.

raw rivet Feb 29, 2024, 5:11 PM

#

gleaming robin This is generally designed with compatibility in mind, and only specifically tou...

Ah thats great
Today i am gonna test with all 3 to see what happens and if it works well with lethalescape + snatchinbracken

#

i imagine it will break, but thats due to snatchinbracken not knowing where to take the body outside

#

so typically we turn that mod off if we want the bracken to escape, or vice versa

gleaming robin Feb 29, 2024, 5:13 PM

#

Please let me know how it goes! I just took a look at SnatchinBracken's page and yea it's possible that it might break since it'll be setting its position to an inaccessible node.

However, I'm wondering if they have a fallback for the mansion tileset where the bracken room doesn't exist where "if bracken room doesn't exist or can't be reached, use normal favorite spot logic"

raw rivet Feb 29, 2024, 5:16 PM

#

I suggested in their thread they could detect when they're outside and set a new favourite spot at the main entrance

#

then, could then make it so it goes back inside with the body and then resume normal behaviour

gleaming robin Feb 29, 2024, 5:20 PM

#

Possibly, though I wouldn't blame them if they decide that entering/leaving would be out-of-scope for SB. For compatibility and to keep the AI as vanilla as possible I would suggest just doing an outside check before they run their code
if (!isOutside) {set favorite spot to BrackRoom}

raw rivet Feb 29, 2024, 5:24 PM

#

Makes sense, i passed it on to him

gleaming robin Feb 29, 2024, 5:25 PM

#

Sweet, ty :)

raw rivet Feb 29, 2024, 5:25 PM

#

It would be awesome if all 3 mods could play nice

gleaming robin Feb 29, 2024, 5:25 PM

#

For sure!

raw rivet Feb 29, 2024, 5:26 PM

#

gleaming robin This is generally designed with compatibility in mind, and only specifically tou...

Only other thing i would want is for lethalescape to let custom enemies escape
I wonder if starlancer would let them function outside too?

#

like the demogorgon

#

the shy guy already has its own unique ai for leaving without lethal escape

gleaming robin Feb 29, 2024, 5:28 PM

#

Lethal Escape actually does give escaping enemies the correct AI. SLAI disables LEsc's Jester Update() postfix in favor of its own, otherwise the Jester is permanently aggressive but stuck in the box. I added my extra Update() patch to it as a failsafe in case the AI just happens to not update (and like I said for when Seamless Dungeon comes out if it allows enemies to cross nav-thresholds).

raw rivet Feb 29, 2024, 5:30 PM

#

Weird, for me the jester freezes outside upon killing a player, or perhaps when they go indoors
Like just stands still whilst the skull is out and doesnt chase anymore
We only had lethal escape, no other mod that would touch the jester AI in any way
Thats why i was gonna try this mod later to see if it fixes it

gleaming robin Feb 29, 2024, 5:31 PM

#

Unless I'm mistaken, LEsc doesn't have logic for returning indoors, does it?
And yea that's definitely odd, and SLAI should fix that for ya :3

#

The main purpose of the mod was to allow moon creators to put enemies on either spawnlist btw, in case you were curious

raw rivet Feb 29, 2024, 5:43 PM

#

makes sense

raw rivet Feb 29, 2024, 11:16 PM

#

gleaming robin I want more people to use my music tbh

I tried it, its goated, we are keeping it

rocky fable Feb 29, 2024, 11:17 PM

#

All Starlancer mods are goated

#

Change my mind

gleaming robin Feb 29, 2024, 11:19 PM

#

https://tenor.com/view/heart-gif-6447159128561953694

Tenor

undone copper Feb 29, 2024, 11:32 PM

#

how do indoors eyeless dog work lol

#

do they work..

#

it would be so funny..

queen furnace Feb 29, 2024, 11:34 PM

#

They work

undone copper Feb 29, 2024, 11:34 PM

#

no way

gleaming robin Feb 29, 2024, 11:39 PM

#

Everything works with SLAIFix :3c

undone copper Feb 29, 2024, 11:40 PM

#

im enabling their inside spawns in a few intersting places :)))

#

my friends are gonna enjoy it

gleaming robin Feb 29, 2024, 11:44 PM

#

I hope they don't 🤭

undone copper Mar 1, 2024, 1:01 AM

#

4 lootbugs spawned in celeste outside and stole my loot put it out of the ship and protected it as if it was theirs

#

i love it

gleaming robin Mar 1, 2024, 1:08 AM

#

oh snap they went in the ship?

#

I thought they didn't have the nav-logic to do so

queen furnace Mar 1, 2024, 1:21 AM

#

gleaming robin I thought they didn't have the nav-logic to do so

They do in specific conditions, like in maps that the ship is close to the floor like celest they can go in without flying

undone copper Mar 1, 2024, 1:26 AM

#

guess so!! plus lethalescape has a config for making them build nests outside

#

soo that likely came into play too

rocky fable Mar 1, 2024, 5:07 AM

#

Hey @gleaming robin is there a bug right now with the current version of ai fix causing outside enemies to not spawn? I notice I keep having dogs and giants not spawning in and I'm gonna check the log after we end stream cus idk what's going on XD

gleaming robin Mar 1, 2024, 5:08 AM

#

I don't touch anything regarding the actual spawning of enemies, so I don't think it'd be the AI Fix

#

But lemme know if you find something

rocky fable Mar 1, 2024, 5:27 AM

#

My only guess is EnemyFix tbh

#

I took it out

gleaming robin Mar 1, 2024, 5:35 AM

#

rocky fable I took it out

Taking it out solved it? Or you took it out earlier and the lack of it caused the issue?

rocky fable Mar 1, 2024, 5:36 AM

#

gleaming robin Taking it out solved it? Or you took it out earlier and the lack of it caused th...

I just took it out incase it was that, cus it despawns enemies after the first game, and for whatever reason every game after our first round after booting the game would never spawn the outside enemies

#

Only inside ones

gleaming robin Mar 1, 2024, 5:36 AM

#

Ah, weird

rocky fable Mar 1, 2024, 5:37 AM

#

Yeah I thought maybe it was AIFix cus I didn't have this last night, but your mod didn't report errors so I doubt it lol

#

I would love for a fix for Stormy planets spamming this message btw [Warning: Unity Log] Particle System is trying to spawn on a mesh with zero surface area
[Warning: Unity Log] Particle System is trying to spawn on a mesh with zero surface area
[Warning: Unity Log] Particle System is trying to spawn on a mesh with zero surface area
[Warning: Unity Log] Particle System is trying to spawn on a mesh with zero surface area
[Warning: Unity Log] Particle System is trying to spawn on a mesh with zero surface area
[Warning: Unity Log] Particle System is trying to spawn on a mesh with zero surface area
[Warning: Unity Log] Particle System is trying to spawn on a mesh with zero surface area
[Warning: Unity Log] Particle System is trying to spawn on a mesh with zero surface area
[Warning: Unity Log] Particle System is trying to spawn on a mesh with zero surface area

#

Idk why they do that

gleaming robin Mar 1, 2024, 5:47 AM

#

I'm pretty sure that's a vanilla issue

#

It's when the static electricity is building on some scraps that aren't properly set-up

#

At least I'm pretty sure that's happened with some vanilla scraps

rocky fable Mar 1, 2024, 5:48 AM

#

Yeah I just would love for the game to not spam that

#

Lol

golden basin Mar 1, 2024, 7:06 AM

#

rocky fable Change my mind

I dont need to, you dont know how his moons look

rocky fable Mar 1, 2024, 7:06 AM

#

golden basin I dont need to, you dont know how his moons look

lol

rough echo Mar 1, 2024, 8:44 AM

#

I've also seen that specific Unity warning when using YippeeKeyMod and attempting to Yippee as a dead player

raw rivet Mar 1, 2024, 11:55 AM

#

The jester seems to work outside now! Nice!

gleaming robin Mar 1, 2024, 2:38 PM

#

golden basin I dont need to, you dont know how his moons look

At first I really couldn't tell if this was a positive or negative statement lmao

gleaming robin Mar 2, 2024, 4:57 AM

#

Just released StarlancerMoons v1.0 peeps ✨

rocky fable Mar 2, 2024, 5:36 AM

#

I still keep noticing dogs and giants aren't spawning the way they should lol, and I know this wasn't happening before the latest update for AIFix I need to check my logs again to see wtf is going on XD

gleaming robin Mar 2, 2024, 5:40 AM

#

That's very strange. I was testing my moon update and I definitely had outside spawns 🤔

#

You've got quite the modlist tho :P

reef salmon Mar 2, 2024, 6:01 AM

#

jesters seem a bit buggy, they seem to sometimes start cranking while walking with no music, then start properly cranking later

gleaming robin Mar 2, 2024, 6:09 AM

#

gah, I feel like there's gotta be something else causing that, I swear I haven't run into that bug in forever

#

Do you have anything else affecting enemies?

rocky fable Mar 2, 2024, 6:28 AM

#

Weirdly enough the only mod I have installed that posted weird messages in the logs was Better Lobbies lol

#Starlancer AIFix v3.13.2 | EnemyEscape v3.0.0