drowsy willow Jun 9, 2024, 10:31 PM

#

now for the second one

#

so everything works when you create a new save?

leaden flume Jun 9, 2024, 10:31 PM

#

drowsy willow so everything works when you create a new save?

yeah

drowsy willow Jun 9, 2024, 10:31 PM

#

huh

leaden flume Jun 9, 2024, 10:31 PM

#

ig it bugs existing saves

drowsy willow Jun 9, 2024, 10:31 PM

#

weiiird

#

i mean

#

i have no idea what LLL does with the save mod

#

i'm assuming it's that tbh

#

actually let me join an old save

#

HEHEHE

leaden flume Jun 9, 2024, 10:33 PM

#

unhanded rpc exceptions my beloved <3

drowsy willow Jun 9, 2024, 10:34 PM

#

alright

#

i have no idea whatsoever what happened to your save/modpack

#

but umm

#

yeah

leaden flume Jun 9, 2024, 10:34 PM

#

the only thing i did was give myself a quadrillion bucks

drowsy willow Jun 9, 2024, 10:34 PM

#

making a new save works ig

leaden flume Jun 9, 2024, 10:34 PM

#

visited cosmocos

#

and thats it lol

#

it was a test save anyway

drowsy willow Jun 9, 2024, 10:34 PM

#

interesting

leaden flume Jun 9, 2024, 10:34 PM

#

so nothing was lost LOL

drowsy willow Jun 9, 2024, 10:37 PM

#

alrighty

#

well, thanks for the quick testing

leaden flume Jun 9, 2024, 10:38 PM

#

yw :]

drowsy willow Jun 9, 2024, 10:38 PM

#

if y'all ever get any more problems - ping me and i'll get it sorted 😇

#

i've pushed an update to WeatherRegistry, please check it out and let me know if it fixes your issue 🥺

hybrid crescent Jun 9, 2024, 10:45 PM

#

drowsy willow i've pushed an update to WeatherRegistry, please check it out and let me know if...

Thanks a lot for this!

hybrid crescent Jun 10, 2024, 11:21 AM

#

drowsy willow i've pushed an update to WeatherRegistry, please check it out and let me know if...

It's working so far!!

rancid gull Jun 10, 2024, 5:31 PM

#

(Orion)

eclipse not eclipsing?

#

happened with march earlier

drowsy willow Jun 10, 2024, 7:10 PM

#

rancid gull (Orion) eclipse not eclipsing?

huh

#

what's your modpack code?

rancid gull Jun 10, 2024, 7:13 PM

#

01900391-91d0-5ffe-c104-70b9e8e21f1a

drowsy willow Jun 10, 2024, 8:22 PM

#

#

hmmmmmmm

#

and that's vanilla

#

yummy

unique turret Jun 10, 2024, 8:33 PM

#

tall tangle Jun 11, 2024, 2:39 AM

#

Is it just me or do the weather weights in the config not go through?

drowsy willow Jun 11, 2024, 6:58 AM

#

tall tangle Is it just me or do the weather weights in the config not go through?

Oh, that's interesting

#

Have you check your logs if they're being applied?

tall tangle Jun 11, 2024, 12:58 PM

#

I’ll do some testing and see

hybrid crescent Jun 11, 2024, 4:30 PM

#

mrov, is there a way to blacklist specific weathers for a planet?

obsidian schooner Jun 11, 2024, 4:46 PM

#

hybrid crescent mrov, is there a way to blacklist specific weathers for a planet?

Idk if possible with the normal WeatherTweaks, but the Weather Registry you can have blacklist per weather

hybrid crescent Jun 11, 2024, 4:56 PM

#

obsidian schooner Idk if possible with the normal WeatherTweaks, but the Weather Registry you can ...

Insane, thank you

drowsy willow Jun 11, 2024, 5:02 PM

#

hybrid crescent mrov, is there a way to blacklist specific weathers for a planet?

yeah, WeatherRegistry allows you to disable weathers on selected planets

#

and weathertweaks uses its settings 😇

hybrid crescent Jun 11, 2024, 5:17 PM

#

drowsy willow yeah, WeatherRegistry allows you to disable weathers on selected planets

I just updated WeatherRegistry and I don't see blacklisting for something else other than sun animator

drowsy willow Jun 11, 2024, 5:18 PM

#

you need to start the lobby once

#

and all the configs will generate

hybrid crescent Jun 11, 2024, 5:18 PM

#

Like, landing on a moon?

drowsy willow Jun 11, 2024, 5:19 PM

#

just starting a game, so selecting save and spawning in the ship

#

when you spawn in they will already be generated

#

and then you can change them

#

like so

hybrid crescent Jun 11, 2024, 5:22 PM

#

Alright, thanks a lot

tall tangle Jun 11, 2024, 6:23 PM

#

I’ve tested with another profile and the weights seem to be working now

drowsy willow Jun 11, 2024, 6:46 PM

#

yippee 😇

mystic oxide Jun 11, 2024, 8:37 PM

#

Is there no setting to disable the combined and progressive weathers anymore?

drowsy willow Jun 11, 2024, 8:42 PM

#

mystic oxide Is there no setting to disable the combined and progressive weathers anymore?

there should be 🤔

#

hmm

#

have you checked after creating a lobby?

#

because that's when the configs are called

mystic oxide Jun 11, 2024, 8:51 PM

#

drowsy willow there should be 🤔

Looks like they don't show in LethalConfig but are there

#

tho they are not working at all

#

I have all of them disabled and still see combined and progressive weathers on the terminal

drowsy willow Jun 11, 2024, 8:57 PM

#

oh

#

umm

#

I might've done an oopsie again

#

so the disabled combined weathers shouldn't show up

#

but progressing ones' check is missing

#

😭😭😭

#

sorry for that

hybrid crescent Jun 11, 2024, 9:14 PM

#

Is there a way to randomize the seed for the first day?

dreamy garden Jun 11, 2024, 9:15 PM

#

i wanted to know that too

#

the first day is always the same

hybrid crescent Jun 11, 2024, 9:15 PM

#

Yep

dreamy garden Jun 11, 2024, 9:15 PM

#

not a big problem

hybrid crescent Jun 11, 2024, 9:15 PM

#

March is always Foggy for example

dreamy garden Jun 11, 2024, 9:16 PM

#

if the first day everything was clear i wouldn't mind

#

but i like going assurance

#

and assurance is foggy 😦

cerulean burrow Jun 11, 2024, 9:22 PM

#

@drowsy willow okay so i found a weird issue. if i use betaweather tweaks and weatherregistry in my profile, if i try to land on a moon it just is stuck with ship in motion. but simply getting rid of beta and the weather registry and get normal weather tweaks the game is fine

#

nothing in the bepin console

#

i could send log

dreamy garden Jun 11, 2024, 9:23 PM

#

is there a seed that everything is clear first day?

mystic oxide Jun 11, 2024, 9:28 PM

#

I'm pretty sure it is different depending on how many moons you have

#

Because I never changed the seed and got different weathers every time I changed the amount of moons I had

dreamy garden Jun 11, 2024, 9:29 PM

#

vanilla moons only

hybrid crescent Jun 11, 2024, 9:42 PM

#

cerulean burrow <@231002429406183424> okay so i found a weird issue. if i use betaweather tweak...

Were you on a custom moon?

cerulean burrow Jun 11, 2024, 9:42 PM

#

happens to both vanilla and custom

hybrid crescent Jun 11, 2024, 9:47 PM

#

mystic oxide I have all of them disabled and still see combined and progressive weathers on t...

same issue with the newest version

unique wraith Jun 11, 2024, 9:50 PM

#

cerulean burrow i could send log

Send the log, Mrov might be sleeping. He'll get it later

#

Sending a log is always the best course of action 🙂

drowsy willow Jun 11, 2024, 9:58 PM

#

cerulean burrow i could send log

please do, I'll check it later

drowsy willow Jun 11, 2024, 9:58 PM

#

hybrid crescent Is there a way to randomize the seed for the first day?

not yet 😓

drowsy willow Jun 11, 2024, 9:59 PM

#

hybrid crescent same issue with the newest version

I've done an oopsie, I'll try to see if I can get an update pushed before being back home

cerulean burrow Jun 11, 2024, 10:56 PM

#

drowsy willow please do, I'll check it later

gonna grab it rn

cerulean burrow Jun 11, 2024, 11:15 PM

#

drowsy willow please do, I'll check it later

📎 LogOutput.log

#

here you go!

cerulean burrow Jun 12, 2024, 1:50 AM

#

i still could not find the issue

#

just know it only happens with betaweathertweaks plus weather reg

bright viper Jun 14, 2024, 2:14 PM

#

Alright so I have a small suggestion for the mod.
Would it be possible to add a config entry to hide changing and combined weathers from the terminal?
Like let's say you get a "None > Stormy" weather on a moon but when routing to that moon the terminal and map would only show "None"
I believe this would add a fun element of surprise (and also reduce clutter)

drowsy willow Jun 14, 2024, 2:35 PM

#

Hey, sure, I could add something like that 😅

slow maple Jun 15, 2024, 2:44 AM

#

not using tweaks but i'm using registry and it's been eclipse THREE times in a row on both of the free moons

drowsy willow Jun 15, 2024, 8:31 AM

#

🥺

#

registry has all the weathers with equal weight

#

so it's possible

drowsy willow Jun 15, 2024, 12:07 PM

#

WeatherRegistry 0.1.1

fixed an issue with LethalLib weathers not being registered correctly on modded moons
fixed an issue with WeatherRegistry weathers being destroyed on joining lobbies
(hopefully) fixed a Dictionary issue with modded weathers on clients
renamed events: setupFinished -> SetupFinished, weatherChanged -> WeatherChanged
added DisableAllWeathers event
added WeatherController for changing weathers
changed some logs
changed possibleWeathers table to be sorted using enum values
changed WeatherRegistry to forcefully remove all "None" weather entries from randomWeathers

drowsy willow Jun 15, 2024, 12:15 PM

#

cerulean burrow

🤔

#

what's your modpack code? I'll try to check it out

#

BetaWeatherTweaksBeta 0.20.4

fixed an issue with special weathers not being disabled (thanks: @mystic oxide , @hybrid crescent , @ancient depot )

#

and with that i think i've fixed all weather-related things that popped up this week

#

the grind is real 😅

drowsy willow Jun 15, 2024, 12:24 PM

#

drowsy willow ## BetaWeatherTweaksBeta 0.20.4 - fixed an issue with special weathers not bein...

the fix was literally that:
https://github.com/AndreyMrovol/LethalWeatherTweaks/commit/bbc2a6833757e4722506d5a3135e9b502e5e0f46

drowsy willow Jun 15, 2024, 3:57 PM

#

@plucky holly it crashed after starting to orbit?

plucky holly Jun 15, 2024, 3:57 PM

#

no, it just broke the lever

#

as in we couldnt pull it

drowsy willow Jun 15, 2024, 3:57 PM

#

in orbit or on planet?

plucky holly Jun 15, 2024, 3:57 PM

#

in orbit

drowsy willow Jun 15, 2024, 3:58 PM

#

alright

#

what's your modpack code?

plucky holly Jun 15, 2024, 3:58 PM

#

01901c4b-6afb-bc3c-0f12-c3aee7afce2e

drowsy willow Jun 15, 2024, 3:58 PM

#

i'm gonna quickly check

plucky holly Jun 15, 2024, 3:59 PM

#

i pray its not a player count issue like that bug i had with only 5+ players in the lobby

drowsy willow Jun 15, 2024, 3:59 PM

#

99% isn't 😅

#

it's something in weather selection

plucky holly Jun 15, 2024, 3:59 PM

#

might be unrelated to wt also cause my first log doesnt have any traces of it i think

drowsy willow Jun 15, 2024, 3:59 PM

#

but i need to see what's happening with debug logs on

plucky holly Jun 15, 2024, 4:00 PM

#

drowsy willow it's something in weather selection

would that cause the ship to get stuck?

drowsy willow Jun 15, 2024, 4:00 PM

#

well

plucky holly Jun 15, 2024, 4:00 PM

#

drowsy willow but i need to see what's happening with debug logs on

alright what do i need to turn on

#

for this

drowsy willow Jun 15, 2024, 4:00 PM

#

the weathers aren't selected and nothing further can progress

#

so yes

#

🥺

plucky holly Jun 15, 2024, 4:00 PM

#

aha ic

drowsy willow Jun 15, 2024, 4:01 PM

#

plucky holly alright what do i need to turn on

you would need to change the Bepinex config - Logging : Disk levels to All

plucky holly Jun 15, 2024, 4:07 PM

#

im gonna play for a bit cause i dont wanna bug my group with testing stuff rn so i'll get you the logs after the sesh 🥺

drowsy willow Jun 15, 2024, 4:16 PM

#

thanks 🥺🙏

plucky holly Jun 15, 2024, 6:16 PM

#

drowsy willow thanks 🥺🙏

📎 wttl5ZD.txt

slow maple Jun 15, 2024, 7:02 PM

#

drowsy willow registry has all the weathers with equal weight

happened to me a few hours after but with flooded

#

anyway thanks for the update mrov :]

drowsy willow Jun 15, 2024, 7:10 PM

#

plucky holly

oh lord it's that again 😂

#

i thought i fixed that already lol

plucky holly Jun 15, 2024, 7:10 PM

#

https://tenor.com/view/garn47-car-explode-shatter-cat-gif-10358843112865587060

Tenor

drowsy willow Jun 15, 2024, 7:46 PM

#

oh it's dividing by 0

#

fuckkkk

#

can math errors go away from me 🥺

#

i'm uploading the fix rn

abstract pivot Jun 15, 2024, 7:52 PM

#

gotta clamp all divisions lol

drowsy willow Jun 15, 2024, 7:52 PM

#

abstract pivot gotta clamp all divisions lol

worse

abstract pivot Jun 15, 2024, 7:52 PM

#

:<

bleak quarry Jun 15, 2024, 8:08 PM

#

drowsy willow can math errors go away from me 🥺

never

drowsy willow Jun 15, 2024, 8:08 PM

#

😧

drowsy willow Jun 15, 2024, 9:01 PM

#

plucky holly

i've pushed the fix for that, thanks for reporting!

drowsy willow Jun 16, 2024, 6:03 PM

#

i've got a brilliant idea

#

it would be so fun to make it work

gray kayak Jun 16, 2024, 6:04 PM

#

this is scary

azure dirge Jun 16, 2024, 7:41 PM

#

concern

prisma vault Jun 17, 2024, 6:12 AM

#

I have a question about weather registry, is there be a thing like meteo multipliers? In the readme it says how it has code from it but i dont see anywhere to actually implement that into the game, or in weathertweaks

#

So where do I look for this setting or is it jus not there yet (or at all)?

abstract pivot Jun 17, 2024, 6:13 AM

#

prisma vault I have a question about weather registry, is there be a thing like meteo multipl...

Are u making a weather?

prisma vault Jun 17, 2024, 6:14 AM

#

no I jus really liked meteomultipliers but want it on meteor shower weather and thought I heard somewhere a while back in the Code Rebirth taht this weather API thing would be able to do someth like meteomultipliers but to everything

#

hopefully I worded that correctly-

abstract pivot Jun 17, 2024, 6:14 AM

#

Next update should have what u need in the meteor shower mod's configs

#

It'll be a few more days though

#

Meteor shower doesn't currently use weather api is all

prisma vault Jun 17, 2024, 6:15 AM

#

yipppeeee

#

so will it be specific to the weather creator's own mods?

#

for the custom weathers at least?

abstract pivot Jun 17, 2024, 6:15 AM

#

When registering the weather I get the option to input the values so yes

prisma vault Jun 17, 2024, 6:15 AM

#

Oki tyty

#

For vanilla weathers should I keep using meteomultiplier then?

abstract pivot Jun 17, 2024, 6:16 AM

#

Afaik stuff like weights is unfortunately not on my end so you'll have to go to weather apis config for that I think

abstract pivot Jun 17, 2024, 6:16 AM

#

prisma vault For vanilla weathers should I keep using meteomultiplier then?

I dont see any problem with it but I think weather tweaks does a similar thing or atleast beta weather tweaks

#

But dunno

prisma vault Jun 17, 2024, 6:16 AM

#

abstract pivot Afaik stuff like weights is unfortunately not on my end so you'll have to go to ...

Ya I found weights, jus wantednto find the like scrap multiplier value

prisma vault Jun 17, 2024, 6:17 AM

#

abstract pivot I dont see any problem with it but I think weather tweaks does a similar thing o...

Oh it does? Ill find it next time I play been keeping my partner waiting for like 30 mins setting up all these updated mods

#

Thx for the info!

drowsy willow Jun 17, 2024, 9:21 AM

#

prisma vault I have a question about weather registry, is there be a thing like meteo multipl...

Hey, I'm planning to include the config options in the Weather registry config

bright viper Jun 17, 2024, 10:24 AM

#

btw mrov are you ever planning on making true combined weathers?
As in 2 weathers are chosen completely randomly and then combined into one instead of being predetermined combinations in the config?

drowsy willow Jun 17, 2024, 10:26 AM

#

bright viper btw mrov are you ever planning on making true combined weathers? As in 2 weather...

🤔 This could be done, it would be perfect with future custom weathers

#

i'm not planning this right now tho

bright viper Jun 17, 2024, 10:28 AM

#

Hell it could even be 2 of the same weather combined
two rainy weathers would make heavy rain (twice as many mud puddles)
two foggy weathers would make dense fog (basically your old superfoggy)
two stormy weathers would make... don't have a proper name but you get my point (double thunder strike rate)

Don't know how that would work for eclipse or flood but it sounds cool

bright viper Jun 17, 2024, 10:28 AM

#

drowsy willow i'm not planning this *right now* tho

fair. that would probably require a solid rewrite

drowsy willow Jun 17, 2024, 10:28 AM

#

🤔

#

well

#

on game start i would just need to generate all possible combinations

#

and it would be on par with my current solution

#

so i don't think that's unreachable

bright viper Jun 17, 2024, 10:29 AM

#

🤔 and I suppose the config would update accordingly?

#

so you could pick and chose?

drowsy willow Jun 17, 2024, 10:29 AM

#

yeee

#

it's generated dynamically already

bright viper Jun 17, 2024, 10:32 AM

#

btw how are combined weathers treated in relation to other weathers?
Are they just completely seperate and treated as their own weathers in the pool or are they chance based?
As in if the moon would be stormy then it has a chance to instead become a stormy + rainy for example

drowsy willow Jun 17, 2024, 10:32 AM

#

it's completely separate

bright viper Jun 17, 2024, 10:32 AM

#

🤔 does that mean you could also introduce weights to them?

drowsy willow Jun 17, 2024, 10:32 AM

#

it uses "base weather" 's weight (dialed down)

drowsy willow Jun 17, 2024, 10:33 AM

#

bright viper 🤔 does that mean you could also introduce weights to them?

well, i could

bright viper Jun 17, 2024, 10:33 AM

#

drowsy willow it uses "base weather" 's weight (dialed down)

hmm then which weather is considered the base weather?
best example I can think of is "Flooded + Eclipsed"
Does it use dialed down flooded weight or dialed down eclipsed weight?

#

flooded is first but eclipsed is harder

#

so if I change the weight for one in the weather registry which would the combined weather use?

manic cobalt Jun 17, 2024, 10:35 AM

#

I wanna pitch Zeekerss on the benefits of moving to SO’s rather than enums

bright viper Jun 17, 2024, 10:35 AM

#

manic cobalt I wanna pitch Zeekerss on the benefits of moving to SO’s rather than enums

SO?

manic cobalt Jun 17, 2024, 10:35 AM

#

ScriptableObject

bright viper Jun 17, 2024, 10:36 AM

#

ah

drowsy willow Jun 17, 2024, 10:36 AM

#

manic cobalt I wanna pitch Zeekerss on the benefits of moving to SO’s rather than enums

👀

drowsy willow Jun 17, 2024, 10:36 AM

#

bright viper hmm then which weather is considered the base weather? best example I can think ...

          if (combinedWeather.CanWeatherBeApplied(level))
          {
            weatherWeight = Mathf.RoundToInt(
              (weights.TryGetValue(weather.weatherType, out int localWeight) ? localWeight : weather.Weather.DefaultWeight)
                * combinedWeather.weightModify
            );
          }
          else
          {
            Plugin.logger.LogDebug($"Combined weather: {combinedWeather.Name} can't be applied");
            continue;
          }

#

the "base weather" is the first in the array of weathers to apply

#

bright viper Jun 17, 2024, 10:37 AM

#

so in this case it would be flooded

drowsy willow Jun 17, 2024, 10:37 AM

#

so in this case it would be stormy

#

yeah

drowsy willow Jun 17, 2024, 10:37 AM

#

bright viper so in this case it would be flooded

in your example yeah

drowsy willow Jun 17, 2024, 10:37 AM

#

manic cobalt I wanna pitch Zeekerss on the benefits of moving to SO’s rather than enums

if zeekers redos the entire weather system i'm gonna cry

bright viper Jun 17, 2024, 10:38 AM

#

🤔 wouldn't it make sense to always put the hardest weather first though?
I know it doesn't matter with base settings since all weathers are equal but if someone wanted to customize it then it creates an issue of... surprise eclipses

drowsy willow Jun 17, 2024, 10:38 AM

#

i get what you mean

manic cobalt Jun 17, 2024, 10:38 AM

#

drowsy willow if zeekers redos the entire weather system i'm gonna cry

Worth it for SO’s tho

drowsy willow Jun 17, 2024, 10:38 AM

#

i was moving this system a few times already and i'm still not happy with how it works rn

#

i'll change it so that the "base" one would be the "hardest" so to speak

drowsy willow Jun 17, 2024, 10:39 AM

#

manic cobalt Worth it for SO’s tho

i agree

manic cobalt Jun 17, 2024, 10:39 AM

#

If it was like Levels, Items & Enemies we’d be so back

drowsy willow Jun 17, 2024, 10:39 AM

#

also welcome back, Batby 👋

manic cobalt Jun 17, 2024, 10:39 AM

#

not fully back but tyty

#

Just mobilin

drowsy willow Jun 17, 2024, 10:40 AM

#

i'm really interested what the future updates bring

#

cause i assume those changes are not in v55 (or next one after)

#

because zeekers would need to change quite a few things in the game to make it work

manic cobalt Jun 17, 2024, 10:41 AM

#

ehhh

#

yes snd no

drowsy willow Jun 17, 2024, 10:42 AM

#

i mean

bright viper Jun 17, 2024, 10:42 AM

#

btw if I am reading this correctly switching to SO weathers would allow for weather events and variants with less memory consumption no?
(I have little to no idea how big the change would be)

drowsy willow Jun 17, 2024, 10:42 AM

#

it's not difficult, but time consuming

drowsy willow Jun 17, 2024, 10:42 AM

#

bright viper btw if I am reading this correctly switching to SO weathers would allow for weat...

right now in the game there's an LevelWeatherType enum

#

and everything weather-related is indexed by it

#

which is painful at best

#

changing the weathers to be ScriptableObjects would mean that everything weather-related could be in one array

#

(just like what i'm trying to do with WeatherRegistry)

bright viper Jun 17, 2024, 10:45 AM

#

so what you're saying is... you could easily add infinite weathers without having to overwrite the enum completely?

drowsy willow Jun 17, 2024, 10:45 AM

#

that would be one of the benefits, yeah

manic cobalt Jun 17, 2024, 10:45 AM

#

You could so the bare minimum by having inpsector based drag and drop references to the vanilla ones in the timeofday class and then compare against them instead of the current enum checks

drowsy willow Jun 17, 2024, 10:45 AM

#

because instead of my current shenanigans you would just add an object to array

#

and it's done

manic cobalt Jun 17, 2024, 10:45 AM

#

Which would be fairly easy to initially swap in

prisma vault Jun 17, 2024, 4:58 PM

#

drowsy willow Hey, I'm planning to include the config options in the Weather registry config

https://tenor.com/view/yippee-happy-yippee-creature-yippee-meme-yippee-gif-gif-1489386840712152603

Tenor

mystic oxide Jun 17, 2024, 8:29 PM

#

drowsy willow ## BetaWeatherTweaksBeta 0.20.4 - fixed an issue with special weathers not bein...

The issue is still there

#

I have disabled combined/progressive weathers and I still see them

drowsy willow Jun 17, 2024, 8:30 PM

#

ohhhhh

#

🥺

#

can you send me your log?

mystic oxide Jun 17, 2024, 8:31 PM

#

📎 adad.txt

drowsy willow Jun 17, 2024, 8:39 PM

#

oh

#

huh

#

why

#

is that happening

drowsy willow Jun 17, 2024, 8:57 PM

#

hmmm

#

i've disabled all of them on my end and they're not popping up

wind bough Jun 17, 2024, 9:04 PM

#

tell me when fixed

drowsy willow Jun 17, 2024, 10:14 PM

#

wind bough tell me when fixed

it should be fixed with latest WeatherTweaks update

#

if anything more happens, let me know

#

basically the weather generation ran twice

#

and the mod that picked the weathers didn't display them

#

oopsie

wind bough Jun 17, 2024, 10:29 PM

#

k

mystic oxide Jun 17, 2024, 10:31 PM

#

drowsy willow i've disabled all of them on my end and they're not popping up

Well, I think I found the problem...

#

Could it be because this part is missing for every combined/progressive config entry in the config file?

#

#

That's probably why they don't show up in LethalConfig either

drowsy willow Jun 17, 2024, 10:36 PM

#

oh wait what

#

gale doesn't show up the + things in the name

#

also it could be that

#

because of how this works (sorry) those configs are read after starting the round

#

could you check if the descriptions pop up after starting the lobby?

mystic oxide Jun 17, 2024, 10:41 PM

#

drowsy willow could you check if the descriptions pop up after starting the lobby?

Yeah that fixed it, which is weird because I did start a lobby earlier when I reported the issue

drowsy willow Jun 17, 2024, 10:47 PM

#

that's really 🤔

wind bough Jun 18, 2024, 1:44 PM

#

yeah it seems fine now good work 👍

drowsy willow Jun 18, 2024, 9:40 PM

#

configs are a mess

drowsy willow Jun 18, 2024, 10:01 PM

#

I've got a cool idea and it would be great to make it happen

slow maple Jun 18, 2024, 10:13 PM

#

SPILL THE BEANS ANDREY

drowsy willow Jun 18, 2024, 10:30 PM

#

#

i need to make a config handler 🫠

#

actually i could do that in a better way

#

but it's gonna be a fucking nightmare

drowsy willow Jun 18, 2024, 10:48 PM

#

this is impossible lol

wind bough Jun 19, 2024, 4:09 AM

#

You got this 👍

ocean vessel Jun 19, 2024, 9:46 PM

#

#

https://tenor.com/view/cat-catcry-gif-19131995

Tenor

abstract pivot Jun 19, 2024, 9:54 PM

#

LOL

drowsy willow Jun 19, 2024, 10:00 PM

#

OH I FORGOT CHANGELOG FOR THAT

#

this was so rushed, sorry

#

I've changed the code to use WeatherRegistry as dependency

ocean vessel Jun 19, 2024, 10:03 PM

#

(it's fine- anytime I don't see a changelog i just assume I gotta move the config out and compare old with new x3)

drowsy willow Jun 19, 2024, 10:31 PM

#

it's already inside WeatherRegistry

#

But I need to add the config options

#

😅

#

so: yes

#

no worries, it's not yet announced anywhere 😅

drowsy willow Jun 20, 2024, 11:55 AM

#

drowsy willow this is impossible lol

i think i did it

#

this looks sooooo nice

#

IT DOESN'T WORK hehe

abstract pivot Jun 20, 2024, 2:35 PM

#

Lol

shut cobalt Jun 20, 2024, 5:47 PM

#

drowsy willow IT DOESN'T WORK hehe

well ye u wouldnt be able to have two with the same key? 🤔

#

oh wait nvm i read that completely wrong 🤣

drowsy willow Jun 20, 2024, 5:49 PM

#

I've done bad things in my code

#

it's not related to that 😅

ancient depot Jun 22, 2024, 12:13 AM

#

drowsy willow But I need to add the config options

Means I can take out MeteoMultipliers then, I use the defaults anyways ^^

drowsy willow Jun 22, 2024, 9:12 AM

#

i've made some questionable design choices

#

stupid configs at it again

#

this is the best worst thing i've done

#

drowsy willow Jun 22, 2024, 10:00 AM

#

WeatherRegistry 0.1.4

added ScrapAmountMultiplier, ScrapValueMultiplier config options
added LevelWeights and WeatherWeights config options (they don't do anything yet)
(hopefully finally) fixed an error with WeatherRegistry not disabling registered weathers' effects when leaving lobby

gray kayak Jun 22, 2024, 10:11 AM

#

yoiled

drowsy willow Jun 22, 2024, 10:16 AM

#

gray kayak <:yoiled:1181287712943259738>

i've tested the issues you were getting and it should (SHOULD) work now

gray kayak Jun 22, 2024, 10:17 AM

#

testing for myself now

drowsy willow Jun 22, 2024, 10:17 AM

#

i've got the tornado to spawn after reloading lobby

gray kayak Jun 22, 2024, 10:18 AM

#

it works

trail lark Jun 22, 2024, 10:18 AM

#

So no more need for MeteoMultiplier?

drowsy willow Jun 22, 2024, 10:18 AM

#

gray kayak it works

YIPPEE 😇

drowsy willow Jun 22, 2024, 10:18 AM

#

trail lark So no more need for MeteoMultiplier?

that should be the case

trail lark Jun 22, 2024, 10:18 AM

#

Very nice.

gray kayak Jun 22, 2024, 10:18 AM

#

hurray

drowsy willow Jun 22, 2024, 10:19 AM

#

every registered weather has its own multiplier sliders

gray kayak Jun 22, 2024, 10:19 AM

#

what does WeatherTweaks add that WeatherRegistry doesn't

#

is it just combined stuff?

drowsy willow Jun 22, 2024, 10:20 AM

#

gray kayak what does WeatherTweaks add that WeatherRegistry doesn't

combined/progressing weathers
weather compatibility stuff with some mods
nicer fog

#

AND the weather-> weather weights being nicer

#

which will be merged into Registry at some point

gray kayak Jun 22, 2024, 10:21 AM

#

https://tenor.com/view/snail-cucumber-snail-eating-cucumber-snail-cucumber-funny-gif-25870918

Tenor

drowsy willow Jun 22, 2024, 10:22 AM

#

drowsy willow which will be merged into Registry at some point

i have the config options there already, but they're not taken into account yet

gray kayak Jun 22, 2024, 10:22 AM

#

haven't heard that one before

drowsy willow Jun 22, 2024, 10:22 AM

#

because having 3 possible weather weights at the same time will cause some funny issues

#

my idea for their priorities would be to use:

level-specific weight (i.e. Vow@200)
weather>weather weights (i.e. Stormy@200)
default weights (i.e. 100)

gray kayak Jun 22, 2024, 10:23 AM

#

Are you planning to just make WeatherRegistry the new WeatherTweaks

#

so everything is more centralized

drowsy willow Jun 22, 2024, 10:24 AM

#

that's a very interesting thing actually

#

because if you take into account my original plan (that's weight-based weather selection and weather sync) it's already there

#

i just need to ~~force ~~convince all weather-related stuff that other mods do to use my solution

#

and it's gonna be sooo epic

#

cause weather is the most disorganized thing this game has (except THE TERMINAL)

manic cobalt Jun 22, 2024, 10:26 AM

#

https://tenor.com/view/robot-congratulations-you-are-rescued-please-gif-17932648

Tenor

drowsy willow Jun 22, 2024, 10:26 AM

#

so having a centralized solution would be amazing

#

of course i probably miss some features that would be useful to modders

#

feel free to let me know

drowsy willow Jun 22, 2024, 10:26 AM

#

manic cobalt https://tenor.com/view/robot-congratulations-you-are-rescued-please-gif-17932648

🤭

gray kayak Jun 22, 2024, 10:27 AM

#

https://tenor.com/view/lunaistabby-fwadri-gif-18189511081587813010

Tenor

#

awsum

drowsy willow Jun 22, 2024, 10:28 AM

#

I need to fix my nuget auto-upload 😭

#

and then it's gonna be epic

drowsy willow Jun 22, 2024, 3:40 PM

#

another MROV oopsie

#

level filtering in Registry doesn't work

#

will fix that ASAP

#

sorry for the inconvenience

azure dirge Jun 22, 2024, 3:42 PM

#

alright

bleak quarry Jun 22, 2024, 4:11 PM

#

mrov throwing once again

vocal dune Jun 22, 2024, 4:17 PM

#

i was thinking that would be cool, if by default weathers could be "unknow" but buying like sort of a Weather antenna or something in the shop for 300 or less, and with it the weathers will show in the terminal ^^

#

actually don't know if there is one already in thunderstore

drowsy willow Jun 22, 2024, 4:20 PM

#

I won't make that, but if someone wants to make that happen I'll gladly help

vocal dune Jun 22, 2024, 4:22 PM

#

i would be glad to learn scripting and modding for that 🥲

#

i think imma drop that into #1188298686560739389

shadow bough Jun 22, 2024, 4:30 PM

#

WeatherRegistry.ImprovedWeatherEffect must be instantiated using the ScriptableObject.CreateInstance method instead of new ImprovedWeatherEffect.

UnityEngine.StackTraceUtility:ExtractStackTrace ()
UnityEngine.ScriptableObject:.ctor ()
WeatherRegistry.ImprovedWeatherEffect:.ctor (UnityEngine.GameObject,UnityEngine.GameObject)
WeatherRegistry.Patches.TerminalStartPatch:Postfix (Terminal)
DMD<Start>?570627916:_Terminal::Start (Terminal)
DMD<>?570627916:Trampoline<Terminal::Start>?-110933648 (Terminal)
LethalLib.Modules.Enemies:Terminal_Start (On.Terminal/orig_Start,Terminal)
DMD<>?570627916:Hook<Terminal::Start>?1449442308 (Terminal)

WeatherRegistry.Weather must be instantiated using the ScriptableObject.CreateInstance method instead of new Weather.

UnityEngine.StackTraceUtility:ExtractStackTrace ()
UnityEngine.ScriptableObject:.ctor ()
WeatherRegistry.Weather:.ctor (string,WeatherRegistry.ImprovedWeatherEffect)
WeatherRegistry.Patches.TerminalStartPatch:Postfix (Terminal)
DMD<Start>?570627916:_Terminal::Start (Terminal)
DMD<>?570627916:Trampoline<Terminal::Start>?-110933648 (Terminal)
LethalLib.Modules.Enemies:Terminal_Start (On.Terminal/orig_Start,Terminal)
DMD<>?570627916:Hook<Terminal::Start>?1449442308 (Terminal)

#

WeatherRegistry.Weather must be instantiated using the ScriptableObject.CreateInstance method instead of new Weather.

WeatherRegistry.Weather:.ctor (string,WeatherRegistry.ImprovedWeatherEffect)
System.Reflection.RuntimeConstructorInfo:InternalInvoke (object,object[],bool)
System.Reflection.RuntimeConstructorInfo:DoInvoke (object,System.Reflection.BindingFlags,System.Reflection.Binder,object[],System.Globalization.CultureInfo)
System.Reflection.RuntimeConstructorInfo:Invoke (System.Reflection.BindingFlags,System.Reflection.Binder,object[],System.Globalization.CultureInfo)
System.Reflection.ConstructorInfo:Invoke (object[])
Newtonsoft.Json.Utilities.LateBoundReflectionDelegateFactory/<>c__DisplayClass3_0:<CreateParameterizedConstructor>b__0 (object[])
...
Newtonsoft.Json.JsonConvert:DeserializeObject<System.Collections.Generic.Dictionary`2<string, WeatherTweaks.Definitions.WeatherType>> (string)
WeatherTweaks.NetworkedConfig:WeatherDataReceived (string)

concern

drowsy willow Jun 22, 2024, 5:13 PM

#

is that a bad thing? 🥺

#

OH WEATHERTWEAKS

#

mmmm

#

I'll check that later

ancient depot Jun 22, 2024, 6:13 PM

#

drowsy willow OH WEATHERTWEAKS

"It's you!!!! It's always you!!!"

drowsy willow Jun 22, 2024, 10:46 PM

#

oh i didn't

ancient depot Jun 22, 2024, 10:56 PM

#

drowsy willow oh i didn't

Also the error seems to be from WeatherRegistry and not WeatherTweaks lol

#

From what it looks like WeatherTweaks ends up erroring way later

drowsy willow Jun 22, 2024, 11:29 PM

#

this is not even funny 😆

#

https://github.com/AndreyMrovol/LethalWeatherRegistry/commit/acc0df1acece6881b676d1d1cac7b874054cc81a

GitHub

fixed confighelper resolving levels to null · AndreyMrovol/LethalWe...

abstract pivot Jun 23, 2024, 6:27 AM

#

drowsy willow https://github.com/AndreyMrovol/LethalWeatherRegistry/commit/acc0df1acece6881b67...

Whays a cross mean?

drowsy willow Jun 23, 2024, 8:48 AM

#

abstract pivot Whays a cross mean?

what cross? 😳

idle light Jun 23, 2024, 8:49 AM

#

Hi mrov

#

I typed complete gibberish and my phone somehow knew that’s what I typed

#

https://tenor.com/view/streetcatwow-cat-look-the-feeder-jule-smp-gif-16547114832070305679

Tenor

drowsy willow Jun 23, 2024, 8:51 AM

#

😅

abstract pivot Jun 23, 2024, 8:56 AM

#

drowsy willow what cross? 😳

the commit emote

drowsy willow Jun 23, 2024, 8:57 AM

#

oooooooh

#

my github action failing because i cannot set minver to work

#

fucking thing

abstract pivot Jun 23, 2024, 8:59 AM

#

lol

drowsy willow Jun 23, 2024, 9:00 AM

#

i spent a few hours on that already

#

it's pointless

unique turret Jun 23, 2024, 2:48 PM

#

drowsy willow my github action failing because i cannot set minver to work

skill issue UAHGHHUAHGHHH

#

anyway what was the issue?

dense nymph Jun 23, 2024, 4:24 PM

#

is this the right place for Weather Registry? Because I think your update just fixed an issue I was hunting down, that involved Selene's Choice and Central Config, and your mod was on the suspect list, now it seems to be fixed.

abstract pivot Jun 23, 2024, 4:35 PM

#

dense nymph is this the right place for Weather Registry? Because I think your update just f...

What's the issue?

#

CC likes to mess with stuff it shouldn't so that issue might just be hidden for now

dense nymph Jun 23, 2024, 6:05 PM

#

As far as I can tell it was just completely breaking down Selene's Choice, but I can't find any errors related, and like I said I think it got fixed? I was still trying to trouble shoot the issue without errors when it stopped after an update, so I might just let it rest.

drowsy willow Jun 23, 2024, 9:27 PM

#

😳

#

ummm

#

I don't knoooow

#

will check that first thing tomorrow

drowsy willow Jun 23, 2024, 9:27 PM

#

unique turret anyway what was the issue?

still haven't solved it

#

I've literally copied LL's action

#

and MinVer always resolves to 0.0.0

unique turret Jun 23, 2024, 9:28 PM

#

so it works?

drowsy willow Jun 23, 2024, 9:28 PM

#

despite the tag being set on like a commit before

unique turret Jun 23, 2024, 9:28 PM

#

hmm

drowsy willow Jun 23, 2024, 9:28 PM

#

unique turret so it works?

nooooo 😭

unique turret Jun 23, 2024, 9:28 PM

#

where's the code?

drowsy willow Jun 23, 2024, 9:29 PM

#

https://github.com/AndreyMrovol/LethalWeatherRegistry/tree/main

GitHub

GitHub - AndreyMrovol/LethalWeatherRegistry

Contribute to AndreyMrovol/LethalWeatherRegistry development by creating an account on GitHub.

#

I'm gonna get owned so bad 😔

#

check the previous action runs as well

#

everything runs okay

#

and MinVer resolves to 0.0.0

#

😓

#

is there a way for it to use the .csproj assembly version?

unique turret Jun 23, 2024, 9:31 PM

#

bruh, your tags don't start with v even though it's configured in your csproj that it should start with v

#

that's why it fails to read the version

#

or is this it?

drowsy willow Jun 23, 2024, 9:32 PM

#

OH is it really that 😭

unique turret Jun 23, 2024, 9:32 PM

#

yes lol

#

It's this <MinVerTagPrefix>v</MinVerTagPrefix>

drowsy willow Jun 23, 2024, 9:32 PM

#

I will check that ASAP as possible

unique turret Jun 23, 2024, 9:32 PM

#

haha

drowsy willow Jun 23, 2024, 9:32 PM

#

another MROV oopsie

unique turret Jun 23, 2024, 9:33 PM

#

🤭

drowsy willow Jun 23, 2024, 9:33 PM

#

unique turret It's this `<MinVerTagPrefix>v</MinVerTagPrefix>`

OH LOL

vocal dune Jun 23, 2024, 9:34 PM

#

idk why ,but i putted every setting on weather in uncertain, but the weather still show up in the cam

#

:c

drowsy willow Jun 23, 2024, 9:36 PM

#

oh, that's interesting

#

if I understand you correctly - you've enabled every uncertain weather type or did you enable always unknown mode?

#

because uncertain weather only has a small % chance of happening, it's not gonna be always and everywhere 😅

vocal dune Jun 23, 2024, 9:49 PM

#

hol on

#

drowsy willow Jun 23, 2024, 9:54 PM

#

vocal dune hol on

THE SLIDERS LOL

#

but yeah, the uncertain stuff is not guaranteed to happen

vocal dune Jun 23, 2024, 9:55 PM

#

seems like i did a fuckie wuckie

drowsy willow Jun 23, 2024, 9:55 PM

#

no you didn't

#

it's modmanager issue

#

but you can try regenerating the config

vocal dune Jun 23, 2024, 9:56 PM

#

agony

drowsy willow Jun 23, 2024, 10:45 PM

#

unique turret bruh, your tags don't start with `v` even though it's configured in your csproj ...

IT REALLY WAS THAT thank you soooooo much 😇

#

something else errors but that's my fault as well lol

unique turret Jun 23, 2024, 10:48 PM

#

haha yeah no problem 😄

drowsy willow Jun 24, 2024, 10:59 PM

#

Weather Tweaks / Registry

leaden flume Jun 25, 2024, 2:07 AM

#

does scrap values work now

ancient depot Jun 25, 2024, 2:08 AM

#

leaden flume does scrap values work now

Yeah they do

leaden flume Jun 25, 2024, 2:09 AM

#

ancient depot Yeah they do

AWESOME

#

i can get rid of meteo's now

drowsy willow Jun 25, 2024, 9:09 AM

#

leaden flume does scrap values work now

you bet

drowsy willow Jun 25, 2024, 2:22 PM

#

drowsy willow Jun 25, 2024, 4:24 PM

#

oh no i forgot that this was a thing

#

fucking weathertweaks still messing my stuff up 😭

ancient depot Jun 25, 2024, 4:25 PM

#

drowsy willow

BetaTweaks at it again

drowsy willow Jun 25, 2024, 4:26 PM

#

i'm trying to debug why weather weights aren't correctly applied on first day

abstract pivot Jun 25, 2024, 4:26 PM

#

drowsy willow

wait wait, 100 default is higher than other vanilla weathers?

ancient depot Jun 25, 2024, 4:27 PM

#

drowsy willow i'm trying to debug why weather weights aren't correctly applied on first day

🤔

drowsy willow Jun 25, 2024, 4:27 PM

#

and that's because levels have random weathers when lobby starts

#

and i forgot i've made a separate logic for that in weathertweaks

#

fun

ancient depot Jun 25, 2024, 4:27 PM

#

Yeah you added the logic to BetaTweaks for the combined and progressing ones

drowsy willow Jun 25, 2024, 4:27 PM

#

abstract pivot wait wait, 100 default is higher than other vanilla weathers?

tweaaaaaking

drowsy willow Jun 25, 2024, 4:28 PM

#

ancient depot Yeah you added the logic to BetaTweaks for the combined and progressing ones

that's not what i'm talking about

#

https://github.com/AndreyMrovol/LethalWeatherTweaks/blob/36c699df2838e89d3cf76f898e092f32b88fee34/WeatherTweaks/WeatherCalculation.cs#L49-L77

ancient depot Jun 25, 2024, 4:28 PM

#

Ah

drowsy willow Jun 25, 2024, 4:28 PM

#

first day weathers being always the same

#

forgive me, but i'm gonna do a gamer move here

abstract pivot Jun 25, 2024, 4:29 PM

#

drowsy willow tweaaaaaking

what are the default weights in weather registry?

drowsy willow Jun 25, 2024, 4:29 PM

#

abstract pivot what are the default weights in weather registry?

right now all 100

abstract pivot Jun 25, 2024, 4:29 PM

#

drowsy willow right now all 100

keep it that way

drowsy willow Jun 25, 2024, 4:29 PM

#

🤭

wicked latch Jun 25, 2024, 5:32 PM

#

HeHeHeHe

#

@drowsy willow Quick question.

#

Building won't publish the uhh.

#

API, right?

#

I'm seeing tcli in proj thus wondering.

drowsy willow Jun 25, 2024, 5:34 PM

#

i'm trying to get it to work still

#

so no

wicked latch Jun 25, 2024, 5:35 PM

#

Oki.

drowsy willow Jun 25, 2024, 5:35 PM

#

what are you doing? 😳

wicked latch Jun 25, 2024, 5:36 PM

#

Just coming back to repositories after mental break.

#

Nice.

drowsy willow Jun 25, 2024, 5:36 PM

#

lol

#

you might want to wait a bit, cause, umm

#

i'm having FUN locally

wicked latch Jun 25, 2024, 5:38 PM

#

It's okay.

drowsy willow Jun 25, 2024, 5:38 PM

#

i was meaning to ask

#

how did your exams go?

wicked latch Jun 25, 2024, 5:39 PM

#

They went fine.

#

still need to know one but it went great.

#

Got maximum grade on the language project though so I'm happy.

drowsy willow Jun 25, 2024, 5:39 PM

#

yippee!

#

that's great to hear! 😇

abstract pivot Jun 25, 2024, 5:39 PM

#

wicked latch Got maximum grade on the language project though so I'm happy.

daym, that's perfect

wicked latch Jun 25, 2024, 5:40 PM

#

Considering that it was meant as a pair project, I think I did a good job on it.

#

You can make WeatherRegistryEvent to WeatherRegistryEvent<object> and pass null as param, no?

#

At least, it seems to be the same thing.

drowsy willow Jun 25, 2024, 5:47 PM

#

wicked latch You can make ``WeatherRegistryEvent`` to ``WeatherRegistryEvent<object>`` and pa...

i think so?

#

i don't know honestly

#

it's copied straight from LLL

wicked latch Jun 25, 2024, 5:47 PM

#

You can still override "Invoke" to just not pass anything to the listeners still.

#

Besides that, it seems functional that way.

drowsy willow Jun 25, 2024, 5:50 PM

#

alrighty

wicked latch Jun 25, 2024, 5:52 PM

#

Nice try catch on a log.

#

Oh, your weight system is ... curious.

#

You're just praying that they have enough memory for the list? Lol.

drowsy willow Jun 25, 2024, 6:04 PM

#

🥺

#

IF i were to change it to something that's not born in the bowels of hell, how would i do that? 😅

drowsy willow Jun 25, 2024, 6:06 PM

#

wicked latch Oh, your weight system is ... curious.

oh shit you're gonna kill me when i push my changes rn

#

it's so much cursed shit

wicked latch Jun 25, 2024, 6:06 PM

#

You can use what I use for the hunter samples API.

#

It's a simple Dictionary<T, double>

#

Where double is the weight.

#

internal class WeightingGroup<T> : Dictionary<T, double> where T : class
{
    public T GetItem()
    {
        double totalWeight = 0f;
        foreach (double item in Values)
        {
            double absWeight = Math.Abs(item);
            totalWeight += absWeight;
        }
        if (totalWeight <= 0f)
            return null;
            
        double roll = new Random().NextDouble();
        double total = 0;

        foreach (KeyValuePair<T, double> pair in this.OrderByDescending(v => v.Value)) 
        {
            total += pair.Value / totalWeight;
            if (roll <= total)
                return pair.Key;
        }
        return Keys.FirstOrDefault();
    }
}

drowsy willow Jun 25, 2024, 6:08 PM

#

oooh, i see how you do it

#

so you're picking a rolled value and going through the dictionary one-by-one until the rolled value is 0

#

that's waaaay better than my stuff

#

🤭

#

i'll change my stuff to this

wicked latch Jun 25, 2024, 6:11 PM

#

drowsy willow that's waaaay better than my stuff

Rather than having [A,A,A,A,B,B,B,...], it's probably better, yes.

#

HeHeHeHe

drowsy willow Jun 25, 2024, 6:12 PM

#

you're gonna have so much fun seeing this shit

#

i'm sorry for the crimes i've commited

#

https://github.com/AndreyMrovol/LethalWeatherRegistry/compare/a9c0f85687e192bd660c20ed24fc720ec3a6f388...main

#

those are the changes from today

wicked latch Jun 25, 2024, 6:32 PM

#

ConfigHandler's Value seems to be abstract.

drowsy willow Jun 25, 2024, 6:34 PM

#

yeaah

#

it's because i'm defining its type in the extensions: LevelListConfigHandler and others

wicked latch Jun 25, 2024, 6:34 PM

#

Ye ye

drowsy willow Jun 25, 2024, 6:34 PM

#

so that i can have a single abstraction for all types of shenanigans i'm doing

#

it's reaaaally bad

wicked latch Jun 25, 2024, 6:35 PM

#

But you put virtual instead.

#

As in you need it for something on the base class.

drowsy willow Jun 25, 2024, 6:35 PM

#

should it not be virual?

#

OOOOH i see what you mean

#

but i would need to have the whole class abstract for that, no?

wicked latch Jun 25, 2024, 6:35 PM

#

You will have to put the handler as abstract ,yes.

drowsy willow Jun 25, 2024, 6:36 PM

#

wicked latch Jun 25, 2024, 6:36 PM

#

Unless you're using the base class somewhere?

#

And remove the default(T)

drowsy willow Jun 25, 2024, 6:36 PM

#

oh

#

i don't actually know if it's gonna work 😅

wicked latch Jun 25, 2024, 6:37 PM

#

I mean

#

You're overriding the get anyways.

#

So the initializer doesn't really do anything.

drowsy willow Jun 25, 2024, 6:38 PM

#

i'm trying to recall why i put it there

#

but i don't remeber lol

wicked latch Jun 25, 2024, 6:40 PM

#

Double array cast on ConvertStringToArray ?

drowsy willow Jun 25, 2024, 6:40 PM

#

😳

#

OH NO

wicked latch Jun 25, 2024, 6:41 PM

#

levels not used in ConvertStringToLevels

drowsy willow Jun 25, 2024, 6:42 PM

#

right, redid that today

wicked latch Jun 25, 2024, 6:43 PM

#

There's some repeated stuff here but that's fine.

drowsy willow Jun 25, 2024, 6:43 PM

#

that's what i wanted to tackle next

#

to just call a method with repeated stuff in there, simplified

#

because i have the same code (with very small differences) like 4 times there 😭

wicked latch Jun 25, 2024, 6:46 PM

#

What is ConsoleTable used for?

#

For logging, it seems?

drowsy willow Jun 25, 2024, 6:46 PM

#

i'm putting stuff into tables to print them nicely

#

ye

wicked latch Jun 25, 2024, 6:46 PM

#

Huh okay.

#

Ah, thus "Console"

drowsy willow Jun 25, 2024, 6:46 PM

#

wicked latch Jun 25, 2024, 6:46 PM

#

Okay.

drowsy willow Jun 25, 2024, 6:46 PM

#

like this:

wicked latch Jun 25, 2024, 6:47 PM

#

You can probably put in your lib tbh.

drowsy willow Jun 25, 2024, 6:47 PM

#

i could, yeah

#

i'm gonna try to not do a mrovlib dependency for as long as i can

wicked latch Jun 25, 2024, 6:47 PM

#

Why not?

drowsy willow Jun 25, 2024, 6:48 PM

#

huh

#

that's a great question actually

wicked latch Jun 25, 2024, 6:48 PM

#

It's just a library.

#

Supposedly it shouldn't break on updates.

drowsy willow Jun 25, 2024, 6:48 PM

#

i'm not keen on that, but don't know why exactly

wicked latch Jun 25, 2024, 6:48 PM

#

It just helps with modularity really.

drowsy willow Jun 25, 2024, 6:48 PM

#

importing it into unity means more packages need to go there?

wicked latch Jun 25, 2024, 6:48 PM

#

Separates stuff from A to B, yada yada.

drowsy willow Jun 25, 2024, 6:48 PM

#

and i think it's that

drowsy willow Jun 25, 2024, 6:49 PM

#

wicked latch Separates stuff from A to B, yada yada.

yeah 😔

#

i know

wicked latch Jun 25, 2024, 6:49 PM

#

Ah, you're making it Unity friendly.

drowsy willow Jun 25, 2024, 6:49 PM

#

i'm trying

wicked latch Jun 25, 2024, 6:49 PM

#

It should be just another .dll though.

drowsy willow Jun 25, 2024, 6:49 PM

#

well

#

the thing is

#

in unity you have to import all soft-dependencies that a .dll has

#

i'm gonna think about it though

wicked latch Jun 25, 2024, 6:51 PM

#

Oki oki.

drowsy willow Jun 25, 2024, 6:51 PM

#

because i'm already doing lethallib

#

and i'm planning to have support for LLL tags in the near future

#

which bring all those dependencies in

wicked latch Jun 25, 2024, 6:53 PM

#

Umm

#

What is...

#

Settings?

#

I see the color one being used.

drowsy willow Jun 25, 2024, 6:53 PM

#

lol

#

i forgot about it 😆

wicked latch Jun 25, 2024, 6:53 PM

#

The SelectWeathers I have no idea what you're doing with it.

drowsy willow Jun 25, 2024, 6:54 PM

#

this is my funny setting that i disable in weathertweaks

#

so the Registry doesn't try to sync anything and pick the weathers

#

and it's handled by something else

#

that was the idea, at least

wicked latch Jun 25, 2024, 6:54 PM

#

Hm ok ok

#

So it's like a modder setting more like?

drowsy willow Jun 25, 2024, 6:55 PM

#

yeah

#

there's surely a better way to organize all of those classes/properties

#

but this is what i have now

wicked latch Jun 25, 2024, 6:58 PM

#

You can put sets in the public properties to change the private fields.

#

Like StringToWeather for _weathersDictionary

drowsy willow Jun 25, 2024, 6:59 PM

#

ohh

#

alrighty

wicked latch Jun 25, 2024, 6:59 PM

#

Unless you're using them someplace else I am not seeing.

#

But I'm only seeing them used in the properties thus suggesting it.

drowsy willow Jun 25, 2024, 7:00 PM

#

the thing i wanted to have here is a "cache": it only actually creates the dictionary when it's not present

#

so the expensive operations aren't performed always

wicked latch Jun 25, 2024, 7:00 PM

#

Ye ye.

drowsy willow Jun 25, 2024, 7:00 PM

#

and i'm doing that in the getter itself

#

    internal static Dictionary<string, Weather> _weathersDictionary = null;
    public static Dictionary<string, Weather> StringToWeather
    {
      get
      {
        if (_weathersDictionary != null)
        {
          return _weathersDictionary;
        }

        Dictionary<string, Weather> Weathers = [];

        WeatherManager
          .Weathers.ToList()
          .ForEach(weather =>
          {
            Weathers.TryAdd(weather.name.ToLower(), weather);
            Weathers.TryAdd(weather.Name.ToLower(), weather);
            Weathers.TryAdd(((int)weather.VanillaWeatherType).ToString(), weather);
          });

        _weathersDictionary = Weathers;

        // return the result of this setter
        return Weathers;
      }
    }

wicked latch Jun 25, 2024, 7:00 PM

#

Ye, I know.

#

But for like resetting it.

drowsy willow Jun 25, 2024, 7:01 PM

#

OOOOOOOH right

#

yeah!

#

that makes more sense lol

wicked latch Jun 25, 2024, 7:01 PM

#

Because the get will always return the cached result.

#

So the set just change the cached result to what you want, in this case null.

drowsy willow Jun 25, 2024, 7:02 PM

#

that makes so much more sense, yeah

#

changed that 👍

wicked latch Jun 25, 2024, 7:03 PM

#

In the uhhh.

#

GetPlanetPossibleWeathers

#

How is the possibleWeathers list ever empty or null?

#

(Also double cast to List)

drowsy willow Jun 25, 2024, 7:05 PM

#

oh shit

#

let me find that in weathertweaks

#

cause that's yoinked 1:1

wicked latch Jun 25, 2024, 7:06 PM

#

Oh, I didn't even see the comment above, lol.

#

But yeah, you can probably remove the if.

#

As it won't ever reach there.

drowsy willow Jun 25, 2024, 7:07 PM

#

#

it seems like i've changed the code order somewhere

wicked latch Jun 25, 2024, 7:08 PM

#

Wait a second.

#

It has triple cast.

drowsy willow Jun 25, 2024, 7:08 PM

#

yeah 😭

wicked latch Jun 25, 2024, 7:08 PM

#

drowsy willow Jun 25, 2024, 7:08 PM

#

after .Where is has to go to the list (becuase c#)

#

and after .Select the same

#

so the first one is not needed, but the rest are?

#

i think

wicked latch Jun 25, 2024, 7:09 PM

#

HyperHMM

drowsy willow Jun 25, 2024, 7:09 PM

#

it's not screaming, but the results won't be correct

#

wait a moment

wicked latch Jun 25, 2024, 7:09 PM

#

How so?

#

The things are waiting for IEnumerable, not List

drowsy willow Jun 25, 2024, 7:10 PM

#

wait

#

what did i do that got me this issue first time

wicked latch Jun 25, 2024, 7:10 PM

#

Am I gonna find a quadruple cast somewhere here?

drowsy willow Jun 25, 2024, 7:11 PM

#

i hope no

wicked latch Jun 25, 2024, 7:12 PM

#

Oh.

#

oh no.

drowsy willow Jun 25, 2024, 7:12 PM

#

please no

wicked latch Jun 25, 2024, 7:12 PM

#

You just want to murder RAM, don't you?

drowsy willow Jun 25, 2024, 7:13 PM

#

what happened 😭

wicked latch Jun 25, 2024, 7:13 PM

#

GetPlanetWeightedList

drowsy willow Jun 25, 2024, 7:14 PM

#

that's the weight shit you pointed before

#

OH my new stuff is badbad

#

isn't it

wicked latch Jun 25, 2024, 7:15 PM

#

Like

#

There's some merit in it.

#

But the problem is that you end putting in a list with repeated entries.

#

So if I decided to put a weight of, I don't know...

#

drowsy willow Jun 25, 2024, 7:16 PM

#

it's gonna put 1000 ints there

wicked latch Jun 25, 2024, 7:16 PM

#

Yeah, it will put 1000 * sizeof(int)

drowsy willow Jun 25, 2024, 7:16 PM

#

.<

ancient depot Jun 25, 2024, 7:16 PM

#

concern

wicked latch Jun 25, 2024, 7:17 PM

#

Meaning...

#

If I know C# memory...

drowsy willow Jun 25, 2024, 7:17 PM

#

memory nom nom nom

wicked latch Jun 25, 2024, 7:17 PM

#

Either 4k bytes or 8k bytes.

drowsy willow Jun 25, 2024, 7:17 PM

#

4mb for this shit?

wicked latch Jun 25, 2024, 7:17 PM

#

It's the first, I checked.

drowsy willow Jun 25, 2024, 7:17 PM

#

ouch

wicked latch Jun 25, 2024, 7:17 PM

#

For 1k weight, yeah.

ancient depot Jun 25, 2024, 7:17 PM

#

Mrov has some optimizations to do

drowsy willow Jun 25, 2024, 7:18 PM

#

hmmm

#

that's not great

#

it's not the worst

#

but could be soooo much better

wicked latch Jun 25, 2024, 7:20 PM

#

drowsy willow 4mb for this shit?

Also kb, not mb.

#

Christ.

drowsy willow Jun 25, 2024, 7:20 PM

#

oh 😅

#

ye

wicked latch Jun 25, 2024, 7:24 PM

#

VanillaWeatherTypes is still in NewWeathers

#

At least I remember seeing these when I last checked.

#

A cast before a find?

#

Why do you need to cast?

#

There's also quota things not used.

drowsy willow Jun 25, 2024, 7:26 PM

#

oh my lord

wicked latch Jun 25, 2024, 7:26 PM

#

Then weights from previousDay that are not used either.

#

Or well, previousDayWeatherWeather

drowsy willow Jun 25, 2024, 7:27 PM

#

hoarders episode incoming

wicked latch Jun 25, 2024, 7:27 PM

#

WeatherController is essentialy a static class.

#

Same for the manager.

drowsy willow Jun 25, 2024, 7:28 PM

#

OH it's not marked as static 💀

#

so much shit copied from weathertweaks without second thought

#

it's genuinely disturbing

wicked latch Jun 25, 2024, 7:31 PM

#

I like how you save the network manager but then you don't use it.

#

You just keep on passing through GetComponents, lol.

drowsy willow Jun 25, 2024, 7:32 PM

#

copied from LLL 😭

#

which is copied from LL

wicked latch Jun 25, 2024, 7:32 PM

#

So yeah, either don't use the cached result (because I only see one usage) or use the cached result and remove the param from the method

drowsy willow Jun 25, 2024, 7:33 PM

#

i see what you mean

wicked latch Jun 25, 2024, 7:34 PM

#

FixedString4096Bytes is to pass string through RPCs?

drowsy willow Jun 25, 2024, 7:34 PM

#

i've used the 1024Bytes one

#

and it got too big at one point

#

so i'm using the biggest

wicked latch Jun 25, 2024, 7:34 PM

#

Why not use encoding?

drowsy willow Jun 25, 2024, 7:34 PM

#

👀

wicked latch Jun 25, 2024, 7:34 PM

#

Like turn to bytes then turn to string after?

drowsy willow Jun 25, 2024, 7:34 PM

#

ummm

wicked latch Jun 25, 2024, 7:35 PM

#

Or, well, anything you want to turn back to after the network message.

drowsy willow Jun 25, 2024, 7:35 PM

#

you can see my lack of knowledge 😭

wicked latch Jun 25, 2024, 7:35 PM

#

I mean, it works for now.

#

But as soon it gets more weathers, it will probably die at some point.

drowsy willow Jun 25, 2024, 7:35 PM

#

this whole thing is me trying not to use LethalNetworkAPI (like for weathertweaks)

#

which goes well

#

🤭

drowsy willow Jun 25, 2024, 7:36 PM

#

wicked latch But as soon it gets more weathers, it will probably die at some point.

i wonder what's the moon limit that will break this

wicked latch Jun 25, 2024, 7:36 PM

#

Well, 4096 bytes is 4096 characters.

drowsy willow Jun 25, 2024, 7:36 PM

#

because it's setting that:

{"41 Experimentation":3,"220 Assurance":4,"56 Vow":4,"71 Gordion":-1,"61 March":9,"20 Adamance":6,"85 Rend":2,"7 Dine":7,"21 Offense":9,"8 Titan":6,"68 Artifice":1,"44 Liquidation":7,"5 Embrion":6}

#

which could probably be squeezed even more

wicked latch Jun 25, 2024, 7:37 PM

#

Probably.

drowsy willow Jun 25, 2024, 7:37 PM

#

or - like you said - just don't use strings 😅

wicked latch Jun 25, 2024, 7:37 PM

#

You would just need to be careful when converting stuff around.

drowsy willow Jun 25, 2024, 7:37 PM

#

how would i do that?

#

oh wait, i can use INetworkSerializable types

#

but that still requires a serializer on my end

#

i'm gonna try doing that in the near future

wicked latch Jun 25, 2024, 7:40 PM

#

drowsy willow but that still requires a serializer on my end

Yeah.

#

Nice == false

drowsy willow Jun 25, 2024, 7:47 PM

#

i'm getting roasted here

wicked latch Jun 25, 2024, 7:47 PM

#

Also delete code instead of commenting it.

#

It will be too much clutter at some point if you keep doing it.

drowsy willow Jun 25, 2024, 7:48 PM

#

I KNOW 😭

#

the hoarder brain never has enough

#

I FIXED THE GITHUB ACTIONS NOT WORKING 😇

#

https://github.com/AndreyMrovol/LethalWeatherRegistry/commit/30482a2bb48550a23de3b04be92fef5bda59fcd2

GitHub

Update thunderstore.toml · AndreyMrovol/LethalWeatherRegistry@30482a2

#

funsies

#

i'll try to tackle the weight list today as well

wicked latch Jun 25, 2024, 8:06 PM

#

Bundles?

drowsy willow Jun 25, 2024, 8:07 PM

#

it didn't find them (cause i don't have bundles), so it gave up

wicked latch Jun 25, 2024, 8:11 PM

#

So you're creating a blank prefab?

drowsy willow Jun 25, 2024, 8:11 PM

#

yes

wicked latch Jun 25, 2024, 8:11 PM

#

Oki

drowsy willow Jun 25, 2024, 10:25 PM

#

i think i got it working

#

i did not

#

i did

lofty silo Jun 26, 2024, 1:07 AM

#

extremely stupid question, but I'm setting up WR to match the original meteo values here
+10% (dustclouds, foggy, rainy), +30% (stormy), +40% (flooded), +50% (eclipse)
Would that just be 10, 10, 10, 30, 40, 50 in WR's values? Or am I tripping

worldly sleet Jun 26, 2024, 1:42 AM

#

why would dustclouds give extra scrap value

lofty silo Jun 26, 2024, 1:49 AM

#

we just dont know

#

allergen hazard

gray kayak Jun 26, 2024, 2:54 AM

#

lofty silo extremely stupid question, but I'm setting up WR to match the original meteo val...

ancient depot Jun 26, 2024, 3:07 AM

#

gray kayak

@drowsy willow please make these the default values, and for Windy do 1.2 and Meteor Shower 1.6 ^^

abstract pivot Jun 26, 2024, 7:42 AM

#

No

drowsy willow Jun 26, 2024, 8:41 AM

#

I'm not planning to - that's why the configs are there 🥲

drowsy willow Jun 26, 2024, 8:42 AM

#

lofty silo extremely stupid question, but I'm setting up WR to match the original meteo val...

10% more from default is (1*1.1) = 1.1

rapid thistle Jun 26, 2024, 8:50 AM

#

I am getting tons of fatal errors after updating and I'm unsure how to parse them D:

#

drowsy willow Jun 26, 2024, 8:50 AM

#

I forgot to remove those logs from my disastrous testing session, don't worry about them

#

I'll push an update today to get rid of those

rapid thistle Jun 26, 2024, 8:51 AM

#

okiedokie ❤️ thank youuuu for your wonderful work :3

wicked latch Jun 26, 2024, 1:41 PM

#

Imagine using fatal logging.

abstract pivot Jun 26, 2024, 1:43 PM

#

wicked latch Imagine using fatal logging.

imagine

wicked latch Jun 26, 2024, 1:43 PM

#

_
_

abstract pivot Jun 26, 2024, 1:43 PM

#

that imagination is quite large

wicked latch Jun 26, 2024, 1:43 PM

#

Nothing is quite large, yes.

drowsy willow Jun 26, 2024, 3:36 PM

#

oh my god

#

i just forgor 😭

drowsy willow Jun 26, 2024, 3:38 PM

#

wicked latch Imagine using fatal logging.

I will not allow to be roasted second day in a row 😂

#

the damage is done already 🤭

quiet agate Jun 26, 2024, 5:44 PM

#

What does Weather Weight actually do?

#

I understand default and level but this one I can't think of what it'd do

drowsy willow Jun 26, 2024, 9:30 PM

#

weather>weather weights changes the weight of the weather when the defined weather was there on the previous day

#

so if you want Foggy to have a big chance to happen after Eclipsed, you would type Eclipsed@500 into the Foggy config

#

I will write a proper readme someday 😭

drowsy willow Jun 26, 2024, 10:12 PM

#

drowsy willow so if you want Foggy to have a big chance to happen after Eclipsed, you would ty...

and also that's the exact system that weathertweaks has - weather to weather weights

ancient depot Jun 26, 2024, 10:26 PM

#

drowsy willow and also that's the exact system that weathertweaks has - weather to weather wei...

Just wanted to let you know cus we added WeatherTweaks back earlier as a test

#

Unknown weather and weathers with ? at the end no longer appear as that on the monitor

#

It just always shows the correct weather

#

lol

drowsy willow Jun 26, 2024, 10:29 PM

#

huh

#

i know why

#

again: forgor 💀

#

will fix tomorrow

ancient depot Jun 26, 2024, 10:29 PM

#

Yeah just wanted to let you know

ancient depot Jun 26, 2024, 10:30 PM

#

drowsy willow will fix tomorrow

Btw since you're trying to have Registy on par with StableTweaks, can you implement the first day stuff to Registry?

drowsy willow Jun 26, 2024, 10:30 PM

#

ancient depot Btw since you're trying to have Registy on par with StableTweaks, can you implem...

the weathers always being the same on first day? i'll try to cook something up tomorrow

ancient depot Jun 26, 2024, 10:31 PM

#

Yeah cus too many planets start off with insane weathers without WeatherTweaks XD

#

and I imagine that's a feature that Registry should include

drowsy willow Jun 26, 2024, 10:31 PM

#

definitely not as a default, but there's gonna be something 🤭

ancient depot Jun 26, 2024, 10:31 PM

#

:3

lofty silo Jun 26, 2024, 10:58 PM

#

gray kayak

thank you for the handy chart!

drowsy willow Jun 27, 2024, 7:04 AM

#

WeatherRegistry v0.1.8

optimized the weight-picking algorithm (thanks, whitespike)
changed some logs

#

finally got github actions to work

ancient depot Jun 27, 2024, 7:13 AM

#

drowsy willow # WeatherRegistry v0.1.8 - optimized the weight-picking algorithm (thanks, whit...

Is the change I asked for in there too? 🥺

#

Hoorah for optimization though

#

c;

drowsy willow Jun 27, 2024, 7:16 AM

#

the first day? not yet 😅

#

i've just fixed my automated workflow to push the updates 🤭

ancient depot Jun 27, 2024, 7:16 AM

#

Noice

drowsy willow Jun 27, 2024, 7:17 AM

#

which means that now i don't have to manually push new releases and i have one set of readme and changelogs instead of 2 😆

ancient depot Jun 27, 2024, 7:17 AM

#

Good

#

XD

manic cobalt Jun 27, 2024, 7:28 AM

#

drowsy willow which means that now i don't have to manually push new releases and i have one s...

ok now figure out how to cross release to CF

#

😛

drowsy willow Jun 27, 2024, 7:30 AM

#

i found the relevant action already: https://github.com/marketplace/actions/upload-to-curseforge

#

i will tinker with it 😇

drowsy willow Jun 27, 2024, 8:31 AM

#

oh i hate that upload system

#

it would be easier if i made a node script for it

#

so i can do some cursed stuff

#

there is still no bepinex on CF 😭

drowsy willow Jun 27, 2024, 9:23 AM

#

forcing people to use yaml should be punishable

drowsy willow Jun 27, 2024, 10:37 AM

#

let's see

#

so close 😭

drowsy willow Jun 27, 2024, 10:55 AM

#

interesting

#

it shows that something went through, but nothing is shown on CF end

drowsy willow Jun 27, 2024, 11:22 AM

#

i think i can claim success

#

i wasted 4 hours on that, barely worth it

manic cobalt Jun 27, 2024, 11:22 AM

#

thats sick as hell tho

loud heart Jun 27, 2024, 11:56 AM

#

wait-

Is the newest update able to make weather appear in moons it doesn't appear?

drowsy willow Jun 27, 2024, 11:57 AM

#

vanilla moons?

loud heart Jun 27, 2024, 11:58 AM

#

yea

#

or modded

drowsy willow Jun 27, 2024, 11:59 AM

#

no

#

you can't add a vanilla weather to any moon, but you can prevent it from being there

loud heart Jun 27, 2024, 11:59 AM

#

ah k

#

now I remember lol

drowsy willow Jun 27, 2024, 12:00 PM

#

because of how vanilla weathers work, you have to set up weather variables on the SelectableLevel itself and it affects the weathers (like Flooded wave height, Eclipsed spawning amount of monsters etc.)

loud heart Jun 27, 2024, 12:00 PM

#

just got confused by the config structure

drowsy willow Jun 27, 2024, 12:00 PM

#

so i would have to have something to allow that

#

and i'm not planning to

#

#

no worries 😅

loud heart Jun 27, 2024, 12:01 PM

#

nice

drowsy willow Jun 27, 2024, 12:09 PM

#

forgot to do that:

WeatherRegistry 0.1.9

added config options to disable logging startup logs & weather selection logs

wicked latch Jun 27, 2024, 4:07 PM

#

drowsy willow # WeatherRegistry v0.1.8 - optimized the weight-picking algorithm (thanks, whit...

patneko

drowsy willow Jun 27, 2024, 4:08 PM

#

I got roasted so brutally I've changed the code that was there since the beginning 🤭

#

thanks again 😇

wind bough Jun 27, 2024, 4:31 PM

#

👍

drowsy willow Jun 28, 2024, 9:29 AM

#

WeatherRegistry v0.1.10

fixed an issue with randomWeathers having multiple entries of the same modded weather (thanks, @abstract pivot )

abstract pivot Jun 28, 2024, 9:30 AM

#

yw

drowsy willow Jun 28, 2024, 3:06 PM

#

don't come to school tomorrow

obsidian schooner Jun 28, 2024, 3:39 PM

#

:[

drowsy willow Jun 28, 2024, 4:18 PM

#

WeatherTweaksBeta 0.20.6

(hopefully) fixed an issue with ChangeMidDay allocating absurd amounts of memory every TimeOfDay update (thanks, diffoz)
moved even more things into WeatherRegistry

drowsy willow Jun 28, 2024, 5:09 PM

#

my mods should work without any changes needed on v55

#

literally nothing changed lol

wicked latch Jun 28, 2024, 5:10 PM

#

Nice.

#

I might need to light up a candle or two.

wicked latch Jun 28, 2024, 5:27 PM

#

So apparently mine didn't immediately catch on fire.

#

As the patches seemed all fine.

#

Um, I'm sorry?

#

Why is the player controller tracking what the vehicle does?

#

pensivebear

drowsy willow Jun 28, 2024, 5:29 PM

#

that's all - hardcoded Mask change and 4 new fields

#

😭

#

let me try to decompile for the 3rd time

wicked latch Jun 28, 2024, 5:30 PM

#

Also good luck on || driving the car to a decent degree ever.||

drowsy willow Jun 28, 2024, 5:30 PM

#

i will always prefer the wheelbarrow 🫡

wicked latch Jun 28, 2024, 5:31 PM

#

Lol

#

Just to give you an idea:
||Back is always stopping the car||

drowsy willow Jun 28, 2024, 5:33 PM

#

oh no

bright viper Jun 28, 2024, 9:22 PM

#

checking weather registry configs rn and...
What are these defaults?
Mrov why are you evil?!!

drowsy willow Jun 28, 2024, 9:28 PM

#

🤭

#

i've done some tweaks, if i may

bright viper Jun 28, 2024, 9:28 PM

#

also what is cloudy weather exactly?
And why does it also have less loot value 😭

drowsy willow Jun 28, 2024, 9:31 PM

#

it's clear weather

#

but cloudy

bright viper Jun 28, 2024, 9:31 PM

#

sounds pretty

#

BUT WHY LESS LOOT VALUE 😭

drowsy willow Jun 28, 2024, 9:32 PM

#

🤭 i was testing my own api's settings 😅

#

and (it looks like) the defaults & configs are working 😇

bright viper Jun 28, 2024, 9:34 PM

#

yeah honestly I was really surprised everything works

drowsy willow Jun 28, 2024, 9:34 PM

#

it's literally unlike me 😂

bright viper Jun 28, 2024, 9:35 PM

#

||~~the terminal cruiser incident~~||

stiff hatch Jun 28, 2024, 10:52 PM

#

Does anyone know the default chances of weather?

drowsy willow Jun 29, 2024, 8:35 AM

#

stiff hatch Does anyone know the default chances of weather?

Everything should be in the config 🥺

#

By default the vanilla weathers have weight of 100

stiff hatch Jun 29, 2024, 7:34 PM

#

drowsy willow By default the vanilla weathers have weight of 100

They’re all the same? Eclipse is definitely not as common as none

drowsy willow Jun 29, 2024, 7:35 PM

#

look at the default weather-weather weights in the config - they are used before the default one

stiff hatch Jun 29, 2024, 7:42 PM

#

Oh ok that update added the actual defaults. I had to generate a new config to see that. Thanks. So they are all 100 but their weights based on the previous weather is what’s different?

drowsy willow Jun 29, 2024, 7:44 PM

#

yeah

#

I'm gonna copy how it works from the readme:

Weight-based weather selection system

Contrary to the vanilla algorithm, this mod uses a weight-based system for selecting weathers. You can set the weights based on 3 criteria:

Level weight: the weight of the weather based on specific level
Weather-to-weather weight: the weight of the weather based on the previous weather
Default weight: the base weight of the weather

During the weather selection process, the algorithm will try to apply the weights in the order listed above.

stiff hatch Jun 29, 2024, 8:00 PM

#

So if I don't touch the config, the weather is the same as vanilla? Your description says "contrary to vanilla" so I'd assume it's different.

drowsy willow Jun 29, 2024, 8:06 PM

#

the weight system itself is different than vanilla

#

the defaults are not equal to vanilla ones

stiff hatch Jun 29, 2024, 8:07 PM

#

Ok. So my question was what are the vanilla chances of weather?

drowsy willow Jun 29, 2024, 8:09 PM

#

🤷

#

vanilla rolls a number of moons to apply weather to, then picks a random one from the SelectableLevel array

rapid thistle Jun 30, 2024, 12:12 AM

#

does the weather tweaks beta play alright with brutal company minus?

drowsy willow Jun 30, 2024, 4:51 AM

#

that's a great question

prisma vault Jun 30, 2024, 4:59 AM

#

Whay is the differmece

#

Between default weights

#

And the qeather weights

#

In the config?

drowsy willow Jun 30, 2024, 4:59 AM

#

drowsy willow I'm gonna copy how it works from the readme: ## Weight-based weather selection s...

👆

prisma vault Jun 30, 2024, 4:59 AM

#

Oop-

#

My bad

drowsy willow Jun 30, 2024, 4:59 AM

#

No worries 😅

prisma vault Jun 30, 2024, 5:00 AM

#

So if I want all of the weights to be default, i would have to basically delete all the weather-to-weather weights?

#

So they all use the default one?

drowsy willow Jun 30, 2024, 5:02 AM

#

Yes

#

Exactly

#

If it's the only weight that can be used, it's gonna be used

rapid thistle Jun 30, 2024, 5:15 AM

#

drowsy willow that's a great question

then I shall test it. I will be the guinea pig

drowsy willow Jun 30, 2024, 10:46 AM

#

i have an idea

rapid thistle Jun 30, 2024, 11:47 AM

#

@drowsy willow I was wondering, how does the beta interact with MeteoMultiplier? I'm trying to figure out if it's functioning the same way with Brutal Company Minus' weather multipliers

#

this is fantastic by the way, especially in conjunction with the terminal formatter

#

really cool stuff

drowsy willow Jun 30, 2024, 11:48 AM

#

weathertweaks beta?

rapid thistle Jun 30, 2024, 11:48 AM

#

yep

drowsy willow Jun 30, 2024, 11:48 AM

#

it doesn't

rapid thistle Jun 30, 2024, 11:48 AM

#

ok, makes sense

drowsy willow Jun 30, 2024, 11:48 AM

#

i've cut that part out when moving to Registry, and haven't implemented it back yet

#

cause - naturally - i'd like to only use the registry system moving forward

#

https://github.com/AndreyMrovol/LethalWeatherTweaks/blob/weathers-extended/WeatherTweaks/Patches/ModCompatibility/MeteoMultiplier.cs

#

i've commented out all code touching meteomultiplier

#

so nothing is in the final product

drowsy willow Jun 30, 2024, 11:50 AM

#

rapid thistle <@231002429406183424> I was wondering, how does the beta interact with MeteoMult...

and when it comes to BrutalCompany: we're patching the same method, so there's two options:

both our values are applied
only one is applied

#

i'm replacing both the ScrapAmountMultiplier and ScrapValueMultiplier

#

so if my patch runs last, it's only gonna use my values

rapid thistle Jun 30, 2024, 11:51 AM

#

right, ok. hmmm

drowsy willow Jun 30, 2024, 11:52 AM

#

HUH actually

#

it's always gonna use both?

#

no, it's always gonna use mine, i've checked

#

because i'm applying the values much later than BC

rapid thistle Jun 30, 2024, 11:53 AM

#

ok cool. that's good

#

I'll play around with some different values and settings and see what feels right

#

and again, really cool stuff, I am loving the unpredictability

wicked latch Jun 30, 2024, 4:16 PM

#

drowsy willow i have an idea

eyesshake

drowsy willow Jun 30, 2024, 4:18 PM

#

🤭

#

i love your panicked emotes

wicked latch Jun 30, 2024, 4:19 PM

#

Wait til I show you '1' + 1

drowsy willow Jun 30, 2024, 4:19 PM

#

good 'ol javascript

abstract pivot Jun 30, 2024, 4:20 PM

#

wicked latch Wait til I show you '1' + 1

output is probably true

drowsy willow Jun 30, 2024, 4:20 PM

#

wicked latch Wait til I show you '1' + 1

how about i one-up you?

shadow bough Jun 30, 2024, 4:21 PM

#

banana

drowsy willow Jun 30, 2024, 4:21 PM

#

shadow bough banana

YES 😆

#

i remember that

#

document.write('ba'+(+'a')+'a');

drowsy willow Jun 30, 2024, 5:41 PM

#

wicked latch You can probably put in your lib tbh.

sorry to bring you out of your sleep

#

#

i tried

#

do i need to match the namespace for it to be accessible?

wicked latch Jun 30, 2024, 5:42 PM

#

Ye.

#

How are you doing it though?

drowsy willow Jun 30, 2024, 5:43 PM

#

oh

#

i've copy-pasted it into the lib

#

so it sits in a ConsoleTables namespace

#

inside MrovLib assembly

#

and - what's funny - i can access it in my code

#

there's no errors, everything is fine

#

and it doesn't work 😔

wicked latch Jun 30, 2024, 5:44 PM

#

Is the assembly loaded?

drowsy willow Jun 30, 2024, 5:44 PM

#

yees

#

i'm using harddependency

wicked latch Jun 30, 2024, 5:44 PM

#

And it's not confusing with other namespace.

drowsy willow Jun 30, 2024, 5:45 PM

#

no, i've removed it from the "local" code so to speak

#

wicked latch Jun 30, 2024, 5:45 PM

#

And nowhere else you would have the same field in the same namespace.

drowsy willow Jun 30, 2024, 5:45 PM

#

that's what the reference is pointing to

#

unless

#

waaaaaaait

#

it was terminalformatter

#

delightful

#

sorry to take your time 😅

wicked latch Jun 30, 2024, 5:48 PM

#

It's fine.

drowsy willow Jun 30, 2024, 5:48 PM

#

the rubber duck experience ™️

wicked latch Jun 30, 2024, 5:49 PM

#

I like always wasting time on coding anyways.

wicked latch Jun 30, 2024, 7:39 PM

#

Not so much on strings though.

abstract pivot Jun 30, 2024, 8:00 PM

#

Lmao

pallid sandal Jun 30, 2024, 10:05 PM

#

What exactly does this function do? Speed up time inside the moon based on game progression?

#

I'm using BetaWeatherTweaks 0.20.6

drowsy willow Jul 1, 2024, 1:23 AM

#

its lowering the chance of clear weather based on the # of completed quotas

tall tangle Jul 1, 2024, 2:20 AM

#

Im not suggesting it but how complex would it be to make weathertoweather weights different for each moon?

drowsy willow Jul 1, 2024, 4:21 AM

#

so you'd have even more specifically defined weights?

#

I like the idea, but it's not something I'm gonna implement

drowsy willow Jul 1, 2024, 4:44 AM

#

although I might add an event for easily adding your own weights to the mix

#

so an external mod could do that without hassle

tall tangle Jul 1, 2024, 7:07 AM

#

differing weather patterns for each moons would be nice but I figured that weather to weather 11 times would be alottt

drowsy willow Jul 1, 2024, 1:43 PM

#

yeah 😅

drowsy willow Jul 1, 2024, 5:26 PM

#

wicked latch You can probably put in your lib tbh.

i caved in

wicked latch Jul 1, 2024, 5:26 PM

#

HeHeHeHe

drowsy willow Jul 1, 2024, 5:27 PM

#

i've played with the weight handler

#

and now it's a little bit overkill

#

https://github.com/AndreyMrovol/LethalMrovLib/blob/main/MrovLib/WeightHandler.cs

abstract pivot Jul 1, 2024, 5:41 PM

#

drowsy willow and now it's a little bit overkill

You mean..... overweight?

drowsy willow Jul 1, 2024, 5:41 PM

#

i am not overweight

abstract pivot Jul 1, 2024, 5:42 PM

#

Thank you, thank you, here every Monday from 9 to 5

abstract pivot Jul 1, 2024, 5:42 PM

#

drowsy willow i am not overweight

Nou

#Weather Registry / Weather Tweaks / mrov

WeatherRegistry 0.1.1

BetaWeatherTweaksBeta 0.20.4

WeatherRegistry 0.1.4

WeatherRegistry v0.1.8

WeatherRegistry 0.1.9

WeatherRegistry v0.1.10

WeatherTweaksBeta 0.20.6

Weight-based weather selection system