General Improvements

[light girder]

If you have OpenBodyCams you can disable it in the config

It'll be this option

[patent orbit]

thanks

[light girder]

👍

[patent orbit]

@light girder I was testing if the disabling better monitors does improve performance on my end, but it only takes around 3~ fps so i will probably keep it on.

don't wanna let this beauty go for 3-5 fps

[light girder]

The fps difference mostly happens while the ship is landed, and it gets worse as you put more items on the ship

The Camera.Render() stuff Better Monitors uses causes a lot of Overhead

[patent orbit]

I have tested it past 4-5 hours and it is usualy 10 fps at max

[light girder]

So the longer you play and just do stuff the fps on the ship gets worse and worse

Also fps loss isn't the main problem

It causes frame time inconsistencies

[patent orbit]

yeah you might be right

[light girder]

Which are very noticeable

[patent orbit]

i see

[light girder]

Yeah

GI has quite a few features that need optimizations, DiFFoZ found that out when he profiled it

I currently can't even use GI cus I'm playing on the V55 beta

lol

[patent orbit]

well it didn't bother me that much but i will probably switch it off if it feel too laggy

[patent orbit]

hmm im still at v50

[light girder]

Yeah I'm gonna stay on the beta til V55 hits the main branch, it's stable enough that I don't see much point to revert to V50

[patent orbit]

Thats good news

hope it comes out soon

[light girder]

Same

[dawn rover]

I built the mod with this branch and re-used the assets from the latest release and from what I've tested so far it works perfectly fine

[light girder]

Yeah that's the fix it needs for V55, Shaoshil just needs to merge and push it to Thunderstore

It's more so does it also work on V50 though?

[dawn rover]

not sure, I could check again when I get a chance

I'll let you know

[sour rain]

it's going to break v50

because SprayPaintItem.isWeedKillerSprayBottle doesn't exist

[sour rain]

oh that's crazy

[rough salmon]

👀

[proven moth]

1st

[short frost]

2nd

[umbral ermine]

3rd

[cerulean thunder]

4th

[short frost]

too much spam

@iron socket ban them all

[rough salmon]

NO

[umbral ermine]

esp. the second one

cuz she a snitch

[rough salmon]

~~someone give me my custom emojis back 😔 ~~

[dawn rover]

yeah no breaks on v50 now, expected though LOL

[vapid acorn]

@broken crescent could you modify PatchKeyActivate so that it handles me transpiling in another DespawnHoldObject 👉 👈

[iron socket]

I was SLEEP

[hazy quail]

maybe if u get a neuralink chip implanted into ur brain u could moderate discord in ur sleep

[rough salmon]

DON'T BAN US!!

[rough salmon]

yet

[edgy crystal]

is lethal fixes or this mod better or are both compatible with one another

[light girder]

They're both compatible with each other.

[sour rain]

they are both compatible with each other, right now general improvements won't load on v55 though because ||weed killer|| added new functionality to SprayPaintItem that breaks most pre-existing spray paint mods

lethalfixes has been updated for v55 (and is also good and you should use it)

[low gyro]

i've always seen your pfp as the 2 black guys kissing and i'll never unsee it

[sour rain]

it's the wolves meme!

[low gyro]

yeah but like

i can't unsee it 😭

[sour rain]

🙂

[rough salmon]

generalimprovements my beloved fix soon ):

[low gyro]

https://cdn.discordapp.com/attachments/1190731323615232012/1258178549194686575/1645710982_CounterG03LM_1.gif

[rough salmon]

😔

is there a built dll of the v55 fix version?

[dawn rover]

I've got one I can send you in DMs

works great on v55 so far but still might be issues

[rough salmon]

alr

[cerulean thunder]

Fun fact: if this is the meme I’m thinking of, the two guys actually got married!

[late owl]

yup

pretty wholesome

[upper schooner]

Oh SprayPaintItem must be why ShowCapacity is able to show its respective UI bar for the Weed Killer too, took me by surprise when I saw it

[oak cradle]

yeah, maybe it could be released as a seperate mod, at least for the duration of the v55/56 beta

[light girder]

Or we just be patient and wait, I don't think it'll be in Beta for much longer.

And some seperate mods have released in the meantime to fill in GI's gaps

[oak cradle]

still, mostly missing better monitors

[light girder]

Better Monitors kills fps anyways and I stopped using that so I can live with OpenMonitors atm

I just miss the OCD fixes the monitors had

and being able to color them

lol

[oak cradle]

yeah im also using openmonitors, not as many good options though and I kind of miss the extra 5 monitors lol

[late owl]

I couldn't get OpenMonitors to work with generalimprovements

despite turning off better monitors

[light girder]

GeneralImprovements is broken entirely on V55+ atm anyways

So it's likely it was trying to load it's monitors on top of OpenMonitors

[late owl]

But, like on v50

[light girder]

If you're using V50 you don't need OpenMonitors

[late owl]

ah ?

[patent orbit]

Does changing the monitor texts but not using the bettermonitors still affect performance?

like this

[light girder]

@broken crescent V56 is on the main branch now if you'd like to Merge 1A3's pr

[upper schooner]

Oh v56 is out of beta now?

Not at home so can't really check myself

[hazy quail]

yes

itsa public

[upper schooner]

Ah gotcha

[thin pecan]

Does this mean general improvements is gonna be updated soon?

[upper schooner]

Prob

[broken crescent]

Yeah hopefully, I'll be away from home for a few days but I hope to get this updated within a week(ish)

[fast lintel]

🙏

praying ur mod updates, it was an must for my modpack

[late owl]

It's a life saver

[dawn rover]

another thing to note when you update the mod, it seems that the fire-exit fix no longer works on v55 and needs to be updated

good luck dude!

[upper venture]

did the terminal shortcuts like arrow left/right for quick monitor switching stop working in v55?

[jagged flower]

Take care Shaosil may you return home safely!

Something to add to what Lilo said (the fire exit is such a good one you made )
so far for me the "Mechanics" section of this mod no longer seem to apply
also hope the "disable cabinet doors" can be fix, but ill wait till your return :3!

[hazy quail]

bro is probably away doing security work at some undisclosed research facility

[light girder]

There's seperate mods for this

[light girder]

Interesting the seperate ones do

https://thunderstore.io/c/lethal-company/p/KarmaModding/NoFacingFireExit/ I'm using this one and it works

https://thunderstore.io/c/lethal-company/p/TKronix/DoorlessStorage/ This can replace the disable cabinet doors feature

It's the og mod that did it

and it still works

@dawn rover It's possible in V56 the Teleporter changes cause issues with GI now rather than the Spray Paint ones, I know CollectYourDead no longer works and it did with the V55 beta

[dawn rover]

I'll install this into our modpack thanks, our doorless storage is working perfectly fine however

[dawn rover]

interesting, which teleporter changes were done in v56?

didn't know that code was actually touched

[light girder]

Inverse Teleporters got changed to react to Spike Traps

[dawn rover]

oh neat, I'm gonna test a few things with the build of GI because I'm pretty sure it still works

not sure I'll take a look rq

[dawn rover]

The collectyourdead-like setting in GI is working in v56

weird

[broken crescent]

Shh

[low gyro]

bro prolly working for the aahw or some shi 😭

[broken crescent]

Bout to write a GI patch for the government

[polar junco]

Hello,

I seem to be encountering an Exception when I load up Lethal Company with General Improvements. Previously I thought it was due to the Better Spray Paint mod, but I removed that and am still getting the same issue:

[light girder]

It's a known issue right now

GI is broken on V56

[polar junco]

Ah okay, that makes sense.

[gritty current]

What is broken with it? Ive still got it installed for extra monitors and a few other QoL settings and most seem to still work

[hazy coral]

I know for us the monitors do not work, fire exit flip and so on dont work either.

[drifting quail]

mod not working anymore

[upper schooner]

They're aware that the mod needs updating for v56

[cold minnow]

By not working, do you mean the whole mod or just some parts like the monitors for example?

Because I did notice the monitors not working, but I am unsure if anything else still works

[upper schooner]

It feels like the whole mod doesn't work, I noticed all of the features I had enabled didn't seem to work

I don't use BetterMonitors at all, but I noticed the extra monitors don't render anything, the terminal history & quick switching didn't work, lightning warning indicator didn't work, etc.

[cold minnow]

Well that straight up sucks, guess time to wait then

[sour rain]

im pretty sure the mod wont load at all rn because of the spray paint crash

if anything is working, probably a bit of a fluke

[broken crescent]

I merged a couple PRs and resolved the rest of the startup warnings and errors. I have NOT tested the gameplay but it loads the ship without errors. I need to leave soon and be gone for a couple days but I can probably get this deployed real quick first.

Next time I touch it will be to fix other things, especially that lightning error that turns monitors off

And yeah some things might have loaded but as soon as that spray paint had an error it would have prevented anything else from loading

[cold minnow]

Thank you friend

You are awesome

[broken crescent]

Ok that should be deploying within a few minutes here, hopefully some of ya'll will ping me if there's more bugs than what we started with 😄

[low gyro]

i have an idea

if it hasn't already been done

assimilate this mod into general improvements https://thunderstore.io/c/lethal-company/p/taffyko/BetterSprayPaint/

[fast lintel]

yeah please

[kind turret]

just got home from work ready to get a mod list set to cover all the things covered in this one; HUGE thanks for the update, saved me an afternoon of searching

[limber dome]

how's the new GI update in terms of performance?

[light girder]

It doesn't address any of the settings that caused performance issues

That's probably what Shaoshil will work on when he fixes the lightning bug and stuff

[limber dome]

yeah but maybe some perfomance improvements slipped through in the PRs he merged

[light girder]

Nah I remember checking the github the pr's were just bug fixes

[limber dome]

Yeah I am checking them rn

[light girder]

Just these 2 got merged

[limber dome]

damn I really want to add GI back

[light girder]

I know someone mentioned the fire exit fix in GI is broken in V56

So you need to use an alternate mod

[limber dome]

honestly I don't mind that much. it didn't work on some custom interiors previously anyway

[limber dome]

and yeah this is just much more convienient than having to manage a ton of other mods that don't work as well together

[upper schooner]

How much of GI still doesn't work for v56?

[light girder]

You can add it back, just disabled the features that cause performance issues

[light girder]

Just the fire exit fix, but there's 2 mods that can replace it

https://thunderstore.io/c/lethal-company/p/KarmaModding/NoFacingFireExit/ I know this one works

[upper schooner]

Ah ok so nothing too bad then

[limber dome]

do you know any good Scan improving type mods?
as in reliability of scanning and stuff

[light girder]

https://thunderstore.io/c/lethal-company/p/PC/FireExitFlip/ Haven't tested this one, I use the other cus it's open source

[light girder]

TestAccount's mods

I use these

[upper schooner]

If I can get my 1337 terminal stuff from GI working then I'm a happy camper

[limber dome]

I have these so far and sometimes the nodes just don't get scanned (maybe a geometry issue?)
Also Ship and Fire Exit nodes have some weird LoS checks
As in they can be scanned in some places but not others?

I dunno maybe it's a config issue

[harsh delta]

which features cause performance issues again?

[light girder]

These

Lol

Hide Empty Subtext of Scan nodes is no longer needed though @sour rain implemented that into ButteryFixes if you need it

[limber dome]

btw Lunx is it worth using openmonitors if I use the non-Better Monitor displays from GI?

[light girder]

I'd still use GI's monitors

They have more customizability

[limber dome]

aighty

[upper schooner]

More customization and pretty redundant to have both

[light girder]

OpenMonitors is good as a temporary replacement

[sour rain]

well, i haven't implemented this actually

[light girder]

Oh it was in the changelog I thought

[sour rain]

Hide Empty Subtext of Scan Nodes just won't draw the second line if there's no text there

vanilla draws the "subtext box" always, it's just empty if there's nothing to show

[limber dome]

~~honestly the only thing holding me to openmonitors were weather colors and weather registry has that so yeah ~~

[sour rain]

I did fix keys showing "Value: $3" though

[light girder]

WeatherRegistry overrides it

lol

[limber dome]

also about GoodItemScan
how severe are these issues?

[light girder]

They're really not any worse than Vanilla

Meaning if you're used to Vanilla it's about the same

[hardy fable]

Is this new scan feature default enabled?

[hardy fable]

I kinda need to know cuz we might do our squad night soon

[proven moth]

what new scan feature

[cold minnow]

nvm I read

[narrow oriole]

...why lol

Is that mod broken? Its scope is quite a bit larger than most of the changes in GeneralImprovements, and not only that, but it just adds to the number of patches that can cause breakage on game updates (i.e. what just happened)

I won't lie, I'm a bit frustrated that the flashlight fixes were merged into GI, considering that the bugs around the flashlight are some of the most common and frustrating ones, and GI stopped functioning because of a completely unrelated fix that was irrelevant to me

[sour rain]

lol, yeah, i was just thinking about that the other day

i think flashlightfix 1.1.2 is identical to what was merged into generalimprovements, so using it is not completely off the table - but i still think emptying out its functionality in v1.2 was a bit overkill, when deprecating it and providing a "use at your own risk" would've been a bit more flexible and user friendly

[proven moth]

BetterSprayPaint didn't actually break which is cool

[narrow oriole]

idk, personally I've never had a problem with maintaining multiple mods either

[sour rain]

it breaks weed killer

[proven moth]

Seems to work fine for me

[sour rain]

it doesn't break the game and spray paint still works ok though

[narrow oriole]

sure, it's easier to just build one project rather than jumping between them, but when people come in here talking about how "my mod pack is too big" and asking for something to be assimilated into GI, it rubs me the wrong way on several levels

[sour rain]

lol yeah im definitely a fan of flexibility over assimilation

so i feel you there

[narrow oriole]

I find that in these massive packs, the largest cause of long loading times is due to

• Poorly written code
• Huge assets
  There is obviously some overhead to having a bunch of fixes in separate mods, but that's a very small contributor compared to the above

[sour rain]

have you used weed killer in vanilla vs with betterspraypaint enabled? it changes functionality in some pretty major ways

[narrow oriole]

there are lots of mods that use reflection just out of convenience, and don't seem aware that reflecting over every class and method in your mod is not good practice and is incredibly slow

[light girder]

BetterSprayPaint also needs updated for proper compat with the Weed Killer

[sour rain]

it changes the weed killer particle effect to be a straight line and sprays continuously without releasing the button and re-pressing

[narrow oriole]

...and then there are the mods that do it to every class in the entire game, including mod assemblies

[light girder]

I can feel this

Some of GI's features unfortunately due to feature creep are pretty unoptimized, and DiFFoZ found that out when he profiled the mod

[sour rain]

not to start a witch hunt (mostly just personal curiosity) but do you have any specific examples of this in mind?

[narrow oriole]

looks like BetterSprayPaint is under the MIT license, so if it's not being updated, someone should fork it

[light girder]

@queen summit Your time has come

[broken crescent]

Lol don't worry fellas, I'm not going to duplicate the code of other mods that do more than a couple simple things (unless it's a very specific case)

[sour rain]

i pinged taffyko about the issues today and they responded pretty much immediately, so it should still be maintained

[light girder]

He said he won't be able to update it for a bit

[narrow oriole]

at the moment, not particularly specific ones, but I have seen some mods that use reflection to avoid binding their config options manually, or there's the classic netcode initialization reflection that a ton of mods use and could instead be achieved by calling a stub method that gets filled by the patcher

[light girder]

But yeah taffyko is pretty chill, at some point he should be made aware of the issue with NiceChat constantly allocating per frame

[sour rain]

i c

[narrow oriole]

anyway, sorry for the vent, I just feel like this breakage was completely avoidable

[light girder]

Yeah I'm pretty lucky I avoided most of those, pretty sure when DiFFoZ profiled my pack I would have had a much larger list of things to remove lol

[sour rain]

nono, i share the sentiment

[proven moth]

Only thing i'm getting from these 2 things is the spray being a straight line

Which is just visual

[sour rain]

that's weird, i was getting both when trying out earlier today. not sure what the deal is then

ah well

[proven moth]

I am using Imperium but idk if that'd do it

[light girder]

It might just due to order of loading

lol

[rough salmon]

yippe update!!!!

[proven moth]

in my normal pack it seems fine too so ¯_(ツ)_/¯

[pseudo field]

was the newest update just to fix v56 compat or did it fix the fps issues?

[light girder]

Just V56 compat, also keep note the fire exit flip feature does not work

You will need an alternative mod

https://thunderstore.io/c/lethal-company/p/KarmaModding/NoFacingFireExit/ I use this one

[pseudo field]

ah, well imma wait for an eventual fps patch, luckily most the stuff I use is covered by other mods

[light girder]

just disable the features that cause performance problems

[pseudo field]

problem is I USE those features

those are the ones that I used other mods to replace

[light girder]

Better Monitors will always be performance heavy

So don't use them

OnlyAllowingOneLight also isn't essential, HotbarPlus has a replacement for Lightning Warnings

TestAccount has mods that can replace the scanning stuff

[pseudo field]

better moniters as in the ones with text of the extra 5 ?

[light girder]

AutoChargeOnOrbit is nice but not essential

[light girder]

Yeah

Better Monitors uses Camera.Render()

So they will always cause overhead

[pseudo field]

both? well I cant live without that and open moniters is incompat with it

so I just ditched GI

[light girder]

I use the vanilla monitor stuff in GI

It's only BetterMonitors

[pseudo field]

ahhh

ok

never used the xtra 5

[broken crescent]

Yeah I've optimized the monitors about as much as I'm willing to, because I'm stubbornly using camera textures to apply it straight to the monitor meshes. It only renders when absolutely necessary, and I personally max out every monitor and have no issues so it's like.. meh

[light girder]

Tbf the monitors might be the least performance heavy compared to the features that allocate constantly per frame lol

[pseudo field]

didnt the masked stuff have issues?

[light girder]

Yeah some of them do

[broken crescent]

I think the scanning fixes may affect the most

(?)

[light girder]

Yeah the scanner stuff, also the Health text is very unoptimized as DiFFoZ discovered

[broken crescent]

Ah ok that's right

I'll try to remember to optimize those next

The cams can still be improved technically, but the amount of changes they need for the amount of performance improvements is probably diminishing returns

[light girder]

Lighting Warnings also allocate constantly apparently

[broken crescent]

I need to write these down

[light girder]

But they never supported more than the first 4 slots

[pseudo field]

which ones(ik the scanning)

[light girder]

Mainly the masked showing name plates feature

[pseudo field]

good I didnt need that

[light girder]

I'm sure @sly jolt could probably give you the list of stuff that needs optimization

lol

Cus he profiled the mod

[broken crescent]

Ok lol yeah feel free, I haven't been making notes like I usually do the last month or so

I tried to profile at one point and gave up after minimal effort 😅

[pseudo field]

nice to see it being worked on

[light girder]

😂

[pseudo field]

if im correct this lets you keep stuff after being fired?

btw does the skip intro still cause issues?

[oak cradle]

It just saves furniture positions

So the starting stuff like bed, terminal etc

Will stay in the same place you had them

And if you configure it to I guess other stuff will as well once you buy them

[low gyro]

https://cdn.discordapp.com/attachments/1190731323615232012/1260052844325769339/caption.gif

[short frost]

@broken crescent not sure if u looked into it but a couple days back bongo pinged about one of your patches that could use a bit more transpiling so i can setup my code in a way that doesn't break the player inventory with the being able to open doors from any slot with a key config

[light girder]

Yeah that setting I know caused issues in the past as well and Shaosil at the time recommended to just not use it, but since he'll be updating the mod soon and fixing the issues DiFFoZ found he may finally fix that too

I imagine he wants to get all of that stuff fixed tbh

[short frost]

Well there's more and I'm interested in hearing his answer lol

[light girder]

Yeah me too ^^ I wanna see what he has to say

[sly jolt]

👍 Will do some profiling later today

[sly jolt]

GeneralImprovements.dll!GeneralImprovements.Patches::PlayerControllerBPatch.Update()
DMDASM.87ED318A.Cecil.dll!::DMD<Update>?-580826304._GameNetcodeStuff_PlayerControllerB::Update()

GeneralImprovements.dll!GeneralImprovements.Patches::HUDManagerPatch.UpdateScanNodes()
DMDASM.9877C41F.Cecil.dll!::DMD<UpdateScanNodes>?-580826304._HUDManager::UpdateScanNodes()
DMDASM.FE41516F.Cecil.dll!::DMD<Update>?-580826304._HUDManager::Update()

GeneralImprovements.dll!GeneralImprovements.Patches::HUDManagerPatch.AssignNewNodes()

GeneralImprovements.dll!GeneralImprovements.Patches::HUDManagerPatch.MeetsScanNodeRequirements()

[limber dome]

yippie an actual bug report!

If ShipPlaceablesCollide is set to false, trying to put items in the item locker will read the raytraced height of the wall/floor behind the locker. leading to items' height being all over the place.

[low gyro]

https://tenor.com/view/mini-oso-luna-tabby-lunaistabby-gif-220644464987255023

[unkempt hamlet]

Bug report:
UseBetterMonitors setting with SyncExtraMonitorsPower setting can get extra monitors stuck in off-state

Steps to reproduce:
enable UseBetterMonitors and SyncExtraMonitorsPower
land on moon with stormy weather condition
use red button to turn off all monitors or have lightning strike the ship to turn off all monitors
have lightning strike the ship while monitors are already off
attempt to turn monitors back on
see only bottom monitors turn back on from now on, with extra monitors stuck in the off-state.

Expected behavior:
All monitors turn back on

Game Version: 55
General Improvements Version: 1.3.0

[light girder]

That is known and has been known

This is nothing new.

[unkempt hamlet]

Oh. ok.

so is there no fix planned or can't it be fixed?

[sour rain]

it will be probably fixed but development has been on hiatus for some time

[unkempt hamlet]

I see, thanks. since the last update was very recent I assumed development was still going alright.

[narrow oriole]

very nice steps to reproduce though, I must say

🫡

[broken crescent]

have lightning strike the ship while monitors are already off

that has to be the missing piece preventing me from reproducing it!! Thanks, I'll make sure this is fixed in the next update (within a few days I think)

[broken crescent]

So those are the main problem areas? Nice, I'll keep that in mind when I do some performance tweaks, thanks

[sly jolt]

👍

Also, I made tutorial on how to enable profiler: https://canary.discord.com/channels/1168655651455639582/1259442214921175082

[short frost]

[fast lintel]

hey Xu

[short frost]

ello

[fast lintel]

remember the hook gun

hook gun!

[short frost]

once im done with my commissions

[fast lintel]

🙏

[jagged flower]

🙏

Sorry for off topic but I vouch for hook gun, one of the first mods I added, but had to stop using due to incompability with modded moons and LC api being discontinued :'3

[low gyro]

𝓯𝓻𝓮𝓪𝓴𝔂

[rough salmon]

😭

No

no freaky

[low gyro]

https://cdn.discordapp.com/attachments/1190731323615232012/1260052844325769339/caption.gif

[low gyro]

https://tenor.com/view/roblox-gif-25300545

[slow flicker]

I’m getting a bug where occasionally we get a masked that doesn’t have a body model, only floating cosmetics. Only two mods we have that mess with masked are Mirage and GI. I left all GI settings for masked at their default values.

[toxic yew]

Is there a way to completely remove the enemies and extramonitors section?

[onyx vine]

yeah I'm also getting some really weird masked issues and I think it's GI

all masked settings in GI are disabled

[light girder]

This is a Vanilla bug unfortunately, sometimes masked become invisible

@broken crescent At some point you should really add a config option to disable allowing picking up items before you're normally able to cus unfortunately it sometimes causes desyncs

[tight field]

what are the settings to enable compat with Mirage?

[neat stone]

Hey guys I’ve been out of the loop a bit. What’s the status with this mod? Have the performance issues been solved? Can it function alongside buttery fixes?

[cloud gate]

i have both just fine
it only matter when u have hundreds of mods and every single fps gain matter

[thin pecan]

This mod is broken in many ways

It will be updated eventually though

[pseudo field]

like rn it "works" if you turn the broken stuff off

hope it gets polished off someday

[thin pecan]

I'd rather just use alternatives for now

Lethal fixes is a good one

Same with buttery fixes

[pseudo field]

those dont really cover what I use from GI

I just disable the broken stuff

and use alts for the rest

[frigid bramble]

everyone is always saying this mod is "broken" or "unoptimized" and tbh i dont get it. i dont notice any difference with or without the mod, i have to imagine its just nocebo at that point. its been working perfectly for me with unnoticeable performance difference so idk what to make of that other than just rumors being spread

[pseudo field]

It is 100% not rumors, how big is your pack for context

[frigid bramble]

96 mods

[pseudo field]

the problems seem to stack up on bigger packs

improvments of 30+ fps from removing GI

and or disabling laggy features

on a pack of your size it should be all fine tho

[broken crescent]

I think the personal scanner fixes have the biggest performance impact at the moment, which I hope to solve in the next update

[short frost]

@broken crescent Any chance to work a bit more on the patch that involves the opening door with key randomly in inventory config?

[broken crescent]

Sure I might need a bit more details on how I should be changing it though

[short frost]

I'll tell you what I'm doing basically and that might help.
In my mod I've made my own interactable object that requires a key that deletes the key from your hand and opens the chest, not using vanilla door cuz that's pretty bloated and annoying.
But yeah with your patch it allows the person to use the key anywhere in the inventory but still deletes the item the player was holding and simultaneously breaks the inventory

I'll see if I can get more details on how it should be changed when bongo wakes up

[broken crescent]

Hmm ok at first glance that sounds like a simple incompatibility with my UnlockDoorsFromInventory setting - wouldn't disabling that solve it?

[short frost]

Yes disabling that config fixes it, but at the same time I'm wondering if there's a way to build compatibility

[broken crescent]

Gotcha

[short frost]

A lot of people seem to like that config so i don't just wanna keep bricking their inventory if that makes sense lol

[broken crescent]

Yeah that's fair, I'm happy to take a look

[short frost]

Thanks!

[broken crescent]

(pending a couple extra details from Bongo lol)

[short frost]

Yea lol

[broken crescent]

Here's a new one. Any devs know why this would be happening?

I'm updating my HudManager UpdateScanNodes patch to be a transpiler instead of a postfix to help with performance. But simply doing this:

[HarmonyPatch(typeof(HUDManager), "UpdateScanNodes")]
[HarmonyTranspiler]
private static IEnumerable<CodeInstruction> UpdateScanNodesTranspiler(IEnumerable<CodeInstruction> instructions)
{
    return instructions;
}

Completely breaks it and no scan elements show up on the HUD at all. Removing the transpiler method fixes it again.

I've had no problems returning instructions or a modified instructions.ToList() in the past with any other transpiled method

[sly jolt]

known issue, use this mod as a dependency https://thunderstore.io/c/lethal-company/p/DiFFoZ/HarmonyXTranspilerFix/

[broken crescent]

Thanks, looking into it 👍🏼

[vapid acorn]

won't be at computer for a bit so this might be slightly wrong

basically the PatchKeyActivate looks for
ldarg.0
ldfld playerheldby
call despawnheldobject

in theory for compatibility, I could run a Transpiler before yours that places another set of those instructions
you'd have to modify i the patch to look for it multiple times

also any reason for not using codematcher? this would be fairly simple to do with it

[light girder]

Glad to see you working on doing a big performance improvement update, when you update the mod can you also make the feature for picking up items before you're supposed to be able to toggleable? I know it always seems to desync Jetpacks for example

[broken crescent]

@short frost and @vapid acorn could you remind me of the name of the mod that I need to support? I'm finally getting to the PatchKeyActivate changes after a slog through some technical issues and want to make sure I do it right

[broken crescent]

This is in locally and will be in the next push

Hopefully I can get something live within the next few days - I might ask ya'll to test it via downloading the release from github since I'm not the best at seeing performance improvements lol

[short frost]

Coderebirth's item crates, they're outside map objects that spawn randomly outside in moons, u can config em high to force spawn but you need to dig em out with a shovel first then use a key

[broken crescent]

cool thanks

[short frost]

:3 ty

[broken crescent]

Hm. Your KetItemPatch uses a Postfix, so looking for DespawnHeldObject multiple times in vanilla KeyItem.ItemActivate won't solve anything, since the postfix just calls a separate function if I recall.

I could always transpile your method myself if found?

[vapid acorn]

I'm wanting to replace it with a transpiler

I'm fairly certain that lets you also patch ig

it

[broken crescent]

Probably, assuming yours ran first (I assume)

[vapid acorn]

HarmonyBefore

[broken crescent]

Well for now I'm coding a soft dependency on CodeRebirth and support to transpile your postfix. It will check safely and only do work if needed, but obviously it will cease to work if you change it to a transpiler - if that happens after this coming update, just let me know and I can adjust things

Edit: Seems to be working - will be in the next update I push

[fast lintel]

Also infinite spray or better spray paint?

since no spray paint mod for 56

[short frost]

Thank you

[slow flicker]

I’ve been using Better Spraypaint in v56 and it seems to work more or less fine. I noticed there’s an animation that broke but it’s infinite and you can still change the size and color

[limber dome]

the main issue with BSP is that it also affects weed killer

I personally still use it because... i kinda like that bug

you can set the size, amount of spray paint

and rechargable spray paint mods work on weed killer aswell which is pretty cool

[slow flicker]

Oh how does it?

[broken crescent]

Does anyone care if I remove the ScanHeldPlayerItems option? I'm not sure how popular that is.

I'm optimizing some FixPersonalScanner code and a change I made will make it a little more difficult to support that

[onyx vine]

I can't say I've ever used that one

it takes like 0.2 seconds to figure out what somebody's holding most of the time

[limber dome]

Tbh I feel like it was pretty redundant since if you wanted to show off an item to a friend you'd just... drop it most of the time. You can remove it imo

[broken crescent]

Ok cool

[cloud gate]

not so useful imo

[pseudo field]

Same for scanning players imo

[cloud gate]

this also doesnt respect the scanplayer setting when true anyway

the scanplayer in question

[fast lintel]

Yeah why not its not really a big thing anyways

[frigid bramble]

i like that option 🙁

[broken crescent]

Haha yeah sorry it went poof

https://github.com/Shaosil/LethalCompanyMods-GeneralImprovements/releases/tag/v1.3.1

The long awaited scanner performance improvements are here though! At least, in theory. AND THE FRIGGIN LIGHTNING MONITOR OFF BUG

I'm not going to push it to Thunderstore until it's been tested by a few of you guys though

just in case

Also, sorry for the annoying grab icon showing when the player was just out of reach of grabbables.. that's actually from my mod. Fixed in v1.3.1

[desert folio]

Does that last point mean that GI does the same thing that HarmonyXTranspilerFix does?

[broken crescent]

From what I can tell, yes

[frigid bramble]

THANK YOU

i thought i was just losing it

[broken crescent]

I spent a few hours trying to understand that so I didn't just rip DiFFoZ's code, but in essence he seems to just be removing a couple of if statements from something in HarmonyX via a replacement prefix. I used a transpiler to do basically the same thing

And I really didn't want to add a mod dependency

[broken crescent]

It was driving me and my friend nuts

Then I disabled GI and I'm like... oh.. it's my fault

[desert folio]

I think I would prefer that GI uses HarmonyXTranspilerFix as a dependency rather than GI reimplementing the same thing, or at least have a config for this functionality, because otherwise this means I need to keep in mind that HarmonyXTranspilerFix has a conflict with GI and remember to always keep one or the other disabled

[broken crescent]

It shouldn't conflict

[desert folio]

are you not doing the same thing?

doing the same thing twice sounds like it may have unintended consequences

[broken crescent]

He's using a prefix, I'm transpiling. If one or the other runs, it should work, or if both run, it should still work in theory. Let me test it real quick though

His is a full replacement, mine is a modification

[desert folio]

I see, so his prevents the base method from being called?

[broken crescent]

Right

[desert folio]

okay good to know

[broken crescent]

Yeah having his patcher loaded at the same time doesn't seem to cause any issues

Guess I could have tested that before releasing it lol

[frigid bramble]

testing is overrated

[broken crescent]

lol right? That's what production is for

Also I guess I'll tag @short frost and @vapid acorn, v1.3.1 on Github should have fixes for the key bug, feel free to test it if you want. No big deal though I tested one scenario and it seemed to work well enough

[short frost]

Lovely and tyvm

[broken crescent]

https://tenor.com/view/han-solo-salute-gif-23189016

[low gyro]

i dont get it

[slow flicker]

You can’t remove features because no matter if you think nobody wants the feature, there’s always at least one person that does

[low gyro]

https://tenor.com/view/flop-flop-tok-floptok-flop-era-staring-gif-12897406995212591919

[slow flicker]

Well, can’t remove features without someone being dissatisfied

[low gyro]

yeah i totally understand

(i cant count to 3)

[slow flicker]

It’s ok start with 2 for now

[low gyro]

one...

t-tw...

twooo

ok

[rough salmon]

https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExeWJzeG00NmR4Y2gxaTU2M2lmMGQxbmN2MnByeW9sZnpiMjE0ajNyMiZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/AjkkqmTKMfcJ9hck1y/giphy.gif

[slow flicker]

You’re two thirds of the way there

[frigid bramble]

i mean, i'm not saying you can't remove it

i just like the feature

also its already done lol

[slate lynx]

Ty you beautiful human being

[broken crescent]

Yolo, pushing to Thunderstore

[light girder]

Btw glad you fixed the grab prompt issue, that was a weird bug created when masked had nameplates

Idk why

LOL

[broken crescent]

Most annoying bug from my mod to date IMO xD

[light girder]

XD

How was it tied to that setting though?

[broken crescent]

I was modifying the ray origin so it didn't intersect with the player but that affected several other raycasts in that function

[light girder]

Fun

lol

[tropic saddle]

speaking of performance, do u know if the dissonance log fix mod is needed if your playing solo/playing without mirage?

[light girder]

If you have LethalFixes DissonanceLagFix is pointless

and I would recommend LethalFixes anyways

[tropic saddle]

i thought about getting that mod but im not too worried about most of the bugs it fixes

[tropic saddle]

does skinwalkers fix the dissonance thing? and so this fix does make a difference right?

[broken crescent]

I hope it does lol. I didn't test frames or anything but I made a bunch of changes related to FixPersonalScanner that should hopefully optimize it. I also tried to optimize PlayerControllerB.Update with the health display but I couldn't find an obvious problem area with that by sight alone so we'll see

[sly jolt]

[high rapids]

Will a config option ever be added to disable moving the clipboard to the wall?

[warm pivot]

is fix fire exit still broken? 👀

[broken crescent]

Probably in the next update

[broken crescent]

It should be fixed in v1.3.1? I was playing last night and it seemed fine

[warm pivot]

Yeah it was a mod conflict

[broken crescent]

ah cool

[warm pivot]

[patent orbit]

Hey I saw this mod has been updated, does that mean the performance issues with the better monitors are fixed?

[broken crescent]

Most of the performance fixes were related to FixPersonalScanner since that was a big one

Tbh I don't know how much more time I'm going to invest in optimizing BetterMonitors, I feel like it's diminishing returns at this point. It's already pretty good all things considered - despite it using a custom Render() call, it only does so when there is a change, and only when you're in the ship. There's other things I could do to get it performing even better, but again it might be a lot of effort for minimal improvements.

Also I (and some others) barely notice an FPS hit when all 14 BetterMonitors are active - I was getting 130-140 FPS in orbit yesterday with all monitors going strong.

My (controversial) opinion at this point is you're probably better off just setting UseBetterMonitors=false if you're trying for the most optimized scenario

[patent orbit]

Thanks a lot!

[late owl]

this will be the update of all times

[cloud gate]

https://tenor.com/view/encore-wuthering-waves-gif-6921813096428547797

[slow flicker]

Just use Mirage

[late owl]

skinwalkers stink doodoo

[sacred kelp]

OpenMonitors has a cool feature where you can see the health status of all the crewmates, could be a cool addition to GeneralImprovements

[wise citrus]

Does other people get performance issues after installing this mod ?

[cloud gate]

not really

[pseudo field]

lux was the one who had pointed out a lot of the things that caused lag

[rain geyser]

Oh hell yeah

[rain geyser]

Is this toggleable or tied to another feature that’s toggleable?

Any and every QoL, performance or bugfix feature really should be toggleable either individually or as a grouped feature as long as we know what all the grouped feature does

Because there is so much overlap with other mods

[harsh delta]

is good item scan still better on performance lol
than GI

for scanning

[light girder]

Dunno still waiting for @sly jolt to test the scan fix in GI

[real grove]

This gets spammed in the console

[light girder]

@broken crescent Any idea what this is?

I don't recognize this error

[toxic summit]

Does your scanner stop working correctly when this shows up

Cus I think I got this too

[real grove]

No idea what it does, it did work but I have a mod by TestAccount666 that changes the scanner

So that may be an incompatibility?

[broken crescent]

Looking at my code I know why this is happening but not why it's happening lol. In other words I'll fix it in the next patch

[real grove]

but it works normally

[broken crescent]

I think it may be finding some things that my code expects to contain scan properties but don't

[toxic summit]

I don't think I had any other scanner mods, but that error only showed up when I went inside a modded interior, and wouldn't show any scan nodes even when I was staring at an object. It fixed itself when I went outside

[broken crescent]

If it'd consistently reproducible could I have the profile code to verify it in testing?

[real grove]

That wasn't on modded interior

[rain geyser]

are you back to using GI?

[toxic summit]

Yea but I guess it's not a consistent issue

[rain geyser]

probably. I had this error spammed to my console when I had too much overlap between BetterItemScans and GeneralImprovements

i fixed it by turning off some stuff in GI

[real grove]

It hasn't repeated yet, but here's the profile code
0190dc85-d833-1c74-b6d0-b6104ff30ae1

[outer crystal]

Hello. I wanted to ask Shaosil if I could request a compatibility option for this older mod.

https://thunderstore.io/c/lethal-company/p/stormytuna/BetterSecurityCameras/

My group plays with the HD visual mods an that camera mod is flawless. Sadly tho it wont work when used with his general improvements mod. So I wanted to see if it was possible to get a compatibility option or have that mods cameras added in as an alt option for HD visual users.

I will drop this as a message as well in case he doesnt read the full chat log. Hope you can accomidate us HD visual mod users as so far we love the other features! Please keep up the great work

[outer crystal]

Tag to get info to mod maker author. thanks again

[frigid bramble]

try tweaking these settings in the config

[rain geyser]

yea you can just change the resolution with GI

the size multiplier

[outer crystal]

AH!!! thank you!!

OOOOoooooooooooo... glorious HD ship cameras. Daddy missed you. Now I can watch em get stuckoutside an get killed by monsters due to comedic timing in HD again. 😄

I retract my request. 😄

[prime glade]

can confirm this is happening to me too, occurred after the last update to generalimprovements, same console spam as subject1v3's screencap, it seems to be triggered by something in-game somehow. Landing in a moon doesn't have it break immediately, but after being inside for long enough or with enough people going in and out or something-or-other, it breaks in this way.

[tropic saddle]

do u think you could add hiding the chat as a feature?

[tropic saddle]

itd be nice to not have to add another mod (HideChat) to my pack in order to have that feature

[rain geyser]

whats wrong with one more mod

[tropic saddle]

its annoying for me, and my friends who contantly gotta import code to update the modpack

[rain geyser]

wouldnt this take like 8 seconds

[frigid bramble]

hidechat is a 7kb mod

if it takes that long to import then it sounds like your friends have some other issues

[rain geyser]

they would still need to update the modpack to sync config changes to avoid quirks

[frigid bramble]

(also, r2modman and gale cache mods so that they dont have to be redownloaded every time you import the same code)

[rain geyser]

yep

i estimate 8 seconds from the moment they copy the code if r2modman is loaded

[tropic saddle]

i just think itd be convienent

[rain geyser]

i can see how it fits in this mod

i mostly was poking the bear because it seems to be a misconception that less mods = faster modpack

10 mods that do the same thing with the same amount of code = same performance as 1 mod that does the same 10 things

[tropic saddle]

i just personally dont like having a super high count modpack

even if it doesnt negatively affect performance

[rain geyser]

fair

cups of tea

[broken crescent]

I do have this on my backlog, now getting to it is another story lol

[tropic saddle]

ok cool

its not a big deal at all, i was just curious

[rain geyser]

is that you in your pfp?

[broken crescent]

:LUL: dang, doxxed

oops, used to my own discord

https://tenor.com/view/lol-laugh-lul-twitch-emotes-gif-23033012

close enough

It's technically an alpha model of the guard from HL1

And for more boring details, I thought it looked funny and ended up using it in my last dev project (currently mostly abandoned) as a temporary placeholder for a guard

[rain geyser]

you have experience using HL1 models in Unity?

[broken crescent]

Actually I found it on Sketchfab and I was using it when learning Unreal 5

https://skfb.ly/o7pEA

[rain geyser]

ohhhh okay i see

[broken crescent]

@tropic saddle actually I finally peeked at HideChat code - I'm not going to copy it since that's not my style, but I do see that it's super easy to change (thanks to Zeekers for having flexible methods)

So yeah, that will be in the next update

[rain geyser]

are there any bug fix or performance improvement aspects of this mod that aren't found in modular alternatives?

@all

[frigid bramble]

would appreciate an option to fade out the chat when it isnt being used

rather than just hiding it

[broken crescent]

That's the goal

[rain geyser]

an uwu chat option would be sweet

to UwU-ify messages automatically

[kind turret]

General UwUments

[rain geyser]

you get it

[broken crescent]

notices improvement OwO what's dis?

[broken crescent]

Next update will have:

• Configurable toggle for changing the ship clipboard starting position

• Configurable chat fade duration

• Configurable chat fade opacity

• Fixing error spam with FixPersonalScanner in some cases

Was there anything else important that I'm forgetting?

[frigid bramble]

unsure if its a mod thing but i think the hide player names setting might be broken?

[broken crescent]

Oh? I think it was working for me last night but I can try to confirm. Keep in mind it doesn't hide player names in orbit

[frigid bramble]

that's probably it then, thats the only time i remember seeing it

[broken crescent]

Cool I'll double check just in case 👍🏼

[light girder]

The dropship changes seem to have a compat issue with some mods that touch the dropship like @queen summit's FastDropship mod

[broken crescent]

ShowDropshipOnScanner?

[rain geyser]

I mean this would make sense to me

Nvm im dumb

[rain geyser]

No where the item dropship lands faster

[broken crescent]

Do I do that?

[rain geyser]

Uh

No

Totally got this mixed up with Lategame Upgrades for a sec

Lolol

[broken crescent]

The only thing I can think of in my mod that might affect anything is how I allow more than 12 (or whatever) items to be purchased at a time

[rain geyser]

Do you use LGU?

[light girder]

It's the feature he has where if you add more items to the dropship it should delay it landing

For some reason your dropship changes prevent that

He said it was a compat issue with GI but he doesn't know why

lol

[rain geyser]

Do you want the delay in fear that it will fly away before you get your stuff?

[broken crescent]

Well my code doesn't touch anything delay related. It could very well be an incompatibility because of the amount of items, but it's hard to say who needs to fix it without more info

[rain geyser]

Cuz IME if I order stuff after the dropship already arrived it still has my stuff I ordered when I open it up

[rain geyser]

How many hrs have u played since adding GI back?

I know we use a lot of the same popular mods

I am contemplating adding it back since the latest update

[light girder]

Yeah until TestAccount replies to you idk

[broken crescent]

Alright v1.3.2 going live shortly

[tropic saddle]

do u know if mods that remove the helmet visor from the screen improve performance?

[rain geyser]

I doubt it

https://thunderstore.io/c/lethal-company/p/woodroach/PerformancePack/

[tropic saddle]

i thought bflap was incompatible with loadstone

[frigid bramble]

iirc the visor uses some pretty heavy effects for not much visual gain, so it could be worth looking into

[tropic saddle]

and the readme of loadstone says it can cause issues, right?

[rain geyser]

I don’t think so

I use both

[rain geyser]

Hmm okay okay

[tropic saddle]

btw dont no console spam and logneuter do the same thing?

[rain geyser]

Nah logneuter completely disables certain console / log writes

No console spam adds a cooldown if it tries to update every frame

LogNeuter is set up very minimally in that modpack just using a few things @dense quartz listed

Tulip snake console junk etc

[frigid bramble]

i don't really think no console spam is necessary if you're already using asyncloggers

[rain geyser]

I don’t think it’s entirely redundant like for the error spam that sometimes happens from the rolling giant for example

“target player switch” blah blah blah every millisecond if it bugs out

[tropic saddle]

what about logneuter is it necessary

[rain geyser]

No mods are necessary unless they’re a dependency for another mod

[frigid bramble]

not really, but it does make it easier to read logs for errors if you set it up to remove all the garbage

[tropic saddle]

i mean necessary for better performance

[rain geyser]

There’s also a playerrpc error that was spamming my console occasionally til I added logneuter

[rain geyser]

It can help if only minimally outside of niche situations

Is there any harm or possibility of incompatibility as far as I know? No

1A3 is one of the more knowledgeable coders I’ve seen around here and he uses it so I thought it a good idea to adopt it

[rough salmon]

did i hear tulip snake

:TulipSmile:

[rain geyser]

Uh oh

[broken crescent]

Quick someone get a shovel

[rough salmon]

NO

https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExeWJzeG00NmR4Y2gxaTU2M2lmMGQxbmN2MnByeW9sZnpiMjE0ajNyMiZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/AjkkqmTKMfcJ9hck1y/giphy.gif

[low gyro]

https://tenor.com/view/lethal-company-jump-barbarian-meme-sped-up-gif-14074021366932976810

[rough salmon]

NO...

[low gyro]

hoo hoo hoorah

[rough salmon]

Truly Evil look at there faces nothing but bad'

[light girder]

@broken crescent glad to see the option for hiding the chat window integrated, HideChat is rather outdated and that's one less mod from my pack

[broken crescent]

To be fair that patch is like one line of code that is handled rather elegantly and it works really well. It calls a fade function via a postfix to 3 methods, which overwrites previous calls to the same function.

I went with the transpile method so I could modify some IL parameters, meaning HideChat will still overwrite mine if it exists

But yeah for simple things like that, I don't mind absorbing them

[light girder]

Yeah

[light girder]

Btw have you considered looking into not using Reflection for the ScannerFix, cus that would improve performance with it even more

Dunno if @sly jolt might have some alternate suggestions

[broken crescent]

I'm pretty sure I'm not using reflection for that, at least not after the first MethodInfo find

[light girder]

Ahhh okay ^^ I remember TestAccount mentioned it used to rely on reflection pretty heavily

But maybe you changed that when optimizing it

[broken crescent]

Well it still uses a MethodInfo every time, but that's a lazy loaded, one time find. After that it's stored in memory and .Invoke() is called on it each time AssignNewNodes is called (about once a second). As far as I know, it's not the invoke that has high overhead, but the actual lookup of the method which should only be happening once

[light girder]

Nice ^^

[broken crescent]

Well also that being said I'm not an expert on under the hood performance, so if Invoke() DOES have a lot of overhead, I can find a better way of doing it that avoids reflection altogether

[light girder]

Yeah @queen summit Might be able to provide suggestions if it does, if he's down to let you look at the code for his GoodItemScan mod or just give tips lol

Idk if it does or not personally

[sly jolt]

You should just remove reflection in player loop frame at all

[broken crescent]

To be honest the FixPersonalScanner was just my small take on how I think the scanner should behave, actually I wouldn't consider it a performance boost or anything. On the contrary I'd say it's slightly less efficient than vanilla, but gives more consistent results by sorting things by distance to player, etc

[broken crescent]

You mean in PlayerControllerB.Update? I don't think I'm using any reflection there. I usually try to avoid reflection whenever possible, especially in the game loops.

[sly jolt]

still don't use any reflection

More mods are using publicizer to open every methods and fields to remove usage of reflection

[sour rain]

in general avoiding invoke() as much as possible is best practice yeah

[queen summit]

Even the invoke is very performance heavy.

So, hop on the hype train and use publicizer instead ;3

[queen summit]

When rapidly buying items and the total is more than 12, the dropship likes to land 2 times instead of just 1 time to deliver all items...

This doesn't seem to happen with other mods that increase the limit.

I haven't looked at your code yet though

[broken crescent]

Hmm I'll do some testing. I wonder if that broke after v55

Seems to work for me, I bought 24 items and they were all delivered at the same time

https://thunderstore.io/c/lethal-company/p/FlipMods/FasterItemDropship

Is this the mod that has the issue with > 12 items?

[queen summit]

No

[broken crescent]

Ah this one https://thunderstore.io/c/lethal-company/p/TestAccount666/FastDropShip/

[queen summit]

Yes

[broken crescent]

I'll download that and test it alongside GI

[rain geyser]

I would’ve judged you for that Sonic icon

[queen summit]

I'm using AI generated icons for a reason...

Me drawing something = World War weapon

[rain geyser]

Oh god

[broken crescent]

lol same

[rain geyser]

🤫🤫🤫🤫

[broken crescent]

Also using both mods together still has no issues - I ordered 24 items, landed on Experimentation, and your fast ship arrived with all of them

[rain geyser]

Shoulda seen the all out debate that unleashed when DiffoZ mentioned using an AI generated icon

[broken crescent]

AI haters gonna hate

[queen summit]

Did you try multiple individual items or did you use something like "pro 24"?

[broken crescent]

walkie 24 😛

I'll try other orders

[queen summit]

Ugh... It's just an icon I use instead of using the "Insert icon here" text as the icon....

[rain geyser]

I am apparently an avid supporter of global warming for AI generating images a couple times a year

[broken crescent]

I run my own image models and LLMS so I guess my PC is literally hitler 🤣

[queen summit]

Ooof 😅

Because AI generating images is the problem

[misty swallow]

in this economy? how dare you 😆

[rain geyser]

😅😅

[broken crescent]

@queen summit yeah even ordering 4 different types of items and maxing it out to 24, it still dropped everything in one go

[queen summit]

Hmmm weird 🤔

[broken crescent]

Is it possible people are ordering it after landing and just type too slow?

[queen summit]

@light girder, if that could be the case, it would be an easy config fix

[queen summit]

It was definitely not landing yet when I tested it.

Does the ship count as landed before the countdown is fully done?

[broken crescent]

I assume items are locked in as soon as it spawns in the sky

But I could be wrong

I've heard people say they order stuff when it's landed and it's there when they open the doors also

so /shrug

[queen summit]

¯_(ツ)_/¯

We'll figure it out at some point

[broken crescent]

Yeah classic case of "works on my machine" lol

[proven moth]

Ew

[rain geyser]

I’ve also always had it work, even if I order something after it already lands and starts playing the music, it still drops the items upon opening

But I use the faster dropship feature from LGU not the TestAccount mod

[sour rain]

in vanilla this is correct

[broken crescent]

New monitor type coming soon™

[sour rain]

the moment the ship starts the landing animation ordered items are added to its inventory

if you order stuff mid landing animation it comes on the next ship

[rain geyser]

Probably a feature of LGU so the faster drops hit isn’t as inconvenient

[neat stone]

Has anyone had issues with the fire exit fix working

[broken crescent]

It might not work on modded moons if the devs coded them correctly in the first place lol, but that was always an issue

Someday I may look into positional rotation instead of just flipping them, if possible

[neat stone]

I figured it out, had buttery fixes and yours enabled in config so I think they did it twice and ended with it being inverted again lol

[broken crescent]

😂 fair

[sour rain]

yeah you should use or the other

i just add 180 to the rotation and i assume GI does the same

so they would both spin it 360

[broken crescent]

Wee

[idle valve]

Oh now I see. That was happening to me too lmao.

[broken crescent]

New update woo

[light girder]

Let's gooooo

[idle valve]

r2modman doesn't detected it. 😭

[broken crescent]

Give it a few minutes lol I always announce it right when I deploy

Check again in 10-15

[tawny gyro]

https://i.gyazo.com/8bc9ad888f43b251e56aa0a4d874267a.png
https://i.gyazo.com/d764adb17b339fab9d182b375a3eb963.png so... this is broke 😛

this is the case in both orbit and on moon

[broken crescent]

Hmm did it work on 1.3.2?

[rain geyser]

Yo I did not realize you could change the settings in game that’s sick

[broken crescent]

Shoutout to LethalConfig mod

[rain geyser]

I think im gonna be a good boy and add GI back to the back

[broken crescent]

Most still require a restart though

[rain geyser]

The other monitor mods fall short

[tawny gyro]

worked in 132, yea

[rain geyser]

Are you aware if there’s any fixes exclusive to GI?

Bug fix type shit

[broken crescent]

Ok I might have broke something when I was doing monitor code cleanup. I'll fix it when I can

[tawny gyro]

i appreciate it ^^

[broken crescent]

Uh probably lol but I haven't kept track of other people's fixes

[rain geyser]

hmmk

[broken crescent]

My readme covers most of the features and fixes

[rain geyser]

Yea I will just be careful when setting up the config

I remember it took some work before with the masked and scanner / item grab stuff

[broken crescent]

Good luck 🤞🏼

I think most of the settings won't change much if you leave them at default

[rain geyser]

@light girder I have question if you have time to answer

And shark

[outer crystal]

I just had to backdown t ov1.3.2 as v.1.3.3 shows an error for me when installed. If you have the Exterior monitor set to the 14th camera/bottom right large monitor. It changes the video camera feed to just saying Camera/Monitor 14

[rain geyser]

Are there any fixes u use GI for in favor over other fix mods

Sharkington

[broken crescent]

Sounds like the same error as BBA

[rain geyser]

Big booty Australians

[tawny gyro]

that's me

[rain geyser]

Too late Pepsi

Far too late

[outer crystal]

so we the sexy ones... erm I mean lucky ones to get a new bug. 😄

[rain geyser]

That’s what I always say

[broken crescent]

Yeah I pushed this one out a bit quick

[outer crystal]

for verification. pic of v 132

...all fine in v132

[broken crescent]

No error log I guess?

[outer crystal]

sec I can get one. I am about to reupdate to v133 for pic. I can snatch image of errors that show too for ay

[tawny gyro]

mine

[light girder]

Wondering if this is a side effect cus you're working on a new monitor

lol

[broken crescent]

I think it's a side effect of some code cleanup but I'll try to verify

[broken crescent]

Thanks, quick glance doesn't show an error when it goes to create the external monitor so it's probably something simple. Putting kiddos to bed then I'll investigate

[outer crystal]

v133 no other changes

[tawny gyro]

tyt

[outer crystal]

also had a single line of red error text from GI as well.

But I think that may be a conflict of some kind

[broken crescent]

Looks like Mattys fixes probably caused that one by transpiling first

[outer crystal]

but wanted to share. just in case

[broken crescent]

Yeah thanks

[light girder]

Yeah Matty has a compat option for that

[rain geyser]

Do you use ButteryFixes, LethalFixes, Matty_Fixes, AND GeneralImprovements?

[light girder]

Yep

[rain geyser]

And testaccountfixes

[light girder]

Yes.

[rain geyser]

Do you use any of the “fix” parts of GI in lieu of the same fixes from those mods?

[light girder]

Not really

[rain geyser]

Kk

thank

[light girder]

If another mod covers something GI does I disable the feature in GI

[rain geyser]

That’s what I was wondering, sometimes I wonder who coded something better tho

Shaosil has kids which means he’s Unc which means he is wise

[broken crescent]

https://tenor.com/view/kill-bill-pai-mei-wise-man-nod-nodding-gif-5291762

[rough salmon]

https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExaWJjZTYzczM4a29vN2N0YXNveDVmc20wMWMzcjU1anV2cG9wOWpreiZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/kXlltVOqV4z2es6qkk/giphy-downsized-large.gif

[broken crescent]

Found it. I reordered some enum declarations alphabetically and missed a spot where I did a "<" when comparing one. One sec lemme get this deployed

[tawny gyro]

tyt. thanks for your efforts, my dude

[broken crescent]

✌️

[light girder]

Btw nice job, the Scanner Fix seems to be super optimized now that you got rid of reflection

[broken crescent]

Was it not also optimized in 1.3.2? I'm a bit surprised. But good to know

[light girder]

I never got around to trying it in that build, was waiting for you to remove reflection haha

[broken crescent]

Ah well cool either way 😄

Fix uploaded, should be live soon

[light girder]

Ye ^^ I'm curious to see what @sly jolt will find when he gets around to profiling it, cus it seems to feel smoother than @queen summit's GoodItemScan mod now

[sacred kelp]

Ooh, you should do the employee health report from OpenMonitors

[broken crescent]

Yeah that's kind of on my todo list I've been lazy about that one since I will need to mess with font size and stuff

[rain geyser]

👀

[thin pecan]

This mod works 100% in v56 now?

Will it still work nicely with buttery fixes and lethal fixes?

[rain geyser]

Yur just turn off overlapping features

[thin pecan]

Alrighty

Is there a list of overlapping features yet?

[rain geyser]

Wrong link

Don’t forget TestAccountFixes

https://thunderstore.io/c/lethal-company/p/woodroach/BugfixBundle/

[rain geyser]

probably best to just disable everything under the Fix section of the config unless you wanna cross-reference the configs of the other bugfix mods

[thin pecan]

I'll have to do a deep dive then

[queen summit]

I've been trying to get him to profile my mod, but he seems to ignore me

[queen summit]

Woah, just checked how the new scanner code looks like and it's Transpiler madness O_O

[broken crescent]

Haha yeah once I got comfortable with how they worked, and created some useful helper functions, I try to use them anytime I think it would be more efficient.

I still don't love the idea because transpilers are more prone to breaking when things update, and they aren't as simple as a "Run before or after" function. But I do have safety checks in each transpiler to only do the work if it's possible, and log a clean error otherwise

[broken crescent]

For those of you that want a monitor that shows the health status of players:

1. Should it reveal when a player is dead, or just report their health as being low to avoid "spoilers?"

2. How should it handle > 4 players? Perhaps cycling through like the sales monitor?

[rain geyser]

Low to avoid spoilers

And 2) sounds good

[broken crescent]

Ok so maybe like a red/yellow/green heart icon or something per player instead of an exact health value

[rain geyser]

Yeah I personally don’t use the alive/dead stuff it kills the suspense

also you’ll never accidentally tp a Masked onto the ship 🤣

[broken crescent]

😏 true

[rain geyser]

Yoooo that’s actually the main thing I missed from this mod was making it so the Masked don’t spin on radar

[broken crescent]

Yeah that's just a hardcoded animation on the radar icon attached to the masked entity. It was easy enough to disable

[rain geyser]

@pliant lintel for your aforementioned curiosity

[low gyro]

i wonder if it's possible to make masked actually spin, so they actually do the radar movement

[rain geyser]

What is the point of that 😂

[low gyro]

realism? idk 🤷

[broken crescent]

Haha I guess if someone wants to keep the spins in there they'll just leave that option off. Unless they just want an easier detection method for visibility, but that's what the masks are for lol

[rain geyser]

Yep I love losing all our scrap to a single masked

Builds character

[rough salmon]

make a masked heart beat reversed but its almost unnoticeable (:

[fickle lodge]

is GI worth again? didn't see if DiFFoZ profiled again and found no gc.alloc

[broken crescent]

I'm kinda confused why people are coming back to the mod after I optimized FixPersonalScanner. Why not just leave that option off if it affected performance previously?

I don't mind if people don't use it or don't like it or whatever of course, I'm just confused because it's not like I overhauled the entire codebase 😅

[frigid bramble]

well i think part of it is that it broke when v56 dropped. otherwise, idk

[broken crescent]

That could be

[rain geyser]

I’ve had weird cross compatibility stuff with scanner mods every update

TestAccount666 scanner is hardly much more reliable than vanilla tho in my opinion I will probably try GI

[broken crescent]

Yeah my general recommendation for that is always to disable mine if you're using others

[rain geyser]

BetterItemScan always worked good but I think it’s dead now

[light girder]

He's trying

https://thunderstore.io/c/lethal-company/p/TestAccount666/ScanShipEverywhere/ I recommend keeping this though if you use it

GI doesn't include this

[rain geyser]

Well yeah, n I appreciate it. His other scan mods like the one you just posted are the best option of any alternative imo

Scan fire exit etc

Further scan for main

[light girder]

Btw @broken crescent dunno if @queen summit would be interested but I think he was wanting you to add a Blacklist for the ScannableTools feature

So that way some modded tools can be excluded if they count as tools when not meant to be

[broken crescent]

Oh I can't remember my implementation, I thought I had comma separated tool class names for defining which ones were scannable but I forget if it's that or just a toggle

[light girder]

Yeah you have it setup as a Whitelist lol

I just added All

LOL

[broken crescent]

Does that even support modded tools?

[fickle lodge]

Most features i liked/used was using reflection and was allocating per frame from what i remember, i have a weak pc so i'm always on search of performance, then i got some alternatives and disabled this mod, but now that you're active again i'm just curious

[light girder]

Idk if yours does or not

But I know his mod does

[broken crescent]

Come to think of it I seem to recall that being a suggestion in my issues

[light girder]

https://github.com/Test-Account666/LethalCompany-ScannableTools you can probably look at his code and fork it if you want, he's got it setup with a MIT License

[broken crescent]

Oh I might have misunderstood, you mean he wants me to help code a blacklist in his own mod?

[light girder]

No no

It's GI's implementation that needs the improvements, I was saying I hope he might be interested in helping you with it XD

[broken crescent]

ah lol

[broken crescent]

https://www.youtube.com/watch?v=w2FizSk7yXE

Throwback Thursday, pre-GI when me and my friends encountered a coilhead before we were used to it

[sour rain]

oh wow

i didn't realize you've uploaded gameplays

[broken crescent]

There was a time I uploaded like every day lol (I have a slightly abandoned YT channel) but then stopped when it was getting repetitive

[light girder]

Btw @broken crescent a minor issue but I noticed the background color is applying to the displays without Better Monitors after the latest update, I have the Show blue monitor background setting turned off lol

[broken crescent]

Hm that's odd, the monitor background stuff is the main thing I cleaned up in v1.3.3, but the logic looks ok for not showing it everywhere. I'll investigate

Ah, found it - I was blending logic with ShowBackgroundOnAllScreens. Fixed in next update

[dire ember]

The hell did I miss between 1.2.9 and 1.3.4 💀

[broken crescent]

Welcome to the alphabetical organization restructure 😎

[dire ember]

😢

Well I'm done with it- but now I wonder how this interacts with NiceChat ., .

I'mma just assume these two will work hand in hand -w -

[broken crescent]

Both pics you showed aren't of any actual changes, I just moved things around in the file

[dire ember]

oh no no - there are values I have to take from old to new

oh f... i don't recall moving hex colors..

[cloud gate]

bbbut i like my usebetter monitor option right beside addmorebettermonitor

[broken crescent]

I did think of that, some of the options made sense to be next to each other. But with all these config options it was looking pretty messy so I opted for the alphabetical order instead =/

[patent orbit]

does FixInternalFireExits doesn't work anymore?

[rain geyser]

I think it’s part of LLL now

Question mark

[broken crescent]

I fixed that a few versions ago, but if you use ButteryStancakes mod we both do the same thing and it flips you twice

[patent orbit]

LOL

that is weirdly funny to me, thanks for quick answer

[sour rain]

yes i cant auto-disable the fire exits without reading GI's config and that is sort of a hassle

so it doesnt have auto compat like any of my other changes

mine fixed internal and external fire exit rotation (external only works for vanilla moons), GI's is internal only

[upper schooner]

ngl the fact that having the fire exit thing with ButteryFixes & GI both on makes you flip back to face the door just sounds really funny

[sour rain]

if you use modded moons it is up to the creator to rotate their external exits, or you can just use GI's config for consistency

up to your preference really

[tawny gyro]

one little request if i may so submit. increase the sell window limit max to like 9999 or something? then i can get rid of that unlimited sell mod 😄

(if it aint problematic to do so, of course)

[frigid bramble]

is it not already increased?

it goes up to 100 now, unless what you're asking for is more than that

[tawny gyro]

https://tenor.com/view/star-wars-more-gif-21856591

with my solo pack, you have 0 clue how much scrap i can amass

tho the MoreItems mod only goes up to 999, so i guess having the sell max go to that would be fine 😛

[frigid bramble]

LobbyControl completely removes item limit

[tawny gyro]

dont need that if im in a solo pack

[frigid bramble]

i mean, it won't cause any issues to play with it solo, and it does remove the limit

[tawny gyro]

but then id just be replacing a mod instead of removing it

that's my goal

[rain geyser]

NoSellLimit

FriendlyShopkeeper

NoShopWait

[broken crescent]

Done

[rain geyser]

👌

[tawny gyro]

beyond based

[frigid bramble]

well it would be replacing MoreItems, you can remove the sell limit mod after that's in GI

[broken crescent]

For player health monitors, I wanted to use "<3" for a heart and just color it greed-red but it looks a little silly on the screen. I don't really want to use more than 2-3 chars because player names could be long (I truncate them but still). Anyone have any suggestions, or should I just keep the "<3"?

I would use the 💚💛❤️ emojis but the vanilla font atlas doesn't have support for that and I don't really want to mess with font assets

[frigid bramble]

yeah idk about the <3

why not just do like green |||, yellow ||, red |

[broken crescent]

You know, I had that exact idea too 🤜🏼 🤛🏼

I'll see how it looks

[rain geyser]

That or there’s fontpatcher

[broken crescent]

hmm this isn't too bad

[broken crescent]

I have no mod dependencies currently and I'd hate to introduce one just for that

[rain geyser]

True

[frigid bramble]

should probably be left aligned

[broken crescent]

Yeah it's still WIP

[frigid bramble]

otherwise yeah i like that

[rain geyser]

Aligned right

Like reading a manga

[upper schooner]

Yeah I'd also say could do a | notch, have the player left aligned and the HP right aligned

You could prob do anywhere between 5 - 10 notches, 5 for 20 hp a notch, 10 for 10 hp a notch

[broken crescent]

like

|||
 ||
  |

[upper schooner]

I like the colors to indicate the status too

[broken crescent]

Although I think I like

|||
||
|

better

I might see how equal signs look also

[frigid bramble]

= could be good but if you're concerned about space that's probably gonna take up significantly more

[broken crescent]

I think I do like that a little better. Working on alignment

[rain geyser]

-–— ?

I’m not sure how limited the character atlas is

[broken crescent]

Well considering it doesn't even have dollar signs $ lol

Since credit symbols are just squares (in code they are $)

[rain geyser]

Interesting

[frigid bramble]

oh, if you do have a square symbol i was gonna suggest that as well

[rain geyser]

[][][]

8=D ?

[cloud gate]

but what about player with a long name

[broken crescent]

I'm truncating them

[rain geyser]

It’s supposed to be vague

[rain geyser]

Oh

[cloud gate]

👀 ohhh

[rain geyser]

What’s that mean?

https://tenor.com/view/the-office-interested-reaction-steve-carell-michael-scott-gif-3915584

[broken crescent]

So IHaveAReallyLongName would become something like IHaveAReallyL

[rain geyser]

Ohhhh ok ok ok

[broken crescent]

I think I'm happy with this. I'm going to push the signs a bit more to the right then deploy it and expect everything to break 🙃

[light girder]

Lmao I've seen cases where they just get cut off

[outer crystal]

Got an idea for a mod option!!!

[light girder]

I have a friend with a long name, and when viewing them on the Terminal their name just doesn't load

lol

[outer crystal]

Make it so we can rotate items "placement spots" like in the cabinent. So we cna display our gear an fav scrap how we want..

would love that function ingame.

so in a mod maker didnt add in so that items rotate toward up like vanilla scrap does, then we can rotate them by holding a key or somethin once placed somewhere

if, pardon

[broken crescent]

ugh my computer is going to explode with this many instances

[broken crescent]

Not a bad idea but it sounds a bit time consuming to implement tbh 🙂

New update on the way bois

It was kind of hasty so feel free to report any new breakages

[subtle mulch]

Do you know anything the conflicts with AutoSelectLaunchMode? I thought it was fine because it selected an option rather than just skipping the screen entirely

[sacred kelp]

Looks great, I've been hoping for an addition like this

It would be cool if it was a purchasable upgrade, like OpenBodyCams

[kind turret]

fix dropped items not colliding with shiplaceables
Lets go

[outer crystal]

no worries. figured I would mention it.

[broken crescent]

It's crazy how many downloads this thing has. I originally made it for me and my friends just so our inventory would populate left - right as we pick things up lol

And seeing people recommend it on reddit when QoL mod threads pop up 😅

[cloud gate]

if useful why not download and cut number of mods (since my friends keep screaming at me saying they dont wanna play with that many) lol

[broken crescent]

That's fair. I have 30 mods, like 5 of which are dependencies from other mods I wish I could ditch but really like

One day I plan on doing quick hotbar switch code

[rain geyser]

i have noticed that my mods don't actually finish initializing for like 15 seconds after it shows the selection screen for Online or LAN

only on my laptop though. My desktop has more RAM and a better cpu and it finishes before showing the selections

I think its a system constraint issue where it might not finish some of the initialization before GI selects online which initiates a whole other step of the mods launching

[subtle mulch]

Hmm that makes me wonder if I should turn that option off then for users with lower amounts of ram

@broken crescent Could a buffer be added for when you are on the screen so everything loads? I just hate when the game finishes loading and I don't notice (my pack is almost 200 mods so it takes awhile) the menu music tends to be my que that its loaded

[rain geyser]

I was thinking this would be a good alternative as well

a configurable buffer

[sour rain]

the <3 is funny but i think it portrays poorly

looks like "less than 3" more than a vital sign

[rough salmon]

Message could not be loaded

[idle valve]

200 mods? Are you getting a good amount of fps? With 150 mods on my game it can barely maintain 50-60 fps, sometimes going straight to 30fps or less.

[subtle mulch]

Most of the time I get around 60, sometimes it dips into the 40s but overall it's pretty good

My group hasn't complained much about performance, barring something going wrong XD