#Sell My Scrap: Terminal Sell

1318 messages · Page 2 of 2 (latest)

grim kraken
grim kraken
sleek sand
silent dove
#

You don't need MinimumQuotaFinder. Sell My Scap can do this for ya by typing sell quota.

grim kraken
grim kraken
sleek sand
#

I saw that the host did have this error in their logs. This error should not be happening because ShipInventory is a soft dependency. I've tested my mod multiple times without having ShipInventory installed and it works just fine.

image.png
#

My guess is that you have a mod installed that's causing this to error

#

Since you are the only person to report this error

grim kraken
#

Yes it is something with the host. I don't know what since we have pretty much exactly the same mods but when I hosted the SellMyScrap mod worked.

#

Thank you for checking into it

sleek sand
#

SellMyScrap - Update v1.7.2 + v1.7.3

  • Fixed compatibility with the ShipInventory mod.
  • Updated Takey (scrap eater)
  • Updated Zombies (scrap eater)
  • Updated Psycho (scrap eater)
  • Small bug fixes.
  • Other changes and improvements.

If you were using the ShipInventory mod and selling items wasn't removing them from the ShipInventory, this has been fixed in this update.

https://thunderstore.io/c/lethal-company/p/Zehs/SellMyScrap/

Thunderstore
ShipInventory v1.1.5

Adds an inventory to the ship, allowing it to store items and retrieve them.

Thunderstore
SellMyScrap v1.7.3

Adds a few terminal commands to sell your scrap from the ship. Compatible with the ShipInventory mod. Highly Configurable. SellFromTerminal +

silent dove
modern thorn
#

@sleek sand Would you still be down to create a method to sort items to the front for selling?

#

This is in relation to competitive modded high quota. We're considering adding this mod along with ShipInventory as an approved mod. If SellMyScrap could pull items out of ShipInventory for selling the quota that would be perfect, however we may still want the risk of dying to Jeb to be included in runs

keen sparrow
sleek sand
sleek sand
modern thorn
#

Yeah I am aware, I've use both this and shipinventory in my weekly lobbies for months now which is why I mentioned that could be used for competitive runs as well.

#

Separate mod for official hq would work but it doesn't seem necessary for now as we have many mods that don't have features locked down for runs, just config options to disable them. Besides, I'm not sure what the rest of the hq team wants really.

#

For modded hq, we might just allow quick selling via a sell command without having to carry items but I have to get confirmation from other moderators first. If it seems okay to moderators of vanilla hq, they may allow some sort of version of sellmyscrap for vanilla as well.

#

To be clear, by modded hq i mean custom moons or brutal company minus high quota, and vanilla hq is vanilla moons with some QoL.

#

I'll present the idea of a separate mod as well to them

sleek sand
sleek sand
#

SellMyScrap - Update v1.8.0

  • Added PrioritySellList config setting to Advanced Sell Settings.
    • Description: Array of item names to prioritize when selling.
  • Updated Takey (scrap eater)
  • Added Wolfy?!
  • Other changes and improvements.

https://thunderstore.io/c/lethal-company/p/Zehs/SellMyScrap/

Thunderstore
SellMyScrap v1.8.0

Adds a few terminal commands to sell your scrap from the ship. Compatible with the ShipInventory mod. Highly Configurable. SellFromTerminal +

sleek sand
#

@modern thorn I saw that SellMyScrap was approved for modded high quota runs. Does this mean quick sell is approved for modded high quota runs or the get quota/get <amount> commands. (Those commands have not been implemented)

#

I'm assuming it's quick sell but I just want to confirm

sleek sand
modern thorn
modern thorn
#

and probably a few others i dont personally use but are approved

#

vanilla hq probably wants to keep gameplay changes such as selling fairly unchanged, at least from how i see it right now

sleek sand
#

Okie

sleek sand
modern thorn
#

as far as I can tell yeah, altho it doesnt matter for single day clears because selling isnt a part of that run

sleek sand
#

Yipppeee

modern thorn
sleek sand
#

SellMyScrap just hit over 500,000 downloads!

image.png
winter bison
sleek sand
silent dove
dreamy berry
#

now do it again perceive

#

fr tho, gratz boyo

paper slate
#

Not sure why, but it seems like selling through this doesn't trigger the day to progress?
I'd expect since I sold stuff that it wouldn't remain on days left 0, is it perhaps because everything was in ship inventory when I ran sell all?

sleek sand
paper slate
#

Far as I understand, if you didn't sell anything you can go back to orbit without losing a day in vanilla, but I'd ran sell all and yeah, remained on day 0, running with a lot of mods so I wouldn't be surprised if it was some odd interaction though

sleek sand
paper slate
#

Recreated events with this profile: 019357f1-1f87-b94d-ebfb-ed2791472896

📎 LogOutput.log
#

Made a new save, went to experimentation, got a piece of scrap, went to gordion, ran sell all, and went back to orbit after the credits were confirmed, and the day didn't advance to 1.

sleek sand
#

SellMyScrap just puts the scrap on the company sell desk automatically and calls the sell method so it should sell like 100% vanilla. The issue you are having is more likely to be another mod that you have installed

#

Did you try doing this without having the SellMyScrap mod installed? @paper slate

paper slate
#

How would I use sell all without the mod?

#

But I'll try and see if something broke the vanilla counter yeah

sleek sand
paper slate
#

But now I'm having to wonder if I somehow broke something that doesn't sync with the codes

paper slate
#

And now it's working as expected... Sorry to bother you then, will try to catch a recording if it does happen again under weird circumstances

sleek sand
sleek sand
silent dove
sleek sand
silent dove
sleek sand
silent dove
#

Thank you for being quick to drop a fix though!!!! ❤️

sleek sand
keen sparrow
#

Or maybe just sell what’s in ShipMod?

image.png
#

It would be convenient

#

Sometimes I have to devalue my favorite things with the players in the casino so that they don’t accidentally get taken away xD

silent dove
# keen sparrow Or maybe just sell what’s in ShipMod?

Confused what you're asking for?

You can do a few things.

  • set to only sell what's on the floor.

  • set to sell everything on the ship

  • pair with ship inventory and type in sell all -inv and it will deposit and sell everything in the chute only.

It's already pretty configurable and compatible with ship inventory so then if you want to save stuff for casino don't put it in the chute or just use the only sell from floor config and store items on stuff to keep it safe.

keen sparrow
#

-inv

#

sell inv

#

Sell ​​what's in the box

#

That would be convenient

silent dove
#

Just type sell all -inv

keen sparrow
#

Really???

#

I didn't know :с

silent dove
#

It's already pretty easy lol

keen sparrow
#

It was not written in the description when selling in the sell command

#

I DIDN'T KNOW :С

silent dove
#

Yeah you have to have the - in -inv

silent dove
#

I thought it was a prompt somewhere but I also was told by Crit when they first released compatibility with ship inventory.

keen sparrow
#

sell quota -inv

Does it work too?

silent dove
#

Also at the moment from what I heard you want to roll back both this mod and ship inventory 1 update at the moment. Ship inventory has had some reports of items corrupting in the chute with the latest update and is being worked on right now. The previous update does work great.

silent dove
sleek sand
sleek sand
silent dove
#

Crit should sell my scrap be rolled back too with ship inventory until it's patched?

#

I was told to roll back both.

sleek sand
#

If you roll back -> ShipInventory v1.1.5 + SellMyScrap v1.8.0

silent dove
#

Gotcha. Thanks 😊

ivory dagger
#

not sure if reported before, but this happened to me as host..

my friend (client) sold all,
i had 2 items in my vanilla slots which i didnt realise
i then desynced when the sell occured, couldent pick up or drop anything, telelporting didnt fix it, i think dying fixes the desync, but those items (and the other items i was holding) did not exist for anyone else, making the equipment impossible to recover from where i was teleported (sadly outside the ship)

paper slate
#

Ship Inventory updated to fix corruption, sell all currently borked due to the changed format looks like

sleek sand
sleek sand
sleek sand
#

SellMyScrap - Update v1.9.0

  • Removed the view config and edit config commands.
    • I recommend you use the LethalConfig mod to edit the config settings.
  • Updated config settings.
    • Old config setting values will migrate to the new config settings.
  • Improved config sync.
  • Updated Takey (scrap eater)
  • Fixed compatibility with the ShipInventory mod v1.1.7+
  • Fixed the ShipInventory mod breaking the sell commands and view scrap command when using an incompatible version.
  • Added some patches to fix the ShipInventory mod v1.1.7 breaking the saving and loading of items.
  • Other changes and improvements.

https://thunderstore.io/c/lethal-company/p/Zehs/SellMyScrap/

Thunderstore
SellMyScrap v1.9.0

Adds a few terminal commands to sell your scrap from the ship. Highly Configurable. Compatible with the ShipInventory mod. SellFromTerminal +

ivory dagger
# sleek sand This is the first time I'm hearing of this bug. Could you please send me your lo...

i will ask the person who did the "sell all" for their log, this is mine though.

[01:19:51.8232905] <- at that time... i tried to put the items on the vanilla selling window and i think that caused a "grab validated" from lobby control.
I then teleported myself.. but couldent grab.. so i tried to kill myself so hopefully after leaving the company, i could grab again.. but it was still not working.

luckily was end of session, so we just ended after that (i opened the save a few times after to test something else out) as being the host.. only way for me to fix issues like that is teleportation, death, or restarting lobby xD

📎 message.txt
sleek sand
#

SellMyScrap - Update v1.9.1

  • Fixed the view overtime command not working properly.
  • Removed patches to fix the ShipInventory mod v1.1.7 breaking the saving and loading of items.

https://thunderstore.io/c/lethal-company/p/Zehs/SellMyScrap/

Thunderstore
SellMyScrap v1.9.1

Adds a few terminal commands to sell your scrap from the ship. Highly Configurable. Compatible with the ShipInventory mod. SellFromTerminal +

ivory dagger
sleek sand
proper kite
#

@sleek sand sorry for bothering, but you might want to take a look if this mod is still compatible with the latest version of ShipInventory. Changed some things that could make it more difficult

sleek sand
sleek sand
sleek sand
placid halo
#

I have a feature request. Can you add a config to allow selling from other moons?
I'm making a modpack, and I'd like to have the ability to sell scrap mid-run. That way the players could sell an item to buy a tool without ending the current day.

Also a configurable penalty sell percentage would be nice. Like selling items mid run could be set to 30% of the value to match the 3 days left rate. etc etc. 💛

sleek sand
placid halo
# sleek sand I don't think I would be adding this anytime soon

thanks ok! I'm just looking for a solution to give players a little bit of in-run money. I'm having some items spawn randomly in the map so if they need a shovel or flashlight or something then they might find one. I also managed to setup VS and compile my first LC mod yesterday, so there are more options in my future!

sleek sand
placid halo
#

Hihi~ Sorry to bother you again with a question about your mod:
ChuteInteractPatch.cs references ChuteInteract.SpawnItemClientRpc and I'm getting an error. maybe a reference to a mod I don't have installed?
I installed ShipInventory and added that reference; that fixed all the errors in ShipInventoryProxy.cs, but this one remains.

Thanks 💛

placid halo
#

it's weird because I see the definition in ShipInventory/Objects/ChuteInteract.cs on the ShipInventory github, and I made sure all my references are pointing to the up-to-date dlls on my pc. So I really don't know what's wrong unless they changed something between ShipInventory v1.2.0(latest github release) and v1.2.4(thunderstore version)

sleek sand
#

Ohhh you are trying to set up a development environment nkoHehe

sleek sand
placid halo
#

Awesome! Yeah I've been just setting it up in order to try my hand at adding the functionality I wanted~ thank you!

keen sage
#

So ur maxwell model dealt damage to me and sent me to the backrooms...

sleek sand
keen sage
#

I'll never recover

ivory dagger
#

Zehs, not sure if your mod is at fault, or another, but i cant track back further than your mod as i dont know what comes before it in the list of store items.

with the TakeyPlush mod (sorry couldent find a thread for it so writing here) you add a "TakeyPack"... from the config, it suggests buying the normal pack has a chance to be replaced by a TakeyPack.

in my store.. i see the TakeyPack as a buyable option, not sure if this is intended.. but if it is, thats fine (i have the chance only on 25%)

the problem im getting is.. i have TakeyPlush installed, and BuyableShotgunPlus installed... and randomly (sometimes at the start of the game, sometimes mid-game) the store buying gets broken...

so, when i load in i usually can type:

TakeyPack -> says its buying a takey pack, buys a takey pack
Shotgun+ -> says its buying a shotgun, buys a shotgun.
Shell+ -> says its buying a shell, buys a shell

but when it breaks...

TakeyPack -> says its buying a takeypack, but price is for a SHOTGUN.. and it buys a shotgun.
Shotgun+ -> says its buying a shotgun, but the price is for a SHELL... buys a shell.
Shell+ doesnt work.. throws an error saying the command doesnt exist, or similar.

whether its your mod causing the issue.. or another mod adding to the store before yours causing the issue, i just figured id report it as it breaks the buying of the takey pack too (if that was even intended, if it wasnt intended then it maybe the takey pack being removed from the store that causes the issue? either way i dont know whats just before TakeyPack in the list xD)

from my pov, it feels like something is removed from the store after the game has started.. which then shifts the index of the items in the store, making the shell+ not buyable with shell+ command...

this is the profile code
01949a94-33e1-33fb-7808-2f1181ce2d40

i dont know how i can help more than this, but if i can (including testing things to fix it if you know whats causing it), let me know, both host and clients get the issue, so its not a desync issue afaik (well at least not between host/clients)

sleek sand
# ivory dagger Zehs, not sure if your mod is at fault, or another, but i cant track back furthe...

There is no thread for the TakeyPlush mod. Though I should make one that is for all my scraps nkoHehe

I'm registering the Takeypack shop item through LethalLib so I don't think it would be the Takeypack specifically.

The jetpack replace chance for the Takeypack does not interact with the shop system itself in a way that would break things. It applies a patch to the ItemDropship before spawning the bought items.

I have seen an issue like this before where a moon that added shop items caused issues like this.... @spice tulip

spice tulip
sleek sand
#

It could be another moon mod

spice tulip
# sleek sand It could be another moon mod

Well my issue came from my item being coded via LL by Figo and registered thru LLL on my end at the time as a buyable item, raised awareness to this shop mixing issue a couple of times and since it wasnt fixed I just left it as a scrap item.

sleek sand
warm skiff
#

in case it hasn't been mentioned before

#

it would be nice if you could use terminal to sell at galetry (from wesley's moon mod)

#

it basically replaces the company building as the hub world and the sell counter is even further away from the ship

spice tulip
warm skiff
#

i see

sleek sand
warm skiff
#

that'd be really nice

#

thank you

sleek sand
#

SellMyScrap - Update v1.11.0

  • Added more algorithms to find scrap match (#15)
    • The scrap match algorithms are:
      • 1 → Default (Recommended)
      • 2 → Brute Force
      • 3 → Super Fast (Recommended when selling 10k+)
    • Added command flag -a:<number> to some sell commands to select a scrap match algorithm.
      • <number> is the index of the scrap match algorithm.
      • Example: sell 10000 -a:3
  • Selling now works on any moon that has a sell desk.
    • This includes the moon Galetry.
  • You can now sell scrap items that are placed on PlaceableShipObjects.
  • The view scrap command now includes scrap items worth $0 when the SellScrapWorthZero config setting is false.
  • Updated Takey (scrap eater)

https://thunderstore.io/c/lethal-company/p/Zehs/SellMyScrap/

Thunderstore
SellMyScrap v1.11.0

Adds a few terminal commands to sell your scrap from the ship. Highly Configurable. Compatible with the ShipInventory mod. SellFromTerminal +

warm skiff
#

hey cool

#

that was fast

spice tulip
#

Love to see that!

sleek sand
#

^w^

languid kiln
#

uh when you sell the scraps in galetry using shipinventory, nothing shows up and the scraps inside gets deleted.. cant be retrieved
i got scammed greed

sleek sand
dreamy berry
sleek sand
viral bluff
#

Jester on the ship plus a million hoarding bugs

dreamy berry
#

ControlCompany on [[DemonMae anomaly moon]]

viral bluff
#

I wish DemonMae would upload that moon seperately ngl, that's hands down her best moon although I appreciate the visual overhaul all her moons got recently

dreamy berry
#

ye

surreal plaza
#

Hi Crit, I have an issue sadCat I have a friend who made a pack and i told her to add the scrap selling mod, cause ofc I did, and it's not working with the other mods. So she asked me to fix it since I recommended adding it and I am not that good LUL The scrap mod recognizes the scrap in ship but when trying to sell quota or all, says nothing found. But you can sell the individual items by name. First screenshot is the 'view scrap' second is results of 'sell quota/all' and third is the sell individual item. The modpack: 0194ed08-92ec-887d-7c6d-d52f67bcdfe6

image.png image.png image.png
#

(also if this is not the right place to put this, please lemme know, thanks!)

sleek sand
sleek sand
surreal plaza
sleek sand
# surreal plaza I just did that. Still getting the above when I try selling. Everything is viewe...

I figured out the issue and it's stupid nkoHehe

The DontSellList config setting value:

the gambler mochi, torch, destiny mochi, zombie, sheep, redstone torch, pumpkin, shotgun, shotgun shells,

ends with a comma so I'm guessing the mod is counting the empty area after the comma to be an entry for an item to not sell. And since the mod checks if any item names contain any entry from the DontSellList it's counting nothing/empty entry for each item and not allowing you to use the sell <amount>, sell quota, and sell all commands.

Just remove the comma at the end of the DontSellList config entry value and it should work.

I'll fix this in the next update.

#

I don't know how this has gone unnoticed for so long nkoHehe

surreal plaza
#

Ooooooh. That is very silly and I didn’t even see she had thing not for sale! Lemme go try that right now

#

Yup that fixed it! Thank you so much Crit!!

sleek sand
sleek sand
#

SellMyScrap - Update v1.12.1

  • Fixed trailing comma in the DontSellList config setting value not allowing you to use the sell <amount>, sell quota, and sell all commands.

https://thunderstore.io/c/lethal-company/p/Zehs/SellMyScrap/

Thunderstore
SellMyScrap v1.12.1

[v40/v69+] Adds a few terminal commands to sell your scrap from the ship. Highly Configurable. Compatible with the ShipInventory mod. SellFromTerminal +

winter yacht
#

anybody know how KeepRate in the config work
is the value in percentages?

#

10 for 10%?
or 0.1 for 10%?

sleek sand
winter yacht
#

The config for KeepRate value

sleek sand
#

There is no config for that in SellMyScrap

winter yacht
#

Oh fck my bad
I thought this was shipinventory

Twas 3am last night

sleek sand
nova wing
#

Hey I got an error while trying to sell

#

Wouldnt let the sell commands work

sleek sand
nova wing
#

Found out recently, thanks

sleek sand
#

SellMyScrap - Update v1.12.2

  • Fixed compatibility with the ShipInventory mod v1.2.6+
  • This mod is compatible with the ShipInventoryUpdated mod v1.2.8+
  • Fixed selling items from the ship inventory where trying to sell too many items (over the Chute max capacity) would cause the command to time out because no more items were spawning out of the chute.

https://thunderstore.io/c/lethal-company/p/Zehs/SellMyScrap/

Thunderstore
SellMyScrap v1.12.2

[v40/v69+] Adds a few terminal commands to sell your scrap from the ship. Highly Configurable. Compatible with the ShipInventory mod. SellFromTerminal +

sleek sand
#

@nova wing The issue has been fixed in the latest version of SellMyScrap v1.12.2+

orchid comet
#

ShipInventoryUpdated has been updated again to v1.2.9, and it looks like SellMyScrap is no longer able to observe its contents.

📎 LogOutput.log
viral bluff
#

Probably cus it's now registered as ShipInventoryUpdated instead of ShipInventory

sleek sand
#

Waaaaa sadfelix

viral bluff
#

so you don't need to add support for the old name anymore

sleek sand
silent dove
#

Wait so now the old ship inventory isn't working now with sell my scrap? Or will the old one work still?

#

I'm just not ready to yet to switch 😩 it was working just fine for us.

sleek sand
silent dove
viral bluff
#

The name got changed but the config works the same

#

That should allow you to just migrate everything over

nova wing
amber lagoon
#

is this based on moon selection or just global registered scrap?

#

like any scrap from initialized mods etc.

sleek sand
tawdry glacier
#

not sure what happened

[Info   :com.github.zehsteam.SellMyScrap] Earned $0; sold 0 items; new credits amount: $852
InvalidOperationException: Sequence contains no elements
  at System.Linq.Enumerable.Max (System.Collections.Generic.IEnumerable`1[T] source) [0x00022] in <dab7f68612224ba3ae40f651d44f9d4c>:IL_0022 
  at com.github.zehsteam.SellMyScrap.Helpers.ScrapHelper.GetScrapMessage (System.String[] itemNames, System.Int32[] scrapValues, com.github.zehsteam.SellMyScrap.Data.ItemLocation[] itemLocations, System.Boolean sortFoundItemsPrice, System.Boolean alignFoundItemsPrice, System.String color2) [0x000b1] in D:\Documents\Visual Studio Projects\Lethal Company Mods\SellMyScrap\SellMyScrap\Helpers\ScrapHelper.cs:331 
  at com.github.zehsteam.SellMyScrap.Helpers.ScrapHelper.GetScrapMessage (System.Collections.Generic.List`1[T] grabbableObjects, System.Boolean sortFoundItemsPrice, System.Boolean alignFoundItemsPrice) [0x00066] in D:\Documents\Visual Studio Projects\Lethal Company Mods\SellMyScrap\SellMyScrap\Helpers\ScrapHelper.cs:299 
  at com.github.zehsteam.SellMyScrap.Helpers.ScrapHelper.GetScrapMessage (System.Collections.Generic.List`1[T] grabbableObjects) [0x00001] in D:\Documents\Visual Studio Projects\Lethal Company Mods\SellMyScrap\SellMyScrap\Helpers\ScrapHelper.cs:290 
  at com.github.zehsteam.SellMyScrap.Patches.HUDManagerPatch.DisplayCreditsEarningPatch (HUDManager& __instance, System.Int32 creditsEarned, GrabbableObject[] objectsSold, System.Int32 newGroupCredits, UnityEngine.Coroutine& ___scrollRewardTextCoroutine) [0x0002a] in D:\Documents\Visual Studio Projects\Lethal Company Mods\SellMyScrap\SellMyScrap\Patches\HUDManagerPatch.cs:20 
  at HUDManager.DisplayCreditsEarning (System.Int32 creditsEarned, GrabbableObject[] objectsSold, System.Int32 newGroupCredits) [0x0001a] in <bdf6a080e98a49fd84b92b24894f768c>:IL_001A 
  at DepositItemsDesk+<delayedAcceptanceOfItems>d__59.MoveNext () [0x00180] in <bdf6a080e98a49fd84b92b24894f768c>:IL_0180
sleek sand
viral bluff
modern thorn
#

@sleek sand Hey I have another suggestion. When only sell scrap on the floor is selected, some scrap like Beehives or some modded scrap never get sold automatically due to how far off the floor they float technically. Would it be a big deal to turn the hardcoded value in return yOffset <= 0.1f in ScrapHelpers.IsScrapOnFloor() to a configurable value?

modern thorn
#

Another idea I had was to have a sell mode that prioritizes selling as many items as possible to remove as much scrap from the ship as possible when selling only a specific amount (like sell quota)

velvet fractal
#

@sleek sand friend sold an inspectable item as i was inspecting it some how and now im permanently stuck in inspecting but able to switch inventory slots

Screenshot_1300.png
#

idk if it was just cause of a network desync where it wasnt off the ground for their side, or just the item itself

#

just in case, the item is "love" from the moon thalasso

dreamy berry
#

so newest update does this...

#

happened on my main profile first, but after downgrading, i continued playing. this is on my tester profile. ACompassRevived and Oxygen seem to very much dislike this update

sleek sand
#

Waaaaa

dreamy berry
#

that's what i said when i learned it was this mod's update

#

since all it apparently does is change a default value

sleek sand
#

I mean I did change a lot of other internal stuff

#

But everything worked perfectly fine when I tested it

dreamy berry
#

well, something was flagged [Fatal] when the chainloader startup was running

#

0198ef59-ab08-c1be-194f-a339a05767a0

#

nothing more i can provide, my fren

sleek sand
#

I figured out the issue

#

I forgot to include the AssetBundle file

#

SellMyScrap - Update v1.13.0

  • Changed the ScrapEaterChance config setting's default value from 75 to 0.
    • This was changed at the request of the High Quota community.

https://thunderstore.io/c/lethal-company/p/Zehs/SellMyScrap/

Thunderstore
SellMyScrap v1.13.0

[v40/v72+] Adds a few terminal commands to sell your scrap from the ship. Highly Configurable. Compatible with the ShipInventoryUpdated mod. SellFromTerminal +

dreamy berry
#

silli

#

i'll give a looksee tomorrow

#

thx for the fix

viral bluff
#

Unfortunately I stopped using the mod since I don't think it would work well with Oxyde, idk if it errors on there or not but I know it definitely couldn't be used there

#

Nor would I wanna use it there, I just worry about errors

sleek sand
sleek sand
sleek sand
viral bluff
#

I haven't tested

viral bluff
#

Which is understandable

sleek sand
#

Yeah

#

It takes sooo long on higher quotas

modest harbor
#

Hello! Any ideas on this issue?

sell_scrap_log.png
dreamy berry
#

and also, how is it affecting gameplay?

modest harbor
#

When using the sell the scrap command it won't sell at all, but it will become invisible or/and uninteractable for who is using the command

📎 LogOutput.log 📎 modlist.txt
sleek sand
modest harbor
sleek sand
sleek sand
viral bluff
ivory dagger
#

i stopped using "sell on floor" because it left so much behind, guess i need to try with this back on 😄

modern thorn
#

It seems to be broken even further now. Only beehives were really a problem before for me, now it cant sell these.

image.png
#

Pack i use (133 mods): 019a1212-533a-ecd1-b75c-49218a5de8b5

viral bluff
sleek sand
sleek sand
#

I think I fixed it for real this time @ivory dagger @modern thorn @viral bluff

warm skiff
#

not sure if this is necessarily a bug but found out that apparently clients can override the host's config for scrap eaters

#

it syncs properly so maybe that's not an issue, but i guess it could be an oversight?

sleek sand
warm skiff
#

well im not sure but i was just playing in a session where the host had scrap eaters disabled and a client using the terminal was able to summon one anyway

#

i was neither the host nor the client in this scenario

sleek sand
#

Ohhhh

warm skiff
#

everyone saw it just fine, there wasn't any desync or bugs, i just wasn't sure if you intended that to be possible

sleek sand
#

Yeah, that's a feature and intentional

warm skiff
#

okay

#

Lol

sleek sand
#

There is a command flag which lets you force enable a scrap eater when you sell and even select which scrap eater appears

velvet fractal
#

my friends been doing this a lot lately

#

i am forever hateful

#

i want my immersion 😡

sleek sand
#

Hehehehe >:3

faint jacinth
#

really cool mod 💪💪

#

execution is like genuinely so nice

sleek sand
#

Thank you ^w^

velvet fractal
#

sell my scrap sucks because theres no item named "my scrap" yet and therefore this mod doesnt function

velvet fractal
#

im sorry

Screenshot_2534.png
#

what

velvet fractal
#

ITS

#

NOT THIS MOD???

ivory dagger
sleek sand
ivory dagger
#

thats fair

viral bluff
sleek sand
#

I hope it's been working as expected @viral bluff

modern thorn
#

no problems with selling items on floor so far. thank you for the fixes 🙏

sleek sand
#

I'm glad to hear that

viral bluff
sleek sand
#

I most likely missed it

viral bluff
sleek sand
modern thorn
#

@sleek sand Selling on v40-v72 fails to sync to clients. Sell only syncs upon entering orbit and calculating next quota. Exception in client side log: Exception: System.InvalidOperationException: Sequence contains no elements at System.Linq.Enumerable.Max (System.Collections.Generic.IEnumerable`1[T] source) [0x00022] in <dab7f68612224ba3ae40f651d44f9d4c>:0 at com.github.zehsteam.SellMyScrap.Helpers.ScrapHelper.GetScrapMessage (System.String[] itemNames, System.Int32[] scrapValues, com.github.zehsteam.SellMyScrap.Objects.ItemLocation[] itemLocations, System.Boolean sortFoundItemsPrice, System.Boolean alignFoundItemsPrice, System.String color2) [0x000aa] in ./Helpers/ScrapHelper.cs:317 at com.github.zehsteam.SellMyScrap.Helpers.ScrapHelper.GetScrapMessage (System.Collections.Generic.List`1[T] grabbableObjects, System.Boolean sortFoundItemsPrice, System.Boolean alignFoundItemsPrice) [0x00065] in ./Helpers/ScrapHelper.cs:285 at com.github.zehsteam.SellMyScrap.Helpers.ScrapHelper.GetScrapMessage (System.Collections.Generic.List`1[T] grabbableObjects) [0x00000] in ./Helpers/ScrapHelper.cs:276 at com.github.zehsteam.SellMyScrap.Patches.HUDManagerPatch.DisplayCreditsEarningPatch (HUDManager& __instance, System.Int32 creditsEarned, GrabbableObject[] objectsSold, System.Int32 newGroupCredits, UnityEngine.Coroutine& ___scrollRewardTextCoroutine) [0x00024] in ./Patches/HUDManagerPatch.cs:20 at (wrapper dynamic-method) HUDManager.DMD<HUDManager::DisplayCreditsEarning>(HUDManager,int,GrabbableObject[],int) at DepositItemsDesk+<delayedAcceptanceOfItems>d__59.MoveNext () [0x00180] in <066a7b7eb8c24d4facd1e255e669803f>:0 at UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) [0x00026] in <e27997765c1848b09d8073e5d642717a>:0 Tested on v72 and v62

ivory dagger
modern thorn
#

Last version is intended and does support them for the most part. The mod detects if yourr playing an older version and generates a v40-v72 config too if so

ivory dagger
#

maybe trying to sell when there is nothing to sell?

sleek sand
sleek sand
sleek sand
#

SellMyScrap hit over 1,000,000 downloads! 🥳 kittyhype

silent dove
#

New scrap Eater for 1 mil?!?!

sleek sand
#

I don't nyo

sleek sand
plush hemlock
#

[REDACTED] ...?

#

curious

silent dove
sleek sand
sly flicker
charred reef
#

Actually I change my mind

#

Add pacoito next

modern thorn
sly flicker
weary quail
#

Found something interesting, went to sell everything i had from the inventory, as they were getting pulled out i blew up on of the bombrocks from pikmoons, and after they all vanished i did not get paid

#

[00:19:49.7793925] [Error : Unity Log] NullReferenceException
Stack trace:
UnityEngine.Component.TryGetComponent[T] (T& component) (at <c39a522eee05469b8171a6cfeb646c59>:IL_0001)
com.github.zehsteam.SellMyScrap.Helpers.NetworkUtils.GetNetworkObjectReferences (System.Collections.Generic.List`1[T] grabbableObjects) (at ./Helpers/NetworkUtils.cs:31)
com.github.zehsteam.SellMyScrap.Managers.SellManager+<PerformSellOnServer>d__17.MoveNext () (at ./Managers/SellManager.cs:161)
UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <c39a522eee05469b8171a6cfeb646c59>:IL_0026) also found this in the logs just now

#

I dont know if its due to the object no longer existing when it tries to sell

sleek sand
weary quail
#

:3

sleek sand