suitsTerminal v1.5.12 (More Suits Addon) (Suits in Terminal)

[serene iron]

i'll look when I have time

[final forum]

here

[serene iron]

[1.4.2]

• Added fix for compatibility with upcoming terminalstuff update
• Hopefully fixed NRE error with addcommand method (unable to replicate on my end)
• Updated to OpenLib 0.1.8
• Update advancedSuitsMenu to accept 0 input to hopefully fix some issues where other mods would place words into the node anyway

[serene iron]

suitsTerminal v1.4.2 (More Suits Addon)

[dry bone]

Rack is still there. Wasn't there yesterday when I was testing

[serene iron]

can i get full logs and profile code?

[dry bone]

'

[serene iron]

also did you happen to start a lobby, close it, and then launch another?

[dry bone]

No I just started lobby without closing it

01912c23-12de-c5a6-b13d-8d1cf6484f00

[serene iron]

huh, thats really weird. Usually with that sort of error it's because I forgot to clear a dictionary before adding to it again

[final forum]

The problem is with UnlockOnStart mod

[serene iron]

wonder if there's a suit with a duplicate name

[serene iron]

oh is this something you're aware of?

[final forum]

yes it's broken lol

caused me to softlock in you're fired cutscene

[serene iron]

me issue?

[final forum]

no, mrov issue

it's his mod

[dry bone]

Oh yeah, that fixed the issue. Didn't know that mod is broken

[serene iron]

oh i didnt know it was his

does it duplicate items or something?

[serene iron]

i'll try to add some handling for this error not to appear at least in a future update

[nova delta]

Suggestion: Make a option in config where you can choose which suits not to show on the terminal (or choose specifics suits to only show on the terminal)

[serene iron]

sounds like two different config option requests

something like:

• dontShowInTerminal (list of suits to not show in the terminal)
• dontAddToRack (list of suits to never add to the rack)

ofc this could end up resulting in a suit being loaded into the game that is neither in the terminal or on the rack (if you config it that way)

[serene iron]

the above sound like it'd work for your suggestion?

[nova delta]

Yes both of those are good

[serene iron]

WARNING: This update will reset your config

[1.4.3]

• Updated configuration item names, descriptions, and default values for clarity.
• Added TransformHotfix to mirror camera for reproducible issue that I cant seem to solve.
  • The issue is if you switch suits from the rack and then go to the terminal and enter the suits menu it will almost always break the mirror camera position/rotation.
  • The TransformHotfix will basically reset the camera position/angles the frame after you enter the suits menu.
• Added [DontAddToTerminal] config item to specify suit names that should NOT be added to the terminal.
  • You will only be able to wear this suit if it's in the rack.
• Added [DontAddToRack] config item to specify suits that should NOT be added to the rack.
  • These suits will only be able to be worn if they are listed in the terminal.
• Changed [suitsOnRackList] to [SuitsOnRackOnly] & removed [suitsOnRackCustom] config item.
  • If [SuitsOnRackOnly] has a value, only suits in this list will be added to the rack.
  • Handling has been updated so that this does not need to be case sensitive and leaving it empty will leave it disabled.
• Moved some more redundant methods over to OpenLib and performed some general code cleanup.
• Updated advancedSuitsMenu formatting, will now show currently equipped suit name at the bottom of the listing above page numbers
• Added nullable to project and better error handling messages

suitsTerminal v1.4.3 (More Suits Addon) (Suits in Terminal)

[serene iron]

finally got around to it. Sorry for the delay

[meager hemlock]

hello!
Is there a way to set a default suit?
(like unable to use the default orange suit)

[serene iron]

currently there is not a feature like that in this mod. Suitsaver does save the last suit you wore though

I can see about adding something like that though

[meager hemlock]

thanks for answering :]

[serene iron]

would just need to make sure it doesnt conflict with suitsaver lol

[serene iron]

oh also, if you want to remove the default suit as an option you can add it to both [DontAddToTerminal] and [DontAddToRack] in the config. You will still spawn with it but it will not be in the suits menu or on the rack

the default orange suit name is "default" so you'd just add that to each config item

[serene iron]

[1.4.4]

• Added [DefaultSuit] configuration item which will allow for setting a new default suit to wear when loading in to the game.
  • If SuitSaver is present, this will be completely disabled to avoid conflicts.

[serene iron]

added in latest patch 👍

[meager hemlock]

Oh!

You are great Darmuh. Thanks!

[serene iron]

note - it will not do anything if you have SuitSaver

[meager hemlock]

Understandable

[serene iron]

suitsTerminal v1.4.4 (More Suits Addon) (Suits in Terminal)

[serene iron]

seems to be working fine with v64, adding tag

[next karma]

yo just wanted to say these new config options are amazing, thank you!

[next karma]

just one thing, maybe it would be cool to make it so when we hide suits from the terminal that the pages actually get less instead of just shorter pages

[serene iron]

this might be a bit more difficult to accomplish than you'd think. Technically the suits are all numbered from 0-100+ so when you remove one from the terminal I have to account for that when building the menu page. That said, they still exist as that number so my menu has to hop skip from say 3 to 6 if 4 and 5 are set to be hidden from the terminal

this also just made me realize that if you hide every item that would have displayed in one page it'll prob break the menu (if not totally, until you press a button)

I'll have to think on it and see if there's an easier way to do things without causing desyncs with the suits menu

[next karma]

Ohh I see, I had no idea. It works okay right now but we did have some instances where people were on hidden suits and they couldn't change the page anymore

[serene iron]

[1.4.5]

• Fixed error with favorites menu that would break suitsTerminal completely.
  • Thanks @spring tangle for the report.

[serene iron]

hmm, would be curious if you can find a way to reproduce people wearing hidden suits. That's an interesting one for sure

I may try to rework the backend a bit at some point to hopefully solve some of these random issues that can occur

suitsTerminal v1.4.5 (More Suits Addon) (Suits in Terminal)

[next karma]

I can try to take a video later, I think I know how to reproduce this

[next karma]

Here you can see how I am able to wear a hidden suit named "Construction" which is between Magenta and Yellow Ranger Suit

[serene iron]

yeah definitely seems like an issue with how I'm working around the hidden suits

will look into reworking the backend at some point

[next karma]

Okii take your time really, it's still the best option out there in my opinion when it comes to handle suits without desync ❤️

[rocky tide]

@serene iron hi there!
I just installed this mod and a bunch of models but I noticed that the page count doesn´t want to go past 11.
When I added more models I tested the mods one by one, but as soon as they get past XX amount other models just vanish out of the list.
Here is my mod code: 0191fbe9-40f6-e521-6195-7132c527ffd8

I don´t know all the models, since this is the first time using that stuff, but right now I noticed pikachu, anya, peter griffin is gone and there must be a lot more missing because it was already at 11 pages before i activated the last mod with a bunch of models. It also doesn´t even fill the 11. page.

Thank you for your help in advance!

[serene iron]

Hello, your suit count is being limited by More_Suits' config item here

if you want more than 100 suits to be added to the game you need to change that number, as it defaults to 100

[rocky tide]

Ohhh I didn't know that mod restricts the amount, thank you very much!

[serene iron]

[1.5.0]

• Slight backend rework. Utilizing a new class that tracks relevant information for each suit.
  • Fixes issue of suits that were hidden from terminal causing odd desyncs in the menus
  • Should also be much more efficient (resource-wise)
• Fixed issues with different camera implementations
  • OpenBodyCams cameras will no longer randomly change positions when equipping a suit
  • Homebrew cams have been moved to OpenLib with built in compatibility for TooManyEmotes, ModelReplacementAPI, and MirrorDecor.
• Changed mirror camera type to a non-orthographic view
  • Zoom steps now change camera fov
  • Set height positions have also been changed completely
• General code cleanup

[serene iron]

got around to it lol

suitsTerminal v1.5.0 (More Suits Addon) (Suits in Terminal)

this should hopefully put this mod in it's most stable state yet

[next karma]

nice thank you so much for the update!

[pure hollow]

suits command are not working for me after i updated suitsterminal

[meager hemlock]

the terminal breaks after typing "suits"

[pure hollow]

Yeah, that

[undone mural]

This
There's a Ton of red text in the log

Pulls up the camera but no suits list, also takes the default suit off the rack even if that's the one thing you told it to keep on the rack

[spring tangle]

@serene iron new update is broken

[livid agate]

hallo, is the legacy command "wear" still available to use? I just remembered last time my friend told me their arrow keys are broken and want an alternative to choose the suits

[serene iron]

I don't know what the fuck happened between my testing (which I have been doing for multiple days) and the last compile before I zipped it for thunderstore. Looking into it now

I have to assume I got fucked by letting visual studio analyze and fix "formatting" issues automatically

[serene iron]

yes you just need to disable this setting to use the legacy commands

you can also use chat commands as an alternative

and the arrow keys can be rebound to something else

[1.5.1]

• Fixed fatal error that broke advancedsuitsmenu, sorry for missing this.
• Added some more logging for when these fatal errors occur to directly point to the exact issue.

suitsTerminal v1.5.1 (More Suits Addon) (Suits in Terminal)

[spring tangle]

Lmao I was giving you shit earlier

In a funny way

"Ah yes I optimized my mod and made it better, by not making it work at all"

[serene iron]

what's crazy is it worked perfectly fine before I posted it

no idea wtf happened between my testing and posting

[spring tangle]

Yeah the second we typed suits it died

lol

[serene iron]

yeah a list was not getting initialized properly

which fucked the math up

and caused a lot more fuckshit

[meager hemlock]

now the camera doesn't work

but at least the terminal is working

[spring tangle]

Lmao

@serene iron

[serene iron]

works for me in testing. Can you provide logs & code?

[meager hemlock]

Code

01929338-13fc-7773-35d2-71259c29f5dc

I can't send Log atm

Not in home

[serene iron]

np

[spring tangle]

I'll see if I can repro it in a bit I suppose lol

[serene iron]

if you toggle the cam (by pressing f12 twice) the cam works

need to figure out why its not on automatically

[03:13:54.9378860] [Warning:   OpenLib] Unable to grab bodycamcomponent @GetCam```

will figure this out later tn

[spring tangle]

It's on automatically for me for some reason

Might be a case of config settings

Also you really should change the binding from F12

F12 is the keybinding for screenshots on Steam

Which makes it very annoying

lol

Idk a good replacer though

[serene iron]

you can change it in config

[marsh wren]

getting this error everytime i try to open the suits menu

opening and closing the game again does not fix, neither does having somebody else host

did not have this issue before most recent update

also am on most recent update

[serene iron]

aware of this issue, see here - https://github.com/darmuh/suitsTerminal/issues/13

[spring tangle]

TerminalStuff is also randomly exploding

Your updates are seriously way too broken for me

[serene iron]

then stop using my mods

either roll back or give me time to fix them

[meager hemlock]

what broke exactly?

[serene iron]

You seem to forget this is free fucking labor

[spring tangle]

Nah nah I love your mods lol I'm just a bit frustrated I apologize

I didn't intend to come off as rude

Just don't understand why they're so buggy rn

[spring tangle]

TerminalStuff seems to no longer work when loading an already created save as far as I can tell

Seems OpenLib related

[meager hemlock]

let me do a test in my profile

and if that's the case, I'll send a log

[serene iron]

yeah sorry, i've also been getting incredibly frustrated. Getting burnt out on maintaining these projects when shit just breaks 3 different ways with xyz different mods.

[spring tangle]

From what I could tell at least this time I think it was an OpenLib issue

[meager hemlock]

I joined in My save of 10 days

[spring tangle]

I understand the frustration on your end

[meager hemlock]

everything looks good

[spring tangle]

Yeah we disabled Shisha so

I think it was that

[serene iron]

if you want to truly find the cause, turn on logging on all of my mods and send logs

[spring tangle]

Cus she kept exploding for clients

[meager hemlock]

shisha?
the deer?

[spring tangle]

Probably caused some save corruption and then exploded TerminalStuff

Yeah

[meager hemlock]

let me guess, the gems

[spring tangle]

Prob, they were still on the ship but I bet when we disabled her it caused something with them to explode

[meager hemlock]

it could be that, going into saves with mod changes can generate issues

[modern harbor]

Because either one of the entries in managedBools from TerminalMenuItems was null or the keywordList of one of them was null.

Nom nom.

I only read the error they sent in chat in frustration.

[serene iron]

will probably need the full logs to see if the error was a symptom of another earlier error, but I can add some null handlers in that particular portion of code to not error out in the future

[spring tangle]

Was sad to see you left my Discord btw, I hope you feel better soon and again I'm sorry the way I worded stuff came off wrong earlier and came off as rude, I just really love your stuff and wanna see it work properly I know you work really hard on updating and optimizing it

I can't fault you for bugs happening, it's just a side effect of you optimizing the code I imagine

[serene iron]

yeah sorry, I've not been in the best mood lately and having these issues with my LC mods was just a tipping point.

[spring tangle]

Yeah I get it

[serene iron]

if anyone is available to test this update for the index error fixes please lmk. I tested with the profile from issue#13 on github and it seemed to work okay, but could use some more testing

[meager hemlock]

I 'll do it in a bir

Bit*

[serene iron]

appreciate it

[meager hemlock]

and a bit is rn!

still no camera

[serene iron]

yeah havent had the time to work on that issue

[meager hemlock]

had to press f12 3 times to make it work

[serene iron]

you should be able to tap F12 (or whatever you rebound togglepip to) to get it to show

yeah

[meager hemlock]

oh, what do you want to test?

[serene iron]

i noticed if you press H and press it again the camera stops working

something wrong with my OpenBodyCams implementation I think

[meager hemlock]

also, if you change your suits, the camera stops working too

[serene iron]

good to know

can you double check if using the homebrew cams works as intended?

[meager hemlock]

changed from civilian to 05HottersTart to make it work

[meager hemlock]

homebrew?

[serene iron]

uh, disabling OBC cams

under OpenBodyCams section in config set UseOpenBodyCams to false

[meager hemlock]

this?

[serene iron]

yepp

[meager hemlock]

k, opening the game with that disabled

[serene iron]

awesome, fyi I think as long as you're in the main menu you can change that config item back and forth

[meager hemlock]

working!

[serene iron]

okay so yeah probably an issue with my openbodycams stuff

[serene iron]

the issue I needed to test was for was this one specifically btw #1191974108863414382 message

[meager hemlock]

Is there a way to replicate it?

[serene iron]

I figured out the issue was having suits that had the same name

the profile I was using to test for it is in here https://github.com/darmuh/suitsTerminal/issues/13

[meager hemlock]

oh, I see

[serene iron]

but I guess @spring tangle was saying that clients got the error in their play session today, so would probably help to test for clients as well

[serene iron]

if you're still down to test, I think I fixed the openbodycams issue

at least, it looks fixed on my end

[meager hemlock]

time to test!

forgot to enable back the openbodycam lol

[serene iron]

hahaha fair, I had to triple check it was enabled when I tested

[meager hemlock]

:,]

[serene iron]

[meager hemlock]

019297d6-8ab6-2198-ed38-88eecc359120

I don't know what it could be :,]

[serene iron]

i'll try it on my end

yep see the issue on your profile

[meager hemlock]

at least you found the issue :,]

[serene iron]

well, haven't found why it isnt working lmao

btw are you aware of this error? ```00:20:28.4357514] [Warning: HarmonyX] AccessTools.GetTypesFromAssembly: assembly LethalMoonUnlocks, Version=2.1.9.0, Culture=neutral, PublicKeyToken=null => System.Reflection.ReflectionTypeLoadException: Exception of type 'System.Reflection.ReflectionTypeLoadException' was thrown.
Could not load type of field 'LethalMoonUnlocks.Compatibility.LethalConstellationsExtension+<>c:<>9__4_0' (1) due to: Could not load file or assembly 'LethalConstellations, Version=0.2.3.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies.
at (wrapper managed-to-native) System.Reflection.Assembly.GetTypes(System.Reflection.Assembly,bool)
at System.Reflection.Assembly.GetTypes () [0x00000] in <787acc3c9a4c471ba7d971300105af24>:IL_0000
at HarmonyLib.AccessTools.GetTypesFromAssembly (System.Reflection.Assembly assembly) [0x0000d] in <474744d65d8e460fa08cd5fd82b5d65f>:IL_000D
System.TypeLoadException: Could not load type of field 'LethalMoonUnlocks.Compatibility.LethalConstellationsExtension+<>c:<>9__4_0' (1) due to: Could not load file or assembly 'LethalConstellations, Version=0.2.3.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies.

or rather, is LethalMoonUnlocks dev aware lol

[meager hemlock]

i didn't know that, but I'm not using LethalConstellations in this profile

[serene iron]

oh, so that's probably why it throws that error lol

guess it can be ignored

[serene iron]

okay, think I might have figured out the issue with the cams

[meager hemlock]

yay

[serene iron]

there was some unintended interactions between terminalstuff and suitsterminal 🙂

[meager hemlock]

oh

[serene iron]

yeah hopefully will have this posted later tonight

if you're still around i'd appreciate someone double checking the results of my testing lol

[meager hemlock]

prob 2-3 hours

[serene iron]

you'll need openlib 0.2.4 with these

from what I could see testing the profile code you gave me it fixed the issues with the suits mirrorcam

if all is good on your end i'll wrap them in a zip and upload to thunderstore

[meager hemlock]

ok

doing it rn

[serene iron]

thanks!

[meager hemlock]

:]

and I've checked

so

yay

[serene iron]

awesome!

i'm gonna try to do a lan test really quick as well

[meager hemlock]

and the cam is updating after changing suits, so it seems that everything is ok now!

[serene iron]

glad to hear the cam stuff is fixed, still need to figure out this one for clients it seems :/

[meager hemlock]

oof

[spring tangle]

Ah so it is still reproing for clients

[serene iron]

yeah gonna try to grab a log from this, as I havent gotten one from anyone reporting the issue yet

chat commands still work for the client

weird

ok, not sure if a symptom of LAN testing but it seems like my client instance is detecting that my suit attribute items have already been created for each suit

should be able to fix it but that's really weird since there's no networking portion of this mod

looks like that fixed it

with that fixed, gonna post now

[spring tangle]

I was wondering if maybe it was a thing cus of networked nodes in TerminalStuff honestly

But glad you fixed it

[serene iron]

nah this class is internal to suitsTerminal only. I'm still not convinced it wasn't just a LAN testing symptom

if anyone else experiences the issue please have them post their logs here

and fyi, chat commands do work regardless of that issue

[1.5.2]

• Fixed indexing issue when suits contain the exact same name
  • some backend changes related to this, now tracking unique suit ID numbers
• Fixed similar but unrelated issue where non-host clients were getting an indexing error
• Removed config option for keeping negative suit IDs as this just creates a duplicate of the default suit and nothing else.
• Fixed some compatibility issues with terminalstuff
  • Thank you @meager hemlock for the help in troubleshooting this.
• Minor fix for old terminal command creation

suitsTerminal v1.5.2 (More Suits Addon) (Suits in Terminal)

[serene iron]

for a more in-depth look at what changed see the diff here - https://github.com/darmuh/suitsTerminal/commit/8c001a7d12a04ce6b9228cc9139fb3da8fbe9482

[serene iron]

[1.5.3]

• Adjusted camera mask to use layer 23 instead of layer 30 (in line with most other mods)
  • This should fix issue #15 on github
• Fixed SuitsOnRackOnly config item, thanks CoolLKKPS for the report on github

suitsTerminal v1.5.3 (More Suits Addon) (Suits in Terminal)

[serene iron]

seems to work fine with v65, looks like the "Default" suit got renamed to "Orange Suit" even though it's not orange

@spring tangle this is without moresuits btw

well that's strange, the birthday hat didnt show up till I loaded a second client

[viscid wharf]

oh I didn't see this until now, but yeah, it doesn't call the function to actually apply the suit until someone joins funnily enough

I'm probably gonna make a patch to switch suits for each player as they take control

[rough geyser]

Well, by the way, there are advantages of this mod, every time the game restarts, the suits from the TooManySuits counter move or disappear, and they are always in the terminal :3
@serene iron

[serene iron]

just to be sure you dont think the toomanysuits issue is caused by suitsTerminal do you? With [DontRemove] enabled there shouldn't be any reason for suitsTerminal to affect TooManySuit's functions but I can always look into potential issues between them

on another note, glad to see suitsTerminal is working as expected for you. And feel free to try chat commands as well if the terminal has too many people using it at a time

[hot anchor]

with the recent update of openbodycams, suitsTerminal seems broken

[serene iron]

looking into this with Zaggy for OpenBodyCams compat - https://discordapp.com/channels/1168655651455639582/1199570032196333648

the error is an easy fix but the new update has broken some other things that I need to look into

[serene iron]

openlib update (and OpenBodyCams update) should resolve the above issue https://discordapp.com/channels/1168655651455639582/1265423220102660229/1303923513542971442

[next karma]

got this bug happening again since a week, joiners cannot use the battery charger so I have to disable the rack completely

[serene iron]

does this happen for both host and client?

also can you send a profile code where it happens?

[undone mural]

Not sure what this is related to, but when I have more than two pages of favorited suits, I get the fatal error index page
Same with more than four pages of regular suits

[serene iron]

i'll take a look into this when I get the chance, could you provide a profile code where the issue happens?

[undone mural]

Here you are
01931929-724e-c827-1b6b-4614b86c4e1f

[serene iron]

looking into a few known issues for this particular mod today

[serene iron]

[1.5.4]

• Fixed various issues with favorites menu such as
  • Fatal index error when the config item has 0 favorited suits.
  • Fatal index error due to duplicate favorite items causing extra pages than needed
• Fixed various issues when changing rack setting config items between lobby loads.
• Fixed issue with pagination system that would increase the page counter even if there was not a new page displayed
• Added new config item [PersonalizedFavorites] which will NOT save favorites to the config item.
  • This will save your favorites to a text file located in the following folder 'AppData\LocalLow\ZeekerssRBLX\Lethal Company\suitsTerminal'
  • This file will persist between different mod profiles so you do not need to re-favorite when using a new profile code.
  • If a suit in your favorites does not exist in the current profile it will be ignored (not cause issues)
• Added some more descriptive logging messages under extensive logging.
• Added some warning logs to indicate the mod is not touching the suits rack. If you have another mod taking care of the rack, like TooManySuits, this can be ignored and is just informative.
  • I added this for any potential reported issues with the rack not adjusting properly due to user config error.

suitsTerminal v1.5.4 (More Suits Addon) (Suits in Terminal)

[serene iron]

[1.5.5]

• Updated menu handling to not throw the "Fatal Error" message into the terminal when a suit in the menu is NULL.
  • Will now list the specific item in the menu as **MISSING SUIT**
  • Selecting a missing suit will not do anything.
  • FYI, when host/client do not share the same amount of extra suits added by mods the suits will be desynced between players. This is not something that will be fixable by suitsTerminal.
    • This is due to mismatched unlockable ID numbers from when the suit is added to the game by the mod that adds it.
  • Changed duplicate name handling to show specific suit ID number rather than adding (1) to the name.

suitsTerminal v1.5.5 (More Suits Addon) (Suits in Terminal)

[serene iron]

[1.5.6]

• Switched to new input handling system for advancedsuitsmenu using OpenLib's new TerminalKeyPressed Event
  • Input should now feel one to one with each individual key press.
  • You can no longer hold down a key to scroll through the menu.
  • The MenuKeyPressDelay and MenuPostSelectDelay have been removed as they are no longer necessary.
• Updated to OpenLib 0.2.10

suitsTerminal v1.5.6 (More Suits Addon) (Suits in Terminal)

[signal sky]

Not sure whether or not if it's this mod or the terminal mod but an "e" randomly gets added in places whenever I go to the Home menu after the Suits menu

Theeeeen there's this also weird... bug... with the Help menu for the Suits menu, causing like terminal softlocks and the game thinking the Suits menu is always open? Which also might be related to TerminalStuff, but also OpenBodyCams maybe? (I also got the 2nd shown error that I now can't reproduce when I was trying to figure out what causes anything)

Stack trace:
suitsTerminal.PictureInPicture.TogglePiP (System.Boolean state) (at ./Visual Stuff/PictureInPicture.cs:151)
suitsTerminal.AdvancedMenu+<SuitsMenuExit>d__43.MoveNext () (at ./Terminal Stuff/AdvancedMenu.cs:481)
UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <e27997765c1848b09d8073e5d642717a>:IL_0026)```

Stack trace:
OpenBodyCams.BodyCamComponent.RevertCullingOverrides () (at E:/Development/Lethal Company/Projects/OpenBodyCams/OpenBodyCams/BodyCamComponent.cs:1174)
OpenBodyCams.BodyCamComponent.RevertLastOverrides () (at E:/Development/Lethal Company/Projects/OpenBodyCams/OpenBodyCams/BodyCamComponent.cs:384)
OpenBodyCams.BodyCamComponent.BeforeRenderingAnyCamera (UnityEngine.Camera camera) (at E:/Development/Lethal Company/Projects/OpenBodyCams/OpenBodyCams/BodyCamComponent.cs:414)
OpenBodyCams.Plugin.BeforeRenderingAnyCamera (UnityEngine.Rendering.ScriptableRenderContext context, UnityEngine.Camera camera) (at E:/Development/Lethal Company/Projects/OpenBodyCams/OpenBodyCams/Plugin.cs:363)
OpenBodyCams.Patches.PatchHDRenderPipeline.BeforeCameraRenderingHook (UnityEngine.Rendering.HighDefinition.HDRenderPipeline+RenderRequest request, UnityEngine.Rendering.ScriptableRenderContext context) (at E:/Development/Lethal Company/Projects/OpenBodyCams/OpenBodyCams/Patches/PatchHDRenderPipeline.cs:126)
UnityEngine.Rendering.HighDefinition.HDRenderPipeline.Render (UnityEngine.Rendering.ScriptableRenderContext renderContext, System.Collections.Generic.List`1[T] cameras) (at <b8abf62aeac646cea5c5cde032ff9314>:IL_04A9)
UnityEngine.Rendering.RenderPipeline.InternalRender (UnityEngine.Rendering.ScriptableRenderContext context, System.Collections.Generic.List`1[T] cameras) (at <e27997765c1848b09d8073e5d642717a>:IL_001C)
UnityEngine.Rendering.RenderPipelineManager.DoRenderLoop_Internal (UnityEngine.Rendering.RenderPipelineAsset pipe, System.IntPtr loopPtr, UnityEngine.Object renderRequest) (at <e27997765c1848b09d8073e5d642717a>:IL_0046)```

[spring tangle]

second time you type it works
repros after exiting and re-entering the terminal as well

[serene iron]

Hmm, you might wanna revert to 1.5.5 as I’m not gonna be able to look into this today. The only change between 1.5.5 and 1.5.6 is leveraging the new input event from OpenLib. I didn’t experience any of these issues last night when I was testing so will need your profile code to see if I can reproduce the issue

[serene iron]

Do you experience this as the host? I’ve never had this issue before and I’m not sure why it would affect only the suits keyword. Also an fyi if you’re gonna stream today considering the errors endoxicom posted I’d suggest maybe sticking to 1.5.5 for suitsTerminal

back to sleep I go

[serene iron]

line that throws error for me to look at later

[signal sky]

felt

019383b8-38b3-b580-a51e-6b320d41f3be

code just in case

[spring tangle]

I did yeah I was solo testing some things

[spring tangle]

Yep downgrading to 1.5.5 fixes it for now, sleep well and I hope to see you fix it later ^^

[serene iron]

Yeah I’ll see if I can find a fix later tonight. I was mostly saying I couldn’t look today because I had plans not that I’m sleeping all day

[spring tangle]

😂

[serene iron]

i think i fixed it

tested just now in a version of lunxara's profile too, not seeing any issues so i'm going to post this hotfix now

[1.5.7]

• Fixed an error related to using the help menu that would throw errors related to the PictureInPicture camera.
  • You can now toggle the favorites menus from the help menu.
• Fixed issue that would cause additional text to leak into other pages from inputs in the advancedsuitsmenu
  • This also fixes the suits command sometimes not working (there was actually an extra empty space character in the input section for some reason lol)
• Removed some old redundant code from when I initially moved this mod to Openlib
• Added logic to make the terminal text caret (the blinking line) transparent when in the advancedsuitsmenu and return to the color it was when you first spawned.
  • If you have mods that change this color (like darmuhsTerminalStuff) it will not update to the latest customization refresh but only what it was when you first spawned.
    • In regards to darmuhsTerminalStuff, i'll add some compatibility for this on terminalstuff's side soon.

Thanks @spring tangle and @signal sky for the reports!

suitsTerminal v1.5.7 (More Suits Addon) (Suits in Terminal)

[spring tangle]

Glad we could help you out bud ^^ nice to see it not complain anymore the first time you type in suits XD

[serene iron]

yeah all of the issues were kinda interconnected. At first I was worried some shit broke with openlib's keyword parser lol

[spring tangle]

Lmao, if it was that then 1.5.5 would have had the same issue

[serene iron]

yeah true (unless openlib's update caused some issues, which it did not). And yeah I considered 1.5.5 pretty stable

[viscid wharf]

out of curiosity, what was causing the null deref on the body cam's camera? I wanna evaluate if it's something I should account for on my side

[serene iron]

it was due to transitioning from the the help page (which has the camera disabled) back to any page that had the camera. I think either my openlib update or a somewhat recent openbodycams update started having the blankedset event actually get called which is set to destroy the bodycam game object. So when my menu was trying to get the camera it didn't exist

I figure it could 100% be the recent OpenLib 0.2.10 update that caused it (since I did change some things for openbodycams compat in there), but it was not the main root cause of the issues they were experiencing

those were mostly just related to how I was disabling the input field and re-enabling it when transitioning from the menu back to the regular terminal vs quitting the terminal

hope that makes sense lmao

[viscid wharf]

huh, why does it need to destroy the body cam when it gets blanked?

kinda makes sense though, I definitely didn't plan for the body cam components to get destroyed lol

at least as far as making the nres make sense

[serene iron]

Honestly it doesn't need to. I think when I set it there I wanted to destroy the bodycam any time it wasnt in use to try to save on performance but it wasn't working

I may change the behavior in the future but yeah it's something I noticed after sifting thru the logs lol

[viscid wharf]

should be fine to deactivate or disable it, but yeah as long as you're recreating it, destroying it is in theory fine

[serene iron]

normally the bodycams only would get destroy at my Terminal Disable event (when the lobby was closed)

[serene iron]

yeah they get recreated if they are detected as not existing, the portion of the code where they were erroring out in suitsTerminal was because I didnt intend on that happening lmao

[viscid wharf]

weird to me if the body cam is sending the blanked event if its target isn't becoming invalid though, are you destroying its attachment point?

[serene iron]

nah I dont think so

[viscid wharf]

huh

when did that event fire then?

[serene iron]

this is all that changed in openlib https://github.com/darmuh/OpenLib/commit/94f073256eae1c8830f9d8b9194610cb6d1f0047#diff-222abdf1b331ea2543f70b1329e40ecf1b4470c4c9d74632a510981d2d329deb

I figured setting forceenablecamera to false was allowing the camerablanked event to actually work

[viscid wharf]

wow that's a big commit

by my standards anyway lol

[serene iron]

you can actually see it in action if you have the latest suitsTerminal with all of the debugging stuff enabled

[viscid wharf]

I did change some things with how the status updates worked internally that might've affected that though

that was like a couple weeks to a month ago I think

[serene iron]

lmao yeah that's a relatively moderate commit for me

[serene iron]

[serene iron]

[10:08:38.3712349] [Info   :suitsTerminal] OpenBodyCams detected, using OBC for Mirror (state:False)
[10:08:38.3712349] [Info   :   OpenLib] OBC - OpenBodyCamsMirrorStatus() state: False
[10:08:38.3712349] [Info   :   OpenLib] OpenLib OBC mirrorcam set to state: False
[10:08:38.3712349] [Info   :   OpenLib] OBC - Setting Mirror Status: [False]
[10:08:38.3727696] [Info   :   OpenLib] OBC - CamIsBlanked: True
[10:08:38.3727696] [Info   :   OpenLib] Attempting to destroy residual TerminalMirrorCam

you can trace those logs to a handful of different methods lmao

[viscid wharf]

probably was this

https://github.com/Zaggy1024/LC_OpenBodyCams/commit/4a08612c09a1b6de43f6e6bb24908a0b3ceaa803

don't look at the diff 🙈

[serene iron]

ooooo yeah, that might be it

because I remembered the blanked stuff never worked for me and I just figured it's because of my implementation

[viscid wharf]

I think I broke it at one point though, it worked initially I thought

I may be wrong

[serene iron]

I remember it working for me in some ways but not in the ways I wanted? Idk it's been forever lmao

[viscid wharf]

so it's happening when you're setting it to not be force enabled I guess? that could make sense, I think with no renderer it would consider itself blanked when that happens

yeah the event should work fine now thankfully

it was messing up some stuff in my pip lol

[serene iron]

yeah basically that, so eventually I might go remove the destroying bit for the blanked event

for now it is literally destroying and building a new camera each time it is shown/hidden lmao

[viscid wharf]

yeah it's probably much cheaper to just disable it, the body cams have to instantiate a bunch of stuff

when you disable the component, it should disable the camera as well

[serene iron]

yeah I definitely agree with you there

it was more-so just leftover stuff I forgot about

[tulip apex]

hello there, im having a minor problem
I found out if I have bought some suits, when I get fired, the suits keep appearing on the terminal, with the [EQUIPPED] tag, even tho I should not have the suit unlocked
trying to equip it gives me a "[Error :suitsTerminal] suit is null!" on the console and nothing happens

It seems to behave that way until I buy any suit on the store or recreate the lobby, and these "ghost" suits disappears
I can equip any other free suit, but trying to equip these unlockable ones does nothing

Was trying to make it work with KeepUnlocks, but I was having the same problem, except it would unlock all saved suits after buying a new one

Anyway, got this little clip of the problem, using the MoreSuits default ones as examples, all of them buyable for some credits, after getting fired having bought the "Glow" and "Slayer" suits, they dont let me use until I buy the "Smile" one, and the other ones disappear

for sure could be a problem on my end with some configuration or something I broke while testing, but was unable to find out what exactly

[serene iron]

definitely looks like an issue on my end I'll need to fix

thank you for the detailed bug report 💜

[tulip apex]

No worries, glad I could be of help, and if you need some more logs, configs or testing feel free to ask

[sacred goblet]

whenever using the suits terminal none of my clients or me can actually navigate the menu

is there a known conflict that could cause that?

downgrading to 1.5.5 fixed it for now 😭

[kind finch]

I have the same issue as with Lilo here, the none of the navigation buttons for suitsTerminal seem to do anything above version 1.5.5 (on versions with the new input handling system for advancedsuitsmenu) after opening up the terminal menu with the "suits" command, i can still hear the keyboard audio for the button presses in game but thats all, the inputs dont actually do anything. I tested this on a very minimal new testing profile (pretty much only the dependencies for this mod and a single suit mod pack, 6 mods in total.) and it still happens. The only error i can see in the console is "[Error : Unity Log] Trying to add Caret (TMPro.TMP_SelectionCaret) for graphic rebuild while we are already inside a graphic rebuild loop. This is not supported." when opening up the terminal for the first time. Here's the profile code that i was testing with: 0193a79d-d5cb-e7b5-99e6-6487e14c3158

Here is what the issue looks like in game. You can hear the buttons im trying to press here (arrow keys, h, backspace, enter) but nothing is happening.

Oh and downgrading to 1.5.5 works fine for me too to "fix" the issue.

[spring tangle]

This is odd, my group and I have been using 1.5.7 without any issues

[solar solstice]

im having this exact issue aswell

[final forum]

caret issue is the vanilla game issue that you can ignore

[sacred goblet]

exactly what I tried too

I'm pretty sure that "Trying to add caret (TMPro..." error is a vanilla one

not sure though but I've seen it long before this was an issue

I tried with a base profile, no config, keybinds, or anything set up, complete vanilla and it won't work 😭

@spring tangle maybe you have an additional mod that we don't have thats allowing it to work

[spring tangle]

I can't think of any

[signal sky]

(it's lack of darmuh's TerminalStuff)

[serene iron]

oh dear, I think I know the reason for this

[serene iron]

[1.5.8]

• Fixed issue with advanced suits menu not working since switching to the new input handling system when darmuhsTerminalStuff was not present.
• Added a check for TooManySuits. If present, this mod will not adjust the suits on the rack in anyway (even if DontRemove is set to false).
• Fixed issue where suits that were supposed to be on the rack were out of position in various ways.
• Fixed issue where, after being fired, paid suits would break the advancedsuitsmenu until a suit had been paid for.
• Fixed issue where sometimes the [EQUIPPED] tag would not show for the suit you're currently wearing when first opening the suits menu.

[serene iron]

pretty sure the issue is fixed now. Thanks again for the detailed report 🙏

[tulip apex]

can confirm its fixed now ty for that

[serene iron]

suitsTerminal v1.5.8 (More Suits Addon) (Suits in Terminal)

[vapid burrow]

Has anyone had an issue where one client can’t use the suits terminal? I can’t figure this out, everyone can use them except one client I have

[serene iron]

Are you using terminalstuff? I noticed a friend was having a similar issue when I was playing and realized it was due to the last terminal node being the suits menu for them so when they start using the terminal the menu looks like it's open (but it's not)

[zenith horizon]

this happens when i have picamera enabled

[serene iron]

please turn this setting on, reproduce the issue, and provide updated logs

typically if that issue happens it means the menu failed to exit properly

[serene iron]

are you able to easily reproduce the issue? Is it just entering the suits menu and closing the terminal?

[zenith horizon]

yes

i just enter the suits command, and then exit the terminal

[serene iron]

can you send your profile code?

[zenith horizon]

alr

0193db91-29bd-d7f6-4110-49ea19461edc

[vapid burrow]

Yes we are using terminal stuff!Is there something we can do to fix it?

[serene iron]

either make sure when you exit the suits menu to load another page before you leave the terminal or set this to a keyword so it always opens up a page when you start using the terminal

I do plan on trying to add a fix for it soon, but that will work in the meantime

disabling networked nodes might fix it as well, if you dont want to have a start page

[serene iron]

btw, if you want to avoid this issue you can add OpenBodyCams and enable the config setting to use it's camera instead. This issue is specific to my homebrew cams

I believe you can even configure openbodycams to not add a camera to the ship monitor at all if you dont want to use the mod itself (but still get the camera for suitsTerminal)

never knew about this btw, very neat

[serene iron]

oh wow, think I found the issue. Surprised this is the first i'm hearing of it (must not be a lot of homebrew cam users)

[serene iron]

[1.5.9]

• Fixed issue with homebrew camera not updating LOD shadow level due to an early return that was added in 1.5.7 to fix another issue.
  • Thank you @zenith horizon for the report and help with troubleshooting the issue.
• Added support for networked nodes when using darmuhsTerminalStuff.
  • This should fix an issue where it appeared you were in the menu but the menu had not been started by the current player.
  • Should also now sync the terminal display for other players when you are navigating the menus

suitsTerminal v1.5.9 (More Suits Addon) (Suits in Terminal)

fuck me, i just noticed something I need to change after uploading

the terminalstuff compat wont work in 1.5.9, give me a sec

[1.5.10]

• Fixed darmuhsTerminalStuff GUID

suitsTerminal v1.5.10 (More Suits Addon) (Suits in Terminal)

wait fuck LMAO hold on, one more version update

last one

[1.5.11]

• Fixed soft compat for darmuhsTerminalStuff

too quick to hit upload today

suitsTerminal v1.5.11 (More Suits Addon) (Suits in Terminal)

[serene iron]

[1.5.12]

• Fixed soft compat for darmuhsTerminalStuff (again)
• including correct dll file, 1.5.11 release looks to have had 1.5.10

suitsTerminal v1.5.12 (More Suits Addon) (Suits in Terminal)

[spring tangle]

Please tell me I don't need to wait on the update

Lol

[serene iron]

you use terminalstuff so nah it doesnt really matter for you

issue was for people who dont use it

[spring tangle]

I figured but wanted to be sure lol

[rugged breach]

I'm not 100% but I think either toomanysuits or suitterminal is causing anyone that plays with me suits to go off the rails, literally

Even with the same configs, for anyone that isn't the host, the suits continue off the rack

it's probably toomanysuits when i rly think about it

[serene iron]

Does everyone have the same mods? Yeah in one of the latest updates I made it so if TooManySuits is detected the rack shouldn’t be touched by suitsTerminal at all

That said, if it’s an older version of TooManySuits then that detection might not work because the GUID for it was changed a few months ago

[rugged breach]

yeah, everyone had the same mods each time it happened

it's the latest version of both suitsterminal and toomanysuit

[serene iron]

Gotcha, yeah this mod shouldn’t be touching the rack in that case. Just to double check though you can make sure DontRemove is enabled in suitsTerminal. That will leave the rack untouched no matter what

If there’s any issues with the rack still then all I can say is “not it” 😂

[dreamy sage]

Is there something I'm doing wrong? This is my mod list, I don't have many mods at all, but I'm only able to see one page of suits with toomanysuits installed. Is there something wrong?

[serene iron]

This isn’t the mod thread for TooManySuits. That said, it doesn’t look like you have any suit mods installed (custom suits) so everything looks about right as far as I can tell. You just have the default suits that come with more suits