#TooManySuits

1236 messages Β· Page 2 of 2 (latest)

rare granite
#

awesome

hidden nebula
#

throw this into your plugins if you wanna test, I still need to test if multiplayer is all good or not.

my friend is getting on soon.

Oh and the asset bundle is inside the dll as an embedded resource so you can delete SuitSelect

πŸ“Ž TooManySuits.dll
rare granite
#

Did you try to tackle the moving text?

hidden nebula
#

I will probably never fix that

#

I position it based on the bounds of the ship, which are not updated when the ship moves

#

so basically I have no way of actually knowing where the ship is

#

the position is offset from the ship bounds

rare granite
#

but..

hidden nebula
#

which it eventually moves to

#

when it lands

rare granite
#

you see that isn't the issue there

# 
    private void SetPageText()
    {
        var textMesh = Hooks.SuitPanel.GetComponentInChildren<TextMeshProUGUI>();
        textMesh.text = $"Page {_currentPage + 1}/{Mathf.CeilToInt((float)_suitsLength / _suitsPerPage)}";
    }```
#

this is rn

hidden nebula
#

Whats wrong with that

rare granite
#

hold on

hidden nebula
#

Yeah

rare granite
#

yeah thats not what I'm talking about hold on

# 
private void SetPageText()
    {
        var textMesh = Hooks.SuitPanel.GetComponentInChildren<TextMeshProUGUI>();
        if (StartOfRound.Instance.shipHasLanded)
        {
            textMesh.text = $"Page {_currentPage + 1}/{Mathf.CeilToInt((float)_suitsLength / _suitsPerPage)}";
        }
        else
        {
            textMesh.text = $""; // makes it blank if the ship is moving
        }
    }
    [HarmonyPatch(typeof(StartOfRound), "ArriveAtLevel")]
    public static class smunguss
    {
        static void postfix()
        {
            SetPageText(); // calls it when the ship goes to the level
        }
    }```
#

maybe add another call to it right after it lands so you don't have to press a key for it to appear again

#

so its still there but this should just make it blank automatically when you start landing on a moon

#

you could also add another 2 calls to it for when the ship leaves (automatically or not) and when it shows the endgamestats

hidden nebula
#

seems like a lot of effort for a visual bug that causes no harm

rare granite
#

I mean yeah but I have ocd probably so I do that sometimes lol

hidden nebula
#

No one's ever really cared about it, and setting it to be nothing isn't really a fix for the issue, and it would require a bunch of hooks to functions to determine if we'd landed, took off, or in space etc

hidden nebula
#

I do love ternary operators

rare granite
#

never used ternary operators

hidden nebula
#

They're pretty cool

#

but this is easier to remember:

private void SetPageText()
    {
        var textMesh = Hooks.SuitPanel.GetComponentInChildren<TextMeshProUGUI>();
        if (StartOfRound.Instance.shipHasLanded)
        {
            textMesh.text = $"Page {_currentPage + 1}/{Mathf.CeilToInt((float)_suitsLength / _suitsPerPage)}";
            return;
        }
        textMesh.text = $""; // makes it blank if the ship is moving
    }

the is only set to "" if statements condition is never met, because the function doesn't return;

#

just cleans up the code a little bit thats all

rare granite
#

wouldn't that set it to be blank always since its set after?

hidden nebula
#

No, because it returns before it gets to that

#

so the function basically "stops"

rare granite
#

oh I didn't see the return

hidden nebula
#

also you can put [HarmonyPostfix] to the method that way it doesn't need to be called postfix

rare granite
#

oh ok, I know you can do that but I didn't understand why

#

so then you can call it whenever and its called at the hook

hidden nebula
#

What do you mean?

rare granite
#

you can call the method whenever then yeah?

#

since its not just PostFix

#

but ig the class itself already would differentiate it

hidden nebula
#

Well the attribute tells Harmony that its a postfix, and yeah I guess you can call the method yourself but idk why you'd want to do that

#

the whole point is that its called after or before the function its hooking

rare granite
#

yeah but if you use the method for something else ig

hidden nebula
#

Sent out an official update to thunderstore, let me know if there are any bugs

rare granite
#

πŸ‘

#

the spacing doesn't change with the value, is that intentional?

hidden nebula
#

the spacing is copied directly from the vanilla code

#

if you go over 20 it'll go over Β―_(ツ)_/Β―

#

my mod is not supposed to fix that issue by squishing them together, like I said.

Its pagination.

wraith elm
#

Any plans of incorporating TooManySuitsWorldButtons functionality into toomanysuits?
It kinda broke now

hidden nebula
#

the mod developer will need to update his mod to be compatible with my update.

lunar sandal
charred spruce
#

setting the suit gameObject to false for some reason causes issues with actually equipping it

lunar sandal
#

huh, that's weird...

#

what if we disabled the Renderer + Interact component instead of disabling the GO?

charred spruce
#

basically disables the SkinnedMeshRenderer and MeshRenderer components specifically rather than the gameobject

#

I imagine you could prob incorporate a similar fix for TooManySuits

lunar sandal
#

πŸ‘€

charred spruce
#

if that is the issue. I'm not 100% certain

lunar sandal
#

I'll give it a shot tmrw probably

charred spruce
#

I just remember trying to figure out if my mod caused the issue a while back and was happy to find out it wasnt me lol

lunar sandal
#

thank you for the lead though

charred spruce
#

would be nice to see this mod work with no issues with mine catsmiley

lunar sandal
charred spruce
lunar sandal
#

yup :)

#

will do

hidden nebula
#

I appreciate you making a pull request

lunar sandal
#

you're welcome πŸ™‚

hidden nebula
#

I just merged it

lunar sandal
#

got some more PRs in the pipeline if you wanna wait for a release

hidden nebula
#

Ill push an update to TooManySuits on thunderstore as well

hidden nebula
lunar sandal
hidden nebula
#

That is insane

#

Does that actually work?

lunar sandal
#

yeah lol

hidden nebula
#

What

#

the

lunar sandal
#

:D

hidden nebula
#

I literally tried that

#

LOL

#

Thanks bro

#

appreciate the help

lunar sandal
#

I saw it in Unity Explorer and was like "huh?"

#

np :D

hidden nebula
#

Yeah I saw it so many times, I just could never get it to work properly

#

like the offsets from where the ships object starts were different for some reason

lunar sandal
hidden nebula
#

Sounds good, just let me know when you're done and ill make a release

#

I think I remember why I didn't visibly hide the suits

#

because they would still be there, you could still select them even while they were invisible

#

thats why I went with disabling the whole object

lunar sandal
#

yeah, that was a bit of a pain. Disabling the Interact component wasn't enough. I also had to disable the collider

charred spruce
#

interesting, wonder why I didnt need to do that for suitsTerminal Think I'm guessing it's because I set disableObject to true in my case? Is that property available for unlockableSuit?

#

worth noting that property is different than gameObject.SetActive

lunar sandal
#

idk much about Unity, but that member doesn't exist on my end.

charred spruce
#

hmmm, must have been a difference in how we access the suits then. It's a property of AutoParentToShip which is what my code I linked earlier accesses for each suit

#

i doubt there's much of an impactful difference from the user's standpoint though

lunar sandal
#

@hidden nebula would you mind adding a license to the repo? MIT maybe?

hidden nebula
lunar sandal
#

thanks

hidden nebula
lunar sandal
#

It uses <PackageReference>s now, so no need to copy files over to the Includes folder.
Also included a zip MSBuild target, so you can just build in the Release configuration (dotnet build -c Release) and it will create bin/Release/netstandard2.1/package.zip, ready to upload to Thunderstore.

#

imma go make food now, feel free to @ me if you have any questions

deft crown
light hawk
#

its getting spammed when i get in the game and exit to main menu
it stopped if i get back in a game

image.png
#

v1.1.1

#

im not sure if this is game breaking or not btu its just concerning when u just wanna do a quick reopen lobby

hidden nebula
#

Ill take a look in a minute

#

how do I reproduce this issue?

hidden nebula
light hawk
#

open the game, open a new/old save
exit to main menu
and there the error poppep up

hidden nebula
#

Ill take a look now

#

thanks bro

#

Ah okay

#

I was confused what was going on

#

because a null check is right there

#

but I assume AutoParentToShip is expecting our game object

#

to be valid

#

which it might not be in the main menu

hidden nebula
#

Okay I found the issue and its (not really a problem) just causes console spam which is annoying.

I will fix it now.

hidden nebula
light hawk
hidden nebula
#

@light hawk I pushed the update

#

You'll have to wait for thunderstore to fully update before you can download it

light hawk
#

thankk uu
ill test later normalcat

hidden nebula
#

πŸ™

#

Sorry for the inconvenience, I should've caught that in testing (I didn't have console open)

jagged knot
hidden nebula
worldly talon
lunar sandal
worldly talon
lunar sandal
#

I actually just finished adding support for controller binds lol

worldly talon
lunar sandal
#

yeah, I'll do both because the default keybinds might not be obvious to new players

worldly talon
lunar sandal
#

what do you think of these defaults:

  • next page: north button
  • previous page: east button
#

I don't play controller so I have no idea if these clash with default binds

worldly talon
#

west and east cyle inventory

lunar sandal
#

dpad buttons you mean?

worldly talon
#

oops sorry yeh

lunar sandal
#

ye

worldly talon
#

i misread

#

i believe north is to move furniture so that should be okay

lunar sandal
#

ah yeah it is

worldly talon
#

or is it east lol

#

i cant remember

lunar sandal
#

it's north

#

just tested it :P

worldly talon
#

and LB and RB (5 and 6) i believe, we usualy maps those and the left stick press to emote wheels and stuff

#

but Y and B should be fine when at the rack

#

oh wait

#

B will drop items I think

lunar sandal
#

oh

#

that might be a problem hmm

worldly talon
#

so if holding an item while cycling it will drop whatever is highlighted lol

#

ye

lunar sandal
#

wait how do you even use the terminal on controller lmao

#

do you just... not? :D

worldly talon
#

lol

lunar sandal
#

oh sick

worldly talon
#

oh maybe bind the pages to the triggers??

lunar sandal
#

left trigger sprints

worldly talon
#

yeh but while standing there at the suits should be ok?

lunar sandal
#

oh yeah

#

I could do that

#

ig it would also toggle your flashlight (or whatever item you're holding) when pressing right trigger

worldly talon
#

crap the right trigger uses your primary item though

#

yeh lol

lunar sandal
#

but probably not an issue since most ppl configure suits early on before buying any items

worldly talon
#

thats true

#

I would do the triggers with optional keybinds then

#

it would be good

lunar sandal
#

well they're gonna be bound by default to the triggers

#

or would you rather not have default controller binds?

worldly talon
#

I would personally just so its easy to use out of the box lol

lunar sandal
#

yeah that's what I'm thinking

worldly talon
#

well mainly my girlfriend uses controller and a couple friends

#

my gf said that sounds good enough for her lol

lunar sandal
#

haha sounds good

worldly talon
#

thank you!

lunar sandal
#

you're welcome :)

hidden nebula
#

peelz why don't you have modder role?

lunar sandal
#

oh uh, I haven't really published any meaningful mods πŸ˜…

#

just contributing to existing mods here and there for now

lunar sandal
#

@worldly talon update should be live soon πŸ™‚

serene parcel
#

Why is InputUtils a dependency ?

#

Making InputUtils a dependency after removing the keybinds xd

#

Keybinds are planned to come back as optional? Or forgot to remove, after plans have changed?

dawn galleon
#

Are you sure it just doesn't have the option to use binds or the actual buttons?

serene parcel
dawn galleon
#

Prolly an oversight

serene parcel
#

Can happen, but I like the update

dawn galleon
#

It was probably already a dependency and the dev forgot to remove it, tbh it's not a big deal as most mods use it anyways

serene parcel
#

In the previous version, it wasn't a dependency

#

Is just likely, that it was planned and forgotten

serene parcel
#

Never liked how more suits squeezed the suits (without moving the actions, to wear the suit you are looking at) and always turned MakeSuitsFitOnRack off

viscid marlin
#

I hope they add the keybinds back. I liked using my keyboard to switch the suit pages.

serene parcel
#

I like the new way, it's straightforward and minus 2 keybinds, if you already have a lot because of mods,
but to have it optional wouldn't hurt

lunar sandal
hushed orbit
#

for some reason i cant change the page with the arrows

lunar sandal
hushed orbit
wraith elm
#

can it be mAtTE iNsTeAD oF gLoSsY?

image.png
lunar sandal
# wraith elm can it be mAtTE iNsTeAD oF gLoSsY?

It looks like that because it uses a lit shader, so it can interact with the lighting in the environment (mostly so that it doesn't stick out like a sore thumb when the lights are turned off).
There's no official HDRP lit shader for TextMeshPro, and I had to use some experimental shader that's been in development limbo for 2+ years. I can probably take another crack at it, but no promises.

wraith elm
#

Other than that the mod is a godsent. Especially with the new in world buttons. Been using the 1.0.9 version for way too long

lunar sandal
serene parcel
#

feature idea, if it's possible, config option to enable one suit set per page (or two pages, if the set has many suits)

lunar sandal
serene parcel
#

Guessed it

lunar sandal
serene parcel
#

I personally use a structure like this to have suits on specific pages:

moresuits
  - Rack1
    - moresuits
      - 6 suits (+ 7 Vanilla)
  - Rack2
    - moresuits
      - 13 suits
  - Rack3
    - moresuits
      - 13 suits
  - !less-suits.txt
wraith elm
wraith elm
lunar sandal
glacial breach
#

any way you can add an option to move the whole rack entirely?

serene parcel
#

Sounds like something for another mod. You could post it in #1188298686560739389, if it doesn't exist already.