LC_API | Lethal Company Modding | Page 2

jagged trout Dec 25, 2023, 4:51 AM

#

I'll actually just rename it to ReceivedNetworkMessage and have NetworkMessage be the attribute

#

unless you have any other ideas

main minnow Dec 25, 2023, 4:52 AM

#

it's a tricky one

#

I think those are good names

jagged trout Dec 25, 2023, 4:52 AM

#

I could make the signature always just ulong, T maybe?

#

Lemme see

main minnow Dec 25, 2023, 4:52 AM

#

jagged trout I could make the signature always just ulong, T maybe?

yeah, does the NetworkMessage actually give any helpful info?

jagged trout Dec 25, 2023, 4:53 AM

#

main minnow yeah, does the `NetworkMessage` actually give any helpful info?

well it describes what the ulong is lol

main minnow Dec 25, 2023, 4:53 AM

#

True. that's definitely better

jagged trout Dec 25, 2023, 4:53 AM

#

but docs

#

we will rely on docs

main minnow Dec 25, 2023, 4:54 AM

#

ummmmm

jagged trout Dec 25, 2023, 4:54 AM

#

readthedocs

#

Ok it does still work as ulong, T

#

future me's problem when people ask questions

main minnow Dec 25, 2023, 5:00 AM

#

You could put the doc comment on the abstract method if you implement it as class annotation rather than method annotation

#

people can still whack a class definition anywhere

#

[NetworkMessage("MyActionName")]
public class MyAction : BaseAction<Vector3>
{
    public override Handle(ulong senderId, Vector3 payload) {
    { 
        ...
    }
}

jagged trout Dec 25, 2023, 5:04 AM

#

main minnow people can still whack a `class` definition anywhere

yeah, but it's a slightly odd

main minnow Dec 25, 2023, 5:05 AM

#

jagged trout yeah, but it's a slightly odd

sure, it might be slightly odd, but it future-proofs you

#

if you ever want people to be able to customise their handlers more than just the callback

#

you can add extra stuff to the class

#

if you're just decorating a method, that's making a huge assumption that users will never want more control than the callback

jagged trout Dec 25, 2023, 5:06 AM

#

Well there's nothing else to control really

main minnow Dec 25, 2023, 5:06 AM

#

that's what we think for now

jagged trout Dec 25, 2023, 5:06 AM

#

I wanted them to be able to access private properties in a class

main minnow Dec 25, 2023, 5:06 AM

#

😂

#

you ... still can

#

can't you?

#

ah yeah, private instance props

#

I see what you're getting at

#

but shouldn't a network message handler always have static context

jagged trout Dec 25, 2023, 5:09 AM

#

I meant private statics lol

#

but yeah static always

main minnow Dec 25, 2023, 5:09 AM

#

oh yeah then no issue

#

classes can access private static members from enclosing classes

jagged trout Dec 25, 2023, 5:10 AM

#

I personally just didn't want to make a class for every network message Iw anted

#

I think it's just a lot of unnecessary classes tbh

main minnow Dec 25, 2023, 5:10 AM

#

but they're not gonna be in the root namespace so why does it matter

#

i could say the way you're proposing is a lot of unnecessary functions

#

Best of both worlds

#

just do both

jagged trout Dec 25, 2023, 5:12 AM

#

main minnow i could say the way you're proposing is a lot of unnecessary functions

Well classes would require a function to handle

#

I also see no future case for having it in a class

#

as you do everything in the handler itself

main minnow Dec 25, 2023, 5:12 AM

#

jagged trout Well classes would require a function to handle

yeah, but they ensure you get a compiler error if you set the wrong signature on your handler method

#

what about metadata like who is allowed to send the message

jagged trout Dec 25, 2023, 5:14 AM

#

that would be defined in the attribute itself

#

like it is with rpcs

main minnow Dec 25, 2023, 5:16 AM

#

I'm not entirely convinced, but that's just how I am

#

Go for the method attribute syntax

jagged trout Dec 25, 2023, 6:16 AM

#

I've actually tried both and it seems incredibly difficult because of the generic

#

Since I need to register it with the generic and an Action<ulong, T>

#

idek how to actually get a generic attribute off of a type

#

since you can't GetAttribute(Attribute<T>)

#

Action action = method.CreateDelegate(typeof(Action).MakeGenericType(typeof(ulong), method.GetGenericArguments()[0])) as Action; no idea if this will work, but even if it does, this is cursed.

main minnow Dec 25, 2023, 6:39 AM

#

interface IAction<out T> where T : class
{
    public void Register(string uniqueName);
}

abstract class BaseAction<T> : IAction<T> where T : class
{
    public abstract void Handle(ulong senderId, T payload);
    
    public void Register(string uniqueName)
    {
        Networking.RegisterMessage<T>(uniqueName, Handle);
    }
}

#

Does that do the trick?

#

Then wherever you're collecting the attribute you can

#

IAction<object> whatever = ...;
whatever.Register();

#

even tho the calling scope only knows it's containing an object type, the instance will know its actual T so will call the right thing

#

@jagged trout Thoughts?

jagged trout Dec 25, 2023, 7:24 AM

#

[NetworkMessage(typeof(TestClass), "TEST_THING")]
internal static void Test(ulong senderId, TestClass thing)
{
    Log.LogInfo("GOT TEST MESSAGE");
    Log.LogInfo(thing.value);
}

[NetworkMessage(typeof(TestClass), "TEST_THING2")]
internal class BigTest : NetworkMessageHandler<TestClass>
{
    public override void Handler(ulong sender, TestClass message)
    {
        Log.LogInfo("GOT TEST MESSAGE");
        Log.LogInfo(message.value);
    }
}

I got both of these working

#

I had to define the message type in the attribute

#

I will probably make it the 2nd argument if I don't find a way around it

#

getting those generics was very odd

#

Apparently c# attributes don't support generics as expected I don't think

#

I did try a register method on the attribute class, but I couldn't get it working

#

I'll see if I can pull the type from the params though

#

but tomorrow

#

it's 2:30 am and I'm tired

#

gn

main minnow Dec 25, 2023, 7:46 AM

#

jagged trout I did try a register method on the attribute class, but I couldn't get it workin...

yeah, the interface with covariant type param is important for that to work

main minnow Dec 25, 2023, 7:46 AM

#

jagged trout gn

sleep well!

grave saffron Dec 25, 2023, 11:40 AM

#

#

What is this?

jagged trout Dec 25, 2023, 3:55 PM

#

Seems like somehow your broadcast happened before HudManager.Instance was set @grave saffron

#

https://github.com/u-2018/LC-API/blob/main/ServerAPI/Networking.cs#L92

GitHub

LC-API/ServerAPI/Networking.cs at main · u-2018/LC-API

General purpose utility API for modding Lethal Company - u-2018/LC-API

#

as that's the only thing that could be null

#

I've never seen that happen before though

jagged trout Dec 25, 2023, 4:00 PM

#

jagged trout ```cs [NetworkMessage(typeof(TestClass), "TEST_THING")] internal static void Tes...

Continuing this, I got it to work with just this, too:

[NetworkMessage("TEST_THING")]
internal static void Test(ulong senderId, TestClass thing)
{
    Log.LogInfo("GOT TEST MESSAGE");
    Log.LogInfo(thing.value);
}

[NetworkMessage("TEST_THING2")]
internal class BigTest : NetworkMessageHandler<TestClass>
{
    public override void Handler(ulong sender, TestClass message)
    {
        Log.LogInfo("GOT TEST MESSAGE 2");
        Log.LogInfo(message.value);
    }
}

#

by extracting the types from the method and from the generic base class

jagged trout Dec 25, 2023, 4:28 PM

#

well now that it works, I'll focus on making it backward compatible...

jagged trout Dec 25, 2023, 4:47 PM

#

actually

#

after thinking about it more, this is basically impossible to make backwards compatible

#

with the new system messages have to actually be registered on the network handler

#

ngo will just ignore ones that aren't, and since the old ones just use Broadcast and add to a delegate invoke list, there's no real efficient way to dynamically register them

#

I can invoke the old delegates for properly registered messages, but I can't really register any of the ones that aren't registered

main minnow Dec 25, 2023, 5:30 PM

#

jagged trout Continuing this, I got it to work with just this, too: ```cs [NetworkMessage("TE...

Awesome, this looks brilliant

main minnow Dec 25, 2023, 5:30 PM

#

jagged trout after thinking about it more, this is basically impossible to make backwards com...

Yeah. A shame but worth it for the ease of use it'll bring in the future

jagged trout Dec 25, 2023, 9:06 PM

#

latest commit to #43 adds support for network messages with no body, so they are just invoked with the sender

GitHub

New Networking by steven4547466 · Pull Request #43 · u-2018/LC-API

#

this is basically just to mimic RPC's with no params

#

And I wanted a way to send a message to clients to tell them to send their mod list, but that message doesn't require any body since we know what handler we're in

main minnow Dec 26, 2023, 12:59 AM

#

jagged trout latest commit to [#43](https://github.com/u-2018/LC-API/pull/43) adds support fo...

noice

main minnow Dec 26, 2023, 1:01 AM

#

jagged trout And I wanted a way to send a message to clients to tell them to send their mod l...

ahh I getchu

#

what'd you need the client modlists for?

#

why not have clients send them when they join, then cache the results?

jagged trout Dec 26, 2023, 3:39 AM

#

main minnow + why not have clients send them when they join, then cache the results?

I'm just working with the flow of the old system that had player mods show on join.

main minnow Dec 26, 2023, 4:55 AM

#

jagged trout I'm just working with the flow of the old system that had player mods show on jo...

okay, that's fair, but do you see what I mean?

#

like, that might be something worth re-jigging in the future

jagged trout Dec 26, 2023, 6:13 AM

#

Apparently people are having issues on 3.1.0 that I just can't seem to reproduce

#

I think most of the issues are caused by outdated mods and people not knowing what the point of a major version is

#

Though someone said LC API is causing godmode? Which I quickly tested and was not able to reproduce

#

I also find it somewhat funny when people report bugs for manually downloading when 99% of the time that means they pirated the game lol

jagged trout Dec 26, 2023, 3:49 PM

#

@main minnow are you able to help me test like a 2 minute bug that someone is apparently having?

#

only asking since I saw you online

main minnow Dec 26, 2023, 3:49 PM

#

i'm watching dr who but what's up

#

?

jagged trout Dec 26, 2023, 3:49 PM

#

apparently someone can't pull the lever, and I tested with one person and then they said it only works with someone else in the lobby

#

¯_(ツ)_/¯

#

If you are able, 018ca6d1-941f-4d75-40fd-9f3323f0b479 this just has bepinex and lc api

main minnow Dec 26, 2023, 3:52 PM

#

jagged trout apparently someone can't pull the lever, and I tested with one person and then t...

could it just be that they started a new lobby

#

when the only one that can pull the lever is the host

jagged trout Dec 26, 2023, 3:52 PM

#

they said it was mid game

main minnow Dec 26, 2023, 3:52 PM

#

are they using late company

jagged trout Dec 26, 2023, 3:53 PM

#

me and my friends have been having this problem where when we leave a planet, the game gets stuck and doesn't let us go to another planet (the lever that you pull to land just gets stuck on "Waiting for ship to land." and the game also doesn't auto save because of this) and i believe it to be an issue with the game thinking that it's still on a planet even after leaving (for god knows why).

i made sure that this is an issue with LC API because after disabling LC API, the issue didn't happen anymore (no other mods i have use LC API so it was safe to disable it)

This was the whole post

#

they said disabling lc api made it work

#

idk why they have it if they don't need it

main minnow Dec 26, 2023, 3:53 PM

#

lmao

#

okay

jagged trout Dec 26, 2023, 3:53 PM

#

but I'd like to test it with more players regardless

#

just to make sure I didn't miss anything

main minnow Dec 26, 2023, 3:53 PM

#

yeah sure - lemme finish this dr who episode if that's ok? 30mins tops

jagged trout Dec 26, 2023, 3:54 PM

#

sure

#

Which episode 👀

main minnow Dec 26, 2023, 3:54 PM

#

this year's Christmas one!

#

my family got home too late to watch it yesterday

main minnow Dec 26, 2023, 4:09 PM

#

aye okay

jagged trout Dec 26, 2023, 4:12 PM

#

main minnow aye okay

The profile code should still work 018ca6d1-941f-4d75-40fd-9f3323f0b479

main minnow Dec 26, 2023, 4:12 PM

#

aye i've used it

jagged trout Dec 26, 2023, 4:12 PM

#

I'll also need your steam friend code

main minnow Dec 26, 2023, 4:12 PM

#

sure

jagged trout Dec 26, 2023, 4:12 PM

#

actually your account is linked

main minnow Dec 26, 2023, 4:14 PM

#

ah good 😂 i was struggling to find the code

#

167473533

jagged trout Dec 26, 2023, 4:14 PM

#

I sent you a fr

main minnow Dec 26, 2023, 4:14 PM

#

aye got it

jagged trout Dec 26, 2023, 4:15 PM

#

alright, we're literally just gonna go to 2 moons lol

main minnow Dec 26, 2023, 4:15 PM

#

cheeky game crashed

jagged trout Dec 26, 2023, 4:16 PM

#

Did you need a new invite?

jagged trout Dec 26, 2023, 10:49 PM

#

@main minnow does the dll not go to Release\net46 anymore on your PR?

#

Hm

#

also

#

Building with minver sets the version as 1.0.0 for the bepinex plugin, even though it builds the dll as 3.2.1

#

#

that'll have to be fixed before I can merge this

#

I'm not sure minver and the bepinex plugin info are compatible

#

and also netcode weave doesn't seem to work

#

even though it says it did

#

On your PR vs on main

#

I think the issue may be in part that it isn't going to Release/net46

#

and is instead just in bin

#

since there's no _original file, either

#

for some reason it also freezes the version in decomp to 3.0.0.0

Here's mine, vs yours, not sure what's going on there

main minnow Dec 26, 2023, 11:25 PM

#

jagged trout <@290259615059279883> does the dll not go to `Release\net46` anymore on your PR?

That's right, sorry

main minnow Dec 26, 2023, 11:26 PM

#

jagged trout for some reason it also freezes the version in decomp to 3.0.0.0 Here's mine, v...

I can overwrite that but minver does that intentionally by convention

#

I don't know why the convention is that way

main minnow Dec 26, 2023, 11:27 PM

#

jagged trout On your PR vs on main

Hmm okay, I'll get that fixed

jagged trout Dec 26, 2023, 11:39 PM

#

main minnow I can overwrite that but minver does that intentionally by convention

I'm not entirely sure it matters, just found it odd

#

as long as the bepinex version is right

jagged trout Dec 26, 2023, 11:39 PM

#

jagged trout

which atm it doesn't seem to be

main minnow Dec 26, 2023, 11:40 PM

#

Aye, I think that'll be because MinVer is setting the Version attr too late for Bepin

#

I'll just need to enforce the right order of the build tasks

main minnow Dec 27, 2023, 12:08 AM

#

It's hacky but I think making an empty target with Aftertargets=minver and BeforeTargets=BepIn will do the trick 😂

jagged trout Dec 27, 2023, 12:15 AM

#

https://github.com/u-2018/LC-API/wiki/Networking

#

I have not yet released 3.2.0 as I'm waiting for your PR, but this will apply then

#

Gonna work on the other pages in the meantime

main minnow Dec 27, 2023, 12:25 AM

#

awesome!

jagged trout Dec 27, 2023, 12:28 AM

#

I'm most likely gonna switch to a github pages and have the xml docs auto generate most of it

main minnow Dec 27, 2023, 2:15 AM

#

@jagged trout I found out why MinVer does what it does:

Assembly version

The assembly version is what the CLR uses at run time to select which version of an assembly to load. Selecting an assembly using versioning only applies to assemblies with a strong name.

<AssemblyVersion>1.0.0.0</AssemblyVersion>

The .NET Framework CLR demands an exact match to load a strong-named assembly. For example, Library1, Version=1.0.0.0 was compiled with a reference to Newtonsoft.Json, Version=11.0.0.0. .NET Framework will only load that exact version 11.0.0.0. To load a different version at run time, a binding redirect must be added to the .NET application's config file.

#

https://learn.microsoft.com/en-ca/dotnet/standard/library-guidance/versioning#version-numbers

Versioning and .NET libraries - .NET

Best practice recommendations for versioning .NET libraries.

#

so assuming we adhere to semver, the assembly version being set that way makes sense

main minnow Dec 27, 2023, 3:15 AM

#

@jagged trout I've updated the PR, take a look when you can

jagged trout Dec 27, 2023, 3:48 PM

#

main minnow <@353782817777385472> I've updated the PR, take a look when you can

Checking

#

Ok

#

I must be using the wrong file

#

where is the actual completed dll going?

#

because the one in bin/ is not netcode patched

#

the only _original file I have in in bin/Release/net46, but it's old

main minnow Dec 27, 2023, 3:51 PM

#

have you pulled changes?

#

Because for me, the DLL is going to bin/ and there is also an original in that folder

jagged trout Dec 27, 2023, 3:52 PM

#

main minnow have you pulled changes?

Well that would help, lol

main minnow Dec 27, 2023, 3:52 PM

#

😂😂😂😂

jagged trout Dec 27, 2023, 3:55 PM

#

seems to work

main minnow Dec 27, 2023, 3:56 PM

#

I should double check it works within actions

jagged trout Dec 27, 2023, 3:57 PM

#

Well I've already merged, so lemme know if it doesn't

#

I won't be making any github releases until 2018 can get the nuget setup as well

#

Where can I get a thunderstore api key?

#

as far as I can tell they just use basic auth

main minnow Dec 27, 2023, 3:59 PM

#

jagged trout Where can I get a thunderstore api key?

You're on the '2018' team ?

jagged trout Dec 27, 2023, 4:00 PM

#

yeah

main minnow Dec 27, 2023, 4:01 PM

#

im not sure you'll have high enough privileges to add service accounts

jagged trout Dec 27, 2023, 4:01 PM

#

I'm not

main minnow Dec 27, 2023, 4:01 PM

#

#

#

when you create a service account, it gives you an API key scoped to the team the account is for

main minnow Dec 27, 2023, 4:02 PM

#

jagged trout I'm not

okay so it'll be another thing 2018 has to do 😅

#

@jagged trout I borked the build badge 😭

#

give me a sec

#

PR opened

#

ah yes you can experience the glory of PR checks!

#

#

it brings a tear to my eye

#

#

🥹

jagged trout Dec 27, 2023, 4:54 PM

#

@main minnow I haven't actually tested that the networking works on other clients, so do you think you could join me with a custom build?

main minnow Dec 27, 2023, 5:02 PM

#

jagged trout <@290259615059279883> I haven't actually tested that the networking works on oth...

Sure, let me get the restructure PR going

jagged trout Dec 27, 2023, 5:04 PM

#

📎 LC_API.dll

#

actually

#

that won't work

main minnow Dec 27, 2023, 5:05 PM

#

can I pull your branch and build it myself?

jagged trout Dec 27, 2023, 5:06 PM

#

no, I have specific test changes that won't be pushed

main minnow Dec 27, 2023, 5:07 PM

#

👍

jagged trout Dec 27, 2023, 5:07 PM

#

📎 LC_API.dll

#

that one should work

main minnow Dec 27, 2023, 5:07 PM

#

is this malware steven

#

do I need to be running in a VM

jagged trout Dec 27, 2023, 5:07 PM

#

If you want lol

#

but you can decomp it

main minnow Dec 27, 2023, 5:10 PM

#

@jagged trout i've just noticed youre using net46 which doesnt support netstandard2.0

jagged trout Dec 27, 2023, 5:10 PM

#

I didn't use net46

main minnow Dec 27, 2023, 5:10 PM

#

in the restructure is it ok if I target netstandard2.0

main minnow Dec 27, 2023, 5:10 PM

#

jagged trout I didn't use net46

2018, OK. Targeting netstandard.

jagged trout Dec 27, 2023, 5:10 PM

#

As long as it doesn't break anything

main minnow Dec 27, 2023, 5:11 PM

#

I'll make sure everything still builds correctly 👍

#

Loading LC with your DLL

jagged trout Dec 27, 2023, 5:11 PM

#

👍

#

ideally we should get the mod list popup then I'll get some console logs after 10 seconds

#

wait

#

I never called the test method lol

#

oh well, the mod list should work

#

also for some reason my vs didn't like that minver so it did this

#

¯_(ツ)_/¯

#

config mismatch

#

hm

main minnow Dec 27, 2023, 5:13 PM

#

what the fuck? 😂

main minnow Dec 27, 2023, 5:13 PM

#

jagged trout also for some reason my vs didn't like that minver so it did this

try to revert this commit if you can

jagged trout Dec 27, 2023, 5:13 PM

#

I didn't commit it

main minnow Dec 27, 2023, 5:13 PM

#

oh okay

#

bing chilling

jagged trout Dec 27, 2023, 5:13 PM

#

it also doesn't let me build if I change it

main minnow Dec 27, 2023, 5:13 PM

#

you what

jagged trout Dec 27, 2023, 5:14 PM

#

but it's the same version

main minnow Dec 27, 2023, 5:14 PM

#

unload project -> edit -> reload?

jagged trout Dec 27, 2023, 5:14 PM

#

and it seems to work on my end still

#

I don't think this should really make a difference anyways

#

as far as I can tell it's still working

#

hm

main minnow Dec 27, 2023, 5:15 PM

#

yeah but it's using the expanded view for no reason

#

i'll set the IncludeAssets attr on the restructure branch

jagged trout Dec 27, 2023, 5:16 PM

#

📎 LC_API.dll

#

Let's try this

#

idk why we got config mismatch

#

wait

#

this won't work

main minnow Dec 27, 2023, 5:17 PM

#

I'll delete my config file so i get a clean one

jagged trout Dec 27, 2023, 5:17 PM

#

hmmmmmmmmmmmmmmmmmmm

main minnow Dec 27, 2023, 5:17 PM

#

kek

jagged trout Dec 27, 2023, 5:17 PM

#

main minnow I'll delete my config file so i get a clean one

it's not an actual config file

#

it's the like network prefabs and stuff

#

📎 LC_API.dll

#

🤞

#

hmmmmmmmm

#

not good

main minnow Dec 27, 2023, 5:22 PM

#

wassup

jagged trout Dec 27, 2023, 5:23 PM

#

I'm assuming unity ngo requires all net messages registered with RegisterNamedMessageHandler to be synced, but with mod mismatches that will almost never be the case, and for mods without lc api, would never work. I'm not sure why we can't connect, however, since we have the same mods

#

I'm gonna remove all the network messages just to see if we can connect

#

📎 LC_API.dll

#

This could be a major problem

#

I may have to switch to unnamed messages and just make my own message handler

#

But first lets see if removing the messages allows you to connect

#

The docs don't really mention that they need to be synced anyways

#

in fact it just says that they should be registered in OnNetworkSpawn

#

so it would be impossible for them to be synced on join

#

You do have the networking asset bundle though, right?

#

Your file structure should look like this and inside that Bundles folder should be networking

main minnow Dec 27, 2023, 5:30 PM

#

I did not

#

I'm sorry about that, let me sort it

#

did you add the Bundles dir with assetbundles to Git?

#

you want me to download from TS?

jagged trout Dec 27, 2023, 5:32 PM

#

main minnow did you add the `Bundles` dir with assetbundles to Git?

Let me just remove Thunderstore from the gitignore

#

so it'll upload with it

main minnow Dec 27, 2023, 5:33 PM

#

okay

jagged trout Dec 27, 2023, 5:34 PM

#

https://github.com/steven4547466/LC-API/tree/main/Thunderstore/BepinEx/plugins/Bundles

#

Also, I'm assuming that's the problem, so let's try this lmao

📎 LC_API.dll

main minnow Dec 27, 2023, 5:38 PM

#

[Info   :Lethal Company API] Broadcasting
[Error  : Unity Log] NotServerException: ConnectedClientIds should only be accessed on server.
Stack trace:
Unity.Netcode.NetworkManager.get_ConnectedClientsIds () (at <1b23ec5fcbfc4fbca0db70afcdb9b715>:0)
Unity.Netcode.CustomMessagingManager.SendNamedMessageToAll (System.String messageName, Unity.Netcode.FastBufferWriter messageStream, Unity.Netcode.NetworkDelivery networkDelivery) (at <1b23ec5fcbfc4fbca0db70afcdb9b715>:0)
LC_API.Networking.NetworkMessageFinalizer.Send () (at <55ac7c31d7b34564b0b94f24f0a6a794>:0)
LC_API.Networking.Network.Broadcast (System.String uniqueName) (at <55ac7c31d7b34564b0b94f24f0a6a794>:0)
LC_API.Plugin+<TestSendMessage>d__14.MoveNext () (at <55ac7c31d7b34564b0b94f24f0a6a794>:0)
UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <e27997765c1848b09d8073e5d642717a>:0)

jagged trout Dec 27, 2023, 5:51 PM

#

hm

#

sender id is pretty much useless if I make this an rpc

#

not sure what to do

#

guess I'll also have to make it a relay...

#

Which means I'll need to wrap the type into a new class that has the actual sender and unpack it when received

#

https://tenor.com/view/ups-oops-gif-25712345

Tenor

main minnow Dec 27, 2023, 5:55 PM

#

have fun!! 😂

#

AUGHHHHHH

#

EVAIIIISAAAAA

#

why couldnt she just make netcodeweaver a clever thing

#

i'm actually going to have to write a javascript action

#

to make the netcode weaver setup action

#

i swear to fucking god

#

see you in a few hours

jagged trout Dec 27, 2023, 6:42 PM

#

@main minnow think you could test with me again?

#

I think I got this wrapped relay done

#

it works sending to self as host, but gotta test clients as well

#

I actually didn't need to add anything to the bundle either

#

thank god

main minnow Dec 27, 2023, 6:49 PM

#

jagged trout <@290259615059279883> think you could test with me again?

sure

jagged trout Dec 27, 2023, 6:49 PM

#

📎 LC_API.dll

#

lmk when you're able to test

main minnow Dec 27, 2023, 9:10 PM

#

@jagged trout sorry about that, whenever

jagged trout Dec 27, 2023, 9:44 PM

#

main minnow <@353782817777385472> sorry about that, whenever

ok

#

is now good?

jagged trout Dec 27, 2023, 10:06 PM

#

Guess not lol

main minnow Dec 27, 2023, 10:10 PM

#

I really should take my meds

#

@jagged trout yes, now is good

jagged trout Dec 27, 2023, 10:11 PM

#

lol that file should still be good

#

alright so we're hoping for it to say broadcasting in your console then in mine I'll see a bunch of network messages

main minnow Dec 27, 2023, 10:12 PM

#

aye aye

jagged trout Dec 27, 2023, 10:13 PM

#

anything?

main minnow Dec 27, 2023, 10:13 PM

#

[Info   :Lethal Company API] Broadcasting
[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
LC_API.Networking.NetworkMessageFinalizer.Send () (at <1be4b194ad4840899e4c16396a912452>:0)
LC_API.Networking.Network.Broadcast (System.String uniqueName) (at <1be4b194ad4840899e4c16396a912452>:0)
LC_API.Plugin+<TestSendMessage>d__14.MoveNext () (at <1be4b194ad4840899e4c16396a912452>:0)
UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <e27997765c1848b09d8073e5d642717a>:0)

#

[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
LC_API.Networking.NetworkMessageFinalizer.Read (System.UInt64 fakeSender, Unity.Netcode.FastBufferReader reader) (at <1be4b194ad4840899e4c16396a912452>:0)
Unity.Netcode.CustomMessagingManager.InvokeNamedMessage (System.UInt64 hash, System.UInt64 sender, Unity.Netcode.FastBufferReader reader, System.Int32 serializedHeaderSize) (at <1b23ec5fcbfc4fbca0db70afcdb9b715>:0)
Unity.Netcode.NamedMessage.Handle (Unity.Netcode.NetworkContext& context) (at <1b23ec5fcbfc4fbca0db70afcdb9b715>:0)
Unity.Netcode.NetworkMessageManager.ReceiveMessage[T] (Unity.Netcode.FastBufferReader reader, Unity.Netcode.NetworkContext& context, Unity.Netcode.NetworkMessageManager manager) (at <1b23ec5fcbfc4fbca0db70afcdb9b715>:0)
Unity.Netcode.NetworkMessageManager.HandleMessage (Unity.Netcode.NetworkMessageHeader& header, Unity.Netcode.FastBufferReader reader, System.UInt64 senderId, System.Single timestamp, System.Int32 serializedHeaderSize) (at <1b23ec5fcbfc4fbca0db70afcdb9b715>:0)
UnityEngine.Debug:LogException(Exception)
Unity.Netcode.NetworkMessageManager:HandleMessage(NetworkMessageHeader&, FastBufferReader, UInt64, Single, Int32)
Unity.Netcode.NetworkMessageManager:ProcessIncomingMessageQueue()
Unity.Netcode.NetworkManager:NetworkUpdate(NetworkUpdateStage)
Unity.Netcode.NetworkUpdateLoop:RunNetworkUpdateStage(NetworkUpdateStage)
Unity.Netcode.<>c:<CreateLoopSystem>b__0_0()

jagged trout Dec 27, 2023, 10:14 PM

#

my pain is immeasurable

#

I wonder if Player.HostPlayer is null for you for some reason

#

Yeah it seems like for you HostPlayer and LocalPlayer are null

main minnow Dec 27, 2023, 10:41 PM

#

THONK

#

that doesn't make any sense

#

maybe i just fucked up the assetbundle

jagged trout Dec 27, 2023, 10:44 PM

#

nah wasn't you

#

syncing the custom players is finnickey

#

especially with timing and ping

#

it's a nightmare

#

Ok, so let's try this lmao

📎 LC_API.dll

jagged trout Dec 27, 2023, 11:02 PM

#

small things

📎 LC_API.dll

#

if you're able to help test again lmk

main minnow Dec 27, 2023, 11:09 PM

#

Yep

#

@jagged trout

#

omw

jagged trout Dec 27, 2023, 11:09 PM

#

👍

#

#

@main minnow before you continue your restructure, I'd pull main

#

after your restructure, I'm going to freeze main for releases and we'll work from a dev branch

main minnow Dec 27, 2023, 11:26 PM

#

Will do. Thankyou for letting me know

zealous beacon Dec 28, 2023, 12:41 AM

#

jagged trout

speaking of this feature can I have a config to turn it off :)

jagged trout Dec 28, 2023, 12:51 AM

#

zealous beacon speaking of this feature can I have a config to turn it off :)

It's networking, if you don't make any handlers it won't do anything

zealous beacon Dec 28, 2023, 12:52 AM

#

wait is this not the same LC_API that spams hud elements for 5 minutes at the start of every game with cutoff lists of mods?

jagged trout Dec 28, 2023, 12:52 AM

#

I completely rewrote networking

#

it uses ngo custom messages now

#

https://github.com/u-2018/LC-API/wiki/Networking

GitHub

Networking

General purpose utility API for modding Lethal Company - u-2018/LC-API

#

so it won't use chat anymore

#

so you can send whatever you want as long as it's serializable and all you gotta do is add that attribute, LC API will handle the rest

swift halo Dec 28, 2023, 12:59 AM

#

Is it automatic? I assumed it was something you had to implement yourself

jagged trout Dec 28, 2023, 12:59 AM

#

swift halo Is it automatic? I assumed it was something you had to implement yourself

well you add the attribute, that's the implementation

swift halo Dec 28, 2023, 12:59 AM

#

Yeah the other messages just loaded for me. Wi-Fi cut out

jagged trout Dec 28, 2023, 1:00 AM

#

then you just do

Network.Broadcast("Name", T obj)

swift halo Dec 28, 2023, 1:00 AM

#

Nice that it doesn't just chat

jagged trout Dec 28, 2023, 1:00 AM

#

Yeah that was an interesting implementation

swift halo Dec 28, 2023, 1:00 AM

#

Ouf the string tho 😔

jagged trout Dec 28, 2023, 1:00 AM

#

swift halo Ouf the string tho 😔

It's gotta be named somehow

#

#

But it just uses named messages under the hood

swift halo Dec 28, 2023, 1:01 AM

#

Oh so it doesn't send the string?

jagged trout Dec 28, 2023, 1:01 AM

#

the name being what you see in the attribute

#

No

#

you can send anything you want that's serializable

swift halo Dec 28, 2023, 1:02 AM

#

Cool then

jagged trout Dec 28, 2023, 1:03 AM

#

jagged trout you can send anything you want that's serializable

this includes your own classes as long as you mark them as serializable

#

the wiki shows an example

#

https://github.com/u-2018/LC-API/wiki/Networking#what-can-you-send

swift halo Dec 28, 2023, 1:04 AM

#

What are you using to serialize the objects?

jagged trout Dec 28, 2023, 1:04 AM

#

internal static byte[] ToBytes(this object @object)
{
    if (@object == null) return null;

    BinaryFormatter binaryFormatter = new BinaryFormatter();
    MemoryStream memoryStream = new MemoryStream();

    binaryFormatter.Serialize(memoryStream, @object);

    return memoryStream.ToArray();
}

internal static T ToObject<T>(this byte[] bytes) where T : class
{
    BinaryFormatter binaryFormatter = new BinaryFormatter();
    MemoryStream memoryStream = new MemoryStream();

    memoryStream.Write(bytes, 0, bytes.Length);
    memoryStream.Seek(0, SeekOrigin.Begin);

    return binaryFormatter.Deserialize(memoryStream) as T;
}

#

it's just a byte array

swift halo Dec 28, 2023, 1:05 AM

#

Doesn't binaryformatter have security issues? See: the Raft incident

jagged trout Dec 28, 2023, 1:06 AM

#

raft incident?

swift halo Dec 28, 2023, 1:06 AM

#

Yeah, the game

#

https://www.google.com/url?sa=t&source=web&rct=j&opi=89978449&url=https://www.synacktiv.com/sites/default/files/2022-12/Raft_RCE.pdf&ved=2ahUKEwj5gZe4-LCDAxXme_UHHSsPBAYQFnoECBEQAQ&usg=AOvVaw1ahczQjL_ilMkf5oDaiWv8

#

Damn that's a shit link

#

If you Google raft binary formatter you'll find it

jagged trout Dec 28, 2023, 1:08 AM

#

hm

#

The data type is defined by the devs using it

#

lemme see tho

swift halo Dec 28, 2023, 1:09 AM

#

Yes, but any dev could use the remote code exploit on anyone else using LC api

#

Having the mod installed would be a liability

jagged trout Dec 28, 2023, 1:13 AM

#

Trying to think of a solution

swift halo Dec 28, 2023, 1:13 AM

#

Don't use binary formatter

jagged trout Dec 28, 2023, 1:13 AM

#

Well yeah

#

that's not a solution

swift halo Dec 28, 2023, 1:14 AM

#

It is the only solution...

jagged trout Dec 28, 2023, 1:14 AM

#

a solution to this problem is replacing it with something else

#

"remove it" is not helpful

swift halo Dec 28, 2023, 1:14 AM

#

Yeah that's what I mean

#

Or ig implied

jagged trout Dec 28, 2023, 1:14 AM

#

Yes, removing it will be a part of the solution, but it isn't the solution entirely

#

I can see if json serialization will work I guess

swift halo Dec 28, 2023, 1:16 AM

#

That would bloat message sizes more than BF

jagged trout Dec 28, 2023, 1:17 AM

#

Yeah, but alternative is RCE

#

and I'm not about to write a custom binary serializer because I would introduce more security problems than binary formatter

swift halo Dec 28, 2023, 1:18 AM

#

That's what I did

#

Gaffer on games has a good implementation of a custom binary serializer

#

The issue is it's too low level for your target audience

jagged trout Dec 28, 2023, 1:23 AM

#

Well I'm not presenting any serialization to the user, I would like them to just be able to send whatever type they want and the api will serialize it for them

#

For more advanced users maybe

#

but it's not useful for most users to have to write their own serialization

swift halo Dec 28, 2023, 1:24 AM

#

Yep

main minnow Dec 28, 2023, 1:38 AM

#

@jagged trout since LCAPI is lethal company specific, you could just use Newtonsoft JSON

swift halo Dec 28, 2023, 1:39 AM

#

I mean then we're back to bloated strings over the network

main minnow Dec 28, 2023, 1:39 AM

#

swift halo I mean then we're back to bloated strings over the network

nono you can use json.bson

#

i think

#

I actually can't tell if that namespace is part of the newtonsoft package

#

Or alternatively https://odininspector.com/odin-serializer

Odin Inspector

Odin Serializer

#

which is apparently the solution that Raft employed

#

Would have to distribute the DLL tho

swift halo Dec 28, 2023, 1:43 AM

#

From some cursory googling, BSON is not smaller in size

jagged trout Dec 28, 2023, 1:44 AM

#

easy networking will come with tradeoffs, and we're talking in the megabyte range over the entire game session

#

people can always write their own to optimize for their objects if needed

swift halo Dec 28, 2023, 1:45 AM

#

Sounds like json would fit your standards then

jagged trout Dec 28, 2023, 1:45 AM

#

main minnow nono you can use json.bson

newtonsoft's bson is deprecated since it was moved

main minnow Dec 28, 2023, 1:47 AM

#

jagged trout newtonsoft's bson is deprecated since it was moved

understood

#

how do RPCs serialize then?

#

FastBufferReader/FastBufferWriter? are those marked as internal?

swift halo Dec 28, 2023, 1:49 AM

#

INetworkSerializable can be used

jagged trout Dec 28, 2023, 1:49 AM

#

They use INetworkSerializable

#

but that would require people to know how to serialize their objects by hand

#

It's not too difficult though

main minnow Dec 28, 2023, 1:50 AM

#

aye. Maybe we could use INetworkSerializable's serialization/deserialization when available and fallback to JSON?

#

That would keep overheads minimal for primitives like string, vectors, etc

jagged trout Dec 28, 2023, 1:51 AM

#

main minnow That would keep overheads minimal for primitives like string, vectors, etc

I mean I'm not sure if those are actually INetworkSerializable

#

Since they are defined by c# and unity themselves

#

ngo couldn't add that interface to them

main minnow Dec 28, 2023, 1:52 AM

#

NC4GO implements serializers/deserializers for primitives, yes

#

https://docs-multiplayer.unity3d.com/netcode/current/advanced-topics/serialization/cprimitives/

C# Primitives | Unity Multiplayer Networking

C# Primitive types will be serialized by built-in serialization code. These types include bool, char, sbyte, byte, short, ushort, int, uint, long, ulong, float, double, and string.

jagged trout Dec 28, 2023, 1:52 AM

#

Yeah what I'm saying is how I can automatically detect whether or not it can be serialized like that

#

I can't just use is INetworkSerializable for those types

#

I can use that for custom classes

swift halo Dec 28, 2023, 1:53 AM

#

Type check ig

main minnow Dec 28, 2023, 1:53 AM

#

let me open the nc4go dll

#

no, I have an idea

jagged trout Dec 28, 2023, 1:54 AM

#

I mean at that point they can probably just make their own custom messages anyways lol

#

ideally it should remain a simple solution for users who just want quick networking

swift halo Dec 28, 2023, 2:01 AM

#

Odin serializer didn't look half bad

#

Open source too

main minnow Dec 28, 2023, 2:02 AM

#

swift halo Odin serializer didn't look half bad

yeah the only slight pain is that if multiple mods bundle it then it's gonna end up being loaded from multiple dlls, unless someone makes it its own thunderstore package?

#

although I don't think theres many mods wanting to do this kinda thing

swift halo Dec 28, 2023, 2:03 AM

#

Sounds like a good idea

main minnow Dec 28, 2023, 2:04 AM

#

swift halo Open source too

Licensed under Apache, so very chilling

swift halo Dec 28, 2023, 2:04 AM

#

I'm not familiar

main minnow Dec 28, 2023, 2:05 AM

#

You can use it commercially (earn money from derived works)

jagged trout Dec 28, 2023, 2:05 AM

#

Basically all I would need to care for is distribution with license

#

which I should be able to do with apache

swift halo Dec 28, 2023, 2:05 AM

#

main minnow You can use it commercially (earn money from derived works)

Sounds good right?

main minnow Dec 28, 2023, 2:05 AM

#

swift halo Sounds good right?

Raft wouldn't have been able to use it, otherwise, so yes

main minnow Dec 28, 2023, 2:05 AM

#

jagged trout which I should be able to do with apache

Yep

#

I would probably go with that

#

or newtonsoft

jagged trout Dec 28, 2023, 2:05 AM

#

I wonder if I need to wrap primitive types

main minnow Dec 28, 2023, 2:06 AM

#

jagged trout I wonder if I need to wrap primitive types

What's your thought process? Why'd you think you might need to?

swift halo Dec 28, 2023, 2:06 AM

#

Not with Odin I doubt

jagged trout Dec 28, 2023, 2:06 AM

#

main minnow What's your thought process? Why'd you think you might need to?

well in case you just wanna send like an int or something

#

Since right now it's limited to reference types as well

#

but I'm not too bothered

#

Does odin have a nuget package I wonder

#

they don't seem to

#

well I'd have to distribute it anyways

#

They don't make downloading this easy lmao

#

It seems to be a unity package

#

not just a dll

swift halo Dec 28, 2023, 2:11 AM

#

Betting the unity package just has a dll in it lol

jagged trout Dec 28, 2023, 2:11 AM

#

Yeah I'm gonna see

#

their little download tool makes you give it a custom namespace lmao

main minnow Dec 28, 2023, 2:13 AM

#

If you intend to include OdinSerializer in one of your own product distributions, you should modify all source files using a tool like search and replace to move the OdinSerializer namespace into an appropriate namespace for your project, and rename the .dll's that are built. This is to avoid namespace and assembly conflicts in the cases where multiple different assets in the same project all use possibly differing versions of OdinSerializer. For example, you might globally rename "OdinSerializer" to "MyProject.Internal.OdinSerializer", and also have the .dll's renamed to "MyProject.Internal.OdinSerializer.dll".

#

so could write an MSBuild task to download source code from their GitHub, fix the namespaces, etc

#

hmm

jagged trout Dec 28, 2023, 2:14 AM

#

It's a bunch of C# files

main minnow Dec 28, 2023, 2:15 AM

#

once I've finished the NetCode weave action and done the restructure

#

I can make an automatic thing for generating a thunderstore package, but not sure what to do about referencing that in project

#

Oh yeah we can just do it in our repo

jagged trout Dec 28, 2023, 2:18 AM

#

I mean I could just copy the unitypackage's cs files into the repo since I gave them the LC_API namespace lol

#

I'm actually not sure if apache allows that specifically

#

or just redistributing the binaries

#

but they don't actually provide binaries

#

technically the unitypackage would just be compiled in the assembly csharp

main minnow Dec 28, 2023, 2:18 AM

#

I would use the cs files from their GitHub if possible

#

not sure if they'll be different

jagged trout Dec 28, 2023, 2:19 AM

#

main minnow I would use the cs files from their GitHub if possible

those cs files have improper namespaces, don't they?

#

Oh it's just odin serializer?

main minnow Dec 28, 2023, 2:20 AM

#

Yeah

jagged trout Dec 28, 2023, 2:20 AM

#

I wonder if I can build the project on github into its own dll and just use that

main minnow Dec 28, 2023, 2:20 AM

#

you can, but that can cause namespace issues if other people do the same thing

jagged trout Dec 28, 2023, 2:20 AM

#

Regardless I do have it working with newtonsoft atm

jagged trout Dec 28, 2023, 2:20 AM

#

main minnow you can, but that can cause namespace issues if other people do the same thing

well I'd have to manually change all the namespaces if I put it in the plugin then

main minnow Dec 28, 2023, 2:20 AM

#

jagged trout Regardless I do have it working with newtonsoft atm

Okay awesome. let's stick with that and I'll open an enhancement issue for later

jagged trout Dec 28, 2023, 2:21 AM

#

which is what their download tool did for me I think

swift halo Dec 28, 2023, 2:31 AM

#

main minnow Okay awesome. let's stick with that and I'll open an enhancement issue for later

The "we'll fix it in post" of game dev xD

jagged trout Dec 28, 2023, 2:34 AM

#

It pains me that there has to be a security vulnerability in creating a byte array from what is literally just a bunch of bytes 😢

#

Just let me mem copy the entire thing

main minnow Dec 28, 2023, 9:59 AM

#

jesus christ that was an ordeal

#

@jagged trout it is done

#

https://github.com/Lordfirespeed/setup-netcode-weaver/blob/main/src/lib/target-framework-moniker.ts is the brunt of what I had to do 😭

#

but anyway, it works

#

https://github.com/u-2018/LC-API/pull/52 is no longer a draft (thankyou for marking it so)

GitHub

Restructure by Lordfirespeed · Pull Request #52 · u-2018/LC-API

jagged trout Dec 28, 2023, 4:22 PM

#

main minnow <@353782817777385472> it is done

Should there be a slash here or no?

main minnow Dec 28, 2023, 6:46 PM

#

jagged trout Should there be a slash here or no?

There was previously and I removed it because SolutionDir has a / on the end

#

No idea why

jagged trout Dec 28, 2023, 6:47 PM

#

interesting

jagged trout Dec 28, 2023, 11:24 PM

#

Should I make the network messages need to be manually registered like harmony patches?

It'd be static though so you could just like Network.RegisterAll() and there'd also be the one for registering messages inside a specific type like: Network.RegisterAll(type) to mirror harmony's PatchAll

main minnow Dec 29, 2023, 1:33 AM

#

jagged trout Should I make the network messages need to be manually registered like harmony p...

Yes

#

Ideally with the same API as harmony

#

Actually, that's only really valid if it's possible to 'unregister' network messages

jagged trout Dec 29, 2023, 1:43 AM

#

main minnow Actually, that's only really valid if it's possible to 'unregister' network mess...

it is

main minnow Dec 29, 2023, 1:43 AM

#

okay, then yeah

#

it would be good to let people unregister their messages as a 'teardown' thing

#

of course adoption would be low (almost no one implements teardown) but its a shame because implementing teardown allows hot-reloading

cyan trout Dec 29, 2023, 1:47 AM

#

cant wait for this 🙏

main minnow Dec 29, 2023, 2:43 AM

#

@jagged trout it brings a tear to my eye

#

jagged trout Dec 29, 2023, 2:45 AM

#

From this point on main will be frozen to releases/release candidates

main minnow Dec 29, 2023, 2:45 AM

#

Hang on, before you do that

jagged trout Dec 29, 2023, 2:45 AM

#

all future PRs should target dev

main minnow Dec 29, 2023, 2:45 AM

#

let me fix the Thunderstore folder

jagged trout Dec 29, 2023, 2:45 AM

#

main minnow Hang on, before you do that

I already did, but what's up

main minnow Dec 29, 2023, 2:45 AM

#

ah never mind then

#

i'll target that on dev

#

👍

jagged trout Dec 29, 2023, 2:45 AM

#

well I haven't done any releasing yet

#

the dev branch is still synced

#

where were you gonna put it?

main minnow Dec 29, 2023, 2:46 AM

#

I'm going to remove the unnecessary duplicated assets (README) and make the paths nicer because tcli does the path remapping for us

jagged trout Dec 29, 2023, 2:46 AM

#

ok

#

The pain of getting my local fork to sync with this

main minnow Dec 29, 2023, 2:49 AM

#

Rebase

#

It might be easier

jagged trout Dec 29, 2023, 2:49 AM

#

didn't seem to do anything

#

I'll probably just reclone

#

actually the sync button on github might work

#

yeah cool, that worked

main minnow Dec 29, 2023, 2:52 AM

#

yeah @jagged trout there are a few options for that

keeping your main branch clean on your fork so it can always sync
git remote add upstream ... and then git pull upstream main

jagged trout Dec 29, 2023, 2:54 AM

#

yeah I have upstream, for some reason updating it kept my local files plus your changes

#

but syncing on github then pulling seemed to work

main minnow Dec 29, 2023, 2:54 AM

#

That might be a git.config issue to do with preventing the possibility of all local copies being purged

#

if a remote repo gets compromised

#

https://github.com/u-2018/LC-API/pull/58

GitHub

Remove thunderstore folder by Lordfirespeed · Pull Request #58 · u-...

#

FYI if you set this in your csproj.user then dotnet build will automatically build the mod zip, provided you have tcli installed

#

<PACK_THUNDERSTORE>true</PACK_THUNDERSTORE>

#

dotnet tool install -g tcli

jagged trout Dec 29, 2023, 2:57 AM

#

so where's the thunderstore readme at now?

main minnow Dec 29, 2023, 2:57 AM

#

It gets copied from the repo readme

jagged trout Dec 29, 2023, 2:57 AM

#

hm

main minnow Dec 29, 2023, 2:57 AM

#

Oh, were they different?

jagged trout Dec 29, 2023, 2:57 AM

#

they're different

#

yeah

#

not something I did

main minnow Dec 29, 2023, 2:57 AM

#

that's ok, I'll bring it back

#

...we could just make it the repo one

#

😂

jagged trout Dec 29, 2023, 2:57 AM

#

we also need the network bundle

main minnow Dec 29, 2023, 2:57 AM

#

jagged trout we also need the network bundle

that's done

#

I tested that

jagged trout Dec 29, 2023, 2:58 AM

#

where's it at?

main minnow Dec 29, 2023, 2:58 AM

#

assets/bundles/networking

#

it gets copied to the correct path in the ZIP

jagged trout Dec 29, 2023, 2:58 AM

#

main minnow Dec 29, 2023, 2:58 AM

#

because of the rule in assets/thunderstore.toml

jagged trout Dec 29, 2023, 2:58 AM

#

didn't seem to be committed

#

oh wait

#

I see it

main minnow Dec 29, 2023, 2:58 AM

#

jagged trout Dec 29, 2023, 2:59 AM

#

can you move the "versions" stuff from the thunderstore readme to CHANGELOG.md and include that in the thunderstore?

#

since thunderstore has a changelog page

#

if it's there

main minnow Dec 29, 2023, 3:00 AM

#

Yeah, that sounds like a good solution. Then we don't need two separate readmes, rght?

jagged trout Dec 29, 2023, 3:00 AM

#

yeah

#

I'm gonna see what other diffs there were

main minnow Dec 29, 2023, 3:00 AM

#

I'll use the Keep A Changelog format if that's ok

main minnow Dec 29, 2023, 3:00 AM

#

jagged trout I'm gonna see what other diffs there were

just this:

# Features
AssetBundle loading - Put asset bundles in BepInEx > Bundles and load them using BundleAPI.BundleLoader.GetLoadedAsset

ServerAPI - Utilities relating to the network and server. This includes:

ModdedServer - Automatically alerts other users when you host a server that your server is modded. 
It also lets mod authors make their mods put users in special matchmaking where they can only play with other modded users

Networking - Easily send data across the network to sync data between clients

jagged trout Dec 29, 2023, 3:01 AM

#

That's kinda outdated

#

I'd just remove it

main minnow Dec 29, 2023, 3:01 AM

#

Aye, in that case the root readme has parity

jagged trout Dec 29, 2023, 3:01 AM

#

Yeah then just get the versions into changelog.md and I'm gonna reformat it then I can merge

main minnow Dec 29, 2023, 3:04 AM

#

jagged trout Yeah then just get the versions into changelog.md and I'm gonna reformat it then...

i'm already reformatting it 😅

#

I'm pretty sure we have the same idea

jagged trout Dec 29, 2023, 3:05 AM

#

I would like new versions to be at the top

main minnow Dec 29, 2023, 3:05 AM

#

already done

jagged trout Dec 29, 2023, 3:05 AM

#

since that's what you'll first see

#

yeah

#

other than that I don't really mind

main minnow Dec 29, 2023, 3:06 AM

#

https://keepachangelog.com/en/1.1.0/

Keep a Changelog

jagged trout Dec 29, 2023, 3:06 AM

#

yeah that's what I use mainly

main minnow Dec 29, 2023, 3:07 AM

#

networking bundle is at BepInEx/plugins/Bundles/networking

#

Changes pushed

jagged trout Dec 29, 2023, 3:08 AM

#

as long as Bundles folder resides next to the dll when r2modman unpacks it, I'm cool with it

main minnow Dec 29, 2023, 3:09 AM

#

jagged trout as long as `Bundles` folder resides next to the dll when r2modman unpacks it, I'...

yeah I think that'll happen using that path

jagged trout Dec 29, 2023, 3:09 AM

#

though I would potentially consider moving the dll to the plugins folder just for those manual installers that drag and drop the BepinEx folder

#

I've had like 8 issues opened about manual installation because none of them know how to set it up

#

so I made it as easy as possible

main minnow Dec 29, 2023, 3:09 AM

#

oh for fucks sakes

#

yeah I'll do that too

jagged trout Dec 29, 2023, 3:11 AM

#

#32, #42, #45, #46, #48, #51

#

all of these issues were because people just dragged and dropped files and expected it to work

#

lmao

main minnow Dec 29, 2023, 3:12 AM

#

and then complain when filename collisions mean that nothing works right

jagged trout Dec 29, 2023, 3:12 AM

#

so in the next version I have it just look exactly where the dll is for the Bundles folder

main minnow Dec 29, 2023, 3:12 AM

#

or that they didn't copy the right file in the first place, like this situ

jagged trout Dec 29, 2023, 3:12 AM

#

Nah the issue was I was looking specifically for 2018-LC_API

#

which manual installation doesn't have

main minnow Dec 29, 2023, 3:12 AM

#

ahhhhhhhhhhhh

#

I see

jagged trout Dec 29, 2023, 3:12 AM

#

I didn't know PluginInfo.Location existed

#

so I was going off of Paths.PluginPath

#

¯_(ツ)_/¯

#

it's "fixed" in the next version though

main minnow Dec 29, 2023, 3:13 AM

#

Paths.PluginPath should be accurate

#

the problem is people installing manually and not using BepInEx correctly

jagged trout Dec 29, 2023, 3:13 AM

#

Nah that's BepinEx/plugins

main minnow Dec 29, 2023, 3:13 AM

#

ah sorry, you're right

jagged trout Dec 29, 2023, 3:13 AM

#

PluginInfo.Location is the literal location of the dll of the plugin lol

#

Now I just do Path.Combine(Plugin.Instance.Info.Location.Substring(0, Plugin.Instance.Info.Location.LastIndexOf(Path.DirectorySeparatorChar)), "Bundles", "networking")

#

https://github.com/u-2018/LC-API/issues/49 this one is funny since he solved it before I even managed to see it

main minnow Dec 29, 2023, 3:15 AM

#

jagged trout Now I just do `Path.Combine(Plugin.Instance.Info.Location.Substring(0, Plugin.In...

Path.GetDirectoryName(Info.Location)

#

sorry 😅

#

if you're within the plugin class, that is

#

otherwise

unique sluice Dec 29, 2023, 3:16 AM

#

wdym transpilers @jagged trout ?

main minnow Dec 29, 2023, 3:16 AM

#

Path.GetDirectoryName(Plugin.Instance.Info.Location)

jagged trout Dec 29, 2023, 3:16 AM

#

I was looking for that method

#

I didn't know what it was called

main minnow Dec 29, 2023, 3:16 AM

#

jagged trout I was looking for that method

I've been doing a whole bunch of filepath bullshit to get the Dehumidifier working. So it's fresh in my memory, haha

#

of course, I confused myself a few times -

jagged trout Dec 29, 2023, 3:17 AM

#

unique sluice wdym transpilers <@353782817777385472> ?

https://github.com/u-2018/LC-API/blob/d61b56445be4b0fbb37686448ffc039a2631ae78/LC-API/GameInterfaceAPI/Events/Patches/Player/Hurt.cs#L46-L143 these are transpilers

main minnow Dec 29, 2023, 3:18 AM

#

GetDirectoryName("foo/bar/abc") returns "foo/bar" which is obvious, but if abc is a directory you wouldn't initially think to do GetFileName to get the abc part

unique sluice Dec 29, 2023, 3:18 AM

#

^-^ I made this a few years back https://github.com/NicholasScott1337/SmartBepInMods/tree/master/Tools

GitHub

SmartBepInMods/Tools at master · NicholasScott1337/SmartBepInMods

Library with utilities I use for almost every BepInMod I make. - NicholasScott1337/SmartBepInMods

main minnow Dec 29, 2023, 3:18 AM

#

unique sluice ^-^ I made this a few years back https://github.com/NicholasScott1337/SmartBepIn...

oh you're back!

#

hello

#

yeah @jagged trout https://github.com/u-2018/LC-API/pull/58 is ready for review

jagged trout Dec 29, 2023, 3:19 AM

#

I was just about to test it

main minnow Dec 29, 2023, 3:19 AM

#

hehe sorry

#

jagged trout Dec 29, 2023, 3:19 AM

#

I mean not that there's much to test

main minnow Dec 29, 2023, 3:19 AM

#

true

#

You can also click on the checkmark and get a download of the Thunderstore mod .zip generated by the build action

#

I think

jagged trout Dec 29, 2023, 3:21 AM

#

I don't see it in there

#

regardless

#

seems to be fine

main minnow Dec 29, 2023, 3:22 AM

#

jagged trout I don't see it in there

there should be 'Artifacts' -> build-artifacts.zip

#

the lc-api.version.zip will be inside that somewhere

#

#

It might be that only 2018 can

jagged trout Dec 29, 2023, 3:23 AM

#

main minnow Dec 29, 2023, 3:23 AM

#

yeah

#

we don't have the permissions

#

Oh wait there it is

#

https://github.com/u-2018/LC-API/actions/runs/7353359342

#

Right at the bottom

#

jagged trout Dec 29, 2023, 3:25 AM

#

amazing version

main minnow Dec 29, 2023, 3:25 AM

#

lmao

#

Because it's on a PR branch

#

there's no tags

jagged trout Dec 29, 2023, 3:26 AM

#

yeah

main minnow Dec 29, 2023, 3:26 AM

#

the main branch ones will be more sane

jagged trout Dec 29, 2023, 3:26 AM

#

well aparently there's an alpha

#

0.0.0-alpha.0.73

main minnow Dec 29, 2023, 3:26 AM

#

jagged trout well aparently there's an alpha

I think I set it to increment the pre-release rather than the patch number

unique sluice Dec 29, 2023, 3:26 AM

#

transpiling w/ bepinex was bad 2 years ago, I wonder if it's better now? like some opcodes just didn't show right and not always matching what dnspy showed for example?

main minnow Dec 29, 2023, 3:26 AM

#

jagged trout 0.0.0-alpha.0.73

73 is the number of commits since the last tag

unique sluice Dec 29, 2023, 3:27 AM

#

main minnow oh you're back!

ye, sooory ;~;

main minnow Dec 29, 2023, 3:27 AM

#

so if the commit is tagged 3.2.1 the version will be 3.2.1
if the 3rd commit back is tagged 3.2.1 the version will be 3.2.1-alpha.3

jagged trout Dec 29, 2023, 3:27 AM

#

unique sluice transpiling w/ bepinex was bad 2 years ago, I wonder if it's better now? like so...

I just use harmony do add/remove code instructions as needed

#

you'll see it in my patches for the hurting and dying event

main minnow Dec 29, 2023, 3:28 AM

#

not sure why it's 0.73 though and not just 73

jagged trout Dec 29, 2023, 3:28 AM

#

I just prefer events to be implemented with transpilers as they are the most compatible

#

some make sense as a prefix/postfix as well

#

but most need to go mid code

jagged trout Dec 29, 2023, 3:28 AM

#

main minnow not sure why it's `0.73` though and not just `73`

mystery

main minnow Dec 29, 2023, 3:29 AM

#

jagged trout I just prefer events to be implemented with transpilers as they are the most com...

i don't understand how people can go 'hurr dee durr cancel original method every time' without worrying about compatability

jagged trout Dec 29, 2023, 3:31 AM

#

they aren't thinking of compatibility usually

#

just "need my mod to work"

unique sluice Dec 29, 2023, 3:33 AM

#

Does this look like a reasonable overhead for "no netcode patching" RPCs?

main minnow Dec 29, 2023, 3:35 AM

#

I don't know 🤔

#

what I do know is netcode patching isn't difficult to configure

#

but i do understand it's really annoying

unique sluice Dec 29, 2023, 3:35 AM

#

I got it to patch but it wouldn't send the messages ;~;

#

Probs something I did

main minnow Dec 29, 2023, 3:36 AM

#

I'm not sure whether unpatched RPCs can work at all

#

are you imitating what the patcher inserts in ValidateRPCExecution?

unique sluice Dec 29, 2023, 3:36 AM

#

unique sluice Does this look like a reasonable overhead for "no netcode patching" RPCs?

These do

#

Yeeee ;~;

main minnow Dec 29, 2023, 3:36 AM

#

oooof

#

well if it works

#

power to you

unique sluice Dec 29, 2023, 3:37 AM

#

#

its something

#

I just dont know if it makes sense

#

to someone else

main minnow Dec 29, 2023, 3:38 AM

#

if you're trying to make it a library

#

you could use harmony to runtime patch their RPCs

#

and add your validateRPCExecution automatically

unique sluice Dec 29, 2023, 3:39 AM

#

O.o

#

oooo

#

u smart

main minnow Dec 29, 2023, 3:39 AM

#

then your thing would be identical to netcode for gameobjects RPCs, right?

unique sluice Dec 29, 2023, 3:39 AM

#

right

#

https://tenor.com/QsT6.gif

Tenor

main minnow Dec 29, 2023, 3:40 AM

#

you would need to write a way for other mods to ask your mod 'Hey, please patch my RPCs!!'

#

so that you don't start runtime patching methods that have already been patched by Netcode weaver

unique sluice Dec 29, 2023, 3:41 AM

#

How would I get assembly references to other loaded mods w/o them passing me an Assembly.GetExecutingAssembly()?

main minnow Dec 29, 2023, 3:42 AM

#

what do you need them for?

unique sluice Dec 29, 2023, 3:42 AM

#

Cuz I culd just do a single attribute like [Nyetwork] applied ot the NetworkBehaviour

main minnow Dec 29, 2023, 3:42 AM

#

oh

unique sluice Dec 29, 2023, 3:42 AM

#

Then just patch all those

main minnow Dec 29, 2023, 3:43 AM

#

I wouldn't do it that way

#

if you look in Harmony's sourcecode

#

You can see the implementations for patch discovery

#

You're basically trying to do the same thing as that

#

It's a lot of code

#

I would probably do something like PatchMyNetworkBehaviour<NetworkBehaviour>();

#

public static void PatchMyThing<T>() where T : NetworkBehaviour
{
  
}

#

which users would call in their Plugin.Awake()

#

@jagged trout I have a bone to pick with you

#

public IEnumerator PlaylistCoroutine()
{
  PrepareNextSongInPlaylist();
  while (Boombox.boomboxAudio.isPlaying) yield return new WaitForSeconds(1);
  IncrementPlaylistIndex();
}

#

what the fuck is that

jagged trout Dec 29, 2023, 3:50 AM

#

that's not in LC API, is it?

#

that boombox mod is very rudimentary

main minnow Dec 29, 2023, 3:50 AM

#

jagged trout that's not in LC API, is it?

no, youtube boombox

main minnow Dec 29, 2023, 3:50 AM

#

jagged trout that boombox mod is very rudimentary

I'm forking it to make something even more rudimentary

jagged trout Dec 29, 2023, 3:51 AM

#

I use that to detect when the song is over to play the next song

main minnow Dec 29, 2023, 3:51 AM

#

Yes

#

My plan is to delete that whole boombox controller

#

and let 'sound pack' creators add tracks using JSON files

#

which are downloaded when the game opens

#

no more copyright problems

#

it can download the audio straight to (other) Steven's boombox tracks folder

jagged trout Dec 29, 2023, 3:52 AM

#

Yeah I want to make the ui for yt boombox better at some point

#

but I haven't worked on it in a while

main minnow Dec 29, 2023, 3:53 AM

#

yeah I've already removed the UI from the fork 😅 since I'm going for config-only

jagged trout Dec 29, 2023, 3:53 AM

#

I also suck at UI design.

main minnow Dec 29, 2023, 3:53 AM

#

Lmaoo that's ok

#

Same

#

I love working with people that actually enjoy/know graphic design

#

https://durhack.com

DurHack

The eighth generation of Durham University Computing Society's annual flagship hackathon.

#

I helped make that iteration of the website, I did most of the splash area

#

but jesus I could never have designed it

jagged trout Dec 29, 2023, 3:56 AM

#

Harmony might be the most cursed C# project tbh

main minnow Dec 29, 2023, 3:56 AM

#

😂😂😂😂

jagged trout Dec 29, 2023, 3:56 AM

#

using a stack trace to get the calling assembly lmao idk any other way so I just used that

main minnow Dec 29, 2023, 3:56 AM

#

ExecutingAssembly

#

wouldn't work?

jagged trout Dec 29, 2023, 3:57 AM

#

I don't think so

#

well not always

#

that would get the current assembly

#

We need to get the one that called the method

main minnow Dec 29, 2023, 3:57 AM

#

oh

main minnow Dec 29, 2023, 3:57 AM

#

jagged trout Harmony might be the most cursed C# project tbh

@unique sluice this is what you wanted

jagged trout Dec 29, 2023, 3:58 AM

#

#

https://github.com/pardeike/Harmony/blob/master/Harmony/Public/Harmony.cs#L74-L79

#

I needed the exact same thing to search all their types for NetworkMessage annotations lol

unique sluice Dec 29, 2023, 4:12 AM

#

weird

jagged trout Dec 29, 2023, 5:37 PM

#

jagged trout #32, #42, #45, #46, #48, #51

https://github.com/u-2018/LC-API/issues/61

#

https://tenor.com/view/dj-khaled-another-one-gif-26093316

Tenor

#

If only there was some sorta guide on manual installation for the current version

#

lmao

#

Also

#

I think I'm gonna release 3.2.0 today so that this issue can go away and we can get the networking out

#

I'll just keep my events for the next version

#

Now time to find what my changes are so I can update the changelog

#

Wait I think it was literally just networking and your project restructure right @main minnow ?

main minnow Dec 29, 2023, 5:48 PM

#

yes

#

and CI

jagged trout Dec 29, 2023, 5:48 PM

#

should I even put that in the changelog?

main minnow Dec 29, 2023, 5:48 PM

#

Shruge

#

I would

#

'notable changes'

#

but it's up to you

jagged trout Dec 29, 2023, 5:49 PM

#

it just probably wouldn't matter to devs/users I don't think since they won't usually be interacting with it at all other than seeing the build checks

#

hm

#

idek what I'd put in there for it lmao

lavish parcel Dec 29, 2023, 5:52 PM

#

This mod causes issues joining into regular servers

jagged trout Dec 29, 2023, 5:52 PM

#

LC API will prevent you from joining regular servers at another mod's request

#

it will not prevent you from joining regular servers without another mod telling it to do so

#

ex

lavish parcel Dec 29, 2023, 5:55 PM

#

alright well, I want to use the Coroner mod but thats with LC API

jagged trout Dec 29, 2023, 5:58 PM

#

@main minnow you wouldn't happen to know how to merge tags from a fork would you?

main minnow Dec 29, 2023, 6:00 PM

#

jagged trout <@290259615059279883> you wouldn't happen to know how to merge tags from a fork ...

git pull --tags [fork]
git push --tags [origin]

jagged trout Dec 29, 2023, 6:01 PM

#

I can't push directly to the remote though

#

I don't think

main minnow Dec 29, 2023, 6:01 PM

#

imuncomfortable

jagged trout Dec 29, 2023, 6:01 PM

#

I can push them to my fork

main minnow Dec 29, 2023, 6:01 PM

#

that's the only way to do it

jagged trout Dec 29, 2023, 6:02 PM

#

but I can't get them to the actual main repo

main minnow Dec 29, 2023, 6:02 PM

#

we should just start working out of your fork lmao

#

(no, 2018 just needs to give you the right permissions ...)

jagged trout Dec 29, 2023, 6:02 PM

#

Well I don't want to take the project from them

main minnow Dec 29, 2023, 6:02 PM

#

They quite literally don't want it

#

There's a reason for this:

#

@balmy rover

#

it was previously '2018 HATES lethal company modding'

#

it would be best if they handed over the Thunderstore team to you so we can keep using the front-page project

jagged trout Dec 29, 2023, 6:08 PM

#

The main issue is if we were to move it to a different team, we probably wouldn't ever get recognized because LC API is the most downloaded mod... It would be seen as a knockoff or potentially even as malware. I also think the thunderstore mods would delete it for being a "copy"

#

So moving it to a new team is basically out of the question

main minnow Dec 29, 2023, 6:17 PM

#

main minnow it would be best if they handed over the Thunderstore team to you so we can keep...

This

#

People do not care if the GitHub repo moves or whatever

#

and NuGet doesn't exist yet

#

So the only thing that would need to happen is that ^^

#

I think all they have to do is set you as 'owner'

#

@jagged trout

#

I mean, all we actually need is an API key for the team

jagged trout Dec 29, 2023, 6:20 PM

#

Yeah

main minnow Dec 29, 2023, 6:20 PM

#

It would be preferable if you were able to generate those yourself

#

but Shruge

jagged trout Dec 29, 2023, 6:21 PM

#

wait

#

lmao one sec

#

nvm lmao

#

I thought I had accidentally bypassed the security somehow

main minnow Dec 29, 2023, 6:22 PM

#

😂

jagged trout Dec 29, 2023, 6:22 PM

#

All I did was go to https://thunderstore.io/settings/teams/2018/add-service-account/

main minnow Dec 29, 2023, 6:22 PM

#

kek

jagged trout Dec 29, 2023, 6:22 PM

#

and it had the menu, but when I tried to add it, it just ignored it

main minnow Dec 29, 2023, 6:23 PM

#

ye i would message 2018 and ask if you can be set as owner

#

if no, just a service account would be perfect

balmy rover Dec 29, 2023, 6:28 PM

#

ill probably come back at some point so i just added them as a service account
gamedev requires 100% of my time so once i eventually finish this project i might start working on mods for a little while again
(and its not like i dont want this project, just other stuff is getting in the way of me working on this (and i got burnt out from working on mods all the time))
letrollface

main minnow Dec 29, 2023, 7:13 PM

#

balmy rover ill probably come back at some point so i just added them as a service account g...

sweet! we'll work out of https://github.com/steven4547466/LC-API until such a time as you return

jagged trout Dec 29, 2023, 8:04 PM

#

Thanks to @main minnow after a few versions of testing (sorry) we now have publish workflow that will auto upload the package to thunderstore and nuget

#

Speaking of nuget, you can now reference the package from there! https://www.nuget.org/packages/LethalCompany.LC-API

#

This should streamline development as well as provide the XML docs for you when you use it while I work on actual documentation (eventually™️)

unique sluice Dec 29, 2023, 8:41 PM

#

That's some high tech stuff O.o

small merlin Dec 29, 2023, 10:45 PM

#

I've been receiving issue reports that LC_API makes their clients no longer work with vanilla clients. I don't know if this is a known issue or can be resolved but whenever I try to make LC_API a dependency I get numerous calls to remove it.

grave saffron Dec 30, 2023, 1:11 AM

#

lavish parcel alright well, I want to use the Coroner mod but thats with LC API

They dont use LC API anymore on newest update. Check Coroner again

lavish parcel Dec 30, 2023, 2:07 AM

#

Oh i just got the one where it said it doesnt use lc api lol

jagged trout Dec 30, 2023, 3:02 AM

#

Yeah I believe it's due to the player networking bundle causing network configs to be out of sync

#

I'm thinking of ways around it, but since the player class needs to be networked I'm not entirely sure what I can do at the moment

main minnow Dec 30, 2023, 4:27 AM

#

I don't really get the appeal of playing with different modlists?

jagged trout Dec 30, 2023, 5:36 AM

#

considering LC API provides both client and server sided things I'm not sure it's even feasible to provide the ability to use it without everyone in the lobby needing it

#

same with any other mod that needs a custom network prefab

cyan trout Dec 30, 2023, 8:10 AM

#

@jagged trout i could be doing this wrong but it seems broadcasting a message is host only even tho it says ANYONE can send them

cyan trout Dec 30, 2023, 8:50 AM

#

or atleast very inconsistent if it sends it or not

jagged trout Dec 30, 2023, 12:11 PM

#

@main minnow and I have tested clients sending and it seemed to have worked, can you show me your code?

#

and are there any errors?

#

@cyan trout ^

jagged trout Dec 30, 2023, 1:59 PM

#

Also, my Internet just got turned off, so this might have to wait a few days

#

Depends on if I can convince Xfinity to turn it back on until my next paycheck

cyan trout Dec 30, 2023, 6:34 PM

#

jagged trout <@263412118257139713> ^

        public class ReviveMessage
        {
            public int PlayerId { get; set; }
        }
        public static void BroadcastRevive(int playerId)
        {
            Debug.LogWarning("BroadcastRevive");
            Debug.LogWarning(playerId);
            Network.Broadcast("VIVIKO_REVIVE", new ReviveMessage() { PlayerId = playerId });
        }

        [NetworkMessage("VIVIKO_REVIVE", true)]
        public static void ReviveHandler(ulong sender, ReviveMessage message)
        {
            Debug.LogWarning("ReviveHandler");
            Debug.LogWarning(message);
            Debug.LogWarning(message.PlayerId);
        }```

#

serveral time i tested this and 90% of the time when the non host triggers the broadcast it doesnt send ot the host/everyone else

jagged trout Dec 30, 2023, 7:42 PM

#

There were no errors or anything?

#

Also, if the host sends it, does it work?

cyan trout Dec 30, 2023, 7:52 PM

#

host sending it works 100%

#

non host = 10%

jagged trout Dec 30, 2023, 7:54 PM

#

I'll test it on LAN since I don't have internet atm

#

Yeah I just sent 100 and received 100

#

Exact same code

#

Hm

#

It's sent with ReliableSequnced, so unity netcode should be ensuring it sends

#

I wonder if the issue is on the receiving relay

#

Did you happen to leave and join multiple games?

#

Specifically whoever was hosting

#

Since the host serves the relay

#

The only thing I could think of is somehow the host isn't relaying the message

cyan trout Dec 30, 2023, 8:11 PM

#

testing:
match 1:
host kills client and triggers this - works
client kills host- works
match 2:
client kills host - doesnt work

jagged trout Dec 30, 2023, 8:17 PM

#

What do you mean by "match 2" like second day?

#

Or quitting out of the server and making a new one

cyan trout Dec 30, 2023, 8:32 PM

#

quit that match and hosted another

main minnow Dec 30, 2023, 8:37 PM

#

cyan trout quit that match and hosted another

iiinteresting

jagged trout Dec 31, 2023, 12:49 AM

#

That is weird

#

I do have to unregister the relay and all messages when the server is exited because the network is off, but I did ensure messages were re-registered when a new server was started. I'll have to check that the relay is, too.

#

It's weird that it'd work sometimes though

#

Because that would lead me to assume everything is properly registered

sharp compass Dec 31, 2023, 6:04 AM

#

Seems like hes still gone…

main minnow Dec 31, 2023, 6:04 AM

#

?

main minnow Dec 31, 2023, 9:30 AM

#

@jagged trout are u about?

jagged trout Dec 31, 2023, 3:10 PM

#

My Internet is still off

#

So I can't do much

main minnow Dec 31, 2023, 6:35 PM

#

Could u merge a PR and make a release?

#

The nuget package is auto referencing gamelibs which is annoying for my dev workflow

jagged trout Jan 1, 2024, 9:26 PM

#

Hi

#

internet back

#

I can do that

jagged trout Jan 1, 2024, 9:36 PM

#

main minnow The nuget package is auto referencing gamelibs which is annoying for my dev work...

done for 3.2.3

main minnow Jan 1, 2024, 9:36 PM

#

jagged trout internet back

Woohoo!

jagged trout Jan 1, 2024, 9:36 PM

#

wait

#

build failed somehow

main minnow Jan 1, 2024, 9:37 PM

#

interesting

#

I'll have a look

jagged trout Jan 1, 2024, 9:37 PM

#

#

builds in vs just fine

main minnow Jan 1, 2024, 9:38 PM

#

oh it's a race condition

#

in MSBuild

#

where NetcodePatcher is being executed twice at the same time

#

rerun the task

jagged trout Jan 1, 2024, 9:39 PM

#

seems to be working

main minnow Jan 1, 2024, 9:40 PM

#

basically when we MSBuild it uses only 1 process

jagged trout Jan 1, 2024, 9:40 PM

#

yeah

#

seems to worked

main minnow Jan 1, 2024, 9:40 PM

#

but Github actions runners set a higher process count by default

#

Which means sometimes it's running NetCode weaver 2x in parallel

#

and that would be fine except it means they are both accessing the same logfile

jagged trout Jan 1, 2024, 9:41 PM

#

apparently there's an issue with large network messages where it goes beyond buffer size and needs to be fragmented

main minnow Jan 1, 2024, 9:41 PM

#

oh crikey

jagged trout Jan 1, 2024, 9:41 PM

#

I need to ensure the fragmented channel doesn't interfere with anything

#

unity has built in fragmentation transport, but I need to make sure the relay doesn't mess up

main minnow Jan 1, 2024, 9:41 PM

#

Did you have a chance to investigate network messages originating from clients working intermittently?

jagged trout Jan 1, 2024, 9:42 PM

#

Not just yet

#

I'll create an issue so that I don't forget

#

Also I was kept at work for an extra 2 hours today so I am absolutely out of energy

main minnow Jan 1, 2024, 9:44 PM

#

Good plan

main minnow Jan 1, 2024, 9:44 PM

#

jagged trout Also I was kept at work for an extra 2 hours today so I am absolutely out of ene...

Oooooofff

jagged trout Jan 1, 2024, 9:44 PM

#

so I will probably not be able to get to these until either tonight or sometime tomorrow

jagged trout Jan 1, 2024, 9:45 PM

#

main minnow Did you have a chance to investigate network messages originating from clients w...

Like I said though I'm assuming this one has to do with the relay not being properly re-registered when creating a new game

main minnow Jan 1, 2024, 9:45 PM

#

mm

#

Where do you register the relay?

#

(s)

jagged trout Jan 1, 2024, 9:46 PM

#

In here at the moment: https://github.com/steven4547466/LC-API/blob/main/LC-API/Networking/Network.cs#L329-L373

#

I planned to move them to their own methods

#

so I could unregister the event handler for hot reloading

#

but atm that's a far in the future plan

#

but basically, since the network manager turns off when leaving a game, you have to unregister all the messages

#

then keep re-register them when a new game is joined or (if you're the host) also the relay

#

wait

#

I know exactly why

#

when I unregister them I remove the handler

#

so it doesn't re-register on new game join

#

pain

main minnow Jan 1, 2024, 9:56 PM

#

Create an issue so you don't forget!

#

🤣

#

Rubber ducky method always works

jagged trout Jan 1, 2024, 9:59 PM

#

well it was an easy fix

#

just added a param for whether or not to actually fully remove it

#

and with that I'm dead for about 2-3 hours

#

I'll test it then

jagged trout Jan 2, 2024, 1:04 AM

#

alright

#

just tested main and my local changes on dev

#

didn't work on main, worked on dev

#

pretty sure that's fixed

#

now to see if fragmented has problems

main minnow Jan 2, 2024, 1:06 AM

#

jagged trout pretty sure that's fixed

Awesome!

jagged trout Jan 2, 2024, 1:13 AM

#

Ok and fragmented sequenced seems to just work drag and drop

#

tested it before and after with 1000 randomly generated random length strings

#

failed on reliablesequenced, worked on reliablefragmentedsequenced

main minnow Jan 2, 2024, 1:29 AM

#

noice

jagged trout Jan 2, 2024, 1:29 AM

#

Also I added a vanilla support config option, however, it disables the entire player and item class

#

including related events

#

which makes the API generally useless

#

it would have its Networking still since those don't require synchronization, except the host requires the mod to relay

#

the message would just be ignored on clients that don't have LC API

#

So I'm debating whether or not we should even have it

#

because technically if one player has LC API, the rest are gonna need it for the API to even work

#

So I'm heavily debating whether or not I should even add vanilla support

#

LC API is just a server sided mod now basically

main minnow Jan 2, 2024, 1:51 AM

#

right I see what you're saying

#

what about asset bundle loading?

#

since thats what basically all of these clientside mods were using lc api for

main minnow Jan 2, 2024, 2:11 AM

#

@paper flare are you using Day's runtime netcode patcher?

#

oh what

paper flare Jan 2, 2024, 2:12 AM

#

Nope, using netcode weaver

main minnow Jan 2, 2024, 2:12 AM

#

what the fuck

paper flare Jan 2, 2024, 2:12 AM

#

hi

#

xD

main minnow Jan 2, 2024, 2:12 AM

#

but you're

#

you're doing it at runtime

paper flare Jan 2, 2024, 2:12 AM

#

me?

#

what

main minnow Jan 2, 2024, 2:12 AM

#

i'm so confused

#

ohhh

#

never mind

#

i understand

#

okay i need to add csproj tasks for netcode weaving then...

#

muh

paper flare Jan 2, 2024, 2:13 AM

#

hwuheehhe

main minnow Jan 2, 2024, 2:13 AM

#

you're lucky i've done this before

main minnow Jan 2, 2024, 2:59 AM

#

woops that was wrong channel

#

@jagged trout are you alive

main minnow Jan 2, 2024, 3:16 AM

#

well, when you're back

jagged trout Jan 2, 2024, 4:58 AM

#

@main minnow your PR build fails

main minnow Jan 2, 2024, 4:59 AM

#

It doesn't

#

it's the same problem as before

#

Rerun the task

jagged trout Jan 2, 2024, 4:59 AM

#

What is the difference anyways?

main minnow Jan 2, 2024, 4:59 AM

#

I renamed the action

#

The old one doesn't exist

jagged trout Jan 2, 2024, 5:00 AM

#

works

#

Did this need a release?

main minnow Jan 2, 2024, 5:00 AM

#

No

#

It's purely a workflow change

jagged trout Jan 2, 2024, 5:01 AM

#

ok

#

I was gonna go to bed

#

When I wake up tomorrow I'm gonna test the dev branch make sure there's no problems then release

#

but I am very tired

main minnow Jan 2, 2024, 5:02 AM

#

Get yourself some good rest brother

#

no rush on the release

jagged trout Jan 2, 2024, 2:39 PM

#

You know

#

I could technically set up the Player behaviour to use custom network messages...

#

seems very silly, though

#

since they work in a static context, I'll have to pass the player id along the message and get the actual player out on the receiving end

#

I do lose the ability to use NetworkVariables, though

#

Which I currently use to set the player's network id from the host to ensure they sync with clients and that all clients have proper IDs

proven terrace Jan 2, 2024, 8:44 PM

#

Who is maintaining this now? I thought Bobbie took it for a while but I'm not sure

jagged trout Jan 2, 2024, 8:44 PM

#

I am

#

I am the only other person with access to the team

proven terrace Jan 2, 2024, 8:46 PM

#

Okay, thanks

uncut raptor Jan 4, 2024, 10:53 PM

#

I think LC API is breaking my game

edgy orbit Jan 5, 2024, 7:56 PM

#

uncut raptor I think LC API is breaking my game

Yea don't use it

#

I removed it and never had a problem since

#LC_API