✅RenoDX: Trails in the Sky 1st Chapter

[raven sequoia]

Build for the Demo

• Latest Build

• Replace the brightness scaling with Tonemapping (DICE, Frostbite, RenoDRT).

• Unclamp Bloom Saturation

• Replace the game's 2.3 Gamma with sRGB + GammaCorrection.

• Both Game and UI brightness are controllable by reno sliders

[spice venture]

What should the in-game sliders be set to?

and am I supposed to set the gamma to falcom or srgb?

[raven sequoia]

in game brightness is ignored, you can set the UI brightness to max and then use renodx's slider

gamma is IMO srgb

the difference is very subtle but the gamma correction can generate some wide color gamut

[spice venture]

anything else to change?

[raven sequoia]

Saturation and the output color space is up to you

if you like saturated or colder colors

[spice venture]

ok, and DICE is correct, yes?

just asking because Reno is another option 😄

[raven sequoia]

DICE is my favourite in games like this

[spice venture]

I see, thanks!

[scenic shore]

I'd suggest setting working color space to bt2020

[spice venture]

I'll have to get used to the reduced brightness now. Always the same with these games

[scenic shore]

although that might only apply to renodrt

not sure

btw @raven sequoia , I had a quick look, and it seems like they're doing the bloom with screen blends

which is kinda sdr only

0xD6CF040B

[raven sequoia]

oh

[scenic shore]

I don't know what's best to do there xD and if there's some hdr replacement for screen blend

this seems to work well tho

I'm just doing log and then inv log at the end (so the values stay between 0..1)

[raven sequoia]

interesting interesting

[scenic shore]

also tried, reinhard + inv reinhard, and that looked horrendous

[raven sequoia]

I think that looks amazing, thanks @scenic shore

[scenic shore]

nice, np

I think skin tones kinda look a bit too red

[raven sequoia]

do you change blending in LogSpace, and then exp back

[scenic shore]

yea it logs all textures, game scene + bloom textures

and then exp back at the end

[raven sequoia]

maybe this can fix the other Falcom games as well

[scenic shore]

ohh right you had issues with bloom there too right

[raven sequoia]

yes

[scenic shore]

how did you fix it there

looked great from the screenshots

[raven sequoia]

I had to multiply the preblended bloom with the scaled y

[scenic shore]

so the bloom was already combined into one texture, and then you multiplied it with the lum?

[raven sequoia]

yes

in the final shader

[scenic shore]

ic ic

do you have your code up on github

want to take a look xD

but it seems like they're doing things differently here

compared to ys8 + 9

[raven sequoia]

I didn't expect that lerping in log space like this could make bloom hdr like this

because I thought its already fp16

[raven sequoia]

I do but that game is very messy

https://github.com/DanaForever/renodx/blob/main/src/games/senkiseki/cs4/final_0x3E08A3A6.ps_4_1.hlsl

https://github.com/DanaForever/renodx/blob/main/src/games/senkiseki/cs4/common.hlsl#L383

you can see the number of artifact shaders

[scenic shore]

holy shit

seems like a ton of work

[raven sequoia]

you can redownload the build. Adrian fixed the bloom, so the game is HDR now

[raven sequoia]

I tried to fix the broken bloom caused by upgrading textures

[spice venture]

looks kinda broken now in the main menu

I have to reduce the ui brightness now, I guess?

but the game also looks super bright now

[raven sequoia]

it looks like HDR is disabled

[spice venture]

hmmm

and it worked with the old version

[raven sequoia]

how about this

hopefully this works

[spice venture]

seems fine now

ah but videos are black 😄

easy to test with the startup movies

[raven sequoia]

crap

looks like upgrading textures breaks movies

no wonder why I don't see any "Gungho"

[static charm]

Its a feature to skip intro 😅

[raven sequoia]

now Gungho is back so hopefully the videos are back as well

and HDR still works with TAA/FXAA

[cursive kraken]

everyones faces look red messed with the options bit still a bit red

[scenic shore]

yea thats due to my bloom "fix" def needs hue correction

[cursive kraken]

Is there a way to turn it back anddeal with the bad bloom?

The pink skin is more distracting for me lol

[scenic shore]

@raven sequoia I rewrote the blending shader a bit, so that colors and skin tones are better

with a hdr screen blend I found on this server lol

seems to work well

you could add sliders for the hue and chrominance correction at the end there

they're just to desat highlights a bit, and fix hues

[cursive kraken]

Ah right new to this how do I add this?

[scenic shore]

you don't :D @raven sequoia will maybe add it to the mod when they have time

[cursive kraken]

ahh i see no probs

[raven sequoia]

oh I just did similar things

float4 linearBloom = blendBloomLinear(samLinear_s, v1);

o0.rgb = renodx::color::correct::Hue(o0.rgb, linearBloom.rgb, 1.0f);

just run the original shader in LInear and then hue correct

[scenic shore]

Vanilla HDR (w/ final shader fix) | HDR + custom bloom | SDR

[scenic shore]

yea but that hdr blend is way better than the log method xD I think

[raven sequoia]

I see I see

[scenic shore]

it's kinda crazy how off vanilla hdr looks

due to it missing the saturate for that bloom shader

[raven sequoia]

the new blend code seems to generate some invalid colors in the fire

(removing huecorrection fixes it but obviously we need it)

[scenic shore]

ah. maybe lower the intensity to 0.75 or 0.5

maybe surrounding that hue correct with something like this could also work

outputColor = renodx::color::bt709::from::BT2020(outputColor);
outputColor = renodx::color::correct::Hue(outputColor, vanillaSdr, CUSTOM_HUE_CORRECTION);
outputColor = renodx::color::bt2020::from::BT709(outputColor);

[raven sequoia]

I forgot to ask, did you also mod this shader 0xCDE6FA28

I needed to remove those saturation to unclamp bloom

[raven sequoia]

Can you help me check if this one reduces the pinky face shade for you?

I am still using the Log-space Bloom because I can't find a setting for the new one's Hue Correction

if you still find the face too red, try to use the Frostbite tonemapper

[raven sequoia]

I don't understand how you have BT2020 outputColor here 😄

[scenic shore]

No, was just using native HDR + live loaded shaders via devkit. So taa is still clamped for me, was using smaa, but bloom worked

[scenic shore]

Idk might be meme code 😅 (it's changing the color primaries, but I still need to fully read up on how that all works)

But I think that helped me with artifacts due to hue correction in the past

You could also try a simple bt2020 clamp before and maybe after

[cursive kraken]

I tested it definitely more natural skin tones, frostbite gets rid of the pink skin however blues and yellows look unsaturated so I prefer DICE overall even if the skin tone is still slightly too red

[raven sequoia]

I hate Falcom's bloom 🙃

[raven sequoia]

I don't understand why Adrian's blending method loses details compared to the linear one (right)

[scenic shore]

it's not the blending method that makes the difference here (I think)

the bloom shader leaves a bit of additional highlight detail, which then gets clipped in sdr

but in hdr they just leave it unclamped which then produces those bad hue shifts

the lamp turns weirdly pink for example

[scenic shore]

or the sky is deep blue + purple, which it shouldn't

that's why I added a saturate after the sdr run

instead of just saturating you could try o0.rgb = saturate(renodx::tonemap::dice::BT709(result, 1.f, 0.5f));

SDR as comparison

if you leave out the chrominance correction the glass is still super saturated

and that the texture of the glass gets obscured is caused by the bloom, which kinda blurs it

[spice venture]

this looks kinda strange, no?

[raven sequoia]

I noticed that you removed the max(0, x) in the original bloom blend

1 - (1 - base) (1 -blend)

clamping the oneminus fixes the broken colors for hue and chrominance correction

[raven sequoia]

are you still online ?

@scenic shore I realized that they did blending in srgb (or an encoded space), so I tried srgb decoding the gameScene and blur textures

looks good to me, no red face, clear texture on Aidios glass, but the sky and lamps aren't as bright 😄

the lamps look naturally yellow to me

(assuming the blending equation is for linear inputs)

@spice venture if you're interested, I am genuinely happy with this 🤗

[scenic shore]

oops sorry

[scenic shore]

in which shader do they gamma encode

[scenic shore]

the sky looks too deep blue here compared to sdr, you need to saturate the vanilla output for proper sdr like colors

[raven sequoia]

I dunno, I also don't want to believe that the textures are in srgb but looks like they are

[raven sequoia]

yes, I set hue shift to 0 in that shot, I think the ideal is 50 (hue and chrominance correction)

[scenic shore]

do they really render the entire game in gamma? lol

[scenic shore]

yea but you don't have the saturate in your code, which inherently happens in sdr, so the hues don't quite match with sdr

[scenic shore]

.

the bloom shader isn't any different between sdr and hdr I think

but sdr obviously clips

and you need that clip for the sky for example

[raven sequoia]

at least it makes the new bloom blending works 😁

I tonemapped at the shader before the UI so we can also reno UI brightness sliders

[scenic shore]

just compared it, and doing srgb decode and encode afterwards just lessens the bloom effect

compared to vanilla

[raven sequoia]

yes its no longer as bright

do you think its muted?

[scenic shore]

yea

[scenic shore]

but bright colors and skin tones don't get as saturated anymore, which is great. still needs a little blowout/chrominance corr for the sky

you can just multiply blend by 5 to make the bloom stronger/like vanilla again

with your linear bloom blend (w/ srgb decode + encode)

you can add a bloom slider too that way

float3 hdrScreenBlend(float3 base, float3 blend) {
  blend *= 5;
  blend *= CUSTOM_BLOOM;
  float3 color = base + (blend / (1.f + base));
}

that hdr blend is really meant to be done in linear, and not gamma

[raven sequoia]

maybe I am using a Mini LED so the blur textures' effects are a bit too strong at 5. But I would make a slider, default at 2 which has the same intensity with vanilla.

[hearty junco]

awesome 😮

[scenic shore]

perceptually, at least to me, the bloom at *= 5 looks closest to vanilla sdr

@raven sequoia this is the correct vanilla bloom btw

float3 vanillaSdrBlend(float3 base, float3 blend) {
  return blend * max(0, 1 - base) + base;
}

got it wrong, mb

but it looks the same with a saturate as the screen blend func before, and the same as vanilla sdr

and if you don't saturate the output, it looks like vanilla hdr

[raven sequoia]

I ran the original function because my head wasn't able to rewrite the code 😄

for some reason I think bloom = 1 or 2 already matches vanilla's intensity (normalized to the same paper white, not their crazy HDRBrightness)

maybe because I am using DICE, which saturates more than RenoDRT

[scenic shore]

I was using Lilium's DICE shader just for testing

[scenic shore]

maybe thats true if you look at the glass in that cathedral or whatever, but the bloom outside looks to be way stronger than 2 imo

like how it blooms around houses and trees

[scenic shore]

you can just follow the code backwards

like so, for this code snippet, the first blend

r3.xyz = float3(1,1,1) + -r2.xyz;
r3.xyz = max(float3(0,0,0), r3.xyz);
r1.xyz = r1.xyz * r3.xyz + r2.xyz;

l3
r1.xyz = r1.xyz * r3.xyz + r2.xyz;

replace r3 with l2
r1.xyz = r1.xyz * max(float3(0,0,0), r3.xyz) + r2.xyz;

and then replace r3 with l1 again
r1.xyz = r1.xyz * max(float3(0,0,0), float3(1,1,1) + -r2.xyz) + r2.xyz;

and simplify
r1.xyz = r1.xyz * max(0, 1 - r2.xyz) + r2.xyz;

and we know r1 is blur1, and r2 game
blur * max(0, 1 - game) + game

[raven sequoia]

thanks @scenic shore

[raven sequoia]

@scenic shore I decided to check other bloom/godray shaders and see if I should do all of them in linear instead of srgb. The Sun looks more appropriate with this (left = new, right = vanilla srgb blending).

not sure if I am insane or not

https://github.com/DanaForever/renodx/blob/Sora1st/src/games/sorakiseki/bloomgodray_0x1343A4D6.ps_5_0.hlsl#L34

this shader specifically, but I also rewrote other bloom shaders that generate the blur masks

[scenic shore]

wow yea, they're using their weird screen blend there too lol

looks way better now

in sdr I think the sun is just a white blob

[grim yarrow]

this game is putting my 5090 to work, im kinda shocked

[cursive kraken]

Yeah kind of wish it had DLSS my 4080 is getting around 80-90 fps at the beginning area at 4k

[static charm]

Try to turn down SSAO to medium/low with no noticeable difference (for me at least).
SSAO on high is performance hogs

[quartz mica]

what frame rate?

I was able to push for 8k 60 in the overworld

after pushing ssao down to medium

[grim yarrow]

225

[quartz mica]

[grim yarrow]

3440x1440

[quartz mica]

ok that makes more sense

[grim yarrow]

I mean it pulls 500+ watts to do it, I don't think that's terribly normal

Its not path traced

But it's all settings on max, it's fine, it looks nice

I'll try the ssao thing

[quartz mica]

yea with ssao turned down

downsampling from insane res is possible

the game has no dlss and it really shows

[grim yarrow]

I'm really excited for this game though

This is going to be an incredible remake

[raven sequoia]

if you use our addon, please feedback about the rewritten Bloom

if its distracting on OLED

there is a slider for Bloom strength and another one for saturation (0 = no correction = most saturated)

[trail hinge]

It's pretty much perfect for me on LG C1. Peak brightness set to 800, Bloom and Saturation at default values. Looks almost exactly like your screenshot [here](#1408042751550951474 message)

Although I sometimes have issue when using SpecialK passthrough; where the addon is loaded but the colours are washed out. Restarting the game fixes it, so it's most likely an issue with SK.

[hearty junco]

You probably have to re-enable hdr in game

[trail hinge]

Late reply, but you're right. HDR was off when I checked it. Thanks!

[worldly schooner]

Man, they really went all out on the "cooking the entire image at all time" in this game 😄

[quartz mica]

yea

[raven sequoia]

do you mean its bright?

[worldly schooner]

Out of the box yeah, insanely so

The mod is massively helping

[mystic igloo]

I've been encountering some weird issues where the this black void shows up and begins to fill up the whole screen. Normally it goes away, but I found this instance where it kept going.

I don't know if this is something wrong with the mod, or the game being super well put together itself. I was using the version linked on the renodx wiki page, unless there's a more up-to-date version to use.

[raven sequoia]

can you send me a save file?

[mystic igloo]

It doesn't happen all the time, and there's nothing in particular that I can see that triggers it

Okay. So it only seems to go away if all of it is moved off screen

video if it helps at all

[raven sequoia]

thanks, I loaded the save but couldn't replicate it yet

[mystic igloo]

This is the first time I've seen something like this, so I'm really hoping its not actually my GPU trying to fry itself.

I'll keep an eye out for if there's anything that specifically triggers it though. The last few times were while in combat though (field or command)

[raven sequoia]

I added some safeguards against 0 during blending

maybe it helpss

[mystic igloo]

Cool. I'll take a look with that one

Thanks!

[mystic igloo]

I haven't seen anything since, so I think that may have done it!

[raven sequoia]

new bloom suggested by @scenic shore and Musa

[wicked crane]

✅RenoDX: Trails in the Sky 1st Chapter

[raven sequoia]

We''re moving to a new home https://discord.com/channels/1408098019194310818/1410855640112566375/threads/1416613436623818863/1416613436623818863

(1 post for all kiseki stuffs)

[spice venture]

it's locked; edit: you have to join the new RenoDX server to be able to click this link 😄

[raven sequoia]

looks like it requires an invitation first https://discord.gg/jGuNsD2v

[spice venture]

noticed the new server right now, thanks

[raven sequoia]

its not ideal but at least we can still make and share mods

[opaque cipher]

What new server?

[glad girder]

if I want the latest version, should I get it from the renodx github or from here? It says the snapshot is from july for Trails in the Sky

[quartz mica]

github

[grim yarrow]

https://discord.gg/MsbPnKRpQ3

[quartz mica]

are you supposed to max out the in game ui brightness?

[grim yarrow]

yes

[wary harness]

Is this okay? I have an LG OLED G4, I don't know if I also need to increase the nits or not, etc... and another thing, the gamma option isn't showing up, is that normal?

[misty basalt]

hello guys. How fix this?

[worldly schooner]

If you have a Nvidia GPU, do not force a anisotropic filtering level via the driver or Special K

[misty basalt]

I'm not forcing it