updater

[silver crystal]

What do you need help with

[blazing vector]

my updater kind of works but it can't get direct download of my gh release

[mint storm]

debug it

take a look why the download URL isn't set

e.g. do you get the correct response from the api?

[blazing vector]

it's because of redirects

[mint storm]

what redirects?

[blazing vector]

 // Construct direct download URL from tag_name
+    char downloadUrlBuffer[512];
+    sprintf_s(downloadUrlBuffer, 512, "https://github.com/%s/releases/download/%s/noteplus.exe", GITHUB_REPO, tagStart);
+    char *downloadUrl = _strdup(downloadUrlBuffer);```

`https://github.com/owner/repo/releases/latest/download/app.exe

https://api.github.com/repos/owner/repo/releases/latest`

Those are samples only, but to give you an idea what what redirects look like.

[mint storm]

you mean this?

[blazing vector]

yes

any clue?

idk actually

@mint storm

new code but didnt wor

[shell dirge]

@blazing vector has reached level 4. GG!

[blazing vector]

k

 // Update available - parse assets for download URL
+    char *assetsStart = strstr(response, "\"assets\":[");
+    char *downloadUrl = NULL;
+    if (assetsStart) {
+        // Find assets and look for noteplus.exe specifically
+        char *asset = assetsStart;
+        while ((asset = strstr(asset, "\"name\":\"")) != NULL) {
+            asset += strlen("\"name\":\"");
+            char *nameEnd = strchr(asset, '\"');
+            if (!nameEnd) break;
+            *nameEnd = '\0';
+            if (strcmp(asset, "noteplus.exe") == 0) {
+                // Found noteplus.exe, now find browser_download_url
+                char *urlAsset = strstr(nameEnd + 1, "\"browser_download_url\":\"");
+                if (urlAsset) {
+                    urlAsset += strlen("\"browser_download_url\":\"");
+                    char *urlEnd = strchr(urlAsset, '\"');
+                    if (urlEnd) {
+                        *urlEnd = '\0';
+                        downloadUrl = _strdup(urlAsset);
+                        break;
+                    }
+                }
+            }
+            asset = nameEnd + 1;
+        }
+    ]```

[mint storm]

the new location is in the response headers

[blazing vector]

how about this? #1439663605393129674 message

[mint storm]

i don't know what you changed or whatsoever

i didn't read your code

[blazing vector]

let me end the new one

that previous one is cancerous

[mint storm]

what are you even trying with that

[blazing vector]

redirects

[mint storm]

by doing what exactly?

[blazing vector]

parsing the assets array for the browser_download_url

[mint storm]

wasn't your problem the redirect?

[blazing vector]

vscode kinda does it like that in some ways

[blazing vector]

yes

[mint storm]

how does that solve it?

[blazing vector]

i am just trying different ways to solve it

but yeah my issue is ith the redirect

[mint storm]

what

[blazing vector]

is this an issue or just a best practice related topic

[mint storm]

how would that solve your problem

[mint storm]

only a issue if your exe file in the release isn't noteplus.exe because your code specifically searches for noteplus.exe

[blazing vector]

in the gh asset yes

[mint storm]

maybe dont jump around multiple issues, that's very confusing

solve one issue and then the next

[blazing vector]

sure sure

how to solve the first one

[blazing vector]

yi combinateit with this code right #1439663605393129674 message

right?

i don't get it lol

[blazing vector]

like

follows redirects to get the actual location from the "new" field in
the response headers.

?

if yes i did try that and it didn't work

[mint storm]

wdym with "didn't work"?

what's the problem?

[blazing vector]

download failed

can't download the file

[blazing vector]

this one that gets invoked

hm

@mint storm

i got it working

but

[mint storm]

but what?

[blazing vector]

i fixed the download thing

but overwrites the existing exe

is fucked up

[mint storm]

sure

[blazing vector]

😭

[mint storm]

so how are you planning to solve that?

[blazing vector]

no idea

i used the CopyFileW

but uh

:\

[mint storm]

currently you have a noteplus.exe that is opened and you download a new version of it and you want to replace the old one with the new one

think of a possible solution

do you understand why it's currently technically not working?

[blazing vector]

a batch injection code

that kills the obsolete exe

and replaces with the new one

[mint storm]

something like that is a possible solution yeah

[blazing vector]

i did it

[shell dirge]

@blazing vector has reached level 5. GG!

[blazing vector]

but it works like shit

[mint storm]

whats the problem?

[blazing vector]

it still corrupts

it

[mint storm]

why?

and how?

[blazing vector]

sprintf(batchContent,
        ":loop\n"
        "tasklist /FI \"IMAGENAME eq noteplus.exe\" | find /I \"noteplus.exe\" >nul\n"
        "if not errorlevel 1 (\n"
        "    timeout /t 1 /nobreak >nul\n"
        "    goto loop\n"
        ")\n"
        "move /Y \"%s\" \"%s\"\n"
        "start \"\" \"%s\"\n"
        "del \"%%~f0\"\n",
        tempExe, exeA, exeA
    );```

[mint storm]

what do you do with it?

[blazing vector]

in temp files

[mint storm]

what does that show me?

[blazing vector]

hold on

i am trying something with tasklist

[blazing vector]

ah shit my trick didn't work

• Downloads exe from temp

• batch inject to force kill the app and copies the nw one

• delete traces

the batch doesn't even get executed

the problem is it's downloading FINE

the copying is corrupted

its like

i t copies half of it

i am going insane

i swear

THE APP IS JUST A FEWJBS

@mint storm pls help

i get hit with compatibility error

[mint storm]

does it work when you download it through your browser from gh?

[blazing vector]

it works fine

[mint storm]

ah

copying from noteplus_new.exe to noteplus.exe?

[blazing vector]

yes

but it renames it

yk

[mint storm]

what do you mean by that then? isn't the batch doing the copying?

[blazing vector]

yes

it copies it wrong

[blazing vector]

@mint storm

[blazing vector]

@silver crystal can u please help me with installation process?

[shell dirge]

@blazing vector has reached level 6. GG!

[blazing vector]

I fixed the download process

[silver crystal]

what's the issue

@blazing vector also do not ping people for help

[blazing vector]

I kindly asked for help

The script i made doesn't copy the updated exe properly

[blazing vector]

😭

another day to go without getting help

[silver crystal]

can you explain what your issue is?

[blazing vector]

i made an updater for my notepad , the updater manage to get the exe from github but the copying isn't working perfectly on it

[silver crystal]

I'm going to need more info than that, there's literally nothing I could do or say only based on that info

[blazing vector]

the code?

[silver crystal]

and what the problem is

[silver crystal]

big code snippets should be shared using pastebin/git or some other kind of online sharing service

[blazing vector]

ipba

n

i can't

[silver crystal]

why not?

[blazing vector]

ipban?

[silver crystal]

you got ipban on every online sharing service that exists?

[blazing vector]

let me send u the file from my gh repo

[blazing vector]

https://github.com/etyuiudfvgg-source/noteplus/blob/main/src/updater.c

[silver crystal]

alright, so what's the issue

[blazing vector]

updater doesn't copy the updated exe properly but instead it creates a corrupted exe file

[silver crystal]

what have you tried so far

[blazing vector]

tried the trick of using batch file

tried making the exe writes new bin date by itself and reboots but it was worse

the file size gets huge

1gb exe

[silver crystal]

have you tried running the batch manually or running the commands by hand?

[blazing vector]

i did yes

but it still gives corrupted exe

[silver crystal]

alright then your issue is not with your code it's with your commands

did you try the .bat or the commands?

[blazing vector]

both

[silver crystal]

can you show the commands you ran exactly

[blazing vector]

the manual one? via cmd?

uhhh

[silver crystal]

yes

[blazing vector]

i forgot the commands

[blazing vector]

they are the same as it had in batch

bu t ran directly

[silver crystal]

yeah, can you show them?

[blazing vector]

#1439663605393129674 message

but instead of tasklist it's tasskill

[silver crystal]

I'm asking to see the commands you ran, not your C code

[blazing vector]

the bracket

[blazing vector]

:loop
tasklist /FI "IMAGENAME eq noteplus.exe" | find /I "noteplus.exe" >nul
if not errorlevel 1 (
    timeout /t 1 /nobreak >nul
    goto loop
)

move /Y "C:\path\temp.exe" "C:\path\noteplus.exe"
start "" "C:\path\noteplus.exe"

[silver crystal]

you're doing your things in the C:\path\?

[blazing vector]

yes , in stable code it does it in temp folder

the windows's temp folder

[silver crystal]

have you tried just running move /Y "C:\path\temp.exe" "C:\path\noteplus.exe"

[blazing vector]

yes

[silver crystal]

and that doesn't work either?

[blazing vector]

noù

[silver crystal]

I have a hard time believing that

maybe you can record a video

[blazing vector]

LMAO

[silver crystal]

?

maybe we can spot what's wrong

[shell dirge]

@blazing vector has reached level 7. GG!

[silver crystal]

@blazing vector don't upload binaries here

[blazing vector]

i am setting to record a video

[silver crystal]

that's fine

[silver crystal]

I just tried the command and it worked for me

[blazing vector]

😐

(can't be executed)

[silver crystal]

ok but I don't know what you did to get that

[blazing vector]

afte using the move cmd 💀

[silver crystal]

can you give a step by step of what you are doing exactly

[blazing vector]

i am having a doubt with my download method ...

[silver crystal]

did you try running the file before the copy/move...

[blazing vector]

no

[silver crystal]

lmao

then why do you think the move is the issue?

[blazing vector]

wait wait a minute

the size

the updated exe size is 282 kb

[silver crystal]

what about the size

[blazing vector]

the one in release is just a bit smaller

[silver crystal]

I don't know what you are talking about

[blazing vector]

https://github.com/etyuiudfvgg-source/noteplus/releases

https://cdn.discordapp.com/attachments/1439663605393129674/1440075526780747947/image.png?ex=691cd658&is=691b84d8&hm=a1ccfbee23e135e13747a9787eeeb234d62ac1a8b2228bac6fd97d842538e29d& compare the size

[silver crystal]

ko is not the same as kb

[blazing vector]

ah yeah right

[blazing vector]

guess what

[silver crystal]

I just tried this with your executable and it worked

[blazing vector]

what did u try

[silver crystal]

there's probably a problem with your download

[silver crystal]

download notepad.exe

[blazing vector]

the updater works?

[silver crystal]

copy it to C:\path

run it

rename to temp.exe

run move /Y "C:\path\temp.exe" "C:\path\noteplus.exe"

run it again

and it worked

[blazing vector]

no

there is still an issue

the downloaded exe file that is from cache is corrupted

[silver crystal]

the issue is probably with the downlaod then

not the copy command

[blazing vector]

yes

i don't know what's the issue

[silver crystal]

you're downloading the html page lmao
https://github.com/etyuiudfvgg-source/noteplus/blob/main/src/updater.c#L37

nevermind I see https://github.com/etyuiudfvgg-source/noteplus/blob/main/src/updater.c#L114

so what's the generated link?

that you actually download

[blazing vector]

💀

[blazing vector]

htmurl ....

[silver crystal]

yes can you print the actual link?

[blazing vector]

1min to debug

but it's htmurl obj

[silver crystal]

idk what that means

[blazing vector]

wait i have to ensure the URL points to the actual executable file ( the browser_download_url from GitHub assets)?

[silver crystal]

idk what that means

[blazing vector]

Confirm Download URL

X

?

Download URL:
https://github.com/etyuiudfvgg-source/noteplus/releases/download/1.1.0/noteplus.exe

Do you want to proceed with the download?

Oui

Non

[silver crystal]

that url is not correct

[blazing vector]

wharra do

[silver crystal]

idk what that means

[blazing vector]

what to do

[silver crystal]

fix the url lol

[blazing vector]

i have no idea, the constants are not wrong and like

[silver crystal]

where did you get that URL?

[blazing vector]

i followed the gh docs 😭

[silver crystal]

link?

[blazing vector]

base url plusrepo path plus

[silver crystal]

I mean, do you have the url to the doc you followed?

[blazing vector]

i constructed it manually ;-;

hold on

[blazing vector]

https://docs.github.com/en/rest/releases/releases

[silver crystal]

that's a link to the API

I don't see where it tells you how to construct a download URL

[silver crystal]

you're missing the v in front of v1.1.0

[blazing vector]

oh

[blazing vector]

it's workinggggg

[blazing vector]

also are u familiar with batch?

[silver crystal]

somewhat

[blazing vector]

like, it doesn't show that the bbuild is successful

it just show Building Noteplus and then exits

[silver crystal]

that's horendous

[blazing vector]

(to silence some noisy shit)

ohh ifixed it

but uhhh

howto deal with broken pipe error from windres