uno game help | C++ | Page 1

craggy mango Dec 13, 2024, 8:41 PM

#

cpp```
void initializeDeck() {
string colors[] = {"Red", "Green", "Blue", "Yellow"};
string values[] = {"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "Draw Two", "Skip", "Reverse"};
for (const string &color : colors) {
for (const string &value : values) {
deck.push_back({color, value});
if (value != "0") {
deck.push_back({color, value});
}
}
}
for (int i = 0; i < 4; i++) {
deck.push_back({"Wild", "Wild"});
deck.push_back({"Wild", "Draw Four"});
}
random_shuffle(deck.begin(), deck.end());
}

hey, i have a class assignment where i have to code a game and i chose uno, this part of the code keeps giving me errors, can someone please help me out with this?

undone rose Dec 13, 2024, 8:47 PM

#

craggy mango cpp``` void initializeDeck() { string colors[] = {"Red", "Green", "Blue"...

Where is deck declared? is it a global variable?

#

I'll assume you also put using namespace std; somewhere as well

craggy mango Dec 13, 2024, 8:59 PM

#

this is whats before that section

#include <iostream>
#include <vector>
#include <cstdlib>
#include <ctime>
#include <string>
#include <algorithm>

using namespace std;

struct Card {
    string color;
    string value;
};

class UNOGame {
private:
    vector<Card> deck;
    vector<Card> player1Hand, player2Hand, player3Hand, player4Hand;
    Card topCard;
    int currentPlayer;
    int totalPlayers;
    bool reverseOrder;

lunar mothBOT Dec 13, 2024, 8:59 PM

#

@craggy mango has reached level 1. GG!

undone rose Dec 13, 2024, 9:00 PM

#

It looks like void initializeDeck needs to be made a method of UNOGame

#

the general structure of a class that is declared in source code is as follows

#include <iostream>

class Dog {
public:
Dog(const std::string &name) { // The constructor. Sets member variables to arguments passed to the constructor function, and performs any other necessary functions
  setName(name);
} 

void Bark() {
  std::cout << "Bark!\n";
}

private:
void setName(const std::string &name) {
  this->name = name;
};

#

You're going to want to create a public member void initializeDeck() inside of the UNOGame class that way it has access to the private members.

craggy mango Dec 13, 2024, 9:09 PM

#

sorry to bother, but how do I do that

undone rose Dec 13, 2024, 9:09 PM

#

No worries!

#

It would look like this:

class UNOGame {
public:
void initializeDeck() {
  // stuff here
}

private:
 // etc.
};```

craggy mango Dec 13, 2024, 9:18 PM

#

so like this?

class UNOGame {
public:
    void initializeDeck() {
        string colors[] = {"Red", "Green", "Blue", "Yellow"};
        string values[] = {"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "Draw Two", "Skip", "Reverse"};
        for (const string &color : colors) {
            for (const string &value : values) {
                deck.push_back({color, value});
                if (value != "0") {
                    deck.push_back({color, value});
                }
            }
        }
        for (int i = 0; i < 4; i++) {
            deck.push_back({"Wild", "Wild"});
            deck.push_back({"Wild", "Draw Four"});
        }
        random_shuffle(deck.begin(), deck.end());
    }
private:
    vector<Card> deck;
    vector<Card> player1Hand, player2Hand, player3Hand, player4Hand;
    Card topCard;
    int currentPlayer;
    int totalPlayers;
    bool reverseOrder;
    
    void dealCards() {
        while (!deck.empty()) {
            player1Hand.push_back(deck.back());
            deck.pop_back();
            player2Hand.push_back(deck.back());
            deck.pop_back();
            if (totalPlayers > 2) {
                player3Hand.push_back(deck.back());
                deck.pop_back();
            }
            if (totalPlayers > 3) {
                player4Hand.push_back(deck.back());
                deck.pop_back();
            }
        }
        topCard = deck.back();
        deck.pop_back();
    }

undone rose Dec 13, 2024, 9:19 PM

#

Yes this looks good. Though you might wanna make dealCards() public, unless you only intend for it to be called by other methods in the class

craggy mango Dec 13, 2024, 9:21 PM

#

I ran this code and it still gave me the errors though

undone rose Dec 13, 2024, 9:22 PM

#

You've created your class but you still need a main function. Otherwise you've created a definition for a class without any instructions on what to do with it.

craggy mango Dec 13, 2024, 9:23 PM

#

I have more code with this so it should be okay, i'm not sure why it's still having problems

undone rose Dec 13, 2024, 9:23 PM

#

What are your errors?

craggy mango Dec 13, 2024, 9:24 PM

#

main.cpp:20:34: warning: range-based for loop is a C++11 extension [-Wc++11-extensions]
for (const string &color : colors) {
^
main.cpp:21:38: warning: range-based for loop is a C++11 extension [-Wc++11-extensions]
for (const string &value : values) {
^
main.cpp:22:32: error: expected expression
deck.push_back({color, value});
^
main.cpp:24:36: error: expected expression
deck.push_back({color, value});
^
main.cpp:29:28: error: expected expression
deck.push_back({"Wild", "Wild"});
^
main.cpp:30:28: error: expected expression
deck.push_back({"Wild", "Draw Four"});
^
main.cpp:221:14: warning: 'auto' type specifier is a C++11 extension [-Wc++11-extensions]
for (auto& card : hand) {
^
main.cpp:221:25: warning: range-based for loop is a C++11 extension [-Wc++11-extensions]
for (auto& card : hand) {

undone rose Dec 13, 2024, 9:26 PM

#

What compiler are you using? I don't have these errors.

#

Your compiler seems to be quite old

craggy mango Dec 13, 2024, 9:28 PM

#

i'm using netbeans which i think is using java

#

that's what i'm required to use unfortunately

undone rose Dec 13, 2024, 9:30 PM

#

I think what's happening is your compiler doesn't support initializer-list initialization of structs

#

try instead doing deck.push_back(Card(val1, val2))

#

with val1 and val2 being what is needed respectively for each line

craggy mango Dec 13, 2024, 9:33 PM

#

do i just add it in like this

class UNOGame {
public:
    void initializeDeck() {
        string colors[] = {"Red", "Green", "Blue", "Yellow"};
        string values[] = {"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "Draw Two", "Skip", "Reverse"};
        for (const string &color : colors) {
            for (const string &value : values) {
                deck.push_back(Card(val1, val2));
                deck.push_back({color, value});
                if (value != "0") {
                    deck.push_back({color, value});
                }
            }
        }
        for (int i = 0; i < 4; i++) {
            deck.push_back({"Wild", "Wild"});
            deck.push_back({"Wild", "Draw Four"});
        }
        random_shuffle(deck.begin(), deck.end());
    }

lunar mothBOT Dec 13, 2024, 9:33 PM

#

@craggy mango has reached level 2. GG!

undone rose Dec 13, 2024, 9:34 PM

#

No. the important part is replacing you're initializer lists ({color, value}) with a struct initializtion like this: Card(color, value)

#

So:

class UNOGame {
public:
    void initializeDeck() {
        string colors[] = {"Red", "Green", "Blue", "Yellow"};
        string values[] = {"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "Draw Two", "Skip", "Reverse"};
        for (const string &color : colors) {
            for (const string &value : values) {
                deck.push_back(Card(color, value));
                deck.push_back(Card(color, value));
                if (value != "0") {
                    deck.push_back(Card(color, value));
                }
            }
        }
        for (int i = 0; i < 4; i++) {
            deck.push_back(Card("Wild", "Wild"));
            deck.push_back(Card("Wild", "Draw Four"));
        }
        random_shuffle(deck.begin(), deck.end());
    }```

craggy mango Dec 13, 2024, 9:39 PM

#

this is what it's giving me now

undone rose Dec 13, 2024, 9:43 PM

#

?

craggy mango Dec 13, 2024, 9:43 PM

#

📎 message.txt

undone rose Dec 13, 2024, 9:44 PM

#

can you paste your entire source code file

lunar mothBOT Dec 13, 2024, 9:44 PM

#

@undone rose has reached level 4. GG!

craggy mango Dec 13, 2024, 9:44 PM

#

yes

#

📎 message.txt

undone rose Dec 13, 2024, 9:48 PM

#

the issue is (firstly that your compiler is archaic) and also that there isn't a constructor for the Card struct

#

becuase there isn't a constructor for the struct, when you call the initializer it just default initializes the values if possible

#

https://www.geeksforgeeks.org/constructors-c/

GeeksforGeeks

Constructors in C++ - GeeksforGeeks

A Computer Science portal for geeks. It contains well written, well thought and well explained computer science and programming articles, quizzes and practice/competitive programming/company interview Questions.

#

In C++, a struct is identical to a class except for the fact that a struct's members are public by default

#

~~generally you would be allowed to initialize like Card(name, color) but since your compiler is old it seems it won't let you without defining a constructor~~ I'm wrong, you'd use Card{name, color}. this is because parenthesis does imply calling a constructor, which wouldn't ever work unless one is explicityl defined (or the default constructor is called withotu arguments)

#

instead try

struct Card {
  string color;
  string value;
    
   // Constructor to initialize color and value
   Card(const string& c, const string& v) : color(c), value(v) {}
};

#

You might be able to get around this by using curly braces like Card{color, value} as opposed to Card(color, value) but i don't really know if it'll work

craggy mango Dec 13, 2024, 9:57 PM

#

undone rose instead try ```cpp struct Card { string color; string value; // Con...

i added that and i think some of the errors went away but there are still a few more

#

and when I tried the curly braces, it made it worse

silent igloo Dec 13, 2024, 11:00 PM

#

Hi. Usually when I add a struct object to a vector, I define a temporary local object and push that back. Like so:

Card newcard;
newcard.color = color;
newcard.value = value;
deck.push_back(newcard);

I'm not sure if this method is good for memory management or not but it works.

lunar mothBOT Dec 13, 2024, 11:00 PM

#

@silent igloo has reached level 6. GG!

silent igloo Dec 13, 2024, 11:03 PM

#

Also if you are still getting errors like "warning: range-based for loop is a C++11 extension" you might want to adjust whatever IDE you're using to use c++11 as the language standard. I don't mean get another compiler. I mean change the language standard in the IDE.

This command should be run when calling the compiler: "-std=c++11"

undone rose Dec 13, 2024, 11:04 PM

#

They're using netbeans, they might not even be able to alter the arguments to the built in compiler

#

really frustrating becasue range based for loops are really great

silent igloo Dec 13, 2024, 11:06 PM

#

You can set it in netbeans. I just checked. You go to Properties > Build > C++ Compiler and in the "Additional Options" field you place this "-std=c++11".

undone rose Dec 13, 2024, 11:07 PM

#

That's cool

#

@craggy mango

craggy mango Dec 13, 2024, 11:27 PM

#

silent igloo You can set it in netbeans. I just checked. You go to Properties > Build > C++ C...

I tried this right now but it's still giving me errors

silent igloo Dec 13, 2024, 11:27 PM

#

Same errors?

#

You didn't change the "Card(color,value)" into something else. What you have won't work.

#

Unless if you have a constructor.

#

I think'

#

Could you show your code again please?

craggy mango Dec 13, 2024, 11:36 PM

#

I thought I did, maybe I undid it. I'll send the code

#

📎 message.txt

silent igloo Dec 13, 2024, 11:38 PM

#

In the struct Card, you have no constructor. Like what Kevin Goldstein said.
Maybe you should try going without the Card() constructor and do this:

Card newcard;
newcard.color = color;
newcard.value = value;
deck.push_back(newcard);

#

`
Instead of Card(color,value)

#

Whenever you have () after a name in c++ it treats that as a function and tries to call it. No such function exists in your Card struct.

craggy mango Dec 13, 2024, 11:45 PM

#

so where in the code do I add that part?

silent igloo Dec 13, 2024, 11:45 PM

#

How long have you been using c++?

craggy mango Dec 13, 2024, 11:45 PM

#

not long, just this semeter for my class

silent igloo Dec 13, 2024, 11:52 PM

#

Place this:

Card newcard;
newcard.color = color;
newcard.value = value;
deck.push_back(newcard);

With the necessary adjustments wherever you need to add to a vector of Card objects. For example: Where you initialize the deck you could place the code inside of your two for loops.


    void initializeDeck() {
        string colors[] = {"Red", "Green", "Blue", "Yellow"};
        string values[] = {"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "Draw Two", "Skip", "Reverse"};
        for (const string &color : colors) {
            for (const string &value : values) {
                Card newcard;
                newcard.color=color;
                newcard.value=value;
                
                deck.push_back(newcard));
                deck.push_back(newcard));
                if (value != "0") {
                    deck.push_back(newcard));
                }
            }
        }
        for (int i = 0; i < 4; i++) {
            Card newcard;
            newcard.color = "Wild";
            newcard.value = "Wild";
            deck.push_back(newcard);
            newcard.value = "Draw Four";
            deck.push_back(newcard);
        }
        random_shuffle(deck.begin(), deck.end());
    }

craggy mango Dec 13, 2024, 11:54 PM

#

this is much better, these are the only errors now
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -f nbproject/Makefile-Debug.mk QMAKE= SUBPROJECTS= .build-conf
"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -f nbproject/Makefile-Debug.mk dist/Debug/GNU-MacOSX/uno_project_2
mkdir -p build/Debug/GNU-MacOSX
rm -f "build/Debug/GNU-MacOSX/main.o.d"
g++ -c -g -std=c++11 -MMD -MP -MF "build/Debug/GNU-MacOSX/main.o.d" -o build/Debug/GNU-MacOSX/main.o main.cpp
main.cpp:26:40: error: extraneous ')' before ';'
deck.push_back(newcard));
^
main.cpp:27:40: error: extraneous ')' before ';'
deck.push_back(newcard));
^
main.cpp:29:44: error: extraneous ')' before ';'
deck.push_back(newcard));
^
3 errors generated.
make[2]: *** [build/Debug/GNU-MacOSX/main.o] Error 1
make[1]: *** [.build-conf] Error 2
make: *** [.build-impl] Error 2

silent igloo Dec 13, 2024, 11:55 PM

#

Ok. So I did a typo. Just remove the extra ")" from the end of deck.push_back(newcard));

craggy mango Dec 13, 2024, 11:58 PM

#

okay perfect now it runs but now it gives each player 80 cards instead of just 7, I dont know if that was from my previous code, or if something changed while I was trying to fix the error

lunar mothBOT Dec 13, 2024, 11:58 PM

#

@craggy mango has reached level 3. GG!

silent igloo Dec 13, 2024, 11:58 PM

#

I didn't think the code looked right. Let me look at it again for a minute.

craggy mango Dec 13, 2024, 11:59 PM

#

okay take your time

silent igloo Dec 14, 2024, 12:01 AM

#

I don't understand why you are pushing back three same cards into the deck. Maybe I'm just forgetting how uno is played. Nevermind. I'll look at the player hand code now.

#

You have dealCards() continue to deal till the deck is empty. The deck is more than what the players should get. There has to be deck left for the players to draw from during the game. To fix this problem change the condition from "while(!deck.empty())" to a for loop.

int dealsize=?; //I forget how many cards should be dealed.
for(int a = 0; a < dealsize; a++)
{
   player1Hand.push_back(deck.back());
   deck.pop_back();
   player2Hand.push_back(deck.back());
   deck.pop_back();
   if (totalPlayers > 2) 
   {
        player3Hand.push_back(deck.back());
        deck.pop_back();
   }
   if (totalPlayers > 3) 
   {
                                  player4Hand.push_back(deck.back());
                deck.pop_back();
            } 
}

craggy mango Dec 14, 2024, 12:19 AM

#

okay that worked and it's only dealing 7 cards per player, this is what the run is showing

#

nevermind i can't copy the output, but there's one more problem, it doesn't say what the top card is

silent igloo Dec 14, 2024, 12:24 AM

#

What do you have for outputting the top card to the console?

craggy mango Dec 14, 2024, 12:32 AM

#

📎 message.txt

silent igloo Dec 14, 2024, 12:44 AM

#

I don't see anything outputting the top card to the console. I also see that your player cards will have to update and consequently be output to the console. If you don't want the player cards and the top card to be output after the old values in the console you can clear the console and output to it in a loop like so:

Something kinda like this:

    void playTurn() {

        bool validMove = false;
        while (!validMove) 
    {
    
    system("cls");
    cout << "======================================" << endl;
        cout << "Player " << currentPlayer + 1 << "'s Turn!" << endl;
        displayHand(currentPlayer);
        cout << "Top card: ";
        displayCard(topCard);
        cout << endl;

        
            cout << "Choose a card to play (1-" << getPlayerHandSize(currentPlayer) << ") or 0 to draw: ";
            int choice;
            cin >> choice;

            if (choice == 0) {
                drawCard(currentPlayer);
                return;
            } else if (choice > 0 && choice <= getPlayerHandSize(currentPlayer)) {
                Card chosenCard = getPlayerCard(currentPlayer, choice - 1);
                if (isValidMove(chosenCard)) {
                    validMove = true;
                    topCard = chosenCard;
                    removeCardFromHand(currentPlayer, choice - 1);
                    applySpecialCardEffect(chosenCard);
                } else {
                    cout << "Invalid move. Try again." << endl;
                }
            } else {
                cout << "Invalid choice. Try again." << endl;
            }
        }

        if (getPlayerHandSize(currentPlayer) == 0) {
            cout << "Player " << currentPlayer + 1 << " has UNO!" << endl;
        }
    }

craggy mango Dec 14, 2024, 12:50 AM

#

still the same problem

silent igloo Dec 14, 2024, 12:51 AM

#

Did you add something to output the topcard value?

silent igloo Dec 14, 2024, 1:30 AM

#

@craggy mango

silent igloo Dec 14, 2024, 3:59 AM

#

Oh. Nevermind. I can see now where you output the value. I just had a hard time finding it in your code.

#uno game help