#Magic: the Jokering

1 messages · Page 2 of 1

atomic crag
#

if MTJ says the card is always a King, and CardSleeves says no face cards, who "wins"?

fresh rover
#

probs card sleeves

#

tbh thats probs why it is working fine is cuz im not sure if there is a set priority

atomic crag
#

or the enhancement just doesn't show up 🤔🤔

fresh rover
#

yea, priority is 0

#

hmmm, i wonder if i can make the fix for grim

#

but im not 100% sure how priority works tho

pastel comet
#

The priority implementation is kinda evil lol

fresh rover
#

well we will see how this works

pastel comet
#
[[patches]]
[patches.pattern]
target = "functions/common_events.lua"
pattern = "if card.ability.consumeable and not skip_materialize then card:start_materialize() end"
position = "before"
payload = '''
    if center.force_suit or center.force_value then
        SMODS.change_base(card, center.force_suit, center.force_value)
    end
'''
match_indent = true```
#

This is the patch

atomic crag
#

yeah I saw but I'm pretty sure CardSleeves should still have the last say based on the code? 🤔

fresh rover
#

I DID IT

#

now i just need to figure out how to make grim take priority over MTJ

#

as they both use a priority of 0

atomic crag
#

okay figured it out

fresh rover
#

oh?

atomic crag
#

I had a check to make sure I was only modifying playing cards (wouldn't want to abandonify vouchers etc)

#

and apparently that check was flawed

fresh rover
#

oh

atomic crag
#

in any case, you guys might be interested in this in_pool for your enhancements with a forced key of a face card, otherwise stuff like this (A Storm Crow that's not a Jack nor a Club) will start happening

function in_pool(self)
    if CardSleeves and G.GAME.selected_back.effect.center.key == "b_abandoned" and G.GAME.selected_sleeve == "sleeve_casl_abandoned" then
        return false
    end
    return true
end
fresh rover
#

seen it happen many times

tender yacht
#

Yeah! I get lands all the time that are on the wrong suit

fresh rover
#

plus they will be getting a rework

tender yacht
#

so many clover plains

atomic crag
#

I mean I still suggest using the in_pool so you don't get weird exceptions like that 10 of Hearts Storm Crow but it's up to you guys ofc

fresh rover
#

well i have only been coding for 2 weeks so im open to new stuff

atomic crag
#

oh, my bad

fresh rover
#

its all good

atomic crag
#

do you not know how to use that in_pool then?

fresh rover
#

see the way i make things work is throw myself at the problem till it works, so for the most part its like word soup to me

atomic crag
#

right so what the in_pool would do is set the spawn conditions

#

so for an enhancements, the enhancement wouldn't show up unless in_pool returns true

fresh rover
#

well i know that, just dont know the more advanced applecations

#

like i had a mod where i made it so a joker spawned in the meme packs

atomic crag
fresh rover
#

so where would i apply it

atomic crag
#

for any enhancement that forces a face card value

#
--- a/Items/enha.lua
+++ b/Items/enha.lua
@@ -13,6 +13,14 @@
 end]]

 -- [[
+
+local function cardsleeves_in_pool_compat(self)
+    if CardSleeves and G.GAME.selected_back.effect.center.key == "b_abandoned" and G.GAME.selected_sleeve == "sleeve_casl_abandoned" then
+        return false
+    end
+    return true
+end
+
 odric = SMODS.Enhancement {
        object_type = "Enhancement",
        key = "odric",
@@ -24,6 +32,7 @@ odric = SMODS.Enhancement {
        loc_vars = function(self, info_queue, card)
         return { vars = { card.ability.extra.x_mult, card.ability.extra.extra } }
        end,
+    in_pool = cardsleeves_in_pool_compat,
     calculate = function(self, card, context, effect)
        if context.cardarea == G.hand and context.main_scoring then
             local diamond_count = 0
@@ -53,6 +62,7 @@ akroma = SMODS.Enhancement {
        loc_vars = function(self, info_queue, card)
         return { vars = {card.ability.extra.mult_x} }
        end,
+    in_pool = cardsleeves_in_pool_compat,
     calculate = function(self, card, context, effect)
         if context.cardarea == G.play and context.main_scoring then
             if G.GAME.current_round.hands_played == 0 then
#

e.g. like this

fresh rover
#

ah, so specify it at the top then put the pool function in there

atomic crag
#

yeah so you don't have to rewrite the function every time haha

fresh rover
#

well once i finish getting the clovers to count as a light suit i will patch that in

#

also would i have to take ownership of the checkered deck to make it so that clovers dont show up in there

atomic crag
#

uhh depends

#

let me check

#

yeah, looks like you'll need either to take ownership of the checkered deck or do a lovely patch

fresh rover
#

ugh, will get to that eventually, unless someone else wants to make a pr for it

atomic crag
#

good luck, it does not sound fun 😅

fresh rover
#

nope, might make a lua file just for this specific thing, so i can keep stuff orginized

fresh rover
#

@pastel comet is there a way to change this so it says clovers instead of mtg_clovers?

outer otter
#

hey this is like kind of small but

#

there's a mod (i think ortalab) that adds a blind called

#

"The Fallacy" which lowers the rank of a card

fresh rover
#

here

#

might want to get a perma link and have it pinned

twilit grove
#

I just played a Yorvo and it upgraded a bunch of times and then removed itself from my deck, that's not normal is it?

fresh rover
gritty vapor
#

absolutely loving playing with the mod rn, great work

fresh rover
atomic crag
#

why, are you having some issues?

fresh rover
#

no was just wondering before i pushed a commit out

atomic crag
#

I'd double check it using cardsleeves but it should be fine

fresh rover
#

ok

dim mason
#

Currently getting issues when in collection, specifically when I hover over lantern of insight, it crashes the game when I do

fresh rover
dim mason
#

Uhh ill check as soon as im back to my pc

fresh rover
modest musk
#

wrong channel sorry

fresh rover
#

all g

dim mason
fresh rover
#

is that the latest release?

fresh rover
gloomy notch
#

Is this effect supposed to trigger multiple of times?

gloomy notch
#

Does not draw 3 cards

#

I think something is wrong here

gloomy notch
glossy fulcrum
#

Played with this for a while now, and I have a couple of pieces of feedback:
First, I would raise the base mult of flushes to x5 instead of x4, to compensate for the increased difficulty in creating them early on due to the fifth suit.
Second, a suggestion for a new enhancement: devoid! Devoid puts the card art in greyscale (and adds Eldrazi tentacles to the border?) and causes it to count as having no suit, similar to a stone card. In return, certain jokers/consumables could care about cards having no suit, and it could provide a small mult boost, similar to stone cards. Unlike stone, they keep their rank and other effects, though.

Anyway, I've been enjoying my experience (bug aside!) so far. Cool mod!

fresh rover
#

oh and also, alreayd have plans for devoid so dw

fresh rover
glossy fulcrum
#

I'm playing on the latest release version, so nope.

fresh rover
#

i would use the commit, cuz i have adressed quite a few bugs and the clovers in your starting deck issue

gloomy notch
fresh rover
#

doing it rn

#

but kinda got caught up on that bug i posted

gloomy notch
#

sorry abt that

fresh rover
#

your all good

magic prism
#

hey, my mod says it requires steammodded but i already have it in the mods folder. any way y'all know to resolve this issue?

fresh rover
#

what version of steamodded?

magic prism
#

the most recent one

fresh rover
#

@magic prism what version number

magic prism
#

i just downloaded it off the github page

fresh rover
#

hmm, have you joined either the MTJ or dims modpack manager discord?

fresh rover
fresh rover
#

new energy mech added

ashen pilot
#

Hey, question/suggestion. Is there a way to limit/a version that changes the card enhancements' designs? I think stuff like the lands look good, but the actual cards are a little busy for my blood and it makes them a little hard to read at a glance.

Mod is super cool btw. I'm not too much of a magic player but the cards feel fun to use so that's all that matters lol

fresh rover
#

yea, the art/srpites are still a wip

#

tho im busy focousing on Cryptid rn but once i have the time i will come back and work on it

spark matrix
#

I'm on the latest commit of smods (just did a git pull)

toxic hazel
#

Hi @fresh rover

I installed the latest release posted on Github (which would be the zip file not named main) which reports 0.8.5, but in game it reports 0.8.2

umbral stream
#

I'd love to see some skins for the Clover and Suitless skins introduced by this mod.

violet raft
#

Okay, does Balance currently work? Cause it hasn't been for me

long dawn
#

Currently getting a crash when playing any hand...I disabled every mod except Talisman and this one, and made sure to grab the zip instead of the one under releases

#

nevermind, my steamodded version was way outdated 😂 updated it and it's working fine now.

wet trellis
#

I got try this mod next

outer otter
#

i gotta get this mod again

wet trellis
#

I got it! It didn't crash not once and using two mods

pastel comet
#

A sneak preview of what is to come... 🫣

high canopy
#

oh cool ||another planeswalker type||

umbral stream
west sentinel
#

thank god