#Magic: the Jokering
1 messages · Page 2 of 1
probs card sleeves
tbh thats probs why it is working fine is cuz im not sure if there is a set priority
or the enhancement just doesn't show up 🤔🤔
yea, priority is 0
hmmm, i wonder if i can make the fix for grim
but im not 100% sure how priority works tho
The priority implementation is kinda evil lol
well we will see how this works
[[patches]]
[patches.pattern]
target = "functions/common_events.lua"
pattern = "if card.ability.consumeable and not skip_materialize then card:start_materialize() end"
position = "before"
payload = '''
if center.force_suit or center.force_value then
SMODS.change_base(card, center.force_suit, center.force_value)
end
'''
match_indent = true```
This is the patch
yeah I saw but I'm pretty sure CardSleeves should still have the last say based on the code? 🤔
I DID IT
now i just need to figure out how to make grim take priority over MTJ
as they both use a priority of 0
okay figured it out
oh?
I had a check to make sure I was only modifying playing cards (wouldn't want to abandonify vouchers etc)
and apparently that check was flawed
oh
in any case, you guys might be interested in this in_pool for your enhancements with a forced key of a face card, otherwise stuff like this (A Storm Crow that's not a Jack nor a Club) will start happening
function in_pool(self)
if CardSleeves and G.GAME.selected_back.effect.center.key == "b_abandoned" and G.GAME.selected_sleeve == "sleeve_casl_abandoned" then
return false
end
return true
end
seen it happen many times
Yeah! I get lands all the time that are on the wrong suit
still need to fix how lands work
plus they will be getting a rework
so many clover plains
I mean I still suggest using the in_pool so you don't get weird exceptions like that 10 of Hearts Storm Crow but it's up to you guys ofc
well i have only been coding for 2 weeks so im open to new stuff
oh, my bad
its all good
do you not know how to use that in_pool then?
see the way i make things work is throw myself at the problem till it works, so for the most part its like word soup to me
right so what the in_pool would do is set the spawn conditions
so for an enhancements, the enhancement wouldn't show up unless in_pool returns true
well i know that, just dont know the more advanced applecations
like i had a mod where i made it so a joker spawned in the meme packs
well all this version does is just check if the user is using abandoned deck + sleeve combo
so where would i apply it
for any enhancement that forces a face card value
--- a/Items/enha.lua
+++ b/Items/enha.lua
@@ -13,6 +13,14 @@
end]]
-- [[
+
+local function cardsleeves_in_pool_compat(self)
+ if CardSleeves and G.GAME.selected_back.effect.center.key == "b_abandoned" and G.GAME.selected_sleeve == "sleeve_casl_abandoned" then
+ return false
+ end
+ return true
+end
+
odric = SMODS.Enhancement {
object_type = "Enhancement",
key = "odric",
@@ -24,6 +32,7 @@ odric = SMODS.Enhancement {
loc_vars = function(self, info_queue, card)
return { vars = { card.ability.extra.x_mult, card.ability.extra.extra } }
end,
+ in_pool = cardsleeves_in_pool_compat,
calculate = function(self, card, context, effect)
if context.cardarea == G.hand and context.main_scoring then
local diamond_count = 0
@@ -53,6 +62,7 @@ akroma = SMODS.Enhancement {
loc_vars = function(self, info_queue, card)
return { vars = {card.ability.extra.mult_x} }
end,
+ in_pool = cardsleeves_in_pool_compat,
calculate = function(self, card, context, effect)
if context.cardarea == G.play and context.main_scoring then
if G.GAME.current_round.hands_played == 0 then
e.g. like this
ah, so specify it at the top then put the pool function in there
yeah so you don't have to rewrite the function every time haha
well once i finish getting the clovers to count as a light suit i will patch that in
also would i have to take ownership of the checkered deck to make it so that clovers dont show up in there
uhh depends
let me check
yeah, looks like you'll need either to take ownership of the checkered deck or do a lovely patch
ugh, will get to that eventually, unless someone else wants to make a pr for it
good luck, it does not sound fun 😅
nope, might make a lua file just for this specific thing, so i can keep stuff orginized
@pastel comet is there a way to change this so it says clovers instead of mtg_clovers?
hey this is like kind of small but
there's a mod (i think ortalab) that adds a blind called
"The Fallacy" which lowers the rank of a card
I just played a Yorvo and it upgraded a bunch of times and then removed itself from my deck, that's not normal is it?
probs a joker or some other external effect doing it
absolutely loving playing with the mod rn, great work
did you test or know if this works?
tested it very quickly
why, are you having some issues?
no was just wondering before i pushed a commit out
I'd double check it using cardsleeves but it should be fine
ok
ok been made
Currently getting issues when in collection, specifically when I hover over lantern of insight, it crashes the game when I do
what version of MTJ are you running
Uhh ill check as soon as im back to my pc
wrong channel sorry
all g
Im running 0.8.2
is that the latest release?
Is this effect supposed to trigger multiple of times?
this is conflict with Dungeon mod
Played with this for a while now, and I have a couple of pieces of feedback:
First, I would raise the base mult of flushes to x5 instead of x4, to compensate for the increased difficulty in creating them early on due to the fifth suit.
Second, a suggestion for a new enhancement: devoid! Devoid puts the card art in greyscale (and adds Eldrazi tentacles to the border?) and causes it to count as having no suit, similar to a stone card. In return, certain jokers/consumables could care about cards having no suit, and it could provide a small mult boost, similar to stone cards. Unlike stone, they keep their rank and other effects, though.
Anyway, I've been enjoying my experience (bug aside!) so far. Cool mod!
have you tried the latest commit?
oh and also, alreayd have plans for devoid so dw
also i i do updates and suggetions here
I'm playing on the latest release version, so nope.
i would use the commit, cuz i have adressed quite a few bugs and the clovers in your starting deck issue
did you look into this one?
sorry abt that
your all good
hey, my mod says it requires steammodded but i already have it in the mods folder. any way y'all know to resolve this issue?
what version of steamodded?
the most recent one
@magic prism what version number
i just downloaded it off the github page
hmm, have you joined either the MTJ or dims modpack manager discord?
new energy mech added
Hey, question/suggestion. Is there a way to limit/a version that changes the card enhancements' designs? I think stuff like the lands look good, but the actual cards are a little busy for my blood and it makes them a little hard to read at a glance.
Mod is super cool btw. I'm not too much of a magic player but the cards feel fun to use so that's all that matters lol
yea, the art/srpites are still a wip
tho im busy focousing on Cryptid rn but once i have the time i will come back and work on it
also the actual discord link discord.gg/cryptid
I'm on the latest commit of smods (just did a git pull)
Hi @fresh rover
I installed the latest release posted on Github (which would be the zip file not named main) which reports 0.8.5, but in game it reports 0.8.2
I'd love to see some skins for the Clover and Suitless skins introduced by this mod.
Okay, does Balance currently work? Cause it hasn't been for me
Currently getting a crash when playing any hand...I disabled every mod except Talisman and this one, and made sure to grab the zip instead of the one under releases
nevermind, my steamodded version was way outdated 😂 updated it and it's working fine now.
I got try this mod next
i gotta get this mod again
I got it! It didn't crash not once and using two mods
A sneak preview of what is to come... 🫣
oh cool ||another planeswalker type||
ive already made ||an API for them with https://discord.com/channels/1116389027176787968/1425585472054497290||
thank god