#elbe's SMODS 1.0.0 Ports, and other things

1 messages · Page 1 of 1 (latest)

vivid musk
#

To simplify my various ports I figure I'd make a thread with links to them all and make it easy to take suggestions.

Basic SMODS ports:
Pampa's Jokers: https://github.com/lshtech/balatro-pampa-joker-pack (28 new jokers)
LushMod: https://github.com/lshtech/LushMod (10 new jokers)
Matchbox: https://github.com/lshtech/Matchbox (3 new enhancements, 3 new tarots)
MorJokers: https://github.com/lshtech/morjokers, and https://discord.com/channels/1116389027176787968/1293324397024907324 for help with new sprites (5 new jokers, 3 new tarots)

Rewrites/Improvements:
Hand Preview: https://github.com/lshtech/Balatro-HandPreview (Preview of best available hand by base score)

New Mods:
Discovery Manager: https://github.com/lshtech/DiscoveryManager (Allows to undiscover/discover all cards)
Card Exporter: https://github.com/lshtech/CardExporter (Export all your cards, decks, and other stuff to create a template website, a work in progress)

Willing to take suggestions for other ports, though I don't want to step on the original creator's toes. Mods I've done a little work already on include Codex Arcanum and several seal mods like dice seals, black seals, and silver seals.

GitHub

Contribute to lshtech/balatro-pampa-joker-pack development by creating an account on GitHub.

GitHub

Mod for Balatro. Contribute to lshtech/LushMod development by creating an account on GitHub.

GitHub

Matchbox. Contribute to lshtech/Matchbox development by creating an account on GitHub.

GitHub

A mod for Balatro which adds a window showing the possible poker hands that you can make with your current hand - lshtech/Balatro-HandPreview

indigo sapphire
#

Do you think the discovery manager buttons can appear in the profile page?

vivid musk
#

I could look into it.

vivid musk
#

I never really payed attention to it before but the Unlock All button on the profile page both unlocks and discovers

vivid musk
#

I put the undiscover button on the profile page underneath the unlock all button. I also unified the discover all button on the settings page with the existing unlock all logic.

indigo sapphire
#

Yo sick. Definitely gonna try it out

vivid musk
indigo sapphire
#

Clicking on reset crashes

vivid musk
#

It does everything dynamically, so it should

indigo sapphire
#

🫢

#

Amazing

vivid musk
# indigo sapphire Clicking on reset crashes

I'm guessing from the settings page. Ugh, looks like unifying it with the profile buttons did it. I have a couple of options to explore but I'm hoping for one I don't have to duplicate a whole bunch of code.

indigo sapphire
#

Yes the one with settings page

vivid musk
#

luckily it seemed to have been quick and painless. should be fixed now.

vivid musk
#

In very specific mods I have ModPackFixes:https://github.com/lshtech/ModPackFixes
It's essentially just a collection of small fixes or incompatibilities in a handful of mods. If you don't have one of the mods it won't apply those specific changes. Most obvious is an incompatibility between bunco, cryptid/ceres in vouchers that add booster slots.

GitHub

Contribute to lshtech/ModPackFixes development by creating an account on GitHub.

#

also a fix for ceres' accountant plus a few safety checks

pliant mulch
#

Betmma's works flawlessly and ceres' just does nothing

vivid musk
#

I need to remember what I did to fix cup and balls.

#

the main thinng is that bunca/cryptid/ceres all try to do the same basic thing in a lovely patch but bunco seems to have won out

pliant mulch
#

Also there's some (semi?) intentional differences in behavior between the vouchers. Betmma's rerolls all boosters, while cups n balls from bunco, when it didn't crash (so if you haven't bought a boatee) just adds one

#

Idk what the cryptid one does or what the ceres I've is supposed to do. I don't pay ceyptid and the ceres one never worked for me

vivid musk
#

ceres has two that just add +1 booster slot, cryptid has one that adds +1 and one or two other things, betmma's gives you +1 slot but only right when you buy it. that felt like a weird thing to be intentional

pliant mulch
#

Maybe cryptid breaks it

#

I know bunco or ceres don't

vivid musk
#

i found it triggered, gave me three slots, and when I came back to the next shop I only had two available

#

it's possible that the logic bunco implemented broke it

pliant mulch
#

Yeah never happened for me

pliant mulch
#

And ceres

vivid musk
#

I put a fix that should hopefully help with the cup and balls crash

vivid musk
#

I'm working on fixing a bunch of modded cards that don't work with modded suits. annoyingly taking ownership of a card sometimes breaks some of it's localization.

vivid musk
#

ok, I've done all the cards that have issues with mod added suits, other than Emergence, which is a lot more complex

vivid musk
#

Would there be more interest in a port of Codex Arcanum or Mika's?

indigo sapphire
#

Mika definitely. CA is mostly working

vivid musk
#

alright, I've got two jokers done so far. I decided that Straight Nate should also activate if the Odd Todd/Even Steven fusion, Dynamic Duo, also exists.

indigo sapphire
#

You are a legit mod necromancer 👍

vivid musk
#

14 done, 46 to go. this is easily the biggest one of these I've worked on

ebon kiln
#

Hey elbe I checked out your website. Are you saying that you play the game with all that installed?

pliant mulch
vivid musk
vivid musk
pliant mulch
#

I mean maybe, but also it's kinda up to the player to 'balance' their own specific mod combination to their liking

vivid musk
#

that is true

indigo sapphire
#

discovery manager is not working

#

And unlock all button is long gone

#

I unlocked all using the option one

vivid musk
#

the unlock button disappearing is vanilla behavior. if your profile gets a flag set it hides that button

indigo sapphire
#

What

ebon kiln
#

Is there a download link floating around for your modpack? @vivid musk shy

vivid musk
#

I don't really have my own released modpack, essentially it's dim's plus whatever else I find and get working'

ebon kiln
#

Ah ok, I can comb through your website and copy what you have then. Cause yours looks like fun

vivid musk
#

here's the list of mod folders I have
5CEBalatro
AchievementsEnabler
Actions
Alices_Annum
Aura
Aure-Spectral
Aurinko
Balatro-Jokers-Plus
Balatro451
balatrogcabuse
BalatroOlympus
BalatroSafety
BBBalatro
Betmma_mods
Better-tprint
BetterIllusion
Bird-Jokers
BirthdayCardMod
BlackJack
BlackSeal
Blanks
BonusBlinds
BossJokers
Buffoonery
Bunco
CardExporter
CardSleeves
Cartomancer
Ceres
CheesyJokers
Codex-Arcanum
CollectorsCards
Contracts
Crimson's Card Collection
Cruel-Blinds
Cryptid
CursedDiceSeal
CustomFont
D6-Jokers 0.7.0
DebugMenu
DebugPlus
DeckSkinsPlus
DiceSeal
DiscoveryManager
DX-Tarots
Escape-Exit-Button
Familiar
FloundersJokers
Flower-Pot
FlushHotkeys
FoldButton
Fusion-Jokers
Galdur
Grim
HandPreview
Handy
HeyListen
HouseRules
Incantation
InkAndColor
JamMod
JankJonklers
Jeantoine
JellyMods
Jen
JenLib
JestersPrivilege
Jestobiology
Jimbo-s-Pack
Joker-Evolution
JokerDisplay
JokerDisplayModSupport
JokerSellValue
KCVanilla
Komakusa-Cards
LobotomyCorp
Loop
LoveForFibonacci
lovely
LunasBalatroMods
LushMod
Matchbox
MathBlinds
MathIsFun0-Ankh
MikasBalatro
MOARJokers
ModpackDecks
ModpackUtil
MoreFluff
MoreJokerPacks
morjokers
multi-jokers
MystBlinds
MystJokers
No-Laughing-Matter
Nopeus
NotJustYet
Oiiman's Additions
Ortalab-DEMO
Othermod
PampaJokerPack
Paperback
PiJoker
Pokermon
Reverie
RiskofJesters - ║╣╗τ║╗
ror2funnyitems
ScoreImprovements
SDM_0-s-Stuff
SeedUnlocker
sevendeadlysins
Shoot_the_Jimbo
SilverSeal
SixSuits
SnoresvillesTurbulentJokers
Snow-s-Mods
SpicyJokers
Steamodded
SyltStickers
Taikomochi
Talisman
TarotPlus
Tetrapak
The-World-Ends-With-Jimbo
Themed_Jokers
Tier 3 Vouchers Preview
TooManyJokers
Trance
Tsunami
Virtues
ZZ_Fixes

#

a few are currently disabled due to issues

ebon kiln
#

Wow Thanks. Did you actually get D6 Jokers to work? I remember trying to install that and no dice, literally

vivid musk
#

yeah, it works for me

ebon kiln
#

Ok maybe there was a weird incompatibility

vivid musk
#

I'd have to grab the source to see how much I may have fixed manually, though

ebon kiln
#

Lol yeah im running your modpack fixes mod too.

vivid musk
#

some things I fixed manually before I started the fixes mod

ebon kiln
#

Oh nice! Are the fixed versions on your repo? or you just went and re-coded it yourself?

vivid musk
#

not everything is forked in my repo, depends on what I changed and how much I cared. if you can't get d6 to work I can upload a fork though

ebon kiln
#

Ok, Ill give it a shot. What are the current mods you have disabled so I can probably avoid them too

vivid musk
#

offhand I can say the balatrogcabuse mod and SyltStickers. the later I want to take a closer look at in the future

ebon kiln
#

Ok two mods I haven't even heard of. Sounds good. This honestly shouldn't take too long since i'm probably over 50% of the way there

#

Oh you also got DX-tarots to work? I removed it because every time I tried to open a pack it would crash.

vivid musk
#

the first is someone's work in progress memory helper, but it causes random other issues

ebon kiln
#

omg a memory helper sounds like a godsend lol. But probably not worth the tradeoffs that you are mentioning

ebon kiln
#

The way the memory works in this game is strange

pliant mulch
#

I don't remember exactly what they were though

vivid musk
#

I remember considering it once but I don't remember why I never went further. Possibly just before I started really fixing stuff as I went.

vivid musk
vivid musk
#

I wouldn't recommend adding it to modpacks as is but if anyone wants to do any play testing be my guest

vivid musk
vivid musk
#

so for a card like Straight Nate, which only works if other cards are present, should I prevent them from being pulled unless you already have those cards?

indigo sapphire
#

What does the card do

vivid musk
#

if you have odd todd and even steven it gives x4 mult if you play a straight

indigo sapphire
#

I am wondering, what makes you decide to make a modpack fixes mod rather than PRs?

indigo sapphire
vivid musk
#

the catalyst was the conflict between cryptid/ceres and bunco's handling of bonus booster slots. I don't really know who should fix what since all three are essentially doing the same thing, bunco just happens to win (ceres has direct compat with cryptid). after that I was just adding things I found, so like the mod suit issue I went through and fixed it but also reported it in case a dev is active and wants to fix it. if not I can fall back on my fixes.

indigo sapphire
#

Gods work though.

#

It's the thing I always want to do but never have the ability to do

vivid musk
#

presumably you've done some fixing with your personal forks

indigo sapphire
#

Tbh those fixes are from other ppls

#

I just put them into my fork

#

So my modpacks are better compatibility

vivid musk
#

that's how I started with my codex fork, it was based on whomever originally made the 1.0 compat fork

indigo sapphire
#

Cool

vivid musk
#

Mika has been updated with some refactoring, which will hopefully handle some issues. The only problem I currently know of is the for hire deck doesn't seem to want to increase the price as it's supposed to

ebon kiln
#

@vivid musk so I spent last night copying your list. This appears on startup instantly. Not really a whole lot to go off of in my opinion

vivid musk
#

no, that's likely cause by some lovely patch that's causing a compile error

ebon kiln
#

im just going to remove stuff until it works

vivid musk
#

it's what I'd do. you can focus on stuff you know isn't in Dim's pack, for example

wet copper
#

@vivid musk
Will it be fine for you to port Deck Creator to SMODs 1.0? It's honestly one of the best 0.9.8 mods, and there really isn't any alternative for 1.0 yet.

vivid musk
#

no idea what all involved in that, I guess I could take a look at some point

wet copper
vivid musk
#

Looks like it'd take some gui rejiggering. That'd be a new area for me so if I continue with it it'll be on the back burner.

ebon kiln
#

@vivid musk I figured it out it was D6Jokers. I should have known. I've never been able to get it to work idk how you did.

#

also 5CEBalatro doesn't work either.

vivid musk
ebon kiln
#

ahh i see.

#

Not too bad out of all the mods 6 mods prevented startup. 5CEBalatro, RiskOfJesters,D6-jokers,Oiimans-additions,Grim, and Tetrapak

vivid musk
ebon kiln
#

Holy crap you are fixing them as we speak? Absolute Wizard

vivid musk
indigo sapphire
ebon kiln
#

@indigo sapphire oh yeah that mod breaks a lot of shit.

vivid musk
#

grim and oiiman's are in active development

indigo sapphire
#

Last time I add oiiman it crashed hard

#

😢

ebon kiln
#

oiiman doesnt even let me start the game lol

vivid musk
#

don't remember what I may have had to do with that, give me a minute

ebon kiln
vivid musk
#

is the folder it's in named "RiskofJesters - ║╣╗τ║╗/"?

ebon kiln
#

umm no its just risk of jesters-main and i erased the main part as usual

vivid musk
#

feh, I'll have to do something about that... for now rename the folder to RiskofJesters - ║╣╗τ║╗

#

no idea why it was hard coded to that of all things

indigo sapphire
#

What

ebon kiln
#

oops lol

vivid musk
#

you can get the proper name in the lua file too

indigo sapphire
#

...

vivid musk
#

I think the release package was named correctly

vivid musk
indigo sapphire
#

Modded tags

vivid musk
#

actually I may have hard coded it when I was starting and trying to fix issues with love.filesystem, but the folder was still weirdly named

ebon kiln
#

that worked

vivid musk
#

try now

#

it had some left over, not fully implemented files

ebon kiln
#

ok

indigo sapphire
ebon kiln
#

is that on startup? @indigo sapphire

indigo sapphire
#

Yes

ebon kiln
#

interesting its working for me. thats from elbes fork?

indigo sapphire
#

Yeah, did you removed -main suffix

ebon kiln
#

yeah, I always do

indigo sapphire
#

I'll try

vivid musk
#

yeah, that line is looking for this love.filesystem.load('Mods/5CEBalatro/jokers/'..v..'.lua')()

patent fox
indigo sapphire
patent fox
#

Yeah np. Honestly it's looking like a lot of folder name issues could be solved this way.

vivid musk
#

if I knew more about them when I started they'd be in better shape

vivid musk
vivid musk
indigo sapphire
patent fox
#

Hey, working on 1.0.0 at all is still better shape than stuck on 0.9.8, so no worries. You're doing God's work updating so many different mods. 🧡

ebon kiln
#

@indigo sapphire mine looks like this and works

vivid musk
vivid musk
#

is it the same error? it's like its trying to process a file that isn't there

ebon kiln
#

Acutally it seems like it. this is me trying to run it not with your forked version

indigo sapphire
#

Another crash

vivid musk
#

the tetrapak source I forked had some old files that don't work anymore. try deleting it and getting my most recent set.

ebon kiln
#

Thats tetrapak now @indigo sapphire

#

same problem were trying to fix rn

indigo sapphire
#

Oh yeah

#

So it is good to fetch now?

vivid musk
#

I think it should be

vivid musk
#

the stuff from my repo. specifically you want to make sure it doesn't have a bad star chart file in the jokers directory

#

there's a couple of other files that got deleted but that's the obvious one right now

patent fox
ebon kiln
#

You're talking about downloading it from here right?

vivid musk
#

yes

ebon kiln
#

Ok just making sure we're on the same page. How do I make sure it doesn't have the bad star chart because it still crashes

vivid musk
#

that's directly copied from my mods subfolder

ebon kiln
#

We're in!

#

I was wondering because it said the last update you made to the repo was over 20 minutes ago when you said try now so maybe it didn't update?

vivid musk
#

i'm very confused by it

ebon kiln
#

Bottom line is it's all working now. Thanks Elbe!

indigo sapphire
#

Looks like they work

indigo sapphire
vivid musk
#

going through the repo just deleting old stuff now

vivid musk
ebon kiln
#

Umm is there a way to see a crash log from the game files? Everytime I try to play a hand the game just closes, no log or nothing

golden urchin
#

Stack overflow crashes sometimes result in the game closing but there's always a log created on game startup in Mods/lovely/logs

vivid musk
#

not a very helpful log, unfortunately

ebon kiln
pliant mulch
pliant mulch
ebon kiln
#

@pliant mulch its cuz hes a god

pliant mulch
ebon kiln
pliant mulch
golden urchin
#

I'm mostly wondering what issues are with D6 Jokers right now (other than auto-discovery and being fully abandoned for a while xdd)

ebon kiln
#

@vivid musk I found the culprit, it was Cruel Blinds

ebon kiln
indigo sapphire
#

Well... Flowwey was the author

vivid musk
#

progress...

ebon kiln
#

Ahh didnt know that

ebon kiln
golden urchin
#

Hell yea

vivid musk
#

apparently it is currently locking up the shop where you're supposed to get the free joker, even on vanilla tags

vivid musk
ebon kiln
#

Cruel Blinds used to work with my old modpack there must be an imcompatability somewhere

vivid musk
indigo sapphire
#

what's codex doing affecting tags collection

golden urchin
#

Probably an override?

#

Tag API didn't exist when Codex was made so it was likely required to display custom ones.

indigo sapphire
#

Oh yeah I remember codex has their own api

vivid musk
#

I think the update I just pushed will fix that. Essentially commented out most of the tagapi code. the one codex tag now shows up in the properely paged tag collection view

indigo sapphire
#

I'll try

vivid musk
#

apparently being the one person who has been using codex all this time has it's disadvantages

indigo sapphire
#

😂

#

Frankly speaking it was in my pack quite a while ago

vivid musk
#

without getting too distracted, I need to finish up the joker display support for mikas (as well as some extra mod support for a couple specific jokers), then I have sylvie's silliness, tag preview, and I still want to look at the weird sticker mod, and at the back see how much I can do to deck builder

indigo sapphire
#

Weird sticker?

vivid musk
#

yeah, that one

indigo sapphire
#

That looks WIP and need mod compat a lot

vivid musk
#

honestly the biggest issue I ran into with it is that every single joker showed up with one of the stickers, and that was a bit much

indigo sapphire
#

And that too

indigo sapphire
pliant mulch
vivid musk
#

I do it all manually through the website, like a pro

pliant mulch
#

Lmfao... that seems like the worst possible way to do repos

indigo sapphire
#

Oof, 😬😅

pliant mulch
#

I just have a folder called ".working" (in my balatro appdata folder for convenience) where all my cloned repos live and get worked on

vivid musk
#

When it was just me throwing something up real quick it got the job done

golden urchin
#

My older mods worked like that as well before I switch to GitHub Desktop for updating.

pliant mulch
#

I don't have that option being on linux

#

Plus git cli (+gh cli when needed) is just nice to use imo

vivid musk
#

Honestly I'm just glad people are enjoying my work.

pliant mulch
#

Yeah you do great stuff man :3

ebon kiln
indigo sapphire
#

👍👍👍

pliant mulch
# vivid musk this is weird, try this

@vivid musk do you think maybe you could make a thread for Mika's like you did for that other mod, where we try to get real art made for it? So many of the excellent jokers are still placeholders

pliant mulch
#

@vivid musk also made a PR to tetrapak replacing its contents with the zip you provided

vivid musk
pliant mulch
vivid musk
#

most of what I saw were asset related, which I don't think should be doing much of anything, but hopefully it'll work this time

pliant mulch
#

maybe it was actually using joker.png? Or the one file that got added when I did the merge was needed under that exact name

#

because yeah the only actual code difference was the order of the config section which shouldn't matter?

#

bizzare stuff

vivid musk
#

I hope you all are proud of yourselves, bullying a poor developer into actually using git as more than a basic file storage...

pliant mulch
#

lmao, silly :3

pliant mulch
#

does balatro 541 work without modification?

#

and what is zeus from?

vivid musk
#

I don't appear to have changed anything in balatro451

vivid musk
#

sylvie's silliness is in progress, I've got the blinds done so far

vivid musk
ebon kiln
#

Would you recommend adding in Mikas yet? Or is it still too unstable?

pliant mulch
#

I'm using it in my modpack and it seems to be working fine

indigo sapphire
#

It's mostly fine, just some cards will crash the game, some will not work.

pliant mulch
#

Even still on elbe's port?

indigo sapphire
#

Oh I haven't test it lately tbh

#

Disregard that

#

So Mika is fully ported, just some placeholder arts?

pliant mulch
#

Not sure. It's definitely at least mostly due apparently

#

And the placeholders are the same ones or always had

#

Now we have a few more real arts

#

But I think anything that isn't ported is still working as well as ever in 0.98 compat

indigo sapphire
#

Ok

#

But still, probably should ask Elbe if port finished

pliant mulch
#

@vivid musk what about kusomods and shenanigansmod. 2 deck mods that least I checked weren't working right

pliant mulch
#

Can you check out MystesOpenJokers?

#

just got this dooder and no effect

#

though that could just be my chatgpt-created fork making the fusion jokers not fusions, lol (was too lazy to just add them to DeFused)

indigo sapphire
#

And I oop

vivid musk
#

just keep finding random things I don't think I've ever even seen

vivid musk
#

ok, that's Sylvie's Silliness done. I added a search filter to allow modded content to end up in the booster packs (suits looks for cards that effect suits, flushes, wild cards, and the like, bonus looks for cards that revolve around enhancements, and fortune look for cards that deal with money)

#

I don't really expect you to add it to mod packs but I created a fork of Six Suits that interacts with Bunco better as well as allowing you to enable or disable starting with the extra suits
https://github.com/lshtech/SixSuits

GitHub

Contribute to lshtech/SixSuits development by creating an account on GitHub.

vivid musk
#

well I figured out why tag preview is locking the shop, now I just need to get it to actually do it's job

vivid musk
indigo sapphire
#

What's joker creation logic

vivid musk
#

each tag object has logic about how it works, so uncommon tag has logic to specifically create a joker that's uncommon. I should have covered most bases but there might be some specific tags I should write specific logic for

indigo sapphire
#

I see, in that case we can just test and revise

vivid musk
#

so with mystes it looks like conquistodor specifically had the same trigger condition as matador, which is a debuffed hand. i changes it to better match the description. I also added support for random editions/enhancements/seals from mods. plus innate support for defused, at least I thinkit should work.
https://github.com/lshtech/MystesOpenJokers

GitHub

A collection of new jokers for Balatro, plus other minor changes. - lshtech/MystesOpenJokers

ebon kiln
vivid musk
#

in my fork of it I actually use bunco's, disabling six suits, and adjusting the values to match six suits

ebon kiln
#

That works too!

#

Definitely using your fork then

#

Is Sylvies up on your repo as well?

indigo sapphire
#

What do you think suits better to fix all these conflicting modded hand types

vivid musk
#

well with my build the only new hand types are buncos (unless you don't have bunco), along with buncos planet cards and such. I balanced the around six suits, however, since a spectrum is a lot easier to get in six suits than bunco. It could be something to have familiar, et. al., support for more mod hand types

#

I have a matching build of inks and colors too, though I haven't uploaded it yet

vivid musk
vivid musk
#
GitHub

Contribute to lshtech/BlackSeal development by creating an account on GitHub.

GitHub

Silver seal mod for the game Balatro. Contribute to lshtech/SilverSeal development by creating an account on GitHub.

GitHub

adds seals that mess with probability. Contribute to lshtech/Dice-Seals development by creating an account on GitHub.

indigo sapphire
#

Oh my goodness

#

A hoard of mods

ebon kiln
#

Nice! Thanks elbe

indigo sapphire
#

I am getting assertion failed crash with ink and color + six suits

#

-# probably shouldn't do that

vivid musk
#

Odd, I can take a look in the morning. Do you have a crash log?

indigo sapphire
#

It's going along with my 100+ modpacks btw

indigo sapphire
#

Also I am getting this crash with familiar when viewing enhancement collection

vivid musk
#

Can you make sure the tag previewer is up to date?

indigo sapphire
#

Regarding which crash?

vivid musk
#

First, possibly both

indigo sapphire
#

I'll leave familiar for now tbh

#

Let's try first

#

Oh yeah It's fixed

#

Jesus

vivid musk
#

I had some bad enhancement code in my first checkin

indigo sapphire
#

Nevermind, still assertion failed

indigo sapphire
vivid musk
#

I guess it'll just have to wait till the morning so I can take a look at it

#

BTW six suits has a config option to not load suits and ink and colors honors that

indigo sapphire
#

What does assertion actually mean

golden urchin
#

Default error when using assert() function

vivid musk
#

Basically saying it should be some value so if it's not throw an error

golden urchin
#

Said function basically takes an arg, and if that value is not true an error is throws with Assertion failed as the default error when not specified.

indigo sapphire
#

I always mistook assert with insert

golden urchin
#

I think I know the issue.

indigo sapphire
#

I get it, it's an codewise fail, not gamewise fail (if that makes sense)

golden urchin
#

The "foil" edition being added is missing e_

#

I think

#

Line of off of any asserts for whatever reason and none have a defined error

indigo sapphire
#

But I am in a new run when nothing is yet to be happened, not even the blinds pop out of existence

#

Where's the foil coming from

vivid musk
#

Possibly tag preview

#

You could try disabling that

indigo sapphire
#

Maybe I am just too unlucky that both instances I tried with both suit adding mods that the game both gave me foil tags?

vivid musk
#

Don't have to be foil tags, non edition tags can generate with editions

indigo sapphire
#

Still, damn foils

vivid musk
#

At least I have an idea where to start looking tomorrow

indigo sapphire
#

I am probably adding only one or even none of the suit mods in my modpacks though

#

We will see

vivid musk
#

Wasn't exactly expecting you too, it's a pretty big balance change

indigo sapphire
#

Yeah

vivid musk
#

If you want just one I'd go with six suits, it has better compat with bunco baked in

indigo sapphire
#

I'll see what others think about this, thanks for the help and advice!!!!

vivid musk
#

Np, enjoy having way too many cards

indigo sapphire
#

Never too many

pliant mulch
pliant mulch
vivid musk
#

ok, patch for tag preview to check for editions and only try and set them if they exist (also try both with and without an additional "e_")

vivid musk
vivid musk
pliant mulch
#

Yeah it's probably fine as is

vivid musk
# indigo sapphire

I put in a pr with familar to fix this (and a couple of other small things I had different in familiar

vivid musk
pliant mulch
#

@vivid musk do you think maybe you could fix business joker from SpicyJokers at some point. It's always crashed the game on obtain

vivid musk
#

I can try, though the copy I have has the joker commented out

#

ah, dim is using his own fork

#

do you happen to have a crash log?

pliant mulch
#

Not atm. I'm not at my computer and it isn't really working atm

#

Maybe I can generate one with winnlator though. I did get it set up

vivid musk
#

the only thing that I could see that could cause a crash might be a compare a number to a table crash

indigo sapphire
pliant mulch
pliant mulch
vivid musk
indigo sapphire
vivid musk
#

do you have a crash log?

#

I finally got it to spawn in a buffoon pack but no crash

indigo sapphire
vivid musk
#

this is pretty bizarre, this card doesn't really do anything particularly unique

#

I pushed a change that might help, but right now unless I can replicate it the error is just complaining about a variable that I'm not sure where it's even coming from

vivid musk
#

I created a debug booster pack that just pulls that card and I can't get it to crash

pliant mulch
#

Are you using your version? Maybe you actually did fix it

vivid musk
#

if anyone else can get it to trigger reliably they can give it a shot

pliant mulch
#

So idk if it's bunco or what, but my modpack has really weird behavior with smeared and similar jokers

#

Flushes sometimes turn into spectrums even though there should only be 3 suits, and all sorts of weird things become flushes

vivid musk
#

I wouldn't be surprised if the spectrum logic had some issues with wild or wild-like effects

pliant mulch
#

Wild is easy enough probably with any 5 card hand with at least 3 wild cards being a spectrum, but yeah this is just weird

indigo sapphire
vivid musk
#

the spectrum stuff shouldn't change what registers as flushes though

pliant mulch
#

Yeah it shouldn't at least

indigo sapphire
indigo sapphire
#

also i wish there's an easy way to disable certain features like polymino cards and packs from bunco, w/o altering codes. do you think it's applicable?

pliant mulch
#

I don't see why it wouldn't be possible to add a config with a different mod, though it'd be involved. I'm not by any means an expert though

pliant mulch
#

You don't have to do all of these ofc, or any of them really. I just thought it'd be intesting to go through the mod index and look for old shit that'd sukk be cool to play with. With a focus on joker mods, because that's my thing

vivid musk
vivid musk
indigo sapphire
vivid musk
#

as a quick solution: table.remove(G.P_CENTER_POOLS["Booster"], G.P_CENTERS[boosterkey])

indigo sapphire
#

Oh, so I just add that line somewhere and fill in booster key right

vivid musk
#

yeah, I'd do an "if G.P_CENTERS[boosterkey] then" first just to be sade

indigo sapphire
#

I'll put them in my modpack utility mod then

indigo sapphire
#

sorry but what are the keys look like

vivid musk
#

for _,v in ipairs(G.P_CENTER_POOLS["Booster"]) do print(v.key) end

#

that will output all the booster keys

indigo sapphire
#

I feel dumb

vivid musk
#

i'm a developer for a living so none of this is particularly difficult for me, but I wouldn't expect a non-dev to really know where to start

indigo sapphire
vivid musk
#

you can just put that in your mod

indigo sapphire
#

then where will i able to read the keys

vivid musk
#

they'll end up in your lovely log file

indigo sapphire
#

it is partially working, but i got what i need

#

bunco's virtual packs should be p_bunc_virtual_*

#

does this work?

function Game:splash_screen()
    splash_screenRef(self)

    SMODS.current_mod = mod
   
    if (SMODS.Mods["Bunco"] or {}).can_load then
        -- Iterate through the Booster pool and remove entries matching the pattern
        for i = #G.P_CENTER_POOLS["Booster"], 1, -1 do  -- Iterate in reverse to safely remove items
            local entry = G.P_CENTER_POOLS["Booster"][i]
            if string.match(entry.key, "^p_bunc_virtual_") then
                table.remove(G.P_CENTER_POOLS["Booster"], i)
            end
        end
    end
end
vivid musk
#

you could use a string.find(entry.key, "p_bunc_virtual")

indigo sapphire
#

replace string.match(entry.key, "^p_bunc_virtual_") right

#

gotcha

vivid musk
#

yeah, match is for regex so it's slightly more complex than needed

indigo sapphire
#

OK

vivid musk
vivid musk
vivid musk
indigo sapphire
vivid musk
#

not yet, sorry

indigo sapphire
#

It's just weird that looking at the collection menu it will crash

vivid musk
#

I'll have to look at it in the morning, along with some other crashes I'm dealing with, but can you try and get a new crash log?

indigo sapphire
#

I'll try again later, kinda busy right now

pliant mulch
pliant mulch
vivid musk
vivid musk
pliant mulch
vivid musk
#

from a quick check only zeus and hera from olympus may not be working correctly

indigo sapphire
vivid musk
#

no, this one just adds a single enhancement that gives x3 mult plus some tarots that change your hand to a suit

indigo sapphire
vivid musk
#

is it x-card?

indigo sapphire
#

Nope, that's a rank enhancement thingy

#

Ah probably jellymod

indigo sapphire
vivid musk
#

I've updated my modpackfixes mod with a basic framework for removing objects from pools, so booster, vouchers, consumables, whatever

vivid musk
vivid musk
#

with assistance from GayCoonie

inland leaf
#

2000 dream is real

vivid musk
#

pokermon alone should put me well over 2000

spring ledge
vivid musk
#

also I pushed an update for tag preview to hard code logic for every relevant tag I saw. the catch all logic worked fine for edition tags but anything that tries to give you specific types of jokers just created a random whatever instead

vivid musk
indigo sapphire
#

Huh

#

I've got outperfected

vivid musk
#

honestly I'd probably still recommend yours over mine, mine is a bit too much of a kitchen sink

indigo sapphire
#

Didn't mine also

pliant mulch
#

Mine is a bit more straightforward and curated than either, but they all have their uses

vivid musk
#

I put mine up mostly as reference for everything I currently know of that I can add

pliant mulch
#

Do you have any recommendations that you think woods fit well with my setup?

vivid musk
#

I think you've got most of the ones that fit your MO. There might be a smaller joker mod or two you've missed. And you can always keep finding new, unported mods.

#

For what it's worth I have both jammod and jellymods, disabling the ones that have already been implemented.

pliant mulch
#

Can you keep you fork of jellymof updated to do that for me? If that wouldn't be too much work

indigo sapphire
#

Wait jam and jelly are two mods?

vivid musk
#

That's my plan. I'm actually going to engineer a solution that checks if they exist in jam before implementing them in jelly

pliant mulch
vivid musk
#

Jelly is old and has bad Ai art, jam is a port/improvement

pliant mulch
#

Yes that too

vivid musk
#

Jam is still missing a lot of art, since I think that puts in the negative for dims pack

pliant mulch
#

Yeah, I prefer everything to have art, but a surprising number of the implemented jokers do tbh

#

Still isn't nearly as bad as Jimbo's pack, lol

#

He just isn't confident in his art skill even though it's more than sufficent

#

Jimbo i mean

vivid musk
#

And getting others to help can be difficult if, you know, it isn't pokemom

indigo sapphire
#

I am considering remove Jimbo's pack and procrastinate on jam/jelly

vivid musk
#

I don't remember what the Jimbo art looks like offhand but it doesn't surprise me. I'm considering looking to possibly replace the ms paint art of Olympus with something more aligned with symbols of those gods

indigo sapphire
#

I'm just in procrastinating mood lately, since most of my mod selection are in the modpack and the rest are not so enticing for me

vivid musk
#

No really normal joker pack stuff seems to be coming down the pipe it seems

pliant mulch
#

Jimbo's art is fine, but he has most of them as blank joker templates

#

Like just the white cards with joker on both sides

vivid musk
#

Ah, yeah, I remember those

pliant mulch
hybrid skiff
pliant mulch
hybrid skiff
#

True

ebon kiln
pliant mulch
ebon kiln
#

Also Elbe I think D6Jokers doesn't work with the new Ortalab demo.

#

And does Cryptid make you have 10 Consumable slots now?

inland leaf
#

Thats a Jen thing

ebon kiln
#

Ahh kind of annoying can that be toggled?

inland leaf
#

Dunno I dont play w it

vivid musk
#

pushed a version that doesn't rely on that

vivid musk
vivid musk
median hawk
vivid musk
hybrid skiff
#

Oh okay that's probably fine

#

Also bte your using a commit with a half working greener pastures

vivid musk
#

so I'm experimenting with creating some new, standardized art for the olympus mod. opinions? (I borrowed the background from jen's)

ebon kiln
#

Getting this crash when beating the final boss on Ante 8. Is the Victory screen making the game crash or something? Crimson Heart BTW.

vivid musk
#

can you try replacing one line in the Blackjack.lua file?
should be ln 448, change it to "unlock_condition = {type = 'win_no_hand', extra = 'bj_jack'},"

ebon kiln
#

Ok, ill give it a shot.

#

yup, that fixed it.

hybrid skiff
#

Actually since you do have JamMod and JellyMod does ore deposit work on coal cards or whatever JellyMod adds

pliant mulch
#

ngl the one thing keeping me from adding jellymod proper is the enhancements. I even like some of them, but way too many in-hand effects for me

ebon kiln
#

I think there is a problem with Familiars Vigor card upgrading modded suits

#

Actually I think there is a problem with Fortune cards from familiar in general

vivid musk
#

I believe familiar's vigor had just been updated

vivid musk
#

get_id is returning a random number between -100 and -1000000

ebon kiln
hybrid skiff
#

looks like a crash to me

ebon kiln
hybrid skiff
#

Any time

pliant mulch
#

This is one of 2 proper balamod content mods that seems to exist, the other adding a new mechanic (luck) and not really up my alley

#

tbh looking at this one at least, the structure doesn't seem too different from smods

vivid musk
#

it looks certainly doable. mostly just the fun of translating the abilities functions into contexts, but I'm assuming that balamod itself would say how it defines each one

pliant mulch
#

yeah I presume, or at least the prehistoric build of it this was made for, lol

vivid musk
# ebon kiln Thoughts?

I'm not sure what card it was trying to create. possibly a planet with the reference to h_bunc_spectrum house in the variable list

vivid musk
pliant mulch
#

spectrum doesn't sem to work on cards that have an edition

vivid musk
#

ok, fixed

pliant mulch
#

nice :3

#

and I'll try switching out the cheesyjokers port in my pack

vivid musk
#

are you familiar enough with cheesy to know if the letter actually show up in the game?

pliant mulch
#

I have so many jokers it'll be hard to tell

vivid musk
#

it's a distinct series of objects that I didn't see anyway to actually use. I commented them out for now since it's just adding stuff into memory for no reason from what I can see

pliant mulch
#

yeah looking at the assets and code I don't think I've ever seen those in my life

#

for some reason

#

even though I've played with cheesy for a long time

#

even back when I had a lot fewer mods

vivid musk
#

somehow they would get attached to cards, like as an ability, but I didn't see any method for doing that, just handling them once they are there

#

and, obviously, none of the jokers mention them

pliant mulch
#

maybe some never implemented project?

#

left in the code because it's not doing anything yet?

vivid musk
#

that's my assumption, it's why I'm currently listing the port as experimental

pliant mulch
#

we can always just ask ilikecheese what they are, he hasn't dissapered like most of these devs

#

just isn't devving, lol

vivid musk
ebon kiln
#

hey @vivid musk Elbe for your modpack how do we properly install it?

vivid musk
#

basically the same way as Dim's. there's a setup batch file. though I disabled the auto copy bits

#

also added some somewhat better art for the olympus mod

ebon kiln
#

So is this how its supposed to go?

vivid musk
#

you have to install git first

ebon kiln
#

git?

#

is that a program?

vivid musk
#

its the software that actually syncs all the files

ebon kiln
#

ahh ok thanks Ive never heard of git

#

so theres an update .bat files too does that mean whenever you update the pack and I run it it will update?

vivid musk
#

that is the idea, yes

ebon kiln
#

That's pretty cool actually

#

oh yep now its working!

vivid musk
#

then find where it downloaded them and copy the stuff in the mods subfolder to the balatro mods folder

#

originally the script did the copy too but I turned that off for my own use. I added a new update that will also copy the files after

ebon kiln
#

it made a folder in the folder where the setup.bat was im assuming thats it

vivid musk
#

yes

ebon kiln
#

ortalab

vivid musk
#

ortalab's current code is broken, you can either add a file named ".lovelyignore" or just remove the ortalab folder

vivid musk
#

today's commits

ebon kiln
#

Is there a certain line where I add .lovelyignore?

vivid musk
#

its a file

#

it might be easier to just remove the folder for now

pliant mulch
#

Yeah just a blank file with that name

ebon kiln
#

oh I missed that

pliant mulch
#

And you can replace it with the last release to still play

vivid musk
#

by default windows is not a big fan of doing the .filename format since it likes to hide th extensions

ebon kiln
#

Classic Windows

pliant mulch
#

Ah good ol windowns

hybrid skiff
#

I mean linux hides them by default too but it doesn't care what you do

vivid musk
pliant mulch
#

Lol keeping the typo

ebon kiln
pliant mulch
ebon kiln
#

Okay now it looks like ror2 Jokers is causing an issue at launch

vivid musk
#

linux tends to assume that users probably are a bit more comfortable with working with files

#

ah, yeah, there;s stuff broken in that one. I need to upload my fork for it

#

as a warning, my modpack is not always going to be in full working order

ebon kiln
#

lol

#

Guess im here to bugtest then

vivid musk
#

I pushed an updat with a fork of ror2

ebon kiln
#

jesus already?

vivid musk
#

oddly the biggest issue with ror2 is conflict with risk of jesters, essentially both trying to create the same cards and since they are doing it the pre-smod way the keys clash

ebon kiln
#

Risk Of Breaking The Game 2

vivid musk
#

I already had the files fixed, I just had to upload them and update some stuff

ebon kiln
#

Ok we've hit title screen

#

Looks like you may have to update incantation or something

#

or its missing all together let me check

vivid musk
#

oh, I thought I got all of jen's stuff added

ebon kiln
#

yeah actually I dont see incantation at all

vivid musk
#

incantation is up

#

I want to have a more automated way to get jen's support mods but until almanac is updated to work with current jenlib I'm just going to add them manually

ebon kiln
#

ok, should I just go to jens repo and grab incantation for the time being?

vivid musk
#

either that or run my updater

ebon kiln
#

oh you pushed it to the updater. Let me test it out

#

Interesting

pliant mulch
#

It you add a .gitignore file to the ortalab directory it might work?

vivid musk
#

are you running the updator from the modpack\windows subfolder?

pliant mulch
ebon kiln
#

yes

vivid musk
#

oh, it's a bit weird right now, fo into that modpack subfolder

ebon kiln
#

drop the update.bat into the modpack folder?

vivid musk
#

if you go into the modpack folder there's probably a windows folder inside that. the setup just grabs it all and puts it wherever it lives so it's a bit nested right now

ebon kiln
#

oh I see what your saying. yeah thats working I believe

glad spindle
vivid musk
#

everything you need will be inside that modpack subfolder so you can move/clean up duplicate files as desired

vivid musk
glad spindle
#

👍

vivid musk
indigo sapphire
#

I can also add support to manage your modpack in my modpack manager too if you want

vivid musk
#

do you have descriptions in your manager?

indigo sapphire
#

Wdym

vivid musk
#

like "this pack is light weight" or "this pack is everything and potentially unstable"?

indigo sapphire
#

I can add that

#

But if anything I can only do them at night

vivid musk
#

but yeah, you can add it. I think it's in a reasonably good position at the moment

indigo sapphire
#

@vivid musk which color is your favorite

vivid musk
#

generally blue

indigo sapphire
#

There's many tint of blue

#

Any blue?

vivid musk
#

I guess so, I'm assuming its for a label or something

indigo sapphire
#

Yeah I am thinking about changing UI colors depending on which pack you chose

vivid musk
#

I guess just some mid blue that looks good on however the ui is layed out

pliant mulch
pliant mulch
#

this bugger

pliant mulch
#

also dollarfuck here doesn't seem to work

#

@vivid musk

vivid musk
#

pushed changes for those two

vivid musk
#

I went through and fixed up some more stuff

median hawk
#

oh wait nvm

#

must have room

vivid musk
sharp quiver
#

Btw elbe, for CodexArcanum, do you know about Aure's fork? They both seem to want to accomplish a similar goal

vivid musk
#

I think my fork is actually based on that one. it was largely working but I found a couple of things that weren't working right

golden urchin
#

The last update was 3 months ago

sharp quiver
#

Ah, right. I'm mostly just wondering if there's any reason for Aure's version to still exist tbh

vivid musk
#

I guess it depends on whether aure wants to do anything with it or not

sharp quiver
#

I believe it was mostly a band-aid fix for SMODS-1.0.0 incompat because it was (is) a big/popular mod

vivid musk
#

mine more or less still is. I've considered doing a proper port of it but it hasn't exactly been high priority.

sharp quiver
#

alright I'll assume your version is master now then

vivid musk
#

I guess until/unless the original author decides to dip their feet back in

sharp quiver
#

ofc

pliant mulch
#

@vivid musk I just realized I haven't been getting anything fun Sylvia's sillies spawn

#

I've done multiple full runs

vivid musk
#

None of the boosters?

indigo sapphire
#

I have

pliant mulch
#

Maybe I accidentally disabled it? I'll check when I'm at my pc

vivid musk
#

The consumables probably should, though I don't remember offhand what all it added there

pliant mulch
#

Iirc you did the consumables before the boosters

vivid musk
#

Yes. I had to take extra time to figure out what the boosters were doing.

#

But I believe they are just standard types so should end up in the standard pools

pliant mulch
#

Ah that explains it

#

Guess I needed to use use --init flag at least once when updating the submodule and failed to do so

brisk steeple
#

can someone tell me step by stop on how to download Steammodded 1.0

pliant mulch
pliant mulch
#

Ah there we go

#

Now just gotta remember to do it on my PC too

indigo sapphire
vivid musk
#

little needs to actually change to get it to work out of the box. improvements could be made, though

#

only change is that the blessing card is jimbo not neow

#

I can look at getting that card replace to work plus some improvements tomorrow

indigo sapphire
#

Thank you 😘

vivid musk
#

From what I can see, with ror2 ported that's all mods that I have that insert directly into g.p_centers done, other than jelly

pliant mulch
#

Have you considered that other balamod mod that I sent? Basically just a balanod tech demo but with decent objects and enough of them to be a small content pack

vivid musk
#

Hmm, there are a couple which could be done properly

indigo sapphire
vivid musk
#

I saw it offered me some options and I was able to open a booster it gave. It's possible that joker rewards may not work since I didn't try one of those

indigo sapphire
#

Then it's definitely some weird issues on my end

vivid musk
#

Since I'll be working on it more tomorrow I'll try out more options to see if there are larger issues I missed.

indigo sapphire
#

🔥

indigo sapphire
vivid musk
#

not sure how I missed that. cicero was trying to calculate with variables it didn't have because it's not supposed to. I removed the broken code.

vivid musk
#

ok, I think neow spawning jokers should work now

civic escarp
#

(I was not the porter either)

vivid musk
# pliant mulch https://github.com/nicholassam6425/balatro-mods This also, while more or less j...

I have an initial port for the arachnei balamod mods, other than fortune. https://github.com/lshtech/arachnei-balamod
I added an easy way to disable objects in code since most of these were originally example mods for balamod.

GitHub

collection of balatro mods. Contribute to lshtech/arachnei-balamod development by creating an account on GitHub.

stoic bridge
vivid musk
#

ah, I didn't port the quick reset since I think pressing and holding r already works, though I'm not sure if that's vanilla or from debugplus or something

pliant mulch
#

It doesn't start a new run, just rerolls tags

vivid musk
#

I guess I thought it was a run reset based on its name

pliant mulch
#

Though betmma already implemented the booster and voucher, i kids like three idea of having the booster because it should give me more voucher packs that way

vivid musk
#

the spectral that give $100 is the only one that particularly jumped out at me. the "sols" joker is a reference to something that I don't know

pliant mulch
#

Yeah same on both

#

Maybe the spectral should be a soul-rate style spectral

vivid musk
#

the voucher doesn't work alongside the betmma implementation. like they both work, just not together

pliant mulch
#

In any case I woulda turned it off to use the betmma version. It's just the booster, the one /with/ vouchers, that I like having both of, to basically hack a higher spawn rate for voucher packs, lol

#

And I do like the different art on each

vivid musk
#

Basically this one appears to take precedence so the price increase of betmmas is ignored. If you redeem both the worst that happens is you wasted your money.

pliant mulch
#

Ah makes sense

vivid musk
#

I haven't really dug much into the actual fortune mechanics thus far, just looking at how all the vanilla jokers are categorized in the code for it

pliant mulch
#

Doesn't seem too friendly to a mod-heavy setup ngl

vivid musk
#

Something I am keeping in mind

pliant mulch
#

Fair

#

Oh om another note, I noticed some of the assets for the community pack aren't trimmed to 71x95, leading to some weird display issues

#

I think the mediocre art is charming given the context that just needs a slight tweak

vivid musk
#

Yeah, I saw those

pliant mulch
#

Got a Jimbo in a Suits pack

pliant mulch
#

got this mousing over a 'fool' card generated by a purple seal. I think the last tarot I used might have been Ace of Pentacles

vivid musk
pliant mulch
#

something is defaulting

#

that's what a jimbo means

#

it must've rolled for a card type it couldn't satisfy

#

even modded consumable types default to jimbo if they don't set their own default

vivid musk
#

everything that gets populated in there is from cards already in the relevant pools

pliant mulch
#

tbh I'm not sure I've gotten any actual jokers in suits packs

#

something might be broken there

vivid musk
#

I just opened a mega and got four jokers

pliant mulch
#

hmmm... weird

#

maybe I need to do some debugging

vivid musk
#

for what it's worth I just opened a bunch of packs and didn't see anything abnormal

pliant mulch
#

same

#

maybe something fucked with the pools that run or smth

#

who's to say

#

I'll let yuou know if it comes up again

#

Also, Spectrum still isn't working on editioned cards

#

i don't recall if you ever said anything about that

vivid musk
#

spectrum should only not work on cards already enhanced. did you make sure you got the newest version of it? line 63 of goldscards.lue should read "if G.hand.highlighted[i].ability.effect ~= "Base" then"

pliant mulch
#

so I was assuming it was the edition

#

I think it let me overwrite enhancements before if the card wasn't editioned

vivid musk
#

the original code I checked in stopped for editions but I updated it to enhancements

pliant mulch
#

huh, it shouldn't do either imo

#

but fair

#

I just wrongly assumed it wasn't workinng for the same reason

#

because the card I wanted to use it on had both

vivid musk
#

I pushed a version that doesn't do a check

pliant mulch
#

thank you :3 I'm super apperciative of how quickly and throughly you maintain all these old-ass mods

vivid musk
#

I'm not sure what could be going on with that mika crash

pliant mulch
#

it happened after an unrelated crash, so maybe something just got corrupted?

#

are there any other mod forks/ports on your agenda, or have you pretty much got everything out that you wanna do? Besides what we've already discussed in DMs, if you end up doin those

vivid musk
#

not really. currently looking at fortune. I want to do some qol stuff for some of the existing ports, but I'll have to figure out what I'll want to do after that

pliant mulch
#

I think I pretty much exhasted every list of mods I know for suggestions

vivid musk
#

maybe musical suit because I'm insane

pliant mulch
#

looks like updates were abandoned a fair bit before people stopped giving ideas

pliant mulch
vivid musk
#

the awesome mod list has a handful of old balamod stuff that hasn't come up yet too

pliant mulch
#

tbh there's a million old decks that could probably be comboined into one mod

#

that's in general, not talking about the balamod stuff specifically

vivid musk
#

aye, I've just been skipping over the deck ones when I look through lists

vivid musk
pliant mulch
#

yeah that's what I was gonna suggest

#

thank you again

vivid musk
#

the community pack is an interesting idea

indigo sapphire
#

Your modpacks has been much "fuller" than mine

vivid musk
#

the arachnei pack has been updated with fortune cards and the tag reroll.

vivid musk
vivid musk
#

I pushed an update for the community mod to make Not Found work as intended (1 in 4 to set chips to 404, not 1 in 4 to add 404 chips). Add creator credits for all implemented cards. Add a list of cards to consider from the community thread that haven't been implemented here.

vivid musk
#

two more cards implemented

indigo sapphire
#

Oh, also do you have looked into deck creater mod?

vivid musk
#

I keep putting it off becuase UI stuff is a mess

indigo sapphire
#

Fair

indigo sapphire
#

I'm thinking about receding from the pursuit of everything modpack (which yours are definitely doing better than mine)

#

And do it like coonie's

vivid musk
#

more of a balanced load?

indigo sapphire
#

More of a personal mods

#

That I personally will use

vivid musk
#

probably helpful to have a pack that you actually like to play

indigo sapphire
#

It's not that I don't play the packs I am maintaining right now

#

But some mods inside I rarely use

vivid musk
#

you gotta do what works for you, right? my list wouldn't be here without yours

indigo sapphire
#

I guess so

vivid musk
#

heck, I didn't know about the git submodule thing so I had to do it all manually before

indigo sapphire
#

Yeah I learned about submodules and stuff very recently too

#

I'll see what works for me

indigo sapphire
#

found these two when i am fumbling through my removed mod list

vivid musk
#

I hadn't seen that shop one but I added the robalatro one to my list today, along with a live-a-live one. haven't really tried them out but no errors starting up

indigo sapphire
#

i think robalatro need thorough checking

#

also can you figure out why bunco causes house rules to load significantly slower?

#

and maybe tune down the Sylt Stickers weight

indigo sapphire
#

I think fortune packs are supposed to only give money (and maybe also possibilities) related cards? (assuming)

#

black seals have duplicate tooltips

indigo sapphire
#

you might wanna re-add deck skin plus as submodule

vivid musk
vivid musk
#

I halved the rate for sylt stickers

#

fortune packs are specifically looking for cards with "gold card" or "$" in their description

#

I need to do a proper port of the seal mods

indigo sapphire
#

cool cool

vivid musk
indigo sapphire
#

i remember it's the consumables

vivid musk
#

I'll go over those when I get a chance

indigo sapphire
vivid musk
#

I do not, I'm not sure I knew about that one

vivid musk
#

ok, pushed actual ports of the seal mods

vivid musk
indigo sapphire
#

Nice

vivid musk
#

I'm going to work on doing a proper port of risk of jesters. I'm getting the occasional odd interactions with it.

pliant mulch
#

@vivid musk do you think you'd be able to give arachnei-balamod a proper smodded config? So I can use yosbr to ship it in my mod pack with fortune defauled to false?

#

or to be easy, just default it to false anyway

pliant mulch
#

Do you think there's any way you could make Gacha deck (from KusoMods iirc) compatible with reverie and tags that generate jokers?

vivid musk
#

finished the risk of jesters port. no lovely patch, which is always nice

vivid musk
#

config for arachnei has been added

crude drum
#

the sniper bugged on proc

#

card.ability.extra.total_chips is never assigned

#

so it cant check if it procs

#

i think

vivid musk
#

I pushed a quick fix that should hopefully help. it's a pretty common error type that seems to show up with chip related values a lot

pliant mulch
#

I recognize it

vivid musk
#

the best solution, for me, is to wrap offending values with to_number()

pliant mulch
#

Tbh I think that's the actual way to add talisman compat

pliant mulch
# crude drum

If you keep talisman in vanilla mode, (will wipe your current run) this shouldn't happen

pliant mulch
#

@vivid musk I think that the 'Humanity' tarot just doesn't work

#

the use option is always greyed out for me

vivid musk
#

Odd, it works for me. It checks that you have between one and three cards selected but not a stone card. Are you pulling it from a booster? What kind?

pliant mulch
#

maybe an arcana dx pack?

vivid musk
#

May have to investigate if there are any other states to be aware of

pliant mulch
#

Is it because I have fortune disabled maybe?

#

idk why that'd do it, but being in the same mod, it mighta accidentally got tied to that?

vivid musk
#

Wouldn't think so, if humanity shows up at all it should work

#

I did realize you can select 1 card, which seems kind of pointless

#

Looks like I have a few things that seem to be borked after some updates. Of course it happens on a morning when I don't feel great so they may have a to wait a bit.

pliant mulch
#

No worries man. Your wellness comes first :3

indigo sapphire
#

I'm getting this crash with your modpack

#

Don't even know what rep_Cards2 is referring to

torn cradle
#

same

vivid musk
#

Repentance

#

It's missing some atlases I think

vivid musk
indigo sapphire
vivid musk
#

Hmm, not sure since I haven't taken a look at it.

indigo sapphire
#

Maybe give it a look

#

It's cool but sadly not compatible with many mods for some apparently obvious reasons

vivid musk
#

that's been pretty much the reason I haven't looked at it, but I could try and see how bad it is

indigo sapphire
#

I see 🤔

#

I mean it looks like it could go well with other mods, functionally speaking

#

But I don't know much codewise

vivid musk
#

so far I think the biggest issue is that they are fully overriding vanilla functions. other mods extending those functions may work with it but it would be unpredictable depending on how early or late it's possible that a mod's extension may never run.

#

I'd have to go over the functions more closely but I might imagine that the functions could be rewritten to extend and not overwrite

pliant mulch
#

@vivid musk think it's fine for the Fusion Joker family to get a 1.0 port

#

that I can precede to rip off for DeFused

vivid musk
#

I just did a quick fusion and it seemed to work

pliant mulch
#

Someone said it was a steamodded version thing

vivid musk
#

I assume so, I run the update script pretty regularly

#

I mean it would make sense, I guess, since they change the rarity api

pliant mulch
#

Yeah, rarity 5 should be invalid now I think

#

I don't ever use the actual Fusion mods so Idk

golden urchin
#

I'm cure that the rarity API breaks if you use integer rarities that aren't 1, 2, 3, or 4

vivid musk
#

I do have the newest steamodded based on the last checkin

#

I fused a card, it has the proper "Fusion" badge, and the rarity on the center is still 5

#

it's weird, the rarity api would break for any number value greater than 4, but it's acting like it's not using the rarity api for my fusion instance

golden urchin
#

Maybe it circumvents the API enough it somehow doesn't need it?

#

Or does it break the parts of the API?

#

Where's the fork for it

vivid musk
golden urchin
#

Not sure why it's not crashing on the badge line but it does manually remove and re-add the rarity text

vivid musk
#

well I think I know why it's not happening for me. the rarity api is getting broken by cryptid or ceres lovely patch

golden urchin
#

Ohh

#

Yeah that would explain it

vivid musk
#

so it's doing it the old way

golden urchin
#

I know that Cryptid pre-spoopy update break Steamodded but Ceres?

vivid musk
#

this is what my ui_definitions looks like
if Ceres.COMPAT.cryptid then
if AUT.card_type == 'Joker' or (AUT.badges and AUT.badges.force_rarity) then card_type = ({localize('k_common'), localize('k_uncommon'), localize('k_rare'), localize('k_legendary'), ['cry_epic'] = 'Epic', ['cry_exotic'] = 'Exotic', ['cere_divine'] = 'Divine'})[card.config.center.rarity] end
else
if AUT.card_type == 'Joker' or (AUT.badges and AUT.badges.force_rarity) then card_type = ({localize('k_common'), localize('k_uncommon'), localize('k_rare'), localize('k_legendary'), ['cere_divine'] = 'Divine'})[card.config.center.rarity] end
end

#

cryptid may have broken it and then ceres just did it's thing on top of it

golden urchin
#

ah

#

yeah that would prevent the function that causes the reported crash

#

Through the power of spaghetti you dodged crashing from :lower()

vivid musk
#

its always fun to figure out why something isn't crashing

#

I feel like I should be able to come up with a workaround for cryptid breaking, but, yeah, fusion would need to be updated

golden urchin
#

Cryptid is already updated to remove the old lovely injects for rarities

#

Ceres needs to update if this is still a thing

vivid musk
#

ok, looks like I definetely have an up to date version of cryptid so I'll look at ceres

golden urchin
#

yeouch, it still does

vivid musk
#

looks like I should update tag preview too

#

I'll see what all it takes to update to the new rarity api for fusion

indigo sapphire
#

I saw your modpackfixes mod have a blacklist function?

#

I figured it out, but the collection menu now looks like this

vivid musk
#

what's the blacklist you're trying to add?

indigo sapphire
#
table.insert(CenterBlacklist, "c_bunc_the_s")
table.insert(CenterBlacklist, "c_bunc_the_i")
table.insert(CenterBlacklist, "c_bunc_the_o")
table.insert(CenterBlacklist, "c_bunc_the_t")
table.insert(CenterBlacklist, "c_bunc_the_z")
table.insert(CenterBlacklist, "c_bunc_the_j")
table.insert(CenterBlacklist, "c_bunc_the_l")
table.insert(CenterBlacklist, "c_bunc_the_slash")
#

This was the first (and stupid) one I did

#
        for i = #G.P_CENTER_POOLS["Polymino"], 1, -1 do
            local entry = G.P_CENTER_POOLS["Polymino"][i]
            if string.find(entry.key, "c_bunc_the") then
                table.remove(G.P_CENTER_POOLS["Polymino"], i)
            end
        end
#

This did the same

vivid musk
#

ah, specifically for the polymino consumable section. I thought your entire consumable screen was borked. my fault for looking at your message before I was fully awake.

indigo sapphire
#

I didn't specify them, my fault

indigo sapphire
vivid musk
#

so far I'm not sure how to hide that button. I've managed to make the button just close the collection screen, but that's not exactly useful

indigo sapphire
#

Yeah

#

I guess I'll just accept it is not hideable

indigo sapphire
#

Do you think you can make the blacklist stuff toggleable?

#

Like, in game toggleable

vivid musk
#

I guess I could make it triggerable. You'd have to restart to get the items back if that's what you wanted

indigo sapphire
#

Wdym

vivid musk
#

so if I made it a config value you could turn it on but if you wanted to turn if off after I can't put the items back in the pools so you'd have to restart

vivid musk
#

I could add a blacklist type option. you could enter "Polymino" or whatever the type name is and it can remove any cards that use it as well as the collection button. the boosters would still need to be handled since those aren't tied together the same way.

vivid musk
#

updated the mod to support types so the current way to hide polyminos would be

indigo sapphire
#

Nice

pliant mulch
#

@vivid musk Repel deck seems to have both the sprite and effect of (Kusomod's) Joker Deck

#

idk if this was just how the original mod was or not

vivid musk
#

the sprite appears to be the same from what i can see. the code is actually different for repel deck. joker deck starts with two random jokers and repel deck starts with two specific jokers

pliant mulch
#

I assumed it was money related tbh from it

#

but now I see the color usage

vivid musk
#

you're right, it doesn't, which made me go check the original code to make sure it was right

pliant mulch
#

I use purple and aqua for every dichotomy I think

vivid musk
#

{C:red}Less{} is {C:blue}more{}, earn more per hand,",
"{C:red}rapid growth{}

pliant mulch
#

Oh it's useless, I see.

#

so yeah it's just decrative anyway I guess. So the description tells you nothing

#

Fair enough

vivid musk
#

so you get vampire and steel jokers and the trigger effect for the deck appears to give you more chips during the scoring steps

pliant mulch
#

makes sense, not my thing really, but not the worst. I can see the gimmick

indigo sapphire
#

Is it possible to somehow cooperate all rebalance mods?

#

Like if three mods all have a version of jimbo

#

It will become jimbo1 jimbo2 jimbo3 instead of conflicting

vivid musk
#

that's an interesting idea... it might be possible as I think about it

#

hypothetically I could intercept the take_ownership command to essentially clone the joker

fringe trellis
#

because it leads to a crash

vivid musk
#

what does it the code look like?

fringe trellis
#

I'll remake it because i just deleted it

vivid musk
#

really you just need to put the table.insert statements after the appropriate if then statements

fringe trellis
#

I probably put it in the wrong spot

#

------------MOD CODE -------------------------
local mod = SMODS.current_mod

if not TypeBlacklist then
TypeBlacklist = {}
end

Table.insert(TypeBlacklsit, "Polymino")

if not CenterBlacklist then
CenterBlacklist = {}
end

table.insert(CenterBlacklist, "p_bunc_virtual_1")
table.insert(CenterBlacklist, "p_bunc_virtual_1")
table.insert(CenterBlacklist, "p_bunc_virtual_jumbo")
table.insert(CenterBlacklist, "p_bunc_virtual_mega")

#

did a typo there but other than that this is what I had

vivid musk
#

that looks about right, what was the error?

fringe trellis
#

Something about a table index nil value

#

ill try again

vivid musk
#

make sure that first table.insert is all lowercase too

fringe trellis
#

It won't let me screenshot so I gotta use my phone

vivid musk
#

table.insert needs to be lowercase

fringe trellis
#

Gotcha

#

Wow was that really it

#

It boots now

#

Thanks!

sage geode
fringe trellis
#

Hi @vivid musk, the modpackfixes mod is causing the Bunco card "Critic" to crash the game when it triggers, did I screw something up in the lua file yesterday?

vivid musk
#

critic has been a bit of a trouble card, make sure you grab the most recent version of modpackfixes, you'll want to copy your blacklist stuff too

fringe trellis
#

okay thank you

sage geode
vivid musk
#

I dont think I touched those cards

sage geode
#

I figured as such, was just making sure

indigo sapphire
#

What about whitelist? Do you think you can make it only populate a list of items?

vivid musk
#

Remove everything but a specific list?

indigo sapphire
#

Yeah

vivid musk
#

I guess it's possible. Obviously you don't want to accidentally exclude jokers or something

indigo sapphire
#

I just hope it's possible, so I can selectively put some stuff in a pack

vivid musk
#

Like a whitelist for a specific mod?

indigo sapphire
#

Yeah like if I just want specific things

#

I don't know if that's too much trouble

vivid musk
#

Honestly that shouldn't be too hard. Would you want it to filter by type or object?

indigo sapphire
#

Both would be awesome

vivid musk
#

Yeah, I can probably do that

languid kettle
#

can "mod pack fixes" be used by itself to resolve issues with some of the mods? or is tailored to a specific mod pack and will cause issues outside of it

#

i'm running into an issue with the bunco cup and balls voucher causing a crash, and have a few other mods installed. if i can just install the "mod pack fixes" mod to fix things, i'll do that.

indigo sapphire
#

Should be usable

languid kettle
#

cool 👍

vivid musk
#

Mod pack fixes tries to be a non-opiniated set of fixes for any issues I run into (that I can do anything with). I built it so that it only makes changes if you have those specific mods, so it should never have any hard requirements other than steamodded

languid kettle
#

thanks :]

vivid musk
#

library page has been updated/fixed.

lean geyser
#

should i have the modpackfixes thing installed? trying to use jen’s almanac from this modpack and it seems to still have an issue with the rarity API (crashes with ‘attempt to get length of local ‘pool’ (a nil value’)

#

also i ran the “setupfull.bat” and it didn’t extract into my mods folder (which is fine because now i can pick and choose which mods i want)

lean geyser
lean geyser
#

gutted my mods folder and copied everything from this modpack, game launched and allowed me to start a game…but crashed when clicking “open a booster pack” on the prompt it gave me. now whenever i press play, i get a lovely injector crash.

indigo sapphire
#

Use 0.6.0

lean geyser
#

ye, figured that was the issue

lean geyser
#

jen’s mod from this pack is crashing with that “attempt to get length of local ‘pool’ (a nil value)”. i’m using the latest main of steamodded and lovely 0.6.0

vivid musk
#

Do you have the crash report?

lean geyser
#

yeah, let me send the log file here

vague oxide
#

Have you tried downgrading to Lovely 0.5.0-6

#

0.6.0 has a lot of kinks that need to be ironed out

vivid musk
#

its weird that I don't get that crash, but I pushed a fix to how the rarity api is implemented in jens that might help

lean geyser
#

i’ll try downgrading to 0.5.0 beta 6 and then update the modpack to see if that fixds it

#

the fix worked

#

jen’s now works, thank you

civic escarp
golden urchin
#

Some regression that messed with the order of injections causing some to go before/after another when it used to not be the case

#

Something like that