Buffoonery | Vanilla-balanced Jokers [v2.0.1 Rework!]

[shadow haven]

hold on, I have a link to it somewhere, I had sent it in #⚙・modding-general earlier as I was unaware of what mod had caused it

#⚙・modding-general message

that's the link

this is the crash

[wicked topaz]

Yup, talisman 😭

I'll have it fixed in a sec

[wicked topaz]

Fixed

[shadow haven]

yipppeeee!! :333

downloading now

[supple musk]

danke schoen

[supple musk]

Hey uhhh my ^mult has been retriggering all by itself recently. Caramosa and Prism's Hypercube included, which is really strange. Has there been any updates to steamodded or something?

[graceful vault]

This may be because of Prism

If you don't have talisman

[supple musk]

Oh, no, since talisman isn't compatible with a lot of things

[wicked topaz]

That's strange. I'll figure this out

[wicked topaz]

Ooh I see

I'll add an exception to Prism, so that stuff don't trigger twice when both mods are installed 👍🏻

[supple musk]

@wicked topaz Looks like since both you and blazingulag added checks now neither trigger on **^**mult.

[wicked topaz]

Yeah, I messed it up lol. However:

Fixed

[supple musk]

poggor

[supple musk]

@wicked topaz patronising joker doesn't make sure its not blueprint before making a supportive joker (can make 2 supportive jokers)

[sleek cedar]

Quirky

[wicked topaz]

Whoops

Will fix

[karmic vale]

@wicked topaz can u look dms real quick 🙏

[supple musk]

Sandstone sleeve + plasma deck does not quadruple blind size

[wicked topaz]

Whoops². Added to the fix list

[slate quarry]

It appears that the in_pool function for blinds is broken when the latest version (1.2.1) is installed. I can tell because in Almanac, Epic Blinds (the Finnish sounding name blinds) appear before Round 40, Cryptid's "The Shackle" appears even without Negative Jokers (Only appears when you have negative Jokers in hand) and my blinds that use in_pool can spawn anytime even without the conditions (for instance requiring either >5 stone cards or having a Jolly Joker) fulfilled. I can tell its this mod, because removing it removes the issue.

Its likely to do with the get_new_boss function being overridden. Is it ok to consider making a fix for it (such as a hook if possible)?

[supple musk]

issue with Supportive Jonkler, something about indexing cards. For context, was on The Serpent

[sleek cedar]

suggestion: make the price of super sayajimbo increase every time he powers up

to improve temperances and make it feel slightly less bad if you have to sell him at some point

[wicked topaz]

Yeah, it's that function for sure. I'll make a hook. Sorry about that.

[wicked topaz]

Will investigate this rn

[wicked topaz]

I approve of this suggestion

Makes sense the price would scale as well

[sleek cedar]

🫡

[supple musk]

Pertinent argument also converts two-pair-containing flushes into flush houses. Is that intended

[wicked topaz]

Nope, but since it does, I think I'll just leave that in and adjust the text as a buff, since it's kinda bad for an uncommon tbh.

Should I do it? Maybe also make it so when it converts, the two pair becomes a regular full house as well

I'm kinda busy with irl stuff these days, but this weekend I'll post an update with those bug fixes and the change about pertinent argument

[heavy jacinth]

It sounds like it should make sense

With three cards that are of the same rank in one pair, and two cards of the same rank in the other, it would be really weird to call it a Two Pair when it should technically count as a Full House

Plus it gives P.A more use IMO

[wicked topaz]

True. I kept it two pair mostly for flavor, but full house kinda makes sense in that department as well, I guess.

[supple musk]

I will say, im all for both versions, mostly with synergy with ramping spare pants and cutoffs n such

[sleek cedar]

Pertinent argument in real life

[wicked topaz]

Lol

An argument that's pertinent to pertinent argument

[graceful depot]

Spoilered for mentioning a Special Joker :3c
|| Supportive Joker Crashes the Game if the Deck has less than 3 Cards.
Either because it's trying to check cards out of Bounds;
Line 37: local _card = G.deck.cards[#G.deck.cards-(i-1)]
Or because it doesn't fill the Config-Keys, then it might be;
Line 28: vars = {card.ability.extra.trank[1], card.ability.extra.trank[2], [...]
Eitherway: I added if #G.deck.cards > 3 in the update-function to continue my Run, before thinking about reporting it first.. Sorry x'3 ||
=> 🥔

[wicked topaz]

I'm actually aware of this one. Will release a fix for it (along the other known bugs) when I have the time (life is busy rn)

[raven ice]

Minor bug with Bunco compatibility, the new Buffoonery stakes don't apply previous stakes properly. It seems this mod has the line prestake_pldm = 'bunco_gold' for compatability, which is no longer needed (Im assuming an older version of Bunco required it)

there's also been a bug reported where a Bunco final boss blind that requires certain conditions to appear can do so without those conditions while this mod is installed. This may be related to new Buffoonery stakes. I am investigating this now

[raven ice]

It seems to happen with other stakes with custom appearance conditions too, like a couple that only appear on certain stakes

[raven ice]

Aha, issue found! And it's pretty simple, it's just that Buffoonery's buf_get_new_boss function doesn't check for the in_pool function for blinds. So, any custom conditions wont apply

[supple musk]

Did some work on the Readme to get it updated. Dunno how you make the images, so I didn't bother. It also has all the special jokers, although not how to acquire them.

[wicked topaz]

Yeah, that was a silly oversight lol. There's a big holiday coming here and I'll get work done on buffoonery soon

[wicked topaz]

Ayyy thanks!

[supple musk]

@wicked topaz Sayajimbo isn't activating for me atm, i think the only change is I have Bunco now. According to my "perfect" bug testing, he's always being counted as retriggered. I'm definitely meeting score requirements

It might have something to do with Bunco's Critic joker? It has a similar check.

[wicked topaz]

Will investigate

Saya isn't upgrading? Or isn't he giving chips/mult/etc?

[supple musk]

He wasn't upgrading. But then he started upgrading and im not sure why.

[wicked topaz]

Oooh. I think I know what's up. It's probably just the sprite not activating, since (as of now) it gets changed "permanently" whenever an upgrade happens until you restart the game

[supple musk]

well it also wasn't giving mult, it was definitely staying as chips

also my friend keeps being frustrated about specifically the wording on pertinent so here's a quick fix (is -> contains, lol)

[wicked topaz]

Yeah lol he's right tbh

[wicked topaz]

Dammit

[supple musk]

and yeah, it definitely wasn't upgrading. i put little print comments in each of the locations, it was definitely getting calculated, and every time it said false to the if statement for upgrading (i added an else and it was constantly being hit)

[autumn lagoon]

Bro I had no idea the clown card had something to do with clowncore

also since when is clowncore nu metal

[wicked topaz]

Clown is from slipknot (he's a member)

Van is from clowncore tho

And clowncore is not nu metal, but (spoilers ahead) ||since Van is Clown's special, I decided to keep it "nu metal" for Maggit, since the player might accidentally transform clown into van and lose Maggit's activation otherwise||

[supple musk]

speaking of nu metal we should definitely get a linkin park jonkler

or... nu metal food joker? :) corn

[gusty rock]

Isn’t there already korn

[wicked topaz]

LP jonkler would be nice indeed

[autumn lagoon]

Clowncore inclusion is appreciated

[supple musk]

this is something that can happen which is interesting. With the bunco boss "The Prince". Seems probably fine tho its counting as ssj2

and it fixed itself when it upgraded

[quiet plinth]

To b3 fair, I did continue a run after updating smodded, so it may be nothing, but it was only like a 1 day difference in version

I get this crash when I try to cash out

[edgy badger]

Talisman moment

[wicked topaz]

Looks like a recent update to smods decided to break stuff

I'm buried in work these days, that's why I haven't worked on the mod

I'll see if I can find what's this all about

[regal hazel]

Hi there,
I'm currently trying to make an exponential joker and I saw you made a couple in this mod. I tried to read your code, but couldnt' find where emult was defined (or if that was even what caused the exponential effect in the first place).

do you mind helping me out?

[regal hazel]

nvm I found it... I think

[wicked topaz]

It's in the notalisman.lua and lovely/notalisman.toml files 👍

[regal hazel]

Neat!

[supple musk]

I forget if PinkMaggit or Blazingulag did the cross compatibility for no talisman, but you may want to also look at Prism's implementation of emult

[regal hazel]

Who/what’s prism

[supple musk]

https://discord.com/channels/1116389027176787968/1345468876476911646

[regal hazel]

Muchas gracias

[turbid talon]

seems like the boss selection does not respect the blind's in_pool function

i found out about this issue because i was looking through someone's mod list

[wicked topaz]

Yeah, the current implementation of the boss blind-altering stakes is a little buggy. I haven't yet found time to sit and code for a long time now, unfortunately. I think it has to do with the fact I altered a vanilla function, iirc

[waxen sierra]

updated zh_CN translation for the latest version

also maggit_alt didn't use the new expmult color for some reason, possibly an oversight

[feral trail]

hey so ive updated smods to a newest version and for some reason started to have issues with cards with destruction chance destroying other cards, im trying to figure out whats causing this

[idle orchid]

you played more then 3 cards

oh wait

whoops!

yea thats not normal

[feral trail]

yeh

[feral trail]

can confirm this happens even with no other mods present

[graceful vault]

this is a bug with smods i think

i had the same issue with prism

what smods version do you have?

[feral trail]

thought so! but reporting it they told me to bother the mod makers

smods-1.0.0-beta-0509c

[graceful vault]

yeah, the modders should fix it

[feral trail]

im guessing they changed something with how those are written and all stuff from before is busted noww

[graceful vault]

i think they changed the way destruction works and it breaks older mods

[graceful vault]

exactly

[feral trail]

im in a funny situation now where i have a lot of mods that break on this version, and also few that use new solutions and break on earlier one @~@

[graceful depot]

You can get Laidback from Buffoon Packs, even when you shouldn't have space for it x3

[wicked topaz]

Thanks! I'll push it into GitHub

[wicked topaz]

Yup, oversight. I should fix it

[wicked topaz]

Yikes, something's changed then

I'll have to check

[wicked topaz]

Whoops, forgot about buffoon packs

The irony

There's lots of stuff to do with this mod

[graceful depot]

I was testing another Joker for a similiar scenario, so I'll just leave that working snippet here x3
-# lovely patch:

# Always allow selecting "Bound Joker" (in packs for example!)
[[patches]]
[patches.pattern]
target = "functions/button_callbacks.lua"
pattern = "G.FUNCS.can_select_card = function(e)"
position = "after"
payload = '''
if e.config.ref_table.ability.set == 'Joker' and e.config.ref_table.ability.name == 'Bound Joker' then
  e.config.colour = G.C.GREEN
  e.config.button = 'use_card'
  return
end
'''
match_indent = true

[wicked topaz]

Wonderful

Thanks!

[graceful depot]

Would it be possible to change the Sandstone-Sleeve to Stack it's Scaling ontop of the usual Scaling?
Instead of setting it to 2.0, add 1.0 to the current scaling, or multiply the base scaling by 2 - It would be really cool for the Plasma Deck (for example) x3

[edgy badger]

I feel like those decks should have an info_queue explaining what the thing is in their desc

Like this for example

[wicked topaz]

Great idea! I've just finished coding this. Shoulda been like this from the start smh my head

[wicked topaz]

Will do 🫡

I'm trying to get around the crads breaking randomly with porcleain problem and the issue with modded blinds now

Idk what changed with smods tho

About the breaking of cards

[edgy badger]

Idk how long you were away

[wicked topaz]

Like 2 months

[edgy badger]

What issue is it exactly? Basically how it works is that you have to to do

return {
  remove = true
}

to destroy scored cards

[wicked topaz]

Non-porcelain cards are being destroyed seemingly at random when scored alongside a porcelain card maked for destruction

I'll try the remove thing

[supple musk]

pinkmaggit's back!!! Hooray!!!

[wicked topaz]

🔥

[main girder]

seems like red seal retrigger on porcelain doesnt work? or at least on the royal porcelain

[wraith pasture]

I also came back after a couple of months and everything seems so different

[graceful depot]

Look, two Jebediah Kermans with different textures~ o3o

Or how about:
All four levels at once

@wicked topaz While I was working on some Texture-Changing Jokers I figured, I could update your Jokers too ^w^

[wicked topaz]

No wayy, that's so cool! Thank you so much, I love it!

I'll be sure to add this ASAP

You're a Scholar!

[edgy badger]

Ty for the tooltip additions on decks real cool 👍

[wicked topaz]

You're always welcome

[wicked topaz]

I wasn't able to reproduce this

Maybe it's because of JokerGebra / ||Integral||. They are currently bugging retriggers 😦

I'm tryna solve this rn

[supple musk]

tbh i still dont really understand how those two work. I've never been able to trigger them

[golden hemlock]

Hello, it seems that there is a bug where attempting to look at your deck while playing Porcelain Deck crashes your game. I am using the latest bugfix build that can be downloaded from the green button on github

[obsidian fern]

i just had this happen as well, but sock and buskin also didn't retrigger the royal porcelain as well

[obsidian fern]

if it is because of jokergebra, that would explain it because i had that in my run LOL ignore if that is the problem

[safe crow]

eternal patronizing joker crashes game if transformed :C

[supple musk]

oops

[supple musk]

It would be nice if russian roulette also killed itself if you lose, so you dont do the weird skipping thing

[graceful depot]

Just wanted to update ya', I implemented something similar on my End and thought it would be nice to come back at'cha with an actual working tidbit and not just the "this general area for patch" x3

# Extra logic to allow taking up more Joker-Slots
[[patches]]
[patches.pattern]
target = "functions/button_callbacks.lua"
pattern = "G.FUNCS.can_select_card = function(e)"
position = "after"
payload = '''
if e.config.ref_table.ability.set == 'Joker' and e.config.ref_table.ability.SEMBY_Slots and not (#G.jokers.cards < (G.jokers.config.card_limit - e.config.ref_table.ability.SEMBY_Slots) + ((e.config.ref_table.edition and e.config.ref_table.edition.negative) and 1 or 0)) then
  e.config.colour = G.C.UI.BACKGROUND_INACTIVE
  e.config.button = nil
  return
end
'''
match_indent = true

[junior stag]

okay so.
the boss blind pool fuckery this mod does.

could it not do that

[wicked topaz]

Okayyy so

I currently do not have a PC anymore

Nor free time to work on Buffoonery

Unfortunately

As soon as I get a break, I'll try to fix it

[heavy jacinth]

🫡

[kindred shale]

@wicked topaz Will Jebediah Kerman reset if I use a Black Hole?

[wicked topaz]

He will not

(iirc)

[supple musk]

haha, no

[graceful depot]

I could take some time and create a new stable Buffoonery release, if I'm allowed to do so? ^w^

[blissful ledge]

Omg the amount dedication to this mod is insane, and here for that

[wicked topaz]

I approve of this 👍🏻
I'm sorry I haven't worked on this mod for ages now

No PC and no time, unfortunately

[wicked topaz]

So if you did, I'd be really grateful

[wicked topaz]

Thanks!

[blissful ledge]

Man that bummer with mo computer and time but so glad at least not dead project

[graceful depot]

There's a non zero chance that JokerGebra might get cut or atleast completely reworked

[junior stag]

have you fixed the issue with modded blinds’ in_pool?

[graceful depot]

I haven't gotten to that yet

But I have it on mind

[wicked topaz]

I'm fine with that, honestly
It has was a huge pain in the ass to implement and it's still buggy af

[junior stag]

hows the progress on the rework, flow?

[blissful ledge]

I was just playing your mods, with Bunco and gemstones and nothing bad happen I just wanted to say how awesome it was

[wicked topaz]

Thanks! I'm really glad you enjoy it. Always good to know something I created brought someone joy 🙂

What's your favorite joker?

[blissful ledge]

It between Laidback Joker, Camarosa or Sayajimbo which so excellent by the way

[wicked topaz]

Thanks
I love those too

My fav is Jebediah Kerman though

[blissful ledge]

I hope we can get another small joker mod from you again

Your stuff awesome to play with

[graceful depot]

Slow!
My work is currently hogging up more of my Free time, but once that's over I'll return to Buffoonery in full force :3

[wraith pasture]

Is the secret Jeb unlock attained by finding a singularity while you have him?

I've been messing with balatro mods while figuring out what's been done and what I want to do with my mod

People have done so many different things, it's wild

[wicked topaz]

You gotta ||use a black hole while he's in the Joker area.||

That's because ||the black hole also is kind of a planet card, and I wanted to flavorfully include it somehow.||

[wraith pasture]

Yeah that makes sense

I need to do that and also all the other unlocks

[graceful depot]

What Mod breaks because of this?
I need a Mod I can test the new System with ^w^
-# Please Reply-Ping! x3

[wicked topaz]

Aikoyori's Shenanigans is an example iirc

[graceful depot]

Merry Christmas my friends!
I bring a Reworked version of Buffoonery!
I wasn't able to Test everything yet, and some Jokers are still Missing...
But this should be a playable Version:
-# I'll post a fully Updated (and Tested) Version the coming days ^w^'

-# Edit: Attachement Removed

Changelog will also come with the full version - But now I gotta attend Christma duties

[blissful ledge]

Wait is this real, new buffoonery?

[heavy jacinth]

???

[wicked topaz]

Woooah, awesome! Merry Christmas! ☃️

[junior stag]

are you able to make a pr?

[graceful depot]

This one has all the Content,
be aware that JokerGebra is a different Joker now.
-# Also PinkMaggit, check your DM-Requests!

I'm gonna have to Test Mod-Compatibility,
Write up all the Changes and clean up a little bit.

But besides that, this would* be the final Version:
-# * After I'm probably gonna fix more Compat-Bugs x3

-# Edit: Attachement Removed

[graceful depot]

I'll try to make one when I'm sure that the new Version works as expected,
since the Tests are pretty much the only thing missing, I'll do that and Push x3

[graceful depot]

A lil' bit of Testing later; A new page on Github!
https://github.com/FlowireXen/Buffoonery_FlowMod/tree/main
-# Ope found a bug oopsie

The Rare @wicked topaz Ping:
Should I change anything on the README.md file,
or can I just go ahead and open a Pull/Push Request? ^w^

[wicked topaz]

Readme file from your repo looks awesome, no changes required!

You can open a PR anytime and I'll merge it whenever I get access to a PC

And thank you so much for the rework!

🙌🏻

[supple musk]

Just noticed the "unknown" planet. very funny lmaoo

[tame shuttle]

Lost edition causes porcelain cards to crash the game! I just tested it by elimination with every mod I had installed. If you know how to fix this, it would be super nice!

[graceful depot]

I'll check it out

[graceful depot]

Do you maybe have more Info?
Were you using the Reworked Version of Buffoonery, did you use any specific Jokers and such?
I can use the porcelain cards no problem with both installed ^w^'

[tame shuttle]

Yeah I was using the reworked buffoonery with lost edition, a couple of quality of life mods and the newest smods

[graceful depot]

Can you send the Crash Report or a Screenshot of the Crash-Screen?

[graceful depot]

Yeah, Nah.. I have no Idea how that would even happen 💀
The Crash's talking about a problem in the UI-Class?
When does this appear, at Game-Start orrr..?

[tame shuttle]

Idk, the only thing that crashes is porcelain cards

This is on mobile, but I've tried it on PC and steamdeck too

[graceful depot]

I kinda need to know: When do they crash? (Scoring, getting Created, when Destroyed...?)
What other "QoL" are installed... I don't wanna sound mean but I cannot replicate this with the current Info at all ^w^'

[tame shuttle]

(when they score)

And you don't sound mean at all 🙂

[graceful depot]

I pretty much installed every Mod on that list, except for the Lua Patcher

And I gotta say...

I have no clue :D
Works fine:

[tame shuttle]

Alright, well thank you still! I'll play without lost edition until I figure out the issue

[wicked topaz]

It might have something to do with the mobile modloader

But idk either, sorry :/

[tame shuttle]

It does the same thing on PC and on steamdeck.

Also, the collage modpack which includes these two mods did the same thing when I changed its smods to the most recent one

(which I know the creator base4 said to not do, but it was just to test it out and outside of these porcelain cards, there wasn't any other bug, so I think it's related to the new steamodded)

[graceful depot]

Created the (Big) Request:
https://github.com/pinkmaggit-hub/Buffoonery/pull/27
This one also includes #23 and #26 ^w^
-# Ope, Sorry for the Ping owo'

[tame shuttle]

I updated my Smods and Lost edition to the main branches on github and suddenly porcelain cards worked fine! So I guess this bug got fixed somehow... Anyway, thanks! Buffoonery is one of my favorites!

[graceful depot]

I'm glad it somehow resolved itself - Have fun with all Mods combined!

[wicked topaz]

Merged!

This is an insane level of polish. Thank you, Flowire!

Unfortunately, I forgor to draft a v2.0.0 release, will do so shortly

[wicked topaz]

Buffoonery | Vanilla-balanced Jokers [v2.0.0 Rework!]

[blissful ledge]

Is that a steam deck?

[graceful depot]

I just noticed that the Link on the Github still leads to my Repository - I didn't expect to see that merged too... Oops!

[graceful depot]

It was lotsa fun and you're welcome!~ ^w^
-# I hope it'll all make sense once you get back into swings in the future

[tame shuttle]

yeah

[wicked topaz]

Oh, I knew I forgor something... I always do lol
I'll fix it as soo as I get a chance

[wicked topaz]

Ment to reply to this

[wicked topaz]

Everything is very organized and commented, you did a great job! I'm sure it's easier to understand than what was there before lol

[junior stag]

hows work on getting a pc?

[graceful depot]

Thanks to the recent Rule changes, I wanna inform you to also add a License (or mention of one) into the Description

-# And I also like to forget about that

[wicked topaz]

Well, it has become harder since ram prices unfortunately skyrocketed, but I'll get there in a few months, I believe

[wicked topaz]

Done! Thanks for the heads up

[wicked topaz]

Buffoonery | Vanilla-balanced Jokers [v2.0.1 Rework!]