💻・modding-dev

[keen blaze]

ive been trying to figure out how to get these to stop saying "ERROR" for a bit now and im at kind of a loss at this point, ive tried putting label stuff in my localization file based off of how i see it in the vanillaremade code but that doesnt seem to be working either, im guessing im missing something here ?

[red flower]

why not context.create_shop_card?

also there's no Card:in_pool

SMODS.add_to_pool is basically that

[rapid stag]

i see

[slim ferry]

mod prefixes arent automatically added to object or consumable types so make sure you actually have the correct full key

[red flower]

ah i should add that to the docs

[slim ferry]

and edition labels should be the full edition key with the e_ prefix

iirc

[keen blaze]

thing is though that in for example the tarot code the key does end up being a bit different with the capitalization, and fixing the capitalization on mine doesnt really change anything anyways so

yeah

and putting the 'e_' with the editions doesnt change anything

[slim ferry]

okay but what key did you put in the ConsumableType definition

[slim ferry]

i see

[slim ferry]

you are actually returning the localization, right?

[keen blaze]

wdym

localization for everything else works

[slim ferry]

oh okay

[red flower]

also make sure misc is not nested

[keen blaze]

OH

OH YOURE RIGHT

ITS NESTED

OOPS

[red flower]

also youre missing the label

[keen blaze]

i am ?

[analog slate]

so... how do i use card_eval_status_text if it exists?

[red flower]

for this, unless you make the badges manually

[red flower]

don't, use SMODS.calculate_effect({message = "message"}, card)

[analog slate]

oh, thx :)

[rapid stag]

so i guess it would be better do everything in context.create_shop_card and return a shop_create_flags table if the card that's going to be created was in the previous roll? but in that case... i'm not sure how to structure that. the docs say that the table that comes out will be passed into create_card, but i'm not sure how what a "make any other card that respects current conditions (voucher redeems, joker effects, etc.) that isn't this one" table would look like, given that create_card doesn't support any kind of blacklisting

so i think i would have to mess with the pools dynamically

maybe remove_from_pool on all created cards, keep track of removed items and readd them every reroll?

[keen blaze]

i actually do not know what a badge is in this context

😭 sorry

[red flower]

the thing below the description

that has the rarity/mod name/consumable type etc

[rapid stag]

wouldn't that still lead to the collection's consumable page still being called error

[keen blaze]

the thing that says challenge here ?

[analog slate]

so it adds the value before it adds the card and i can tell because the upgrade message

[keen blaze]

bc that works now that i un-nested the misc localization thing

(the card type is called "challenge")

[rapid stag]

does your collection page still say error

[red flower]

i think in this case just hooking add_to_pool and doing what you said would work, i just didnt finish reading the entire thing lol

[red flower]

you would hook it and check if card_was_in_the_previous_roll and args and args.source == "sho"

(obviously card_was_in_the_previous_roll is something you have to flag somewhere else)

[rapid stag]

this actually kinda makes me want to develop a more generic banning system that looks at a G.GAME.banned_cards table, which would work similarly to how debuff_card does with like sources and stuff to allow for people to more easily develop something like a challenge where every joker you encounter only appears once, and develop it into something that could eventually be PR'd as an smods feature

[red flower]

that would be cool

[rapid stag]

speaking of PRs, i need to test my unlock text one at some point

[vale zinc]

One of my Boss Blinds, on Ante 1, gave me something that shouldn't be appearing before Ante 4.

set_blind = function(self, blind, context)
    if not G.GAME.blind.disabled then
        G.GAME.blind:set_blind(G.P_BLINDS[get_new_boss()])
    end
end

Here's the in_pool() function of the offending Blind:

in_pool = function(self, args)
    --[[
    self.config.extra.suits_to_seek = {'Hearts', 'Diamonds'}
    --]]
    for _, suit_to_seek in pairs(self.config.extra.suits_to_seek) do
        for __, playing_card in pairs(G.playing_cards or {}) do
            if playing_card:is_suit(suit_to_seek) then
                return true
            end
        end
    end
    return false
end

Does this override the boss.min consideration?

[frosty dock]

yes

For implementing advanced restrictions on when a Blind may appear in a run. This puts boss.min and boss.max restrictions out of effect.

[vale zinc]

How do I keep 'em in effect?

Manually?

[frosty dock]

manually, by comparing G.GAME.round_resets.ante

[wintry solar]

why does in_pool override the min btw

[frosty dock]

I dunno, it probably doesn't need to

idr if it was a deliberate choice or just how the code ligned up

[wintry solar]

the branch I have for object weights changes that and also makes max actually work 🙃

[frosty dock]

that's good

[vale zinc]

Branch? You one of the people behind Steamodded?

[frosty dock]

both of us are >_<

[wintry solar]

I also settled on having it function as an optional feature so that I didn't need to spend any more time trying to get it to match vanilla spawnings, thoughts on that?

[red flower]

how long until i get into the top 3

[frosty dock]

the order is based on commits

[wintry solar]

only another 270 commits to go N!

[frosty dock]

tbf I've done a bunch of stuff early spread to more than one commit on main

[red flower]

oh speaking of commits i forgot to bump the version yesterday

[frosty dock]

I suppose that's acceptable. I'd be good for untouched pools to preserve vanilla spawnings but I don't view it as strictly required

[vale zinc]

Could you enable it per blind, like with no_collection?

[frosty dock]

The feature mentioned includes weighted pools, which must be active (or not) for a full pool (e.g. of blinds or jokers), so that doesn't make much sense in this case

[rapid stag]

why does context.setting_ability not have a before and after of the other card's ability table

[wild escarp]

So, I'm trying to make a blind that sets your money to $0 when the most common suit in your deck is played, but I don't know where to actually put the logic for it so that it updates the most common suit at the appropriate times.

[frosty dock]

before the effect of setting the money should do

[scenic umbra]

Uh I'm so lost looking at the vanilla remade for ref

What is this src folder for

[red flower]

that's the folder with all the code

[scenic umbra]

Wait it doesnt all sit in the main lua?

or is that a sort of alt way of doing that

[red flower]

no that would be a nightmare and very much not recommended

[scenic umbra]

well then

[red flower]

https://github.com/nh6574/VanillaRemade/wiki#how-do-i-organize-my-files

[scenic umbra]

im looking at that lol

so rather than cram everything inside the main

put them in seperate files inside another folder

[red flower]

you don't need this when you are just starting but if the mod has a couple of objects i would recommend it

[scenic umbra]

This mod will have a lot yes

[red flower]

also it doesn't need to be a src folder, thats just a naming convention i like

[scenic umbra]

what does src mean

[red flower]

source

[scenic umbra]

I prefer that over other namings then

cause ik my brain lol

but the main.lua will be for what then? setting up the mod and that's it?

like instructions for the game essentially

to tell it what to do with all the code lol

[red flower]

kinda yeah, the main.lua is treated the same as every other file so you can do stuff there too but i prefer keeping it for loading files

[scenic umbra]

yeah it's nicer

okay so i assume there is instructions for how to do all that then?

well ig i need to figure out how to make this first jokers description happen in game now lol

[red flower]

yes, what i linked

: )

[scenic umbra]

alright

i shall begin the digging

cracking open a ice cold monster while i do it lol

[red flower]

the main vanillaremade repository is also an example

[scenic umbra]

oh ya im using that to understand how everything needs to be framed

so for now if i plan to make a new rarity would it be best to make the rarity 4 for legendary as the joker is a variant of a legendary

just til i get it working

ugh i need to snag someone into a vc to help me break this down in a way i can understand it lmfao

is this a yes or no?

\localization\en-us is what it's listing

okay so the game crashes now so im obv doing something

this line is cited but i swear that's right

[red flower]

what does the crash say

[scenic umbra]

here

[red flower]

you are missing a bracket in the surrounding lines

or a comma

[scenic umbra]

whaaaat

in jokers.lua?

[red flower]

yes

[scenic umbra]

comma

my bad g

well now another crash

i have the sprite and for now just using the code from the vanilla remade just so i can at the very least get it into the game

i added the assert into the main

I feel like this is a case of me forgetting to switch sum out

WAIT

I don't have a utils.lua

will just removing that bit from the code fix this?

like i said i just want to see it in game bare minimum

oh wait

there's no mention of that in the code

[red flower]

did you make an smods.atlas

[scenic umbra]

like the sprites?

[dreamy lodge]

[red flower]

like

[scenic umbra]

fudge

so that is a seperate file from the jokers lua file

[red flower]

it can be in any file as long as it loads first

i usually put it in the same file as the jokers

[scenic umbra]

thank you for not getting annoyed btw

i ask too many damn questions but it's how i learn

so i can put it in the main and be fine?

[frosty rampart]

as long as the atlas comes first, yea

[scenic umbra]

so put it at the top

[frosty rampart]

pretty much ye

[scenic umbra]

key is the name of the file replacing spaces with _ correct?

sorry i can read everything six times but until i ask questions in my own way i don't grasp stuff lol

ADHD am I right?

[frosty rampart]

no, key is whatever you want, but you have to use that same key whenever you're defining the atlas for a joker
path is the exact name of the file, even if it has spaces

[scenic umbra]

so if for example the key i placed in the joker lua says warpedperkeo

then i have to use that

[frosty rampart]

not quite
going by the crash, your joker has atlas = "Warped_Legendary_Jokers" in it. so the key when you create the atlas should be key = "Warped_Legendary_Jokers"

[scenic umbra]

oooooo

okay so i had it backwards lol

and path is the name of the file

actually i can change the key to whatever as long as its the same right?

[frosty rampart]

yes

and yea path is the name of the file

[scenic umbra]

alright we're shortening that for sure

like dis?

I did change it on the others

hmmm i hope that's alright cause now it's something else

Oh and should i nuke that config file so it doesn't display all that garbo at the bottom

this is my entire main, jokers and en-us lua files so far

im lost

wait

the key

the key isnt warp anymore is it

[lament roost]

how would i go about debuffing a hand (akin to the psychic) as a stake

[scenic umbra]

AAAA

[tall wharf]

change the prefix?

[scenic umbra]

huh?

hang on

PrEfIx?

Which one lol

image

[tall wharf]

in the header

it still says xmpl

[scenic umbra]

main?

[tall wharf]

second image yeah

[scenic umbra]

ohhhh the one with the commented header

thats my joker lua lol

so like nuke it?

[tall wharf]

do you have any json file already

[scenic umbra]

omg im an idiot

nvm

this

[tall wharf]

yeah you should remove the header then

[scenic umbra]

i had no idea that would mess with the code

i though comments were harmless lol

I think I'm lost

I removed the commented header (The one in green)

Is that what you meant?

(Also thank you Aiko for helping a dum dum)

im kinda taking this in stages lol

tomorrow i learn how to do the effect so it's not just joker lol

but rn i just wanna see him in game 😭

[inner terrace]

Hmm
A joker with a custom calculate is causing a crash when losing a run if it's in the joker area
It's a "calculate on table extra" crash which is weird

[dreamy lodge]

How do I make custom music play during the payout screen after beating a blind? I know how to make music just don't know how to check for that

[red flower]

G.STATE == G.STATES.ROUND_EVAL

[red flower]

you should post the crash

[inner terrace]

Zokers is there to be able to grab jokers to test, but I can confirm it's not causing the issue - it occurs regardless

[inner terrace]

The code itself for the joker is this - it's effectively just VanillaRemade's implementation of Popcorn, with some extra to change the sprite on activation

[frosty rampart]

it won't help the crash but you can use debugplus to spawn jokers at will instead, zokers is pretty outdated afaik

[inner terrace]

Oh! I wasn't aware that was part of its utilities, I'll check it out, thanks! might save me some other issues down the line

[red flower]

it's trying to run the original code as well, which doesn't use extra as a table

the easiest want to fix it is to give it another name like name = "modprefix_popcorn"

[inner terrace]

This is taking ownership of the original, I thought that was supposed to overwrite it

[red flower]

it overwrites its SMODS.Joker.calculate function but vanilla jokers don't have those and are hardcoded

[inner terrace]

Oh, I see. I had a similar issue with a different joker, where I had to have extra as a value, and use a different variable to store mine - I tried to do that here by renaming it to extran for the table, but yeah that hasn't worked either

[red flower]

because there you are overwriting its config table lol

[inner terrace]

for reference, I did a similar thing with credit_card, and that one works without a crash - If I do the same here, with extra = 0 in front, and renaming extran.extra to something else, it seems to still face the same issue
(I think there's a high chance I'm just not understanding something yet)

[red flower]

like i said, the easiest way is to give them another name

[frosty rampart]

there's vanilla code that runs the vanilla behavior of jokers regardless of what the joker's calculate function is, but it checks for the joker's name (different from key). if you change the name of the joker when you take ownership, it will stop running the vanilla behavior

[inner terrace]

OH

[rapid stag]

i had a similar issue with my 8ball take ownership. at the very end of your calculate function, outside of any condition, do return nil, true. this ensures your calculate function always runs and prevents original code from running

[red flower]

yeah

[inner terrace]

Ohhh, I get it now, I hadn't realized that was one of the uses for the name field, thank you!

[red flower]

well, it's not an intended use

more like a hack

[rapid stag]

@frosty rampart?

[daring fern]

That would trigger post trigger effects on every context.

[frosty rampart]

as N said, it's a bit of a hack, and i prefer changing the name field because making your joker always count as triggering means it can mess with some other mods (e.g. Ready To Fly in Paperback)
so yea what Somethingcom said

[rapid stag]

oh

[red flower]

the proper way is to return nil, true but just in the vanilla context

but the name is better honestly

[rapid stag]

...i should probably change that

so name field is...

[red flower]

i will port vanillaremade to smods

[rapid stag]

what even is the name field

[red flower]

name = "something"

[rapid stag]

it's not loc_txt.name, surely

[red flower]

no

[rapid stag]

oh literally a name property

i was gonna ask if that changes the discovered state if you'd already discovered it beforehand, but it has that same key, so it should be fine

[frosty rampart]

yea literally a name in the table, same as atlas or whatever

[scenic umbra]

I did it

[round lion]

this jonkler goes nuts in endless

[rapid stag]

...hm.

when hooking this, how do i get to the object's key from prototype_obj? i'm aware that this is typically self, but i'm like... is it self.key?

wait, yes it is, i'm stupid. i literally just did this with my weird create_mod_badges madness which also receives self as obj

...oh. that's actually much simpler than i thought.

i think i'll write the PR now, actually. as i flesh this idea out, it actually sounds kinda stupid. i'll hold onto it for now, but

[scenic umbra]

If you make it to endless

[rapid stag]

remind me how i do queue.stack() and queue.pop() in lua again

[scenic umbra]

so uh

Whoops

[hoary spear]

Is there a way to hide all vanilla content without taking ownership or something like that?

Like, jokers, consumables, boss blinds, skip tags, everything

[sturdy compass]

You can hook SMODS.add_to_pool and remove anything that isn't from a mod

[hoary spear]

Would that hide from collection?

[sturdy compass]

no

[hoary spear]

Is there a way to do that?

[sturdy compass]

not an easy way off the top of my head

[hoary spear]

Basically; im just making a vanilla rebalance mid, but take_ownership is causing bugs for stuff

So i was thinking i could just, remake it all, but hude the base game stuff

[daring fern]

for k, v in pairs({G.P_CENTERS, G.P_BLINDS, G.P_TAGS, G.P_SEALS}) do
    for kk, vv in pairs(v) do
        if not vv.original_mod then
            SMODS[vv.consumeable and 'Consumable' or vv.set]:take_ownership(vv.key, {
                in_pool = function() return false end,
                no_collection = true
            }, true)
        end
    end
end

[hoary spear]

Sorry, where exactly would i put this?

Would this be in my main .lua i assume?

And if so, where in that?

[frosty rampart]

anywhere you want, as long as the code runs
(i.e. not inside a joker definition or anything)

[hoary spear]

So inside my main .lua file works then?

Just at the top should be fine right?

[frosty rampart]

yea

[hoary spear]

Okay cool

Then i should be able to just use something like vanilla remade as a base for ut then right?

Oh and apologies if these sound like dumb questions

[frosty rampart]

no worries lol, we all start somewhere
yea you should be able to use vanillaremade from there

[daring fern]

You mean that it was still running the old code?

[hoary spear]

Its so funny to me that i can be making some weird stuff like draft deck in my mod, but cant just figure out something basic

[hoary spear]

Correct

In some cases (mostly boss blinds and a few others)

It ran both

[daring fern]

Add name = 'Name (Mod Name)'

[rapid stag]

bump

[hoary spear]

To the code you gave you mean?

Cause that i havent tested yet

[daring fern]

No, to your take_ownership calls.

[hoary spear]

Ahhh

Noted

Okay, i will try that as well

Which should i try first.

?

Probably just the adding mod name right

[daring fern]

Yes.

[hoary spear]

Cool

Then ill try what you gave

And if neither works well or i need help ill be back

Sometime tomorrow though, i am done for today, it's almost 11:30

It becomes quite annoying being able to figure out the complicated stuff easily but not the easy stuff period lol

Again, thank y'all for the help :)

[vocal helm]

Real quick, how would I localize a consumable type? I.e. localize("spectral") -> "Spectral"

I guess this would count as a center

[daring fern]

localize('k_lowercaseconsumabletypekey')

[vocal helm]

thanks!

[vital wren]

is there a way for a joker calculation to return a chips or mult value without it generating the ui notification?

[daring fern]

chip_mod and mult_mod

[vital wren]

cool, will that still update the hand score ui and just not give the lil popup?

[daring fern]

Yes.

[vital wren]

perfection. thanks <3

[vital wren]

im having an issue when setting a playing card's enhancement from m_stone to other enhancements where the card's front (rank and suit) doesn't appear. is there some kind of update front function i should run?

[bold sleet]

Hey chat, is there a simple way to just turn a card into another, rank, suit, enhancement, etc included?

[vital wren]

i have code for that. are you copying it from another card?

[bold sleet]

Yes.

[vital wren]

one moment

[bold sleet]

Just make a playing card become another playing card.

[vital wren]

fully copying all aspects or just select aspects?

[bold sleet]

Probably everything.

Though if you have code for either of the situations, that might come in handy later on.

[vital wren]

the full card is just what the death tarot does. but i also have the others. ill drop you a code snippet

[bold sleet]

k

[bold sleet]

I might have totally forgotten death is a card that exists.

[bold sleet]

k ty

[vital wren]

oh, im using get_rank_suffix there which looks like this:

function get_rank_suffix(_id)
    local _rank = 'A'
    if _id < 10 then _rank = tostring(_id)
    elseif _id == 10 then _rank = 'T'
    elseif _id == 11 then _rank = 'J'
    elseif _id == 12 then _rank = 'Q'
    elseif _id == 13 then _rank = 'K'
    elseif _id == 14 then _rank = 'A'
    end
    return _rank
end```

[daring fern]

No, you should be doing:

for k, v in pairs(SMODS.Ranks) do
    if v.id == _id then return v.card_key end
end

[vital wren]

okay

thanks

[vital wren]

i'm using this string.sub(_source.base.suit, 1, 1) to get the suit. is there an SMODS method i should be using instead?

[daring fern]

for k, v in pairs(SMODS.Suits) do
    if v.key == _source.base.suit then return v.card_key end
end

[vital wren]

understood

[feral storm]

attempt to index field 'T' (a nil value) ante

[vital wren]

where is the code that generates this entire text block? i need to make it not still show the base card's chip value

[wild patrol]

is there away to debug a custom boss blind?

instead of just hoping it randomly shows up

[daring fern]

Yes, with DebugPlus, if you hover over a boss blind in the collection, and press 3, it will be set as the boss blind for the current ante.

[wild patrol]

👍

[wanton jolt]

stone card shouldn't have a base card chip value, is this a custom enhancement?

[vital wren]

im changing stone with take ownership

[wanton jolt]

yeah normally it shouldn't have base chip

[vital wren]

ive managed to get it to not display the nominal. im currently trying to get it to correctly reset its front when converted from stone to another enhancement

for some reason, using set_ability to apply a new enhancement after my custom m_stone leaves the card without a visible front (though it functions normally). so i'm hooking set_ability to reset the front if the card goes from m_stone to anything else

[wanton jolt]

i think its due to a smods bug i've heard

[vital wren]

would seem so

it's also not corrently resetting card.ability.bonus so im doing that in the same hook

[vital wren]

okay, i believe i have it fixed now. seems to function as intended

[wanton jolt]

okay

[vital wren]

in that video being referenced, it looks like delay_sprite is set to true so the card fronts are being removed before the center is updated visually. but yeah, the stone cards have some stuff going on that i cant find the code for in the vanilla code. like i'm not sure where it's setting the card's nominal to 0 or back to normal when the vanilla The Tower is used

[flint spindle]

What is the easiest way to destroy a random card in the deck that I can put in a joker calculate function

[vital wren]

something like SMODS.destroy(pseudorandom_element(G.playing_cards)). will look for that in the wiki quick

[daring fern]

local other_card = pseudorandom_element(G.playing_cards, 'seed')
SMODS.destroy_cards(other_card)

[vital wren]

yeah that

[wanton jolt]

How do i make a consumable open a set booster on use? even if already inside a booster

[flint spindle]

you are a beautiful person

[vital wren]

carefully. it breaks. once you finish the second booster the original one gets soft locked on screen so you'll have to dig deep to fix that

[daring fern]

If a booster is open do you want to delay the booster to open when the current one is closed or do you want to open the booster and return to the other one after it's closed?

[wanton jolt]

i would open the booster and return to the other one (unless it is too fucky)

[frosty dock]

this is a smods bug, though it's already fixed in dev

[wild patrol]

I have unlock set to true

but the custom boss blind is still locked

[vital wren]

hover and press 2

[wild patrol]

it worked but is there anyway to have it unlocked by default

like jokers

[vital wren]

unsure, sorry

[wanton jolt]

have you tried discovered = true,

[wild patrol]

how to u lock the boss blind lol

so I can see if that works

[wanton jolt]

unlocked = true,
discovered = true,

[daring fern]

eval G.P_BLINDS['bl_modprefix_key'].unlocked = false

[wanton jolt]

bump

[daring fern]

Yes, you would have to do a lot of work to save the other booster pack's state to return to it after closing the booster pack.

[wanton jolt]

and for the other way?

[vital wren]

it's a bit odd, but i do it by just making a tag that triggers after the first booster closes

[wanton jolt]

oh true i could make a tag

[daring fern]

You could do that, or you could set a global variable and hook G.FUNCS.end_consumeable and open it there.

[vital wren]

that's smart

[wanton jolt]

the tag would be more versatile, as i could just use it too

[timid zinc]

is there a way to have a function run near boot but not TOO early (as in, all mod objects have loaded and G exists)

[wanton jolt]

thank you all

[daring fern]

Hook Game:main_menu

[timid zinc]

thank you

[wild patrol]

well it's a start

grammar bad just to rush it

[wanton jolt]

logo is sweet

[wild patrol]

wasn't done by me was done by a friend

They are pretty good at pixel art

[vital wren]

the twitch purple background is a nice touch

[wild patrol]

now that I did

took me forever to figure it out

looked at how the cardsauce mod did it

still don't know how exactly cardsauce did it but I got the general idea

[analog geode]

hey all, looking for a bit of help getting this joker ready. The effect of the joker is that it duplicates any tags earnt through skipping a blind. Ive tried a couple implementations and none of them have worked. My current one which has gotten me furthest is this:

        if context.skip_blind then
            G.E_MANAGER:add_event(Event({
                func = (function()
                    add_tag(Tag(G.GAME.round_resets.blind_tags["Small"]))
                    play_sound('generic1', 0.9 + math.random() * 0.1, 0.8)
                    play_sound('holo1', 1.2 + math.random() * 0.1, 0.4)
                    return true
                end)
            }))
            return nil, true -- This is for Joker retrigger purposes
        end
    end```
which works as you'd expect. when a tag is earnt from skipping, whatever the tag on the Small blind is duplicated. but when i try and replace "Small" with G.GAME.blind to make it sense what blind you're currently on, it doesnt work (i imagine G.GAME.blind is a numeral value or something other than the "Small/Big" that G.GAME.round_resets.blind.tags wants). Any ideas on a fix or an alternate method to get the same effect?

[daring fern]

G.GAME.blind_on_deck

[analog geode]

just tested, blind_on_deck is already the one you're hovering over, so when you skip a small blind you get the big blind tag, and when you skip big blind the game crashes

[daring fern]

Do local blind_on_deck = G.GAME.blind_on_deck outside of the event and use that.

[analog geode]

        if context.skip_blind then
            local blind_on_deck = G.GAME.blind_on_deck
            G.E_MANAGER:add_event(Event({
                func = (function()
                    add_tag(Tag(G.GAME.round_resets.blind_tags[blind_on_deck]))
                    play_sound('generic1', 0.9 + math.random() * 0.1, 0.8)
                    play_sound('holo1', 1.2 + math.random() * 0.1, 0.4)
                    return true
                end)
            }))
            return nil, true -- This is for Joker retrigger purposes
        end
    end```
this? its having the same issue

[daring fern]

Try instead doing add_tag({key = G.GAME.tags[#G.GAME.tags].key})

[analog geode]

ohhh its working perfectly 🙏 tysm

[rigid solar]

I have 2 different music tracks that are supposed to be sync'd, but when I go from one to the other it starts from... well the start
anyone knows what could the issue be? 🤔

oh i needed to put my mod's key before the name in sync, duuh

[daring fern]

You need your mod prefix on the sound keys.

[fading rivet]

How can I change the text of a UI element?

im trying to change the .config.text of the element when its grabbed from get_UIE_by_ID but its not working

[red flower]

yeah that doesn't work, there's probably a way but i had a hard time doing this when i made jokerdisplay

the easiest is just to patch the element to use ref_table

[fading rivet]

thx

[fading rivet]

is there a way I can change the color or no?

cuase I need some way I can differentiate between safe and unchecked cells

[red flower]

changing config.colour should work for it

[twilit hearth]

critique my new legendary

[wanton jolt]

a new ouro to the pile

[twilit hearth]

new and unique concept ofc

[fading rivet]

Is there a way I could disable the movement on a button?

[vale zinc]

What's it do?

[next timber]

im going insane

[wanton jolt]

lmaooo

[next timber]

ok i stole some code from sealsoneverything to make a joker that makes all editioned cards count as negative.. i can tell it is registering the cards as being quantum negative. but its not actually doing anything with them. the eval is spitting out an empty table

and i dont know why

[wanton jolt]

they just count as negative in terms of scoring

[next timber]

ugh

[wanton jolt]

thats what quantum does

as far as i'm aware

if you want to give cards the negative perk in extra you could probably just increase the joker slot by 1 or reduce its size to 0

[next timber]

what

[wanton jolt]

or something

idk

[next timber]

this is meant to be working on playing cards i should mention

[wanton jolt]

oh lol

[next timber]

ok im certain theres at least 1 or 2 mods with jokers that make certain playing cards act as negatives. does anyone know of any so i can go and raid their code

[pastel kernel]

it's this```lua
local function count_mod()
seen = {}
for _, c in ipairs(G.playing_cards) do
local ed = c.edition and c.edition.key
local seal = c:get_seal()
local enh = (SMODS.get_enhancements(c))
if ed then seen[ed] = true end
if seal then seen[seal] = true end
for key in pairs(enh) do seen[key] = true end
end
local mods = 0
for _, mod in pairs(seen) do
if mod then mods = mods + 1 end
end
return mods
end

Idk how to fix this

[frosty rampart]

ipairs(G.playing_cards or {})

G.playing_cards doesn't exist if you're not in a run

with my fix, if G.playing_cards is nil, it'll pick the empty table instead and just skip over the for loop

[pastel kernel]

Thank you

[fading rivet]

bump

[pastel kernel]

does emult follow the convention of "just keep it there and let SMODS do the rest" or do i have to manually make it calculate

[frosty rampart]

if your mod depends on amulet or spectrallib, you can treat it just like xmult. if it's standalone, you'll have to implement it yourself

[pastel kernel]

i'm using both

[frosty rampart]

then yes, emult should work fine without any extra work on your end

[pastel kernel]

i'm trying to make an enhancement that, when played 3 times in the same ante, it self destructs.

actually i think i'll change that to "destroyed when discarded"

[wanton jolt]

can i set multiple different enhancements as an enhancement_gate?

OR logic operator preferably

nvm

[small walrus]

is there a tutorial for making face card mods?

[twilit hearth]

Let me show you

1s

[rapid stag]

bump

[rapid stag]

could you elaborate?

[frosty rampart]

there's some documentation on how to do it, but it's not exactly a tutorial that'll hold your hand through the whole process https://github.com/Steamodded/smods/wiki/SMODS.DeckSkin

[rapid stag]

oh, i figured they might be referring to things that do stuff with Card:is_face()

[small walrus]

i'm trying to modify the royal face cards with my own artwork for a project, but i'm not experienced with coding

[rapid stag]

that link on deckskins is what you're looking for, then

[wanton jolt]

ooo

[calm marten]

i always thought attaching conditions is gonna be way too difficult but as long as it isnt something very complex,
appearently its not that hard.

[fading rivet]

why is it a rare?

[royal comet]

Made the immortal joker baby trapped in concrete

[calm marten]

no reason
its supposed to imitiate older version of bloodstone

[rapid stag]

bump

[noble ore]

I AM SO SO SORRY 😭

i didn't know i got hacked

[tranquil echo]

LOLL WHAT HAPPENED

[tranquil echo]

OHHH

[noble ore]

actually it was two thing

i was making a bot and then i got hacked

-_-

[tranquil echo]

oopsies

[noble ore]

thank you mods for not banning me 🥺

[jade snow]

do any of you guys use BMM (mod manager)? doesnt seem to work so im assuming i just need to go back to the regular mod strat (when my account is unhacked)

[red flower]

just use imm

https://discord.com/channels/1116389027176787968/1413687995378176021

[fading rivet]

bump

[pastel kernel]

how do i make it so that after it stole enhancements, it removes them during scoring and replaces them with bloodmarked after scoring```lua
--stole some stuff from ascensio
calculate = function(self, card, context)
if (context.before and not context.blueprint) or context.forcetrigger then
local scalar = 0

        for _, card in ipairs(context.scoring_hand) do
            if next(SMODS.get_enhancements(card)) and not card.debuff and not card.vampired then
                scalar = scalar + 1
                card.vampired = true
                card:set_ability("c_base", nil, true)
                G.E_MANAGER:add_event(Event({
                    func = function()
                        card:juice_up()
                        card.vampired = nil
                        return true
                    end,
                }))
            end
        end
        SMODS.scale_card(card, {
                ref_table = card.ability.extra,
                ref_value = "eemult",
                scalar_value = "gain",
                scalar_table = { gain = scalar * card.ability.extra.eemult_gain },
            })
    end
    if context.joker_main or context.forcetrigger then
        return { eemult = card.ability.extra.eemult }
    end
end,```

[rapid stag]

what is bloodmarked is it an enhancement, an edition, a seal, a sticker, what

[lyric wadi]

where should i hook if i wanna mess with rarity badge

is there a smods function i can use or do i just have to dive into source code

[red flower]

for every card or for a specific one?

[lyric wadi]

just specific one

[red flower]

set_card_type_badge https://github.com/Steamodded/smods/wiki/SMODS.Joker

there's also badge_colour, badge_text_colour if you just want to change the colors

[rapid stag]

bump

[lyric wadi]

oh cool, is there a reference or key for the vanilla badges i can pass into it or do i just have to redefine them

[red flower]

check G.UIDEF.card_h_popup

[red flower]

table.insert and table.remove?

idk if theres anything closer

[rapid stag]

oh, table.remove returns the value removed?

[red flower]

yes iirc

[lyric wadi]

set_card_type_badge = function(self, card, badges)
        G.E_MANAGER:add_event(Event({
            blockable = false,
            func = function()
                if not card.ability then       
                elseif card.ability and card.ability.extra.disguisingAs then 
                    badges[#badges+1] = create_badge(({localize('k_common'), localize('k_uncommon'), localize('k_rare'), localize('k_legendary')})[G.P_CENTERS[card.ability.extra.disguisingAs].rarity], G.C.RARITY[card.ability.extra.disguisingAs].rarity)
                elseif card.ability and card.ability.extra.failure then
                    badges[#badges+1] = create_badge('IMPOSTEROUS', HEX('FF00FF'))
                end 
                return true
            end
        }))
    end
``` does this look somewhat correct

[red flower]

you shouldnt use an event, the card will have an ability table when this function runs

[lyric wadi]

ok sorgy

i've been burth too many times by this

wait so does this not run in collection

[red flower]

they have an ability table in the collection

[lyric wadi]

:0

[red flower]

an event will just make it not show up

[analog slate]

how do i make code that adds a RANDOM joker to your deck>

[sturdy compass]

SMODS.add_card({set = 'Joker'})

Easy as that

[analog slate]

ohh ok

does it make a random one?

[red flower]

:3 https://github.com/nh6574/VanillaRemade/wiki#jokersconsumablescustom-pool

[sturdy compass]

yes it is random

[analog slate]

alr thx

one question

HOW THE HELL DOES ANY ONE OF YOU UNDERSTAND THIS WITHOUT GOOGLE
I CANT FIND ANYTHING THAT FALLS UNDER THIS AND RELY ON SMARTER PEOPLE THAN ME ON A DISCORD SERVER

[sturdy compass]

That's exactly why I'm making a video guide right now lmao

[red flower]

have you checked the link i sent

[analog slate]

thank you

[sturdy compass]

Also VanillaRemade is a fantastic resource

So is #1349064230825103441

[lyric wadi]

heck

set_card_type_badge = function(self, card, badges)
        G.E_MANAGER:add_event(Event({
            blockable = false,
            func = function()
                if not card.ability then
                elseif card.ability and card.ability.extra.failure then
                    badges[#badges+1] = create_badge('IMPOSTEROUS', HEX('FF00FF'))       
                elseif card.ability and card.ability.extra.disguisingAs then 
                    badges[#badges+1] = create_badge(({localize('k_common'), localize('k_uncommon'), localize('k_rare'), localize('k_legendary')})[G.P_CENTERS[card.ability.extra.disguisingAs].rarity], G.C.RARITY[card.ability.extra.disguisingAs].rarity)
                end 
                return true
            end
        }))
    end

677 is the one that does the rarity badge, i cant tell which one is returning nil

[frosty dock]

you shouldn't use an event

[lyric wadi]

nvm i think i see it now

there's a lot of indexing going on it's tripping me up

[frosty dock]

as for the actual crash, the line where the rarity badges are created is messed up in terms of brackets

[red flower]

you are missing a comma after they key

[analog slate]

oh damn

wow im so fucking stupid lols

[red flower]

also you should have a context check in that calculate function

or it will add a million jokers

[sturdy compass]

smods 1502e is crazy work lol

[analog slate]

ohhh like how

[red flower]

https://github.com/nh6574/VanillaRemade/wiki#whats-a-context

in this case if context.ante_change and context.ante_end then should work i think

[analog slate]

OH

[frosty dock]

ikr..

[analog slate]

also whats the thing so that only one of said card can be in your deck

[red flower]

SMODS.add_card does that by default, it only spawns multiple if showman is present

[analog slate]

no its more like uhhh lemme give you an example
if i have one "Kindness luigi" card, the shop shouldnt be able to sell me another

[red flower]

yes, the game does that by default too

unless you have showman

[analog slate]

whats that

[sturdy compass]

[analog slate]

cuz like i saw a copy of my card show up in shop even after i bought it

[tidal hemlock]

have you not played basegame

[red flower]

https://balatrowiki.org/w/Showman

[red flower]

ah thats a debugplus bug most likely

[analog slate]

granted i did hack it in but still

[analog slate]

i have i just use certain jokers

[tidal hemlock]

oh yeah if you hack in it, the clone clause breaks

[analog slate]

OH

mb

[sturdy compass]

Nah that's a fair worry lol

[tidal hemlock]

i've seen this convo so many times, there should just be a billboard of faqs with this being one of them

[sturdy compass]

fr

[frosty rampart]

really what should happen is debugplus should fix it

[sturdy compass]

that or wilson should fix it

brainwave

[analog slate]

does this theoretically work?

[red flower]

i think it might be a base debig bug that debugplus didn't touch

[red flower]

yes
you can return { message = "STOLEN!" } instead of using calculate_effect

[frosty rampart]

^

[sturdy compass]

Was just about to say that

[red flower]

ah wait

[analog slate]

oh yea but does it like change anything? just wanting to know

just makes it easier

[sturdy compass]

nope

[red flower]

rarity = 3 will work but it's not the way to use rarities there because it doesn't follow the standard 1,2,3,4

use rarity = "Rare"

[analog slate]

alright

[sturdy compass]

using returns is a lot more preferrable tbh

[red flower]

also returns makes it so other cards can detect if it triggers

[sturdy compass]

I had a feeling that was the case I just wasn't 100% sure on it

[analog slate]

random question: whats the code for the credit card

[sturdy compass]

https://github.com/nh6574/VanillaRemade/blob/1abd606dc26c46f0c7b281995f40fb25b1d54b4f/src/jokers.lua#L394

[analog slate]

w8 thats really useful

[sturdy compass]

please use VanillaRemade as a reference it is fantastic

as if the three links we've posted to it already weren't enough of an indicator

[red flower]

i am only posting links to it because it fills my ego

[analog slate]

well i mean atleast youre helping

but like what if i want my card to have a 40 percent chance of giving a common joker (cuz some common jokers like raised fist are really good) and a 60 percent chance of gettin a rare

[sturdy compass]

I believe rarity is observed when making a random joker

[analog slate]

i know how math.random works i played roblox

[analog slate]

its forced to be rare rn

[sturdy compass]

I mean if you remove the rarity flag

[analog slate]

true..

[red flower]

rarity = pseudorandom("unique seed") > 0.4 and "Rare" or "Common"

don't use math.random for gameplay because it doesn't take the seed into account, but pseudorandom works similarly

[wanton jolt]

i have a weighted pool function i love weighted pools

i love weighted pools

[sturdy compass]

weighted pools are about to be a smods thing sooo

[red flower]

get excited for an smods update soon

[analog slate]

thats a boolean tho i dont think thats working

[wanton jolt]

its fine i already have my function

[red flower]

what's a boolean

[analog slate]

TRUE

FALSE

[wanton jolt]

if your roll is over 0.4 fill true condition and get rare, otherwise get common

[analog slate]

ohhhhhh

[red flower]

no I didnt mean what boolean means lmao

i meant to ask what you thought was a boolean there

[analog slate]

ohhhh

[wanton jolt]

akso yeah it outputs a number not a bool

[analog slate]

like adding 3 = 3 is a boolean so adding extra things like > 0.4 and rare or common fits the boolean

[wanton jolt]

no

[analog slate]

looks so goofy in the code i love it

[wanton jolt]

3 = 3 is a condition

[red flower]

number > number is a boolean but then that expression it gets evaluated into a string

[wanton jolt]

not a variable

[red flower]

a and b or c gives b when a is true or c if it's false

[idle plaza]

Technically it's just a syntax error since you'd be trying to assign '3' as if it were a varaible.

[analog slate]

oh

[wanton jolt]

yes

i put my weights in the same pools i use to build my cards

and then i call the pool to do weighted pick

soemwhere else

yay

[rough furnace]

yeah the spawn card hits a vanilla code pass that calls add_joker. I could probably change it but I can't be bothered

I actually don't know why it even happens (I never looked into it)

[analog slate]

CAN THIS WORK or do i need to write tarot a different way

[rough furnace]

try it and see

[analog slate]

oh ok :D

does vanillaremade have a thing on colored text

[rough furnace]

Is this still happening for you? If so, dos it happen if DebugPlus is the only mod (it doesn't need steamodded)? What is your lovely and DebugPlus version?

[sturdy compass]

No but smods does https://github.com/Steamodded/smods/wiki/Text-Styling

[analog slate]

ohhh thx

[sturdy compass]

👌

[flint spindle]

I'm modifying superposition to give a planet card as well, but creating the different messages in sync with the consumeables being made is annoying. Putting them in the return of the calculate function makes the messages appear at the same time, and when I try to do them separately like this, they don't even play. what do I do

[wanton jolt]

gaze and enjoy the section on fonts

it has my blood in there

[analog slate]

ok, can i use {C:purple}? like whats the color option

[wanton jolt]

c:purple works

c:tarot too

you can make ur own color too

[analog slate]

ohhh like color codes like c:#00ff00

[wanton jolt]

u have to define it solewhere

[wanton jolt]

no

it has to be either passed as a loc variable or defined globally

[analog slate]

ohhhh

[idle plaza]

Use SMODS.calculate_effect({message = whatever, colour = whatever}, card) since returning a table in an event's function won't do anything

The only relavent return in an event's func is return true to prevent it from looping infinitely

[wanton jolt]

for example you could in your joker loc vars

return
 {
 vars= { colours = {HEX('222222')}}
}

*code might not ne exact im on phone

and in your loc description you would use B or V for background or text color respect.
like {B:1,C:white}Hello{}

[frosty dock]

two options here. you can return multiple consecutive effects by putting one table inside the other as an extra key. Or if you care about this specific delay you can use a func return

return { func = function()
  SMODS.calculate_effect({ ... }, card)
  delay(0.5)
  SMODS.calculate_effect({ ... }, card)
end }

[wanton jolt]

or define it globally as told in the vanillaremade wiki

[flint spindle]

I see

tytyty

[wanton jolt]

aure cat smod cat

[median veldt]

no i fixed it by unchecking only show commands

[rough furnace]

oh

that makes sense

[frosty dock]

yes

[wanton jolt]

cool

[frosty dock]

very yes. much cool

[wanton jolt]

yes

[flint spindle]

ok I did this and it didn't work so I'm assuming I did something wrong

[frosty rampart]

it should be SMODS.calculate_effect, not SMODS.calculate_context

[flint spindle]

whoopsie

[hoary spear]

okay, to clarify, you mean add it like this correct?

[daring fern]

No, you need a ,

[hoary spear]

well

okay yea

[hoary spear]

but in the right spot?

[daring fern]

Yes.

[hoary spear]

oki, i shall uh

go add that to everything

then test

[hoary spear]

but thank you!

[long sun]

how do i add an edition to the playing card pool? is it "Default", "Enhanced" or "Playing Card"?

[red flower]

what do you mean

like a random edition when you create the card?

[long sun]

i'm editing Waxed, and i'd like it to only appear on playing cards

[red flower]

ah, i dont even know if editions have an option for that

[frosty rampart]

paperback does some kinda weird stuff to lock dichrome to jokers only, it piggybacks off the argument in poll_edition that removes negative from the pool and assumes that only jokers would ever want natural negatives

to make it playing cards only you can probably do the inverse of that, hook poll_edition and just remove waxed from the pool for the duration of the function call if the edition pool allows for negatives (since only jokers want that, and consumables don't poll for edition at all)
but that might have some weird edge cases with crossmod of course

[long sun]

hmm i see

i'll give that a go, thanks!

[frosty rampart]

here's how dichrome does it, you'd just check if not _no_neg instead

[ripe charm]

How good is Joker Forge? I'm building a mod, and although I do know a good amount of Lua code I am trying to do the bulk of the mode in Joker Forge then edit or add stuff afterwards that I can't do there.

[frosty rampart]

jokerforge is fine for simpler projects, but you are going to be much better off coding from scratch than editing jokerforge output

[analog slate]

i know im missing a comma but i dont know where

[ripe charm]

I have always (strangely) felt like a better coder when editing preexisting files or projects, sometimes that empty code area makes me not know where to start

[frosty rampart]

not a comma this time, you're missing an end for the if statement in your calculate function

[ripe charm]

after 'sound everytime a card is played'?

[ripe charm]

yep see that

[analog slate]

OH MY GOD HOW CAN I NOT NOTICE THIS

[frosty rampart]

no that line doesn't need a comma, but it can have one without any issues and jokerforge probably adds it there because it's easier not to have to account for a final line when generating the localization

[analog slate]

how do i set up the sound tho im trying to set up glenn quagmire sound but it doesnt exist or i dont know how to make it exist

[ripe charm]

I don't know if it is added by Joker Forge but it's something I normally do writing Lua anyway

[frosty rampart]

do you have a SMODS.Sound object yet?
https://github.com/Steamodded/smods/wiki/SMODS.Sound

[ripe charm]

I didn't know code worked without it, and I have known the language for half a decade ;-;

[analog slate]

yes i do

[frosty rampart]

ok well the key is glennn with 3 Ns, so that's part of the issue, but also what's your mod's prefix? it needs to be play_sound("modprefix_soundkey") because it's just a function call, so it doesn't know what mod the sound is from automatically

[analog slate]

oh like EpicerMod_glennn

[ripe charm]

wait so if Cryptid is installed I could call cry_music_jimball.ogg to get Funkytown to play

[frosty rampart]

ye

[frosty rampart]

post your mod's json file, it needs to specifically be the mod's prefix and not the key

[ripe charm]

advanced tech, that's insane

I may have to do that

[analog slate]

but how do i install cryptid

[ripe charm]

Don't worry about it, I was wondering if I could call assets from other mods in my mod.

[frosty rampart]

ok so it would be play_sound("epicerMod_glennn") then
(capitalization matters, and your prefix has a lowercase e at the start)

[analog slate]

ohhhh ok

it still doesnt work as i think it needs an atlas

[frosty rampart]

ok that one's strange, because from the screenshot you should have the atlas already

[analog slate]

definitely

[frosty rampart]

oh do you actually have glenquagmire.png in both the 1x and 2x folders in your assets folder?

with specifically that filename

[analog slate]

no its in a seperate folder titled sounds i think that could be a problem but yahimod does the same thing and doesnt specify where the file is and it works

[analog slate]

yea thats a cardname

[ripe charm]

is there a recommended development studio for this? I could get away with Notepad++ but if there's something better I'd like to hear it, all of my Lua experience is in Roblox from when I used to mass produce low quality slop games with my friends a few years back during covid (literally had nothing else to do) so if I seem like a noob I kinda am to this side of Lua

[frosty rampart]

no the sound is fine, we're talking about the sprite now

[analog slate]

visual studio code

[frosty rampart]

a lot of people like vscode, notepad++ is perfectly fine, just use whatever's comfortable

[analog slate]

oh fuck i gave it two ns cuz thats how its spelt,

[frosty rampart]

ok yea make it match in the atlas

[analog slate]

mb

i thought i wrote it as glenquagmire and not glennquagmire

cant use ogg lols

do i have to use wavs?

[frosty rampart]

ogg should be fine

[analog slate]

it crashed

[frosty rampart]

post the crash then

[frosty rampart]

ok this is just an issue with the audio file, not with it being an ogg in general
run it through some converter to convert it to wav and then back to ogg and it should be fine lol

(or you can just leave it as .wav, that should be supported too)

[ripe charm]

So I think I might code from scratch, I want my mod to be massive and unbalanced which I can't really do with Joker Forge easily, I made a tetration joker with it which just did XMult equal to current mult twice successively but I think it could be easier coding from scratch

[ripe charm]

to add, fre:ac is a good conversion tool

[analog slate]

i transitioned it to wav

[ripe charm]

and convert.to.it

(website)

[frosty rampart]

true
if you know your way around the command line and have ffmpeg, you can even convert it from ogg directly back to ogg

[hoary spear]

some things still double trigger twt

[primal robin]

I added fucking CSS to Balatro

[analog slate]

ok so just grab it, convert it to wav and then ogg

[frosty rampart]

ye

[hoary spear]

i dislike this and dont know why

[hoary spear]

im going to try that other method you had now

[analog slate]

it plays once but i want it everytime a card is played

and it lagged the game

[daring fern]

Put sound = 'modprefix_soundkey' in the return instead of using play_sound

[analog slate]

ohhh ok

thx

[ripe charm]

Where is the best place to figure out where to start my mod? I don't need Lua tutorials (good amount of experience) but I have so far only edited Joker Forge projects

[sturdy compass]

#1349064230825103441

[ripe charm]

I have a name for my mod already, "Eris" and the description will be "An out-of-this-world, horrifically imbalanced Balatro mod"

[ripe charm]

thx

[red flower]

https://github.com/nh6574/VanillaRemade/wiki#2-install-a-code-editor

[rapid stag]

fine, i will switch from notepad++

[frosty dock]

notepad++ != notepad

it's workable if that's what you're into, whereas notepad... isn't

[frosty dock]

this is impressive but also deeply unsettling

[primal robin]

What exactly? Performance? Maybe

[hoary spear]

agreed...

[primal robin]

I optimized it as I can, shouldnt be that bad

[analog slate]

that didnt work

it doesnt play

[frosty dock]

I dunno, that's not what I thought about. Moreso on a level of "why would you do that"

[primal robin]

I was implementing different format for balala UI first, which is looks like this

[daring fern]

Code?

[primal robin]

As a part of it, I implemented classes, and during discussion was some mentions that classes may be part of smods

[frosty dock]

if performance winds up being an issue, I could see this being an optional feature

well, a soft-optional feature would do as it's tied to a class

[primal robin]

shouldnt be a big deal, I implemented various things to minimize performance issues

Specifically, caching

[daring fern]

Put the message in the return

[primal robin]

But again, is niche thing worth performance? Not sure tbf

[frosty dock]

I like this for how compact and readable it is

[analog slate]

no the message works, the audio doesnt

[daring fern]

Yes, the message needs to be in the return

[frosty dock]

if it's used? sure. what I mean by soft-optional feature is that it can just be bypassed entirely if no selectors were registered

[analog slate]

but why

if i put it in return the message goes on the card played and not the joker

[primal robin]

In this way yes that's true

[analog slate]

i dont want that

[frosty dock]

because a sound return can't exist by itself

[daring fern]

message_card = card

[analog slate]

OHHHH

[primal robin]

But I think there's no place for this in SMODS

[red flower]

the reason is because the sound in a return only replaces the sound a message makes so you need a message as well

[analog slate]

putting all the code made quagmire useless

[frosty dock]

that's not necessarily true. it could be of real value if it integrates smods UI things like localize_box

[analog slate]

is this like right?

[frosty dock]

you still need the message

[analog slate]

its message_card tho right?

[frosty dock]

Also what's that message_card

[analog slate]

ohh

this

[frosty dock]

card, not some string

and there needs to be a message, for the reasons N' explained

[primal robin]

this can be done if try hard enough, but not sure yet. Modders hate UI in general and I don't think this one will help, maybe even opposite, even more things to memorize

[red flower]

i think if it adds some more predefined classes it would be very neat, and other devs could contribute more templates to it

[primal robin]

Especially when it's optional thing, you can do UI as usual too, just like everyone else

[frosty dock]

especially if it has a lot of templates, I can see this being liked by at least some modders

[primal robin]

I see some places for elements which applying localized text for sure

[analog slate]

whats the code for context if blinds selected?

[red flower]

context.setting_blind

[analog slate]

oh ok

so hands is the thing of how many cards you hold, and hand is how many cards/ rounds you play

so how do i write them

[versed swan]

I was developing something similar too, but I really like this

[red flower]

what do you mean

[versed swan]

Or developed*, I already made it https://github.com/Oinite12/balatro-modding-modules/wiki/JTML

[analog slate]

like how would they be written in the code

[frosty dock]

maybe try reading this https://github.com/Steamodded/smods/wiki/G

[analog slate]

as like how do change hand size and how many hands

[red flower]

hand size: G.hand:change_size(number)

how many hands to play:
https://github.com/nh6574/VanillaRemade/blob/1abd606dc26c46f0c7b281995f40fb25b1d54b4f/src/vouchers.lua#L368

[analog slate]

so if the hand is one, then it will only have one card in hand

[red flower]

if the size of G.hand is 1 then yes

[analog slate]

so how much to only have like 4 cards

[red flower]

G.hand:change_size(-G.hand.config.card_limit+4)

[analog slate]

ohh ok

also on the topic of context.setting_blind can this be used as a boolean of sorts

[red flower]

it is a boolean im pretty sure

well true or nil

[frosty dock]

that's basically a boolean

[analog slate]

ohhh ok thx

[frosty dock]

I prefer ternary logic though: true, false or nil

[red flower]

the blind is being set
the blind is not being set
the blind is maybe being set

[analog slate]

ohhhhhhh, also can i theoretically change joker slots to just 2

[red flower]

yes, it's the same code but G.jokers instead of G.hand

[analog slate]

ohhh okie

[random basin]

how do I pull the rarity of a joker card object?
for context G.E_MANAGER:add_event(Event({ func = function() G.GAME.joker_buffer = 0 card:juice_up(0.8, 0.8) sliced_card:start_dissolve({ HEX("57ecab") }, nil, 1.6) play_sound('slice1', 0.96 + math.random() * 0.08) SMODS.add_card { set = 'Joker', rarity = --sliced_card's rarity goes here } return true end }))

[analog slate]

but is it g.jokerslots? i thought i saw that exist

[red flower]

no, G.jokers:change_size() to change it G.jokers.config.card_limit to get the current one

[analog slate]

G.jokers:change_size(2)?

[red flower]

rarity = "Common" ?

or do you mean something else

[random basin]

I mean taking the value of the rarity from the removed joker

[red flower]

ah
sliced_card.config.center.rarity

[random basin]

I think it's sliced_card.config.center.rarity

oh lmao

[primal robin]

I see the vision but a bit too far from initial balala system, also requiring n be exactly first and children be exaclty second arguments is weird

[daring fern]

Yes, but you would have to do ({'Common', 'Uncommon', 'Rare', 'Legendary'})[sliced_card.config.center.rarity] or sliced_card.config.center.rarity

[random basin]

cool that works

[analog slate]

even though ive been pretty much going to see how long i could go without help, it seems that every new atlas isnt working now

[versed swan]

Yeah I'm aware it's very distant from UIBoxDef, I'd say that design choice is intentional because I don't really like how UIBoxDef lumps behavioral attributes with visual attributes

As for the second point, mainly did that so I don't have to use keys which I find to be noisy in code - but I could always revise the module to include keys for those two (though it's not within my interests atm)

[red flower]

did you make an SMODS.Atlas

[analog slate]

yes

OH NVM

know i need to know the color for yellow

oh w8 its gol

uhh since context.setting_blind can be a nil it crashed the game

[rapid stag]

where is G.GAME.legendary_mod in this list turns out that's not a thing

[ripe charm]

Before I code too much towards my mod just for it to have conflicts with another, would prefix "eris" be taken already? (If so I can just think of another)

[sturdy compass]

Are you making Atlases for each individual card??

[red flower]

it wont with the code you posted earlier

probably something else is crashing

[red flower]

i wouldn't worry about it personally unless it's one of the big mods

[analog slate]

yea

[rapid stag]

how would i implement a joker effect that increases the rates of hidden legendary consumables (i.e. the soul and anything else with soul_rate) while you have it?

[sturdy compass]

You can def get away with doing this but you’ll end up with a ton of tech debt

[ripe charm]

I do worry since "eris" of course is borrowed from the Flush Five planet Eris and I know mods named after Balatro cards are common (Talisman, Cryptid, Incantation)

[red flower]

wait until my pr for it gets merged : )

or look at the code for it and change the same places

[analog slate]

ohhh, like what

[red flower]

idk show the crash log and the current code

[red flower]

that one is in limbo until eremel finishes the weighting stuff

[red flower]

ah i see
you forgot to put a number on G.jokers:change_size

[analog slate]

w8 wut

oh i did lol

[wild patrol]

wip but the template is there

[vale zinc]

Can anyone say why these hover-tooltips don't show? Here's the localization data:

ch_c_LAPSEMS_den_of_shadows = {"All Boss Blinds are {C:attention,T:bl_lapsems_mask}The Mask{} or {C:attention,T:bl_lapsems_final_cloak}Chromatic Cloak{}"},

[analog slate]

so how do i get the discards and change it

[vale zinc]

Y'wanna know how many Discards you got left? That's stored in G.GAME.current_round.discards_left.

[analog slate]

ohhhh, could i use that to have only one discard right?

[vale zinc]

Yeah, if you run ease_discard(-(G.GAME.current_round.discards_left - 1)).

Sets 'em to 1. Now, anyone got any pointers for what I messaged a minute ago?

[analog slate]

ohhh

[red flower]

https://github.com/nh6574/VanillaRemade/blob/1abd606dc26c46f0c7b281995f40fb25b1d54b4f/src/jokers.lua#L2494

[analog slate]

ok so know i need it so the player can only play one hand..

[vale zinc]

https://github.com/nh6574/VanillaRemade/blob/1abd606dc26c46f0c7b281995f40fb25b1d54b4f/src/blinds.lua#L449

So, is this just a souped-up version of The Needle?

[analog slate]

its a shrimpo card but yea same thing

[vale zinc]

What is that, a shrimpo card?

[analog slate]

so its a joker card based off dandys world character shrimpo

i just wanted to make a goofy challenge card

[vale zinc]

Anyone?

[sturdy compass]

I don't believe Blinds have hover tooltips

[analog slate]

the website ive been shown talking about colors says it exists

[analog slate]

https://github.com/Steamodded/smods/wiki/Text-Styling

[vale zinc]

Yes, that's what I was going off of!

[analog slate]

is it like this

[sturdy compass]

So no blinds

[vale zinc]

There's no way to include G.P_BLINDS in that selection?

[analog slate]

is it possible to restart balatro? i keep adding things to my mod and i wanna test it out but i have to restart it every time

[sturdy compass]

None that I know of

[sturdy compass]

alt + F5

[analog slate]

oh dang fr?

[wooden nexus]

Okay so I'm trying to write a Joker where one rank is considered the other rank (it's random per ante) and i can't figure out how to even start the code (I'm HELLA rusty)

[sturdy compass]

probably hook Card:get_id

[frosty rampart]

note that hooking card:get_id means the card's rank is effectively replaced (so e.g. "aces count as 2s" means that aces won't trigger scholar anymore)
if you want a card to simultaneously count as multiple ranks, like smeared joker or wild cards behave with suits, you'll have to wait for the infamous quantum ranks PR in smods to get merged (it will probably not get merged any time soon)

[wild patrol]

is it possible to make a boss blind always appear as the final ante 8 boss for a certain deck?

[rapid stag]

me when i use card.base.value:

[vale zinc]

How do I create a Config tab of settings for a mod?

Might you know, @red flower?

[rapid stag]

put UI code into SMODS.current_mod.config_tab

[vale zinc]

How?

[red flower]

https://github.com/nh6574/VanillaRemade/wiki#how-do-i-add-a-config-page

[rapid stag]

well the way i did it was i had a separate lua file where i defined my config tab UI code and then assert(SMODS.load_file())'d that into that var

[frosty rampart]

that's bad practice because that also bypasses rankless enhancements like stone

[rapid stag]

which is why i also check SMODS.has_no_rank()

[red flower]

well it depends why and how its used

[frosty rampart]

is there any particular reason why you need to use card.base.value instead of card:get_id()

[rapid stag]

my reason is that i'm stupid

-# who has docs on Card:get_id()

[red flower]

it returns the id of the card : )

2-10 for 2-10, 11 for jack, 12 for queen, 13 for king, 14 for ace, a random negative value for stone

i think modded ranks get assigned an id

[frosty rampart]

you can get modded rank IDs by checking SMODS.Ranks.modprefix_rankkey.id, and all rankless cards get a random negative value

[rapid stag]

i think for some reason i had it in my head that :get_id() was bad practice and you were supposed to use .base.value

i don't know how this happened

there are a couple non-mechanic-related circumstances where i need .base.value though, so

[vale zinc]

Now that I've got a config page available, how do I access its values?

[rapid stag]

SMODS.current_mod.config.myValue

although it's generally safer to have a global mod table you can access that is populated by SMODS.find_mod([your mod id])[1]

[rapid stag]

yeah, that value in runtime is volatile because it iterates through all mods

to find it via debugplus, you could try
SMODS.find_mod([your mod id]).config.myValue

[vale zinc]

Is it supposed to return a table?

[frosty rampart]

SMODS.find_mod returns a table of all the mods that have or provide the ID
next(SMODS.find_mod("...")) is the first mod in that table, which is what you're looking for

[rapid stag]

right, forgot about that part

[frosty rampart]

although actually you shouldn't need find_mod at all
just SMODS.Mods.Lapsems should get you the same table lol

[vale zinc]

Same with next(SMODS.find_mod('Lapsems')).config.

SMODS.Mods.Lapsems.config.disable_vanilla_boss_blinds worked, though.

[wild patrol]

how do you change the background color of a boss blind?

I can change the ui and title color

but not the background

[vale zinc]

Of a Boss Blind, it's boss_colour = HEX("FF5555"), say, if you want a light red!

[wild patrol]

or is that a lovely patch thing

tried that the color stays the same

talking about the swirl in the background

[vale zinc]

That should be the same as boss_colour. I'm as stumped as you are.

[wild patrol]

maybe i'm just not doing something right

yeah it only affects the ui

[daring fern]

Yes, if you wanted to do that it would be select(2, next(SMODS.find_mod('Lapsems'))).config

[wild patrol]

I change itt o the ox but only the ui changed not the swirl

[vale zinc]

Ohhhh, it's negated for Showdown Blinds. I tried the same.

[wild patrol]

so just not possible through smod?

[vale zinc]

I'm sure it's possible somehow, but that solution is not known to you or me.

[wild patrol]

probably needs to be done through lovely patch then

[rapid stag]

i'm pretty sure there's stuff on changing vortex colour code is that only for the main menu

[wild patrol]

I had to do it through lovely patch

unless it was recently added

smod wiki says it's supposed to affect the background colour

but only affects the ui

yeah it's disabled if it's a showdown boss

is that intentional?

[rapid stag]

does this work to do what i want, or am i stupid? in testing, it's never done the xmult more than once, even with a bunch of oops all 6s

[frosty rampart]

yes, all showdown blinds have the same generic "final boss" background

[wild patrol]

huh never noticed until now

I wonder if I could do a dumb work around

I was gonna make it the final boss of the twitch deck anyways

is there away to set a boss to be the ante 8 boss of a deck?

[twilit hearth]

thoughts on the artwork?? (dont mind the elephant in the room)

[wild patrol]

It looks good to me

Art is subjective anyways lol

As long as it fits your theme should be good

[twilit hearth]

nice way of saying its ass

[wild patrol]

It's better than anything I could make

[gentle rain]

what if the joker were like a library card

[twilit hearth]

how would that work?

@gentle rain

[gentle rain]

something like this

i meant artwise

the effect is rly funny i like that a lot

[twilit hearth]

oh LMAO i was so confused. I know what a library card is i just didnt understand what you meant 😭

thank you for the reference image

[sturdy compass]

Oh hey you're alive again lol

[rapid stag]

bump

[sturdy compass]

That is a scary amount of extras

[daring fern]

Why aren't you using a for loop and SMODS.merge_effects?

[rapid stag]

the idea was to, instead of combining the xmult, have it do the xmult juice each time.

it's 1 in 3 chance for x1.5 mult, then 1 in 4, 1 in 5 and 1 in 6. so the intent is if they all procced, it goes x1.5, x1.5, x1.5, x1.5.

...would merge_effects do that, or would it just do 1 lot of x5 mult?

[daring fern]

Yes, it would do what you want.

[rapid stag]

merge_effects creates a return table, right?

[daring fern]

Yes.

[rapid stag]

wow, it works!

[vale zinc]

Did you design those face cards? I've got some ideas of my own for such, but my pixel art skills are not what I'd like for them to be.

[rapid stag]

i didn't - they were drawn by the former other developer and lead for this mod, who seemingly disappeared off the internet altogether back in november

[versed swan]

hell yeah n you the goat

[wild escarp]

How would I check if the blind is beaten in one hand?

[daring fern]

if context.end_of_round and context.main_eval and G.GAME.current_round.hands_played == 1

[vital wren]

is there a hand scoring context that a joker can access that would occur just before an individual card is calculated? i would want each individual card to score until the last, then have this joker affect that last scoring card, and then that affected card gets scored

i guess i could use context.individual of the card right before it as a really hacky way to accomplish this

[daring fern]

No, but you could use SMODS.calculate_effect outside of a func and it would look as if you did.

[red flower]

i dont think there is

[vital wren]

sorry, how would i do that?

[daring fern]

SMODS.calculate_effect(effect, card)

[vital wren]

where do i put it though, sorry. do you have an example of that being used for something?

[daring fern]

In context.individual

[vital wren]

oh, are you saying like, just don't put it in an event so it bypasses the event manager?

i feel so dense right now, im really sorry im not understanding

[daring fern]

No, things in returns happen when they should, but if you use SMODS.calculate_effect outside of a func in a return it doesn't.

[pastel kernel]

does SMODS.scale_card accept operation = "/"?

[daring fern]

No, you would have to use a function.

[vital wren]

is this what you mean?

-- TODO: new joker that makes rocks count as wild, playing a flush causes the last scored card to become a rock
SMODS.Joker { key = "painted", -- object key (mod prefix will be added automatically)
    atlas = 'balatro-revalanced-jokers',
    pos = { x = 0, y = 0 },
    rarity = 2,
    blueprint_compat = false,
    cost = 5,
    calculate = function(self, card, context)
        -- m_stone are also m_wild, can quantum enhancements do this part?
        if context.individual and context.cardarea == G.play and next(context.poker_hands['Flush']) and 
        context.other_card == context.scoring_hand[#context.scoring_hand] and not context.blueprint then
            SMODS.calculate_effect({
                context.other_card:set_ability(G.P_CENTERS['m_stone'])
            }, card)
        end
    end,
}

[daring fern]

If what you want to do doesn't require a return then you don't need the SMODS.calculate_effect

[vital wren]

oh, i just put the code directly into the calculate and it will work?

[daring fern]

Yes.

[vital wren]

lawl, that's easier