💻・modding-dev

[fluid steppe]

oh.

they're not objects parented to the joker are they

[red flower]

no

[fluid steppe]

fuck

[willow scroll]

is there a context for entering the blind select screen

[red flower]

no but there's one for exiting the shop which might be the same

[willow scroll]

since i literally do not get how to get it to not reset after clicking the cash out button at the end of round screen

[willow scroll]

i guess that works but i dont want the scoring calculation screen to change between default and my deck specific one every time you enter exit shop

[red flower]

check for the state maybe

i think it's G.STATES.BLIND_SELECT or something like that

[willow scroll]

yeah thatd work

evil hook where i modify what happens when you click the cash out button :clueless:

[fluid steppe]

maxbo-ism

[gusty compass]

Can I bump an issue that seems to be some sort of conflict between my mod and the multiplayer mod?

[primal robin]

yes

[gusty compass]

Alr one sec

#💻・modding-dev message

[slim ferry]

im pretty sure thats a fantoms preview issue

which comes baked into multiplayer

[gusty compass]

I'll give that a test

[primal robin]

Yes it is

[gusty compass]

Since the issue seems to be apparent when my mod comes into play

[primal robin]

It's incompatibility with latest smods and MP preview

[gusty compass]

Oh

Well that would be a nice patch later in the future

Yea it works but now I might just fix the phantom edition spawning from my deck effect

[daring fern]

‎

[willow scroll]

raaah the best i can get with states is it flashing back and forth while transitioning to shop

ts pmo 🥀

[clear ocean]

check_for_unlock = function(self, args)
  return args.type == 'win_deck' and get_deck_win_stake('b_checkered') > 1
end

is there a reason why it isnt unlocking?

[willow scroll]

raaah

[daring fern]

Have you tried printing get_deck_win_stake('b_checkered')?

[clear ocean]

I could do that in a moment doing some excersing with the wiifit

[final jewel]

I dont understand why I crash

[willow scroll]

i suspect your loc_vars return is fucked

[final jewel]

yeah probably

But im trying to switch my upgrade check to the card itself so people can implement them by easily

[feral tree]

is it possible to have a enhancement detect if it returns to the deck?

[vale zinc]

Red Card kicks in when the player skips a Booster Pack. Is there any way to tell what kind of Booster Pack is being skipped?

[daring fern]

Yes, hook CardArea:emplace

[daring fern]

Yes, context.booster.config.center.kind

[vale zinc]

So, would if context.skipping_booster and context.booster.config.center.kind == 'Spectral' do the trick?

[willow scroll]

ok it flashes for a single frame now 🙏

i have no idea where in the code the change back to normal is coming from

[daring fern]

Yes.

[wintry swallow]

is there a way to force a specific boss blind order in a challenge deck besides just banning unwanted blinds? for example, making the manacle always the ante 1 boss, the wall always the ante 2 boss, psychic ante 3, etc.

[wind steppe]

yes

hold on let me get the code

[wind steppe]

        G.GAME.perscribed_bosses = {}
        G.GAME.perscribed_bosses[1] = 'bl_fish'
        G.GAME.perscribed_bosses[2] = 'bl_flint'
        G.GAME.perscribed_bosses[3] = 'bl_house'
        G.GAME.perscribed_bosses[4] = 'bl_wall'
        G.GAME.perscribed_bosses[5] = 'bl_serpent'
        G.GAME.perscribed_bosses[6] = 'bl_psychic'
        G.GAME.perscribed_bosses[7] = 'bl_final_heart'

essentially set G.GAME.perscribed_bosses (not typo) to a table containing each ante's boss

[slim ferry]

utdr code spotted

i love the deck that stops you from rerolling prescribed bosses for some reason

[lime pendant]

are yall aware of any mods that handle music in smart ways? (changing tracks at certain times, overriding vanilla music behavior, properly looped tracks etc)

The base steammodded implementation is barebones at best

[final jewel]

I just want to add that to the vanilla seal 😭

[red flower]

all the ones i know use the smods functions

[obsidian spear]

i mean v1 in the yahi mod over takes the blind and boss blind music to be music from the cybergrind

[slim ferry]

whats even wrong with select_music_track

i dont see whats so barebones about it

[red flower]

hotpot has a ton of music tracks

lobcorp is the only one i know that extends music functionality to sync lyrics

[fluid steppe]

weueueu

dk why eternals not modified

but it should be fine

ittl look a lil jank but ehhh

[clear ocean]

im back

@daring fern

https://github.com/nh6574/VanillaRemade/blob/a18262ba0805ecd51ae91e9cc9cf69d0fbfed810/src/backs.lua#L305

[daring fern]

It would be > 0 not > 1

[lime pendant]

lobcorp is sick ty for pointing me that way

[fluid steppe]

awww shit it doesnt work with modded stickers

does this

just like w/ eternal

ideally the entirety of the stickers' displays would be rotated 90°

[red flower]

are you sending the rotation to draw_shader

[fluid steppe]

yea

wait no

no im not

[fluid steppe]

also draw_shader is what im using here

doesnt work on anything but perishable and rental afaict

[red flower]

maybe eternal is drawn somewhere else?

[fluid steppe]

yea and all modded stickers

[final jewel]

Whyyyyyyy 😭
When I select a card with no seal it crash the game but if I select a card with a seal and one with no seal it doesnt crash

[fluid steppe]

READ THE CRASHLONG

WHICH ONE'S LINE 122

ah shit caps lock

[final jewel]

if G.P_SEALS[selected_card:get_seal()].giga_data.seal_upgrade then

its this line but I dont understand

[fluid steppe]

giga_data might not exist sometimes

do if G.P_SEALS[selected_card:get_seal()].giga_data and G.P_SEALS[selected_card:get_seal()].giga_data.seal_upgrade

[willow scroll]

no i think its selected_card:get_seal() returning nil

[fluid steppe]

ohh true

[willow scroll]

and then indexing on the nil value

[final jewel]

oh so I add a condition like if G.P_SEALS[selected_card:get_seal()].giga_data

[willow scroll]

because thing[nil] doesnt exist

[fluid steppe]

ok do uh

if selected_card:get_seal() and G.P_SEALS[selected_card:get_seal()].giga_data.seal_upgrade

[final jewel]

ok

[turbid solstice]

Am I cooking (I know it doesn't exactly follow tarot card "rules"

[fluid steppe]

you know what?

make its number negative

-I

[final jewel]

if selected_card:get_seal() and G.P_SEALS[selected_card:get_seal()].giga_data and 
G.P_SEALS[selected_card:get_seal()].giga_data.seal_upgrade then

Thats the full condition btw

[turbid solstice]

final !

[normal crest]

woof

[civic solstice]

its time for hell again

my shit still dont work lol

[vale zinc]

May anyone tell me why active_message returns "nil"?

config = {
    extra = {
        odds = 4,
        ready_to_sell = false,
        active_message = localize {
            type = 'variable',
            key = 'k_lapsems_when_ready',
            vars = {
                localize('k_active_ex')
            }
        }
    }
}

[red flower]

i think localization is not loaded at that point

even if it was it wouldn't work when changing languages

[vale zinc]

When does localization kick in?

[red flower]

after the game finishes loading but that's not important here
you want to localize at the point you want to use the text, not before

[civic solstice]

why isnt the code transfering properly to the trib ingame im so confused

i dont think i did anything wrong

[red flower]

what is it doing

[civic solstice]

its not doing anything

[red flower]

is it just acting like vanilla or something else

[civic solstice]

i want the trib to be modified so instead of just kings and queens it uses jacks as well and before you say to use the is_face() thing i tried that it just broke trib entirely

[vale zinc]

I defined it within loc_vars instead and that worked.

[civic solstice]

thats a cool mechanic

[red flower]

ok but what does it do now, does it act like normal or does it do nothing at all?

[civic solstice]

it acts like normal

kings and queens work fine just not the jacks

[red flower]

do you have debugplus

[civic solstice]

yeah'

[red flower]

hmm actually it doesn't matter what I was going to suggest because I think this code should crash if it was being read

yeah no idea take_ownership is evil

[civic solstice]

okay im probably gonna scrap all the joker modifications i was gonna do

if take_ownership doesnt wanna work

i do have these ideas as well but like how do i code the majority of this LOL

[vale zinc]

You'll get there eventually. Also, funnily enough, I've also got a Joker named Hitman!

[civic solstice]

awesome

mines actually based off of agent 47

[vale zinc]

Mine's gonna be some unassuming guy holding up a pistol, à la Juggler/Drunkard.

And if you really do "know very little ab(out) lua", then you'd be well served to read through these pages.
https://www.lua.org/pil/contents.html

[frosty rampart]

you should make the hand change after defeating the boss blind, so that you can make a strategic choice if you see it in the shop

[vale zinc]

I had considered that, but wanted the hand assignment to be a surprise instead.

[frosty rampart]

that's fair too

[civic solstice]

i tried

dyslexia makes shit hard LOL

i tried making the jokermancy thing in jokerforge its time to painstakingly figure out how to make it not crash just to display the card ingame

oh dear god i am so fucked

okay i have the custom pool and an if statement that tracks when a joker is sold

i assume i have to get the joker key and add it to the pool

[rocky plaza]

what exactly are u trying to do with the pool
(also do you have prior experience with programming and are new to lua or are you new to programming in general)

[rocky plaza]

yeah jokerforge code is not very neat

if true 🔥

[civic solstice]

1: im tryna add the key of a joker that gets sold to a pool so it has a chance from jokermancy to be reformed in your inventory
2: im not rly new to programming, i used to do it a good bit a handful of years ago but im recently getting back into it and am very new to lua lmao

im tryna learn via the lua website but im dyslexic and can barely read any of it lmao

[willow scroll]

Joker forge spitting out 30 lines of code for 1 block

[civic solstice]

^

[rocky plaza]

what programming languages are you familiar with

[civic solstice]

scratch and thats about it LMAO

[rocky plaza]

oh

hmmm

[civic solstice]

even then im not very adept at scratch so

[rocky plaza]

ok

so your joker will need a config field

if it doesnt have one already

[civic solstice]

it does

[rocky plaza]

because we need to track which jokers have been sold

config = {extra = {sold_joker_keys = {}}}

the {} basically tells lua that the data is stored in the form of
key: value

[rocky plaza]

you're aware of for loops and lists, though
correct?

[civic solstice]

loops yes lists not as much

but i have a relative idea of how lists work

[rocky plaza]

a list is just a collection of data
[1, 2, 3, 4]
has 4 items

[civic solstice]

okay yeah

[rocky plaza]

and so u can access a particular item

by using list[2]

to get the 2nd item

in the case of lua
lists start counting at 1

other languages count from 0 for lists

[civic solstice]

mhm

[vale zinc]

You can also use 'em like dictionaries in Python.

config = {
    extra = {
        odds = 4,
        ready_to_sell = false,
    }
}

card.ability.extra.odds -- returns "4"

That's pulled from my Orange Juice I showed earlier.

[rocky plaza]

in lua
the expression {}
indicates an empty table
which can act as either a list or a hashmap (which is not what we need right now, though lua lists act as hashmaps under the hood)

[civic solstice]

sounds ab right

[rocky plaza]

list = {"joker_1", "joker_2"}
is a list of 2 strings (string is the programming term for text)

[civic solstice]

ya

[rocky plaza]

to access a joker's config values you would check
card.ability.extra

[civic solstice]

ye i learned this from the other 2 jokers i made

[rocky plaza]

okok

so if we set config = {extra = {sold_joker_keys = {}}}
as our initial config table
then card.ability.extra.sold_joker_keys
will initially be an empty table

[civic solstice]

i have this if statement

that hopefully will track when a joker is sold

i think

[rocky plaza]

that checks if card.ability.extra.c_jokers_sold exists as a config value

[civic solstice]

ah

[rocky plaza]

no
heres a grand list of all contexts
SMODS uses contexts to check whether effects should trigger or not
https://github.com/Steamodded/smods/wiki/Calculate-Functions

the relevant one is context.selling_card

[civic solstice]

okay gotchu gotchu

[rocky plaza]

so inside the calculate function

if context.selling_card and context.card.ability.set == "Joker" and not context.selling_self and not context.blueprint then
    -- the code inside here will only trigger if a Joker that is not this Joker is sold (provided this effect is not being triggered because of a Blueprint-like effect
end

[civic solstice]

alright

[rocky plaza]

hopefully im not being too overwhelming

[civic solstice]

no its chill

i actually like how youre explaining what everything means here

[obsidian spear]

            local jokers_to_create = math.min(card.ability.extra.cards, G.jokers.config.card_limit - (#G.jokers.cards + G.GAME.joker_buffer))
            G.GAME.joker_buffer = G.GAME.joker_buffer + jokers_to_create
            G.E_MANAGER:add_event(Event({
                func = function()
                    for _ = 1, jokers_to_create do
                        SMODS.add_card {
                            set = "Bitter",
                            key_append = 'NxkooBreeder'
                        }
                        -- card:add_to_deck()   -- these two are probably not needed, not the issue tho
                        -- G.jokers:emplace(card)
                        G.GAME.joker_buffer = 0
                    end
                    return true
                end
            }))

why does this cause the crash bad argument #1 to 'ipairs'
theres no ipairs

and the issue is not that the mod prefix isnt in set isnt the issue since I've tried both

theres also a bunch of different jokers in the set so thats also not a problem

is this another moment where i've looked over smth

[rocky plaza]

whats the crash message

like the trace

[obsidian spear]

dont ask about the key_append 🥰

[willow scroll]

I won't ask however I will judge

[obsidian spear]

ill check if the crash is different with the prefix in set

[obsidian spear]

D:

[willow scroll]

NOT THE HORSE

[obsidian spear]

horse'd

[rocky plaza]

can i see the bitter object pool def

[willow scroll]

💥

[obsidian spear]

wdym

[rocky plaza]

u tried to spawn a joker from a custom pool, correct?

[obsidian spear]

istg do i need some SMODS.objectpool or smth

[rocky plaza]

SMODS.ObjectType

[obsidian spear]

fml

i prolly should of looked harder

[rocky plaza]

https://github.com/nh6574/VanillaRemade/wiki#how-do-i-create-a-poolset

read this

[obsidian spear]

i do have another issue thats similar i think

lemme get the code

nvm

i just forgot to finish the code

how do i get the center_pool for every consumable

[rocky plaza]

local is_part_of_object_type = (card.config.center.pools or {}).modprefix_custom_pool -- See "How do I create a `pool/set?""

[obsidian spear]

where is this in vremade?

[rocky plaza]

a consumable can be a part of multiple pools

[rocky plaza]

https://github.com/nh6574/VanillaRemade/wiki#how-do-i-get-the-set-pool-or-key-of-a-specific-cardobject

vremade is a gift given by god to humanity

[obsidian spear]

god being N'

my brain is mush i may need extra help implementing

[rocky plaza]

implementing a custom pool?

[obsidian spear]

no with finding if its consumable

wait

no yes

no wait

getting all cards that are consumable

[rocky plaza]

?
is the intent to spawn a random consumable?

[obsidian spear]

yes

[rocky plaza]

i see

[obsidian spear]

specially 2

but doesnt matter

heres the entire calculate function

    calculate = function(self, card, context)
        if context.end_of_round then
            -- main if statement
            for _=1, card.ability.extra.cards  do
                -- card will look like {card = key, negative = boolean}
                if #G.consumeables.cards + G.GAME.consumeable_buffer >= G.consumeables.config.card_limit then
                    -- check for space
                    goto continue
                end
                
                local other_card = SMODS.create_card({ key = pseudorandom_element(G.P_CENTER_POOLS[""], "glitchkatcard").key, area = G.consumeables })
                other_card:set_edition("e_polychrome")

                -- so we can skip the card incase
                ::continue::
            end
        end
    end```

[rocky plaza]

hold on im testing something

[obsidian spear]

alr

take your time

[rocky plaza]

https://github.com/nh6574/VanillaRemade/wiki#whats-a-poolset

[obsidian spear]

i got other bugs i can fix in the mean time

[rocky plaza]

checking if something here is relevant

[obsidian spear]

yea

i just sent it

lololo

[rocky plaza]

and if i think it works how it works

[red flower]

hi

[obsidian spear]

thank you thunder edgeee

[obsidian spear]

Omg its god

[obsidian spear]

would I just put it as key?

[red flower]

i am shigure ui

[obsidian spear]

🙏

[red flower]

as a set

set = "Consumables"

[obsidian spear]

right

[rocky plaza]

oh i think its the misspelled version for the set

[obsidian spear]

bit more than usual

should of only created 4 since i have bitter copying him

thats a bit odd

could be bitter shenanigans

[rocky plaza]

SMODS.add_card({set = "Consumeables", area = G.consumeables})

[obsidian spear]

yea i accidentally used create_card

[rocky plaza]

also wtf are u doing with goto

i understand what is going on

but why

[obsidian spear]

wdym goto

[civic solstice]

this is a funny idea for a legendary joker dont yall think

[rocky plaza]

this

[obsidian spear]

skipping

ig i could make it return

wait

no

its a loop

i have to skipp to the end

[obsidian spear]

pretty good yea

but its not that much mult

since it wont be retriggered as much as photograph or baron can

[civic solstice]

i was actually just thinking of making a rarity above legendary and make a few mythic cards to put into a super rare pack that has all 3 that you have to choose

and that wastumok would be one of those

[obsidian spear]

well its not that good though...

but if you think its right then its good

[civic solstice]

i can buff it

[obsidian spear]

true

[rocky plaza]

oh i know why
u need context.main_eval in addition to context.end_of_round

[obsidian spear]

you'd need to buff it through different means

[obsidian spear]

oh what?

[rocky plaza]

because context.end_of_round is called multiple times

[obsidian spear]

ohhhhhhhh

okay ty again thunnderrrrr

[civic solstice]

maybe like it can trigger all the seals in the hand as well?

[obsidian spear]

yea thats about right

[rocky plaza]

context.main_eval ensures that end of round effects only trigger once

[obsidian spear]

okay cool

ill remember that i hope

[rocky plaza]

in other words what do yall think about this sticker

[obsidian spear]

hmmm

yea

its hard to use but in a good way

makes you use hands you probably wont use if you're getting rid of cards that are in that hand

[rocky plaza]

see stickers have the potential to add new gameplans

[obsidian spear]

yesssssss

[rocky plaza]

i wish people capitalized on this more

they dont have to strictly be negative

[obsidian spear]

i think i forgot a return

just maybe

its also all jimbo

[rocky plaza]

... what is jimbo doing in the consumable slots 😭

[obsidian spear]

no idea

[rocky plaza]

whats the code for the end of round card creation again

[obsidian spear]

local other_card = SMODS.add_card({ set = "Consumeables", area = G.consumeables })
                        other_card:set_edition("e_polychrome")```

[rocky plaza]

unless this is a different thing

[obsidian spear]

uhm

cuz of variable?

[rocky plaza]

no...

[obsidian spear]

uhm

[rocky plaza]

hover over the jimbos

are they actually jimbos

[obsidian spear]

lemme just add the return

[rocky plaza]

i know that sometimes people use the default jimbo sprite as placeholder sprite

[obsidian spear]

that uhm

main_eval btw

oh i see

but that doesnt bhelp

should move this

[civic solstice]

gimme ideas

[obsidian spear]

better so it doesnt accidentally create more than should be possible

but doesnt make sense on the multiple

[rocky plaza]

calculate = function(self, card, context)
    if context.end_of_round and context.main_eval then
        for i = 1, math.min(card.ability.extra.cards, G.consumeables.config.card_limit - #G.consumeables.cards - G.GAME.consumeable_buffer) do
            -- create cards here
        end
    end
end

try this???

[obsidian spear]

oh problem

its waiting for there to be room for jokers ithink

bro 😭

[rocky plaza]

bruh

[obsidian spear]

could you join cold beans so i can show you?

[rocky plaza]

im in cold beans

[obsidian spear]

    calculate = function(self, card, context)
        if context.main_eval then
            -- main if statement
            G.GAME.joker_buffer = G.GAME.joker_buffer + card.ability.extra.cards
            for _=1, card.ability.extra.cards  do
                -- card will look like {card = key, negative = boolean}
                if #G.consumeables.cards + G.GAME.consumeable_buffer >= G.consumeables.config.card_limit then
                    -- check for space
                    goto continue
                end

                G.E_MANAGER:add_event(Event({
                    func = function()
                        local other_card = SMODS.add_card({ set = "Consumeables", area = G.consumeables })
                        other_card:set_edition("e_polychrome")
                        G.GAME.joker_buffer = G.GAME.joker_buffer - 1
                        return true
                    end
                }))

                -- so we can skip the card incase
                ::continue::
            end
        end
    end

[vale zinc]

Wait, what's the ::continue:: used for? I've never seen anything like that in Lua!

[still isle]

cat

[obsidian spear]

cat :3

[obsidian spear]

its lua

[still isle]

ilovecars

[obsidian spear]

it just skips to the next thingy

thats same name

its used in alot of coding langs

[red flower]

using goto instead of not is crazy

[rocky plaza]

thats what im saying

[obsidian spear]

im used to my continue in luau

[rocky plaza]

theres a better way to do this without goto

surely

[still isle]

can u give me the cato mod pls :3

[civic solstice]

chat thoughts?

[vale zinc]

Does Cliphtonyke function like Splash?

[civic solstice]

yes and no?

like you can play any and all cards you have in your hand like you dont have to worry about the selection limit

but it wont give a splash effect if you use it

so like

if you play a hearts flush and you have 2 spades in there the spades wont trigger

but the other hearts do

[obsidian spear]

    calculate = function(self, card, context)
        if context.main_eval then
            -- main if statement
            G.GAME.joker_buffer = G.GAME.joker_buffer + card.ability.extra.cards
            for _=1, card.ability.extra.cards  do
                -- card will look like {card = key, negative = boolean}
                if #G.consumeables.cards + G.GAME.consumeable_buffer <= G.consumeables.config.card_limit then
                    G.E_MANAGER:add_event(Event({
                        func = function()
                            local other_card = SMODS.add_card({ set = "Consumeables", area = G.consumeables })
                            other_card:set_edition("e_polychrome")
                            G.GAME.joker_buffer = G.GAME.joker_buffer - 1
                            return true
                        end
                    }))
                end

                -- so we can skip the card incase
                -- ::continue::
            end
        end
    end

[obsidian spear]

no cato mod

[soft pier]

Mega stupid idea

[obsidian spear]

bitter mod

[obsidian spear]

yea?

[soft pier]

Wild cards have the effects of every enhancement, edition, and seal

(Minus negative)

[still isle]

wait public or?

[obsidian spear]

bitter mod

[still isle]

link pls :3

[obsidian spear]

its buggy

i will tho

[still isle]

if buggy its oke :)

[obsidian spear]

https://github.com/BitterrDoes/BitterStuff

[still isle]

thank woo

[civic solstice]

actually fk it ima make 2 more and plan up a good amount more legendaries

done

what do we think

also any other ideas for pnostia i have none LOL

[civic solstice]

also im gonna come back to this and instead focus on other small things i have planned like the vouchers and maybe even the stakes idk

[obsidian spear]

<@&1133519078540185692>

[terse merlin]

<@&1133519078540185692>

[gray void]

[obsidian spear]

[gray void]

I mean

Nope to the images

Immolate such images

[obsidian spear]

real

we should flood the images away with random dev questions

[obsidian spear]

How does a for loop work?

I mean i've used them but like how do they work

[gray void]

||nsfw better pls dont ban me me joking||

[obsidian spear]

dev questions idiot

[gray void]

Okay okay

[ashen drift]

why is "attempt to index local 'center' (a nil value)" popping up when i use card:set_ability to enhance a card

[wind steppe]

first they for then they loop

let's for loop

[obsidian spear]

ah

lets for loop?

for

[ashen drift]

4 loops

[gray void]

4 for loops made of of fours for looping the four 4s

[obsidian spear]

for for for for

[ashen drift]

                    if not result_area.cards[1] then crrd = SMODS.create_card { set = "Base", enhancement = resultenhancement, rank = resultrank, area = result_area } 
                    G.playing_card = (G.playing_card and G.playing_card + 1) or 1
                    table.insert(G.playing_cards, crrd)  
                    G.result:emplace(crrd) else 
                        crrd = result_area.cards[1] 
                        crrd:set_ability(resultenhancement)
                    end

this is the snippet of code causing it specifically

[obsidian spear]

its a bug with smods i think

n' told be one time

or was it eremel

lemme get it

[ashen drift]

that sucks

[obsidian spear]

cant find

just like set it outside of create card

also you should use add_card instead so you can remove table insert and emplace

[ashen drift]

ill just try to put the actual center as the arguement

okay it completely breaks drawing hands for no reason

[obsidian spear]

odd

well now I have a balala question, how do I set the seal, edition and enhancement of a chosen playing card

[ashen drift]

im doing```lua
crrd:set_ability(G.P_CENTERS[resultenhancement])

[obsidian spear]

uuh

again i dunno im also needing to set enhancement

[ashen drift]

and the game shits itself

i think the not drawing cards was caused by something else which is weird

okay i checked the dump and im more confused now

supposedly its crashing at line 281, which is ```lua

if center.name == "Half Joker" and (center.discovered or self.bypass_discovery_center) then 
    H = H/1.7
    self.T.h = H

but previous code also indexes the center

so its just breaking here for no reason

isnt that how you get them

[obsidian spear]

robably should use center.key

then do

j_modprefix_jokerkey

[ashen drift]

oh nevermind i troubleshotted it

yeah i was looking at the wrong thing LOL

[obsidian spear]

lolll

[obsidian spear]

please someone answer

[ashen drift]

card:set_seal("seal_key"), card:set_ability("enhancement_key"), card:set_edition("edition_key")

[obsidian spear]

tyyy ampll,e

[obsidian spear]

calculate = function(self, card, context)
        if context.playing_card_added then
            print(context.cards)
            for _, other_card in pairs(context.cards) do
                SMODS.change_base(other_card, pseudorandom_element{SMODS.Suits}, pseudorandom_element{SMODS.Ranks})
                other_card:set_seal(pseudorandom_element{G.P_CENTER_POOLS.Seal})
                other_card:set_edition(pseudorandom_element{G.P_CENTER_POOLS.Edition})
                other_card:set_ability(pseudorandom_element{G.P_CENTER_POOLS.Enhanced})
            end
        end
    end

why does this crash?

[lucid owl]

which line is 614

[obsidian spear]

thats from lovely or smods

not my mod

@lucid owl ?

[lucid owl]

the stack trace should provide an exact line of code in this calculate function somewhere

[obsidian spear]

i've checked through them and a majority is from tangents, aiko or from my own hooks

okay well its the seal's fault ig

oh

its cause i didnt add .key

new crash log

this isnt right...

that line is for half joker

[lucid owl]

bold to test your mod with aiko and tangents installed

actually insane to test your mod with aiko and tangents installed

[obsidian spear]

my mod edits tangents

and aiko cuz i forgot to change it

[lucid owl]

is this checking vanilla card.lua or lovely dump

[obsidian spear]

uuh

[lucid owl]

like are you checking vanilla source or the card.lua found in the lovely dump

[obsidian spear]

lovely dump

@lucid owl is it alright for me to ping reply?

[lucid owl]

yea

[obsidian spear]

ight

[lucid owl]

send the full file

that's crashing

[obsidian spear]

you mean the joker?

[lucid owl]

cause i'm not sure what you're really trying to do and your stack trace is a bit fucked up

[lucid owl]

whatever the file is that's crashing

unless you have everything in one file

ig just send the section if so

[obsidian spear]

SMODS.Joker {
    key = "yandev",
    
    loc_txt = {
        name = "Yandare Dev",
        text = {"Added playing cards have everything {C:,E:1}randomized"}
    },
    pronouns = "he_him",

    blueprint_compat = false,
    config = { extra = {} },
    loc_vars = function(self, info_queue, card)
        return { vars = {}}
    end,

    atlas = 'JokeJokersAtlas',
    pos = { x = 4, y = 0 },

    rarity = "Bitters_baddev",
    cost = 6,
    pools = {["BitterPool"] = true},

    calculate = function(self, card, context)
        if context.playing_card_added then
            print(context.cards)
            for _, other_card in pairs(context.cards) do
                SMODS.change_base(other_card, pseudorandom_element{SMODS.Suits}, pseudorandom_element{SMODS.Ranks})
                other_card:set_seal(pseudorandom_element{G.P_CENTER_POOLS.Seal}.key)
                other_card:set_edition(pseudorandom_element{G.P_CENTER_POOLS.Edition}.key)
                other_card:set_ability(pseudorandom_element{G.P_CENTER_POOLS.Enhanced}.key)
            end
        end
    end
}```

all on same file

[lucid owl]

probably separate your files eventually

[obsidian spear]

thinking of seperating by rarity

[lucid owl]

not by rarity

by individual joker

[obsidian spear]

thats a lotta files

[lucid owl]

nxkoo shouldn't have separated by rarity

[lucid owl]

you get used to it

[obsidian spear]

also the amount of jokers dont really matter since they take up 2 lines atleast

using ctrl-k -> ctrl-0 will collapse everything

[lucid owl]

i'm not really sure what the issue could be because this should totally work

how many hooks do you have on those functions

[obsidian spear]

which functions?

i have like 4 or so hooks

[lucid owl]

you could always try changing to a for i = 1, #context.cards do loop

[lucid owl]

set_seal(), set_edition(), etc

[obsidian spear]

none

also the for loop isnt the problem

-# im pretty sure

[lucid owl]

oh, you'll probably want to use SMODS.poll_seal, poll_edition, etc

you may be setting variables incorrectly

[lucid owl]

it's still not really good practice

[obsidian spear]

so how would I implement? instead of pseudorandomelement I'd do poll seal or smth?

[lucid owl]

separating into individual files makes things much easier to parse

[obsidian spear]

i want it to be completely random

not caring about weight

[lucid owl]

card:set_ability(random_enhancement) -- Set an enhancement on an existing card```

[lucid owl]

hm

a bit weird

[obsidian spear]

which is why i have it be fully random

i guess i could just use poll

mmmm

if we cant find a way to fix it then i will

[lucid owl]

can you post the entire crash log

you never really gave detail on that aside from the vague starting crash message

[daring fern]

if context.playing_card_added then
    for k, v in pairs(context.cards) do
        SMODS.change_base(v, pseudorandom_element(SMODS.Suits, 'seed').key, pseudorandom_element(SMODS.Ranks, 'seed').key)
        v:set_seal(pseudorandom_element(G.P_SEALS, 'seed').key)
        v:set_edition(pseudorandom_element(G.P_CENTER_POOLS.Edition, 'seed').key)
        v:set_ability(pseudorandom_element(G.P_CENTER_POOLS.Enhanced, 'seed').key)
    end
end

[obsidian spear]

omg

is it missing the seed

holy shit.

istg

okay okay it didnt matter

[lucid owl]

a seed isn't necessary but it was likely the missing .keys that i definitely should have picked up on

[obsidian spear]

it did have .key?

[lucid owl]

not suit and ranks

[obsidian spear]

ah

ill check

[daring fern]

No, it is.

[obsidian spear]

nah nothing changed

    calculate = function(self, card, context)
        if context.playing_card_added then
            print(context.cards)
            for _, other_card in pairs(context.cards) do
                SMODS.change_base(other_card, pseudorandom_element{SMODS.Suits}.key, pseudorandom_element{SMODS.Ranks}.key)

                other_card:set_seal(pseudorandom_element{G.P_CENTER_POOLS.Seal}.key, 'yandev_s')
                other_card:set_edition(pseudorandom_element{G.P_CENTER_POOLS.Edition}.key, 'yandev_e')
                other_card:set_ability(pseudorandom_element{G.P_CENTER_POOLS.Enhanced}.key, 'yandev_a')
            end
        end
    end

current code

[daring fern]

#💻・modding-dev message

[obsidian spear]

a

[lucid owl]

would this not still work without a seed present?

i'm less familiar with math and its seed stuff

[obsidian spear]

    calculate = function(self, card, context)
        if context.playing_card_added then
            print(context.cards)
            for _, other_card in pairs(context.cards) do
                SMODS.change_base(other_card, pseudorandom_element{SMODS.Suits, 'yandev_suit'}.key, pseudorandom_element{SMODS.Ranks, 'yandev_rank'}.key)

                other_card:set_seal(pseudorandom_element{G.P_CENTER_POOLS.Seal, 'yandev_s'}.key)
                other_card:set_edition(pseudorandom_element{G.P_CENTER_POOLS.Edition, 'yandev_e'}.key)
                other_card:set_ability(pseudorandom_element{G.P_CENTER_POOLS.Enhanced, 'yandev_a'}.key)
            end
        end
    end

added the stuff, still no work

wait

the {}

okay it works

god damn that took far longer than it shouldve

[vale zinc]

For accomplishing something after cards in hand finish scoring but before Jokers begin scoring, would a patch be the easiest way to do it?

[prisma loom]

Folks, how do I make my custom rank to NOT have any suit or rank?

and make it so it's not a part of all decks by default

[daring fern]

in_pool = function(self, args) return not args.initial_deck end

[prisma loom]

👌

[daring fern]

Hook SMODS.has_no_rank and SMODS.has_no_suit

[prisma loom]

Should I add those to my main.lua?

or to hooks.lua?

[daring fern]

Yes, because you need to hook it.

[prisma loom]

like this?

[latent perch]

a hook is a redefinition of a function to include your own logic;

local function_ref = function_name
function function_name()
    local ret = function_ref()
    # your logic here
    return ret
end

so what you need is;

local smods_hnr_ref = SMODS.has_no_rank
function SMODS.has_no_rank(card)
  local ret = smods_hnr_ref(card)
  if card.base.rank == "your_rank_key" then
    ret = true
  end
  return ret
end

and the same for SMODS.has_no_suit

[prisma loom]

ic ic

on it👌

[latent perch]

correction, it's card.base.value btw

not card.base.rank

[daring fern]

No, it would be card:get_id() == SMODS.Ranks['modprefix_key'].id

[prisma loom]

👌

[latent perch]

I mean card.base.value would also work would it not?

oh wait no because stone cards

right

[latent perch]

replace if card.base.rank == "your_rank_key" then with the above card:get_id() == SMODS.Ranks['modprefix_key'].id

[prisma loom]

kk

[latent perch]

if card:get_id() == SMODS.Ranks['modprefix_key'].id then that is ofc

[slim ferry]

Wouldnt that stack overflow

[prisma loom]

my games crashes

[slim ferry]

Because Card:get_id() calls SMODS.has_no_rank too

[prisma loom]

without error report

as well

[slim ferry]

Yeah thats kinda what i expected

Use card.base.id instead of card:get_id()

[prisma loom]

👌

[prisma loom]

Is there a way to assign cutom amount of chips/mult/xmult to this rank?

instead of default +chips

Also it seems like it still doesnt ignore suits

I did smth wrong?

[slim ferry]

The display is not removed by has_no_suit

In the name

[prisma loom]

It's done via loc lua?

[slim ferry]

Handled in Card:generate_loc_vars

[daring fern]

Hook Card:get_chip_bonus, Card:get_chip_mult and Card:get_chip_x_mult

[slim ferry]

I think

[prisma loom]

It would override default chips?

[daring fern]

No, because that doesn't exist.

[daring fern]

Yes, if you don't return the original functions chips.

[slim ferry]

It definitely does, ive patched it for showing perma bonuses on cards

[daring fern]

No, it definitely doesn't.

[prisma loom]

Where do I define how much xmult?

in the lua file of the custom rank itself?

[daring fern]

No, it's Card:get_chip_x_mult not SMODS.get_chip_x_mult

[prisma loom]

👌

[daring fern]

No, you return the xmult

[prisma loom]

Got it right?

[daring fern]

No, it would be Card.get_chip_x_mult for the old function, also you would return the xmult as a number.

[prisma loom]

Oh, I saw it my bad

[prisma loom]

Like this?

also local ret got grey'ed out

do I need to return ret?

[daring fern]

Yes.

[prisma loom]

I think I messed up returns

[wintry swallow]

is this overpowered ?

[prisma loom]

gains +1 sell value mb?

wording is wierd

[wintry swallow]

no, lose 1$

if its a high card

[prisma loom]

then say so "and lose $1" ("$1" in red color)

[wintry swallow]

ok

but u think it needs a nerf or its good?

[prisma loom]

Compare it Green Joker/Ride the bus

and decide

I think it's alr for uncommon ig

[wintry swallow]

i will change the text and play some runs with

[prisma loom]

👌

[daring fern]

It should be function Card:get_chip_x_mult(context) and it should be self not card also move the 1.5 out of the table.

[prisma loom]

Should ret and 1,5 be in the same return?

Im totally lost

[wintry solar]

what are you trying to do?

[prisma loom]

Custom playing card

with no rank or suit

(basically a new rank)

[prisma loom]

and x1.5 mult

It is a token created by a Joker

(added to your deck)

in SMODS.Rank there are no settings for no rank/no suit so it got complicated

[wintry solar]

local chip_x_mult_ref = Card.get_chip_x_mult
function Card:get_chip_x_mult(context)
  if self.base.id == SMODS.Ranks['hnds_creepycard'].id then
    return SMODS.Ranks['hnds_creepycard'].config.xmult
  end
  return chip_x_mult_ref(self, context)
end

and then put config = {xmult = 1.5} in your Rank definition

though you should probably just be using an enhancement for this, no?

[slim ferry]

Its supposed to be able to be enhanced too

[prisma loom]

It's supposed to be enhanceable

yeah

it's a playing card

[prisma loom]

Or you meant quantum enhancements?

the ones that can be on card without taking ehn slot

iirc

[wintry solar]

I don't

[prisma loom]

kk

[wintry solar]

regardless, the code I sent should work

[prisma loom]

It still adds 13 chips

[wintry solar]

try adding nominal = 0

[prisma loom]

👌

[prisma loom]

The last thing: how exactly can I customize the text box/name (remove "of suit") of a playing card?

or nominal = 0 is all I can use?

[wintry solar]

I don't think you can customise it

I've never worked with Ranks though

[prisma loom]

ic ic, thanks a lot regardless!

[latent perch]

you can actually, gimme a sec

# generate_card_ui() patch '[rank] of [suits]' -> '? of [suits]'
[[patches]]
[patches.pattern]
target = "functions/common_events.lua"
pattern = '''localize{type = 'other', key = 'playing_card', set = 'Other', nodes = full_UI_table.name, vars = {localize(specific_vars.value, 'ranks'), localize(specific_vars.suit, 'suits_plural'), colours = {specific_vars.colour}}}'''
position = "at"
payload = '''localize{type = 'other', key = 'playing_card', set = 'Other', nodes = full_UI_table.name, vars = {((card.seal == 'uni_shattered' and '?') or localize(specific_vars.value, 'ranks')), localize(specific_vars.suit, 'suits_plural'), colours = {specific_vars.colour}}}'''
match_indent = true

This patch makes it so that a card with a certain seal displays '? of [suit]' instead of the rank

[prisma loom]

oooo

[latent perch]

adjusting it like so should make it work for suits;

# generate_card_ui() patch '[rank] of [suits]' -> '? of [suits]'
[[patches]]
[patches.pattern]
target = "functions/common_events.lua"
pattern = '''localize{type = 'other', key = 'playing_card', set = 'Other', nodes = full_UI_table.name, vars = {localize(specific_vars.value, 'ranks'), localize(specific_vars.suit, 'suits_plural'), colours = {specific_vars.colour}}}'''
position = "at"
payload = '''localize{type = 'other', key = 'playing_card', set = 'Other', nodes = full_UI_table.name, vars = {localize(specific_vars.value, 'ranks', (card.base.value == "your_rank_key" and "?" or localize(specific_vars.suit, 'suits_plural')), colours = {specific_vars.colour}}}'''
match_indent = true

<@&1133519078540185692>

thanks <3

[latent perch]

however this will display "Rank name of ?", not just "Rank name"

if you want just the rank name I'll have to dig a little deeper..

[wintry solar]

but that's a very destructive patch

[prisma loom]

☢️

[latent perch]

you might be able to hook generate_card_ui() instead

and set specific_vars.suit

[wintry solar]

ultimately, this specific effect sort of needs a new SMODS.PlayingCard class

[latent perch]

alternatively, you could add a check before this line

localize{type = 'other', key = 'playing_card', set = 'Other', nodes = full_UI_table.name, vars = {localize(specific_vars.value, 'ranks'), localize(specific_vars.suit, 'suits_plural'), colours = {specific_vars.colour}}}

like;

if card.base.value == "your_rank_key" then
  localize{..., nodes = full_UI_table.name, vars = {localize(specific_vars.value, 'ranks'), "", colours = {specific_vars.colour}}}
else
  localize{type = 'other', key = 'playing_card', set = 'Other', nodes = full_UI_table.name, vars = {localize(specific_vars.value, 'ranks'), localize(specific_vars.suit, 'suits_plural'), colours = {specific_vars.colour}}}
end

and have the upper localize point to a localization entry that mimics the playing card one

[slim ferry]

Is that like a raw G.P_CARDS entry? Ive never heard of that

[latent perch]

just without the "of"

[wintry solar]

no eris, it's not a thing that exists

[slim ferry]

Ohhh

Like that

[prisma loom]

Wait, why is it SMODS.Ranks that exists and not SMODS.PlayingCard?

I feel like the latter should include rank settings

and have more options on top

[slim ferry]

Probably because making every rank+suit combination seperately is rather inconvenient

Since every rank+suit combination has an entry in G.P_CARDS

Afaik

[wintry solar]

because nobody has made it

where as custom suits and ranks are much more likely to be wanted

[vernal seal]

hello again, another question that i want to ask:
how can i make the text color change with the custom value?

[prisma loom]

No I meant SMODS.PlayingCard should be superior functionally speaking since it implies that it can adjust both suit/rank and other stuff at the same time

instead of just being one or the other

I hope this makes sense

[slim ferry]

V:1 is the first colour returned in loc vars as a text colour, B:1 is the same but background colour

Is how it works

Iirc

[prisma loom]

why so?

[vernal seal]

ill show you the entire code for loc_vars and other part of the file

[slim ferry]

returned colours should be in a colours table in vars

[wintry solar]

because these are some of the very first SMODS objects that were created

and nobody has ever really needed an implementation of specific playing cards that aren't just suit + rank

[prisma loom]

In that case how can I go about my problem?

make it into enhancement?

[wintry solar]

you either revise your aim so that it functions as an enhancement, or your program all the stuff you need yourself

but at this moment in time, the SMODS api can't really do what you're trying to do for you

[prisma loom]

never thought Id come across smth smods can't handle huh

[prisma loom]

👌

[wintry solar]

there are lots of things smods can't do

it's far from being a complete api for modding

[prisma loom]

what are the most desired features atm?

for Balala modding that is

[wintry solar]

a lot of people want quantum ranks but that is inherently scuffed imo

[prisma loom]

huh, this is the one that sounds way too specific to me

[prisma loom]

it's very scuffed gameplay-wise I think

in terms of making hands

[vernal seal]

soo like this?

[prisma loom]

never know what would take priority

or at least it'll be hard to track

[slim ferry]

colours = {...}

And it would be B:1 since its the first colour

<@&1133519078540185692>

[wintry solar]

<@&1133519078540185692>

[slim ferry]

Oh my god bruh

[vernal seal]

who was that?

[stoic void]

how did i miss that when i was sitting right here

[slim ferry]

A bot

[finite crow]

how do i change the jimbo that pops up at the end of the run to a different joker sprite (more specifically one from my mod)

if that’s even possible

[red flower]

search for JimboQuip https://github.com/Steamodded/smods/discussions/919

[zealous glen]

What would take priority is obvious

[zealous glen]

Quantum Suits already exist, this is a natural extension. The main complication is that Straights exist, unlike Flushes

[prisma loom]

Its more about actually understanding what options you have at a given moment

Could be confusing

[wintry solar]

Quantum ranks absolutely is not a priority over other features

[zealous glen]

Outside of Quantum Ranks, probably applying Edition Shaders to arbitrary sprites and putting things on a grid

[zealous glen]

That’s upon game designers

Unless you think Wild Cards are confusing

[prisma loom]

👌 thanks for clarifying

[zealous glen]

I’m totally unbiased

[prisma loom]

Wild cards are way way less so since there are only 4 in the base game

[wintry solar]

Those also aren’t widely requested features, they’re just things victin wants

[prisma loom]

Opposed to 13 ranks + face cards definitions

[zealous glen]

I don’t think it would be harder to understand if there were 60 suits

[zealous glen]

I mean 7 people have reimplemented the former by themselves

Or are trying to

The latter I only mentioned because Winter said she was going to try and implement it for a Credits page, and I realized a Grid would address 2 other features that have been brought up

Automatic Sticker placement and automatic CardArea positioning

[prisma loom]

And I want SMODS.Playing card 😭 we all want more smods upgrades nothing bad in that, its just all up to priority list ig

[zealous glen]

So while by itself it’s not a requested feature it’s a

[prisma loom]

Whos resposible for adding new smods features?

John?

[zealous glen]

How do you call it in English

A stone that kills two birds

[zealous glen]

You

[prisma loom]

Awwww

[zealous glen]

🫵

[tall wharf]

me

[prisma loom]

its me tfym

[zealous glen]

resident chat GPT apikoyori

[tall wharf]

i added 2 banger features to SMODS

[zealous glen]

I added 2 banger features to SMODS

which got removed

[prisma loom]

I contributed nothing
but no bugs as well😎

[zealous glen]

Wrong you forgot the door open and the moths flew in

Now they’re eating the cards

[prisma loom]

it seems I was a fool [Creates a copy of the last used tarot or planet card] all along

[slim ferry]

Creates a copy of the last used tarot or planet card

[slim ferry]

Everyone (in theory)

The wonders of open source software

Anyone can contribut

E

[prisma loom]

E indeed

[wintry solar]

What was the second?

[umbral spire]

Alpaca, Theta and Delta?

[finite crow]

therian

[zealous glen]

The DeckSkin template

Also my contributions didn’t get removed

I was making a joke

[finite crow]

not exaaaactly what i was looking for, i want to change the sprite on the default win/loss quips and nothing else

i do know it's possible to change sprites like that because i already have the jimbo on the bootup screen changed to a custom joker i just wanna know what path i need to change the one at the end of the run

[wintry solar]

Change the quips that already exist

[finite crow]

i. still need to know the pathing to do that

wait hang on i might already

but i might not

I GOT IT

...almost

works flawlessly on *most of the win quips, but only the text works for some win quips and all the lose quips

ehhhh whatever i'll just do custom text instead of having a custom sprite too this is too much of a headache

[red flower]

how are you doing it

i think you can take ownership of the jimboquips

[lavish elm]

local _card = SMODS.create_card {set = "Base", rank = tostring(random_rank), suit = random_suit, seal = random_seal, enhancement = random_enhancement, edition = random_edition, area = G.deck}
why this not work
I am doing this inside the apply function of my deck

[red flower]

what doesnt work

[lavish elm]

it creates a random card instead of the assigned rank and suit and it also places them in the free roam way

[red flower]

for the first problem how are you getting the rank and suit
for the second change create_card to add_card

[lavish elm]

local random_rank = pseudorandom("flush five", 2, 14)
local random_suit = pseudorandom_element({"Clubs", "Hearts", "Diamonds", "Spades"}, "flush five")

[red flower]

for the random rank 11, 12, 13 and 14 wont work, it needs to be the rank key

what smods version do you have

[lavish elm]

latest version

[red flower]

hmm idk why the suit doesnt work then

can i see the whole code

[lavish elm]

ok but I will have to send it in a .txt file bc me have no nitro

[red flower]

ok

[lavish elm]

here is my terribly crafted code

ok so when the math.random hit a non face card rank it worked

[red flower]

yeah you need to change that to the keys, also in that code pseudorandom_element is missing the seed

[lavish elm]

yeah I am trying to make it true random bc I realised that pseudorandom not good for decks

[red flower]

you shouldn't use math.random because the same seeds will produce different results

lol i mixed it up

pseudorandom should do the same thing here

[lavish elm]

yeah that is the point
the deck is supposed to generate 5 copies of a random card

[red flower]

ok but you want the same seed to always be the same

[lavish elm]

when I used pseudorandom it always hit jack of clubs

[red flower]

you probably need to use pseudorandom inside the event

you would need to use pseudorandom_element anyway to get the rank keys

[lavish elm]

So does rank kays work with card:get_id()

[red flower]

no

[red flower]

you need card.base.value

[vale grove]

iam making a joker that gives x0.25 mult if your hand played isnt the same as the last one

        if context.before and not context.blueprint and G.GAME.last_hand_played then

how do i make the correct context check?

[slim ferry]

context.initial_scoring_step and G.GAME.last_hand_played ~= context.scoring_name

[vale grove]

with this the joker doesnt gain anything

[slim ferry]

fuck

[vale grove]

    calculate = function(self, card, context)
      if  context.initial_scoring_step and G.GAME.last_hand_played ~= context.scoring_name then
            card.ability.extra.Xmult = card.ability.extra.Xmult + card.ability.extra.Xmult_mod
        end
        if context.joker_main then
          return {
            Xmult = card.ability.extra.Xmult
        }
        end

    end

this is the full func btw

[daring fern]

What is the goal?

[umbral spire]

oh just curious

[red flower]

i think last_hand_played gets updated to the current hand before that

[daring fern]

Then no, it doesn't exist.

[umbral spire]

Ah alr

[vale grove]

oh really? what other context do I use then

[red flower]

uhh context.press_play and save last_hand_played to the joker and then check if it's the same in joker_main

[vale grove]

hold on how do you save last hand played to the joker

[red flower]

card.ability.extra.last_hand_played = G.GAME.last_hand_played

[vale grove]

i must admit im a little confused on how to actually implement this

    calculate = function(self, card, context)
        card.ability.extra.last_hand_played = G.GAME.last_hand_played
        if context.press_play and card.ability.extra.last_hand_played then
            return {
                
            }
        end
    end

because from what i understand this is the start of what im supposed to do

but how do i do card.ability.extra.last_hand_played == true ?

[umbral spire]

how do i clear all or a specific tag?

[daring fern]

for k, v in pairs(G.GAME.tags) do
    if v.key == 'tag_modprefix_key' then
        v:remove()
    end
end

[red flower]

calculate = function(self, card, context)
    if context.press_play then
        card.ability.extra.last_hand_played = G.GAME.last_hand_played
    end
    if context.joker_main then
        if card.ability.extra.last_hand_played ~= context.scoring_name then
            card.ability.extra.Xmult = card.ability.extra.Xmult + card.ability.extra.Xmult_mod
        end
        return {
            Xmult = card.ability.extra.Xmult
        }
    end
end

[vale grove]

ohhh

i see thank thank you

[umbral spire]

is there any way to see every G. variable?

or is documentated anywhere?

[slim ferry]

https://github.com/Steamodded/smods/wiki/G this has a lot of them i think

[umbral spire]

but not all G.GAME.current_round stuff

thats what i want to see specifically

also what exactly is G.GAME.played_hands is it the amount of played hands or like the blue number near discards?

[slim ferry]

its the total in the run i thin

used for run stats

[red flower]

look at Game:init_game_object

[slim ferry]

or just

[umbral spire]

?

[slim ferry]

type in G.GAME.current_round. in vscode

and see what comes up

also what are you even looking for

[red flower]

? what

[umbral spire]

in my mods folder i presume?

[umbral spire]

nothing specific

[umbral spire]

nvm

[slim ferry]

i said type it in vscode

and see what comes up

[umbral spire]

where tho

[slim ferry]

like

[slim ferry]

anywhere where you have the lovely dump and smods in the library?

[umbral spire]

ah

[red flower]

i still recommend this

[viscid talon]

hello modding dev i need help with a custom deck

ive been making a ghost deck clone called "holy deck" that functions identically, except it uses sephirots

in order to unlock it, you need to beat ghost deck

here is the code

    key = 'holy_deck',
    pos = { x = 1, y = 0 },
    config = {{ sephirot_rate = 2, consumables = { 'c_hatchet_kether' } } },
    loc_txt = {
        name = 'Holy Deck',
        text = {
            [1] = '{C:green}Sephirot{} cards may appear in the',
            [2] = 'shop, start with a {C:green}Kether{} card'
        },
    },
    unlocked = false,
    atlas = 'CustomDecks',
    loc_vars = function(self, info_queue, back)
        return { vars = { self.config.sephirot_rate, self.config.consumables[4] } }
    end,
    locked_loc_vars = function(self, info_queue, back)
        local other_name = localize('k_unknown')
        if G.P_CENTERS['b_ghost'].unlocked then
            other_name = localize { type = 'name_text', set = 'Back', key = 'b_ghost' }
        end

        return { vars = { other_name } }
    end,
    check_for_unlock = function(self, args)
        return args.type == 'win_deck' and get_deck_win_stake('b_ghost') and true
    end
}```

it comes with an error on line15, saying i was indexing a null value

[red flower]

you have one extra set of {} in config

[viscid talon]

wait where

[red flower]

it should be config = { sephirot_rate = 2, consumables = { 'c_hatchet_kether' } },

[viscid talon]

oo oke

[red flower]

also sephirot_rate wont work in the config like the vanilla ones do, you need to use an apply function

[viscid talon]

orgh true

ok, ive taken a look at vanillaremade and applied it

[vale grove]

with this setup, is it possible ti make the joker display the last played hand?

[viscid talon]

uh oh, new error

[red flower]

not with the ability one, but you can use the g.game one

[red flower]

i just fixed vanillaremade :3

[vale grove]

return { vars = { card.ability.extra.mult, card.ability.extra.mult_mod, G.GAME.last_hand_played } }
'last played hand is {C:attention}#3#{}',
so like this?

[red flower]

you need to localize it but yes

[vale grove]

alright thank you 🙂

[viscid talon]

wuh how

SHUT UUUUUUPPPPP

BURGULAR ATTACK

[vale grove]

<@&1133519078540185692>

[vale grove]

lol

go my jimbos

[viscid talon]

    key = 'holy_deck',
    pos = { x = 1, y = 0 },
    config = { sephirot_rate = 2, consumables = { 'c_hatchet_kether' }  },
    loc_txt = {
        name = 'Holy Deck',
        text = {
            [1] = '{C:green}Sephirot{} cards may appear in the',
            [2] = 'shop, start with a {C:green}Kether{} card'
        },
    },
    unlocked = false,
    atlas = 'CustomDecks',

    apply = function(self, back)
        -- Apply the spectral rate
        G.GAME.sephirot_rate = self.config.extra.sephirot_rate

        -- Apply the consumables
        delay(0.4)
        G.E_MANAGER:add_event(Event({
            func = function()
                for k, v in ipairs(self.config.extra.consumables) do
                    SMODS.add_card({ key = v })
                end
                return true
            end
        }))
    end,

    loc_vars = function(self, info_queue, back)
        return { vars = { self.config.sephirot_rate, self.config.consumables[1] } }
    end,
    locked_loc_vars = function(self, info_queue, back)
        local other_name = localize('k_unknown')
        if G.P_CENTERS['b_ghost'].unlocked then
            other_name = localize { type = 'name_text', set = 'Back', key = 'b_ghost' }
        end

        return { vars = { other_name } }
    end,
    check_for_unlock = function(self, args)
        return args.type == 'win_deck' and get_deck_win_stake('b_ghost') and true
    end
}```

hhmm

[exotic hedge]

💔

[slim ferry]

when blind is selected, gain +3 hands and lose all discards

[viscid talon]

yes

[red flower]

remove the .extra

[viscid talon]

i think i know the issue

o

sephirot_rate isnt defined anywhere

so it has no idea what sephirot rate is

[red flower]

it is

[viscid talon]

:o

how

[slim ferry]

it does that automatically for consumable types

[viscid talon]

hmmm,

ok so

ive redone the code

now it creates 2 kethers instead of just 1

and sephirot cards still dont appear in the store

[red flower]

remove the apply the consumables part

[vale grove]

how does localizing work? i read up on how you do it in zany mad and those jokers but i get this error

[viscid talon]

hmmm, unexpected symbol =

locked_loc_vars = function(self, info_queue, back)

    key = 'holy_deck',
    pos = { x = 1, y = 0 },
    config = { sephirot_rate = 2, consumables = { 'c_hatchet_kether' }  },
    loc_txt = {
        name = 'Holy Deck',
        text = {
            [1] = '{C:green}Sephirot{} cards may appear in the',
            [2] = 'shop, start with a {C:green}Kether{} card'
        },
    },
    unlocked = false,
    atlas = 'CustomDecks',

    apply = function(self, back)
        -- Apply the spectral rate
        G.GAME.sephirot_rate = self.config.sephirot_rate
    
    loc_vars = function(self, info_queue, back)
        return { vars = { self.config.sephirot_rate, self.config.consumables[1] } }
    end,
    locked_loc_vars = function(self, info_queue, back)
        local other_name = localize('k_unknown')
        if G.P_CENTERS['b_ghost'].unlocked then
            other_name = localize { type = 'name_text', set = 'Back', key = 'b_ghost' }
        end

        return { vars = { other_name } }
    end,
    check_for_unlock = function(self, args)
        return args.type == 'win_deck' and get_deck_win_stake('b_ghost') and true
    end
}```

what am i even doing

[red flower]

whats the code

[viscid talon]

lemme add an end,

oke now it launches

[red flower]

you're missing an end,

[viscid talon]

it works!!!!

[red flower]

oh oops i was scrolled too high lol

[viscid talon]

yee i just fixed it

[vale grove]

            text = {
                "If your hand played isn't the same as last played hand",
                'gain {C:mult}1{} Mult, if you don\'t lose it all',
                'last played hand is {C:attention}#3#{}',
                '{C:inactive}(Currently,{C:mult}+#1#{}{C:inactive)){}'
            }
        },
        atlas = 'Jokers',
        pos = { x = 4, y = 1 },
        config = { extra = {
            mult = 0,
            mult_mod = 1
        } },
        loc_vars = function(self, info_queue, card)
            return { vars = { card.ability.extra.mult, card.ability.extra.mult_mod, localize(G.GAME.last_hand_played, 'poker_hands')  } }
        end,
calculate = function(self, card, context)
                local reset = true

    if context.press_play then
        card.ability.extra.last_hand_played = G.GAME.last_hand_played
    end
    
    
    
    if context.joker_main then
        if card.ability.extra.last_hand_played ~= context.scoring_name then
            card.ability.extra.mult = card.ability.extra.mult + card.ability.extra.mult_mod
        end
        return {
            mult = card.ability.extra.mult
        }
    end
end
}

this is is obviously with the faulty localize

[viscid talon]

thank youuu

[red flower]

have you tried G.GAME.last_hand_played or "High Card"

[vale grove]

in the loc_vars return{}?

[red flower]

in localize

[vale grove]

no

lemme see

[vale grove]

this just displays error

previously it would crash my game if i hoverd over it so its an improvement XD

[viscid talon]

how do i add text here saying smth along the lines of "beat ghost deck to unlock this deck"

nvm it somehow unlocks after winning a run on any deck LMAO 😭

[vale grove]

nvm got it fixed

[rigid solar]

Im having issues loading a sticker, specifically the tooltip and badge
I've added its name in misc.labels and a description in descriptions.Other, yet it doesn't display either the tooltip or the badge when hovered over, does anyone have an idea as to why?

[vale grove]

oh yeah one more questoin now that youre here, is it possidble to make a joker change the language?

[red flower]

possible yes, no idea how sorry

[vale grove]

okay okay, ill have to do some more research into how then

[rigid solar]

nvm ignore this it was an issue in how i was loading it

Ok new problem
I used this to define that my sticker can only be applied on jokers, and yet hum
what am i doing wrong here

is it because the rate is 1? i just set it to 1 to test
edit: no it's not that

[red flower]

whats the full code

[red flower]

should apply is overriding all the defaults

[rigid solar]

oh

if i have should_apply then it doesn't read sets?

[red flower]

yeah

[rigid solar]

kinda weird but ok, i already found a workaround anyway

[red flower]

you need to call the original as well

[crystal perch]

is there a way i can get specifically the new cards drawn after discarding in a list?

i know i can just scan the whole hand before and after discarding but i want to know if there's a better way

[slim ferry]

set a flag in context.discard

and then check in context.hand_drawn

for the drawn cards

[crystal perch]

like give a flag to all the cards in hand when you discard, when heck for the cards without the flag in hand_drawn?

[slim ferry]

put a flag on the joker

to check if the draw came from a discard

[umbral zodiac]

@broken rivet it still crashes w/ this and im so clueless

its only modifying p_centers 🥀

[broken rivet]

try commenting out the entire hook

[umbral zodiac]

i did

it didnt crash without the hook

[broken rivet]

ok what the fuck

did the commit before that do anything weird

[umbral zodiac]

ok it appears modifying the function at all is causing it to crash Lol

im going to do some debauchery and see what happens #brb

also sorry but i am going to kill valk_censored_loc_vars because i really dont think anybody is going to use it and it just kinda adds to the lack of clarity anyway

[broken rivet]

fair

it's fairly niche anyway

i feel like the other half shouldn't break anything though

[umbral zodiac]

also im going to obliterate pseudorandom because its visual anyway

[broken rivet]

also fair

i really should've just used math.random

but pseudorandom_element was convenient

[umbral zodiac]

fair

[crystal perch]

use pseudorandom

otherwise it won't be consistent throughout seeds

[umbral zodiac]

i know

[tired otter]

tried testing my jokerforge mod but apparently one of my jokers crashes the game??
Went into the code and found this, any ideas?

[broken rivet]

this doesn't have to be

[umbral zodiac]

this is a purely visual thing

it only changes text to a random thing between two options to obfuscate it

[umbral zodiac]

which is something that doesnt have to be consistent

[tired otter]

this is the full error message btw

[umbral zodiac]

how is that getting there dude what

[keen atlas]

🤷‍♂️

[umbral zodiac]

oh

i know

lol, lmao

it doesnt check if [x].loc_vars exists before setting it to the new function

probably being copied over when you start a run when it shouldnt even exist

[broken rivet]

also adding itself to a deck

[umbral zodiac]

might as well add it to decks rather thanadding to everything but decks

as long as it safely adds to decks

[broken rivet]

i guess though decks normally don't have editions

[umbral zodiac]

ya its just like

might as well not have an extra check since it supposedly wont hurt

[broken rivet]

maybe if like parakmi does something weird

[tired otter]

don't wanna interrupt the conversation but does anyone know how to fix this?

[umbral zodiac]

do i just quit modding now this is such a sinful line

[keen atlas]

you have invalid syntax in jokers/thenoise.lua line 71, try checking it

[umbral zodiac]

idk if it even works

[broken rivet]

it's funny though

[tired otter]

@keen atlas already checked and found this

[broken rivet]

what the fuck

[umbral zodiac]

yay it doesnt crash now

at the cost of the worlds ugliest line

[keen atlas]

oh

jf-generated code