💻・modding-dev

[long sun]

is there an alternative to using the front?

[hardy viper]

what is it that you're trying to do anyways

[daring fern]

Yes, SMODS.DrawStep

[long sun]

i wanna make Doug Dimmadome's hat gigantic

[hardy viper]

ah

is the hat a soul sprite

[long sun]

nope, it's the card's front right now

as are all of my Jokers' overlay sprites, except for the Legendaries and Possession

[hardy viper]

that works?

[daring fern]

Yes, but that would break if the joker also happened to be a playing card.

[long sun]

apparently :3

[long sun]

das true

[hardy viper]

is this really a scenario worth supporting

[long sun]

part of the reason why i want this alternative

[daring fern]

Yes.

[frosty rampart]

if you care about cryptid compat then yes

[long sun]

lemme take a look at DrawStep

[hardy viper]

pretty outlandish

[long sun]

still

i have Entropy crossmod so

[hardy viper]

drawstep good yes

[long sun]

i've never used a DrawStep iirc so i'd like some help with the bits i don't understand yet

[frosty rampart]

making the new drawstep should be relatively easy, you can probably just copy the front drawstep and change a few things

[long sun]

grand

[frosty rampart]

(all the vanilla/smods drawsteps are in src/card_draw.lua in smods)

[long sun]

yupyup

thanks for your help :D

/gen

okay question

the func for the front drawstep mentions self.children.front a lot

i assume that was assigned earlier

what do i need to do to assign a new layer?

is that done automatically?

[daring fern]

No, you just create a Sprite and you draw it on the card.

[long sun]

could you give an example?

actually wait i think i've got this

lemme try something

[daring heron]

thanks, tho the stake description says "applies black stake" instead of "applies all previous stakes" now

but still amazing

i'll credit you instead of me since i really didnt do anything lol

[long sun]

how's this looking?

[mystic river]

there's also #1412655729730650262

[rotund sable]

not my fault (i think)

[daring heron]

FUCK 😭

thanks tho

[rotund sable]

literally the same thing

[daring heron]

i tried looking for smth like this but i couldnt

yeah

[daring fern]

No, don't define a sprite every frame.

[rotund sable]

you just stole the idea smh

[long sun]

ah, do i only do that if it's nil?

[hardy viper]

create it in set_sprites probably

[long sun]

;u;

overwhelmed

[hardy viper]

@umbral zodiac noway

[hardy viper]

set_sprites is on the smods wiki iirc

if u wanna read that

[long sun]

where do i define it? on the card, or elsewhere?

do i hook it?

[daring fern]

No, you should hook Game:main_menu then define G.shared_thing = Sprite(...) and use that.

[hardy viper]

normal function on a center

[long sun]

okay i've got two answers now ;u;

oh ya one more question

what should self.T.y be if i'd like the extra sprite's bottom edge to be 1/4 of the card's height from its top?

like

about here

it was said that it's not related to pixel size so i'm wondering what it depends on

if it was pixel size, it'd be ((3/4 * card height) + extra height) / 2 i think (from the bottom)

[hardy viper]

virtual pixels or smth

there's an smods function converting between the two (it is a one liner)

[long sun]

right, goodgood

what's it called? i don't see it in the docs

[distant junco]

yo, ive looked in the utils and documentations and im still not sure, how can i check if a card is destroyed?

[daring fern]

A playing card or any other card?

[distant junco]

playing card

[long sun]

okay i'm very lost 😭

[daring fern]

context.remove_playing_cards

[willow scroll]

this should just make cards that are flipped still show their description right?

or did i forget smth

[long sun]

taking a break

[round lion]

should i avoid declaring local variables in calculate all together

it seems like all the variables are getting reset as soon as any calculate triggers

[mystic river]

you should use local variables whenever you don't need them to persist past an individual instance of calculation, which is usually

[daring fern]

Are you setting them outside of context checks?

[round lion]

yeah no, this returned question already confirmed what i have assumed

if i dont leave a global variable in g.game will i be affected by ramifications as well

[mystic river]

global variables in G.GAME get reset when a new game starts
other global variables generally do not

if you make your own global variable it definitely won't, though it will get reset when the game is shut down

(unless you actively save it, which i don't know how to do)

[faint yacht]

-# As long as it is defined under G.GAME and is not a Card object(?) or a recursive table, it'll get saved.

[round lion]

DUDE I FORGOT EVERYTHING NOW

[mystic river]

if you want something to be saved between games, you can save it in SMODS.current_mod.config["variable name"]
if you also want it to be profile-specific you can save it in G.PROFILES[G.SETTINGS.profile]["variable name"]

[wild berry]

how to get the current tags owned

[daring fern]

G.GAME.tags

[wild berry]

k

[mystic river]

(i imagine you can also combine these and use SMODS.current_mod.config[G.SETTINGS.profile]["variable name"] if you want to)

(though you would want to have a line somewhere before that that says SMODS.current_mod.config[G.SETTINGS.profile] = SMODS.current_mod.config[G.SETTINGS.profile] or {} so you don't go around indexing nil values)

(probably in the first few lines of your main file)

?

well, i didn't say "only do this before saving profiles"

G.SETTINGS.profile is a variable containing your profile number

it's always accessible

well yes
you can add things to it

the game doesn't save it once and then throw it away forever

[wild berry]

is it possible to prevent a joker from repetition from context.repetition_check

[daring fern]

That doesn't exist.

[wild berry]

wait

i meant retrigger joker check

[lofty elm]

Hey guys, I'm having an issue where changing my seed for pseudorandom_element doesn't seem to change the result. Any ideas? I loop a number of times and do a pseudorandom_element with the loop index stapled to the end of the seed so that it would theoreitcally change the result every time, though idk if thats the best way at all

this might be super niche or just a thing ppl know abt pseudorandom_element, no worries if it's weird and you don't wanna troubleshoot for me lol

[wild berry]

use this

[lofty elm]

this'll return a number right? I spose I could do that

[mystic river]

that will return a boolean

[wild berry]

it returns a boolean

true if it passed the probability check

false otherwise

[lofty elm]

oh, no I need to be able to pick from a *table

anyone know what to do for that?

[wild berry]

table[psuedorandom("insertseedhere", 1, #table)]

[lofty elm]

got it, ill try that

[frosty rampart]

there's actually a pseudorandom_element function

[lofty elm]

I was having issues with it that idk how to fix :/

[rocky plaza]

hey
leaving this here if anyone has answers
does anybody here know a formula for converting a Joker's position in T into love2D coords?

[frosty rampart]

pseudorandom_element(table, pseudoseed('insertseedhere')) should return a random element from the table

[lofty elm]

it does, and it changes between runs, but if I run it multiple times in my for loop, even with a different seed each time, it always picks the same item

oh wait

nvm gimme a second

[lofty elm]

i hadnt tried that pseudoseed thing but it didn't seem to fix it :/

[ocean sinew]

Who's gonna tell him???

[frosty rampart]

show your full code

[lofty elm]

I can give you all of it if you want theres just a bunch that I don't think is relevant

for i=1, (num_planets_destroyed) do
    planet = pseudorandom_element(most_played_planets,  pseudoseed('collapse!'))
    G.E_MANAGER:add_event(Event({
        func = function()
            SMODS.add_card{key = planet, edition = 'e_negative'}
            card:juice_up(0.5, 0.5)
            return true
        end
    }))
end

most_played_planets is a table of keys of planets that correspond to your most played hand. So like if theres a tie there's multiple. I've been testing this with them all at 0 so all the hands should be in there

[frosty rampart]

the events don't trigger until after the for loop is done

move the pseudorandom call inside the event

[lofty elm]

oh god im so dumb

sorry for wasting your time ty

[frosty rampart]

no worries, that's why we're here

[magic crane]

i cant find a functions to create my own buttons im currently trying to add some stuff to the main menu and i cant find any functions for making buttons by default

[ocean sinew]

check at UI_definitions.lua

UIBox_button

[magic crane]

thanks

[ocean sinew]

maybe It's what u looking for

np

[hidden notch]

it doesn't seem like context.hand_drawn activates if no cards are drawn
So, I stumbled upon the same Problem - In my case it's for a Blind:
It works similar to Crimson Heart -> Debuff "Something" after a Hand is drawn.
I was thinking this was a Vanilla Bug, but Crimson Heart works perfectly fine!
Then I tested the Vanilla Remade Crimson Heart, and that doesn't work either (when you don't draw any cards)!
Now, it's not the worst thing for my current Blind to have this issue, but I wanted to ask:
Is this intended or should I put in a Bug report (for SMODS)?
-# The very rare direct Ping: @wintry solar

[timid zinc]

Is there a way to make generating a negative card skip the little animation and noise it makes?

[daring fern]

Yes, set the 3rd input to true

[timid zinc]

the 3rd input?

I'm using SMODS.add_card

[daring fern]

Yes, use card:set_edition('e_modprefix_key', nil, true) instead of edition = 'e_modprefix_key'

[lavish elm]

hey what location should sounds be is it assets->sounds or something else and what file type should it be

[daring fern]

assets/sounds, ogg

[lavish elm]

oh ok thx

[wintry solar]

try using context.drawing_cards

[lavish elm]

turns out it looks for resources/sounds

[daring fern]

No, that means the key is wrong.

[hidden notch]

Yeah works but also triggers too early:
Works when trying to Debuff Jokers but when Debuffing Hand-Cards it triggers before the hand finishes drawing. Then again: I could check if the amount of cards exceeds the hand-limit and only then check for this context...
It just seems very... Convoluted?
At the end of the day it helps in my case (Thank you!) but, uh, yeah :D

I kinda liked using context.hand_drawn as "This is the Start of a new Turn" Context

[lavish elm]

can the key be any name?

[daring fern]

No, it means you're using the wrong key when playing the sound.

[frosty rampart]

perhaps do the debuffing in an event? idk

[lavish elm]

SMODS.Sound{
key = "error",
path = "error.ogg"
}
sound = { sound = "error", per = 1.2, vol = 0.4 }
pretty sure there is nothing wrong here

[daring fern]

No, it's modprefix_key

[wintry solar]

I would expect hand_drawn to only trigger if a hand has been drawn, rather than whenever a hand should be drawn. You can also use the drawn_to_hand function on your blind itself

[lavish elm]

oh ok thx for clarifying

[hidden notch]

It's not even about Debuffing at this point, kinda applies to all things regarding that ^^'

[hidden notch]

What about Jokers then - Can they use that Context/Function too?
I get your point, but I'm kinda missing a "Start of Turn" context then ^^'

[long sun]

okay, getting back to this

this code is blatantly wrong, but what have i done wrong?

T is nil when the Sprite is being made

[daring fern]

self is G in the hook.

[long sun]

👍

oh wait yeah i see what you mean

what do i replace the selfs with?

i assume i've put this code in the wrong place

[daring fern]

0, 0, 71, 95

[long sun]

ah awesome ^u^ thanks

what would Y be if the sprite was 1 card height above where it would otherwise be?

would it be 95, or some magical mystery unit?

[daring fern]

Also move the SMODS.DrawStep out of the hook.

[long sun]

it seems to be running before G.phanta_extra_sprites is initialised

[daring fern]

G.CARD_H?

[long sun]

will try

thanks

[daring fern]

Yes, but the func wont run until then.

[wintry solar]

there isn't really a "start of turn" context

[daring fern]

Also you should be running the old function first.

[long sun]

oh true :3

[robust marsh]

How is a card added to the main menu besides the existing one? I kinda forgot that's a thing that can be done and I recently got a cool idea for it

[daring fern]

Hooking Game:main_menu and putting a card on G.title_top

[robust marsh]

ty

[hidden notch]

Also: "drawn_to_hand" seems to work perfectly for my Blind, I didn't even know that was a Thing... Guess I should check the SMODS Code more often, kinda just reading the wiki for functions mostly ^^'

[hidden notch]

Yeah.. That's kinda my point ^^'

[sturdy compass]

We love undocumented functionality 🔥

[daring fern]

‎

[long sun]

i'm struggling to paste my crash log as a file, but it's complaining about phanta_extra_sprites being nil

so it's trying to index into it before it's ready

i'll try nil-checking it

[wintry solar]

we also love documentation thats been there for 9 months

[turbid tiger]

Still the same.

I've tried to write it a bunch of other ways but, I really don't know what i'm doing.

Just copying things from other jokers.

[long sun]

code atm

i don't know what i missed ;u;

[hidden notch]

Browser Cache Moment 💀
Okay actually I got no Idea my Page's being Buggy-Moment

Welp, Ignore silly me then - Sorry to have bothered ya'

[sturdy compass]

I'm with flow on that lmao

browser cache be annoying sometimes

[wintry solar]

when on earth is your cache from, this page has always had the function on

nless I am misreading things

[long sun]

eremel can u help ;u; i'm trying to get a second layer on top of my cards, similar to front, but it's not working

i've never used DrawStep before

[wintry solar]

https://github.com/EremelMods/Ortalab/blob/498cbebaa0226853b76a8d2475717ad393fa5682/objects/curses.lua#L38

[turbid tiger]

realized i replied wrong, here.

[wintry solar]

this is how I do it

[long sun]

thanks ^U^ will take a look

oh ya mine needs to use sprites ;u;

will try your things

[echo parrot]

--in "enhancements.lua"

SMODS.Enhancement {
    key = 'bone',
    atlas = 'TBOJ_enhancements',
    pos = {x = 1, y = 0},

    config = {x_chips = 1.25, extra = { odds = 6} },
    shatters = true,
    loc_vars = function(self, info_queue, card)
        local numerator, denominator = SMODS.get_probability_vars(card, 1, card.ability.extra.odds, 'tboj_bone')
        return { vars = { card.ability.x_chips, numerator, denominator } }
    end,

    loc_txt = {
        name = 'Bone Card',
        text = {
            [1] = '{X:chips,C:white}X#1#{} Chips',
            [2] = '{C:green}#2# in #3#{} chance to',
            [3] = 'destroy card',
        }
    },

    calculate = function(self, card, context)
        if context.destroy_card and context.cardarea == G.play and context.destroy_card == card and
            SMODS.pseudorandom_probability(card, 'tboj_bone', 1, card.ability.extra.odds) then
            return { remove = true }
        end
    end,
}

--in "reverse_tarots.lua"

SMODS.Consumable {
    key = 'reverse_hierophant',
    set = 'Tarot',
    atlas = 'reverse_tarots',
    unlocked = true,
    discovered = true,
    cost = 3,
    pos = {x = 4, y = 2},

    config = { max_highlighted = 1, mod_conv = 'm_tboj_bone'},
    loc_vars = function(self, info_queue, card)
        info_queue[#info_queue + 1] = G.P_CENTERS[card.ability.mod_conv]
        return { vars = { card.ability.max_highlighted } }
    end,

    loc_txt = {
        name = 'The Hierophant?',
        text = {
            [1] = 'Enhances {C:attention}#1#{} selected',
            [2] = 'card into a',
            [3] = '{C:attention}Bone Card',
        }
    },

    can_use = function(self, card)
        return G.hand and #G.hand.highlighted > 0 and #G.hand.highlighted <= card.ability.max_highlighted
    end,

    use = function(self, card, area, copier)
        for i = 1, #G.hand.highlighted do
            G.hand.highlighted[i]:set_ability(card.ability.mod_conv)
        end
        return true
    end
}```

Hey all! I'm new to Balatro modding, so I apologize in advance if this is a really obvious mistake, but I'm not able to get my modded enhancement working. Whenever I try to use the reverse hierophant, I get an error that it "Could not find center 'm_tboj_bone'"

[frosty rampart]

is your mod's prefix exactly "tboj" (including capitalization)?

[echo parrot]

I'll double check, but I believe it is

yes it is

[sturdy compass]

Does the enhancement exist?

[echo parrot]

wym?

[frosty rampart]

it should, it's at the top of the code that they posted

[sturdy compass]

It's been a day for me

Is your enhancements.lua file being loaded properly?

[echo parrot]

would it appear with the enhancements in the collection? or does smods not have that functionality yet

[sturdy compass]

It should yes

[daring fern]

You can remove the use and can_use functions because that's automatic.

[echo parrot]

okay

it's not in there

[sturdy compass]

Then your enhancements.lua is probably not loading properly

[echo parrot]

Thank you! I figured it out, there was a typo in main

[sturdy compass]

u got it

[long sun]

pulling my hair out why won't this workkkkk

[vale grove]

i wanna add to this that the hand has to contain two heart suits, how do i do that?

[cursive gazelle]

Try changing the order

[wispy falcon]

What is context.other_card.sprint?

[daring fern]

Nothing, because it doesn't exist.

[long sun]

it comes after centre though

[wispy falcon]

So it's a self-made thing?

[frosty rampart]

yea it's probably something that a mod added

[wispy falcon]

Would you guys understand this code?

    key = "foxy",
    atlas = "fnaf1",
    pos = {x = 5, y = 1},
    rarity = 1,
    cost = 4,
    unlocked = true,
    discovered = false,
    blueprint_compat = true,
    eternal_compat = true,
    perishable_compat = true,
    config = {extra = {chips = 0}},
    loc_vars = function(self, info_queue, center)
        return {vars = {card.ability.extra.chips}}
    end,
    calculate = function(self, card, context)
        if context.individual and context.cardarea == G.play then
            if not context.other_card.sprint then
                context.other_card.sprint = true
                local c = context.other_card
                G.E_MANAGER:add_event(Event({
                    func = function()
                        if c then
                            c.sprint = nil
                        end
                        return true
                    end,
                }))
            else
                if context.individual and context.cardarea == G.play and not context.other_card.debuff then
                    carde = context.individual
                    card.ability.extra.chips = card.ability.extra.chips + carde.base.nominal
                else
                    return 0
                end
            end
        end
    end,
})```

[daring fern]

No, because you're returning a number.

[wispy falcon]

That's the part that's confusing me too xD

[wispy falcon]

What does context.other_card.base.nominal do?

[gusty iron]

would there be a way to add a 4th blind to the ante via patching?

[frosty rampart]

assuming context.other_card is a playing card, it gets the amount of chips that the card's rank is worth (e.g. 2-10 for 2-10, 10 for jack/queen/king, and 11 for ace)

[wispy falcon]

Got it, thank you :3

[thorny ether]

Weird question but is there a way to make the collection menu of Spectral cards to show 11 cards like Tarot? I made 4 more custom Spectral cards and I dislike how they spill to a new page

I changed create_UIBox_your_collection_spectrals to match the tarot one in UI_definitions.lua but it still displays 9 spectrals per page in game

[rotund sable]

Did you edit lovely/dump

😢

[thorny ether]

Oh dear, let me check

[rotund sable]

You'd have to make a patch

That won't work...

[thorny ether]

I'll make the patch then, was throwing edited file directly to the exe

[frosty rampart]

lovely/dump is where lovely dumps all the vanilla files after they get patched

[thorny ether]

Ooops

[rotund sable]

Please check the integrity using steam

[twilit wing]

something kewl

[true jasper]

this is peak, you should have the mult decrease after the joker is scored tho

[twilit wing]

yeah :p

[weary grail]

giraffe joker

[twilit wing]

why does its neck do that

[weary grail]

noodle

upgraded design

[twilit wing]

i somehow cannot figure this out

is this the wrong context?

[true jasper]

Put that line below the return

[obtuse wraith]

Can the head look like a giraffe?

[twilit wing]

Wait what
Wouldn’t that have the code not execute cause it returns beforehand…..?

[true jasper]

just try it

[twilit wing]

Alright

Wacky

[idle plaza]

I can confirm, that was a nonsense suggestion.

[twilit wing]

how do i do it then

,_,

[idle plaza]

Looks like you already do to me. Final Scoring Step occurs after Joker Main.

[twilit wing]

this does not work tho for some reason

nothing in the if statement triggers, like the message n stuff

[true jasper]

you need a comma after that }

[frosty rampart]

what happens when you get rid of the cardarea check

[twilit wing]

lemme try

[idle plaza]

The Xmult-decreasing line is not a field being set within {}. It is its own line of code. Adding a comma after that particular } would just be a syntax error.

[winter flower]

how do i make it so that if i play a hand with a joker from my mod, this happens

[frosty rampart]

G.jokers.cards is a table of all the jokers the player currently has
iterate over that and check if [joker].config.center.original_mod == SMODS.Mods["mod id goes here"] for any of the jokers

[rigid solar]

Does anyone know a mod that changes the background color on the main menu? I'd like to do that but have no idea how and so I'd like to check how it's done

[red flower]

mine

[twilit wing]

i fixed it!!

[red flower]

https://github.com/nh6574/JoyousSpring/blob/e0cdbd2da1daeb698eb2ebe14693811e8ab59e65/src/general_ui.lua#L782

[rigid solar]

oh neat

[red flower]

hi dilyy

dilllyy

[frosty rampart]

@winter flower just to make sure you see

[winter flower]

im trying to do

[modern kindle]

hi bestie

[red flower]

how are u doing

[modern kindle]

i am doing

still have not resumed working

[winter flower]

i dont know if im doing this completely wrong

[willow scroll]

what would be the best way to change the texture of a joker using based on a run variable using draw?

can i just change the card.config.center.pos?

[winter flower]

like just changing it’s sprite?

[willow scroll]

yeah

[winter flower]

you can use update=function(self,card,dt), then do “if (var) then card.children.center:set_sprite_pos { x = newx, y = newy }”

for soul_pos you can use children.floating_sprite

[willow scroll]

aha i see

[winter flower]

that’s how i did it, and it works pretty well

[willow scroll]

ill just use draw though i think as its for that

[frosty rampart]

no, overwriting the draw function means it stops doing the regular draw function stuff

i.e. things will probably go bad

[willow scroll]

oh, so like also rendering editions?>

[frosty rampart]

no, the editions handle their own drawing. but every joker comes with a default draw function that draws its sprite, and defining your own draw function won't do that automatically anymore

[willow scroll]

well, i have this in the smods joker

and quick testing shows it works fine

so far

[winter flower]

(this will delete literally everything BUT the image/obj you loaded)

[gusty iron]

so im trying to make it so that the small and big blinds are bosses, but they seem to be the same two bosses every ante. any help?

[[patches]]
[patches.pattern]
target = "game.lua"
pattern = "self.GAME.round_resets.blind_choices.Boss = get_new_boss()"
position = "before"
payload = '''
if G.GAME.modifiers.JCJ_bossrush then
    self.GAME.round_resets.blind_choices.Small = get_new_boss()
    self.GAME.round_resets.blind_choices.Big = get_new_boss()
end
'''
match_indent = true

[rigid solar]

Struggled to understand a bunch of stuff, but this is really cool

[paper lava]

is there a SMODS.Enhancements, simillar to SMODS.Ranks and SMODS.Suits?

[gusty iron]

nvm i got this to work :)

[paper lava]

heres what i need it for

basically, im trying to get the number of distinct enhancement types in your deck

[frosty rampart]

you can find out by searching for it in the SMODS github repository, or by going into debugplus's console and running eval SMODS.Enhancements
(no, but i believe vanilla has a table of centers in general that'll include vanilla and modded enhancements? don't remember any more details off the top of my head)

[rigid solar]

Isnt there a get_enhancement function or smth

[frosty rampart]

for your specific goal you can also just go reference paperback, the Grand Strategy joker checks for exactly this

[rigid solar]

And you use it on all cards in deck to retrieve their enhancement and then you can check all unique enhancement

[faint yacht]

SMODS.get_enhancements(card, extra_only)

function SMODS.get_enhancements(card, extra_only)
    if not SMODS.optional_features.quantum_enhancements or not G.hand then
        return not extra_only and card.ability.set == 'Enhanced' and { [card.config.center.key] = true } or {}
    end
    if not SMODS.enh_cache:read(card, extra_only) then

        local enhancements = {}
        if card.config.center.key ~= "c_base" then
            enhancements[card.config.center.key] = true
        end
        local calc_return = {}
        SMODS.calculate_context({other_card = card, check_enhancement = true, no_blueprint = true}, calc_return)
        for _, eval in pairs(calc_return) do
            for key, eval2 in pairs(eval) do
                if type(eval2) == 'table' then
                    for key2, _ in pairs(eval2) do
                        if G.P_CENTERS[key2] then enhancements[key2] = true end
                    end
                else
                    if G.P_CENTERS[key] then enhancements[key] = true end
                end
            end
        end
        SMODS.enh_cache:write(card, enhancements)
    end
    return SMODS.enh_cache:read(card, extra_only)
end

[frosty rampart]

also yea, it would be a lot more efficient to just loop over playing cards and get their enhancements instead of looping over playing cards once per every enhancement in the game

[rigid solar]

^

[paper lava]

i see

good idea

[faint yacht]

...I also have a Joker that does check for unique enhancements too.

If it helps any--

[iron haven]

I wanted to make letter tarots then I changed my mind

[paper lava]

oh hi F

[iron haven]

hi

[stiff locust]

hey chaaat

I'm trying to inject cards into a pool again and it's not working and I don't know why

i feel like it's the fault of :inject()

but idk how to use that function properly

i am trying 1 other thing and if that doesnt magically fix it then im stumped

nevermind it didn't work

function Fusionpack()
    SMODS.ObjectType({
        key = "mjp_fused_pack",
        default = "j_fuse_dynamic_duo",
        cards = {
            ["j_fuse_dynamic_duo"] = true
        }
    })
    for _, v in ipairs(FusionJokers.fusions) do
        ---Dynamic Duo is the default Joker for this pool and does not need to be injected into it again
        if G.P_CENTERS[v.result_joker].rarity == "fusion" and v.result_joker ~= "j_fuse_dynamic_duo" then
            SMODS.ObjectTypes["mjp_fused_pack"]:inject()
            SMODS.ObjectTypes["mjp_fused_pack"]:inject_card(G.P_CENTERS[v.result_joker])
        end
    end
end

this code should be putting every fused joker into the pool but it's not putting any jokers into the pool, and packs using it only create dynamic duo

so I am very confused

[ocean sinew]

if original_mod is nil and ocstobal mod is nil it'll be true

[ocean sinew]

.rarity == "mod_prefix_fusion"

[stiff locust]

the rarity key is "fusion"

why does it need a mod prefix now

[ocean sinew]

cuz every rarity needs mod prefix

[stiff locust]

it never needed that before

[ocean sinew]

cry_epic

cry_exotic

[stiff locust]

I guess that does explain why the code was working, until it stopped working randomly 🤔

[ocean sinew]

probably

[stiff locust]

smods must've updated it to need one

[loud summit]

oof

[stiff locust]

well that doesn't explain why the other one isn't working

i've got one here which is supposed to do it with fusion materials

function Materialpack()
    for _, v in ipairs(FusionJokers.fusions) do
        for _, vv in ipairs(v) do
            local tempkey = vv.Jokers[1].name
            local tempkey2 = vv.Jokers[2].name
            ---Splash is the default Joker for this pool and does not need to be injected into it again
            SMODS.ObjectTypes["mjp_material_pack_pool"]:inject()
            if G.P_CENTERS[tempkey].rarity ~= 4 and G.P_CENTERS[tempkey].rarity ~= "fusion" and tempkey ~= "j_splash" then
                SMODS.ObjectTypes["mjp_material_pack_pool"]:inject_card(G.P_CENTERS[tempkey])
            end
            SMODS.ObjectTypes["mjp_material_pack_pool"]:inject()
            if G.P_CENTERS[tempkey2].rarity ~= 4 and G.P_CENTERS[tempkey2].rarity ~= "fusion" and tempkey2 ~= "j_splash" then
                SMODS.ObjectTypes["mjp_material_pack_pool"]:inject_card(G.P_CENTERS[tempkey2])
            end
        end
    end
end

it has the same problem although all of its if checks are not equals

[stiff locust]

i fixed it

and i don't know how

so i'm gonna not touch it

and it's gonna keep working

[jolly shadow]

Is it possible to blueprint the effect of a joker that the player doesnt have?

[stiff locust]

ive been waiting so long for this idea to be the only good solution

what if you created an invisible joker outside G.jokers and just put it offscreen somewhere

and it runs the effect

[red flower]

look at ortalab pinkprint

[fallow breach]

does anyone know what color is used for the negative effect

on text specifically

[red flower]

dark_edition

[fallow breach]

thank you

[clear ocean]

what's causing the issue?

wait i see why

i forgot to delete that when copying tooth

[unkempt thicket]

I'm attempting to get a variable i set on the creation of playing cards in function Card:set_sprites(_center, _front) or more specifically get_front_spriteinfo(_front) i got a way to pass self(the card) in set_sprites to get_front_spriteinfo though it seems to work different when running, the code is getting the correct atlas and pos that i would like when reviewing it through debug plus though it does not seem to be properly applying them.

[clear ocean]

fixed it 👍 for balancing should it be ante 2 or 3 when it shows up

[daring fern]

‎

[fallow breach]

does G.GAME.edition_rate also affect negative spawn rates?

[daring fern]

Yes.

It affects all editions.

[fallow breach]

is there a way to target a specific edition when modifying the rate

[daring fern]

Hook its get_weight

[fallow breach]

may i please be walked through this because i'm still very bad at hooking

[daring fern]

local oldemodprefixkeygetweight = G.P_CENTERS.e_modprefix_key.get_weight
SMODS.Edition:take_ownership('e_modprefix_key', {
    get_weight = function(self)
        local weight = oldenegativegetweight(self)
        -- change weight
        return weight
    end
}, true)

[fallow breach]

what does take_ownership do?

[daring fern]

https://github.com/Steamodded/smods/wiki/API-Documentation#taking-ownership

[fallow breach]

so then what do i call in the code for the card i want the modification effect to be for?

[daring fern]

No, you do that in the hook.

[fallow breach]

well yeah. but i want a modification to the rates once a voucher is redeemed

how do you go about htat

[daring fern]

if G.GAME.used_vouchers.v_modprefix_key

[lucid owl]

is it easy to retrigger specific effects? would retriggering only effects from seals be difficult?

[daring fern]

No, just patch eval_card and run card:calculate_seal() twice then merge their effects.

And add {message = localize('k_again_ex'), message_card = card} in the middle.

[lucid owl]

should i merge with SMODS.merge_effects() or a different way? my shoddy current implementation isn't working

[daring fern]

Yes.

[lucid owl]

here's the eval_card snippet i patched, seemingly disables red seals and doesn't do anything to others

[daring fern]

No, you should only run it if the joker is found.

[lucid owl]

i had it like that before but had swapped to see if that would fix anything lol, my bad

ohhh wait i see what you mean

[daring fern]

Also it would be SMODS.merge_effects({seals, seal2})

[lucid owl]

like this?

original code is just with the if seals and ... part removed

[daring fern]

No, because Card:calculate_seal can return multiple values.

[lucid owl]

ah i see

[lucid owl]

this works perfectly on red seals, but no other seals have any effect (ignore the missing {message = localize('k_again_ex'), message_card = card}, will get that after)

[daring fern]

Have you tried with purple seals?

[lucid owl]

yup, they only trigger once as well

[daring fern]

Every seal except purple and red seals are hard coded.

[hidden mirage]

is it possible to use calculate on seals (or otherwise) on cards still in the deck?

[lucid owl]

well that's inconvenient, had no clue

[daring fern]

Yes, context.cardarea == G.deck also you have to enable it.

[lucid owl]

hmm, guess i'll have to target seals individually

[hidden mirage]

what do you mean by enable it

[lucid owl]

i guess i could.. retrigger all cards with seals but that comes with the fact that full retriggers are definitely not intended

[daring fern]

SMODS.current_mod.optional_features = function()
    return {
        cardareas = {deck = true}
    }
end

[daring fern]

Do purple seals still trigger if you remove every card:calculate_seal?

Also are you patching both times when card:calculate_seal is called in eval_card?

[lucid owl]

let me check

[lucid owl]

shoot, just one patch

[hidden mirage]

thanks, whats the card area for after a card is been drawn and played/discarded

[daring fern]

G.discard?

[hidden mirage]

👍

[hidden mirage]

is the ? because im ambiguous or youre unsure

[daring fern]

It means that I'm unsure if you mean what I think.

[lucid owl]

patching twice still makes purple seals not retrigger, and purple seals do not trigger if the card:calculate_seal calls are removed

[hidden mirage]

cards that arent "in deck" or in hand

[daring fern]

You mean where cards go when they are discarded?

[hidden mirage]

Yeah kinda but also after played

[daring fern]

Then yes, it's G.discard

[hidden mirage]

Ok thanks

[ashen drift]

how can i make color in a ui change dynamically without having to reload it

[daring fern]

Are you sure? It works fine for me.

[hidden mirage]

how to set main badge text of a seal

[ashen drift]

something akin to ref_table and ref_value in here, except for colours

[lucid owl]

the patching twice part?

[daring fern]

Yes.

[lucid owl]

yeah, i'm only getting one trigger on purple

[daring fern]

What does your patch look like?

[daring fern]

Are both locations successfully getting patched?

[lucid owl]

yup, both are present in the lovely dump

..huh. it was the if seals and part somehow??

works great now...

[daring fern]

Yes, now you just need to run the other seals code manually.

[lucid owl]

yeah, that shouldn't be too difficult. theoretically this should account for most modded seals too, right?

[daring fern]

Yes, unless they are hard coded.

[lucid owl]

also, where would i put that {message = localize('k_again_ex'), message_card = card} at?

[lucid owl]

perfect, thanks for the help

[daring fern]

{seals, {message = localize('k_again_ex'), message_card = card}, seal2}

[lucid owl]

ah, didn't realize it took arguments like that

[hidden mirage]

why does if context.end_of_round and context.main_eval and context.game_over == false then not work, when context.end_of_round does (just with the multiple triggers)

[daring fern]

Is this a seal/enhancement/edition?

[hidden mirage]

seal

[daring fern]

context.main_eval isn't called on playing cards.

[hidden mirage]

so how to prevent multiple retriggers on end_of_round

[true jasper]

Look at blue seal in vanilla remade
https://github.com/nh6574/VanillaRemade/blob/24ee6098f692a58a34d573dec5a86a347c5fd13a/src/seals.lua#L20

[daring fern]

context.playing_card_end_of_round

[hidden mirage]

yep thanks, i looked at the wiki before, dunno why i dint think of that for this, sorry

[naive musk]

wait how do i make a custom suit

[robust marsh]

SMODS.Suit

[naive musk]

what's that

[robust marsh]

https://github.com/Steamodded/smods/wiki/SMODS.Rank-and-SMODS.Suit

[naive musk]

oh

thanks man

[robust marsh]

yuup ofc

[prisma loom]

How much sell value Negative gives to a consumable card?

[true jasper]

doubles it I believe

[robust marsh]

It increases the cost of any card by 5 so the sell value increase is 2 but I could be wrong

[prisma loom]

Wierd but thanks!

[gilded blaze]

I'm gonna assume this is how take_ownership respects other mod's take_ownership

[pastel kernel]

destroying asriel dreemurr creates a negative eternal astro joker, how do i do that?

[daring fern]

Create it in remove_from_deck and check for not G.CONTROLLER.locks.selling_card

[pastel kernel]

remove_from_deck = function(self, card)
  if not G.CONTROLLER.locks.selling_card  then
    SMODS.add_card{ key = "j_busterb_astro" }
  end
end

[daring fern]

Yes, but you would also add edition = 'e_negative', stickers = {'eternal'}

[pastel kernel]

like this?```lua
remove_from_deck = function(self, card)
if not G.CONTROLLER.locks.selling_card then
SMODS.add_card{ key = "j_busterb_astro", edition = 'e_negative', stickers = {'eternal'} }
end
end

(no eternal sticker)

[daring fern]

force_stickers = true

[pastel kernel]

in the same function?

[daring fern]

Yes.

[lavish elm]

G.jokers.cards[i].edition == "e_foil" is this correct?

[daring fern]

No, it's G.jokers.cards[i].edition and G.jokers.cards[i].edition.foil

[lavish elm]

ok so vscode is telling me there .holo and .holographic which one is the right one?

[daring fern]

.holo

[lavish elm]

ok thx alot

[pseudo furnace]

Does creating a custom sticker require a hook on the function when the joker is created?

[daring fern]

No.

[robust marsh]

How exactly would I go about reducing mult/chips/dollars given by all jokers?

[daring fern]

You would change context.other_ret in context.post_trigger

[robust marsh]

alrighty, thank you

[lavish elm]

ease_dollars(card.ability.extra.dollars, true)
return{
message = '+' .. card.ability.extra.dollars .. "$",
colour = G.C.money
}
ok so this does not make money sound when retriggered, why?

[daring fern]

return {dollars = card.ability.extra.dollars}

[lavish elm]

I tried this but for some reason it triggered twice

[daring fern]

Yes, remove the ease_dollars

[robust marsh]

because you're also using ease_dollars alongside it

[lavish elm]

yeah no it triggers twice

no ease_dollars with it

if context.setting_blind and G.GAME.blind.boss then
            return{
                dollars = card.ability.extra.dollars,
                message = '+' .. card.ability.extra.dollars .. "$",
                colour = G.C.money
            }
        end
        if context.end_of_round and context.game_over == false and G.GAME.blind.boss then
            return{
                dollars = card.ability.extra.dollars,
                message = '+' .. card.ability.extra.dollars .. "$",
                colour = G.C.money
            }
        end

[daring fern]

No, it's just return {dollars = card.ability.extra.dollars}

No message and no colour

[lavish elm]

oh ok thx

how to make the joker give multiple messages with different colors?

message = '+' .. card.ability.extra.chips .. " Chips",
message = "+" .. card.ability.extra.mult .. " Mult",

[daring fern]

return {mult = card.ability.extra.mult, chips = card.ability.extra.chips}

[lavish elm]

then what is the difference between mult_mod and mult etc

[manic rune]

mult_mod, xmult_mod, chips_mod dont come with messages by default iirc

[lavish elm]

so does their non mod counterparts

[manic rune]

no, mult, chips, etc have messages by default

[lavish elm]

oh wait my my iletrate brain didn't notice the don't in the first message my bad

[robust marsh]

sorry for bothering you but I'd like to ask if you know what I should be changing in other_ret?

[daring fern]

Do you want all mult and chips and dollars or just ones that comes from jokers?

[robust marsh]

just the ones coming from jokers, so i'd assume i have to alter context.other_ret.jokers but again i'm not sure how to do that properly

[daring fern]

if context.other_ret and context.other_ret.jokers then
    for k, v in pairs(context.other_ret.jokers) do
        if type(v) == 'number' then
            context.other_ret.jokers[k] = reduce(v)
        end
    end
end

[robust marsh]

thank you !!!!

[wispy falcon]

How do I check if a set is fully unlocked?

[daring fern]

local unlocked = true
for k, v in pairs(G.P_CENTER_POOLS.Set) do
    if not v.unlocked then  
        unlocked = false
        break
    end
end
if unlocked then
end

[wispy falcon]

What specifically does this do? Just so I understand that

[daring fern]

It loops through the set checking if they are not unlocked, if they aren't it will set unlocked to false

[wispy falcon]

Do I need to clarify a specific set? I want to check for my consumable type

[daring fern]

Yes, change Set to the key.

[vale grove]

i have this currently and the joker functionally works great but i just have one issue,
the value up visual effect happens on the card instead of the joker

does anyone know why this is happening?

[daring fern]

message_card = card

‎

[vale grove]

when i run this i get that error

does anyone know why

[daring fern]

Firstly, use SMODS.add_card, Secondly, it takes a table.

[vale grove]

whats a table in this context?

[loud summit]

{ key1 = "value1", key2 = "value2" }

[vale grove]

oh like that

where would i apply that here?

what i want it to do is a have a 50% chance to summon itself back into your deck

[loud summit]

SMODS.add_card { }

its syntax sugar for calling a function with a table

[loud summit]

first of all, probability values are supposed to be config values and not hard coded

so things like oops all 6 can modify it

[vale grove]

uh-huh

i was thinking of asking how to make it unaffected

bcs it could create an infinte money glitch

but then i realized i can just set its sell value to zero

[loud summit]

lol

[vale grove]

wait so are they key's the outcome or the jokers?

[loud summit]

keys?

[vale grove]

bcs if so wouldnt i just need key1 ="goochelaar"

[vale grove]

well yeah but the keys stand for something dont they?

i give my goochelaar the key "goochelaar" to later identify it as such

[loud summit]

the keys are kinda parameters to the add card call

[daring fern]

No, that's the entire point of the function.

[loud summit]

look at the smods docs

[loud summit]

what

[red flower]

they can be hardcoded, the function modifies them

[vale grove]

im hearing so many things at once

[loud summit]

yea i mean it should be a config value instead of a hardcoded

[red flower]

yes and i mean that they dont need to

[loud summit]

and also using a loc_var for the numerator and denominator

[vale grove]

so what am i supposed to do to fix this...

[red flower]

you need to fix the create card bit like candycane said

[vale grove]

so use a table?

[red flower]

yes

[vale grove]

bcs im still kinda confused about what keys are

i thought they were just labels

so you can call it later

[red flower]

keys and values: https://www.reddit.com/r/lua/comments/3wgnu7/understanding_keyvalue_pairs/

add card usage: https://github.com/nh6574/VanillaRemade/wiki#jokers-or-consumables

[loud summit]

tables are usually reffered to as key/value pairs

[vale grove]

idk if anyone here is familiar with java but is a table just a form of collection

like an array

or array list

[red flower]

it's more like a map or dictionary

[vale grove]

hmm

[red flower]

that can also act as an array

[vale grove]

it just seems so counterintuitive to create something like that for one value

and im not insulting you or candycane you guys are probably correct

it just seems so weird in my mind

[red flower]

it's so it's easier to get all the arguments

[loud summit]

lua is weird (it doesnt really have classes either)

[red flower]

if not then this would lead to SMODS.create_card("Joker", nil, nil, nil, nil, nil, "e_negative", nil, ...)

[robust marsh]

Alright so I finally have a somewhat functioning mechanic which makes it so jokers are half as effective (mult, chips, etc. are reduced by 50%). How would I make their localization reflects this

[vale grove]

it feels more refreshing to learn than java thats for sure

idk why my college says you dont need programming experience yet also expects you to get a fairy decent mastery over it and more in a year

[loud summit]

fun

[vale grove]

real

what is fun tho is balala modding

having a blast just coding random things

[loud summit]

yeahh

[loud summit]

all this because lua doesnt support named arguments lmao

[daring fern]

You can't.

[robust marsh]

alright, i can think of something else

[vale grove]

this is currently how it looks and i get this error

[loud summit]

what line is the error on

[vale grove]

this lol

[loud summit]

also youre trying to access center but you defined calculate with "card"

[loud summit]

wait whst

[vale grove]

I've had that once before

or something similar

it was just a minor issue in the code that time

[vale grove]

so I need to add center in my calculate?

[loud summit]

no

add_cardi think requires "set" to be defined

so set set to "Joker"

[vale grove]

so it needs a type?

[loud summit]

you give a set argument to add_card

[vale grove]

adding just set = "joker", still gives the same error

[daring fern]

No, it only needs a key.

[daring fern]

It's j_modprefix_key

[vale grove]

OH UR SO RIGHT

[loud summit]

? oh

[vale grove]

i completely forgot my prefix

[loud summit]

sorry

[vale grove]

nah dw abt it

you helped plenty

one more quick question then ill fuck off (for now)

how do you set sell value

bcs i need this guy to be worth 0 to prevent infinite money lol

[loud summit]

hang on ill check necromancer

[daring fern]

Hook Card:set_cost

[loud summit]

ok so use a local var to save the add_card return var

[loud summit]

no they mean the card they created

i think

[vale grove]

uh

i mean

both work tbh

im not picky XD

[loud summit]

hooking it would set the sell value on the joker itself, not the one it created

[vale grove]

i must admit i dont know how hooks work tho

[vale grove]

ik ik im just saying it doesnt matter that much

[loud summit]

???? whicj do you want to have 0 sell value

the joker itself

or the joker it creates

[vale grove]

ig the one it creates

maybe ill change it later for balancing

but i do like ur idea more for now

[loud summit]

right so save the return value to add_card in a local variable

and do var.sell_cost = 0

[vale grove]

i must admit im a little confused

do i create a return on my if that has the variable?

[loud summit]

local card = SMODS.add_card...
card.sell_cost = 0

[vale grove]

ohhhh

thats interesting

[loud summit]

yea u can see add_card returns the card it created (because the definition ends with -> Card) and cards are also just tables

[vale grove]

i know i probably seem stupid its just so different from what im used to with java

[loud summit]

fair, lua is a lot more fast and loose lol

[long sun]

getting back to Doug Dimmadome again

[vale grove]

im used to everything being a alot more complicated so having things go so smoothly is a first

[long sun]

i've reverted it to what it was before, but commented out the new code

[vale grove]

also where am i supposed to enter that

bcs my mind insctively went to the if statement

bcs thats where you define the SMODS.add_card

but that gives an error

[loud summit]

yeah right below

what error

[vale grove]

so i was right

[loud summit]

waitwait

did you delete what you originally had with SMODS.add_card

[vale grove]

wdym what i originally had?

i did what mr seals on everything said

which was add the J_prefix_ before my joker

okay why does it dothat

[loud summit]

send your current code

[vale grove]

J _ prefix _

MF

[daring fern]

No, it would do any card.

[vale grove]

the error is on line 392 now

bcs i did smth unrelated to this issue

[loud summit]

nnno

[daring fern]

No, hook Card:set_cost

[vale grove]

capital C?

[loud summit]

do local card = SMODS.add_card { key = "j_YA_Goochlear" }

[daring fern]

Yes.

[vale grove]

oh like that

[vale grove]

but thats just a code convention no?

[loud summit]

why would you do that tho

[daring fern]

So it stays at 0

[loud summit]

@vale grove does it matter if the jokers sell value can be increased after being created

[vale grove]

yes

quite alot

bcs this guy is basically lucky cat

but for sell value

[loud summit]

oh

[vale grove]

and bcs he is a goochelaar (magician in dutch) i just thought it'd be cool to make him do a magic trick to make him reappear lol

and him not getting the abillity to increase his own sell value (after reappearing) makes it kinda pointless

[frosty dock]

then just decrease the copy's ability.extra_value by its current sell cost

[vale grove]

can you define that in an if statement?

[daring fern]

No, I mean it will go back to its original sell cost whenever card:set_cost is called.

[long sun]

okay i'm very lost with the DrawStep shenanigans i'm attempting

i'd like to add a DrawStep to render a sprite over center

the sprite will be referenced by the card via pos_extra and atlas_extra

[vale grove]

wait now i keep getting an error when i just rolled back to a previos version that worked

tf

[long sun]

i'm not sure what the best thing to do is

i've checked Ortalab's curse code but i don't quite get it

[frosty dock]

if context.selling_self and SMODS.pseudorandom_probability(...) then
  local new_card = copy_card(card)
  new_card:add_to_deck()
  G.jokers:emplace(new_card)
  new_card.ability.extra_value = new_card.ability.extra_value - new_card.sell_cost
  new_card:set_cost()
end

I'm thinking something like this. Copy the card being sold instead of making a new one so that it keeps any modifications, and the rest is as I said

[vale grove]

hold on i gotta check why it isnt working

i had a previous working version except for sell value

and now it just goes back to an old error despite to my knowledge not touching any of it

[frosty dock]

I'll also note that SMODS.add_card returns the card being added, so if you want to do anything to the card afterwards, you should save the result of that function call and not the function itself

[long sun]

so, the Ortalab code creates the relevant sprites when it's injected

okay i'm very lost again ;u;

[frosty dock]

this just sets the sell value to 0, so no

[vale grove]

like i had this version

that worked except for

j_ya

on my line of code

[frosty dock]

yeah exactly

extra_value is reduced by the current sell cost of the copy

effectively setting the sell cost of the copy to 0

[vale grove]

like am i not seeing something?

isnt this the except same version

besides

the prefix on SMODS.add_card

[frosty dock]

did you try what i sent?

[vale grove]

im first trying to get my copying to work in general

i mean i could

[frosty dock]

i mean i suggested you copy the card in a different way..?

[vale grove]

oh i didnt really look at it yet

i was too busy trying to figure this out

ill see if that works

im still so confused

bcs i was asking abt sell value bcs the copying worked

but now it doesnt anymore

oh yeah that works

[long sun]

so i was gonna put all of the extra sprites into a list, but i can't do that if i want them to be animatable

[vale grove]

thank you mr smods

[frosty dock]

how do you know it doesn't work?

[long sun]

(wait no maybe i can)

(trying something)

[vale grove]

well i got an error when selling it with oops all sixes

lol

[frosty dock]

oh well lol

[vale grove]

but

[frosty dock]

maybe you didn't save

[vale grove]

this works

[vale grove]

i did multiple times

but

it doesnt matter anymore

bcs this now works

thank you

im also kinda proud of the concept

i think a lucky cat for sell value is very fun

[frosty dock]

yeah it's a fun idea

maybe you should add a message when it reappears though

[vale grove]

ohhh

that is a very fun idea

and a sound

yeah youve committed me to this

im looking up a magic smoke sound

[frosty dock]

-# and make the reappearing part also incompatible with blueprint unless you want it able to give duplicates?

[long sun]

what does this crash mean?

[vale grove]

i already gave it non blue print compatible didnt i?

[frosty dock]

you need to specify and not context.blueprint, which you did for the first effect

[vale grove]

yeah just checked it doesnt dupe the ability

OH LIKE THAT

LOL

well thats fixed

i hope

[long sun]

okay self.sprite seems to be nil

i don't get it

[vale grove]

another thingy im realizing now

[vale grove]

it still gets destroyed by cards like ceremoinal dagger and madness

now i did some digging and changed the context to "getting sliced"

but that still makes it get destroyed

[frosty dock]

you can use context.joker_type_destroyed and context.card == card to catch all instances of it being destroyed

[vale grove]

currently using this still makes it get destroyed

with a oops all sixes

[red flower]

what's the goal here again?

[vale grove]

to make it copy itself when getting destroyed by madness or ceremoinal dagger

this works just fine

[frosty dock]

whoops, i gtg

[red flower]

why dont you do all this in remove_from_deck

[vale grove]

ill see how that goes

i kinda forgot that was a command i could do lowk

[vale grove]

that still makes it get removed

i think the issue lies in that its trying to copy the card that no longer exists

[red flower]

i dont understand what you mean by this

[vale grove]

when i run that code

having it in my deck get destroyed by dagger

with an oops all sixes

doesnt make it reappear

[frosty dock]

might be that getting_sliced is set at that timing? idk

try adding new_card.getting_sliced = nil, but I'm not positive that's it

[vale grove]

which should be 100% with oops all sixes (as it does with selling)

[red flower]

try what aure said but also show me the code you tried

[vale grove]

this is what i tried last

[vale grove]

im about to try this

[red flower]

it's not a context

[vale grove]

where do i implement this

[frosty dock]

with joker_type_destroyed, just throw it at the end of the if block

[vale grove]

ohhh

[long sun]

so with reference to this crash:
engine/sprite.lua:149: bad argument #3 to 'setColor' (number expected, got nil)

this is causing it

[vale grove]

so throw this up there with my loc_vars

no that doesnt make sense

[long sun]

but self.children.phanta_extra.sprite is not nil

so how could it be crashing??

wha

[daring fern]

Things in card.children are drawn automatically.

[long sun]

oh, oh i see

lemme remove that then

is that better?

or do i need to remove more

[red flower]

remove_from_deck = function(self, card, from_debuff)
    if not from_debuff and SMODS.pseudorandom_probability(...) then
        local new_card = copy_card(card)
        new_card:add_to_deck()
        G.jokers:emplace(new_card)
        new_card.ability.extra_value = new_card.ability.extra_value - new_card.sell_cost
        new_card:set_cost()
    end
end

you should also remove the selling self stuff for this

[vale grove]

i should remove the selling stuff bcs this works the same is what ur saying right?

[red flower]

yes this works for all forms of removal

[long sun]

okay this can't be right 😭 (cards removed so i could see behind them)

i don't know why The Riddler's specifically is rendered twice and also massive

[vale grove]

oh yeah that works, thanks twin

[daring fern]

What is the goal?

[long sun]

render the extras on top of the centers normally :3

they were fronts before this

[static valley]

quick question. is there a way to keep track of which jokers you've sold or destroyed during a run?

[daring fern]

Why are you drawing the sprite twice and setting tilt_shadow to 0.6 the first time?

[long sun]

ortalab did the same

[daring fern]

No, the shadow_height is nil instead of 0 on the second one.

[long sun]

oh ;u;

[daring fern]

Also you should be drawing it on card.children.center

[long sun]

i missed that, i didn't copy and paste it

ohhhh true

omg i'm so close

i just need to fix the thing with the Jokers on the Doug Dimmadome page and i'm done

[vale grove]

on this

im trying to make a silly sound effect play when it happens

is this not how to do it?

or does it require a message

[frosty rampart]

indent your code

[long sun]

here's my code now

[daring fern]

Yes.

[frosty rampart]

thank you

[daring fern]

Also remove_from_deck doesn't take returns.

[frosty rampart]

anyway if you want to play a sound without a message, use the play_sound() function instead of returning a sound

[vale grove]

thats what i was thinking

[vale grove]

no idm that

but

[vale grove]

how do i play it inside of this then?

[daring fern]

play_sound('modprefix_key')

[vale grove]

and message?

[red flower]

SMODS.calulate_effect({message = "message"}, card)

[frosty rampart]

and if you're doing that then you can put a sound in that table in the calculate_effect call

[long sun]

is this just a rendering issue balatro has ;u;

[vale grove]

and message colour to that?

[daring fern]

What is the issue?

[frosty rampart]

the table in a calculate_effect call is pretty much identical to a table that you can return in a calculate function

[long sun]

hold on lemme grab a screenshot

[vale grove]

i see ty

[vale grove]

for some reason this works

but when i add a colour

it breaks

[red flower]

does G.C.WHITE exist

[frosty rampart]

it should

[vale grove]

this tells me it does

[robust marsh]

    calculate = function(self, back, context)
        if context.post_trigger then
            if context.other_ret and context.other_ret.jokers then
                for k, v in pairs(context.other_ret.jokers) do
                    if type(v) == "number" then
                        context.other_ret.jokers[k] = reduce(v, k)
                    elseif type(v) == "string" then
                        context.other_ret.jokers[k] = reflect(v)
                    end
                end
            end
        end

How would i check for a specific edition in my deck's calculate? I've tried a few things but yeah idk atp

[red flower]

what does it do with the color

[vale grove]

wait nvm

i might be stupid

i was thinking abt sound

[daring fern]

Edition on what?

[vale grove]

i dont think the message works either lemme try

[robust marsh]

jokers

[vale grove]

yeah message doesnt work either

[daring fern]

if context.other_card and context.other_card.edition.modprefix_key

[robust marsh]

godsend, thank you

[red flower]

what doesn't work? it doesn't appear?

[vale grove]

it crashes

[red flower]

then send the crash!!!

[vale grove]

mb twin

[long sun]

yeah i have no idea what's causing this ;u;

[long sun]

typo

[robust marsh]

calulate

[vale grove]

alr

i might kms

[long sun]

do not do that

i hate it when people joke about that

[red flower]

dont trust anything i type because my keyboard is not working

[vale grove]

then i will not do that anymore

[long sun]

thanks :D

[vale grove]

np

idk what people are/aren't okay with so if you tell me ill make sure to respect ur boundaries

[long sun]

respectable! ✨

[long sun]

i reformatted things and now the extras aren't being rendered, do you see why?

(ignore the reference to v here, i forgot to fix that)

wait i'm actually such a klutz omg

i forgot to remove the big if statement 😭

okay wait the big sprite issue isn't a problem with Dimmadome

it happens with all of them

weird, removing the dissolve shader does nothing to that

so something else is rendering them

[daring fern]

Have you tried not putting the sprite in card.children?

[long sun]

oh wait that renders them automatically right

lemme try that

wait that fixed it :D!!!!

tysm omg

one more thing, why isn't the T being applied?

[note dimmadome's hat is not scaled, and not repositioned over his head]

do i have to do something other than setting the X, Y, W and H in Sprite()?

[daring fern]

Yes, the first 2 inputs are where the sprite itself is located, the sprite on the card will be directly on the card, you need to offset it.

[long sun]

i thought i already set the first two inputs

0, Y

do you mean elsewhere?

OH wait i see what you mean

how do i set those?

[floral marsh]

what should I hook to modify the final score of each hand (without a joker/voucher/blind)

[red flower]

you can use the mod global calculate

[floral marsh]

wha

like a whole calculate outside of any tables

[red flower]

gimme a sec that my keyboard isnt letting me copy the link lol

[red flower]

yeah

[daring fern]

The ninth input offsets the y

[red flower]

ctrl + f calculation https://github.com/Steamodded/smods/discussions/919

[long sun]

do you mean in the diffuse shader line?

ah ye it seems to

lemme add that ^u^

[daring fern]

No, in the draw_shader

[long sun]

ya das what i meant

[floral marsh]

so I suppose SMODS.current_mod.calculate = function(self, context)

[long sun]

like so, then?

[daring fern]

No, the seventh input is rotation.

[long sun]

ah

is it the sixth then? do i pass that in as a table?

mm, no, it seems to be a number value

can i scale just the Y axis?

[daring fern]

Yes.

[long sun]

how may i do that?

[daring fern]

Change the T.h, VT.h and CT.h of the sprite?

[long sun]

👍 will try

little tiny sprite :3

also my jokers with animated extras have had their animated extras stop animating for some reason

code

[lavish elm]

how to do ^ mult?

[daring fern]

Install Talisman and return {emult = number}

[lavish elm]

ok nvm I don't wanna add more dependencies

[frosty rampart]

if you have cryptlib as a dependency (I think I remember that being something we helped you with before), I think it also implements emult in the same way

[wild berry]

how can i forcefully draw specific cards into hand regardless of hand size

[frosty rampart]

SMODS.draw_cards(x) should draw x cards to hand

[daring fern]

‎

[lavish elm]

nah I removed it

seals helped me implement the thing I wanted without cryptlib

[lavish elm]

how to change the weight of rarities when a joker is present?

[red flower]

change G.GAME.<rarity in lowercase>_mod

[long sun]

why is the extra so small 😭

i cannot figure this out

[lavish elm]

it is giving me an error

if context.card == card then
            return{
                card = card,
                G.GAME.common_mod = 0.5

            }
        end

[red flower]

dont put it in the return

you dont need a return at all

context.card == card is also probably not correct

[slim ferry]

cryptlib has it too

exact same return

[static valley]

        if context.cardarea == G.play and context.individual and #context.full_hand == 1 then
            if G.GAME.current_round.hands_played == 0 or G.GAME.current_round.hands_left == 0 then
                context.other_card:set_seal("comedy_smiley_seal", true, true)
                return {
                    message = "Imbued with Chaos",
                    card = card,
                }
            end
        end

getting the error "attempt to index a nil value"

[slim ferry]

send log?

[lavish elm]

as I said I removed it

[slim ferry]

oh okiay

just steal cryptlib 🧠

[slim ferry]

could you just send the entire lovely log

[slim ferry]

hm

that doesnt even have a crash in it

wierd

though it had something about an smods patch failing, maybe somethings with your smods installation?

[static valley]

do you think i might need to reinstall Smod

[slim ferry]

is your smods nested

[static valley]

no

[slim ferry]

hm

i imagine its just fine then i guess?

idk what else the issue would be though

[long sun]

took at look at Paya's Terrible Additions' Cyan joker, but i'm getting a stranger bug now

the extra moves faster than the center, when being dragged

the scale is now fine though, so there's that

wait i think i see the issue? maybe?

[slim ferry]

why are you even setting Y actually

you dont use it at all

[long sun]

i'm setting Y because the sprite should be off the card if the Joker is Doug Dimmadome

however i neglected to actually assign that