💻・modding-dev

[cobalt arrow]

hmm smart

yesss that was the problem

[shut crater]

the only thing this doesn't account for is the loc_vars text, which I have no idea how stencil displays the correct current value or if it just does that calculation in both functions

and I'm not at home rn so I can't check the source

[cobalt arrow]

oh no problems

you're help was wonderful

i'll try your idea of the loop and counter

[shut crater]

yeah lmk how it goes

[cobalt arrow]

o7

[high sinew]

how do i get tarots to spawn on specific conditions

[digital niche]

is there a documentation for unlock_condition?

[unkempt thicket]

in_pool

unlock condition is like a condition for discovery, in_pool is a condition for spawning

[digital niche]

yeah we want a condition for discovery

is there a place that explain unlock_condition better?

[bold sleet]

Can someone help me getting the localize function to actually do shit?

[unkempt thicket]

I think that goes outside of config, and unlocked has to be set to false

Also the thing itself is the function you don't need to add local function

[red flower]

{type = "name_text", set = G.consumeables.cards[1].ability.set, key = G.consumeables.cards[1].config center.key}

[bold sleet]

yummers

[placid star]

is there a way to see these extra values with debug plus?

[bold sleet]

now time to figure out how and why it works

[faint yacht]

eval inspectDepth(table)

[rough furnace]

If you wrap the given table in either inspect or tprint they show more

[digital niche]

how do i check for a enhancement in can_use in a consumable

[rough furnace]

I think I show all keys on the top level object so just indexing into it works too

[red flower]

if localize gets a string it grabs it from misc.dictionary, else you need to give it a table with the parameters you need
"name_text" gives you the name of the object as a string ("name" gives you the UI table), key and set are self explanatory

[red flower]

in the deck or in the selected cards?

[digital niche]

in the selected cards

i want to select 2 cards and if both have "bonus" i can use the card

[red flower]

iterate through G.hand.highlighted and check for SMODS.has_enhancement(card, "m_bonus")

[digital niche]

oh wait, forgot the card

[digital niche]

like that?

[shut crater]

that checks if the player has highlighted 2 cards and if the consumable has the bonus enhancement

to check if the highlighted cards have the enhancement you would need to loop over G.hand.highlighted and check each highlighted card for the enhancement

if either one does not have the enhancement, you can return false right away. If you make it through the entire loop without seeing any issues, then you return true

[digital niche]

how do i check if the card itself have the enhancement?

if the selected card i meean

[placid star]

how can you find the key of a highlighted joker?

[digital niche]

its my first time trying things arund consumables so im not sure how anything works

[verbal hare]

how can i make a dynamic debuff joker slot

[shut crater]

your loop will probably look something like

for i,v in ipairs(G.hand.highlighted) do
  -- stuff
end

in which case v will store the current highlighted card you're looking at

[red flower]

no

[shut crater]

G.jokers.highlighted[1].center.config.key
I think?

[placid star]

oh i just assumed it wasnt a table tyy

[shut crater]

I could be wrong, I'm not at my computer rn

but that's my instinct

[verbal hare]

i want to make a joker that debuff the joker in the right side, like a blueprint. and when it debuff you can get xmult and shi

[shut crater]

that's tough because there's not a great trigger for when a joker gets moved around

the reason blueprint works is because it doesn't actually care what joker is to the right until calculate gets called

but if you want to update the ui and stuff to show that the card is debuffed then that's gonna be trickier

[old cairn]

i did a similar thing, someone here suggested to use update() to check for a joker to the right every frame and debuff it

if you want the code i'm happy to show it

[shut crater]

that was my instinct but using update sucks lol

[old cairn]

if it works it works i dunno 🤷‍♀️

[rough furnace]

There's worse uses of update in vanills

[shut crater]

yeah no that's definitely the right way to do it I just always feel like I'm doing something wrong if I have to use update lol

[rough furnace]

Listen every steel joker loops over every card in your entire deck every frame

[stark geode]

what for???

[rough furnace]

To count the number of steel cards you have

[stark geode]

ah

why every frame?

[rough furnace]

Its in update

No better place to run it

[stark geode]

huh

[old cairn]

if it didnt it wouldnt update the value in real time which would look a bit weird methinks

[stark geode]

game is wierd

[rough furnace]

It could be much more effinent and just check the two times it reads the value but that's how thunk made it

Its easier to implement

And less likely to have a bug from forgetting to calculate

I've been saying smods should have a lazy update for thing like steel joker

[digital niche]

almost sure i did it wrong

what does the i and the v stand for?

[brisk rose]

literally the variables can be anything, but I think it's 'index' and 'value'

by convention

[digital niche]

so what do i need that i for?

[brisk rose]

it's the index into the table you're iterating over

p sure

but you could name it bob instead of i if you wanted, lol

[placid star]

so this is progress ig, but my joker doesnt get emplaced ito my other jokers card area, but i cant select it anymore(havent patched that into the card area) and as you can see my card areas #cards goes up

[eager pendant]

Is there any way to put HEX("dg0944") in {X:mult,C:white}{} instead of color?

[brisk rose]

I think you might have to do a new color entry to the colors table?

[rough furnace]

Or use one in loc_vars

[eager pendant]

And how do you do that?

[rough furnace]

https://github.com/Steamodded/smods/wiki/Text-Styling

[digital niche]

can anyone help please?

[gusty iron]

Funny idea i had for a consumable:

"Combination"

Select 2 cards of the same rank. Combine their suits.

Examples:

7 of Hearts + 7 of Spades = 7 of Spearts

[red flower]

you kinda want to do the opposite of that

if #G.hand.highlighted ~= 2 then
    return false
end
for _, v in ipairs(G.hand.highlighted) do
    if not SMODS.has_enhancement(v, "m_bonus") then
        return false
    end
end
return true

[digital niche]

my mod have that! didnt start working on bbut will have

[brisk rose]

familiar has dual suits, you probably would wanna use their implementation for compatibility

[brisk rose]

same with you

[digital niche]

ooh, tyty!

[rough furnace]

I is index v is value. They can be named anything, but i/k (for key) and v are pretty standard

[brisk rose]

@unkempt thicket have you considered, if you haven't already, having a ready-to-use sual suit api for people to drop in

seems like a lot of people want to use them

because cards having dual suits. but no, not that way, seems like a nightmare, lol

[placid star]

okay so jokers go in just fine, but they dont appear in the box...

[brisk rose]

why... why are you using a new card area?

[unkempt thicket]

It's implmentation isn't exactly hard, the hardest part is how the sprites for it is setup right now.

Very hardcoded and linear sprite setup

[red flower]

how are you doing it

[verbal hare]

suree thx

how can i make a debuff effect? im still looking for that

[eager pendant]

And what parameters should the function have?

[red flower]

SMODS.debuff_card
https://github.com/Steamodded/smods/wiki/Utility

[old cairn]

it might be a bit complicated but hopefully you can understand it

[gusty iron]

could i possibly get a link?

[brisk rose]

https://github.com/RattlingSnow353/Familiar/tree/BetterCalc-Fixes

also @unkempt thicket I think it's a good idea to move development back to main

oldcalc has no relevence anymore

[unkempt thicket]

I'll make a Pr to do that

[brisk rose]

anyone know what could be causing this?

the uh... enhancement was applied by a consumable from balatro+

[gusty iron]

Also would something like this be possible?

Upgrade Tree Deck:
No more booster packs, but you can do an upgrade tree, which gives you upgrades for either money or upgrade points (im still deciding)

[brisk rose]

possible, yes, but a lot of work

[gusty iron]

ill be willing to put in the work

[red flower]

the booster pack part is easy :3

[gusty iron]

can i get the code for that rq then

[red flower]

5 dollars

[gusty iron]

here

[red flower]

use SMODS.change_booster_limit

[gusty iron]

peak

[brisk rose]

to be clear, what it does is apply a random enhancement and seal to three seleted cards, and destroy 3 non selected cards

I think it worked, but... Silver Deck is a very unusual enhancement

[lucid owl]

this is debuffing every single hand that contains a high card (so all hands) - what the hell am i doing wrong?

this is how SMODS debuffs hands in blinds

so i'm not sure what's going on here

[brisk rose]

@dense crescent idk if this is related to the code of the card or it goes deeper

[lucid owl]

and this just crashes things (i know this is probably not correct at all)

[brisk rose]

  config = { extra = 3 },

  loc_vars = function(self, _, card)
    return { vars = { card.ability.extra } }
  end,

  can_use = function(self, card)
    return G.hand
      and #G.hand.highlighted > 0
      and #G.hand.highlighted <= card.ability.extra
      and #G.hand.cards - #G.hand.highlighted >= #G.hand.highlighted
  end,

  use = function(self, card)
    local enhancement = BPlus.u.random_enhancement("c_bplus_sigil_beast_enhancement")
    local seal = BPlus.u.random_seal("c_bplus_sigil_beast_seal")
    local destroyables = {}
    local destroyed_cards = {}
    for _, card in ipairs(G.hand.cards) do
      if not card.highlighted then
        destroyables[#destroyables + 1] = card
      end
    end

    for i = 1, #G.hand.highlighted do
      local card_to_destroy = pseudorandom_element(destroyables, pseudoseed("c_bplus_sigil_beast_destroy"))
      destroyed_cards[#destroyed_cards + 1] = card_to_destroy
      G.E_MANAGER:add_event(Event {
        trigger = "after",
        func = function()
          if card_to_destroy.ability.name == G.P_CENTERS.m_glass.name then
            card_to_destroy:shatter()
          else
            card_to_destroy:start_dissolve(nil, nil, 1.3)
          end
          play_sound("slice1", 0.96 + math.random() * 0.05)
          return true
        end,
      })
      local i = 1
      for index, card in ipairs(destroyables) do
        if card == card_to_destroy then
          i = index
        end
      end
      table.remove(destroyables, i)
    end

    for _, card in ipairs(G.hand.highlighted) do
      G.E_MANAGER:add_event(Event {
        trigger = "after",
        delay = 0.1,
        func = function()
          card:flip()
          play_sound("card1", percent)
          card:juice_up(0.3, 0.3)
          return true
        end,
      })
    end

    for _, card in ipairs(G.hand.highlighted) do
      G.E_MANAGER:add_event(Event {
        trigger = "after",
        delay = 0.2,
        func = function()
          card:set_seal(seal, nil, true)
          card:set_ability(enhancement)
          return true
        end,
      })
    end

    for i, card in ipairs(G.hand.highlighted) do
      local percent = 0.85 - (i - 0.999) / (#G.hand.cards - 0.998) * 0.3
      G.E_MANAGER:add_event(Event {
        trigger = "after",
        delay = 0.5,
        func = function()
          card:flip()
          play_sound("tarot2", percent, 0.6)
          card:juice_up(0.3, 0.3)
          return true
        end,
      })
    end

    for i = 1, #G.jokers.cards do
      G.jokers.cards[i]:calculate_joker { remove_playing_cards = true, removed = destroyed_cards }
    end
  end,
}

this is the code for the card

[gusty iron]

also do i do SMODS.change_booster_limit = 0

[brisk rose]

is it doing what it's supposed to do and the pools are just wrong, or is it borked?

[verbal hare]

i dont see the debuff effect in game :((

[red flower]

no it's SMODS.change_booster_limit(mod)
mod is probably -2? i never tried setting it to negative so it might not work

[lucid owl]

okay so the formatting is correct, it just seems to think that the argument passed to next() in blind.lua is nil for whatever reason

[red flower]

yeah i answered a similar question the other day
you want hand = string

the docs seem to be wrong or outdated

[gusty iron]

GET OUTTTTT

WE DONT WANT YOU HERE

[lucid owl]

damn, that's so weird lol

[red flower]

did you try what carrie sent?

[lucid owl]

0 won't do anything, it adjusts by whatever modifier, so you can just count the number of booster packs and subtract by that amount

-1 subtracts one booster, 1 adds one booster, etc etc

[gusty iron]

i did -2 and

like

the packs are still there

[red flower]

weird

[gusty iron]

also ill probably make it so you can press rightbracket to open/close the tree, but you can only buy upgrades during the shop

[lucid owl]

fixed this, changed to debuff_hand rather than the base debuff table

[gusty iron]

so uh

any ideas

yeah SMODS.change_booster_limit isnt doing crap

[red flower]

does it work if you set it higher

[gusty iron]

lemme try

[brisk rose]

okay, this is weird, Beat (the balatro+ consumable) seems to only be able to roll Familiar decks as "enhancements"

[gusty iron]

nope

[red flower]

then you might be using it wrong

can i see the code

[brisk rose]

but I got a playcards,cab (like a supercharged standard pack) that had regular enhancements

[gusty iron]

SMODS.Back{
   key = "upgradetree",
    atlas = "Backs",
    pos = {x = 3, y = 0},
    config = {},
    loc_txt = {
        name ="Upgrade Tree",
        text={
          "{C:attention}Booster Packs{} can no longer spawn,",
    "but, theres an {C:attention}upgrade tree{} in the shop."
        },
    },
    loc_vars = function(self, info_queue, center)
        return{vars={colours = { G.C.SUITS["Clubs"], G.C.SUITS["Diamonds"] }}}
    end,
    apply = function(self)
        SMODS.change_booster_limit(-2)
    end
}

[brisk rose]

@unkempt thicket sorry for keepign on pining you, but I have a feeling this might also relate to your mod, saying that it's decks from it that get spawned as enhancements

[red flower]

what if you put that inside an event

[gusty iron]

i tried putting it into a hook too

still didnt work

[red flower]

weird

I'll try it tomorrow to see if something didn't break with smods lol

[unkempt thicket]

There shouldn't be any problem with familiar's decks, they are like any other deck. What's the mod that's causing it called?

[brisk rose]

balatro+ or balatro plus, I posted the code for the consumable in question

[brisk rose]

.

oh, that's even weirder

apperently it's any object from Familliar

not just the decks

[gusty iron]

...suddenly started working for some reason

oh well

time to work on the main portion ive been dreading.

The Upgrade Tree.

[unkempt thicket]

Maybe its way of getting its enhancements has a similar prefix of familiar

[gusty iron]

okay i have 2 ways of doing this, so i want some opinions.

should i:

A - Go the incrimental route, where the upgrade tree has its own currency which generates/gets earned.

B - Have the upgrade tree be based on money

[brisk rose]

it seems to just be doing card:set_ability(enhancement)

[brisk rose]

which idk if is correct

[brisk rose]

.

oh nvm

I see there's a function to grab an enhancement

lemme see what that is

[crisp coral]

the grass route

[gusty iron]

yeah

uh

ill make a forum for upgrade suggestions and the whole mod in general

[verbal hare]

yeye, i think im just bad at this lmaoo

[brisk rose]

the function it calls doesn't seem to exist?

the closest I can find is in utils

[rustic swallow]

anyone know how to make a joker count all cards as non face cards

[daring fern]

Hook is_face

[brisk rose]

am I correct that the code in the consumable won't call this function?

the relevent one with the similar name about a random enhancement

[regal ether]

any reason this doesn't do shit when used?

[rustic swallow]

like how? i make a function that calls is_face?

[red flower]

G.hand is a cardarea
G.hand.cards is the list of cards in the area

[regal ether]

ty

FIRE

[daring fern]

No, you would overwrite it while still keeping the original function.

[rustic swallow]

so i use take_ownership?

[willow plinth]

what is better, card_eval_status_text or SMODS.calculate_effect or are they even the same?

(i know the signature is not the same but to me they seemingly do the same thing effectively)

[daring fern]

No.

[rustic swallow]

then what do i do? im pretty new to coding

[red flower]

calculate_effect does more because it can also calculate other effects but they're practically the same for text
it's just a bit more practical than having to write 'extra',nil,nil,nil etc each time

[willow plinth]

i'm also still struggling with this wiki page https://github.com/Steamodded/smods/wiki/Calculate-Functions

if "card" is mentioned, that means playing cards, jokers, basically everything, right?

[brisk rose]

can someone tell me at least if the error is contrained to balatro+ itself?

[willow plinth]

i would if i had any clue

[brisk rose]

@dense crescent oh you're online, you can help

sorryt hat was a bit extra

[red flower]

yeah playing cards + anything under SMODS.Center is a card

[daring fern]

local oldisface = Card.is_face
function Card:is_face(from_boss)
    -- if joker is present return true
    oldisface(self, from_boss)
end

[willow plinth]

i've scrolled over that contexts page several times, i find it very hard to grasp

slowly i understand small pieces but some mods using this and some mods using that to do basically the same thing is also not helping lol

[red flower]

the best part is that there are undocumented contexts!

[willow plinth]

awesome

[rustic swallow]

to find the joker do i use the key?

[willow plinth]

and it's impossible to inspect because just printing it in calculate spams my logs

[daring fern]

You would use SMODS.find_card

[lucid owl]

unfortunately you'll soon learn that the SMODS documentation is largely very out of date

[willow plinth]

i'd learn much faster if i could print out the whole context in readable speed, any tricks in that regard?

[red flower]

I usually just look for when the context is called in the code

[shut crater]

use events?

[dense crescent]

Can you explain what's the problem?

[brisk rose]

the beast, instead of enhancements, does objects from Familiar, of all things

[rustic swallow]

thank you very much

[brisk rose]

and I can't figure out where the function you're calling to get the enhancement even lives

[willow plinth]

i feel lost with that because there no like "set_context" function, it's just all over the place being passed around in the source code

[brisk rose]

the closest I could find is in here

[red flower]

there is for most of them: SMODS.calculate_context

[willow plinth]

mmmm with that i could indeed ensure one kind of context combination is only printed once

[willow plinth]

oh i should look into smods for the contexts, i was looking at the source code

[red flower]

yeah, smods replaces them for calculate_context most of the time

[lucid owl]

is there a way to give an object an alternate name? i need to change a blind's name if ortalab is present

[willow plinth]

i feel like i also need to take a crash course in lua about order of events/microtasks, i feel like i'm creating race conditions with every line i write

[brisk rose]

I mean... I'm sure there's something you can just wrap in an if statement

[lucid owl]

problem is i need to make sure it's localized correctly in the case of eventual translations

[brisk rose]

but I don't think having blinds of the same name causes anything but minor confusion?

[lucid owl]

and i don't think name changes can be done in loc_vars

[red flower]

they can

return a key and a set (optionally) in loc_vars
idk if they work for blinds tho

[brisk rose]

There's still this though, where it seems more confusing for it to have an alt name, if anything

[stark geode]

for loop is not for looping

[red flower]

pairs instead of ipairs

[dense crescent]

Is there an object with prefix 'm_' in that mod? cause I got enhancements from filtering all Center with prefix 'm_'

[lucid owl]

ah, alright

[flat sorrel]

can't you grab G.P_CENTER_POOLS.Enhanced?

[brisk rose]

will that even work for modded enhancements?

is that why I only got vanillia seals too?

[red flower]

all mod things should be in P_CENTERS

[brisk rose]

i meant selecting for prefix of "m"

[dense crescent]

Yeah I think i'm doing it wrong

[brisk rose]

luckily the actual function you need is much less complex than what you have

[red flower]

yeah all modded enhancements should be there with prefix m_

[brisk rose]

from what I can tell

[brisk rose]

ah, well atm I'm not getting enhancements at all

for some reason

[dense crescent]

Ouch forgot, I hard coded it

[brisk rose]

but instead random objects from familiar, as I've said

which wouldn't have a prefix of m

the familiar prefix is fam

which depending on how you did the string matching I can see the issue

[dense crescent]

not that prefix, center prefix, like all jokers center key start with 'j_'

[brisk rose]

but in three tries, I shoulda got at least one actual enhancement

[brisk rose]

ah nah, i'm getting different types of centers anyway

deck backs and momento cards so far

which is like tarots

[red flower]

how are you looking at the prefix

sorry ive not been following the convo

[brisk rose]

and only deck backs from familiar

[brisk rose]

as I said, the function you call here doesn't seem to exist in the mod files

[brisk rose]

seems to have a different name than the version in utils

[dense crescent]

I think i should use SMODS.poll_seal() and SMODS.poll_enhancement()

[willow plinth]

they are also similar in that they don't return anything, right? so i should be able to carefully replace card_eval_status_text with SMODS.calculate_effect

only weird thing i see often is mods calling card_eval_status_text(card, "extra", ....)
does that translate to the extra table of calculate_effect or can i just ignore it? (as i understood, the extra in calculate_effect is for adding an additional effect)

WHY DO I FORGET TO WRITE WORDS man sorry everyone who needs to read my garbage

[brisk rose]

I think this makes sense? Also, it would give them /different/ random enhancements and seals depending on how you do it, which seems more in line with the point of it, but that's up to you

as it stands all up to 3 get the same

[red flower]

extra in calculate_effect is for that yeah
extra in calc_eval is for making the text background orange iirc

[willow plinth]

ah okay, but i can just include colour in calculate_effect as it seems

[red flower]

yeah

[willow plinth]

calculate_effect wohooooo, card_eval_status_text boooooo

[red flower]

i wish i could make everyone replace create_card for SMODS.add_card

[pearl jacinth]

what happened

[red flower]

you attempted to index local 'res' (which is in fact a boolean)

are you making a mod or just playing?

[pearl jacinth]

making

[red flower]

can we see your code then

[willow plinth]

lmao that was my next question, thanks

[pearl jacinth]

element potassium code

[willow plinth]

just sad that this otherwise goated file doesn't use the newer smods functions https://github.com/Steamodded/examples/blob/master/Mods/ExampleJokersMod/ModdedVanilla.lua

[brisk rose]

I lowkey hate that threads in text channels are a thing

I get the purpose

I just don't like the vibes

[red flower]

i think this was made before better calc lol

[willow plinth]

i've read bettercalc so often in the last two weeks i have no idea what it is, just that it came before me lol

[brisk rose]

gentlemen finish second

[red flower]

they made some things about calculate more straightforward and gave a calculate function to most objects

[brisk rose]

it also means you can't trust mods updated last before newcalc became the standard not to do weird shit

[red flower]

i only started my content mod after bettercalc too so idk much about before it

[willow plinth]

you guys need better names for stuff lol

not that i know any better name but...still

[brisk rose]

hence why I restarted my modpack when I came back after coming to terms with the loss of dozens of mods

took me months, lol

where's @dense jasper when we need him?

[red flower]

@/john aure smods

[hasty mist]

is there a way to change the appearance of a rarity badge on the fly

like

[brisk rose]

(just kidding btw man, I know you've been busy with life)

[willow plinth]

i can't trust any mod, period. i get modders not updating their whole codebase to better_calc...like kino uses a bunch of older stuff, but i get it

[hasty mist]

changing every second or so like the misprint text

[brisk rose]

I mean things that still work are fine to use still

[willow plinth]

yeah right

[brisk rose]

but that's not everything pre newcalc

[willow plinth]

i also mean in general balatro...centers are cards and cards are not just cards but also joker or even more but not always and backs are decks and waahahahahahaahahhaah

[shut crater]

what determines the order of jokers in the collection

[brisk rose]

whenever they load

[pearl jacinth]

the order they were created

[brisk rose]

which can be kinda random sometimes

[shut crater]

annoying but reasonable

[red flower]

if i understand correctly the idea is front = rank/suit, center = ability (enhancement, joker, etc.), back = deck (back of the card)

[willow plinth]

yeah the front thing i actually get when you look at it from a sprite perspective

[brisk rose]

I mean it just uses the naming conventions thunk did

all of the things do

[red flower]

[hasty mist]

actually, is there anything that lets you freely manipulate badges? or is that hardcoded

[willow plinth]

oh and centers are basically the "heart"/"core" of the card....maybe i get it slowly

[hasty mist]

like, the rarity badge

i want to animate it

[shut crater]

anything can be freely manipulated if you're determined enough

and know how to patch

[red flower]

for most objects there is iirc idk if rarities have access to it the docs don't seem to mention anything like that

[brisk rose]

the problem tbh is thunk used a lot of the same words for different things

like I think center means something different depending on context

[willow plinth]

and different words for the same thing

[shut crater]

context also means something

[red flower]

center usually means ability

[willow plinth]

aaahhhhhhh get me out of here

[brisk rose]

that's a lua thing possibly? Or a love2d thing?

[hasty mist]

yeah i tried searching this channel and couldnt find anything either

[brisk rose]

that's also the issue, there's 4 layers here

smods, balatro, love2d, lua

[shut crater]

we need more

quick, someone add an api

[brisk rose]

and your mod is another layer

[red flower]

talisman is the worst layer

[shut crater]

lol

[willow plinth]

my mod is layers and layers of stinking shit added on to it mmmmmmhhhh yes

[shut crater]

I have also just created an additional layer for my own mod to sit on

[brisk rose]

each spaghetto a masterpiece

[willow plinth]

you guys are spared from the obscure transpilation quirks from tstl at least

that's like an actual fucking layer

[brisk rose]

indeed, lol

[willow plinth]

typescript doesn't even have multireturns - and arrays and objects are different things here

[brisk rose]

people should use spaghetto more in the context of spghetti code

[dense crescent]

Is there another way for creating joker with forced rarity? I don't think SMODS.add_card { rarity = 0.99 } will work if there is a new rarity

[brisk rose]

isn't rarity a param for add_card

[shut crater]

does anyone know the difference between mult, h_mult, and mult_mod

[red flower]

rarity = "Rare"?

or maybe it was lowercase

[brisk rose]

rarities are strings now, thanks to the rarity api, so are an open set

[red flower]

for returns?

[brisk rose]

or uh... they're keys I guess

[shut crater]

yeah, or I guess if they're used elsewhere then what they mean in those contexts too

[brisk rose]

see, my thing is that smods/balatro is the only codebase I have major exposure to, so I have no idea how idiosyncratic the terminology is

why did keys used to be called slugs, despite balatro not seeming to use that in its own codebase? no clue

[red flower]

mult is for mult
mult_mod is for mult without a message
h_mult means mult in hand but it's interchangeable with mult in returns for compatibility reasons (I'm guessing)

[dense crescent]

The wiki said it's a number between 0 and 1

[willow plinth]

damn i wanted to write bad fanfiction of mult, h_mult and mult_mod here but no

[brisk rose]

oh that's for weighting

[red flower]

strings should work too

[brisk rose]

but there is a way to definie a rarity

[red flower]

also any modded rarity has to be a string

afaik

[brisk rose]

I'm wrong, it's just stupid

but yeah "under vanillia conditions" the numbers definie rarities

the implication is that rarity strings also work

[red flower]

the number is to hard set the weight

[dense jasper]

The fact I'm going to need to go over who knows how many breaking changes has somewhat cooled my desire to get back into it. Do I need to set up a priority board?

[weak gate]

How do I make a right click with the mouse do things in Balatro?

[brisk rose]

idk why it doesn't just use the old 1-4 system as well as the strings? but yeah it must be because it's a wrighting thing under the hood

[brisk rose]

I can very much relate to that

[red flower]

instead of doing pseudorandom() it replaces it with your number

[dense crescent]

I don't know but, this function just a wrapper for create_card() and call get_current_pool() that is hard coded to 'Common', 'Uncommon', 'Rare' and 'Legendary'

[brisk rose]

yeah I can get that

[brisk rose]

I mean, those functions are likely overridden or hooked by smods

[willow plinth]

this looks like i need to do the effects in events, right?

[red flower]

yeah

[red flower]

are you looking at the dumps?

[shut crater]

I feel like I'm in the dumps 😔

but yes dumps are a powerful resource

[willow plinth]

i feel like i'm taking dumps into my code

[shut crater]

big mood

[dense crescent]

from lovely/dump

[red flower]

yeah that's not hardcoded

it checks if it's a number and does the weight thing else it checks if it's a vanilla rarity and assigns it to the respective number else it uses what you gave it

[verbal hare]

hey chaseoqueso, where can i donate for super tank fight?

[dense crescent]

It's poll new rarity

[red flower]

if you give it a correct one it doesn't poll

[brisk rose]

the last "or _rarity"

passes the string directly

[shut crater]

oh uh, I don't think I have anything set up for that yet. I really appreciate that though, I'll figure something out for donations

[brisk rose]

and you can see, it goes to the pool where the smods.rarities live

[dense crescent]

Oohh yeah I read it wrong

[brisk rose]

also... you're using arch, but not using your print screen key?

or is discord just not on your pc?

[dense crescent]

Discord on my phone, my laptop has 2GB ram it will very laggy if i use Discord

[brisk rose]

fair tbh

must be a bitch to develop a balatro mod on it

[verbal hare]

arch is a W, i tried install it but have errors with the servers and pacman shi

[brisk rose]

though if it's only 2gb, it's probably ddr2 or smth, which is very cheap?

[dense crescent]

Yeah like, close web for documentation, open balatro, close it again, open web again

[brisk rose]

or is it old enough where 2gb is the max?

[dense crescent]

The laptop ram is planted to the motherboard

[brisk rose]

oh that's grody

sometimes when they do they, they still use actual dimms, which is funny bevause it meas it's still upgradable if you're a good solderer

though I've never soldered in my life

[tender ermine]

How do you check how much score you have at the end of a blind?

Couldn’t find it myself

[daring fern]

G.GAME.chips?

[brisk rose]

@dense crescent lemme know when you get balatro plus updated, I've been trying to do a release of my modpack, but I keep on running into little issues

[willow plinth]

i'm cooking

and these negative icosahedra look RAD

my only question is this:

in my eyes i'm doing "make random negative copy of joker" first, then "destroy all negative jokers"

the intention was to also destroy the just created joker with that second action, but hm

[tender ermine]

Idk, I don’t think that would be it, cause I would think that the score would be a separate variable than chips, but I will try it out later

[daring fern]

The score is a different variable from chips, hand_chips is the current chips of the current hand.

[tender ermine]

Oohhhh, I think I get it now, thanks

[verbal hare]

got this crash, can somebody help?

[willow plinth]

excuse the typescript but the calculate for the first action (copying) is this

if (
    G.jokers !== undefined &&
    G.jokers.cards !== undefined &&
    G.jokers.cards.length > 0
) {
    SMODS.calculate_effect(
        {
            colour: G.C.DARK_EDITION,
            message: localize("landedOnVertex")
        },
        context.blueprint_card ?? card
    );

    G.E_MANAGER.add_event(Event({
        delay: 0,
        func: () => {
            if (
                G.jokers !== undefined &&
                G.jokers.cards !== undefined &&
                G.jokers.cards.length > 0
            ) {
                const randomJoker = pickRandom({
                    options: G.jokers.cards,
                    seed: "icosahedron"
                });

                const copiedJoker = create_card(
                    "Joker",
                    G.jokers,
                    undefined,
                    undefined,
                    undefined,
                    undefined,
                    randomJoker.config.center.key,
                    undefined
                );

                copiedJoker.set_edition("e_negative", true);
                copiedJoker.add_to_deck();
                G.jokers.emplace(copiedJoker);
                copiedJoker.start_materialize();
            }

            return true;
        },
        trigger: "after"
    }));
}

the calculate for the second action (destroying) is this:

if (
    G.jokers !== undefined &&
    G.jokers.cards !== undefined &&
    G.jokers.cards.length > 0
) {
    const destructibleJokers = G.jokers.cards
        .filter((joker) => !joker.ability.eternal && !joker.ability.getting_sliced);

    if (
        destructibleJokers.length > 0 &&
        !(context.blueprint_card ?? card).getting_sliced
    ) {
        if (!(context.blueprint_card ?? card).getting_sliced) {
            SMODS.calculate_effect(
                {
                    colour: G.C.RED,
                    message: localize("landedOnEdge")
                },
                context.blueprint_card ?? card
            );
        }

        G.E_MANAGER.add_event(Event({
            delay: 0,
            func: () => {
                for (const joker of destructibleJokers) {
                    joker.ability.getting_sliced = true;

                    (context.blueprint_card ?? card).juice_up(0.8, 0.8);
                    joker.start_dissolve({ colour: G.C.RED }, undefined, 1.6);
                }

                return true;
            },
            trigger: "after"
        }));
    }
}

they get called after each other and both in the context context.ending_shop

any idea what i am doing wrong here?

sorry for flooding the chat

[willow plinth]

when does this happen?

[verbal hare]

starting a game

like after selecting a deck

[brisk rose]

what is ++jokers?

[willow plinth]

your mod is loading twice

no bueno i think

[verbal hare]

is my mod]

lmaoao

just a name to difference it, i dont think im going to upload it

[willow plinth]

oh is MiDeckTest and WDeckMod something different??

[verbal hare]

yeah

test was to look some differences cuz it was crashing

but im gonna delete it now lmao

[chrome widget]

Is SMODS.Ranks[card.base.rank].key the best way to determine something's rank within SMODS?

[willow plinth]

no, use .base.id

at least for cards

that's an integer and you can just work with that

[chrome widget]

does id account for modded ranks?

[daring fern]

Why not get_id?

[willow plinth]

that i don't know, i'd also be curious

[verbal hare]

btw, rn the problem is with ++jokers mod, i was trying to do the debuff shit and it isn't working

[willow plinth]

idk, someone here told me this :D

[chrome widget]

Oh wait it's not base.rank, it's base.valuethat's typically used for internal SMODS stuff

Okay yeah I guess get_id() is fine and accounts for modded ranks, it grabs rank.id from the SMODS rank when it's set

It's not constrainted to vanilla ones

[brisk rose]

oh... smods.rank is a mess, the ordering is definied by the person who makes the rank object literally defining ranks that come afterit

there is no like.... way to sort by an index

which I guess makes sense tbh

[chrome widget]

wdym?

[brisk rose]

I mean they have no inherent numerical value

even if you want them to

at least from what I can glean of documentation

[chrome widget]

I'm still not entirely certain what you're referring to. Numerical value in what context?

They give their chip score value, and vanilla ranks at least have numerical ids

[digital niche]

how do i make this but with more enhancements iinstead of just one?

[brisk rose]

I mean for straights mostly, but yes the chips value can be used for most purposes

but yeah if you just wanna poll for ranks it doesn't matter anyway

[chrome widget]

If you mean the vanilla ranks within the SMODS.Ranks table, they do have the order they're created, which is in SMODS.Rank.obj_buffer

Obviously for modded ranks, it depends on when the mod is loaded

[brisk rose]

the thing with how the straight behavior is defined, which is by the user as what comes after it, other modded ranks aren't accounted for

[daring fern]

You mean check if a card has multiple enhancements or if a card has one of a certain amount of enhancements?

[brisk rose]

so one mod could add a 13 and another a 14 and they wouldn't work in a way that makes sense without them having knowledge of eachother

[digital niche]

if it have one of the enhancements its being checked

[brisk rose]

again, from my reading

[digital niche]

i want to check for 3 enhancements rn

[brisk rose]

I think the problem is with vanillia balatro straight detection come to think of it

not smodded

[daring fern]

You could do SMODS.get_enhancements(card) then check if any of the outputs equal to one of those 3.

[digital niche]

ooh, okok, ty!

[chrome widget]

As far as I'm aware, no. Not without changing SMODS code

[brisk rose]

also applies to strngth

[chrome widget]

The way Rank ids are determined is in order of application load

[verbal hare]

bump

[brisk rose]

it's a limitation in the ranks of the actual game, I think, so I don't blame smods. they'd have to reimplement and break every mod that messes with ranks

[chrome widget]

So multiple mod creators can't force ranks to have the same IDs, because they're determined automatically by the smods load. They could force them to have conflicting keys, but that should generally be avoided just as a design principle

[willow plinth]

i feel like you are talking past each other

[digital niche]

i think i did it wrong but idk another way that i could do that

[brisk rose]

yeah, though it's probably because I'm musing rather than making a solid point

and they're coming at me with facts, which are fine, and pretty much what I presumed, but don't really apply to my musings

[chrome widget]

My pronouns are in my bio, don't refer to me with they/them pronouns pls

[brisk rose]

sorry, she

I wasn't assuming you were a they, I was just using the English language default pronoun

but yeah, I'll keep that in mind

[pearl jacinth]

how do i make a negative card

[digital niche]

use ectoplasm

[brisk rose]

lmfao

[pearl jacinth]

well how do i make a negative consumable

[brisk rose]

I think he means in code

[pearl jacinth]

(don't answer perkeo)

[chrome widget]

use card:set_edition(e_negative)

[brisk rose]

this time I checked bio

[daring fern]

No, you want to check if it contains any of those.

[brisk rose]

I have a habit of not doing that, so I'm sorry to anyone I use they for who doesn't wish to be referred to as such

[digital niche]

im not sure how, its one of the first times im using check enhancements things

[brisk rose]

discord should really just display the pronouns field on messages

[digital niche]

!

[willow plinth]

relax, they/them is the default neutral pronoun, no one randomly looks at every profile, she told you what to call her and it's fine (i hope)

[brisk rose]

fair, what's probably worse(?) is my sometimes he/him defaultism when I do check and no pronouns are listed

[willow plinth]

also normal, problematic, but systematically normal...i'm not queer but from what i've gathered in most conversations, ur only shitty if you know the pronouns and still actively refuse to use them

[brisk rose]

yeah I'd pretty much agree

My reason behind doing it is if I check, it means I actually am actively interacting with someone on a somewhat interpersonal and extended level a lot of times, and in that case, I inherently recognize that for anyone that doesn't actively prefer they/them, being referred to exclusively as such can feel odd and othering

like, you don't list pronouns, but because we interact so much, they/them would start to feel weird to use

[willow plinth]

i personally just don't care, feel free to mix it up lol

not to make fun of others, i get caring about it

[frosty rampart]

there's a plugin for vencord that does exactly this
(although it seems to be partially non-functional at the moment, in that it won't actually load the pronouns until you've clicked on a user's profile anyway lmao)

[digital niche]

for some reason everything here is becoming the m_mills_feral

did i do something wrong?

[daring fern]

You should be checking if the table contains it, not if it is it.

[verbal hare]

bump

[digital niche]

how do i check if it contains?

[daring fern]

Put this somewhere in your code ```lua
function table.contains(table, element)
if table and type(table) == "table" then
for _, value in pairs(table) do
if value == element then
return true
end
end
return false
end
end

[digital niche]

ok, what else?

[brisk rose]

I'll not say I've never used vencord, but I do try to avoid it because it can get ya banned

and I don't trust folk

or really trust discord to not somehow detect it

[frosty rampart]

tbh i'd recommend just using if SMODS.has_enhancement(v, "m_bonus") then instead. does the same as what you're trying to do i think

[daring fern]

Then just do if table.contains(SMODS.get_enhancements(v), 'm_mult')

[frosty rampart]

fair enough

[digital niche]

tyty

[digital niche]

also tried and had the same issue

[frosty rampart]

dang

[digital niche]

didnt work

[digital niche]

also that code of the screenshot worked

[daring fern]

For that statement to be true the card would have to be wild, mult and bonus?

Which is possible but not normally.

[digital niche]

in that part it have to be one of them

[willow plinth]

i doubt anyone cares but just for reference: i fixed it by resetting destructibleJokers inside the destroy event - obviously once the destroy event actually fires, there could be new jokers, but i've set destructibleJokers way before outside the event

and it looks nice too (imo)

[digital niche]

nvm i just can select anything

its not working lol

[chrome widget]

Hm I've never done this before, does anyone have any pointers towards animating the Blind Score requirement if an effect changes its value?

[willow plinth]

i think it's ease_value 🤔

[chrome widget]

No I don't mean changing the value, I mean actually animating the text UI element itself

[daring fern]

G.GAME.blind.chip_text:juice_up()?

[chrome widget]

Although after saying that I literally just found what the game does at least when it sets a blind, which is G.HUD_blind:get_UIE_by_ID("HUD_blind_count"):juice_up()

Or I think more preferrably, G.hand_text_area.blind_chips:juice_up()

[vocal cedar]

okay chatters
Im making a consumable that acts very similar to sigil, the "flip your entire hand over, change it in some way, then flip it back"
so it can be used freely whenever you have a hand drawn
so base blinds, arcana packs, and spectrals

this line of code doesnt work tho, works fine on blinds put not the packs

any tips?

i tried to copy sigils code from base game a

and no dice no pizza

[high sinew]

Is there a way to make a consumable check if a card has a certain enhancement to upgrade/them into a new enhancement

[vocal cedar]

you would check if G.hand.highlighted[i]:edition = "whatever

[daring fern]

SMODS.has_enhancement(card, 'm_key')

[vocal cedar]

thats a netter way

much better

[vocal cedar]

is there a place where all game states are?

[willow plinth]

G

globals.lua

[vocal cedar]

okay nice

so

is there a state that the game sets at when

[vocal cedar]

wait

hold on chat

[vocal cedar]

i copied that code exactly before and it didnt quite work

yeah its not working

it either only works in blinds

or works literalyl everywhere lmao?

[daring fern]

Try just checking if #G.hand.cards > 0

[vocal cedar]

just like a devcheck?

okay hold on

[high sinew]

What if I want this consumable to basically check if it has Mult bonus or Wild and have it turn into a certain enhancement based on what it was

[daring fern]

if SMODS.has_enhancement(card, "m_bonus") or SMODS.has_enhancement(card, "m_mult") or SMODS.has_enhancement(card, "m_wild")?

[vocal cedar]

#g.hand.cards > 0 is true on blind battles arcanas and spectrals

so

perhaps i literally just do that lol

this seems scuffed tho

[daring fern]

You want it to happen when there are cards in hand right?

[vocal cedar]

i got it working lol

its scuffed but works

[vocal cedar]

whats the stone card enhancement called in game btw

like

e_stone?

[daring fern]

m_stone

[vocal cedar]

thank!

any reason why this isnt working

i am unfamiliar with lua lol

game isnt crashing, but using the card is softlocking my game

some noob shit i know but

im just trying to learn i think

[daring fern]

Definition of flipAllCards?

[vocal cedar]

flip all cards works perfectly

its the transform one

but here

game flips all cards, then just softlocks lol

[daring fern]

Try using pairs instead of ipairs

[vocal cedar]

nah

its something with the setting of the shit i think

let me try to hard code it rq

[daring fern]

Try changing 'm_stone' to G.P_CENTERS.m_stone

[vocal cedar]

hmm okay

[shut crater]

my magnum opus

[brisk rose]

wait... is this a revive of a really old mod?

[shut crater]

is it?

[brisk rose]

I've heard of pow like a year ago

[shut crater]

I know barely any mods

I'm not surprised that I'm not the first person to come up with it though

[vocal cedar]

it seems to be infinitly looping....?

oh shit i need a return true

[brisk rose]

nah, I'm just having a deja vu moment or something, if it was talked about, it was just in passing

[vocal cedar]

IT LITERALLY JUST NEEDED A TRUE LOL

[tall wharf]

never punished

[vocal cedar]

@daring fern what exactly is G.P_Centers anyway?

[daring fern]

It's where mostly every object is.

[vocal cedar]

oh okay

nice

[desert ore]

should I worry about how the back would look when flipped by amber acorn? things like chad stencil and ignore it, but idk

lol

[crisp coral]

not worth the hassle id assume

if thunk doesnt do it you dont have to

[desert ore]

would I not be able to hook the function that flips the jokers and for specifically its id, shows a different back? or is it not that simple

[brisk rose]

tbh I thought he changed all backs to look the same, because isn't amber acorn vanillia?

[desert ore]

I'm not sure what you mean

the backs used to be different?

[brisk rose]

I didn't think they showed up different sizes anymore

like for wee and square

[desert ore]

no? they still do I think

[brisk rose]

ah I forgor

I guess it was modders who wanted to change that

[desert ore]

I like that functionality idk

[brisk rose]

I think they just thought it defeated the purpose of amber acorn on an arbitrary basis

[desert ore]

well it's like an immersion type thing, like you're actually playing a card game

[brisk rose]

yeah I get that side of it

[frosty rampart]

you're both right
the backs are solid, even if the joker has holes in it. however, the shape is still retained
(this was stencil, photograph, hanging chad, golden ticket, and half joker)

[brisk rose]

buy tnh in a real card game, they'd prpbably just be images printed on normal playing cards

[marble flint]

I have a double-sided joker that acorn shows the back of, but only because it's based off a real line of cards that were printed on both sides

[brisk rose]

yeah I knew the stencil didn't apply, that'd require a custom shader on the deck back I think

[desert ore]

oh half joker look real weird there

ok yeah Irdc then

[tall wharf]

i think you can just punch a hole into the normal back

[brisk rose]

but that breaks immersion with other decks

or wait...

do jokers always have red deck back?

I don't remember

[tall wharf]

no lol

[desert ore]

there's a bug with anhk/invis where it had the wrong back so I think not

[marble flint]

it's (supposed to be) whatever deck you're using

[tall wharf]

you can do the thing I said or maybe make a mask out of it?

[brisk rose]

then yeah you'd need a shader to do it rigjht

or maybe drawstep?

with a ask like aiko says

mask

[desert ore]

can a shader even make something translucent?

[marble flint]

i need to figure wtf a smods.drawstep actually is

[brisk rose]

yes, there are translucent editions

[desert ore]

huh

[chrome widget]

Grrr unblockable events are the bane of my existence right now

[desert ore]

my assumption would be that it can only add colors, but I haven't dared to touch shaders yet

[marble flint]

shaders can do basically whatever, so long as you're okay with pain

[brisk rose]

It just does math on the colors, alpha is part of them

afaik

[marble flint]

i could theoretically move card calculation logic into shaders if i really wanted to

the only issue is that's dumb

[brisk rose]

yes, shader languages are indeed full programming langauges, lol

[marble flint]

time to go take a video of that one vertex shader i wrote a while ago to establish that i know what i'm talking about

[brisk rose]

ugh, if it's not one thing it's another, i stg

[manic rune]

where are all the blinds' centers?

[crisp coral]

G.P_BLINDS

[manic rune]

thank

[desert ore]

was my assumption correct for this if I did want to do smth like that

[marble flint]

take a look at Werewolf in Bakery which basically does exactly that

[desert ore]

alright, good to know

[marble flint]

http://cdn.gdane.net/octa1.mp4 http://cdn.gdane.net/octa2.mp4

[daring fern]

How does one call a function in itself without causing an infinite loop?

[willow plinth]

stop at a certain point, either condition or counter

[willow plinth]

or how do you mean that?

[daring fern]

I'm trying to be more efficient with a card having more than 1 seal.

[willow plinth]

there's multiple way to stop recursion once a goal is reached though

the most basic thing is like this

function test(a)
  if (hasReachedGoal(a)) {
    return true
  }
  
  local new_a = something(a);

  return test(new_a);
end

but i think i misunderstand

[manic rune]

i noticed that defeating a boss blind will reset you back to small blind, and i initially thought that the code was in end_round(), but its not, anyone got a clue where the code could be?

[willow plinth]

just need to make sure of two things: have a case that terminates, and return your function call

[digital niche]

is there a way to just remove one of the selected cards in consumable?

like a way to differentiate the 2 selected things

[daring fern]

G.hand.highlighted[1]:start_dissolve()?

[digital niche]

tyty!

[hard flume]

Hi chat

[digital niche]

is G.hand.highlighted[1]: a way to differenciate the first and the second card selected in general?

[digital niche]

hii!

[daring fern]

The first card is G.hand.highlighted[1] the second one is G.hand.highlighted[2]

[digital niche]

then would this work?

[hard flume]

I can't work on my Balatro Mod, away from Computer, so instead I'm working on ideas for it

[digital niche]

the first one i want to change to that enhancement, "m_mills_lots, the second one to remove

its crashing

[digital niche]

relatable

[daring fern]

You don't check the highlighted in use you check in can_use also v does not exist.

[regal ether]

as much as i want to dunk on you for this not being how it works i admit i also dont know how to approach what you're doing

many such cases...

[digital niche]

oh so i have to set an v and take out the #G.hand thing right?

[regal ether]

well what argument is v supposed to be anyway

[daring fern]

What does this consumable do?

[regal ether]

what parameter is that

[digital niche]

like, if i select 2 bonus cards he will remove one and set the other to a "lots" card

basically fusing

[regal ether]

interesting

[digital niche]

i had something similar to this before and was working but both became the "lots" enhancement so i just kept those two without thinking LOL

[regal ether]

also personally i would just check the Card.enhancement instead of using the smods function if possible

[daring fern]

if SMODS.has_enhancement(G.hand.highlighted[1], 'm_bonus') and SMODS.has_enhancement(G.hand.highlighted[2], 'm_bonus') then

[regal ether]

OHHHH

see THIS makes sense

arg1 is the card ok

[digital niche]

ooh ok, so this instead of the "SMODS" thing i have now i put this right?

[daring fern]

Replace the whole if with that.

[digital niche]

yeye, thats what i meant! tyty!

how do i check if a card have an enhancement? like any enhancement, not a specific one

just SMODS.has_enhancement()?

[daring fern]

next(SMODS.get_enhancements(card))

[digital niche]

tyty!

[glass scaffold]

Can I do multiple calculate functions in a Joker or do I have to figure out some Lua magic to fit 2 effects in one functions?

[daring fern]

Use SMODS.calculate_effect?

It works for most things that would be in the return.

[glass scaffold]

My Joker already has a calc function for a 1 in 5 to auto-win a blind. I want to add in some passive emult.

[daring fern]

Why would you need to return to auto win a blind?

[glass scaffold]

Here's what I got for reference

[daring fern]

Just put it after the setting_blind check?

[digital niche]

how can i make this but with 2 different enhancements and both can be either first or second? like, the G.hand.highlighted[1] can be either m_bonus or m_mult and same for the G.hand.highlighted[2]? i thought of just using some or but then it could also be just 2 m_bonus than it breaks

[glass scaffold]

I'll try that idea later on and come back.

[daring fern]

Just change 'm_bonus' to something else.

Iterate over all highlighted cards.

[digital niche]

but the idea of the mod is fusion, so i can have bonus+bonus, bonus+mult, bonus+wild etc

wait i dont think i got it right

[daring fern]

Just change 'm_bonus' and check if v from the iteration has the enhancment.

[digital niche]

sorry i really dont understand how that works

[daring fern]

for loop?

[digital niche]

i think ill just lay down in all four and start eating grass like the caprine i am instead

[daring heron]

probably a pretty dumb question but how do i add multiple lines to the description?

(and how do i add a mod icon)

[digital niche]

like this:

text = { "this is line 1",
         "this is line 2",
         "this is line 3",}

just add a , and go to the next line

remember to add a " before the comma and in the start of the next line

[daring heron]

?

[shut crater]

So probably what you want to do is something like

local enhancement1 = SMODS.get_enhancements(card1)[1]
local enhancement2 = SMODS.get_enhancements(card2)[1]

And then use whatever combining code you already have. Only problem is that I'm on mobile and have no idea if that's how get_enhancements works

[daring heron]

okay it works if i put it in the JSON, but which lines in the .lua should i keep?

[daring fern]

Put it all in the JSON

[shut crater]

That header is an outdated way of doing things, use the JSON method instead

[daring heron]

well i tried, but then it just doesnt show up here

[crisp coral]

you don't need the lua header if you're using json

try using a readme.md file instead

[daring heron]

??

[shut crater]

There is a correct way to do everything the header does but with JSON instead

I can send you my mod repo if you want to see how I set mine up

[daring heron]

yes please

[shut crater]

https://github.com/chaseoqueso/Powerful_Balatro

[digital niche]

i dont see how that would help? i need a way to make it so the first hand and the second hand can be both 2 different enhancements but not the same, like, both can be either mult or bonus, but they cant both be mult or both be bonus

[daring heron]

doesnt work

[bold sleet]

Hello. Question: Is there a way to check if any given card has an enhancement?
-# to this day I think enhancements are extra fucked up

[daring heron]

do i make it "text" instead of "description"?

[daring fern]

Has a specific one or any enhancement?

[digital niche]

oh in json? thought you meant in cards

[bold sleet]

Would be nice to have both.

So I don't have to ask again.

[shut crater]

Well doing it that way gets you any possible enhancement in the entire game in two lines of code, instead of having to manually check every possible combination of enhancements

[daring heron]

in json yeah

[daring fern]

SMODS.has_enhancement(card, 'm_key') for specific and next(SMODS.get_enhancements(card)) for any.

[bold sleet]

oh

ty

[digital niche]

but isnt what you sent basically what im already doing but with extra steps?

i think i didnt get it right, again

[digital niche]

maybe just take out the {}, im not sure

[shut crater]

But doesn't your code not do what you want it to? And the code I sent would be a step in the direction of what you want to do?

Can you explain the goal again?

[vocal cedar]

how does one target a joker? G.P_CENTER.Jokers?

[daring fern]

What do you mean?

[vocal cedar]

i want to give iridescent to a random joker

[daring heron]

sadly not

[vocal cedar]

just trying to figure out to call

[digital niche]

nono, it is working properly now, what i want is a way to say that like

G.hand_highlighted = 1 mult and 1 bonus

G.hand_highlighted[1] either mult or bonus
G.hand_highlighted[2] either mult or bonus

G.hand_highlighted[1] and G.hand_highlighted[2] never the same

[daring fern]

Get a random joker and card:set_edition('e_modprefix_key')?

[vocal cedar]

exactly

[digital niche]

wait i think i know how

[vocal cedar]

just how do i target one of your random jokers

[daring fern]

pseudorandom_element(G.jokers.cards, pseudoseed('random'))

[vocal cedar]

its G.jokers.cards got it

thank you

i need to just study the game objects lol

[daring heron]

so how do i add multiple lines of text in the json?

[daring fern]

Add more text.

[digital niche]

i can just say
if SMODS.has_enhancement(G.hand.highlighted, {'m_mult', 'm_bonus'})?

[daring fern]

No.

[daring heron]

i can't see how thatd help at all

ofc i wanna add more text

but how

[digital niche]

oh then nvm😭

[thorn flame]

thoughts

[digital niche]

can i make something similar to it?

[daring fern]

You press the keys on your keyboard.

[daring heron]

..

[digital niche]

as you add more text it will automatically make more lines

[daring heron]

alright

[shut crater]

So it essentially requires credit card to be functional?

[daring fern]

Rental?

[thorn flame]

thats the problem

i was gonna add more jokers that allow you to get into debt

fwiw it may not stay in

[daring heron]

thats the problem

[shut crater]

It's generally (with some exceptions) bad design to create an ability that relies on another ability when that ability is rare or extremely conditional. It is generally better to design around ubiquitous mechanics

[daring fern]

Then put it in a new tab?

[thorn flame]

i want to try to make debt more ubiquitous

[shut crater]

I think jokers are not the best way to do that

[daring heron]

yeah thats the problem. how

this doesnt work

[valid dove]

i've made a joker very similair to what you've done here. for me it made it way more useful if the joker allows you to slightly go in debt already, like $5, so maybe try adding that?

[shut crater]

Just because of the cursed design problem of the variance of the joker pool

[shut crater]

That makes a lot of sense

[thorn flame]

why didnt i think of that

[valid dove]

and it makes the joker a lot of fun to use haha

[thorn flame]

i need to start working on this fucki n mod EARLIER in the dyay when i can think criticaklly

[valid dove]

farming debt on the tooth was an experience

[thorn flame]

wow it really is

[vocal cedar]

is there a generic SMODS.has_enhancement that just checks if a joker HAS an enhancement

not a specefiuc

[brisk rose]

"description": "A description of your mod.", // [required] ! To use more advanced typesetting, specify your description as a localization entry at G.localization.descriptions.Mod[id]

[vocal cedar]

tryint to code a spectral to apply an enhancement to a random joker that does not already have an edition

[shut crater]

Use
next(SMODS.get_enhancements(card))

[vocal cedar]

and if get_enhancements returns nothing thats good

okay nice

[daring heron]

does anyone even know what i mean. i just want to add multiple lines to the description like how you can press enter normally in stuff

[vocal cedar]

would it return nil or none

[hoary crown]

crash when my blind is on screen

[brisk rose]

you can't not without making a loc entry

[valid dove]

SMODS.get_enhancements(card, extra_only) returns all the enhancements a card has, so if it has none it would be nil? idk never used it but it may be useful haha

[vocal cedar]

unfortunanlty i havent messed with those yet

[brisk rose]

that's what what I sent means

i'm almost sure

[vocal cedar]

thank you!

[brisk rose]

The lack of newlines in the description field has been discussed many times before iirc

@daring heron

but you can do it in a loc entry

[daring heron]

how do i do that then

[brisk rose]

you create a folder called /localization/

I mean without the /

in the folder for your mod

and make a file called en-us.lua

(or altneritvely default.lua. I've seen both be used

[daring heron]

like this?

[brisk rose]

yes, but please stick to lowercase for all the folders inside your mod's folder. It's not technically nessacary but lua is case sensative, as is every OS besides Windows, so things can get weird

and you can just forgor what case you used

the mod folder being capital is fine

also same with the filename for default, that should be lowercase. idk if it needs to be because windows is strange, but that's how it is officially in the code

[daring heron]

do i need to lowercase the pngs too?

[brisk rose]

that seems to be the way that people do it, but you'd also have to make sure your code asks for them in lowercase too

[daring heron]

okay, and then what do i put in the default.lua?

[brisk rose]

gimme a second to figure that out, lol

[daring heron]

alrighty

[tall wharf]

lowercase please

[brisk rose]

https://github.com/Steamodded/smods/wiki/Localization

here's the docs if you wanna figure it out with me

[brisk rose]

I already told them, lol

[vocal cedar]

this breaks on jokers i think

how would i figure out what editons a joker has

[wintry solar]

Jokers don’t have enhancements

[vocal cedar]

does get_enhancements return it

yeah

[valid dove]

edition is not the same as enhancement

[vocal cedar]

im just trying to figure out if a joker has an editionbruh

endition*

[eager pendant]

Can you tell me how to put your color in loc_vars?

[valid dove]

enhancement = lucky, bons, mult
edition = polychrome, foil, holo

[wintry solar]

if card.edition then return card.edition.key end

[vocal cedar]

peak thank you

so if a joker has card.edition it returns true?

[vocal cedar]

many ways! heres an example

theres a list of colors somewhere on the wiki

[valid dove]

read this page https://github.com/Steamodded/smods/wiki/Text-Styling

[vocal cedar]

but do the {C:color}{} thing

[valid dove]

there are all the colors you ever need

[vocal cedar]

valid?

[eager pendant]

I know that, there is some way to move it to {V:1} I'm not quite sure how.

[vocal cedar]

oh i see

[daring fern]

No, if not joker.edition then

[eager pendant]

Would this be the correct code?

loc_vars = function(self, info_queue, card)
return {
vars = {
colours = { HEX("#FF00FF") }

[vocal cedar]

use = function(self, card, area, copier)

        local used_tarot = copier or self
        local cards = G.hand.cards
        --Flip cards
        flipAllCards(cards)
        --Make them stone
        transformCards(cards, G.P_CENTERS.m_stone, nil, nil)
        --Grab a Random Joker without an edition
        local jokers_without_enhancement = {}

        for _, joker in ipairs(G.jokers.cards) do
            if not joker.edition then
                table.insert(jokers_without_enhancement, joker)
            end
        end
        local joker = pseudorandom_element(jokers_without_enhancement, pseudoseed('random'))
        --Roll for initiative
        if joker and math.random() < G.GAME.probabilities.normal / card.ability.extra.odds then
            joker:juice_up(0.3, 0.5)
            joker:set_edition('e_frover_iridescent',nil,true)
            play_sound('frover_iridescent',1,1)
        
        else
            G.E_MANAGER:add_event(Event({trigger = 'after', delay = 0.4, func = function()
                attention_text({
                    text = localize('k_nope_ex'),
                    scale = 1.3, 
                    hold = 1.4,
                    major = self,
                    backdrop_colour = G.C.SECONDARY_SET.Tarot,
                    align = (G.STATE == G.STATES.TAROT_PACK or G.STATE == G.STATES.SPECTRAL_PACK) and 'tm' or 'cm',
                    offset = {x = 0, y = (G.STATE == G.STATES.TAROT_PACK or G.STATE == G.STATES.SPECTRAL_PACK) and -0.2 or 0},
                    silent = true
                    })
                    G.E_MANAGER:add_event(Event({trigger = 'after', delay = 0.06*G.SETTINGS.GAMESPEED, blockable = false, blocking = false, func = function()
                        play_sound('tarot2', 0.76, 0.4);return true end}))
                    play_sound('tarot2', 1, 0.4)
                    used_tarot:juice_up(0.3, 0.5)
            return true end }))


        end

okay so help me out here

setting used tarot to "self" but self is nil

literally fucking now

juice up crashes my game

[daring fern]

local used_tarot = copier or card

Use card.

[vocal cedar]

thats WHAT i did lol?

or CARD?

not self?

is card self?

[daring fern]

Always use card unless you're hooking vanilla functions.

[vocal cedar]

okay got it

thank you lol

[eager pendant]

Would this be the correct code?

loc_vars = function(self, info_queue, card)
return {
vars = {
colours = { HEX("#FF00FF") }

[valid dove]

you're missing a lot of closing curly brackets but besides that yes

[vocal cedar]

it WORKS!!! thank you chat

[wintry solar]

You could use the unknown function SMODS.get_edition_cards(G.jokers, true)

[eager pendant]

Thanks, I'm gonna go try it

[brisk rose]

did you figure it out at all? sorry I got distracted

[daring heron]

not really, it's okay lol

[brisk rose]

    descriptions = {
Mod = {
[your mods id] = {
'line 1',
'line 2'
}
}
    },
    misc = {
    },
}```

I think this is all you need

does that look right @wintry solar

besides the terrible indenting

[daring heron]

i did try and it didnt work

[brisk rose]

remove the one from your json file

oh I see what I did wrong

[last sentinel]

Is there an effective way to have a joker change the hand recognition(similar to four fingers?), so like, if i have this joker, two pairs are considered full house or something like that

[brisk rose]

edited

[marble flint]

you want to take_ownership of PokerHands for that

preferably with a hook to only modify the original logic instead of replacing it

[last sentinel]

gotcha

[daring heron]

still didnt work sadly

[wintry solar]

I haven’t used the loc file for my mod descriptions

[brisk rose]

yeah I must be parsing "G.localization.descriptions.Mod[id]" wrong

all it says is put a loc entry there

no more info

[brisk rose]

just figured you might know because you're pretty involved in smods development and were around

[wintry solar]

If cebee can send their code I’ll be able to sort it out

[brisk rose]

@daring heron

[daring heron]

the loc file?

or just the .lua script

[brisk rose]

I think it's the header json and loc file that are relevent here?

[daring heron]

loc file was just the one you sent me

[bold sleet]

Question: How do I make so it says +1 consumeable slots instead of joker slots?

[daring heron]

{
"id": "extradecks",
"name": "Extra Decks",
"display_name": "Extra Decks",
"author": ["CebeeDrawz"],
"description": "Extra Decks - Adds a multitude of new decks to the game",
"prefix": "extradecks",
"main_file": "main.lua",
"priority": 0,
"badge_colour": "8389dd",
"badge_text_colour": "fffff",
"version": "1.2",
"dependencies": ["Steamodded (>=1.*)"]
}

this is the json

[brisk rose]

did you fill in your mod's id?

idek if that's what that means in what ti says to do, but it's worth a try

[brisk rose]

as is removing the desc here

but I'll let eremel take it from here because he actually has a clue what he's taking about, lol :3

[bold sleet]

pweaxe?

[brisk rose]

uh... negative consumables are in the base game?

so the desc should be fixed for them already?

[wintry solar]

e_negative_consumeable

[wintry solar]

And the loc file please

[bold sleet]

tried with G.P_CENTERS.e_negative. key does not exist

[brisk rose]

I think it's you set the edition to e_negative_consumable instead of jsut e_negative

[wintry solar]

No

[brisk rose]

oh sorry

i shouldn't talk out of my ass so much

[bold sleet]

I tried.

[wintry solar]

Haha

[bold sleet]

Shit does not appear.

[wintry solar]

I don’t remember exactly how to change it, just search the game files for that key

[daring fern]

You need to set the info_queue to {key = 'e_negative_consumable', set = 'Edition'}

[bold sleet]

dis?

[daring fern]

Add _consumable to e_negative

[wintry solar]

Literally the next line

[bold sleet]

?

[wintry solar]

Oh that’s your file

[bold sleet]

Yes

[wintry solar]

Yeah add the _consumeable now

[bold sleet]

dis?

[daring fern]

Yes.

[bold sleet]

Let's see...

woah, a crash!

[wintry solar]

Missing an e

[daring fern]

?

[wintry solar]

Thunk pls

[bold sleet]

?

[tall wharf]

maybe you are missing something

[brisk rose]

so from what I'm getting, the keys for the loc entries are the same as for their respective editions, but negative_consumable of course isn't an actual edition but is just an alt text for if it's on a consumable?

couldn't thunk have used a dymanic description? lol

[bold sleet]

UI_definitions, line ~1100, it seems.

Not certain.

Nor I understand how it works.

[wintry solar]

info_queue[#info_queue+1] = {key = 'e_negative_consumable', set = 'Edition', config = {extra = 1}}

[bold sleet]

Let's see...

-# and if ti works do tell how you figured that shit out

[wintry solar]

I mean that’s straight from the game code

[bold sleet]

oh well

if it works it works

[brisk rose]

I mean.... it's literally the code that's already in the game for the same purpose

it's not rocket surgery

[bold sleet]

for me it is. brain is smol and dumb

[brisk rose]

oh same tho, I just mean how eremel knows is because that's how it is in the game

@daring heron looks like you're still online, are you gonna send your loc file for eremel so he can help you? I know it's basicaly what I aleady sent but it's helpful to have it exaclty

[desert ore]

when lovely patching, do I do it for the lovely dump, or for the base game code?

[brisk rose]

I mean the lovely dump insludes any number of mods

unless you're just playing vanillia, in which case I think it's nearly identical

you match with a pattern, so line numbers don't matter

so the base game code I'd say

[desert ore]

well rn I'm looking at the dump vs base game code and they are different, even with just steammodded

[daring fern]

Do it for the lovely dump.

[desert ore]

ok that makes sense

[daring fern]

It depends on the patch priority though.

[desert ore]

how exactly does that work

[rapid stag]

bump

[desert ore]

actually I should really go to bed

[brisk rose]

Oh yeah smodded ofc