💻・modding-dev

[rancid bridge]

i swear to god if i forgot another comma somewhere

[daring fern]

Do you have the lua extension in vscode?

[rancid bridge]

i forgot commas.

please... please just let me be happy....

[thin anchor]

so

[plush cove]

you need to put return after the info queue

return means the end of a function

[rancid bridge]

what. the. fuck. does. it. want. me. to. fix.

[thin anchor]

i did not know that

[daring fern]

Replacing prefix with your mod prefix.

[rancid bridge]

i am about to just send the lua file and have people figure out what i did wrong that's making the game whine about it

either that or i lose my mind

[daring fern]

The lua extension tells you if there are any syntax errors.

[rancid bridge]

alright

where's the lua extension

[red flower]

https://marketplace.visualstudio.com/items?itemName=sumneko.lua

[normal crest]

sum neko

meow

[red flower]

sumireko

[digital niche]

ok so i know how to make most of the stuff like enhancements, seals, jokers, consumables etc but where do i even start on the code itself? by making the thing i want? by setting something before?

[rancid bridge]

mhm. that helps.

[red flower]

just put the code inside a folder in your mods folder

like this https://github.com/Steamodded/examples/tree/master/Mods/ExampleJokersMod

[digital niche]

no yeah, that i already did, i mean like, where do i start in the code itself, what do i do first?

[rancid bridge]

oh.

i just forgot an "end"

[thin anchor]

never making a consumable again this took me 2~ days

[digital niche]

like that giant code with 8k lines in most mods

[digital niche]

what does the board do?

[red flower]

you can just make an SMODS.Joker object and it will work without any other setup other than the .json metadata

[digital niche]

okok, ty!

[thin anchor]

gives the blue bullseye (1 in 3 chance for +50 chips)

[digital niche]

ooh, thats cool!

[thin anchor]

yeah a little

[cerulean rose]

how would i go about adding a joker from another mod to my ObjectType?

[red flower]

i would do something like this

local SMODS_injectItems_ref = SMODS.injectItems
function SMODS.injectItems()
    SMODS_injectItems_ref()
    v = G.P_CENTERS["j_key"]
    SMODS.ObjectTypes["key"]:inject_card(v)
end

but maybe theres a cleaner way

[cerulean rose]

whats v supposed to be

[red flower]

oops wrong code

[red flower]

there sorry, forgot to copy

[willow void]

question for you gamers: is it possible to change the text/name of a joker once it has been bought?

[winged igloo]

yo, i got an idea, u should add spell and trap cards as consumables

[red flower]

no

[red flower]

yes

[winged igloo]

k

[willow void]

ooo could you point me to a resource or example?

[red flower]

for the text you can return set and key in loc_vars
that might work for the name too

if not then you can use generate_ui

[willow void]

ok, cool thanks!

[cerulean rose]

local clubs_pack_inject_hook = SMODS.ObjectTypes.clubs_pack.inject
function SMODS.ObjectTypes.clubs_pack.inject(self)
    clubs_pack_inject_hook(self)
    self:inject_card(SMODS.Centers.j_ortalab_abstemious)
    self:inject_card(SMODS.Centers.j_ortalab_pitch_mitch)
    self:inject_card(SMODS.Centers.j_ortalab_basalt_column)
end

this seems to work pretty well actually

[gleaming summit]

ok I updated it to use the new stuff
I still have the same issue of not being able to detect when I'm selling a card and not itself
the calculate for the joker has just this code and when I try selling itself or any other card it always says false
so is there another way of checking for the joker being sold not being itself? (I've tried context.selling_card ~= card and it also doesn't work)

[digital niche]

wait what should the atlas be? im a little confused

[rancid bridge]

having a slight issue...
it does not render in game

[red flower]

https://github.com/Steamodded/smods/wiki/SMODS.Atlas

[cerulean rose]

try context.card ~= card

[rancid bridge]

like he is just gone

[red flower]

if context.selling_card and context.card ~= card then

[gleaming summit]

ty

[thin anchor]

jim-gone

[gleaming summit]

oh nice it worked! ty!

[rancid bridge]

i have it laid out like this
what am i doing wrong

does the y value need to be negative since it's going into the row below the top one

[stark geode]

what are you doing?

[thin anchor]

pillar john

[rancid bridge]

i just want them to render in game but they're invisible

[sonic cedar]

can you show

[stark geode]

odd

[digital niche]

what should the px and py be in the atlas? ik what they do but im not sure how i should set it

[rancid bridge]

i don't think anything is wrong with my pos or soul_pos variables

[stark geode]

full code?

atlas included

[red flower]

depends on the object but for cards its px = 71, py = 95

[digital niche]

its tarot card

is it that?

[rancid bridge]

here you go

[stark geode]

SMODS.Atlas{
    key = 'jokers',
    path = 'Jokers.png',
    px = 71,
    py = 95,
    -- 2x is 144 by 190
}

basic template for jokers

[red flower]

yeah it should work, make sure each card in your sheet is actually that size

[digital niche]

okok! ty

[normal crest]

quick thing I found, when using find_card you need to use the full key, j_prefix_key

unrelated to your current issue

[stark geode]

jus make sure path is set to the name of your textures png

like this

[cerulean rose]

the -- 2x is 144 by 190 thing is a bit distracting here
you don't need a separate atlas for 2x

[stark geode]

dear god please indent your code

[normal crest]

it is indented, discord is just weird

click view whole file

[digital niche]

wait i downloaded a placeholder and it is 63x93, so i should chance the px to 63 and the py to 93 right?

[rancid bridge]

that's just how discord does it idk

[stark geode]

now that i have it downloaded it looks better lol

[normal crest]

it'll probably look weird ingame but sure, ideally they're always 71x95 tho

[errant fulcrum]

Does context.other_card:get_id() return a string?

[normal crest]

number

[digital niche]

idk why its as 63x93, i downloaded from here, thought it'd be 71x95

[errant fulcrum]

What about for the face cards and aces

[normal crest]

also id

a jack is id 11 for example

[errant fulcrum]

Gotcha

[red flower]

thats the literal size of it visually but you need to leave empty space to fill the rest

[digital niche]

"undefined global SMODS"

[digital niche]

ooh okok

[cerulean rose]

also see this https://github.com/Steamodded/smods/wiki/API-Documentation#pixel_size

[red flower]

do you have smods installed?

[digital niche]

yeah

[daring fern]

I loaded it with a different atlas and it worked fine.

[digital niche]

here

[cursive ocean]

does anyone know where one could get a data set of the jokers and their effects and all that?

[red flower]

if you make a file that just says sendDebugMessage("hi") what happens

[stark geode]

what the

[red flower]

balatro wiki 🙂
what exactly do you need

[stark geode]

by accounts this should work

[rancid bridge]

wha

[cursive ocean]

hm like a data file a csv or json. ill even take an xml

[digital niche]

undefined global sendDebugMessage

[rancid bridge]

why is mine evil and scary and not working then

[red flower]

huh

[stark geode]

can i have a zip copy of your mod tp debug it btter

[rancid bridge]

alright let me bundle it all in a zip rq...

[red flower]

have you installed other mods before?

[normal crest]

what's inside Smods

[sonic cedar]

is your atlas the wrong size

[digital niche]

yeah, some

[rancid bridge]

it shouldn't be

[stark geode]

the atlas looks fine

[digital niche]

bunch of stuff

[stark geode]

it looks like mine

[normal crest]

okay that looks fine

[rancid bridge]

do you want me to dm it to you or

[stark geode]

sure

[manic rune]

good morning chat

[sonic cedar]

unrelated but does smods still use glass_shattered as a context, or was that lumped into destroying_card?

[red flower]

morning bepis

[sonic cedar]

hi bepis
hi belis
hi craig
hi bella

[manic rune]

i think its just context.destroy_card now

destroying a card through context.destroy_card seems to still have the glass shatter effect

[red flower]

can you post the crash log

[manic rune]

which is nice

[sonic cedar]

and ill just have to specify i want glass

right

[manic rune]

mjm

mhm

[digital niche]

[{
"resource": "/c:/Users/eurea/AppData/Roaming/Balatro/Mods/I might be making a mod/a.lua",
"owner": "generated_diagnostic_collection_name#0",
"code": "undefined-global",
"severity": 4,
"message": "Undefined global sendDebugMessage.",
"source": "Lua Diagnostics.",
"startLineNumber": 1,
"startColumn": 1,
"endLineNumber": 1,
"endColumn": 17
}]

[sonic cedar]

look at me learning hwarhwarhwar

[manic rune]

awr awr awr awr

[sonic cedar]

I DIDNT UPDATE MY NAME

[red flower]

if this is an editor warning you can disregard it

[digital niche]

editor warning is that little "!" sign right?

[red flower]

yeah you can put SMODS in your development folder if it annoys you

[digital niche]

oh okok, ty!

[red flower]

(or rather open a folder with smods in it, dont put smods inside your mod)

[manic rune]

include: "fucking smods itself"

:3

[midnight coyote]

hi guys

[manic rune]

hiii basil

[stark geode]

i just strapped smods and the sorce code to the lua thing in vs code

[hard flume]

bells and whistles complete

[stark geode]

anyone eversee this before

[rugged pier]

bringing this back to implement now

[stark geode]

it works fine on my balatro

but not on thiers

[midnight coyote]

just making my game on the godot

baking lighting takes like 3 minutes so i’m just lazing off

[red flower]

different smods versions? or something wrong with the asset file

[digital niche]

i want to make a tarot card where you can choose 2 different cards that have different editions (like one king wiith steel and one queen with lucky) and fuse those 2, i would need to make both be destroyed then add one king with the edition that would be steel+lucky to the deck right?

looks like the easier way

at least to me

[red flower]

that would get rid of any other stuff on them but if you're fine with that then yeah

[stark geode]

theyre restarting thierpc

[digital niche]

yeah thats fine, there will be different jokers for seals and things like righed, eternal and etc

and one to fuse everything from both, but thats for later wwhen i get to spectral cards

so i would need to set the fusion result of all the fusions id want to have (like the editions i would add) first and then do the tarot things right?

[stark geode]

the 1x and 2x are diffrent

when you turn on pixel art smoothing they stop rendering

i keep mine off

[daring fern]

Then there must be something wrong with the 2x file.

[rugged pier]

calculate = function(self, card, context)
        if context.before and not context.blueprint and not context.retrigger_joker then
            for k,v in ipairs(G.jokers.cards) do
                if v.config.center.rarity == 'csmr_preserver' and v.ability.set == 'Joker' and not v.debuff then
                    card.ability.extra.xmult = card.ability.extra.xmult + card.ability.extra.xmult_gain
                    G.E_MANAGER:add_event(Event({
                        func = function()
                            v:juice_up(0.3, 0.4)
                            return true
                        end,
                    }))
                    return {
                        message = localize({
                            type = "variable",
                            key = "csmr_xmult_gain",
                            vars = { card.ability.extra.xmult_gain },
                        }),
                        colour = G.C.MULT,
                    }
                end
            end
        elseif context.joker_main then
            return {
                message = localize({
                    type = "variable",
                    key = "a_xmult",
                    vars = { card.ability.extra.xmult },
                }),
                colour = G.C.MULT,
                Xmult_mod = card.ability.extra.xmult,
            }
        end
    end

now it is only taking the first joker and ignoring the rest?

[manic rune]

:3 i cant read on phone

ghh

how can u do this N'

😭

[rugged pier]

lock in bepis, you can do this

[manic rune]

oh wait

ur returning in the for loop

[stark geode]

2x (left) 1x (right)

[manic rune]

that completely stops the loop from running at the first joker

[rugged pier]

oh

okay

im going to

[manic rune]

use SMODS.calculate_effect instead

[rugged pier]

use a variable to count

oh

[sonic cedar]

your... atlases... arent the same?

[rugged pier]

what does this do

[stark geode]

notmine

[manic rune]

its like returning, but doesn't interfere with ur code ig

[stark geode]

someone elses

im helping debug

[rugged pier]

so i replace return with that?

[manic rune]

ex:
SMODS.calculate_effect({xmult = 1.5},card)

[rugged pier]

gotcha

can i return a message as well

[manic rune]

increases mult by x1.5

[manic rune]

yeah

format in {} is exactly like how you would return stuff

[sonic cedar]

the atlases shoudl still match 😭

[thin anchor]

what do yall think

[manic rune]

no clue what that is :3

[sonic cedar]

so then this is a glass counter right

[thin anchor]

its an art

[manic rune]

but looks cool, the blue inside could be darker tho

[thin anchor]

ok

[manic rune]

nop

[sonic cedar]

looks cool
post it in #🎨・fan-art so the art guys can say something

[rugged pier]

SMODS.calculate_effect({xmult = 1.5, message = localize({type = "variable",key = "csmr_xmult_gain",vars = {card.ability.extra.xmult_gain }}),colour = G.C.MULT,''},card)

like so?

[sonic cedar]

killing me

[thin anchor]

ok

[manic rune]

if context.destroy_card then
   if SMODS.has_enhancement(context.destroy_card,"m_glass") then
      --do stuff
   end
end

actually, thats wrong

uhhhhh

[sonic cedar]

no wait i remember stone

[manic rune]

check how glass joker works, i completely forgot how to check whether the card is being destroyed or not 💔

[red flower]

this will return the xmult earlier

[sonic cedar]

this is loc vars man... checking glass joker is why i asked 😭

[rugged pier]

earlier?

[manic rune]

oh.

what is it supposed to do again

:333

[red flower]

like you're going to be giving xmult in before and also in the main joker scoring

[sonic cedar]

glass joker (surely you couldve guessed)

[manic rune]

surely

[rugged pier]

so i can just remove the xmult line from smods.calculateeffect

[red flower]

yeah

[manic rune]

oh

[manic rune]

use context.glass_shattered then

[red flower]

also as a side note you can do return { xmult = card.ability.extra.xmult } in joker_main and it will do the same thing you're doing

[manic rune]

:3

[rugged pier]

so i dont need all the message stuff?

awesome

[red flower]

yeah it does it for you

[tawny narwhal]

Why??? Am I a mega goober?

    key = 'singular',
    loc_txt = {
        name = 'Singularity',
        text = {
            "Squares the Mult",
        }
    },
    config = { extra = { Xmult = 1 } },
    rarity = 1, -- Rare rarity
    atlas = 'singularityatlas',
    pos = { x = 0, y = 0 },
    cost = 1, -- Adjust cost as needed
    loc_vars = function(self, info_queue, card)
        return { vars = { card.ability.extra.Xmult } }
    end,

    calculate = function(self, card, context)
        if context.joker_main then
            return {
                message = localize { type = 'variable', key = 'a_xmult', vars = { squared_mult } },
                mult_mod = squared_mult  -- Apply squared multiplier
            }
        end
    end
}

Bruh I cut down the vid, why is this the uncut version...\

[manic rune]

whats squared_mult

[tawny narwhal]

Holy moly

I am a mega goober

old variable I changed...

[rancid bridge]

i'm a bit silly okay i didn't realize i didn't do my procedure of making a 2x image

[stark geode]

good thing i asked for the whole mod lol

[red flower]

also as a side note you can do return { xmult = card.ability.extra.Xmult } in joker_main and it will do the same thing you're doing (x2)

[stark geode]

mfing spacebar misbehaving

[tawny narwhal]

Oh you right

I'm still learning lmao

[red flower]

I'm forgetting

[stark geode]

i needto setup the returns for my jokers

[rain slate]

If I'm doing ```lua
SMODS.ObjectTypes["Joker"].rarities[4].weight = 0.02

[rancid bridge]

also one of the jokers is not working properly
great... 🥹

[junior lily]

i scaled the 1x up by 2 using a website why is it so blurry

[sonic cedar]

"i scaled the 1x up by 2 using a website"

[junior lily]

yes idk how to do it otherwise

[rancid bridge]

one line was so big i had to split it across 2 screenshots but anyway

[rain slate]

probably used bilinear or something

you need nearest neighbor

[sonic cedar]

whatd you make it on

[rugged pier]

it works now, thank you!

[junior lily]

imageresizer

[rancid bridge]

it's just.. not detecting the cards

[sonic cedar]

the art

not the resize

[junior lily]

oh

krita

the 1x looks fine

ignore square that was just from ctrl key

[thin anchor]

im going to notice that square

[sonic cedar]

i dont know aanything about krita

[junior lily]

how could you

[rancid bridge]

why is the joker text so blurry

[junior lily]

idk

[rain slate]

look up smtn like "krita nearest neighbor resize"

because by default it will use something like bilinear and bicubic and those don't work too well for pixel art

[rancid bridge]

what sin have i commited against jimbo

[thin anchor]

i personally recommend libresprite for pixel art
its free

[rancid bridge]

if you have over 20 bucks to spend you can get aseprite

[rain slate]

you can also compile aseprite yourself

[thin anchor]

yeah that too

[rain slate]

I think

[rancid bridge]

that too

[rain slate]

if you don't want to spend over 20 bucks on it

[thin anchor]

someday i will do that because im a penny-pincher

[stark geode]

or you can use ms paint

[junior lily]

ill check that out

does it have an upscale thingy on its own

[rain slate]

I use paint.net but I should get aseprite

krita also has a resizing feature

just so you know

[rancid bridge]

is it something to do with the get_id thing i used or

[stark geode]

the paint resize feature is so ass

im going to use a python script

[junior lily]

[rain slate]

you just gotta resize it to double its original dimensions and use the nearest neighbor algorithm

and you'll be good

[stark geode]

-# def didnt lift it off the cryptid github

[unkempt thicket]

I use kirta for art and resizing

[red flower]

"m_key" has to be replaced with the key of the enhancement

[rancid bridge]

oh

i.. want it to detect all vanilla enhancements

[junior lily]

worked, i didnt know that!

[rain slate]

nice

[stark geode]

which jonkler

[red flower]

if you need to detect if it has an enhancement then next(SMODS.get_enhancements(context.other_card))

[junior lily]

much better

[stark geode]

crazy how diverse the modding community for this game is

[rancid bridge]

so where do i put that

[junior lily]

are added jokers automatically able to be bought in the shop

[red flower]

instead of SMODS.has_enhancement

[red flower]

yes unless it's legendary of course

[junior lily]

oo

alright

if its legendary its pulled from soul right

[red flower]

yeah

[junior lily]

alrighty then

[rancid bridge]

oopsie

accidentally deleted the then

yay it works!

i put enchanced instead of enhanced 😭

[rugged pier]

username checks out

this feels a little...weak for legendary

why just even, make it every enhanced numbered card

[rancid bridge]

you know what?

you may be right...

[rugged pier]

wheres the fun in b a l a n c e

[tall wharf]

omg

[tawny narwhal]

What is the name for the value of the current mult when scoring?

I'm as lost as a wet spoon rn

[rugged pier]

wet spoons are not lost

[crisp coral]

mult

[rancid bridge]

i picked even number cards because even numbers are like happy and stuff

and enhancements are like colors and fun

[tawny narwhal]

so when I config Xmult = mult for the calc, that should work, right?

[rugged pier]

odd numbers are plenty happy :(

[rugged pier]

wdym, show me your calculate function

[rancid bridge]

didn't you hear what happened to 9?

[tawny narwhal]

wait I'm testing it

[rugged pier]

it just needs to be better prepared for 7

[crisp coral]

...what

are you doing xmult equals to current mult

[tawny narwhal]

My friends say I sometimes use weaponised incompetence, but rn this is just straight up incompatence

[tawny narwhal]

yeah

[crisp coral]

i guess

[tawny narwhal]

mmmmm it gave me x1

[rancid bridge]

i'll just make it every enhanced number card then

[rugged pier]

yay

[tawny narwhal]

    config = { extra = { Xmult = mult } },
    rarity = 1, -- will be Rare/legend rarity
    atlas = 'singularityatlas',
    pos = { x = 0, y = 0 },
    cost = 1, -- Adjust cost
    loc_vars = function(self, info_queue, card)
        return { vars = { card.ability.extra.Xmult } }
    end,

    calculate = function(self, card, context)
        if context.joker_main then
            local squared_mult = card.ability.extra.Xmult ^ 2
            return {
                message = localize { type = 'variable', key = 'a_xmult', vars = { squared_mult } },
                Xmult_mod = squared_mult
            }
        end
    end
}

wait why have I local'd my square

idk

[rancid bridge]

alright how do i check for number cards

[tawny narwhal]

take me back to signal analysis

[stark geode]

yo this resize python script go crazy

[rancid bridge]

do i just get rid of this part of the card check thingy

the rest is uh

[rugged pier]

not is_face()

[rancid bridge]

so would it be context.other_card:not is_face()

[tall wharf]

not card:is_face()

[rugged pier]

no i dont think that works

what they said

[tall wharf]

I'm not that smart

i might be misremembering things

[stark geode]

my latest additon

[night juniper]

just wanted to come back and say thank you for the help since i disappeared after you made the suggestion 🙂

[rugged pier]

what does a negative playing card mean

[tall wharf]

this shit is rare type shit

[stark geode]

+1 handsize

[rugged pier]

errr rarity should be 3 for rare i think, but please just use talisman

[stark geode]

imgoing to make a perkeo rarity

[tawny narwhal]

Ugh I was trying to be stubborn

But you right

[rugged pier]

:0 is there an overflow? like does it physically increase handsize or does it just bring one from deck but go over handsize

[stark geode]

typically i do one joker and one feature

so PNA and rarity

[rancid bridge]

again: i'm a little silly so expect me to have done this wrong

[stark geode]

it just lest youdrawmore cards

[rugged pier]

card is your joker im assuming

so it should be context.other_card:is_face()

[rancid bridge]

alright

[tall wharf]

not context blah blah

[rancid bridge]

so this, then

[rugged pier]

maybe should work, try it

[stray warren]

Is there a way to store values onto a Blind like the config for Jokers? I don't see that on the Wiki.

other than just adding an attribute to it at declaration

[tall wharf]

i put shit in blind debuff

[stray warren]

I guess that would work lol

[rancid bridge]

yay it works!!!

[rugged pier]

yay

[rancid bridge]

now i need to change the description hang on

[rugged pier]

new idea for joker brb

[rancid bridge]

yay!!

[rugged pier]

if self.ability.name == 'Stone Joker' and self.ability.stone_tally > 0 then
                            return {
                                message = localize{type='variable',key='a_chips',vars={self.ability.extra*self.ability.stone_tally}},
                                chip_mod = self.ability.extra*self.ability.stone_tally, 
                                colour = G.C.CHIPS
                            }
                        end
``` this is the implementation for stone joker in Balatro, but is self.ability.stone_tally something i can use in my mod with 
```card.stone_tally```?

[modern kindle]

is there a good way i can make a blind take note of the scored hand and then either subtract that amount, make it 0, or leave it untouched?

im attempting to make a blind that rolls against the player and if the blind wins then the chips are instead subtracted from the total chip count instead of added, if the roll ties then it makes the scored hand worth 0, and if the player wins its the normal score of the hand

[night juniper]

you can modify the G.FUNCS.evaluate_play function so that it backs up the score before playing the cards then at the end of the function restore the old score value and get the hand points by subtracting after - before

[stray warren]

Looks like you can access custom defined attributes like this lol
G.GAME.blind.config.blind.odds

[night juniper]

actually you can hook right before this event is scheduled and get the hand score

functions/state_events.lua:1049

[slender bay]

So it's apparently scoring the queens again after the round ends and the score bleeds over to the next round

[modern kindle]

its funny because im already storing the hand value but i just couldnt seem to implement it into the blind properly because it keeps saying the score is 0

cause i use this for some of my jokers as well

[sturdy compass]

This is so janky but it actually works lmfao

[night juniper]

evaluate_play changes hand_chips to 0 before exiting

you need to patch into it or diff G.GAME.chips before and after

[cerulean rose]

breaks if u use ankh then sell 1

[night juniper]

i think

[modern kindle]

yea ill have to look into which works better and go from there
i am probably shrimply tired rn and just not comprehending shit as i should

[sturdy compass]

Shit you're right

Just gonna check if there are any duplicates then. Thanks for the catch

[thin anchor]

why am i making this many enhancements

[tawny narwhal]

Maybe a basic question, where can I find the names of all the different hand types and jokers etc?

Specifically High Card hand

[rapid stag]

how can i check if a card has a seal

[jolly ruin]

holy shit im in the wrong chat

im dumb

i will keep this here as a reminder that im dumb

[tawny narwhal]

lmao no prob

[rapid stag]

[digital niche]

i can add things like a way of knowing some card is a specific thing, like there are "food" and "candy" cards in cryptid to playing cards?

without those things being enhancements itself

[night juniper]

print(card.seal)

[digital niche]

im making close to this amount

[thin anchor]

wow

wowies!

[digital niche]

im making fusion of all the normal enhancements

[thin anchor]

oh thats cool

[digital niche]

like, bonus+bonus, bonus+mult, bonus+wild and it goes on

im rn seeing what the things could make

[thin anchor]

i like that

[digital niche]

thats why i asked this, id make some cards that are like ores, for example, glass+steel its obsidian, stone+gold is Goldstone and more, and there is a card that is a cave, that have 1 in 4 chance to create an ore card when scored

i just dk what wild+wild could make yet

[rapid stag]

do you know how i can apply a seal to a card? and if that method works on jokers i imagine it should since jokers have the same structure as cards

[cerulean rose]

check how basegame does it

[night juniper]

i think card:set_seal("Purple") should just work

[night juniper]

or debugplus

[rapid stag]

that's the thing, i looked and found nothing

[cerulean rose]

card.lua:1178

[night juniper]

functions/common_events.lua:2173

[rugged pier]

calculate = function(self, card, context)
        if context.joker_main and card.ability.extra.stone_tally > 0 then
            return {
                mult = card.ability.extra.stone_tally * card.ability.extra.mult_mod
            }
        end
        if context.before and not context.blueprint then
            card.ability.extra.stone_tally = 0
            for k, v in pairs(G.playing_cards) do
                if v.config.center == G.P_CENTERS.m_stone then 
                    card.ability.extra.stone_tally = card.ability.extra.stone_tally + 1
                end
            end
        end
    end

why could this be making my joker file unrecognizeable? is there any mistake in this code

[sturdy compass]

Is there an error or crash report?

[rapid stag]

i see i was looking to see how the spectral do it, but couldn't find their code that calls the function

[rugged pier]

just said my main file cannot file the joker file and the game crashes

[sturdy compass]

^

Pleas

[rapid stag]

they might want the full crash log

[rugged pier]

local mod_path = '' .. SMODS.current_mod.path
local function load_folder(folder)
    local files = NFS.getDirectoryItems(mod_path .. folder)
    for i, file in ipairs(files) do
        SMODS.load_file(folder .. '/' .. file)()
    end
end

load_folder('src/joker')

[sturdy compass]

well what's line 96 in cosmere.lua

[rugged pier]

line 96 is SMODS.load_file(folder .. '/' .. file)()

so my lua file is not compiling or something?

[cerulean rose]

yeah seems like a syntax error

[tawny narwhal]

whenc checking poker hands what is the name for High card? Surely There's somewhere that has all this stuff listed...

[rugged pier]

cannot for the life of me figure out whats wrong though, i checked every loop, if statements, etc

[cerulean rose]

send the whole file

[rugged pier]

--Hammond: This Jokers gains +4 Mult for each Stone Card in your full deck
SMODS.Joker {
    key = 'hammond',
    atlas = 'scadrial',
    pos = { x = 0, y = 0 },
    rarity = 'csmr_preserver',
    cost = 4,
    unlocked = true,
    discovered = true,
    blueprint_compat = true,
    config = { extra = { mult_mod = 4, stone_tally = 0 } },
    loc_vars = function(self, info_queue, card)
        return { 
            vars = { 
                card.ability.extra.mult_mod,
                card.ability.extra.stone_tally * card.ability.extra.mult_mod,
            } 
        }
    end,
    calculate = function(self, card, context)
        if context.joker_main and card.ability.extra.stone_tally > 0 then
            return {
                mult = card.ability.extra.stone_tally * card.ability.extra.mult_mod
            }
        end
        if context.before and not context.blueprint then
            card.ability.extra.stone_tally = 0
            for k, v in pairs(G.playing_cards) do
                if v.config.center == G.P_CENTERS.m_stone then 
                    card.ability.extra.stone_tally = card.ability.extra.stone_tally + 1
                end
            end
        end
    end
}

This is the only new thing in this file

[sturdy compass]

How do you know this is the joker that's causing it?

[rugged pier]

every other joker worked, i keep adding to the file as and when i get new ideas

this is the one that broke it

[crystal snow]

is there a way to get a table of all the jokers in the game? (i'm looking to get all the keys)

[sturdy compass]

I think G.P_CENTERS holds them all (along with all consumables)

[rugged pier]

any ideas as to what could be breaking the file?

[sturdy compass]

Have you tried removing the file from your folder just to experiment to see if it really is that causing the issue?

If you can 100% confirm it's this file that's the problem it will help a ton

[manic rune]

have u tried using assert to load ur file

:3

[sturdy compass]

belis loves to assert dominance

[rugged pier]

oh my god

im such a ding dong

[rugged pier]

youre so right, i shouldnt be so confident in my old code :3

i removed a condition in an if statement and forgot to remove "and" from that condition

[sturdy compass]

[rugged pier]

sigh

[rugged pier]

new question, the joker only calculates stone cards in context.before

but

what if the user adds new stone cards, the joker description wont auto update to reflect the new stone cards

like the stone joker does in real time

what context would i use?

[sturdy compass]

You wanna do that in an update function instead of calculate

[rugged pier]

theres an update function??

[sturdy compass]

https://github.com/Steamodded/smods/wiki/SMODS.Joker

Check the API methods

[stark geode]

I wonder if I could make a joker that just rips wheels of fortune

Like a specific number

[rugged pier]

oh wow, dont know how this page went unnoticed

thank you

[sturdy compass]

It's how I have my Minimalist Joker up and running

[sturdy compass]

np np

[rugged pier]

do you mind sharing your update function :3

[sturdy compass]

update = function(self, card, dt)
    local stg = card.ability.extra
    if G.STAGE == G.STAGES.RUN then
        stg.chips = stg.base_chips
        for k, v in pairs(G.playing_cards) do
            if next(SMODS.get_enhancements(v)) and stg.chips > 0 then
                stg.chips = stg.chips - stg.dChips
            end
        end
    end
end

[rugged pier]

goat

[sturdy compass]

Should be able to pretty easily adapt that to check for stone cards

[rugged pier]

i just took what i had under context.before and put that under G.STAGE == G.STAGES.RUN

[sturdy compass]

That should work I think

[rugged pier]

whats the stg

for

[sturdy compass]

That's just a way to make accessing card.ability.extra more convenient for myself

[rugged pier]

ah i see the use for it now

awesome

[sturdy compass]

so I'd just have to type stg instead of card.ability.extra

[rugged pier]

makes sense

[sturdy compass]

Thank you random person in chat like a month ago for enlightening me

[radiant plank]

hey for the context.selling_card how do i get the sell value of the card being sold? im only seeing it for the joker that owns the calculate function

[rugged pier]

it worked!!!

thank you so much :)

[radiant plank]

im guessing its stored somewhere in context but im not seeing where it would be on the wiki

[sturdy compass]

try context.card.cost

context.card is a reference to the card being sold

[radiant plank]

thanks will try this

[manic rune]

good morning everyone

[sturdy compass]

gm

[radiant plank]

thanks jerome that worked

[sturdy compass]

please call me astra lmfao

[radiant plank]

you got it maximus astra

[sturdy compass]

😭

[radiant plank]

i said it correctly

[sturdy compass]

Close enough ig

[manic rune]

hi john

[sturdy compass]

hello bepis/belis/craig/bella

[manic rune]

hi mark

[sturdy compass]

https://tenor.com/view/tommy-wiseau-oh-hi-mark-hey-mark-gif-17296134

[manic rune]

https://tenor.com/view/cat-kitty-kitten-zoom-persuit-gif-17646381782073725526

[sonic cedar]

did i do it right,,,, this is within calculate this time NOT loc vars like an idot

[modern kindle]

Hi bepis

[manic rune]

do i need to_big this one

:3

hi dilly

[sonic cedar]

i mean it's chips

[manic rune]

i think

context.destroy_card will cycle through every card in your playing hand, hand and deck (this is an optional feature)

since, yk

returning true will destroy it

[sonic cedar]

so,,,, i did it,,,? glass joker transplanted,,?

(i mean of course theres the other contexts but PLEASE

[brazen tusk]

what exactly does ipairs mean?

its used in most for loops i see people here doing

[sonic cedar]

it's just pairs but for arrays
so iteration through an entire array instead of just a table

also ipairs does index

(hence the

the i)

[faint yacht]

How do I check current deck again?

[brazen tusk]

ahhh

[rugged pier]

is there a way to make debuffed cards score?

[sonic cedar]

you can do that?

[stark geode]

Id look but

I'm in bed on my phone

I'm getting better at reading the sacred texts

[sonic cedar]

it MIGHT be G.GAME.selected_back.name?

[manic rune]

???wtf happened

i just reloaded my run

😭

am i cooked chat

[rugged pier]

nah youre cooking

naneif on a 1050 round

[manic rune]

nane NEGATIVE inf

[ionic cobalt]

nan e negative inf

so its basically infinitely small

[rugged pier]

bump

[rugged pier]

how the flip do you accomplish this

[manic rune]

talisman shenanigans

idfk

[rapid stag]

...i can't do this like this?
oh, i didn't notice the malformed property, why did it not paste the full G.GAME.round_resets.ante when i copied it wtf

[sturdy compass]

Why do your screenshots have aura wtf lol

[rapid stag]

funny sharex post-image processing

[sonic cedar]

lost my shit

[brazen tusk]

imma be real i have no idea how for loops work, how would i fit a destroy into this?

[rapid stag]

under what condition do you need the destroy to occur

[sturdy compass]

G.GAME.round_resets.

You have a hanging . Lol

[rugged pier]

calculate = function(self, card, context)
        if context.individual and context.cardarea == G.play and context.scoring_hand then
            if context.other_card.debuffed then
                if pseudorandom('cladent') < G.GAME.probabilities.normal/card.ability.extra.odds then
                    --WHAT DO I DO HERE? I NEED TO MAKE THE CARD UN-DEBUFFED
                end
            end
        end
    end

any ideas?

[daring fern]

That probably requires a patch.

[rugged pier]

wdym

[rapid stag]

yeah just noticed it

[daring fern]

You need to use lovely to patch code into the game but im not too familiar with patching so I can't help with that.

[rugged pier]

ah

alternatively

is there a way to remove the boss blind for a hand played

and add it back

since that would remove the debuff anyway

[minor furnace]

can you disable the content of other mods for your own custom challenges?

[sturdy compass]

Btw if it does work for Jokers do tell cuz I do wanna do something with that

[rapid stag]

you mean adding a seal or if the seal itself works? because i have just tested adding the seal and adding the seal works. yet to see if the seal itself works though

[sturdy compass]

Adding a seal. Ok cool good to know

[rapid stag]

it's very funky though, it like, adds the seal graphic before doing the animation on the joker
and if i call :juice_up() beforehand, it feels a little off. not sure what's going on there

[sonic cedar]

bepis,,,,,,,,,, how do i,,,,,,,,,,,,,,, do this for remove_playing_cards,,,,,,,,,,,,,,,

[brazen tusk]

if the played card is a heart

[sturdy compass]

I don’t think set_seal goes on an event basis. Try wrapping it in an event manager

[rapid stag]

ah, will do

[rapid stag]

well i'm no expert on destroying cards, but try card:start_dissolve()

might probably need to be in an event manager first

[sturdy compass]

start_dissolve actually does work on an event basis by default lmao

We love inconsistency

[rapid stag]

thank you localthunk, very cool

[minor furnace]

if it works it works

[minor furnace]

has anyone tried to do this before?

[faint yacht]

G.GAME.selected_back.effect.center.key, actually. ⛓️‍💥

[rugged pier]

calculate = function(self, card, context)
        if context.setting_blind then
            if pseudorandom('cladent') < G.GAME.probabilities.normal/card.ability.extra.odds then
                if G.GAME.blind and ((not G.GAME.blind.disabled) and (G.GAME.blind:get_type() == 'Boss')) then 
                    G.E_MANAGER:add_event(Event({trigger = 'after',delay = 0.5,func = function()
                        card_eval_status_text(context.blueprint_card or self, 'extra', nil, nil, nil, {message = localize('ph_boss_disabled')})
                        G.GAME.blind:disable()
                        return true end }))
                end
            end
        end
    end

h e l p

[modern kindle]

Can't you just put them on the challenge blacklist or whatever

[faint yacht]

...why are you using self?

[rugged pier]

facepalm

omg

[faint yacht]

Maybe if such is integrated into the mod itself?

[minor furnace]

I don't see a place in the SMODS.Challenge documentation that would let me do that. And it would probably be easier to figure out how to whitelist my own mod instead of trying to blacklist others

honestly the best implementation I can think of is to either hook or patch the get_current_pool() function directly and remove things from the pool there

[rapid stag]

it makes it even worse

[edgy reef]

restrictions is a challenge blacklist.

[sturdy compass]

[edgy reef]

Prob doesn't cover everything by itself but most vanilla-based objects are covered.

[sturdy compass]

Show code

[rapid stag]

                local jkrsToSeal = {}
                local finalSealChoice = nil
                
                for i, jkr in ipairs(G.jokers.cards) do
                    if not jkr.seal then
                        table.insert(jkrsToSeal, jkr)
                    end
                end
                
                if #jkrsToSeal > 1 then
                    finalSealChoice = pseudorandom_element(jkrsToSeal, pseudoseed('randJokerSeal'..G.GAME.round_resets.ante))
                else
                    finalSealChoice = jkrsToSeal[1]
                end
                
                if finalSealChoice ~= nil then
                    finalSealChoice:juice_up()
                    G.E_MANAGER:add_event(Event({
                        trigger = 'after',
                        delay = 0.005,
                        blocking = false,
                        func = function()
                            finalSealChoice:set_seal(card.ability.extra)
                            return true
                        end}))
                end
            end```

[sturdy compass]

Would you mind sending it via screenshot? I’m on mobile 😭

[minor furnace]

this reads like I would have to manually list out every card, tag, and blind from every possible mod, which I cannot do if I don't know what mods people have installed

[minor furnace]

I want to make it so that only my mod's content can appear during my challenge run

[rapid stag]

speaking of, is there like, a table of every single say, joker key that is in the game, that i can just iterate through

[radiant plank]

for localization with localization files whats a clean way to not have to rewrite default.lua to be en-us.lua

like does lua have a built in #include like in c that just expands the file given into the source of the calling file

[faint yacht]

Technically G.P_CENTERS... but it has everything.

[minor furnace]

all jokers are prefixed with j_ though

so it would work

[sturdy compass]

I’m curious of what would happen without the juice up call

[sturdy compass]

Could also check for the set

[minor furnace]

that would probably be a better implementation

[edgy reef]

oh uh yeah then you'd have to write extra code for that.

[minor furnace]

yeah

[tawny narwhal]

Where would I look to figure out how to have a joker destroy itself and turn into another joker? Similar to Ghost, except it turns into a spcific card.

[edgy reef]

Probably just setting each table with a __index metamethod that always returns true if it's not a part of the curated object list.

[rapid stag]

see what i mean about the seal appearing before the anim?

...or is that how set seal goes normally and i just never noticed

[minor furnace]

I can probably just hook get_current_pool()

[edgy reef]

Probably more advanced than needed

[sturdy compass]

Double check with a Deja Vu rq

Cuz idk either lol

[edgy reef]

(about metamethod not get_current_pool)

[last sentinel]

does the core game/SMODS allow consumables to be perishable?

[sturdy compass]

No clue but it’d be worth testing

[last sentinel]

doesnt seem like :set_perishable works on them like it does for jokers

[sturdy compass]

Have you taken a look at the code for that function? It could be specifically checking for set == joker

[rapid stag]

yeah, the seal is definitely with the anim when deja vu does it

i feel correct about it being off in this instance

[sturdy compass]

Suuuuuper weird

I’d check the code for set_seal myself to see what gives but like I said, mobile :(

[last sentinel]

yeahh it checks to see if the card is perishable_compat. I went around it by just setting perishable = true which successfully gives them the stickers, but it might cause an unavoidable crash

[sturdy compass]

Ah that makes sense. Honestly though I could see it working out fine

[rapid stag]

well i'm wondering about the args here - set_seal(_seal, silent, immediate) - do you know if, when called, immediate is true by default?because i don't see any indication that it is

i'm wondering if deja vu calls it with immediate being true

[sturdy compass]

Ykw I don’t think it is true by default. Try that

[sturdy compass]

Ouch

[rapid stag]

yep, calling it with the immediate arg as true fixed it

[sturdy compass]

Ofc LOL

[sonic cedar]

save me astra im begging you

[sturdy compass]

I’m jim support tonight

What’s triggering that causes it to die

[sonic cedar]

i started a blind

[sturdy compass]

Do you have anything checking for that?

[sonic cedar]

no

[sturdy compass]

Hrrrm

[sonic cedar]

the crash:

[sturdy compass]

What is that line in utils.lua

[sonic cedar]

i will go look

[sturdy compass]

Would you mind showing the full block lol

Context is key

[rapid stag]

and now i have a function problem - when scoring, the red seal on any joker basically just acts like seltzer

[sturdy compass]

Ok so it’s happening because something is trying to add mult when you’re setting the blind I think??

[sturdy compass]

You’re probably gonna have to take ownership of the seal and specify the functionality it should execute depending on if the card it’s on is a joker or a playing card

[sonic cedar]

but none of my contexts are setting_blind....

[sturdy compass]

What Jokers did you have in hand at the time of the crash (if any)

[last sentinel]

nah i was right it crashes

[sturdy compass]

Damn

[sonic cedar]

just the one im trying to do

[rapid stag]

where can i find the default functionality of seals

[sonic cedar]

(im transplanting glass joker)

[sturdy compass]

This is firing off every time calculate is called because it’s in an else block, and thus context.setting_blind triggers it

[sonic cedar]

so i need to do an elseif [whatever] then ?

[sturdy compass]

Just search “[COLOR] Seal]” in card.lua

Actually calculate_seal would be better

[tawny narwhal]

What function do I use to transform one joker into another (I.e. it turns into a different Joker)

[sturdy compass]

It depends, when are you trying to have this trigger?

[sonic cedar]

card:set_ability

[sturdy compass]

card:copy_card I believe

Check the death code

[sonic cedar]

it's set_ability

[tawny narwhal]

where is said death code

[sturdy compass]

card.lua

ctrl + F and search for death

[sonic cedar]

that else statement is supposed to be during scoring when the xmult value is greater than 0

[sturdy compass]

Well the way you have it set up currently has it trigger if it’s not context.joker_main and not xbase <= 0

[sonic cedar]

oh

so just move the if down a peg

[sturdy compass]

So you need a second set of conditionals within the context.joker_main conditional to handle the xbase comparisons

Or you could just make it easy and check if xbase is > 0 in the same line and ditch the else lol

[spiral crown]

Hello! New to modding and was hoping for some help with my first mod
I have made the json file with the drag and drop info from the Steam modded documentation but I can't get the mod to appear in game
this is what I have in json file

[tawny narwhal]

I had a similar thing, removing badge colour and text colour fixed it for me

[manic rune]

i was having lunch, im sorry 😭

did u fix it

[sonic cedar]

here with astra doing exactly that

i have no idea

ok granted this is a different issue

[sturdy compass]

I’m being Joe Helpful

[manic rune]

❤️

[tawny narwhal]

I'm ngl I can't seem to make this work

[spiral crown]

unfortunately that didn't fix it, Tried removing the info and deleting the lines as well

[sonic cedar]

why ping me if you’re using the death method 😭

[tawny narwhal]

I'm not

[sturdy compass]

Can you show the contents of your mod folder?

[tawny narwhal]

I'm talking about set_abilityu

[sonic cedar]

oh well in that case whaddya have

[tawny narwhal]

was gonna say, have you got the mod folder layout down

[sonic cedar]

does using_consumeable use context.removed in the ipair

[tawny narwhal]

Nothing so far, I can't make sense of how set_ability is used

[manic rune]

dunno, never used that before

💔

[sonic cedar]

crying

[sonic cedar]

well you wanna put it in an event

[sturdy compass]

Nothing immediately sticks out as wrong here. I wish I could cross reference with my mod but I cannot

[tawny narwhal]

SMODS.Joker {
    key = 'stellar_collapse',
    loc_txt = {
        name = 'Stellar Collapse',
        text = {
            "After {C:attention}#2# High Card{} hands,",
            "collapses into {C:legendary}Singularity{}.",
            "{C:inactive}(Currently {C:attention}#1#{C:inactive} hands played)",
        }
    },
    config = { extra = { high_card_count = 0, high_card_limit = 20 } },
    rarity = 2,
    atlas = 'collapseatlas',
    pos = { x = 0, y = 0 },
    cost = 6,
    loc_vars = function(self, info_queue, card)
        return { vars = { card.ability.extra.high_card_count, card.ability.extra.high_card_limit } }
    end,

    calculate = function(self, card, context)
        if context.before and next(context.poker_hands['High Card']) and not context.blueprint then
            -- Increment count
            card.ability.extra.high_card_count = card.ability.extra.high_card_count + 1
            
            -- Check if it should transform
            if card.ability.extra.high_card_count >= card.ability.extra.high_card_limit then
                return {
                    message = "Gravitational Collapse!",
                    colour = G.C.LEGENDARY,
                    card = card,
                    action = function()
                        card:set_ability -- NO CLUE WUT TO DU
                    end
                }
            end

            -- Normal progress message
            return {
                message = "Collapsing...",
                colour = G.C.ATTENTION,
                card = card
            }
        end
    end
}

[tawny narwhal]

Imma hail mary it and hope you guys (smart people) can help out

[rapid stag]

i'm thinking i maybe need to patch calculate_seal() instead? this is kinda melting my mind, i don't really understand like, at all

i kinda get that it's calling calculate and acting like the seal is on every card?

[sonic cedar]

i was saying set_ability cause it's what ive been doing for like,,,, oh my god its been a month,,,

[tawny narwhal]

A month?

[sonic cedar]

oh my god beta whomp

[sonic cedar]

(joker im working on)

[tawny narwhal]

I see

[sturdy compass]

Actually I wonder if that function got overriden by SMODS

[rapid stag]

the screenshot is of the dumped card.lua

[radiant plank]

how do i check when a tarot card is used in my calculate function?

[manic rune]

how do i save stuff in a blind that wont get reset when i re-enter a run

[spiral crown]

dang, thanks anyway

[manic rune]

asides from G.GAME

does self.config work?

[rapid stag]

it'll be under context.consumeable

[tawny narwhal]

Where do I store a sound in the mod folder? I hadn't considered that, but now I want to do it. Also, does it have to be initialised beforehand?

[radiant plank]

thanks, overlooked that. how can i check that the consumeable is a tarot?

[sturdy compass]

I’m aware but I suspect it’s something to do agnostic of patches

I just can’t find it tho

[sonic cedar]

either this doesn’t work or i was supposed to do elseif

[rapid stag]

context.consumeable.ability.set == "Tarot" should work

[sturdy compass]

What does it look like now

[sonic cedar]

one moment

having discord pc open with balatro and vscode equals

no memory

[sturdy compass]

Ouchie

[sonic cedar]

my pc sucks

did my discord crash on opening

there we are

there we aren’t im in a loading l—

i should close balatro

[sturdy compass]

Yes

[sonic cedar]

wait i don’t need to show the transform code it’s just taking up screenshot space

much better

[sturdy compass]

So no matter what it should give xmult during joker_main?

[sonic cedar]

yes

[tawny narwhal]

@sonic cedar I tried using your structure and got this when the event should have happened

[rapid stag]

...hghh, so if i take ownership of the red seal, should i be doing calculate = function(self, card, context) or calculate_seal = function(context)

[last sentinel]

Anyone got any bright ideas as to why this puppy would be crashing with "attempt to index local card (a nil value)" ?

[sturdy compass]

just calculate

[sonic cedar]

what did i miss this time

[sonic cedar]

can you send

[faint yacht]

assets/sounds/filename.ogg + SMODS.Sound

[tawny narwhal]

I gurentee I am the one who goofed it

[sonic cedar]

i dont

😭

[tawny narwhal]

 -- Check if it should transform
            if card.ability.extra.high_card_count >= card.ability.extra.high_card_limit then
                G.E_MANAGER:add_event(Event({
                    trigger = "after",
                    delay = 0.15,
                    func = function()
                        card:set_ability(G.P_CENTERS("j_LSingle_singular"))
                        card:juice_up(0.3, 0.3)
                        return true
                    end,
                }))
            end

[sturdy compass]

And it just doesn’t?

[sonic cedar]

it does a little thing called

crash my game when i select a blind

[sturdy compass]

I’d ask you to hand over the code so I could start digging if I could do work on it lol

[sonic cedar]

but…?

nvm i read with my eyes

[spiral crown]

deleted the comments (or what I assume are comments, I have no experience with json) json file and now its being detected, just figured I would let you know in case anyone else asks lol

[sonic cedar]

and LSingle is your mod prefix right

[tawny narwhal]

yea

wait

maybe

[sonic cedar]

https://tenor.com/view/ishowspeed-try-not-to-laugh-gif-7682731162751353849

[tawny narwhal]

It is now

[sonic cedar]

IT IS NOW 😭

[sturdy compass]

[manic rune]

??????????????????????????

BRO IM TESTING

😭

[sonic cedar]

NOT YOU TOO

[sturdy compass]

Insane

[manic rune]

oh nvm we good

[sturdy compass]

Kill

@ aikoyori

[last sentinel]

bumpsies

[tawny narwhal]

Still the same error

P_CENTERS seems to be the error cause for some reason

[sturdy compass]

gifted_card is being instatiated within the scope of the conditional statements and therefore doesn’t exist elsewhere in the block. Define the variable before assigning it a value in your conditionals

[sonic cedar]

is the joker you’re transforming into one that you have in existence

[tawny narwhal]

In existasnce?

yes

wait

would it being a legendary mean anything? I wouldn't think so...

[sonic cedar]

no that’s fine lmao

[tawny narwhal]

thought so

[manic rune]

https://streamable.com/2g9fd2

[sonic cedar]

and what’s the id of the joker you’re transforming into

[tawny narwhal]

'singular'

[sonic cedar]

and NOT the joker you’re transforming FROM right

[tawny narwhal]

no, Joker I'm transforming from is 'stellar_collapse'

[sonic cedar]

is

is this in a context

[tawny narwhal]

I don't think so

Sorry man I just started learning lua yesterday

My base of knowledge is using python and MatLab lmao

[rapid stag]

yeah i think the problem is with calculate_seal(). it doesn't really matter what i do to the seal itself, since as i showed in the calculate_seal() screenshot, i think it's being run on the card side? and is checking the type of seal itself? and just repeating if it sees a red seal somewhere in the calculation? because this is what i wrote to try and make it not do what i showed

and not only did it keep doing what i showed, it didn't print either of those things once

[sonic cedar]

ok so when do you want this to trigger

[tawny narwhal]

Once 20 high card hands have been played

[rapid stag]

i think what i need to do is patch calculate_seal and have it differentiate between the seal being on a card and being on a joker.

[tawny narwhal]

Wait so yes, it is in a context

if card.ability.extra.high_card_count >= card.ability.extra.high_card_limit then

[sturdy compass]

You can try that and I wish you luck. I hope you get it to work. I’m just really sketched out by how it just works on a Joker like that

[sonic cedar]

that’s not a context 😭

[tawny narwhal]

clearly I have an enormous brain

so what have I missed here?

[sonic cedar]

ok so

take your code there

put it within

if context.joker_main then

[tawny narwhal]

Oh you right

so like...

[sonic cedar]

joker_main is the main scoring step for jokers

[tawny narwhal]

Oh okay

well I have put it in if context.before and next(context.poker_hands['High Card']) and not context.blueprint then

Like the card functions correctly right up until it should transform

So I think it's the transforming that blows it all up

[sonic cedar]

you had it in a context this whole time i

ok

send the whole block

[manic rune]

https://streamable.com/eo9m22

AND THATS THE ENTIRE BOSS DONE

[tawny narwhal]

Yea... I feel real bad for you having to put up with my noobiness

[sonic cedar]

it’s chill

[minor furnace]

after fooling around with it for a while, I feel like it's too much work to force disable other mods' content for my own challenges...

[tawny narwhal]

SMODS.Joker {
    key = 'stellar_collapse',
    loc_txt = {
        name = 'Stellar Collapse',
        text = {
            "After {C:attention}#2# High Card{} hands,",
            "collapses into {C:legendary}Singularity{}.",
            "{C:inactive}(Currently {C:attention}#1#{C:inactive} hands played)",
        }
    },
    config = { extra = { high_card_count = 0, high_card_limit = 20 } },
    rarity = 2,
    atlas = 'collapseatlas',
    pos = { x = 0, y = 0 },
    cost = 6,
    loc_vars = function(self, info_queue, card)
        return { vars = { card.ability.extra.high_card_count, card.ability.extra.high_card_limit } }
    end,

    calculate = function(self, card, context)
        if context.before and next(context.poker_hands['High Card']) and not context.blueprint then
            -- Increment count
            card.ability.extra.high_card_count = card.ability.extra.high_card_count + 1
            
            -- Check if it should transform
            if card.ability.extra.high_card_count >= card.ability.extra.high_card_limit then
                G.E_MANAGER:add_event(Event({
                    trigger = "after",
                    delay = 0.15,
                    func = function()
                        card:set_ability(G.P_CENTERS("j_LSingle_singular"))
                        play_sound("CollapseBoom")
                        card:juice_up(0.3, 0.3)
                        return true
                    end,
                }))
            end

            -- Normal progress message
            return {
                message = "Collapsing...",
                colour = G.C.ATTENTION,
                card = card
            }
        end
    end
}

[rugged pier]

have you considered using the Potatro mod for balatro

[sonic cedar]

i have not

i chose suffering willingly

…plus i can just run discord on my phone

[rugged pier]

true, just less of a hassle having everything open in one place

[minor furnace]

sounds like someone has 8 gigs of ram

[tawny narwhal]

Wait this counts high cards played before this joker is aquired doesn't it...

I think...

[daring fern]

It shouldn't.

[rugged pier]

not possible

wait

[radiant plank]

@rapid stag quick question, do you know how to get the key of the consumeable that's used? seems to be nil for context.consumeable.key and context.consumeable.ability.key.

[rugged pier]

no

[tawny narwhal]

LEmme test, I have no idea what I'm doing

[rugged pier]

yes youre right, it does

let me show you how i implemented something like this

[minor furnace]

I don't believe it does

[daring fern]

It should only be calculating when the joker is present.

[sonic cedar]

card = card is redundant btw

[rapid stag]

i don't, but you can do print(tprint(context.consumeable)) and that should output the entire table to the lovely console so you can find the key

[radiant plank]

AWESOME

[rugged pier]

hes checking the total times highcard is played in the run no?

[radiant plank]

thanks that's so useful i didn't know that existed

[rugged pier]

so it will count those instances of high cards being played

[tawny narwhal]

The mod examples on smods github says it has a purpose? Idrk... I trust you tho

[minor furnace]

it would only count the ones before if you did something with G.GAME.hands[k].played

[rugged pier]

ah nvm

i misread his code

[sonic cedar]

i knew i wasn’t crazy

[rugged pier]

it has a purpose if youre doing an action on a card that is not your joker, since by default it happens on your joker anyway

[daring fern]

Also, i think you should use context.scoring_name == "High Card" instead of next(context.poker_hands['High Card'])

[tawny narwhal]

ahh

[rugged pier]

for example if your joker is putting a message on a played card, it would be card = v (assuming you made a loop where v is the played card)

[tawny narwhal]

What would that change? It works atm.

[rugged pier]

just good practice

[tawny narwhal]

valid

[minor furnace]

have you tried playing something other than a High Card with it?

[daring fern]

Your current code checks if your hand contains high card, the modified code is only high card.

[tawny narwhal]

If i have I dont remember

[minor furnace]

every hand contains a high card

[sonic cedar]

did you want it to contain or be

[tawny narwhal]

ooooooooh

[rugged pier]

the point is, it will trigger everytime you play a hand

[sonic cedar]

if BE a high card yeah use the modified code

if contains a high card leave it how it is

[rugged pier]

im sure OP doesnt want it to be "contain" since he wouldnt need the check anyway

everytime hand is played just do effect lol

[sonic cedar]

it’s the first day let em cook 😭

[rugged pier]

true

[tawny narwhal]

Nah he right though

[rugged pier]

did you end up using talisman @tawny narwhal

[minor furnace]

I've really been modding this game for a month and a half now...

[tawny narwhal]

In the pursuit of good practise, what would I do for it being only a single card scored?

[sonic cedar]

don’t remind me,,,,

[tawny narwhal]

Nah I changed the whole concept of the card

[rugged pier]

real

[tawny narwhal]

Dependency is a next week kinda thing

[sonic cedar]

the modified code

[rugged pier]

yall get this good in a month?? i have a steep learning curve to look forward to then...

[minor furnace]

I literally started the day I joined the server. I literally joined the server because I wanted to write a mod

[sonic cedar]

who is this yall you speak of

[minor furnace]

I also have a bachelor's in CS so uhhhh

[rugged pier]

skyward

[rugged pier]

oh valid

im a pesky business major that loves coding and wishes he went into CS instead

[ionic hill]

One message removed from a suspended account.

[sonic cedar]

nested if statement

[rapid stag]

i mean, it makes sense because jokers and cards basically have the same structure - but it's weird that it behaves like that.

anyway, this is what i patched calculate_seal() to be and this is where it got me.

but now i need to work out how to make it retrigger the joker

[ionic hill]

One message removed from a suspended account.

[ionic hill]

One message removed from a suspended account.

[minor furnace]

recursive functions

[rugged pier]

NO

[sonic cedar]

now how were YOU gonna run it 😭

[rugged pier]

NO RECURSIVE FUNCTIONS UNDER MY WATCH

[minor furnace]

I wrote a recursive function to make my Omnirank enhancement work

[ionic hill]

One message removed from a suspended account.

[sonic cedar]

bad skyward bad

[rugged pier]

i have no idea what the use case would even be in balatro for recursion

am i just stupid

[sturdy compass]

Probably have to do some shenannigans with the optional joker retriggering SMODS option

[rugged pier]

on another note, i have 70 hours in the game and the last 20 hours are just creating mods...

love opening and closing the game 15 times for minor changes

[sturdy compass]

I wanna say at least 95% of my hours were spent modding

[rugged pier]

whats your total time

[minor furnace]

I created a card that can count as any rank, and I needed a way to iterate through the possible values regardless of how many there were in the played hand. However, this grows exponentially with the number of cards, so it does something different if four or more of them are played, because by the game's logic there's only a few hands you can make because it always picks the highest scoring hand

[rugged pier]

scary.

[sturdy compass]

80 hours

[rugged pier]

doesnt this break the game, i swear i saw someone talk about it in #1155557846805643434

[rugged pier]

wow

[minor furnace]

break the game how?

[faint yacht]

https://github.com/TheOneGoofAli/TOGAPackBalatro/blob/20a4d9d2d930cb22daa22c01930aaafb67656daf/togastuff.lua#L1336-L1399 2 of recursive them.

[rugged pier]

not functionally, just like playability since its to powerful

[minor furnace]

ohhh like balance-wise

[rugged pier]

yeee

[minor furnace]

idk

[rugged pier]

too late for my brain to comprehend code

[minor furnace]

I did it because I thought it would be fun

[rugged pier]

do you have it uploaded on a mod, id love to see it

[minor furnace]

I also had to patch literally every base-game joker that does something with ranks

[minor furnace]

https://discord.com/channels/1116389027176787968/1343446475018997832

[rugged pier]

yikes, what happens when someone adds mods that adds other jokers

[tawny narwhal]

I've put this in but the lua checkerator says I can't assign boolean to parameter table

[minor furnace]

not compatible with those lol

[rugged pier]

rip

[daring fern]

Where?

[daring fern]

You need to remove the next()

[tawny narwhal]

Bruh

you right

[minor furnace]

What the base game does when it wants a rank is it uses if card:get_id() == 14 for something like Scolar. And there's no useful way to override get_id() for Omnirnak so I had to edit the base game code

[rugged pier]

how do you edit base game code?

[minor furnace]

every instance of card:get_id() I replaced with a boolean function is_rank(card, {2,3,4}) to compare against all necessary ranks

[minor furnace]

with these things called patches

you can also hook functions which is less intrusive and less likely to have issues with other mods

[rugged pier]

omg how long does this even take 😭

you have to go through the entirety of the cards.lua file and pick out every joker and other abilities therein

[minor furnace]

don't worry about it 🙃

[rugged pier]

also blinds that dont allow a certain hand type being played

or repeated hand types

[minor furnace]

I had gotten Completion++ by that point so I more or less already knew which jokers did things with rank

[rugged pier]

i have much to learn

[rugged pier]

jesus how many hours do you have in the game

[tawny narwhal]

Okay guys.... I swear I'm making progress

When it goes to trnasfrom, I'm still getting this

ALSO

[minor furnace]

Got C++ at around 236, and since modding it says I've had the game running for 427. But most of that additional time is just idle because I was too lazy to close it while coding

[tawny narwhal]

Debuffed cards still count, how I stop that?

[rugged pier]

send your code again?

[rugged pier]

wow, respect

[tawny narwhal]

SMODS.Joker {
    key = 'stellar_collapse',
    loc_txt = {
        name = 'Stellar Collapse',
        text = {
            "After {C:attention}#2# High Card{} hands,",
            "collapses into {C:legendary}Singularity{}.",
            "{C:inactive}(Currently {C:attention}#1#{C:inactive} hands played)",
        }
    },
    config = { extra = { high_card_count = 0, high_card_limit = 20 } },
    rarity = 2,
    atlas = 'collapseatlas',
    pos = { x = 0, y = 0 },
    cost = 6,
    loc_vars = function(self, info_queue, card)
        return { vars = { card.ability.extra.high_card_count, card.ability.extra.high_card_limit } }
    end,

    calculate = function(self, card, context)
        if context.before and context.scoring_name == "High Card" and not context.blueprint then
            -- Increment count
            card.ability.extra.high_card_count = card.ability.extra.high_card_count + 1
            
            -- Check if it should transform
            if card.ability.extra.high_card_count >= card.ability.extra.high_card_limit then
                G.E_MANAGER:add_event(Event({
                    trigger = "after",
                    delay = 0.15,
                    func = function()
                        card:set_ability(G.P_CENTERS("j_LSingle_singular"))
                        play_sound("CollapseBoom")
                        card:juice_up(0.3, 0.3)
                        return true
                    end,
                }))
            end

            -- Normal progress message
            return {
                message = "Collapsing...",
                colour = G.C.ATTENTION,
                card = card
            }
        end
    end
}

[rugged pier]

theres a context for debuffed hand

[radiant plank]

how exactly does the SMODS.create_card function work? im using it to create a tarot card but its not putting the card in my consumeables

i can just drag it around the screen and everything

[daring fern]

You can just do card:set_ability("j_LSingle_singular")

[rugged pier]

what is line 92 here?

[radiant plank]

im specifying the area field for the table

[tawny narwhal]

card:set_ability(G.P_CENTERS("j_LSingle_singular"))

[rugged pier]

what the other person said

[tawny narwhal]

Legend

[tawny narwhal]

what is that specifically

I'm being hard carried rn

[rugged pier]

honestly dont know this lol, i tried to implement it for something today, ended up scrapping it. might reimplement it at some point later

[minor furnace]

no clue, I don't use SMODS.create_card, I do

card:add_to_deck()
G.CardArea:emplace(card)```

[rugged pier]

time for me to sleep