💻・modding-dev

[crisp coral]

so i haven't been keeping up with smods changes, were there any that makes created cards not use Card:set_sprites?

function Card.set_sprites(self, _center, _front)
    set_spritesref(self, _center, _front)

    if next(SMODS.find_card("j_lobc_youre_bald")) and (self.ability and not self.ability.lobc_censored) then
        if _center then print("has center") end
    end
end

the center print line isn't being called when a card is created

[opal spade]

set sprites is a part of set ability and it happens before any of set ability unless it's a playing card

[opal spade]

self.ability doesn't exist upon first set_sprites

[crisp coral]

thing is, this worked before

exact same code

[opal spade]

the way i bypass this issue is by calling set sprites within my set ability so the sprite is set correctly even on creation

but idk if that'd work for this

[crisp coral]

oh wait-

fuck that was the issue

maku_dies

before it was just if next(SMODS.find_card("j_lobc_youre_bald")) then

okay thank you!!!

[royal seal]

Yeah I think that should work?

[brisk rose]

yeah, I downloaded mono, and figured out the parent .cs was Program.cs, but got this error:
```"Program.cs(5,22): error CS0234: The type or namespace name Forms' does not exist in the namespace System.Windows'. Are you missing `System.Windows.Forms' assembly reference?"

Seems to be a thing that can't be directly fixed on linux. Ofc Wine being Wine. I'm sure there's still a way, just not savvy enough personally

[tepid crow]

iirc there are other tools for generating code for steamodded api jokers btw

[brisk rose]

the only one I know didn't get nearly as far iirc

[tepid crow]

there's https://github.com/tyuugy/tomFoolery (I think you've seen this one already) and there's https://www.balaui.dev/joker

those were the 2 I could find quickly at least

[brisk rose]

yeah the second one seems to be more at parity with Steak's

wonder why there doesn't seem to be a thread here?

[tepid crow]

there is

[brisk rose]

ah must've missed it

my b

[wintry solar]

it also encourages localization files which gets a big 👍 from me

[brisk rose]

loc_txt ride til I die :P

not because it's better but because I'm lazy and like the aesthetics, lol

[royal seal]

Nice, that balaui one looks sick

Still not a waste though, because I like having a personal tool for my own use

[brisk rose]

seriously though, not even having an option for loc_txt (that I can see) on balaui blows. It's not that I don't want my mod to be translatable, I just... really really prefer the object to just... have everything

Especially because I'll be making jokers that are identical for multiple suits, flounders-mod style

(suits will have their uncommons/rares (snow's mods style coins and fusion-jokers style 'heros') made for them, but also ported to every other suit)

[crisp coral]

it's not too difficult to add loc_txt tbf

[brisk rose]

wait, why isn't en-us on the locale list?

I guess it's just 'default'

[brisk rose]

yeah ofc I can just copy what it spits out in the locale file to a loc_txt entry ofc

and just edit that object for the duplicate jokers

[frosty dock]

https://github.com/Steamopollys/Steamodded/wiki/01.-Getting-started#metadata 🤔

[frosty dock]

en-us and default aren't exactly identical though

you may want the english version to be one thing, but another thing to be filled in for unsupported languages

[brisk rose]

mods are just gonnna follow this example and when 2.0 comes out in like 2026 and /is/ compatoble with 1.0 mods will run into trouble

[frosty dock]

though I'd say that's rarely the case

[brisk rose]

wait nvm

gladur vers

still applies kinda

non-existing major versions shouldn't be listed as incompat

[tepid crow]

wow that comment highlighting is not great

unless that's indicating invalid json? 🤔

[frosty dock]

json doesn't always support comments ig

[frosty dock]

guess I'll have that be talisman then

also i might include a minimal example for copying

[tepid crow]

you should really fix your tabs/spaces inconsistency btw

[crisp coral]

To use more advanced typesetting, specify your description as a localization entry at G.localization.descriptions.Mod[id]
so does this support {C:color} and line breaks

[frosty dock]

yes

[crisp coral]

sweet

[frosty dock]

i switched to js highlighting because that was atrocious

[tepid crow]

oh yeah that does help a lot

thanks

[crisp coral]

crashes when hovering a joker with the new system

{
    "id": "LobotomyCorp",
    "name": "Lobotomy Corporation",
    "author": ["Mysthaps"],
    "description": "",
    "prefix": "lobc",
    "main_file": "LobotomyCorp.lua",
    "badge_colour": "FC3A3A",
    "display_name": "L Corp.",
    "version": "0.9.0-pre2",
    "dependencies": [
        {
            "id": "Steamodded",
            "min_version": "1.0.0~ALPHA-0909a"
        }
    ],
    "carmen_says": "You should distort yourself... NOW!"
}

is it fucking up because of my custom generate_ui.....

[frosty dock]

i don't see how that's related?

[crisp coral]

shrug

[frosty dock]

I think I see why will fix later

[tepid crow]

you could also try using yaml highlighting and comments with # (also disallows tabs btw)

[opal spade]

does this allow for localized mod name/display name?

[frosty dock]

yes but I didn't account for badge display names iirc

[frosty dock]

thanks but I'll just restructure to have the descriptions outside the actual structure

[tepid crow]

yeah that'll also work

probably more readable with markup too

[rough furnace]

Can we pretty please specify the default config file in here now please

So I can use config.lua

Provided should also have a version in it (and I should be able to provide multiple versions of a provided package)

(Specicizklly I would like to be able to provide DebugPlus api things people can depend on and I could support multiple versions but one version is never guaranteed to be compatible with another)

Although this would need some kind of optimal dependency thing to be greatly utilized

Also the metadata for mod icon so it may be show for disabled mods

Also what happens when a mod has both a header and metadata file

Also what happens when multiple json files in a folder

Also does nested still work (and how so kf it does)

[edgy reef]

About nested, json metadata is checked for the same say as legacy header

At least from when I last looked

[rough furnace]

TBH I think I would prefer a constant name for the json file and also not spport nesting/multiple mods per folder but I know this will break some mods that already exist

Specifically for the mod index having multiple mods in a downlaod would make it way more complicated

Also since we're discussing changing metadata stuff can we please define I'd restructions

Sepcifixlalt I want to make it possible to have internal smods IDs able to not be used by eztenrla mods (such as the mods used to represent lovely mods)

[tepid crow]

Page says

Using the legacy file header system is still supported, though switching to metadata files is encouraged. ... If you are transitioning away from using this method, make sure to remove the header to prevent Steamodded from trying to load your mod twice.

A possible hacky solution would be creating a second file with only the steamodded headers and a conflict header for steamodded version < current? 🤔

though it'd be better if steamodded just... didn't load the mod twice

[tepid crow]

I think it's clearer it can be hovered on with the exclamation mark rather than keeping the mod icon the same

[rough furnace]

That's why i specify disabled and not failed to load

[tepid crow]

OH

my bad

disregard then

[rough furnace]

Like this grey icon doesn't do much

and sometimes finding a mod by icon is easier

[tepid crow]

yeah I getcha

(though a gray filter on the mod icon might still be nice? 🤔)

[rough furnace]

yeah that seems iffy. I belive it should be okay, because it will just abort if two mods are detected with the same id, then it will just abort the second one it trys to load. Howveer, you need to keep the metadata in sync betwen the two. I assume there will be a breaking change someday to remove the old header method

[tepid crow]

oh it's an absolutely horrendous approach

[rough furnace]

if we did move to this then you could check for the presence of the json file and then switch behaviour

[edgy reef]

I'm getting the feeling that not everything being loaded by json is parsed.

Got the same error from D6 Jokers when adding display_text into the json metadata

[tepid crow]

actually, wouldn't that be a good way of hackily supporting both metadata variants?
Though... ugh, it'd still actually load twice so nevermind

[edgy reef]

Trying to debug this resulted in a print error that's saying that self.config.colour is a string.

Just so happens that legacy converts string to HEX and json doesn't.

ok the string error thing is unrelated lmfao

damnit

[frosty dock]

noticed this earlier but haven't gotten around to fixing it

[edgy reef]

oh it got found?

Nice

[frosty dock]

it doesn't actually load twice, it's just inconsistent which one loads

[edgy reef]

Ok the engine/ui crash is definitely related to json loading

Specifically with mod badges

So for now omit display_name

[frosty dock]

sure

[rough furnace]

thank you

(also can it support no default config as an option)

[frosty dock]

yes and no (multiple versions don't work with the current system)

[frosty dock]

yes (by means of the specified filename not existing)

[rough furnace]

ok good enough for me

That means I can remove this soon

[frosty dock]

I agree

[edgy reef]

It is basically the same SMODS.Atlas code for all mods anyways, the only "new" thing is the path to the icon

[tepid crow]

the resolution differs sometimes, no?

[rough furnace]

Does it actually check

I think I mseed up the specified resolution one time but I had the real resolution and I don't think it actually effected it

[tepid crow]

oh, seriously?

[rough furnace]

It was off by one pixel so I might have just not noticed it

or maybe 2

oh also metadata mod icon means the index can get the mod icon

BTW steamodded does not do this

[tepid crow]

https://tenor.com/78bW.gif

[rough furnace]

our system is more like debian versioning lite

[tepid crow]

seems to use the px and py as specified by the atlas, but it should be able to just auto-detect the size if needed

[frosty dock]

this is me being lazy

[rough furnace]

I'm not sure how balatro's atlas thing works but it moght be worth seeing if we can just look at the image resolution as most are just one sprite anyways (the only one I've seen with multiple is the Steamodded one)

[frosty dock]

it's not semver

[rough furnace]

I could document the versioning protocal

I'll have to go through and make sure I understand everything

[frosty dock]

<major>.<minor>.<patch><rest> is pretty much all. it's considered less than <major>.<minor>.<patch> when rest starts with ~

and patch is optional

[rough furnace]

I think it technically supports just like a version like 1

I'd have to double check

[frosty dock]

it doesn't, at least with the current pattern

that being this lua pattern ^(%d-)%.(%d+)%.?(%d*)(.*)$

[rough furnace]

oh we have a pattern

good to know

[frosty dock]

i guess technically we could make the minor version number optional

[rough furnace]

It could be nice in some cases

[frosty dock]

I'm not sure i see the use of that

[rough furnace]

I would use it

for the debugplus api

as it's a simpler api

also for dependancies I can then just depend on Steamodded>=1

[tepid sky]

how do i check for if a card is a jack?

nvm

[frosty dock]

Steamodded>=1~ actually

[rough furnace]

get_id() or smth

[tepid sky]

found it :D

ya

[rough furnace]

assuming I want to support beta versions

but yes

[tepid sky]

get_id() == 11

cuz jack is 11 in rank

[frosty dock]

non-beta versions do not yet exist

[rough furnace]

well technically, there are versions that would match >=1 but yes true

also can we dpeend (or mostly conflict) any version?

[frosty dock]

I'm not so sure about this one

[frosty dock]

anything considered a valid version can be depended on or conflicted

[rough furnace]

like can I specifcy no version to match all versions

[frosty dock]

yes

neither min nor max version are required

[rough furnace]

okay

also can we specify complex api things?

like (steamodded < versiona AND somedep >= 1 ) or steamodded >= versiona

[rough furnace]

I don't like the current system, and I think it'll be super messy with a version index

[rough furnace]

Also it would be nice to have this for a fake lovely package so mods can depend on certain lovely versions

oh also on the topic of breaking everything do we want to change the default prefix to the full mod id?

[frosty dock]

the default prefix for the json format is none

you have to specify one

[rough furnace]

it's required now?

[frosty dock]

not in headers, of course. I'm not crazy

but for the new format, it's required

[rough furnace]

ok sounds good

whats the fail behaviour?

does it show up as a mod failed to load or just a log in the console and not sane

[frosty dock]

not sane

[rough furnace]

maybe we should add some dev mode where all not sane things are put somewhere, and then we can add other stuff (like keep track of any warnings found and present them)

[frosty dock]

there should have to be some way to do this, actually

[rough furnace]

also I just checked the commits and we're at version f already today

[rough furnace]

oh also a fake balatro version so this can be done with balatro itself too

[frosty dock]

i feel like this is not reasonable to put in JSON config files

[rough furnace]

Yeah we might need to specify something

Debian juse does a string for versions

[tepid crow]

if you want to go the route of complex requirement specification a requirement text file would probably be better

[rough furnace]

just support the debian control format

[frosty dock]

or you can specify a preload file that is run to check for any unsupported requirements

[brisk rose]

What does debian have to do with anything? I mean unless balatro is going native sometime soon?

[frosty dock]

this just seems overkill 95% of the time

[rough furnace]

Because it has a well defined metadata file (the control file) that has all the version dependancies and defines how versions work and relations work

[rough furnace]

yeah but how would I know if all my deps are present (especially when they also have preload file)

[brisk rose]

ah I see. It's just a complete and thought out versioning system

[tepid crow]

just looked at it and there is genuinely some cool stuff in there, though extremely overkill lol

[frosty dock]

yeah nevermind that

[rough furnace]

Yeah. However, it is nice to look at to see how they handle certain behaviours

[tepid sky]

how would i reverse this one?

i know how to have lowe than or higher than

[brisk rose]

and probably contributes to debendecy hell in its actual application

lmfao

[tepid crow]

~=?

[tepid sky]

i'll try

[rough furnace]

Debians spec for relationships btw

wait wrong thing copiesd

https://www.debian.org/doc/debian-policy/ch-relationships.html#syntax-of-relationship-fields

[brisk rose]

I say this as a daily driver of a debian based OS who's tried to upgrade dependecies before. Not a good time

[tepid crow]

I was trying to find this but couldn't, thanks

[frosty dock]

maybe a structure like this can do

base := { id,min_version,max_version::string; };
operator := "and"|"or"|"xor"|"maybe something else idk"
version_spec :=
  | base
  | { type::operator; values::version_spec[] };
dependencies := version_spec[]

[rough furnace]

I think that many operators is overkill

[tepid crow]

don't you only need and and or?

[rough furnace]

the debian one just has a , (for and) and | for or

[frosty dock]

yeah and+or is complete

[rough furnace]

xor seems like just have a conflict

[brisk rose]

Wilson's version is much more intuitive to me ngl

[frosty dock]

nested objects are also annoying ig

[rough furnace]

is nested nessicary?

I don't think debian has it

[frosty dock]

for this

[rough furnace]

This example would just be steamodded >= version or somedep >= 1 I just overcomplicated it

[frosty dock]

if you have to write out something like (a|b),(c|d)|e,f as basically an AST

[rough furnace]

well if you need steamodded anyways you can do steamodded >= versiona and steamodded >= versionb or somedep >= 1

[tepid crow]

I'm getting antlr4 flashbacks

[rough furnace]

I think just don't support bracketing

[frosty dock]

fair enough

[tepid crow]

yeah I think you should stay away from ASTs and stuff

[rough furnace]

Debian doesn't do it so I trust them to figure out it worked

oh also make sure you treat provides properly

liek if I provide a package I conflict with don't disable myself

[frosty dock]

DNFs are logically complete so there's no issue here

[tepid sky]

next question, +-35? ._.

[frosty dock]

so deps and conflicts are just strings again

[tepid crow]

doesn't almost all software use strings for dependencies/conflicts/etc?

[rough furnace]

JS package.json doesn't but it doesn't support more complex dependency stuff like this (becuase we can have multiple versions of the same package to keep everybody happy and there's no conflicting)

[frosty dock]

so we have

• config file name
• provides versioning
• edit version pattern to allow major(+rev) only
• mod icon metadata
• fix display name error
• rework deps/conflict parsing

I'm not dealing with multi-versioning

anything I've missed?

[rough furnace]

We need to discuss the nesting and multiple mods thing a bit more

If we have a fixed conifg name we can't have multiple mods per folder anymore

(Without nesting)

[frosty dock]

we've established the config file goes unfixed

[brisk rose]

Make "Poor Raccoon's Fortune" fit on a badge, even with the legacy header

[tepid crow]

isn't this just the "should we allow multiple nested mods" conversation?

[rough furnace]

I think not having a fixed name is a bad idea though ( we could parse a json file for something as a mod config) and Its easier to not scan everything

[rough furnace]

Yes

But particularly its result can effect how the config file is defined

And we don't want to be changing things manorly when it's been around for a while and everyone has adopted ot

[brisk rose]

I wonder how many new words you've 'invented' Wilsom :P

[rough furnace]

I think if we do desicded to allow multiple mods in a folder, then the config file should specify what all the mods are and where (ar at the least just specify the paths for the individual mod json files)

[tepid crow]

actually took me a min to understand

Sepcifixlalt I want to make it possible to have internal smods IDs able to not be used by eztenrla mods
haha

[brisk rose]

I'm just as bad, lol

[tepid crow]

hold on I'm getting confused between config.lua and metadata.json, you're talking about the latter right?

[rough furnace]

sorry yes the metadata

[brisk rose]

Maybe if it is fixed, Betmma will finally have to turn their abomination into one actual mod

lol

[rough furnace]

or just have a few seperate mods installed seperatly

[tepid crow]

I mean at the end of the day it'll be

pros: people stop making weirdly confusing nested mods (real world issue: increased load time?)
vs
cons: it will be harder to install mods (mostly for first-timers and modpack makers)
right?

[brisk rose]

that'd blow for modpackers without multiple repos though

[rough furnace]

oh also I noticed a werid behaviour with betmma's where adding a lovely ignore to the top level mod will disbale the lovely patch won't disable the mods in it's sub directory

[rough furnace]

Well it would basically be what it is now, but bettama's mods would just be like 5 mods instead of 1 (or it would be reworked to actually be one mod)

also modpacks are are just a collection of files you put in the right spot

[brisk rose]

yes, and due to how submodules work, putting them 'in the right spot' and having them automatically update is... impractical if there's multiple mods in the same repo

it'd require external scripts which I certainly don't wanna mess with, instead of just git

[rough furnace]

I mean it's already that way if you just want one out of a few like any of the mods in https://github.com/WilsontheWolf/Balatro-Mods

[brisk rose]

the only collection like that I personally use is a couple things from jen's, which thankfullly don't really get updated much, so I can just add static copies directly to my modpack repo

[rough furnace]

like you may want a couple of the mods in there like the score improvements, metal pipe crashing noise and maybe rumble but theres some actively you don't want ones like crashing, negateInvis, negateEverything nobackground

Also those multi mod packs are just bound to not work well with the mod index

[tepid crow]

the way those are done currently by modpacks is by copy-pasting the files and manually updating them if the mod does iirc

[rough furnace]

Honestly any kind of modpack pretty much needs some manual work anyways

Like ever made a minectaft modpack?

[tepid crow]

never have and I thank god every day

[rough furnace]

I made one for my friends and it's annoying

with the mod index, you can probably make a script to just have the mods by id and then make a mods folder from it

[tepid crow]

Good point. The mod index still feels pretty far away for me though

[brisk rose]

I just tend to prefer people give mod's their own repo

(why are apostorophe and return so close together?)

[tepid crow]

I have it with\

(above the enter key for me)

[tepid sky]

can someone tell me what i am doing wrong?

[rough furnace]

Yeah but I don't want an additional 12 repos for mods I'm never going to touch again

[tepid sky]

i feel like i did it ok

[tepid crow]

what's the issue?

[rough furnace]

I mean making the same check twice seems odd

[brisk rose]

yeah and because they're not actively updating, it'd be fine for me to just copy them into my repo if I wanted them

[tepid sky]

looks like nothing gets added

[brisk rose]

only a problem for active mods

[tepid sky]

mb

[rough furnace]

I think honestly just make a script™️

[tepid crow]

the indentation is a tad off

[frosty dock]

oh btw

[rough furnace]

like for mine it would be clone the repo somewhere and rm -rf Mods/Rumble ; cp -r ClonedRepo/Steamodded/Rumble Mods/Rumble 👍

[frosty dock]

dependencies in DNF makes intuitive sense, but that's not so much the case for conflicts

[tepid sky]

Yea, nothing does

[rough furnace]

what is DNF btw?

[tepid crow]

https://en.wikipedia.org/wiki/Disjunctive_normal_form

(I'm assuming)

[frosty dock]

yeah

[rough furnace]

oh symbolic logic

[tepid sky]

And i think the whole joker is fucked rn

._.

[rough furnace]

or wait?

[frosty dock]

for conflicts, it seems the top-level operation should be OR

[wintry solar]

iirc context.before doesn't ahve any return values

[rough furnace]

or and and's?

[rough furnace]

Can you give an exampe where it wouldn't make sense?

[brisk rose]

I can tell you're frustrated, slipping into L1

[frosty dock]

i might be trippin

[tepid sky]

L1?

[frosty dock]

say I'm conflicting with three mods

that's just a|b|c

[brisk rose]

your first language (I saw it was in dutch at first)

[rough furnace]

no it would be a and b and c

[tepid sky]

That yea, its bed time

[frosty dock]

that's not my condition though

[tepid sky]

But i don't wanna untill it works

[frosty dock]

the condition is, one or more of these mods is present

[rough furnace]

oh I see

[wintry solar]

you need to use card_eval_status_text to display your message instead

[tepid crow]

yeah wait why are you checking context.individual and context.before?
do those actually happen at the same time? 🤔

[frosty dock]

but say I wanted (a and b) or c or d

[rough furnace]

See I see it as this is a list of mods I conflict with

[frosty dock]

that's fine if it's in CNF

[tepid sky]

Ty

[wintry solar]

oh this is also a major problem

[frosty dock]

but in DNF that's a or c or d and b or c or d

[rough furnace]

A - I conflict with a
A AND B - I conflict with a and b

[frosty dock]

I see this as follows. In order to load, I need <dependency condition> AND NOT <conflict condition> to be met

[rough furnace]

I guess I would think or conflicts as a I anti-depend on these

so
A AND B - would actually be NOT A AND NOT B

[frosty dock]

except the logical equivalent is NOT A OR NOT B

[rough furnace]

Well if NOT A AND NOT B then I can load

[frosty dock]

that's A OR B

which is exactly my point

I can easily parse as CNF (reverse roles of AND and OR) and thus have no operator precedence whatsoever and confuse the hell out of everyone

[rough furnace]

well it's NOT (A OR B) technically

[frosty dock]

yes

but we're absorbing that NOT

[rough furnace]

I would just have it behave the exact same as depeandacies, but each low level check is negated instead of the whole thing

[tepid sky]

Eh, I'll look tmr

Gn

[rough furnace]

So A OR B AND C is treated as NOT A OR NOT B AND NOT C

[tepid crow]

do we really need DNF for the deps though

[rough furnace]

I mean it's just conceptually

the syntax doesn't need to be using the logic one

[frosty dock]

unless we support bracketing (which I won't), it's always either a representation of DNF or CNF

[rough furnace]

do you understand what I'm saying?

[tepid crow]

not sure if you're asking me or aure

[rough furnace]

aure

[frosty dock]

uh

i think so

[rough furnace]

does it make sense?

or did I mess up my logic?

[frosty dock]

wait lemme rethink

don't I actually want CNF for dependencies?

[tepid crow]

sort of depends on the operators you will use in both dependencies and conflicts?

[rough furnace]

I think we just want and and or

but internally when doing conlficts any "literal" (like A or A > 5.0.0) just gets inverted

[tepid crow]

is either intuitive enough for
conflicts: A and B
conflicts: A or B
?

[frosty dock]

yeah I just confused myself

a,b|c,d should parse (a) and (b or c) and (d)

for dependencies

[tepid crow]

yes

[frosty dock]

which has AND being weak, which is not how that works normally

[rough furnace]

uhhh

let me see how debian does it

[tepid crow]

huh, probably why dependency resolvers usually format it that way

neat

[frosty dock]

for dependencies, it's intuitively clear why that's better

now for conflicts

[rough furnace]

Yes I guess it does

[frosty dock]

if (a) and (b or c) and (d) is a stand-in for (not a) and (not b or not c) and (not d) and that's just another condition for loading (not one for not loading)

that means in order to NOT load, I have the condition
(a) or (b and c) or (d)

[brisk rose]

so shouldn't the focus be on making the json format intuitve to uh... non-CS majors, and then converting it into logic from there?

which to be fair seems like what you're doing

[frosty dock]

it makes enough sense for dependencies

[rough furnace]

Well we need to figure out how to program it before we specify how to define it

[tepid crow]

A, B | C, D makes sense for dependencies right?

[rough furnace]

ok so wait how should A <=1.2, A >=1.0 be treated?

as a conflict

[brisk rose]

well that's a choice, but I guess the sort of choice a programmer would make. I read on some stackoverflow thread that I guess what I'm reffering to would be called 'readme-driven' development

[tepid crow]

lmao love that term

[rough furnace]

Well in this case it's moreso we need to figre out how to interprit sutff before we figure out how to parse it

[frosty dock]

this conflicts either one of A<=1.2 and A>=1.0, which is all instances of A

[rough furnace]

okay

[frosty dock]

okay what if

we don't have two separate fields

but a negation operator

[tepid crow]

no

[rough furnace]

idk about that

[frosty dock]

except idk what symbol to use

i can't ban either one of ~ or - in version strings

[rough furnace]

especially if we want to do stuff like optional depeandies (which would just mostly be load me later)

[rough furnace]

! but still I don't really like that

[tepid crow]

negation just makes reading it a pain in the ass

[rough furnace]

So i guess if we were just to simplify it, , would just be seperating seperate elements and | would be conditions that support multiple

I wonder if someone made a version resolving thing we can just steal

[frosty dock]

including negation extends it logically to having conflicts and dependencies interact

Steamodded>=1.0, !Talisman>=1<=2, !SomethingElse|CompatLayer

[rough furnace]

See the issue is that gets harder to parse (as a human)

Like is !SomethingElse|CompatLayer ~(A|B) or (~A)|B

and then also if we want the other now we need backets

[frosty dock]

I'd say negation would have to be strong

so (~A)|B

[rough furnace]

so then how do I represent ~(A|B)

[frosty dock]

besides ~(A|B) is ~A,~B

[tepid crow]

isn't the provides supposed to do that

[rough furnace]

Well you could have 2 things that provide similar apis and have the logic to choose between one or the other,

[frosty dock]

I could normally conflict with something unless something else is present

I'm not sure how provides helps there

[tepid crow]

ah

[rough furnace]

provides would be so somethingelse could provide compatlayer at the specific version

[brisk rose]

I'm not sure I understand the purpose of a negation oprerator when the field is already for anti-depends?

[tepid crow]

.

[frosty dock]

my point is to get rid of anti-depends as a field

[rough furnace]

Well the idea is we get rid of conflicts and you just negate your depedancies for conflicts

[frosty dock]

there's one dependency field for both depends and anti-depends

[rough furnace]

I like the idea of an anti-depends/conflicts field

[brisk rose]

oh that seems needlessly convoluted on the users

[rough furnace]

yeah I agree

[frosty dock]

feels like there's no intuitive way to do this though

[rough furnace]

tbh could this discussion use a thread?

[frosty dock]

probably yea

[rough furnace]

I feel like it's a longer discussion and not getting it buired in modding dev may be nice

Make a #1209506514763522108 thread or one in this channel?

[brisk rose]

this channel really could use its own dedicated threads counterpart

[rough furnace]

Depedancy Discussion

[brisk rose]

as could modding-chat tbh (for casual topics not fit for #1209506514763522108)

[rough furnace]

I think just threads in their channel is fine

[brisk rose]

The issue is they're not really persistent or browsable. Fine for their intended use case of break-away convos, but less so if you want actual forum topics that don't fit the #1209506514763522108 vibe

[brisk rose]

It's also possible I just have some sort of allergy to understanding Discord's interface, lol

[rough furnace]

they are very much persistant and browseable

they even do the same thing under the channel for with messages

[brisk rose]

Indeed I just... never knew what that button was before

[brisk rose]

This I did see ofc

Just didn't know about the list of all of them

[rough furnace]

Threads in channels don't make a lot of sense except in more active channels

cause most of the itme you're not going to exceed two convos at a time

and often they don't need to be followed up

so a new convo is fine

[brisk rose]

I still think it'd make sense to have an additional forum channel for more modding-chat style memes and like "what's your favorite mod atm" type threads. Leaving #1209506514763522108 to its defacto use case of mostly project threads

[orchid thunder]

how would one use a joker to change what a seal does

for example i want to make a joker that changes blue seal to have a 1/2 chance to give a blackhole

[brisk rose]

Looking at the code for this would probably be a good start

[orchid thunder]

oh ok

[orchid thunder]

huh

[brisk rose]

Look at elbe's port

[orchid thunder]

?

[brisk rose]

https://github.com/lshtech/MikasBalatro

[orchid thunder]

oh hmm

[brisk rose]

Mika's is abandoned so this is the canonical version

[orchid thunder]

what is harp seal

i keep seeing it

[brisk rose]

Maybe was a better example?

[orchid thunder]

Oh hmm

this is for a joker in cryptid so il have to make it compatable with this somehow right

[brisk rose]

Tbh I don't know how sensible this stuff In mika's is coded, so take it witb a grain of salt

[brisk rose]

How do you mean?

[orchid thunder]

?

[brisk rose]

Make what compatible with what?

[orchid thunder]

i mean im doing this for a joker in cryptid should i worry about this or no

[brisk rose]

The stuff in mika's will probably take care of itself Idk

[orchid thunder]

im just goign to not for now if modpacks break modpacks break

[brisk rose]

You'd have to ask @dense jasper

[orchid thunder]

bro out here @ing people

[brisk rose]

Idk how many people have both cryptid and mika's. I guess dimserene's pack users

[brisk rose]

Seems not to bother people. I don't do it with Myst or anyone else I know minds

[dense jasper]

Harp seal is, I believe, hard coded to just replicate what the vanilla seals do.

[brisk rose]

So yeah it shouldn't break anything. Just not exactly follow the description

[dense jasper]

Long term plans were to make it work for modded seals just haven't gotten to it

[rough furnace]

Could you reuse the logic for stuff like oversatuated and glitched but just apply it to seals

Since it is a cryptid joker

[orchid thunder]

what do i use to create a card

such as a black hole

[haughty wraith]

I'm a complete 0 in programming, and my translator is clumsy, but here's what I came up with: let's add a variable, if this variable has a value of 0, then the blue seals work as usual, but if the value is greater than 1, then they will give black holes, and the joker will simply add 1 to the value of this variable

[crisp coral]

appreciate it

[tranquil gull]

@muted kite sorry if the ping bothers you, but would you happen to know if steamodded supports giving jokers custom Card:draw functions?

[lucid umbra]

anyone know how to get rid off other event queues? they keep stacking and stacking up and laging out my game

[crisp coral]

afaik no

also you'd be better off pinging @ aure__ for steamodded now

[crisp coral]

you need to find which mod is calling all the events

[lucid umbra]

well i know that the events increase whenever cards get drawn or redeposited back in the deck, but somehow, not in challange decks

[frosty dock]

no

but stickers do, for some reason

[edgy reef]

:]

Honestly forgot the reason

Oh wait I know

Using a different shader for the shine or not having it all

Felt for intuitive to just expose drawing the sticker over a variable that disabled the shine.

[wintry solar]

You can clear the queues as well, but I don’t remember the syntax off the top of my head

Probably something like queue:clear_queue()

[crisp coral]

@frosty dock have you fixed the hovering crash?

because i just updated and it still does that

[frosty dock]

ah no i still need to do that

[crisp coral]

🥀

[frosty dock]

i was too busy discussing dependencies

[frosty dock]

done

[crisp coral]

tyty

[cerulean rose]

i'm trying to add a new challenge, but its name shows up as ERROR

name = "Debug Challenge",
    id = "c_debug_1",
    rules = {
        custom = {
        },
        modifiers = {
            { id = "dollars", value = 1e200 },
        }
    },
    jokers = {
    },
    consumeables = {
    },
    vouchers = {
    },
    deck = {
        cards = { { s = "S", r = "K", e = "m_glass", eternal = true } },
        type = 'Challenge Deck'
    },
    restrictions = {
        banned_cards = {
        },
        banned_tags = {
        },
        banned_other = {
        }
    }

[brisk rose]

You need either a loc_txt or a full localization file

[cerulean rose]

i'm having trouble getting loc_txt to work

table.insert(G.CHALLENGES, {
    name = "Debug Challenge",
    id = "c_debug",
    key = "c_debug",
    loc_txt = {
        ["en-us"] = {
            name = "Debug Challenge"
        }
    },
    rules = {
        custom = {
        },
        modifiers = {
            { id = "dollars", value = 1e200 },
        }
    },
    jokers = {
    },
    consumeables = {
    },
    vouchers = {
    },
    deck = {
        cards = { { s = "S", r = "K", e = "m_steel" }, { s = "S", r = "K", e = "m_steel" }, { s = "S", r = "K", e = "m_steel" }, { s = "S", r = "K", e = "m_steel" }, { s = "S", r = "K", e = "m_steel" }, { s = "S", r = "K", e = "m_steel" }, { s = "S", r = "K", e = "m_steel" }, { s = "S", r = "K", e = "m_steel" } },
        type = 'Challenge Deck'
    },
    restrictions = {
        banned_cards = {
        },
        banned_tags = {
        },
        banned_other = {
        }
    }
})

[wintry solar]

where are you putting this code

[cerulean rose]

body of main file

[frosty dock]

loc_txt can only possibly work with steamodded APIs

you're directly inserting into the game's challenge table

[cerulean rose]

how do i do this properly

[frosty dock]

SMODS.Challenge({ your table here ... })

[cerulean rose]

that worked! thanks

how do i ban blinds from other mods in challenges?

waitwaitwait lemme try something first

alright just include it in the table

it's ignored if the mod isn't active

also haha the challenge screen breaks if you ban too many blinds

also even though the blinds show the correct description, their sprites are wrong

i'm trying to make a challenge that debuffs certain poker hands, how would i go about doing that?

[primal robin]

What is correct way to replicate creating cards for Standard Pack?

Ingame code so hardcoded, which is not good for other mods support (like seals)

[primal robin]

And how to scale card properly?

[tranquil gull]

there's probalby SOME way to do it

even if hacky

[edgy reef]

Lovely injects are how most mods handle it right now

[tranquil gull]

why lovely inject when you can monkeypatch

local card_draw = Card.draw
function Card:draw()
  if --[[ some condition ]] then
    -- stuff goes here
  else 
    card_draw(self)
  end
end

i mean performance is probably the reason but who cares about performance :D

/j

[wintry solar]

because you're goiong to miss out lots of stuff

[tranquil gull]

ah it's fineeeee

i mean look my end goal is a 3d joker

nothing's gonna work with that anyways

lmao

[hardy viper]

this is always way better than lovely patching when you can do it btw

[tranquil gull]

oh?

[hardy viper]

lovely is only for cases when this isnt convenient

[tranquil gull]

does lua implement tco?

[hardy viper]

sorry?

[tranquil gull]

tail call optimization

[hallow forge]

now the REALLY bad this is overriding the function entirely

[hardy viper]

no clue but i know function call overhead is not that bad in lua

[hardy viper]

^

[tranquil gull]

oh it does! awesome

so doing something like

function f(v)
  if cond then return v end
  g(v)
end

takes up zero additional stack space since it jumps directly from f to g

which means you don't get stack overflows from recursion and it's a little faster 🎉

this only works if the function call is deterministically at the end of the function

hence, tail call optimization

@hardy viper

[hardy viper]

understandable

thanks for the explanation

[tranquil gull]

WAIT HI MATHGUY !!

[hallow forge]

HI BALT factorial factorial

[crisp elbow]

omg balt hi

[tranquil gull]

kjdfghdf

[tranquil gull]

we don't know each other

[crisp elbow]

but hi nonetheless

[tranquil gull]

hi lol

[cerulean rose]

i figured it out

[hardy viper]

omg hi cg

[static cairn]

?

[tranquil gull]

so what's a good way to load something that isn't a regular asset? do i just put it in the mod files and then load the file like how you usually do in love?

[cerulean rose]

turns out that's not the case

[timid parrot]

currently trying to make a custom edition for playing cards, but it keeps crashing when I try to apply the edition and I have no idea why

[brisk rose]

So idk the issue, but in any case you should be developing these on the newest smods and lovely

[timid parrot]

am I not?

[brisk rose]

Lovely is on 0.6.0 now and steanodded gets updates at least every couple days including a fairly big one on the 30th

[timid parrot]

fun

[brisk rose]

I don't think the card.edition.phantom syntax is right? Unless you saw that somewhere

[timid parrot]

I saw that in the main code lol

they flag an extra variable on the edition for use with edition checks when it's set

and like the edition works fine in the collection

so I think either I'm setting it wrong or something funky is going on

[brisk rose]

Well if it's the key, then the actual key would include your mod prefix

[timid parrot]

I mean I can try that

[brisk rose]

Definitely worth a try. Smods always accounts for conflicting names

[timid parrot]

no change

[brisk rose]

Did you do card.edition.prefix_key?

Yeah I'm not sure you need those on_apply things for smods.edition objects

[timid parrot]

ah you're right

[brisk rose]

Here's what the editions in ortalab look like

You still want loc_txt ofc. Ortalsb just uses loc files instead

[timid parrot]

so I'm looking through the code in Steamodded to find out what's crashing

it's this line in their set_edition function

[timid parrot]

ok I got it working after a lot of pain

[wintry solar]

Looks lile it was a mod prefix error?

[timid parrot]

yes

I just didn't have one set in my mod header

and now it's finally working

[wintry solar]

You also don’t need those on apply and remove functions at all

[glossy stone]

i can feel my motivation coming back

augh time to do 7 more arts so i can release OS

[lucid sun]

hey, looking for some assistance as am unsure what is wrong with code. trying to code it so that if current hand played is the same as last hand plated, joker will upgrade. currently it upgrads on every card played. looked through a few other mods that have something similar but have been unsuccessful

  loc_txt = {
    name = 'Bobo Doll',
    text = {
      "This Joker gains {C:chips}#2#{} Chips", "if played hand is the same","as previously played hand.", "{C:inactive}Currently {C:chips}#1#{} {C:inactive}Chips" 
    }
  },
  config = { extra = { chips = 0, chips_gain = 10, last_hand = 'High Card'} },
  rarity = 1,
  atlas = 'JestersPrivilegeAtlas',
  pos = { x = 3, y = 0 },
  cost = 4,
  unlocked = true,
  discovered = true,
  blueprint_compat = true,
  eternal_compat = true,
  perishable_compat = true,

  loc_vars = function(self, info_queue, card)
    return { vars = {card.ability.extra.chips, card.ability.extra.chips_gain, G.GAME.last_hand_played } }
  end,

  calculate = function(self, card, context)
    local last_hand = G.GAME.last_hand_played
    if context.joker_main then
        return {
            chips_gain = card.ability.extra.chips,
            message = localize {type = 'variable', key = 'a_chips', vars = {card.ability.extra.chips}}
         }
    end
    if context.before and not context.blueprint and context.cardarea == G.jokers then
        if context.scoring_name == G.GAME.last_hand_played then
            card.ability.extra.chips = card.ability.extra.chips + card.ability.extra.chips_gain
                return {
                    message = "Upgraded!",
                    colour = G.C.CHIPS,
                    card = card
                 }
        end
    end
  end
}

[wintry solar]

I imagine G.GAME.last_hand_played is updated before the joker is being calculated

[lucid sun]

yep you are right, just did a quick search in the server and seems to be the case lmao. thank you

[wintry solar]

you can store the last hand inside your jokers extra table though

[limpid flint]

Can I somehow inspect an object's full key ingame

Like jokers, booster packs, consumables, blinds, etc

[wintry solar]

local click_ref = Card.click
function Card:click()
  click_ref(self)
  print(self.config.center and self.config.center.key or 'no key found')
end

something like this should work

[limpid flint]

So then everytime I leftclick an object, the full key will be printed out?

[wintry solar]

yeah

[limpid flint]

In the console I assume

[wintry solar]

if you have debug plus it'll show up there too

[limpid flint]

Oh cool

Thanks a lot

[lucid sun]

hello me again. trying to make it so if a glass is played, xmult is added to the joker, however get this error: bad argument #1 to 'ipairs' (table expected, got nil) and am unsure why if anyone could help

  loc_vars = function(self, info_queue, card)
    return { vars = {card.ability.extra.x_mult, card.ability.extra.x_mult_gain } }
  end,

calculate = function(self, card, context)
    if context.cardarea == G.jokers and context.before and not context.blueprint then
        local faces = {}
        for k, v in ipairs(context.scoring_hand) do
            if v.ability.effect == "Glass Card" then
                card.ability.extra.x_mult = card.ability.extra.x_mult + card.ability.extra.x_mult_gain
                G.E_MANAGER:add_event(Event({
                    func = function()
                        card_eval_status_text(card, 'extra', nil, nil, nil, {message = localize('k_upgrade_ex')}); return true
                        end
                }))
            end
        end ```

[maiden phoenix]

Check if context.scoring_hand exists too, I dont remember if its created on context.before

[wintry solar]

you don't want to do this in context.before

you want to use if context.cardarea == G.play and context.individual and not context.blueprint then and then use if context.other_card.config.center_key == 'm_glass' then

I believe that'll work

[lucid sun]

legend thank you. if i could ask, why not use context.before in this situation?

[hearty sand]

Hi, I'm new here. I wanted to know how modding this game is. I never really learn code, but I would be done to learn for this game, however, I would like to know how hard it can be.

I already understood how to change text and texture. But the thing I want to do the most is some Joker, would it be hard to start with that?

[stiff locust]

jokers are decently easy to do

as long as you don't do anything too outlandish like implementing an entire new system

there's probably a way to do it, or a similar method you can reference in another mod

also the steamodded example mods are great for that kinda stuff

[hearty sand]

Oooh, ok, good to know

[stiff locust]

the example mod re-makes a bunch of vanilla stuff in steamodded format

https://www.youtube.com/watch?v=VVkBgBsIBOQ

oops

cool video but wrong link

https://github.com/Steamopollys/Steamodded/blob/main/example_mods/Mods/ExampleJokersMod/ModdedVanilla.lua

there we go

[hearty sand]

That's exactly what I need I think, ye. Thank you very much!!

[stiff locust]

that's the one for jokers, they have others for other game objects in there

and don't be afraid to look into other mods' code to see how they do a certain thing

you dont need to reinvent the wheel if someone else made a similar joker already

[hearty sand]

Perfect, I'll start looking that up, thanks

[hearty sand]

Perfect, good to know

[stiff locust]

the beauty of open source coding

[hearty sand]

Hehehhe

[stiff locust]

if you have any other more specific questions this is the place to ask and you'll get a reasonably timed response

[gloomy aspen]

anyone know any sites where i can edit my save? not sure where else i'd ask, but i want to port my joker stickers and stake wins from mobile -> pc, essentially "merging" my saves

oop! nvm, didn't realise the first result let you put in files other than just save.jkr

[timid parrot]

gotta love the spaghetti code that led to the stay_flipped parameter in the draw_card function being overridden inside the function in every use case

[topaz sun]

Guys, why is the game crashing when I try to play a sound, saying
Could not open file resources/sounds/buf_crystal.ogg. Does not exist.

The sound does, in fact, exist though. Also I'm using the same syntax I used to play another sound which works. Both sounds are .ogg files. They also have similar sizes / lengths. I can't figure this out

The /sounds folder. The 'explosion' sound works fine, but the 'crystal' one doesn't

[tepid crow]

seems like steamodded prefix shenanigans

[topaz sun]

I used the 'buf_' prefix on both occasions

[wintry solar]

Can you show the sound definition?

[topaz sun]

Here

[wintry solar]

No where you create the sound

[topaz sun]

You have to create the sound?

How does one do that?

[wintry solar]

Using SMODS.Sound

[topaz sun]

Oooooog

[hardy viper]

https://github.com/Steamopollys/Steamodded/wiki/09.-SMODS.Sound

[topaz sun]

Right, omg

[hardy viper]

[topaz sun]

I simply had forgotten about this entirely

Thanks, Eremel and Lars

[onyx mango]

gonna potentially try to start nodding today, any tips on setting up a development / testing environment? are there any stub files available to make working with the api easier or testing mods to enable quick testing of a particular joker?

[topaz sun]

And cg

[hardy viper]

you shake your head up and down at a rhythmic pace

anyways no there's no way of doing what you're asking outside of a couple love2d definition extensions, the best way is to just use some sort of IDE with luals and make sure all the dependencies (like steamodded) are in the environment

as for testing a particular joker, use debugplus so you can just spawn it in with C and too many jokers to search it up in record time

proud self insert right there

[topaz sun]

It's probably best to just use the game to test stuff. You can use DebugPlus to give yourself some debug tools to work with during testing and TooManyJokers to quickly find the joker you want to test.

https://discord.com/channels/1116389027176787968/1228149931257237664

https://discord.com/channels/1116389027176787968/1292542891800920215

Probably a good idea to create an in game profile just for testing, so you don't mess up your stats and stuff

[onyx mango]

awesome! thank you bothhh!!!

is there any way to reload a jokers functionality dynamically so i wouldn’t have to exit out to fix bugs? i know lua is interpreted so it should be theoretically possible but idk if steammodded is built in a way that supports it

[frosty dock]

we've tried but have never gotten it to work because side effects in mod files are extremely common. You can however, for testing purposes, use the watch command of debugplus to load/reload files when changed

[onyx mango]

awesome! thank you so much!

[teal estuary]

forcing myself back into balatro moddinf: how plausible is it to have a joker that gains the amount of chips each played card gives? i can kinda visualise the code in my head, but wanna ask people smarter than i 😭

[tepid crow]

seems very doable

[wintry solar]

yeah seems like a reasonably simple idea

[teal estuary]

oh thank god

i'd presume the main meat and potatoes of the could would be something along the lines of

card.ability.extra.chip = card.ability.extra.chip + card.ability.extra.chip_gain then
return{
message = "you played a card! good job!"
colour = [color here]
}
end

of course, within the correct contexts

[tepid crow]

more like
card.ability.extra.chip = card.ability.extra.chip + context.other_card.base.value

(if I remember my contexts correctly)

[teal estuary]

all my code is botched together unless theres an example version i can steal from

[cerulean rose]

is there a good way to check another mod's settings?

[teal estuary]

im.. trying something, it just says attempt to perform arithmetic on field 'value'

(actual crash log, i know im missing something but no fucking idea what 😭)

[frosty dock]

base.value is a string like "8", "10" or "Ace", not a number

you'd want to use context.other_card.base.nominal for base chip value

[teal estuary]

thank you 😭

that works, ty ty

is there a way to make the joker trigger specifically at the end of the hand? currently this one triggers after every card played (and adds the chips every time), which is a little busted

[primal robin]

Ice cream

[teal estuary]

oh yeah, true

[hardy viper]

funny

[teal estuary]

oh hey, moar jokers

also funny

[wintry solar]

remove the chips return and throw a context.joker_main check in afterwards

[teal estuary]

ah, ty

[tepid crow]

SMODS.Mods.<other_mod>.config works I think?

[teal estuary]

i know this is me being stupid, but is this what you meant

[wintry solar]

no

the if context.joker_main then needs to be a seperate statement

let me find you an example

[teal estuary]

thank you 😭

[cerulean rose]

I pro e y ur run!

[teal estuary]

i wasnt sure if you meant throw the context in the main if line, so i guessed

[teal estuary]

ahhh, gotcha

ty

~~i was gonna make a triangle joker, with that exact same premise 😭 ~~

it works! ty

[tranquil gull]

is it just me or does love.filesystem.read just. not work. it says the file doesn't exist when it very much does

[hardy viper]

paste the line

i imagine your issue is assuming the working directory is where your lua file is as opposed to the balatro appdata folder

[tranquil gull]

local mesh = obj.load_obj((mod.path .. "assets/test.obj"):gsub("\\", "/"))

function obj.load_obj(path)
    local obj_file, err = love.filesystem.read(path)
    if not obj_file then
        error("failed to load model: " .. err)
    end
    -- ...
end

and the error message is failed to load model: Could not open file C:/Users/baltdev/AppData/Roaming/Balatro/Mods/Jimbo3D/assets/test.obj. Does not exist.

[hardy viper]

weird

[tranquil gull]

that gsub was me trying to fix it, didn't work

[hardy viper]

try with nativefs.read i guess? that'll tell you whether it's a love filesystem issue

[tranquil gull]

nativefs?

[hardy viper]

require("nativefs")

steamodded provides it

iirc

[tranquil gull]

ah

oop that fixed it

nice

[hardy viper]

lol

[tranquil gull]

also yeah i'm loading a 3d model, mostly as a proof of concept

[hardy viper]

it's called love2d for a reason

[tranquil gull]

idc

[lucid sun]

working off this and advice SDM and Eremel gave, have got it working so when a glass is scored it adds x mult, but also want it that if a glass shatters it resets.
thought it would be a simple steal glass joker code and tweak it but nope. I have tried many different things and nothing seems to work - current error is the same bad argument #1 to 'ipairs'. I understand that i probably shouldnt be using the ipairs anyway so i have tried looking for other mods that use shattered cards but havent been able to find anything that could help me, if anyone has any ideas.

  calculate = function(self, card, context)
    if context.joker_main and card.ability.extra.x_mult > 1 then
        return {
            Xmult_mod = card.ability.extra.x_mult,
            message = localize {type = 'variable', key = 'a_mult', vars = {card.ability.extra.x_mult}}
        }
    end
    if context.cardarea == G.play and context.individual and not context.blueprint then
        if context.other_card.ability.effect == "Glass Card" then
                card.ability.extra.x_mult = card.ability.extra.x_mult + card.ability.extra.x_mult_gain
                return {
                    message = "Upgrade",
                    colour = G.C.RED,
                    card = card
                }
        end
    end
    if card.ability.extra.x_mult > 1 and not context.blueprint then
        for k, v in ipairs(context.glass_shattered) do
            if v.shattered then
                card.ability.extra.x_mult = 1
            end
        end
    end
end

[tranquil gull]

so how would i go about detecting if an arbitrary Card is my joker?

.name isn't set by steamodded

or if it is, name isn't set in the collection listing

this is for custom logic in Card:draw

[brisk rose]

Wouldn't it just be .key?

[tranquil gull]

that's not set either

i looked into it and it

makes.

entirely new Card instances

in the collection.

[brisk rose]

Hmm maybe check the sprite object for the key? I'm kinda just throwing things out they'd, but it has to be there somewhere

[tranquil gull]

okay, What

why do i have a value of type table

that when printed prints nil

and hard crashes when i do anything with it

is this deadass a null pointer

[maiden phoenix]

Your object should have mod in it, that could work no?

[tranquil gull]

i think it might be which begs the question - how the fuck did i get that

lemme do some diggig to make sure that isn't whjatr's happening here

okay it isn't lmao

[narrow pollen]

so uh, is there a way for me to access the SMODS version of a joker i've already taken ownership of?

[onyx mango]

any apparent reason why this code neither changes the card nor spawns a message?

nevermind i misunderstood how the function took the rank lol

[tranquil gull]

hh i think 3d is a bust

can't get it actually drawing

wait love.physics exists

just had a REALLY funny idea for a joker

[hallow forge]

i don't likw where this is going

*like

[tranquil gull]

you know these things

"x3 mult when ball is inside cup", but the shake from Card:juice_up yeets the ball wherever the fuck

it's REALLY good so you kinda gotta pick it up when you see it but also REALLY annoying because you gotta reset it every. time. which takes like 5 minutes. and you can't really do retriggers on it

i was thinking "hgey i should make more jokers like this and make a content mod out of it"

and then i was like "okay what would i name it"

and fucking

Jimbotomy

just jokers that are Weird.

and to get their full potential you have to do esoteric and possibly frustrating things

[tranquil gull]

do you like it

[hallow forge]

Not really

[tranquil gull]

gottem

[hallow forge]

It’s silly and I’d never take it in a run

But it’s funny

[tranquil gull]

that's what i'm going for

LMAO another idea

"+20 mult if language is not set to system language"

hmm what else

"x5 Mult if Chips is prime, debuffed if Chips > 1,000,000,000"

[opal spade]

X1 mult for every joker who's name doesn't include "Joker"

[tranquil gull]

oh that's good

[timid parrot]

+1 mult for every modded boss blind installed

[tranquil gull]

lkjfds

[timid parrot]

Actually no +2 or +3

Well depends on rarity

[tranquil gull]

Roll the Dice: +{N} mult, 5/6 chance when selling this card to create a Roll the Dice with the same enhancements, edition, and seals with +{N+5} mult (N starts at 0)

[timid parrot]

Time to buy madness or dagger

[tranquil gull]

no specifically when selling

[timid parrot]

Exactly

[tranquil gull]

dagger destroys, doesn't sell

[timid parrot]

Yeah

I imagine that joker as the ultimate Judgement trap

[brisk rose]

With eternal in parenthesis and a sell value listed I'm confused

Oh I see

It creates itself when sold

[timid parrot]

Yeah I mean eternal is great when it’s on the thing you want

Oh you changed it

[tranquil gull]

actually imma change the name

[brisk rose]

It's a good name tbh

[timid parrot]

Call it the gambler lol

[brisk rose]

Reminds me of Jimbo's Ouroboros

It's similar it just makes a stronger version of itself that costs more spawn in shop when you sell it

But this is distinct and interesting

[tranquil gull]

alr imma make some of these lmao

maybe not the one that needs love.physics yet, don't wanna be up until 4am setting that up

[tranquil gull]

ah wait this doesn't work because localization

well

ig i could take the localized string for jimbo ("Joker") and then search for that

[opal spade]

yes

[tranquil gull]

hmmmm you know

i've made raymarchers before

oh my god hilarious idea

Pirate Joker: +20 mult if Steam is not initialized

Dyslexic Joker: Each hand is scored as a random hand type

eh, no why would you take that

well ig with a little tweaking it could be good early game, bc you could random into things like flush five

[hallow forge]

tbh I feel the hand type matters too much to be left to chance like that

[cerulean rose]

doesn't seem to

if (SMODS.Mods["Cryptid"] or {}).can_load and SMODS.Mods.Cryptid.config["Blinds"] then
    table.insert(permamouth.restrictions.banned_other, { id = "bl_cry_oldhouse", type = 'blind' })
    table.insert(permamouth.restrictions.banned_other, { id = "bl_cry_oldpillar", type = 'blind' })
    table.insert(permamouth.restrictions.banned_other, { id = "bl_cry_oldflint", type = 'blind' })
    table.insert(permamouth.restrictions.banned_other, { id = "bl_cry_oldmark", type = 'blind' })
end

[tepid crow]

looks like the mod would have to be loaded first 😅

maybe put it in the function where the run starts or smth

[stiff locust]

is it easy to "reimplement xchips"

[wintry solar]

Why not just depend on talisman

[stiff locust]

I don't think it's an issue to depend on it but a lot of people for some reason hate doing that

¯_(ツ)_/¯

[brisk rose]

I hate having talisman because the actual head-lining feature needs special compat, so I feel the need to have it, while also keeping it set to vanillia

which until math makes the config save to the config folder, has other issues

[stiff locust]

if i do anything xchips in tsunami it'll use talisman as a dependency because you're already getting fusionjokers as a dependency anyway so why do you care

[brisk rose]

I mean I already have Talisman and don't plan to play Tsumami (sorry), so it's not something that bothers me

I just think the Talisman situation is in general unfortunate

[stiff locust]

yeah you're (unfortunately) the last person i expect to play my mod

so for limit must be a number crash on this line in state events.lua

what's that mean

happens when i play a hand with the fusion i just made
it doesnt even do anything outlandish nor use retriggers so i'm confused

[wintry solar]

you need to add and not context.repetition iirc

[stiff locust]

oh

why is this happening on this joker and no others

[wintry solar]

yeah this is an unfortunate consequence of it adding all the extra stuff, though personally I'd never use xchips anyway so 🤷‍♂️

[stiff locust]

so is it difficult to reimplement xchips

can i copy borrow some code from talisman to do it or is it harder than that

[wintry solar]

I'm guessing your other jokers don't just use context.cardarea == G.hand

implemenet xchips is pretty straightforward

it's just a couple of lovely patches iirc

[stiff locust]

yeah none of the others do

so that's why it is, noted

[stiff locust]

yeah that shouldn't be so bad

one of the other projects i'm on uses xchips

so i'll do that for that one

tsunami will use talisman as a dependency

[stiff locust]

is there a way i can have this code (in lovely.toml) not load if talisman is present

dont want anything to break if this mod and talisman are both present

[wintry solar]

just change your variable name to be different to talismans

[stiff locust]

which variable name

oh I almost forgot about the sounds

[wintry solar]

for your xchip return

[stiff locust]

which one is that
this makes zero sense to me

[wintry solar]

so say talisman uses x_chip_mod as it's return value name, you can make yours tsunami_x_chips and it won't conflict with anything

[stiff locust]

this still makes no sense to me

i think this is out of my pay grade for now

just gonna bite the bullet and have talisman as a dependency

[topaz sun]

I think I saw a mod check in some .toml file of Cryptid's

Can't remember which one though

But it's probably possible

[tepid sky]

We need custom xchip or ^chip/mult api 😏

(jk, idk anything about that stuff so don't take me seriously)

[wintry solar]

It’s called talisman

[opal spade]

on one hand true but i feel like xchip is common enough to warrant a smods inclusion

[brisk rose]

tbh same. I think that because it doesn't alter base game functionality, it should be fine

[mellow sable]

I feel like a large part of Talisman could be merged with Steamodded, ye

[teal estuary]

there are defintely an Amount of things that are common enough, but i 100% agree that xchips is common enough

out of all features i’d want next in steammodded, xchips is definitely up there

[teal estuary]

is there a way to enforce a max amount on a joker? for example, if i wanted a joker to only be able to gain 100 of something - would it be possible?

[stiff locust]

that's

and i hate to patronise you

trivial

you take the increase amount, check if it's above 100, and if it is, set it back to 100

[teal estuary]

not patronising, and it just clicked in my head on how you’d so it

yeah

😭

i forgot code can code

[stiff locust]

increase = <insert calculation>
if increase > 100 then
increase = 100
end
card.ability.extra.value = card.ability.extra.value + increase

literally that

[teal estuary]

yeah, i was writing that out as you started typing 😭😭

[stiff locust]

it happens to the best of us

[teal estuary]

im good at coding, i swear

ty thougg 😭

[stiff locust]

i mean yeah everyone whos good at coding forgets the simple shit

[teal estuary]

ong, clearly just means im amazing at code

[frosty dock]

why do that when you can just oneline it

math.min(increase, 100)

[primal robin]

How can I rename Joker by using some value from card.ability?

[teal estuary]

in the context of what im doing, just put:

card.ability.extra.mult = card.ability.extra.mult + card.ability.extra.mult_gain and math.min(mult, 100)

?

[tepid sky]

random mult gain? cool :o

[teal estuary]

oh, no, its something different 😭

is a good idea though

[tepid sky]

lol

[opal spade]

card.ability.extra.mult = math.min(card.ability.extra.mult + card.ability.extra.mult_gain, 100)

[teal estuary]

ahhh, gotcha

ty

[bitter fog]

did the most recent update break modding? I tried following the guides on installing mods and found nothing changed

If i were to restart the modding proccess, would a clean reinstall of balatro help?

[tepid crow]

balatro's 1.0.1m? no, everything should be fine as long as you're not using steamodded 0.9.8

[bitter fog]

hmmm, i think i installed the 1.0 alpha version

one sec

oop ok i did download the 9.8 version. do i just do a reinstall of vanilla balatro to restart and install 1.0?

[tepid crow]

it should all be in the guide https://github.com/Steamopollys/Steamodded/wiki/01.-Getting-started

[bitter fog]

kk thanks

[vague island]

how do i check how many enhanced cards are in the deck (for example drivers license)

?

[cerulean rose]

if self.ability.name == "Driver's License" then 
    self.ability.driver_tally = 0
    for k, v in pairs(G.playing_cards) do
        if v.config.center ~= G.P_CENTERS.c_base then self.ability.driver_tally = self.ability.driver_tally+1 end
    end
end

this is the code that tallies driver's license

what's the best way to organize code into different files like cryptid does?

[narrow arch]

@brisk rose i know you probably can't do much about this but when im using the modpack the game stack overflows when i try to switch profiles

[tepid crow]

^ someone else in the cryptid discord had the same issue

[wintry solar]

anyone using the blind animation tool in aseprite? I'm having some issues with it misaligning

[brisk rose]

Yeah I noticed that too. Dunno what mod is causing it

[narrow arch]

i think it's all of them

it must be loading in all of the unlocks, which is like a couple thousand stacks (a lot i think)

[brisk rose]

Try removing card-exporter. There's an update but I haven't pushed a release. I know it does things with unlocks

I don't think it's just a scale issue

[cerulean rose]

is G.hand.highlighted supposed to be nil when a consumable is used?

i have this so far

    use = function(self, card, area, copier)
        local left = nil
        local right = nil
        print(G.hand.highlighted)
        for k, v in ipairs(G.hand.highlighted) do
            if v == card then
            elseif left == nil then
                left = v
            else
                right = v
            end
        end
        G.E_MANAGER:add_event(Event({
            trigger = "after",
            delay = 0.15,
            func = function()
                left:flip()
                play_sound("card1", 1.15 - (1 - 0.999) / (2 - 0.998) * 0.3)
                return true
            end,
        }))
        G.E_MANAGER:add_event(Event({
            trigger = "after",
            delay = 0.15,
            func = function()
                right:flip()
                play_sound("card1", 1.15 - (2 - 0.999) / (2 - 0.998) * 0.3)
                return true
            end,
        }))
        G.E_MANAGER:add_event(Event({
            trigger = "after",
            delay = 0.1,
            func = function()
                    local left_suit_prefix = string.sub(left.base.suit, 1, 1)..'_'
                    local left_rank_suffix = left.base.id
                    if left_rank_suffix < 10 then left_rank_suffix = tostring(rank_suffix)
                    elseif left_rank_suffix == 10 then left_rank_suffix = 'T'
                    elseif left_rank_suffix == 11 then left_rank_suffix = 'J'
                    elseif left_rank_suffix == 12 then left_rank_suffix = 'Q'
                    elseif left_rank_suffix == 13 then left_rank_suffix = 'K'
                    elseif left_rank_suffix == 14 then left_rank_suffix = 'A'
                    end
                    local right_suit_prefix = string.sub(right.base.suit, 1, 1)..'_'
                    local right_rank_suffix = right.base.id
                    if right_rank_suffix < 10 then right_rank_suffix = tostring(rank_suffix)
                    elseif right_rank_suffix == 10 then right_rank_suffix = 'T'
                    elseif right_rank_suffix == 11 then right_rank_suffix = 'J'
                    elseif right_rank_suffix == 12 then right_rank_suffix = 'Q'
                    elseif right_rank_suffix == 13 then right_rank_suffix = 'K'
                    elseif right_rank_suffix == 14 then right_rank_suffix = 'A'
                    end
                    left:set_base(G.P_CARDS[right_suit_prefix..right_rank_suffix])
                    right:set_base(G.P_CARDS[left_suit_prefix..left_rank_suffix])
            end,
        }))
        G.E_MANAGER:add_event(Event({
            trigger = "after",
            delay = 0.15,
            func = function()
                left:flip()
                play_sound("card1", 1.15 - (1 - 0.999) / (2 - 0.998) * 0.3)
                return true
            end,
        }))
        G.E_MANAGER:add_event(Event({
            trigger = "after",
            delay = 0.15,
            func = function()
                right:flip()
                play_sound("card1", 1.15 - (2 - 0.999) / (2 - 0.998) * 0.3)
                return true
            end,
        }))
        G.E_MANAGER:add_event(Event({trigger = 'after', delay = 0.2,func = function() G.hand:unhighlight_all(); return true end }))
    end

print says nil

[restive badger]

hey first time modder here can anyone help?
I tried following a tutorial and it says the game crashed with a bunch of lines saying a whole bunch of stuff about errors and such

[limpid flint]

Hi first time modder!

Can you post that bunch of lines saying a whole bunch of stuff about errors and such

[restive badger]

I can try im not sure how to take a screenshot and save it...

[tepid crow]

don't take a screenshot

copy+paste it

you can just press ctrl+c on the crash screen

[restive badger]

Well I mean when I try to open the game it has a crash screen I cant interact with

it had alot of other stuff before I closed it but now it has this

oh wait I think I know what you mean

[tepid crow]

that one looks like steamodded isn't present

[restive badger]

how would I go about adding it? I have steamodded in...

[tepid crow]

probably just nested on accident

[restive badger]

Is this not correct?

[tepid crow]

it looks fine in this folder

[restive badger]

Also it made the lovely folder after I tried launching the game it didnt have that before launch

where could I go to check for errors?

[tepid crow]

coincidentally, in the lovely folder

lovely/logs/

[hardy viper]

i wish steamodded had basic integrity checks

[tepid crow]

such as?

[hardy viper]

oh wait i could just

do that myself

[hardy viper]

errors in nesting is the main issue that doesnt seem to be accounted for

[restive badger]

one moment

I have two logs as I tried to launch twice

[tepid crow]

yeah I'm still guessing steamodded is nested

open the steamodded folder

[restive badger]

can I fix that somehow?

alright

[tepid crow]

sure, nested just means that instead of Balatro/mods/steamodded/ you have Balatro/mods/steamodded/steamodded/

[restive badger]

thanks for clarifying im like a toddler when it comes to modding if its not minecraft or f&h

What now?

[tepid crow]

could you show the steamodded folder?

[tepid crow]

well that seems good

did you just fix it based on the description I gave?

[restive badger]

Im afraid im not sure what you mean

[tepid crow]

that's a "no" then, don't worry haha

although you are missing the steamodded/lovely folder 🤔

[restive badger]

I apologize for being slow I dont want to try and waste your time as im trying to mod the first time-

[tepid crow]

no worries!

[restive badger]

Could I just make a lovely folder out of nowhere?

[tepid crow]

well you could but you'd be missing a lot of files in the folder haha

can I see your Mods/lovely/ folder? it might've accidentally moved

[restive badger]

Should I try re installing steamodded and see if I accidentally deleted lovely?

[edgy reef]

Because you can't.
Steamodded is nested -> lovely files inside SMODS can't patch -> code that detects if Steamodded is nested cannot load.

[restive badger]

alrighty

[tepid crow]

Hmm, nope. No idea where that folder went then

[restive badger]

?

[tepid crow]

Yeah just delete the entire steamodded folder and "reinstall"

[edgy reef]

Are we sure the mods aren't nested?

[restive badger]

alright, one moment...

[tepid crow]

I mean, steamodded missing its lovely folder should be fixed regardless

[restive badger]

?

[tepid crow]

yup

(also some other files that were indeed missing)

[restive badger]

should I try launching?

[tepid crow]

go for it

[restive badger]

well now im back with the huge line of error code let me take a phone picture...

[tepid crow]

if you could ctrl+c it that'd be better 😬

[restive badger]

Sorry I didnt know I could do that for a sec-

If ultimately my pc just cant mod it i'd be a little disapointed but I could live I just really wanted to be able to mod

[tepid crow]

why's your balatro version 1.0.1f?

[restive badger]

Well, I dont know how to update it as it isnt from steam... if I were to reinstall a "latest version" would it be better?

[tepid crow]

I think it's crashing because it's assuming you're using the latest version of balatro

[restive badger]

Im not sure if that gets in the way as Ive modded lots of games not from steam

[tepid crow]

(there's some small code changes)

[restive badger]

I see...

should I check for a newer version?

[edgy reef]

ig checking if mods being loaded are nested is definitely possible but it's more of an issue on created by Steamodded having a different file depth loading than lovely.

[tepid crow]

I don't recall there being anything else on the pc except steam? is this pirated?