#💻・modding-dev | Balatro | Page 68

shell timber Sep 20, 2024, 12:11 PM

#

that's not a good idea tbh

stiff locust Sep 20, 2024, 12:11 PM

#

i always have bad ideas this is nothing new

shell timber Sep 20, 2024, 12:11 PM

#

if you're learning as you go, you'll make bad decisions for e.g. the structure of the code

#

which will be hard to fix if you're new

stiff locust Sep 20, 2024, 12:12 PM

#

that doesn't sound too hard
i do already know python

#

so fundamentally i feel like im okay

shell timber Sep 20, 2024, 12:16 PM

#

well good luck then

stiff locust Sep 20, 2024, 12:16 PM

#

yeah it looks like i fixed almost everything

#

it's just this part that is red now

shell timber Sep 20, 2024, 12:19 PM

#

have you defined mod_obj?

#

other than that that's probably normal(?)

stiff locust Sep 20, 2024, 12:19 PM

#

uhh

#

no

languid mirage Sep 20, 2024, 12:20 PM

#

SMODS will always be like that

stiff locust Sep 20, 2024, 12:20 PM

#

i see so that's normal

shell timber Sep 20, 2024, 12:20 PM

#

(as will fusion jokers)

languid mirage Sep 20, 2024, 12:20 PM

#

because it's not a part of your project

stiff locust Sep 20, 2024, 12:20 PM

#

makes sense

#

i made sure the priority is higher than fusionjokers so this mod loads after fusionjokers

#

balatro gave me the same error though

languid mirage Sep 20, 2024, 12:23 PM

#

stiff locust it's just this part that is red now

that atlas registering looks rather horrendous

at least take a look at example mods for better understanding of how 1.0.0 steamodded works

https://github.com/Steamopollys/Steamodded/blob/main/example_mods/Mods/ExampleJokersMod/ModdedVanilla.lua

https://github.com/Steamopollys/Steamodded/wiki/03.-API-Documentation

https://github.com/Steamopollys/Steamodded/wiki/04.-SMODS.Atlas

https://github.com/Steamopollys/Steamodded/wiki/05.-SMODS.Center

stiff locust Sep 20, 2024, 12:23 PM

#

oh okay

#

so I need to write

SMODS.atlas {
key = "Tsunami",
path = "TsunamiJokers.png",
px = 71,
py = 95,
}

#

did i get that right

languid mirage Sep 20, 2024, 12:28 PM

#

ye

stiff locust Sep 20, 2024, 12:28 PM

#

and I do that at the top of the code

languid mirage Sep 20, 2024, 12:28 PM

#

uppercase Atlas

stiff locust Sep 20, 2024, 12:28 PM

#

okay

languid mirage Sep 20, 2024, 12:28 PM

#

it doesn't matter

stiff locust Sep 20, 2024, 12:28 PM

#

👍

#

I am still getting the same [ expected near local error

#

the rest of the code looks like it'll work

shell timber Sep 20, 2024, 1:34 PM

#

i'm having a weird issue with steamodded's consumeable api

#

i have my consumeables and they're working normally

#

but the use function's card doesn't refer to the actual card

#

for whatever reason

frosty dock Sep 20, 2024, 1:35 PM

#

shell timber but the `use` function's `card` doesn't refer to the actual card

are you sure you got your arguments right? it's use(self, card)

shell timber Sep 20, 2024, 1:35 PM

#

it is

#

the issue is that the values in ability are always the values of the default center

frosty dock Sep 20, 2024, 1:36 PM

#

any other mods?

shell timber Sep 20, 2024, 1:37 PM

#

cryptid, talisman, debugplus

frosty dock Sep 20, 2024, 1:38 PM

#

i remember cryptid causing similar issues at one point?? though they really should be resolved

shell timber Sep 20, 2024, 1:38 PM

#

hm

#

i'll try disabling cryptid

#

okay yeah i turned cryptid and talisman off and it works now

crisp elbow Sep 20, 2024, 1:45 PM

#

🤔 that's interesting

hardy viper Sep 20, 2024, 1:46 PM

#

shell timber i'll try disabling cryptid

do you have latest cryptid?

shell timber Sep 20, 2024, 1:46 PM

#

i have the release version of cryptid

hardy viper Sep 20, 2024, 1:46 PM

#

that would explain it

crisp elbow Sep 20, 2024, 1:46 PM

#

yeah use git

shell timber Sep 20, 2024, 1:46 PM

#

since that's what most people will be using

#

i know how to use git

crisp elbow Sep 20, 2024, 1:46 PM

#

Never said you didn't it's just that dev versions of cryptid usually include those fixes

shell timber Sep 20, 2024, 1:47 PM

#

true

hardy viper Sep 20, 2024, 1:47 PM

#

latest is generally the most stable (ironically), release version has a lot of bugs that are patched

crisp elbow Sep 20, 2024, 1:47 PM

#

NODDERS

hardy viper Sep 20, 2024, 1:47 PM

#

the only exception to that is lovely beta7

crisp elbow Sep 20, 2024, 1:47 PM

#

What is even going on with lovely beta7 atm kekw

hardy viper Sep 20, 2024, 1:47 PM

#

idk

#

i mean

crisp elbow Sep 20, 2024, 1:48 PM

#

i haven't even updated out of fear cause of the crashes

hardy viper Sep 20, 2024, 1:48 PM

#

all i know is that the priority is limited to an int32 for some reason

#

and even then that's just because i heard someone say that jen said to lower priority to within that range

#

it's a mystery

#

all i know is that lovely beta6 works just fine

#

and beta7 doesn't

shell timber Sep 20, 2024, 1:51 PM

#

okay, latest cryptid still has the issue

crisp elbow Sep 20, 2024, 1:51 PM

#

huh that's wack

#

I would say something in their discord or in the mod thread abt it as well to see if it can get checked out or fixed

#

🤔

hardy viper Sep 20, 2024, 1:52 PM

#

ya if you post relevant mod code and stuff in the cryptid bug report channel it should get fixed relatively quickly

#

or look through the cryptid code and figure out what's wrong yourself but that's only if you think you'd find it fun

shell timber Sep 20, 2024, 1:54 PM

#

i found it already

#

this is probably the issue

frosty dock Sep 20, 2024, 1:55 PM

#

that's still there?

shell timber Sep 20, 2024, 1:55 PM

#

it's to fix vanilla stuff i think

frosty dock Sep 20, 2024, 1:56 PM

#

vanilla stuff is fixed in steamodded last i checked

#

try just removing the patch

shell timber Sep 20, 2024, 1:56 PM

#

nah i just fixed it

frosty dock Sep 20, 2024, 1:57 PM

#

hm?

shell timber Sep 20, 2024, 1:57 PM

#

i just added self.ability.set ~= "Colour"

frosty dock Sep 20, 2024, 1:57 PM

#

still i don't think removing the patch should cause any issues

shell timber Sep 20, 2024, 2:00 PM

#

okay yeah removing it works fine?

#

i've submitted a PR to cryptid that removes the patch

#

anyways, colour cards are in again

crisp elbow Sep 20, 2024, 3:16 PM

#

real

shell timber Sep 20, 2024, 4:07 PM

#

morefluff 1.0.0 will also have jokerdisplay support

gaunt thistle Sep 21, 2024, 12:53 AM

#

can one of y'all Ctrl+f balatro source for if not OmegaMeta for me?

hardy viper Sep 21, 2024, 12:58 AM

#

hallow forge Sep 21, 2024, 12:59 AM

#

gaunt thistle can one of y'all Ctrl+f balatro source for `if not OmegaMeta` for me?

that's Talisman

hardy viper Sep 21, 2024, 12:59 AM

#

yeah it looks like theres a patch in game.lua for that

#

📎 message.txt

gaunt thistle Sep 21, 2024, 1:00 AM

#

gotcha. thats the code that's causing lovely's UTF-8 crash

#

it's odd because it's being passed as the chunk name

mellow sable Sep 21, 2024, 1:27 AM

#

:jimball:

hardy viper Sep 21, 2024, 1:27 AM

#

jimball

#

renew that nitro

#

or dont discord doesnt deserve money gladeline

mellow sable Sep 21, 2024, 1:28 AM

#

I never bought nitro lol

narrow pollen Sep 21, 2024, 1:36 AM

#

just a question, as i'm getting back into the swing of things for balatro modding:
if i don't set a sprite for an existing joker, will it retain its default sprite after i take ownership of it?

lament flame Sep 21, 2024, 1:47 AM

#

Guys whats the height and width of the jokers, vouchers and consumables?

#

Also for atlas's you do draw the jokers as individual sprites then import them into one big one?

surreal marsh Sep 21, 2024, 1:55 AM

#

lament flame Guys whats the height and width of the jokers, vouchers and consumables?

1x 71*95, 2x 142*190

brisk rose Sep 21, 2024, 2:51 AM

#

shell timber morefluff 1.0.0 will also have jokerdisplay support

Wait, did you buff coupon catalog? Bold move if so

shell timber Sep 21, 2024, 3:18 AM

#

it's uncommon now

spiral orbit Sep 21, 2024, 3:21 AM

#

making a texture pack that replaces face cards with just more queens

gray magnet Sep 21, 2024, 3:21 AM

#

oops all queens

spiral orbit Sep 21, 2024, 3:22 AM

#

your never gonna guess what i called the mod

opal spade Sep 21, 2024, 3:26 AM

#

my favorite cards
Queen, Kueen and Jueen

shell timber Sep 21, 2024, 4:39 AM

#

is there a way to include a literal # in a card's name?

wild gyro Sep 21, 2024, 4:39 AM

#

spiral orbit making a texture pack that replaces face cards with just more queens

estrogen

shell timber Sep 21, 2024, 4:40 AM

#

i thought that was a suggestion for a method for a moment

wild gyro Sep 21, 2024, 4:41 AM

#

yeah that works too

shell timber Sep 21, 2024, 4:51 AM

#

first bit of New Content for the morefluff 1.0.0 port: Cryptid colour cards!
in order:

Purple: Epic Tag (4 rounds)
Moonstone: Jolly Joker (2 rounds)
Gold: Negative Gateway (9 rounds)
00FF00: Negative Code Card (4 rounds)

shell timber Sep 21, 2024, 5:28 AM

#

another bit, there's now a T3 voucher for Colour Cards

lament flame Sep 21, 2024, 5:34 AM

#

hey guys, how do you all add joker text on your joker sprites?

brisk rose Sep 21, 2024, 5:47 AM

#

lament flame hey guys, how do you all add joker text on your joker sprites?

I presume they just draw it like anything else or copy the pixels directly from another joker

lament flame Sep 21, 2024, 6:26 AM

#

moab jonkler

#

(my first attempt at making a joker)

tepid sky Sep 21, 2024, 6:57 AM

#

spiral orbit making a texture pack that replaces face cards with just more queens

now we also need oops all kings & oops all jacks 🤔 , but they look good! nice one :D

spiral orbit Sep 21, 2024, 6:57 AM

#

ty :D

shell timber Sep 21, 2024, 7:05 AM

#

morefluff 1.0.0 will also be compatible with cardsleeves

brisk rose Sep 21, 2024, 7:11 AM

#

shell timber morefluff 1.0.0 will also be compatible with cardsleeves

indeed, it isn't a dick... or a deck for that matter :P It's a sleeve

#

(it really does look like an i at a distance to me)

limpid flint Sep 21, 2024, 7:21 AM

#

What

brisk rose Sep 21, 2024, 7:23 AM

#

limpid flint What

bottom right

#

Says "this is not a deck" in french, the e looks kinda like an i

limpid flint Sep 21, 2024, 7:24 AM

#

That doesn't look like an I to me...

brisk rose Sep 21, 2024, 7:24 AM

#

I may be slightly blind

#

lmao

#

for reference, this is kinda what I see when it's all zoomed out

hearty mesa Sep 21, 2024, 7:52 AM

#

how can i get the edition of a joker?

languid mirage Sep 21, 2024, 9:26 AM

#

if you're using steamodded then card.edition.key

#

@hearty mesa

#

otherwise its wonky
you need to check like card.edition.negative card.edition.polychrome etc.

#

also make sure to check that card.edition exists

stiff locust Sep 21, 2024, 9:51 AM

#

shell timber morefluff 1.0.0 will also have jokerdisplay support

why did you buff it

shell timber Sep 21, 2024, 9:51 AM

#

it's uncommon now

stiff locust Sep 21, 2024, 9:51 AM

#

ohh okay

#

makes sense then

shell timber Sep 21, 2024, 11:12 AM

#

wanted to test if a card worked while another language was on, picked italian at random, and then got jumpscared

hearty mesa Sep 21, 2024, 11:17 AM

#

languid mirage if you're using steamodded then card.edition.key

thank you!

stiff locust Sep 21, 2024, 11:24 AM

#

SMODS.Atlas {
    key = "Tsunami",
    path = "TsunamiJokers.png",
    px = 71,
    py = 95,
    }

local splishsplash = {
    loc = {
        name = "Splish Splash",
        text = {
            "Creates 1",
            "{X:red,C:white} Splash",
            " at end of round"
        },
        rarity = 5,
        cost = 8,
        unlocked = true,
        discovered = true,
        blueprint_compat = true,
        eternal_compat = true,
        atlas = "Tsunami",
        pos = { x = 0, y = 0 },
    },
    ability_name = "Splish Splash",
    slug = "j_splish_splash",
    calculate = function(self_card,context)
        if
        context.end_of_round
        then
            local card = self_card("Joker", G.jokers, nil, nil, nil, nil, "j_splash")
            card:add_to_deck()
            G.jokers:emplace(card)
        end
    end
    }

    FusionJokers.fusions:add_fusion("j_riff_raff", nil, false, "j_splash", nil, false, "j_splish_splash", 8)

still getting that unexpected [ near local error, it says it happens near local splishsplash = { and near apparently means within one line?

#

this error happened before i cleaned up the atlas too so I know it's not the atlas

shell timber Sep 21, 2024, 11:26 AM

#

you're probably missing a comma?

stiff locust Sep 21, 2024, 11:26 AM

#

i excluded the steamodded header and footer from the code here, rest assured they are in my actual lua file

shell timber Sep 21, 2024, 11:26 AM

#

somewhere

stiff locust Sep 21, 2024, 11:26 AM

#

the lua extension for vscode doesn't say i'm missing one

#

¯_(ツ)_/¯

shell timber Sep 21, 2024, 11:27 AM

#

uh, that's very odd

brisk rose Sep 21, 2024, 11:27 AM

#

shell timber you're probably missing a comma?

wait isn't there an extra comma? I don't think you're supposed to have one in the last item

shell timber Sep 21, 2024, 11:27 AM

#

you're allowed to do that

brisk rose Sep 21, 2024, 11:27 AM

#

ah ok

wintry solar Sep 21, 2024, 11:27 AM

#

you miss a } in your loc

shell timber Sep 21, 2024, 11:27 AM

#

makes appending easier

brisk rose Sep 21, 2024, 11:27 AM

#

I was guessing

stiff locust Sep 21, 2024, 11:27 AM

#

wintry solar you miss a } in your loc

it's this one at the end

#

or wait

shell timber Sep 21, 2024, 11:28 AM

#

that one's the end of the object

stiff locust Sep 21, 2024, 11:28 AM

#

this one is the one for the loc {

#

above ability name

shell timber Sep 21, 2024, 11:28 AM

#

can you screenshot the code? it should show the pairs of brackets

wintry solar Sep 21, 2024, 11:28 AM

#

should be here

stiff locust Sep 21, 2024, 11:28 AM

#

stiff locust Sep 21, 2024, 11:28 AM

#

wintry solar should be here

but there is a } there

wintry solar Sep 21, 2024, 11:28 AM

#

no, another one

stiff locust Sep 21, 2024, 11:28 AM

#

i need two??

wintry solar Sep 21, 2024, 11:28 AM

#

the one there closes the text

#

you need to close the loc too

#

then delete the one under pos

stiff locust Sep 21, 2024, 11:29 AM

#

so like this

wintry solar Sep 21, 2024, 11:29 AM

#

👍

stiff locust Sep 21, 2024, 11:29 AM

#

okay i'll try it now

#

also it's

#

supposed to be when blind is selected

#

what's the state name for blind select

maiden phoenix Sep 21, 2024, 11:30 AM

#

context.setting_blind

stiff locust Sep 21, 2024, 11:30 AM

#

wintry solar 👍

same error happened

wintry solar Sep 21, 2024, 11:30 AM

#

can I see where you try and create the joker object?

stiff locust Sep 21, 2024, 11:30 AM

#

is that not what I'm doing

wintry solar Sep 21, 2024, 11:30 AM

#

no

stiff locust Sep 21, 2024, 11:31 AM

#

oh

#

i

haven't done that yet

wintry solar Sep 21, 2024, 11:31 AM

#

when does it crash?

stiff locust Sep 21, 2024, 11:31 AM

#

on boot

#

of balatro

#

and it still says unexpected [ near local

#

and it's on the line local splishsplash = {

wintry solar Sep 21, 2024, 11:31 AM

#

can you send the crash screen?

stiff locust Sep 21, 2024, 11:32 AM

#

it's here
the only difference between this crash and the one I just got is that the crash in the new one happens on line 18 because the code got moved down when i added the atlas

#

i made sure my mod loads after fusionjokers because i'm trying to register a fusion

tepid sky Sep 21, 2024, 11:35 AM

#

oh god fusions, i've never been able to get that working personally lol

brisk rose Sep 21, 2024, 11:35 AM

#

I... have expereince in shoddily making fusions... not fusions, lol

stiff locust Sep 21, 2024, 11:35 AM

#

i haven't gotten past booting up the game yet so

#

¯_(ツ)_/¯

#

once i get past this error

#

the next error will show up

brisk rose Sep 21, 2024, 11:36 AM

#

as is the nature of coding

stiff locust Sep 21, 2024, 11:36 AM

#

it also just occurred to me that i forgot to add the line of text that lists the fusion material

#

added that now

tepid sky Sep 21, 2024, 11:36 AM

#

nice

stiff locust Sep 21, 2024, 11:36 AM

#

brisk rose as is the nature of coding

as long as the error changes, progress is being made

brisk rose Sep 21, 2024, 11:37 AM

#

I wonder if you're gonna run into problems with Fusion being 0.98 when your mod is native 1.0 code

stiff locust Sep 21, 2024, 11:37 AM

#

at first i did it the 0.9.8 way but they told me to not do that

#

it didn't work before or after i did that though

shell timber Sep 21, 2024, 11:38 AM

#

brisk rose I wonder if you're gonna run into problems with Fusion being 0.98 when your mod ...

Jen's Almanac rewrote fusion jokers for 1.0.0 iirc

stiff locust Sep 21, 2024, 11:38 AM

#

he just fixed the uhh

brisk rose Sep 21, 2024, 11:38 AM

#

stiff locust at first i did it the 0.9.8 way but they told me to not do that

should be fine if you pass it the values it expects

stiff locust Sep 21, 2024, 11:38 AM

#

end round cash bug

#

i don't think he rewrote the entire thing

brisk rose Sep 21, 2024, 11:38 AM

#

stiff locust end round cash bug

I thought Dim did that

#

or me

#

but dim added it

stiff locust Sep 21, 2024, 11:38 AM

#

it's been fixed by multiple people

wintry solar Sep 21, 2024, 11:38 AM

#

can you drop your main file in here for me to look at?

brisk rose Sep 21, 2024, 11:39 AM

#

brisk rose or me

(yes I deadass forgot for a second I was the first one to fix that bug, lol)

stiff locust Sep 21, 2024, 11:39 AM

#

wintry solar can you drop your main file in here for me to look at?

📎 Tsunami.lua

wintry solar Sep 21, 2024, 11:40 AM

#

that's not what you sent before?

stiff locust Sep 21, 2024, 11:40 AM

#

yes that's exactly the same thing

#

but with the header and footer

#

this is all the code I have so far

wintry solar Sep 21, 2024, 11:40 AM

#

theres no atlas in this

stiff locust Sep 21, 2024, 11:40 AM

#

oh huh

#

where did it go

wintry solar Sep 21, 2024, 11:40 AM

#

are you editing a different file

stiff locust Sep 21, 2024, 11:40 AM

#

oh my god i'm editing a different file

#

I MOVED A COPY OF THE MOD OUT OF THE MODS FOLDER SO I COULD PLAY BALATRO WHILE I WAS WORKING ON IT

#

hold on let me

#

if this works it's gonna be really funny

wintry solar Sep 21, 2024, 11:41 AM

#

I mean it still won't work

#

but it shouldn't crash

frosty dock Sep 21, 2024, 11:42 AM

#

oops didn't realize i was scrolled up, don't mind me

stiff locust Sep 21, 2024, 11:42 AM

#

wintry solar but it shouldn't crash

i mean that's progress

#

okay it shows up in the mod browser

#

and doesn't crash on startup

#

so now I need to create the joker object

#

that's with smods.joker right

wintry solar Sep 21, 2024, 11:44 AM

#

yeah, though I don't see why you'd create this table to then take the values of it and put them in the function, just put them striaght in instead

stiff locust Sep 21, 2024, 11:45 AM

#

"put them straight in"?

#

so by values of it you mean like

#

the ability and the text and the name of the joker and stuff

#

right

wintry solar Sep 21, 2024, 11:45 AM

#

yes

stiff locust Sep 21, 2024, 11:46 AM

#

okay

#

i will do that now

#

oh i forgot the key

stiff locust Sep 21, 2024, 11:49 AM

#

wintry solar yes

will my joker by default be undiscovered

#

i can't find it in the collection but the number of jokers went up so

brisk rose Sep 21, 2024, 11:49 AM

#

stiff locust will my joker by default be undiscovered

it's a parameter on making it

stiff locust Sep 21, 2024, 11:49 AM

#

it's definitely there

#

okay but what's the default value

wintry solar Sep 21, 2024, 11:50 AM

#

if you go via the mods menu you'll find it easily

stiff locust Sep 21, 2024, 11:50 AM

#

oh ok

#

.

#

something went wrong

#

brisk rose Sep 21, 2024, 11:50 AM

#

stiff locust Sep 21, 2024, 11:50 AM

#

it also occurred to me I made the mod badge green instead of blue

#

oops.

#

fixed that

#

okay the picture of the joker showed up

#

but the text has not

brisk rose Sep 21, 2024, 11:54 AM

#

brisk rose

is it formatted like the example here?

stiff locust Sep 21, 2024, 11:55 AM

#

i think i fixed the format

#

let me try

#

okay i formatted it wrong but IT WORKS

#

also i need to update the text to say when blind is selected

#

oops

#

what's the formatting for a joker name

shell timber Sep 21, 2024, 11:59 AM

#

{C:attention}whatever{}

#

usually(?)

nimble sequoia Sep 21, 2024, 11:59 AM

#

stiff locust

did you fix your calculate function parameters? it should be self,card,context and not self_card,context

stiff locust Sep 21, 2024, 11:59 AM

#

oh i'll do that now

nimble sequoia Sep 21, 2024, 11:59 AM

#

👍

stiff locust Sep 21, 2024, 12:00 PM

#

and what's the formatting for the (must have room) text

shell timber Sep 21, 2024, 12:00 PM

#

{C:inactive}(must have room){}

stiff locust Sep 21, 2024, 12:00 PM

#

thanks

shell timber Sep 21, 2024, 12:01 PM

#

you can open the base game's code by opening the exe with winrar

#

and then the default localisation string are under localization/en_us.lua

stiff locust Sep 21, 2024, 12:01 PM

#

nimble sequoia 👍

it made this turn red

#

that's not supposed to happen is it

nimble sequoia Sep 21, 2024, 12:02 PM

#

i think self_card should be card and your local card variable should be something different

stiff locust Sep 21, 2024, 12:03 PM

#

does it matter what i name the local card variable

nimble sequoia Sep 21, 2024, 12:03 PM

#

nah

stiff locust Sep 21, 2024, 12:03 PM

#

okay

brisk rose Sep 21, 2024, 12:03 PM

#

(Keeping in mind this is 0.98 code) Does anyone know whey this joker doesn't work?

#

It just... does nothing, at least when you try it with a lucky card. I don't think the specific enhancement would make a difference though

#

Joker is originally from Jestobiology and the code is identical. I don't know if it works there, but I'm unsure why it would

maiden phoenix Sep 21, 2024, 12:06 PM

#

brisk rose (Keeping in mind this is 0.98 code) Does anyone know whey this joker doesn't wor...

Replace context.other_card.ability.set == 'Enhanced' by context.other_card.ability.effect ~= 'Base'

nimble sequoia Sep 21, 2024, 12:09 PM

#

stiff locust it made this turn red

oh fuck are you coding for 0.9.8? i think i take back what i suggested

stiff locust Sep 21, 2024, 12:09 PM

#

nimble sequoia oh fuck are you coding for 0.9.8? i think i take back what i suggested

no

nimble sequoia Sep 21, 2024, 12:09 PM

#

ah

stiff locust Sep 21, 2024, 12:09 PM

#

fusionjokers is 0.9.8 i don't know if coding for 1.0.0 will have implications yet

#

if it causes problems with the first joker it won't be too hard to go back

#

i am gonna try it with 1.0.0 coding until something breaks

nimble sequoia Sep 21, 2024, 12:10 PM

#

stiff locust

i thought the code was 0.9.8 because there is SMODS.Sprite in it

maiden phoenix Sep 21, 2024, 12:10 PM

#

stiff locust it made this turn red

Shouldn't this be create_card instead?

stiff locust Sep 21, 2024, 12:10 PM

#

nimble sequoia i thought the code was 0.9.8 because there is SMODS.Sprite in it

oh yeah they got me to update the atlas

stiff locust Sep 21, 2024, 12:10 PM

#

maiden phoenix Shouldn't this be create_card instead?

oh should it be

maiden phoenix Sep 21, 2024, 12:11 PM

#

idk any function called self_card lol

stiff locust Sep 21, 2024, 12:11 PM

#

according to 0.9.8 that's how you'd create cards

brisk rose Sep 21, 2024, 12:11 PM

#

maiden phoenix Replace `context.other_card.ability.set == 'Enhanced'` by `context.other_card.ab...

no dice

maiden phoenix Sep 21, 2024, 12:11 PM

#

stiff locust according to 0.9.8 that's how you'd create cards

What?

stiff locust Sep 21, 2024, 12:11 PM

#

idk i saw a 0.9.8 joker do it

#

and i just copied that over

#

brb

maiden phoenix Sep 21, 2024, 12:14 PM

#

Ooh I get it

maiden phoenix Sep 21, 2024, 12:15 PM

#

brisk rose (Keeping in mind this is 0.98 code) Does anyone know whey this joker doesn't wor...

You also have to change Xmult_mod to x_mult

brisk rose Sep 21, 2024, 12:18 PM

#

maiden phoenix You also have to change `Xmult_mod` to `x_mult`

ayyy it works

#

thanks

stiff locust Sep 21, 2024, 12:26 PM

#

when i assign x and y positions for a joker

#

do i need to do anything special to make it work with 2x sprites

#

or does it just do that

maiden phoenix Sep 21, 2024, 12:28 PM

#

It automatically loads both x1 and x2 with the same pos

stiff locust Sep 21, 2024, 12:28 PM

#

with the
same pos?

#

won't that break it

maiden phoenix Sep 21, 2024, 12:28 PM

#

?

stiff locust Sep 21, 2024, 12:28 PM

#

or does it 2x the position values

maiden phoenix Sep 21, 2024, 12:28 PM

#

You need 2 different spritesheet

stiff locust Sep 21, 2024, 12:28 PM

#

well yeah

maiden phoenix Sep 21, 2024, 12:28 PM

#

one for x1 one for x2

stiff locust Sep 21, 2024, 12:28 PM

#

i know

#

but

maiden phoenix Sep 21, 2024, 12:28 PM

#

And that's it

stiff locust Sep 21, 2024, 12:28 PM

#

o kay

#

alright so

#

after setting the position values

#

(since i'm fusing every joker i just decided to copy over the vanilla joker sheets and slowly replace each joker on the sheet with its splash fusion)

#

i set it to 71 1140 which should be for riff raff, right?

#

but the sprite is invisible on 2x

#

olay so it's also invisible on 1x

brisk rose Sep 21, 2024, 12:39 PM

#

stiff locust i set it to 71 1140 which should be for riff raff, right?

pretty sure the pos isn't absolute pixels and is like.. the joker grid

stiff locust Sep 21, 2024, 12:40 PM

#

oh I know what I did wrong i think

#

these should be the size of the entire sheet right

brisk rose Sep 21, 2024, 12:41 PM

#

brisk rose pretty sure the pos isn't absolute pixels and is like.. the joker grid

#

unless it was changed for 1.0

stiff locust Sep 21, 2024, 12:41 PM

#

okay in that case it would beee

#

x 2 y 13

brisk rose Sep 21, 2024, 12:42 PM

#

keep in mind it's 0 indexed

#

so the top left is 0,0

stiff locust Sep 21, 2024, 12:42 PM

#

oh right

#

so it's x 1 y 12

stiff locust Sep 21, 2024, 12:43 PM

#

stiff locust these should be the size of the entire sheet right

i was wrong

#

there we go

#

now it's showing up as riff raff

#

final step is to check if the ability works

#

uh

#

okay so when I fused them

#

I got a cryptid crash?

#

what

📎 message.txt

#

i will now check the joker itself but the fusion is not working

#

upon starting a blind with the joker it gives this crash

📎 message.txt

#

i'm guessing it's one of these nil values that should have something in them

maiden phoenix Sep 21, 2024, 12:56 PM

#

This should be create_card not just card

stiff locust Sep 21, 2024, 12:56 PM

#

okay

#

it says undefined global when i do that

#

is that normal

maiden phoenix Sep 21, 2024, 12:56 PM

#

What

#

Send a screenshot

stiff locust Sep 21, 2024, 12:57 PM

#

maiden phoenix Sep 21, 2024, 12:57 PM

#

Ah ignore it

stiff locust Sep 21, 2024, 12:58 PM

#

okay

brisk rose Sep 21, 2024, 12:58 PM

#

Yeah you're using a library that the IDE doesn't know anything about

#

(at least I think that's what's going on)

stiff locust Sep 21, 2024, 12:58 PM

#

what about the cryptid crash

#

uhhh

#

LMAO

#

it made splash but splash did not get put in the joker slots

#

maiden phoenix Sep 21, 2024, 12:59 PM

#

Does your thing have the emplace line?

stiff locust Sep 21, 2024, 12:59 PM

#

uhh

#

yeah

maiden phoenix Sep 21, 2024, 12:59 PM

#

This should have the name of your local variable

stiff locust Sep 21, 2024, 12:59 PM

#

ohhhh

#

okay

#

fixed

#

that means the ability works now

#

but the actual fusion does not work right now

stiff locust Sep 21, 2024, 1:01 PM

#

maiden phoenix This should have the name of your local variable

i changed it and it didn't work

#

is this because of the second line here

maiden phoenix Sep 21, 2024, 1:03 PM

#

Yea this card should be splishcard too

stiff locust Sep 21, 2024, 1:03 PM

#

okay

#

do you know anything about that cryptid crash

#

dude i just got a seed that drew the hand K Q J 10 9 8 7 6

#

while testing the ability

#

everything is working ability side now :D

shell timber Sep 21, 2024, 1:05 PM

#

should it check to see if there's room available?

stiff locust Sep 21, 2024, 1:07 PM

#

shell timber should it check to see if there's room available?

i don't know i'm gonna test if it already does that or not

#

it does not check right now

#

honestly, might just change it to "don't need room" as a buff

#

yeah i'll do that

stiff locust Sep 21, 2024, 1:08 PM

#

stiff locust what

but what about this cryotid crash when i fuse it

shell timber Sep 21, 2024, 1:08 PM

#

i don't know about that

stiff locust Sep 21, 2024, 1:08 PM

#

🤔

wintry solar Sep 21, 2024, 1:09 PM

#

What does your fusion line look like?

stiff locust Sep 21, 2024, 1:09 PM

#

nocturne garnet Sep 21, 2024, 1:10 PM

#

does anyone know how to give something a sell button if its in a specifc cardarea?

#

i have no idea how ui stuff works

stiff locust Sep 21, 2024, 1:10 PM

#

check betmma's spells/abilities

#

they do that

stiff locust Sep 21, 2024, 1:12 PM

#

stiff locust

i'm pretty sure both nil here are for the carried value

#

because fusionjokers lets you carry values like sellvalue of the original jokers

#

and splish splash should not carry any values

stiff locust Sep 21, 2024, 1:14 PM

#

stiff locust

@wintry solar

wintry solar Sep 21, 2024, 1:15 PM

#

It’ll need to be j_modprefix_jokerkey

#

For the last argument

stiff locust Sep 21, 2024, 1:17 PM

#

wintry solar It’ll need to be `j_modprefix_jokerkey`

j_tsunami_splish_splash then?

wintry solar Sep 21, 2024, 1:17 PM

#

If that’s what you set your prefix and key as, yes

stiff locust Sep 21, 2024, 1:17 PM

#

okay

#

this did not fix the crash

stiff locust Sep 21, 2024, 1:21 PM

#

wintry solar If that’s what you set your prefix and key as, yes

should the slug be j_splish_splash splish_splash or j_tsunami_splish_splash

wintry solar Sep 21, 2024, 1:22 PM

#

You don’t need a slug

stiff locust Sep 21, 2024, 1:22 PM

#

oh

#

what does it do

wintry solar Sep 21, 2024, 1:22 PM

#

It’s old 0.9.8 jank

stiff locust Sep 21, 2024, 1:22 PM

#

oh okay

#

so i can just remove that

wintry solar Sep 21, 2024, 1:22 PM

#

Yeah

stiff locust Sep 21, 2024, 1:22 PM

#

alright

wintry solar Sep 21, 2024, 1:22 PM

#

Your joker should have a key value

stiff locust Sep 21, 2024, 1:22 PM

#

it does have a key value

#

which is splish_splash right now

wintry solar Sep 21, 2024, 1:23 PM

#

stiff locust `j_tsunami_splish_splash` then?

This then

stiff locust Sep 21, 2024, 1:23 PM

#

okay

stiff locust Sep 21, 2024, 1:24 PM

#

stiff locust what

the same crash still occurs

#

this crash still happens if cryptid isn't there

wintry solar Sep 21, 2024, 1:28 PM

#

Did you set your mod prefix?

stiff locust Sep 21, 2024, 1:29 PM

#

wintry solar Did you set your mod prefix?

.

#

no

#

where do I do that

wintry solar Sep 21, 2024, 1:35 PM

#

In the header, or just use the first four characters of your mod id instead

stiff locust Sep 21, 2024, 1:39 PM

#

wintry solar In the header, or just use the first four characters of your mod id instead

like this?

wintry solar Sep 21, 2024, 1:46 PM

#

I think it’s just prefix iirc

stiff locust Sep 21, 2024, 1:50 PM

#

did not fix the crash

wintry solar Sep 21, 2024, 1:52 PM

#

It might be case sensitive

stiff locust Sep 21, 2024, 1:53 PM

#

wintry solar It might be case sensitive

did not work

stiff locust Sep 21, 2024, 2:35 PM

#

stiff locust what

still have not solved this crash :(

#

it is the last roadblock to my splash fusion journey

stiff locust Sep 21, 2024, 6:28 PM

#

i need a lua wizard to save me

tepid sky Sep 21, 2024, 6:38 PM

#

settings is killing me

#

wintry solar Sep 21, 2024, 6:44 PM

#

stiff locust i need a lua wizard to save me

What’s the problem now?

edgy reef Sep 21, 2024, 6:58 PM

#

Hasn’t this error happened before?

#

Cryptid’s create_card getting a nil center?

#

Something like that.

#

Oh nah it’s just missing the mod prefix

tepid sky Sep 21, 2024, 7:25 PM

#

edgy reef Hasn’t this error happened before?

you mean my error?

#

nah right?

edgy reef Sep 21, 2024, 7:26 PM

#

No, the UI error is something else

#

That’s just incorrect depth.

edgy reef Sep 21, 2024, 7:27 PM

#

stiff locust what

This is lacking the mod prefix

tepid sky Sep 21, 2024, 7:28 PM

#

ah okays

stiff locust Sep 21, 2024, 7:29 PM

#

edgy reef This is lacking the mod prefix

but i

#

put the prefix in

#

on the steamodded header

#

is it supposed to go somewhere else

wintry solar Sep 21, 2024, 7:31 PM

#

show your code

stiff locust Sep 21, 2024, 7:34 PM

#

--- STEAMODDED HEADER
--- MOD_NAME: Tsunami
--- MOD_ID: Tsunami
--- MOD_AUTHOR: [Maratby]
--- MOD_DESCRIPTION: FUSES EVERY JOKER WITH SPLASH!!!! Eventually. Except for the ones on the front page.
--- BADGE_COLOUR: 0000FF
--- PRIORITY: -9999
--- PREFIX: tsun
----------------------------------------------
------------MOD CODE -------------------------

SMODS.Atlas {
    key = "Tsunami",
    path = "TsunamiJokers.png",
    px = 71,
    py = 95,
    }

    SMODS.Joker {
        loc_txt = {
            name = "Splish Splash",
            text = {
                "When blind is selected, creates {C:attention}Splash{}",
                "{C:inactive}(don't need room){}",
                "{s:0.7}(Riff Raff + Splash){}",
            }},
            rarity = 5,
            cost = 8,
            unlocked = true,
            discovered = true,
            blueprint_compat = true,
            eternal_compat = true,
            perishable_compat = true,
            key = "j_tsun_splish_splash",
            atlas = "Tsunami",
            pos = { x = 1, y = 12 },
        ability_name = "Splish Splash",
        calculate = function(self,card,context)
            if
            context.setting_blind
            then
                local splishcard = create_card("Joker", G.jokers, nil, nil, nil, nil, "j_splash")
                splishcard:add_to_deck()
                G.jokers:emplace(splishcard)
            end
        end
        }

    FusionJokers.fusions:add_fusion("j_riff_raff", nil, false, "j_splash", nil, false, "j_tsun_splish_splash", 6)
----------------------------------------------
------------MOD CODE END----------------------

wintry solar Sep 21, 2024, 7:38 PM

#

change your key to just splish_splash

#

you don't need to add j_tsun, smods does it for you

#

your actual key right now is j_tsun_j_tsun_splish_splash

tepid crow Sep 21, 2024, 7:40 PM

#

also, please fix that indentation 😬

stiff locust Sep 21, 2024, 7:44 PM

#

wintry solar your actual key right now is `j_tsun_j_tsun_splish_splash`

i see

#

will that solve the crash

wintry solar Sep 21, 2024, 7:46 PM

#

it should do yeah

stiff locust Sep 21, 2024, 7:52 PM

#

i will check soon i am on overwatch

tepid crow Sep 21, 2024, 7:53 PM

#

what role?

stiff locust Sep 21, 2024, 8:00 PM

#

tepid crow what role?

support

tepid crow Sep 21, 2024, 8:01 PM

#

W teammate

primal robin Sep 21, 2024, 8:03 PM

#

wintry solar you don't need to add `j_tsun`, smods does it for you

Btw for blinds it works different

#

It will add if it's not present only, so it has some checks

wintry solar Sep 21, 2024, 8:05 PM

#

are you sure?

primal robin Sep 21, 2024, 8:07 PM

#

Yes. In my mod I register blinds with key = "twbl_test" (where twbl is my mod prefix) and they added to a game like bl_twbl_test instead of bl_twbl_twbl_test

orchid thunder Sep 21, 2024, 8:08 PM

#

how does one make a new button

wintry solar Sep 21, 2024, 8:09 PM

#

sounds more like the prefix isn't defined properly, I'm not aware of any objects checking whether the prefix is present or not

tepid crow Sep 21, 2024, 8:10 PM

#

seems like he's right

            if string.sub(obj[key], 1, #prefix + 1) == prefix..'_' then
                -- this happens within steamodded itself and I don't want to spam the logs with warnings, leaving this disabled for now
                -- sendWarnMessage(("Attempted to prefix field %s=%s on object %s, already prefixed"):format(key, obj[key], obj.key), obj.set)
                return
            end

edgy reef Sep 21, 2024, 8:11 PM

#

How would this behavior be exclusive to blinds?

tepid crow Sep 21, 2024, 8:11 PM

#

it's not

wintry solar Sep 21, 2024, 8:12 PM

#

huh, I guess you can add your mod prefix to your keys if you want to

tepid crow Sep 21, 2024, 8:12 PM

#

and as usual, you really shouldn't 🙃

tepid crow Sep 21, 2024, 8:13 PM

#

orchid thunder how does one make a new button

there's UIBox_button?

wintry solar Sep 21, 2024, 8:13 PM

#

it'll also not recognise your prefixes if you put the objects prefix there too, so again, don't prefix your keys

tepid crow Sep 21, 2024, 8:13 PM

#

yeah, won't work if you do [obj-prefix]_[mod-prefix]_[obj-key]

stiff locust Sep 21, 2024, 8:45 PM

#

IT WORKED

#

okay so how do I create a github

tepid crow Sep 21, 2024, 8:49 PM

#

you probably start with a github account

stiff locust Sep 21, 2024, 8:53 PM

#

yeah i'm doing that

hardy viper Sep 21, 2024, 8:56 PM

#

how it feels to spend like 30 minutes figuring out how to make a custom rarity because there is no steamodded api for it

stiff locust Sep 21, 2024, 8:59 PM

#

how do I upload a file to my github

wintry solar Sep 21, 2024, 8:59 PM

#

I think rarity api was merged yesterday

#

oh maybe not

#

maybe the PR was updated

stiff locust Sep 21, 2024, 9:01 PM

#

also which license do i use

mellow sable Sep 21, 2024, 9:01 PM

#

wintry solar I think rarity api was merged yesterday

I don’t think it was

wintry solar Sep 21, 2024, 9:04 PM

#

yeah, I misread my emails

stiff locust Sep 21, 2024, 9:07 PM

#

also it is occurring to me that a fuck ton of these fusion effects require being able to count how many unscored cards were played

#

is it possible to apply splash's effect while also counting cards that would be unscored normally, to count how many extra cards were scored by splash?

#

this would be a major help

hardy viper Sep 21, 2024, 9:10 PM

#

wintry solar I think rarity api was merged yesterday

if only

maiden phoenix Sep 21, 2024, 9:11 PM

#

stiff locust is it possible to apply splash's effect while also counting cards that would be ...

I think I achieved this by calculating the diff between the poker hand size and the played hand size

#

When I made splash evo

stiff locust Sep 21, 2024, 9:11 PM

#

okay

#

is there a way i can detect which cards are not part of the poker hand size

#

some of these effects apply things to those specifically

maiden phoenix Sep 21, 2024, 9:14 PM

#

I made a table with that info, with the poker hand as a key and the size of the poker hand at its value

#

Taking four fingers into account too

stiff locust Sep 21, 2024, 9:27 PM

#

half joker is called j_half_joker internally right

#

i assume every joker is internally named like that, but after registering a fusion between half joker and splash just like last time, the fusion did not show up

tepid crow Sep 21, 2024, 9:29 PM

#

thunk might've named it differently

#

you should double check in game.lua

#

(showman for example is j_ring_master or something)

stiff locust Sep 21, 2024, 9:30 PM

#

also i'm pretty sure i got the calculation right for how much mult my joker should give

#

but it's not actually giving the mult

stiff locust Sep 21, 2024, 9:32 PM

#

tepid crow you should double check in `game.lua`

okay it's just called j_half

#

how do I make the joker output mult

tepid crow Sep 21, 2024, 9:33 PM

#

yeah that sounds logical

#

the example mods should give you something

stiff locust Sep 21, 2024, 9:33 PM

#

okay

loud citrus Sep 21, 2024, 9:35 PM

#

big thanks to frich for helping me understand how take ownership works

#

i have 4 more joker changes i wanna do egg

stiff locust Sep 21, 2024, 9:40 PM

#

uhh

#

why did it become rental when i fused them

#

i am on white stake???

loud citrus Sep 21, 2024, 9:43 PM

#

this is concerning

stiff locust Sep 21, 2024, 9:43 PM

#

it seems to have been a fluke?? i'll test again

stiff locust Sep 21, 2024, 9:44 PM

#

tepid crow the example mods should give you something

i am looking at the example walkie talkie
i can't figure out what part of the ability actually sends the mult

tepid crow Sep 21, 2024, 9:45 PM

#

not sure, I've never actually made a joker 😅

loud citrus Sep 21, 2024, 10:14 PM

#

can someone tell me why ability is a nil value? i'm taking ownership of square joker so it should use all of it's other code

zealous glen Sep 21, 2024, 10:35 PM

#

loud citrus can someone tell me why ability is a nil value? i'm taking ownership of square j...

I think it should be card in this instance

#

I haven’t modded in a while but I think Steamodded reserves the first argument here to the prototype objects the game builds, while the actual Joker during the game is the second argument, card

loud citrus Sep 21, 2024, 10:36 PM

#

it also says card is a nil value

#

this is raising more questions than answers

#

out of everything card shouldn't be nil lol

zealous glen Sep 21, 2024, 10:37 PM

#

Try checking a mod that takes ownership of existing Jokers then

loud citrus Sep 21, 2024, 10:38 PM

#

bunco is the only one ive seen and they just implement entirely new effects, what i'm trying to do is add abilities that rely on the existing card's code

zealous glen Sep 21, 2024, 10:39 PM

#

Aren’t you copy-pasting the existing code?

loud citrus Sep 21, 2024, 10:41 PM

#

no, i'm adding onto it, here's a screen shot of my working code for credit card, i gave it the ability to wipe debt

for square joker i'm adding a new context where if you discard exactly 4 cards it also adds chips, i'm using what should be an existing ability to make this happen

zealous glen Sep 21, 2024, 10:43 PM

#

loud citrus no, i'm adding onto it, here's a screen shot of my working code for credit card,...

I see. I do think you need to copy-paste because I reckon Steamodded would overwrite the native calculate function

#

Credit Card probably doesn’t break because it doesn’t use calculate

#

Credit Card probably works when added or removed from the deck, which have their own functions

wintry solar Sep 21, 2024, 10:44 PM

#

yeah it will overwrite the default behaviour

loud citrus Sep 21, 2024, 10:44 PM

#

oh! that helps because in testing i recreated the card as a new joker, shouldn't be too much work

zealous glen Sep 21, 2024, 10:45 PM

#

wintry solar yeah it will overwrite the default behaviour

Thanks for confirming my suspicion

#

I wonder if a setting to keep the original behaviour would be good

#

It would avoid mods copy-pasting code

loud citrus Sep 21, 2024, 10:46 PM

#

wintry solar yeah it will overwrite the default behaviour

then what about loyalty card? it's working just fine as well looking like this

wintry solar Sep 21, 2024, 10:46 PM

#

oh hang on actually

#

if it doesn't return anything it'll hit the default tower

zealous glen Sep 21, 2024, 10:47 PM

#

Ohh

#

The spaghetti

loud citrus Sep 21, 2024, 10:48 PM

#

i'm scared :(

#

working with spaghetti when i already make my own

tepid crow Sep 21, 2024, 10:48 PM

#

https://tenor.com/bIIwI.gif

Tenor

loud citrus Sep 21, 2024, 10:49 PM

#

i think it's funny how many if statements you can find in the code

wintry solar Sep 21, 2024, 10:49 PM

#

I mean you don't need to touch the base code at all

zealous glen Sep 21, 2024, 10:49 PM

#

localthunk’s if-else-if Tower of Babel

zealous glen Sep 21, 2024, 10:49 PM

#

wintry solar I mean you don't need to touch the base code at all

Well, it’s a good reference

tepid crow Sep 21, 2024, 10:50 PM

#

wintry solar I mean you don't need to touch the base code at all

No touching, only looking!

loud citrus Sep 21, 2024, 10:52 PM

#

anyways how do i fix the ability nil problem i have, because when i made new joker through SMODS it seems to take care of that problem for me?

tepid crow Sep 21, 2024, 10:53 PM

#

try returning something?

loud citrus Sep 21, 2024, 10:53 PM

#

when i remade square joker this is it! that's why i'm confused

tepid crow Sep 21, 2024, 10:54 PM

#

I'm sorry what is that

wintry solar Sep 21, 2024, 10:54 PM

#

the function should be (self, card, context) and then replace self.ability with card.ability

loud citrus Sep 21, 2024, 10:55 PM

#

tepid crow I'm sorry what is that

a remaking of square joker with my changes i wanna do in new joker form

loud citrus Sep 21, 2024, 10:55 PM

#

wintry solar the function should be `(self, card, context)` and then replace `self.ability` w...

lets try that

tepid crow Sep 21, 2024, 10:56 PM

#

isn't :register 0.9.8 stuff

loud citrus Sep 21, 2024, 10:57 PM

#

wintry solar the function should be `(self, card, context)` and then replace `self.ability` w...

IT WORKS

#

tank you!

#

thank

#

my old code is working again

zealous glen Sep 21, 2024, 10:58 PM

#

loud citrus lets try that

But that’s the first thing I said

loud citrus Sep 21, 2024, 10:58 PM

#

i thought you said to replace ability, i'm so silly

#

i'm sorry

zealous glen Sep 21, 2024, 10:58 PM

#

It’s fine

loud citrus Sep 21, 2024, 10:59 PM

#

it's funny because i have local card = self at the top

wintry solar Sep 21, 2024, 10:59 PM

#

in other news, I have loc_txt working with my texture pack stuff 🎉

loud citrus Sep 21, 2024, 11:00 PM

#

🥳

wintry solar Sep 21, 2024, 11:01 PM

#

now to build the actual selection UI 😭

zealous glen Sep 21, 2024, 11:02 PM

#

What does watermelon mean

hardy viper Sep 21, 2024, 11:02 PM

#

thats a fruit\

#

gladeline

zealous glen Sep 21, 2024, 11:03 PM

#

So is gros_michel

loud citrus Sep 21, 2024, 11:04 PM

#

now i'm proud to share reworked square joker

loud citrus Sep 21, 2024, 11:35 PM

#

well not to diffrent this time around

orchid thunder Sep 21, 2024, 11:51 PM

#

tepid crow there's `UIBox_button`?

How do I use it tho

tepid crow Sep 21, 2024, 11:53 PM

#

orchid thunder How do I use it tho

look at what thunk does in the base game

orchid thunder Sep 21, 2024, 11:56 PM

#

Do you know where I find that

tepid crow Sep 21, 2024, 11:57 PM

#

your editor really should have a "search through all files"

#

does it not?

orchid thunder Sep 21, 2024, 11:58 PM

#

I use notepad ++

tepid crow Sep 21, 2024, 11:58 PM

#

cool, that one has search all

#

ctrl+shift+f

orchid thunder Sep 21, 2024, 11:58 PM

#

But don't I have to open all the files with it

tepid crow Sep 21, 2024, 11:59 PM

#

no

#

just select the directory of the unzipped game

orchid thunder Sep 21, 2024, 11:59 PM

#

Oh

tepid crow Sep 22, 2024, 12:01 AM

#

like this :)

orchid thunder Sep 22, 2024, 12:02 AM

#

Holy shoot

#

Ok you learn something new every day

tepid crow Sep 22, 2024, 12:03 AM

#

https://tenor.com/bkFGw.gif

Tenor

normal timber Sep 22, 2024, 12:54 AM

#

Mods won't load for me 😦 I've followed the steps, and tried several different mods, but when I launch the game, it just runs the base version of Balatro. Am I missing something?

crisp elbow Sep 22, 2024, 1:04 AM

#

no version.dll

#

also mods is in the wrong folder I think

#

the folder they're supposed to be in is c:/users/user/appdata/roaming/balatro

#

just copy and paste the mod folder into the balatro folder

normal timber Sep 22, 2024, 1:10 AM

#

Thanks for the help. Moving the files there has made no difference. What's the version.dll? I can't see any reference to that file in the Steamodded installation guide

brisk rose Sep 22, 2024, 1:11 AM

#

It's Lovely. You need it for Steamodded

#

https://github.com/ethangreen-dev/lovely-injector

GitHub

GitHub - ethangreen-dev/lovely-injector: A runtime lua injector for...

A runtime lua injector for games built with LÖVE. Contribute to ethangreen-dev/lovely-injector development by creating an account on GitHub.

normal timber Sep 22, 2024, 1:14 AM

#

ah, ty

orchid thunder Sep 22, 2024, 2:22 AM

#

im about to cry i cant figure out how to make a button

stiff locust Sep 22, 2024, 5:30 AM

#

okay seriously how do i make my joker give mult

#

the example mods did not help

#

i just can't understand why theirs gives mult and mine doesn't

brisk rose Sep 22, 2024, 5:32 AM

#

here's another example, it's a bit conveluted due to its dual nature, but it's what I found on short notice

#

it looks like it's almost done by default

stiff locust Sep 22, 2024, 5:33 AM

#

so it's the

if context.joker_main
  return {
    mult = card.ability.extra.mult,
    card = card
  }

right?

brisk rose Sep 22, 2024, 5:35 AM

#

What exactly does your calculate function look like?

#

the whole thing

brisk rose Sep 22, 2024, 5:36 AM

#

stiff locust so it's the ``` if context.joker_main return { mult = card.ability.extra....

I'd guess so, but you might need more for context

#

also I haven't seen context.joker_main anywhere

stiff locust Sep 22, 2024, 5:38 AM

#

brisk rose What exactly does your calculate function look like?

this joker should give +5 mult per unscored card
and i'm using the same method as sdm0's splash evolution to determine the number of unscored cards, which is checking how many scored cards there should be and checking how many cards were in the played hand and then subtracting them and multiplying the difference by 5 to get the number of mult it gives

even when i just tried setting the mult to a static value (was 5 for testing) though, it never gives out mult anyway

#

most of this code is unchanged from sdm0's, except with me changing the mult mod to 5, because the effects of the splash evolution and the soaked joker fusion are really similar

#

everything else about the joker works except for the ability

#

I need to get this working because this function is the backbone to a LOT of splash fusions

lament flame Sep 22, 2024, 5:43 AM

#

where are the joker abilities stored in balatro? i was looking in the source code and it only has the description and stuff i think its loc text stuff

brisk rose Sep 22, 2024, 5:43 AM

#

stiff locust this joker should give +5 mult per unscored card and i'm using the same method a...

does it work if you don't hardcode the 5 and keep it as card.ability.extra?

#

keeping in mind to set that extra value in the definition

stiff locust Sep 22, 2024, 5:44 AM

#

brisk rose does it work if you don't hardcode the 5 and keep it as card.ability.extra?

where should that go

brisk rose Sep 22, 2024, 5:44 AM

#

the same way he has it

#

just looked at the code you copied

stiff locust Sep 22, 2024, 5:44 AM

#

okay

#

but if this works won't it give +5 mult if there's at least one unscored card instead

#

i guess i'll find out

stiff locust Sep 22, 2024, 5:45 AM

#

brisk rose does it work if you don't hardcode the 5 and keep it as card.ability.extra?

nope

brisk rose Sep 22, 2024, 5:45 AM

#

this looks important

#

did you add it too?

stiff locust Sep 22, 2024, 5:46 AM

#

i will try that

brisk rose Sep 22, 2024, 5:46 AM

#

Also sorry if I'm wasting your time, by coding at all you're well ahead of me at this

stiff locust Sep 22, 2024, 5:47 AM

#

nah it's cool

stiff locust Sep 22, 2024, 5:49 AM

#

brisk rose this looks important

it didn't work

brisk rose Sep 22, 2024, 5:50 AM

#

did you set the extra=5 in the joker definition?

stiff locust Sep 22, 2024, 5:50 AM

#

wait I think I know why it's not working

#

nevermind I don't know

brisk rose Sep 22, 2024, 5:51 AM

#

What I'd do is just copy the whole thing again completely verbatim, and change stuff while keeping it working

stiff locust Sep 22, 2024, 5:51 AM

#

yeah thats what im doing right now

stiff locust Sep 22, 2024, 6:01 AM

#

brisk rose What I'd do is just copy the whole thing again completely verbatim, and change ...

it

#

didn't

work

#

i copied everything except the function that calculates the evo condition

#

it does nothing

brisk rose Sep 22, 2024, 6:02 AM

#

seems like there's some problem with variables or something

#

like... he uses a variable that he set up himself somewhere else

stiff locust Sep 22, 2024, 6:03 AM

#

if that were the case it would tell me

#

the lua extension for vscode doesn't flag anything

#

gotta go check if the splash evo even works itself

brisk rose Sep 22, 2024, 6:04 AM

#

good idea. Most of the problems I've run into with DeFused were problems with the original jokers

stiff locust Sep 22, 2024, 6:05 AM

#

it

doesn't work

#

this
makes a lot of sense

brisk rose Sep 22, 2024, 6:05 AM

#

speaking of, still trying to figure out why Collectable Chaos Card isn't working

brisk rose Sep 22, 2024, 6:05 AM

#

stiff locust it doesn't work

oof, but also good news for your sanity, lol

stiff locust Sep 22, 2024, 6:05 AM

#

yeah lol

stiff locust Sep 22, 2024, 6:07 AM

#

brisk rose oof, but also good news for your sanity, lol

okay so

#

I broke splash.

#

like the vanilla joker

#

is not working

brisk rose Sep 22, 2024, 6:08 AM

#

lmfao, so there's something in your mod probably not letting any of the splash related stuff work

#

does SDM's splash evolution work without your mod loaded?

stiff locust Sep 22, 2024, 6:08 AM

#

i will check that

stiff locust Sep 22, 2024, 6:10 AM

#

brisk rose does SDM's splash evolution work without your mod loaded?

i can't get the evolution to check it

#

i don't have it discovered and i can't discover it because splash does not work

#

even without my mod loaded

#

splash is not working

brisk rose Sep 22, 2024, 6:10 AM

#

oh what

#

that... makes no sense

stiff locust Sep 22, 2024, 6:10 AM

#

exactly

#

i think it has to be the evolution

brisk rose Sep 22, 2024, 6:10 AM

#

well... does splash work without evo loaded?

stiff locust Sep 22, 2024, 6:11 AM

#

if it doesn't i'm gonna be

#

a little annoyed

#

slightly pissed

#

yknow just

#

a tiny bit

stiff locust Sep 22, 2024, 6:11 AM

#

brisk rose well... does splash work without evo loaded?

no

brisk rose Sep 22, 2024, 6:12 AM

#

so... another mod must be breaking it

stiff locust Sep 22, 2024, 6:12 AM

#

wahtwhat the fuck

#

no other mods do anything to splash

brisk rose Sep 22, 2024, 6:12 AM

#

unless it was broken in the newest update and no one noticed

#

lmfao

stiff locust Sep 22, 2024, 6:12 AM

#

i turned the speed to 4x and turned off fast forward and the issue is still there

#

guess it's time to figure out which mod broke splash

#

when i find the bastard that broke splash

edgy reef Sep 22, 2024, 6:13 AM

#

brisk rose so... another mod must be breaking it

That would imply either a mod screws with this line or a mod/SMODS broke find_joker

#

This is basically 100% of splash's logic

brisk rose Sep 22, 2024, 6:17 AM

#

stiff locust i don't have it discovered and i can't discover it because splash does not work

oh also this is why we need a discover all button

stiff locust Sep 22, 2024, 6:18 AM

#

i have

#

narrowed down the number of mods it can be

#

to 8

brisk rose Sep 22, 2024, 6:43 AM

#

brisk rose speaking of, still trying to figure out why Collectable Chaos Card isn't working

can anyone help me with this?

#

I just realized that the "#" in front of the variable doesn't seem to be done anywhere else that I can see. Is it that simple?

loud citrus Sep 22, 2024, 6:45 AM

#

ahhh, i don't know why it's not working, i feel silly, could i get some help?

brisk rose Sep 22, 2024, 6:48 AM

#

brisk rose I just realized that the "#" in front of the variable doesn't seem to be done an...

nvm, if I remove it it just says it's a table and it can't do math with it

#

should have expectd something like that

nocturne garnet Sep 22, 2024, 7:33 AM

#

brisk rose I just realized that the "#" in front of the variable doesn't seem to be done an...

#chaos is the number of things inside of the table chaos

brisk rose Sep 22, 2024, 8:10 AM

#

nocturne garnet #chaos is the number of things inside of the table chaos

yeah, figured it must be something like that

wintry solar Sep 22, 2024, 8:24 AM

#

stiff locust this joker should give +5 mult per unscored card and i'm using the same method a...

I imagine the key for the mult return is probably wrong though I don’t remember what it should be off the top of my head, you also have two different key value pairs for mult when you should only have one

#

Does it do anything right now?

lament flame Sep 22, 2024, 8:25 AM

#

do i need the "mod" configs if its not scaling?

#

like if i want flat chips nothing else would it be like

config = {chips = 300},

stiff locust Sep 22, 2024, 8:28 AM

#

wintry solar Does it do anything right now?

no

wintry solar Sep 22, 2024, 8:31 AM

#

stiff locust no

Have you tried throwing some debug messages around your function to check where it’s getting to?

stiff locust Sep 22, 2024, 9:49 AM

#

wintry solar Does it do anything right now?

right now my bigger concern is that splash, the vanilla joker is not working with a certain mod

#

and that is fucking up sdm0's evolved splash
and thus also fucking up my fusion since they are very similar

brisk rose Sep 22, 2024, 9:49 AM

#

did you figure out what mod it was?

stiff locust Sep 22, 2024, 9:50 AM

#

almost

#

i have it down to 8

#

i have it down to four

#

ceres, nopeus, SDM_0's stuff and more joker packs

#

it's ceres or more joker packs

#

it's ceres

loud citrus Sep 22, 2024, 9:53 AM

#

loud citrus ahhh, i don't know why it's not working, i feel silly, could i get some help?

i fixed it, made a rookie mistake
now a new problem, how do i get the messages to both show and with delay between each other

stiff locust Sep 22, 2024, 9:54 AM

#

yeah 100% ceres is causing it

#

now that i've gotten to the bottom of that

#

i will test my joker again with ceres disabled

#

you know what I think I figured out why my joker isn't working

#

it doesn't apply the splash effect

#

yep that was the issue

#

if splash is in play, my joker works properly

#

now how do I add the splash effect to my joker

brisk rose Sep 22, 2024, 10:09 AM

#

well it seems to be basically a single line of code from what was said before

brisk rose Sep 22, 2024, 10:09 AM

#

edgy reef That would imply either a mod screws with this line or a mod/SMODS broke `find_j...

this

stiff locust Sep 22, 2024, 10:12 AM

#

okay

stiff locust Sep 22, 2024, 10:16 AM

#

edgy reef That would imply either a mod screws with this line or a mod/SMODS broke `find_j...

it says scoring_hand is an undefined global

#

(i am putting splash effect on my joker)

brisk rose Sep 22, 2024, 10:17 AM

#

again, you're using outside libraries, so that sort of IDE warning is irrelevent

wintry solar Sep 22, 2024, 10:17 AM

#

You can probably just check the size of G.play and compare to scoring hand if you don’t need to actually score the other cards

brisk rose Sep 22, 2024, 10:19 AM

#

brisk rose again, you're using outside libraries, so that sort of IDE warning is irrelevent

Maybe somebody should make a steamodded VSCode plugin, lol

wintry solar Sep 22, 2024, 10:19 AM

#

You just need to open the folder where you pull the files out of the game into your project

#

Or open your entire mods folder and the lovely dumps will probably have most of it

brisk rose Sep 22, 2024, 10:20 AM

#

wintry solar You just need to open the folder where you pull the files out of the game into y...

ah fair

wintry solar Sep 22, 2024, 10:20 AM

#

stiff locust it says scoring_hand is an undefined global

However for this, it should be context.scoring_hand

brisk rose Sep 22, 2024, 10:21 AM

#

My coding experience is one quarter each of beginner Python and c++ at a community college 5 years ago that I haven't used since... and it shows

stiff locust Sep 22, 2024, 10:23 AM

#

wintry solar However for this, it should be `context.scoring_hand`

so this before the other parts of the joker ability?

stiff locust Sep 22, 2024, 10:23 AM

#

brisk rose again, you're using outside libraries, so that sort of IDE warning is irrelevent

okay but when i booted up balatro it told me scoring_hand was undefined

#

soooo

brisk rose Sep 22, 2024, 10:24 AM

#

Yeah, in this case it was. As Eremel said, if you have your whole mods folder in your project those warnings will be more consistently relevent

stiff locust Sep 22, 2024, 10:25 AM

#

still says this

wintry solar Sep 22, 2024, 10:26 AM

#

Does the joker need to score the extra cards that aren’t in the hand?

stiff locust Sep 22, 2024, 10:29 AM

#

wintry solar Does the joker need to score the extra cards that aren’t in the hand?

i think it's too weak if i don't add that

#

in future i will need to know how to do this though

wintry solar Sep 22, 2024, 10:31 AM

#

You’ll probably need to patch the part that checks you have splash then

stiff locust Sep 22, 2024, 10:36 AM

#

wintry solar You’ll probably need to patch the part that checks you have splash then

what does that mean

#

like replace the code?

nocturne garnet Sep 22, 2024, 11:07 AM

#

stiff locust so this before the other parts of the joker ability?

i believe it should be context.scoring_hand and not just scoring_hand?

#

not sure tho

nimble sequoia Sep 22, 2024, 1:11 PM

#

ye, it's context.scoring_hand

wintry solar Sep 22, 2024, 1:38 PM

#

progress!

opal spade Sep 22, 2024, 1:49 PM

#

wait

#

are the texture packs going to be represente by cards???

#

:0

wintry solar Sep 22, 2024, 1:50 PM

#

that's the plan

languid mirage Sep 22, 2024, 2:09 PM

#

would there be a simpler menu option? this seems rather overwhelming
I think most people would just want to have a texture pack management like in minecraft, with priorities per pack

individual cards might be good for edge cases tho

#

unless I am misunderstanding how this would work

wintry solar Sep 22, 2024, 2:18 PM

#

Select the object type from the left, the texture displays zone will display all the textures you have installed and then you can reorder the oens you want to use at the top respecting priority

nocturne garnet Sep 22, 2024, 3:05 PM

#

is this awesome

nocturne garnet Sep 22, 2024, 3:18 PM

#

nocturne garnet is this awesome

#

i completely forgot to make it give Xmult 💀

#

also cost is weird

#

nvm fixed it lmfao

#

regal wolf Sep 22, 2024, 5:41 PM

#

languid mirage would there be a simpler menu option? this seems rather overwhelming I think mos...

I agree, this seems drastically overcomplicated / overwhelming. It should be a simple button press / action to start using a new pack imo. If people want to have custom textures on specific cards they can just add a texture pack with only a specific texture

wintry solar Sep 22, 2024, 6:28 PM

#

eh, I can work on simplifying it down, the issues arise when you want to combine texture packs, and having a blanket apply button wouldn't work nicely with that

zealous glen Sep 22, 2024, 6:52 PM

#

wintry solar Select the object type from the left, the texture displays zone will display all...

Does selecting the object type just change the example display or do you set textures per object?

wintry solar Sep 22, 2024, 6:53 PM

#

set the textures per object

zealous glen Sep 22, 2024, 6:53 PM

#

nocturne garnet nvm fixed it lmfao

Another Ouroboros :0

zealous glen Sep 22, 2024, 6:54 PM

#

wintry solar set the textures per object

I agree that sounds too granular for the average use case

#

I expect most texture packs to either change everything or one specific set, so the only conflict is when two different texture packs change everything.

#

Otherwise, you could beg the question of more granularity: why not set texture packs by suit, like the Friends of Jimbo?

#

I think a global object setting is simpler to use and sufficient for 99% of use cases

loud citrus Sep 22, 2024, 7:30 PM

#

when using take_ownership, how do i completely overwrite a joker?

rough furnace Sep 22, 2024, 7:32 PM

#

I think you just redefine every thing about it

loud citrus Sep 22, 2024, 7:35 PM

#

like the slug?

#

and name?

rough furnace Sep 22, 2024, 7:36 PM

#

what are you trying to do?

loud citrus Sep 22, 2024, 7:46 PM

#

make it so 8 ball gives the last used tarot instead of a random one

#

i'm guessing that will need a rewrite of the card

rough furnace Sep 22, 2024, 7:47 PM

#

you should be able to take ownership and just replace it's calculate function

loud citrus Sep 22, 2024, 7:48 PM

#

what would that look like? if you don't mind me asking

rough furnace Sep 22, 2024, 7:49 PM

#

imma be honest I've never used take_ownership

loud citrus Sep 22, 2024, 7:49 PM

#

lol, that's fine

rough furnace Sep 22, 2024, 7:50 PM

#

yeah probably something like that

#

I can pull up the 8ball code

loud citrus Sep 22, 2024, 7:50 PM

#

for this i never touched the hand context so i'm asuming when i do that i'll replace it?

#

working with this game spaghetti before won't it just try and do both?

agile rain Sep 22, 2024, 7:51 PM

#

for some reason my planet cards are not localizing anymore, but tarots and some spectrals are. Both Tarots.png files in assets have the correct sprites so I'm clueless what's going wrong.

SMODS.Atlas { key = "Booster", path = { ['it'] = 'boosters.png', }, px = 71, py = 95, prefix_config = { key = false } }
        SMODS.Atlas { key = "Tarot", path = { ['it'] = 'Tarots.png', }, px = 71, py = 95, prefix_config = { key = false } }
        SMODS.Atlas { key = "Voucher", path = { ['it'] = 'Vouchers.png', }, px = 71, py = 95, prefix_config = { key = false } }
        SMODS.Atlas { key = "icons", path = { ['it'] = 'icons.png', }, px = 66, py = 66, prefix_config = { key = false } }
        SMODS.Atlas { key = "Joker", path = { ['it'] = 'Jokers.png', }, px = 71, py = 95, prefix_config = { key = false } }
        SMODS.Atlas { key = "blind_chips", path = { ['it'] = "BlindChips.png", }, px = 34, py = 34, prefix_config = { key = false }, atlas_table = 'ANIMATION_ATLAS', frames = 21 }
        SMODS.Atlas { key = "shop_sign", path = { ['it'] = "ShopSignAnimation.png", }, px = 113, py = 57, prefix_config = { key = false }, atlas_table = 'ANIMATION_ATLAS', frames = 4 }```

rough furnace Sep 22, 2024, 7:52 PM

#

loud citrus working with this game spaghetti before won't it just try and do both?

I belive smods will just call it's calculate instead of the games built in one

loud citrus Sep 22, 2024, 7:53 PM

#

okay ill try it out

wintry solar Sep 22, 2024, 7:57 PM

#

agile rain for some reason my planet cards are not localizing anymore, but tarots and *some...

I think that smods still separates planets and spectral out into their own sheets, so using the key Planet would work maybe?

zealous glen Sep 22, 2024, 7:57 PM

#

loud citrus for this i never touched the hand context so i'm asuming when i do that i'll rep...

As we talked earlier just defining a calculate function with a return will override the native one

loud citrus Sep 22, 2024, 7:58 PM

#

zealous glen As we talked earlier just defining a `calculate` function with a `return` will o...

OH RIGHT

#

☝️ this person (me)
goldfish memory

agile rain Sep 22, 2024, 8:02 PM

#

wintry solar I *think* that smods still separates planets and spectral out into their own she...

Oh yeah this worked for now. Pretty odd tho to happen so suddenly with no updates since it used to work having only tarot key

frosty dock Sep 22, 2024, 8:16 PM

#

wintry solar I *think* that smods still separates planets and spectral out into their own she...

nope that was removed when i cut palettes

#

i do recall seeing something about localized atlases being jank though

loud citrus Sep 23, 2024, 12:29 AM

#

i don't understand what it's asking of me

#

everything should close right

tepid crow Sep 23, 2024, 12:33 AM

#

so apparently thunk never actually uses set_deck_usage meaning every deck's count is just 1 lmao

loud citrus Sep 23, 2024, 12:33 AM

#

lol

tepid crow Sep 23, 2024, 12:34 AM

#

loud citrus i don't understand what it's asking of me

what is line 104 even for Rose?

#

that looks like it came from an event, but I don't see one

loud citrus Sep 23, 2024, 12:35 AM

#

i'm mashing 8 ball code with the fool

tepid crow Sep 23, 2024, 12:37 AM

#

oh oops there actually is an event I'm blind

loud citrus Sep 23, 2024, 12:37 AM

#

lol thats fine

tepid crow Sep 23, 2024, 12:37 AM

#

you really need to fix that indentation though

#

actually, fixing the indentation will probably even show you what the issue is

#

do you know what I mean when I say "fix the indentation"?

loud citrus Sep 23, 2024, 12:39 AM

#

no

#

if it's not to much for you, could you do a small expiation?

tepid crow Sep 23, 2024, 12:40 AM

#

sure

#

do you know what indentation is?

loud citrus Sep 23, 2024, 12:41 AM

#

nope

#

i may have a rough idea but i don't know the terms

tepid crow Sep 23, 2024, 12:41 AM

#

indentation in coding usually is however many spaces (or tabs) you have before a line of code

#

so this code is not indented at all:

local x = 1

and this code has a lot of indentation:

                            local y = "hi"

loud citrus Sep 23, 2024, 12:43 AM

#

so this is used to space stuff out like my code here?

tepid crow Sep 23, 2024, 12:43 AM

#

yeah!

#

its used for visual grouping and organization

#

compare no indentation (or imagine nonsense indentation)

if (self.methods.init) then
if (tostring(arg[1]) ~= "___CREATE_ONLY___") then
obj.init = self.methods.init
if obj.init then
obj:init(unpack(arg))
end
end
end

versus "proper" indentation

if (self.methods.init) then
    if (tostring(arg[1]) ~= "___CREATE_ONLY___") then
        obj.init = self.methods.init
        if obj.init then
            obj:init(unpack(arg))
        end
    end
end

loud citrus Sep 23, 2024, 12:46 AM

#

this is better

tepid crow Sep 23, 2024, 12:46 AM

#

Yeah 🥳

loud citrus Sep 23, 2024, 12:46 AM

#

tepid crow compare no indentation (or imagine nonsense indentation) ```lua if (self.methods...

it's like an aspect of grammar in coding

tepid crow Sep 23, 2024, 12:47 AM

#

funny you chose the word "grammar" haha

#

most languages don't force you to indent, and you can do whatever you want

#

but there are languages that use indentation as actual program control flow

#

so indenting less/more means it does/doesn't get executed

loud citrus Sep 23, 2024, 12:48 AM

#

that is cool! fool

tepid crow Sep 23, 2024, 12:49 AM

#

loud citrus this is better

anyway, do you spot the issue with your code now?

loud citrus Sep 23, 2024, 12:49 AM

#

not yet, but it might been seen in time :)

tepid crow Sep 23, 2024, 12:50 AM

#

try matching the "beginning statements" (such as if ... then, function ...() or for ... do) with their end

loud citrus Sep 23, 2024, 12:53 AM

#

this seems right so far, good thing it can show me the starts and ends :)

tepid crow Sep 23, 2024, 12:53 AM

#

ooh, be careful with that

#

notepad++ makes some small assumptions about beginning and ends

#

in this case, something went wrong, but notepad++ just ignores it

loud citrus Sep 23, 2024, 12:55 AM

#

oh i see, probably has to do with , then

tepid crow Sep 23, 2024, 12:55 AM

#

could you quickly paste your code here?

loud citrus Sep 23, 2024, 12:56 AM

#

    calculate = function(self, card, context)
        if context.individual then
            if #G.consumeables.cards + G.GAME.consumeable_buffer < G.consumeables.config.card_limit then
                if (context.other_card:get_id() == 8) and (pseudorandom('8ball') < G.GAME.probabilities.normal/self.ability.extra) then
                    G.GAME.consumeable_buffer = G.GAME.consumeable_buffer + 1
                    G.E_MANAGER:add_event(Event({trigger = 'after', delay = 0.4, func = function()
                        if G.consumeables.config.card_limit > #G.consumeables.cards then
                            play_sound('timpani')
                            local self = create_card('Tarot_Planet', G.consumeables, nil, nil, nil, nil, G.GAME.last_tarot_planet, 'fool')
                            self:add_to_deck()
                            G.consumeables:emplace(self)
                            used_tarot:juice_up(0.3, 0.5)
                        end
                    end
                return true end }))
            delay(0.6)
            colour = G.C.SECONDARY_SET.Tarot,
            card = self
            end
        end
    end
    })```

#

uhhh

tepid crow Sep 23, 2024, 12:56 AM

#

use ``` for multiline blocks haha

loud citrus Sep 23, 2024, 12:57 AM

#

📎 Re-Baloed.lua

#

that's better

#

i have a hand full of jokers in the works so the one you're looking for is 8 ball

tepid crow Sep 23, 2024, 12:58 AM

#

I'm gonna turn your code into a very abstract tree of ifs and (){}s, one sec

loud citrus Sep 23, 2024, 1:00 AM

#

yeah, spaghetti code

tepid crow Sep 23, 2024, 1:00 AM

#

calculate = function(self, card, context)
    if then
        if then
            if then
                (({function()
                    if then
                    end
                end
            return true end }))
        end
    end
end

alright I think this is only the ifs and brackets

loud citrus Sep 23, 2024, 1:00 AM

#

that's a good visual

tepid crow Sep 23, 2024, 1:00 AM

#

what you see there makes sense?

#

as in how its just your code without any actual variables?

loud citrus Sep 23, 2024, 1:02 AM

#

this is what i'm thinking

tepid crow Sep 23, 2024, 1:02 AM

#

yeah, exactly

#

but there is an issue with the code

#

because not only the ifs and ends have to match up, the ()s and {}s also need to match up

#

and they really can't cross lines

#

if then
    (
end
)

can't really do this, right?

loud citrus Sep 23, 2024, 1:04 AM

#

is this what's happening?

#

the ends included are messing this up, so i need to restructure

tepid crow Sep 23, 2024, 1:06 AM

#

this end is messing up yeah

wintry solar Sep 23, 2024, 1:07 AM

#

loud citrus this is better

I think line 103 isn't needed

tepid crow Sep 23, 2024, 1:08 AM

#

wintry solar I think line 103 isn't needed

almost :)

wintry solar Sep 23, 2024, 1:08 AM

#

no, the return true needs to be inside the event function

tepid crow Sep 23, 2024, 1:08 AM

#

there it is

wintry solar Sep 23, 2024, 1:08 AM

#

103 is ending it early

tepid crow Sep 23, 2024, 1:08 AM

#

does Eremel's comment make sense with the explanation I just gave Rose?

loud citrus Sep 23, 2024, 1:11 AM

#

here's there working code! i fixed a few other things by the game telling me and now i can counite troubleshooting the rest of the code :)

#

thanks for explanation how the ends were interacting with the code

tepid crow Sep 23, 2024, 1:12 AM

#

would it be possible to see the full code just to double check?

loud citrus Sep 23, 2024, 1:12 AM

#

yeah

#

tepid crow Sep 23, 2024, 1:14 AM

#

perfect, code looks good

#

might wanna indent this part though

#

since its still within the if

loud citrus Sep 23, 2024, 1:16 AM

#

👍

#

i'll make sure you get credit in my mod for teaching me about this :)

tepid crow Sep 23, 2024, 1:19 AM

#

haha you don't have to, I don't mind 🙃

tepid sky Sep 23, 2024, 5:40 AM

#

loud citrus ``` SMODS.Joker:take_ownership('8_ball', { calculate = function(self, car...

did you change a base game joker? nice!

loud citrus Sep 23, 2024, 8:27 AM

#

tepid sky did you change a base game joker? nice!

it's using an existing function by the mod tool

stiff locust Sep 23, 2024, 8:52 AM

#

last time i was around i dont remember if i got an answer

#

how do I add splash's effect to a custom joker

maiden phoenix Sep 23, 2024, 9:05 AM

#

Its just a joker check in G.FUNCS.evaluate_play

stiff locust Sep 23, 2024, 9:50 AM

#

maiden phoenix Its just a joker check in `G.FUNCS.evaluate_play`

reminder that i am stupid
what does this mean

maiden phoenix Sep 23, 2024, 9:51 AM

#

Look for the function G.FUNCS.evaluate_play (using ctrl+shift+f) and you'll see it calls next(find_joker("Splash"))

stiff locust Sep 23, 2024, 9:51 AM

#

in which lua

maiden phoenix Sep 23, 2024, 9:51 AM

#

ctrl+shift+f lets you find it in every file it exists

stiff locust Sep 23, 2024, 9:52 AM

#

what

maiden phoenix Sep 23, 2024, 9:52 AM

#

You use VSCode no?

stiff locust Sep 23, 2024, 9:52 AM

#

yeah

maiden phoenix Sep 23, 2024, 9:52 AM

#

Well you can use this nifty shortcut

stiff locust Sep 23, 2024, 9:52 AM

#

it searches every file that exists??

#

(on my computer)

maiden phoenix Sep 23, 2024, 9:52 AM

#

It search every occurence of the word in every file that's in your VSCode workspace

#

it's like ctrl+f but better

stiff locust Sep 23, 2024, 9:53 AM

#

ahhh

#

okay this makes sense

stiff locust Sep 23, 2024, 9:55 AM

#

maiden phoenix It search every occurence of the word in every file that's in your VSCode worksp...

i can't find the thing

#

oh wait

#

i found it

maiden phoenix Sep 23, 2024, 9:55 AM

#

Did you drop your unzipped balatro folder inside VSCode?

stiff locust Sep 23, 2024, 9:55 AM

#

okay

maiden phoenix Sep 23, 2024, 9:55 AM

#

Ok nvm

stiff locust Sep 23, 2024, 9:55 AM

#

so how do I add a custom joker to that

maiden phoenix Sep 23, 2024, 9:55 AM

#

Either hook or lovely inject the joker you wanna check in

stiff locust Sep 23, 2024, 9:56 AM

#

which one of those is easier

#

actually i should do the first one

#

because your evolution might have a lovely patch collision with my fusions

#

am i understanding this right

maiden phoenix Sep 23, 2024, 9:56 AM

#

Lemme check cuz I'm not sure

stiff locust Sep 23, 2024, 9:56 AM

#

okay

maiden phoenix Sep 23, 2024, 9:57 AM

#

Nah I don't override it, I write after it

stiff locust Sep 23, 2024, 9:57 AM

#

ahh okay

#

so that'd be the best way to avoid a collision?

maiden phoenix Sep 23, 2024, 9:57 AM

#

# "Ripple" joker scoring

[[patches]]
[patches.pattern]
target = "functions/state_events.lua"
pattern = "scoring_hand[i] = G.play.cards[i]"
position = "after"
payload = """
        elseif next(find_joker('Ripple')) then
            scoring_hand[i] = G.play.cards[i]
"""
match_indent = false

stiff locust Sep 23, 2024, 9:57 AM

#

oh that's really easy actually

#

how would I add multiple jokers to the list

#

patching again for every joker seems inefficient

maiden phoenix Sep 23, 2024, 9:58 AM

#

elseif next(find_joker('x')) or next(find_joker('y'))...

#

How many jokers there is?

stiff locust Sep 23, 2024, 9:59 AM

#

almost all of my fusions will require this

maiden phoenix Sep 23, 2024, 9:59 AM

#

Maybe make a global table with all your fusions and add a check in the lovely inject see if it exists

stiff locust Sep 23, 2024, 9:59 AM

#

a table is {} right

maiden phoenix Sep 23, 2024, 10:00 AM

#

Yea, to make it global you just don't write local behind the table variable

stiff locust Sep 23, 2024, 10:01 AM

#

would I have to do something like

for x in splashtable
if next(find_joker(x)) then
scoring_hand[i] = G.play.cards[i]

or does it just work if i do elseif next(find_joker(splashtable)) then on that line

maiden phoenix Sep 23, 2024, 10:09 AM

#

I think theres an easier way, you could add a "is_splash: true" to your joker object's ability, then during the function you iterate over your jokers and check if any jokers you got has the attribute (and isnt debuffed)

stiff locust Sep 23, 2024, 10:10 AM

#

and how would I check that value

stiff locust Sep 23, 2024, 10:12 AM

#

maiden phoenix I think theres an easier way, you could add a "is_splash: true" to your joker ob...

actually that sounds like similar if not more complexity than doing the for loop

#

if i'm gonna iterate over every joker anyway then what difference does it make

maiden phoenix Sep 23, 2024, 10:20 AM

#

Whatever suits you

hardy viper Sep 23, 2024, 10:21 AM

#

wintry solar I think rarity api was merged yesterday

i tried out this rarity api you mentioned btw and its like not functional gladeline that is not getting merged anytime soon

stiff locust Sep 23, 2024, 10:27 AM

#

maiden phoenix ``` # "Ripple" joker scoring [[patches]] [patches.pattern] target = "functions/...

it says unexpected symbol near [[patches]]

#

when i try to do this

maiden phoenix Sep 23, 2024, 10:29 AM

#

stiff locust it says unexpected symbol near [[patches]]

Did you do it in a lua file?

stiff locust Sep 23, 2024, 10:30 AM

#

oh does it have to be in its own file

maiden phoenix Sep 23, 2024, 10:30 AM

#

Also I found a better way to do your splash check

#

Yea inside lovely.toml

stiff locust Sep 23, 2024, 10:30 AM

#

ahhhhh

maiden phoenix Sep 23, 2024, 10:30 AM

#

or lovely/your_file.toml

#

It requires an header too

stiff locust Sep 23, 2024, 10:30 AM

#

okay

maiden phoenix Sep 23, 2024, 10:30 AM

#

[manifest]
version = "1.0.0"
dump_lua = true
priority = 0

stiff locust Sep 23, 2024, 10:31 AM

#

should i change the priority

maiden phoenix Sep 23, 2024, 10:31 AM

#

Idk if it matters really

stiff locust Sep 23, 2024, 10:31 AM

#

okay

maiden phoenix Sep 23, 2024, 10:31 AM

#

^This one is from JokerEvo so

stiff locust Sep 23, 2024, 10:31 AM

#

well i'd want it to happen after my mod loads right

maiden phoenix Sep 23, 2024, 10:31 AM

#

Doesn't really matter

stiff locust Sep 23, 2024, 10:31 AM

#

okay

maiden phoenix Sep 23, 2024, 10:32 AM

#

maiden phoenix Also I found a better way to do your splash check

About this, what if, when your joker is added/removed, you add a G.GAME variable for example G.GAME.has_splash = true

#

And when it's removed you set it to false

#

Actually it might cause issue if one joker gets debuffed and you got another splash so nvm

stiff locust Sep 23, 2024, 10:33 AM

#

yeah

#

Oops! The game crashed:
Syntax error: functions/state_events.lua:804: 'then' expected near ')'

maiden phoenix Sep 23, 2024, 10:34 AM

#

?

stiff locust Sep 23, 2024, 10:35 AM

#

¯_(ツ)_/¯

maiden phoenix Sep 23, 2024, 10:35 AM

#

Show the content of your toml file

stiff locust Sep 23, 2024, 10:35 AM

#

[manifest]
version = "1.0.0"
dump_lua = true
priority = 0

[[patches]]
[patches.pattern]
target = "functions/state_events.lua"
pattern = "scoring_hand[i] = G.play.cards[i]"
position = "after"
payload = """
        elseif next(find_joker(Splashtable))) then
            scoring_hand[i] = G.play.cards[i]
"""
match_indent = false

trying it with just putting the name of the table in and if that doesn't work i'll do the for loop

#

oh there's an extra bracket

#

oh i see

maiden phoenix Sep 23, 2024, 10:36 AM

#

Wait are you sending the whole table to find_joker?

stiff locust Sep 23, 2024, 10:36 AM

#

well i'm gonna see if that works yeah

maiden phoenix Sep 23, 2024, 10:36 AM

#

I don't think it will

stiff locust Sep 23, 2024, 10:36 AM

#

we will see

#

i forgot to remove it from my regular lua file

#

lol

stiff locust Sep 23, 2024, 10:38 AM

#

maiden phoenix I don't think it will

yeah it didn't work

stiff locust Sep 23, 2024, 10:47 AM

#

maiden phoenix Wait are you sending the whole table to find_joker?

when i used the for loop method it crashed trying to call the table

#

i did put the table at the top of my lua file

do i need to put it elsewhere for the game to recognise it

maiden phoenix Sep 23, 2024, 10:47 AM

#

Check if the table exists before looping over it

stiff locust Sep 23, 2024, 10:48 AM

#

but then it'll just return false and move on won't it

maiden phoenix Sep 23, 2024, 10:49 AM

#

Was the crash "table is nil"?

stiff locust Sep 23, 2024, 10:50 AM

#

the crash was "attempt to call a table value"

maiden phoenix Sep 23, 2024, 10:50 AM

#

Show what your table looks like

stiff locust Sep 23, 2024, 10:50 AM

#

Splashtable = {
    "Soaked Joker",
    "Splish Splash",
}

splish splash isn't supposed to be here, but I wanted to add it to the list just to make sure it works with multiple entries

maiden phoenix Sep 23, 2024, 10:51 AM

#

And whats your loop iteration like?

stiff locust Sep 23, 2024, 10:51 AM

#

payload = """
        for x in Splashtable do
            if next(find_joker(x)) then
                scoring_hand[i] = G.play.cards[i]
                break
            end
        end
"""

#

oh i

#

left another extra bracket

#

but that was not the issue

maiden phoenix Sep 23, 2024, 10:52 AM

#

Not only that, but you need to specify pairs or ipairs for the table

stiff locust Sep 23, 2024, 10:52 AM

#

huh

maiden phoenix Sep 23, 2024, 10:52 AM

#

Check the vanilla code there's plenty of example

stiff locust Sep 23, 2024, 10:54 AM

#

i think i get it

#

well it didn't crash this time

#

but the splash effect is also not triggering

#

which makes me think something is up with the table entries

#

do i need to put the joker key in there

stiff locust Sep 23, 2024, 10:56 AM

#

stiff locust do i need to put the joker key in there

that didn't change it not working

maiden phoenix Sep 23, 2024, 10:57 AM

#

Show your changed loop

stiff locust Sep 23, 2024, 10:57 AM

#

i think i know why it's not working

#

actually no i don't

#

but i did move the pattern up by one line because I couldn't figure out how to write elseif for x in... in a way that made the code actually function on that line (it was just being skipped most of the time)
~~but i think i moved it to the wrong place and I should actually put it lower inside the else part below~~
this was wrong

maiden phoenix Sep 23, 2024, 11:01 AM

#

If you want to iterate over a keyless table you do for k, v in ipairs(table)

stiff locust Sep 23, 2024, 11:01 AM

#

i suspect that's what it is? but the code is still clearly being run because of the call table crash