I am not experienced enough with shader dev to say what the exact issue is, but it seems to occur only in the HLSLPROGRAM shaders, while the CGPROGRAM shaders are fine. There are no errors or warnings in the console about these shaders, so I don't think they are failing to compile or anything. Video is of Scanlines, but it's identical on Mirror, and the flickering seems to be due to the Unity Editor, it doesn't happen in a build (in a build it's just black).
#Scanlines and Mirror shaders are broken on MacOS/Metal
wheat badger
balmy skiff
Hm, thanks for testing. I would not have expected those to be the ones that are messed up lol
acoustic flint
I wonder if its always been like that then why noone complains, noone uses mac? o_O
balmy skiff
from the download stats, it's less than 4% of the user base IIRC
balmy skiff
just so I'm 100% clear on the issue, you were using an invisible bot there? it doesn't actually overwrite the highway if it is visible?
acoustic flint
how can you make invisible bot? even with 0 opacity on the highway the notes are still opaque, no?
wheat badger
just so I'm 100% clear on the issue, you were using an invisible bot there? it d...
yeah, invisible bot, highway shows up fine
balmy skiff
@wheat badger Can you, or one of you other Mac-havers replace the existing shaders with these and see if it helps? (I have zero confidence of anything but it still working on DX11, but apparently there are some differences that using Unity macros might smooth over)
(they go in Assets/Resources/VenueShaders)
acoustic flint
I'll look into those, I've installed unity no my work macbook
gwiw you have to use unity's macroses and functions as few things are different between rendering APIs and they abstract it away (like is uv flipped, range of depth values, etc ,etc)
wheat badger
<@322420951125852163> Can you, or one of you other Mac-havers replace the existi...
Same issue sadly
balmy skiff
Thanks for testing. Might take another shot in the dark a bit later (making them use the old style cgprogram format since that seems to work for some other shaders)
wheat badger
Not sure if this is helpful for anyone taking a look at this bug, but here's some output I got from XCode when running (filtered for the word shader)
ERROR: Shader Hidden/Universal Render Pipeline/DBufferClear shader is not supported on this GPU (none of subshaders/fallbacks are suitable)
Desired shader compiler platform 14 is not available in shader blob
ERROR: Shader Unlit/MenuBackgroundVenue shader is not supported on this GPU (none of subshaders/fallbacks are suitable)
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
Desired shader compiler platform 14 is not available in shader blob
ERROR: Shader Kali/TechnoCore shader is not supported on this GPU (none of subshaders/fallbacks are suitable)
ERROR: Shader YARGVid shader is not supported on this GPU (none of subshaders/fallbacks are suitable)
its not shaders
https://github.com/YARC-Official/YARG/pull/1366
Though I vaguely remember @sturdy flare had some prior issues with osx venue rendering so I'd like to ask him to test this
I guess it would be nice if @wheat badger could test this too
wheat badger
I guess it would be nice if <@322420951125852163> could test this too
Tested it, and from what I can tell, Scanlines does work now, but Mirror doesn't. It doesn't cause a black screen anymore, but it just doesn't do anything at all
balmy skiff
I assume you mean the shader isn't doing anything..one hopes the color change is still happening
for reference, it should look like this (the kind of wipe varies, could also be left to right or clockwise/counterclockwise)
wheat badger
It's possible I don't know what mirror does lol, I was thinking of the one that mirrors in the middle of the screen
balmy skiff
sometimes it does that, but not always
actually, it probably should do that for both horizontal wipes
as it is now I guess you only get the mid-screen split 1/4 of the time
wheat badger
Okay, scratch what I said earlier, it's still the same black screen in an actual build
acoustic flint
I really should be doing something I actually getting paid for right now. I'll double check later tonight, in like 5 hours
I do have unit in Mac though. I'll test the actual build
acoustic flint
Alright, this should fix it all https://github.com/YARC-Official/YARG/pull/1370
