The number only populates once you actually scan; should it be there to begin with?
#Nitpick: Song scanning menu says "ERRORS FOUND" with no number before it when you open the menu
merry wadi
simple tulip
i dont have any errors when i launch or after i scan
simple tulip
here ill force an error in one of my songs and then check again
simple tulip
okay its here now
so it only shows that if there is an error
but wont show a number until after you scan?
hmmm
so if you scan with an error and the quit out
it wont show the number when you relaunch until after you scan
the error message also wont go away until you rescan if you fix the error
lost orbit
Realistically the errors that get found should only show after the scan and only then
Or after a scan rather
As things may change filesystem-wise or game-wise and it'd still be checking for th badsongs.txt regardless
So the info may be incorrect
simple tulip
yep
i scanned with an error
then fixed the error and restarted without scanning
the badsongs.txt still registers the error that isnt there until i rescan
errors go away after a scan tho
hollow gorge
so the badsongs.txt file exists if errors have been found, and doesn't exist if there are no errors. YARG checks for that file's existence in order to show the ERRORS FOUND button or not. but it can't tell how many errors there are at that time, that information is only learned during an actual scan.
so if you open the settings and there were errors found previously, it will just say ERRORS FOUND. but if you do a scan, it will tell you the numbers.
if its too jarring/inconsistent to have it, my only solution is to remove the number after the scan, so you just see ERRORS FOUND or not, and you can click on it to see the list.
simple tulip
Yeah but the issue is when you fix the errors it still shows errors found until you rescan
normal kestrel
cause the game only knows its fixed when it rescan
theres no way the game will know something is fixed without scanning
simple tulip
Well i understand that
But i feel like the error message should go away if you relaunch the game
normal kestrel
I disagree with that
simple tulip
Just so its not giving incorrect badsongs.txt until you scan
normal kestrel
message for it can be changed to something like "scan your library to check" or whatever, interface is being changed so I can make something more friendly anyway
simple tulip
hollow gorge
if you click on the button it will still show your bad file. the game has no idea you fixed your song until you rescan.
sturdy adder
But i feel like the error message should go away if you relaunch the game
But if you're relaunch the game without scanning then the game has no way of knowing if the error was fixed so it makes sense for it to assume it hasn't.
Unless you want it to rescan every time it starts or if it finds a badsongs file on startup.
lost orbit
I think best case scenario would be to create a whole interface that displays all of the bad songs, and we remove the badsongs.txt and replace it with something parseable like a json file that contains the information
lost orbit
if its too jarring/inconsistent to have it, my only solution is to remove the nu...
So for this nitpick I think this is the quickest solution, but I think leaving it how it is now is fine
Not perfect, but it'll do