Some charts won't load into the game | YARG | Page 1

thick oyster Dec 3, 2023, 7:09 PM

#

This has been an issue I've been dealing with since day one. At least half the songs I have are simply not loaded into the game.
And they aren't read as "bad songs" either, it's as if the charts are ignored entirely. Looking into the files of the charts there seems to be absolutely nothing different from the ones that do work

shut dragon Dec 3, 2023, 7:12 PM

#

Can you preform a scan, close the game, then send the log file? Thanks

stark windBOT Dec 3, 2023, 7:12 PM

#

Your Player.log file may be found here:

Windows: C:\Users\<you>\AppData\LocalLow\YARC\YARG
Mac: ~/Library/Logs/YARC/YARG
Linux: ~/.config/unity3d/YARC/YARG

thick oyster Dec 3, 2023, 7:55 PM

#

📎 Player.log

stray tree Dec 3, 2023, 9:41 PM

#

thick oyster

not seeing anything wrong in the log there, can you post a screenshot of what's in your songs folder?

thick oyster Dec 3, 2023, 9:50 PM

#

Currently not at home. But the songs folder is just organized by playlist.
Best example I can give is that one of the things I have is the Rock Band version of Ziltoid, and despite every chart being grouped in the same folder, only about 3 of the songs work

stray tree Dec 3, 2023, 10:09 PM

#

i need to see what in specific is in the song folder, there might be something odd you missed

#

@wide ginkgo also would be good to have your input here

rustic talon Dec 4, 2023, 2:01 AM

#

Was reading through the help channels and just jumping in on this to say that the other day I had a similar issue that I talked with @stray tree about and it was caused by some rogue .txt files that ended up in the subfolders of my songs folder. Make sure to double check you don’t have any extra files in there that shouldn’t be there and then scan again.

thick oyster Dec 4, 2023, 3:39 AM

#

Nothing weird that I'm able to find

#

And I'm not even sure where I'd begin showing everything in the songs folder. I have thousands of charts in several subfolders that organize them by playlist

stray tree Dec 4, 2023, 3:46 AM

#

at most, i just need a screenshot of the top level of your songs folder, and a screenshot of what's in one or two songs

thick oyster Dec 4, 2023, 3:47 AM

#

Left is a song that works, right is one that doesn't

#

And this is top level

stray tree Dec 4, 2023, 3:54 AM

#

hm

stray tree Dec 4, 2023, 3:55 AM

#

thick oyster Left is a song that works, right is one that doesn't

what's in the second song of this pack?

thick oyster Dec 4, 2023, 3:55 AM

#

This one I assume? It's also one of the few that work

wide ginkgo Dec 4, 2023, 4:06 AM

#

Ah I see.

#

I knew we should've kept this as a full exception instead of a warning that doesn't show in logs

#

The issue is the path length

#

Windows has a max size for the length of the path string that can be used to access a file.

stray tree Dec 4, 2023, 4:08 AM

#

it should be showing in logs, hm

wide ginkgo Dec 4, 2023, 4:09 AM

#

It only logs it as a warning, not an error

stray tree Dec 4, 2023, 4:09 AM

#

which should still be showing

#

#

all 3 cases write to the log

wide ginkgo Dec 4, 2023, 4:10 AM

#

in any case, notice how the subfolder name for the one that works is shorter than the ones that don't

thick oyster Dec 4, 2023, 4:10 AM

#

Should I try changing folder names and see what happens?

stray tree Dec 4, 2023, 4:10 AM

#

you should probably move your entire songs folder to a higher point in the file system

wide ginkgo Dec 4, 2023, 4:11 AM

#

The complete path just ends up being too long for windows to handle in one go (without long_path support through an OS registry entry I believe anyways)

stray tree Dec 4, 2023, 4:12 AM

#

wide ginkgo I knew we should've kept this as a full exception instead of a warning that does...

it's also supposed to log these to bad songs

#

but that's supposedly not happening

wide ginkgo Dec 4, 2023, 4:13 AM

#

but the error in this situation happens in the directory's file name, not the chart's

#

In other words, it would be like if parent/folder was fine but parent/folder/notes.chart for BadSongs to be written to

thick oyster Dec 4, 2023, 4:14 AM

#

I moved the songs folder to the root of my game drive and that made no difference even after changing the path and doing several rescans

#

It's just D:\Songs now and, nothing

stray tree Dec 4, 2023, 4:18 AM

#

wide ginkgo but the error in this situation happens in the directory's file name, not the ch...

it handles PathTooLongException specially regardless

#

it should be showing up in the log

#

@thick oyster can you post your latest game log?

wide ginkgo Dec 4, 2023, 4:19 AM

#

just to be clear, this is the one I mean

thick oyster Dec 4, 2023, 4:19 AM

#

Player log, yeh?

stray tree Dec 4, 2023, 4:19 AM

#

yeah

thick oyster Dec 4, 2023, 4:19 AM

#

📎 Player.log

stray tree Dec 4, 2023, 4:20 AM

#

wide ginkgo just to be clear, this is the one I mean

yes, it'll still write to the log in that case

wide ginkgo Dec 4, 2023, 4:20 AM

#

wait no, that's one a slight edit. It originally is logwarning

stray tree Dec 4, 2023, 4:20 AM

#

DirectoryNotFoundException: Could not find a part of the path 'D:\CloneHero\Songs\Guitar Hero X-II\13 - Metallica Solo Medleys\3 - Master Of Puppets Solo Medley'.

#

okay that's from the music player, nvm

#

beacuse your cache became outdated

wide ginkgo Dec 4, 2023, 4:21 AM

#

oh

#

you know what

#

part of the trick of the scanning is that it will do a full scan if no songs are found

#

problem: the setlist songs will always be found KEKNitro

stray tree Dec 4, 2023, 4:22 AM

#

lol

wide ginkgo Dec 4, 2023, 4:25 AM

#

~~anyways, try again but manually pressing Refresh Songs~~ nvm you already did

#

Now granted, removing CloneHero as a subfolder only manages to remove 9 characters

#

actually hold on. That can't be it. tf

stray tree Dec 4, 2023, 4:29 AM

#

hold on, is the scanning even aware of the paths that are too long?

thick oyster Dec 4, 2023, 4:29 AM

#

I was gonna say, I have other songs that are in subfolders with WAY longer names and they work just fine

#

All these ones work

wide ginkgo Dec 4, 2023, 4:35 AM

#

thick oyster Left is a song that works, right is one that doesn't

just to check, does the second one work after the folder changes?

thick oyster Dec 4, 2023, 4:37 AM

#

Nope. Nothing's changed

wide ginkgo Dec 4, 2023, 4:46 AM

#

And if you make that the only folder scanned, I assume it still doesn't work?

thick oyster Dec 4, 2023, 5:11 AM

#

Yea I tried that as well

queen yew Dec 4, 2023, 5:19 AM

#

stray tree hold on, is the scanning even aware of the paths that are too long?

Yeah, every time I scan it throws up directory not found exceptions for the few folders that I have which are nested so far that it exceeds the limit

#

And those paths go over the limit

stray tree Dec 4, 2023, 5:21 AM

#

odd that it's not using PathTooLongException for that

wide ginkgo Dec 4, 2023, 5:21 AM

#

send the notes.mid if you could for testing purposes

#

Though I got an early shift tomorrow so I gotta sleep

queen yew Dec 4, 2023, 5:22 AM

#

I am also in bed so will have to do it tomorrow

queen yew Dec 4, 2023, 5:24 AM

#

stray tree odd that it's not using `PathTooLongException` for that

From doing a bit of googling, it may be something to do with .net framework/mono

#

on newer .net the path automatically gets converted by the framework into the long path format

#

so you never run into the issue in the first place

thick oyster Dec 4, 2023, 5:26 AM

#

wide ginkgo send the notes.mid if you could for testing purposes

here's one of the ones I know off the top of my head doesn't wanna work

📎 3_-_Ziltoidia_Attaxx.zip

wide ginkgo Dec 4, 2023, 5:33 AM

#

ah yep

#

@stray tree remember that one midi file that you analyzed and found that the midi tracks had duplicate trackname events?

#

It did it again

#

The midi file in question is out of spec

#

so it makes sense why that song fails

#

HUH

#

Note: TEMPO_TRACK is present in all the instrument track chunks. Every one of them

stray tree Dec 4, 2023, 5:38 AM

#

okay what the heck lol

#

how have i not encountered this in my own 10k library

#

and what program exported these

#

that's what i wanna know

#

so i guess we'll have to be lenient with the track names

thick oyster Dec 4, 2023, 5:40 AM

#

It's ripped from rock band as far as I know

#

One of my friends sent me the charts to show me the album

stray tree Dec 4, 2023, 5:40 AM

#

these must be old rips or something

#

they're very much not what the original game has

thick oyster Dec 4, 2023, 5:41 AM

#

It's RB2 DLC afaik

stray tree Dec 4, 2023, 5:42 AM

#

not seeing these songs there

thick oyster Dec 4, 2023, 5:44 AM

#

I'm not sure where they got the charts nor how long they've had 'em for

stray tree Dec 4, 2023, 5:45 AM

#

either way, i presume these songs work in CH?

thick oyster Dec 4, 2023, 5:45 AM

#

Yep

stray tree Dec 4, 2023, 5:46 AM

#

not entirely sure why they would unless they modified the Moonscraper parsing to not use just the first event as the track name, but maybe they did

wide ginkgo Dec 4, 2023, 5:46 AM

#

Reminder that the old YARG scanner didn’t either.

#

It looped through every single midi event to check for the trackname event type

#

Though it also, as a separate consequence, had no means of accurately checking available difficulties.

But it would explain why the chart worked on stable vs nightly

#

But yea, weird. Moonscraper indeed also only checks the first event.

stray tree Dec 4, 2023, 5:53 AM

#

lol dnSpy is not having a fun time with the strings in the CH assembly

#

idk why i'm going to this length just to find out for sure

#

alright yeah, CH does check all events in the file for the track name

#Some charts won't load into the game